test: a plugin section saved through /config/main needs no restart

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

CHANGELOG.md

@@ -488,23 +488,34 @@ policies are unchanged.
 
 ### Fixes
 
-- A cache key too long to be a filename is now cached. The calendar
-  plugin's key joins every calendar id the user picked; on a real install
-  it passed 300 bytes, ext4 refuses names over 255, and every write failed
-  with `File name too long` — logged as "(permission denied)", so it read
-  like a cache-directory ownership problem. `DiskCache.get_cache_path` now
-  keeps a key of up to 200 UTF-8 bytes as its filename, as before, and
-  turns a longer one into its first bytes plus a hash of the whole key. The
-  web UI's cache list and delete keep working, because the shortened name
-  maps back to the same file. A failed write now names the real error.
-- The cache's memory tier no longer serves data older than the reader asked
-  for. A record loaded from disk was timed in memory from the load, not
-  from when it was written, so `get(key, max_age=300)` could return data
-  close to 600 s old (after a restart, after the hourly memory sweep, or in
-  the other process, which only ever loads the record from disk), and a
-  stored `ttl` was stretched the same way. A memory hit is now also checked against
-  the record's own timestamp, and a stale one falls through to disk, which
-  returns a newer write if there is one.
+- `POST /api/v3/config/schedule` and `/config/dim-schedule` accept a
+  disabled per-day schedule with every day off. That is the shape
+  `config.template.json` ships, so posting back what GET returned on a fresh
+  install answered 400 "At least one day must be enabled". An enabled per-day
+  schedule still needs a day on. A day that is off now keeps the times it
+  was posted with (the schedule picker sends them). Before, saving dropped
+  them, so turning the day back on showed the defaults.
+- `POST /api/v3/config/main` answers `restart_required: true` only when the
+  save changed a setting the running display does not apply by itself.
+  Brightness (`brightness.set` and the config watcher), the per-mode
+  durations and plugin sections are applied live. A brightness-only save,
+  such as the MQTT bridge's slider, or a save that changed nothing, no longer
+  shows the restart banner. Hardware, rotation order, timezone and every
+  other setting still ask for the restart.
+- `GET /api/v3/health` reports `degraded` when the display service is
+  stopped. Before, only the sub-checks changed, and the overall status stayed
+  `healthy` for as long as the last preview frame was under 60 s old.
+  `checks.display_loop.status` is now `stopped` when three things agree:
+  systemd says the service is not active, the control socket does not
+  answer, and there is no live heartbeat. Where the platform has no socket
+  (Windows) or it is switched off, nothing changes.
+- `GET /api/v3/display/current-status` no longer reports the stopped
+  display's last state (`is_display_active: true`) from the cache for up to
+  120 s. When the control socket does not answer and the render loop's
+  heartbeat is absent, stale, or from a process that is gone (#726's rules),
+  the answer is unknown, with every field `null`. A display that still beats
+  without a socket, Windows and a socket switched off read the cache as
+  before. New `web_interface.display_state.display_gone()`.
 - The garbage-collection timer (`GcMonitor`, above) no longer prints
   `Exception ignored while calling GC callback ... 'NoneType' object has no
   attribute 'perf_counter'` when the display service or a test run exits.
@@ -515,16 +526,6 @@ policies are unchanged.
   `DisplayManager.cleanup()` (reached from SIGTERM through `run()`'s
   `finally`) unregisters it with the frame recorder. New
   `frame_timing.uninstall_gc_monitor()`.
-- The web interface's state subscription (`StateSubscription`,
-  `src/ipc/client.py`) resubscribes about 1 s after a display restart, every
-  time. Its reconnect wait went back to the minimum only when the
-  subscription was stopped. A disconnect after a working connection kept
-  doubling the wait, so successive display restarts were followed by waits
-  of 1, 2, 4, 8, 16 and then 30 s for good.
-  During each wait the web answered from one-shot `state.get` connections
-  instead of its copy. The wait now resets once a connection has stored a
-  snapshot. A display that does not offer the stream is still retried
-  slowly.
 - A plugin reload after a store update (`plugin.reload`, #720) no longer
   freezes the panel during Vegas. On ledpi a football reload froze it for
   3.0 s (`Render stall over: no frame for 3043ms`). The reload ran on the
@@ -541,25 +542,6 @@ policies are unchanged.
   for the plugin is refused (`plugin-reloading`), and a config reconcile
   neither loads it twice nor unloads it mid-load. A Vegas fetch that waited
   out a reload for the lock skips the old instance.
-- A plugin display duration that is not a number no longer stops the
-  display. Several plugins (clock-simple, calendar, countdown) return their
-  `display_duration` setting as it is in config.json, so a value saved as
-  `"20"` or `null` (the raw config editor, a hand edit) reached the run loop
-  as a string or None. Comparing it with 0 raised a TypeError that no
-  handler in the loop caught: the display service exited when that plugin's
-  screen came up, and systemd restarted it into the same crash. The
-  controller now reads the plugin's answer as a number: a numeric string
-  counts, and anything else (or a `get_display_duration()` that raises)
-  shows the mode for 30 s, with one warning per plugin.
-- A scroll strip narrower than the panel scrolls instead of raising on every
-  frame. When a frame ran off the end of the strip, `ScrollHelper` copied
-  the strip's tail and then the rest of the frame from its head, which
-  assumed the head was that wide; for a narrower strip that raised
-  `ValueError: could not broadcast` at every position, so nothing was drawn
-  and each frame logged a traceback. Vegas builds such a strip, with no
-  lead-in, when its content is narrower than the chain. A frame that runs
-  off the strip now continues from its head column by column, so a narrow
-  strip repeats across the panel; a wide strip wraps exactly as before.
 - The schedule-off blank and the WiFi notice no longer start with a
   scroller's leftovers. Both are drawn by the display controller rather than
   dispatched to a plugin, so #716's handover never reached them: drawn while
@@ -569,46 +551,6 @@ policies are unchanged.
   scroller or Vegas) were counted as 0.5-1 s freezes and logged as a
   `Render stall ... mid-scroll`. The controller now ends the scroll state
   before drawing either.
-- A plugin that keeps helpers in a package (elections' `providers/`,
-  flights' `enrichment/`, olympics' `data/` and `renderers/`) now runs its
-  updated helpers after a reload. Unloading dropped the package itself but
-  left its modules (`providers.feed`) in `sys.modules`, so the reload after a
-  store update imported the new `manager.py` and got the old helpers back from
-  the cache until the display restarted. `PluginLoader` now drops a plugin's
-  package modules when it unloads, and when a load fails part-way.
-- Uninstalling a dev plugin that `scripts/dev/dev_plugin_setup.sh` linked
-  into the plugins directory now removes the link and leaves the checkout
-  alone. The store's removal passed the link to `shutil.rmtree`, which
-  refuses a symlink; its fallback then walked through the link and chmodded
-  every directory and file of the linked checkout to 0700, and the sudo stage
-  refused a path outside the plugins directory, so the uninstall failed with
-  the link still in place. The same removal discards the set-aside copy after
-  an install or update. A symlink, dangling or not, is now unlinked.
-- A dev plugin linked in under a name its checkout does not share now loads.
-  `dev_plugin_setup.sh link-github foo <url>` clones `ledmatrix-foo` (the
-  repository naming convention) and links it as `plugins/foo`. The loader's
-  containment check for dependency installs resolved the link and looked for
-  `ledmatrix-foo` among the plugins directory's entries, found none, and
-  refused the plugin, so the load failed with "Dependency installation
-  failed" even when it had no `requirements.txt`. The check now looks for the
-  entry the path itself names in the plugins directory, the link, and still
-  only ever answers with an entry it found there.
-- A plugin whose `update()` raises `asyncio.CancelledError` or `SystemExit`
-  no longer goes dark until a restart. Both derive from `BaseException`, not
-  `Exception`, and the update worker's bookkeeping caught only `Exception`:
-  the plugin kept its lock and stayed RUNNING, so it was never updated again
-  and every `display()` was skipped as busy. It is now recorded as that
-  update's failure, the same as any other raise. The plugin executor
-  reported such a call as a timeout; it now reports it as a failure.
-- Saving a config change no longer freezes the panel while a plugin is busy.
-  `ConfigService` told its subscribers about a change while holding its lock,
-  and the display's per-plugin subscriber waits up to 5 s for a plugin in the
-  middle of an update. A save that enables or disables a plugin also queues a
-  reconcile, which the render thread runs, and its `get_config()` and
-  `unsubscribe()` waited behind every one of those callbacks. Subscribers now
-  run after the lock is released. One reload's notifications still finish
-  before the next one's start, and a callback `unsubscribe()` removed is not
-  running, and will not run, once it returns.
 - A plugin whose `display()` raises now opens its circuit breaker. The first
   frame of each screen goes through the plugin executor, which caught the
   exception and returned False. The display read that as "no content" and
@@ -646,48 +588,6 @@ policies are unchanged.
   being stopped, blanks the panel within about a second. It used to stay on
   until the next minute, because the once-a-minute schedule check had
   already run that minute and the session had overridden its answer.
-- Check & Update All updates what is installed now. A second run in the
-  same page sent the plugins the first run had seen, so a plugin uninstalled
-  since then failed with "plugin not found" and one installed since was
-  skipped. After a run the installed cards and the Updates badge show the
-  new versions; they kept offering "Update to vX" for what had just been
-  updated until the page was reloaded.
-- The Run On-Demand dialog lists a plugin's display modes, so a mode other
-  than the first can be started, and pinned. `/api/v3/plugins/installed`
-  never sent `display_modes`, which the dialog reads, so every plugin
-  offered only its own id under "This plugin exposes a single display
-  mode", and the display started its first mode. Each entry now carries
-  `display_modes`, the modes its manifest declares.
-- Installing Weather, Music, Stocks or Leaderboard from the Plugin Store
-  enables it, as installing any other plugin does. Each installs under the
-  id its manifest declares (`ledmatrix-weather` for the store's `weather`),
-  but the store enabled the store id, which `/api/v3/plugins/toggle`
-  answered with "Plugin not found": the plugin stayed disabled behind
-  "installed, but enabling it failed". `POST /api/v3/plugins/install` now
-  answers with the installed `plugin_id` (in the operation's result when it
-  is queued), and the store enables that.
-- Reinstalling a plugin from the Plugin Store leaves it enabled or disabled
-  as it was. Reinstall enabled it as a fresh install does, so a plugin the
-  user had switched off came back on.
-- A Plugin Store install that takes more than a minute is no longer
-  reported as failed. The store stopped waiting after 60 s and showed
-  "Install operation timed out" while the server, which allows the
-  plugin's dependency install 300 s on its own, carried on and usually
-  succeeded; the plugin was then neither enabled nor listed until the page
-  was reloaded. The store now waits up to 10 minutes, and if it still has
-  no answer it reloads the installed list and says the install may still
-  be running.
-- The Plugin Store's category filter lists every category its plugins
-  have. It offered a fixed seven while the registry uses about twenty, so
-  plugins filed under productivity, utility, transit and the rest could not
-  be filtered to, and "Financial" missed the plugin filed under "finance".
-  The choices are now built from the store's plugins, as the Starlark
-  section's are.
-- The Install button under Install Single Plugin (Plugin Manager > Install
-  from GitHub) runs one handler per click. It also had an inline `onclick`
-  whose handler threw a `ReferenceError` on every click; only the other
-  handler's request went out, and making the inline one work would have
-  sent every install twice. The inline handler is gone.
 - `/api/v3/plugins/installed` no longer reports the display's plugins as
   `live` while `/api/v3/health` says `display_loop: stalled`. The runtime
   snapshot is written from its own thread, which kept going while the render
@@ -699,17 +599,6 @@ policies are unchanged.
   heartbeat when the service stops), is `stale` at once instead of `live`
   for up to 180 s. No new files or writes: both checks are on the reading
   side.
-- A scoreboard's scroll and Vegas cards with `scroll_card.date_format:
-  "weekday"` now show the printed date's own weekday. A Friday 8 PM ET game
-  read "Sat Oct 2". The card took the weekday in the plugin's own
-  `timezone` setting, which ships blank, so it fell back to UTC, while the
-  "Oct 2" beside it came from the zone the plugin actually resolves (its
-  setting, then the global one, then the system zone). Every zone is within a
-  day of UTC, so the card now finds which day near the start's UTC date has
-  the printed month and day and names that one. Games east of UTC (Auckland,
-  Kiritimati) were off by a day the other way and are fixed the same way.
-  The switch-mode scorebug, which already used the plugin's resolved zone,
-  shares the same formatter and draws what it drew before.
 - `/api/v3/display/current-status` reflects a wake from scheduled-off, a
   schedule-off blank, or an on-demand session starting or ending at once,
   even when the mode name stays the same. The display republished its

docs/REST_API_REFERENCE.md

@@ -159,14 +159,16 @@ there an unchecked checkbox — which the browser omits — is saved as
 }
 ```
 
-`restart_required` is always true here: display hardware, rotation,
-durations and general settings take effect when the display restarts, and
-the web UI shows its restart banner on the flag. (Plugin sections saved
-through this route reach the running plugin live, like
-`POST /plugins/config`.)
+`restart_required` is true when the save changed a setting that takes
+effect when the display restarts: display hardware, rotation order,
+timezone, general settings and the rest. The web UI shows its restart banner
+on the flag. It is false when the save changed only what the running display
+applies by itself, or nothing: `brightness`, the per-mode durations
+(`duration__<mode>`, `display.display_durations`) and plugin sections, which
+reach the running plugin live, like `POST /plugins/config`.
 
-A saved `brightness` is the exception: it reaches the panel without a
-restart. The route also sends it to the running display over the control
+A saved `brightness` reaches the panel without a restart. The route also
+sends it to the running display over the control
 socket (`brightness.set`), which puts it on the panel at once, and the
 response adds `"brightness_transport": "socket"`. Otherwise it is
 `"config"`, with `brightness_socket_error` giving the reason, and the
@@ -246,7 +248,10 @@ Replace the schedule configuration.
 ```
 
 A day whose `<day>_enabled` key is absent counts as enabled, with default
-times `07:00`-`23:00`. At least one day must be enabled.
+times `07:00`-`23:00`. An enabled schedule needs at least one day enabled; a
+disabled one (`"enabled": false`) may have every day off, as
+`config.template.json` ships it. A day that is off keeps the times sent for
+it, when they are valid `HH:MM`.
 
 **Response**:
 ```json
@@ -343,7 +348,11 @@ control socket ([IPC_CONTROL_SOCKET.md](IPC_CONTROL_SOCKET.md)), and `cache`
 when it came from the `display_current_state` cache key (no socket: the
 display is stopped or older, or this is Windows). A display whose render
 loop has not refreshed its state for 120 seconds is reported with every
-field `null`, either way.
+field `null`, either way. So is a stopped display: when the socket does not
+answer and the render loop's heartbeat
+(`/run/ledmatrix/display-heartbeat.json`) is absent, stale or from a process
+that is gone, the cache's last entry is not used. A display still beating
+without a socket, Windows, or a socket switched off reads the cache.
 
 ### List Display Modes
 
@@ -2281,7 +2290,11 @@ display snapshot. `data.status` is `healthy` or `degraded`, with
 (with `heartbeat_age_seconds`), `stalled` (no heartbeat for 60s: the panel is
 frozen even if the service is active; the status turns `degraded`), or
 `not_reported` when the display writes none (not started yet, the dev server,
-Windows), which does not affect the status. Its `source` is `socket` when the
+Windows), which does not affect the status, or `stopped` (with `source:
+"service"`) when the display service is not active, the control socket does
+not answer and there is no live heartbeat; the status then turns
+`degraded`. A platform with no control socket (Windows) or a socket switched
+off never reports `stopped`. Its `source` is `socket` when the
 age came from the display's state stream over the control socket (measured
 in memory by the display) and `heartbeat_file` when it came from
 `/run/ledmatrix/display-heartbeat.json`.
@@ -2344,8 +2357,9 @@ Replace the dim schedule. `dim_brightness` is 0-100 (default 30). In
 `per-day` mode the days can be sent either as the `days` object that GET
 returns, or as the web form's flat fields (`monday_enabled`,
 `monday_start`, `monday_end`, ...). A day that is not sent counts as
-enabled with default times `20:00`-`07:00`; at least one day must be
-enabled.
+enabled with default times `20:00`-`07:00`. As for the schedule above, an
+enabled dim schedule needs at least one day enabled and a disabled one may
+have every day off.
 
 ---
 

src/background_data_service.py

@@ -34,7 +34,6 @@ from src.common.fetch_service import (
     plugin_scope,
     share_connection_pool,
 )
-from src.common.espn_payload import is_espn_scoreboard_url, slim_scoreboard_payload
 from src.common.espn_dates import (
     RANGE_RETRY_SECONDS,
     _note_range_rejected,
@@ -84,10 +83,6 @@ class FetchRequest:
     # the cache with the callbacks suppressed -- joiners waiting forever for a
     # fetch that did, in fact, succeed.
     commit_claimed: bool = False
-    # Trim an ESPN scoreboard response before it is cached and delivered
-    # (src/common/espn_payload.py). Set by whoever created the request; a
-    # submitter that joins the fetch gets the same payload.
-    slim_payload: bool = True
     result: Optional[Any] = None
     error: Optional[str] = None
     # The plugin that submitted the request, so the fetch service counts the
@@ -254,8 +249,7 @@ class BackgroundDataService:
                            timeout: Optional[int] = None,
                            max_retries: int = 3,
                            priority: int = 1,
-                           callback: Optional[Callable] = None,
-                           slim_payload: bool = True) -> str:
+                           callback: Optional[Callable] = None) -> str:
         """
         Submit a background fetch request.
         
@@ -271,11 +265,6 @@ class BackgroundDataService:
             priority: Accepted for compatibility and ignored; requests run in
                 submission order.
             callback: Optional callback function when request completes
-            slim_payload: Drop the parts of an ESPN scoreboard response no
-                scoreboard reads (stat leaders, athlete cards, links,
-                headlines, highlights) before caching it; see
-                src/common/espn_payload.py. Only ESPN /scoreboard URLs are
-                touched. Pass False to cache the response whole.
             
         Returns:
             Request ID for tracking the fetch operation
@@ -347,7 +336,6 @@ class BackgroundDataService:
             priority=priority,
             callback=callback,
             owner=owner,
-            slim_payload=slim_payload,
         )
         
         with self._lock:
@@ -509,13 +497,6 @@ class BackgroundDataService:
                 )
                 return result
 
-            # Most of an ESPN scoreboard response is never drawn, and the
-            # cached copy stays parsed in the memory tier while it is fresh.
-            # Trimmed before the write so the cache, request.result and the
-            # callbacks all see the same payload. See src/common/espn_payload.py.
-            if request.slim_payload and is_espn_scoreboard_url(request.url):
-                slim_scoreboard_payload(data)
-
             # Cache the data
             self.cache_manager.set(request.cache_key, data)
             

src/cache/disk_cache.py

@@ -4,7 +4,6 @@ Disk Cache
 Handles persistent disk-based caching with atomic writes and error recovery.
 """
 
-import hashlib
 import json
 import math
 import os
@@ -32,35 +31,6 @@ except ImportError:  # pragma: no cover - exercised on hosts without the wheel
 # useful, and a half-written file was never useful.
 _ORPHAN_TEMP_MAX_AGE_SECONDS = 3600
 
-# Longest key, in UTF-8 bytes, used verbatim as a filename stem. ext4 caps a
-# name at 255 bytes and set()'s temp file is ".<stem>.json.<8 random>", 15
-# bytes longer than the stem, so anything near the cap could never be written:
-# the calendar plugin's key joins every calendar id and passed 300 bytes on a
-# real install, failing every write with ENAMETOOLONG. Longer keys keep this
-# many bytes as a readable prefix and end in a hash of the whole key.
-_MAX_KEY_FILENAME_BYTES = 200
-_KEY_HASH_CHARS = 16
-
-
-def _filename_stem(key: str) -> str:
-    """The filename stem for a key that is already a safe path component.
-
-    Short keys are used as they are, so every file already on disk keeps its
-    name. A long one becomes its first bytes plus a hash of the full key: the
-    prefix keeps the stem recognisable (and keeps the data-type words that
-    cleanup's retention lookup reads from it), the hash keeps two keys that
-    share a long prefix apart. The result is itself short, so a stem read back
-    from a filename -- which is how the web UI names a key it deletes -- maps to
-    the same file.
-    """
-    encoded = key.encode('utf-8')
-    if len(encoded) <= _MAX_KEY_FILENAME_BYTES:
-        return key
-    digest = hashlib.sha256(encoded).hexdigest()[:_KEY_HASH_CHARS]
-    keep = _MAX_KEY_FILENAME_BYTES - _KEY_HASH_CHARS - 1
-    prefix = encoded[:keep].decode('utf-8', errors='ignore')
-    return f"{prefix}-{digest}"
-
 
 
 class CacheStrategyProtocol(Protocol):
@@ -373,8 +343,6 @@ class DiskCache:
         derives them), so rejecting anything with a path component turns
         away only inputs that could never have been written here.
 
-        A key too long to be a filename is shortened by _filename_stem.
-
         Args:
             key: Cache key
 
@@ -388,7 +356,7 @@ class DiskCache:
         if safe_key is None:
             self.logger.warning("Rejected unsafe cache key %r", key)
             return None
-        return os.path.join(self.cache_dir, f"{_filename_stem(safe_key)}.json")
+        return os.path.join(self.cache_dir, f"{safe_key}.json")
     
     def get(self, key: str, max_age: Optional[int] = 300) -> Optional[Dict[str, Any]]:
         """
@@ -593,7 +561,7 @@ class DiskCache:
                             # If direct write also fails, try fallback location
                             self.logger.warning("Direct write failed for key '%s' to %s: %s", key, cache_path, write_error)
                             raise  # Re-raise to trigger fallback logic
-                except (IOError, OSError, PermissionError) as primary_error:
+                except (IOError, OSError, PermissionError):
                     # Attempt one-time fallback write to user's home cache directory
                     try:
                         # Try user's home cache directory as fallback
@@ -619,14 +587,11 @@ class DiskCache:
                         self.logger.debug("Fallback cache write also failed for key '%s': %s", key, e2)
                     
                     # If all write attempts failed, log warning but don't raise exception
-                    # Cache is a performance optimization, not critical for operation.
-                    # Name the real error: this used to say "permission denied"
-                    # whatever happened, which sent a too-long filename off to
-                    # be debugged as a directory-ownership problem.
+                    # Cache is a performance optimization, not critical for operation
                     self.logger.warning(
-                        "Could not write cache for key '%s' to %s (%s). "
+                        "Could not write cache for key '%s' to %s (permission denied). "
                         "Cache will be unavailable for this key, but application will continue.",
-                        key, cache_path, primary_error.strerror or primary_error
+                        key, cache_path
                     )
                     return  # Exit gracefully without raising exception
         

src/cache_manager.py

@@ -46,32 +46,6 @@ from src.cache.disk_cache import DateTimeEncoder  # noqa: F401 - deliberate re-e
 # CacheManager.config_manager not built yet (None means "not available").
 _UNSET: Any = object()
 
-
-def _outlived(record: Any, max_age: Optional[float], now: float) -> bool:
-    """Whether a record's own timestamp puts it past max_age.
-
-    The memory tier times an entry from when it was put there, and a record
-    loaded from disk is put there when it is read, not when it was written: a
-    record 290 s old, read after a restart, could be served for another
-    max_age from memory. This is the age check DiskCache.get makes, with the
-    same rule that a stored ttl wins over the caller's max_age. A record that
-    carries no timestamp is left to the memory tier's own clock.
-    """
-    if not isinstance(record, dict):
-        return False
-    stored_ttl = record.get('ttl')
-    if isinstance(stored_ttl, (int, float)) and not isinstance(stored_ttl, bool) \
-            and stored_ttl >= 0:
-        max_age = stored_ttl
-    stamp = record.get('timestamp')
-    if max_age is None or stamp is None or isinstance(stamp, bool):
-        return False
-    try:
-        return now - float(stamp) > max_age
-    except (TypeError, ValueError):
-        return False
-
-
 class CacheManager:
     """Manages caching of API responses to reduce API calls."""
 
@@ -310,11 +284,7 @@ class CacheManager:
         # 1) Memory cache
         cached = self._memory_cache_component.get(key, max_age=in_memory_ttl)
         if cached is not None:
-            if not _outlived(cached, max_age, time.time()):
-                return cached
-            # Too old for this reader. Disk may hold a newer write (from the
-            # other process), and if it does not, the miss is the right answer.
-            self._memory_cache_component.clear(key)
+            return cached
 
         # 2) Disk cache
         record = self._disk_cache_component.get(key, max_age=max_age)
@@ -348,9 +318,7 @@ class CacheManager:
         # Check memory cache first (1 minute TTL)
         cached = self._memory_cache_component.get(key, max_age=60)
         if cached is not None:
-            if not _outlived(cached, 3600, time.time()):
-                return cached
-            self._memory_cache_component.clear(key)
+            return cached
         
         # Check disk cache
         data = self._disk_cache_component.get(key, max_age=3600)  # 1 hour for load_cache

src/common/espn_payload.py

@@ -1,97 +0,0 @@
-"""Drop the parts of an ESPN scoreboard payload no scoreboard reads.
-
-The sports scoreboards cache their Recent/Upcoming window (14 days back, 7
-ahead) as the raw ESPN response, and that record stays parsed in the memory
-cache for as long as it is fresh. Most of it is never drawn. Measured on hdpi
-(2026-10-02) the MLB window was 3.35MB of JSON and 13.5MB of Python objects,
-and the five windows together ~40MB, mostly in:
-
-* ``competitors[].leaders`` / ``competitions[].leaders`` -- per-team and
-  per-game stat leaders (28% of the MLB window)
-* ``competitors[].team.links`` / ``event.links`` -- web and app URLs
-* ``status.featuredAthletes`` and ``competitors[].probables`` -- athlete
-  cards with headshots and season stats
-* ``competitions[].headlines`` / ``highlights`` -- article and video blurbs
-  (28% of the college-football window)
-* ``competitions[].geoBroadcasts``
-
-None of those keys is read by core or by any plugin in ledmatrix-plugins
-(checked 2026-10-02 across every scoreboard, the odds ticker and the
-leaderboard), while everything that is read -- odds, records, linescores,
-situation, statistics, notes, broadcasts, venue -- is kept. Dropping them
-takes the five windows from ~40MB to ~12MB of parsed objects and the files from
-10.6MB to 3.0MB, so the reads that parse an expired window on the render
-thread get 3-4x cheaper too.
-
-:func:`slim_scoreboard_payload` changes the payload in place, and only ever
-removes the keys listed here: anything it does not know about is left alone.
-"""
-
-from typing import Any, Dict
-from urllib.parse import urlsplit
-
-# Per level of the payload, the keys removed. Kept deliberately explicit:
-# adding a key here means checking that nothing reads it first.
-_EVENT_DROP = ("links",)
-_COMPETITION_DROP = ("leaders", "headlines", "highlights", "geoBroadcasts")
-_STATUS_DROP = ("featuredAthletes",)
-_COMPETITOR_DROP = ("leaders", "probables")
-_TEAM_DROP = ("links",)
-
-
-def is_espn_scoreboard_url(url: Any) -> bool:
-    """Whether ``url`` is an ESPN site-API scoreboard endpoint."""
-    if not isinstance(url, str):
-        return False
-    try:
-        parts = urlsplit(url)
-    except ValueError:
-        return False
-    host = (parts.hostname or "").lower()
-    if host != "espn.com" and not host.endswith(".espn.com"):
-        return False
-    return parts.path.rstrip("/").endswith("/scoreboard")
-
-
-def _drop(obj: Any, keys) -> None:
-    if isinstance(obj, dict):
-        for key in keys:
-            obj.pop(key, None)
-
-
-def slim_scoreboard_payload(payload: Any) -> Any:
-    """Remove the unread parts of an ESPN scoreboard payload, in place.
-
-    Returns ``payload`` for convenience. Anything that is not shaped like a
-    scoreboard (not a dict, no ``events`` list, odd entries) is passed over
-    untouched rather than raising.
-    """
-    if not isinstance(payload, dict):
-        return payload
-    events = payload.get("events")
-    if not isinstance(events, list):
-        return payload
-    for event in events:
-        if not isinstance(event, dict):
-            continue
-        _drop(event, _EVENT_DROP)
-        competitions = event.get("competitions")
-        if not isinstance(competitions, list):
-            continue
-        for competition in competitions:
-            if not isinstance(competition, dict):
-                continue
-            _drop(competition, _COMPETITION_DROP)
-            _drop(competition.get("status"), _STATUS_DROP)
-            competitors = competition.get("competitors")
-            if not isinstance(competitors, list):
-                continue
-            for competitor in competitors:
-                if not isinstance(competitor, dict):
-                    continue
-                _drop(competitor, _COMPETITOR_DROP)
-                _drop(competitor.get("team"), _TEAM_DROP)
-    return payload
-
-
-__all__ = ["is_espn_scoreboard_url", "slim_scoreboard_payload"]

src/common/scroll_helper.py

@@ -561,7 +561,7 @@ class ScrollHelper:
         width = self.display_width
         strip_width = self.cached_array.shape[1]
 
-        if 0 <= start_x and start_x + width + 1 <= strip_width:
+        if start_x + width + 1 <= strip_width:
             # Slice the backing array directly. Going via
             # _get_visible_portion_integer would build two PIL images only for
             # them to be converted straight back to arrays, which measured 15x
@@ -569,10 +569,9 @@ class ScrollHelper:
             near = self.cached_array[:, start_x:start_x + width]
             far = self.cached_array[:, start_x + 1:start_x + 1 + width]
         else:
-            # One of the slices wraps (close to the end, or a strip narrower
-            # than the panel); let the integer path handle that and pay the
-            # conversion. Continuous mode extends the strip before reaching
-            # here, so this is the rare case.
+            # Close enough to the end that one of the slices wraps; let the
+            # integer path handle that and pay the conversion. Continuous mode
+            # extends the strip before reaching here, so this is the rare case.
             near = np.asarray(
                 self._get_visible_portion_integer(start_x, start_x + width))
             far = np.asarray(
@@ -602,33 +601,34 @@ class ScrollHelper:
         _size = (self.display_width, self.display_height)
         img_w = self.cached_array.shape[1]
 
-        if 0 <= start_x and end_x <= img_w:
+        if end_x <= img_w:
             # Normal case: single contiguous slice (fastest path). tobytes()
             # on the column-slice view already returns C-order bytes, so
             # ascontiguousarray() first only added a second full-frame copy.
             return Image.frombytes(
                 'RGB', _size,
                 self.cached_array[:, start_x:end_x].tobytes())
-
-        # Ensure frame buffer is allocated for all non-simple paths
-        if self._frame_buffer is None or self._frame_buffer.shape != (self.display_height, self.display_width, 3):
-            self._frame_buffer = np.zeros((self.display_height, self.display_width, 3), dtype=np.uint8)
-
-        if img_w == 0:
-            self._frame_buffer[:] = 0
         else:
-            # The frame runs off the strip, so it carries on from the head:
-            # frame column j is strip column (start_x + j) modulo the strip's
-            # width -- the tail and then the head, and a strip narrower than
-            # the panel repeated across it. Copying the tail and then the rest
-            # of the frame from the head assumed the head was that wide, and
-            # raised at every position for a strip narrower than the panel
-            # (Vegas composes one, with no lead-in, when its content is
-            # narrower than the chain).
-            np.take(self.cached_array, np.arange(start_x, end_x), axis=1,
-                    mode='wrap', out=self._frame_buffer)
+            # Ensure frame buffer is allocated for all non-simple paths
+            if self._frame_buffer is None or self._frame_buffer.shape != (self.display_height, self.display_width, 3):
+                self._frame_buffer = np.zeros((self.display_height, self.display_width, 3), dtype=np.uint8)
 
-        return Image.frombytes('RGB', _size, self._frame_buffer.tobytes())
+            width1 = img_w - start_x
+            if width1 > 0:
+                # Wrap-around: tail of image + head of image
+                self._frame_buffer[:, :width1] = self.cached_array[:, start_x:]
+                remaining_width = self.display_width - width1
+                self._frame_buffer[:, width1:] = self.cached_array[:, :remaining_width]
+            else:
+                # Edge case: start_x at or past image end — show from beginning,
+                # clamped to available width (scroll_position should wrap before
+                # reaching this state in normal operation).
+                available = min(self.display_width, img_w)
+                self._frame_buffer[:, :available] = self.cached_array[:, :available]
+                if available < self.display_width:
+                    self._frame_buffer[:, available:] = 0
+
+            return Image.frombytes('RGB', _size, self._frame_buffer.tobytes())
     
     def calculate_dynamic_duration(self) -> int:
         """

src/common/sports_card.py

@@ -18,7 +18,7 @@ the extra guard only stops a None size raising TypeError.
 """
 
 import logging
-from datetime import datetime, timedelta, timezone
+from datetime import datetime, timezone
 from typing import Any, Dict, Optional, Tuple
 from zoneinfo import ZoneInfo
 
@@ -338,46 +338,10 @@ def format_game_date(config: Optional[Dict[str, Any]], logger, date_text: str,
     if not raw:
         return ""
     fmt = str(scroll_card_option(config, "date_format", "abbrev") or "abbrev")
-    return _format_date_as(fmt, raw, lambda: weekday_for(config, logger, game),
-                           game=game)
+    return _format_date_as(fmt, raw, lambda: weekday_for(config, logger, game))
 
 
-def _printed_weekday(game: Optional[Dict], month: int, day: int) -> str:
-    """The weekday of the date a card prints as month/day, or '' if unknown.
-
-    The extractor prints "M/D" in the plugin's resolved zone (its own setting,
-    else the global one, else the system zone). The card cannot see that zone:
-    it is handed the plugin's config, whose ``timezone`` ships as "", so
-    card_tzinfo answers UTC and an evening kickoff in the Americas got the
-    next day's weekday ("Sat Oct 2" for a Friday game). Every zone is within
-    a day of UTC, so the printed date is the start's UTC date or a neighbour
-    of it; the one with that month and day is the date on the card.
-    """
-    if not isinstance(game, dict):
-        return ""
-    raw = game.get("start_time_utc") or game.get("start_time")
-    if not raw:
-        return ""
-    try:
-        start = raw if isinstance(raw, datetime) else datetime.fromisoformat(
-            str(raw).replace("Z", "+00:00"))
-        if start.utcoffset() is None:
-            return ""  # naive: no instant to place the date against
-        utc_day = start.astimezone(timezone.utc).date()
-    except (ValueError, TypeError, OverflowError):
-        return ""
-    for offset in (0, -1, 1):
-        try:
-            candidate = utc_day + timedelta(days=offset)
-        except OverflowError:
-            continue
-        if (candidate.month, candidate.day) == (month, day):
-            return WEEKDAY_ABBR[candidate.weekday()]
-    return ""
-
-
-def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR,
-                    game: Optional[Dict] = None) -> str:
+def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR) -> str:
     """Render a stripped, non-empty "M/D" *raw* in style *fmt*.
 
     The body both date formatters share. They differ in which setting names the
@@ -385,9 +349,6 @@ def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR,
     ``SportsCoreSharedMixin._format_game_date``), so those arrive as arguments:
     *weekday* is a zero-argument callable, only called for the "weekday" style.
     *months* lets the mixin keep reading its (overridable) ``_MONTH_ABBR``.
-    With *game*, the "weekday" style names the printed date's own weekday
-    (:func:`_printed_weekday`), and *weekday* is only the fallback for a
-    date its start time cannot place.
     """
     if fmt == "numeric":
         return raw
@@ -403,7 +364,7 @@ def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR,
     if fmt == "day_first":
         return f"{day} {name}"
     if fmt == "weekday":
-        day_name = _printed_weekday(game, month, day) or weekday()
+        day_name = weekday()
         return f"{day_name} {name} {day}" if day_name else f"{name} {day}"
     return f"{name} {day}"
 

src/common/sports_shared.py

@@ -360,16 +360,14 @@ class SportsCoreSharedMixin:
         The formatting is sports_card's. What differs from the card's
         ``format_game_date`` is passed in: the setting (``switch_date_format``,
         see :meth:`_switch_date_format`) and the weekday, which comes from
-        :meth:`_weekday_for` and so from this plugin's resolved timezone
-        when the game's start cannot place the printed date. The game goes
-        in too, so both formatters name the printed date's own weekday.
+        :meth:`_weekday_for` and so from this plugin's resolved timezone.
         """
         raw = str(date_text or "").strip()
         if not raw:
             return raw
         return _card._format_date_as(self._switch_date_format(), raw,
                                      lambda: self._weekday_for(game),
-                                     self._MONTH_ABBR, game=game)
+                                     self._MONTH_ABBR)
 
     def _weekday_for(self, game: Optional[Dict]) -> str:
         """Weekday abbreviation from the game's start time, or ''."""

src/config_service.py

@@ -14,7 +14,7 @@ import json
 import time
 import threading
 from pathlib import Path
-from typing import Dict, Any, Optional, List, Callable, Tuple
+from typing import Dict, Any, Optional, List, Callable
 from collections import defaultdict
 import logging
 import hashlib
@@ -52,18 +52,7 @@ class ConfigService:
         
         # Thread safety
         self._lock: threading.RLock = threading.RLock()
-        # Held across a whole reload -- read, swap, notify -- so one reload's
-        # notifications finish before the next one's start. Subscribers run
-        # under this lock and never under _lock: the display's per-plugin
-        # subscriber can wait seconds for a busy plugin, and get_config(),
-        # subscribe() and unsubscribe() -- called from the render thread --
-        # must not wait behind it.
-        self._notify_lock: threading.RLock = threading.RLock()
-        # (key, callback, thread id) of the callback a notification is running,
-        # so unsubscribe() can wait for that one call; signalled on its return.
-        self._running_callback: Optional[Tuple[str, Callable[..., None], int]] = None
-        self._callback_done = threading.Condition(self._lock)
-
+        
         # Current configuration
         self._current_config: Dict[str, Any] = {}
         self._current_checksum: Optional[str] = None
@@ -98,33 +87,32 @@ class ConfigService:
             True if config changed, False otherwise
         """
         try:
-            with self._notify_lock:
-                new_config = self.config_manager.load_config()
-                new_checksum = self._calculate_checksum(new_config)
-
-                with self._lock:
-                    # Check if config actually changed
-                    if new_checksum == self._current_checksum:
-                        self.logger.debug("Configuration unchanged, skipping reload")
-                        return False
-
-                    # Store old config for change detection
-                    old_config = self._current_config.copy()
-
-                    # Update current config
-                    self._current_config = new_config
-                    self._current_checksum = new_checksum
-
-                # Notify subscribers, outside _lock (see _notify_lock)
+            new_config = self.config_manager.load_config()
+            new_checksum = self._calculate_checksum(new_config)
+            
+            with self._lock:
+                # Check if config actually changed
+                if new_checksum == self._current_checksum:
+                    self.logger.debug("Configuration unchanged, skipping reload")
+                    return False
+                
+                # Store old config for change detection
+                old_config = self._current_config.copy()
+                
+                # Update current config
+                self._current_config = new_config
+                self._current_checksum = new_checksum
+                
+                # Notify subscribers
                 self._notify_subscribers(old_config, new_config)
-
+                
                 self.logger.info(
                     "Configuration reloaded (checksum: %s)",
                     new_checksum[:8]
                 )
-
+                
                 return True
-
+                
         except ConfigError as e:
             self.logger.error("Error loading configuration: %s", e, exc_info=True)
             return False
@@ -139,64 +127,35 @@ class ConfigService:
         Args:
             old_config: Previous configuration
             new_config: New configuration
-
-        Called without _lock held. The subscriber lists are copied under it,
-        and each callback is checked against them again just before it runs.
         """
-        with self._lock:
-            subscribers = {key: list(callbacks) for key, callbacks in self._subscribers.items()}
-
         # Notify global subscribers (key: '*')
-        for callback in subscribers.get('*', []):
-            self._call_subscriber('*', callback, old_config, new_config)
-
+        for callback in self._subscribers.get('*', []):
+            try:
+                callback(old_config, new_config)
+            except Exception as e:
+                self.logger.error("Error in global config change callback: %s", e, exc_info=True)
+        
         # Notify plugin-specific subscribers
-        for plugin_id, callbacks in subscribers.items():
+        for plugin_id in self._subscribers.keys():
             if plugin_id == '*':
                 continue
-
+            
             old_plugin_config = old_config.get(plugin_id, {})
             new_plugin_config = new_config.get(plugin_id, {})
-
+            
             # Only notify if plugin config actually changed
             if old_plugin_config != new_plugin_config:
-                for callback in callbacks:
-                    self._call_subscriber(plugin_id, callback,
-                                          old_plugin_config, new_plugin_config)
-
-    def _call_subscriber(
-        self,
-        key: str,
-        callback: Callable[[Dict[str, Any], Dict[str, Any]], None],
-        old_config: Dict[str, Any],
-        new_config: Dict[str, Any],
-    ) -> None:
-        """Run one callback, unless it was unsubscribed since the snapshot.
-
-        unsubscribe() promises that once it returns the callback is neither
-        running nor will run: the display unloads the plugin straight after.
-        """
-        with self._lock:
-            if callback not in self._subscribers.get(key, ()):
-                return
-            self._running_callback = (key, callback, threading.get_ident())
-        try:
-            callback(old_config, new_config)
-        except Exception as e:
-            if key == '*':
-                self.logger.error("Error in global config change callback: %s", e, exc_info=True)
-            else:
-                self.logger.error(
-                    "Error in config change callback for %s: %s",
-                    key,
-                    e,
-                    exc_info=True
-                )
-        finally:
-            with self._lock:
-                self._running_callback = None
-                self._callback_done.notify_all()
-
+                for callback in self._subscribers[plugin_id]:
+                    try:
+                        callback(old_plugin_config, new_plugin_config)
+                    except Exception as e:
+                        self.logger.error(
+                            "Error in config change callback for %s: %s",
+                            plugin_id,
+                            e,
+                            exc_info=True
+                        )
+    
     def _check_file_changes(self) -> bool:
         """
         Check if configuration files have been modified.
@@ -317,11 +276,6 @@ class ConfigService:
         """
         Unsubscribe from configuration changes.
         
-        Once this returns the callback is not running and will not be called
-        again. A notification that is running this very callback is waited
-        for (unless the callback is the caller); one running any other
-        callback is not.
-
         Args:
             callback: Callback function to remove
             plugin_id: Optional plugin ID (must match subscription)
@@ -331,10 +285,6 @@ class ConfigService:
             if callback in self._subscribers[key]:
                 self._subscribers[key].remove(callback)
                 self.logger.debug("Unsubscribed from config changes for %s", key)
-            while (self._running_callback is not None
-                   and self._running_callback[:2] == (key, callback)
-                   and self._running_callback[2] != threading.get_ident()):
-                self._callback_done.wait()
     
     def shutdown(self) -> None:
         """Shutdown the configuration service."""

src/display_controller.py

@@ -25,12 +25,11 @@ import os
 import inspect
 import signal
 import json
-import math
 import threading
 import types
 from collections import deque
 from contextlib import contextmanager
-from typing import Dict, Any, FrozenSet, List, Optional, Callable, Set, Tuple
+from typing import Dict, Any, List, Optional, Callable, Set, Tuple
 from datetime import datetime
 from concurrent.futures import ThreadPoolExecutor, as_completed  # pylint: disable=no-name-in-module
 import pytz
@@ -90,19 +89,6 @@ _MIN_INITIAL_UPDATE_TIMEOUT_SECONDS = 2.0
 DEFAULT_DYNAMIC_DURATION_CAP = 180.0
 
 
-def _finite_seconds(value: Any) -> Optional[float]:
-    """``value`` as seconds when it is a finite number or a numeric string,
-    else None. A bool is not a number here, though it is an int: True would
-    read as a one-second screen."""
-    if isinstance(value, bool):
-        return None
-    try:
-        seconds = float(value)
-    except (TypeError, ValueError, OverflowError):
-        return None
-    return seconds if math.isfinite(seconds) else None
-
-
 class _PluginReloadJob:
     """A ``plugin.reload`` whose slow half runs off the render thread.
 
@@ -1354,12 +1340,6 @@ class DisplayController:
                         "until one does", self.EMPTY_ROTATION_PAUSE)
         self._sleep_with_plugin_updates(self.EMPTY_ROTATION_PAUSE)
 
-    #: Plugins already warned about a display duration that is not a number,
-    #: so a bad setting logs once, not at every one of its screens. A
-    #: frozenset, replaced rather than mutated; class-level default for
-    #: controllers built without __init__ (tests).
-    _duration_warned: FrozenSet[str] = frozenset()
-
     def _get_display_duration(self, mode_key):
         """Seconds to show a mode: the Rotation & Durations page's value for it
         (display.display_durations), else the plugin's own duration.
@@ -1367,17 +1347,6 @@ class DisplayController:
         The saved value has to win. Every plugin inherits
         get_display_duration(), so checking the plugin first meant the page's
         values were never read.
-
-        The plugin's answer is checked here, not trusted. Several plugins
-        return their display_duration setting straight from config.json, so
-        one saved as "20" or null (the raw config editor, a hand edit) came
-        back as a string or None; _resolve_durations compared it with 0, and
-        the TypeError went past every handler in the loop and stopped the
-        display service, which systemd restarted into the same screen. A
-        numeric string counts, as in BasePlugin.get_display_duration; any
-        other value that is not a finite number, or a raise, gets the 30 s a
-        mode without a plugin gets. A number at or below zero is passed on:
-        _resolve_durations has its own rule for that.
         """
         display_durations = self.config.get('display', {}).get('display_durations', {}) or {}
         override = display_durations.get(mode_key)
@@ -1385,22 +1354,8 @@ class DisplayController:
             return float(override)
 
         plugin_instance = self.plugin_modes.get(mode_key)
-        if plugin_instance is None or not hasattr(plugin_instance, 'get_display_duration'):
-            return 30
-        try:
-            value = plugin_instance.get_display_duration()
-        except Exception as err:  # pylint: disable=broad-except
-            problem = f"get_display_duration() raised {type(err).__name__}: {err}"
-        else:
-            seconds = _finite_seconds(value)
-            if seconds is not None:
-                return seconds
-            problem = f"display duration {value!r} is not a number"
-        plugin_id = getattr(plugin_instance, 'plugin_id', None) or mode_key
-        if plugin_id not in self._duration_warned:
-            self._duration_warned = self._duration_warned | {plugin_id}
-            logger.warning("Plugin %s: %s; showing its modes for 30s (logged once)",
-                           plugin_id, problem)
+        if plugin_instance is not None and hasattr(plugin_instance, 'get_display_duration'):
+            return plugin_instance.get_display_duration()
         return 30
 
     def _get_global_dynamic_cap(self) -> Optional[float]:

src/ipc/client.py

@@ -396,9 +396,9 @@ class StateSubscription:
     def _run(self) -> None:
         backoff = _RECONNECT_MIN_SECONDS
         while not self._stop.is_set():
-            snapshots = self.snapshots
             try:
                 self._follow()
+                backoff = _RECONNECT_MIN_SECONDS
             except ControlError as e:
                 self.last_error = e.reason
                 if e.reason in _SLOW_RETRY_REASONS:
@@ -414,11 +414,6 @@ class StateSubscription:
                         sock.close()
                     except OSError:
                         pass
-            if self.snapshots != snapshots:
-                # This connection got as far as the display's state: whatever
-                # ended it (a restart, most often), it was working, so the
-                # next try starts from the shortest wait again.
-                backoff = _RECONNECT_MIN_SECONDS
             if self._stop.wait(backoff):
                 return
             backoff = min(backoff * 2, _RECONNECT_MAX_SECONDS)

src/plugin_system/plugin_executor.py

@@ -92,10 +92,7 @@ class PluginExecutor:
                 with plugin_scope(plugin_id):
                     result_container['value'] = operation()
                 result_container['completed'] = True
-            except BaseException as e:  # pylint: disable=broad-except
-                # asyncio.CancelledError and SystemExit too: uncaught, one
-                # ended this thread with 'completed' unset, and an operation
-                # that failed at once was reported as timing out.
+            except Exception as e:
                 result_container['exception'] = e
                 result_container['completed'] = True
         

src/plugin_system/plugin_loader.py

@@ -199,22 +199,9 @@ def contained_plugin_dir(plugin_dir: Path, plugins_dir: Path) -> Optional[str]:
     name that came out of ``os.scandir()`` on the trusted root carries no
     taint, which is a real containment guarantee (and one CodeQL's
     path-injection query can follow), not a string sanitiser.
-
-    The entry looked for is the one ``plugin_dir`` itself names when it sits
-    directly in ``plugins_dir``: for a dev plugin symlinked in under its id,
-    the link's name. Resolving the link first and looking for the target's
-    folder name refused ``plugins/foo -> ~/.ledmatrix-dev-plugins/ledmatrix-foo``
-    (what ``dev_plugin_setup.sh link-github foo <url>`` makes), so the plugin
-    never loaded. Any other path is resolved and matched by its final name,
-    as before.
     """
-    plugins_dir_real = os.path.realpath(str(plugins_dir))
-    plugin_dir_abs = os.path.abspath(str(plugin_dir))
-    if os.path.realpath(os.path.dirname(plugin_dir_abs)) == plugins_dir_real:
-        matched_name = find_trusted_subdir(plugins_dir_real, os.path.basename(plugin_dir_abs))
-        if matched_name is not None:
-            return os.path.join(plugins_dir_real, matched_name)
     plugin_dir_real = os.path.realpath(str(plugin_dir))
+    plugins_dir_real = os.path.realpath(str(plugins_dir))
     matched_name = find_trusted_subdir(plugins_dir_real, os.path.basename(plugin_dir_real))
     if matched_name is None:
         return None
@@ -256,10 +243,6 @@ class PluginLoader:
         self.logger = logger or get_logger(__name__)
         self._loaded_modules: Dict[str, Any] = {}
         self._plugin_module_registry: Dict[str, set] = {}  # Maps plugin_id to set of module names
-        # plugin_id -> {dotted name: module} for the modules of the plugin's
-        # own packages (``providers.feed``). They keep their names while the
-        # plugin runs and are dropped with it; see _iter_plugin_submodules.
-        self._plugin_submodules: Dict[str, Dict[str, Any]] = {}
         # Lock to serialize module loading when plugins share module names
         # (e.g., scroll_display.py, game_renderer.py across sport plugins).
         # During exec_module, bare-name sub-modules temporarily appear in
@@ -466,45 +449,6 @@ class PluginLoader:
                 continue
         return result
 
-    @staticmethod
-    def _iter_plugin_submodules(
-        plugin_dir: Path, before_keys: set
-    ) -> list:
-        """Return dotted-name modules from plugin_dir added after before_keys.
-
-        The modules of a package the plugin ships (``providers.feed`` from
-        ``providers/feed.py``). _iter_plugin_bare_modules skips them, so the
-        bare ``providers`` was namespaced and dropped on unload while
-        ``providers.feed`` stayed in sys.modules: a reload after a store update
-        imported a fresh ``providers`` and then got the old ``feed`` back from
-        the cache, running the new manager.py against the old helpers until the
-        display restarted.
-
-        A module counts when its ``__file__`` -- or, for a namespace package,
-        which has none, every ``__path__`` entry -- is inside plugin_dir, so a
-        library the plugin imports (``requests.adapters``) never does.
-
-        Returns a list of (mod_name, module) tuples.
-        """
-        resolved_dir = plugin_dir.resolve()
-        result = []
-        for key in set(sys.modules.keys()) - before_keys:
-            if "." not in key:
-                continue
-            mod = sys.modules.get(key)
-            if mod is None:
-                continue
-            mod_file = getattr(mod, "__file__", None)
-            locations = [mod_file] if mod_file else list(getattr(mod, "__path__", None) or [])
-            if not locations:
-                continue
-            try:
-                if all(Path(loc).resolve().is_relative_to(resolved_dir) for loc in locations):
-                    result.append((key, mod))
-            except (ValueError, TypeError, OSError):
-                continue
-        return result
-
     def _evict_stale_bare_modules(self, plugin_dir: Path) -> dict:
         """Temporarily remove bare-name sys.modules entries from other plugins.
 
@@ -583,13 +527,6 @@ class PluginLoader:
         # Track for cleanup during unload
         self._plugin_module_registry[plugin_id] = namespaced_names
 
-        # The modules of the plugin's own packages keep their dotted names
-        # while it runs -- as they always have, so the package and its
-        # children stay a matching set in sys.modules -- and are dropped
-        # with the plugin by unregister_plugin_modules().
-        self._plugin_submodules[plugin_id] = dict(
-            self._iter_plugin_submodules(plugin_dir, before_keys))
-
         if namespaced_names:
             self.logger.info(
                 "Namespace-isolated %d module(s) for plugin %s",
@@ -600,16 +537,10 @@ class PluginLoader:
         """Remove namespaced sub-modules and cached module for a plugin from sys.modules.
 
         Called by PluginManager during unload to clean up all module entries
-        that were created when the plugin was loaded, including the dotted
-        modules of its packages. A dotted name is dropped only while it still
-        holds this plugin's module: the name is not namespaced, so another
-        plugin may have put its own there since.
+        that were created when the plugin was loaded.
         """
         for ns_name in self._plugin_module_registry.pop(plugin_id, set()):
             sys.modules.pop(ns_name, None)
-        for name, mod in self._plugin_submodules.pop(plugin_id, {}).items():
-            if sys.modules.get(name) is mod:
-                sys.modules.pop(name, None)
         self._loaded_modules.pop(plugin_id, None)
 
     def load_module(
@@ -715,13 +646,11 @@ class PluginLoader:
                     if evicted_name not in sys.modules:
                         sys.modules[evicted_name] = evicted_mod
                 # Clean up the partially-initialized main module and any
-                # bare-name or package sub-modules that were added during
-                # exec_module so they don't leak into subsequent plugin loads.
+                # bare-name sub-modules that were added during exec_module
+                # so they don't leak into subsequent plugin loads.
                 sys.modules.pop(module_name, None)
                 for key, _ in self._iter_plugin_bare_modules(plugin_dir, before_keys):
                     sys.modules.pop(key, None)
-                for key, _ in self._iter_plugin_submodules(plugin_dir, before_keys):
-                    sys.modules.pop(key, None)
                 raise
 
             self._loaded_modules[plugin_id] = module

src/plugin_system/plugin_manager.py

@@ -1163,7 +1163,7 @@ class PluginManager:
     def _record_update_failure(
         self,
         plugin_id: str,
-        exc: Optional[BaseException] = None,
+        exc: Optional[Exception] = None,
         log: bool = True,
         count_failure: bool = True,
     ) -> None:
@@ -1187,7 +1187,7 @@ class PluginManager:
         """
         failure_time = time.time()
         if exc is not None:
-            err: BaseException = exc
+            err: Exception = exc
             error_type = type(exc).__name__
         else:
             err = Exception(f"Plugin {plugin_id} execution failed (timeout or executor error)")
@@ -1653,7 +1653,7 @@ class PluginManager:
         finish_guard = threading.Lock()
         finished = {'done': False}
 
-        def _finish(success: bool, exc: Optional[BaseException] = None) -> None:
+        def _finish(success: bool, exc: Optional[Exception] = None) -> None:
             with finish_guard:
                 if finished['done']:
                     return
@@ -1727,13 +1727,7 @@ class PluginManager:
                     self.resource_monitor.monitor_call(plugin_id, plugin_instance.update)
                 else:
                     plugin_instance.update()
-            except BaseException as exc:  # pylint: disable=broad-except
-                # BaseException, not just Exception: asyncio.CancelledError
-                # and SystemExit derive from it. Either one skipped _finish,
-                # so the plugin kept its lock and stayed RUNNING for good --
-                # never rescheduled, and every display() skipped as busy.
-                # Re-raised for the executor, which reports it as this
-                # update's failure.
+            except Exception as exc:
                 _finish(False, exc=exc)
                 raise
             else:

src/plugin_system/store_manager.py

@@ -344,26 +344,12 @@ class PluginStoreManager(_RegistryMixin, _InstallMixin, _UpdateMixin):
         2. Fix permissions via os.chmod() then retry (works for same-owner files)
         3. Use sudo rm -rf as last resort (works for root-owned __pycache__, etc.)
 
-        A symlink -- a dev plugin linked in by scripts/dev/dev_plugin_setup.sh
-        -- is removed as a link, before any of that: rmtree refuses one, and
-        stage 2 would walk through it and chmod the developer's checkout.
-
         Args:
             path: Path to directory to remove
 
         Returns:
             True if directory was removed successfully, False otherwise
         """
-        if path.is_symlink():
-            # Checked before exists(), which follows the link: a dangling one
-            # would read as already removed and be left behind.
-            try:
-                path.unlink()
-                return True
-            except OSError as e:
-                self.logger.error(f"Could not remove the symlink {path}: {e}")
-                return False
-
         if not path.exists():
             return True  # Already removed
 

test/js/README.md

@@ -45,10 +45,6 @@ server has none.
 |---|---|---|
 | `unit/test_list_filter.js` | no | `ListFilter` search/filter/sort/count/sticky, and the installed-plugins config **extracted verbatim** from `plugins_manager.js` so the test can't drift from it |
 | `unit/test_update_all.js` | no | `PluginInstallManager.updateAll` from `plugins/install_manager.js`: Check & Update All sends only plugin ids (never `starlark:` app entries), re-sends a request that got no HTTP answer (web service restarting) instead of skipping that plugin, never re-sends one that got any HTTP answer (the real `api_client.js` classifies a proxy 502 or a JSON error without `error_code` as `API_ERROR`), and counts a no-op update as already up to date in the summary. Also run by `test/web_interface/test_update_all_plugins.py` so CI covers it |
-| `unit/test_store_install.js` | no | The store's Install button, with the whole of `plugins_manager.js` run by `plugins_manager_sandbox.js` (a vm context, fake DOM and API): a fresh install reloads the list, then enables the id the plugin was installed as -- the answer's `plugin_id`, else the installed entry the store entry matches (Weather installs as `ledmatrix-weather`); a Reinstall leaves the enabled state alone |
-| `unit/test_install_polling.js` | no | How long Install waits for a queued install (sandbox): at least the server's 300 s dependency-install timeout; when it stops waiting it reloads the installed list and warns, rather than reporting a failure or enabling anything |
-| `unit/test_store_categories.js` | no | The store's category filter (sandbox): the template ships only All Categories, the rest come from the store's plugins (one per category whatever its case), choosing one filters to it, and a swapped-in select is refilled from the cache keeping the choice |
-| `unit/test_github_url_install.js` | no | Install Single Plugin (sandbox, the button as `plugins.html` ships it): no inline `onclick`, so a click or Enter sends exactly one `install-from-url` request and raises no error |
 | `unit/test_render_cards.js` | no | `renderInstalledCards` markup, both empty states, and HTML-escaping of hostile plugin metadata |
 | `unit/test_style_editor_element_keys.js` | no | `elementKeys()`/`styleRows()`/`positionRows()` from `widgets/style-editor.js`: every `customization.layout` entry gets exactly one row -- paired with its style element through core's `x-layout-key` (so `score` belongs to `score_text`, not a second row), or a position row of its own, leaves included -- since the widget claims the whole `layout` block from the generic fallback renderer |
 | `unit/test_style_editor_layout_leaf_columns.js` | no | `columnsFor()` from `widgets/style-editor.js`: a layout-only key whose own value is a leaf (no x/y sub-object, e.g. a `show_logo` toggle) gets a self-keyed column instead of a blank, uneditable row |

test/js/plugins_manager_sandbox.js

@@ -1,212 +0,0 @@
-// The whole of plugins_manager.js (and list_filter.js before it, as the page
-// loads them), evaluated in a node vm context against a small fake DOM.
-//
-// For suites that drive the plugin manager's real flows -- install, polling,
-// store filters, the GitHub-URL button -- rather than one function sliced
-// out of the file. Nothing is mocked inside the script: only what the page
-// gives it (document, fetch, timers, showNotification, LEDEscape).
-//
-//   const sb = create({ route: (method, url, body) => ({ status, json }) });
-//   sb.el('plugin-store-grid');          // make an element exist by id
-//   sb.window.installPlugin('weather');
-//   await sb.until(() => sb.requests.some(r => r.url.includes('/toggle')));
-//
-// Timers ignore their delays and run on the next turn, so a poll loop that
-// would take minutes in a browser finishes in milliseconds. The page is in
-// readyState "loading" with no #installed-plugins-grid, so the script's own
-// start-up does nothing until a suite asks for it (window.initPluginsPage()).
-const fs = require('fs');
-const path = require('path');
-const vm = require('vm');
-const ledEscape = require('./led_escape');
-
-const V3 = path.resolve(__dirname, '../../web_interface/static/v3');
-const PLUGINS_HTML = path.resolve(__dirname, '../../web_interface/templates/v3/partials/plugins.html');
-
-class FakeClassList {
-  constructor() { this.set = new Set(); }
-  add(...c) { c.forEach(x => this.set.add(x)); }
-  remove(...c) { c.forEach(x => this.set.delete(x)); }
-  contains(c) { return this.set.has(c); }
-  toggle(c, force) {
-    const on = force === undefined ? !this.set.has(c) : !!force;
-    if (on) this.set.add(c); else this.set.delete(c);
-    return on;
-  }
-}
-
-function create({ route } = {}) {
-  const elements = new Map();
-  const requests = [];
-  const toasts = [];
-  const errors = [];
-  const restartNotes = [];
-
-  class FakeElement {
-    constructor(id, tag = 'div', attributes = {}) {
-      this.id = id;
-      this.tagName = tag.toUpperCase();
-      this.attributes = { ...attributes };
-      this.listeners = {};
-      this.children = [];
-      this.classList = new FakeClassList();
-      this.style = { removeProperty() {} };
-      this.dataset = {};
-      this.value = '';
-      this.textContent = '';
-      this.disabled = false;
-      this.parentNode = null;
-      this._html = '';
-    }
-    get innerHTML() { return this._html; }
-    set innerHTML(v) { this._html = String(v); this.children = []; }
-    getAttribute(n) { return n in this.attributes ? this.attributes[n] : null; }
-    setAttribute(n, v) { this.attributes[n] = String(v); }
-    hasAttribute(n) { return n in this.attributes; }
-    removeAttribute(n) { delete this.attributes[n]; }
-    addEventListener(type, fn) { (this.listeners[type] = this.listeners[type] || []).push(fn); }
-    removeEventListener(type, fn) {
-      this.listeners[type] = (this.listeners[type] || []).filter(f => f !== fn);
-    }
-    appendChild(child) { this.children.push(child); child.parentNode = this; return child; }
-    querySelector() { return null; }
-    querySelectorAll() { return []; }
-    closest() { return null; }
-    cloneNode() {
-      const copy = new FakeElement(this.id, this.tagName, this.attributes);
-      copy._html = this._html;
-      copy.value = this.value;
-      return copy;
-    }
-    replaceChild(next, prev) {
-      next.parentNode = this;
-      prev.parentNode = null;
-      if (next.id) elements.set(next.id, next);
-      return prev;
-    }
-    replaceWith(next) { if (this.parentNode) this.parentNode.replaceChild(next, this); }
-    // A browser runs an inline on<type> attribute first (it was set before
-    // any listener was added), then the listeners, and an exception in one
-    // does not stop the next: it is reported, which is what `errors` holds.
-    dispatch(type, init = {}) {
-      const event = {
-        type, target: this, currentTarget: this, key: init.key,
-        defaultPrevented: false,
-        preventDefault() { this.defaultPrevented = true; },
-        stopPropagation() {}, stopImmediatePropagation() {},
-      };
-      const inline = this.getAttribute('on' + type);
-      const handlers = [];
-      if (inline !== null) {
-        handlers.push(vm.runInContext(`(function(event) {\n${inline}\n})`, ctx));
-      }
-      handlers.push(...(this.listeners[type] || []));
-      for (const h of handlers) {
-        try { h.call(this, event); } catch (e) { errors.push(e); }
-      }
-      return event;
-    }
-    click() { return this.dispatch('click'); }
-  }
-
-  function el(id, tag, attributes) {
-    if (!elements.has(id)) {
-      const parent = new FakeElement(null);
-      parent.appendChild(new FakeElement(id, tag, attributes));
-      elements.set(id, parent.children[0]);
-    }
-    return elements.get(id);
-  }
-
-  const timers = [];
-  const ctx = {
-    // Warnings are the script noting elements this fake page doesn't have.
-    console: { log: console.log.bind(console), error: console.error.bind(console),
-               warn: () => {}, info: () => {}, debug: () => {} },
-    debugLog: () => {},
-    addEventListener() {},
-    URL,
-    document: {
-      readyState: 'loading',
-      body: { addEventListener() {} },
-      getElementById: id => elements.get(id) || null,
-      querySelector: () => null,
-      querySelectorAll: () => [],
-      addEventListener() {},
-      dispatchEvent() { return true; },
-      createElement: tag => new FakeElement(null, tag),
-    },
-    CustomEvent: class { constructor(type, init) { this.type = type; this.detail = init && init.detail; } },
-    setTimeout: (fn, _ms, ...args) => { timers.push(setImmediate(() => fn(...args))); return timers.length; },
-    clearTimeout: () => {},
-    setInterval: () => 0,
-    clearInterval: () => {},
-    requestAnimationFrame: fn => setImmediate(fn),
-    getComputedStyle: () => ({ display: 'block' }),
-    scrollTo() {},
-    sessionStorage: { getItem: () => null, setItem() {}, removeItem() {} },
-    localStorage: { getItem: () => null, setItem() {}, removeItem() {} },
-    confirm: () => true,
-    alert: () => {},
-    showNotification: (message, type) => {
-      toasts.push({ message: String(message),
-                    type: type && typeof type === 'object' ? type.type : type });
-    },
-    noteRestartRequired: (body) => { restartNotes.push(body); },
-    fetch: async (url, opts = {}) => {
-      const method = (opts.method || 'GET').toUpperCase();
-      let body = null;
-      try { body = opts.body ? JSON.parse(opts.body) : null; } catch (e) { body = opts.body; }
-      requests.push({ method, url: String(url), body });
-      const answer = (route && route(method, String(url), body)) || { status: 200, json: { status: 'success' } };
-      const status = answer.status || 200;
-      return { ok: status < 400, status, json: async () => answer.json };
-    },
-  };
-  ctx.window = ctx;
-  vm.createContext(ctx);
-  ledEscape.install(ctx);
-  for (const file of ['js/plugins/list_filter.js', 'plugins_manager.js']) {
-    vm.runInContext(fs.readFileSync(path.join(V3, file), 'utf8'), ctx, { filename: file });
-  }
-
-  // Resolves once cond() is true, letting timers and promises run between
-  // checks; rejects if it never is.
-  async function until(cond, label = 'condition', turns = 20000) {
-    for (let i = 0; i < turns; i++) {
-      if (cond()) return;
-      await new Promise(r => setImmediate(r));
-    }
-    throw new Error('timed out waiting for ' + label);
-  }
-
-  // Lets every pending timer and promise run.
-  async function settle(turns = 50) {
-    for (let i = 0; i < turns; i++) await new Promise(r => setImmediate(r));
-  }
-
-  return { window: ctx, el, FakeElement, requests, toasts, errors, restartNotes, until, settle };
-}
-
-// The attributes of the element with this id in partials/plugins.html, as
-// the template ships them (no Jinja on the tags these suites read).
-function templateAttributes(id) {
-  const html = fs.readFileSync(PLUGINS_HTML, 'utf8');
-  const at = html.indexOf(`id="${id}"`);
-  if (at < 0) throw new Error(`no element with id ${id} in plugins.html`);
-  const start = html.lastIndexOf('<', at);
-  let end = start, quote = null;
-  for (; end < html.length; end++) {
-    const ch = html[end];
-    if (quote) { if (ch === quote) quote = null; } else if (ch === '"' || ch === "'") quote = ch;
-    else if (ch === '>') break;
-  }
-  const tag = html.slice(start, end + 1);
-  const attrs = {};
-  const re = /([\w:-]+)\s*=\s*("([^"]*)"|'([^']*)')/g;
-  let m;
-  while ((m = re.exec(tag))) attrs[m[1]] = m[3] !== undefined ? m[3] : m[4];
-  return { tag: tag.match(/^<(\w+)/)[1], attrs, source: tag };
-}
-
-module.exports = { create, templateAttributes };

test/js/run_all.js

@@ -20,12 +20,7 @@ const UNIT = ['unit/test_list_filter.js', 'unit/test_render_cards.js',
               'unit/test_html_escaping.js', 'unit/test_style_editor_element_keys.js',
               'unit/test_style_editor_layout_leaf_columns.js',
               'unit/test_style_editor_layout_leaf_collision.js',
-              'unit/test_update_all.js',
-              'unit/test_store_install.js',
-              'unit/test_install_polling.js',
-              'unit/test_store_categories.js',
-              'unit/test_github_url_install.js',
-              'unit/test_inline_handler_escaping.js',
+              'unit/test_update_all.js', 'unit/test_inline_handler_escaping.js',
               'unit/test_plugin_action_delegation.js', 'unit/test_file_upload_widget.js',
               'unit/test_store_registry_fields.js', 'unit/test_restart_banner.js',
               'unit/test_page_registry.js', 'unit/test_core_modules.js'];

test/js/unit/test_github_url_install.js

@@ -1,93 +0,0 @@
-// Plugin Manager > Install from GitHub > Install Single Plugin: one click,
-// one request, no errors.
-//
-// The Install button carried an inline onclick calling
-// window.handleGitHubPluginInstall, and attachInstallButtonHandler also gave
-// it a click listener that installs. Both ran on every click. The inline one
-// threw a ReferenceError (it called isGithubUrl, which lives inside the
-// plugin-manager IIFE, from outside it), so only the listener's request went
-// out -- and fixing that scope alone would have sent every install twice.
-// The button now has the listener only.
-//
-// Runs the whole of plugins_manager.js in the sandbox, with the button as
-// partials/plugins.html ships it.
-
-const { create, templateAttributes } = require('../plugins_manager_sandbox');
-
-let pass = 0, fail = 0;
-const ok = (label, cond, extra) => cond
-  ? (pass++, console.log('  ok   ' + label))
-  : (fail++, console.log('  FAIL ' + label + (extra !== undefined ? '  -> ' + JSON.stringify(extra).slice(0, 400) : '')));
-
-const URL = 'https://github.com/someone/ledmatrix-demo';
-
-function route(method, url) {
-  if (method === 'POST' && url === '/api/v3/plugins/install-from-url') {
-    return { json: { status: 'success', message: 'Plugin demo installed successfully', plugin_id: 'demo' } };
-  }
-  if (url.startsWith('/api/v3/plugins/installed')) return { json: { status: 'success', data: { plugins: [] } } };
-  return { json: { status: 'success' } };
-}
-
-function page() {
-  const sb = create({ route });
-  const button = templateAttributes('install-plugin-from-url');
-  sb.el('install-plugin-from-url', button.tag, button.attrs);
-  sb.el('github-plugin-url', 'input');
-  sb.el('github-plugin-status');
-  sb.el('plugin-branch-input', 'input');
-  return sb;
-}
-
-const installs = sb => sb.requests.filter(r => r.url === '/api/v3/plugins/install-from-url');
-
-(async () => {
-  console.log('\nthe template');
-  {
-    const { attrs } = templateAttributes('install-plugin-from-url');
-    ok('the Install button has no inline onclick', !('onclick' in attrs), attrs.onclick);
-  }
-
-  console.log('\na click');
-  {
-    const sb = page();
-    sb.window.attachInstallButtonHandler();
-    // htmx:afterSettle runs it again on every swap; that must not add a handler.
-    sb.window.attachInstallButtonHandler();
-    sb.el('github-plugin-url').value = URL;
-    sb.window.document.getElementById('install-plugin-from-url').click();
-    await sb.settle();
-    ok('raises no error', sb.errors.length === 0, sb.errors.map(String));
-    ok('sends exactly one install request', installs(sb).length === 1, installs(sb));
-    ok('for the URL typed', installs(sb)[0] && installs(sb)[0].body.repo_url === URL, installs(sb));
-    ok('and reports the result', /Successfully installed: demo/.test(sb.el('github-plugin-status').innerHTML),
-       sb.el('github-plugin-status').innerHTML);
-  }
-
-  console.log('\nEnter in the URL field');
-  {
-    const sb = page();
-    sb.window.attachInstallButtonHandler();
-    const input = sb.el('github-plugin-url');
-    input.value = URL;
-    input.dispatch('keypress', { key: 'Enter' });
-    await sb.settle();
-    ok('raises no error', sb.errors.length === 0, sb.errors.map(String));
-    ok('sends exactly one install request', installs(sb).length === 1, installs(sb));
-  }
-
-  console.log('\na URL that is not GitHub');
-  {
-    const sb = page();
-    sb.window.attachInstallButtonHandler();
-    sb.el('github-plugin-url').value = 'https://example.com/x';
-    sb.window.document.getElementById('install-plugin-from-url').click();
-    await sb.settle();
-    ok('is refused without a request or an error',
-       installs(sb).length === 0 && sb.errors.length === 0 && /valid GitHub URL/.test(sb.el('github-plugin-status').innerHTML),
-       { errors: sb.errors.map(String), status: sb.el('github-plugin-status').innerHTML });
-  }
-
-  console.log(`\n${pass} passed, ${fail} failed`);
-  process.exit(fail ? 1 : 0);
-})().catch(e => { console.error(e); process.exit(1); });

test/js/unit/test_install_polling.js

@@ -1,89 +0,0 @@
-// How long the store's Install waits for a queued install, and what it says
-// when it stops waiting.
-//
-// It polled the operation 60 times, a second apart, then reported "Install
-// operation timed out" as an error and did nothing else. The server is
-// allowed far longer: the plugin's dependency install alone may take 300 s
-// (install_requirements_file in src/plugin_system/store_install.py), after
-// a download that fetches the plugin one file at a time. So an install that
-// went on to succeed was reported as failed, never enabled, and missing from
-// the installed list until the page was reloaded.
-//
-// Runs the whole of plugins_manager.js in the sandbox; its timers ignore
-// their delays, so each poll here stands for one second on a real page.
-
-const { create } = require('../plugins_manager_sandbox');
-
-let pass = 0, fail = 0;
-const ok = (label, cond, extra) => cond
-  ? (pass++, console.log('  ok   ' + label))
-  : (fail++, console.log('  FAIL ' + label + (extra !== undefined ? '  -> ' + JSON.stringify(extra).slice(0, 400) : '')));
-
-// The server's dependency-install timeout, in polls (one a second).
-const DEPENDENCY_INSTALL_TIMEOUT_POLLS = 300;
-
-function server(completesAfterPolls) {
-  const state = { polls: 0, installed: [] };
-  state.route = (method, url, body) => {
-    if (url.startsWith('/api/v3/plugins/installed')) {
-      return { json: { status: 'success', data: { plugins: state.installed.map(p => ({ ...p })) } } };
-    }
-    if (method === 'POST' && url === '/api/v3/plugins/install') {
-      return { json: { status: 'success', message: 'queued', data: { operation_id: 'op-1' } } };
-    }
-    if (url === '/api/v3/plugins/operation/op-1') {
-      state.polls++;
-      if (completesAfterPolls === null || state.polls < completesAfterPolls) {
-        return { json: { status: 'success', data: { status: 'running' } } };
-      }
-      state.installed = [{ id: 'clock-simple', name: 'Clock', enabled: false }];
-      return { json: { status: 'success', data: { status: 'completed',
-        result: { success: true, message: 'installed', plugin_id: 'clock-simple' } } } };
-    }
-    if (method === 'POST' && url === '/api/v3/plugins/toggle') {
-      return { json: { status: 'success', message: 'enabled' } };
-    }
-    return { json: { status: 'success' } };
-  };
-  return state;
-}
-
-(async () => {
-  console.log('\nan install that takes longer than a minute');
-  {
-    // 200 s: well inside what the server allows.
-    const srv = server(200);
-    const sb = create({ route: srv.route });
-    sb.window.installPlugin('clock-simple');
-    await sb.until(() => sb.toasts.some(t => /installed and enabled|enabling it failed|timed out|still/i.test(t.message)),
-                   'the install to finish');
-    await sb.settle();
-    ok('is waited for until it completes', srv.polls === 200, srv.polls);
-    ok('is not reported as an error', !sb.toasts.some(t => t.type === 'error'), sb.toasts);
-    ok('and is enabled', sb.requests.some(r => r.url === '/api/v3/plugins/toggle' && r.body.plugin_id === 'clock-simple'),
-       sb.requests.filter(r => r.method === 'POST'));
-  }
-
-  console.log('\nan install that never reports back');
-  {
-    const srv = server(null);
-    const sb = create({ route: srv.route });
-    sb.window.installPlugin('clock-simple');
-    await sb.until(() => sb.toasts.length >= 3, 'the poller to give up');
-    await sb.settle();
-    ok(`is polled for at least the ${DEPENDENCY_INSTALL_TIMEOUT_POLLS} s dependency-install timeout`,
-       srv.polls >= DEPENDENCY_INSTALL_TIMEOUT_POLLS, srv.polls);
-    ok('...but not forever', srv.polls <= 1200, srv.polls);
-    const lastPoll = sb.requests.map(r => r.url).lastIndexOf('/api/v3/plugins/operation/op-1');
-    ok('then the installed list is reloaded, to show what actually happened',
-       sb.requests.slice(lastPoll + 1).some(r => r.url === '/api/v3/plugins/installed'),
-       sb.requests.slice(lastPoll + 1).map(r => r.url));
-    const last = sb.toasts[sb.toasts.length - 1];
-    ok('it says the install may still be running, as a warning, not a failure',
-       last && last.type === 'warning' && !/fail|timed out/i.test(last.message), sb.toasts);
-    ok('nothing is enabled on a guess', !sb.requests.some(r => r.url === '/api/v3/plugins/toggle'));
-  }
-
-  console.log(`\n${pass} passed, ${fail} failed`);
-  process.exit(fail ? 1 : 0);
-})().catch(e => { console.error(e); process.exit(1); });

test/js/unit/test_store_categories.js

@@ -1,105 +0,0 @@
-// The Plugin Store's category filter offers the categories its plugins have.
-//
-// The template listed seven fixed categories. The registry uses about
-// twenty (productivity, utility, transit, finance, ...), so roughly a third
-// of the store could not be filtered to at all, and "Financial" missed the
-// plugin filed under "finance". The options are now built from the store's
-// plugins, as the Starlark section builds its own; the template ships only
-// "All Categories".
-//
-// Runs the whole of plugins_manager.js in the sandbox.
-
-const fs = require('fs');
-const path = require('path');
-const { create, templateAttributes } = require('../plugins_manager_sandbox');
-
-let pass = 0, fail = 0;
-const ok = (label, cond, extra) => cond
-  ? (pass++, console.log('  ok   ' + label))
-  : (fail++, console.log('  FAIL ' + label + (extra !== undefined ? '  -> ' + JSON.stringify(extra).slice(0, 400) : '')));
-
-const STORE = [
-  { id: 'nfl', name: 'NFL', category: 'sports' },
-  { id: 'nba', name: 'NBA', category: 'Sports' },
-  { id: 'todo', name: 'Todo', category: 'productivity' },
-  { id: 'stocks', name: 'Stocks', category: 'finance' },
-  { id: 'crypto', name: 'Crypto', category: 'financial' },
-  { id: 'bus', name: 'Bus', category: 'transit' },
-  { id: 'mystery', name: 'Mystery' },
-];
-
-function route(method, url) {
-  if (url.startsWith('/api/v3/plugins/store/list')) return { json: { status: 'success', data: { plugins: STORE } } };
-  if (url.startsWith('/api/v3/plugins/installed')) return { json: { status: 'success', data: { plugins: [] } } };
-  if (url.startsWith('/api/v3/plugins/store/github-status')) {
-    return { json: { status: 'success', data: { token_status: 'valid', authenticated: true, rate_limit: 5000 } } };
-  }
-  if (url.startsWith('/api/v3/plugins/saved-repositories')) {
-    return { json: { status: 'success', data: { repositories: [] } } };
-  }
-  if (url.startsWith('/api/v3/display/on-demand/status')) {
-    return { json: { status: 'success', data: { state: {}, service: {} } } };
-  }
-  return { json: { status: 'success' } };
-}
-
-const options = sel => sel.children.map(o => o.value);
-const cardIds = sb => [...sb.el('plugin-store-grid').innerHTML.matchAll(/<h4[^>]*>([^<]*)<\/h4>/g)].map(m => m[1]);
-
-(async () => {
-  console.log('\nthe template');
-  {
-    const html = fs.readFileSync(path.resolve(__dirname,
-      '../../../web_interface/templates/v3/partials/plugins.html'), 'utf8');
-    const start = html.indexOf('<select id="plugin-category"');
-    const block = html.slice(start, html.indexOf('</select>', start));
-    const shipped = [...block.matchAll(/<option value="([^"]*)"/g)].map(m => m[1]);
-    ok('ships only "All Categories"', JSON.stringify(shipped) === JSON.stringify(['']), shipped);
-  }
-
-  const sb = create({ route });
-  const attrs = templateAttributes('plugin-category').attrs;
-  const select = sb.el('plugin-category', 'select', attrs);
-  sb.el('plugin-store-grid');
-  sb.el('installed-plugins-grid');
-  sb.window.initPluginsPage();
-  await sb.until(() => sb.requests.some(r => r.url.startsWith('/api/v3/plugins/store/list')), 'the store list');
-  await sb.settle();
-
-  console.log('\noptions come from the store\'s plugins');
-  ok('"All Categories" is still the first choice', /<option value="">All Categories<\/option>/.test(select.innerHTML),
-     select.innerHTML);
-  ok('every category a plugin has is offered once, whatever its case',
-     JSON.stringify(options(select)) === JSON.stringify(['finance', 'financial', 'productivity', 'sports', 'transit']),
-     options(select));
-  ok('labels are capitalised',
-     (select.children.find(o => o.value === 'productivity') || {}).textContent === 'Productivity');
-
-  console.log('\nchoosing one filters to it');
-  select.value = 'productivity';
-  select.dispatch('change');
-  ok('productivity shows its plugin', JSON.stringify(cardIds(sb)) === JSON.stringify(['Todo']), cardIds(sb));
-  select.value = 'finance';
-  select.dispatch('change');
-  ok('finance is not lost to "financial"', JSON.stringify(cardIds(sb)) === JSON.stringify(['Stocks']), cardIds(sb));
-  select.value = 'sports';
-  select.dispatch('change');
-  ok('one option covers both spellings of sports',
-     JSON.stringify(cardIds(sb).sort()) === JSON.stringify(['NBA', 'NFL']), cardIds(sb));
-
-  console.log('\nthe partial is swapped back in (tab switch)');
-  {
-    // A fresh <select> from the template, the store list still cached.
-    const fresh = new sb.FakeElement('plugin-category', 'select', attrs);
-    select.parentNode.replaceChild(fresh, select);
-    sb.window.searchPluginStore(false);
-    await sb.settle();
-    ok('the new select is filled from the cache',
-       JSON.stringify(options(fresh)) === JSON.stringify(['finance', 'financial', 'productivity', 'sports', 'transit']),
-       options(fresh));
-    ok('keeping the chosen category', fresh.value === 'sports', fresh.value);
-  }
-
-  console.log(`\n${pass} passed, ${fail} failed`);
-  process.exit(fail ? 1 : 0);
-})().catch(e => { console.error(e); process.exit(1); });

test/js/unit/test_store_install.js

@@ -1,138 +0,0 @@
-// The store's Install button: which plugin it enables afterwards, and when.
-//
-//  1. Weather, Music, Stocks and Leaderboard are registry entries (`weather`)
-//     whose manifests declare another id (`ledmatrix-weather`). The plugin
-//     list, its config section and /plugins/toggle know them by that id, but
-//     the button enabled the registry id: /plugins/toggle answered 404
-//     "Plugin not found" and the plugin stayed disabled behind "installed,
-//     but enabling it failed". It now enables the id the install answer
-//     names (`plugin_id`), or, from an answer without one, the installed
-//     entry the store entry matches (its id, plugin_path name or aliases).
-//
-//  2. Reinstall (the same button on an installed plugin) enabled it too, so
-//     reinstalling a plugin the user had switched off switched it back on.
-//     Only a fresh install enables.
-//
-// Runs the whole of plugins_manager.js in the sandbox against a fake API.
-
-const { create } = require('../plugins_manager_sandbox');
-
-let pass = 0, fail = 0;
-const ok = (label, cond, extra) => cond
-  ? (pass++, console.log('  ok   ' + label))
-  : (fail++, console.log('  FAIL ' + label + (extra !== undefined ? '  -> ' + JSON.stringify(extra).slice(0, 400) : '')));
-
-const STORE = [
-  { id: 'weather', name: 'Weather', category: 'weather', plugin_path: 'plugins/ledmatrix-weather',
-    aliases: ['ledmatrix-weather'] },
-  { id: 'clock-simple', name: 'Clock', category: 'time', plugin_path: 'plugins/clock-simple', aliases: [] },
-];
-
-// A server with one install in flight. `queue` false answers the install
-// directly; `names` false leaves plugin_id out of the answer (an older
-// server); `installsAs` is the id the installed manifest declares.
-function server({ installed = [], queue = true, names = true, installsAs }) {
-  const state = { installed: installed.map(p => ({ ...p })), polls: 0 };
-  const done = (id) => {
-    if (!state.installed.some(p => p.id === installsAs)) {
-      state.installed.push({ id: installsAs, name: id, enabled: false });
-    }
-    const result = { success: true, message: `Plugin ${id} installed successfully`, restart_required: false };
-    if (names) result.plugin_id = installsAs;
-    return result;
-  };
-  state.route = (method, url, body) => {
-    if (url.startsWith('/api/v3/plugins/store/list')) {
-      return { json: { status: 'success', data: { plugins: STORE } } };
-    }
-    if (url.startsWith('/api/v3/plugins/installed')) {
-      return { json: { status: 'success', data: { plugins: state.installed.map(p => ({ ...p })) } } };
-    }
-    if (method === 'POST' && url === '/api/v3/plugins/install') {
-      if (queue) return { json: { status: 'success', message: 'queued', data: { operation_id: 'op-1' } } };
-      return { json: { status: 'success', message: 'Plugin installed successfully', ...done(body.plugin_id) } };
-    }
-    if (url === '/api/v3/plugins/operation/op-1') {
-      state.polls++;
-      if (state.polls < 3) return { json: { status: 'success', data: { status: 'running' } } };
-      return { json: { status: 'success', data: { status: 'completed', result: done('weather') } } };
-    }
-    if (method === 'POST' && url === '/api/v3/plugins/toggle') {
-      const plugin = state.installed.find(p => p.id === body.plugin_id);
-      if (!plugin) return { status: 404, json: { status: 'error', message: 'Plugin not found' } };
-      plugin.enabled = body.enabled;
-      return { json: { status: 'success', message: `Plugin ${body.plugin_id} enabled successfully` } };
-    }
-    return { json: { status: 'success' } };
-  };
-  return state;
-}
-
-async function install(pluginId, opts) {
-  const srv = server(opts);
-  const sb = create({ route: srv.route });
-  sb.window.searchPluginStore();
-  await sb.until(() => sb.requests.some(r => r.url.startsWith('/api/v3/plugins/store/list')), 'store list');
-  await sb.window.pluginManager.loadInstalledPlugins(true);
-  await sb.settle();
-  sb.requests.length = 0;
-  sb.toasts.length = 0;
-  sb.window.installPlugin(pluginId);
-  await sb.until(() => sb.toasts.some(t => /installed and enabled|enabling it failed|reinstalled/.test(t.message)),
-                 'the install to finish');
-  await sb.settle();
-  const toggles = sb.requests.filter(r => r.url === '/api/v3/plugins/toggle').map(r => r.body);
-  return { sb, srv, toggles };
-}
-
-(async () => {
-  console.log('\n1. a fresh install enables the id the plugin was installed as');
-  {
-    const { srv, toggles, sb } = await install('weather', { installsAs: 'ledmatrix-weather' });
-    ok('enables ledmatrix-weather, not the registry id',
-       JSON.stringify(toggles) === JSON.stringify([{ plugin_id: 'ledmatrix-weather', enabled: true }]), toggles);
-    ok('...which the server enabled', srv.installed.find(p => p.id === 'ledmatrix-weather').enabled === true, srv.installed);
-    ok('says so', sb.toasts.some(t => t.type === 'success' && /installed and enabled/.test(t.message)), sb.toasts);
-    ok('no "Plugin not found"', !sb.toasts.some(t => /not found|failed/.test(t.message)), sb.toasts);
-    const lastList = sb.requests.map(r => r.url).lastIndexOf('/api/v3/plugins/installed');
-    const toggleAt = sb.requests.findIndex(r => r.url === '/api/v3/plugins/toggle');
-    ok('the installed list is reloaded before enabling, so the new card is there to update',
-       lastList >= 0 && lastList < toggleAt, sb.requests.map(r => r.method + ' ' + r.url));
-  }
-  {
-    const { toggles } = await install('weather', { installsAs: 'ledmatrix-weather', names: false });
-    ok('an answer without plugin_id: the installed entry the store entry matches (its alias)',
-       JSON.stringify(toggles) === JSON.stringify([{ plugin_id: 'ledmatrix-weather', enabled: true }]), toggles);
-  }
-  {
-    const { toggles } = await install('weather', { installsAs: 'ledmatrix-weather', queue: false });
-    ok('without the operation queue, from the direct answer',
-       JSON.stringify(toggles) === JSON.stringify([{ plugin_id: 'ledmatrix-weather', enabled: true }]), toggles);
-  }
-  {
-    const { toggles } = await install('clock-simple', { installsAs: 'clock-simple', names: false });
-    ok('a plugin installed under its registry id is enabled by that id',
-       JSON.stringify(toggles) === JSON.stringify([{ plugin_id: 'clock-simple', enabled: true }]), toggles);
-  }
-
-  console.log('\n2. a reinstall leaves the plugin as the user had it');
-  {
-    const { srv, toggles, sb } = await install('weather', {
-      installsAs: 'ledmatrix-weather', installed: [{ id: 'ledmatrix-weather', name: 'Weather', enabled: false }],
-    });
-    ok('sends no toggle', toggles.length === 0, toggles);
-    ok('the plugin stays disabled', srv.installed.find(p => p.id === 'ledmatrix-weather').enabled === false);
-    ok('says it was reinstalled', sb.toasts.some(t => t.type === 'success' && /reinstalled/.test(t.message)), sb.toasts);
-    ok('and reloads the list',
-       sb.requests.some(r => r.url === '/api/v3/plugins/installed'), sb.requests.map(r => r.url));
-  }
-  {
-    const { toggles } = await install('weather', {
-      installsAs: 'ledmatrix-weather', installed: [{ id: 'ledmatrix-weather', name: 'Weather', enabled: true }],
-    });
-    ok('an enabled plugin is not toggled either', toggles.length === 0, toggles);
-  }
-
-  console.log(`\n${pass} passed, ${fail} failed`);
-  process.exit(fail ? 1 : 0);
-})().catch(e => { console.error(e); process.exit(1); });

test/js/unit/test_store_registry_fields.js

@@ -52,8 +52,7 @@ global.installedPlugins = [];
 // eslint-disable-next-line no-eval
 eval([
   'function escapeHtml(text) {', 'function escapeAttribute(text) {', 'function jsStringAttr(value) {',
-  'function isStorePluginInstalled(pluginIdOrPlugin) {',
-  'function findInstalledStorePlugin(pluginIdOrPlugin) {', 'function renderPluginStore(plugins) {',
+  'function isStorePluginInstalled(pluginIdOrPlugin) {', 'function renderPluginStore(plugins) {',
 ].map(extract).join('\n') + '\nglobal.renderPluginStore = renderPluginStore;'
   + '\nglobal.isStorePluginInstalled = isStorePluginInstalled;');
 

test/js/unit/test_update_all.js

@@ -52,7 +52,7 @@ function fakeApi(behaviour = {}) {
   };
 }
 
-function setup(api, { stateList, windowList, pluginManager } = {}) {
+function setup(api, { stateList, windowList } = {}) {
   global.window = {
     PluginAPI: api,
     installedPlugins: windowList,
@@ -60,7 +60,6 @@ function setup(api, { stateList, windowList, pluginManager } = {}) {
       installedPlugins: stateList,
       loadInstalledPlugins: async () => stateList,
     },
-    pluginManager,
   };
 }
 
@@ -93,68 +92,12 @@ const noSleep = { sleep: async () => {} };
     ok('progress total counts only what is sent',
        progress.length === EXPECTED.length && progress.every(([, n]) => n === EXPECTED.length), progress);
   }
-  {
-    // A page without the plugin manager has no window.installedPlugins.
-    const api = fakeApi();
-    setup(api, { stateList: INSTALLED });
-    await Manager.updateAll(null, noSleep);
-    ok('the PluginStateManager list (no live list) is filtered the same way',
-       JSON.stringify(api.calls) === JSON.stringify(EXPECTED), api.calls);
-  }
-
-  console.log('\na second run sends the live list, not the first run\'s snapshot');
-  {
-    // Run 1 leaves PluginStateManager holding a, b, c. Then c is uninstalled
-    // and d installed: plugins_manager.js publishes that only as
-    // window.installedPlugins. Run 2 used to send a, b, c -- c failed as
-    // "plugin not found" and d, which had an update waiting, was skipped.
-    const api = fakeApi({
-      c: () => { throw { error_code: 'PLUGIN_UPDATE_FAILED', message: 'Plugin update failed: plugin not found' }; },
-    });
-    const stale = [{ id: 'a' }, { id: 'b' }, { id: 'c' }];
-    setup(api, { stateList: stale, windowList: [{ id: 'a' }, { id: 'b' }, { id: 'd' }] });
-    const results = await Manager.updateAll(null, noSleep);
-    ok('sends exactly what is installed now',
-       JSON.stringify(api.calls) === JSON.stringify(['a', 'b', 'd']), api.calls);
-    ok('...so nothing fails over an uninstalled plugin', results.every(r => r.success), results);
-  }
   {
     const api = fakeApi();
     setup(api, { stateList: INSTALLED, windowList: [] });
-    const results = await Manager.updateAll(null, noSleep);
-    ok('an empty live list means nothing is installed: nothing is sent',
-       api.calls.length === 0 && results.length === 0, api.calls);
-  }
-
-  console.log('\nthe end-of-run refresh redraws the installed grid');
-  {
-    // PluginStateManager's refresh replaced window.installedPlugins and
-    // nothing else: the cards kept "Update to vX" and the Updates badge
-    // kept its count. The plugin manager's load renders the grid.
-    const loads = [];
-    let stateLoads = 0;
-    const pluginManager = { loadInstalledPlugins: async (force) => { loads.push(force); } };
-    setup(fakeApi(), { stateList: INSTALLED, windowList: INSTALLED, pluginManager });
-    window.PluginStateManager.loadInstalledPlugins = async () => { stateLoads++; };
     await Manager.updateAll(null, noSleep);
-    ok('reloads through the plugin manager once, forced past its caches',
-       JSON.stringify(loads) === JSON.stringify([true]), loads);
-    ok('...instead of PluginStateManager', stateLoads === 0, stateLoads);
-  }
-  {
-    const pluginManager = { loadInstalledPlugins: async () => { throw new Error('offline'); } };
-    const answer = { status: 'success', data: { update_status: 'updated' }, restart_required: true };
-    setup(fakeApi({ 'ledmatrix-flights': () => answer }), { windowList: INSTALLED, pluginManager });
-    const warn = console.warn;
-    console.warn = () => {};
-    let results;
-    try {
-      results = await Manager.updateAll(null, noSleep);
-    } finally {
-      console.warn = warn;
-    }
-    ok('a failed plugin-manager reload still returns the results with their restart flag',
-       Array.isArray(results) && Manager.restartRequest(results) === answer);
+    ok('the PluginStateManager list is filtered the same way',
+       JSON.stringify(api.calls) === JSON.stringify(EXPECTED), api.calls);
   }
   {
     const api = fakeApi();

test/test_api_v3_install_reports_installed_id.py

@@ -1,104 +0,0 @@
-"""POST /plugins/install says which id the plugin was installed as.
-
-A registry entry can install under another id: `weather` (aliases
-`ledmatrix-weather`) installs a directory whose manifest declares
-`ledmatrix-weather`, and that is the id the plugin list, the plugin's config
-section and /plugins/toggle know it by. The store's Install button enabled
-the new plugin by the registry id, which /plugins/toggle answered with 404
-"Plugin not found", so Weather, Music, Stocks and Leaderboard installed
-disabled behind an "enabling it failed" warning.
-
-The answer -- the queued operation's result, or the direct response --
-carries `plugin_id`: the id the installed manifest declares, found the way
-the store's update and uninstall find an install.
-"""
-
-import json
-from unittest.mock import MagicMock
-
-import pytest
-
-from test._api_v3_test_helpers import api_v3_client, api_v3_module  # noqa: F401
-
-INSTALL = "/api/v3/plugins/install"
-
-
-@pytest.fixture
-def store(api_v3_module, tmp_path):
-    manager = api_v3_module.api_v3.plugin_store_manager
-    manager.install_plugin.return_value = True
-    manager.get_registry_info.return_value = None
-    manager._find_plugin_path.return_value = None
-
-    def installed_as(directory, manifest):
-        path = tmp_path / directory
-        path.mkdir()
-        (path / "manifest.json").write_text(json.dumps(manifest), encoding="utf-8")
-        manager._find_plugin_path.side_effect = (
-            lambda pid: path if pid == "weather" else None)
-        return path
-
-    manager.installed_as = installed_as
-    return manager
-
-
-@pytest.fixture
-def queued(api_v3_module):
-    queue = MagicMock()
-
-    def enqueue(operation_type, plugin_id, operation_callback=None):
-        queue.callback_result = operation_callback(MagicMock())
-        return "op-1"
-
-    queue.enqueue_operation.side_effect = enqueue
-    api_v3_module.api_v3.operation_queue = queue
-    return queue
-
-
-class TestDirectInstall:
-    def test_an_aliased_entry_reports_the_manifest_id(self, api_v3_client, store):
-        store.installed_as("ledmatrix-weather", {"id": "ledmatrix-weather"})
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["status"] == "success"
-        assert body["plugin_id"] == "ledmatrix-weather"
-        store._find_plugin_path.assert_called_with("weather")
-
-    def test_an_entry_installed_under_its_own_id_reports_that(self, api_v3_client, store):
-        store.installed_as("weather", {"id": "weather"})
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["plugin_id"] == "weather"
-
-    def test_an_install_that_cannot_be_found_reports_the_requested_id(self, api_v3_client, store):
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["status"] == "success"
-        assert body["plugin_id"] == "weather"
-
-    def test_a_manifest_id_that_is_not_a_plain_name_is_not_passed_on(self, api_v3_client, store):
-        store.installed_as("ledmatrix-weather", {"id": "../elsewhere"})
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["plugin_id"] == "weather"
-
-    def test_an_unreadable_manifest_reports_the_requested_id(self, api_v3_client, store):
-        path = store.installed_as("ledmatrix-weather", {})
-        (path / "manifest.json").write_text("[not json", encoding="utf-8")
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["plugin_id"] == "weather"
-
-    def test_the_restart_fields_are_still_sent(self, api_v3_client, store):
-        store.installed_as("ledmatrix-weather", {"id": "ledmatrix-weather"})
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert "restart_required" in body
-
-
-class TestQueuedInstall:
-    def test_the_operation_result_names_the_manifest_id(self, api_v3_client, store, queued):
-        store.installed_as("ledmatrix-weather", {"id": "ledmatrix-weather"})
-        body = api_v3_client.post(INSTALL, json={"plugin_id": "weather"}).get_json()
-        assert body["data"]["operation_id"] == "op-1"
-        assert queued.callback_result["success"] is True
-        assert queued.callback_result["plugin_id"] == "ledmatrix-weather"
-
-    def test_an_install_that_cannot_be_found_names_the_requested_id(
-            self, api_v3_client, store, queued):
-        api_v3_client.post(INSTALL, json={"plugin_id": "weather"})
-        assert queued.callback_result["plugin_id"] == "weather"

test/test_api_v3_installed_display_modes.py

@@ -1,59 +0,0 @@
-"""GET /api/v3/plugins/installed carries each plugin's ``display_modes``.
-
-The on-demand modal (plugins_manager.js) fills its Display Mode list from
-``plugin.display_modes``, but the route never included the field, so every
-plugin offered one option -- its own id -- under "This plugin exposes a
-single display mode". The display turns that id into the plugin's first
-mode, so a multi-mode plugin could only be started, and pinned, on that one.
-
-The modes come from the plugin catalog (the manifests the web process
-discovered), the same source /display/modes and on-demand/start use.
-"""
-
-from unittest.mock import MagicMock
-
-import pytest
-
-from test._api_v3_test_helpers import (  # noqa: F401 - fixtures
-    api_v3_client, api_v3_module,
-)
-
-
-@pytest.fixture
-def installed(api_v3_module, api_v3_client, tmp_path):
-    def _get(declared_modes):
-        api = api_v3_module.api_v3
-        # The listing's own metadata says nothing about modes: what the
-        # route reports must come from the catalog.
-        info = {'id': 'football-scoreboard', 'name': 'Football', 'version': '1.0.0'}
-        api.plugin_catalog.plugins_dir = str(tmp_path)  # no manifest on disk
-        api.plugin_catalog.get_all_plugin_info = MagicMock(return_value=[info])
-        api.plugin_catalog.get_plugin_display_modes = MagicMock(return_value=declared_modes)
-        api.plugin_store_manager.get_registry_info = MagicMock(return_value=None)
-        api.config_manager.load_config = MagicMock(return_value={})
-        response = api_v3_client.get('/api/v3/plugins/installed')
-        assert response.status_code == 200
-        plugins = [p for p in response.get_json()['data']['plugins']
-                   if p['id'] == 'football-scoreboard']
-        assert len(plugins) == 1
-        api.plugin_catalog.get_plugin_display_modes.assert_any_call('football-scoreboard')
-        return plugins[0]
-    return _get
-
-
-def test_every_declared_mode_is_listed_in_order(installed):
-    modes = ['nfl_live', 'nfl_recent', 'nfl_upcoming']
-    assert installed(modes)['display_modes'] == modes
-
-
-def test_a_single_mode_plugin_lists_its_one_mode(installed):
-    assert installed(['clock-simple'])['display_modes'] == ['clock-simple']
-
-
-def test_no_declared_modes_is_an_empty_list(installed):
-    # The modal falls back to the plugin id for an empty list.
-    assert installed([])['display_modes'] == []
-
-
-def test_a_hand_edited_manifest_cannot_put_non_strings_in_the_list(installed):
-    assert installed(['nfl_live', 7, None, {'x': 1}])['display_modes'] == ['nfl_live']

test/test_api_v3_status_accuracy.py

@@ -0,0 +1,326 @@
+"""Four web answers that disagreed with the rig they describe (found on ledpi).
+
+1. POST /config/schedule refused the schedule GET returns on a fresh install
+   (config.template.json: per-day, every day off, schedule disabled) with
+   "At least one day must be enabled", as did /config/dim-schedule. A
+   disabled schedule needs no enabled day.
+2. A brightness-only POST /config/main answered ``restart_required: true``,
+   though the display applies brightness live (brightness.set over the
+   socket, and the config watcher). The flag now says whether anything
+   changed that the running display does not pick up by itself.
+3. /health stayed "healthy" with the display service stopped: only the
+   sub-checks changed. Service inactive, no socket and no live heartbeat
+   is now ``display_loop: stopped`` and "degraded".
+4. /display/current-status kept answering ``is_display_active: true`` from
+   the cache for up to 120 s after the display stopped. With no socket and
+   no live heartbeat it is now unknown.
+"""
+
+import copy
+import json
+import os
+import sys
+import time
+from pathlib import Path
+from unittest.mock import patch
+
+import pytest
+
+sys.path.insert(0, str(Path(__file__).parent.parent))
+
+from test._api_v3_test_helpers import api_v3_client, api_v3_module  # noqa: F401,E402
+
+from src import display_watchdog  # noqa: E402
+from src.ipc import client as control_client  # noqa: E402
+from web_interface import display_state  # noqa: E402
+
+REPO = Path(__file__).resolve().parent.parent
+TEMPLATE = json.loads((REPO / 'config' / 'config.template.json').read_text(encoding='utf-8'))
+
+
+@pytest.fixture
+def store(api_v3_module, monkeypatch):
+    state = {'config': {}, 'saves': 0}
+    api_v3_module.api_v3.config_manager.load_config.side_effect = \
+        lambda *a, **k: copy.deepcopy(state['config'])
+
+    def fake_save(_manager, config, **_kwargs):
+        state['config'] = copy.deepcopy(config)
+        state['saves'] += 1
+        return True, ''
+
+    monkeypatch.setattr(api_v3_module, '_save_config_atomic', fake_save)
+    return state
+
+
+# --- 1. schedules ---------------------------------------------------------------
+
+SCHEDULE_ROUTES = [('/api/v3/config/schedule', 'schedule'),
+                   ('/api/v3/config/dim-schedule', 'dim_schedule')]
+
+
+@pytest.mark.parametrize('route,section', SCHEDULE_ROUTES)
+def test_the_templates_disabled_per_day_schedule_saves_back(api_v3_client, store,
+                                                            route, section):
+    stored = copy.deepcopy(TEMPLATE[section])
+    stored['mode'] = 'per-day'
+    assert stored['enabled'] is False
+    assert not any(day['enabled'] for day in stored['days'].values())
+    store['config'] = {section: copy.deepcopy(stored)}
+
+    read = api_v3_client.get(route).get_json()['data']
+    resp = api_v3_client.post(route, json=read)
+
+    assert resp.status_code == 200, resp.get_json()
+    saved = store['config'][section]
+    assert saved['enabled'] is False and saved['mode'] == 'per-day'
+    # The disabled days keep their times: switching one on finds them.
+    assert saved['days'] == stored['days']
+
+
+@pytest.mark.parametrize('route,section', SCHEDULE_ROUTES)
+def test_an_enabled_per_day_schedule_still_needs_a_day(api_v3_client, store, route, section):
+    body = copy.deepcopy(TEMPLATE[section])
+    body.update(enabled=True, mode='per-day')
+    resp = api_v3_client.post(route, json=body)
+    assert resp.status_code == 400
+    assert 'At least one day must be enabled' in resp.get_json()['message']
+    assert store['saves'] == 0
+
+
+@pytest.mark.parametrize('route', [r for r, _ in SCHEDULE_ROUTES])
+def test_the_pickers_form_post_with_every_day_off_saves(api_v3_client, store, route):
+    """What schedule-picker.js posts: flat hidden inputs, booleans as strings,
+    times for every day."""
+    body = {'enabled': 'false', 'mode': 'per_day', 'start_time': '07:00', 'end_time': '23:00'}
+    for day in ('monday', 'tuesday', 'wednesday', 'thursday', 'friday', 'saturday', 'sunday'):
+        body.update({f'{day}_enabled': 'false', f'{day}_start': '06:30', f'{day}_end': '22:15'})
+    resp = api_v3_client.post(route, json=body)
+    assert resp.status_code == 200, resp.get_json()
+
+
+def test_an_invalid_time_on_a_disabled_day_is_dropped_not_refused(api_v3_client, store):
+    body = {'enabled': False, 'mode': 'per-day',
+            'days': {'monday': {'enabled': False, 'start_time': 'soon', 'end_time': '22:00'}}}
+    resp = api_v3_client.post('/api/v3/config/schedule', json=body)
+    assert resp.status_code == 200, resp.get_json()
+    assert store['config']['schedule']['days']['monday'] == {'enabled': False,
+                                                             'end_time': '22:00'}
+
+
+# --- 2. restart_required on /config/main ------------------------------------------
+
+STORED_MAIN = {
+    'timezone': 'America/Chicago',
+    'display': {
+        'hardware': {'rows': 32, 'cols': 64, 'chain_length': 2, 'brightness': 90,
+                     'disable_hardware_pulsing': False, 'inverse_colors': False,
+                     'show_refresh_rate': False},
+        'runtime': {'gpio_slowdown': 4},
+        'display_durations': {'clock': 15},
+        'use_short_date_format': False,
+    },
+}
+
+
+@pytest.fixture
+def main_store(store):
+    store['config'] = copy.deepcopy(STORED_MAIN)
+    return store
+
+
+def _save_main(client, body):
+    with patch('web_interface.blueprints.api_v3.control_client.brightness_set',
+               side_effect=control_client.ControlError('no_socket', 'x')):
+        resp = client.post('/api/v3/config/main', data=json.dumps(body),
+                           content_type='application/json')
+    assert resp.status_code == 200, resp.get_json()
+    return resp.get_json()
+
+
+def test_a_brightness_only_save_needs_no_restart(api_v3_client, main_store):
+    body = _save_main(api_v3_client, {'brightness': 40})
+    assert main_store['config']['display']['hardware']['brightness'] == 40
+    assert body['restart_required'] is False
+
+
+def test_a_brightness_save_on_a_config_without_a_display_section(api_v3_client, store):
+    """The route creates display.hardware and display.runtime on the way;
+    empty sections are not a change."""
+    store['config'] = {}
+    assert _save_main(api_v3_client, {'brightness': 40})['restart_required'] is False
+
+
+def test_the_display_form_with_only_brightness_changed_needs_no_restart(api_v3_client,
+                                                                       main_store):
+    hw = STORED_MAIN['display']['hardware']
+    body = {'__form_section': 'display', 'rows': 32, 'cols': 64, 'chain_length': 2,
+            'brightness': 55, 'gpio_slowdown': 4}
+    body.update({k: 'on' for k in ('disable_hardware_pulsing', 'inverse_colors',
+                                   'show_refresh_rate') if hw[k]})
+    assert _save_main(api_v3_client, body)['restart_required'] is False
+
+
+def test_a_mode_duration_needs_no_restart(api_v3_client, main_store):
+    body = _save_main(api_v3_client, {'duration__clock': 40})
+    assert main_store['config']['display']['display_durations']['clock'] == 40
+    assert body['restart_required'] is False
+
+
+@pytest.mark.parametrize('change', [{'rows': 64}, {'brightness': 40, 'chain_length': 3},
+                                    {'gpio_slowdown': 2}, {'timezone': 'UTC'}])
+def test_a_setting_the_display_reads_at_startup_still_needs_one(api_v3_client, main_store,
+                                                                change):
+    assert _save_main(api_v3_client, change)['restart_required'] is True
+
+
+def test_restart_needed_compares_leaves():
+    from web_interface.blueprints.api_v3.config import restart_needed
+    before = {'display': {'hardware': {'brightness': 90, 'rows': 32}}}
+    assert not restart_needed(before, copy.deepcopy(before))
+    assert not restart_needed(before, {'display': {'hardware': {'brightness': 10, 'rows': 32},
+                                                   'runtime': {}}})
+    assert restart_needed(before, {'display': {'hardware': {'brightness': 90}}})  # removed
+    assert not restart_needed({}, {'clock': {'enabled': True}}, live_paths=[('clock',)])
+    assert restart_needed({}, {'clockwork': {'enabled': True}}, live_paths=[('clock',)])
+
+
+# --- 3 and 4. a stopped display -----------------------------------------------------
+
+@pytest.fixture
+def no_display(monkeypatch, tmp_path):
+    """A Pi whose display service has stopped: the socket is expected here
+    but does not answer, and systemd took the heartbeat's directory away."""
+    monkeypatch.setattr(display_state, 'socket_supported', lambda: True)
+    monkeypatch.setattr(display_state, 'client_socket_paths', lambda: [str(tmp_path / 'gone')])
+    monkeypatch.setattr(display_state, 'read_state', lambda: None)
+    path = tmp_path / 'display-heartbeat.json'
+    monkeypatch.setattr(display_watchdog, 'HEARTBEAT_PATH', str(path))
+
+    def beat(age, pid=None):
+        path.write_text(json.dumps({'pid': os.getpid() if pid is None else pid,
+                                    'mono': time.monotonic() - age,
+                                    'wall': time.time() - age}))
+    return beat
+
+
+@pytest.fixture
+def service(monkeypatch):
+    status = {'active': False, 'returncode': 3, 'stdout': 'inactive', 'stderr': ''}
+    monkeypatch.setattr('web_interface.blueprints.api_v3.misc._get_display_service_status',
+                        lambda: dict(status))
+    return status
+
+
+@pytest.fixture
+def fresh_preview(tmp_path, monkeypatch):
+    """The preview frame the display left behind, under 60 s old: on its own
+    it kept the hardware check "connected"."""
+    from web_interface import display_preview
+    snapshot = tmp_path / 'preview.png'
+    snapshot.write_bytes(b'png')
+    monkeypatch.setattr(display_preview, 'SNAPSHOT_PATH', str(snapshot))
+
+
+def _health(client):
+    resp = client.get('/api/v3/health')
+    assert resp.status_code == 200, resp.get_json()
+    return resp.get_json()['data']
+
+
+class TestHealth:
+    def test_a_stopped_display_service_is_degraded(self, api_v3_client, no_display, service,
+                                                   fresh_preview):
+        data = _health(api_v3_client)
+        assert data['services']['display_service']['status'] == 'inactive'
+        assert data['checks']['display_loop']['status'] == 'stopped'
+        assert data['status'] == 'degraded'
+
+    def test_a_service_still_starting_is_not(self, api_v3_client, no_display, service,
+                                             fresh_preview):
+        """Active, before its socket and first heartbeat: not stopped."""
+        service.update(active=True, stdout='active', returncode=0)
+        data = _health(api_v3_client)
+        assert data['checks']['display_loop']['status'] == 'not_reported'
+        assert data['status'] == 'healthy'
+
+    def test_a_display_run_by_hand_is_not_stopped(self, api_v3_client, no_display, service,
+                                                  fresh_preview):
+        """The service is off but a display process beats (sudo python3 run.py)."""
+        no_display(age=2)
+        data = _health(api_v3_client)
+        assert data['checks']['display_loop']['status'] == 'running'
+        assert data['status'] == 'healthy'
+
+    @pytest.mark.parametrize('platform', ['no_unix_sockets', 'socket_off'])
+    def test_without_a_socket_to_expect_nothing_changes(self, api_v3_client, no_display,
+                                                        service, fresh_preview, monkeypatch,
+                                                        platform):
+        """Windows and the dev server (no systemd unit), or the socket
+        deliberately off: no heartbeat is no signal, as before."""
+        if platform == 'no_unix_sockets':
+            monkeypatch.setattr(display_state, 'socket_supported', lambda: False)
+        else:
+            monkeypatch.setattr(display_state, 'client_socket_paths', lambda: [])
+        service.update(returncode=-1, stdout='', stderr='systemctl not found')
+        data = _health(api_v3_client)
+        assert data['checks']['display_loop']['status'] == 'not_reported'
+        assert data['status'] == 'healthy'
+
+    def test_the_status_only_answer_says_degraded(self, api_v3_client, no_display, service,
+                                                  fresh_preview, monkeypatch):
+        monkeypatch.setattr('web_interface.blueprints.api_v3.misc.request_is_authenticated',
+                            lambda: False)
+        resp = api_v3_client.get('/api/v3/health')
+        assert resp.get_json()['data'] == {'status': 'degraded'}
+
+
+class TestCurrentStatus:
+    CACHED = {'mode': 'clock', 'plugin_id': 'clock', 'is_display_active': True,
+              'on_demand_active': False, 'last_updated': None}
+
+    @pytest.fixture
+    def cached(self, api_v3_module):
+        entry = dict(self.CACHED, last_updated=time.time() - 30)
+        cache = api_v3_module.api_v3.cache_manager
+        cache.get.side_effect = lambda key, *a, **kw: (
+            dict(entry) if key == 'display_current_state' else None)
+        return entry
+
+    def _status(self, client):
+        resp = client.get('/api/v3/display/current-status')
+        assert resp.status_code == 200
+        return resp.get_json()['data']
+
+    def test_a_stopped_display_is_not_reported_active(self, api_v3_client, no_display, cached):
+        data = self._status(api_v3_client)
+        assert not data.get('is_display_active')
+        assert data['mode'] is None and data['last_updated'] is None
+        assert data['source'] == 'cache'
+
+    def test_a_stale_heartbeat_is_not_active_either(self, api_v3_client, no_display, cached):
+        no_display(age=display_watchdog.HEARTBEAT_STALE_SECONDS + 5)
+        assert self._status(api_v3_client)['mode'] is None
+
+    @pytest.mark.skipif(os.name != 'posix', reason='process_exists answers only on POSIX')
+    def test_a_heartbeat_from_a_dead_process_is_not_active(self, api_v3_client, no_display,
+                                                           cached):
+        no_display(age=1, pid=2 ** 22 + 12345)
+        assert self._status(api_v3_client)['mode'] is None
+
+    def test_a_live_heartbeat_without_a_socket_reads_the_cache(self, api_v3_client,
+                                                               no_display, cached):
+        """An older display with no socket, still running."""
+        no_display(age=2)
+        data = self._status(api_v3_client)
+        assert data['mode'] == 'clock' and data['is_display_active'] is True
+
+    @pytest.mark.parametrize('platform', ['no_unix_sockets', 'socket_off'])
+    def test_without_a_socket_to_expect_the_cache_answers(self, api_v3_client, no_display,
+                                                          cached, monkeypatch, platform):
+        if platform == 'no_unix_sockets':
+            monkeypatch.setattr(display_state, 'socket_supported', lambda: False)
+        else:
+            monkeypatch.setattr(display_state, 'client_socket_paths', lambda: [])
+        data = self._status(api_v3_client)
+        assert data['mode'] == 'clock' and data['is_display_active'] is True

test/test_async_plugin_updates.py

@@ -13,7 +13,6 @@ The invariants that keep this change safe:
    inline path exactly.
 """
 
-import asyncio
 import os
 import sys
 import threading
@@ -210,32 +209,6 @@ class TestFailurePaths:
         assert pm.get_plugin_lock(plugin_id).acquire(blocking=False) is True
         pm.get_plugin_lock(plugin_id).release()
 
-    @pytest.mark.parametrize("raised", [asyncio.CancelledError, SystemExit])
-    def test_update_raising_a_base_exception_still_releases_the_plugin(self, pm, raised):
-        """asyncio.CancelledError and SystemExit derive from BaseException,
-        not Exception. Raised from update() on the worker, one skipped the
-        bookkeeping entirely: the plugin kept its lock and stayed RUNNING for
-        the life of the process -- never updated again, and every display()
-        skipped as busy."""
-        class CancellingPlugin(SlowPlugin):
-            def update(self):
-                self.update_calls += 1
-                raise raised()
-
-        plugin_id = _install(pm, CancellingPlugin())
-        pm.run_scheduled_updates()
-        deadline = time.monotonic() + 3
-        while pm.plugins[plugin_id].update_calls == 0 and time.monotonic() < deadline:
-            time.sleep(0.05)
-        time.sleep(0.2)
-
-        assert pm.get_plugin_lock(plugin_id).acquire(blocking=False) is True
-        pm.get_plugin_lock(plugin_id).release()
-        assert pm.state_manager.can_execute(plugin_id) is True
-        assert pm.plugin_last_update.get(plugin_id, 0) > 0
-        error = pm.state_manager.get_error_info(plugin_id)
-        assert error is not None and error["error_type"] == raised.__name__
-
     def test_unloaded_while_queued_is_harmless(self, pm):
         """Exercise the public unload_plugin() lifecycle rather than
         deleting pm.plugins directly: queue the target's update behind a

test/test_cache_long_keys.py

@@ -1,99 +0,0 @@
-"""A cache key too long to be a filename still gets a cache file.
-
-The calendar plugin's key joins every calendar id the user picked; on a real
-install it passed 300 bytes, and since ext4 caps a filename at 255 every write
-failed with ENAMETOOLONG -- logged as "permission denied", every update.
-"""
-
-import logging
-import os
-from unittest.mock import patch
-
-from src.cache.disk_cache import DiskCache, _MAX_KEY_FILENAME_BYTES, _filename_stem
-from src.cache_manager import CacheManager
-
-# The shape of the key that failed on hdpi, ids anonymised.
-CALENDAR_KEY = (
-    "calendar_events_someone@example.com_en.usa#holiday@group.v.calendar.google.com_"
-    "family13997378751670666433@group.calendar.google.com_ncaaf_-m-07kbp5_"
-    "%47eorgia+%42ulldogs+football#sports@group.v.calendar.google.com_nfl_-m-07l24_"
-    "%54ampa+%42ay+%42uccaneers#sports@group.v.calendar.google.com_primary"
-)
-
-# ext4/xfs/btrfs NAME_MAX; set()'s temp file adds 15 bytes to the stem.
-NAME_MAX = 255
-TEMP_OVERHEAD = len(".") + len(".json") + len(".") + 8
-
-
-def test_the_real_key_was_too_long_to_write():
-    assert len((CALENDAR_KEY + ".json").encode()) > NAME_MAX - 10
-
-
-def test_a_long_key_round_trips(tmp_path):
-    cache = DiskCache(str(tmp_path))
-    cache.set(CALENDAR_KEY, {"events": [1, 2, 3]})
-
-    assert cache.get(CALENDAR_KEY, max_age=None) == {"events": [1, 2, 3]}
-    path = cache.get_cache_path(CALENDAR_KEY)
-    assert os.path.isfile(path)
-    stem = os.path.basename(path)[:-len(".json")]
-    assert len(stem.encode()) + TEMP_OVERHEAD <= NAME_MAX
-
-
-def test_short_keys_keep_their_filename(tmp_path):
-    cache = DiskCache(str(tmp_path))
-    exactly = "k" * _MAX_KEY_FILENAME_BYTES
-    assert cache.get_cache_path("weather_current") == str(tmp_path / "weather_current.json")
-    assert cache.get_cache_path(exactly) == str(tmp_path / f"{exactly}.json")
-    assert cache.get_cache_path(exactly + "k") != str(tmp_path / f"{exactly}k.json")
-
-
-def test_long_keys_sharing_a_prefix_stay_apart(tmp_path):
-    cache = DiskCache(str(tmp_path))
-    first, second = CALENDAR_KEY + "_a", CALENDAR_KEY + "_b"
-    cache.set(first, {"which": "a"})
-    cache.set(second, {"which": "b"})
-
-    assert cache.get_cache_path(first) != cache.get_cache_path(second)
-    assert cache.get(first, max_age=None) == {"which": "a"}
-    assert cache.get(second, max_age=None) == {"which": "b"}
-
-
-def test_the_prefix_never_splits_a_character():
-    key = "news_" + "é" * 300  # two bytes each, so the cut lands mid-character
-    stem = _filename_stem(key)
-
-    assert stem.startswith("news_é")
-    assert len(stem.encode("utf-8")) <= _MAX_KEY_FILENAME_BYTES
-    stem.encode("utf-8").decode("utf-8")  # well-formed
-
-
-def test_a_stem_listed_by_the_web_ui_deletes_the_same_file(tmp_path):
-    with patch('src.cache_manager.CacheManager._get_writable_cache_dir', return_value=str(tmp_path)):
-        manager = CacheManager()
-    try:
-        manager.save_cache(CALENDAR_KEY, {"events": []})
-
-        listed = [entry["key"] for entry in manager.list_cache_files()]
-        assert len(listed) == 1
-        manager.clear_cache(listed[0])
-
-        assert [n for n in os.listdir(tmp_path) if n.endswith(".json")] == []
-    finally:
-        manager.stop_cleanup_thread()
-
-
-def test_a_failed_write_names_the_real_error(tmp_path, monkeypatch, caplog):
-    blocker = tmp_path / "a-file"
-    blocker.write_text("")
-    # No writable fallback either, so set() gives up and says why.
-    monkeypatch.setattr(os.path, "expanduser", lambda _p: str(blocker / "home"))
-    cache = DiskCache(str(tmp_path / "missing"))
-
-    with caplog.at_level(logging.WARNING):
-        cache.set("weather_current", {"t": 1})
-
-    gave_up = [r.getMessage() for r in caplog.records if "Could not write cache" in r.getMessage()]
-    assert len(gave_up) == 1
-    assert "permission denied" not in gave_up[0]
-    assert os.strerror(2) in gave_up[0]  # ENOENT: the directory does not exist

test/test_cache_memory_tier_age.py

@@ -1,95 +0,0 @@
-"""The memory tier never serves a record older than the reader asked for.
-
-A record read from disk went into the memory tier timed from the read, not
-from when it was written, so get(max_age=300) could hand out data up to twice
-that old: after a restart, after the memory sweep, or in a second process that
-loaded a record once and kept serving it.
-"""
-
-import time
-from unittest.mock import patch
-
-import pytest
-
-from src.cache_manager import CacheManager
-
-
-class Clock:
-    def __init__(self, now):
-        self.now = now
-
-    def __call__(self):
-        return self.now
-
-
-@pytest.fixture
-def clock(monkeypatch):
-    fake = Clock(1_800_000_000.0)
-    monkeypatch.setattr(time, "time", fake)
-    return fake
-
-
-def _manager(path):
-    # No disk sweep: it judges files by their real mtime against the fake
-    # clock and would delete them as months old.
-    with patch('src.cache_manager.CacheManager._get_writable_cache_dir',
-               return_value=str(path)), \
-            patch('src.cache_manager.CacheManager.start_cleanup_thread'):
-        return CacheManager()
-
-
-def test_a_record_loaded_late_expires_on_its_own_timestamp(tmp_path, clock):
-    writer = _manager(tmp_path)
-    writer.set("weather_current", {"t": 1})
-
-    reader = _manager(tmp_path)  # a restart, or the other process
-    clock.now += 250
-    assert reader.get("weather_current", max_age=300) == {"t": 1}
-
-    clock.now += 100  # the data is 350 s old; it sat in memory for 100 s
-    assert reader.get("weather_current", max_age=300) is None
-
-
-def test_a_stored_ttl_bounds_the_memory_copy_too(tmp_path, clock):
-    writer = _manager(tmp_path)
-    writer.set("odds_espn_football_nfl_401", {"spread": 6.5}, ttl=60)
-
-    reader = _manager(tmp_path)
-    clock.now += 55
-    assert reader.get("odds_espn_football_nfl_401", max_age=3600) == {"spread": 6.5}
-
-    clock.now += 60
-    assert reader.get("odds_espn_football_nfl_401", max_age=3600) is None
-
-
-def test_a_stale_memory_copy_gives_way_to_a_newer_write_on_disk(tmp_path, clock):
-    writer = _manager(tmp_path)
-    reader = _manager(tmp_path)
-    writer.set("stocks_AAPL", {"price": 1})
-    assert reader.get("stocks_AAPL", max_age=300) == {"price": 1}
-
-    clock.now += 280
-    writer.set("stocks_AAPL", {"price": 2})
-    clock.now += 40  # reader's copy: 40 s in memory, 320 s old
-
-    assert reader.get("stocks_AAPL", max_age=300) == {"price": 2}
-
-
-def test_fresh_records_are_still_served_from_memory(tmp_path, clock):
-    manager = _manager(tmp_path)
-    manager.set("news_NFL", {"items": []})
-    clock.now += 100
-
-    with patch.object(manager._disk_cache_component, "get") as disk_get:
-        assert manager.get("news_NFL", max_age=300) == {"items": []}
-    disk_get.assert_not_called()
-
-
-def test_max_age_none_and_records_without_a_timestamp_never_expire(tmp_path, clock):
-    manager = _manager(tmp_path)
-    manager.set("plugin_health_x", {"ok": True})
-    manager.save_cache("raw_record", {"no": "timestamp"})
-    clock.now += 10 ** 6
-
-    assert manager.get("plugin_health_x", max_age=None) == {"ok": True}
-    assert manager.get_cached_data("raw_record", max_age=None) == {"no": "timestamp"}

test/test_config_service_notify.py

@@ -1,199 +0,0 @@
-"""ConfigService notifies subscribers outside its lock, in order.
-
-Subscribers ran while _load_config held the service's lock. The display's
-per-plugin subscriber is PluginManager.apply_config_change, which waits up to
-PLUGIN_LOCK_TIMEOUT (5 s) for a busy plugin. The same save that toggles a
-plugin's ``enabled`` flags a reconcile, and the render thread runs it: its
-get_config() -- and the unsubscribe() of a plugin it disables -- waited behind
-every slow callback, freezing the panel for up to 5 s per busy plugin.
-
-What callers could rely on before still holds: one reload's notifications
-finish before the next reload's start, and a callback unsubscribe() removed is
-not running, and will not run, once unsubscribe() returns.
-"""
-
-import itertools
-import json
-import os
-import threading
-import time
-
-import pytest
-
-from src.config_manager import ConfigManager
-from src.config_service import ConfigService
-
-SLOW = 2.0  # how long a blocked callback waits before giving up
-
-
-@pytest.fixture
-def service(tmp_path):
-    config_path = tmp_path / "config.json"
-    config_path.write_text(json.dumps({"display": {"brightness": 50},
-                                       "weather": {"enabled": True}}),
-                           encoding="utf-8")
-    manager = ConfigManager(str(config_path), str(tmp_path / "config_secrets.json"))
-    manager.template_path = str(tmp_path / "no-template.json")
-    svc = ConfigService(manager, enable_hot_reload=False)
-    yield svc, config_path
-    svc.shutdown()
-
-
-_saves = itertools.count(1)
-
-
-def _save(config_path, **sections):
-    config = json.loads(config_path.read_text(encoding="utf-8"))
-    config.update(sections)
-    config_path.write_text(json.dumps(config), encoding="utf-8")
-    # ConfigManager re-reads only when (mtime, size) moves. Two quick saves of
-    # the same size can share an mtime tick (about 16 ms on Windows), so step
-    # it forward explicitly.
-    st = config_path.stat()
-    os.utime(config_path, ns=(st.st_atime_ns, st.st_mtime_ns + next(_saves) * 50_000_000))
-
-
-def _reload_in_background(svc):
-    thread = threading.Thread(target=svc._load_config, daemon=True)
-    thread.start()
-    return thread
-
-
-def test_get_config_does_not_wait_for_a_slow_subscriber(service):
-    svc, config_path = service
-    entered, release = threading.Event(), threading.Event()
-
-    def slow(_old, _new):
-        entered.set()
-        release.wait(SLOW)
-
-    svc.subscribe(slow, plugin_id="weather")
-    _save(config_path, weather={"enabled": False})
-    reload = _reload_in_background(svc)
-    assert entered.wait(SLOW)
-
-    start = time.monotonic()
-    config = svc.get_config()
-    waited = time.monotonic() - start
-    release.set()
-    reload.join(SLOW)
-
-    assert waited < 0.5
-    # Swapped before anyone was told: a subscriber that reads it sees the new one.
-    assert config["weather"]["enabled"] is False
-
-
-def test_unsubscribing_another_callback_does_not_wait(service):
-    svc, config_path = service
-    entered, release = threading.Event(), threading.Event()
-
-    def slow(_old, _new):
-        entered.set()
-        release.wait(SLOW)
-
-    def other(_old, _new):
-        pass
-
-    svc.subscribe(slow, plugin_id="weather")
-    svc.subscribe(other, plugin_id="clock")
-    _save(config_path, weather={"enabled": False})
-    reload = _reload_in_background(svc)
-    assert entered.wait(SLOW)
-
-    start = time.monotonic()
-    svc.unsubscribe(other, plugin_id="clock")
-    waited = time.monotonic() - start
-    release.set()
-    reload.join(SLOW)
-
-    assert waited < 0.5
-
-
-def test_a_callback_unsubscribed_mid_notification_is_not_called(service):
-    svc, config_path = service
-    entered, release = threading.Event(), threading.Event()
-    called = []
-
-    def slow_global(_old, _new):  # global subscribers are notified first
-        entered.set()
-        release.wait(SLOW)
-
-    def weather(_old, _new):
-        called.append("weather")
-
-    svc.subscribe(slow_global)
-    svc.subscribe(weather, plugin_id="weather")
-    _save(config_path, weather={"enabled": False})
-    reload = _reload_in_background(svc)
-    assert entered.wait(SLOW)
-
-    svc.unsubscribe(weather, plugin_id="weather")
-    release.set()
-    reload.join(SLOW)
-
-    assert called == []
-
-
-def test_unsubscribe_waits_for_its_own_callback_to_return(service):
-    svc, config_path = service
-    entered, release = threading.Event(), threading.Event()
-    returned = threading.Event()
-
-    def slow(_old, _new):
-        entered.set()
-        release.wait(SLOW)
-        returned.set()
-
-    svc.subscribe(slow, plugin_id="weather")
-    _save(config_path, weather={"enabled": False})
-    reload = _reload_in_background(svc)
-    assert entered.wait(SLOW)
-
-    threading.Timer(0.2, release.set).start()
-    svc.unsubscribe(slow, plugin_id="weather")
-
-    assert returned.is_set()
-    reload.join(SLOW)
-
-
-def test_a_callback_may_read_config_and_unsubscribe_itself(service):
-    svc, config_path = service
-    seen = []
-
-    def once(_old, _new):
-        seen.append(svc.get_config()["weather"]["enabled"])
-        svc.unsubscribe(once, plugin_id="weather")
-
-    svc.subscribe(once, plugin_id="weather")
-    _save(config_path, weather={"enabled": False})
-    reload = _reload_in_background(svc)
-    reload.join(SLOW)
-
-    assert not reload.is_alive()
-    assert seen == [False]
-
-
-def test_two_reloads_notify_in_order(service):
-    svc, config_path = service
-    entered, release = threading.Event(), threading.Event()
-    seen = []
-
-    def record(old, new):
-        seen.append((old["brightness"], new["brightness"]))
-        if len(seen) == 1:
-            entered.set()
-            release.wait(SLOW)
-
-    svc.subscribe(record, plugin_id="display")
-    _save(config_path, display={"brightness": 60})
-    first = _reload_in_background(svc)
-    assert entered.wait(SLOW)
-
-    _save(config_path, display={"brightness": 100})
-    second = _reload_in_background(svc)
-    time.sleep(0.2)
-    release.set()
-    first.join(SLOW)
-    second.join(SLOW)
-
-    assert seen == [(50, 60), (60, 100)]

test/test_display_duration_not_a_number.py

@@ -1,112 +0,0 @@
-"""A plugin duration that is not a number must not stop the display.
-
-Several plugins return their ``display_duration`` setting as it is in
-config.json (``return self.config.get('display_duration', 15.0)``), so a
-value saved as ``"20"`` or ``null`` -- from the raw config editor, or by
-hand -- reached run() as a string or None. _resolve_durations then compared
-it with 0, the TypeError went past every handler in the loop, and the
-display service exited; systemd restarted it into the same screen and the
-same crash.
-"""
-
-import logging
-import math
-import os
-from unittest.mock import MagicMock
-
-os.environ.setdefault("EMULATOR", "true")
-
-import pytest
-
-from src.display_controller import DisplayController
-from test._run_loop_harness import FakePlugin, RunLoopHarness
-
-
-def _controller(plugin_modes):
-    dc = object.__new__(DisplayController)
-    dc.config = {}
-    dc.plugin_modes = plugin_modes
-    return dc
-
-
-def _plugin(duration, plugin_id='clock-simple'):
-    plugin = MagicMock()
-    plugin.plugin_id = plugin_id
-    plugin.get_display_duration.return_value = duration
-    return plugin
-
-
-class TestPluginDurationIsCoerced:
-    @pytest.mark.parametrize('value, expected', [
-        ('20', 20.0), (' 7.5 ', 7.5), (12, 12.0), (12.5, 12.5)])
-    def test_numbers_and_numeric_strings_are_used(self, value, expected):
-        dc = _controller({'clock': _plugin(value)})
-        duration = dc._get_display_duration('clock')
-        assert duration == expected and isinstance(duration, float)
-
-    @pytest.mark.parametrize('value', [
-        None, '', 'twenty', True, False, float('nan'), float('inf'), 'inf',
-        [20], {'seconds': 20}])
-    def test_anything_but_a_finite_number_gets_the_default(self, value):
-        dc = _controller({'clock': _plugin(value)})
-        assert dc._get_display_duration('clock') == 30
-
-    @pytest.mark.parametrize('value', [0, -5, '-5', '0'])
-    def test_a_number_not_above_zero_still_gets_the_15s_rule(self, value):
-        """Unchanged: _resolve_durations turns it into 15 s, with its warning."""
-        plugin = _plugin(value)
-        dc = _controller({'clock': plugin})
-        base = dc._get_display_duration('clock')
-        assert dc._resolve_durations(plugin, 'clock', base, False)[1] == 15.0
-
-    def test_a_raising_get_display_duration_gets_the_default(self):
-        plugin = _plugin(None)
-        plugin.get_display_duration.side_effect = KeyError('display_duration')
-        assert _controller({'clock': plugin})._get_display_duration('clock') == 30
-
-    def test_the_result_feeds_resolve_durations(self):
-        """The two calls run() makes back to back, for one screen."""
-        plugin = _plugin('bad')
-        dc = _controller({'clock': plugin})
-        base = dc._get_display_duration('clock')
-        assert dc._resolve_durations(plugin, 'clock', base, False) == (30, 30)
-
-    def test_logged_once_per_plugin(self, caplog):
-        dc = _controller({'clock': _plugin('twenty'),
-                          'clock_big': _plugin('twenty'),
-                          'calendar': _plugin(None, plugin_id='calendar')})
-        # clock_big is a second mode of the same plugin.
-        dc.plugin_modes['clock_big'].plugin_id = 'clock-simple'
-        with caplog.at_level(logging.WARNING, logger='src.display_controller'):
-            for _ in range(3):
-                for mode in ('clock', 'clock_big', 'calendar'):
-                    dc._get_display_duration(mode)
-        warnings = [r for r in caplog.records if 'display duration' in r.getMessage()]
-        assert len(warnings) == 2
-        assert {'clock-simple', 'calendar'} == {
-            next(p for p in ('clock-simple', 'calendar') if p in r.getMessage())
-            for r in warnings}
-
-    def test_a_good_value_after_a_bad_one_is_used(self):
-        plugin = _plugin(None)
-        dc = _controller({'clock': plugin})
-        assert dc._get_display_duration('clock') == 30
-        plugin.get_display_duration.return_value = 45
-        assert dc._get_display_duration('clock') == 45.0
-
-
-class TestRunLoopSurvives:
-    """Through the real run() on the harness's fake clock."""
-
-    @pytest.mark.parametrize('duration, shown_for', [('20', 20.0), (None, 30.0),
-                                                     ('twenty', 30.0)])
-    def test_the_screen_runs_and_the_rotation_goes_on(self, tmp_path, duration, shown_for):
-        harness = RunLoopHarness(tmp_path, horizon=120)
-        harness.add_plugin(FakePlugin("weather", ["weather"], duration=30))
-        harness.add_plugin(FakePlugin("clock-simple", ["clock"], duration=duration))
-        # Before the fix run() returned at t=30, when the clock came up, and
-        # the harness raised "run() returned ... before the horizon".
-        rows = harness.run()["screens"]
-        clock = next(row for row in rows if row[1] == "clock")
-        assert math.isclose(clock[2], shown_for, abs_tol=1.0)
-        assert [row[1] for row in rows][:3] == ["weather", "clock", "weather"]

test/test_espn_payload.py

@@ -1,162 +0,0 @@
-"""Tests for src/common/espn_payload.py and its use by BackgroundDataService."""
-
-import copy
-import time
-from unittest.mock import MagicMock, Mock, patch
-
-import pytest
-
-from src.background_data_service import BackgroundDataService, shutdown_background_service
-from src.common.espn_payload import is_espn_scoreboard_url, slim_scoreboard_payload
-
-SCOREBOARD = "https://site.api.espn.com/apis/site/v2/sports/baseball/mlb/scoreboard"
-
-
-def _event():
-    """One event carrying every key the slimming drops and a sample of the
-    keys scoreboards read, at the depth ESPN puts them."""
-    competitor = {
-        "id": "10",
-        "homeAway": "home",
-        "score": "5",
-        "team": {"abbreviation": "NYY", "logo": "https://a/l.png",
-                 "links": [{"href": "https://espn.com/team"}]},
-        "records": [{"summary": "90-60"}],
-        "linescores": [{"value": 1}],
-        "statistics": [{"name": "hits", "displayValue": "9"}],
-        "leaders": [{"name": "avg", "leaders": [{"athlete": {"id": "1"}}]}],
-        "probables": [{"athlete": {"id": "2"}, "statistics": []}],
-    }
-    return {
-        "id": "401",
-        "date": "2026-10-01T23:05Z",
-        "links": [{"href": "https://espn.com/game"}],
-        "status": {"type": {"state": "post"}},
-        "competitions": [{
-            "status": {"type": {"state": "post", "shortDetail": "Final"},
-                       "featuredAthletes": [{"athlete": {"id": "3"}}]},
-            "competitors": [competitor, dict(copy.deepcopy(competitor), homeAway="away")],
-            "odds": [{"details": "NYY -150", "overUnder": 8.5}],
-            "situation": {"outs": 2},
-            "notes": [{"headline": "Game 1"}],
-            "broadcasts": [{"names": ["FOX"]}],
-            "venue": {"fullName": "Yankee Stadium"},
-            "leaders": [{"name": "hits"}],
-            "headlines": [{"description": "recap"}],
-            "highlights": [{"links": {"source": {}}}],
-            "geoBroadcasts": [{"media": {"shortName": "FOX"}}],
-        }],
-    }
-
-
-class TestSlimScoreboardPayload:
-    def test_drops_exactly_the_listed_keys(self):
-        payload = {"leagues": [{"id": "10"}], "events": [_event()]}
-        slim_scoreboard_payload(payload)
-        event = payload["events"][0]
-        competition = event["competitions"][0]
-        assert "links" not in event
-        for key in ("leaders", "headlines", "highlights", "geoBroadcasts"):
-            assert key not in competition
-        assert "featuredAthletes" not in competition["status"]
-        for competitor in competition["competitors"]:
-            assert "leaders" not in competitor
-            assert "probables" not in competitor
-            assert "links" not in competitor["team"]
-
-    def test_keeps_everything_else_unchanged(self):
-        """Removing the dropped keys from the original by hand gives exactly
-        the slimmed payload: nothing else moved, changed or went missing."""
-        original = {"leagues": [{"id": "10"}], "events": [_event(), _event()]}
-        expected = copy.deepcopy(original)
-        for event in expected["events"]:
-            del event["links"]
-            competition = event["competitions"][0]
-            for key in ("leaders", "headlines", "highlights", "geoBroadcasts"):
-                del competition[key]
-            del competition["status"]["featuredAthletes"]
-            for competitor in competition["competitors"]:
-                del competitor["leaders"], competitor["probables"]
-                del competitor["team"]["links"]
-        assert slim_scoreboard_payload(original) == expected
-
-    def test_in_place_and_returns_payload(self):
-        payload = {"events": [_event()]}
-        assert slim_scoreboard_payload(payload) is payload
-
-    @pytest.mark.parametrize("payload", [
-        None, [], "x", {}, {"events": None}, {"events": "x"},
-        {"events": [None, 1, "x", {"competitions": None}]},
-        {"events": [{"competitions": [None, {"status": None, "competitors": None}]}]},
-        {"events": [{"competitions": [{"competitors": [None, {"team": None}]}]}]},
-    ])
-    def test_odd_shapes_pass_through(self, payload):
-        before = copy.deepcopy(payload)
-        assert slim_scoreboard_payload(payload) == before
-
-
-class TestIsEspnScoreboardUrl:
-    @pytest.mark.parametrize("url", [
-        SCOREBOARD,
-        SCOREBOARD + "/",
-        "http://site.api.espn.com/apis/site/v2/sports/football/college-football/scoreboard",
-    ])
-    def test_scoreboards(self, url):
-        assert is_espn_scoreboard_url(url)
-
-    @pytest.mark.parametrize("url", [
-        None, "", 12,
-        "https://site.api.espn.com/apis/site/v2/sports/baseball/mlb/teams",
-        "https://site.api.espn.com/apis/site/v2/sports/football/nfl/summary",
-        "https://example.com/scoreboard",
-        "https://espn.com.evil.example/apis/x/scoreboard",
-        "https://notespn.com/apis/x/scoreboard",
-    ])
-    def test_not_scoreboards(self, url):
-        assert not is_espn_scoreboard_url(url)
-
-
-@pytest.fixture
-def service():
-    shutdown_background_service()
-    cache = MagicMock()
-    cache.get.return_value = None
-    svc = BackgroundDataService(cache, max_workers=1, request_timeout=5)
-    yield svc
-    svc.shutdown(wait=False)
-    shutdown_background_service()
-
-
-def _run(service, url, **kwargs):
-    response = Mock(status_code=200)
-    response.json.return_value = {"events": [_event()]}
-    response.raise_for_status.return_value = None
-    delivered = []
-    with patch.object(service.session, "get", return_value=response):
-        req_id = service.submit_fetch_request(
-            sport="mlb", year=2026, url=url, cache_key="mlb_schedule_window_14_7",
-            callback=lambda result: delivered.append(result.data), **kwargs)
-        deadline = time.time() + 5
-        while not service.is_request_complete(req_id) and time.time() < deadline:
-            time.sleep(0.02)
-    cached = service.cache_manager.set.call_args[0][1]
-    return cached, delivered
-
-
-class TestBackgroundServiceSlims:
-    def test_espn_scoreboard_is_cached_and_delivered_slimmed(self, service):
-        cached, delivered = _run(service, SCOREBOARD)
-        competition = cached["events"][0]["competitions"][0]
-        assert "leaders" not in competition
-        assert "probables" not in competition["competitors"][0]
-        assert competition["odds"] and competition["situation"]
-        # The callback sees the very payload that was cached.
-        assert delivered and delivered[0] is cached
-
-    def test_opt_out_caches_whole_response(self, service):
-        cached, _ = _run(service, SCOREBOARD, slim_payload=False)
-        assert cached == {"events": [_event()]}
-
-    def test_other_urls_untouched(self, service):
-        cached, _ = _run(service, "https://example.com/feed")
-        assert cached == {"events": [_event()]}

test/test_ipc_state_stream.py

@@ -346,52 +346,6 @@ class TestSubscriptionStore:
         assert client.snapshot_loop_age(snap, now_mono=104.0) is None
 
 
-class TestReconnectBackoff:
-    """StateSubscription._run's waits between connections, without a socket."""
-
-    def test_a_connection_that_got_a_snapshot_starts_the_backoff_over(self, hub,
-                                                                       monkeypatch):
-        """Three failed tries, then the display is back twice, restarting
-        each time, then gone again. Each restart is retried after the
-        shortest wait, not after whatever the waits had grown to."""
-        sub = client.StateSubscription(paths=['/nowhere'])
-        script = ['refused', 'refused', 'refused', 'snapshot', 'snapshot', 'refused']
-        waits = []
-
-        def follow():
-            step = script.pop(0)
-            if step == 'snapshot':      # subscribed, then the display restarted
-                sub._store(hub.snapshot(), full=True)
-                raise client.ControlError('closed', 'the display closed the connection')
-            raise client.ControlError(step)
-
-        def wait(seconds):
-            waits.append(seconds)
-            return not script           # True ends _run, as stop() would
-
-        monkeypatch.setattr(sub, '_follow', follow)
-        monkeypatch.setattr(sub._stop, 'wait', wait)
-        sub._run()
-        first = client._RECONNECT_MIN_SECONDS
-        assert waits == [first, 2 * first, 4 * first, first, first, 2 * first]
-
-    def test_a_display_without_the_stream_is_still_retried_slowly(self, monkeypatch):
-        sub = client.StateSubscription(paths=['/nowhere'])
-        waits = []
-
-        def follow():
-            raise client.ControlError('unknown_command')
-
-        def wait(seconds):
-            waits.append(seconds)
-            return len(waits) == 2
-
-        monkeypatch.setattr(sub, '_follow', follow)
-        monkeypatch.setattr(sub._stop, 'wait', wait)
-        sub._run()
-        assert waits == [client._RECONNECT_MAX_SECONDS] * 2
-
-
 # --- a real socket ------------------------------------------------------------------
 
 def _wait_until(predicate, timeout=5.0):

test/test_plugin_loader_reload_isolation.py

@@ -58,83 +58,3 @@ def test_a_reloaded_plugin_still_gets_its_own_bare_module(plugins):
     assert reloaded.WHO == "alpha"
     assert sys.path.index(str(plugins["alpha"])) < sys.path.index(str(plugins["beta"]))
     assert sys.path.count(str(plugins["alpha"])) == 1
-
-
-# -- sub-packages ------------------------------------------------------------
-#
-# A plugin that keeps helpers in a package (``providers/feed.py``, imported as
-# ``from providers.feed import ...``) leaves dotted entries in sys.modules.
-# Only the bare ``providers`` used to be tracked, so ``providers.feed`` outlived
-# the plugin: a reload after a store update re-ran the new manager.py against
-# the old feed.py, until the display restarted. Elections (providers/),
-# flights (enrichment/) and olympics (data/, renderers/) ship packages.
-
-
-@pytest.fixture
-def package_plugin(tmp_path):
-    before_path = list(sys.path)
-    before_modules = set(sys.modules)
-    plugin_dir = tmp_path / "pkgdemo"
-    (plugin_dir / "providers").mkdir(parents=True)
-    (plugin_dir / "providers" / "__init__.py").write_text("", encoding="utf-8")
-    (plugin_dir / "providers" / "feed.py").write_text("VERSION = 'v1'\n", encoding="utf-8")
-    (plugin_dir / "manager.py").write_text(
-        "from providers.feed import VERSION\n", encoding="utf-8")
-    yield plugin_dir
-    sys.path[:] = before_path
-    for key in set(sys.modules) - before_modules:
-        sys.modules.pop(key, None)
-
-
-def test_a_reloaded_plugin_runs_its_updated_subpackage_module(package_plugin):
-    loader = PluginLoader()
-    assert loader.load_module("pkgdemo", package_plugin, "manager.py").VERSION == "v1"
-
-    _unload(loader, "pkgdemo")
-    # The store update: a different size, so no cached bytecode can match.
-    (package_plugin / "providers" / "feed.py").write_text(
-        "VERSION = 'v2 from the update'\n", encoding="utf-8")
-    reloaded = loader.load_module("pkgdemo", package_plugin, "manager.py")
-
-    assert reloaded.VERSION == "v2 from the update"
-
-
-def test_unload_drops_the_plugins_subpackage_modules(package_plugin):
-    loader = PluginLoader()
-    loader.load_module("pkgdemo", package_plugin, "manager.py")
-    # Still importable while the plugin runs, as before.
-    assert "providers.feed" in sys.modules
-
-    _unload(loader, "pkgdemo")
-
-    assert not [k for k in sys.modules if k.startswith("providers")]
-
-
-def test_a_failed_load_leaves_no_subpackage_module_behind(package_plugin):
-    (package_plugin / "manager.py").write_text(
-        "from providers.feed import VERSION\nraise RuntimeError('broken')\n",
-        encoding="utf-8")
-    loader = PluginLoader()
-
-    with pytest.raises(RuntimeError):
-        loader.load_module("pkgdemo", package_plugin, "manager.py")
-
-    assert not [k for k in sys.modules if k.startswith("providers")]
-
-
-def test_unload_leaves_packages_from_outside_the_plugin_alone(package_plugin, tmp_path):
-    # A library the plugin imports is not the plugin's to drop.
-    lib_root = tmp_path / "site"
-    (lib_root / "extlib").mkdir(parents=True)
-    (lib_root / "extlib" / "__init__.py").write_text("", encoding="utf-8")
-    (lib_root / "extlib" / "sub.py").write_text("X = 1\n", encoding="utf-8")
-    sys.path.append(str(lib_root))
-    (package_plugin / "manager.py").write_text(
-        "import extlib.sub\nfrom providers.feed import VERSION\n", encoding="utf-8")
-    loader = PluginLoader()
-    loader.load_module("pkgdemo", package_plugin, "manager.py")
-
-    _unload(loader, "pkgdemo")
-
-    assert "extlib.sub" in sys.modules
-    assert "extlib" in sys.modules

test/test_plugin_loader_symlinked_dir.py

@@ -1,81 +0,0 @@
-"""A dev plugin linked in under a name its checkout does not share still loads.
-
-``scripts/dev/dev_plugin_setup.sh`` links a checkout into the plugins
-directory under the plugin's id: ``link-github foo <url>`` clones
-``ledmatrix-foo`` (the repository naming convention) and links it as
-``plugins/foo``. ``contained_plugin_dir`` resolved the link and looked for the
-*target's* folder name, ``ledmatrix-foo``, among the plugins directory's
-entries. There is none, so ``install_dependencies`` refused the plugin as
-outside the plugins directory and the load failed with "Dependency
-installation failed" -- even with no requirements.txt at all.
-
-The containment it exists for still holds: the answer is always rebuilt from
-an entry enumerated under the plugins directory.
-
-Skipped where this process cannot create a symlink (Windows without the
-privilege).
-"""
-
-import os
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from src.plugin_system.plugin_loader import PluginLoader, contained_plugin_dir
-
-
-def _symlink_or_skip(target, link):
-    try:
-        os.symlink(target, link, target_is_directory=True)
-    except (OSError, NotImplementedError) as e:
-        pytest.skip(f"cannot create a symlink here: {e}")
-
-
-@pytest.fixture
-def linked(tmp_path):
-    checkout = tmp_path / "dev-plugins" / "ledmatrix-foo"
-    checkout.mkdir(parents=True)
-    plugins_dir = tmp_path / "plugins"
-    plugins_dir.mkdir()
-    link = plugins_dir / "foo"
-    _symlink_or_skip(checkout, link)
-    return plugins_dir, link, checkout
-
-
-def test_a_link_resolves_to_its_own_entry_in_the_plugins_dir(linked):
-    plugins_dir, link, _checkout = linked
-
-    assert contained_plugin_dir(link, plugins_dir) == os.path.join(
-        os.path.realpath(plugins_dir), "foo")
-
-
-def test_a_linked_plugin_without_requirements_needs_no_install(linked):
-    plugins_dir, link, _checkout = linked
-
-    with patch("subprocess.run") as pip:
-        assert PluginLoader().install_dependencies(link, "foo", plugins_dir=plugins_dir) is True
-    pip.assert_not_called()
-
-
-@patch("src.plugin_system.plugin_loader.requirements_are_satisfied", return_value=False)
-def test_a_linked_plugins_requirements_are_installed_through_the_link(_satisfied, linked):
-    plugins_dir, link, checkout = linked
-    (checkout / "requirements.txt").write_text("package1==1.0.0\n", encoding="utf-8")
-
-    with patch("subprocess.run", return_value=MagicMock(returncode=0, stderr="")) as pip:
-        assert PluginLoader().install_dependencies(link, "foo", plugins_dir=plugins_dir) is True
-
-    argv = pip.call_args[0][0]
-    assert argv[argv.index("-r") + 1] == os.path.join(
-        os.path.realpath(plugins_dir), "foo", "requirements.txt")
-
-
-def test_a_link_outside_the_plugins_dir_is_still_refused(linked, tmp_path):
-    plugins_dir, _link, checkout = linked
-    elsewhere = tmp_path / "elsewhere"
-    elsewhere.mkdir()
-    stray = elsewhere / "bar"
-    _symlink_or_skip(checkout, stray)
-
-    assert contained_plugin_dir(stray, plugins_dir) is None
-    assert contained_plugin_dir(plugins_dir / ".." / "elsewhere" / "bar", plugins_dir) is None

test/test_plugin_system.py

@@ -189,24 +189,6 @@ class TestPluginExecutor:
         
         assert result is False
 
-    def test_a_base_exception_is_a_failure_not_a_timeout(self):
-        """asyncio.CancelledError derives from BaseException. Uncaught on
-        the executor's thread it ended the thread with the call never marked
-        complete, so a call that failed at once was reported, and recorded,
-        as timing out."""
-        import asyncio
-        import pytest
-        from src.exceptions import PluginError
-        from src.plugin_system.plugin_executor import PluginExecutor
-        executor = PluginExecutor(default_timeout=5.0)
-
-        def cancelled():
-            raise asyncio.CancelledError()
-
-        with pytest.raises(PluginError) as raised:
-            executor.execute_with_timeout(cancelled, plugin_id="test_plugin")
-        assert isinstance(raised.value.__cause__, asyncio.CancelledError)
-
 
 class TestPluginHealth:
     """Test plugin health monitoring."""

test/test_scroll_helper_narrow_strip.py

@@ -1,112 +0,0 @@
-"""
-ScrollHelper frames for a strip narrower than the panel, and other wraps.
-
-A frame that runs past the end of the strip continues from its head: column
-j of the frame is strip column (position + j) modulo the strip's width. The
-wrap path sliced the strip's tail and then "the rest of the frame" from its
-head, which assumed the head was at least that wide. For a strip narrower
-than the panel it raised ValueError at every position, so a narrow strip
-(Vegas composes one when its content is narrower than the chain, with its
-lead-in of 0) logged a traceback every frame instead of drawing.
-"""
-
-import numpy as np
-import pytest
-from PIL import Image
-
-from src.common.scroll_helper import ScrollHelper
-
-W, H = 128, 32
-
-
-def _strip(width, height=H):
-    """A strip whose every column is distinct: R and B are the column number."""
-    columns = np.arange(width)
-    pixels = np.zeros((height, width, 3), dtype=np.uint8)
-    pixels[:, :, 0] = columns % 256
-    pixels[:, :, 1] = 255 - (columns % 256)
-    pixels[:, :, 2] = columns // 256
-    return Image.fromarray(pixels, 'RGB')
-
-
-def _helper(strip_width, sub_pixel=False):
-    sh = ScrollHelper(W, H)
-    sh.set_scrolling_image(_strip(strip_width))
-    sh.sub_pixel_scrolling = sub_pixel
-    return sh
-
-
-def _frame(sh, position):
-    sh.scroll_position = position
-    frame = sh.get_visible_portion()
-    assert frame is not None and frame.size == (W, H) and frame.mode == 'RGB'
-    return np.asarray(frame)
-
-
-def _wrapped(sh, start):
-    """What the panel should show from ``start``: the strip, wrapping."""
-    return sh.cached_array[:, np.arange(start, start + W) % sh.cached_array.shape[1]]
-
-
-class TestNarrowStrip:
-    @pytest.mark.parametrize('strip_width', [1, 40, 50, W - 1])
-    @pytest.mark.parametrize('position', [0, 10, 39])
-    def test_frame_repeats_the_strip_across_the_panel(self, strip_width, position):
-        sh = _helper(strip_width)
-        position %= strip_width
-        assert np.array_equal(_frame(sh, position), _wrapped(sh, position))
-
-    def test_a_composed_strip_without_lead_in(self):
-        # How Vegas builds its strip: lead_gap=0 (vegas_scroll.lead_in_width).
-        sh = ScrollHelper(W, H)
-        sh.create_scrolling_image([_strip(40)], item_gap=0, element_gap=0, lead_gap=0)
-        assert sh.total_scroll_width == 40
-        for position in range(40):
-            assert np.array_equal(_frame(sh, position), _wrapped(sh, position))
-
-    def test_a_whole_pass_scrolls_without_raising(self):
-        sh = _helper(50)
-        sh.set_pixels_per_frame(3)
-        for _ in range(60):
-            sh.update_scroll_position()
-            assert sh.get_visible_portion().size == (W, H)
-
-    @pytest.mark.parametrize('position', [0.5, 10.25, 49.5])
-    def test_sub_pixel_blend_of_a_narrow_strip(self, position):
-        sh = _helper(50, sub_pixel=True)
-        frame = _frame(sh, position)
-        start = int(position)
-        near, far = _wrapped(sh, start), _wrapped(sh, start + 1)
-        lo, hi = np.minimum(near, far), np.maximum(near, far)
-        assert (frame >= lo).all() and (frame <= hi).all()
-
-
-class TestWrapOfAWideStrip:
-    """Unchanged: the tail, then the head."""
-
-    @pytest.mark.parametrize('position', [200 - W + 1, 150, 199])
-    def test_tail_then_head(self, position):
-        sh = _helper(200)
-        frame = _frame(sh, position)
-        tail = 200 - position
-        assert np.array_equal(frame[:, :tail], sh.cached_array[:, position:])
-        assert np.array_equal(frame[:, tail:], sh.cached_array[:, :W - tail])
-
-    def test_at_the_end_shows_the_head(self):
-        sh = _helper(200)
-        assert np.array_equal(_frame(sh, 200), sh.cached_array[:, :W])
-
-    def test_sub_pixel_at_the_last_column(self):
-        sh = _helper(200, sub_pixel=True)
-        assert _frame(sh, 199.5).shape == (H, W, 3)
-
-    def test_a_position_before_the_start_wraps_too(self):
-        # Slicing [-10:118] of the array was an empty slice: frombytes raised.
-        sh = _helper(200)
-        assert np.array_equal(_frame(sh, -10), _wrapped(sh, -10))
-
-
-def test_a_zero_width_strip_is_a_black_frame():
-    sh = ScrollHelper(W, H)
-    sh.set_scrolling_image(Image.new('RGB', (0, H)))
-    assert not _frame(sh, 0).any()

test/test_sports_card.py

@@ -13,8 +13,6 @@ body. That is what let all eight adopt this with byte-identical renders.
 import logging
 import json
 import os
-from datetime import datetime, timezone
-from zoneinfo import ZoneInfo
 
 import pytest
 
@@ -171,95 +169,6 @@ class TestDateAndTime:
         assert C.card_tzinfo({"timezone": "Not/AZone"}, log) is timezone.utc
 
 
-class TestWeekdayMatchesThePrintedDate:
-    """The weekday is the printed date's, whichever zone printed it.
-
-    The extractor prints "M/D" in the plugin's resolved zone (its own
-    setting, else the global one, else the system zone). The card is handed
-    only the plugin's config, whose ``timezone`` ships as "" -- so a weekday
-    taken in card_tzinfo's zone was UTC's, and an evening kickoff in the
-    Americas read "Sat Oct 2" for a Friday game.
-    """
-
-    WEEKDAY = {"timezone": "", "scroll_card": {"date_format": "weekday"}}
-
-    @staticmethod
-    def _as_printed(start_utc, zone):
-        """The game dict and the date text, as the extractor builds them."""
-        local = datetime.fromisoformat(start_utc).astimezone(ZoneInfo(zone))
-        game = {"start_time_utc": datetime.fromisoformat(start_utc),
-                "game_date": f"{local.month}/{local.day}"}
-        want = f"{C.WEEKDAY_ABBR[local.weekday()]} {C.MONTH_ABBR[local.month - 1]} {local.day}"
-        return game, want
-
-    @pytest.mark.parametrize("start_utc, zone, want", [
-        # Friday 8 PM EDT is Saturday in UTC.
-        ("2026-10-03T00:00:00+00:00", "America/New_York", "Fri Oct 2"),
-        # The night US clocks go back: 8:30 PM EDT Saturday, then 11 PM EST
-        # Sunday, each the next day in UTC.
-        ("2026-11-01T00:30:00+00:00", "America/New_York", "Sat Oct 31"),
-        ("2026-11-02T04:00:00+00:00", "America/New_York", "Sun Nov 1"),
-        # New Year's Eve on the west coast is New Year's Day in UTC.
-        ("2027-01-01T04:00:00+00:00", "America/Los_Angeles", "Thu Dec 31"),
-        # Just east of the date line: Pago Pago's Friday evening.
-        ("2026-10-03T05:00:00+00:00", "Pacific/Pago_Pago", "Fri Oct 2"),
-        # Just west of it, the other way: Saturday morning in Auckland is
-        # Friday in UTC -- and the 10 AM game on the day NZ clocks go forward.
-        ("2026-10-02T20:00:00+00:00", "Pacific/Auckland", "Sat Oct 3"),
-        ("2026-09-26T21:00:00+00:00", "Pacific/Auckland", "Sun Sep 27"),
-        # UTC+14, the furthest any zone sits from UTC.
-        ("2026-10-02T11:00:00+00:00", "Pacific/Kiritimati", "Sat Oct 3"),
-        # A zone on UTC's own date needs nothing.
-        ("2026-10-02T19:00:00+00:00", "Europe/London", "Fri Oct 2"),
-    ])
-    def test_the_shipped_blank_timezone(self, log, start_utc, zone, want):
-        game, printed = self._as_printed(start_utc, zone)
-        assert printed == want  # the case says what the extractor prints
-        assert C.format_game_date(self.WEEKDAY, log, game["game_date"], game) == want
-
-    def test_an_iso_string_start_reads_the_same(self, log):
-        game = {"start_time_utc": "2026-10-03T00:00:00Z"}
-        assert C.format_game_date(self.WEEKDAY, log, "10/2", game) == "Fri Oct 2"
-        assert C.format_game_date(self.WEEKDAY, log, "10/02", game) == "Fri Oct 2"
-
-    def test_a_plugin_level_zone_still_agrees(self, log):
-        game, want = self._as_printed("2026-10-03T00:00:00+00:00", "America/Chicago")
-        cfg = dict(self.WEEKDAY, timezone="America/Chicago")
-        assert C.format_game_date(cfg, log, game["game_date"], game) == want == "Fri Oct 2"
-
-    def test_a_date_no_zone_could_print_keeps_the_zone_weekday(self, log):
-        """More than a day from the start: nothing to anchor to, so the
-        weekday is card_tzinfo's, as it always was."""
-        game = {"start_time_utc": datetime(2026, 10, 3, 0, 0, tzinfo=timezone.utc)}
-        assert C.format_game_date(self.WEEKDAY, log, "10/9", game) == "Sat Oct 9"
-
-    def test_a_start_without_an_offset_keeps_the_zone_weekday(self, log):
-        """A naive time names no instant, so it cannot place the date."""
-        game = {"start_time_utc": datetime(2026, 10, 2, 20, 0)}
-        assert C.format_game_date(self.WEEKDAY, log, "10/3", game) == \
-            f"{C.weekday_for(self.WEEKDAY, log, game)} Oct 3"
-
-    @pytest.mark.parametrize("game", [None, {}, {"start_time_utc": "garbage"}])
-    def test_no_usable_start_draws_no_weekday(self, log, game):
-        assert C.format_game_date(self.WEEKDAY, log, "10/2", game) == "Oct 2"
-
-    def test_the_scorebug_twin_formats_the_same(self, log):
-        """Switch mode (SportsCoreSharedMixin) shares the formatter body."""
-        from src.common.sports_shared import SportsCoreSharedMixin
-
-        class Host(SportsCoreSharedMixin):
-            config = {"scroll_card": {"date_format": "weekday",
-                                      "switch_date_format": "inherit"}}
-            logger = log
-
-            def _get_timezone(self):
-                return ZoneInfo("America/New_York")
-
-        game, want = self._as_printed("2026-11-01T00:30:00+00:00", "America/New_York")
-        assert Host()._format_game_date(game["game_date"], game) == want
-        assert C.format_game_date(Host.config, log, game["game_date"], game) == want
-
-
 class TestFontSizing:
     def test_snaps_to_the_faces_pixel_grid(self):
         assert C.crisp_size("4x6-font.ttf", 6) == 7        # 7px grid

test/test_sports_twins.py

@@ -561,24 +561,21 @@ class TestPinnedDivergence:
         assert C.recent_score_color(on, LOG, game, (9, 9, 9)) == (9, 9, 9)
 
     def test_weekday_zone_source(self):
-        # DIVERGENCE, not drawn: the scorebug asks the plugin's
+        # DIVERGENCE, user-visible: the scorebug asks the plugin's
         # _get_timezone() (plugin setting -> global setting -> system zone);
         # the card reads only config["timezone"] and falls back to UTC. The
         # scoreboards' schemas default that key to "", and the scroll display
-        # hands the renderer the plugin config, so the bare weekday helpers
-        # still disagree for an evening kickoff in New York.
+        # hands the renderer the plugin config, so a board that sets only the
+        # global zone gets UTC weekdays in scroll mode: an evening kickoff in
+        # New York is labelled with the next day.
         game = {"start_time_utc": "2026-09-20T00:30:00+00:00"}  # Sat 20:30 EDT
         host = _Host({}, tz=ZoneInfo("America/New_York"))
         assert host._weekday_for(game) == "Sat"
         assert C.weekday_for({}, LOG, game) == "Sun"
-        # DECIDED: what a card draws is the printed date's own weekday, so
-        # the scroll card no longer labels that kickoff with the next day
-        # ("Sun Sep 19" before). Both formatters place the extractor's "M/D"
-        # against the start time instead of re-deriving the day in a zone.
         cfg = {"scroll_card": {"date_format": "weekday", "switch_date_format": "inherit"}}
         host = _Host(cfg, tz=ZoneInfo("America/New_York"))
         assert host._format_game_date("9/19", game) == "Sat Sep 19"
-        assert C.format_game_date(cfg, LOG, "9/19", game) == "Sat Sep 19"
+        assert C.format_game_date(cfg, LOG, "9/19", game) == "Sun Sep 19"
 
     def test_weekday_out_of_range_start(self):
         # DIVERGENCE: the mixin catches OverflowError from astimezone() and

test/test_state_stream_readers.py

@@ -612,6 +612,12 @@ class TestEndToEnd:
         cached['display_current_state'] = {'mode': 'from-cache', 'last_updated': 1}
         path = str(tmp_path / 'control.sock')
         monkeypatch.setenv(c.SOCKET_PATH_ENV, path)
+        # The display is this process, and its render loop is beating: the
+        # cache is then still its answer once the socket goes.
+        heartbeat = tmp_path / 'display-heartbeat.json'
+        heartbeat.write_text(json.dumps({'pid': os.getpid(), 'mono': time.monotonic(),
+                                         'wall': time.time()}))
+        monkeypatch.setattr(display_watchdog, 'HEARTBEAT_PATH', str(heartbeat))
         hub = _hub_with_everything()
         server = ControlServer(path, state_hub=hub, keepalive=0.2)
         assert server.start()
@@ -638,3 +644,8 @@ class TestEndToEnd:
                 break
             time.sleep(0.05)
         assert (data['mode'], data['source']) == ('from-cache', 'cache')
+        # Stopped: systemd takes the heartbeat's directory with it, and the
+        # cache's last answer is no longer anyone's.
+        heartbeat.unlink()
+        data = _data(client, '/api/v3/display/current-status')
+        assert (data['mode'], data['source']) == (None, 'cache')

test/test_store_symlinked_plugin.py

@@ -1,90 +0,0 @@
-"""Removing a dev plugin linked into the plugins directory removes the link.
-
-``scripts/dev/dev_plugin_setup.sh`` symlinks a checkout into the plugins
-directory. ``PluginStoreManager._safe_remove_directory`` -- behind uninstall,
-and behind discarding the set-aside copy after an install or update -- handed
-the link to ``shutil.rmtree``, which refuses a symlink. Its fallback then
-walked through the link and chmodded every directory and file of the linked
-checkout to 0700, and the sudo stage refused a path outside the plugins
-directory. So the uninstall failed, the link stayed, and the developer's
-checkout lost its group/other permissions and gained execute bits.
-
-Skipped where this process cannot create a symlink (Windows without the
-privilege).
-"""
-
-import json
-import os
-from unittest.mock import MagicMock
-
-import pytest
-
-from src.plugin_system.store_manager import PluginStoreManager
-
-PLUGIN_ID = "linked-demo"
-
-
-def _symlink_or_skip(target, link):
-    try:
-        os.symlink(target, link, target_is_directory=True)
-    except (OSError, NotImplementedError) as e:
-        pytest.skip(f"cannot create a symlink here: {e}")
-
-
-@pytest.fixture
-def linked(tmp_path):
-    checkout = tmp_path / "dev-plugins" / PLUGIN_ID
-    checkout.mkdir(parents=True)
-    (checkout / "manifest.json").write_text(
-        json.dumps({"id": PLUGIN_ID, "name": "Linked", "class_name": "P",
-                    "display_modes": ["linked"], "version": "1.0.0"}),
-        encoding="utf-8")
-    (checkout / "manager.py").write_text("X = 1\n", encoding="utf-8")
-    plugins_dir = tmp_path / "plugins"
-    plugins_dir.mkdir()
-    link = plugins_dir / PLUGIN_ID
-    _symlink_or_skip(checkout, link)
-    store = PluginStoreManager(plugins_dir=str(plugins_dir))
-    store.logger = MagicMock()
-    return store, link, checkout
-
-
-def test_removing_a_linked_plugin_removes_only_the_link(linked):
-    store, link, checkout = linked
-
-    assert store._safe_remove_directory(link) is True
-
-    assert not os.path.lexists(link)
-    assert (checkout / "manager.py").read_text(encoding="utf-8") == "X = 1\n"
-
-
-@pytest.mark.skipif(os.name != "posix", reason="POSIX permission bits")
-def test_removing_a_linked_plugin_leaves_the_checkouts_permissions(linked):
-    store, link, checkout = linked
-    os.chmod(checkout, 0o755)
-    os.chmod(checkout / "manager.py", 0o644)
-
-    store._safe_remove_directory(link)
-
-    assert checkout.stat().st_mode & 0o777 == 0o755
-    assert (checkout / "manager.py").stat().st_mode & 0o777 == 0o644
-
-
-def test_uninstalling_a_linked_plugin_removes_the_link(linked):
-    store, link, checkout = linked
-
-    assert store.uninstall_plugin(PLUGIN_ID) is True
-
-    assert not os.path.lexists(link)
-    assert (checkout / "manifest.json").exists()
-
-
-def test_a_dangling_link_is_removed_too(linked):
-    store, link, checkout = linked
-    for child in checkout.iterdir():
-        child.unlink()
-    checkout.rmdir()
-
-    assert store._safe_remove_directory(link) is True
-
-    assert not os.path.lexists(link)

test/web_interface/test_web_process_runs_no_plugin_code.py

@@ -221,7 +221,9 @@ class TestTheWebProcessNeverRunsAPlugin:
     def test_saving_its_section_through_the_main_config(self, web):
         body = web.post("/api/v3/config/main", {PLUGIN_ID: {"message": "via main"}})
         assert web.stored()["message"] == "via main"
-        assert body["restart_required"] is True
+        # The display's config watcher hands the section to the running
+        # plugin (on_config_change), as for /plugins/config: no restart.
+        assert body["restart_required"] is False
         assert web.ran() == []
 
     def test_resetting_its_config(self, web):

web_interface/blueprints/api_v3/config.py

@@ -17,6 +17,8 @@ from src.pi5_matrix_support import is_raspberry_pi_5
 from web_interface.cache import invalidate_cache
 from web_interface.auth import SECTION as _WEB_AUTH_SECTION, strip_auth_section
 import web_interface.blueprints.api_v3 as _pkg
+import copy
+from typing import Any, Dict, Iterable, Tuple
 
 # Read through the module rather than bound by value: tests patch these
 # as module attributes, and a value binding would not see the patch.
@@ -33,6 +35,50 @@ FORM_SECTION_FIELD = '__form_section'
 GENERAL_FIELDS = ('timezone', 'city', 'state', 'country', 'web_display_autostart',
                   'plugins_directory', 'auto_update_enabled', 'auto_update_channel')
 
+#: Settings in config.json the running display applies without a restart,
+#: as key paths (a path covers everything under it). Brightness goes over the
+#: control socket (brightness.set) and the config watcher's refresh
+#: (DisplayController._refresh_config_cache); the per-mode durations are read
+#: from the live config each time a mode starts (_get_display_duration).
+#: Plugin sections are live as well (each plugin's on_config_change), and
+#: save_main_config adds the ones a request saves.
+LIVE_CONFIG_PATHS: Tuple[Tuple[str, ...], ...] = (
+    ('display', 'hardware', 'brightness'),
+    ('display', 'display_durations'),
+)
+
+
+_MISSING = object()
+
+
+def _config_leaves(config: Any, prefix: Tuple[str, ...] = ()) -> Dict[Tuple[str, ...], Any]:
+    """Every non-dict value in ``config``, by key path. An empty dict has none,
+    so a section created empty on the way to a field is not a change."""
+    if not isinstance(config, dict):
+        return {prefix: config}
+    leaves: Dict[Tuple[str, ...], Any] = {}
+    for key, value in config.items():
+        leaves.update(_config_leaves(value, prefix + (str(key),)))
+    return leaves
+
+
+def restart_needed(before: Dict[str, Any], after: Dict[str, Any],
+                   live_paths: Iterable[Tuple[str, ...]] = LIVE_CONFIG_PATHS) -> bool:
+    """Does going from config ``before`` to ``after`` need a display restart?
+
+    True when anything changed outside ``live_paths``. A save that changes
+    only live settings, or nothing at all, does not.
+    """
+    live = tuple(live_paths)
+    old, new = _config_leaves(before), _config_leaves(after)
+    for path in set(old) | set(new):
+        if old.get(path, _MISSING) == new.get(path, _MISSING):
+            continue
+        if not any(path[:len(prefix)] == prefix for prefix in live):
+            return True
+    return False
+
+
 #: Top-level fields save_main_config stores somewhere of its own (location,
 #: plugin_system, ...), never as a config key of the same name.
 _MAPPED_TOP_LEVEL_FIELDS = GENERAL_FIELDS + (
@@ -72,6 +118,22 @@ def _day_setting(data, day, flat_key, nested_key):
     return False, None
 
 
+def _disabled_day_times(data, day, start_key, end_key):
+    """The times posted for a day that is off, the valid ones.
+
+    Nothing reads them while the day is off, but the schedule picker posts
+    them and GET returns them, so keeping them means turning the day back on
+    finds what was there. An invalid one is dropped rather than refused, for
+    the same reason.
+    """
+    times = {}
+    for field, key in (('start_time', start_key), ('end_time', end_key)):
+        value = _day_setting(data, day, key, field)[1]
+        if value and _validate_time_format(value)[0]:
+            times[field] = value
+    return times
+
+
 @api_v3.route('/config/main', methods=['GET'])
 def get_main_config():
     """Get main configuration, with credentials redacted."""
@@ -257,11 +319,16 @@ def save_schedule_config():
 
                     day_config['start_time'] = start_time
                     day_config['end_time'] = end_time
+                else:
+                    day_config.update(_disabled_day_times(data, day, start_key, end_key))
 
                 schedule_config['days'][day] = day_config
 
-            # Validate that at least one day is enabled in per-day mode
-            if enabled_days_count == 0:
+            # An enabled per-day schedule needs a day to be on. A disabled
+            # one does not: every day off with the schedule off is what
+            # config.template.json ships, so refusing it meant a fresh
+            # install could not post back the schedule GET returned.
+            if enabled_days_count == 0 and enabled_value:
                 return error_response(
                     ErrorCode.VALIDATION_ERROR,
                     "At least one day must be enabled in per-day schedule mode",
@@ -465,11 +532,13 @@ def save_dim_schedule_config():
 
                     day_config['start_time'] = start_time
                     day_config['end_time'] = end_time
+                else:
+                    day_config.update(_disabled_day_times(data, day, start_key, end_key))
 
                 dim_schedule_config['days'][day] = day_config
 
-            # Validate that at least one day is enabled in per-day mode
-            if enabled_days_count == 0:
+            # As for the on/off schedule: only an enabled one needs a day on.
+            if enabled_days_count == 0 and enabled_value:
                 return error_response(
                     ErrorCode.VALIDATION_ERROR,
                     "At least one day must be enabled in per-day dim schedule mode",
@@ -553,6 +622,8 @@ def save_main_config():
 
         # Merge with existing config (similar to original implementation)
         current_config = api_v3.config_manager.load_config()
+        # What was stored, to tell which settings this save changed.
+        stored_config = copy.deepcopy(current_config)
         was_auto_update_enabled = bool((current_config.get('auto_update') or {}).get('enabled'))
 
         is_general_update = any(k in data for k in GENERAL_FIELDS)
@@ -1190,13 +1261,15 @@ def save_main_config():
                 message = f'{message}. {note}'
         except Exception:
             logger.warning("Automatic update setup could not be started", exc_info=True)
-        # Display hardware, rotation/durations and general settings take
-        # effect after a display restart; the UI shows its restart banner on
-        # this flag.
-        extra = {'restart_required': True}
-        # Brightness is the exception: the display applies a saved one
-        # without a restart. Over the control socket it lands at once,
-        # instead of when the config watcher next looks (up to ~2 s).
+        # Display hardware, rotation order and general settings take effect
+        # after a display restart; the UI shows its restart banner on this
+        # flag. Brightness, mode durations and plugin settings are applied by
+        # the running display (LIVE_CONFIG_PATHS), so a save that changed
+        # only those -- or nothing -- does not ask for one.
+        live_paths = LIVE_CONFIG_PATHS + tuple((plugin_id,) for plugin_id in plugin_keys_to_remove)
+        extra = {'restart_required': restart_needed(stored_config, current_config, live_paths)}
+        # Over the control socket a saved brightness lands at once, instead
+        # of when the config watcher next looks (up to ~2 s).
         if 'brightness' in data:
             saved = (current_config.get('display', {}).get('hardware', {}) or {}).get('brightness')
             if isinstance(saved, int) and not isinstance(saved, bool):

web_interface/blueprints/api_v3/display.py

@@ -340,15 +340,22 @@ def get_current_display_status():
     Read from the display's state stream over the control socket when it is
     available (``source: "socket"``). Otherwise from what the display
     publishes to the shared cache (display_controller._publish_current_mode_state)
-    when the active mode changes (``source: "cache"``).
+    when the active mode changes (``source: "cache"``). Unknown (every field
+    None) when the socket and the heartbeat both say the display is gone
+    (display_state.display_gone).
     """
-    state = display_state.current_status(display_state.read_state())
+    snapshot = display_state.read_state()
+    state = display_state.current_status(snapshot)
     source = 'socket'
     if state is None:
         source = 'cache'
-        cache = _cache_manager()
-        # memory_ttl=0: written by the display service; see get_on_demand_status.
-        state = cache.get('display_current_state', max_age=120, memory_ttl=0)
+        # A stopped display leaves its last answer in the cache, where it
+        # read as on (is_display_active: true) for the 120 s max_age. With
+        # no socket and no live heartbeat there is no display behind it.
+        if not display_state.display_gone(snapshot):
+            cache = _cache_manager()
+            # memory_ttl=0: written by the display service; see get_on_demand_status.
+            state = cache.get('display_current_state', max_age=120, memory_ttl=0)
     if state is None:
         state = {
             'mode': None,

web_interface/blueprints/api_v3/misc.py

@@ -102,6 +102,7 @@ def get_health():
         # the only signal, as it always was.
         # The display reports the same beat's age over the control socket's
         # state stream, measured in memory; the file is the fallback.
+        snapshot = None
         try:
             snapshot = display_state.read_state()
             if snapshot is not None:
@@ -132,6 +133,26 @@ def get_health():
                 'error': 'see logs for details'
             }
 
+        # A stopped display service. The heartbeat's absence alone says
+        # nothing (the dev server, the emulator and Windows write none), so
+        # the overall status stayed "healthy" with the display down until the
+        # last preview frame it left aged past 60 s (hardware: stale). Together
+        # the three signals are definite: systemd says the service is not
+        # active, the control socket does not answer, and there is no live
+        # heartbeat (display_state.display_gone, which is never true where
+        # the platform has no socket or it is switched off).
+        try:
+            if (not display_service_status.get('active')
+                    and display_state.display_gone(snapshot)):
+                health_status['checks']['display_loop'] = {
+                    'status': 'stopped',
+                    'note': 'The display service is not running',
+                    'source': 'service',
+                }
+        except Exception:
+            logger.warning("Health check could not tell whether the display is stopped",
+                           exc_info=True)
+
         # Check hardware connectivity (if display manager available)
         try:
             snapshot_path = display_preview.SNAPSHOT_PATH

web_interface/blueprints/api_v3/plugin_store.py

@@ -42,29 +42,6 @@ def _store_incompatibility(plugin: dict) -> Optional[str]:
     return reason if isinstance(reason, str) and reason else None
 
 
-def _installed_plugin_id(plugin_id: str) -> str:
-    """The id the plugin installed for store entry ``plugin_id`` declares.
-
-    A registry entry can install under another id: ``weather`` installs a
-    directory whose manifest says ``ledmatrix-weather``, and that is the id
-    the plugin list, the config section and /plugins/toggle know it by. The
-    install is found the way the store's update and uninstall find it (the
-    entry's id, ``aliases`` and ``plugin_path`` name); ``plugin_id`` itself
-    when its manifest can't be read.
-    """
-    try:
-        plugin_dir = api_v3.plugin_store_manager._find_plugin_path(plugin_id)
-        manifest_path = (resolve_under(plugin_dir, 'manifest.json')
-                         if isinstance(plugin_dir, Path) else None)
-        if manifest_path is None or not manifest_path.is_file():
-            return plugin_id
-        with open(manifest_path, 'r', encoding='utf-8') as f:
-            manifest_id = json.load(f).get('id')
-    except Exception:  # noqa: BLE001 - only names the install for the client
-        return plugin_id
-    return manifest_id if isinstance(manifest_id, str) and safe_path_component(manifest_id) else plugin_id
-
-
 def _listed_plugin_dir(base: Path, name: str) -> Optional[Path]:
     """The entry of ``base`` called ``name``, or None.
 
@@ -510,10 +487,8 @@ def install_plugin():
                     )
 
                 branch_msg = f" (branch: {branch})" if branch else ""
-                # plugin_id: the id to enable it by (see _installed_plugin_id).
                 return {'success': True,
                         'message': f'Plugin {plugin_id} installed successfully{branch_msg}',
-                        'plugin_id': _installed_plugin_id(plugin_id),
                         **_store_restart_fields('install', _plugin_enabled_in_config(plugin_id))}
             else:
                 error_msg = f'Failed to install plugin {plugin_id}'
@@ -571,8 +546,7 @@ def install_plugin():
             branch_msg = f" (branch: {branch})" if branch else ""
             return success_response(
                 message=f'Plugin installed successfully{branch_msg}',
-                extra={'plugin_id': _installed_plugin_id(plugin_id),
-                       **_store_restart_fields('install', _plugin_enabled_in_config(plugin_id))})
+                extra=_store_restart_fields('install', _plugin_enabled_in_config(plugin_id)))
         else:
             error_msg = f'Failed to install plugin {plugin_id}'
             if branch:

web_interface/blueprints/api_v3/plugins.py

@@ -145,14 +145,6 @@ def get_installed_plugins():
         vegas_participation, vegas_participation_source = _vegas_participation(
             plugin_id, plugin_config, plugin_info)
 
-        # The modes the manifest declares, from the catalog as /display/modes
-        # and on-demand/start read them. The on-demand modal offers these;
-        # without them it offered only the plugin id, which the display
-        # turns into the first mode. Strings only: a manifest is hand-edited.
-        declared_modes = api_v3.plugin_catalog.get_plugin_display_modes(plugin_id)
-        display_modes = ([m for m in declared_modes if isinstance(m, str)]
-                         if isinstance(declared_modes, list) else [])
-
         return {
             'id': plugin_id,
             'name': plugin_info.get('name', plugin_id),
@@ -166,7 +158,6 @@ def get_installed_plugins():
             # The tab nav uses this as the <i> element's Font Awesome class
             # (app-shell.js / app-early.js); only a string can be one.
             'icon': plugin_info.get('icon') if isinstance(plugin_info.get('icon'), str) else None,
-            'display_modes': display_modes,
             'enabled': enabled,
             'verified': verified,
             # loaded, state, error_info, loaded_version, loaded_at: the

web_interface/display_state.py

@@ -133,6 +133,39 @@ def on_demand_state(snapshot: Optional[Dict[str, Any]],
     return state
 
 
+def display_gone(snapshot: Optional[Dict[str, Any]]) -> bool:
+    """Is there positively no display behind a fallback to the cache?
+
+    True only when the socket should be there (this platform has one and it
+    is not switched off) but gave no ``snapshot``, and the render loop's
+    heartbeat file says nothing is running either: it is absent (systemd
+    removes its directory when the service stops), stale, or written by a
+    process that no longer exists -- #726's rules for the runtime snapshot.
+    Then what the display last left in the cache is a dead process's answer.
+
+    False whenever the answer is in doubt: a snapshot came in, the socket is
+    off or unsupported (Windows, the test suite, a deliberate ``off``), or a
+    live heartbeat says the display is running without a socket (an older
+    display). Those read the cache exactly as before.
+    """
+    if snapshot is not None:
+        return False
+    if not socket_supported() or not client_socket_paths():
+        return False
+    from src import display_watchdog
+    from src.plugin_system.plugin_runtime import process_exists
+    heartbeat = display_watchdog.read_heartbeat(display_watchdog.HEARTBEAT_PATH)
+    if heartbeat is None:
+        return True
+    age = display_watchdog.heartbeat_age(heartbeat)
+    if age is None or age >= display_watchdog.HEARTBEAT_STALE_SECONDS:
+        return True
+    pid = heartbeat.get('pid')
+    if isinstance(pid, int) and not isinstance(pid, bool) and process_exists(pid) is False:
+        return True
+    return False
+
+
 def loop_heartbeat_age(snapshot: Optional[Dict[str, Any]]) -> Optional[float]:
     """The render loop's heartbeat age now; None when the display has no
     beat to report yet (or there is no snapshot)."""
@@ -141,5 +174,5 @@ def loop_heartbeat_age(snapshot: Optional[Dict[str, Any]]) -> Optional[float]:
     return control_client.snapshot_loop_age(snapshot)
 
 
-__all__ = ['current_status', 'loop_heartbeat_age', 'on_demand_state', 'read_state',
-           'stop_subscription']
+__all__ = ['current_status', 'display_gone', 'loop_heartbeat_age', 'on_demand_state',
+           'read_state', 'stop_subscription']

web_interface/static/v3/js/plugins/install_manager.js

@@ -48,15 +48,12 @@ const PluginInstallManager = {
      * @returns {Promise<Array>} Update results, one per plugin sent
      */
     async updateAll(onProgress, options = {}) {
-        // window.installedPlugins is the live list: plugins_manager.js
-        // republishes it after every install, uninstall and refresh.
-        // PluginStateManager's copy is written only by the refresh at the end
-        // of a run, so preferring it sent a second run the first run's
-        // plugins -- an uninstalled one failed, a new one was skipped. It is
-        // the fallback for a page without the plugin manager.
-        const listed = Array.isArray(window.installedPlugins)
-            ? window.installedPlugins
-            : ((window.PluginStateManager && window.PluginStateManager.installedPlugins) || []);
+        // Prefer PluginStateManager if populated, fall back to window.installedPlugins
+        // (plugins_manager.js populates window.installedPlugins independently)
+        const stateManagerPlugins = window.PluginStateManager && window.PluginStateManager.installedPlugins;
+        const listed = (stateManagerPlugins && stateManagerPlugins.length > 0)
+            ? stateManagerPlugins
+            : (window.installedPlugins || []);
         // Snapshot: the list can be replaced while this loop is awaiting.
         const plugins = this.updatablePlugins(listed);
 
@@ -105,18 +102,10 @@ const PluginInstallManager = {
         }
 
         // Reload plugin list once at the end. A failed refresh must not
-        // lose the results: they carry the restart flags. The plugin
-        // manager's load, forced past its caches, also redraws the installed
-        // grid and its Updates badge; PluginStateManager's only replaced
-        // window.installedPlugins, so the cards kept offering "Update to vX"
-        // for what had just been updated.
-        const pluginManager = window.pluginManager;
-        const refresh = (pluginManager && typeof pluginManager.loadInstalledPlugins === 'function')
-            ? () => pluginManager.loadInstalledPlugins(true)
-            : (window.PluginStateManager ? () => window.PluginStateManager.loadInstalledPlugins() : null);
-        if (refresh) {
+        // lose the results: they carry the restart flags.
+        if (window.PluginStateManager) {
             try {
-                await refresh();
+                await window.PluginStateManager.loadInstalledPlugins();
             } catch (error) {
                 console.warn('Could not refresh the installed plugin list after updating:', error);
             }

web_interface/static/v3/plugins_manager.js

@@ -34,8 +34,8 @@
  *
  * Layout: a few handlers defined up front, outside any IIFE, because the
  * cards and other scripts call them through window (configurePlugin,
- * togglePlugin, the GitHub token helpers, checkGitHubAuthStatus); then the
- * plugin-manager IIFE (private state:
+ * togglePlugin, the GitHub token helpers, handleGitHubPluginInstall,
+ * checkGitHubAuthStatus); then the plugin-manager IIFE (private state:
  * installedPlugins, the store cache, the on-demand poller); then the
  * Starlark IIFE.
  *
@@ -386,6 +386,103 @@ window.toggleGithubTokenContent = function(e) {
     }
 };
 
+// Simple standalone handler for GitHub plugin installation
+// Defined early and globally to ensure it's always available
+debugLog('[DEFINE] Defining handleGitHubPluginInstall function...');
+window.handleGitHubPluginInstall = function() {
+    debugLog('[handleGitHubPluginInstall] Function called!');
+
+    const urlInput = document.getElementById('github-plugin-url');
+    const statusDiv = document.getElementById('github-plugin-status');
+    const branchInput = document.getElementById('plugin-branch-input');
+    const installBtn = document.getElementById('install-plugin-from-url');
+
+    if (!urlInput) {
+        console.error('[handleGitHubPluginInstall] URL input not found');
+        alert('Error: Could not find URL input field');
+        return;
+    }
+
+    const repoUrl = urlInput.value.trim();
+    debugLog('[handleGitHubPluginInstall] Repo URL:', repoUrl);
+
+    if (!repoUrl) {
+        if (statusDiv) {
+            statusDiv.innerHTML = '<span class="text-red-600"><i class="fas fa-exclamation-circle mr-1"></i>Please enter a GitHub URL</span>';
+        }
+        return;
+    }
+
+    if (!isGithubUrl(repoUrl)) {
+        if (statusDiv) {
+            statusDiv.innerHTML = '<span class="text-red-600"><i class="fas fa-exclamation-circle mr-1"></i>Please enter a valid GitHub URL</span>';
+        }
+        return;
+    }
+
+    // Disable button and show loading
+    if (installBtn) {
+        installBtn.disabled = true;
+        installBtn.innerHTML = '<i class="fas fa-spinner fa-spin mr-2"></i>Installing...';
+    }
+    if (statusDiv) {
+        statusDiv.innerHTML = '<span class="text-blue-600"><i class="fas fa-spinner fa-spin mr-1"></i>Installing plugin...</span>';
+    }
+
+    const branch = branchInput?.value?.trim() || null;
+    const requestBody = { repo_url: repoUrl };
+    if (branch) {
+        requestBody.branch = branch;
+    }
+
+    debugLog('[handleGitHubPluginInstall] Sending request:', requestBody);
+
+    fetch('/api/v3/plugins/install-from-url', {
+        method: 'POST',
+        headers: {
+            'Content-Type': 'application/json'
+        },
+        body: JSON.stringify(requestBody)
+    })
+    .then(response => {
+        debugLog('[handleGitHubPluginInstall] Response status:', response.status);
+        return response.json();
+    })
+    .then(data => {
+        debugLog('[handleGitHubPluginInstall] Response data:', data);
+        if (data.status === 'success') {
+            if (statusDiv) {
+                statusDiv.innerHTML = `<span class="text-green-600"><i class="fas fa-check-circle mr-1"></i>Successfully installed: ${window.LEDEscape.html(data.plugin_id)}</span>`;
+            }
+            urlInput.value = '';
+
+            showNotification(`Plugin ${data.plugin_id} installed successfully`, 'success');
+            window.noteRestartRequired(data);
+
+            setTimeout(() => window.pluginManager.loadInstalledPlugins(true).catch(() => {}), 1000);
+        } else {
+            if (statusDiv) {
+                statusDiv.innerHTML = `<span class="text-red-600"><i class="fas fa-times-circle mr-1"></i>${window.LEDEscape.html(data.message || 'Installation failed')}</span>`;
+            }
+            showNotification(data.message || 'Installation failed', 'error');
+        }
+    })
+    .catch(error => {
+        console.error('[handleGitHubPluginInstall] Error:', error);
+        if (statusDiv) {
+            statusDiv.innerHTML = `<span class="text-red-600"><i class="fas fa-times-circle mr-1"></i>Error: ${window.LEDEscape.html(error.message)}</span>`;
+        }
+        showNotification('Error installing plugin: ' + error.message, 'error');
+    })
+    .finally(() => {
+        if (installBtn) {
+            installBtn.disabled = false;
+            installBtn.innerHTML = '<i class="fas fa-download mr-2"></i>Install';
+        }
+    });
+};
+debugLog('[DEFINE] handleGitHubPluginInstall defined and ready');
+
 // GitHub Authentication Status - Define early so it's available in IIFE
 // Shows warning banner only when token is missing or invalid
 // The token itself is never exposed to the frontend for security
@@ -1986,13 +2083,6 @@ window.uninstallPlugin = function(pluginId) {
     });
 }
 
-// How many times the store's Install polls a queued install, a second apart.
-// The server allows the plugin's dependency install 300 s on its own
-// (install_requirements_file in src/plugin_system/store_install.py), after a
-// download that fetches the plugin a file at a time; the 60 the poller
-// defaults to reported installs that then succeeded as timed out.
-const INSTALL_POLL_MAX_ATTEMPTS = 600;
-
 function pollOperationStatus(operationId, pluginId, pluginName, options = {}) {
     const maxAttempts = options.maxAttempts || 60;
     const attempt = options.attempt || 0;
@@ -2024,10 +2114,9 @@ function pollOperationStatus(operationId, pluginId, pluginName, options = {}) {
 
                 if (status === 'completed') {
                     // The operation's result says whether the display picks
-                    // the change up by itself or needs a restart, and for an
-                    // install which id the plugin was installed as.
+                    // the change up by itself or needs a restart.
                     window.noteRestartRequired(operation.result);
-                    onComplete(operation.result);
+                    onComplete();
                 } else if (status === 'failed') {
                     onFailed(operation.error || operation.message);
                 } else {
@@ -2181,18 +2270,10 @@ function showStoreLoading(show) {
 // ── Plugin Store: Client-Side Filter/Sort/Pagination ────────────────────────
 
 function isStorePluginInstalled(pluginIdOrPlugin) {
-    return Boolean(findInstalledStorePlugin(pluginIdOrPlugin));
-}
-
-// The installed-list entry for a store plugin, or undefined. A registry entry
-// can be installed under another id -- `weather` is listed as the
-// `ledmatrix-weather` its manifest declares -- so its own id is tried first,
-// then its plugin_path name, then its aliases.
-function findInstalledStorePlugin(pluginIdOrPlugin) {
     const installed = window.installedPlugins || installedPlugins || [];
     // Accept either a plain ID string or a store plugin object (which may have plugin_path)
     if (typeof pluginIdOrPlugin === 'string') {
-        return installed.find(p => p.id === pluginIdOrPlugin);
+        return installed.some(p => p.id === pluginIdOrPlugin);
     }
     const storeId = pluginIdOrPlugin.id;
     // Derive the actual installed directory name from plugin_path (e.g. "plugins/ledmatrix-weather" → "ledmatrix-weather")
@@ -2200,9 +2281,8 @@ function findInstalledStorePlugin(pluginIdOrPlugin) {
     const pathDerivedId = pluginPath ? pluginPath.split('/').pop() : null;
     // Newer registries also list the other ids outright (the manifest id).
     const aliases = Array.isArray(pluginIdOrPlugin.aliases) ? pluginIdOrPlugin.aliases : [];
-    return installed.find(p => p.id === storeId)
-        || (pathDerivedId ? installed.find(p => p.id === pathDerivedId) : undefined)
-        || installed.find(p => aliases.includes(p.id));
+    return installed.some(p => p.id === storeId || (pathDerivedId && p.id === pathDerivedId)
+        || aliases.includes(p.id));
 }
 
 // ── Plugin Store: search / filter / sort ────────────────────────────────
@@ -2312,43 +2392,8 @@ function getStoreFilter() {
     return _storeFilter;
 }
 
-// The category filter offers the categories the store's plugins have, as the
-// Starlark section does. The template ships only "All Categories": a fixed
-// list offered 7 of the registry's ~20 categories, so most plugins could not
-// be filtered to, and "Financial" missed the plugin filed under "finance".
-// One option per category whatever its case (the filter ignores case), and
-// rebuilt only when the set changes, or for a select freshly swapped in.
-function syncStoreCategoryOptions() {
-    const select = document.getElementById('plugin-category');
-    if (!select) return;
-    const ctl = getStoreFilter();
-    const selected = String((ctl ? ctl.state.filterCategory : select.value) || '');
-    const byKey = new Map();
-    (pluginStoreCache || []).forEach(plugin => {
-        const category = plugin && typeof plugin.category === 'string' ? plugin.category : '';
-        if (category.trim() && !byKey.has(category.toLowerCase())) {
-            byKey.set(category.toLowerCase(), category);
-        }
-    });
-    // The current choice stays selectable even if no plugin has it any more.
-    if (selected && !byKey.has(selected.toLowerCase())) byKey.set(selected.toLowerCase(), selected);
-    const categories = [...byKey.values()].sort((a, b) => a.localeCompare(b, undefined, { sensitivity: 'base' }));
-    const key = categories.join('\n');
-    if (select._storeCategories === key) return;
-    select._storeCategories = key;
-    select.innerHTML = '<option value="">All Categories</option>';
-    categories.forEach(category => {
-        const option = document.createElement('option');
-        option.value = category;
-        option.textContent = category.charAt(0).toUpperCase() + category.slice(1);
-        select.appendChild(option);
-    });
-    select.value = selected;
-}
-
 function applyStoreFiltersAndSort(skipPageReset) {
     if (!pluginStoreCache) return;
-    syncStoreCategoryOptions();
     const ctl = getStoreFilter();
     if (ctl) {
         ctl.apply(skipPageReset);
@@ -2465,45 +2510,11 @@ window.installPlugin = function(pluginId, branch = null) {
         requestBody.branch = branch;
     }
 
-    const storeEntry = (pluginStoreCache || []).find(p => p && p.id === pluginId) || { id: pluginId };
-    // Decided before the install changes the list, by the same match that
-    // labelled the button Install or Reinstall. A reinstall keeps the plugin
-    // as the user had it: enabling it here switched a deliberately disabled
-    // plugin back on.
-    const isReinstall = isStorePluginInstalled(storeEntry);
-
-    // The id the plugin was installed as, which can differ from the store's:
-    // `weather` installs as the `ledmatrix-weather` its manifest declares,
-    // and that is the id /plugins/toggle knows. The install answer names it
-    // (plugin_id); from one that doesn't, the installed entry the store
-    // entry matches, as for the Installed badge.
-    function installedPluginId(result) {
-        if (result && typeof result.plugin_id === 'string' && result.plugin_id) {
-            return result.plugin_id;
-        }
-        const match = findInstalledStorePlugin(storeEntry);
-        return match ? match.id : pluginId;
-    }
-
-    function afterInstall(result) {
-        // Reload first, so the new card exists (and, without plugin_id in the
-        // answer, so the installed id can be found), then redraw the store's
-        // badges from that list.
-        loadInstalledPlugins(true).catch(() => {}).then(() => {
-            applyStoreFiltersAndSort(true);
-            if (isReinstall) {
-                showNotification(`${pluginId} reinstalled`, 'success');
-                return;
-            }
-            enableAfterInstall(installedPluginId(result));
-        });
-    }
-
-    function enableAfterInstall(installedId) {
+    function enableAfterInstall() {
         // Enable immediately so install -> enable is one step; only nudge
         // for a restart once enablement actually succeeded (persistent
         // toast; duration 0 = stays until dismissed).
-        Promise.resolve(window.togglePlugin(installedId, true)).then(toggleResult => {
+        Promise.resolve(window.togglePlugin(pluginId, true)).then(toggleResult => {
             if (toggleResult && toggleResult.status === 'success') {
                 showNotification(
                     `${pluginId} installed and enabled — restart the display to show it`,
@@ -2521,6 +2532,9 @@ window.installPlugin = function(pluginId, branch = null) {
                 );
             }
         });
+        // Refresh installed plugins list, then re-render store to update badges
+        loadInstalledPlugins().catch(() => {});
+        setTimeout(() => applyStoreFiltersAndSort(true), 500);
     }
 
     fetch('/api/v3/plugins/install', {
@@ -2541,25 +2555,14 @@ window.installPlugin = function(pluginId, branch = null) {
             // live: "installation queued" followed immediately by a failed
             // enable). Wait for the operation to actually finish first.
             pollOperationStatus(data.data.operation_id, pluginId, pluginId, {
-                onComplete: afterInstall,
+                onComplete: enableAfterInstall,
                 onFailed: (errorMsg) => showNotification(errorMsg || `Failed to install ${pluginId}`, 'error'),
-                maxAttempts: INSTALL_POLL_MAX_ATTEMPTS,
-                // Out of patience is not a failure: the server may still be
-                // installing. Show the list as it is now and say so; nothing
-                // is enabled without the operation's answer.
-                onTimeout: () => {
-                    showNotification(
-                        `${pluginId} is still installing — it will appear in the installed list when it finishes`,
-                        'warning'
-                    );
-                    loadInstalledPlugins(true).catch(() => {})
-                        .then(() => applyStoreFiltersAndSort(true));
-                }
+                onTimeout: () => showNotification(`Install operation timed out for ${pluginId}`, 'error')
             });
         } else {
             // No operation queue configured - install already completed synchronously.
             window.noteRestartRequired(data);
-            afterInstall(data);
+            enableAfterInstall();
         }
     })
     .catch(error => {

web_interface/templates/v3/partials/plugins.html

@@ -250,7 +250,13 @@
                 <input type="text" id="plugin-search" placeholder="Search plugins by name, description, or tags..." aria-label="Search the Plugin Store" class="form-control text-sm flex-[3] min-w-0 px-4 py-2.5 border border-gray-300 rounded-lg shadow-sm focus:shadow-md transition-shadow">
                 <select id="plugin-category" aria-label="Filter the Plugin Store by category" class="form-control text-sm flex-1 px-3 py-2.5 border border-gray-300 rounded-lg shadow-sm focus:shadow-md transition-shadow">
                     <option value="">All Categories</option>
-                    <!-- The rest come from the store's plugins (plugins_manager.js, syncStoreCategoryOptions). -->
+                    <option value="sports">Sports</option>
+                    <option value="content">Content</option>
+                    <option value="time">Time</option>
+                    <option value="weather">Weather</option>
+                    <option value="financial">Financial</option>
+                    <option value="media">Media</option>
+                    <option value="demo">Demo</option>
                 </select>
             </div>
 
@@ -461,9 +467,8 @@
                             <input type="text" id="github-plugin-url" aria-label="Plugin GitHub repository URL"
                                    placeholder="https://github.com/user/ledmatrix-plugin-name" 
                                    class="flex-1 px-3 py-2 text-sm border border-gray-300 rounded-md focus:ring-blue-500 focus:border-blue-500">
-                            <!-- Wired by attachInstallButtonHandler (plugins_manager.js); an inline
-                                 onclick here ran a second install handler on every click. -->
-                            <button type="button" id="install-plugin-from-url"
+                            <button type="button" id="install-plugin-from-url" 
+                                    onclick="if(window.handleGitHubPluginInstall){window.handleGitHubPluginInstall()}else{alert('Function not loaded yet, please refresh the page')}"
                                     class="px-4 py-2 bg-blue-600 hover:bg-blue-700 text-white text-sm rounded-md whitespace-nowrap">
                                 <i class="fas fa-download mr-2"></i>Install
                             </button>