* fix(web): implement delete_cached so the font catalog cache actually invalidates
api_v3.py's font upload/delete handlers import delete_cached from
web_interface.cache, but the function was never defined. The surrounding
except ImportError silently swallowed the failure, so the fonts_catalog
cache entry survived uploads/deletes and newly uploaded fonts did not
appear until the TTL expired or the service restarted.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(web): remove dead weather/stocks partial routes that returned 500
The partial dispatcher still routed 'weather' and 'stocks' to loaders
rendering v3/partials/weather.html and stocks.html — templates that no
longer exist since weather and stocks became store plugins. Requesting
either partial raised TemplateNotFound, which the catch-all turned into
a 500. No template or JS references these partials (the only 'weather'
hit in the front end is a plugin-store category filter option), so the
branches and both loader functions are removed; unknown partials now
fall through to the existing 404 handler.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(deps): align contradictory psutil/Flask-Limiter/freetype-py pins
requirements.txt's optional-install comment recommended psutil>=5.9,<6.0
while web_interface/requirements.txt hard-requires >=6.0,<7.0 — anyone
following the comment ends up with an unsatisfiable pair. The comment now
recommends the same range the web interface requires (all psutil APIs
used — Process, boot_time, cpu_percent, disk_usage, virtual_memory — are
stable in 6.x). Flask-Limiter gains the same <4.0 cap in both files and
freetype-py the same >=2.5.1 floor.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(config): add template keys the code already reads
display.hardware gains pixel_mapper_config, row_address_type,
multiplexing and panel_type (read at display_manager.py with these exact
fallbacks — users on non-standard panels previously had no way to
discover them from the template). vegas_scroll gains
frame_based_scrolling and scroll_delay, the only two of its 27 keys the
template omitted (read in src/vegas_mode/config.py). plugin_system gains
development_mode, which the web UI reads and writes but the template
never declared.
Every added value is byte-identical to the code-side .get() fallback, so
ConfigManager._migrate_config() merging these keys into existing user
configs cannot change behavior on any installed device.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(scripts): repair broken sys.path setup in utility scripts
clear_cache.py and download_nba_logos.py pointed sys.path at a 'src'
directory relative to the script's own folder (scripts/utils/src and
scripts/src — neither exists), so both crashed on import; they now insert
the project root and import via the src package like the other scripts.
debug_web_manual.py resolved 'project root' to scripts/debug/ instead of
two levels up. fix_nhl_cache.sh is removed: it used Python docstring
syntax in a bash script and invoked clear_nhl_cache.py, which does not
exist anywhere in the repo — it cannot ever have worked in its current
location.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: correct stale file:line references and the loader-fallback contradiction
CLAUDE.md and .cursorrules disagreed about plugin-directory fallback
behavior; the code (SchemaManager.get_schema_path) probes plugins/
BEFORE plugin-repos/, and the main discovery path has no fallback at
all — both files now describe the real behavior, preferring symbol names
over line numbers so the references rot slower. REST_API_REFERENCE.md
pointed at app.py:144/:607 for mounts that live at :199/:799 and counted
92 routes where there are 94. PLUGIN_ARCHITECTURE_SPEC.md's historical
banner gains a note that its example imports
(src/plugin_system/base_classes/*_plugin.py) never shipped — the real
base classes are src.base_classes.sports.SportsCore and
src.base_classes.hockey.Hockey.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: fix broken links, phantom script references, and stale CI description
Repairs every broken relative link in active docs (targets renamed or
archived long ago: PLUGIN_DEVELOPMENT.md -> PLUGIN_DEVELOPMENT_GUIDE.md,
API_REFERENCE.md -> REST_API_REFERENCE.md, PLUGIN_STORE_USER_GUIDE.md ->
PLUGIN_STORE_GUIDE.md, plugin_docs/ dir, TROUBLESHOOTING_QUICK_START.md,
and MIGRATION_GUIDE's README link that silently resolved to the docs
index instead of the project README). Replaces commands invoking scripts
that do not exist (scripts/update_stats.py, validate_registry.py,
check_updates.py, fix_permissions.sh) with the real tooling, and
rewrites HOW_TO_RUN_TESTS.md's CI section, which described a
security-audit workflow that was never committed and a pytest workflow
'queued to land' that landed long ago as test.yml.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: complete the docs index and refresh the web interface file tree
docs/README.md's own policy says every page must be linked from the
index, yet five weren't — including the entire skin system
(SKIN_SYSTEM.md, CREATING_SKINS.md), ADAPTIVE_LAYOUT.md,
plugin-safety-harness.md and SPORTS_UNIFICATION.md. Each is now listed
in the section it belongs to, and PLUGIN_ARCHITECTURE_SPEC.md is marked
historical in the index (the doc itself already carries the banner).
web_interface/README.md's static/v3 tree showed only app.css/app.js;
it now reflects the actual contents.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: remove dead modules confirmed unused in-repo and across all store plugins
- src/common/cli.py: imports a 'ledmatrix_common' package that exists
nowhere (not in this repo, any requirements file, or the plugin
monorepo), so it cannot ever have run; its README section claimed
scripts/dev/* used it, which was also untrue.
- src/web_interface/logging_config.py: zero callers — the web app uses
web_interface/logging_config.py (a different module), and nothing
imports the src copy.
- handle_errors decorator in src/web_interface/error_handler.py: zero
call sites (the module's response helpers stay — they are used).
- ConfigManager.get_clock_config(): reads a 'clock' config key that no
longer exists anywhere; only caller was its own unit test.
Deliberately kept despite zero in-repo callers: DisplayError,
src/common/config_helper.py and display_helper.py — all documented as
plugin-facing API (docs/PLUGIN_ERROR_HANDLING.md, src/common/README.md),
and third-party plugins outside the official monorepo cannot be
enumerated. Verified against a fresh clone of ledmatrix-plugins (43
plugins): zero references to any removed symbol.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: remove manager-era NBA test files and one-off debug scripts
The four test_nba_*.py files imported nba_managers, leaderboard_manager
and odds_manager — top-level modules deleted when sports displays became
plugins — inside try/except blocks that swallowed the ImportError, so
they passed while exercising nothing. test_nba_data_structure.py and
debug_nba_api.py (a diagnostic script living in test/) made live ESPN
API calls rather than testing repo code. None were enrolled in CI.
scripts/debug/direct_fix_imports.py and check_imports.py were one-shot
artifacts that edited/inspected a hardcoded ~/LEDMatrix/web_interface/
app.py to fix an import problem solved long ago; nothing references
them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: remove generate_report.py, which aggregates artifacts of CI jobs that do not exist
The script's only function is to merge JSON artifacts
(bandit/semgrep/pip-audit/safety/gitleaks results) produced by a
security-audit workflow that was never committed —
.github/workflows/ has no such jobs, so there is nothing for it to
aggregate and no way to run it usefully. Its siblings stay:
prove_security.py and audit_plugins.py both run standalone (verified),
and .codacy.yml stays because the Codacy service (README badge) reads it
server-side without a workflow file.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(web): load the three widget scripts store plugins already declare
time-picker.js, file-upload-single.js and plugin-file-manager.js
register widgets that installed store plugins reference in their config
schemas (countdown uses x-widget: time-picker and file-upload-single;
of-the-day uses plugin-file-manager), but base.html never included the
scripts. plugin_config.html renders such fields as an empty container
that polls LEDMatrixWidgets.get(...) on a 50ms loop forever, so those
plugin config fields appeared permanently blank. The audit initially
flagged these files as dead code; the monorepo cross-check proved the
opposite — they were unreachable, not unused.
example-color-picker.js (the documented custom-widget example) gains an
explicit warning that including it in base.html would shadow the
built-in color-picker widget.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: drop the legacy youtube block from the secrets template
No code reads a top-level youtube secrets key: the youtube-stats plugin
receives its API key namespaced under its own plugin id (declared via
x-secret in its config schema), like every other store plugin. The key
survives only in state_reconciliation.py's non-plugin-key exclusion set,
which stays — existing installs still carry the key in their generated
config_secrets.json, and the exclusion prevents it from being
misclassified as a plugin config. New installs simply stop being asked
for a YouTube API key they have nowhere to use.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore(deps): remove packages nothing imports, declare direct imports, move mypy to test deps
Removed from requirements.txt: python-socketio, python-engineio,
websockets, websocket-client — zero imports anywhere in this repo, and
the one store plugin that needs Socket.IO (ledmatrix-music) declares it
in its own requirements.txt, which the plugin store installs. Removed
the same quartet plus timezonefinder, geopy, google-auth-oauthlib,
google-auth-httplib2, google-api-python-client, unidecode, icalevents,
python-dateutil, flask-wtf and the werkzeug pin from
web_interface/requirements.txt — all leftovers from the deleted built-in
weather/calendar/music displays (flask-wtf was doubly dead: app.py
explicitly disables CSRF and sets csrf=None). scripts/
install_dependencies_apt.py, which mirrors these lists for the
first-time installer, drops the same packages.
Added: urllib3 (imported directly in four core modules), jinja2 and
markupsafe (imported directly in pages_v3.py) — previously reachable
only as transitives. mypy moves from runtime requirements to
requirements-test.txt.
Verified in a fresh venv: all four requirements files co-install, pip
check is clean, the full CI-enrolled suite (907 tests) and a Flask boot
smoke pass with the trimmed dependency set.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* refactor: single canonical DateTimeEncoder
src/cache_manager.py and src/cache/disk_cache.py each defined an
identical DateTimeEncoder (datetime -> ISO-8601). The disk_cache copy is
the only one actually used for serialization; cache_manager now
re-exports it instead of defining a twin, so the two can never silently
diverge. Import compatibility is preserved — from src.cache_manager
import DateTimeEncoder still works and is the same class object.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs(code): document deliberate duplicates instead of merging them
The audit surfaced several near-duplicate implementations that turned
out to be either deliberate forks or behaviorally different — merging
any of them would risk changing behavior on installed devices, so each
now carries an explicit comment stating the relationship:
- VisualDisplayManager: headless fork of DisplayManager; header now
lists the ~15 mirrored methods and warns that DisplayManager changes
must be mirrored.
- normalize_abbreviation: LogoDownloader's version (called directly by
nine scoreboard plugins) replaces filesystem-unsafe characters;
LogoHelper's strips spaces. Logo filenames on existing installs
depend on both behaviors staying put.
- The two PluginTestBase classes: the shipped one is plugin-author
API, the repo's own richer harness lives in test/plugins/ — now
cross-referenced.
Also verified (no change needed): ConfigManager's backup/rollback
methods genuinely delegate to AtomicConfigManager, and SportsCore
already delegates _read_bdf_native_size to FontManager.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: add a unified configuration reference
There was no single place documenting what lives in config.json —
display.* keys were scattered across README sections, vegas_scroll lived
in ADVANCED_FEATURES.md, and dim_schedule, display.double_sided,
sync.follower_position, plugin_system.development_mode and the four
newly-templated hardware keys were documented nowhere. CONFIG_REFERENCE.md
now lists every template key plus the code-read-only keys, each with
type, default, and the code location that reads it, and explains the
secrets file's plugin-id namespacing. Linked from the docs index.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: bring the README's feature tour into the plugin era
The Core Features section still presented clock/weather/sports/stocks/
music displays as built into the project, when all of them are store
plugins installed from the ledmatrix-plugins monorepo — only
starlark-apps and web-ui-info ship in this repo. The intro now says so
(the showcase itself is unchanged; those are real displays available in
the store). The display_durations reference drops its built-in-calendar
example in favor of plugin-id keys, and the Configuration section links
the new CONFIG_REFERENCE.md.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: archive the custom-icons status report, cross-link config docs, document assets/
PLUGIN_CUSTOM_ICONS_FEATURE.md was a 'What Was Implemented' status
report duplicating the actual guide (PLUGIN_CUSTOM_ICONS.md) — moved to
docs/archive/ per the docs index's own policy. The overlapping
plugin-config docs keep their content but PLUGIN_CONFIG_ARCHITECTURE.md
now states up front which doc is canonical for which purpose.
assets/README.md is new and load-bearing: assets/stocks, weather,
news_logos and broadcast_logos have zero references in this repo's code,
which makes them look deletable — but store plugins (ledmatrix-stocks,
ledmatrix-weather, news, odds-ticker) resolve those exact paths at
runtime against the install directory. The README records that evidence
so a future cleanup doesn't break installed plugins.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* test: add regression guards for the bug classes fixed in this PR
Three lightweight static checks, all enrolled in CI's unit-test
allowlist along with the new web-cache test:
- test_template_targets.py: every literal render_template() target must
exist (would have caught the weather/stocks partial 500s at commit
time).
- test_widget_scripts.py: every widget JS file must be script-included
in base.html or explicitly allowlisted with a reason (would have
caught the unloaded time-picker/file-upload-single/plugin-file-manager
widgets), and allowlisted files must NOT be included (prevents the
example widget from shadowing the real color-picker).
- test_doc_links.py: relative markdown links in active docs must
resolve (docs/archive/ exempt).
Each guard was verified to fail against the pre-PR tree and pass now.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(deps): restore the werkzeug version floor
Commit 1ec22db removed the werkzeug>=3.1.6,<4.0.0 pin along with the
genuinely-unused packages, but this one was a version floor on Flask's
transitive dependency, not a phantom: Flask 3.1.3 itself only requires
werkzeug>=3.1.0, so dropping the pin let fresh installs resolve
3.1.0-3.1.5. Restored with a comment explaining why it exists.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix(web): route pixel_mapper_config into display.hardware; guard time-picker registration
pixel_mapper_config was the only display.hardware key absent from both
the display_fields detection allowlist and the hardware write loop in
the settings save path. No form posts it today, but if one ever did the
key would fall through to the generic handler and land at the TOP level
of config.json — where state_reconciliation would mistake it for a
missing plugin id and loop auto-repair attempts (the failure class the
'github'/'youtube' exclusion comment documents). It now round-trips
into display.hardware like its siblings.
time-picker.js gains the same LEDMatrixWidgets-undefined guard its two
sibling widgets already have; correct today only via defer ordering.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: align installer leftovers with the dependency cleanup
first_time_install.sh's fallback secrets heredoc (used only when the
template is missing) still wrote the legacy youtube block — now matches
the template (github only). install_dependencies_apt.py drops the
IMPORT_NAME_MAP entries for packages no longer in its install lists and
a stale google-api reference in a docstring.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix: address CodeRabbit review findings
Verified each finding against the code; fixes for the valid ones:
- install_dependencies_apt.py: the installer listed 'freetype', but the
declared dependency is freetype-py — an apt miss would pip-install the
wrong PyPI package. Now installs freetype-py with an import-name
mapping (pre-existing bug, surfaced by the review).
- api_v3.py: pixel_mapper_config is validated as a string before being
saved to display.hardware (JSON callers could previously store an
object/list the matrix library can't use).
- .cursorrules: the Plugin Loading Process and File Organization
sections still said discovery scans plugins/ — now consistent with the
corrected overview (configured directory, default plugin-repos/).
- README.md: removed the stale '(except the core calendar)' claim — no
core calendar exists in src/ — and qualified the plugin inventory
(official plugins in the monorepo; third-party from their own repos).
- CONFIG_REFERENCE.md: hardware_mapping now shows the code fallback
(adafruit-hat-pwm) alongside the template value.
- PLUGIN_REGISTRY_SETUP_GUIDE.md: check_plugin.py takes --plugin, not a
positional id.
- scripts/fix_perms/fix_*.sh: exec bits set so the documented
'sudo ./...' invocations work.
- Guard tests hardened: template guard now catches multi-line
render_template() calls; widget guard parses actual <script> src
values and fails if the widgets dir goes missing; type hints and
docstrings added per repo coding guidelines.
Skipped with reasons (noted on the PR): limit_refresh_rate_hz 100-vs-90
is documented as intentional in CONFIG_REFERENCE.md; the psutil comment
already names the enforcing manifest; docs/archive/ findings are out of
scope per the docs policy (archive may rot).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: remove Cursor IDE tooling, consolidate its guidance into CLAUDE.md
The maintainer no longer uses Cursor. .cursorrules, .cursorignore and the
.cursor/ tree (rules, plugin templates, a parallel 751-line plugins
guide) are removed; measurement showed near-zero literal overlap risk —
the canonical content already lives in docs/. Unique guidance worth
keeping moved before deletion:
- CLAUDE.md gains the dev workflow (dev_plugin_setup.sh, dev_server.py,
run.py -e, check_plugin.py), the plugin-secrets namespacing contract,
and the no-draw_image()/paste-onto-PIL pitfall.
- PLUGIN_DEVELOPMENT_GUIDE.md absorbs the plugin version-management
rules (pre-push hook install, SKIP_TAG, version resolution order) that
its own text previously linked out to .cursorrules for.
- The one completed plan doc (.cursor/plans/) is archived to
docs/archive/ per the docs policy rather than deleted.
One of the deleted rule files (sports-managers.mdc) targeted
src/*_managers.py globs that have matched nothing since the plugin
migration.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* chore: second-pass cleanup — dead installer branch, broken script, orphaned JS, misfiled test deps
- first_time_install.sh: removed the pip fallback branch that installed
from requirements_web_v2.txt — a file that has not existed since the
v2 web interface was removed (the branch always printed its own
'not found; skipping' warning).
- scripts/remove_plugin_backups.sh deleted: its PROJECT_ROOT resolved to
the repo's PARENT directory, and its verify_submodules() checks for
plugin submodules from an era before plugins moved to the store — it
could never have worked from its current location.
- plugins_manager.js: removed three functions with zero call sites
anywhere (addKeyValuePair, formatCommit, togglePasswordVisibility) —
verified against all templates, all JS, and the dynamic window[name]
dispatch sites, which resolve widget-registry keys only. Also replaced
base.html's misleading 'Legacy ... during migration' label: the file
is deliberately loaded last and provides the LIVE implementations of
seven window.* plugin actions that shadow same-named definitions in
app.js/app-shell.js.
- pytest/pytest-cov/pytest-mock moved from runtime requirements.txt to
requirements-test.txt (CI already installs both files; the installer's
line-by-line loop simply installs three fewer packages on devices; no
store plugin declares pytest). HOW_TO_RUN_TESTS.md updated.
- scripts/add_defaults_to_schemas.py and analyze_plugin_schemas.py
scanned the empty legacy plugins/ dir — now scan plugin-repos/.
Verified: fresh venv installs all four requirements files with pip check
clean and pytest available; bash -n on the installer; node --check on
the JS; widget/cache guard tests green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* docs: correct semantically stale content across the user and developer guides
A second-pass content audit checked the guides' substantive claims
against the code (the first pass only fixed mechanical drift). Fixes:
- GETTING_STARTED: described booting a prebuilt SD image and seeing
default clock/weather plugins — neither exists. Now documents the real
install (Pi OS Lite + one-shot installer / first_time_install.sh) and
that displays come from the Plugin Store. Duration and ordering
instructions moved to the Rotation tab where the controls actually
live.
- WEB_INTERFACE_GUIDE: three whole tabs were undocumented (Rotation,
Backup & Restore, Tools) and the Display tab's Vegas Scroll section
was unmentioned. Fonts overrides are per display element (not per
plugin); Logs has an Auto-scroll checkbox (not a Pause button); the
aspirational keyboard-shortcut list and no-JS claim removed.
- TROUBLESHOOTING: the hand-written service-file template (wrong user,
wrong ExecStart, dropped the autostart gate) replaced with the real
systemd/ units + install scripts; recovery steps no longer copy
placeholder units verbatim; WiFi curl endpoint corrected to /api/v3/;
cache-clearing advice now targets the real cache locations.
- ADVANCED_FEATURES: removed a false claim that CacheManager has no
delete(); fixed two example snippets that raise TypeError
(BackgroundDataService and get_config_file_mode signatures); fixed
cache paths, a 5-minute TTL that is actually 1 hour, and the vegas
table now links the complete 26-key reference.
- EMULATOR_SETUP_GUIDE: documented run.py flags that don't exist
(--plugin/--test-plugins) removed in favor of dev_server.py and
check_plugin.py; shipped emulator config values corrected (browser
adapter default on :8888, not pygame).
- PLUGIN_QUICK_REFERENCE: drag-and-drop reordering is shipped, not
'not yet supported'; discovery-fallback and registry-repo claims
corrected. PLUGIN_API_REFERENCE: get_vegas_segment_width returns
panels, not pixels. CONTRIBUTING: the repo uses flake8/mypy/bandit
pre-commit hooks, not black/ruff, and tests need requirements-test.txt.
- SKIN_SYSTEM/DEVELOPER_QUICK_REFERENCE: stale module paths.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
* fix: raise the two new dependency floors past their CVEs, silence a deliberate re-export
All three of these were introduced by this PR, which is what makes them
worth fixing here rather than deferring.
`urllib3` and `jinja2` were added to the requirements so that direct
imports stop relying on transitives — right call, but both floors were
set to the version that introduced the API rather than a version that is
safe to install. `urllib3>=1.26.0` sits below roughly ten CVEs including
a decompression-bomb safeguard bypass, and `jinja2>=3.1.0` below five
including two sandbox breakouts. Raised to 2.7.0 and 3.1.6, which is what
a working device already runs, so no install is disturbed. The comments
now say the floor is a security floor, since the next person to read
"imported directly" would otherwise reasonably lower it again.
This is the same reasoning the PR already applied to werkzeug; these two
just missed it.
The `DateTimeEncoder` import in cache_manager is unused on purpose — the
canonical class moved to src.cache.disk_cache and this re-export keeps
the documented import path working. flake8 cannot see intent, so it gets
an explicit `# noqa: F401` rather than being removed and quietly breaking
anything importing it from here. Verified the re-export still resolves to
the same object and still serialises datetimes.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Udr6MfaFLUPhX5Fgo67Jf5
* fix: address CodeRabbit re-review — installer robustness and doc lint
- install_dependencies_apt.py: an import-only check let Debian
Bookworm's python3-freetype 2.3.0 satisfy the freetype-py>=2.5.1 pin.
check_package_installed() now verifies the installed freetype-py
version, and an apt install that lands below the minimum falls through
to pip instead of counting as success.
- first_time_install.sh: the .web_deps_installed marker was created even
when the smart installer failed, so re-runs skipped installation with
dependencies missing. The marker is now created only on success.
- CONTRIBUTING.md: document installing the pre-commit CLI before
'pre-commit install' (the requirements files don't provide it).
- Doc lint: fence language on the on-demand cache example (MD040),
blockquote continuation in GETTING_STARTED (MD028), and the
suppress_adapter_load_errors key removed from the emulator debug
example to match the options table.
Skipped one finding with reason (noted on the PR): the per-plugin
display_duration field in PLUGIN_QUICK_REFERENCE's example is not
obsolete — BasePlugin.get_display_duration() reads it and
PLUGIN_CONFIG_CORE_PROPERTIES.md documents it as a core property;
display.display_durations is a per-mode override, not a replacement.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SXb4mKcAkVaxkeTb3YnAdr
---------
Co-authored-by: Claude <noreply@anthropic.com>
31 KiB
Advanced Features Guide
This guide covers advanced LEDMatrix features for users and developers, including Vegas scroll mode, on-demand display, cache management, background services, and permission management.
1. Vegas Scroll Mode
Overview
Vegas scroll mode displays content from multiple plugins in a continuous horizontal scroll, similar to news tickers seen in Las Vegas casinos. Plugins contribute content segments that flow across the display in a seamless ticker-style presentation.
Display Modes
SCROLL (Continuous Scrolling):
- Content scrolls continuously left
- Smooth, fluid motion
- Best for news-ticker style displays
FIXED_SEGMENT (Fixed-Width Block):
- Plugin gets fixed-width block on display
- Content doesn't scroll out of its segment
- Multiple plugins can share the display simultaneously
STATIC (Scroll Pauses):
- Scrolling pauses when content is fully visible
- Displays for specified duration, then resumes scrolling
- Best for content that needs to be fully read
Configuration
Enable Vegas mode in config/config.json:
{
"display": {
"vegas_scroll": {
"enabled": true,
"scroll_speed": 50,
"separator_width": 32,
"plugin_order": ["clock", "weather", "sports"],
"excluded_plugins": ["debug_plugin"],
"target_fps": 125,
"buffer_ahead": 2
}
}
}
Vegas mode can also be configured entirely from the web UI — the Display tab has a Vegas Scroll Mode section (enable toggle, scroll speed, separator width, dynamic duration, and more), so hand-editing JSON is optional.
Configuration Options:
| Setting | Default | Description |
|---|---|---|
enabled |
false |
Enable Vegas scroll mode |
scroll_speed |
50 |
Pixels per second scroll speed |
separator_width |
32 |
Width between plugin segments (pixels) |
plugin_order |
[] |
Plugin display order (empty = auto) |
excluded_plugins |
[] |
Plugins to exclude from Vegas mode |
target_fps |
125 |
Target frame rate |
buffer_ahead |
2 |
Number of plugins buffered ahead |
This table is a subset — display.vegas_scroll supports 26 keys in
total. See the full list in
CONFIG_REFERENCE.md.
Per-Plugin Configuration
Override Vegas behavior for specific plugins:
{
"my_plugin": {
"enabled": true,
"vegas_mode": "scroll",
"vegas_panel_count": 2,
"display_duration": 10
}
}
Per-Plugin Options:
| Setting | Values | Description |
|---|---|---|
vegas_mode |
scroll, fixed, static |
Display mode for this plugin |
vegas_panel_count |
any positive integer | Width in panels (1 panel = display width) |
display_duration |
seconds | Pause duration for STATIC mode |
Plugins may also set vegas_overflow and vegas_max_width_screens in
their config section to control how oversized content is handled (see
PluginManager in src/plugin_system/plugin_manager.py).
Plugin Integration (Developer Guide)
1. Implement Content Method:
def get_vegas_content(self):
"""
Return PIL Image or list of Images for Vegas mode.
Returns:
PIL.Image or list[PIL.Image]: Content to display
- Single image: fixed-width content
- List of images: multiple segments
- None: skip this cycle
"""
# Example: Return single wide image
img = Image.new('RGB', (256, 32))
# ... render your content ...
return img
# Example: Return multiple segments
return [image1, image2, image3]
2. Specify Content Type:
def get_vegas_content_type(self):
"""
Specify how content should be handled.
Returns:
str: 'multi' | 'static' | 'none'
"""
return 'multi' # Default for most plugins
3. Optionally Specify Display Mode:
def get_vegas_display_mode(self):
"""
Preferred display mode for this plugin.
Returns:
str: 'scroll' | 'fixed' | 'static'
"""
return 'scroll'
def get_supported_vegas_modes(self):
"""
List of supported modes.
Returns:
list: ['scroll', 'fixed', 'static']
"""
return ['scroll', 'static']
Content Rendering Guidelines
Image Dimensions:
- Height: Must match display height (typically 32 pixels)
- Width: Varies by mode:
- SCROLL: Any width (recommended 64-512 pixels)
- FIXED_SEGMENT:
panel_count * display_width - STATIC: Any width, optimized for readability
Color Mode:
- Use RGB color mode
- 24-bit color (8 bits per channel)
Performance Tips:
- Cache rendered images - Render in
update(), not inget_vegas_content() - Keep images small - Larger images use more memory
- Pre-render on update - Don't create images on-demand
- Reuse images - Return same image if content unchanged
Example Integration
Complete example for a weather plugin:
class WeatherPlugin(BasePlugin):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.vegas_image = None
def update(self):
"""Update data and pre-render Vegas image"""
# Fetch weather data
weather_data = self.fetch_weather()
# Pre-render Vegas image
self.vegas_image = self._render_vegas_content(weather_data)
def _render_vegas_content(self, data):
"""Render weather content for Vegas mode"""
img = Image.new('RGB', (384, 32))
draw = ImageDraw.Draw(img)
# Draw temperature
draw.text((10, 0), f"{data['temp']}°F", fill=(255, 255, 255))
# Draw condition
draw.text((100, 0), data['condition'], fill=(200, 200, 200))
# Draw icon
icon = Image.open(f"assets/{data['icon']}.png")
img.paste(icon, (250, 0))
return img
def get_vegas_content(self):
"""Return cached Vegas image"""
return self.vegas_image
def get_vegas_content_type(self):
return 'multi'
def get_vegas_display_mode(self):
return 'scroll'
def get_supported_vegas_modes(self):
return ['scroll', 'static']
System Architecture
Vegas mode consists of four core components working together to provide smooth 125 FPS continuous scrolling:
Component Overview
┌─────────────────────────────────────────────────────────────┐
│ VegasModeCoordinator │
│ Main orchestrator - manages lifecycle and coordination │
└───────┬──────────────────┬──────────────────┬──────────────┘
│ │ │
▼ ▼ ▼
┌───────────────┐ ┌──────────────┐ ┌─────────────────┐
│ PluginAdapter │ │StreamManager │ │ RenderPipeline │
│ │ │ │ │ │
│ Converts │─▶│ Manages │─▶│ 125 FPS render │
│ plugin content│ │ content │ │ Double-buffered │
│ to images │ │ stream with │ │ Smooth scroll │
│ │ │ 1-2 ahead │ │ │
└───────────────┘ │ buffering │ └─────────────────┘
└──────────────┘
1. VegasModeCoordinator
Responsibilities:
- Initialize and coordinate all Vegas mode components
- Manage the high-FPS render loop (target: 125 FPS)
- Handle live priority interruptions
- Process config updates during runtime
- Provide status and control interface
Key Features:
- Thread-safe state management
- Config hot-reload support
- Live priority integration
- Interrupt checking for yielding control back to display controller
- Static pause handling (pauses scroll when content fully visible)
Main Loop:
- Check for interrupts (live priority, on-demand, config updates)
- If static pause active, wait for duration
- Otherwise, delegate to render pipeline for frame rendering
- Sleep to maintain target FPS
2. StreamManager
Responsibilities:
- Manage plugin content streaming with look-ahead buffering
- Coordinate with PluginAdapter to fetch plugin content
- Handle plugin ordering and exclusions
- Optimize content generation timing
Buffering Strategy:
- Buffer Ahead: 1-2 panels (configurable)
- Just-in-Time Generation: Fetch content only when needed
- Memory Efficient: Only keep necessary content in memory
Content Flow:
- Determine which plugins should appear in stream
- Respect
plugin_orderconfiguration (or use default order) - Exclude plugins in
excluded_pluginslist - Request content from each plugin via PluginAdapter
- Compose into continuous stream with separators
Key Methods:
get_stream_content()- Returns current stream content as PIL Imageadvance_stream(pixels)- Advances stream by N pixelsrefresh_stream()- Regenerates stream from current plugins
3. PluginAdapter
Responsibilities:
- Convert plugin content to scrollable images
- Handle different Vegas display modes (SCROLL, FIXED, STATIC)
- Manage fallback for plugins without Vegas support
- Cache plugin content for performance
Plugin Integration:
-
Check for Vegas support:
- Calls
get_vegas_content()if available - Falls back to
display()method if not
- Calls
-
Handle display mode:
- SCROLL: Returns image as-is for continuous scrolling
- FIXED_SEGMENT: Creates fixed-width block (panel_count * display_width)
- STATIC: Marks content for pause-when-visible behavior
-
Content type handling:
multi: Multiple segments (list of images)static: Single static imagenone: Skip this plugin in current cycle
Fallback Behavior:
- If plugin doesn't implement Vegas methods:
- Calls plugin's
display()method - Captures rendered display as static image
- Treats as fixed segment
- Calls plugin's
- Ensures all plugins work in Vegas mode without explicit support
4. RenderPipeline
Responsibilities:
- High-performance 125 FPS rendering
- Double-buffered composition for smooth scrolling
- Scroll position management
- Frame rate control
Rendering Process:
- Fetch Stream Content: Get current stream from StreamManager
- Extract Viewport: Calculate which portion of stream is visible
- Compose Frame: Create frame with visible content
- Double Buffer: Render to off-screen buffer
- Display: Swap buffer to display
- Advance: Update scroll position based on speed and elapsed time
Performance Optimizations:
- Double Buffering: Eliminates flicker
- Viewport Extraction: Only processes visible region
- Frame Rate Control: Precise timing to maintain 125 FPS
- Pre-rendered Content: Plugins pre-render during update()
Scroll Speed Calculation:
pixels_per_frame = (scroll_speed / target_fps)
scroll_position += pixels_per_frame * elapsed_time
Component Interactions
Initialization Flow:
1. VegasModeCoordinator created
2. Coordinator creates PluginAdapter
3. Coordinator creates StreamManager (with PluginAdapter)
4. Coordinator creates RenderPipeline (with StreamManager)
5. All components initialized and ready
Render Loop Flow:
1. Coordinator starts render loop
2. Check for interrupts (live priority, on-demand)
3. RenderPipeline.render_frame():
a. Request current stream from StreamManager
b. StreamManager uses PluginAdapter to get plugin content
c. PluginAdapter calls plugin Vegas methods or fallback
d. Stream content returned to RenderPipeline
e. RenderPipeline extracts viewport and renders
4. Update scroll position
5. Sleep to maintain target FPS
6. Repeat from step 2
Config Update Flow:
1. Config change detected by Coordinator
2. Set _pending_config_update flag
3. On next render loop iteration:
a. Pause rendering
b. Update VegasModeConfig
c. Notify StreamManager of config change
d. StreamManager refreshes stream
e. Resume rendering
Thread Safety
All components use thread-safe patterns:
- Coordinator: Uses
threading.Lockfor state management - StreamManager: Thread-safe content access
- RenderPipeline: Atomic frame composition
- PluginAdapter: Stateless operations (except caching)
Performance Characteristics
Frame Rate:
- Target: 125 FPS
- Actual: 100-125 FPS (depends on content complexity)
- Render time budget: ~8ms per frame
Memory Usage:
- Stream buffer: ~2-3 panels ahead
- Plugin content: Cached in plugin's
update()method - Double buffer: 2x display size
CPU Usage:
- Light load: 5-10% (simple content)
- Heavy load: 15-25% (complex content, many plugins)
- Optimized with numpy for pixel operations
Fallback Behavior
If a plugin doesn't implement Vegas methods:
- System calls the plugin's
display()method - Captures the rendered display as a static image
- Treats it as a fixed segment
This ensures all plugins work in Vegas mode, even without explicit support.
2. On-Demand Display
Overview
On-demand display allows users to manually trigger specific plugins to show immediately on the LED matrix, overriding the normal rotation. This is useful for:
- Quick checks (weather, scores, time)
- Pinning important information
- Testing plugins during development
- Showing specific content to visitors
Priority Hierarchy
On-demand display has the highest priority:
Priority Order (highest to lowest):
1. On-Demand Display (manual trigger)
2. Live Priority (games in progress)
3. Normal Rotation
When on-demand expires or is cleared, the display returns to the next highest priority (live priority or normal rotation).
Web Interface Controls
Each installed plugin has its own tab in the second nav row of the web UI. Inside the plugin's tab, scroll to On-Demand Controls:
- Run On-Demand — triggers the plugin immediately, even if it's disabled in the rotation
- Stop On-Demand — clears on-demand and returns to the normal rotation
The display service must be running. The status banner at the top of the plugin tab shows the active on-demand plugin, mode, and remaining time when something is active.
REST API Reference
The API is mounted at /api/v3 (web_interface/app.py:199).
Start On-Demand Display
POST /api/v3/display/on-demand/start
# Body:
{
"plugin_id": "weather",
"duration": 30, # Optional: seconds (0 = indefinite, null = default)
"pinned": false # Optional: keep until manually cleared
}
# Examples:
# 30-second preview
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
-H "Content-Type: application/json" \
-d '{"plugin_id": "weather", "duration": 30}'
# Pin indefinitely
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
-H "Content-Type: application/json" \
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
Stop On-Demand Display
POST /api/v3/display/on-demand/stop
# Body:
{
"stop_service": false # Optional: also stop display service
}
# Examples:
# Clear on-demand
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
# Stop service too
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop \
-H "Content-Type: application/json" \
-d '{"stop_service": true}'
Get On-Demand Status
GET /api/v3/display/on-demand/status
# Example:
curl http://localhost:5000/api/v3/display/on-demand/status
# Response:
{
"active": true,
"plugin_id": "weather",
"mode": "weather",
"remaining": 25.5,
"pinned": false,
"status": "active"
}
There is no public Python on-demand API. The display controller's on-demand machinery is internal — drive it through the REST endpoints above (or the web UI buttons). The API handlers (
start_on_demand_display()/stop_on_demand_display()inweb_interface/blueprints/api_v3.py) write a request into the cache manager under thedisplay_on_demand_requestkey, whichDisplayController._poll_on_demand_requests()(src/display_controller.py) picks up. A separatedisplay_on_demand_configkey is used by the controller itself during activation (_activate_on_demand()) to track what's currently running, and is cleared by_clear_on_demand().
Duration Modes
| Duration | Pinned | Behavior |
|---|---|---|
None |
false |
Use plugin's default duration, auto-clear when expires |
0 |
false |
Indefinite, clears manually or on error |
> 0 |
false |
Timed display, auto-clear after N seconds |
| Any | true |
Pin until manually cleared (ignores duration) |
Use Case Examples
Quick check (30-second preview):
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
-H "Content-Type: application/json" \
-d '{"plugin_id": "ledmatrix-weather", "duration": 30}'
Pin important information:
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
-H "Content-Type: application/json" \
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
# ... later ...
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
Indefinite display:
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
-H "Content-Type: application/json" \
-d '{"plugin_id": "text-display", "duration": 0}'
Testing a plugin during development: the same call works, or just click Run On-Demand in the plugin's tab.
Best Practices
For Users:
- Use timed display as default (prevents forgetting to clear)
- Pin only when necessary
- Clear when done to return to normal rotation
For Developers:
- Validate plugin ID exists before calling
- Provide visual feedback in UI (loading state, status updates)
- Handle concurrent requests gracefully
- Log on-demand activations for debugging
Security Considerations
Authentication:
- Add authentication to API endpoints
- Restrict on-demand to authorized users
Rate Limiting:
- Prevent abuse from rapid requests
- Implement cooldown between activations
Input Validation:
- Sanitize plugin IDs
- Validate duration values
- Check plugin exists before activation
3. On-Demand Cache Management
Overview
On-demand display uses cache keys (managed by src/cache_manager.py —
file-based, not Redis) to coordinate state between the web interface
and the display controller across service restarts. Understanding these
keys helps troubleshoot stuck states.
Cache Keys
1. display_on_demand_request (TTL: 1 hour)
{
"request_id": "uuid-string",
"action": "start|stop",
"plugin_id": "plugin-name",
"mode": "mode-name",
"duration": 30.0,
"pinned": true,
"timestamp": 1234567890.123
}
Purpose: Communication from web interface to display controller When Set: API endpoint receives request Auto-Cleared: After processing or 1 hour TTL
2. display_on_demand_config (No TTL)
{
"mode": "mode-name",
"duration": 30.0,
"pinned": true
}
Purpose: Persistent configuration for display controller When Set: Controller processes start request Auto-Cleared: When on-demand stops
3. display_on_demand_state (Continuously updated)
{
"active": true,
"mode": "mode-name",
"remaining": 25.5,
"pinned": true,
"status": "active|idle|restarting|error"
}
Purpose: Real-time state for web interface status card When Set: Every display loop iteration Auto-Cleared: Never (continuously updated)
4. display_on_demand_processed_id (TTL: 1 hour)
"uuid-string-of-last-processed-request"
Purpose: Prevents duplicate request processing When Set: After processing request Auto-Cleared: After 1 hour TTL
When Manual Clearing is Needed
Scenario 1: Stuck in On-Demand State
- Symptom: Display stays on one plugin, won't return to rotation
- Clear:
config,state,request
Scenario 2: Mode Switching Issues
- Symptom: Can't change to different plugin
- Clear:
request,processed_id,state
Scenario 3: On-Demand Not Activating
- Symptom: Button click does nothing
- Clear:
processed_id,request
Scenario 4: After Service Crash
- Symptom: Strange behavior after crash/restart
- Clear: All four keys
Manual Recovery Procedures
Via Web Interface (Recommended):
- Open the Cache tab in the web UI
- Find the
display_on_demand_*entries - Delete them
- Restart display:
sudo systemctl restart ledmatrix
Via Command Line:
The cache is stored as JSON files under one of:
/var/cache/ledmatrix/(preferred when the service has permission)~/.ledmatrix_cache//opt/ledmatrix/cache/$TMPDIR/ledmatrix_cache/(fallback)
# Find the cache dir actually in use
journalctl -u ledmatrix | grep -i "cache directory" | tail -1
# Clear all on-demand keys (replace path with the one above)
rm /var/cache/ledmatrix/display_on_demand_*
# Restart service
sudo systemctl restart ledmatrix
Via Python:
from src.cache_manager import CacheManager
cache = CacheManager()
cache.clear_cache('display_on_demand_config')
cache.clear_cache('display_on_demand_state')
cache.clear_cache('display_on_demand_request')
cache.clear_cache('display_on_demand_processed_id')
CacheManageralso has adelete(key)method — a thin wrapper overclear_cache(key)— socache.delete('display_on_demand_config')works equally well.
Cache Impact on Running Service
IMPORTANT: Clearing cache keys does NOT immediately affect the running controller in memory.
To fully reset:
- Stop the service:
sudo systemctl stop ledmatrix - Clear cache keys (web UI Cache tab or
rmfrom the cache directory) - Clear systemd environment:
sudo systemctl daemon-reload - Start the service:
sudo systemctl start ledmatrix
Automatic Cleanup
The display controller automatically handles cleanup:
- Config key: Cleared when on-demand stops
- State key: Updated every display loop iteration
- Request key: Expires after 1 hour TTL (or after processing)
- Processed ID: Expires after 1 hour TTL
4. Background Data Service
Overview
The Background Data Service enables non-blocking data fetching through background threading. This prevents the main display loop from freezing during slow API requests, maintaining smooth display rotation.
Benefits
Performance:
- Display loop never freezes during API calls
- Immediate response with cached/partial data
- Complete data loads in background
User Experience:
- No "frozen" display during data updates
- Smooth transitions between plugins
- Faster perceived load times
Architecture:
Cache Check → Background Fetch → Partial Data → Completion → Cache
(0.1s) (async) (<1s) (10-30s) (cache)
Configuration
Enable background service per plugin in config/config.json:
{
"football-scoreboard": {
"enabled": true,
"background_service": {
"enabled": true,
"max_workers": 3,
"request_timeout": 30,
"max_retries": 3,
"priority": 2
}
}
}
Configuration Options:
| Setting | Default | Description |
|---|---|---|
enabled |
false |
Enable background service for this plugin |
max_workers |
3 |
Max concurrent background tasks |
request_timeout |
30 |
Timeout per API request (seconds) |
max_retries |
3 |
Retry attempts on failure |
priority |
1 |
Task priority (1=highest, 10=lowest) |
Performance Impact
First Request (Cache Empty):
- Returns partial data: < 1 second
- Background completes: 10-30 seconds
- Subsequent requests use cache: < 0.1 seconds
Subsequent Requests (Cache Hit):
- Returns immediately: < 0.1 seconds
- Background refresh (if stale): async, no blocking
Plugins using the background service
The background data service is used by all of the sports scoreboard
plugins (football, hockey, baseball/MLB, basketball, soccer, lacrosse,
F1, UFC), the odds ticker, and the leaderboard plugin. Each plugin's
background_service block (under its own config namespace) follows the
same shape as the example above.
Error Handling & Fallback
Automatic Retry:
- Exponential backoff (1s, 2s, 4s, 8s, ...)
- Maximum retry attempts configurable
- Logs all retry attempts
Fallback Behavior:
- If background service disabled: reverts to synchronous fetching
- If background fetch fails: returns cached data
- If no cache: returns empty/error state
Testing
# Check logs for background operations
sudo journalctl -u ledmatrix -f | grep "background"
Monitoring
View Statistics:
from src.background_data_service import get_background_service
from src.cache_manager import CacheManager
service = get_background_service(CacheManager())
stats = service.get_statistics()
print(f"Active tasks: {stats['active_tasks']}")
print(f"Completed: {stats['completed']}")
print(f"Failed: {stats['failed']}")
Enable Debug Logging:
import logging
logging.getLogger('src.background_data_service').setLevel(logging.DEBUG)
5. Permission Management
Overview
LEDMatrix uses a dual-user architecture: the display service runs as root (hardware access), while the web interface runs as a non-privileged user. Centralized permission management ensures both can access necessary files.
Why It Matters
Problem:
- Root service creates files with root ownership
- Web user cannot read/write those files
- Results in
PermissionErrorexceptions
Solution:
- Set group ownership to shared group
- Grant group write permissions
- Use setgid bit for automatic inheritance
Permission Utilities
from src.common.permission_utils import (
ensure_directory_permissions,
ensure_file_permissions,
get_config_file_mode,
get_assets_file_mode,
get_assets_dir_mode,
get_plugin_file_mode,
get_cache_dir_mode
)
# Create directory with correct permissions
ensure_directory_permissions(Path("assets/sports"), get_assets_dir_mode())
# Set file permissions after writing
# (get_config_file_mode requires the file path — secrets files get a
# stricter mode than the main config)
config_path = Path("config/config.json")
ensure_file_permissions(config_path, get_config_file_mode(config_path))
When to Use Utilities
Use permission utilities when:
- Creating new directories
- Writing configuration files
- Downloading/creating asset files (logos, fonts)
- Creating plugin files
- Writing cache files
Don't use for:
- Reading files (permissions don't change)
- Temporary files in
/tmp - Files in already-managed directories (if parent has setgid)
Permission Standards
File Permissions:
| File Type | Mode | Octal | Description |
|---|---|---|---|
| Config (main) | rw-r--r-- |
0o644 |
Owner write, all read |
| Config (secrets) | rw-r----- |
0o640 |
Owner write, group read |
| Assets | rw-rw-r-- |
0o664 |
Owner/group write, all read |
| Plugins | rw-rw-r-- |
0o664 |
Owner/group write, all read |
| Cache files | rw-rw-r-- |
0o664 |
Owner/group write, all read |
Directory Permissions:
| Directory Type | Mode | Octal | Description |
|---|---|---|---|
| All directories | rwxrwsr-x |
0o2775 |
With setgid bit for inheritance |
Note: The s in rwxrwsr-x is the setgid bit (2000), which makes new files inherit the directory's group ownership.
Common Patterns
Pattern 1: Creating Config Directory
from pathlib import Path
from src.common.permission_utils import ensure_directory_permissions, get_config_dir_mode
config_dir = Path("config/plugins")
ensure_directory_permissions(config_dir, get_config_dir_mode())
Pattern 2: Saving Config File
from src.common.permission_utils import ensure_file_permissions, get_config_file_mode
config_path = Path("config/config.json")
with open(config_path, 'w') as f:
json.dump(data, f)
ensure_file_permissions(config_path, get_config_file_mode(config_path))
Pattern 3: Downloading Logo
from src.common.permission_utils import ensure_directory_permissions, ensure_file_permissions
from src.common.permission_utils import get_assets_dir_mode, get_assets_file_mode
logo_path = Path("assets/sports/nhl/logo.png")
ensure_directory_permissions(logo_path.parent, get_assets_dir_mode())
# ... download and save logo ...
ensure_file_permissions(logo_path, get_assets_file_mode())
Pattern 4: Creating Plugin File
from src.common.permission_utils import ensure_file_permissions, get_plugin_file_mode
plugin_file = Path("plugins/my-plugin/data.json")
with open(plugin_file, 'w') as f:
json.dump(data, f)
ensure_file_permissions(plugin_file, get_plugin_file_mode())
Pattern 5: Cache Directory Setup
from src.common.permission_utils import ensure_directory_permissions, get_cache_dir_mode
cache_dir = Path("cache/plugin-name")
ensure_directory_permissions(cache_dir, get_cache_dir_mode())
Integration with Core Utilities
These core utilities already handle permissions - you don't need to call permission utilities when using them:
- ConfigManager - Handles config file permissions
- CacheManager - Handles cache file permissions
- LogoHelper - Handles logo file permissions
- PluginManager - Handles plugin file permissions
Manual Fixes
If you encounter permission issues:
# Targeted permission fixes (see scripts/fix_perms/README.md)
sudo ./scripts/fix_perms/fix_assets_permissions.sh # assets/ tree (logos, fonts)
sudo ./scripts/fix_perms/fix_cache_permissions.sh # all cache directories
sudo ./scripts/fix_perms/fix_plugin_permissions.sh # plugin directories
sudo ./scripts/fix_perms/fix_web_permissions.sh # web interface files
# Fix specific directory
sudo chown -R ledpi:ledpi /home/ledpi/LEDMatrix/config
sudo chmod -R 2775 /home/ledpi/LEDMatrix/config
sudo find /home/ledpi/LEDMatrix/config -type f -exec chmod 664 {} \;
# Verify permissions
ls -la config/
ls -la assets/
Verification
# Check directory has setgid bit
ls -ld assets/
# Should show: drwxrwsr-x (note the 's')
# Check file has correct group
ls -l assets/logo.png
# Should show group 'ledpi'
# Check file permissions
stat -c "%a %n" config/config.json
# Should show: 644 config/config.json
Related Documentation
- PLUGIN_DEVELOPMENT_GUIDE.md - Creating plugins with Vegas/on-demand support
- WEB_INTERFACE_GUIDE.md - Using on-demand controls in web UI
- PLUGIN_API_REFERENCE.md - Complete API documentation
- DEVELOPMENT.md - Development environment and testing