mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 22:35:08 +00:00
* fix(sports): share the ESPN rejected-range memo with the background service BackgroundDataService always sent a season range first and, on a 400, fell back to chunks without recording the rejection, so every background season fetch spent a doomed request and live scoreboards learned nothing from it (or it from them). The worker now consults and sets the same 6-hour memo fetch_espn_scoreboard() uses: a known rejection goes straight to month/day chunks, and if every chunk fails the range is asked once for a real error without re-spending the chunks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): keep plugin asset and action routes inside their directories POST /plugins/assets/upload, GET /plugins/assets/list and POST /plugins/assets/delete joined the request's plugin_id onto assets/plugins unchecked, so '../../config' created, wrote, listed and deleted outside it. #561 guarded only the route that serves the files. All three now go through path_safety.resolve_under and answer 400 for anything but a plain name, and delete only unlinks a metadata path that resolves into that plugin's uploads directory. PluginManager.get_plugin_directory refuses ids that are not one plain path segment, so /plugins/action (which runs a manifest script from the returned directory) and every other caller get the guard; the action route also rejects such ids up front, covering its no-manager fallback. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): report a no-op plugin update as already up to date update_plugin() returns True both for a real update and for "nothing to do" (a ZIP-installed monorepo plugin already at the registry version, a bundled plugin). With no git commit to compare, POST /plugins/update called every such success "updated successfully", so Check & Update All counted most official plugins as updated on every run. The route now reads what changed off the plugin itself (commit, else manifest version, else last_updated) and returns data.update_status (updated / up_to_date / local_only). The update-all toast is summarised by PluginInstallManager.summarizeUpdateResults from that status, falling back to the message for older servers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(sports): scoreboard scroll speed no longer follows target_fps sports_scroll computed the crisp speed ladder against the global target_fps whenever limit_refresh_rate_hz was the 100 Hz default. Since frame-locked presentation (#545) the helper steps a fixed number of whole pixels per presented frame and the panel presents at its real refresh, so the General tab's "Scroll Frame Rate" became a speed multiplier: 60 ran a 50 px/s scoreboard at 100 px/s, 200 ran it at 25 px/s. The ladder now uses the display manager's refresh_hz, then display.hardware.limit_refresh_rate_hz, then the default. target_fps is not consulted. Docstrings now say scroll_delay is ignored for pacing (no behaviour change there) and describe the fixed-step model. Tests: replace the tests that pinned target_fps as the ladder refresh and described time-based stepping; assert speed independence from target_fps (unit and end-to-end presented px/s against the real helper), that the fixed per-frame step is applied, and that scroll_delay does not change speed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): escape registry and upload values in plugin manager inline handlers The store, saved-repository and custom-registry buttons built onclick='...(${JSON.stringify(id)})...'. JSON.stringify leaves ' alone, so a custom registry entry whose id contained ' closed the attribute and added its own handler. One helper, jsStringAttr(), now HTML-escapes the JSON literal for every one of those handlers, and the store View button opens only http(s) repo links. The live window.updateImageList (plugins_manager.js loads last, so its copy wins over the file-upload widget's) wrote the uploaded file's original name, path and ids into markup raw; they are escaped now. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): note plugin asset, action and inline handler guards Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(update): let the root pip wrapper install web_interface/requirements.txt Update Code, the automatic update's health check and Install Base Requirements install web_interface/requirements.txt through safe_pip_install.sh, which only allowed the root requirements.txt. The first commit changing that file would fail its dependency install, and the automatic updater rolls back any update whose dependencies did not install -- on every device, for every newer commit. The wrapper now lists both core requirement files. Only their folders are resolved, so a requirements.txt symlinked out of the project is compared by its target and refused (previously the root file's own symlink target was what got allowed). The updater's file list is a named constant, and a test runs the real wrapper (pip stubbed) on every file Update Code and the rollback install. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): do not retry plugin requests that got an HTTP answer PluginAPI.request wrapped everything that was not a structured error as NETWORK_ERROR: a proxy's 502 HTML page (response.json() throws) and a JSON error without error_code included. Check & Update All retries NETWORK_ERROR, so those updates were re-sent five more times with backoff, contrary to the #587 contract that an HTTP error response is the server's answer. NETWORK_ERROR now means only that fetch() rejected. Any HTTP response without an error_code, or with a body that is not JSON, is API_ERROR with the HTTP status attached. Tested against the shipped api_client.js. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scroll): restart the stats window when an idle gap is dropped by size #582 dropped an idle gap from the frame stats two ways: the reset_scroll() sentinel, which also restarts the 5s window timer, and a size guard for scrollers that never call reset_scroll(), which did not. On that path the first real frame after the gap found the boundary overdue and logged a stats line for a one-frame window. Both paths now share one seeding helper. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(update): leave plugins alone when update_core's own rollback fails update_core returns rollback_failed directly when a partial pull or an update whose health check never started cannot be rolled back. run() only held plugins back for 'verifying', so those devices still got new plugin versions and a display restart on top of a core in an unknown state -- the opposite of what the health-check path does, and of the 3.4.0 changelog (plugins are left alone if the rollback fails). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(api): make the REST reference match the api_v3 package Every documented request body, query parameter and response shape was re-checked against the handlers in web_interface/blueprints/api_v3/. Fixes calls that failed as documented (repo_url, action_id/params, files/image_id, font_file+font_family, ?font=, cache key, auto_enable_ap_mode, plugin limit keys), removes the font-override endpoints dropped in #566, corrects response shapes (plugins/config, plugins/schema, health, metrics, operation history, github-status, fonts/catalog, cache/list, logs, wifi, on-demand, SSE streams), and adds the 26 routes it omitted (backup, system auto-update/git, wifi radio, starlark editor, MQTT bridge, status endpoints, skins). Documents the merge semantics of partial JSON saves to /config/main and /plugins/config and the dim-schedule POST accepting GET's days shape, which land in the same change set. Replaces app.py line numbers and the removed api_v3.py path with file and function names. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): remove the General-tab plugin system toggles that did nothing plugin_system.auto_discover, auto_load_enabled and development_mode had General-tab toggles whose help tips promised dormant plugins and verbose logging, but nothing reads them: every enabled plugin is discovered and loaded regardless. Remove the three toggles. The keys stay tolerated in stored configs. The save handler now stores a flag only when a client sends it; treating a missing key as an unchecked box would otherwise rewrite all three to false on every General-tab save, which still posts plugins_directory. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(scroll): remove dead code left by #523/#570 - Drop the optional scipy.ndimage import and HAS_SCIPY; nothing read them since the numpy blend replaced the scipy path. - Drop ScrollHelper._last_integer_position and frame_time_target, which were written but never read. - Keep target_fps and set_target_fps() but document them as informational: nothing paces off them, yet ledmatrix-elections' test_scroll_pacing.py reads helper.target_fps back and third-party plugins may call the setter. - Fix stale comments: fixed_pixels_per_frame's "use scroll_delay to throttle", set_sub_pixel_scrolling's "default: True", and set_frame_based_scrolling's claim that it steps. The plugins monorepo was grepped for every removed name; none is used. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(fonts): point plugins at plugin_manager.font_manager; drop removed overrides UI FONT_MANAGER.md told plugins to read display_manager.font_manager, which does not exist, so a plugin following it failed to load with AttributeError. The shared FontManager lives on the PluginManager and BasePlugin._get_font_manager() returns it (with a fallback for harnesses). Also removes the Fonts-tab override workflow and element-override panels that #566 deleted, from FONT_MANAGER.md and WEB_INTERFACE_GUIDE.md. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(store): search via /plugins/store/list?query=; send Content-Type on registry curls /plugins/store/search does not exist (404) and the list endpoint reads query, not q. The registry guide's curl examples omitted the JSON Content-Type, so the handlers saw an empty body and answered 400. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(config): use the shared core-key list in the last three private copies StartupValidator warned "Plugin 'auto_update' is enabled but not found" on every display start with auto-update or a dim schedule on; the reserved plugin-id check missed auto_update, sync, location and the rest; and ConfigManager's (uncalled) orphan cleanup would have deleted display, schedule and auto_update. All three now read src/core_config_keys.py, which also gains CORE_SECRETS_KEYS for the github/youtube secrets sections. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): partial JSON saves to /config/main change only what they send A JSON body with one field reset every checkbox in the sections it touched: the MQTT bridge's brightness slider turned off disable_hardware_pulsing, inverse_colors, show_refresh_rate and use_short_date_format, and a timezone-only save turned off web-UI autostart and weekly auto-updates. Missing-means-unchecked now applies only to form posts: form-encoded bodies and the v3 forms, which mark themselves with a hidden __form_section input. Also on the config routes: - vegas_min/max_cycle_duration no longer match the generic *_duration rule, so they stop landing in display_durations and a blank one no longer rejects the whole Display save; - saving from the Raw JSON editor calls start_setup_if_needed like the General form, so enabling auto-update there finishes its setup; - the schedule and dim-schedule POSTs accept the per-day days.<day> shape their GETs return, as well as the flat form keys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scripts): install plugin dependencies from the configured plugins directory install_plugin_dependencies.sh scanned only plugins/, but the Plugin Store installs into plugin_system.plugins_directory (default plugin-repos), so the documented "Recommended" fix found 0 plugins on every store install. It now reads plugins_directory from config/config.json (relative to the project root or absolute, default plugin-repos) and also scans plugins/ for dev symlinks, installing a plugin reached through both only once. With set -e alone, `pip ... | tee` took tee's exit status, so a failed pip install was reported as success; set -o pipefail. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: replace stale API names, line numbers and the api_v3.py path - ADVANCED_FEATURES: StreamManager methods that exist (get_next_segment, take_next_group, refresh, advance_cycle, ...), and the real on-demand status envelope ({status, data: {state, service}}) - app.py:199 / :144 / :607-619 line citations and web_interface/blueprints/api_v3.py (now a package) replaced with file and function names in ADVANCED_FEATURES, CONFIG_DEBUGGING, PLUGIN_ARCHITECTURE_SPEC, PLUGIN_QUICK_REFERENCE, PLUGIN_CONFIGURATION_TABS, TROUBLESHOOTING and web_interface/README - CONFIG_DEBUGGING: partial /config/main saves change only sent keys; use /config/raw/main to replace the file; describe where validation runs - TROUBLESHOOTING: clear_cache.py needs --clear-all (no args only prints usage) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scripts): verify the web interface that actually ships, on port 5000 verify_installation.sh failed every healthy install: it required the long-removed web_interface_v2.py and looked for a listener on port 5001, while the web interface binds 5000 (web_interface/start.py). It now checks the files ledmatrix-web.service runs (start_web_conditionally.py, web_interface/start.py, app.py) and port 5000. verify_web_ui.sh had the same 5001 port in its listen check, HTTP probe and printed URLs. Port matches are anchored so :50001 no longer counts as :5000. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(plugins): one display-size contract: display_manager.width/height CLAUDE.md (#580) says to read display_manager.width/height because matrix is None when hardware init fails; the development guide, the safety-harness doc and two DisplayManager docstrings still recommended matrix.width/height. The bundled starlark-apps plugin read matrix.width unguarded, so its magnify recommendation and frame scaling raised in fallback mode (e.g. after the Pi 5 hardware refusal). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(install): make install_service.sh --help print usage instead of installing install_service.sh parsed no arguments, so `sudo ./scripts/install/ install_service.sh --help` (presented as harmless in MIGRATION_GUIDE.md) rewrote ledmatrix.service, ledmatrix-web.service and both update-verify units and enabled/started them. It now handles -h/--help (usage, exit 0, no changes) and rejects any other argument with exit 2 before doing anything. Running it with no arguments, as first_time_install.sh does, is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(scroll): describe the fixed-step model and document frame_hold Since #545 a crisp speed from scroll_config.configure() makes the helper advance a fixed whole-pixel step per presented frame with no clock, and the display manager's frame hold is part of the speed. The docs still described the removed wall-clock model: - scroll_config's module and configure() docstrings said speed is applied in time-based mode and that omitting the hold "falls back to fractional pixels"; omitting it actually runs the scroll frame_hold times too fast. - SCROLL_PERFORMANCE.md said ScrollHelper accumulates elapsed time in both modes, and read a 20 ms stats median as missed refreshes although that is a healthy 50 px/s (hold 2) scroll. It now explains the fixed step, the hold-dependent healthy median, that target_fps plays no part, and that a hand-added scroll_pixels_per_second loses to a schema-default pair. - PLUGIN_API_REFERENCE.md documented set_scrolling_state(is_scrolling) without frame_hold; it now documents the parameter (core 3.4.0) with a configure() + set_scrolling_state example. - update_scroll_position/set_scroll_speed and set_scrolling_state docstrings say the same. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(config): mark target_fps legacy; describe what Vegas scroll_delay does - General tab "Scroll Frame Rate" (target_fps) is labelled legacy: after the sports_scroll fix nothing in core scrolling reads it. The field and its API validation stay so saved configs and plugins that read global_config['target_fps'] keep working. CONFIG_REFERENCE says the same. - Vegas frame_based_scrolling/scroll_delay were described as frame-count stepping at ~50 FPS. Neither steps nor sets a frame rate: frame-based mode converts the speed to px per scroll_delay, clamps it to 0.1-5, and still advances by elapsed time, so the applied speed is clamp(scroll_speed * scroll_delay, 0.1, 5) / scroll_delay px/s. The config comments, render_pipeline comment and CONFIG_REFERENCE rows now say so. No behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(deps): describe how plugin dependencies are really installed The guides said the web service runs as root, that installs pick --user from os.geteuid(), and quoted a warning and a PluginManager._install_plugin_dependencies() method that don't exist. The web unit runs as the installing user; store installs go through install_requirements_file() and sudo safe_pip_install.sh (root), with a user-level fallback that says so, and load-time installs run in the display service's own (root) interpreter. Manual paths now use the configured plugins directory (plugin-repos/ by default) instead of plugins/, which store installs no longer use, and install_plugin_dependencies.sh is described as scanning that directory. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(update): count local changes one way for the preflight and the pull The automatic update's preflight ignored mode-only changes and anything whose status line contained plugins/ or plugin-repos/, then promised "Automatic updates will not stash your changes". perform_core_update used plain git status (modes count) and ignored only 'plugins/', then ran 'git stash push -- :!plugins', which nothing ever pops. So an edit to a bundled plugin under plugin-repos/, or the installer's chmods on tracked scripts, passed the preflight and was stashed away for good. - auto_update.local_changes() is the one predicate both use: core.fileMode=false, porcelain -z, and plugins/ and plugin-repos/ excluded by leading folder rather than substring (a core file under web_interface/static/v3/js/plugins/ now counts). - Update Code's explicit stash leaves out both plugin folders; the pull's --autostash carries their edits and mode changes across and reapplies them. - The automatic updater calls perform_core_update(stash_local_changes= False), which refuses instead of stashing edits that appeared after the preflight; update_core reports that as 'blocked'. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scripts): diagnostics follow the web autostart default and api_v3 package #556 made a missing web_display_autostart mean "start" (only an explicit false/off keeps the web interface down), but the diagnostics still said otherwise: diagnose_web_ui.sh reported a missing key as "defaults to false", diagnose_web_interface.sh said the web interface "will not start unless this is set to true" and recommended enabling it, and debug_web_manual.py printed False. Troubleshooting a down web UI pointed users at a non-cause. Both shell scripts now evaluate the setting with the launcher's own autostart_enabled() (inline fallback if it cannot be imported) and report on / off / not set (on) / unparseable config; debug_web_manual.py uses the same function. They also check web_interface/blueprints/api_v3/ __init__.py: api_v3.py became a package in #553, so every healthy checkout was reported as missing a file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(install): what install_service.sh installs; verify script port; no sudo for --help install_service.sh installs and starts ledmatrix, ledmatrix-web and the update-verify units, not only ledmatrix.service (systemd/README.md, README.md). MIGRATION_GUIDE presented 'sudo install_service.sh --help' as a harmless check; it now shows --help without sudo and warns what a real run does. SSH_UNAVAILABLE_AFTER_INSTALL: verify_installation.sh checks the web interface on port 5000. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): note update-all, plugin system settings and script fixes Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(display): size the preview after orientation and pixel mappers display_geometry.physical_size claimed to give DisplayManager's answer but only computed cols*chain x rows*parallel. RGBMatrix.width/height are measured after the library's pixel mappers, so a Rotate:90 / orientation 90 chain previewed 128x32 for a 32x128 panel and a U-mapper chain of four 256x32 for 128x64. Model the built-in mappers' size effect as the pinned lib/pixel-mapper.cc does (Rotate, U-mapper, V-mapper, StackToRow, Remap; Mirror and unknown names leave it alone), and move the orientation composition here so DisplayManager and the preview share it. The module docstring no longer claims the sync handshake uses it; that imports only DEFAULT_CHAIN_LENGTH. Audit finding F18. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(display): refuse settings the rgbmatrix library aborts on, on every board The library answers several settings with a NULL matrix or abort() rather than an error, so the display service crash-looped (Restart=on-failure) instead of reaching fallback mode: rows above 64, chain_length above 255 (uint8_t binding setter, documented as "no upper limit"), a misspelled hardware_mapping, and parallel 2-3 on a single-output mapping, reachable from the Display form on the default adafruit-hat(-pwm) mapping. #586 only guarded the Pi 5 subset. - src/matrix_support.py holds the rules for every board (Options::Validate ranges, binding integer types, mapping names and outputs from lib/hardware-mapping.c) plus the Pi 5 ones, and is the one source of the API's numeric ranges. - DisplayManager checks them before building options and raises MatrixSettingsRefused, so a hand-edited config falls back with a logged, reported reason. Emulator mode only warns. - The config API refuses them with a 400 naming the setting; combinations are checked against stored values but reported only when the request sets a field involved. - The hardware status file gains "cause" (settings/library/forced). The fallback log and Display banner give the Pi 5 rebuild hint only for a library failure instead of rebuild + gpio_slowdown advice for every failure; one Pi 5 slowdown recommendation (1-3, start at 1). - The Display form offers classic/classic-pi1 and orientation 90/270 and renders any other stored mapping selected with a warning, so an unrelated save no longer rewrites them; the API accepts 90/270. Audit findings F03, F16, F19, F21. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(display): library limits, template defaults and Pi 5 slowdown - rows 8-64, chain_length 1-255, parallel limited by the mapping's outputs, classic/classic-pi1 mappings and orientation 90/270 documented. - Defaults are the config.template.json values: config migration adds missing keys from the template, so the listed "code defaults" never applied. - One Raspberry Pi 5 gpio_slowdown recommendation: 1-3 in PIO mode, starting at 1. - Troubleshooting describes the refused-settings fallback, and CHANGELOG corrects the Unreleased "no upper limit" entry. Audit findings F19, F20, F21. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scripts): scroll_speeds.py opens the panel with the service's options --measure and --demo built RGBMatrixOptions from a private copy of the display service's builder that had drifted: gpio_slowdown came from display.hardware (default 2) instead of display.runtime (default 3), and rp1_rio, panel_type, disable_hardware_pulsing, inverse_colors, pixel_mapper_config and orientation were skipped, with different defaults (hardware_mapping "regular", pwm_bits 11). A panel needing a high slowdown was measured -- or garbled -- in a setup the service never drives. The option filling in DisplayManager._setup_matrix moves, unchanged, into DisplayManager.apply_matrix_options(options, config), which _setup_matrix calls and the script reuses (overriding only limit_refresh_rate_hz for --measure). The script now loads the whole config rather than the hardware block. Tests pin the script's options to the service's attribute for attribute. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(scripts): scroll_speeds.py recommends keys the resolver honours The ladder ended by telling users to set display_options.scroll_pixels_per_second. scroll_config ranks that key below the scroll_speed + scroll_delay pair, deliberately, and several plugin schemas default the pair into config, so the advised key was silently ignored (a schema-default 1/0.02 pair plus an advised 66 still resolved to 50 px/s). The advice is now the pair that selects the crisp speed exactly (pixels_per_frame every frame_hold/refresh seconds), explains that the pair outranks scroll_pixels_per_second, and gives the scoreboards' per-league scroll_settings.scroll_speed (px/s) form. Tests resolve the printed pair over a schema-default pair and check it lands on the advertised speed and hold. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs: withdraw the target_fps claim for sports_scroll; fix the Vegas speed formula - SPORTS_UNIFICATION.md still presented honouring global target_fps as sports_scroll's added behaviour and its one user-visible gain; note that it was withdrawn because it had become a speed multiplier. - ADVANCED_FEATURES.md gave Vegas scrolling as (scroll_speed / target_fps) * elapsed; the real rule is scroll_speed px/s by elapsed time, through a 0.1-5 px per scroll_delay clamp when frame_based_scrolling is on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): scroll model fixes Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(dev): link-github links plugins from the ledmatrix-plugins monorepo link-github <name> cloned https://github.com/ChuckBuilds/ledmatrix-<name>.git, and those per-plugin repositories no longer exist: official plugins are directories in the ledmatrix-plugins monorepo. It now clones (or pulls) the monorepo once into the dev directory, finds plugins/<name>, plugins/ledmatrix-<name> or the plugin whose manifest id is <name>, and links it under its manifest id. With an explicit repo URL it still links a single-repository plugin as before. dev_plugins.json: github_user is honoured again (monorepo owner, e.g. a fork), plus plugins_repo and plugins_branch; github_pattern, which was documented but never read, is dropped and warned about. Ships dev_plugins.json.example and git-ignores dev_plugins.json, both of which the guide promised. Reading JSON falls back to python3 when jq is missing (get_plugin_id silently returned nothing without jq). update/status/list find the git checkout above a monorepo plugin directory (its .git is not in the plugin dir), and update pulls a shared checkout once. status no longer exits 1 when nothing is broken. Docs: PLUGIN_DEVELOPMENT_GUIDE (quick start, link-github, configuration, workflow, store integration, hello-world link, submission), and the nonexistent scripts/git-hooks/pre-push-plugin-version and scripts/bump_plugin_version.py replaced with the real rule: bump the manifest version and run update_registry.py. scripts/dev/README.md and CLAUDE.md updated to match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(scripts): monorepo workspace layout; fix_perms and install READMEs MULTI_ROOT_WORKSPACE_SETUP described one sibling repository per plugin; setup_plugin_repos.py links ../ledmatrix-plugins/plugins/* into plugin-repos/ and update_plugin_repos.py pulls only the monorepo, and the workspace file opens LEDMatrix plus ../ledmatrix-plugins. scripts/fix_perms/README.md listed cache directories fix_cache_permissions.sh never touches and a 'ledmatrix' service user that doesn't exist (also in scripts/install/README.md); adds safe_pip_install.sh. install/README: install_service.sh installs the web and update-verify units too. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(update): keep the rollback's pip retries inside the unit time limit The health check reinstalled the previous requirements by trying the next bash path after any failure, including a 600 s pip timeout. Two files, two paths: up to 40 minutes of pip alone, while systemd stops ledmatrix-update-verify.service at TimeoutStartSec=30min -- killing the rollback half-way and leaving the update 'verifying' until the web UI calls it lost. - Like permission_utils.install_requirements_file, only a sudo refusal moves on to the next bash; a pip that ran and failed or timed out is not repeated. The refusal wording is one list (permission_utils.SUDO_REFUSAL_PHRASES), mirrored in the stdlib-only verifier and pinned equal by a test. - All reinstalls in one rollback share a 600 s budget. - WORST_CASE_SECONDS adds up every timeout on the longest path (27.5 min); a test holds it under the unit's TimeoutStartSec and that under the web UI's VERIFY_LOST_SECONDS. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(plugins): prepare plugin configs one way for load, saves, GET, hot reload and dev tools Plugin config was prepared differently depending on how it arrived: - JSON POST /plugins/config built a partial body on schema defaults, so {"enabled": true} reset every other setting of the plugin. It now merges onto the stored section first, as the form path already did. - Legacy-boolean normalization (#588) ran only at load: GET /plugins/config returned the raw boolean, posting it back failed validation, and hot reload handed plugins the raw section (a legacy dynamic_duration: true came back as a boolean). schema_manager.prepare_plugin_config (normalize, then defaults) is now used by PluginManager.load_plugin, both save paths, GET, the save notifications and DisplayController's hot-reload callback. - The JSON save's filter kept only enabled/display_duration/live_priority and dropped a submitted skin, skin_options or vegas_* tuning key. There is now one core-owned per-plugin list, schema_manager.CORE_PLUGIN_PROPERTIES, used by validation and by the save filter; PluginManager's CORE_OWNED_CONFIG_KEYS is its vegas subset. - Plugin sections posted to /config/main were stored verbatim, including values /plugins/config rejects. They now go through the same preparation (_prepare_plugin_config_for_save, extracted from save_plugin_config), and a failing section rejects the whole save before anything is written. - dev_server read only top-level defaults and let a schema enabled:false win; build_full_config shallow-merged overrides, dropping sibling defaults; the harness extracted defaults differently from the device. loading.build_config now uses the device's extraction and preparation, and dev_server, check_plugin, render_plugin and the harness all use it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(mqtt-bridge): brightness changes apply live and touch nothing else The display service's hot reload applies a saved brightness within a few seconds, and /config/main no longer resets other display settings on a brightness-only JSON body. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): automatic update hardening Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(config): rewrite PLUGIN_CONFIG_ARCHITECTURE for the v3 web UI It described web_interface_v2.py and index_v2.html (both gone), client-side form generation, one POST per field with {key, value}, and 'no nested objects'. The v3 UI renders plugin forms server-side from the schema (pages_v3 partial + plugin_config.html macros, nested sections and x-widgets), posts the whole form once, and save_plugin_config() merges onto the stored section, validates, splits x-secret fields and notifies the plugin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(mqtt): brightness saves apply via hot reload and leave other settings alone The bridge README said brightness is applied on the display's next restart; the display controller's config hot reload applies it within seconds. It also now states that the bridge's partial JSON save changes only brightness (the /config/main merge fix in this change set). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(update): don't log pip's output from the health check's reinstall pip can echo a private index URL with embedded credentials; permission_utils redacts it, the stdlib-only verifier cannot, so it logs the exit code only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(config): mark the plugin_system toggles as unused legacy keys auto_discover, auto_load_enabled and development_mode are read by nothing and leave the General tab in this change set (F40). CONFIG_REFERENCE said they were read by the plugin loader; PLUGIN_CONFIGURATION_GUIDE and the REST reference listed them as live settings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): docs and developer tools group Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): legacy plugin-system toggles no longer count as a General save auto_discover, auto_load_enabled and development_mode have left the General form, so a post carrying only one of them is not a general-settings save and must not treat web_display_autostart and auto_update as unchecked. The plugin_system block itself is left as on main for the branch that reworks it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(changelog): config-save and plugin-config preparation fixes Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(claude): re-check matrix_support.py rules when the library submodule is bumped Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix: address Codacy findings on the core audit PR - plugin_manager.prepare_plugin_config: when the fallback legacy-boolean pass also fails, log a warning instead of a bare except/pass. - api_client.js: request() refuses any endpoint that is not a plain path under /api/v3 ("//host", backslashes, ".." or "." segments, whitespace, control characters) with INVALID_ENDPOINT before calling fetch(), and plugin ids are URL-encoded wherever they are put into a URL (also in the app-shell batch load). - test_update_all.js: pins both against the shipped client. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): check endpoint control characters without a control-character regex Codacy (ESLint no-control-regex, Biome noControlCharactersInRegex) flags the \x00-\x1f range in checkEndpoint's regex. Test the char codes instead; the endpoints refused are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test(auto-update): make the seed script executable on disk, not only in the index On Linux Repo.publish() commits with -a, which recorded scripts/run.sh as 100644 upstream because the seed file was never chmod +x. The pull then brought in the same mode the installer chmod had made locally, so installer_chmod saw no mode change left to check. The updater was fine: with the upstream commit at 100755 the --autostash carries the device's chmod across. Verified under Linux (WSL, git 2.43): the old helper fails exactly as CI did, the fixed one passes all 63 tests in the file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
1155 lines
36 KiB
Markdown
1155 lines
36 KiB
Markdown
# Advanced Features Guide
|
||
|
||
This guide covers advanced LEDMatrix features for users and developers, including Vegas scroll mode, on-demand display, cache management, background services, and permission management.
|
||
|
||
---
|
||
|
||
## 1. Vegas Scroll Mode
|
||
|
||
### Overview
|
||
|
||
Vegas scroll mode displays content from multiple plugins in a continuous horizontal scroll, similar to news tickers seen in Las Vegas casinos. Plugins contribute content segments that flow across the display in a seamless ticker-style presentation.
|
||
|
||
### Display Modes
|
||
|
||
**SCROLL (Continuous Scrolling):**
|
||
- Content scrolls continuously left
|
||
- Smooth, fluid motion
|
||
- Best for news-ticker style displays
|
||
|
||
**FIXED_SEGMENT (Fixed-Width Block):**
|
||
- Plugin gets fixed-width block on display
|
||
- Content doesn't scroll out of its segment
|
||
- Multiple plugins can share the display simultaneously
|
||
|
||
**STATIC (Scroll Pauses):**
|
||
- Scrolling pauses when content is fully visible
|
||
- Displays for specified duration, then resumes scrolling
|
||
- Best for content that needs to be fully read
|
||
|
||
### Configuration
|
||
|
||
Enable Vegas mode in `config/config.json`:
|
||
|
||
```json
|
||
{
|
||
"display": {
|
||
"vegas_scroll": {
|
||
"enabled": true,
|
||
"scroll_speed": 50,
|
||
"separator_width": 32,
|
||
"plugin_order": ["clock", "weather", "sports"],
|
||
"excluded_plugins": ["debug_plugin"],
|
||
"target_fps": 125,
|
||
"buffer_ahead": 2
|
||
}
|
||
}
|
||
}
|
||
```
|
||
|
||
Vegas mode can also be configured entirely from the web UI — the
|
||
**Display** tab has a Vegas Scroll Mode section (enable toggle, scroll
|
||
speed, separator width, dynamic duration, and more), so hand-editing
|
||
JSON is optional.
|
||
|
||
**Configuration Options:**
|
||
|
||
| Setting | Default | Description |
|
||
|---------|---------|-------------|
|
||
| `enabled` | `false` | Enable Vegas scroll mode |
|
||
| `scroll_speed` | `50` | Pixels per second scroll speed |
|
||
| `separator_width` | `32` | Width between plugin segments (pixels) |
|
||
| `plugin_order` | `[]` | Plugin display order (empty = auto) |
|
||
| `excluded_plugins` | `[]` | Plugins to exclude from Vegas mode |
|
||
| `target_fps` | `125` | Target frame rate |
|
||
| `buffer_ahead` | `2` | Number of plugins buffered ahead |
|
||
|
||
This table is a subset — `display.vegas_scroll` supports 30 keys in
|
||
total. See the full list in
|
||
[CONFIG_REFERENCE.md](CONFIG_REFERENCE.md#displayvegas_scroll--continuous-scroll-mode).
|
||
|
||
### Live Content in the Ticker
|
||
|
||
By default, live content **preempts** Vegas mode: while any plugin reports
|
||
live priority, the display controller refuses to run the ticker and shows
|
||
that plugin's full-screen display instead. You get a big readable scoreboard,
|
||
but the marquee stops entirely for the duration of the game.
|
||
|
||
Set `live_in_ticker` to keep the ticker running and let live content take
|
||
**extra turns inside it** instead:
|
||
|
||
```json
|
||
"vegas_scroll": {
|
||
"live_in_ticker": true,
|
||
"live_weight": 3,
|
||
"favorite_live_weight": 5
|
||
}
|
||
```
|
||
|
||
#### Why weights exist
|
||
|
||
The rotation is otherwise a strict round robin — every plugin appears exactly
|
||
once per cycle. With a dozen plugins enabled, a live score comes round once a
|
||
lap and can be minutes old by the time you see it. A weight of *N* gives a
|
||
plugin *N* slots per cycle.
|
||
|
||
The slots are placed by **Smooth Weighted Round-Robin**, the same scheduler
|
||
the sports plugins use internally to rotate their own games. The important
|
||
property is that repeats are *spread through the cycle* rather than clumped:
|
||
three appearances in a row followed by a long silence would be worse than not
|
||
boosting at all.
|
||
|
||
Twelve plugins, with a favorite's baseball game and an ordinary live hockey
|
||
game (`live_weight: 3`, `favorite_live_weight: 5`):
|
||
|
||
```
|
||
baseball > hockey > weather > clock > baseball
|
||
stocks > news > flights > baseball > hockey
|
||
calendar > f1 > music > baseball > tides
|
||
birds > hockey > baseball
|
||
```
|
||
|
||
18 slots for 12 plugins. Baseball appears 5 times, hockey 3, everything else
|
||
once, and no plugin ever appears twice in a row — **including across the seam**
|
||
where the cycle loops back on itself. Smooth Weighted Round-Robin schedules the
|
||
heaviest item first and usually last as well, so the strip would otherwise show
|
||
it twice running at exactly the one join a within-cycle check cannot see. The
|
||
trailing repeat is moved into the widest remaining gap. Where a double is
|
||
unavoidable — a plugin holding most of the slots has to neighbour itself — the
|
||
schedule is left as it is.
|
||
|
||
#### Where the weight comes from
|
||
|
||
For each plugin in the rotation, in order:
|
||
|
||
1. **The plugin's own answer.** If it implements
|
||
`get_vegas_priority_weight()` and returns a number, that wins. This is the
|
||
only route for favorite-team awareness — the core can see *that* a game is
|
||
live, but not *whose*, so a scoreboard has to say so itself.
|
||
2. **The core's default.** When the plugin returns `None` (the base-class
|
||
default), a plugin where both `has_live_priority()` and `has_live_content()`
|
||
are true gets `live_weight`.
|
||
3. **Everything else** gets 1.
|
||
|
||
Because of step 2, **existing plugins need no changes** — any scoreboard with
|
||
`live_priority` enabled already gets extra turns. Step 1 is opt-in, for
|
||
plugins that want to distinguish a favorite's game from any other live game.
|
||
|
||
Weights are clamped to 1–10. A weight of 1 is no boost; a weight below 1 would
|
||
drop the plugin from the rotation entirely, which is never what is meant.
|
||
|
||
#### Things worth knowing
|
||
|
||
- **Weights are per plugin, not per game.** A scoreboard showing four live
|
||
games still occupies one slot at a time, rotating its own games within that
|
||
slot using its own `favorite_live_boost`. This controls how often the
|
||
*plugin* comes round.
|
||
- **The ticker is zero-sum.** Giving baseball 5 slots does not make the cycle
|
||
faster; it makes the cycle *longer* and everything else proportionally
|
||
rarer. If you want live scores sooner in wall-clock terms, pair this with a
|
||
smaller `plugins_per_cycle`.
|
||
- **Frequency is not freshness.** Each appearance redraws from the plugin's
|
||
current data (`refresh_updated_plugins()` drops cached content when a
|
||
plugin's data changes), but how current that data is depends on the
|
||
plugin's own `live_update_interval`. Showing a stale score five times a lap
|
||
is no better than showing it once.
|
||
- **Everything still appears.** A boost never starves another plugin out of
|
||
the cycle; low-weight plugins keep their single slot.
|
||
|
||
### Per-Plugin Configuration
|
||
|
||
Override Vegas behavior for specific plugins:
|
||
|
||
```json
|
||
{
|
||
"my_plugin": {
|
||
"enabled": true,
|
||
"vegas_mode": "scroll",
|
||
"vegas_panel_count": 2,
|
||
"display_duration": 10
|
||
}
|
||
}
|
||
```
|
||
|
||
**Per-Plugin Options:**
|
||
|
||
| Setting | Values | Description |
|
||
|---------|--------|-------------|
|
||
| `vegas_mode` | `scroll`, `fixed`, `static` | Display mode for this plugin |
|
||
| `vegas_panel_count` | any positive integer | Width in panels (1 panel = display width) |
|
||
| `display_duration` | seconds | Pause duration for STATIC mode |
|
||
|
||
Plugins may also set `vegas_overflow` and `vegas_max_width_screens` in
|
||
their config section to control how oversized content is handled (see
|
||
`PluginManager` in `src/plugin_system/plugin_manager.py`).
|
||
|
||
### Plugin Integration (Developer Guide)
|
||
|
||
**1. Implement Content Method:**
|
||
|
||
```python
|
||
def get_vegas_content(self):
|
||
"""
|
||
Return PIL Image or list of Images for Vegas mode.
|
||
|
||
Returns:
|
||
PIL.Image or list[PIL.Image]: Content to display
|
||
- Single image: fixed-width content
|
||
- List of images: multiple segments
|
||
- None: skip this cycle
|
||
"""
|
||
# Example: Return single wide image
|
||
img = Image.new('RGB', (256, 32))
|
||
# ... render your content ...
|
||
return img
|
||
|
||
# Example: Return multiple segments
|
||
return [image1, image2, image3]
|
||
```
|
||
|
||
**2. Specify Content Type:**
|
||
|
||
```python
|
||
def get_vegas_content_type(self):
|
||
"""
|
||
Specify how content should be handled.
|
||
|
||
Returns:
|
||
str: 'multi' | 'static' | 'none'
|
||
"""
|
||
return 'multi' # Default for most plugins
|
||
```
|
||
|
||
**3. Optionally Specify Display Mode:**
|
||
|
||
```python
|
||
def get_vegas_display_mode(self):
|
||
"""
|
||
Preferred display mode for this plugin.
|
||
|
||
Returns:
|
||
str: 'scroll' | 'fixed' | 'static'
|
||
"""
|
||
return 'scroll'
|
||
|
||
def get_supported_vegas_modes(self):
|
||
"""
|
||
List of supported modes.
|
||
|
||
Returns:
|
||
list: ['scroll', 'fixed', 'static']
|
||
"""
|
||
return ['scroll', 'static']
|
||
```
|
||
|
||
### Content Rendering Guidelines
|
||
|
||
**Image Dimensions:**
|
||
- **Height:** Must match display height (typically 32 pixels)
|
||
- **Width:** Varies by mode:
|
||
- SCROLL: Any width (recommended 64-512 pixels)
|
||
- FIXED_SEGMENT: `panel_count * display_width`
|
||
- STATIC: Any width, optimized for readability
|
||
|
||
**Color Mode:**
|
||
- Use RGB color mode
|
||
- 24-bit color (8 bits per channel)
|
||
|
||
**Performance Tips:**
|
||
1. **Cache rendered images** - Render in `update()`, not in `get_vegas_content()`
|
||
2. **Keep images small** - Larger images use more memory
|
||
3. **Pre-render on update** - Don't create images on-demand
|
||
4. **Reuse images** - Return same image if content unchanged
|
||
|
||
### Example Integration
|
||
|
||
Complete example for a weather plugin:
|
||
|
||
```python
|
||
class WeatherPlugin(BasePlugin):
|
||
def __init__(self, *args, **kwargs):
|
||
super().__init__(*args, **kwargs)
|
||
self.vegas_image = None
|
||
|
||
def update(self):
|
||
"""Update data and pre-render Vegas image"""
|
||
# Fetch weather data
|
||
weather_data = self.fetch_weather()
|
||
|
||
# Pre-render Vegas image
|
||
self.vegas_image = self._render_vegas_content(weather_data)
|
||
|
||
def _render_vegas_content(self, data):
|
||
"""Render weather content for Vegas mode"""
|
||
img = Image.new('RGB', (384, 32))
|
||
draw = ImageDraw.Draw(img)
|
||
|
||
# Draw temperature
|
||
draw.text((10, 0), f"{data['temp']}°F", fill=(255, 255, 255))
|
||
|
||
# Draw condition
|
||
draw.text((100, 0), data['condition'], fill=(200, 200, 200))
|
||
|
||
# Draw icon
|
||
icon = Image.open(f"assets/{data['icon']}.png")
|
||
img.paste(icon, (250, 0))
|
||
|
||
return img
|
||
|
||
def get_vegas_content(self):
|
||
"""Return cached Vegas image"""
|
||
return self.vegas_image
|
||
|
||
def get_vegas_content_type(self):
|
||
return 'multi'
|
||
|
||
def get_vegas_display_mode(self):
|
||
return 'scroll'
|
||
|
||
def get_supported_vegas_modes(self):
|
||
return ['scroll', 'static']
|
||
```
|
||
|
||
### System Architecture
|
||
|
||
Vegas mode consists of four core components working together to provide smooth 125 FPS continuous scrolling:
|
||
|
||
#### Component Overview
|
||
|
||
```
|
||
┌─────────────────────────────────────────────────────────────┐
|
||
│ VegasModeCoordinator │
|
||
│ Main orchestrator - manages lifecycle and coordination │
|
||
└───────┬──────────────────┬──────────────────┬──────────────┘
|
||
│ │ │
|
||
▼ ▼ ▼
|
||
┌───────────────┐ ┌──────────────┐ ┌─────────────────┐
|
||
│ PluginAdapter │ │StreamManager │ │ RenderPipeline │
|
||
│ │ │ │ │ │
|
||
│ Converts │─▶│ Manages │─▶│ 125 FPS render │
|
||
│ plugin content│ │ content │ │ Double-buffered │
|
||
│ to images │ │ stream with │ │ Smooth scroll │
|
||
│ │ │ 1-2 ahead │ │ │
|
||
└───────────────┘ │ buffering │ └─────────────────┘
|
||
└──────────────┘
|
||
```
|
||
|
||
#### 1. VegasModeCoordinator
|
||
|
||
**Responsibilities:**
|
||
- Initialize and coordinate all Vegas mode components
|
||
- Manage the high-FPS render loop (target: 125 FPS)
|
||
- Handle live priority interruptions
|
||
- Process config updates during runtime
|
||
- Provide status and control interface
|
||
|
||
**Key Features:**
|
||
- Thread-safe state management
|
||
- Config hot-reload support
|
||
- Live priority integration
|
||
- Interrupt checking for yielding control back to display controller
|
||
- Static pause handling (pauses scroll when content fully visible)
|
||
|
||
**Main Loop:**
|
||
1. Check for interrupts (live priority, on-demand, config updates)
|
||
2. If static pause active, wait for duration
|
||
3. Otherwise, delegate to render pipeline for frame rendering
|
||
4. Sleep to maintain target FPS
|
||
|
||
#### 2. StreamManager
|
||
|
||
**Responsibilities:**
|
||
- Manage plugin content streaming with look-ahead buffering
|
||
- Coordinate with PluginAdapter to fetch plugin content
|
||
- Handle plugin ordering and exclusions
|
||
- Optimize content generation timing
|
||
|
||
**Buffering Strategy:**
|
||
- **Buffer Ahead:** 1-2 panels (configurable)
|
||
- **Just-in-Time Generation:** Fetch content only when needed
|
||
- **Memory Efficient:** Only keep necessary content in memory
|
||
|
||
**Content Flow:**
|
||
1. Determine which plugins should appear in stream
|
||
2. Respect `plugin_order` configuration (or use default order)
|
||
3. Exclude plugins in `excluded_plugins` list
|
||
4. Request content from each plugin via PluginAdapter
|
||
5. Compose into continuous stream with separators
|
||
|
||
**Key Methods:**
|
||
- `get_next_segment()` - Returns the next buffered `ContentSegment` (or `None`)
|
||
- `take_next_group(count=None, offscreen_only=False)` - Hands over the next
|
||
slice of the rotation as `(plugin_id, images)` groups
|
||
- `get_grouped_content_for_composition()` - Buffered images grouped by plugin
|
||
- `mark_plugin_updated(plugin_id)` / `process_updates()` - Refresh one
|
||
plugin's segment in place when its data changes
|
||
- `refresh()` - Re-read the plugin list and config
|
||
- `advance_cycle()` - Clear the active buffer when a scroll cycle completes
|
||
|
||
(`src/vegas_mode/stream_manager.py`)
|
||
|
||
#### 3. PluginAdapter
|
||
|
||
**Responsibilities:**
|
||
- Convert plugin content to scrollable images
|
||
- Handle different Vegas display modes (SCROLL, FIXED, STATIC)
|
||
- Manage fallback for plugins without Vegas support
|
||
- Cache plugin content for performance
|
||
|
||
**Plugin Integration:**
|
||
1. **Check for Vegas support:**
|
||
- Calls `get_vegas_content()` if available
|
||
- Falls back to `display()` method if not
|
||
|
||
2. **Handle display mode:**
|
||
- SCROLL: Returns image as-is for continuous scrolling
|
||
- FIXED_SEGMENT: Creates fixed-width block (panel_count * display_width)
|
||
- STATIC: Marks content for pause-when-visible behavior
|
||
|
||
3. **Content type handling:**
|
||
- `multi`: Multiple segments (list of images)
|
||
- `static`: Single static image
|
||
- `none`: Skip this plugin in current cycle
|
||
|
||
**Fallback Behavior:**
|
||
- If plugin doesn't implement Vegas methods:
|
||
- Calls plugin's `display()` method
|
||
- Captures rendered display as static image
|
||
- Treats as fixed segment
|
||
- Ensures all plugins work in Vegas mode without explicit support
|
||
|
||
#### 4. RenderPipeline
|
||
|
||
**Responsibilities:**
|
||
- High-performance 125 FPS rendering
|
||
- Double-buffered composition for smooth scrolling
|
||
- Scroll position management
|
||
- Frame rate control
|
||
|
||
**Rendering Process:**
|
||
1. **Fetch Stream Content:** Get current stream from StreamManager
|
||
2. **Extract Viewport:** Calculate which portion of stream is visible
|
||
3. **Compose Frame:** Create frame with visible content
|
||
4. **Double Buffer:** Render to off-screen buffer
|
||
5. **Display:** Swap buffer to display
|
||
6. **Advance:** Update scroll position based on speed and elapsed time
|
||
|
||
**Performance Optimizations:**
|
||
- **Double Buffering:** Eliminates flicker
|
||
- **Viewport Extraction:** Only processes visible region
|
||
- **Frame Rate Control:** Precise timing to maintain 125 FPS
|
||
- **Pre-rendered Content:** Plugins pre-render during update()
|
||
|
||
**Scroll Speed Calculation:** motion is by elapsed time; `target_fps` paces
|
||
the render loop, not the speed.
|
||
```python
|
||
# frame_based_scrolling: false
|
||
scroll_position += scroll_speed * elapsed_time # scroll_speed in px/s
|
||
# frame_based_scrolling: true (the default) -- not stepping, just a clamp
|
||
applied = clamp(scroll_speed * scroll_delay, 0.1, 5) / scroll_delay
|
||
scroll_position += applied * elapsed_time
|
||
```
|
||
|
||
#### Component Interactions
|
||
|
||
**Initialization Flow:**
|
||
```
|
||
1. VegasModeCoordinator created
|
||
2. Coordinator creates PluginAdapter
|
||
3. Coordinator creates StreamManager (with PluginAdapter)
|
||
4. Coordinator creates RenderPipeline (with StreamManager)
|
||
5. All components initialized and ready
|
||
```
|
||
|
||
**Render Loop Flow:**
|
||
```
|
||
1. Coordinator starts render loop
|
||
2. Check for interrupts (live priority, on-demand)
|
||
3. RenderPipeline.render_frame():
|
||
a. Request current stream from StreamManager
|
||
b. StreamManager uses PluginAdapter to get plugin content
|
||
c. PluginAdapter calls plugin Vegas methods or fallback
|
||
d. Stream content returned to RenderPipeline
|
||
e. RenderPipeline extracts viewport and renders
|
||
4. Update scroll position
|
||
5. Sleep to maintain target FPS
|
||
6. Repeat from step 2
|
||
```
|
||
|
||
**Config Update Flow:**
|
||
```
|
||
1. Config change detected by Coordinator
|
||
2. Set _pending_config_update flag
|
||
3. On next render loop iteration:
|
||
a. Pause rendering
|
||
b. Update VegasModeConfig
|
||
c. Notify StreamManager of config change
|
||
d. StreamManager refreshes stream
|
||
e. Resume rendering
|
||
```
|
||
|
||
#### Thread Safety
|
||
|
||
All components use thread-safe patterns:
|
||
- **Coordinator:** Uses `threading.Lock` for state management
|
||
- **StreamManager:** Thread-safe content access
|
||
- **RenderPipeline:** Atomic frame composition
|
||
- **PluginAdapter:** Stateless operations (except caching)
|
||
|
||
#### Performance Characteristics
|
||
|
||
**Frame Rate:**
|
||
- Target: 125 FPS
|
||
- Actual: 100-125 FPS (depends on content complexity)
|
||
- Render time budget: ~8ms per frame
|
||
|
||
**Memory Usage:**
|
||
- Stream buffer: ~2-3 panels ahead
|
||
- Plugin content: Cached in plugin's `update()` method
|
||
- Double buffer: 2x display size
|
||
|
||
**CPU Usage:**
|
||
- Light load: 5-10% (simple content)
|
||
- Heavy load: 15-25% (complex content, many plugins)
|
||
- Optimized with numpy for pixel operations
|
||
|
||
### Fallback Behavior
|
||
|
||
If a plugin doesn't implement Vegas methods:
|
||
- System calls the plugin's `display()` method
|
||
- Captures the rendered display as a static image
|
||
- Treats it as a fixed segment
|
||
|
||
This ensures all plugins work in Vegas mode, even without explicit support.
|
||
|
||
---
|
||
|
||
## 2. On-Demand Display
|
||
|
||
### Overview
|
||
|
||
On-demand display allows users to manually trigger specific plugins to show immediately on the LED matrix, overriding the normal rotation. This is useful for:
|
||
- Quick checks (weather, scores, time)
|
||
- Pinning important information
|
||
- Testing plugins during development
|
||
- Showing specific content to visitors
|
||
|
||
### Priority Hierarchy
|
||
|
||
On-demand display has the highest priority:
|
||
|
||
```
|
||
Priority Order (highest to lowest):
|
||
1. On-Demand Display (manual trigger)
|
||
2. Live Priority (games in progress)
|
||
3. Normal Rotation
|
||
```
|
||
|
||
When on-demand expires or is cleared, the display returns to the next highest priority (live priority or normal rotation).
|
||
|
||
### Web Interface Controls
|
||
|
||
Each installed plugin has its own tab in the second nav row of the web
|
||
UI. Inside the plugin's tab, scroll to **On-Demand Controls**:
|
||
|
||
- **Run On-Demand** — triggers the plugin immediately, even if it's
|
||
disabled in the rotation
|
||
- **Stop On-Demand** — clears on-demand and returns to the normal
|
||
rotation
|
||
|
||
The display service must be running. The status banner at the top of
|
||
the plugin tab shows the active on-demand plugin, mode, and remaining
|
||
time when something is active.
|
||
|
||
### REST API Reference
|
||
|
||
The API is mounted at `/api/v3` (the `api_v3` blueprint, registered in
|
||
`web_interface/app.py`). Full details: [REST_API_REFERENCE.md](REST_API_REFERENCE.md#display-control).
|
||
|
||
#### Start On-Demand Display
|
||
|
||
```bash
|
||
POST /api/v3/display/on-demand/start
|
||
|
||
# Body:
|
||
{
|
||
"plugin_id": "weather",
|
||
"duration": 30, # Optional: seconds (0 = indefinite, null = default)
|
||
"pinned": false # Optional: keep until manually cleared
|
||
}
|
||
|
||
# Examples:
|
||
# 30-second preview
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "weather", "duration": 30}'
|
||
|
||
# Pin indefinitely
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
|
||
```
|
||
|
||
#### Stop On-Demand Display
|
||
|
||
```bash
|
||
POST /api/v3/display/on-demand/stop
|
||
|
||
# Body:
|
||
{
|
||
"stop_service": false # Optional: also stop display service
|
||
}
|
||
|
||
# Examples:
|
||
# Clear on-demand
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
|
||
|
||
# Stop service too
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"stop_service": true}'
|
||
```
|
||
|
||
#### Get On-Demand Status
|
||
|
||
```bash
|
||
GET /api/v3/display/on-demand/status
|
||
|
||
# Example:
|
||
curl http://localhost:5000/api/v3/display/on-demand/status
|
||
|
||
# Response:
|
||
{
|
||
"status": "success",
|
||
"data": {
|
||
"state": {
|
||
"active": true,
|
||
"plugin_id": "weather",
|
||
"mode": "weather",
|
||
"duration": 30,
|
||
"pinned": false,
|
||
"status": "running",
|
||
"last_updated": 1234567890.1
|
||
},
|
||
"service": {"active": true, "returncode": 0, "stdout": "active", "stderr": ""}
|
||
}
|
||
}
|
||
```
|
||
|
||
When nothing is running on demand, `data.state` is
|
||
`{"active": false, "status": "idle", "last_updated": null}`.
|
||
|
||
> There is no public Python on-demand API. The display controller's
|
||
> on-demand machinery is internal — drive it through the REST endpoints
|
||
> above (or the web UI buttons). The API handlers
|
||
> (`start_on_demand_display()` / `stop_on_demand_display()` in
|
||
> `web_interface/blueprints/api_v3/display.py`) write a request into the cache
|
||
> manager under the `display_on_demand_request` key, which
|
||
> `DisplayController._poll_on_demand_requests()`
|
||
> (`src/display_controller.py`) picks up. A separate
|
||
> `display_on_demand_config` key is used by the controller itself
|
||
> during activation (`_activate_on_demand()`) to track what's
|
||
> currently running, and is cleared by `_clear_on_demand()`.
|
||
|
||
### Duration Modes
|
||
|
||
| Duration | Pinned | Behavior |
|
||
|----------|--------|----------|
|
||
| `None` | `false` | Use plugin's default duration, auto-clear when expires |
|
||
| `0` | `false` | Indefinite, clears manually or on error |
|
||
| `> 0` | `false` | Timed display, auto-clear after N seconds |
|
||
| Any | `true` | Pin until manually cleared (ignores duration) |
|
||
|
||
### Use Case Examples
|
||
|
||
**Quick check (30-second preview):**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "ledmatrix-weather", "duration": 30}'
|
||
```
|
||
|
||
**Pin important information:**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
|
||
# ... later ...
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
|
||
```
|
||
|
||
**Indefinite display:**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "text-display", "duration": 0}'
|
||
```
|
||
|
||
**Testing a plugin during development:** the same call works, or just
|
||
click **Run On-Demand** in the plugin's tab.
|
||
|
||
### Best Practices
|
||
|
||
**For Users:**
|
||
1. Use timed display as default (prevents forgetting to clear)
|
||
2. Pin only when necessary
|
||
3. Clear when done to return to normal rotation
|
||
|
||
**For Developers:**
|
||
1. Validate plugin ID exists before calling
|
||
2. Provide visual feedback in UI (loading state, status updates)
|
||
3. Handle concurrent requests gracefully
|
||
4. Log on-demand activations for debugging
|
||
|
||
### Security Considerations
|
||
|
||
**Authentication:**
|
||
- Add authentication to API endpoints
|
||
- Restrict on-demand to authorized users
|
||
|
||
**Rate Limiting:**
|
||
- Prevent abuse from rapid requests
|
||
- Implement cooldown between activations
|
||
|
||
**Input Validation:**
|
||
- Sanitize plugin IDs
|
||
- Validate duration values
|
||
- Check plugin exists before activation
|
||
|
||
---
|
||
|
||
## 3. On-Demand Cache Management
|
||
|
||
### Overview
|
||
|
||
On-demand display uses cache keys (managed by `src/cache_manager.py` —
|
||
file-based, not Redis) to coordinate state between the web interface
|
||
and the display controller across service restarts. Understanding these
|
||
keys helps troubleshoot stuck states.
|
||
|
||
### Cache Keys
|
||
|
||
**1. display_on_demand_request** (TTL: 1 hour)
|
||
```json
|
||
{
|
||
"request_id": "uuid-string",
|
||
"action": "start|stop",
|
||
"plugin_id": "plugin-name",
|
||
"mode": "mode-name",
|
||
"duration": 30.0,
|
||
"pinned": true,
|
||
"timestamp": 1234567890.123
|
||
}
|
||
```
|
||
**Purpose:** Communication from web interface to display controller
|
||
**When Set:** API endpoint receives request
|
||
**Auto-Cleared:** After processing or 1 hour TTL
|
||
|
||
**2. display_on_demand_config** (No TTL)
|
||
```json
|
||
{
|
||
"mode": "mode-name",
|
||
"duration": 30.0,
|
||
"pinned": true
|
||
}
|
||
```
|
||
**Purpose:** Persistent configuration for display controller
|
||
**When Set:** Controller processes start request
|
||
**Auto-Cleared:** When on-demand stops
|
||
|
||
**3. display_on_demand_state** (Continuously updated)
|
||
```json
|
||
{
|
||
"active": true,
|
||
"mode": "mode-name",
|
||
"remaining": 25.5,
|
||
"pinned": true,
|
||
"status": "active|idle|restarting|error"
|
||
}
|
||
```
|
||
**Purpose:** Real-time state for web interface status card
|
||
**When Set:** Every display loop iteration
|
||
**Auto-Cleared:** Never (continuously updated)
|
||
|
||
**4. display_on_demand_processed_id** (TTL: 1 hour)
|
||
```text
|
||
"uuid-string-of-last-processed-request"
|
||
```
|
||
**Purpose:** Prevents duplicate request processing
|
||
**When Set:** After processing request
|
||
**Auto-Cleared:** After 1 hour TTL
|
||
|
||
### When Manual Clearing is Needed
|
||
|
||
**Scenario 1: Stuck in On-Demand State**
|
||
- Symptom: Display stays on one plugin, won't return to rotation
|
||
- Clear: `config`, `state`, `request`
|
||
|
||
**Scenario 2: Mode Switching Issues**
|
||
- Symptom: Can't change to different plugin
|
||
- Clear: `request`, `processed_id`, `state`
|
||
|
||
**Scenario 3: On-Demand Not Activating**
|
||
- Symptom: Button click does nothing
|
||
- Clear: `processed_id`, `request`
|
||
|
||
**Scenario 4: After Service Crash**
|
||
- Symptom: Strange behavior after crash/restart
|
||
- Clear: All four keys
|
||
|
||
### Manual Recovery Procedures
|
||
|
||
**Via Web Interface (Recommended):**
|
||
1. Open the **Cache** tab in the web UI
|
||
2. Find the `display_on_demand_*` entries
|
||
3. Delete them
|
||
4. Restart display: `sudo systemctl restart ledmatrix`
|
||
|
||
**Via Command Line:**
|
||
|
||
The cache is stored as JSON files under one of:
|
||
|
||
- `/var/cache/ledmatrix/` (preferred when the service has permission)
|
||
- `~/.ledmatrix_cache/`
|
||
- `/opt/ledmatrix/cache/`
|
||
- `$TMPDIR/ledmatrix_cache/` (fallback)
|
||
|
||
```bash
|
||
# Find the cache dir actually in use
|
||
journalctl -u ledmatrix | grep -i "cache directory" | tail -1
|
||
|
||
# Clear all on-demand keys (replace path with the one above)
|
||
rm /var/cache/ledmatrix/display_on_demand_*
|
||
|
||
# Restart service
|
||
sudo systemctl restart ledmatrix
|
||
```
|
||
|
||
**Via Python:**
|
||
```python
|
||
from src.cache_manager import CacheManager
|
||
|
||
cache = CacheManager()
|
||
cache.clear_cache('display_on_demand_config')
|
||
cache.clear_cache('display_on_demand_state')
|
||
cache.clear_cache('display_on_demand_request')
|
||
cache.clear_cache('display_on_demand_processed_id')
|
||
```
|
||
|
||
> `CacheManager` also has a `delete(key)` method — a thin wrapper over
|
||
> `clear_cache(key)` — so `cache.delete('display_on_demand_config')`
|
||
> works equally well.
|
||
|
||
### Cache Impact on Running Service
|
||
|
||
**IMPORTANT:** Clearing cache keys does NOT immediately affect the running controller in memory.
|
||
|
||
**To fully reset:**
|
||
1. Stop the service: `sudo systemctl stop ledmatrix`
|
||
2. Clear cache keys (web UI Cache tab or `rm` from the cache directory)
|
||
3. Clear systemd environment: `sudo systemctl daemon-reload`
|
||
4. Start the service: `sudo systemctl start ledmatrix`
|
||
|
||
### Automatic Cleanup
|
||
|
||
The display controller automatically handles cleanup:
|
||
- **Config key**: Cleared when on-demand stops
|
||
- **State key**: Updated every display loop iteration
|
||
- **Request key**: Expires after 1 hour TTL (or after processing)
|
||
- **Processed ID**: Expires after 1 hour TTL
|
||
|
||
---
|
||
|
||
## 4. Background Data Service
|
||
|
||
### Overview
|
||
|
||
The Background Data Service enables non-blocking data fetching through background threading. This prevents the main display loop from freezing during slow API requests, maintaining smooth display rotation.
|
||
|
||
### Benefits
|
||
|
||
**Performance:**
|
||
- Display loop never freezes during API calls
|
||
- Immediate response with cached/partial data
|
||
- Complete data loads in background
|
||
|
||
**User Experience:**
|
||
- No "frozen" display during data updates
|
||
- Smooth transitions between plugins
|
||
- Faster perceived load times
|
||
|
||
**Architecture:**
|
||
```
|
||
Cache Check → Background Fetch → Partial Data → Completion → Cache
|
||
(0.1s) (async) (<1s) (10-30s) (cache)
|
||
```
|
||
|
||
### Configuration
|
||
|
||
Enable background service per plugin in `config/config.json`:
|
||
|
||
```json
|
||
{
|
||
"football-scoreboard": {
|
||
"enabled": true,
|
||
"background_service": {
|
||
"enabled": true,
|
||
"max_workers": 3,
|
||
"request_timeout": 30,
|
||
"max_retries": 3,
|
||
"priority": 2
|
||
}
|
||
}
|
||
}
|
||
```
|
||
|
||
**Configuration Options:**
|
||
|
||
| Setting | Default | Description |
|
||
|---------|---------|-------------|
|
||
| `enabled` | `false` | Enable background service for this plugin |
|
||
| `max_workers` | `3` | Max concurrent background tasks |
|
||
| `request_timeout` | `30` | Timeout per API request (seconds) |
|
||
| `max_retries` | `3` | Retry attempts on failure |
|
||
| `priority` | `1` | Task priority (1=highest, 10=lowest) |
|
||
|
||
### Performance Impact
|
||
|
||
**First Request (Cache Empty):**
|
||
- Returns partial data: < 1 second
|
||
- Background completes: 10-30 seconds
|
||
- Subsequent requests use cache: < 0.1 seconds
|
||
|
||
**Subsequent Requests (Cache Hit):**
|
||
- Returns immediately: < 0.1 seconds
|
||
- Background refresh (if stale): async, no blocking
|
||
|
||
### Plugins using the background service
|
||
|
||
The background data service is used by all of the sports scoreboard
|
||
plugins (football, hockey, baseball/MLB, basketball, soccer, lacrosse,
|
||
F1, UFC), the odds ticker, and the leaderboard plugin. Each plugin's
|
||
`background_service` block (under its own config namespace) follows the
|
||
same shape as the example above.
|
||
|
||
### Error Handling & Fallback
|
||
|
||
**Automatic Retry:**
|
||
- Exponential backoff (1s, 2s, 4s, 8s, ...)
|
||
- Maximum retry attempts configurable
|
||
- Logs all retry attempts
|
||
|
||
**Fallback Behavior:**
|
||
- If background service disabled: reverts to synchronous fetching
|
||
- If background fetch fails: returns cached data
|
||
- If no cache: returns empty/error state
|
||
|
||
### Testing
|
||
|
||
```bash
|
||
# Check logs for background operations
|
||
sudo journalctl -u ledmatrix -f | grep "background"
|
||
```
|
||
|
||
### Monitoring
|
||
|
||
**View Statistics:**
|
||
```python
|
||
from src.background_data_service import get_background_service
|
||
from src.cache_manager import CacheManager
|
||
|
||
service = get_background_service(CacheManager())
|
||
stats = service.get_statistics()
|
||
print(f"Active tasks: {stats['active_tasks']}")
|
||
print(f"Completed: {stats['completed']}")
|
||
print(f"Failed: {stats['failed']}")
|
||
```
|
||
|
||
**Enable Debug Logging:**
|
||
```python
|
||
import logging
|
||
logging.getLogger('src.background_data_service').setLevel(logging.DEBUG)
|
||
```
|
||
|
||
---
|
||
|
||
## 5. Permission Management
|
||
|
||
### Overview
|
||
|
||
LEDMatrix uses a dual-user architecture: the display service runs as root (hardware access), while the web interface runs as a non-privileged user. Centralized permission management ensures both can access necessary files.
|
||
|
||
### Why It Matters
|
||
|
||
**Problem:**
|
||
- Root service creates files with root ownership
|
||
- Web user cannot read/write those files
|
||
- Results in `PermissionError` exceptions
|
||
|
||
**Solution:**
|
||
- Set group ownership to shared group
|
||
- Grant group write permissions
|
||
- Use setgid bit for automatic inheritance
|
||
|
||
### Permission Utilities
|
||
|
||
```python
|
||
from src.common.permission_utils import (
|
||
ensure_directory_permissions,
|
||
ensure_file_permissions,
|
||
get_config_file_mode,
|
||
get_assets_file_mode,
|
||
get_assets_dir_mode,
|
||
get_plugin_file_mode,
|
||
get_cache_dir_mode
|
||
)
|
||
|
||
# Create directory with correct permissions
|
||
ensure_directory_permissions(Path("assets/sports"), get_assets_dir_mode())
|
||
|
||
# Set file permissions after writing
|
||
# (get_config_file_mode requires the file path — secrets files get a
|
||
# stricter mode than the main config)
|
||
config_path = Path("config/config.json")
|
||
ensure_file_permissions(config_path, get_config_file_mode(config_path))
|
||
```
|
||
|
||
### When to Use Utilities
|
||
|
||
**Use permission utilities when:**
|
||
1. Creating new directories
|
||
2. Writing configuration files
|
||
3. Downloading/creating asset files (logos, fonts)
|
||
4. Creating plugin files
|
||
5. Writing cache files
|
||
|
||
**Don't use for:**
|
||
1. Reading files (permissions don't change)
|
||
2. Temporary files in `/tmp`
|
||
3. Files in already-managed directories (if parent has setgid)
|
||
|
||
### Permission Standards
|
||
|
||
**File Permissions:**
|
||
|
||
| File Type | Mode | Octal | Description |
|
||
|-----------|------|-------|-------------|
|
||
| Config (main) | `rw-r--r--` | `0o644` | Owner write, all read |
|
||
| Config (secrets) | `rw-r-----` | `0o640` | Owner write, group read |
|
||
| Assets | `rw-rw-r--` | `0o664` | Owner/group write, all read |
|
||
| Plugins | `rw-rw-r--` | `0o664` | Owner/group write, all read |
|
||
| Cache files | `rw-rw-r--` | `0o664` | Owner/group write, all read |
|
||
|
||
**Directory Permissions:**
|
||
|
||
| Directory Type | Mode | Octal | Description |
|
||
|----------------|------|-------|-------------|
|
||
| All directories | `rwxrwsr-x` | `0o2775` | With setgid bit for inheritance |
|
||
|
||
**Note:** The `s` in `rwxrwsr-x` is the setgid bit (2000), which makes new files inherit the directory's group ownership.
|
||
|
||
### Common Patterns
|
||
|
||
**Pattern 1: Creating Config Directory**
|
||
```python
|
||
from pathlib import Path
|
||
from src.common.permission_utils import ensure_directory_permissions, get_config_dir_mode
|
||
|
||
config_dir = Path("config/plugins")
|
||
ensure_directory_permissions(config_dir, get_config_dir_mode())
|
||
```
|
||
|
||
**Pattern 2: Saving Config File**
|
||
```python
|
||
from src.common.permission_utils import ensure_file_permissions, get_config_file_mode
|
||
|
||
config_path = Path("config/config.json")
|
||
with open(config_path, 'w') as f:
|
||
json.dump(data, f)
|
||
ensure_file_permissions(config_path, get_config_file_mode(config_path))
|
||
```
|
||
|
||
**Pattern 3: Downloading Logo**
|
||
```python
|
||
from src.common.permission_utils import ensure_directory_permissions, ensure_file_permissions
|
||
from src.common.permission_utils import get_assets_dir_mode, get_assets_file_mode
|
||
|
||
logo_path = Path("assets/sports/nhl/logo.png")
|
||
ensure_directory_permissions(logo_path.parent, get_assets_dir_mode())
|
||
# ... download and save logo ...
|
||
ensure_file_permissions(logo_path, get_assets_file_mode())
|
||
```
|
||
|
||
**Pattern 4: Creating Plugin File**
|
||
```python
|
||
from src.common.permission_utils import ensure_file_permissions, get_plugin_file_mode
|
||
|
||
plugin_file = Path("plugins/my-plugin/data.json")
|
||
with open(plugin_file, 'w') as f:
|
||
json.dump(data, f)
|
||
ensure_file_permissions(plugin_file, get_plugin_file_mode())
|
||
```
|
||
|
||
**Pattern 5: Cache Directory Setup**
|
||
```python
|
||
from src.common.permission_utils import ensure_directory_permissions, get_cache_dir_mode
|
||
|
||
cache_dir = Path("cache/plugin-name")
|
||
ensure_directory_permissions(cache_dir, get_cache_dir_mode())
|
||
```
|
||
|
||
### Integration with Core Utilities
|
||
|
||
These core utilities **already handle permissions** - you don't need to call permission utilities when using them:
|
||
|
||
- **ConfigManager** - Handles config file permissions
|
||
- **CacheManager** - Handles cache file permissions
|
||
- **LogoHelper** - Handles logo file permissions
|
||
- **PluginManager** - Handles plugin file permissions
|
||
|
||
### Manual Fixes
|
||
|
||
If you encounter permission issues:
|
||
|
||
```bash
|
||
# Targeted permission fixes (see scripts/fix_perms/README.md)
|
||
sudo ./scripts/fix_perms/fix_assets_permissions.sh # assets/ tree (logos, fonts)
|
||
sudo ./scripts/fix_perms/fix_cache_permissions.sh # all cache directories
|
||
sudo ./scripts/fix_perms/fix_plugin_permissions.sh # plugin directories
|
||
sudo ./scripts/fix_perms/fix_web_permissions.sh # web interface files
|
||
|
||
# Fix specific directory
|
||
sudo chown -R ledpi:ledpi /home/ledpi/LEDMatrix/config
|
||
sudo chmod -R 2775 /home/ledpi/LEDMatrix/config
|
||
sudo find /home/ledpi/LEDMatrix/config -type f -exec chmod 664 {} \;
|
||
|
||
# Verify permissions
|
||
ls -la config/
|
||
ls -la assets/
|
||
```
|
||
|
||
### Verification
|
||
|
||
```bash
|
||
# Check directory has setgid bit
|
||
ls -ld assets/
|
||
# Should show: drwxrwsr-x (note the 's')
|
||
|
||
# Check file has correct group
|
||
ls -l assets/logo.png
|
||
# Should show group 'ledpi'
|
||
|
||
# Check file permissions
|
||
stat -c "%a %n" config/config.json
|
||
# Should show: 644 config/config.json
|
||
```
|
||
|
||
---
|
||
|
||
## Related Documentation
|
||
|
||
- [PLUGIN_DEVELOPMENT_GUIDE.md](PLUGIN_DEVELOPMENT_GUIDE.md) - Creating plugins with Vegas/on-demand support
|
||
- [WEB_INTERFACE_GUIDE.md](WEB_INTERFACE_GUIDE.md) - Using on-demand controls in web UI
|
||
- [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) - Complete API documentation
|
||
- [DEVELOPMENT.md](DEVELOPMENT.md) - Development environment and testing
|