mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 22:35:08 +00:00
* fix(web): harden, polish and optimize the web UI per the September 2026 audit Works through docs/archive/WEB_UI_AUDIT_2026-09.md (health 8/20). Implementation integrity (P0) - app.css now defines every utility class the templates and JS use, including .hidden, so the ~145 JS show/hide toggles work. Button reset, and base component rules (.btn, .form-control) wrapped in :where() so utility classes on the same element win. New static-audit test fails when a used utility class has no rule. Accessibility - Focus rings render (the old ring rule referenced undefined variables); one :focus-visible outline everywhere; skip link; labelled nav landmarks. - Shared dialog helper (js/utils/dialog.js): role/aria-modal, focus trap, Escape, focus return, applied to every modal. - Named icon-only buttons and labelled ~70 form fields. - Toasts announced once; errors persist >= 10s; one showNotification. - Captive WiFi page: live region, timeouts, dark mode, 16px inputs. Performance (Pi Zero 2 W) - SSE streams and tab timers pause when hidden or off-tab; the display stream only runs while a preview is visible. app-shell.js deferred. - Widget scripts served as one versioned bundle (/assets/widgets.js): 52 -> 21 script tags, 66 -> 35 requests on first load. - Stdlib gzip fallback when flask-compress is missing: first-load JS/CSS 1358 KB -> 291 KB on the wire. SSE untouched. Theming and responsive - File managers, form fields and Fonts upload on theme tokens; bare inputs themed in dark mode; no more white surfaces. - No horizontal overflow at 375px on any tab; 44px touch targets on coarse pointers; reduced-motion respected; header title truncates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): clear Codacy findings on #568 - json-file-manager: focus-trap releases kept in a Map (no dynamic property access or delete; no value-returning forEach callback) - notification / schedule-picker: style and day-label lookups via Map - app.js: move the pending-queue assignment out of the expression - diff_viewer / error_handler: named function declarations instead of arrow consts No behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * test: check the OAuth widget ships in the widget bundle base.html no longer tags widget scripts one by one; they load through /assets/widgets.js. Assert the page requests the bundle and the bundle contains google-oauth.js, which is what the test was protecting. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): address review feedback on #568 - widget bundle version fingerprints every file (name, mtime_ns, size) - gzip fallback appends Accept-Encoding to an existing Vary header - dialog helper: releasing a non-top dialog no longer moves focus out of the dialog the user is in - labels: file-upload targets its file input; fallback config fields get label for/id pairs; native color input has a fallback name - utility audit also reads class names inside bound :class expressions Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): give the native color-picker input an accessible name CodeRabbit flagged this on PR #568 as an outside-diff finding (never posted inline, so it was missed in the round of fixes that addressed the other 6 review comments). The <input type="color"> only carried a title attribute; screen readers don't reliably announce title, and there's no other label naming the control when showHexInput is false. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): clear Codacy findings in app-shell.js - drop the unused catch binding on the SSE JSON parse - move the pending-notification queue assignment out of the expression No behavior change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(web): contain plugin widgets/ dir and bound style-editor retries From CodeRabbit review on #568 (code that arrived with the main merge): - serve_plugin_widget resolves widgets/ with resolve_under before resolving the manifest script under it, so a symlinked widgets directory can't become the containment base (CWE-22). New test. - style-editor init stops polling after ~10s when the widget never registers and leaves the plain fallback fields in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
245 lines
10 KiB
JavaScript
245 lines
10 KiB
JavaScript
/**
|
|
* LEDMatrix Number Input Widget
|
|
*
|
|
* Enhanced number input with min/max/step, formatting, and increment buttons.
|
|
*
|
|
* Schema example:
|
|
* {
|
|
* "brightness": {
|
|
* "type": "number",
|
|
* "x-widget": "number-input",
|
|
* "minimum": 0,
|
|
* "maximum": 100,
|
|
* "x-options": {
|
|
* "step": 5,
|
|
* "prefix": null,
|
|
* "suffix": "%",
|
|
* "showButtons": true,
|
|
* "format": "integer" // "integer", "decimal", "percent"
|
|
* }
|
|
* }
|
|
* }
|
|
*
|
|
* @module NumberInputWidget
|
|
*/
|
|
|
|
(function() {
|
|
'use strict';
|
|
|
|
const base = window.BaseWidget ? new window.BaseWidget('NumberInput', '1.0.0') : null;
|
|
|
|
function escapeHtml(text) {
|
|
if (base) return base.escapeHtml(text);
|
|
const div = document.createElement('div');
|
|
div.textContent = String(text);
|
|
return div.innerHTML.replace(/"/g, '"').replace(/'/g, ''');
|
|
}
|
|
|
|
function sanitizeId(id) {
|
|
if (base) return base.sanitizeId(id);
|
|
return String(id).replace(/[^a-zA-Z0-9_-]/g, '_');
|
|
}
|
|
|
|
function triggerChange(fieldId, value) {
|
|
if (base) {
|
|
base.triggerChange(fieldId, value);
|
|
} else {
|
|
const event = new CustomEvent('widget-change', {
|
|
detail: { fieldId, value },
|
|
bubbles: true,
|
|
cancelable: true
|
|
});
|
|
document.dispatchEvent(event);
|
|
}
|
|
}
|
|
|
|
window.LEDMatrixWidgets.register('number-input', {
|
|
name: 'Number Input Widget',
|
|
version: '1.0.0',
|
|
|
|
render: function(container, config, value, options) {
|
|
// Guard against undefined options
|
|
options = options || {};
|
|
const fieldId = sanitizeId(options.fieldId || container.id || 'number_input');
|
|
const xOptions = config['x-options'] || config['x_options'] || {};
|
|
|
|
// Sanitize min/max as valid numbers or null
|
|
const rawMin = config.minimum !== undefined ? config.minimum : (xOptions.min !== undefined ? xOptions.min : null);
|
|
const rawMax = config.maximum !== undefined ? config.maximum : (xOptions.max !== undefined ? xOptions.max : null);
|
|
const min = (rawMin !== null && Number.isFinite(Number(rawMin))) ? Number(rawMin) : null;
|
|
const max = (rawMax !== null && Number.isFinite(Number(rawMax))) ? Number(rawMax) : null;
|
|
|
|
// Sanitize step - must be a positive number or 'any'
|
|
const rawStep = xOptions.step || (config.type === 'integer' ? 1 : 'any');
|
|
const step = (rawStep === 'any' || (Number.isFinite(Number(rawStep)) && Number(rawStep) > 0))
|
|
? (rawStep === 'any' ? 'any' : Number(rawStep))
|
|
: 1;
|
|
const prefix = xOptions.prefix || '';
|
|
const suffix = xOptions.suffix || '';
|
|
const showButtons = xOptions.showButtons !== false;
|
|
const disabled = xOptions.disabled === true;
|
|
const placeholder = xOptions.placeholder || '';
|
|
|
|
// Sanitize currentValue - ensure it's a safe numeric string or empty
|
|
const rawValue = value !== null && value !== undefined ? value : '';
|
|
const currentValue = rawValue === '' ? '' : (isNaN(Number(rawValue)) ? '' : String(Number(rawValue)));
|
|
|
|
// Escape values for safe HTML attribute interpolation
|
|
const safeMin = min !== null ? escapeHtml(String(min)) : '';
|
|
const safeMax = max !== null ? escapeHtml(String(max)) : '';
|
|
const safeStep = escapeHtml(String(step));
|
|
|
|
let html = `<div id="${fieldId}_widget" class="number-input-widget" data-field-id="${fieldId}" data-min="${safeMin}" data-max="${safeMax}" data-step="${safeStep}">`;
|
|
|
|
html += '<div class="flex items-center">';
|
|
|
|
if (prefix) {
|
|
html += `<span class="inline-flex items-center px-3 text-sm text-gray-500 bg-gray-100 border border-r-0 border-gray-300 rounded-l-md">${escapeHtml(prefix)}</span>`;
|
|
}
|
|
|
|
if (showButtons && !disabled) {
|
|
html += `
|
|
<button type="button"
|
|
onclick="window.LEDMatrixWidgets.getHandlers('number-input').onDecrement('${fieldId}')"
|
|
class="inline-flex items-center px-3 py-2 text-gray-600 bg-gray-100 border border-r-0 border-gray-300 hover:bg-gray-200 ${prefix ? '' : 'rounded-l-md'}"
|
|
aria-label="Decrease" aria-controls="${fieldId}_input">
|
|
<i class="fas fa-minus text-xs" aria-hidden="true"></i>
|
|
</button>
|
|
`;
|
|
}
|
|
|
|
const inputRoundedClass = showButtons || prefix || suffix ? '' : 'rounded-md';
|
|
|
|
html += `
|
|
<input type="number"
|
|
id="${fieldId}_input"
|
|
name="${escapeHtml(options.name || fieldId)}"
|
|
value="${escapeHtml(currentValue)}"
|
|
placeholder="${escapeHtml(placeholder)}"
|
|
${min !== null ? `min="${safeMin}"` : ''}
|
|
${max !== null ? `max="${safeMax}"` : ''}
|
|
step="${safeStep}"
|
|
${disabled ? 'disabled' : ''}
|
|
onchange="window.LEDMatrixWidgets.getHandlers('number-input').onChange('${fieldId}')"
|
|
oninput="window.LEDMatrixWidgets.getHandlers('number-input').onInput('${fieldId}')"
|
|
class="form-input w-24 text-center ${inputRoundedClass} border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 ${disabled ? 'bg-gray-100 cursor-not-allowed' : 'bg-white'} text-black placeholder:text-gray-400">
|
|
`;
|
|
|
|
if (showButtons && !disabled) {
|
|
html += `
|
|
<button type="button"
|
|
onclick="window.LEDMatrixWidgets.getHandlers('number-input').onIncrement('${fieldId}')"
|
|
class="inline-flex items-center px-3 py-2 text-gray-600 bg-gray-100 border border-l-0 border-gray-300 hover:bg-gray-200 ${suffix ? '' : 'rounded-r-md'}"
|
|
aria-label="Increase" aria-controls="${fieldId}_input">
|
|
<i class="fas fa-plus text-xs" aria-hidden="true"></i>
|
|
</button>
|
|
`;
|
|
}
|
|
|
|
if (suffix) {
|
|
html += `<span class="inline-flex items-center px-3 text-sm text-gray-500 bg-gray-100 border border-l-0 border-gray-300 rounded-r-md">${escapeHtml(suffix)}</span>`;
|
|
}
|
|
|
|
html += '</div>';
|
|
|
|
// Range indicator if min/max specified
|
|
if (min !== null || max !== null) {
|
|
const rangeText = min !== null && max !== null
|
|
? `${min} - ${max}`
|
|
: (min !== null ? `Min: ${min}` : `Max: ${max}`);
|
|
html += `<div class="text-xs text-gray-400 mt-1">${escapeHtml(rangeText)}</div>`;
|
|
}
|
|
|
|
// Error message area
|
|
html += `<div id="${fieldId}_error" class="text-sm text-red-600 mt-1 hidden"></div>`;
|
|
|
|
html += '</div>';
|
|
|
|
container.innerHTML = html;
|
|
},
|
|
|
|
getValue: function(fieldId) {
|
|
const safeId = sanitizeId(fieldId);
|
|
const input = document.getElementById(`${safeId}_input`);
|
|
if (!input || input.value === '') return null;
|
|
const num = parseFloat(input.value);
|
|
return isNaN(num) ? null : num;
|
|
},
|
|
|
|
setValue: function(fieldId, value) {
|
|
const safeId = sanitizeId(fieldId);
|
|
const input = document.getElementById(`${safeId}_input`);
|
|
if (input) {
|
|
input.value = value !== null && value !== undefined ? value : '';
|
|
}
|
|
},
|
|
|
|
validate: function(fieldId) {
|
|
const safeId = sanitizeId(fieldId);
|
|
const input = document.getElementById(`${safeId}_input`);
|
|
const errorEl = document.getElementById(`${safeId}_error`);
|
|
|
|
if (!input) return { valid: true, errors: [] };
|
|
|
|
const isValid = input.checkValidity();
|
|
|
|
if (errorEl) {
|
|
if (!isValid) {
|
|
errorEl.textContent = input.validationMessage;
|
|
errorEl.classList.remove('hidden');
|
|
input.classList.add('border-red-500');
|
|
} else {
|
|
errorEl.classList.add('hidden');
|
|
input.classList.remove('border-red-500');
|
|
}
|
|
}
|
|
|
|
return { valid: isValid, errors: isValid ? [] : [input.validationMessage] };
|
|
},
|
|
|
|
handlers: {
|
|
onChange: function(fieldId) {
|
|
const widget = window.LEDMatrixWidgets.get('number-input');
|
|
widget.validate(fieldId);
|
|
triggerChange(fieldId, widget.getValue(fieldId));
|
|
},
|
|
|
|
onInput: function(fieldId) {
|
|
// Real-time input handling if needed
|
|
},
|
|
|
|
onIncrement: function(fieldId) {
|
|
const safeId = sanitizeId(fieldId);
|
|
const widget = document.getElementById(`${safeId}_widget`);
|
|
const input = document.getElementById(`${safeId}_input`);
|
|
if (!input || !widget) return;
|
|
|
|
const step = parseFloat(widget.dataset.step) || 1;
|
|
const max = widget.dataset.max !== '' ? parseFloat(widget.dataset.max) : Infinity;
|
|
const current = parseFloat(input.value) || 0;
|
|
const newValue = Math.min(current + step, max);
|
|
|
|
input.value = newValue;
|
|
this.onChange(fieldId);
|
|
},
|
|
|
|
onDecrement: function(fieldId) {
|
|
const safeId = sanitizeId(fieldId);
|
|
const widget = document.getElementById(`${safeId}_widget`);
|
|
const input = document.getElementById(`${safeId}_input`);
|
|
if (!input || !widget) return;
|
|
|
|
const step = parseFloat(widget.dataset.step) || 1;
|
|
const min = widget.dataset.min !== '' ? parseFloat(widget.dataset.min) : -Infinity;
|
|
const current = parseFloat(input.value) || 0;
|
|
const newValue = Math.max(current - step, min);
|
|
|
|
input.value = newValue;
|
|
this.onChange(fieldId);
|
|
}
|
|
}
|
|
});
|
|
|
|
console.log('[NumberInputWidget] Number input widget registered');
|
|
})();
|