mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 22:35:08 +00:00
* docs: add ARCHITECTURE and PERMISSIONS guides ARCHITECTURE.md maps the processes, the state the display and web services share through the cache, the display loop, the plugin system, the web UI and the update path, with links into the code and a where-to-start table. PERMISSIONS.md lists who owns what after install, both sudoers files (and why iptables is not granted), the polkit rule, and which scripts/fix_perms script to run as which user. Both are linked from the docs index, along with the MQTT bridge README and src/common/README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct stale setup, service and troubleshooting claims - README: quick actions run systemctl on ledmatrix.service (run.py), not display_controller.py; use_short_date_format has no effect; the installer uses system pip with --break-system-packages, not a venv. - CONFIG_DEBUGGING: LEDMATRIX_DEBUG must be "true"; logs are in journald. - GETTING_STARTED, WEB_INTERFACE_GUIDE, TROUBLESHOOTING: enabling a plugin, plugin settings, brightness and Vegas settings apply without a restart; matrix hardware settings still need one. - TROUBLESHOOTING: install dependencies with sudo so the root service sees them; point permission problems at PERMISSIONS.md instead of a project-wide chown. - ADVANCED_FEATURES: real BackgroundDataService stats keys; Vegas hooks return VegasDisplayMode and None falls back to capture; cache files are 0660; fix_web_permissions.sh runs as the web user and does not touch sudoers. - STARLARK_APPS_GUIDE: only the linux-arm64 pixlet binary is downloaded. - HOW_TO_RUN_TESTS: test class examples that exist. - CLAUDE.md: PluginStoreManager, plugin_dirs.py, monorepo installs via the Trees API with ZIP fallback, requirements.txt is optional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: mark deprecated plugin APIs and state manifest fields once Methods @deprecated("3.7.0") (the set pinned in test_deprecation.py) were shown as current API in the quick reference, API reference, advanced guide, development guide and FONT_MANAGER. Each is now marked deprecated with its replacement. FONT_MANAGER is rewritten around the current API; the override editor is gone and override methods are deprecated. Required manifest fields were stated three different ways. The API reference now has one section: the 7 schema-required fields, the 4 the store refuses without, class_name for the loader, and the 8 to set. The other guides link to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: document every src/common module and every widget - src/common/README.md covered 7 of 17 modules. It now has a table of all of them (purpose, whether plugins import it, release to floor on), a short entry each, and logging advice that matches the code. - SPORTS_UNIFICATION listed two shared modules and called sports_helpers the first; it now lists all six. - The widgets README lists all 28 registered widgets plus the support files, and absorbs the parts that only docs/widget-guide.md had (x-options.labels, x-advanced, x-display hidden, plugin-file-manager). docs/widget-guide.md is now a pointer to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): fix_web_permissions.sh re-hardens the root sudo helpers The script chowns the whole project to the web user. That included scripts/fix_perms/safe_plugin_rm.sh and safe_pip_install.sh -- the two helpers /etc/sudoers.d/ledmatrix_web lets the web user run as root -- so running it turned both into a root shell for whoever can edit them. It also re-grouped config_secrets.json away from ledmatrix. After the chown it now does what first_time_install.sh's Steps 11 and 11.1 do: helpers back to root:root 755, and config_secrets.json back to the web unit's User=:ledmatrix 640. Each step is non-fatal and prints the manual command if it fails. Also fixes what the script and its docs claimed: it never configured sudoers, its closing hint pointed at ./configure_web_sudo.sh (wrong path), and the README and ADVANCED_FEATURES.md said to run it with sudo, which it refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): validate and harden every sudoers drop-in the scripts write configure_wifi_permissions.sh copied its rules into /etc/sudoers.d/ledmatrix_wifi without `visudo -c`. A malformed drop-in makes sudo refuse every command for every user, which on a headless Pi leaves no way back in. It now checks first and leaves the installed file alone when the rules do not parse, as the other two writers do. (It already used mktemp, so that part of the review did not apply.) It also grants the two literal commands wifi_manager.py runs for NetworkManager's shared-mode dnsmasq drop-in -- `cp /tmp/ledmatrix-nm-dnsmasq.conf .../dnsmasq-shared.d/ledmatrix-captive.conf` and `rm -f` of that file. The directory's mkdir was granted, the file was not. Both are pinned in test_sudo_allowlist_covers_calls.py. configure_web_sudo.sh wrote its rules to /tmp/ledmatrix_web_sudoers_$$, a predictable name in a world-writable directory; it now uses mktemp with an EXIT trap, as first_time_install.sh does. It sets mode 440 on the installed file instead of leaving the temp file's mode, and finds visudo in /usr/sbin when that is not on the user's PATH, which skipped the check silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): escape the project path in the DNS-fix and MQTT unit renderers install_dns_fix.sh and install_mqtt_bridge.sh substituted __PROJECT_ROOT_DIR__ with the raw path, while the other three renderers go through sed_escape_replacement from lib_systemd_render.sh. A checkout under a path containing `&`, `\` or `|` rendered a corrupted unit from these two only. Both now source the helper and use it, and a test checks that every placeholder substitution in scripts/install uses an escaped value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): stop the installer scripts reporting things that are not true - first_time_install.sh printed "Password: ledmatrix123" for the setup access point. wifi_manager creates it as an open network ("No password" on the panel), so it now says so. - Step 10.1 printed "✓ WiFi management permissions configured" straight after its own failure message; install_wifi_monitor.sh printed "✓ Package installation completed" after a failed apt install. The tick now only follows success. - Step 7 printed "Web dependencies already installed ... in Step 5" in the one branch that runs because Step 5 did not install them, then created .web_deps_installed on that basis. It now warns and leaves the marker off so the next run retries, as the comment below it intends. - check_system_compatibility.sh called Debian 12 Bookworm "full compatibility confirmed" while first_time_install.sh refuses anything but Debian 13. Bookworm, older Debian and non-Debian systems are now errors. Its counters used ((X++)), which under `set -e` exits the script at the first warning or error (the expression is 0), so the check never reached its summary on any system with one. - configure_web_sudo.sh and configure_wifi_permissions.sh finished by testing `sudo -n test -f ...` and `sudo -n nmcli device status`, neither of which is granted, so they always reported a failure. They now ask `sudo -n -l` about commands the new rules do grant, which checks the rule without running anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): print the completion summary before rebooting With -y -- and so for every one-shot `curl | bash` install, which always passes -y -- first_time_install.sh ran `reboot` about 180 lines before its "Installation Complete / Web UI Access" summary. reboot returns at once, so the summary printed while the Pi was going down and the SSH session usually dropped before the web UI address could be read. The reboot block moves, unchanged, to the very end of the script. The interactive prompt now also follows the summary. Because the summary now runs before the -y reboot, its one command that could fail under `set -Eeuo pipefail` (the SSID lookup, when nmcli reports a connected device but no active network line) gets `|| true`; a missing SSID was already handled as "SSID unknown". one-shot-install.sh prints its "Next steps" after the installer returns, by which time the reboot is under way, so it now says so, and README's Quick Install mentions the automatic reboot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(scripts): correct wrong comments and messages, drop dead code No behaviour change except the output text noted below. - 2775 is setgid, not the sticky bit (first_time_install.sh Step 3.1, fix_plugin_permissions.sh), and root needs no "PWM hardware access" to plugin files. - The 777 comments in first_time_install.sh Step 3's fallback and fix_assets_permissions.sh said root needs it to write. Root ignores mode bits; the comments now say what 777 actually opens. The 777 itself is unchanged. - apt_remove ends in `|| true`, so Step 12's "Some packages could not be removed" branch could never run; it is gone and the helper stays non-fatal. - detect_web_service_user's comment named Step 8 for the web unit (install_service.sh installs it in Step 7.5) and now says which branch actually runs. - Step 5 described an "already installed" check that does not exist; the ACTUAL_USER comment described the re-exec backwards. - on_error printed a literal "\n" before "Common fixes:". - Dead code: one-shot-install.sh's uncalled fix_tmp_permissions, LEDMATRIX_ELEVATED=1 (never read) on the sudo re-exec, and configure_web_sudo.sh's unused PYTHON_PATH, which also made a missing python3 fatal for rules that never mention it. - start_display.sh / stop_display.sh said "for user: <you>"; the service runs as root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(fix_perms): fix_cache_permissions.sh uses setup_cache.sh's model There were two models for /var/cache/ledmatrix. setup_cache.sh (the installer's Step 2) and install_web_service.sh share it through the ledmatrix group: root:ledmatrix, 2775, files 660, which is also what DiskCache relies on to give files the directory's group. fix_cache_permissions.sh instead made it 777 and re-grouped it to the invoking user's group, undoing that. It now runs setup_cache.sh for /var/cache/ledmatrix and keeps its own handling of ~/.ledmatrix_cache. Dropped: /var/cache/ledmatrix/ placeholder_logos (nothing reads it) and the checks against the `daemon` user (no service runs as daemon). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: pin actions/checkout in the Claude workflows, drop template comments claude.yml and claude-code-review.yml used actions/checkout@v4 while test.yml and release-version-check.yml pin the v4.2.2 commit SHA; they now pin the same SHA. The commented-out starter-template settings (prompt, claude_args, paths, author filter) are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(scripts): index every script and list removal candidates New scripts/README.md gives one line per top-level script and scripts directory, marked keep, dev-only or diagnostic, and lists the eight scripts nothing in the repo refers to as candidates for removal (kept for now). The install, utils and dev READMEs now list the files they were missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: tighten two checks that mutation testing showed were too loose - The wifi sudoers check matched `visudo -c -f "$TEMP_SUDOERS"` in the error report too, so replacing the check with `if false` still passed. It now requires the command as the condition. - The summary test never had the setup access point up, so reinstating the bogus "Password: ledmatrix123" line went unnoticed. A case with hostapd active now checks the AP is described as open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(permissions): describe the repaired fix_perms scripts and new WiFi grants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): docs-scripts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1142 lines
37 KiB
Markdown
1142 lines
37 KiB
Markdown
# Advanced Features Guide
|
||
|
||
This guide covers advanced LEDMatrix features for users and developers, including Vegas scroll mode, on-demand display, cache management, background services, and permission management.
|
||
|
||
---
|
||
|
||
## 1. Vegas Scroll Mode
|
||
|
||
### Overview
|
||
|
||
Vegas scroll mode displays content from multiple plugins in a continuous horizontal scroll, similar to news tickers seen in Las Vegas casinos. Plugins contribute content segments that flow across the display in a seamless ticker-style presentation.
|
||
|
||
### Display Modes
|
||
|
||
**SCROLL (Continuous Scrolling):**
|
||
- Content scrolls continuously left
|
||
- Smooth, fluid motion
|
||
- Best for news-ticker style displays
|
||
|
||
**FIXED_SEGMENT (Fixed-Width Block):**
|
||
- Plugin gets fixed-width block on display
|
||
- Content doesn't scroll out of its segment
|
||
- Multiple plugins can share the display simultaneously
|
||
|
||
**STATIC (Scroll Pauses):**
|
||
- Scrolling pauses when content is fully visible
|
||
- Displays for specified duration, then resumes scrolling
|
||
- Best for content that needs to be fully read
|
||
|
||
### Configuration
|
||
|
||
Enable Vegas mode in `config/config.json`:
|
||
|
||
```json
|
||
{
|
||
"display": {
|
||
"vegas_scroll": {
|
||
"enabled": true,
|
||
"scroll_speed": 50,
|
||
"separator_width": 32,
|
||
"plugin_order": ["clock", "weather", "sports"],
|
||
"excluded_plugins": ["debug_plugin"],
|
||
"target_fps": 125,
|
||
"buffer_ahead": 2
|
||
}
|
||
}
|
||
}
|
||
```
|
||
|
||
Vegas mode can also be configured entirely from the web UI — the
|
||
**Display** tab has a Vegas Scroll Mode section (enable toggle, scroll
|
||
speed, separator width, dynamic duration, and more), so hand-editing
|
||
JSON is optional.
|
||
|
||
**Configuration Options:**
|
||
|
||
| Setting | Default | Description |
|
||
|---------|---------|-------------|
|
||
| `enabled` | `false` | Enable Vegas scroll mode |
|
||
| `scroll_speed` | `50` | Pixels per second scroll speed |
|
||
| `separator_width` | `32` | Width between plugin segments (pixels) |
|
||
| `plugin_order` | `[]` | Plugin display order (empty = auto) |
|
||
| `excluded_plugins` | `[]` | Plugins to exclude from Vegas mode |
|
||
| `target_fps` | `125` | Target frame rate |
|
||
| `buffer_ahead` | `2` | Number of plugins buffered ahead |
|
||
|
||
This table is a subset — `display.vegas_scroll` supports 30 keys in
|
||
total. See the full list in
|
||
[CONFIG_REFERENCE.md](CONFIG_REFERENCE.md#displayvegas_scroll--continuous-scroll-mode).
|
||
|
||
### Live Content in the Ticker
|
||
|
||
By default, live content **preempts** Vegas mode: while any plugin reports
|
||
live priority, the display controller refuses to run the ticker and shows
|
||
that plugin's full-screen display instead. You get a big readable scoreboard,
|
||
but the marquee stops entirely for the duration of the game.
|
||
|
||
Set `live_in_ticker` to keep the ticker running and let live content take
|
||
**extra turns inside it** instead:
|
||
|
||
```json
|
||
"vegas_scroll": {
|
||
"live_in_ticker": true,
|
||
"live_weight": 3,
|
||
"favorite_live_weight": 5
|
||
}
|
||
```
|
||
|
||
#### Why weights exist
|
||
|
||
The rotation is otherwise a strict round robin — every plugin appears exactly
|
||
once per cycle. With a dozen plugins enabled, a live score comes round once a
|
||
lap and can be minutes old by the time you see it. A weight of *N* gives a
|
||
plugin *N* slots per cycle.
|
||
|
||
The slots are placed by **Smooth Weighted Round-Robin**, the same scheduler
|
||
the sports plugins use internally to rotate their own games. The important
|
||
property is that repeats are *spread through the cycle* rather than clumped:
|
||
three appearances in a row followed by a long silence would be worse than not
|
||
boosting at all.
|
||
|
||
Twelve plugins, with a favorite's baseball game and an ordinary live hockey
|
||
game (`live_weight: 3`, `favorite_live_weight: 5`):
|
||
|
||
```
|
||
baseball > hockey > weather > clock > baseball
|
||
stocks > news > flights > baseball > hockey
|
||
calendar > f1 > music > baseball > tides
|
||
birds > hockey > baseball
|
||
```
|
||
|
||
18 slots for 12 plugins. Baseball appears 5 times, hockey 3, everything else
|
||
once, and no plugin ever appears twice in a row — **including across the seam**
|
||
where the cycle loops back on itself. Smooth Weighted Round-Robin schedules the
|
||
heaviest item first and usually last as well, so the strip would otherwise show
|
||
it twice running at exactly the one join a within-cycle check cannot see. The
|
||
trailing repeat is moved into the widest remaining gap. Where a double is
|
||
unavoidable — a plugin holding most of the slots has to neighbour itself — the
|
||
schedule is left as it is.
|
||
|
||
#### Where the weight comes from
|
||
|
||
For each plugin in the rotation, in order:
|
||
|
||
1. **The plugin's own answer.** If it implements
|
||
`get_vegas_priority_weight()` and returns a number, that wins. This is the
|
||
only route for favorite-team awareness — the core can see *that* a game is
|
||
live, but not *whose*, so a scoreboard has to say so itself.
|
||
2. **The core's default.** When the plugin returns `None` (the base-class
|
||
default), a plugin where both `has_live_priority()` and `has_live_content()`
|
||
are true gets `live_weight`.
|
||
3. **Everything else** gets 1.
|
||
|
||
Because of step 2, **existing plugins need no changes** — any scoreboard with
|
||
`live_priority` enabled already gets extra turns. Step 1 is opt-in, for
|
||
plugins that want to distinguish a favorite's game from any other live game.
|
||
|
||
Weights are clamped to 1–10. A weight of 1 is no boost; a weight below 1 would
|
||
drop the plugin from the rotation entirely, which is never what is meant.
|
||
|
||
#### Things worth knowing
|
||
|
||
- **Weights are per plugin, not per game.** A scoreboard showing four live
|
||
games still occupies one slot at a time, rotating its own games within that
|
||
slot using its own `favorite_live_boost`. This controls how often the
|
||
*plugin* comes round.
|
||
- **The ticker is zero-sum.** Giving baseball 5 slots does not make the cycle
|
||
faster; it makes the cycle *longer* and everything else proportionally
|
||
rarer. If you want live scores sooner in wall-clock terms, pair this with a
|
||
smaller `plugins_per_cycle`.
|
||
- **Frequency is not freshness.** Each appearance redraws from the plugin's
|
||
current data (`refresh_updated_plugins()` drops cached content when a
|
||
plugin's data changes), but how current that data is depends on the
|
||
plugin's own `live_update_interval`. Showing a stale score five times a lap
|
||
is no better than showing it once.
|
||
- **Everything still appears.** A boost never starves another plugin out of
|
||
the cycle; low-weight plugins keep their single slot.
|
||
|
||
### Per-Plugin Configuration
|
||
|
||
Override Vegas behavior for specific plugins:
|
||
|
||
```json
|
||
{
|
||
"my_plugin": {
|
||
"enabled": true,
|
||
"vegas_mode": "scroll",
|
||
"vegas_panel_count": 2,
|
||
"display_duration": 10
|
||
}
|
||
}
|
||
```
|
||
|
||
**Per-Plugin Options:**
|
||
|
||
| Setting | Values | Description |
|
||
|---------|--------|-------------|
|
||
| `vegas_mode` | `scroll`, `fixed`, `static` | Display mode for this plugin |
|
||
| `vegas_panel_count` | any positive integer | Width in panels (1 panel = display width) |
|
||
| `display_duration` | seconds | Pause duration for STATIC mode |
|
||
|
||
Plugins may also set `vegas_overflow` and `vegas_max_width_screens` in
|
||
their config section to control how oversized content is handled (see
|
||
`PluginManager` in `src/plugin_system/plugin_manager.py`).
|
||
|
||
### Plugin Integration (Developer Guide)
|
||
|
||
All of these have defaults in
|
||
[`BasePlugin`](../src/plugin_system/base_plugin.py); override only what you
|
||
need.
|
||
|
||
**1. Implement Content Method:**
|
||
|
||
```python
|
||
def get_vegas_content(self):
|
||
# Return a PIL Image, a list of Images, or None.
|
||
# A single image is one block; a list becomes one item per image.
|
||
return [self._render_game(game) for game in self.games]
|
||
```
|
||
|
||
If it returns `None` (the default), Vegas falls back to the plugin's
|
||
`scroll_helper` image, then to capturing `display()` output
|
||
(`PluginAdapter.get_content()` in
|
||
[`src/vegas_mode/plugin_adapter.py`](../src/vegas_mode/plugin_adapter.py)).
|
||
|
||
**2. Specify Content Type:**
|
||
|
||
```python
|
||
def get_vegas_content_type(self):
|
||
# 'multi' | 'static' | 'none' -- default is 'static'
|
||
return 'multi'
|
||
```
|
||
|
||
`'none'` excludes the plugin from Vegas mode.
|
||
|
||
**3. Optionally Specify Display Mode:**
|
||
|
||
These return `VegasDisplayMode` members, not strings:
|
||
|
||
```python
|
||
from src.plugin_system.base_plugin import VegasDisplayMode
|
||
|
||
def get_vegas_display_mode(self):
|
||
return VegasDisplayMode.SCROLL
|
||
|
||
def get_supported_vegas_modes(self):
|
||
return [VegasDisplayMode.SCROLL, VegasDisplayMode.STATIC]
|
||
```
|
||
|
||
`VegasDisplayMode` has `SCROLL` (`"scroll"`), `FIXED_SEGMENT` (`"fixed"`) and
|
||
`STATIC` (`"static"`). The default `get_vegas_display_mode()` uses the
|
||
plugin's `vegas_mode` config value if set, otherwise maps the content type
|
||
(`multi` to `SCROLL`, anything else to `FIXED_SEGMENT`).
|
||
|
||
### Content Rendering Guidelines
|
||
|
||
**Image Dimensions:**
|
||
- **Height:** Must match display height (typically 32 pixels)
|
||
- **Width:** Varies by mode:
|
||
- SCROLL: Any width (recommended 64-512 pixels)
|
||
- FIXED_SEGMENT: `panel_count * display_width`
|
||
- STATIC: Any width, optimized for readability
|
||
|
||
**Color Mode:**
|
||
- Use RGB color mode
|
||
- 24-bit color (8 bits per channel)
|
||
|
||
**Performance Tips:**
|
||
1. **Cache rendered images** - Render in `update()`, not in `get_vegas_content()`
|
||
2. **Keep images small** - Larger images use more memory
|
||
3. **Pre-render on update** - Don't create images on-demand
|
||
4. **Reuse images** - Return same image if content unchanged
|
||
|
||
### Example Integration
|
||
|
||
Complete example for a weather plugin:
|
||
|
||
```python
|
||
class WeatherPlugin(BasePlugin):
|
||
def __init__(self, *args, **kwargs):
|
||
super().__init__(*args, **kwargs)
|
||
self.vegas_image = None
|
||
|
||
def update(self):
|
||
"""Update data and pre-render Vegas image"""
|
||
# Fetch weather data
|
||
weather_data = self.fetch_weather()
|
||
|
||
# Pre-render Vegas image
|
||
self.vegas_image = self._render_vegas_content(weather_data)
|
||
|
||
def _render_vegas_content(self, data):
|
||
"""Render weather content for Vegas mode"""
|
||
img = Image.new('RGB', (384, 32))
|
||
draw = ImageDraw.Draw(img)
|
||
|
||
# Draw temperature
|
||
draw.text((10, 0), f"{data['temp']}°F", fill=(255, 255, 255))
|
||
|
||
# Draw condition
|
||
draw.text((100, 0), data['condition'], fill=(200, 200, 200))
|
||
|
||
# Draw icon
|
||
icon = Image.open(f"assets/{data['icon']}.png")
|
||
img.paste(icon, (250, 0))
|
||
|
||
return img
|
||
|
||
def get_vegas_content(self):
|
||
"""Return cached Vegas image"""
|
||
return self.vegas_image
|
||
|
||
def get_vegas_content_type(self):
|
||
return 'multi'
|
||
|
||
def get_vegas_display_mode(self):
|
||
return 'scroll'
|
||
|
||
def get_supported_vegas_modes(self):
|
||
return ['scroll', 'static']
|
||
```
|
||
|
||
### System Architecture
|
||
|
||
Vegas mode consists of four core components working together to provide smooth 125 FPS continuous scrolling:
|
||
|
||
#### Component Overview
|
||
|
||
```
|
||
┌─────────────────────────────────────────────────────────────┐
|
||
│ VegasModeCoordinator │
|
||
│ Main orchestrator - manages lifecycle and coordination │
|
||
└───────┬──────────────────┬──────────────────┬──────────────┘
|
||
│ │ │
|
||
▼ ▼ ▼
|
||
┌───────────────┐ ┌──────────────┐ ┌─────────────────┐
|
||
│ PluginAdapter │ │StreamManager │ │ RenderPipeline │
|
||
│ │ │ │ │ │
|
||
│ Converts │─▶│ Manages │─▶│ 125 FPS render │
|
||
│ plugin content│ │ content │ │ Double-buffered │
|
||
│ to images │ │ stream with │ │ Smooth scroll │
|
||
│ │ │ 1-2 ahead │ │ │
|
||
└───────────────┘ │ buffering │ └─────────────────┘
|
||
└──────────────┘
|
||
```
|
||
|
||
#### 1. VegasModeCoordinator
|
||
|
||
**Responsibilities:**
|
||
- Initialize and coordinate all Vegas mode components
|
||
- Manage the high-FPS render loop (target: 125 FPS)
|
||
- Handle live priority interruptions
|
||
- Process config updates during runtime
|
||
- Provide status and control interface
|
||
|
||
**Key Features:**
|
||
- Thread-safe state management
|
||
- Config hot-reload support
|
||
- Live priority integration
|
||
- Interrupt checking for yielding control back to display controller
|
||
- Static pause handling (pauses scroll when content fully visible)
|
||
|
||
**Main Loop:**
|
||
1. Check for interrupts (live priority, on-demand, config updates)
|
||
2. If static pause active, wait for duration
|
||
3. Otherwise, delegate to render pipeline for frame rendering
|
||
4. Sleep to maintain target FPS
|
||
|
||
#### 2. StreamManager
|
||
|
||
**Responsibilities:**
|
||
- Manage plugin content streaming with look-ahead buffering
|
||
- Coordinate with PluginAdapter to fetch plugin content
|
||
- Handle plugin ordering and exclusions
|
||
- Optimize content generation timing
|
||
|
||
**Buffering Strategy:**
|
||
- **Buffer Ahead:** 1-2 panels (configurable)
|
||
- **Just-in-Time Generation:** Fetch content only when needed
|
||
- **Memory Efficient:** Only keep necessary content in memory
|
||
|
||
**Content Flow:**
|
||
1. Determine which plugins should appear in stream
|
||
2. Respect `plugin_order` configuration (or use default order)
|
||
3. Exclude plugins in `excluded_plugins` list
|
||
4. Request content from each plugin via PluginAdapter
|
||
5. Compose into continuous stream with separators
|
||
|
||
**Key Methods:**
|
||
- `get_next_segment()` - Returns the next buffered `ContentSegment` (or `None`)
|
||
- `take_next_group(count=None, offscreen_only=False)` - Hands over the next
|
||
slice of the rotation as `(plugin_id, images)` groups
|
||
- `get_grouped_content_for_composition()` - Buffered images grouped by plugin
|
||
- `mark_plugin_updated(plugin_id)` / `process_updates()` - Refresh one
|
||
plugin's segment in place when its data changes
|
||
- `refresh()` - Re-read the plugin list and config
|
||
- `advance_cycle()` - Clear the active buffer when a scroll cycle completes
|
||
|
||
(`src/vegas_mode/stream_manager.py`)
|
||
|
||
#### 3. PluginAdapter
|
||
|
||
**Responsibilities:**
|
||
- Convert plugin content to scrollable images
|
||
- Handle different Vegas display modes (SCROLL, FIXED, STATIC)
|
||
- Manage fallback for plugins without Vegas support
|
||
- Cache plugin content for performance
|
||
|
||
**Plugin Integration:**
|
||
1. **Check for Vegas support:**
|
||
- Calls `get_vegas_content()` if available
|
||
- Falls back to `display()` method if not
|
||
|
||
2. **Handle display mode:**
|
||
- SCROLL: Returns image as-is for continuous scrolling
|
||
- FIXED_SEGMENT: Creates fixed-width block (panel_count * display_width)
|
||
- STATIC: Marks content for pause-when-visible behavior
|
||
|
||
3. **Content type handling:**
|
||
- `multi`: Multiple segments (list of images)
|
||
- `static`: Single static image
|
||
- `none`: Skip this plugin in current cycle
|
||
|
||
**Fallback Behavior:**
|
||
- If plugin doesn't implement Vegas methods:
|
||
- Calls plugin's `display()` method
|
||
- Captures rendered display as static image
|
||
- Treats as fixed segment
|
||
- Ensures all plugins work in Vegas mode without explicit support
|
||
|
||
#### 4. RenderPipeline
|
||
|
||
**Responsibilities:**
|
||
- High-performance 125 FPS rendering
|
||
- Double-buffered composition for smooth scrolling
|
||
- Scroll position management
|
||
- Frame rate control
|
||
|
||
**Rendering Process:**
|
||
1. **Fetch Stream Content:** Get current stream from StreamManager
|
||
2. **Extract Viewport:** Calculate which portion of stream is visible
|
||
3. **Compose Frame:** Create frame with visible content
|
||
4. **Double Buffer:** Render to off-screen buffer
|
||
5. **Display:** Swap buffer to display
|
||
6. **Advance:** Update scroll position based on speed and elapsed time
|
||
|
||
**Performance Optimizations:**
|
||
- **Double Buffering:** Eliminates flicker
|
||
- **Viewport Extraction:** Only processes visible region
|
||
- **Frame Rate Control:** Precise timing to maintain 125 FPS
|
||
- **Pre-rendered Content:** Plugins pre-render during update()
|
||
|
||
**Scroll Speed Calculation:** motion is by elapsed time; `target_fps` paces
|
||
the render loop, not the speed.
|
||
```python
|
||
# frame_based_scrolling: false
|
||
scroll_position += scroll_speed * elapsed_time # scroll_speed in px/s
|
||
# frame_based_scrolling: true (the default) -- not stepping, just a clamp
|
||
applied = clamp(scroll_speed * scroll_delay, 0.1, 5) / scroll_delay
|
||
scroll_position += applied * elapsed_time
|
||
```
|
||
|
||
#### Component Interactions
|
||
|
||
**Initialization Flow:**
|
||
```
|
||
1. VegasModeCoordinator created
|
||
2. Coordinator creates PluginAdapter
|
||
3. Coordinator creates StreamManager (with PluginAdapter)
|
||
4. Coordinator creates RenderPipeline (with StreamManager)
|
||
5. All components initialized and ready
|
||
```
|
||
|
||
**Render Loop Flow:**
|
||
```
|
||
1. Coordinator starts render loop
|
||
2. Check for interrupts (live priority, on-demand)
|
||
3. RenderPipeline.render_frame():
|
||
a. Request current stream from StreamManager
|
||
b. StreamManager uses PluginAdapter to get plugin content
|
||
c. PluginAdapter calls plugin Vegas methods or fallback
|
||
d. Stream content returned to RenderPipeline
|
||
e. RenderPipeline extracts viewport and renders
|
||
4. Update scroll position
|
||
5. Sleep to maintain target FPS
|
||
6. Repeat from step 2
|
||
```
|
||
|
||
**Config Update Flow:**
|
||
```
|
||
1. Config change detected by Coordinator
|
||
2. Set _pending_config_update flag
|
||
3. On next render loop iteration:
|
||
a. Pause rendering
|
||
b. Update VegasModeConfig
|
||
c. Notify StreamManager of config change
|
||
d. StreamManager refreshes stream
|
||
e. Resume rendering
|
||
```
|
||
|
||
#### Thread Safety
|
||
|
||
All components use thread-safe patterns:
|
||
- **Coordinator:** Uses `threading.Lock` for state management
|
||
- **StreamManager:** Thread-safe content access
|
||
- **RenderPipeline:** Atomic frame composition
|
||
- **PluginAdapter:** Stateless operations (except caching)
|
||
|
||
#### Performance Characteristics
|
||
|
||
**Frame Rate:**
|
||
- Target: 125 FPS
|
||
- Actual: 100-125 FPS (depends on content complexity)
|
||
- Render time budget: ~8ms per frame
|
||
|
||
**Memory Usage:**
|
||
- Stream buffer: ~2-3 panels ahead
|
||
- Plugin content: Cached in plugin's `update()` method
|
||
- Double buffer: 2x display size
|
||
|
||
**CPU Usage:**
|
||
- Light load: 5-10% (simple content)
|
||
- Heavy load: 15-25% (complex content, many plugins)
|
||
- Optimized with numpy for pixel operations
|
||
|
||
### Fallback Behavior
|
||
|
||
If a plugin doesn't implement Vegas methods:
|
||
- System calls the plugin's `display()` method
|
||
- Captures the rendered display as a static image
|
||
- Treats it as a fixed segment
|
||
|
||
This ensures all plugins work in Vegas mode, even without explicit support.
|
||
|
||
---
|
||
|
||
## 2. On-Demand Display
|
||
|
||
### Overview
|
||
|
||
On-demand display allows users to manually trigger specific plugins to show immediately on the LED matrix, overriding the normal rotation. This is useful for:
|
||
- Quick checks (weather, scores, time)
|
||
- Pinning important information
|
||
- Testing plugins during development
|
||
- Showing specific content to visitors
|
||
|
||
### Priority Hierarchy
|
||
|
||
On-demand display has the highest priority:
|
||
|
||
```
|
||
Priority Order (highest to lowest):
|
||
1. On-Demand Display (manual trigger)
|
||
2. Live Priority (games in progress)
|
||
3. Normal Rotation
|
||
```
|
||
|
||
When on-demand expires or is cleared, the display returns to the next highest priority (live priority or normal rotation).
|
||
|
||
### Web Interface Controls
|
||
|
||
Each installed plugin has its own tab in the second nav row of the web
|
||
UI. Inside the plugin's tab, scroll to **On-Demand Controls**:
|
||
|
||
- **Run On-Demand** — triggers the plugin immediately, even if it's
|
||
disabled in the rotation
|
||
- **Stop On-Demand** — clears on-demand and returns to the normal
|
||
rotation
|
||
|
||
The display service must be running. The status banner at the top of
|
||
the plugin tab shows the active on-demand plugin, mode, and remaining
|
||
time when something is active.
|
||
|
||
### REST API Reference
|
||
|
||
The API is mounted at `/api/v3` (the `api_v3` blueprint, registered in
|
||
`web_interface/app.py`). Full details: [REST_API_REFERENCE.md](REST_API_REFERENCE.md#display-control).
|
||
|
||
#### Start On-Demand Display
|
||
|
||
```bash
|
||
POST /api/v3/display/on-demand/start
|
||
|
||
# Body:
|
||
{
|
||
"plugin_id": "weather",
|
||
"duration": 30, # Optional: seconds (0 = indefinite, null = default)
|
||
"pinned": false # Optional: keep until manually cleared
|
||
}
|
||
|
||
# Examples:
|
||
# 30-second preview
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "weather", "duration": 30}'
|
||
|
||
# Pin indefinitely
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
|
||
```
|
||
|
||
#### Stop On-Demand Display
|
||
|
||
```bash
|
||
POST /api/v3/display/on-demand/stop
|
||
|
||
# Body:
|
||
{
|
||
"stop_service": false # Optional: also stop display service
|
||
}
|
||
|
||
# Examples:
|
||
# Clear on-demand
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
|
||
|
||
# Stop service too
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"stop_service": true}'
|
||
```
|
||
|
||
#### Get On-Demand Status
|
||
|
||
```bash
|
||
GET /api/v3/display/on-demand/status
|
||
|
||
# Example:
|
||
curl http://localhost:5000/api/v3/display/on-demand/status
|
||
|
||
# Response:
|
||
{
|
||
"status": "success",
|
||
"data": {
|
||
"state": {
|
||
"active": true,
|
||
"plugin_id": "weather",
|
||
"mode": "weather",
|
||
"duration": 30,
|
||
"pinned": false,
|
||
"status": "running",
|
||
"last_updated": 1234567890.1
|
||
},
|
||
"service": {"active": true, "returncode": 0, "stdout": "active", "stderr": ""}
|
||
}
|
||
}
|
||
```
|
||
|
||
When nothing is running on demand, `data.state` is
|
||
`{"active": false, "status": "idle", "last_updated": null}`.
|
||
|
||
> There is no public Python on-demand API. The display controller's
|
||
> on-demand machinery is internal — drive it through the REST endpoints
|
||
> above (or the web UI buttons). The API handlers
|
||
> (`start_on_demand_display()` / `stop_on_demand_display()` in
|
||
> `web_interface/blueprints/api_v3/display.py`) write a request into the cache
|
||
> manager under the `display_on_demand_request` key, which
|
||
> `DisplayController._poll_on_demand_requests()`
|
||
> (`src/display_controller.py`) picks up. A separate
|
||
> `display_on_demand_config` key is used by the controller itself
|
||
> during activation (`_activate_on_demand()`) to track what's
|
||
> currently running, and is cleared by `_clear_on_demand()`.
|
||
|
||
### Duration Modes
|
||
|
||
| Duration | Pinned | Behavior |
|
||
|----------|--------|----------|
|
||
| `None` | `false` | Use plugin's default duration, auto-clear when expires |
|
||
| `0` | `false` | Indefinite, clears manually or on error |
|
||
| `> 0` | `false` | Timed display, auto-clear after N seconds |
|
||
| Any | `true` | Pin until manually cleared (ignores duration) |
|
||
|
||
### Use Case Examples
|
||
|
||
**Quick check (30-second preview):**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "ledmatrix-weather", "duration": 30}'
|
||
```
|
||
|
||
**Pin important information:**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "hockey-scoreboard", "pinned": true}'
|
||
# ... later ...
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/stop
|
||
```
|
||
|
||
**Indefinite display:**
|
||
```bash
|
||
curl -X POST http://localhost:5000/api/v3/display/on-demand/start \
|
||
-H "Content-Type: application/json" \
|
||
-d '{"plugin_id": "text-display", "duration": 0}'
|
||
```
|
||
|
||
**Testing a plugin during development:** the same call works, or just
|
||
click **Run On-Demand** in the plugin's tab.
|
||
|
||
### Best Practices
|
||
|
||
**For Users:**
|
||
1. Use timed display as default (prevents forgetting to clear)
|
||
2. Pin only when necessary
|
||
3. Clear when done to return to normal rotation
|
||
|
||
**For Developers:**
|
||
1. Validate plugin ID exists before calling
|
||
2. Provide visual feedback in UI (loading state, status updates)
|
||
3. Handle concurrent requests gracefully
|
||
4. Log on-demand activations for debugging
|
||
|
||
### Security Considerations
|
||
|
||
**Authentication:**
|
||
- Add authentication to API endpoints
|
||
- Restrict on-demand to authorized users
|
||
|
||
**Rate Limiting:**
|
||
- Prevent abuse from rapid requests
|
||
- Implement cooldown between activations
|
||
|
||
**Input Validation:**
|
||
- Sanitize plugin IDs
|
||
- Validate duration values
|
||
- Check plugin exists before activation
|
||
|
||
---
|
||
|
||
## 3. On-Demand Cache Management
|
||
|
||
### Overview
|
||
|
||
On-demand display uses cache keys (managed by `src/cache_manager.py` —
|
||
file-based, not Redis) to coordinate state between the web interface
|
||
and the display controller across service restarts. Understanding these
|
||
keys helps troubleshoot stuck states.
|
||
|
||
### Cache Keys
|
||
|
||
**1. display_on_demand_request** (TTL: 1 hour)
|
||
```json
|
||
{
|
||
"request_id": "uuid-string",
|
||
"action": "start|stop",
|
||
"plugin_id": "plugin-name",
|
||
"mode": "mode-name",
|
||
"duration": 30.0,
|
||
"pinned": true,
|
||
"timestamp": 1234567890.123
|
||
}
|
||
```
|
||
**Purpose:** Communication from web interface to display controller
|
||
**When Set:** API endpoint receives request
|
||
**Auto-Cleared:** After processing or 1 hour TTL
|
||
|
||
**2. display_on_demand_config** (No TTL)
|
||
```json
|
||
{
|
||
"mode": "mode-name",
|
||
"duration": 30.0,
|
||
"pinned": true
|
||
}
|
||
```
|
||
**Purpose:** Persistent configuration for display controller
|
||
**When Set:** Controller processes start request
|
||
**Auto-Cleared:** When on-demand stops
|
||
|
||
**3. display_on_demand_state** (Continuously updated)
|
||
```json
|
||
{
|
||
"active": true,
|
||
"mode": "mode-name",
|
||
"remaining": 25.5,
|
||
"pinned": true,
|
||
"status": "active|idle|restarting|error"
|
||
}
|
||
```
|
||
**Purpose:** Real-time state for web interface status card
|
||
**When Set:** Every display loop iteration
|
||
**Auto-Cleared:** Never (continuously updated)
|
||
|
||
**4. display_on_demand_processed_id** (TTL: 1 hour)
|
||
```text
|
||
"uuid-string-of-last-processed-request"
|
||
```
|
||
**Purpose:** Prevents duplicate request processing
|
||
**When Set:** After processing request
|
||
**Auto-Cleared:** After 1 hour TTL
|
||
|
||
### When Manual Clearing is Needed
|
||
|
||
**Scenario 1: Stuck in On-Demand State**
|
||
- Symptom: Display stays on one plugin, won't return to rotation
|
||
- Clear: `config`, `state`, `request`
|
||
|
||
**Scenario 2: Mode Switching Issues**
|
||
- Symptom: Can't change to different plugin
|
||
- Clear: `request`, `processed_id`, `state`
|
||
|
||
**Scenario 3: On-Demand Not Activating**
|
||
- Symptom: Button click does nothing
|
||
- Clear: `processed_id`, `request`
|
||
|
||
**Scenario 4: After Service Crash**
|
||
- Symptom: Strange behavior after crash/restart
|
||
- Clear: All four keys
|
||
|
||
### Manual Recovery Procedures
|
||
|
||
**Via Web Interface (Recommended):**
|
||
1. Open the **Cache** tab in the web UI
|
||
2. Find the `display_on_demand_*` entries
|
||
3. Delete them
|
||
4. Restart display: `sudo systemctl restart ledmatrix`
|
||
|
||
**Via Command Line:**
|
||
|
||
The cache is stored as JSON files under one of:
|
||
|
||
- `/var/cache/ledmatrix/` (preferred when the service has permission)
|
||
- `~/.ledmatrix_cache/`
|
||
- `/opt/ledmatrix/cache/`
|
||
- `$TMPDIR/ledmatrix_cache/` (fallback)
|
||
|
||
```bash
|
||
# Find the cache dir actually in use
|
||
journalctl -u ledmatrix | grep -i "cache directory" | tail -1
|
||
|
||
# Clear all on-demand keys (replace path with the one above)
|
||
rm /var/cache/ledmatrix/display_on_demand_*
|
||
|
||
# Restart service
|
||
sudo systemctl restart ledmatrix
|
||
```
|
||
|
||
**Via Python:**
|
||
```python
|
||
from src.cache_manager import CacheManager
|
||
|
||
cache = CacheManager()
|
||
cache.clear_cache('display_on_demand_config')
|
||
cache.clear_cache('display_on_demand_state')
|
||
cache.clear_cache('display_on_demand_request')
|
||
cache.clear_cache('display_on_demand_processed_id')
|
||
```
|
||
|
||
> `CacheManager` also has a `delete(key)` method — a thin wrapper over
|
||
> `clear_cache(key)` — so `cache.delete('display_on_demand_config')`
|
||
> works equally well.
|
||
|
||
### Cache Impact on Running Service
|
||
|
||
**IMPORTANT:** Clearing cache keys does NOT immediately affect the running controller in memory.
|
||
|
||
**To fully reset:**
|
||
1. Stop the service: `sudo systemctl stop ledmatrix`
|
||
2. Clear cache keys (web UI Cache tab or `rm` from the cache directory)
|
||
3. Clear systemd environment: `sudo systemctl daemon-reload`
|
||
4. Start the service: `sudo systemctl start ledmatrix`
|
||
|
||
### Automatic Cleanup
|
||
|
||
The display controller automatically handles cleanup:
|
||
- **Config key**: Cleared when on-demand stops
|
||
- **State key**: Updated every display loop iteration
|
||
- **Request key**: Expires after 1 hour TTL (or after processing)
|
||
- **Processed ID**: Expires after 1 hour TTL
|
||
|
||
---
|
||
|
||
## 4. Background Data Service
|
||
|
||
### Overview
|
||
|
||
The Background Data Service enables non-blocking data fetching through background threading. This prevents the main display loop from freezing during slow API requests, maintaining smooth display rotation.
|
||
|
||
### Benefits
|
||
|
||
**Performance:**
|
||
- Display loop never freezes during API calls
|
||
- Immediate response with cached/partial data
|
||
- Complete data loads in background
|
||
|
||
**User Experience:**
|
||
- No "frozen" display during data updates
|
||
- Smooth transitions between plugins
|
||
- Faster perceived load times
|
||
|
||
**Architecture:**
|
||
```
|
||
Cache Check → Background Fetch → Partial Data → Completion → Cache
|
||
(0.1s) (async) (<1s) (10-30s) (cache)
|
||
```
|
||
|
||
### Configuration
|
||
|
||
Core does not read a `background_service` config block: the service itself
|
||
(`src/background_data_service.py`) is a process-wide singleton, and its
|
||
worker count is whatever the first caller of `get_background_service()`
|
||
passes. The sports scoreboard plugins read their own
|
||
`background_service` settings and pass them to it, so the exact keys and
|
||
where they sit (top level or per league) are defined by each plugin's
|
||
`config_schema.json`. A typical block looks like:
|
||
|
||
```json
|
||
{
|
||
"football-scoreboard": {
|
||
"enabled": true,
|
||
"background_service": {
|
||
"enabled": true,
|
||
"max_workers": 3,
|
||
"request_timeout": 30,
|
||
"max_retries": 3,
|
||
"priority": 2
|
||
}
|
||
}
|
||
}
|
||
```
|
||
|
||
**Configuration Options:**
|
||
|
||
| Setting | Default | Description |
|
||
|---------|---------|-------------|
|
||
| `enabled` | plugin-defined | Use the background service for this plugin's fetches |
|
||
| `max_workers` | `3` | Max concurrent background tasks |
|
||
| `request_timeout` | `30` | Timeout per API request (seconds) |
|
||
| `max_retries` | `3` | Retry attempts on failure |
|
||
| `priority` | `1` | Stored on each request (higher number = higher priority, per `FetchRequest`), but the service runs requests in submission order; it does not reorder by priority |
|
||
|
||
### Performance Impact
|
||
|
||
**First Request (Cache Empty):**
|
||
- Returns partial data: < 1 second
|
||
- Background completes: 10-30 seconds
|
||
- Subsequent requests use cache: < 0.1 seconds
|
||
|
||
**Subsequent Requests (Cache Hit):**
|
||
- Returns immediately: < 0.1 seconds
|
||
- Background refresh (if stale): async, no blocking
|
||
|
||
### Plugins using the background service
|
||
|
||
The background data service is used by all of the sports scoreboard
|
||
plugins (football, hockey, baseball/MLB, basketball, soccer, lacrosse,
|
||
F1, UFC), the odds ticker, and the leaderboard plugin. Each plugin reads
|
||
its own `background_service` block (under its own config namespace); check
|
||
that plugin's `config_schema.json` for the keys it accepts.
|
||
|
||
### Error Handling & Fallback
|
||
|
||
**Automatic Retry:**
|
||
- Exponential backoff (1s, 2s, 4s, 8s, ...)
|
||
- Maximum retry attempts configurable
|
||
- Logs all retry attempts
|
||
|
||
**Fallback Behavior:**
|
||
- If background service disabled: reverts to synchronous fetching
|
||
- If background fetch fails: returns cached data
|
||
- If no cache: returns empty/error state
|
||
|
||
### Testing
|
||
|
||
```bash
|
||
# Check logs for background operations
|
||
sudo journalctl -u ledmatrix -f | grep "background"
|
||
```
|
||
|
||
### Monitoring
|
||
|
||
**View Statistics:**
|
||
```python
|
||
from src.background_data_service import get_background_service
|
||
from src.cache_manager import CacheManager
|
||
|
||
service = get_background_service(CacheManager())
|
||
stats = service.get_statistics()
|
||
print(f"Active: {stats['active_requests']}")
|
||
print(f"Completed: {stats['completed_requests']}")
|
||
print(f"Failed: {stats['failed_requests']}")
|
||
```
|
||
|
||
Other keys: `total_requests`, `cached_hits`, `cache_misses`,
|
||
`average_fetch_time`, `completed_requests_count` (results currently held in
|
||
memory) — see `BackgroundDataService.get_statistics()` in
|
||
[`src/background_data_service.py`](../src/background_data_service.py).
|
||
|
||
**Enable Debug Logging:**
|
||
```python
|
||
import logging
|
||
logging.getLogger('src.background_data_service').setLevel(logging.DEBUG)
|
||
```
|
||
|
||
---
|
||
|
||
## 5. Permission Management
|
||
|
||
Ownership, modes, sudo rules and the repair scripts are listed in
|
||
[PERMISSIONS.md](PERMISSIONS.md). This section covers the helpers code uses
|
||
to keep files shareable.
|
||
|
||
### Overview
|
||
|
||
LEDMatrix uses a dual-user architecture: the display service runs as root (hardware access), while the web interface runs as a non-privileged user. Centralized permission management ensures both can access necessary files.
|
||
|
||
### Why It Matters
|
||
|
||
**Problem:**
|
||
- Root service creates files with root ownership
|
||
- Web user cannot read/write those files
|
||
- Results in `PermissionError` exceptions
|
||
|
||
**Solution:**
|
||
- Set group ownership to shared group
|
||
- Grant group write permissions
|
||
- Use setgid bit for automatic inheritance
|
||
|
||
### Permission Utilities
|
||
|
||
```python
|
||
from src.common.permission_utils import (
|
||
ensure_directory_permissions,
|
||
ensure_file_permissions,
|
||
get_config_file_mode,
|
||
get_assets_file_mode,
|
||
get_assets_dir_mode,
|
||
get_plugin_file_mode,
|
||
get_cache_dir_mode
|
||
)
|
||
|
||
# Create directory with correct permissions
|
||
ensure_directory_permissions(Path("assets/sports"), get_assets_dir_mode())
|
||
|
||
# Set file permissions after writing
|
||
# (get_config_file_mode requires the file path — secrets files get a
|
||
# stricter mode than the main config)
|
||
config_path = Path("config/config.json")
|
||
ensure_file_permissions(config_path, get_config_file_mode(config_path))
|
||
```
|
||
|
||
### When to Use Utilities
|
||
|
||
**Use permission utilities when:**
|
||
1. Creating new directories
|
||
2. Writing configuration files
|
||
3. Downloading/creating asset files (logos, fonts)
|
||
4. Creating plugin files
|
||
5. Writing cache files
|
||
|
||
**Don't use for:**
|
||
1. Reading files (permissions don't change)
|
||
2. Temporary files in `/tmp`
|
||
3. Files in already-managed directories (if parent has setgid)
|
||
|
||
### Permission Standards
|
||
|
||
**File Permissions:**
|
||
|
||
| File Type | Mode | Octal | Description |
|
||
|-----------|------|-------|-------------|
|
||
| Config (main) | `rw-r--r--` | `0o644` | Owner write, all read |
|
||
| Config (secrets) | `rw-r-----` | `0o640` | Owner write, group read |
|
||
| Assets | `rw-rw-r--` | `0o664` | Owner/group write, all read |
|
||
| Plugins | `rw-rw-r--` | `0o664` | Owner/group write, all read |
|
||
| Cache files | `rw-rw----` | `0o660` | Owner/group write, no world access (`_CACHE_FILE_MODE` in `src/cache/disk_cache.py`) |
|
||
|
||
**Directory Permissions:**
|
||
|
||
| Directory Type | Mode | Octal | Description |
|
||
|----------------|------|-------|-------------|
|
||
| All directories | `rwxrwsr-x` | `0o2775` | With setgid bit for inheritance |
|
||
|
||
**Note:** The `s` in `rwxrwsr-x` is the setgid bit (2000), which makes new files inherit the directory's group ownership.
|
||
|
||
### Common Patterns
|
||
|
||
**Pattern 1: Creating Config Directory**
|
||
```python
|
||
from pathlib import Path
|
||
from src.common.permission_utils import ensure_directory_permissions, get_config_dir_mode
|
||
|
||
config_dir = Path("config/plugins")
|
||
ensure_directory_permissions(config_dir, get_config_dir_mode())
|
||
```
|
||
|
||
**Pattern 2: Saving Config File**
|
||
```python
|
||
from src.common.permission_utils import ensure_file_permissions, get_config_file_mode
|
||
|
||
config_path = Path("config/config.json")
|
||
with open(config_path, 'w') as f:
|
||
json.dump(data, f)
|
||
ensure_file_permissions(config_path, get_config_file_mode(config_path))
|
||
```
|
||
|
||
**Pattern 3: Downloading Logo**
|
||
```python
|
||
from src.common.permission_utils import ensure_directory_permissions, ensure_file_permissions
|
||
from src.common.permission_utils import get_assets_dir_mode, get_assets_file_mode
|
||
|
||
logo_path = Path("assets/sports/nhl/logo.png")
|
||
ensure_directory_permissions(logo_path.parent, get_assets_dir_mode())
|
||
# ... download and save logo ...
|
||
ensure_file_permissions(logo_path, get_assets_file_mode())
|
||
```
|
||
|
||
**Pattern 4: Creating Plugin File**
|
||
```python
|
||
from src.common.permission_utils import ensure_file_permissions, get_plugin_file_mode
|
||
|
||
plugin_file = Path("plugins/my-plugin/data.json")
|
||
with open(plugin_file, 'w') as f:
|
||
json.dump(data, f)
|
||
ensure_file_permissions(plugin_file, get_plugin_file_mode())
|
||
```
|
||
|
||
**Pattern 5: Cache Directory Setup**
|
||
```python
|
||
from src.common.permission_utils import ensure_directory_permissions, get_cache_dir_mode
|
||
|
||
cache_dir = Path("cache/plugin-name")
|
||
ensure_directory_permissions(cache_dir, get_cache_dir_mode())
|
||
```
|
||
|
||
### Integration with Core Utilities
|
||
|
||
These core utilities **already handle permissions** - you don't need to call permission utilities when using them:
|
||
|
||
- **ConfigManager** - Handles config file permissions
|
||
- **CacheManager** - Handles cache file permissions
|
||
- **LogoHelper** - Handles logo file permissions
|
||
- **PluginManager** - Handles plugin file permissions
|
||
|
||
### Manual Fixes
|
||
|
||
[PERMISSIONS.md](PERMISSIONS.md) lists who owns what on an installed system,
|
||
the expected modes, and which `scripts/fix_perms/` script to run as which
|
||
user. In short:
|
||
|
||
- `fix_assets_permissions.sh`, `fix_cache_permissions.sh` and
|
||
`fix_plugin_permissions.sh` are run with `sudo`.
|
||
- `fix_web_permissions.sh` is run as the web interface user, without
|
||
`sudo` (it refuses to run as root and calls `sudo` itself where needed).
|
||
It resets project file ownership for that user, then makes the two
|
||
helper scripts the web user may run as root (`safe_plugin_rm.sh`,
|
||
`safe_pip_install.sh`) root-owned again and restores `config_secrets.json`
|
||
to its owner, the `ledmatrix` group and mode `640`. It does not write
|
||
sudoers rules; `scripts/install/configure_web_sudo.sh` does that.
|
||
|
||
Do not `chmod` the whole `config/` directory: `config_secrets.json` must stay
|
||
`640`.
|
||
|
||
---
|
||
|
||
## Related Documentation
|
||
|
||
- [PLUGIN_DEVELOPMENT_GUIDE.md](PLUGIN_DEVELOPMENT_GUIDE.md) - Creating plugins with Vegas/on-demand support
|
||
- [WEB_INTERFACE_GUIDE.md](WEB_INTERFACE_GUIDE.md) - Using on-demand controls in web UI
|
||
- [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) - Complete API documentation
|
||
- [DEVELOPMENT.md](DEVELOPMENT.md) - Development environment and testing
|