mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 06:15:09 +00:00
* chore(scripts): delete unreferenced helper scripts None of these is referenced by an installer, systemd unit, CI workflow, test, the web UI or src/: - utils/cleanup_venv.sh removes venv_web_v2, which nothing creates - utils/clear_python_cache.sh hardcodes ~/LEDMatrix and a .webassets-cache nothing uses - install/migrate_config.sh only copies the template, which the installer and ConfigManager already do - install/debug_install.sh, debug/debug_web_manual.py - diagnose_web_ui.sh and verify_web_ui.sh overlap diagnose_web_interface.sh, which the docs point to - fix_internet_connectivity.sh is iptables-only (stale on nftables) - diagnose_plugin_permissions.sh, dev/validate_python.py - download_nba_logos.py + README_NBA_LOGOS.md: logo_downloader fetches logos on demand - setup_plugin_repos.py linked into the production plugin-repos/ dir; the dev workflow is scripts/dev/dev_plugin_setup.sh, and MULTI_ROOT_WORKSPACE_SETUP.md now uses it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(config): drop unused plugin_system flags and a dead unit comment - config.template.json: remove plugin_system.auto_discover, auto_load_enabled and development_mode. Nothing reads them; the web UI only stores them when a client sends them. ConfigManager's migration only adds template keys, so existing configs keep theirs unchanged. - config.template.json: re-indent vegas_scroll's live_* keys. - systemd/ledmatrix.service: remove the comment documenting LEDMATRIX_ON_DEMAND_PLUGIN / on_demand_env.conf; nothing reads either. - CONFIG_REFERENCE.md: say the legacy keys are no longer in the template. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: delete docs/archive and PLUGIN_IMPLEMENTATION_SUMMARY.md - docs/archive/: superseded guides; the repository history keeps them and no live doc links into the directory. The one open document in it, WEB_UI_AUDIT_2026-09.md, moves to docs/audits/ and is linked from the docs index. - PLUGIN_IMPLEMENTATION_SUMMARY.md invented usage statistics, called v2.0.0 current, listed shipped auto-updates as future work and documented a BasePlugin.get_config() that does not exist. - docs/README.md: drop both, and stop telling contributors to archive obsolete pages instead of deleting them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plugin-api): fix extra_small_font size, cache metric key and scroll pacing example - PLUGIN_API_REFERENCE: extra_small_font loads at 7, not 6 (crisp_size snaps it, src/display_manager.py); get_cache_metrics() returns cache_hit_rate, not hit_rate (src/cache/cache_metrics.py). - ADVANCED_PLUGIN_DEVELOPMENT: the basic scrolling example slept in a loop and never passed frame_hold; use ScrollHelper + scroll_config.configure() and set_scrolling_state(True, frame_hold=...) as PLUGIN_API_REFERENCE does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plugin-config): match the config tab, icon and web-action docs to the code - PLUGIN_CONFIG_QUICK_START / PLUGIN_CONFIGURATION_TABS / PLUGIN_CONFIGURATION_GUIDE: there is no "Reset to Defaults" button (the tab has Refresh, Update, Uninstall, Save Configuration); plugin config hot-reloads (ConfigService + on_config_change), so no restart; the schema is found by the fixed name config_schema.json, not a manifest config_schema field; the tab row is "Plugin Manager", not "Plugins"; forms are server-rendered from /v3/partials/plugin-config/<id>; the duration hook is get_display_duration()/display_duration; a class_name mismatch raises PluginError; the store requires id, name, class_name and display_modes (not version); plugin_system.debug/log_level do not exist (use run.py -d / LEDMATRIX_DEBUG). Drop "future" features that shipped. - PLUGIN_CONFIG_CORE_PROPERTIES: list all of CORE_PLUGIN_PROPERTIES, including skin, skin_options and the vegas_* tuning keys. - PLUGIN_CUSTOM_ICONS: icon is only a Font Awesome class (fallback fa-puzzle-piece); emoji/URL icons and getPluginIcon() never existed in v3. Note that /api/v3/plugins/installed currently omits icon. - PLUGIN_WEB_UI_ACTIONS (+ example JSON): success_message, error_message and step1_message are never read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(store): describe the monorepo registry and the store UI as they are - PLUGIN_STORE_GUIDE: the Plugin Store is a section of the Plugin Manager tab; URL installs are "Install from GitHub" -> "Install Single Plugin"; bulk update exists (Check & Update All) plus opt-in weekly auto-update; PluginStoreManager() defaults to plugins/, so the Python examples pass plugin-repos; registry plugins are downloaded (GitHub API, ZIP fallback), not cloned; updates compare version with latest_version. - PLUGIN_REGISTRY_SETUP_GUIDE: replace the per-plugin-repo + tag walkthrough with a short page on the monorepo registry (plugin_path, latest_version, update_registry.py) that points at the monorepo's own SUBMISSION.md. Drops the reference to the deleted PLUGIN_IMPLEMENTATION_SUMMARY.md and setup_plugin_repos.py. - plugin_registry_template.json: use the real entry shape. - PLUGIN_QUICK_REFERENCE: automatic background updates exist (opt-in); registry example and publishing steps use the monorepo, not tags. - PLUGIN_DEVELOPMENT_GUIDE: tags/releases are not read by the store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(readme): fix the Triple Bonnet mapping, install prerequisites and backup names - README: the Adafruit Triple Bonnet uses `regular` (3 outputs), not `regular-pi1` (1 output) -- src/matrix_support.py MAPPING_OUTPUTS, and the README's own hardware_mapping section; the template default mapping is adafruit-hat, the PWM mod switches it to adafruit-hat-pwm; manual install only needs git up front (first_time_install.sh installs python-dev-is-python3, cmake, ninja-build etc.; cython3/scons are not used); the Pi Zero 2 W is a supported low-memory board, consistent with PRODUCT.md, LOW_MEMORY_BOARDS.md and the installer's low-memory build; fix the "First_time_install.sh" spelling, an orphan "2." list item and the hello-world starter link (it lives in the plugins monorepo). - CONFIG_DEBUGGING: automatic backups are config/backups/config.json.backup.<YYYYMMDD_HHMMSS_ffffff> (five kept), not config_YYYYMMDD_HHMMSS.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(dev): correct the test-running and rgbmatrix build instructions - HOW_TO_RUN_TESTS: coverage is not collected by a plain pytest run and pytest.ini has no threshold; the only one is --cov-fail-under=52 in the core unit-test job of .github/workflows/test.yml, which runs the whole test/ tree (not an allowlist). Almost no tests carry markers, so -m integration / -m slow select nothing; drop them and -m unit as the quick check. Replace the hardcoded /home/chuck path. - DEVELOPMENT: the rgbmatrix package is built with pip install . from the submodule root (scikit-build-core + CMake + Ninja), as first_time_install.sh does; there is no make build-python / bindings/python step, and the build deps are python-dev-is-python3, cmake and ninja-build, not cython3/scons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(wifi): the setup AP is open; auto-enable can be turned off without code changes - WIFI_NETWORK_SETUP / SSH_UNAVAILABLE_AFTER_INSTALL: both AP paths in src/wifi_manager.py create an open network and nothing reads ap_password, so drop the "ledmatrix123" password and the ap_password key/advice. - SSH_UNAVAILABLE_AFTER_INSTALL: disabling automatic AP mode does not need code changes -- auto_enable_ap_mode is a WiFi-tab toggle and POST /api/v3/wifi/ap/auto-enable; note the monitor daemon reads wifi_config.json at start, so restart it after changing the setting. Use the ledpi username and a relative install path like the other docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(reference): add auto_update, drop drifted line numbers, fix UI and service details - CONFIG_REFERENCE: document the top-level auto_update.enabled key (read by web_interface/auto_update.py and src/auto_update_setup.py); replace drifted file:line references with function names; the template's dim_schedule mode is "global". - ADVANCED_FEATURES: core does not read a per-plugin background_service block (the sports plugins read their own), and priority is "higher number = higher priority" on FetchRequest but not used for ordering. - WEB_INTERFACE_GUIDE: the General tab toggle is "Web Display Autostart" (web interface service), brightness is 1-100, and config paths are relative to the LEDMatrix folder, not /config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: drop references to code removed in #608 get_installed_plugin_info, WiFiManager's saved_networks and the six always-skipping plugin test files are deleted there. NetworkManager already remembers joined networks; LEDMatrix no longer stores WiFi passwords. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: don't link SKIN_SYSTEM.md from the core-properties page #615 deletes SKIN_SYSTEM.md; with this link, whichever of the two merged second would break test_doc_links. The skin/skin_options entries go when #615 removes the keys. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
351 lines
9.0 KiB
Markdown
351 lines
9.0 KiB
Markdown
# How to Run Tests for LEDMatrix
|
|
|
|
This guide explains how to use the test suite for the LEDMatrix project.
|
|
|
|
## Prerequisites
|
|
|
|
### 1. Install Test Dependencies
|
|
|
|
Make sure you have the testing packages installed:
|
|
|
|
```bash
|
|
# Install all dependencies including test packages
|
|
pip install -r requirements.txt -r requirements-test.txt
|
|
```
|
|
|
|
### 2. Set Environment Variables
|
|
|
|
For tests that don't require hardware, set the emulator mode:
|
|
|
|
```bash
|
|
export EMULATOR=true
|
|
```
|
|
|
|
This ensures tests use the emulator instead of trying to access actual hardware.
|
|
|
|
## Running Tests
|
|
|
|
### Run All Tests
|
|
|
|
```bash
|
|
# From the project root directory
|
|
pytest
|
|
|
|
# Or with more verbose output
|
|
pytest -v
|
|
|
|
# Or with even more detail
|
|
pytest -vv
|
|
```
|
|
|
|
### Run Specific Test Files
|
|
|
|
```bash
|
|
# Run a specific test file
|
|
pytest test/test_display_controller.py
|
|
|
|
# Run multiple specific files
|
|
pytest test/test_display_controller.py test/test_plugin_system.py
|
|
```
|
|
|
|
### Run Specific Test Classes or Functions
|
|
|
|
```bash
|
|
# Run a specific test class
|
|
pytest test/test_display_controller.py::TestDisplayControllerModeRotation
|
|
|
|
# Run a specific test function
|
|
pytest test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
|
|
```
|
|
|
|
### Run Tests by Marker
|
|
|
|
`pytest.ini` declares the markers `unit`, `integration`, `hardware`, `slow`
|
|
and `plugin` (with `--strict-markers`, so a typo in a marker name is an
|
|
error). Few tests are marked: only a handful carry `unit`, and none currently
|
|
carry `integration`, `slow` or `hardware`, so `-m integration` and `-m slow`
|
|
select nothing. Select tests by file, directory or `-k` instead.
|
|
|
|
```bash
|
|
# What CI runs for the core suites (excludes anything marked hardware)
|
|
pytest -m "not hardware" test/ --ignore=test/plugins
|
|
|
|
# Tests whose name matches an expression
|
|
pytest -k "config and not secrets"
|
|
```
|
|
|
|
### Run Tests in a Directory
|
|
|
|
```bash
|
|
# Run all tests in the test directory
|
|
pytest test/
|
|
|
|
# Run plugin tests only
|
|
pytest test/plugins/
|
|
|
|
# Run web interface tests only
|
|
pytest test/web_interface/
|
|
|
|
# Run web interface integration tests
|
|
pytest test/web_interface/integration/
|
|
```
|
|
|
|
## Understanding Test Output
|
|
|
|
### Basic Output
|
|
|
|
When you run `pytest`, you'll see:
|
|
|
|
```
|
|
test/test_display_controller.py::TestDisplayControllerInitialization::test_init_success PASSED
|
|
test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation PASSED
|
|
...
|
|
```
|
|
|
|
- `PASSED` - Test succeeded
|
|
- `FAILED` - Test failed (check the error message)
|
|
- `SKIPPED` - Test was skipped (usually due to missing dependencies or conditions)
|
|
- `ERROR` - Test had an error during setup
|
|
|
|
### Verbose Output
|
|
|
|
Use `-v` or `-vv` for more detail:
|
|
|
|
```bash
|
|
pytest -vv
|
|
```
|
|
|
|
This shows:
|
|
- Full test names
|
|
- Setup/teardown information
|
|
- More detailed failure messages
|
|
|
|
### Show Print Statements
|
|
|
|
To see print statements and logging output:
|
|
|
|
```bash
|
|
pytest -s
|
|
```
|
|
|
|
Or combine with verbose:
|
|
|
|
```bash
|
|
pytest -sv
|
|
```
|
|
|
|
## Coverage Reports
|
|
|
|
Coverage is not collected by a plain `pytest` run: `pytest.ini` deliberately
|
|
has no coverage flags, so local runs stay fast. Ask for it explicitly
|
|
(needs `pytest-cov`, which is in `requirements-test.txt`):
|
|
|
|
```bash
|
|
# Terminal summary
|
|
pytest --cov=src --cov=web_interface --cov-report=term test/ --ignore=test/plugins
|
|
|
|
# HTML report in htmlcov/
|
|
pytest --cov=src --cov=web_interface --cov-report=html test/ --ignore=test/plugins
|
|
```
|
|
|
|
Then open `htmlcov/index.html` in your browser (`xdg-open` on Linux, `open`
|
|
on macOS, `start` on Windows).
|
|
|
|
### Coverage Threshold
|
|
|
|
The only threshold is in CI: the core unit-test job in
|
|
[`.github/workflows/test.yml`](../.github/workflows/test.yml) runs with
|
|
`--cov-fail-under=52`. To check it locally, add that flag to the command
|
|
above.
|
|
|
|
## Common Test Scenarios
|
|
|
|
### Run Tests After Making Changes
|
|
|
|
```bash
|
|
# Quick run: just the tests for the area you changed
|
|
pytest test/test_config_manager.py
|
|
|
|
# Full test suite
|
|
pytest
|
|
```
|
|
|
|
### Debug a Failing Test
|
|
|
|
```bash
|
|
# Run with maximum verbosity and show print statements
|
|
pytest -vv -s test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
|
|
|
|
# Run with Python debugger (pdb)
|
|
pytest --pdb test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
|
|
```
|
|
|
|
### Run Tests in Parallel (Faster)
|
|
|
|
```bash
|
|
# Install pytest-xdist first
|
|
pip install pytest-xdist
|
|
|
|
# Run tests in parallel (4 workers)
|
|
pytest -n 4
|
|
|
|
# Auto-detect number of CPUs
|
|
pytest -n auto
|
|
```
|
|
|
|
### Stop on First Failure
|
|
|
|
```bash
|
|
# Stop immediately when a test fails
|
|
pytest -x
|
|
|
|
# Stop after N failures
|
|
pytest --maxfail=3
|
|
```
|
|
|
|
## Test Organization
|
|
|
|
### Test Files Structure
|
|
|
|
```
|
|
test/
|
|
├── conftest.py # Shared fixtures and configuration
|
|
├── test_display_controller.py # Display controller tests
|
|
├── test_display_manager.py # Display manager tests
|
|
├── test_plugin_system.py # Plugin system tests
|
|
├── test_plugin_loader.py # Plugin discovery/loading tests
|
|
├── test_plugin_loading_failures.py # Plugin failure-mode tests
|
|
├── test_cache_manager.py # Cache manager tests
|
|
├── test_config_manager.py # Config manager tests
|
|
├── test_config_service.py # Config service tests
|
|
├── test_config_validation_edge_cases.py # Config edge cases
|
|
├── test_font_manager.py # Font manager tests
|
|
├── test_text_helper.py # Text helper tests
|
|
├── test_error_handling.py # Error handling tests
|
|
├── test_error_aggregator.py # Error aggregation tests
|
|
├── test_schema_manager.py # Schema manager tests
|
|
├── test_web_api.py # Web API tests
|
|
├── plugins/ # Plugin rendering suites
|
|
│ ├── test_plugin_matrix.py # Every discovered plugin, across panel sizes
|
|
│ ├── test_harness.py
|
|
│ └── test_visual_rendering.py
|
|
└── web_interface/
|
|
├── test_config_manager_atomic.py
|
|
├── test_state_reconciliation.py
|
|
├── test_plugin_operation_queue.py
|
|
├── test_dedup_unique_arrays.py
|
|
└── integration/ # Web interface integration tests
|
|
├── test_config_flows.py
|
|
└── test_plugin_operations.py
|
|
```
|
|
|
|
### Test Categories
|
|
|
|
- **Unit Tests**: Fast, isolated tests for individual components
|
|
- **Integration Tests**: Tests that verify components work together
|
|
- **Error Scenarios**: Tests for error handling and edge cases
|
|
- **Edge Cases**: Boundary conditions and unusual inputs
|
|
|
|
## Troubleshooting
|
|
|
|
### Import Errors
|
|
|
|
If you see import errors:
|
|
|
|
```bash
|
|
# Make sure you're in the project root (wherever you cloned it)
|
|
cd ~/LEDMatrix
|
|
|
|
# Check Python path
|
|
python -c "import sys; print(sys.path)"
|
|
|
|
# Run pytest from project root
|
|
pytest
|
|
```
|
|
|
|
### Missing Dependencies
|
|
|
|
If tests fail due to missing packages:
|
|
|
|
```bash
|
|
# Install all dependencies
|
|
pip install -r requirements.txt -r requirements-test.txt
|
|
|
|
# Or install specific missing package
|
|
pip install <package-name>
|
|
```
|
|
|
|
### Hardware Tests Failing
|
|
|
|
If tests that require hardware are failing:
|
|
|
|
```bash
|
|
# Set emulator mode
|
|
export EMULATOR=true
|
|
|
|
# Or skip hardware tests
|
|
pytest -m "not hardware"
|
|
```
|
|
|
|
### Coverage Not Working
|
|
|
|
If coverage reports aren't generating:
|
|
|
|
```bash
|
|
# Make sure pytest-cov is installed
|
|
pip install pytest-cov
|
|
|
|
# Coverage is opt-in; ask for it explicitly
|
|
pytest --cov=src --cov=web_interface --cov-report=html
|
|
```
|
|
|
|
## Continuous Integration
|
|
|
|
The repo runs the pytest suite via
|
|
[`.github/workflows/test.yml`](../.github/workflows/test.yml) on every
|
|
push and pull request: a plugin-safety job that runs `test/plugins/`, and a
|
|
core unit-test job that runs the whole `test/` tree except `test/plugins/`
|
|
with `-m "not hardware"` and enforces coverage (`--cov-fail-under=52`). New
|
|
test files are picked up automatically. Release version consistency is checked by
|
|
[`.github/workflows/release-version-check.yml`](../.github/workflows/release-version-check.yml).
|
|
Bandit, flake8, mypy and gitleaks run as pre-commit hooks (see
|
|
`.pre-commit-config.yaml`), not in CI.
|
|
|
|
## Best Practices
|
|
|
|
1. **Run tests before committing**:
|
|
```bash
|
|
pytest test/test_<area>.py # Quick check of what you touched
|
|
```
|
|
|
|
2. **Run full suite before pushing**:
|
|
```bash
|
|
pytest # Full test suite (add --cov flags for coverage)
|
|
```
|
|
|
|
3. **Fix failing tests immediately** - Don't let them accumulate
|
|
|
|
4. **Keep coverage above threshold** - CI fails below 52%
|
|
|
|
5. **Write tests for new features** - Add tests when adding new functionality
|
|
|
|
## Quick Reference
|
|
|
|
```bash
|
|
# Most common commands
|
|
pytest # Run all tests (no coverage)
|
|
pytest -v # Verbose output
|
|
pytest test/test_x.py # Run one file
|
|
pytest -k "test_name" # Run tests matching pattern
|
|
pytest --cov=src # Generate coverage report
|
|
pytest -x # Stop on first failure
|
|
pytest --pdb # Drop into debugger on failure
|
|
```
|
|
|
|
## Getting Help
|
|
|
|
- Check test output for error messages
|
|
- Look at the test file to understand what's being tested
|
|
- Check `conftest.py` for available fixtures
|
|
- Review `pytest.ini` for configuration options
|