mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-08-08 12:18:06 +00:00
Claude
41f91a40b9
- config_manager: the "secrets list longer than config list" warning now
interpolates only config-side data (no key name or secrets-derived
values), resolving the CodeQL clear-text-logging alert.
- base_plugin: validate_config rejects bool display_duration, matching
get_display_duration (bool is an int subclass and would otherwise pass
as a positive number).
- config_helper: merge_configs deep-copies override values in the
non-recursive branch so mutating the merged result cannot reach back
into override_config.
- saved_repositories: saves are atomic (temp file + fsync + os.replace),
so a failed write can no longer truncate saved_repositories.json.
- tests: regression cases for each fix, plus a pin that whole-item
array secrets (key[] + key[].field both marked) strip to empty {}
skeletons — no secret values can reach config.json.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NohXi78cwsAKtN1sCfxjUh
147 lines
5.7 KiB
Python
147 lines
5.7 KiB
Python
"""
|
|
Tests for BasePlugin.get_display_duration — ~100 lines of type coercion that
|
|
every plugin's rotation slot depends on, previously untested.
|
|
|
|
The contract: a positive number wins wherever it comes from; everything else
|
|
falls through instance attr → config → the 15.0 default, logging on the way.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from src.plugin_system.base_plugin import BasePlugin
|
|
|
|
|
|
class _MinimalPlugin(BasePlugin):
|
|
def update(self):
|
|
pass
|
|
|
|
def display(self, force_clear=False):
|
|
pass
|
|
|
|
|
|
def make_plugin(config=None, instance_duration="__unset__"):
|
|
plugin = _MinimalPlugin(
|
|
plugin_id="duration-test",
|
|
config=config or {},
|
|
display_manager=MagicMock(),
|
|
cache_manager=MagicMock(),
|
|
plugin_manager=MagicMock(),
|
|
)
|
|
if instance_duration != "__unset__":
|
|
plugin.display_duration = instance_duration
|
|
return plugin
|
|
|
|
|
|
class TestInstanceVariable:
|
|
def test_positive_int_wins(self):
|
|
assert make_plugin(instance_duration=30).get_display_duration() == 30.0
|
|
|
|
def test_positive_float_wins(self):
|
|
assert make_plugin(instance_duration=12.5).get_display_duration() == 12.5
|
|
|
|
def test_returns_float_type(self):
|
|
result = make_plugin(instance_duration=30).get_display_duration()
|
|
assert isinstance(result, float)
|
|
|
|
def test_numeric_string_wins(self):
|
|
assert make_plugin(instance_duration="25").get_display_duration() == 25.0
|
|
|
|
def test_zero_falls_through_to_config(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=0)
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_negative_falls_through_to_config(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=-5)
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_none_falls_through_to_config(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=None)
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_garbage_string_falls_through(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration="abc")
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_non_positive_string_falls_through(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration="0")
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_unexpected_type_falls_through(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=[30])
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_bool_true_falls_through_like_any_non_number(self):
|
|
# bool is an int subclass, but a boolean is not a duration: True
|
|
# must NOT read as 1 second — it falls through to config/default.
|
|
assert make_plugin(instance_duration=True).get_display_duration() == 15.0
|
|
|
|
def test_bool_true_falls_through_to_config(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=True)
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
def test_bool_false_still_falls_through(self):
|
|
plugin = make_plugin(config={"display_duration": 20},
|
|
instance_duration=False)
|
|
assert plugin.get_display_duration() == 20.0
|
|
|
|
|
|
class TestConfigFallback:
|
|
def test_config_number(self):
|
|
assert make_plugin({"display_duration": 20}).get_display_duration() == 20.0
|
|
|
|
def test_config_numeric_string(self):
|
|
assert make_plugin({"display_duration": "12.5"}).get_display_duration() == 12.5
|
|
|
|
def test_missing_config_uses_default(self):
|
|
assert make_plugin({}).get_display_duration() == 15.0
|
|
|
|
def test_config_zero_uses_default(self):
|
|
assert make_plugin({"display_duration": 0}).get_display_duration() == 15.0
|
|
|
|
def test_config_negative_uses_default(self):
|
|
assert make_plugin({"display_duration": -10}).get_display_duration() == 15.0
|
|
|
|
def test_config_garbage_string_uses_default(self):
|
|
assert make_plugin({"display_duration": "soon"}).get_display_duration() == 15.0
|
|
|
|
def test_config_unexpected_type_uses_default(self):
|
|
assert make_plugin({"display_duration": {"s": 5}}).get_display_duration() == 15.0
|
|
|
|
def test_config_none_uses_default(self):
|
|
assert make_plugin({"display_duration": None}).get_display_duration() == 15.0
|
|
|
|
def test_config_bool_uses_default(self):
|
|
assert make_plugin({"display_duration": True}).get_display_duration() == 15.0
|
|
assert make_plugin({"display_duration": False}).get_display_duration() == 15.0
|
|
|
|
|
|
class TestValidateConfigDuration:
|
|
# validate_config must agree with get_display_duration about what a
|
|
# valid duration is — a config it accepts must not then be rejected
|
|
# (or silently defaulted) when the duration is actually read.
|
|
|
|
def test_positive_number_valid(self):
|
|
assert make_plugin({"display_duration": 20}).validate_config() is True
|
|
|
|
def test_zero_and_negative_invalid(self):
|
|
assert make_plugin({"display_duration": 0}).validate_config() is False
|
|
assert make_plugin({"display_duration": -5}).validate_config() is False
|
|
|
|
def test_bool_invalid(self):
|
|
# bool is an int subclass; True would otherwise pass as "positive
|
|
# number" here while get_display_duration rejects it.
|
|
assert make_plugin({"display_duration": True}).validate_config() is False
|
|
assert make_plugin({"display_duration": False}).validate_config() is False
|
|
|
|
def test_missing_duration_valid(self):
|
|
assert make_plugin({}).validate_config() is True
|