mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 06:15:09 +00:00
* docs: add ARCHITECTURE and PERMISSIONS guides ARCHITECTURE.md maps the processes, the state the display and web services share through the cache, the display loop, the plugin system, the web UI and the update path, with links into the code and a where-to-start table. PERMISSIONS.md lists who owns what after install, both sudoers files (and why iptables is not granted), the polkit rule, and which scripts/fix_perms script to run as which user. Both are linked from the docs index, along with the MQTT bridge README and src/common/README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct stale setup, service and troubleshooting claims - README: quick actions run systemctl on ledmatrix.service (run.py), not display_controller.py; use_short_date_format has no effect; the installer uses system pip with --break-system-packages, not a venv. - CONFIG_DEBUGGING: LEDMATRIX_DEBUG must be "true"; logs are in journald. - GETTING_STARTED, WEB_INTERFACE_GUIDE, TROUBLESHOOTING: enabling a plugin, plugin settings, brightness and Vegas settings apply without a restart; matrix hardware settings still need one. - TROUBLESHOOTING: install dependencies with sudo so the root service sees them; point permission problems at PERMISSIONS.md instead of a project-wide chown. - ADVANCED_FEATURES: real BackgroundDataService stats keys; Vegas hooks return VegasDisplayMode and None falls back to capture; cache files are 0660; fix_web_permissions.sh runs as the web user and does not touch sudoers. - STARLARK_APPS_GUIDE: only the linux-arm64 pixlet binary is downloaded. - HOW_TO_RUN_TESTS: test class examples that exist. - CLAUDE.md: PluginStoreManager, plugin_dirs.py, monorepo installs via the Trees API with ZIP fallback, requirements.txt is optional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: mark deprecated plugin APIs and state manifest fields once Methods @deprecated("3.7.0") (the set pinned in test_deprecation.py) were shown as current API in the quick reference, API reference, advanced guide, development guide and FONT_MANAGER. Each is now marked deprecated with its replacement. FONT_MANAGER is rewritten around the current API; the override editor is gone and override methods are deprecated. Required manifest fields were stated three different ways. The API reference now has one section: the 7 schema-required fields, the 4 the store refuses without, class_name for the loader, and the 8 to set. The other guides link to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: document every src/common module and every widget - src/common/README.md covered 7 of 17 modules. It now has a table of all of them (purpose, whether plugins import it, release to floor on), a short entry each, and logging advice that matches the code. - SPORTS_UNIFICATION listed two shared modules and called sports_helpers the first; it now lists all six. - The widgets README lists all 28 registered widgets plus the support files, and absorbs the parts that only docs/widget-guide.md had (x-options.labels, x-advanced, x-display hidden, plugin-file-manager). docs/widget-guide.md is now a pointer to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): fix_web_permissions.sh re-hardens the root sudo helpers The script chowns the whole project to the web user. That included scripts/fix_perms/safe_plugin_rm.sh and safe_pip_install.sh -- the two helpers /etc/sudoers.d/ledmatrix_web lets the web user run as root -- so running it turned both into a root shell for whoever can edit them. It also re-grouped config_secrets.json away from ledmatrix. After the chown it now does what first_time_install.sh's Steps 11 and 11.1 do: helpers back to root:root 755, and config_secrets.json back to the web unit's User=:ledmatrix 640. Each step is non-fatal and prints the manual command if it fails. Also fixes what the script and its docs claimed: it never configured sudoers, its closing hint pointed at ./configure_web_sudo.sh (wrong path), and the README and ADVANCED_FEATURES.md said to run it with sudo, which it refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): validate and harden every sudoers drop-in the scripts write configure_wifi_permissions.sh copied its rules into /etc/sudoers.d/ledmatrix_wifi without `visudo -c`. A malformed drop-in makes sudo refuse every command for every user, which on a headless Pi leaves no way back in. It now checks first and leaves the installed file alone when the rules do not parse, as the other two writers do. (It already used mktemp, so that part of the review did not apply.) It also grants the two literal commands wifi_manager.py runs for NetworkManager's shared-mode dnsmasq drop-in -- `cp /tmp/ledmatrix-nm-dnsmasq.conf .../dnsmasq-shared.d/ledmatrix-captive.conf` and `rm -f` of that file. The directory's mkdir was granted, the file was not. Both are pinned in test_sudo_allowlist_covers_calls.py. configure_web_sudo.sh wrote its rules to /tmp/ledmatrix_web_sudoers_$$, a predictable name in a world-writable directory; it now uses mktemp with an EXIT trap, as first_time_install.sh does. It sets mode 440 on the installed file instead of leaving the temp file's mode, and finds visudo in /usr/sbin when that is not on the user's PATH, which skipped the check silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): escape the project path in the DNS-fix and MQTT unit renderers install_dns_fix.sh and install_mqtt_bridge.sh substituted __PROJECT_ROOT_DIR__ with the raw path, while the other three renderers go through sed_escape_replacement from lib_systemd_render.sh. A checkout under a path containing `&`, `\` or `|` rendered a corrupted unit from these two only. Both now source the helper and use it, and a test checks that every placeholder substitution in scripts/install uses an escaped value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): stop the installer scripts reporting things that are not true - first_time_install.sh printed "Password: ledmatrix123" for the setup access point. wifi_manager creates it as an open network ("No password" on the panel), so it now says so. - Step 10.1 printed "✓ WiFi management permissions configured" straight after its own failure message; install_wifi_monitor.sh printed "✓ Package installation completed" after a failed apt install. The tick now only follows success. - Step 7 printed "Web dependencies already installed ... in Step 5" in the one branch that runs because Step 5 did not install them, then created .web_deps_installed on that basis. It now warns and leaves the marker off so the next run retries, as the comment below it intends. - check_system_compatibility.sh called Debian 12 Bookworm "full compatibility confirmed" while first_time_install.sh refuses anything but Debian 13. Bookworm, older Debian and non-Debian systems are now errors. Its counters used ((X++)), which under `set -e` exits the script at the first warning or error (the expression is 0), so the check never reached its summary on any system with one. - configure_web_sudo.sh and configure_wifi_permissions.sh finished by testing `sudo -n test -f ...` and `sudo -n nmcli device status`, neither of which is granted, so they always reported a failure. They now ask `sudo -n -l` about commands the new rules do grant, which checks the rule without running anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): print the completion summary before rebooting With -y -- and so for every one-shot `curl | bash` install, which always passes -y -- first_time_install.sh ran `reboot` about 180 lines before its "Installation Complete / Web UI Access" summary. reboot returns at once, so the summary printed while the Pi was going down and the SSH session usually dropped before the web UI address could be read. The reboot block moves, unchanged, to the very end of the script. The interactive prompt now also follows the summary. Because the summary now runs before the -y reboot, its one command that could fail under `set -Eeuo pipefail` (the SSID lookup, when nmcli reports a connected device but no active network line) gets `|| true`; a missing SSID was already handled as "SSID unknown". one-shot-install.sh prints its "Next steps" after the installer returns, by which time the reboot is under way, so it now says so, and README's Quick Install mentions the automatic reboot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(scripts): correct wrong comments and messages, drop dead code No behaviour change except the output text noted below. - 2775 is setgid, not the sticky bit (first_time_install.sh Step 3.1, fix_plugin_permissions.sh), and root needs no "PWM hardware access" to plugin files. - The 777 comments in first_time_install.sh Step 3's fallback and fix_assets_permissions.sh said root needs it to write. Root ignores mode bits; the comments now say what 777 actually opens. The 777 itself is unchanged. - apt_remove ends in `|| true`, so Step 12's "Some packages could not be removed" branch could never run; it is gone and the helper stays non-fatal. - detect_web_service_user's comment named Step 8 for the web unit (install_service.sh installs it in Step 7.5) and now says which branch actually runs. - Step 5 described an "already installed" check that does not exist; the ACTUAL_USER comment described the re-exec backwards. - on_error printed a literal "\n" before "Common fixes:". - Dead code: one-shot-install.sh's uncalled fix_tmp_permissions, LEDMATRIX_ELEVATED=1 (never read) on the sudo re-exec, and configure_web_sudo.sh's unused PYTHON_PATH, which also made a missing python3 fatal for rules that never mention it. - start_display.sh / stop_display.sh said "for user: <you>"; the service runs as root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(fix_perms): fix_cache_permissions.sh uses setup_cache.sh's model There were two models for /var/cache/ledmatrix. setup_cache.sh (the installer's Step 2) and install_web_service.sh share it through the ledmatrix group: root:ledmatrix, 2775, files 660, which is also what DiskCache relies on to give files the directory's group. fix_cache_permissions.sh instead made it 777 and re-grouped it to the invoking user's group, undoing that. It now runs setup_cache.sh for /var/cache/ledmatrix and keeps its own handling of ~/.ledmatrix_cache. Dropped: /var/cache/ledmatrix/ placeholder_logos (nothing reads it) and the checks against the `daemon` user (no service runs as daemon). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: pin actions/checkout in the Claude workflows, drop template comments claude.yml and claude-code-review.yml used actions/checkout@v4 while test.yml and release-version-check.yml pin the v4.2.2 commit SHA; they now pin the same SHA. The commented-out starter-template settings (prompt, claude_args, paths, author filter) are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(scripts): index every script and list removal candidates New scripts/README.md gives one line per top-level script and scripts directory, marked keep, dev-only or diagnostic, and lists the eight scripts nothing in the repo refers to as candidates for removal (kept for now). The install, utils and dev READMEs now list the files they were missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: tighten two checks that mutation testing showed were too loose - The wifi sudoers check matched `visudo -c -f "$TEMP_SUDOERS"` in the error report too, so replacing the check with `if false` still passed. It now requires the command as the condition. - The summary test never had the setup access point up, so reinstating the bogus "Password: ledmatrix123" line went unnoticed. A case with hostapd active now checks the AP is described as open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(permissions): describe the repaired fix_perms scripts and new WiFi grants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): docs-scripts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
351 lines
9.0 KiB
Markdown
351 lines
9.0 KiB
Markdown
# How to Run Tests for LEDMatrix
|
|
|
|
This guide explains how to use the test suite for the LEDMatrix project.
|
|
|
|
## Prerequisites
|
|
|
|
### 1. Install Test Dependencies
|
|
|
|
Make sure you have the testing packages installed:
|
|
|
|
```bash
|
|
# Install all dependencies including test packages
|
|
pip install -r requirements.txt -r requirements-test.txt
|
|
```
|
|
|
|
### 2. Set Environment Variables
|
|
|
|
For tests that don't require hardware, set the emulator mode:
|
|
|
|
```bash
|
|
export EMULATOR=true
|
|
```
|
|
|
|
This ensures tests use the emulator instead of trying to access actual hardware.
|
|
|
|
## Running Tests
|
|
|
|
### Run All Tests
|
|
|
|
```bash
|
|
# From the project root directory
|
|
pytest
|
|
|
|
# Or with more verbose output
|
|
pytest -v
|
|
|
|
# Or with even more detail
|
|
pytest -vv
|
|
```
|
|
|
|
### Run Specific Test Files
|
|
|
|
```bash
|
|
# Run a specific test file
|
|
pytest test/test_display_controller.py
|
|
|
|
# Run multiple specific files
|
|
pytest test/test_display_controller.py test/test_plugin_system.py
|
|
```
|
|
|
|
### Run Specific Test Classes or Functions
|
|
|
|
```bash
|
|
# Run a specific test class
|
|
pytest test/test_display_controller.py::TestDisplayControllerLivePriority
|
|
|
|
# Run a specific test function
|
|
pytest test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
|
|
```
|
|
|
|
### Run Tests by Marker
|
|
|
|
`pytest.ini` declares the markers `unit`, `integration`, `hardware`, `slow`
|
|
and `plugin` (with `--strict-markers`, so a typo in a marker name is an
|
|
error). Few tests are marked: only a handful carry `unit`, and none currently
|
|
carry `integration`, `slow` or `hardware`, so `-m integration` and `-m slow`
|
|
select nothing. Select tests by file, directory or `-k` instead.
|
|
|
|
```bash
|
|
# What CI runs for the core suites (excludes anything marked hardware)
|
|
pytest -m "not hardware" test/ --ignore=test/plugins
|
|
|
|
# Tests whose name matches an expression
|
|
pytest -k "config and not secrets"
|
|
```
|
|
|
|
### Run Tests in a Directory
|
|
|
|
```bash
|
|
# Run all tests in the test directory
|
|
pytest test/
|
|
|
|
# Run plugin tests only
|
|
pytest test/plugins/
|
|
|
|
# Run web interface tests only
|
|
pytest test/web_interface/
|
|
|
|
# Run web interface integration tests
|
|
pytest test/web_interface/integration/
|
|
```
|
|
|
|
## Understanding Test Output
|
|
|
|
### Basic Output
|
|
|
|
When you run `pytest`, you'll see:
|
|
|
|
```
|
|
test/test_display_controller.py::TestDisplayControllerInitialization::test_init_success PASSED
|
|
test/test_display_controller.py::TestDisplayControllerOnDemand::test_activate_on_demand PASSED
|
|
...
|
|
```
|
|
|
|
- `PASSED` - Test succeeded
|
|
- `FAILED` - Test failed (check the error message)
|
|
- `SKIPPED` - Test was skipped (usually due to missing dependencies or conditions)
|
|
- `ERROR` - Test had an error during setup
|
|
|
|
### Verbose Output
|
|
|
|
Use `-v` or `-vv` for more detail:
|
|
|
|
```bash
|
|
pytest -vv
|
|
```
|
|
|
|
This shows:
|
|
- Full test names
|
|
- Setup/teardown information
|
|
- More detailed failure messages
|
|
|
|
### Show Print Statements
|
|
|
|
To see print statements and logging output:
|
|
|
|
```bash
|
|
pytest -s
|
|
```
|
|
|
|
Or combine with verbose:
|
|
|
|
```bash
|
|
pytest -sv
|
|
```
|
|
|
|
## Coverage Reports
|
|
|
|
Coverage is not collected by a plain `pytest` run: `pytest.ini` deliberately
|
|
has no coverage flags, so local runs stay fast. Ask for it explicitly
|
|
(needs `pytest-cov`, which is in `requirements-test.txt`):
|
|
|
|
```bash
|
|
# Terminal summary
|
|
pytest --cov=src --cov=web_interface --cov-report=term test/ --ignore=test/plugins
|
|
|
|
# HTML report in htmlcov/
|
|
pytest --cov=src --cov=web_interface --cov-report=html test/ --ignore=test/plugins
|
|
```
|
|
|
|
Then open `htmlcov/index.html` in your browser (`xdg-open` on Linux, `open`
|
|
on macOS, `start` on Windows).
|
|
|
|
### Coverage Threshold
|
|
|
|
The only threshold is in CI: the core unit-test job in
|
|
[`.github/workflows/test.yml`](../.github/workflows/test.yml) runs with
|
|
`--cov-fail-under=52`. To check it locally, add that flag to the command
|
|
above.
|
|
|
|
## Common Test Scenarios
|
|
|
|
### Run Tests After Making Changes
|
|
|
|
```bash
|
|
# Quick run: just the tests for the area you changed
|
|
pytest test/test_config_manager.py
|
|
|
|
# Full test suite
|
|
pytest
|
|
```
|
|
|
|
### Debug a Failing Test
|
|
|
|
```bash
|
|
# Run with maximum verbosity and show print statements
|
|
pytest -vv -s test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
|
|
|
|
# Run with Python debugger (pdb)
|
|
pytest --pdb test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
|
|
```
|
|
|
|
### Run Tests in Parallel (Faster)
|
|
|
|
```bash
|
|
# Install pytest-xdist first
|
|
pip install pytest-xdist
|
|
|
|
# Run tests in parallel (4 workers)
|
|
pytest -n 4
|
|
|
|
# Auto-detect number of CPUs
|
|
pytest -n auto
|
|
```
|
|
|
|
### Stop on First Failure
|
|
|
|
```bash
|
|
# Stop immediately when a test fails
|
|
pytest -x
|
|
|
|
# Stop after N failures
|
|
pytest --maxfail=3
|
|
```
|
|
|
|
## Test Organization
|
|
|
|
### Test Files Structure
|
|
|
|
```
|
|
test/
|
|
├── conftest.py # Shared fixtures and configuration
|
|
├── test_display_controller.py # Display controller tests
|
|
├── test_display_manager.py # Display manager tests
|
|
├── test_plugin_system.py # Plugin system tests
|
|
├── test_plugin_loader.py # Plugin discovery/loading tests
|
|
├── test_plugin_loading_failures.py # Plugin failure-mode tests
|
|
├── test_cache_manager.py # Cache manager tests
|
|
├── test_config_manager.py # Config manager tests
|
|
├── test_config_service.py # Config service tests
|
|
├── test_config_validation_edge_cases.py # Config edge cases
|
|
├── test_font_manager.py # Font manager tests
|
|
├── test_text_helper.py # Text helper tests
|
|
├── test_error_handling.py # Error handling tests
|
|
├── test_error_aggregator.py # Error aggregation tests
|
|
├── test_schema_manager.py # Schema manager tests
|
|
├── test_web_api.py # Web API tests
|
|
├── plugins/ # Plugin rendering suites
|
|
│ ├── test_plugin_matrix.py # Every discovered plugin, across panel sizes
|
|
│ ├── test_harness.py
|
|
│ └── test_visual_rendering.py
|
|
└── web_interface/
|
|
├── test_config_manager_atomic.py
|
|
├── test_state_reconciliation.py
|
|
├── test_plugin_operation_queue.py
|
|
├── test_dedup_unique_arrays.py
|
|
└── integration/ # Web interface integration tests
|
|
├── test_config_flows.py
|
|
└── test_plugin_operations.py
|
|
```
|
|
|
|
### Test Categories
|
|
|
|
- **Unit Tests**: Fast, isolated tests for individual components
|
|
- **Integration Tests**: Tests that verify components work together
|
|
- **Error Scenarios**: Tests for error handling and edge cases
|
|
- **Edge Cases**: Boundary conditions and unusual inputs
|
|
|
|
## Troubleshooting
|
|
|
|
### Import Errors
|
|
|
|
If you see import errors:
|
|
|
|
```bash
|
|
# Make sure you're in the project root (wherever you cloned it)
|
|
cd ~/LEDMatrix
|
|
|
|
# Check Python path
|
|
python -c "import sys; print(sys.path)"
|
|
|
|
# Run pytest from project root
|
|
pytest
|
|
```
|
|
|
|
### Missing Dependencies
|
|
|
|
If tests fail due to missing packages:
|
|
|
|
```bash
|
|
# Install all dependencies
|
|
pip install -r requirements.txt -r requirements-test.txt
|
|
|
|
# Or install specific missing package
|
|
pip install <package-name>
|
|
```
|
|
|
|
### Hardware Tests Failing
|
|
|
|
If tests that require hardware are failing:
|
|
|
|
```bash
|
|
# Set emulator mode
|
|
export EMULATOR=true
|
|
|
|
# Or skip hardware tests
|
|
pytest -m "not hardware"
|
|
```
|
|
|
|
### Coverage Not Working
|
|
|
|
If coverage reports aren't generating:
|
|
|
|
```bash
|
|
# Make sure pytest-cov is installed
|
|
pip install pytest-cov
|
|
|
|
# Coverage is opt-in; ask for it explicitly
|
|
pytest --cov=src --cov=web_interface --cov-report=html
|
|
```
|
|
|
|
## Continuous Integration
|
|
|
|
The repo runs the pytest suite via
|
|
[`.github/workflows/test.yml`](../.github/workflows/test.yml) on every
|
|
push and pull request: a plugin-safety job that runs `test/plugins/`, and a
|
|
core unit-test job that runs the whole `test/` tree except `test/plugins/`
|
|
with `-m "not hardware"` and enforces coverage (`--cov-fail-under=52`). New
|
|
test files are picked up automatically. Release version consistency is checked by
|
|
[`.github/workflows/release-version-check.yml`](../.github/workflows/release-version-check.yml).
|
|
Bandit, flake8, mypy and gitleaks run as pre-commit hooks (see
|
|
`.pre-commit-config.yaml`), not in CI.
|
|
|
|
## Best Practices
|
|
|
|
1. **Run tests before committing**:
|
|
```bash
|
|
pytest test/test_<area>.py # Quick check of what you touched
|
|
```
|
|
|
|
2. **Run full suite before pushing**:
|
|
```bash
|
|
pytest # Full test suite (add --cov flags for coverage)
|
|
```
|
|
|
|
3. **Fix failing tests immediately** - Don't let them accumulate
|
|
|
|
4. **Keep coverage above threshold** - CI fails below 52%
|
|
|
|
5. **Write tests for new features** - Add tests when adding new functionality
|
|
|
|
## Quick Reference
|
|
|
|
```bash
|
|
# Most common commands
|
|
pytest # Run all tests (no coverage)
|
|
pytest -v # Verbose output
|
|
pytest test/test_x.py # Run one file
|
|
pytest -k "test_name" # Run tests matching pattern
|
|
pytest --cov=src # Generate coverage report
|
|
pytest -x # Stop on first failure
|
|
pytest --pdb # Drop into debugger on failure
|
|
```
|
|
|
|
## Getting Help
|
|
|
|
- Check test output for error messages
|
|
- Look at the test file to understand what's being tested
|
|
- Check `conftest.py` for available fixtures
|
|
- Review `pytest.ini` for configuration options
|