mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 14:25:08 +00:00
ChuckandClaude Opus 5.5
7ab6fb1aff
The web process built its own PluginManager and loaded plugins into itself: store installs and updates loaded or reloaded a web-side copy, and config saves and enable/disable called on_config_change, on_enable and on_disable on it. None of that reached the panel, and /plugins/installed reported runtime state from those copies. - Add PluginCatalog (src/plugin_system/plugin_catalog.py): manifests, directories, display modes, installed version, schema and config reads, with no way to run a plugin. app.py and both blueprints use it; the plugin_manager blueprint attribute is gone. - Remove every lifecycle call from the web routes. Config changes already reach the display through ConfigService (on_config_change) and the enabled-set reconcile. - Health and metrics readers move to api_v3.health_tracker / resource_monitor. /plugins/installed reports loaded/state/error_info as null (the display does not publish them) and enabled by the display's rule. - Store install, update and uninstall answer restart_required when the running display will not pick the change up by itself (display_restart_required). The restart banner follows the flag via window.noteRestartRequired instead of the /config/main URL heuristic; /config/main now sends restart_required: true. - The one remaining in-process import of plugin code (Starlark helper modules, oauth_flow action scripts) goes through _import_plugin_code_in_web_process() until a web-entry contract. - /plugins/installed reports vegas_participation (from #682) from the user's setting or the manifest, with vegas_participation_source; when only the plugin's code decides it, null with source 'runtime', since the web process no longer has plugin instances to ask. - Check & Update All keeps its restart flags when the final list refresh fails, and asks for a restart when an enabled plugin's first request got no answer and the re-sent one found it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
80 lines
2.9 KiB
Python
80 lines
2.9 KiB
Python
"""/partials/<name> dispatch and the plugin web_ui page's directory lookup."""
|
|
|
|
import logging
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
from flask import Flask
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent.parent))
|
|
|
|
from web_interface.blueprints import pages_v3 as module # noqa: E402
|
|
|
|
|
|
@pytest.fixture
|
|
def client(tmp_path, monkeypatch):
|
|
plugin_manager = MagicMock()
|
|
plugin_manager.plugins_dir = tmp_path
|
|
monkeypatch.setattr(module.pages_v3, "plugin_catalog", plugin_manager, raising=False)
|
|
monkeypatch.setattr(module.pages_v3, "config_manager",
|
|
MagicMock(load_config=lambda: {}), raising=False)
|
|
app = Flask(__name__, template_folder=str(
|
|
Path(module.__file__).resolve().parents[1] / "templates"))
|
|
app.register_blueprint(module.pages_v3)
|
|
return app.test_client()
|
|
|
|
|
|
def test_every_tab_the_old_if_chain_served_is_still_served():
|
|
assert set(module._PARTIAL_LOADERS) == {
|
|
"overview", "general", "display", "durations", "schedule", "plugins",
|
|
"fonts", "logs", "raw-json", "backup-restore", "wifi", "cache",
|
|
"operation-history", "tools",
|
|
}
|
|
|
|
|
|
def test_an_unknown_partial_is_a_404(client):
|
|
response = client.get("/partials/nope")
|
|
assert response.status_code == 404
|
|
|
|
|
|
def test_a_failing_loader_is_one_500_that_names_the_partial(client, monkeypatch, caplog):
|
|
def boom():
|
|
raise RuntimeError("template exploded")
|
|
monkeypatch.setitem(module._PARTIAL_LOADERS, "logs", boom)
|
|
|
|
with caplog.at_level(logging.ERROR):
|
|
response = client.get("/partials/logs")
|
|
|
|
assert response.status_code == 500
|
|
assert response.get_data(as_text=True) == "Error loading partial"
|
|
errors = [r for r in caplog.records if r.levelno >= logging.ERROR]
|
|
assert len(errors) == 1
|
|
assert errors[0].getMessage() == "Error loading partial logs"
|
|
|
|
|
|
def test_web_ui_page_uses_the_ledmatrix_prefix_fallback(client, tmp_path):
|
|
web_ui = tmp_path / "ledmatrix-radar" / "web_ui"
|
|
web_ui.mkdir(parents=True)
|
|
(web_ui / "panel.html").write_text("<p>radar panel</p>", encoding="utf-8")
|
|
|
|
response = client.get("/plugin-ui/radar/web-ui/panel.html")
|
|
|
|
assert response.status_code == 200
|
|
assert "radar panel" in response.get_data(as_text=True)
|
|
|
|
|
|
def test_web_ui_page_styles_come_from_the_pi_not_a_cdn(client, tmp_path):
|
|
"""In AP mode there is no internet; a CDN stylesheet left fragments unstyled."""
|
|
web_ui = tmp_path / "radar" / "web_ui"
|
|
web_ui.mkdir(parents=True)
|
|
(web_ui / "panel.html").write_text("<p>radar panel</p>", encoding="utf-8")
|
|
|
|
body = client.get("/plugin-ui/radar/web-ui/panel.html").get_data(as_text=True)
|
|
|
|
assert '<link rel="stylesheet" href="/static/v3/plugin-frame.css' in body
|
|
assert "cdnjs" not in body and "https://" not in body
|
|
assert (Path(module.__file__).resolve().parents[1]
|
|
/ "static" / "v3" / "plugin-frame.css").is_file()
|