docs(changelog): one plugin-directory resolver

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

.codacy.yml

@@ -4,3 +4,4 @@ exclude_paths:
   - "plugins/**"
   - "assets/**"
   - "test/**"
+  - "scripts/debug/**"

.gitattributes

@@ -1,8 +1,2 @@
 # Auto detect text files and perform LF normalization
 * text=auto
-
-# Files the Pi executes must stay LF even in a Windows checkout with
-# core.autocrlf=true: a CRLF shebang line fails with "bad interpreter",
-# and systemd rejects CRLF unit files.
-*.sh text eol=lf
-*.service text eol=lf

.github/workflows/claude-code-review.yml

@@ -3,13 +3,21 @@ name: Claude Code Review
 on:
   pull_request:
     types: [opened, synchronize, ready_for_review, reopened]
+    # Optional: Only run on specific file changes
+    # paths:
+    #   - "src/**/*.ts"
+    #   - "src/**/*.tsx"
+    #   - "src/**/*.js"
+    #   - "src/**/*.jsx"
 
 jobs:
   claude-review:
-    # Pull requests from forks get no repository secrets, so without this
-    # guard every outside contributor's PR showed this check red for a reason
-    # they can't fix. Skipped checks don't block merging.
-    if: github.event.pull_request.head.repo.full_name == github.repository
+    # Optional: Filter by PR author
+    # if: |
+    #   github.event.pull_request.user.login == 'external-contributor' ||
+    #   github.event.pull_request.user.login == 'new-developer' ||
+    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
+
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -19,13 +27,13 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
       - name: Run Claude Code Review
         id: claude-review
-        uses: anthropics/claude-code-action@756cc22e19660d20e8cc9496b4f242475a7f7790 # v1
+        uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
           # Review PRs opened by the Claude GitHub App. Without this the action
@@ -37,4 +45,6 @@ jobs:
           plugin_marketplaces: 'https://github.com/anthropics/claude-code.git'
           plugins: 'code-review@claude-code-plugins'
           prompt: '/code-review:code-review ${{ github.repository }}/pull/${{ github.event.pull_request.number }}'
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://code.claude.com/docs/en/cli-reference for available options
 

.github/workflows/claude.yml

@@ -26,13 +26,13 @@ jobs:
       actions: read # Required for Claude to read CI results on PRs
     steps:
       - name: Checkout repository
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        uses: actions/checkout@v4
         with:
           fetch-depth: 1
 
       - name: Run Claude Code
         id: claude
-        uses: anthropics/claude-code-action@756cc22e19660d20e8cc9496b4f242475a7f7790 # v1
+        uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
@@ -40,3 +40,11 @@ jobs:
           additional_permissions: |
             actions: read
 
+          # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
+          # prompt: 'Update the pull request description to include a summary of changes.'
+
+          # Optional: Add claude_args to customize behavior and configuration
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://code.claude.com/docs/en/cli-reference for available options
+          # claude_args: '--allowed-tools Bash(gh pr *)'
+

.github/workflows/test.yml

@@ -8,7 +8,7 @@ on:
   # needs a re-run or didn't get created.
   workflow_dispatch:
 
-# The jobs only check out the repo and run the tests.
+# Both jobs only check out the repo and run pytest.
 permissions:
   contents: read
 
@@ -35,7 +35,7 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install -r requirements.txt -r web_interface/requirements.txt -r requirements-test.txt
+          pip install -r requirements.txt -r requirements-test.txt
           pip install RGBMatrixEmulator
 
       - name: Run plugin safety harness
@@ -58,7 +58,7 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install -r requirements.txt -r web_interface/requirements.txt -r requirements-test.txt
+          pip install -r requirements.txt -r requirements-test.txt
           pip install RGBMatrixEmulator
 
       # Run the ENTIRE test tree (except test/plugins, which the
@@ -73,70 +73,3 @@ jobs:
             --cov=src --cov=web_interface \
             --cov-report=term \
             --cov-fail-under=52
-
-  js-tests:
-    name: Web UI JS tests
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-        with:
-          persist-credentials: false
-
-      - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
-        with:
-          python-version: "3.12"
-          cache: pip
-
-      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
-        with:
-          node-version: "22"
-
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt -r web_interface/requirements.txt
-          npm install --no-audit --no-fund --prefix test/js
-
-      # The DOM suites test the real server-rendered pages and API, so they
-      # need the web interface running. REQUIRE_DOM turns "couldn't reach it"
-      # into a failure instead of a silent skip.
-      - name: Start the web interface
-        run: |
-          EMULATOR=true python -c "from web_interface.app import app; app.run(host='127.0.0.1', port=5000, threaded=True)" > web.log 2>&1 &
-          for i in $(seq 60); do curl -sf -o /dev/null http://127.0.0.1:5000/ && exit 0; sleep 1; done
-          cat web.log
-          exit 1
-
-      - name: Run JS suites
-        env:
-          BASE: http://127.0.0.1:5000
-          REQUIRE_DOM: "1"
-        run: node test/js/run_all.js
-
-  type-check:
-    name: Type check (mypy ratchet)
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-        with:
-          persist-credentials: false
-
-      - uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
-        with:
-          python-version: "3.12"
-          cache: pip
-
-      # The runtime requirements are installed so mypy sees the real types of
-      # PIL, requests, psutil and friends -- missing, they'd be Any and the
-      # result would differ from a developer's machine. mypy and the stubs are
-      # pinned so a new release can't turn this red without a code change.
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install -r requirements.txt -r web_interface/requirements.txt
-          pip install mypy==1.20.2 types-requests==2.33.0.20260906 types-pytz==2026.4.0.20260926
-
-      # mypy on exactly the modules in mypy-clean.txt; fails on any error in
-      # them, or if a listed file is missing. See CONTRIBUTING.md.
-      - name: Run mypy on the ratchet list
-        run: python scripts/check_types.py

.gitignore

@@ -3,13 +3,15 @@ __pycache__/
 *.py[cod]
 *$py.class
 
-# Secrets and per-device state. Everything the software writes into config/
-# is local to one device -- config.json, config_secrets.json, wifi_config.json,
-# ytm_auth.json (a login session), saved_repositories.json, font_overrides.json,
-# and the temp files atomic writes leave behind when interrupted -- so only
-# the templates are tracked. Listing files one by one missed several.
-config/*
-!config/*.template.json
+# Secrets
+config/config_secrets.json
+# Atomic writes leave these behind when a save or a test is interrupted;
+# the suite drops several per run.
+config/.config_secrets.json.tmp.*
+config/config.json
+config/config.json.backup
+config/wifi_config.json
+config/uninstalled_plugins.json
 credentials.json
 token.pickle
 
@@ -79,10 +81,10 @@ assets/stocks/crypto_icons/
 
 # Plugin operation state written at runtime.
 #
-# web_interface/app.py writes data/plugin_state.json and data/operation_history.json
-# (older releases also data/plugin_operations.json) as the web interface runs, into
-# a directory that ships tracked (data/.gitkeep). Unignored, every rig that ever
-# opened the web UI -- and every test run that constructs the app -- would leave
+# web_interface/app.py writes data/plugin_operations.json, data/plugin_state.json
+# and data/operation_history.json as the web interface runs, into a directory that
+# ships tracked (data/.gitkeep) and was otherwise unignored. So every rig that ever
+# opened the web UI -- and every test run that constructs the app -- left three
 # untracked files behind and a permanently dirty `git status`. Same reasoning as
 # the logo rule above: a checkout that is always dirty is a checkout nobody reads.
 data/*

.pre-commit-config.yaml

@@ -37,22 +37,14 @@ repos:
         types: [python]
         pass_filenames: false
 
-  # The mypy ratchet -- the same check as CI's "Type check (mypy ratchet)"
-  # job: mypy on exactly the modules listed in mypy-clean.txt. Run it with
-  #   pre-commit run mypy --hook-stage manual
-  # A local hook rather than mirrors-mypy so mypy sees the packages installed
-  # from requirements.txt, as CI does; an isolated hook env without them types
-  # PIL, requests and friends as Any and reports different errors. Needs
-  # mypy==1.20.2 (the version CI pins) in the environment you commit from.
-  - repo: local
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.8.0
     hooks:
       - id: mypy
-        name: mypy (ratchet, mypy-clean.txt)
-        entry: python scripts/check_types.py
-        language: system
+        additional_dependencies: [types-requests, types-pytz]
+        args: [--ignore-missing-imports, --no-error-summary]
         pass_filenames: false
-        always_run: true
-        stages: [manual]
+        files: ^src/
 
   - repo: https://github.com/PyCQA/bandit
     rev: 1.8.3

CHANGELOG.md

@@ -19,185 +19,35 @@ accepts both, but the store flags the old spelling as deprecated
 
 ## Unreleased
 
-### Fixes
+- One plugin-directory resolver, `src/plugin_system/plugin_dirs.py`, behind
+  discovery, `PluginManager.get_plugin_directory`, `PluginLoader`, the store and
+  state reconciliation. A manifest's `id` wins over a directory merely named for
+  the id; hidden and `.standalone-backup-` directories are never treated as
+  plugins (auto-update could previously try to update a backup); ids like
+  `a/b` or `..` resolve to nothing everywhere. Installs where each directory is
+  named for its manifest id, the installer's layout, behave as before.
 
-- On-demand no longer restarts a running display. `POST
-  /display/on-demand/start` treated `start_service` (on by default, and what
-  "Preview on display", the on-demand dialog and the MQTT bridge all send) as
-  "restart": it stopped the service, waited 1.5s and started it again, so
-  every request reloaded every plugin and left the panel blank for seconds.
-  The running display already reads the request within a quarter of a second,
-  mid-screen and mid-Vegas included, so the route now only starts the service
-  when it is not running. `POST /display/on-demand/stop` reads
-  `stop_service` as a boolean, so `"false"` no longer stops the service.
-- On-demand works for a disabled plugin. The display only loads enabled
-  plugins, so "Preview on display" on a disabled plugin's config page (which
-  says the plugin will be enabled for the preview) failed with
-  `invalid-mode`. The display now loads the plugin live for the session,
-  without writing `enabled` to `config.json`, and unloads it when on-demand
-  is stopped, expires or moves to another plugin. A plugin that fails to
-  load reports on-demand status `error` with `load-failed`. A session
-  restored after a restart unloads its disabled plugin the same way; it used
-  to stay loaded until the next restart.
-- A stop request now clears an on-demand error. After a failed request,
-  `/display/on-demand/status` kept reporting `status: error` for up to two
-  minutes even after a stop.
-- Re-saving unchanged data through `CacheManager.set` no longer rewrites its
-  cache file. The disk cache already skipped a payload identical to the last
-  one written, but `set()` stamps every record with the current time, so the
-  skip never fired and every plugin rewrote its unchanged API data to the SD
-  card on every update cycle. Records are now compared without that
-  timestamp, and a skipped write moves the file's mtime to it instead; reads
-  treat a record as fresh from the later of the two, so it expires exactly
-  when the rewrite would have. Changed data or a changed `ttl` still writes,
-  and so does a file another process has replaced since.
-
-## 3.7.0
-
-Sports consolidation stage 3 (#672). No behaviour change: nothing in core
-uses these yet, and the scoreboards adopt them when they floor on 3.7.0.
-
-### New modules
-
-A plugin may import these via `src.*` (floor on 3.7.0). All three hold code
-the scoreboard plugins carry as identical copies, moved without behaviour
-change under the plugins' own method names; each docstring lists what the
-host class must provide. The plugins delete their copies when they floor on
-3.7.0.
-
-- `src/common/sports_celebration.py` — `SportsCelebrationMixin`, the
-  score/win celebration takeover drawn by afl, football, hockey, nrl and
-  soccer (`_draw_celebration_layout` and the palette, backdrop, scenery,
-  confetti and crest steps behind it), plus its colour helpers as free
-  functions: `logo_palette`, `lift_color`, `cap_luminance`, `mix_color`,
-  `scale_color`, `dim_rgba`, `rgb_luminance`, `rgb_saturation`,
-  `color_distance`. Only the drawing: when to celebrate, the phrase and the
-  scenery stay in each plugin.
-- `src/common/sports_fetch.py` — `SportsFetchMixin`, four `SportsCore`
-  methods identical in all nine scoreboards: `_fetch_season_directly`,
-  `_background_fetches_espn_ranges`, `_needs_previous_day` and
-  `_wants_live_odds` (with `_LOOKBACK_CUTOFF_HOUR` and
-  `_LIVE_ODDS_LOOKAHEAD`).
-- `src/common/sports_card_wrappers.py` — `SportsCardWrappersMixin`, the
-  seventeen `sports_card` delegations the eight scoreboard game renderers
-  carry (`_vs_text`, `_element_color`, `_format_game_date`, ...): the methods
-  `SportsGameRendererMixin` expects its host to provide.
-
-## 3.6.2
-
-A fix to `src.common.favorite_team_check` (#670).
-
-### Fixes
-
-- The favourite-team check no longer says the Europa League season has
-  finished between matchdays. Its scoreboard keeps showing the last matchday,
-  and its calendar is a "list" of rounds rather than match days, so neither
-  3.6.1 rule applied. When every event is past, a round in a list calendar
-  that has not started yet (outside an offseason phase) now draws no
-  conclusion. PLL, the World Cup and AFL, whose seasons are over, are still
-  reported as finished: no round of theirs is still to start. (#670)
-
-## 3.6.1
-
-A fix to `src.common.favorite_team_check` (#667). Plugins that drop their
-bundled copy of it should floor on 3.6.1, not 3.6.0.
-
-### Fixes
-
-- The favourite-team check no longer logs "the season has finished" for a
-  league that is still playing. ESPN's default scoreboard keeps showing the
-  last slate after it: MLB's regular-season games two days into the
-  postseason, a soccer league's previous matchday between rounds. When every
-  event is in the past, the check now looks first at the league's phase (a
-  regular season or postseason that has moved past the events shown draws no
-  conclusion) and at a match-day calendar (`calendarType` "day" with
-  `calendarIsWhitelist`, as soccer, the NHL and the NBA use), whose next date
-  becomes "nothing on until <date>". An offseason, or a payload without these
-  fields, is reported as before.
-
-## 3.6.0
-
-New modules a plugin may import via `src.*` (floor on 3.6.0). Both are
-promoted from files the scoreboard plugins carry as copies; the plugins keep
-their copies as a fallback until they floor on 3.6.0. No other change since
-3.5.0.
-
-- `src/common/favorite_team_check.py` — `FavoriteTeamCheck(logger, leagues)`:
-  checks configured favourite team codes against ESPN once per league, on a
-  daemon thread, and logs why a league shows nothing (a wrong code, with the
-  nearest real one, or a season that has not started). The seven copies
-  (`<sport>_favorite_check.py`) were byte-identical; this is the same code,
-  with type annotations added.
-- `src/common/sports_timezone.py` — `resolve_timezone_name()` /
-  `resolve_timezone()` (plus `system_timezone_name()`): the timezone a
-  scoreboard draws start times in. The ten copies (`<sport>_timezone.py`)
-  differed only in two values, which are keyword-only arguments here:
-  `plugin_label` (named in the warning logged when nothing resolves) and
-  `writeback_fixed_in` (for a plugin that once wrote `"UTC"` back into the
-  saved config; `None` otherwise). Same resolution order and log messages.
-
-## 3.5.0
-
-New modules a plugin may import via `src.*` (floor on 3.5.0):
-
-- `src/common/sports_helpers.py` — the helpers the scoreboards' `sports.py`
-  carry byte-identical copies of: `clamp_window`, `clamp_seconds`,
-  `logo_needs_refresh`, `spread_weighted_order` (+ `MIN_WINDOW_DAYS`,
-  `MAX_WINDOW_DAYS`), and `SportsHelpersMixin` with `_mode_customization`,
-  `_setting_int`, `_reset_dwell_on_reentry`, `_next_switch_index`,
-  `_spread_weighted_order`, `_odds_color`, `_upcoming_date_and_time_text` under
-  the plugins' names and signatures, plus the `_favorite_key` override point.
-  Constructor-free; keeps lazy state on its host (see the module docstring,
-  which also gives the host contract).
-  A new module rather than more methods on `sports_shared`: a plugin that
-  deletes a copy and leans on an older module having grown the method fails at
-  runtime with `AttributeError`, which no load-time check sees, while a missing
-  module fails at load. Nothing in core uses it yet.
-- `src/common/espn_dates.py` — `fetch_espn_scoreboard`,
-  `fetch_espn_date_chunks`, `espn_date_chunks`, `clamp_espn_limit`,
-  `ESPN_MAX_LIMIT`: fetch an ESPN scoreboard date range now that ESPN rejects
-  ranges (see Sports data below). Plugins bundle a copy of it.
-- `src/common/json_body.py` — `response_json(response)`: `response.json()`,
-  parsed by orjson when it is installed (an optional dependency) and by the
-  stdlib otherwise; an orjson parse error falls back to `response.json()` so
-  requests raises its usual error. Same Python objects either way; a season
-  schedule parses about 1.7x faster on a Pi 4, and the parse holds the GIL (so
-  freezes the display) for that much less time. `espn_dates` and
-  `BackgroundDataService` use it; `espn_dates` falls back to `response.json()`
-  when it is missing, so the plugins' bundled copies of `espn_dates` still load
-  on an older core.
-- `src/common/bdf_font.py` — `load_bdf_face(path, size)` (a cached
-  `freetype.Face` plus the pixel size it really renders at, falling back to
-  the file's native strike) and `draw_bdf_text(draw, text, x, y, face, color)`.
-  `DisplayManager`, `FontManager`, `element_style` and the plugin test harness
-  now all load and draw BDF text through it; the panel's pixels are unchanged
-  and BDF text draws 10-250x faster. The plugin test harness's
-  `calendar_font` / `bdf_5x7_font` now has the panel's 7px size set: it used
-  to be an unsized face, so in golden images and `check_plugin` /
-  `dev_server` previews its text sat 6px above where the panel draws it (off
-  the canvas entirely near the top) and `get_font_height()` returned 0.
-
-Also new under `src/` since 3.4.0, but internal to core rather than for plugins:
-`src/common/frame_timing.py` and `src/common/render_gate.py` (see Scrolling),
-`src/core_config_keys.py`, `src/deprecation.py`, `src/device_location.py`,
-`src/font_usage.py`, `src/matrix_support.py`, `src/pi5_matrix_support.py`,
-`src/redaction.py`, `src/scan_order.py`, `src/web_interface/config_arrays.py`,
-and in `src/plugin_system/`: `plugin_dirs.py`, `repo_urls.py`,
-`store_install.py`, `store_registry.py` and `store_update.py`.
-
-New names in existing modules (a plugin using these must floor on 3.5.0):
-
-- `src.common.api_helper`: `USER_AGENT`, `DEFAULT_HTTP_HEADERS` (read-only).
-- `src.logo_downloader`: `fetch_logo`, `save_png_atomically`,
-  `shared_downloader`.
-- `src.common.sports_card.unshare_element_fonts` takes an optional third
-  argument, `element_for_font` (default: the module's `ELEMENT_FOR_FONT`, so
-  existing calls are unchanged).
+- `FontManager.get_font()` returns a BDF font at its native size when asked for
+  a size the file doesn't contain (5x7.bdf at 8 or 10px, say). It used to
+  return PIL's default font, a different typeface, so a plugin that relied on
+  that will now render the font it asked for.
 - `src.wifi_manager.get_wifi_status_path()` — where WiFi status messages for
   the display are written (`config/wifi_status.json`).
-- `BackgroundDataService.handles_espn_date_ranges` (see Sports data).
-- `FontManager.register_plugin_fonts()` takes an optional `plugin_dir`, and
-  `FontManager.forget_manager_fonts()` is new (see Fonts).
+- `src.device_location` — a blank `Location` field on a Starlark (Tidbyt) app
+  now renders at the device's City / State / Country (geocoded once via
+  Open-Meteo and cached) instead of the app author's hard-coded default,
+  usually San Francisco. A location saved on the app still wins. With no
+  device city set, or when the lookup fails or finds no match, the app keeps
+  its own default (a failed lookup is retried after 30 minutes). Clearing an
+  app's location in the web UI now actually clears it; the save used to drop
+  the blank field, so the old value stayed.
+
+- The web UI's Fonts tab has a **Used by** column: the loaded plugins that
+  registered each font with `FontManager.register_manager_font()`, published
+  by the display service to the shared cache (`src/font_usage.py`) and merged
+  into `GET /api/v3/fonts/catalog` as `used_by`. Deleting a font a plugin
+  uses now names those plugins in the confirmation (it is not blocked).
+  `FontManager.forget_manager_fonts()` is new; unloading a plugin calls it.
 
 Deprecated, removed in 3.7.0 (each logs a warning on first use; see
 `docs/PLUGIN_API_REFERENCE.md#deprecated-apis` for replacements). Nothing in
@@ -217,6 +67,108 @@ core, the monorepo or the registry's third-party plugins calls them:
   `unregister_plugin_fonts`.
 - `PluginManager.get_enabled_plugins`.
 
+### Config writes
+
+- A power cut or crash mid-save can no longer leave `config/config.json`
+  truncated. `ConfigManager.save_config()` wrote the file in place; it,
+  `save_config_atomic()`, `save_raw_file_content()` and backup rollback now
+  share one writer (`atomic_write_text` in `src/config_manager_atomic.py`)
+  that fsyncs a temp file, renames it into place and fsyncs the directory.
+- `save_config_atomic()` no longer rewrites `config_secrets.json` on every
+  save, only when its content changes, and rotating backups no longer re-reads
+  every backup. The backups themselves are unchanged:
+  `config/backups/config.json.backup.<version>` plus its paired secrets
+  backup, five newest kept.
+- A save by the root-run display service keeps the file's previous owner
+  instead of handing `config.json` to root, and an install path with
+  "secrets" in a directory name no longer makes `config.json` mode 0640.
+
+New names in existing modules (no new modules; a plugin importing these must
+floor on the release that ships them):
+
+- `src.common.api_helper`: `USER_AGENT`, `DEFAULT_HTTP_HEADERS` (read-only).
+- `src.logo_downloader`: `fetch_logo`, `save_png_atomically`,
+  `shared_downloader`.
+
+### Logo downloads
+
+- `download_missing_logo` / `LogoDownloader.download_logo` (the path the
+  scoreboard plugins use) now stream the logo with a 10 MB cap, accept only an
+  `image/*` response that Pillow can decode, and move the finished RGBA PNG
+  into place atomically. A failed, oversized or non-image download no longer
+  leaves a partial file behind, and no longer replaces a logo already on disk.
+  `LogoHelper._download_logo` goes through the same code. Signatures and return
+  values are unchanged; saved files are pixel-identical to before.
+- `download_missing_logo` reuses one downloader (one `requests.Session`) per
+  thread instead of building a new one for every logo.
+- Placeholder logos are written atomically, without the `test_write.tmp`
+  probe file.
+
+### HTTP headers
+
+- The logo downloader and the background data service send the real
+  `LEDMatrix/1.0 (+https://github.com/ChuckBuilds/LEDMatrix)` User-Agent
+  instead of a `yourusername` / `contact@example.com` placeholder, and no
+  longer set `Accept-Encoding: ... br` by hand (brotli is not installed, so a
+  `br` response could not be decoded); requests picks the encodings.
+
+### Plugin error reporting
+
+- `/api/v3/errors/summary` and `/api/v3/errors/plugin/<id>` report the errors
+  the display service recorded. They used to read the web process's own error
+  aggregator, which never records anything, so they always answered "no
+  errors". The display service now publishes a bounded snapshot to the shared
+  cache (`plugin_error_snapshot`, at most every 10 seconds and only on change;
+  `src/error_aggregator.py`, started from `DisplayController.__init__`).
+  Responses keep their shape and add `snapshot_available`, `generated_at` and
+  `clear_pending`; exception text has credentials redacted.
+- `POST /api/v3/errors/clear` records a request (`plugin_error_clear_request`)
+  the display service applies within about 5 seconds; reads hide the cleared
+  errors at once. It accepts `"all": true`, and `cleared_count` can be `null`
+  when the count is only known to the display service.
+- The Logs tab has a **Plugin errors** panel: per-plugin counts, repeating
+  errors and a Clear button.
+
+### Removed
+
+- **The skin system.** Skins never rendered with the current scoreboard
+  plugins, so they are gone rather than "not supported yet": `src/skin_system/`,
+  `skins/`, `scripts/validate_skin.py`, `GET /api/v3/skins`, the store's
+  `"type": "skin"` handling and `docs/SKIN_SYSTEM.md` / `docs/CREATING_SKINS.md`.
+  A `skin` or `skin_options` key left in a plugin's saved config still loads
+  and saves without a validation error; it is ignored, and the next save of
+  that plugin's settings removes it (unless the plugin's own schema declares
+  the key).
+- **`src/base_classes/`** (`SportsCore`, the sport and mode classes,
+  `CelebrationMixin`, the rotation strategies, `data_sources`,
+  `api_extractors`). No known plugin imports it. A plugin that does must use
+  `src.common` or its own copy of the code.
+
+## 3.5.0
+
+New modules a plugin may import via `src.*` (floor on 3.5.0):
+
+- `src/common/sports_helpers.py` — the helpers the scoreboards' `sports.py`
+  carry byte-identical copies of: `clamp_window`, `clamp_seconds`,
+  `logo_needs_refresh`, `spread_weighted_order` (+ `MIN_WINDOW_DAYS`,
+  `MAX_WINDOW_DAYS`), and `SportsHelpersMixin` with `_mode_customization`,
+  `_setting_int`, `_reset_dwell_on_reentry`, `_next_switch_index`,
+  `_spread_weighted_order`, `_odds_color`, `_upcoming_date_and_time_text` under
+  the plugins' names and signatures, plus the `_favorite_key` override point.
+  Constructor-free; keeps lazy state on its host (see the module docstring,
+  which also gives the host contract).
+  A new module rather than more methods on `sports_shared`: a plugin that
+  deletes a copy and leans on an older module having grown the method fails at
+  runtime with `AttributeError`, which no load-time check sees, while a missing
+  module fails at load. Nothing in core uses it yet.
+- `test/test_common_is_hardware_free.py` — `src/common` must import without
+  `rgbmatrix` and never import `src.base_classes`, `src.display_manager` or
+  `src.plugin_system` at module level.
+- `src/common/espn_dates.py` — `fetch_espn_scoreboard`,
+  `fetch_espn_date_chunks`, `espn_date_chunks`, `clamp_espn_limit`,
+  `ESPN_MAX_LIMIT`: fetch an ESPN scoreboard date range now that ESPN rejects
+  ranges (see Sports data below). Plugins bundle a copy of it.
+
 ### Config saves and plugin config preparation
 
 - A JSON `POST /api/v3/config/main` changes only the keys it sends. The MQTT
@@ -262,23 +214,8 @@ core, the monorepo or the registry's third-party plugins calls them:
   "enabled but not found in plugins directory", and plugin ids that collide
   with any core config section are flagged: the last private copies of the
   core-key list now use `src/core_config_keys.py`.
-- Plugin config saves recombine position-keyed inputs for nullable array fields (`"type": ["array", "null"]`).
-- A blank Max Dynamic Duration keeps the stored value instead of failing the Display save with a 500; other values must be whole seconds from 30 to 1800.
-- A power cut or crash mid-save can no longer leave `config/config.json`
-  truncated. `ConfigManager.save_config()` wrote the file in place; it,
-  `save_config_atomic()`, `save_raw_file_content()` and backup rollback now
-  share one writer (`atomic_write_text` in `src/config_manager_atomic.py`)
-  that fsyncs a temp file, renames it into place and fsyncs the directory.
-- `save_config_atomic()` no longer rewrites `config_secrets.json` on every
-  save, only when its content changes, and rotating backups no longer re-reads
-  every backup. The backups themselves are unchanged:
-  `config/backups/config.json.backup.<version>` plus its paired secrets
-  backup, five newest kept.
-- A save by the root-run display service keeps the file's previous owner
-  instead of handing `config.json` to root, and an install path with
-  "secrets" in a directory name no longer makes `config.json` mode 0640.
 
-### Sports data, logos and odds
+### Sports data
 
 - Since 2026-09-15 ESPN answers `dates=YYYYMMDD-YYYYMMDD` scoreboard queries
   with `400 Bad Request` for every sport, so season schedules, the weeks window
@@ -326,44 +263,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   longer swallowed as a missing poll. This is the implementation the football,
   baseball and hockey boards already ship; core was the last copy on the old
   one.
-- `BaseOddsManager.get_odds()` no longer returns the cached "no odds" marker (`{"no_odds": True}`) as if it were odds. A game ESPN had no odds for is cached that way so it isn't re-requested every update; on the next update the cache hit handed the marker back, and callers saw a truthy dict. It now returns `None` for it, on the cache hit and in the stale-cache fallback after a failed fetch, as the plugins' bundled copies already did.
-- Background data fetches retry at one level instead of two. The session adapter retried a connection error three times inside every attempt of the service's own retry loop, so a dead network cost up to 16 connection attempts per request and held one of the few worker threads throughout; now it is the loop's `max_retries + 1` attempts. ESPN date-range chunks, which don't go through that loop and skip a chunk that fails, keep a small connection retry of their own so a brief blip doesn't drop a month from a cached season.
-- `LogoHelper.load_logo_with_download()` sizes its placeholder to the scaled logo box, like a real logo (only differs when `scale` isn't 1).
-- The AP Top 25 resolver remembers a failed or empty rankings fetch for 5 minutes, so an ESPN outage no longer costs every scoreboard update a 30s timeout. Its duplicate INFO log line is gone.
-- `BackgroundDataService` runs a cache-hit callback outside its lock, as the fetch path does.
-- `LogoHelper.load_logo_with_download()` waits an hour before retrying a download that failed for a missing logo, instead of retrying (with a 30 s timeout) on every call.
-- Restamping a placeholder logo writes the file atomically.
-- The odds manager logs cache hits, misses and fetches at DEBUG, and a bad JSON body is logged as a parse error rather than a failed fetch.
-- `APIHelper` keeps cached responses for the `cache_ttl` it was given, instead of always 300 s.
-- Logo scales from 0.1 to 10 are honoured everywhere; values outside that range are clamped.
-- `LogoHelper` and `logo_downloader`: an empty ESPN logo list counts as a failed download, and the placeholder is written at the requested path.
-- The `SportsCoreSharedMixin` helpers that behave identically to their
-  `sports_card` twins (`_card_option`, `_vs_text`, `_format_game_time`,
-  `_coerce_rgb`, `_crisp_size`, `_unshare_element_fonts`, the colour/month/
-  weekday/font-grid tables) are now thin wrappers over the `sports_card`
-  functions, and `_format_game_date` / `_schema_font_size` share its
-  formatting body and schema parser. No method was removed or renamed and
-  nothing renders differently: `test/test_sports_twins.py` checks each pair
-  against the same inputs, and the old and new mixin agree on every input
-  there. The pairs that do differ -- favourite-result colours on nested
-  payloads, the weekday's timezone, the element-name map, per-mode colours --
-  are left as they are and pinned in that test.
-- `download_missing_logo` / `LogoDownloader.download_logo` (the path the
-  scoreboard plugins use) now stream the logo with a 10 MB cap, accept only an
-  `image/*` response that Pillow can decode, and move the finished RGBA PNG
-  into place atomically. A failed, oversized or non-image download no longer
-  leaves a partial file behind, and no longer replaces a logo already on disk.
-  `LogoHelper._download_logo` goes through the same code. Signatures and return
-  values are unchanged; saved files are pixel-identical to before.
-- `download_missing_logo` reuses one downloader (one `requests.Session`) per
-  thread instead of building a new one for every logo.
-- Placeholder logos are written atomically, without the `test_write.tmp`
-  probe file.
-- The logo downloader and the background data service send the real
-  `LEDMatrix/1.0 (+https://github.com/ChuckBuilds/LEDMatrix)` User-Agent
-  instead of a `yourusername` / `contact@example.com` placeholder, and no
-  longer set `Accept-Encoding: ... br` by hand (brotli is not installed, so a
-  `br` response could not be decoded); requests picks the encodings.
 
 ### Scrolling
 
@@ -394,92 +293,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   held 20 ms frame as missed refreshes, and Vegas `frame_based_scrolling` /
   `scroll_delay` are described as the speed clamp they are rather than frame
   stepping. Scoreboard `scroll_delay` is documented as ignored for pacing.
-- `ScrollHelper.set_scrolling_image()` accepts RGBA, L and palette images (transparent pixels become black), and a new scrolling image no longer jumps ahead by the time the helper sat idle.
-- `src.common.frame_timing` -- times every frame the display presents, whoever
-  drew it, and writes cumulative counters to `/dev/shm`. Two tools read it:
-  `scripts/frame_soak.py` judges a running service (late frames, freezes,
-  where the time goes), and `scripts/render_bench.py` judges the hardware and
-  render path alone on a synthetic strip. Both fail a run above 0.1% late
-  frames, and both call a loop that never waited for the panel NOT LOCKED. A
-  stall watchdog logs the stack of whatever holds a scroll up for 250 ms or
-  more. See `docs/SCROLL_PERFORMANCE.md`, "Soaking a rig".
-- `display.scan_order_compensation` (`"auto"` by default): while something
-  scrolls at one pixel per refresh, one half of each panel is shown a refresh
-  behind the other, which removes the 1px step a 1:N-scan panel shows across
-  its middle. Only for layouts whose row order is known; `"off"` disables it.
-  See `docs/SCROLL_PERFORMANCE.md`, "A tear across the middle on fast scrolls".
-
-### Display and Vegas
-
-- Vegas scrolls in step with the panel's refresh (#628). With `smooth_scroll`
-  (on by default) the strip moves a whole number of pixels per presented
-  frame, each held for `frame_hold` refreshes and timed by `SwapOnVSync`,
-  the same pacing as the plugin tickers; it used to advance by elapsed time
-  and sleep to `target_fps`, missing a vsync every few frames. The speed is
-  solved against the panel's measured refresh when that is below its
-  `limit_refresh_rate_hz` cap. The old sub-pixel blend, which the panel shows
-  as shimmer, is kept as `vegas_scroll.sub_pixel_blend` (default off). While
-  scrolling, the web preview's PNG is encoded on a background writer instead
-  of the render thread. On a Pi 4 driving 512x64, late frames went from about
-  6.4% to 0.7%.
-- Vegas prepares plugin content off the render thread (#630). A plugin that
-  needed the shared canvas used to be fetched on the render thread, stalling
-  the scroll for as long as it took (320 ms for news, 660 ms for a hockey
-  scoreboard, measured). `DisplayManager.offscreen(width, height)` gives the
-  calling thread a canvas of its own: `image`, `draw` and `matrix` are now
-  properties that resolve to it inside the block, where `update_display()`,
-  the hardware half of `clear()` and `set_scrolling_state()` /
-  `set_frame_hold()` do nothing. Background fetches take the plugin's lock,
-  waiting up to 2 s for a running `update()` and otherwise skipping the plugin
-  that round. A GIL gate (`src/common/render_gate.py`) pauses the prefetch
-  thread outside a window around each vsync swap, so the render thread finds
-  the GIL free; it needs the rebuilt binding that releases the GIL in
-  `SwapOnVSync` and stays off (one INFO line per Vegas run) on a stock one.
-  New `vegas_scroll` keys: `offscreen_prefetch` and `prefetch_gate` (both on by
-  default) and `switch_interval_ms` (experimental, default 0, off). Design in
-  `docs/OFFSCREEN_RENDERING.md`.
-- On-demand requests, the display on/off schedule and brightness take effect
-  within about a quarter of a second instead of at the next screen (#618). A
-  screen can stay up for a minute and a Vegas iteration for 240 s, so an
-  on-demand request during Vegas waited for the iteration to end and a
-  brightness save mid-screen could be lost. Vegas now stops for an on-demand
-  request and for the display being scheduled off, and a brightness change
-  re-sends the current frame. Plugin enable/disable, screen durations and Vegas
-  settings still apply at the next screen.
-- The Rotation & Durations page takes effect (#605). A saved
-  `display.display_durations` value now wins over the plugin's own duration;
-  the plugin was asked first, and every plugin inherits
-  `get_display_duration()`, so saved values did nothing. The page shows an
-  unsaved screen blank with the plugin's own duration as the placeholder (it
-  showed 30 where the real default is 15), and saving a blank removes the
-  override. Durations saved before this now apply.
-- Vegas settings reach a running scroll (#605): they are queued when
-  `display.vegas_scroll` changes (unrelated saves don't rebuild the strip) and
-  also applied while Vegas is stopped. The sync follower's scroll-speed
-  default (75) now matches `VegasModeConfig`'s (50). The Vegas live-priority
-  scan is throttled to 4 Hz.
-- `DisplayManager.defer_update()` from a plugin's update thread no longer loses queued updates while the render thread processes the queue; the queue is locked, and the queued callables still run outside the lock.
-- **Behaviour change:** when `display.hardware.limit_refresh_rate_hz` is missing from config, the panel is now capped at 100 Hz (the config template's value) instead of 90 Hz. Scroll pacing already assumed 100 Hz in that case, so it now matches what the panel does. Configs that set the key (every config migrated from the template) are unaffected.
-- A sync follower adopts the leader's scroll image between frames on the render thread, instead of the TCP thread swapping the image, array and width while a frame is being drawn.
-- `update_display()` errors are logged once with a traceback, then at most once a minute with a count, instead of an untraced line every frame. Several swallowed exceptions in `DisplayController` now log at DEBUG.
-- The repo-root `display_controller.py` now runs `run.py` (the real entry point), so it gets run.py's `-e`/`-d` flags, logging setup and `sys.dont_write_bytecode`.
-- Vegas: a plugin set to `vegas_mode: "static"` pauses the scroll for its turn again. The pause was triggered by peeking at the front of a segment buffer that continuous scrolling (the default) never advances, so a static plugin paused only if it happened to be first, once, at startup, and otherwise scrolled past as ordinary content; swap mode had the same problem for any static plugin not first in its cycle. The render pipeline now marks where each static plugin's turn falls in the strip and the scroll pauses when it gets there. The pause runs the plugin's `display()` under its plugin lock, and a static plugin's content is no longer rendered for the strip.
-- The display loop no longer spins at 100% CPU when no enabled mode has anything to show (for example, only a sports plugin enabled in its off-season). After one full rotation of empty modes it checks one mode per second until something shows; live content still takes over at once.
-- Stopping `ledmatrix.service` runs the controller's cleanup (SIGTERM now takes the Ctrl-C path).
-- Turning Vegas on in the web UI works without a restart when it was off at startup.
-- Vegas comes back after live content interrupts it. It stayed paused, and the display fell back to normal rotation until a restart.
-- A day with dimming turned off in a per-day dim schedule stays at normal brightness. Before, brightness went back to dim for most of each minute.
-- Stopping on-demand after a second request resumes rotation where it was first interrupted, not at the first request's screen.
-- Turning Vegas off and on no longer shows content prepared for the previous run, including plugins disabled in between.
-- How long a Vegas iteration runs is timed with the monotonic clock, so an NTP clock step on a Pi without an RTC doesn't cut it short or stretch it.
-- The sync status file is removed when the display service stops, and at startup in standalone mode, so the web UI no longer reports a peer from an earlier run. Concurrent writes each use their own temp file.
-- `render_gate.swap_releases_gil()` delegates to `frame_timing.binding_releases_gil()` instead of duplicating it.
-- Vegas `max_cycle_duration` defaults to 240 s when unset, as documented (it was 600 s). The Vegas defaults are now defined once.
-- The display controller stops Vegas mode on shutdown.
-- Startup validation warnings are logged once, not twice.
-- Vegas logs one INFO line per plugin-list refresh.
-- `run.py -d` shows `display_manager` debug output.
-- Removed: the Vegas staging buffer that was never filled (`swap_buffers()`, and `staging_count` / `current_index` in `get_buffer_status()`), unread `ContentSegment` fields, and `geometry.find_blank_cut()`.
 
 ### Web interface
 
@@ -544,142 +357,8 @@ core, the monorepo or the registry's third-party plugins calls them:
   discover when nothing has been discovered yet, and rescan once when a
   specific plugin id (or, for on-demand by mode, a mode) is not found, so a
   plugin installed since the last scan is found too.
-- `web_interface/blueprints/api_v3/plugins.py` (3,285 lines) is split by area into `plugins.py` (installed list, enable/disable, plugin actions), `plugin_store.py`, `plugin_config.py`, `plugin_assets.py`, `plugin_health.py`, `plugin_operations.py` and `plugin_calendar.py`. Pure move: every function body and route decorator is byte-identical, and URLs and endpoint names are unchanged.
-- Plugins installed as `ledmatrix-<id>` (or in a directory not named after their id) work in the installed list, the update button, recorded versions, the plugin config form and plugin web UI pages. Those routes built `plugins_dir/<id>` themselves instead of asking the plugin manager.
-- Uploading several plugin images checks every file before saving any, so a rejected file no longer leaves the others saved; the images' `.metadata.json` and the calendar plugin's `credentials.json` are written atomically, and the credentials upload no longer returns the server's absolute path.
-- `"false"` sent as a string no longer counts as true when toggling a plugin (including Starlark apps) or starting on-demand mode (`pinned`, `start_service`); `force` on the AP-enable route is parsed like every other WiFi boolean (`"yes"` and `1` now force).
-- The live-preview stream starts a new broadcast thread for a client that connects while the previous one is shutting down; that client got no updates.
-- The web server's log filter no longer raises when werkzeug logs with `exc_info=True`.
-- The raw secrets editor's save errors carry `error_code` like the main config's; the asset delete route answers 400 for a missing body instead of 415/500. Dead code removed: an unused manifest scan on each Plugins-tab load, backup routes' duplicate catch-alls, redundant imports.
-- A plugin's own config widget (`/static/plugin-widgets/<id>/<widget>.js`) is requested with `?v=<plugin version>`, so an updated plugin's widget reaches browsers instead of the copy cached as immutable for a year.
-- A failed installed-plugins reload after a toggle, install or uninstall shows one error, not a second generic "unexpected error" toast.
-- The timezone picker on the General tab renders again when the tab is reloaded in the same page session.
-- Removed dead code: the plugin-action button's six plugin-id fallbacks (the button always passes its id) and its `[DEBUG]` logging, `window.currentPluginConfig` (never set to anything but `null`), the file-upload widget's JSON delete branch (its endpoint never existed), unused `PluginAPI` / `PluginInstallManager` / `PluginStateManager` helpers, `loadPluginWidgetsFromManifest`, no-longer-reachable fallbacks for a stale `install_manager.js` and a missing `LEDVisibility`, and 13 unused CSS utility rules.
-- The Logs tab's "Now showing" no longer reads "unknown" when one screen stays up longer than 2 minutes.
-- A network failure fetching GitHub repo info logs a warning, not an error.
-- The Operation History plugin filter lists installed plugins (it showed one option, "plugins").
-- Ctrl/Cmd+S submits the active tab's visible form (with its validation) instead of the first form in the page; it does nothing inside a dialog or on a tab without a form. The Ctrl/Cmd+R override (the browser's own reload) and the textarea auto-resize (no textarea exists at load) are removed.
-- Tools tab actions and diagnostics show the server's error message; only a non-JSON error falls back to `HTTP <status>`.
-- An uninstalled plugin no longer reappears in the installed list: writes through `PluginAPI` clear its 5s GET cache, and Refresh and the post-uninstall reload bypass both list caches.
-- Plugin widgets load from `/static/plugin-widgets/` only; the two other paths it tried have no route.
-- The raw JSON editor escapes the parse error, and the slider widget escapes its value, min, max and step.
-- Removed unused array-of-objects and key-value helpers from `plugins_manager.js` (about 640 lines, no callers) and a redundant `?v=` on its script tag.
-- Plugin tabs show the manifest's `icon`: `/api/v3/plugins/installed` now includes it.
-- `POST /api/v3/starlark/apps/<id>/toggle` goes through the same code as `/plugins/toggle`: `"false"` disables, a failed save no longer leaves the running app out of step with disk, and a loaded app with no manifest entry no longer answers 500.
-- `/api/v3/` JSON responses are sent `Cache-Control: no-store`, so a reload right after an install, toggle or Wi-Fi connect shows the new state. Non-JSON files served through the API keep the 5 s cache.
-- Startup plugin validation no longer gives up on a `null` plugin block, and plugins are discovered once at startup instead of twice.
-- A plugin save drops repeated entries in lists whose schema says `uniqueItems`, instead of failing validation.
-- `/api/v3/health` reports the real plugin count.
-- A malformed `vegas_plugin_order` or `vegas_excluded_plugins` is refused with a 400 and nothing is saved. It used to wipe the saved list.
-- The per-plugin health and metrics routes return the display service's latest state.
-- Resetting a plugin's config takes a backup first and reports a failed save.
-- System metrics that can't be read are `null` everywhere: `cpu_temp` off a Pi, and every metric without psutil, where `/system/status` now answers 200 instead of 503.
-- `/plugins/store/refresh` no longer claims a commit-metadata refresh it doesn't do.
-- The plugin-config list repair code is in one place, `src/web_interface/config_arrays.py`.
-- Cache tab errors no longer show up in the Logs tab.
-- A tab that fails to load shows "Try again" instead of a skeleton that never goes away.
-- Plugin Store search and registry errors appear as a notification, and the Plugin Manager stays on screen.
-- The image schedule button works on uploaded images, and the editor stays open while you edit.
-- A failed plugin toggle moves the switch back.
-- Each save shows one notification; a failed Durations save says it failed.
-- Stats the server can't read show `--`.
-- New `window.LEDEscape` (`html`, `attr`, `jsStringAttr`) replaces about 30 copied escapers. `window.escapeHtml` and `window.escapeAttribute` remain as aliases for plugin pages.
-- The web service (`ledmatrix-web`) logs through `src.logging_config` like the
-  display service, so `journalctl -p err -u ledmatrix-web` works. Successful
-  GET/HEAD/OPTIONS requests (the UI's polling) are logged at DEBUG instead of
-  INFO; 4xx at WARNING, 5xx at ERROR. `LEDMATRIX_DEBUG=true` shows them again.
-  `web_interface/logging_config.py` is removed. The web cache
-  (`web_interface/cache.py`) now honours the TTL a value was stored with and is
-  thread-safe.
-- `/api/v3` routes answer an exception they don't handle themselves from one
-  blueprint error handler, with the same `{status, message, details}` body the
-  53 removed per-route catch-alls returned. `ErrorCategory` and the
-  `error_category` key are removed from `src.web_interface.errors` (nothing read
-  them); `exception_error_response()` replaces the `from_exception` +
-  `error_response` pairs. A failing plugin action script's error now names the
-  real failure instead of `UnboundLocalError`.
-- Installing a Starlark app works on a fresh install (#604). `starlark-apps/`
-  is created by whichever service reaches it first, and on a fresh install
-  that was usually the root display service, so the web interface could not
-  write to it and every install path answered "Failed to install from
-  repository". The display service now hands the directory and its contents
-  to the checkout's owner on every start (a no-op when not root or when the
-  checkout belongs to root), which also repairs devices already affected; a
-  permission error from the install routes names the directory and the fix.
-- Clicks on plugin cards reach `handlePluginAction` (#605). Every click took
-  a copied fallback that asked twice before uninstalling and sent Starlark app
-  uninstalls to `POST /plugins/uninstall` instead of
-  `DELETE /starlark/apps/<id>`. A failed plugin toggle no longer always says
-  "A plugin operation is already in progress".
-- The web interface starts with an absolute `plugin_system.plugins_directory`
-  (#616); it crashed at import with `NameError: project_root`.
-- Stopping a Pixlet editor that ignores SIGTERM restarts the display instead
-  of answering 500 and leaving the panel dark (#625).
-- Removed dead routes and files (#609): `POST /plugins/authenticate/spotify`
-  and `/ytm` (the music plugin runs its auth scripts through `web_ui_actions`),
-  `POST /plugins/of-the-day/json/upload` and `/json/delete` (they used the
-  wrong plugin id), `js/plugins/store_manager.js`, `js/config/diff_viewer.js`
-  and `js/htmx-sse.js`, and `web_interface/run.sh`. `htmx-config.js` no longer
-  replaces `console.error` / `console.warn`, which hid some real errors.
 
-### Plugin error reporting
-
-- `/api/v3/errors/summary` and `/api/v3/errors/plugin/<id>` report the errors
-  the display service recorded. They used to read the web process's own error
-  aggregator, which never records anything, so they always answered "no
-  errors". The display service now publishes a bounded snapshot to the shared
-  cache (`plugin_error_snapshot`, at most every 10 seconds and only on change;
-  `src/error_aggregator.py`, started from `DisplayController.__init__`).
-  Responses keep their shape and add `snapshot_available`, `generated_at` and
-  `clear_pending`; exception text has credentials redacted.
-- `POST /api/v3/errors/clear` records a request (`plugin_error_clear_request`)
-  the display service applies within about 5 seconds; reads hide the cleared
-  errors at once. It accepts `"all": true`, and `cleared_count` can be `null`
-  when the count is only known to the display service.
-- The Logs tab has a **Plugin errors** panel: per-plugin counts, repeating
-  errors and a Clear button.
-- Credential redaction in exception text (`src/redaction.py`) takes time
-  proportional to the text, not its square. Two patterns were quadratic: URL
-  `user:password@`, on a long unbroken run of letters or digits (a hex digest,
-  an ID), and `Authorization:` followed by a long run of whitespace. Either
-  used to stall every thread of the display service for up to seconds each
-  time the snapshot was published: about 0.5s for 20k characters of hex, 8s
-  for 20k spaces. What gets redacted is unchanged.
-
-### Wi-Fi
-
-- WiFi status messages reach the panel (#605). The display controller looked
-  for `wifi_status.json` one directory above the repo; both sides now use
-  `wifi_manager.get_wifi_status_path()`, the file is written atomically, and
-  the plugin that resumes afterwards redraws the whole panel.
-- The captive-portal checks (`/generate_204` and friends) also detect an access point brought up through NetworkManager, the fallback `enable_ap_mode` uses without hostapd; only hostapd was checked, so phones on that AP were told the internet worked.
-- The WiFi monitor daemon re-reads `wifi_config.json` when it changes, so the "auto-enable AP mode" toggle takes effect without restarting the daemon.
-- Disconnecting from WiFi in the web UI no longer runs an AP-mode check that could never enable the AP; it only added seconds of waiting. The daemon still enables the AP after its grace period.
-- The WiFi status message file follows each WiFi manager's own config directory, and the config path falls back to this checkout rather than `/home/ledpi/LEDMatrix`.
-- A wrong Wi-Fi password is reported as one again ("Incorrect password for ..."); the fallback that restores the old network or brings up the setup AP was replacing the signal.
-- Wi-Fi disconnect takes the saved connection profile down.
-- `wifi_config.json` is written atomically, and a save that fails now gets a 500.
-
-### Fonts
-
-- Fonts tab: the preview endpoint renders BDF fonts with the panel's own rasterizer instead of refusing them. (The Fonts page still skips the request for `.bdf`; enabling it there is a separate template change.)
-- A plugin font declared as a `.zip` URL is served as the font extracted from it after a restart, instead of registering the archive itself. Font downloads time out after 30s and land in the cache only once complete, so an interrupted download is retried rather than served forever.
-- BDF fonts: `FontManager.get_font()` and `element_style.load_font()` no longer hand one `freetype.Face` to every thread. BDF faces come from `load_bdf_face`, which already caches them per thread; TrueType fonts are cached as before. `element_style`'s font cache is locked (a concurrent eviction could raise `KeyError`).
-- `FontManager.clear_cache()` and unregistering a plugin's fonts bump `cache_generation`, so cached layouts are rebuilt.
-- `plugin://` fonts load from the plugin's own install directory. `FontManager.register_plugin_fonts()` takes an optional `plugin_dir`.
-- Bundled font paths no longer depend on the directory the process was started from.
-- `FontManager.get_font()` returns a BDF font at its native size when asked for
-  a size the file doesn't contain (5x7.bdf at 8 or 10px, say). It used to
-  return PIL's default font, a different typeface, so a plugin that relied on
-  that will now render the font it asked for.
-- The web UI's Fonts tab has a **Used by** column: the loaded plugins that
-  registered each font with `FontManager.register_manager_font()`, published
-  by the display service to the shared cache (`src/font_usage.py`) and merged
-  into `GET /api/v3/fonts/catalog` as `used_by`. Deleting a font a plugin
-  uses now names those plugins in the confirmation (it is not blocked).
-  `FontManager.forget_manager_fonts()` is new; unloading a plugin calls it.
-
-### Security
+### Security (request paths and inline handlers, siblings of #561)
 
 - `POST /api/v3/plugins/assets/upload`, `GET .../assets/list` and
   `POST .../assets/delete` validate `plugin_id` with `src/common/path_safety`
@@ -698,24 +377,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   and add its own script. The store's View button opens only `http(s)` links.
 - The uploaded-images list escapes each file's original name, path and ids; a
   name like `<img src=x onerror=...>.png` was inserted as markup.
-- Installing from a URL (and a registry install whose manifest renames the plugin) refuses a plugin id that isn't a single safe name, so `../x` can no longer delete and replace a directory outside the plugins directory.
-- Plugin uninstall and config reset refuse core config sections (`display`, `schedule`, ...) and ids with path parts. Uninstall still cleans the config of a plugin whose directory is already gone.
-- A config field marked `x-secret` whose value is an object or array is saved to `config_secrets.json`, not to `config.json` in plain text.
-- Restoring a backup onto a device without `config_secrets.json`, `wifi_config.json` or `ytm_auth.json` creates them with mode 640 instead of world-readable 644.
-- Backup export skips a plugin `manifest.json` that isn't a JSON object instead of failing, and two exports in the same second no longer share a temp file or overwrite each other (the second gets a `-2` suffix).
-- Every font that ships in `assets/fonts/` is protected from deletion; `MatrixChunky8X`, `MatrixLight6X`, `MatrixLight8X` and `ic8x8u` could be deleted from the Fonts tab.
-- The raw config and secrets editors, and endpoints using `validate_request_json`, answer 400 for a JSON body that isn't an object.
-- `fix_web_permissions.sh` makes `safe_plugin_rm.sh` and `safe_pip_install.sh` root-owned again after resetting ownership. A web-user-owned copy of either is a root shell, since sudo lets the web user run them as root. It also restores `config_secrets.json` to mode 640.
-- Wi-Fi passwords are no longer stored in `config/wifi_config.json` (#608).
-  `WiFiManager` appended every joined network's SSID and password, in plain
-  text, to `saved_networks`, and nothing read them back (NetworkManager keeps
-  its own credentials). Loading the config now drops a `saved_networks` key and
-  rewrites the file, so passwords already on disk are removed.
-- The installers no longer grant the web user passwordless root on
-  `display_controller.py`, `start_display.sh` and `stop_display.sh` (#606).
-  Those files are owned by the user, so the web user could rewrite them and
-  run them as root; nothing ran them through sudo. Existing devices keep the
-  old rules until the installer or `configure_web_sudo.sh` is run again.
 
 ### Display hardware settings the library refuses
 
@@ -758,38 +419,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   (`legacy_bool_as_object` in `src/plugin_system/schema_manager.py`). Nothing
   is written at load; the next save of that plugin's settings stores the object.
   Other type mismatches still warn.
-- A plugin that is reloaded (switched off and on again from the web UI) imports its own modules again, not another plugin's. Plugins import their own files by bare name (`from sports import ...`), which resolves to the first plugin directory on `sys.path` that has the file; the loader only added a directory that was missing, so a reloaded plugin's directory stayed behind any loaded since. On a Pi, re-enabling UFC with hockey running failed with "cannot import name '_status_is_final' from 'sports'". A loading plugin's directory is now always moved to the front.
-- `src/plugin_system/store_manager.py` (2,977 lines) is split into mixins: `store_registry.py` (registry, GitHub metadata, search, manifest validation), `store_install.py` (install paths and dependencies) and `store_update.py` (updates, rollback, local git state). `PluginStoreManager` is still imported from `store_manager.py` and has exactly the same methods and attributes; every method body is byte-identical.
-- Unloading a plugin waits (up to 5s) for an in-flight `update()` before running `cleanup()`/`on_disable()`, and an update that finishes after the unload no longer puts the plugin back to ENABLED.
-- A plugin whose load fails after its module was imported (constructor, `validate_config()` or `on_enable()` raising) no longer leaves that module cached: fixing the plugin and reloading it runs the new code without a restart. Its font registrations are dropped too.
-- `POST /api/v3/plugins/limits/<id>` answers 400 for a limit that isn't a non-negative number (a string limit used to make every later update of that plugin raise). A bad cached limits record is ignored with a warning instead of raising.
-- The config schema is found for a plugin installed as `ledmatrix-<id>` or in a directory named differently from its manifest id, resolved the way the loader resolves it (plugins/ is still searched before plugin-repos/). A plugin with no schema is logged once at DEBUG instead of a warning on every lookup.
-- Installing from a URL over an existing install sets the old copy aside and restores it if the move fails, under the same per-plugin lock as a registry install.
-- The operation queue refuses a second operation for a plugin whose first is still waiting (a double-clicked Install ran twice), and no longer keeps every finished operation in memory.
-- `get_vegas_render_width()` reads `display_manager.width` first, as plugins are told to.
-- Store and state files are read as UTF-8 regardless of the system locale.
-- Docs: `update_interval` in `config.json` sets the scheduler's cadence only for a plugin whose manifest has none (TROUBLESHOOTING, PLUGIN_CONFIGURATION_GUIDE). The health/metrics reset and limits routes note that they only change the web process's view.
-- A plugin whose `on_enable()` raises is no longer left registered: the next load retries it instead of reporting "already loaded" for a plugin that never ran.
-- One plugin's `get_info()` raising no longer breaks the installed-plugins list; it is logged and shown with empty runtime info.
-- `plugin_state.json` and the operation history are written atomically (temp file + rename) under their lock, so concurrent saves or a failed save can't leave a truncated file.
-- Plugin dependency installs run one `pip` at a time during parallel startup loading.
-- A failed store download no longer leaves its extraction directory in the temp dir.
-- Test doubles: `draw_image()` on `MockDisplayManager`, `VisualTestDisplayManager` and `BoundsCheckingDisplayManager` now emits a `DeprecationWarning` — the real `DisplayManager` has no such method; use `display_manager.image.paste(img, (x, y))`. `MockDisplayManager.draw_text` accepts the real signature's `small_font`/`centered` and default `x`/`y`, and `VisualTestDisplayManager` logs draw errors at WARNING.
-- Removed the unused `PluginOperationQueue.get_active_operations()`.
-- Updating a plugin that was installed from a ZIP no longer tries to reinstall it from the LEDMatrix repository's own URL.
-- Repository URLs with `.git` in the middle are no longer mangled. The URL helpers now live in `src/plugin_system/repo_urls.py`.
-- Installing from a URL works when the repository's only branch isn't `main` or `master`.
-- A missing required config field is reported once, by name.
-- A plugin that went over `max_memory_mb` once is no longer refused on every call after that.
-- `reload_plugin` reads the manifest from the plugin's discovered directory.
-- Removed: `last_display` from plugin state info and `get_last_display()` (nothing recorded them); `PluginOperationQueue`'s `history_file` and `lazy_load` arguments; and `data/plugin_operations.json`, which nothing read.
-- One plugin-directory resolver, `src/plugin_system/plugin_dirs.py`, behind
-  discovery, `PluginManager.get_plugin_directory`, `PluginLoader`, the store and
-  state reconciliation. A manifest's `id` wins over a directory merely named for
-  the id; hidden and `.standalone-backup-` directories are never treated as
-  plugins (auto-update could previously try to update a backup); ids like
-  `a/b` or `..` resolve to nothing everywhere. Installs where each directory is
-  named for its manifest id, the installer's layout, behave as before.
 
 ### Core
 
@@ -808,39 +437,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   handling, so the restore stopped at `config.json` with nothing restored. The
   ownership step is now skipped where `os.chown` is missing. No behaviour
   change on the Pi.
-- `APIHelper`'s rate limit and the display-sync heartbeat/leader timeouts measure elapsed time with `time.monotonic()`. A wall-clock step (NTP correcting a Pi with no RTC) could stall API requests for as long as the step or fake a sync timeout. `get_request_stats()['last_request_time']` is still wall-clock time.
-- `sudo_remove_directory()` tries each bash path the sudoers rule might name, as `install_requirements_file()` already did.
-- An element's saved layout `scale` equal to its schema default is no longer treated as a user choice when the default is declared under an alias (`score` for `score_text`).
-- `CacheError`/`ConfigError`/`PluginError`/`DisplayError` no longer write their key into the caller's `context` dict; the JSON log formatter stringifies values it can't encode instead of dropping the record.
-- Removed `ErrorAggregator`'s unused JSON export (`export_path`, `export_to_file()`); nothing called it. Docstring fixes in `validate_file_upload`, `StartupValidator.raise_on_errors`, `DisplaySyncManager.set_on_new_cycle`, `dynamic_team_resolver` and `config_arrays`.
-- `/api/v3/errors` shows each exception's real stack trace instead of `NoneType: None`.
-- Backups record `src.__version__`.
-- Removed: `BackgroundDataService`'s `queue_size` stat and `clear_completed_requests()`.
-- `src.device_location` — a blank `Location` field on a Starlark (Tidbyt) app
-  now renders at the device's City / State / Country (geocoded once via
-  Open-Meteo and cached) instead of the app author's hard-coded default,
-  usually San Francisco. A location saved on the app still wins. With no
-  device city set, or when the lookup fails or finds no match, the app keeps
-  its own default (a failed lookup is retried after 30 minutes). Clearing an
-  app's location in the web UI now actually clears it; the save used to drop
-  the blank field, so the old value stayed.
-- Fixed a memory leak in the display service (#605): `ErrorAggregator`
-  appended every plugin in the time window to a pattern's `affected_plugins`
-  on each repeat (3,000 errors from three plugins reached 2.5 million
-  entries).
-- An expired cache record is refused without being parsed (#633).
-  `CacheManager.set` writes `timestamp` and `ttl` ahead of `data`, and
-  `DiskCache.get` reads the first 256 bytes to decide staleness, with the same
-  rules as before. A 53 MB MLB season file used to be parsed in full (about
-  1.8 s holding the GIL on a Pi 4, freezing the display) only to be thrown
-  away. Files in the old layout are parsed as before and convert when
-  rewritten.
-- Cache internals (#613): `CacheManager` delegates memory-tier cleanup and
-  stats to `MemoryCache`; `list_cache_files` no longer holds the memory lock
-  during directory I/O; `BackgroundDataService.get_sport_cache_key()` formats
-  the key instead of building a whole `CacheManager` (and probing the cache
-  directory) on every call; the unused request queue is gone, and `priority=`
-  is accepted and documented as ignored.
 
 ### Cache permissions
 
@@ -895,8 +491,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   timeouts with a second bash path, and all reinstalls share a 10-minute
   budget, so a rollback finishes inside the unit's 30-minute limit instead of
   being killed mid-way.
-- A hand-edited non-object `auto_update` value reads as off instead of raising at startup, and a failed result write no longer leaves a temp file behind.
-- Overview "Check Updates" asks for the same confirmation as "Update Code" and shows the server's message. Both, and the Tools tab's git pull, show the restart-pending banner when the update needs a restart.
 
 ### Installers
 
@@ -910,22 +504,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   `configure_web_sudo.sh` does the same before offering the rules for
   confirmation. `first_time_install.sh` also built that file at a fixed `/tmp`
   path as root; `mktemp` now picks the name.
-- `check_system_compatibility.sh` treats Python 3.13 (what Trixie ships) as supported and anything below 3.10 as an error.
-- `configure_web_sudo.sh` run as the web user keeps the reboot/poweroff rules.
-- `check_system_compatibility.sh` no longer reports installed packages as missing.
-- `configure_wifi_permissions.sh` checks its rules with `visudo -c` before installing them, and grants the NetworkManager captive-portal `cp` and `rm` commands `wifi_manager` runs.
-- `configure_web_sudo.sh` uses a random temp file and installs its rules with mode 440.
-- The installer prints its completion summary before the `-y` reboot, and describes the setup access point as an open network (it was shown with a password it doesn't have).
-- `fix_cache_permissions.sh` applies `setup_cache.sh`'s `ledmatrix`-group model instead of setting 777.
-- `check_system_compatibility.sh` reports anything but Debian 13 (Trixie) as unsupported, and reaches its summary.
-- `one-shot-install.sh`'s `retry()` retries (#606). It read `$?` after `!`,
-  which is always 0, so a failed command ran once and was reported as a
-  success. It now tries three times and returns the command's status; both
-  apt steps still warn and continue after their retries, and a clone that
-  keeps failing stops the install sooner, with its own message.
-- One generator for the web sudoers rules, `scripts/install/lib_sudoers.sh`,
-  used by `first_time_install.sh` and `configure_web_sudo.sh` (#622); the two
-  copies had drifted.
 
 ### Small fixes (update-all, plugin system settings, scripts)
 
@@ -963,9 +541,7 @@ core, the monorepo or the registry's third-party plugins calls them:
   (only an explicit `web_display_autostart: false` keeps the web interface
   down), so a missing key no longer shows as disabled. The shell scripts also
   check `web_interface/blueprints/api_v3/`, which became a package, instead of
-  reporting `api_v3.py` as missing. (`scripts/verify_web_ui.sh`,
-  `scripts/diagnose_web_ui.sh` and `scripts/debug/debug_web_manual.py` were
-  later deleted as unreferenced; see Docs and developer tools.)
+  reporting `api_v3.py` as missing.
 
 ### Docs and developer tools
 
@@ -994,67 +570,6 @@ core, the monorepo or the registry's third-party plugins calls them:
   `app.py` line numbers, `api_v3.py` paths, StreamManager method names,
   nonexistent version-bump scripts and `ledmatrix` service user references
   removed.
-- A mypy ratchet in CI. `mypy-clean.txt` lists the 71 modules under `src/` that type-check clean, and the new "Type check (mypy ratchet)" job runs `python scripts/check_types.py` (mypy 1.20.2 on exactly those files) so they stay clean; add a module when you make it clean (see CONTRIBUTING.md). The manual pre-commit `mypy` hook runs the same script. 35 modules were made clean for it with annotation-only fixes, no behaviour change. Their public signatures only widened (`declared_min_version()` now says it returns the manifest's value as-is, `Any`); `DynamicTeamResolver._rankings_cache` is annotated as the abbreviation-to-rank dict it holds. `mypy.ini` treats numpy and orjson as `Any`, so it parses with `python_version = 3.10` against numpy 2.3+ stubs and gives the same result whether orjson is installed or not.
-- CI runs the web UI's DOM test suites (jsdom against the real server-rendered pages and API) in a new **Web UI JS tests** job, with the web interface started in emulator mode; `REQUIRE_DOM=1` makes a suite that can't run fail instead of being skipped. Two suites that had gone stale were fixed: the Tools suite now installs `LEDEscape` the way `base.html` does and supplies sample Starlark apps when the server has none, and the Store suite no longer assumes the registry has 48 plugins or fewer.
-- CI installs `web_interface/requirements.txt` too, so flask-limiter, flask-compress and the web floors are tested. `test_api_helper_does_not_hand_set_brotli` now checks what it meant: core doesn't add `br` itself, and `requests` may advertise it when a brotli decoder is installed.
-- All Discord links point to the LEDMatrix server's invite.
-- `pytz` may be any release before 2027, so current timezone data installs; `requirements-test.txt` caps `psutil` below 7 like the runtime requirements and allows `pytest-cov` up to 7.x (checked against pytest 9 with the CI coverage run).
-- The Claude GitHub Actions workflows pin `anthropics/claude-code-action` to a commit SHA like the other actions.
-- `mypy.ini` parses again. A multi-line `exclude` and trailing comments on values made mypy refuse the whole file, so none of its settings applied and the pre-commit hook failed with "Missing target". The mypy hook is now manual (`pre-commit run mypy --hook-stage manual`) while the ~500 existing type errors in `src/` are paid down.
-- `.gitignore` ignores everything in `config/` except the templates; `ytm_auth.json`, `saved_repositories.json`, `wifi_status.json` and `font_overrides.json` weren't ignored.
-- `.sh` and `.service` files are always checked out with LF line endings.
-- The Claude code-review check is skipped on pull requests from forks, which get no secrets and always failed it.
-- Doc fixes: emulator guide (Python 3.10+, `emulator_config.json` isn't in the repo), README's nonexistent "API Metrics" feature, a stale route count, and missing index entries for the scroll-performance and offscreen-rendering docs and the frame-soak and render-bench scripts.
-- `src/common/README.md` lists `frame_timing`, `json_body` and `render_gate`.
-- New `scripts/README.md` lists every script.
-- New `docs/ARCHITECTURE.md` (processes, shared state, display loop, plugin system, web UI) and `docs/PERMISSIONS.md` (owners, modes, both sudoers files, repair scripts).
-- Deprecated plugin APIs are marked in the plugin docs.
-- `src/common/README.md` covers every module.
-- Stale setup, service and troubleshooting claims are corrected.
-- Deleted 13 scripts nothing referenced (#607): `utils/cleanup_venv.sh`,
-  `utils/clear_python_cache.sh`, `install/migrate_config.sh`,
-  `install/debug_install.sh`, `debug/debug_web_manual.py`,
-  `diagnose_web_ui.sh`, `verify_web_ui.sh`, `fix_internet_connectivity.sh`,
-  `diagnose_plugin_permissions.sh`, `dev/validate_python.py`,
-  `download_nba_logos.py` (with `README_NBA_LOGOS.md`) and
-  `setup_plugin_repos.py`, all under `scripts/`; also `docs/archive/` and
-  `PLUGIN_IMPLEMENTATION_SUMMARY.md`. `config.template.json` no longer carries
-  `plugin_system.auto_discover`, `auto_load_enabled` or `development_mode`,
-  which nothing reads (existing configs keep them). About 20 docs had stale
-  claims corrected against the code.
-- `test/test_js_unit_suites.py` runs every `test/js/unit/*.js` suite under
-  pytest; CI used to run one of the eight (#605).
-- New test `test/test_common_is_hardware_free.py`: `src/common` must import
-  without `rgbmatrix`, and never import `src.base_classes`,
-  `src.display_manager` or `src.plugin_system` at module level, so plugins can
-  use it on machines with no panel library.
-
-### Removed
-
-- **The skin system.** Skins never rendered with the current scoreboard
-  plugins, so they are gone rather than "not supported yet": `src/skin_system/`,
-  `skins/`, `scripts/validate_skin.py`, `GET /api/v3/skins`, the store's
-  `"type": "skin"` handling and `docs/SKIN_SYSTEM.md` / `docs/CREATING_SKINS.md`.
-  A `skin` or `skin_options` key left in a plugin's saved config still loads
-  and saves without a validation error; it is ignored, and the next save of
-  that plugin's settings removes it (unless the plugin's own schema declares
-  the key).
-- **`src/base_classes/`** (`SportsCore`, the sport and mode classes,
-  `CelebrationMixin`, the rotation strategies, `data_sources`,
-  `api_extractors`). No known plugin imports it. A plugin that does must use
-  `src.common` or its own copy of the code.
-- **Unused `src.common` modules and plugin-system helpers** (#608):
-  `src/common/config_helper.py`, `display_helper.py`, `game_helper.py`,
-  `utils.py` and `error_handler.py` (its re-exports leave `src.common`'s
-  `__all__`), `src/plugin_system/health_monitor.py` (`PluginHealthMonitor`,
-  whose loop did nothing; `PluginHealthTracker` is unchanged), and
-  `src.plugin_system.get_store_manager` / `__api_version__`. Nothing in core,
-  the scripts or the plugin monorepo imported them. `APIHelper`, `TextHelper`,
-  `ScrollHelper`, `LogoHelper` and the adaptive-layout exports of `src.common`
-  are unchanged. The same change removed unused methods from `ConfigService`,
-  `PluginStateManager`, `PluginManager`, `PluginExecutor`, `PluginLoader`,
-  `PluginStoreManager`, `VegasModeConfig` and `DisplayController`; none had
-  callers in core, the scripts or the monorepo.
 
 ## 3.4.0
 

CLAUDE.md

@@ -13,17 +13,14 @@
   loader does NOT fall back to it — `PluginManager.discover_plugins()`
   (`src/plugin_system/plugin_manager.py`) scans only the configured
   directory. Fallbacks exist in two narrower places: store operations
-  (`PluginStoreManager._find_plugin_path()` in `store_manager.py`, which
-  searches `store_search_dirs()` from `plugin_dirs.py`) and schema lookup
-  (`SchemaManager.get_schema_path()` in `schema_manager.py`, which probes
-  `plugins/` *before* `plugin-repos/`).
-- `src/plugin_system/plugin_dirs.py` — the one resolver for "which directory
-  holds plugin X" (manifest `id` first, then `<id>` / `ledmatrix-<id>`)
+  (`StoreManager._find_plugin_path()` in `store_manager.py`) and schema
+  lookup (`SchemaManager.get_schema_path()` in `schema_manager.py`,
+  which probes `plugins/` *before* `plugin-repos/`).
 
 ## Plugin System
 - Plugins inherit from `BasePlugin` in `src/plugin_system/base_plugin.py`
 - Required abstract methods: `update()`, `display(force_clear=False)`
-- Each plugin needs: `manifest.json`, `config_schema.json`, and the entry point (`manager.py` by default); `requirements.txt` if it has dependencies. Required manifest fields: `docs/PLUGIN_API_REFERENCE.md#manifest-required-fields`
+- Each plugin needs: `manifest.json`, `config_schema.json`, `manager.py`, `requirements.txt`
 - Plugin instantiation args: `plugin_id, config, display_manager, cache_manager, plugin_manager`
 - Config schemas use JSON Schema Draft-7
 - Display dimensions: always read dynamically from `self.display_manager.width/height` — not `display_manager.matrix.width/height`, because `matrix` is `None` when hardware init fails (the properties fall back to the canvas size)
@@ -37,20 +34,19 @@
 - Browser preview without the display loop: `python3 scripts/dev_server.py` → http://localhost:5001
 - Full display in emulator mode: `python3 run.py -e` (or `EMULATOR=true python3 run.py`)
 - Validate one plugin headlessly: `python3 scripts/check_plugin.py --plugin <id>`
-- Soak a rig for frame timing (on the Pi, service running): `python3 scripts/frame_soak.py --preview` — late-frame rate across every scroller; see `docs/SCROLL_PERFORMANCE.md`
 
 ## Plugin Store Architecture
 - Official plugins live in the `ledmatrix-plugins` monorepo (not individual repos)
 - Plugin repo naming convention: `ledmatrix-<plugin-id>` (e.g., `ledmatrix-football-scoreboard`)
 - `plugins.json` registry at `https://raw.githubusercontent.com/ChuckBuilds/ledmatrix-plugins/main/plugins.json`
-- Store manager (`PluginStoreManager` in `src/plugin_system/store_manager.py`) handles install/update/uninstall
-- Monorepo plugins are installed without a `.git` directory: GitHub Trees API + raw downloads, falling back to ZIP extraction
+- Store manager (`src/plugin_system/store_manager.py`) handles install/update/uninstall
+- Monorepo plugins are installed via ZIP extraction (no `.git` directory)
 - Update detection for monorepo plugins uses version comparison (manifest version vs registry latest_version)
 - Plugin configs stored in `config/config.json`, NOT in plugin directories — safe across reinstalls
 - Third-party plugins can use their own repo URL with empty `plugin_path`
 
 ## Common Pitfalls
-- paho-mqtt 2.x requires a `CallbackAPIVersion` argument: `VERSION1` for code written against v1 callback signatures (the MQTT bridge uses `VERSION2`)
+- paho-mqtt 2.x needs `callback_api_version=mqtt.CallbackAPIVersion.VERSION1` for v1 compat
 - BasePlugin uses `get_logger()` from `src.logging_config`, not standard `logging.getLogger()`
 - `DisplayManager` has no `draw_image()` — paste onto the PIL image directly:
   `self.display_manager.image.paste(img, (x, y))` then `update_display()`

CODE_OF_CONDUCT.md

@@ -63,7 +63,7 @@ ChuckBuilds, and any other forums hosted by or affiliated with the project.
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
 reported to the community leaders responsible for enforcement on the
-[LEDMatrix Discord](https://discord.gg/RdrC37rEag) (DM a moderator or
+[LEDMatrix Discord](https://discord.gg/uW36dVAtcT) (DM a moderator or
 ChuckBuilds directly) or by opening a private GitHub Security Advisory if
 the issue involves account safety. All complaints will be reviewed and
 investigated promptly and fairly.

CONTRIBUTING.md

@@ -9,7 +9,7 @@ improvements, and code changes.
 - **Bugs / feature requests**: open an issue using one of the templates
   in [`.github/ISSUE_TEMPLATE/`](.github/ISSUE_TEMPLATE/).
 - **Real-time discussion**: the
-  [LEDMatrix Discord](https://discord.gg/RdrC37rEag).
+  [LEDMatrix Discord](https://discord.gg/uW36dVAtcT).
 - **Plugin development**:
   [`docs/PLUGIN_DEVELOPMENT_GUIDE.md`](docs/PLUGIN_DEVELOPMENT_GUIDE.md)
   and the [`ledmatrix-plugins`](https://github.com/ChuckBuilds/ledmatrix-plugins)
@@ -58,18 +58,10 @@ integration tests.
 3. **Keep PRs focused.** One conceptual change per PR. If you find
    adjacent bugs while working, fix them in a separate PR.
 4. **Follow the existing code style.** The pre-commit hooks run
-   `flake8` (E9, F63, F7, F82 plus bugbear `B` checks), `bandit`,
-   and `gitleaks` — install the CLI with
+   `flake8` (E9, F63, F7, F82 plus bugbear `B` checks), `mypy` on
+   `src/`, `bandit`, and `gitleaks` — install the CLI with
    `python -m pip install pre-commit`, then run
-   `pre-commit install` so they run on every commit. Type checking
-   is a ratchet while the existing mypy errors in `src/` are paid
-   down: `mypy-clean.txt` lists the modules that type-check clean, and
-   CI runs `python scripts/check_types.py` (also the manual hook
-   `pre-commit run mypy --hook-stage manual`) to keep every listed
-   module clean. When you make another module clean, add it to the
-   list (sorted); don't take one off to get CI green. Keep type fixes
-   annotation-only where you can -- widen a hint rather than delete a
-   defensive runtime check mypy calls unreachable. HTML/JS in
+   `pre-commit install` so they run on every commit; HTML/JS in
    `web_interface/` follows the patterns already in `templates/v3/`
    and `static/v3/`.
 5. **Update documentation** alongside code changes. If you add a

README.md

@@ -33,7 +33,7 @@ I'm trying to be open to constructive criticism and support, as long as it's a r
 - Show support on Youtube: https://www.youtube.com/@ChuckBuilds
 - Check out the write-up on my website: https://www.chuck-builds.com/led-matrix/
 - Stay in touch on Instagram: https://www.instagram.com/ChuckBuilds/
-- Want to chat? Reach out on the LEDMatrix Discord: [https://discord.gg/RdrC37rEag](https://discord.gg/RdrC37rEag)
+- Want to chat? Reach out on the LEDMatrix Discord: [https://discord.com/invite/uW36dVAtcT](https://discord.gg/dfFwsasa6W)
 - Feeling Generous? Consider sponsoring this project or sending a donation (these AI credits aren't cheap!)          
 
 -----------------------------------------------------------------------------------
@@ -328,7 +328,6 @@ This one-shot installer will automatically:
 - Install required system packages (git, python3, build tools, etc.)
 - Clone or update the LEDMatrix repository
 - Run the complete first-time installation script
-- Print the web interface address, then **reboot the Pi automatically** (your SSH session will disconnect; give it a few minutes to come back)
 
 The installation process typically takes 10-30 minutes depending on your internet connection and Pi model. Pi 3B/3B+ and other 1GB boards land at the top of that range, because the C++ library is compiled serially to stay within available memory. All errors are reported explicitly with actionable fixes.
 
@@ -690,10 +689,9 @@ Controls how long each installed plugin stays visible in seconds before switchin
 ### Display Format Settings
 
 - **`use_short_date_format`** (boolean, default: true)
-  - Currently has no effect. The web UI still saves it, but no core code
-    reads it. Scoreboard plugins that offer a short date format read the
-    setting from their own plugin config instead. See
-    [CONFIG_REFERENCE.md](docs/CONFIG_REFERENCE.md#display--other-keys).
+  - Use short date format (e.g., "Jan 15") instead of long format (e.g., "January 15th")
+  - Set to `false` for longer, more readable dates
+  - Set to `true` to save space and show more information
 
 ### Dynamic Duration Settings (`display.dynamic_duration`)
 
@@ -781,21 +779,15 @@ Controls how long each installed plugin stays visible in seconds before switchin
 <details>
 <summary>Manual SSH Commands (for reference)</summary>
 
-The web interface's quick actions (Start/Stop/Restart Display) call
-`sudo systemctl start|stop|restart ledmatrix.service` — see
-`execute_system_action()` in
-[`web_interface/blueprints/api_v3/system.py`](web_interface/blueprints/api_v3/system.py).
-The service runs [`run.py`](run.py) as root.
+The quick actions essentially just execute the following commands on the Pi.
 
-To run the display in the foreground instead (for debugging), stop the service
-first, then from the project root (e.g. `/home/ledpi/LEDMatrix`):
+From the project root directory (ex: /home/ledpi/LEDMatrix):
 
 ```bash
-sudo systemctl stop ledmatrix.service
-sudo python3 run.py          # add -d for debug logging
+sudo python3 display_controller.py
 ```
 
-This only runs as long as your SSH session stays open.
+This will start the display cycle but only stays active as long as your ssh session is active.
 
 ### Convenience Scripts
 
@@ -948,7 +940,7 @@ sudo systemctl enable ledmatrix-web.service
 - **On-Demand Controls**: Start specific displays (weather, stocks, sports) on demand
 - **Service Management**: Start/stop the main display service
 - **System Controls**: Restart, update code, and manage the system
-- **System Stats**: CPU, memory and temperature on the Overview tab
+- **API Metrics**: Monitor API usage and system performance
 - **Logs**: View system logs in real-time
 
 ### Troubleshooting Web Interface
@@ -965,10 +957,9 @@ sudo systemctl enable ledmatrix-web.service
 3. Check if another service is using port 5000
 
 **Service Fails to Start:**
-1. Check Python dependencies are installed. The installer puts them in the
-   system Python with `pip install --break-system-packages` (there is no
-   virtual environment), so `python3 -c "import flask"` should succeed.
-2. Check file permissions and ownership
+1. Check Python dependencies are installed
+2. Verify the virtual environment is set up correctly
+3. Check file permissions and ownership
 
 </details>
 

SECURITY.md

@@ -16,7 +16,7 @@ Use one of these channels, in order of preference:
    maintainer.
    - Direct link: <https://github.com/ChuckBuilds/LEDMatrix/security/advisories/new>
 2. **Discord DM**. Send a direct message to a moderator on the
-   [LEDMatrix Discord](https://discord.gg/RdrC37rEag). Don't post in
+   [LEDMatrix Discord](https://discord.gg/uW36dVAtcT). Don't post in
    public channels.
 
 Please include:

display_controller.py

@@ -1,20 +1,12 @@
 #!/usr/bin/env python3
-"""Legacy entry point: runs ``run.py``, which is the one to use.
-
-``python3 run.py`` (``-e`` for the emulator, ``-d`` for debug logging) is how
-the display service and the docs start LEDMatrix. This file used to import
-``src.display_controller.main`` directly, which skipped what run.py sets up
-first -- ``sys.dont_write_bytecode`` (root-owned ``__pycache__`` in plugin
-directories blocks the web service from updating them), the ``-e``/``-d``
-flags, and the logging configuration. It now runs run.py exactly as
-``python3 run.py`` would, with the same arguments.
-"""
 
 import os
-import runpy
+import sys
+
+# Add the project root directory to Python path
+sys.path.append(os.path.dirname(os.path.abspath(__file__)))
+
+from src.display_controller import main
 
 if __name__ == "__main__":
-    runpy.run_path(
-        os.path.join(os.path.dirname(os.path.abspath(__file__)), "run.py"),
-        run_name="__main__",
-    )
+    main() 

docs/ADVANCED_FEATURES.md

@@ -185,52 +185,62 @@ their config section to control how oversized content is handled (see
 
 ### Plugin Integration (Developer Guide)
 
-All of these have defaults in
-[`BasePlugin`](../src/plugin_system/base_plugin.py); override only what you
-need.
-
 **1. Implement Content Method:**
 
 ```python
 def get_vegas_content(self):
-    # Return a PIL Image, a list of Images, or None.
-    # A single image is one block; a list becomes one item per image.
-    return [self._render_game(game) for game in self.games]
-```
+    """
+    Return PIL Image or list of Images for Vegas mode.
 
-If it returns `None` (the default), Vegas falls back to the plugin's
-`scroll_helper` image, then to capturing `display()` output
-(`PluginAdapter.get_content()` in
-[`src/vegas_mode/plugin_adapter.py`](../src/vegas_mode/plugin_adapter.py)).
+    Returns:
+        PIL.Image or list[PIL.Image]: Content to display
+        - Single image: fixed-width content
+        - List of images: multiple segments
+        - None: skip this cycle
+    """
+    # Example: Return single wide image
+    img = Image.new('RGB', (256, 32))
+    # ... render your content ...
+    return img
+
+    # Example: Return multiple segments
+    return [image1, image2, image3]
+```
 
 **2. Specify Content Type:**
 
 ```python
 def get_vegas_content_type(self):
-    # 'multi' | 'static' | 'none'  -- default is 'static'
-    return 'multi'
-```
+    """
+    Specify how content should be handled.
 
-`'none'` excludes the plugin from Vegas mode.
+    Returns:
+        str: 'multi' | 'static' | 'none'
+    """
+    return 'multi'  # Default for most plugins
+```
 
 **3. Optionally Specify Display Mode:**
 
-These return `VegasDisplayMode` members, not strings:
-
 ```python
-from src.plugin_system.base_plugin import VegasDisplayMode
-
 def get_vegas_display_mode(self):
-    return VegasDisplayMode.SCROLL
+    """
+    Preferred display mode for this plugin.
+
+    Returns:
+        str: 'scroll' | 'fixed' | 'static'
+    """
+    return 'scroll'
 
 def get_supported_vegas_modes(self):
-    return [VegasDisplayMode.SCROLL, VegasDisplayMode.STATIC]
-```
+    """
+    List of supported modes.
 
-`VegasDisplayMode` has `SCROLL` (`"scroll"`), `FIXED_SEGMENT` (`"fixed"`) and
-`STATIC` (`"static"`). The default `get_vegas_display_mode()` uses the
-plugin's `vegas_mode` config value if set, otherwise maps the content type
-(`multi` to `SCROLL`, anything else to `FIXED_SEGMENT`).
+    Returns:
+        list: ['scroll', 'fixed', 'static']
+    """
+    return ['scroll', 'static']
+```
 
 ### Content Rendering Guidelines
 
@@ -956,16 +966,11 @@ from src.cache_manager import CacheManager
 
 service = get_background_service(CacheManager())
 stats = service.get_statistics()
-print(f"Active: {stats['active_requests']}")
-print(f"Completed: {stats['completed_requests']}")
-print(f"Failed: {stats['failed_requests']}")
+print(f"Active tasks: {stats['active_tasks']}")
+print(f"Completed: {stats['completed']}")
+print(f"Failed: {stats['failed']}")
 ```
 
-Other keys: `total_requests`, `cached_hits`, `cache_misses`,
-`average_fetch_time`, `completed_requests_count` (results currently held in
-memory) — see `BackgroundDataService.get_statistics()` in
-[`src/background_data_service.py`](../src/background_data_service.py).
-
 **Enable Debug Logging:**
 ```python
 import logging
@@ -976,10 +981,6 @@ logging.getLogger('src.background_data_service').setLevel(logging.DEBUG)
 
 ## 5. Permission Management
 
-Ownership, modes, sudo rules and the repair scripts are listed in
-[PERMISSIONS.md](PERMISSIONS.md). This section covers the helpers code uses
-to keep files shareable.
-
 ### Overview
 
 LEDMatrix uses a dual-user architecture: the display service runs as root (hardware access), while the web interface runs as a non-privileged user. Centralized permission management ensures both can access necessary files.
@@ -1043,7 +1044,7 @@ ensure_file_permissions(config_path, get_config_file_mode(config_path))
 | Config (secrets) | `rw-r-----` | `0o640` | Owner write, group read |
 | Assets | `rw-rw-r--` | `0o664` | Owner/group write, all read |
 | Plugins | `rw-rw-r--` | `0o664` | Owner/group write, all read |
-| Cache files | `rw-rw----` | `0o660` | Owner/group write, no world access (`_CACHE_FILE_MODE` in `src/cache/disk_cache.py`) |
+| Cache files | `rw-rw-r--` | `0o664` | Owner/group write, all read |
 
 **Directory Permissions:**
 
@@ -1114,22 +1115,40 @@ These core utilities **already handle permissions** - you don't need to call per
 
 ### Manual Fixes
 
-[PERMISSIONS.md](PERMISSIONS.md) lists who owns what on an installed system,
-the expected modes, and which `scripts/fix_perms/` script to run as which
-user. In short:
+If you encounter permission issues:
 
-- `fix_assets_permissions.sh`, `fix_cache_permissions.sh` and
-  `fix_plugin_permissions.sh` are run with `sudo`.
-- `fix_web_permissions.sh` is run as the web interface user, without
-  `sudo` (it refuses to run as root and calls `sudo` itself where needed).
-  It resets project file ownership for that user, then makes the two
-  helper scripts the web user may run as root (`safe_plugin_rm.sh`,
-  `safe_pip_install.sh`) root-owned again and restores `config_secrets.json`
-  to its owner, the `ledmatrix` group and mode `640`. It does not write
-  sudoers rules; `scripts/install/configure_web_sudo.sh` does that.
+```bash
+# Targeted permission fixes (see scripts/fix_perms/README.md)
+sudo ./scripts/fix_perms/fix_assets_permissions.sh   # assets/ tree (logos, fonts)
+sudo ./scripts/fix_perms/fix_cache_permissions.sh    # all cache directories
+sudo ./scripts/fix_perms/fix_plugin_permissions.sh   # plugin directories
+sudo ./scripts/fix_perms/fix_web_permissions.sh      # web interface files
 
-Do not `chmod` the whole `config/` directory: `config_secrets.json` must stay
-`640`.
+# Fix specific directory
+sudo chown -R ledpi:ledpi /home/ledpi/LEDMatrix/config
+sudo chmod -R 2775 /home/ledpi/LEDMatrix/config
+sudo find /home/ledpi/LEDMatrix/config -type f -exec chmod 664 {} \;
+
+# Verify permissions
+ls -la config/
+ls -la assets/
+```
+
+### Verification
+
+```bash
+# Check directory has setgid bit
+ls -ld assets/
+# Should show: drwxrwsr-x (note the 's')
+
+# Check file has correct group
+ls -l assets/logo.png
+# Should show group 'ledpi'
+
+# Check file permissions
+stat -c "%a %n" config/config.json
+# Should show: 644 config/config.json
+```
 
 ---
 

docs/ADVANCED_PLUGIN_DEVELOPMENT.md

@@ -13,7 +13,7 @@ Advanced patterns, examples, and best practices for developing LEDMatrix plugins
 - [Using Weather Icons](#using-weather-icons)
 - [Implementing Scrolling with Deferred Updates](#implementing-scrolling-with-deferred-updates)
 - [Cache Strategy Patterns](#cache-strategy-patterns)
-- [Font Management](#font-management)
+- [Font Management and Overrides](#font-management-and-overrides)
 - [Error Handling Best Practices](#error-handling-best-practices)
 - [Performance Optimization](#performance-optimization)
 - [Testing Plugins with Mocks](#testing-plugins-with-mocks)
@@ -25,12 +25,69 @@ Advanced patterns, examples, and best practices for developing LEDMatrix plugins
 
 ## Using Weather Icons
 
-The Display Manager's icon methods — `draw_weather_icon()`, `draw_sun()`,
-`draw_cloud()`, `draw_rain()`, `draw_snow()` and `draw_text_with_icons()` —
-are deprecated, removed in 3.7.0. Draw your own icons instead: render them
-onto a PIL image and paste it onto `self.display_manager.image`, or ship
-icon images with the plugin. The weather plugin's `WeatherIcons` class is an
-example. See [Deprecated APIs](PLUGIN_API_REFERENCE.md#deprecated-apis).
+The Display Manager provides built-in weather icon drawing methods for easy visual representation of weather conditions.
+
+### Basic Weather Icon Usage
+
+```python
+def display(self, force_clear=False):
+    if force_clear:
+        self.display_manager.clear()
+    
+    # Draw weather icon based on condition
+    condition = self.data.get('condition', 'clear')
+    self.display_manager.draw_weather_icon(condition, x=5, y=5, size=16)
+    
+    # Draw temperature next to icon
+    temp = self.data.get('temp', 72)
+    self.display_manager.draw_text(
+        f"{temp}°F",
+        x=25, y=10,
+        color=(255, 255, 255)
+    )
+    
+    self.display_manager.update_display()
+```
+
+### Supported Weather Conditions
+
+The `draw_weather_icon()` method automatically maps condition strings to appropriate icons:
+
+- `"clear"`, `"sunny"` → Sun icon
+- `"clouds"`, `"cloudy"`, `"partly cloudy"` → Cloud icon
+- `"rain"`, `"drizzle"`, `"shower"` → Rain icon
+- `"snow"`, `"sleet"`, `"hail"` → Snow icon
+- `"thunderstorm"`, `"storm"` → Storm icon
+
+### Custom Weather Icons
+
+For more control, use individual icon methods:
+
+```python
+# Draw specific icons
+self.display_manager.draw_sun(x=10, y=10, size=16)
+self.display_manager.draw_cloud(x=10, y=10, size=16, color=(150, 150, 150))
+self.display_manager.draw_rain(x=10, y=10, size=16)
+self.display_manager.draw_snow(x=10, y=10, size=16)
+```
+
+### Text with Weather Icons
+
+Use `draw_text_with_icons()` to combine text and icons:
+
+```python
+icons = [
+    ("sun", 5, 5),      # Sun icon at (5, 5)
+    ("cloud", 100, 5)   # Cloud icon at (100, 5)
+]
+
+self.display_manager.draw_text_with_icons(
+    "Weather: Sunny, Cloudy",
+    icons=icons,
+    x=10, y=20,
+    color=(255, 255, 255)
+)
+```
 
 ---
 
@@ -194,8 +251,11 @@ def update(self):
     sport_key = "nhl"
     cache_key = f"{self.plugin_id}_{sport_key}_games"
     
-    # get_background_cached_data() is deprecated, removed in 3.7.0 — use get()
-    cached = self.cache_manager.get(cache_key, max_age=60)
+    # Uses sport-specific live_update_interval from config
+    cached = self.cache_manager.get_background_cached_data(
+        cache_key,
+        sport_key=sport_key
+    )
     
     if cached:
         self.games = cached
@@ -222,9 +282,9 @@ def on_config_change(self, new_config):
 
 ---
 
-## Font Management
+## Font Management and Overrides
 
-The display manager's built-in fonts and text measurement. For fonts shipped with a plugin, see [FONT_MANAGER.md](FONT_MANAGER.md).
+Use the Font Manager for advanced font handling and user customization.
 
 ### Using Different Fonts
 
@@ -596,12 +656,14 @@ def update(self):
 
 ```python
 def update(self):
-    # get_enabled_plugins() is deprecated, removed in 3.7.0 — check the
-    # instance's `enabled` flag instead
-    weather_plugin = self.plugin_manager.get_plugin("weather")
-    if weather_plugin is not None and weather_plugin.enabled:
-        # Use weather data
-        pass
+    # Check if another plugin is enabled
+    enabled_plugins = self.plugin_manager.get_enabled_plugins()
+    if "weather" in enabled_plugins:
+        # Weather plugin is available
+        weather_plugin = self.plugin_manager.get_plugin("weather")
+        if weather_plugin:
+            # Use weather data
+            pass
 ```
 
 ### Sharing Data Between Plugins

docs/ARCHITECTURE.md

@@ -1,226 +0,0 @@
-# Architecture
-
-A map of the codebase for a new contributor: which process does what, how
-they talk to each other, and where to start reading for common changes.
-
-## Processes
-
-| systemd unit | Runs as | Runs | Installed by |
-|---|---|---|---|
-| `ledmatrix.service` | root | [`run.py`](../run.py) → `DisplayController` | [`install_service.sh`](../scripts/install/install_service.sh) |
-| `ledmatrix-web.service` | the installing user | [`start_web_conditionally.py`](../scripts/utils/start_web_conditionally.py) → [`web_interface/start.py`](../web_interface/start.py) (Flask, port 5000) | `install_service.sh`, [`install_web_service.sh`](../scripts/install/install_web_service.sh) |
-| `ledmatrix-update-verify.path` / `.service` | the web user | Health check after an automatic update | the same installers, or [`src/auto_update_setup.py`](../src/auto_update_setup.py) at runtime |
-| `ledmatrix-wifi-monitor.service` | root | [`wifi_monitor_daemon.py`](../scripts/utils/wifi_monitor_daemon.py) | [`install_wifi_monitor.sh`](../scripts/install/install_wifi_monitor.sh) |
-| `ledmatrix-mqtt-bridge.service` | root | [MQTT bridge](../integrations/mqtt_bridge/README.md) (optional) | [`install_mqtt_bridge.sh`](../scripts/install/install_mqtt_bridge.sh) |
-| `ledmatrix-dns-fix.service` | root | DNS workaround (optional) | [`install_dns_fix.sh`](../scripts/install/install_dns_fix.sh) |
-
-Unit templates are in [`systemd/`](../systemd/README.md). The display runs as
-root because the LED matrix library needs direct GPIO access. The web
-interface runs unprivileged and uses a fixed list of `sudo` rules for the
-few privileged things it does; see [PERMISSIONS.md](PERMISSIONS.md).
-
-`start_web_conditionally.py` exits without starting Flask when
-`web_display_autostart` is explicitly false in `config.json`.
-
-## How the two main processes share state
-
-The display and the web interface are separate processes that never call
-each other. They share three things:
-
-1. **`config/config.json` and `config/config_secrets.json`.** The web
-   interface writes them through `ConfigManager`
-   ([`src/config_manager.py`](../src/config_manager.py)); the display
-   notices through `ConfigService` (below).
-2. **The disk cache**, `/var/cache/ledmatrix` (owned `root:ledmatrix`,
-   setgid, files `0660`), read and written through `CacheManager`
-   ([`src/cache_manager.py`](../src/cache_manager.py),
-   [`src/cache/disk_cache.py`](../src/cache/disk_cache.py)). Readers in the
-   other process pass `memory_ttl=0` so they do not serve a stale in-memory
-   copy.
-3. **A few files in `/tmp`.**
-
-| State | Where | Written by | Read by |
-|---|---|---|---|
-| On-demand request | cache `display_on_demand_request` | web: `start_on_demand_display()` / `stop_on_demand_display()` in [`api_v3/display.py`](../web_interface/blueprints/api_v3/display.py) | display: `_poll_on_demand_requests()` |
-| On-demand state | cache `display_on_demand_state` | display: `_publish_on_demand_state()` | web: `/api/v3/display/on-demand/status` |
-| Current screen | cache `display_current_state` | display | web: `/api/v3/display/current-status` |
-| Plugin errors | cache `plugin_error_snapshot` | display: `ErrorSnapshotPublisher` ([`src/error_aggregator.py`](../src/error_aggregator.py)) | web: `read_error_report()` for `/api/v3/errors/*` |
-| Error clear | cache `plugin_error_clear_request` | web | display |
-| Font usage | cache `font_usage_snapshot` | display: `FontUsagePublisher` ([`src/font_usage.py`](../src/font_usage.py)) | web: Fonts tab |
-| Plugin health | cache `plugin_health:<id>` | display (web writes on reset) | web: `/api/v3/plugins/health` |
-| Preview frame | `/tmp/led_matrix_preview.png` | display: `DisplayManager`, gated by [`snapshot_policy`](../src/common/snapshot_policy.py) | web: display SSE stream, `/api/v3/health` (file age) |
-| Preview viewer marker | `/tmp/led_matrix_preview_viewer` | web, while a preview is open | display: writes full-rate snapshots only while it is fresh |
-| Hardware init status | `/tmp/led_matrix_hw_status.json` | display | web: `/api/v3/hardware/status` |
-
-The on-demand start route starts `ledmatrix.service` when it is not running
-(`start_service`, on by default) but never restarts a running one: the display
-reads the mailbox every `ON_DEMAND_POLL_INTERVAL` (0.25s), from its dwell
-sleep, its render loops and Vegas's interrupt check as well as the main loop.
-
-## Display loop
-
-[`src/display_controller.py`](../src/display_controller.py), class
-`DisplayController`. `__init__` loads config, starts the cache and the
-error-snapshot publisher, runs the startup validator, creates the
-`DisplayManager` ([`src/display_manager.py`](../src/display_manager.py)),
-`FontManager` and `PluginManager`, loads the enabled plugins in parallel,
-runs an initial `update()` pass within a 20-second budget
-(`_INITIAL_UPDATE_BUDGET_SECONDS`; a plugin that misses it is deferred to
-the scheduler), and sets up Vegas mode.
-
-`run()` is the main loop. Each pass, in order: apply a pending plugin
-enable/disable, poll on-demand requests, run scheduled plugin updates, check
-the on/off schedule and brightness, then show one screen. Priority is
-on-demand, then WiFi status messages, then live priority, then Vegas mode,
-then normal rotation.
-
-- **Rotation.** `available_modes` is the ordered list of display modes;
-  `current_mode_index` advances after each screen.
-  `_apply_plugin_rotation_order()` applies `display.plugin_rotation_order`.
-- **Durations.** `_get_display_duration()`: `display.display_durations[mode]`,
-  else the plugin's `get_display_duration()`, else 30 s. Plugins that
-  support dynamic duration run until `is_cycle_complete()`, capped by
-  `display.dynamic_duration.max_duration_seconds` (default 180 s).
-- **On-demand.** A request from the web interface pins one plugin (or mode)
-  for a duration. `_activate_on_demand()` / `_clear_on_demand()`; the
-  session is saved under `display_on_demand_config` so it survives a
-  restart. It also keeps the display on during scheduled off hours. A
-  request for a plugin that is disabled in config loads it live
-  (`_load_plugin_for_on_demand()`, `load_plugin(force_enabled=True)`)
-  without writing `config.json`; the main loop unloads it once on-demand
-  moves off it (`_release_on_demand_plugins()`).
-- **Live priority.** `_check_live_priority()` looks for a plugin whose
-  `has_live_priority()` and `has_live_content()` are both true and switches
-  to it, rotating between several live games.
-- **Schedule and dim schedule.** `_check_schedule()` reads `schedule`;
-  `_check_dim_schedule()` reads `dim_schedule` and
-  `display.hardware.brightness`. Both are re-evaluated once a minute.
-- **Long screens.** While a screen is showing (a dwell, a scroll, a Vegas
-  iteration), `_service_pending_changes()` repeats the on-demand, schedule
-  and brightness checks every 0.25 s, so a change does not wait for the
-  screen to end.
-- **Config hot reload.** `ConfigService`
-  ([`src/config_service.py`](../src/config_service.py)) polls the config and
-  secrets files' mtimes every 2 s and notifies subscribers when the content
-  changes. The controller refreshes its cached settings; enabling or
-  disabling a plugin queues `_reconcile_enabled_plugins()`, which loads or
-  unloads it on the display thread; each plugin gets `on_config_change()`
-  for its own section. Set `LEDMATRIX_HOT_RELOAD=false` to turn this off.
-  Matrix hardware settings are only read at start-up.
-- **Vegas mode.** [`src/vegas_mode/`](../src/vegas_mode/): the display loop
-  calls `VegasModeCoordinator.run_iteration()`
-  ([`coordinator.py`](../src/vegas_mode/coordinator.py)) when
-  `display.vegas_scroll.enabled` is set. `PluginAdapter` gets each plugin's
-  content (`get_vegas_content()`, else its `scroll_helper` image, else a
-  capture of `display()`), `StreamManager` orders it and `RenderPipeline`
-  scrolls it. See [ADVANCED_FEATURES.md](ADVANCED_FEATURES.md).
-- **Multi-display sync.** `DisplaySyncManager`
-  ([`src/common/sync_manager.py`](../src/common/sync_manager.py)), enabled by
-  `sync.role`: a leader sends a follower its share of each frame over UDP
-  (port 5765).
-
-## Plugin system
-
-[`src/plugin_system/`](../src/plugin_system/):
-
-| Area | Where |
-|---|---|
-| Base class plugins implement | [`base_plugin.py`](../src/plugin_system/base_plugin.py) (`BasePlugin`, `VegasDisplayMode`) |
-| Finding a plugin's directory | [`plugin_dirs.py`](../src/plugin_system/plugin_dirs.py): manifest `id` first, then directory `<id>` or `ledmatrix-<id>` |
-| Discovery, load, unload, scheduled updates | [`plugin_manager.py`](../src/plugin_system/plugin_manager.py) (`PluginManager`) |
-| Import and instantiate | [`plugin_loader.py`](../src/plugin_system/plugin_loader.py) (`PluginLoader.load_plugin()`: dependencies, module, class) |
-| Timeouts | [`plugin_executor.py`](../src/plugin_system/plugin_executor.py) (`PluginExecutor`, 30 s default; a timed-out thread is abandoned, not killed) |
-| Circuit breaker | [`plugin_health.py`](../src/plugin_system/plugin_health.py) (`PluginHealthTracker`: 3 consecutive failures open the circuit for 300 s) |
-| Resource metrics | [`resource_monitor.py`](../src/plugin_system/resource_monitor.py) |
-| Config schemas and defaults | [`schema_manager.py`](../src/plugin_system/schema_manager.py) |
-| Install, update, uninstall | [`store_manager.py`](../src/plugin_system/store_manager.py) (`PluginStoreManager`), with its methods split across [`store_registry.py`](../src/plugin_system/store_registry.py) (registry, GitHub), [`store_install.py`](../src/plugin_system/store_install.py) and [`store_update.py`](../src/plugin_system/store_update.py) |
-| Core-version gate | [`compatibility.py`](../src/plugin_system/compatibility.py) |
-
-Discovery scans only `plugin_system.plugins_directory` (default
-`plugin-repos/`). Scheduled `update()` calls run on one background worker
-thread; a per-plugin lock keeps `display()` from running during an update.
-
-**Store flow.** `install_plugin()` renames any existing copy aside
-(`<id>.standalone-backup-preinstall`), installs the new one, and puts the old
-copy back if the install fails. Monorepo plugins come from the GitHub Trees
-API, falling back to the repository ZIP; other plugins by `git clone` or
-download. The manifest is checked (see
-[required fields](PLUGIN_API_REFERENCE.md#manifest-required-fields)), the core
-version gate runs, then dependencies are installed as root through
-`scripts/fix_perms/safe_pip_install.sh`. `update_plugin()` pulls git
-installs, undoing a pull whose new version is incompatible, and reinstalls
-everything else through `_reinstall_with_rollback()`.
-
-## Web interface
-
-- **App.** [`web_interface/app.py`](../web_interface/app.py) builds the
-  Flask `app` at import time, creates the managers, and registers two
-  blueprints. `web_interface/start.py` runs it on port 5000.
-- **Pages.** [`blueprints/pages_v3.py`](../web_interface/blueprints/pages_v3.py)
-  serves the shell `templates/v3/base.html` at `/` and each tab as a
-  partial at `/partials/<name>` (templates in
-  `web_interface/templates/v3/partials/`). Plugin configuration tabs are
-  rendered from the plugin's schema by `plugin_config.html`.
-- **API.** [`blueprints/api_v3/`](../web_interface/blueprints/api_v3/) is one
-  blueprint at `/api/v3`, split by area: `backup.py`, `config.py`,
-  `display.py`, `fonts.py`, `misc.py` (health, logs, errors, cache, sync),
-  `starlark.py`, `system.py` (service actions, updates, git), `wifi.py`, and
-  the plugin routes: `plugins.py` (installed list, enable/disable, plugin
-  actions), `plugin_store.py` (install, update, uninstall, store),
-  `plugin_config.py` (config, schema, reset), `plugin_assets.py` (uploads,
-  plugin static files), `plugin_health.py` (health, metrics, limits),
-  `plugin_operations.py` (operation history, state reconciliation) and
-  `plugin_calendar.py`. `__init__.py` defines the blueprint and shared helpers and
-  imports the modules so their routes register. Endpoints are listed in
-  [REST_API_REFERENCE.md](REST_API_REFERENCE.md).
-- **Front end.** HTMX loads each tab's partial on first open
-  (`hx-trigger="loadtab"`); Alpine.js holds page state. Scripts are in
-  `web_interface/static/v3/js/`; form widgets are bundled from
-  [`js/widgets/`](../web_interface/static/v3/js/widgets/README.md).
-- **Server-sent events** (`app.py`): `/api/v3/stream/stats` (CPU, memory,
-  temperature, service state, every 10 s), `/api/v3/stream/display` (preview
-  frames when the PNG changes) and `/api/v3/stream/logs` (journal of both
-  services). One generator thread per stream is shared by all clients.
-
-## Updates
-
-- **Update Code** on the Overview tab and the automatic updater both call
-  `perform_core_update()` in
-  [`api_v3/system.py`](../web_interface/blueprints/api_v3/system.py):
-  `git pull --rebase`, reinstall changed requirement files, report whether a
-  restart is needed.
-- **Automatic updates** (`auto_update.enabled`, off by default):
-  `AutoUpdater` in [`web_interface/auto_update.py`](../web_interface/auto_update.py)
-  runs in the web process, checks every 30 minutes, and updates at most
-  weekly between 02:00 and 05:00. Before pulling it copies
-  [`scripts/utils/auto_update_verify.py`](../scripts/utils/auto_update_verify.py)
-  to `data/auto_update_verifier.py`, then writes
-  `data/auto_update_verify.request`. That file triggers
-  `ledmatrix-update-verify.path`, which runs the verifier as a separate unit
-  (so restarting the web service does not kill it). The verifier restarts
-  both services, waits for the web API to answer and the display service to
-  stay up, and on failure resets to the previous commit and restarts again.
-  Plugin updates run only after a verified core update. State is in
-  `data/auto_update_state.json` and `data/auto_update_pending.json`.
-- **Startup validator.** `StartupValidator`
-  ([`src/startup_validator.py`](../src/startup_validator.py)) runs twice in
-  `DisplayController.__init__`: config and cache directory first, then
-  enabled plugins once the plugin manager exists. It also warns when an
-  installed systemd unit differs from its template in `systemd/`. Results
-  are logged; startup continues either way.
-
-## Where to start reading
-
-| Task | Start with |
-|---|---|
-| Change rotation, durations or priorities | `DisplayController.run()` and `_get_display_duration()` in [`display_controller.py`](../src/display_controller.py) |
-| Add a config key | [CONFIG_REFERENCE.md](CONFIG_REFERENCE.md), [`config/config.template.json`](../config/config.template.json), the tab's partial and `api_v3/config.py` |
-| Change drawing or fonts | [`display_manager.py`](../src/display_manager.py), [`font_manager.py`](../src/font_manager.py), [`src/common/bdf_font.py`](../src/common/bdf_font.py) |
-| Add a plugin-facing API | [`base_plugin.py`](../src/plugin_system/base_plugin.py) or [`src/common/`](../src/common/README.md); document it in [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) |
-| Plugin install/update bugs | `PluginStoreManager` in [`store_manager.py`](../src/plugin_system/store_manager.py) |
-| A plugin that won't load | `PluginManager.load_plugin()` and `PluginLoader.load_plugin()`; `python3 scripts/check_plugin.py --plugin <id>` |
-| Add an API endpoint | the matching module in [`api_v3/`](../web_interface/blueprints/api_v3/) |
-| Add a web UI tab or control | `templates/v3/base.html`, the tab's partial, `pages_v3.py` |
-| Vegas scroll | [`src/vegas_mode/coordinator.py`](../src/vegas_mode/coordinator.py) |
-| Installer or permissions | [`first_time_install.sh`](../first_time_install.sh), [`scripts/install/`](../scripts/install/), [PERMISSIONS.md](PERMISSIONS.md) |
-| Work without a Pi | [DEV_PREVIEW.md](DEV_PREVIEW.md), [EMULATOR_SETUP_GUIDE.md](EMULATOR_SETUP_GUIDE.md), [HOW_TO_RUN_TESTS.md](HOW_TO_RUN_TESTS.md) |

docs/CONFIG_DEBUGGING.md

@@ -172,14 +172,10 @@ ERROR - Plugin football-scoreboard configuration validation failed: 'api_key' is
 
 ### Enable Debug Logging
 
-Run the display in the foreground with `-d`, or set `LEDMATRIX_DEBUG=true`
-(the value must be `true`; `1` is ignored — see `setup_logging()` in
-[`src/logging_config.py`](../src/logging_config.py)):
+Set environment variable:
 ```bash
-sudo systemctl stop ledmatrix.service
-sudo python3 run.py -d
-# or
-sudo LEDMATRIX_DEBUG=true python3 run.py
+export LEDMATRIX_DEBUG=1
+python run.py
 ```
 
 ### Check Merged Configuration
@@ -325,10 +321,8 @@ cp config/backups/config.json.backup.20240115_120000_000000 config/config.json
 
 ## Getting Help
 
-1. Check logs. Both services log to journald, not to a file:
-   `sudo journalctl -u ledmatrix.service -f` (display) and
-   `sudo journalctl -u ledmatrix-web.service -f` (web interface)
-2. Enable debug: `LEDMATRIX_DEBUG=true` or `python3 run.py -d`
+1. Check logs: `tail -f logs/ledmatrix.log`
+2. Enable debug: `LEDMATRIX_DEBUG=1`
 3. Check error dashboard: `/api/v3/errors/summary`
 4. Validate JSON: https://jsonlint.com/
 5. File an issue: https://github.com/ChuckBuilds/LEDMatrix/issues

docs/CONFIG_REFERENCE.md

@@ -105,7 +105,6 @@ logical image to multiple chained physical panels.
 | `display_durations` | object, `{}` | Per-plugin display duration in seconds, keyed by plugin id (e.g. `"clock": 15`) | `DisplayController._get_display_duration()` (`src/display_controller.py`) |
 | `plugin_rotation_order` | array, `[]` | Explicit rotation order of plugin ids; empty = all enabled plugins in discovery order | `DisplayController._apply_plugin_rotation_order()` (`src/display_controller.py`) |
 | `use_short_date_format` | bool, `true` | Compact date rendering in sports scoreboards | Nothing since `src/base_classes` was removed; scoreboards read `display.use_short_date_format` from their own plugin config |
-| `scan_order_compensation` | string, `"auto"` | `"auto"` shows one half of each panel a refresh behind while something scrolls at one frame per refresh, which removes the 1px step a 1:N-scan panel shows across its middle; `"off"` disables it. Applies only to layouts whose row order is known: plain or parallel chains, 0 or 180 degree orientation, `multiplexing` 0, `scan_mode` 0, and not in the emulator | `DisplayManager._setup_scan_order_compensation()` (`src/display_manager.py`, `src/scan_order.py`) |
 | `dynamic_duration.max_duration_seconds` | int, optional | Cap for plugins that request dynamic display time | `DisplayController._get_global_dynamic_cap()` (`src/display_controller.py`) |
 
 ## `display.vegas_scroll` — continuous scroll mode
@@ -128,11 +127,7 @@ Read by `src/vegas_mode/config.py` (`VegasScrollConfig.from_config`). See
 | `min_content_separation` | int, `24` |
 | `min_cut_gap` | int, `6` |
 | `continuous_scroll` | bool, `true` |
-| `offscreen_prefetch` | bool, `true` — render every plugin's ticker content on the background thread, each on its own canvas. `false` restores handing canvas-bound plugins to the render thread, one pause at a time. Temporary; see [OFFSCREEN_RENDERING.md](OFFSCREEN_RENDERING.md) |
-| `prefetch_gate` | bool, `true` — let that background thread run Python only while the render thread is waiting for the panel, so the render thread never waits for the GIL when a refresh comes round. Only takes effect with the rebuilt rgbmatrix binding (`scripts/build_rgbmatrix_nogil.sh`). See [OFFSCREEN_RENDERING.md](OFFSCREEN_RENDERING.md) |
-| `switch_interval_ms` | float, `0` — experimental: shorten Python's GIL switch interval to this many ms while Vegas runs. `0` leaves the default (5 ms) alone |
-| `smooth_scroll` | bool, `true` — move a whole number of pixels per panel refresh, locked to vsync. `scroll_speed` is snapped to the nearest speed the panel can show that way (at 95Hz: 95, 47.5, 31.7 px/s…), measured against the panel's real refresh rate once scrolling starts |
-| `sub_pixel_blend` | bool, `false` — the older smoothing: advance by elapsed time and blend neighbouring pixel columns. Looks anti-aliased in the web preview but shimmers on the panel and is not locked to the refresh. Overrides `smooth_scroll` when on |
+| `smooth_scroll` | bool, `true` |
 | `extend_threshold_screens` | float, `2.0` |
 | `auto_trim` | bool, `true` |
 | `trim_threshold` | int, `10` |
@@ -180,5 +175,5 @@ See [PLUGIN_CONFIG_CORE_PROPERTIES.md](PLUGIN_CONFIG_CORE_PROPERTIES.md).
 
 | Key | Meaning |
 |---|---|
-| `github.api_token` | Optional GitHub token the Plugin Store uses to avoid API rate limits (`src/plugin_system/store_registry.py`) |
+| `github.api_token` | Optional GitHub token the Plugin Store uses to avoid API rate limits (`src/plugin_system/store_manager.py`) |
 | `<plugin-id>.*` | Secrets a plugin declares with `"x-secret": true` in its config schema; merged into that plugin's config at load time |

docs/DEVELOPER_QUICK_REFERENCE.md

@@ -54,8 +54,8 @@ rows = self.layout.bounds.inset(1).split_v(3, 1, gap=1)
 self.draw_fit("12:34", rows[0])                 # largest crisp font that fits
 self.draw_image(logo, rows[1], mode="fill_height", crop_to_ink=True)
 
-# Weather icons: draw_weather_icon() is deprecated, removed in 3.7.0 —
-# draw your own icons (the weather plugin ships WeatherIcons)
+# Weather icons
+display_manager.draw_weather_icon("rain", x=10, y=10, size=16)
 
 # Scrolling state
 display_manager.set_scrolling_state(True)
@@ -72,23 +72,20 @@ cache_manager.delete("key")       # alias for clear_cache(key)
 
 # Advanced caching
 data = cache_manager.get_cached_data_with_strategy("key", data_type="weather")
+data = cache_manager.get_background_cached_data("key", sport_key="nhl")
 
 # Strategy
 strategy = cache_manager.get_cache_strategy("weather")
+interval = cache_manager.get_sport_live_interval("nhl")
 ```
 
-`get_background_cached_data()` (use `get()`) and `get_sport_live_interval()`
-are deprecated, removed in 3.7.0. See
-[Deprecated APIs](PLUGIN_API_REFERENCE.md#deprecated-apis).
-
 ## Plugin Manager Quick Methods
 
 ```python
 # Get plugins
 plugin = plugin_manager.get_plugin("plugin-id")
 all_plugins = plugin_manager.get_all_plugins()
-# get_enabled_plugins() is deprecated, removed in 3.7.0 — check `enabled`
-# on the entries in plugin_manager.plugins
+enabled = plugin_manager.get_enabled_plugins()
 
 # Get info
 info = plugin_manager.get_plugin_info("plugin-id")
@@ -171,7 +168,7 @@ def display(self, force_clear=False):
 
 - [ ] Plugin inherits from `BasePlugin`
 - [ ] Implements `update()` and `display()` methods
-- [ ] `manifest.json` with the [required fields](PLUGIN_API_REFERENCE.md#manifest-required-fields)
+- [ ] `manifest.json` with required fields
 - [ ] `config_schema.json` for web UI (recommended)
 - [ ] `README.md` with documentation
 - [ ] Error handling implemented

docs/EMULATOR_SETUP_GUIDE.md

@@ -17,13 +17,13 @@ The LEDMatrix emulator allows you to run and test LEDMatrix displays on your com
 ## Prerequisites
 
 ### System Requirements
-- Python 3.10 or higher
+- Python 3.7 or higher
 - Windows, macOS, or Linux
 - At least 2GB RAM (4GB recommended)
 - Internet connection for plugin downloads
 
 ### Required Software
-- Python 3.10+
+- Python 3.7+
 - pip (Python package manager)
 - Git (for plugin management)
 
@@ -50,7 +50,8 @@ pip install -r requirements-emulator.txt
 ```
 
 This installs:
-- `RGBMatrixEmulator` - the emulation library (and whatever it depends on)
+- `RGBMatrixEmulator` - The core emulation library
+- Additional dependencies for display adapters
 
 ### 3. Install Standard Dependencies
 
@@ -62,9 +63,8 @@ pip install -r requirements.txt
 
 ### 1. Emulator Configuration File
 
-The emulator uses `emulator_config.json` for configuration. It isn't in
-the repo (it's gitignored): RGBMatrixEmulator writes it on first run.
-A typical file looks like this:
+The emulator uses `emulator_config.json` for configuration. Here's the
+default configuration as it ships in the repo:
 
 ```json
 {

docs/FONT_MANAGER.md

@@ -9,14 +9,12 @@
 
 ## Overview
 
-[`src/font_manager.py`](../src/font_manager.py) loads and caches the TTF and
-BDF fonts in `assets/fonts/`, registers fonts that plugins ship, and records
-which plugin uses which font so the web UI can show it.
-
-Several methods are deprecated and will be removed in LEDMatrix 3.7.0; they
-log a warning on first call. They are listed in
-[Deprecated methods](#deprecated-methods) below, and the full set is pinned in
-[`test/test_deprecation.py`](../test/test_deprecation.py).
+The enhanced FontManager provides comprehensive font management for the LEDMatrix application with support for:
+- Manager font registration and detection
+- Plugin font management
+- Programmatic per-element font overrides
+- Performance monitoring and caching
+- Dynamic font discovery
 
 ## Getting the FontManager
 
@@ -36,60 +34,157 @@ standalone FontManager when none is available (test harnesses, mocks).
 `DisplayManager` has **no** `font_manager` attribute —
 `display_manager.font_manager` raises `AttributeError`.
 
-## Resolving a font
+## Architecture
 
-```python
-element_key = f"{self.plugin_id}.title"
+### Manager-Centric Design
 
-# Register the choice so the web UI's Fonts tab can list it.
-self.font_manager.register_manager_font(
-    manager_id=self.plugin_id,
-    element_key=element_key,
-    family="press_start",
-    size_px=10,
-    color=(255, 255, 255),
-)
+Managers define their own fonts, but the FontManager:
+1. **Loads and caches fonts** for performance
+2. **Detects font usage** for visibility
+3. **Allows manual overrides** when needed
+4. **Supports plugin fonts** with namespacing
 
-font = self.font_manager.resolve_font(
-    element_key=element_key,
-    family="press_start",
-    size_px=10,
-)
-self.display_manager.draw_text("Hello", x=10, y=10, font=font)
+### Font Resolution Flow
+
+```
+Manager requests font → Check manual overrides → Apply manager choice → Cache & return
 ```
 
-`resolve_font()` applies any entry for `element_key` in
-`config/font_overrides.json`, maps a plugin-local family to its namespaced
-name when `plugin_id` is passed, and then calls `get_font(family, size_px)`.
-On error it returns a fallback font rather than raising.
+## For Manager Developers
 
-`get_font(family, size_px)` looks the family up in `font_catalog` and loads
-it (cached per family and size).
+### Basic Font Usage
 
-## Font families
+```python
+from src.font_manager import FontManager
 
-At start-up the FontManager scans `assets/fonts/` for `.ttf` and `.bdf`
-files. Each becomes a family named after the file, lower-cased and without
-the extension (`PressStart2P-Regular.ttf` → `pressstart2p-regular`). Four
-aliases are added on top:
+class MyManager:
+    def __init__(self, config, display_manager, cache_manager, plugin_manager):
+        self.display_manager = display_manager
+        self.font_manager = plugin_manager.font_manager  # Shared FontManager
+        self.manager_id = "my_manager"
+        
+    def display(self):
+        # Define your font choices
+        element_key = "my_manager.title"
+        font_family = "press_start"
+        font_size_px = 10
+        color = (255, 255, 255)  # RGB white
+        
+        # Register your font choice (for detection and future overrides)
+        self.font_manager.register_manager_font(
+            manager_id=self.manager_id,
+            element_key=element_key,
+            family=font_family,
+            size_px=font_size_px,
+            color=color
+        )
+        
+        # Get the font (checks for manual overrides automatically)
+        font = self.font_manager.resolve_font(
+            element_key=element_key,
+            family=font_family,
+            size_px=font_size_px
+        )
+        
+        # Use the font for rendering
+        self.display_manager.draw_text(
+            "Hello World",
+            x=10, y=10,
+            color=color,
+            font=font
+        )
+```
 
-| Alias | File |
-|---|---|
-| `press_start` | `assets/fonts/PressStart2P-Regular.ttf` |
-| `four_by_six` | `assets/fonts/4x6-font.ttf` |
-| `five_by_seven` | `assets/fonts/5x7.bdf` |
-| `tom_thumb` | `assets/fonts/tom-thumb.bdf` |
+### Advanced Font Usage
 
-Read the catalog directly: `font_manager.font_catalog` is a dict of family
-name to file path. Files added later are picked up on the next start of the
-display service.
+```python
+class AdvancedManager:
+    def __init__(self, config, display_manager, cache_manager, plugin_manager):
+        self.display_manager = display_manager
+        self.font_manager = plugin_manager.font_manager
+        self.manager_id = "advanced_manager"
+        
+        # Define your font specifications
+        self.font_specs = {
+            "title": {"family": "press_start", "size_px": 12, "color": (255, 255, 0)},
+            "body": {"family": "four_by_six", "size_px": 8, "color": (255, 255, 255)},
+            "footer": {"family": "five_by_seven", "size_px": 7, "color": (128, 128, 128)}
+        }
+        
+        # Register all font specs
+        for element_type, spec in self.font_specs.items():
+            element_key = f"{self.manager_id}.{element_type}"
+            self.font_manager.register_manager_font(
+                manager_id=self.manager_id,
+                element_key=element_key,
+                family=spec["family"],
+                size_px=spec["size_px"],
+                color=spec["color"]
+            )
+    
+    def get_font(self, element_type: str):
+        """Helper method to get fonts with override support."""
+        spec = self.font_specs[element_type]
+        element_key = f"{self.manager_id}.{element_type}"
+        
+        return self.font_manager.resolve_font(
+            element_key=element_key,
+            family=spec["family"],
+            size_px=spec["size_px"]
+        )
+    
+    def display(self):
+        # Get fonts (automatically checks for overrides)
+        title_font = self.get_font("title")
+        body_font = self.get_font("body")
+        footer_font = self.get_font("footer")
+        
+        # Render with fonts
+        self.display_manager.draw_text("Title", font=title_font, color=self.font_specs["title"]["color"])
+        self.display_manager.draw_text("Body Text", font=body_font, color=self.font_specs["body"]["color"])
+        self.display_manager.draw_text("Footer", font=footer_font, color=self.font_specs["footer"]["color"])
+```
 
-## Plugin fonts
+### Using Size Tokens
 
-Plugins that ship their own fonts declare them in a `"fonts"` block in
-`manifest.json`. The plugin manager calls
-`FontManager.register_plugin_fonts()` during plugin load. `plugin://…`
-sources are resolved relative to the plugin's install directory.
+```python
+# Get available size tokens
+tokens = self.font_manager.get_size_tokens()
+# Returns: {'xs': 6, 'sm': 8, 'md': 10, 'lg': 12, 'xl': 14, 'xxl': 16}
+
+# Use token to get size
+size_px = tokens.get('md', 10)  # 10px
+
+# Then use in font resolution
+font = self.font_manager.resolve_font(
+    element_key="my_manager.text",
+    family="press_start",
+    size_px=size_px
+)
+```
+
+## For Plugin Developers
+
+> **Note**: plugins that ship their own fonts via a `"fonts"` block
+> in `manifest.json` are registered automatically during plugin load
+> (`src/plugin_system/plugin_manager.py` calls
+> `FontManager.register_plugin_fonts()`). The `plugin://…` source
+> URIs documented below are resolved relative to the plugin's
+> install directory.
+>
+> The web UI's **Fonts** tab lists, uploads, previews and deletes the
+> font files in `assets/fonts/`. Its **Used by** column shows which
+> loaded plugins registered each file through `register_manager_font()`
+> (see [Font usage in the web UI](#font-usage-in-the-web-ui)), and it
+> warns before deleting one of them. It has no override editor (the
+> override panels and `/api/v3/fonts/overrides` endpoints were removed).
+> The programmatic override workflow in
+> [Manual Font Overrides](#manual-font-overrides) below still works.
+> Let users pick fonts through your plugin's own config schema.
+
+### Plugin Font Registration
+
+In your plugin's `manifest.json`:
 
 ```json
 {
@@ -100,123 +195,231 @@ sources are resolved relative to the plugin's install directory.
       {
         "family": "custom_font",
         "source": "plugin://fonts/custom.ttf",
-        "metadata": {"description": "Custom plugin font", "license": "MIT"}
+        "metadata": {
+          "description": "Custom plugin font",
+          "license": "MIT"
+        }
       },
       {
         "family": "web_font",
         "source": "https://example.com/fonts/font.ttf",
-        "metadata": {"checksum": "sha256:abc123..."}
+        "metadata": {
+          "description": "Downloaded font",
+          "checksum": "sha256:abc123..."
+        }
       }
     ]
   }
 }
 ```
 
-Registered families are namespaced as `<plugin_id>::<family>`. Pass
-`plugin_id` to `resolve_font()` to use the short name:
+### Using Plugin Fonts
 
 ```python
-font = self.font_manager.resolve_font(
-    element_key=f"{self.plugin_id}.text",
-    family="custom_font",          # resolved as "my-plugin::custom_font"
-    size_px=10,
-    plugin_id=self.plugin_id,
-)
+class MyPlugin(BasePlugin):
+    def __init__(self, plugin_id, config, display_manager, cache_manager, plugin_manager):
+        super().__init__(plugin_id, config, display_manager, cache_manager, plugin_manager)
+        self.font_manager = self._get_font_manager()
+        
+    def display(self):
+        # Use plugin font (automatically namespaced)
+        font = self.font_manager.resolve_font(
+            element_key=f"{self.plugin_id}.text",
+            family="custom_font",  # Will be resolved as "my-plugin::custom_font"
+            size_px=10,
+            plugin_id=self.plugin_id
+        )
+        
+        self.display_manager.draw_text("Plugin Text", font=font)
 ```
 
-## Overrides
+## Manual Font Overrides
 
-`resolve_font()` still honours `config/font_overrides.json` (a map of
-element key to `family` and/or `size_px`), which is read once at start-up.
-The methods that edit it — `set_override()`, `remove_override()`,
-`get_overrides()` — are deprecated, and there is no web UI or REST endpoint
-for overrides (the override editor and `/api/v3/fonts/overrides` were
-removed). To let users choose a font, add a field to your plugin's config
-schema.
+Overrides are set in code (there is no web UI or REST endpoint for them).
+They are stored in `config/font_overrides.json` and persist across restarts.
+
+### Programmatic Overrides
+
+```python
+# Set override
+font_manager.set_override(
+    element_key="nfl.live.score",
+    family="four_by_six",
+    size_px=8
+)
+
+# Remove override
+font_manager.remove_override("nfl.live.score")
+
+# Get all overrides
+overrides = font_manager.get_overrides()
+```
+
+## Font Discovery
+
+### Available Fonts
+
+The FontManager automatically scans `assets/fonts/` for TTF and BDF fonts:
+
+```python
+# Get all available fonts
+fonts = font_manager.get_available_fonts()
+# Returns: {'press_start': 'assets/fonts/PressStart2P-Regular.ttf', ...}
+
+# Check if font exists
+if "my_font" in fonts:
+    font = font_manager.get_font("my_font", 10)
+```
+
+### Adding Custom Fonts
+
+Place font files in `assets/fonts/` directory:
+- Supported formats: `.ttf`, `.bdf`
+- Font family name is derived from filename (without extension)
+- Will be automatically discovered on next initialization
 
 ## Font usage in the web UI
 
-The web UI's **Fonts** tab lists, uploads, previews and deletes the font
-files in `assets/fonts/`. The web interface runs in its own process and has
-no FontManager, so the display service publishes which plugin uses which
-font ([`src/font_usage.py`](../src/font_usage.py)), and the tab's **Used by**
-column reads it:
+The web interface runs in its own process and has no FontManager, so the
+display service publishes which plugin uses which font
+(`src/font_usage.py`), and the Fonts tab's **Used by** column reads it:
 
 - **Source**: `register_manager_font()` registrations of the loaded
   plugins. `get_font()` and `resolve_font()` do not know the calling plugin
   and are not counted, and neither is a plugin that opens a font file
   directly with PIL — register the fonts your plugin draws with if you want
   them listed.
-- **Names**: a family, alias or path is resolved through `font_catalog` to
-  the file it loads and reported under that file's name without extension
-  (`PressStart2P-Regular`, `4x6-font`, `5x7`, `tom-thumb`), which is how the
-  Fonts tab keys its rows. Fonts outside `assets/fonts/` (a plugin's own
-  `plugin_id::family` fonts) and families that resolve to nothing are left
-  out.
+- **Names**: a family, alias (`press_start`, `four_by_six`,
+  `five_by_seven`, `tom_thumb`) or path is resolved through
+  `font_catalog` to the file it loads and reported under that file's name
+  without extension (`PressStart2P-Regular`, `4x6-font`, `5x7`,
+  `tom-thumb`), which is how the Fonts tab keys its rows. Fonts outside
+  `assets/fonts/` (a plugin's own `plugin_id::family` fonts) and families
+  that resolve to nothing are left out.
 - **When**: a daemon thread started once plugins have loaded checks every
   10 seconds and writes the `font_usage_snapshot` cache key only when the
   usage changed (and once a day, so the cache's cleanup never expires it).
   Unloading a plugin drops its registrations (`forget_manager_fonts`).
 - **Unknown**: until the display service has published, the column reads
   "unknown" and `GET /api/v3/fonts/catalog` returns `used_by: null`.
-- The tab warns before deleting a font that a loaded plugin registered.
 
-## Text measurement
+## Performance Monitoring
 
 ```python
+# Get performance stats
+stats = font_manager.get_performance_stats()
+
+print(f"Cache hit rate: {stats['cache_hit_rate']*100:.1f}%")
+print(f"Total fonts cached: {stats['total_fonts_cached']}")
+print(f"Failed loads: {stats['failed_loads']}")
+print(f"Manager fonts: {stats['manager_fonts']}")
+print(f"Plugin fonts: {stats['plugin_fonts']}")
+```
+
+## Text Measurement
+
+```python
+# Measure text dimensions
 width, height, baseline = font_manager.measure_text("Hello", font)
+
+# Get font height
 font_height = font_manager.get_font_height(font)
 ```
 
-## Tips
+## Best Practices
 
-- BDF fonts usually look better than TTF at small sizes on LED panels.
-- Use `{plugin_id}.{element}` element keys.
-- Register the fonts you draw with, so the Fonts tab can warn before one is
-  deleted.
-- Replace direct `ImageFont.truetype("assets/fonts/...", 8)` calls with
-  `resolve_font()`: it caches, resolves paths against the install directory,
-  and handles BDF files.
+### For Managers
+
+1. **Register all fonts** you use for visibility
+2. **Use consistent element keys** (e.g., `{manager_id}.{element_type}`)
+3. **Cache font references** if using same font multiple times
+4. **Use `resolve_font()`** not `get_font()` directly to support overrides
+5. **Define sensible defaults** that work well on LED matrix
+
+### For Plugins
+
+1. **Use plugin-relative paths** (`plugin://fonts/...`)
+2. **Include font metadata** (license, description)
+3. **Provide fallback** fonts if custom fonts fail to load
+4. **Test with different display sizes**
+
+### General
+
+1. **BDF fonts** are often better for small sizes on LED matrices
+2. **TTF fonts** work well for larger sizes
+3. **Monospace fonts** are easier to align
+4. **Test on actual hardware** - what looks good on screen may not work on LED matrix
+
+## Migration from Old System
+
+### Old Way (Direct Font Loading)
+```python
+self.font = ImageFont.truetype("assets/fonts/PressStart2P-Regular.ttf", 8)
+```
+
+### New Way (FontManager)
+```python
+element_key = f"{self.manager_id}.text"
+self.font_manager.register_manager_font(
+    manager_id=self.manager_id,
+    element_key=element_key,
+    family="pressstart2p-regular",
+    size_px=8
+)
+self.font = self.font_manager.resolve_font(
+    element_key=element_key,
+    family="pressstart2p-regular",
+    size_px=8
+)
+```
 
 ## Troubleshooting
 
-**Font not found**
-- Check the file exists in `assets/fonts/`.
-- The family name is the filename without extension, lower-cased.
-- Check the display service log for font discovery errors.
+### Font Not Found
+- Check font file exists in `assets/fonts/`
+- Verify font family name matches filename (without extension, lowercase)
+- Check logs for font discovery errors
 
-**Plugin fonts not loading**
-- Check the manifest's `"fonts"` block.
-- Check the log for download or registration errors, and that font URLs are
-  reachable.
+### Override Not Working
+- Verify element key matches exactly what manager registered
+- Check `config/font_overrides.json` for correct syntax
+- Restart application to ensure overrides are loaded
 
-## API reference
+### Performance Issues
+- Check cache hit rate in performance stats
+- Reduce number of unique font/size combinations
+- Clear cache if it grows too large: `font_manager.clear_cache()`
 
-Current methods:
+### Plugin Fonts Not Loading
+- Verify plugin manifest syntax
+- Check plugin directory structure
+- Review logs for download/registration errors
+- Ensure font URLs are accessible
 
-| Method | Purpose |
-|---|---|
-| `register_manager_font(manager_id, element_key, family, size_px, color=None)` | Record a font choice (feeds the Fonts tab) |
-| `forget_manager_fonts(manager_id)` | Drop a manager's registrations (core calls it when a plugin unloads) |
-| `resolve_font(element_key, family, size_px, plugin_id=None)` | Get a font, applying overrides and plugin namespacing |
-| `get_font(family, size_px)` | Get a font directly |
-| `get_native_bdf_size(family)` | Native pixel size of a BDF family, or `None` |
-| `measure_text(text, font)` | `(width, height, baseline)` |
-| `get_font_height(font)` | Line height |
-| `register_plugin_fonts(plugin_id, font_manifest)` | Register a plugin's fonts (core calls it at load) |
-| `clear_cache()` | Drop cached fonts and metrics |
-| `font_catalog` (attribute) | Family name → file path |
+## API Reference
 
-### Deprecated methods
+### FontManager Methods
 
-Removed in 3.7.0. Each logs a warning on first call.
+- `register_manager_font(manager_id, element_key, family, size_px, color=None)` - Register font usage
+- `forget_manager_fonts(manager_id)` - Drop a manager's registrations (core calls it when a plugin unloads)
+- `resolve_font(element_key, family, size_px, plugin_id=None)` - Get font with override support
+- `get_font(family, size_px)` - Get font directly (bypasses overrides)
+- `measure_text(text, font)` - Measure text dimensions
+- `get_font_height(font)` - Get font height
+- `set_override(element_key, family=None, size_px=None)` - Set manual override
+- `remove_override(element_key)` - Remove override
+- `get_overrides()` - Get all overrides
+- `get_detected_fonts()` - Get all detected font usage
+- `get_manager_fonts(manager_id=None)` - Get fonts by manager
+- `get_available_fonts()` - Get font catalog
+- `get_size_tokens()` - Get size token definitions
+- `get_performance_stats()` - Get performance metrics
+- `clear_cache()` - Clear font cache
+- `register_plugin_fonts(plugin_id, font_manifest)` - Register plugin fonts
+- `unregister_plugin_fonts(plugin_id)` - Unregister plugin fonts
+
+## Example: Complete Manager Implementation
+
+For a working example of the font manager API in use, see
+`src/font_manager.py` itself.
 
-| Method | Use instead |
-|---|---|
-| `get_available_fonts()`, `get_font_catalog()` | read `font_catalog` |
-| `get_size_tokens()` | pass a pixel size |
-| `get_performance_stats()` | — |
-| `set_override()`, `remove_override()`, `get_overrides()` | a font field in your plugin's config schema |
-| `get_manager_fonts()`, `get_detected_fonts()` | — |
-| `get_plugin_fonts()`, `unregister_plugin_fonts()` | — |
-| `add_font()`, `remove_font()`, `validate_font()` | the web UI's Fonts tab |

docs/GETTING_STARTED.md

@@ -116,8 +116,8 @@ weather and other location-aware plugins.
 4. Wait for installation to finish — installed plugins appear in the
    **Installed Plugins** section above and get their own tab in the second
    nav row
-5. Toggle the plugin to enabled. The running display loads it within a
-   few seconds; no restart is needed
+5. Toggle the plugin to enabled
+6. From **Overview**, click **Restart Display Service**
 
 You can also install community plugins straight from a GitHub URL using the
 **Install from GitHub** section further down the same tab — see
@@ -128,9 +128,9 @@ You can also install community plugins straight from a GitHub URL using the
 1. Each installed plugin gets its own tab in the second navigation row
 2. Open that plugin's tab to edit its settings (favorite teams, API keys,
    update intervals, etc.)
-3. Click **Save**. The display service watches `config.json` and hands the
-   new settings to the running plugin, so no restart is needed. If a plugin
-   still shows old settings, restart the display service from **Overview**
+3. Click **Save**
+4. Restart the display service from **Overview** so the new settings take
+   effect
 
 **Note:** how long each plugin stays on screen is not set in the
 plugin's own tab — use the **Rotation** tab's **Screen Durations**
@@ -197,15 +197,14 @@ The fastest way to verify a plugin works without waiting for the rotation:
 
 **Check:**
 1. Plugin is enabled (toggle on the **Plugin Manager** tab)
-2. Plugin's display duration is non-zero
-3. No errors in the **Logs** tab for that plugin. A plugin whose
-   `validate_config()` fails is not loaded until its settings are fixed
+2. Display service was restarted after enabling
+3. Plugin's display duration is non-zero
+4. No errors in the **Logs** tab for that plugin
 
 **Fix:**
 1. Enable the plugin from **Plugin Manager**
-2. Check the **Logs** tab for plugin-specific errors
-3. If it still does not appear, click **Restart Display Service** on
-   **Overview**
+2. Click **Restart Display Service** on **Overview**
+3. Check the **Logs** tab for plugin-specific errors
 
 ### Weather Plugin Shows "No Data"
 

docs/HOW_TO_RUN_TESTS.md

@@ -52,10 +52,10 @@ pytest test/test_display_controller.py test/test_plugin_system.py
 
 ```bash
 # Run a specific test class
-pytest test/test_display_controller.py::TestDisplayControllerLivePriority
+pytest test/test_display_controller.py::TestDisplayControllerModeRotation
 
 # Run a specific test function
-pytest test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
+pytest test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
 ```
 
 ### Run Tests by Marker
@@ -98,7 +98,7 @@ When you run `pytest`, you'll see:
 
 ```
 test/test_display_controller.py::TestDisplayControllerInitialization::test_init_success PASSED
-test/test_display_controller.py::TestDisplayControllerOnDemand::test_activate_on_demand PASSED
+test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation PASSED
 ...
 ```
 
@@ -174,10 +174,10 @@ pytest
 
 ```bash
 # Run with maximum verbosity and show print statements
-pytest -vv -s test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
+pytest -vv -s test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
 
 # Run with Python debugger (pdb)
-pytest --pdb test/test_display_controller.py::TestDisplayControllerSchedule::test_active_hours
+pytest --pdb test/test_display_controller.py::TestDisplayControllerModeRotation::test_basic_rotation
 ```
 
 ### Run Tests in Parallel (Faster)

docs/OFFSCREEN_RENDERING.md

@@ -1,388 +0,0 @@
-# Offscreen Rendering
-
-**Status (2026-09-24):** step 1, offscreen rendering, is implemented
-(`DisplayManager.offscreen()`, the adapter on the prefetch thread, the plugin
-lock). Steps 2 and 3 are proposed. When all three land, this file becomes the
-reference for how plugin content is rendered off the render thread.
-
-First soak of step 1 on hdpi (50 px/s, `pwm_bits` 7, preview open, 8-minute
-runs, A/B/B/A):
-
-| build | late | by 1 | 2 | 3–5 | 6+ | freezes | render-thread fetches |
-|---|---|---|---|---|---|---|---|
-| #628 | 0.53% | 82 | 2 | 3 | 2 | 3 | 6 |
-| step 1 | 0.63% | 78 | 63 | 17 | 2 | 1 | 0 |
-| step 1 | 0.42% | 77 | 23 | 10 | 0 | 0 | 0 |
-| #628 | 0.37% | 84 | 5 | 3 | 3 | 2 | 14 |
-
-It does what it was built to: no plugin is fetched on the render thread, and
-freezes fell from 5 to 1. But frames 2–5 refreshes late rose. The rendering
-moved to the prefetch thread still needs the GIL, and the render thread waits
-for it (risk 5 below). The late rate did not improve overall. The 1–2 s
-freezes appear in both builds and have a separate, not yet identified cause.
-
-The GIL fix, measured on hdpi (90 px/s, `pwm_bits` 8, preview open, 8-minute
-runs after a 2-minute warm-up, order A B C C B A, 2026-09-24). Each arm pools
-two runs, about 81,000 frames:
-
-| arm | late | by 1 | 2 | 3–5 | 6+ | 2+ late per 10k frames | freezes |
-|---|---|---|---|---|---|---|---|
-| A: step 1 as is | 0.90% | 575 | 64 | 91 | 9 | 20.1 | 0 |
-| B: `switch_interval_ms` 1 | 0.78% | 510 | 105 | 23 | 2 | 15.8 | 0 |
-| C: `prefetch_gate` | **0.60%** | 471 | 11 | 7 | 2 | **2.5** | 0 |
-
-The gate removes the frames the render thread spent waiting for the GIL, and
-it costs the prefetch nothing that shows: it parked the thread for 3–6 s per
-run, and the next group was ready at every strip extension in every arm.
-`prefetch_gate` is therefore on by default; `switch_interval_ms` stays an
-off-by-default experiment. What is left is almost all one refresh late, which
-is the per-frame budget (a 6.75 ms p50 blit in a refresh the panel holds at
-83–85 Hz while rendering), not contention.
-
-The runs restart the service, so the hourly sports refresh never fell inside
-one. That refresh is its own case: about twenty ESPN chunk-fetch threads at
-once, which the gate does not cover (it gates only the prefetch thread).
-
-## The problem
-
-Vegas mode builds its ticker from every plugin's content. Most of that work
-already happens on a background prefetch thread
-(`RenderPipeline.start_prefetch`). But any plugin whose content needs the
-**shared display canvas** is deferred to the render thread
-(`RenderPipeline.drain_deferred`), one plugin every two seconds. The code's
-own comments put each of those at 40–600 ms, and the render thread presents no
-frames while one runs.
-
-On hdpi (Pi 4, 512×64) most plugins take that path: geochron, tide-display,
-news, hockey-scoreboard, ledmatrix-stocks, incoming-packages, clock-simple,
-countdown, birdnet-go, ledmatrix-music and odds-ticker. They arrive in bursts
-("Whole group deferred; strip will extend as it drains") every minute or so,
-12 fetches in five minutes. That is the "occasional pause" a viewer sees.
-
-An 8-minute soak (`scripts/frame_soak.py --preview`) of the #628 build on
-hdpi:
-
-| late by | frames |
-|---|---|
-| 1 refresh | 238 |
-| 2 | 32 |
-| 3–5 | 30 |
-| 6+ | 5 |
-| freezes ≥ 250 ms | 2 (0.97 s total) |
-
-The 3+ rows and the freezes are the pauses. The single-refresh row is a
-separate problem: the blit is 6 ms of a 10 ms refresh, so there is little
-slack. It is covered under *What this does not fix*.
-
-## Why a plugin is canvas-bound
-
-The plugin-facing canvas is a set of shared attributes on `DisplayManager`:
-`image`, `draw`, `matrix`, and the `width`/`height` properties that read from
-`matrix`. Three adapter paths (`src/vegas_mode/plugin_adapter.py`) need them,
-and each returns `None` under `offscreen_only=True` so the plugin is queued for
-the render thread:
-
-1. **Display capture** (`_capture_display_content`): clear the canvas, call
-   `plugin.display()`, copy `display_manager.image`. Used by any plugin
-   without `get_vegas_content()` or a populated `scroll_helper`.
-2. **Scroll-content generation** (`_trigger_scroll_content_generation`): a
-   ticker plugin whose `scroll_helper.cached_image` is empty is made to build
-   it by calling `display(force_clear=True)` or `_create_scrolling_display()`.
-   Both draw on the canvas.
-3. **Narrowed rendering** (`DisplayManager.render_size`): swaps the shared
-   `matrix`, `image` and `draw` for a narrower set so the plugin lays out for
-   `render_width_pct`. The render thread would see the swap mid-frame.
-
-The render thread keeps the canvas coherent only because nothing else touches
-it at the same time. A background thread can't use it.
-
-## The design: a per-thread render target
-
-`capture_mode()` is already per-thread (#423 made its state a
-`threading.local`, so a background capture no longer suppresses the render
-loop's pushes). The same move applies to the canvas itself:
-
-```python
-with display_manager.offscreen(width=None, height=None) as surface:
-    plugin.display(force_clear=True)
-    content = surface.image.copy()
-```
-
-For the **calling thread only**, inside the block:
-
-| accessor | resolves to |
-|---|---|
-| `display_manager.image`, `.draw` | the surface's own image and draw: a fresh black canvas, `fontmode = "1"` |
-| `display_manager.matrix` | a logical proxy reporting the surface size, so `width`/`height` and plugins that read `matrix.width` follow it. Hardware calls through it (`SetImage`, `SwapOnVSync`, `Clear`, brightness writes) are inert. |
-| `update_display()`, `clear()` | canvas-only: the block implies capture mode, which is already per-thread |
-| `set_scrolling_state()`, `set_frame_hold()` | no-ops, so a plugin's `display()` cannot re-pace the live scroll. Today it can, when it is captured on the render thread. |
-
-Every other thread sees the real canvas, unchanged. The render loop in
-particular keeps presenting while a plugin draws elsewhere.
-
-### Implementation sketch
-
-- `image`, `draw` and `matrix` become properties over `_image`, `_draw` and
-  `_matrix`, plus a thread-local current surface. The getter returns the
-  surface's value when the calling thread has one, else the shared one; setters
-  mirror that. That costs about 0.1 µs per access, and `update_display()` reads
-  each a handful of times per frame. Every existing `self.image = ...` in
-  `DisplayManager` (`clear()`, setup, fallback) keeps working and becomes
-  thread-correct for free.
-- `render_size()` is rebuilt on `offscreen()`: it creates or narrows the
-  calling thread's surface instead of swapping shared state.
-- `offscreen()` nests and always restores on exit, including when the plugin
-  raises.
-- `VisualDisplayManager` (the plugin test harness) gets the same method, for
-  parity.
-
-### Adapter changes
-
-- `get_content(offscreen_only=True)` stops returning `None` for the three
-  paths above. Each runs inside `display_manager.offscreen(render_width)`.
-- `_capture_display_content` and `_trigger_scroll_content_generation` drop
-  their "copy the shared image, restore it afterwards" bookkeeping, since the
-  shared image is never touched.
-- **Take the plugin's lock.** `PluginManager.get_plugin_lock()` keeps
-  `update()` and `display()` mutually exclusive in normal rotation, but Vegas
-  never takes it, so today's render-thread captures already race
-  `update()`. Off the render thread the adapter can afford to wait: blocking
-  acquire with a timeout (proposed 2 s). On timeout it keeps the cached segment
-  and tries again next group.
-- `drain_deferred()` and the deferred queue are deleted. The only render-thread
-  fetch left is the inline fallback when no prepared group is ready, which in
-  practice is the first extension. Prefetching at start removes that too.
-
-## Keeping live content fresh
-
-Offscreen rendering is also what makes fresh sports scores possible. Today a
-plugin's segment is drawn when its group is prefetched, and the strip carries
-7,000–10,000 px of content ahead of the viewport (hdpi logs: "7153px still
-ahead", "9842px ahead"). At ~100 px/s, a score drawn now reaches the screen
-70–100 seconds later. When a plugin reports new data, Vegas only drops its
-cache (`invalidate_pending_updates`), so the change is drawn on the plugin's
-*next* turn, several minutes later. A segment already in the strip scrolls by
-with the data it was drawn with.
-
-That was the right trade while every redraw of a canvas-bound plugin stalled
-the scroll. Off the render thread a redraw costs the scroll nothing, so the
-strip can afford three things.
-
-### 1. Refresh at the gate
-
-Before a segment enters the viewport, check whether its plugin has updated
-since the segment was drawn. If it has, redraw it offscreen and replace it
-while it is still out of sight. Width changes are fine here, because
-everything from that segment onward is still invisible.
-
-The gate sits `lead` pixels ahead of the viewport's right edge:
-`lead = max(one screen, speed × (render time + margin))`. The render time is
-the plugin's own, measured on each render (sports cards take the longest,
-hundreds of ms up to seconds per the prefetch notes). A plugin whose render
-does not finish before its segment reaches the viewport keeps the old segment.
-The scroll never waits for it.
-
-Content is then at most `lead / speed` seconds old when it appears, a few
-seconds instead of minutes, without changing how far ahead the rotation
-fetches.
-
-### 2. Replace ahead of the screen
-
-When a plugin reports new data (the Vegas update tick already names them), any
-of its segments that are **anywhere ahead of the viewport** are redrawn and
-replaced straight away, not only at the gate. That covers the long stretch of
-strip between prefetch and the gate.
-
-### 3. Update on screen
-
-A segment that is already **visible** is patched in place when the redrawn
-version has the same geometry: the same total width, and the same width for
-each card (a sports plugin returns one image per game, joined with
-`intra_plugin_gap`). Scoreboard cards keep a fixed layout, so a score change
-patches in and the digits update as the card scrolls past. The patch is a
-pixel copy of one card (a 150×64 card is ~29 KB) applied by the render thread
-between frames, so a frame never shows half of a patch.
-
-When the geometry differs (a game added or dropped, a card that grew), the
-visible part cannot change without a jump. Only the cards not yet on screen
-are replaced, and only if the geometry up to that point is unchanged. Otherwise
-the segment keeps its snapshot until it has scrolled off.
-
-### Avoiding wasted work
-
-- **Change detection.** `run_scheduled_updates_with_changes()` names a plugin
-  whenever its `update()` ran, not when its data changed. On hdpi
-  `clock-simple` and `ledmatrix-music` are named on every 4-second tick. A
-  redraw whose pixels hash the same as the segment's is discarded without a
-  swap.
-- **Redraw on real updates only.** Vegas makes no API calls. Each plugin
-  fetches on its own schedule, and a redraw is triggered only when the
-  plugin's `update()` has run since its segment was drawn. On hdpi live
-  football, baseball and hockey poll every 30 s (live odds every 60 s,
-  everything else hourly), so a live sports card is redrawn once per poll.
-- **Floor.** A plugin is redrawn at most once per
-  `vegas_scroll.refresh_min_interval` (proposed 10 s), and never while its
-  previous redraw is still running. The floor never holds back a sports card
-  polling every 30 s. It exists for chatty plugins: `clock-simple` updates
-  every second and `ledmatrix-music` polls every 2 s.
-- **One worker.** Redraws go through the same background worker as prefetch,
-  one plugin at a time at `nice 10`, under the plugin's lock.
-
-Data freshness is still bounded by each plugin's own fetch interval (how often
-it polls live scores). Drawing faster cannot beat the data source.
-
-### The strip becomes a list of segments
-
-All three need the strip to be replaceable by segment. Today it is one
-image (`ScrollHelper.cached_array`, 8,000–20,000 px wide, 1.5–3.8 MB), and
-`append_content()` rebuilds the whole thing on the render thread for every
-appended block. That is also a pause source.
-
-Proposed `SegmentStrip`, used by Vegas in place of the single image:
-
-- an ordered list of segments: plugin id, card boundaries, a pixel array, the
-  render time, and the plugin data version it was drawn from, plus its
-  x-offset in the strip;
-- `visible(x, width)` assembles the viewport by slicing across at most a few
-  segments: the same ~100 KB copy per frame that slicing the single image
-  costs today;
-- append and trim become O(block) list operations, not a copy of the strip;
-- replace swaps one list entry and shifts the offsets of the segments after it
-  (dozens at most). A same-geometry patch copies pixels into the existing array.
-
-Every mutation is prepared off the render thread and applied by the render
-thread at a frame boundary, so the strip the render loop reads is never
-half-changed.
-
-### Multi-display sync
-
-The follower renders from its own copy of the strip, offset from the leader's
-scroll position. Today the leader sends that copy whole, and only in
-`start_new_cycle()` (`send_scroll_image`), plus the scroll position every
-frame. Continuous scroll, the default, extends and trims the strip without
-starting a new cycle, and nothing sends those changes. From reading the code,
-the follower therefore probably falls out of step after the first extension
-already, before any of this design. That is untested; it needs a two-Pi rig.
-
-With a segment strip, keeping the follower identical becomes **replaying the
-leader's operations**:
-
-- Every strip mutation (append, trim, replace, patch) is one operation in
-  strip coordinates. The leader applies it and sends the same operation to the
-  follower over the existing TCP channel. Segments are small: a card is ~29 KB
-  raw and compresses well.
-- Operations on off-screen segments apply on arrival. A patch to a segment
-  that is on either panel carries an *apply at scroll position X* stamp a
-  couple of hundred milliseconds ahead. Both sides apply it when their scroll
-  position passes X, so both panels change on the same frame, within the
-  existing position-sync jitter.
-- Each operation carries a sequence number. A follower that sees a gap (a
-  reconnect, a dropped message) asks for a full snapshot, which is today's
-  `send_scroll_image` path.
-
-That also fixes the probable continuous-mode gap as a side effect, since
-appends and trims become operations too. Until it is in place, fresh-content
-updates are disabled while sync is active.
-
-## Risks, and what was checked
-
-1. **Plugins holding their own reference to the shared `draw` or `image`.**
-   They would keep drawing into the shared canvas, and routing by thread can't
-   redirect them. A grep of the 49 plugins installed on hdpi found none storing
-   `display_manager.draw` or `.image` in an attribute (a pattern search, so
-   indirect aliasing would slip past it). A plugin that did would
-   draw into an image nobody displays, which trims to a blank segment. That is
-   not corruption, and it is no worse than today.
-2. **Plugins calling the matrix directly.** None in the audit. Inside
-   `offscreen()` the proxy makes it inert anyway.
-3. **Font thread-safety.** `FontManager` shares font objects across plugins.
-   Measured on Pillow 12.3, two threads rendering text take 1.94× as long as
-   one, so text rendering holds the GIL and FreeType is never entered
-   concurrently. Re-check if Pillow changes that.
-4. **Plugin thread-safety.** `display()` moves to the prefetch thread. The
-   plugin lock makes it exclusive with `update()`, which is more protection
-   than it has today. Threads a plugin starts itself are not covered, as today.
-5. **The GIL.** Moving 40–600 ms of plugin rendering off the render thread
-   removes the pauses, but the work still needs the GIL. Pillow drawing holds
-   it, and a waiting thread only gets it back after the switch interval
-   (default 5 ms). Expect some single-refresh late frames while a prefetch
-   runs. Measure with the soak. A render process separate from plugin work
-   is the structural answer (the "native presenter" step). Two experiments
-   get most of the way first (results under Status, above):
-   - `vegas_scroll.switch_interval_ms` lowers the switch interval for a Vegas
-     run (1 ms is the obvious try), so the render thread waits at most that
-     long behind bytecode. It does nothing for a C call that keeps the GIL.
-   - `vegas_scroll.prefetch_gate` (`src/common/render_gate.py`) lets the
-     prefetch thread run Python only while the render thread is blocked in
-     `SwapOnVSync`, up to just before the refresh the swap returns on, and
-     parks it the rest of the time. That covers C calls too, since the gate is
-     checked before each one starts. It never parks the thread while it holds
-     a lock the render thread takes, and never for more than 50 ms. It needs
-     the rebuilt binding, which releases the GIL during the swap. On by
-     default.
-
-## What this does not fix
-
-- **The blit.** Copying a 512×64 frame into the matrix (`SetImage`) is ~6 ms at
-  8 PWM bits on a Pi 4, leaving ~4 ms of slack per refresh. That is the main
-  source of the single-refresh late frames. Holding frames for two refreshes
-  (≈50 px/s) doubles the budget. Cutting the blit itself is the native-presenter
-  step.
-- **Live refreshes pushed from `update()`.** Some sports plugins call
-  `display()` and `update_display()` from inside `update()`, which runs on the
-  update worker and can push to the panel mid-Vegas. That is a separate
-  hazard. `offscreen()` gives a tool for it (run the update worker offscreen
-  while Vegas owns the panel), but it is out of scope here.
-
-## Test plan
-
-- **Unit, `DisplayManager`:** one thread inside `offscreen()` draws while
-  another reads `image`/`draw`/`matrix`/`width`/`height` and sees the real
-  canvas. Also: `update_display()` and `set_scrolling_state()` are inert inside;
-  `render_size()` narrows only the calling thread; nesting and exceptions
-  restore state.
-- **Unit, adapter:** a stub display-capture plugin and a stub scroll-helper
-  plugin both return content with `offscreen_only=True`, and nothing is queued
-  for the render thread. The plugin lock is taken, and a timeout keeps the cached
-  segment.
-- **Emulator integration:** a stub canvas-bound plugin whose `display()` sleeps
-  300 ms. The Vegas render loop never goes a frame without presenting (frame
-  timing recorder: zero freezes).
-- **Unit, `SegmentStrip`:** the viewport assembled across segment boundaries
-  matches slicing one concatenated image, pixel for pixel. Append, trim,
-  replace-ahead and same-geometry patch each leave every other column
-  unchanged. A geometry-changing patch of a visible segment is refused.
-- **Freshness:** a stub sports plugin whose score changes every second. The
-  score on screen is never older than `lead / speed` plus the plugin's fetch
-  interval. A visible card's digits change without the frame-timing recorder
-  seeing a late frame. An unchanged redraw is discarded.
-- **Hardware:** an hdpi soak, A/B against the #628 build, alternating order.
-  Targets: no freezes, an empty 6+ bucket, the 3–5 bucket near zero, and the late
-  rate below 0.66%. Plus, for freshness: log each segment's age when it enters
-  the viewport, and compare the median and max before and after.
-
-## Rollout
-
-Three changes, each soaked on hdpi before the next:
-
-1. **Offscreen rendering:** `offscreen()`, the adapter on the prefetch thread,
-   and the plugin lock. Removes the render-thread pauses.
-2. **`SegmentStrip`:** Vegas's strip becomes a list of segments. Removes the
-   whole-strip copy on append. No visible behaviour change.
-3. **Fresh content:** refresh at the gate, replace ahead, patch on screen,
-   with change detection and the rate limit.
-
-`display.vegas_scroll.offscreen_prefetch` (default `true`) restores today's
-deferred path when `false`, and `display.vegas_scroll.live_refresh` (default
-`true`) turns off step 3. Keep both for one release, then delete the old paths.
-
-## Open questions
-
-1. Keep the kill switch, or ship without one?
-2. Plugin lock timeout: skip the plugin and keep its cached segment (proposed),
-   or wait longer?
-3. `refresh_min_interval`: 10 s proposed. It only limits chatty plugins;
-   live sports are redrawn once per 30 s poll regardless.
-4. Multi-display sync: is there a two-Pi rig to test on? Operation replay is
-   proposed as part of the segment strip (step 2), with fresh content
-   disabled under sync until it has been verified on real hardware.

docs/PERMISSIONS.md

@@ -1,154 +0,0 @@
-# Permissions
-
-Who owns what on an installed system, which privileged commands the web
-interface may run, and how to repair ownership when it goes wrong. The
-installer, [`first_time_install.sh`](../first_time_install.sh), sets all of
-this up; this page describes the result.
-
-## Users and groups
-
-| Account | Used by | Why |
-|---|---|---|
-| `root` | `ledmatrix.service` (the display) | The LED matrix library needs direct GPIO access |
-| The installing user (e.g. `ledpi`) | `ledmatrix-web.service`, `ledmatrix-update-verify.service` | A web server should not run as root |
-| `ledmatrix` group | shared files | Members: the installing user, `root`, and `daemon` if it exists. Created by [`setup_cache.sh`](../scripts/install/setup_cache.sh) and the installer |
-
-The installer also adds the web user to `systemd-journal` and `adm` so the
-**Logs** tab can read the journal. Group changes apply after the user logs
-in again (services pick them up on restart).
-
-## Files and directories
-
-| Path | Owner | Mode | Notes |
-|---|---|---|---|
-| Project directory | web user | dirs `755`, files `644`, `*.sh` `755` | Set in the installer's "Normalize project file permissions" step |
-| `config/` | web user | `2775` | |
-| `config/config.json` | web user | `644` | Written by the web interface |
-| `config/config_secrets.json` | web user : `ledmatrix` | `640` | Owned by the web user because the web interface writes it; root reads it regardless of mode |
-| `plugin-repos/`, `plugins/` | web user | dirs `2775`, files `664` | The web interface installs and removes plugins |
-| `assets/` | web user | dirs `755`, files `644` | Root writes downloaded logos regardless |
-| `/var/cache/ledmatrix/` | `root:ledmatrix` | `2775` (setgid) | Shared cache: see below |
-| Cache files | creator : `ledmatrix` | `660` | |
-| `scripts/fix_perms/safe_plugin_rm.sh`, `safe_pip_install.sh` | `root:root` | `755` | Run as root through sudo, so the web user must not be able to edit them |
-| `/etc/sudoers.d/ledmatrix_web`, `ledmatrix_wifi` | `root` | `440` | |
-
-What keeps it that way at runtime:
-
-- **Config files.** Saves go through
-  [`src/config_manager_atomic.py`](../src/config_manager_atomic.py), which
-  applies `get_config_file_mode()` (`640` for secrets, `644` otherwise) and,
-  when running as root, moves the file's group to the project directory's
-  group (`ensure_shared_group_ownership()` in
-  [`src/common/permission_utils.py`](../src/common/permission_utils.py)).
-- **Cache files.** [`src/cache/disk_cache.py`](../src/cache/disk_cache.py)
-  sets every file it writes to `0660` and gives it the cache directory's
-  group, without relying on the setgid bit. So a file root writes stays
-  readable by the web user.
-- **Plugin directories.** [`run.py`](../run.py) sets
-  `sys.dont_write_bytecode`, because root-owned `__pycache__` directories
-  inside a plugin stop the web user updating or removing it.
-
-`ledmatrix-web.service` deliberately has no `CacheDirectory=`: systemd would
-re-own `/var/cache/ledmatrix` to the web user and its primary group, and the
-web interface could no longer read what the display writes (see the comment
-in [`systemd/ledmatrix-web.service`](../systemd/ledmatrix-web.service)).
-
-If `/var/cache/ledmatrix` is not usable, `CacheManager` falls back to
-`~/.ledmatrix_cache`, `/opt/ledmatrix/cache` or a temp directory
-([`src/cache_manager.py`](../src/cache_manager.py)). The two services then
-may not share a cache, and the web UI shows stale or empty display status,
-on-demand state and plugin health. Fix the directory rather than living
-with the fallback.
-
-## sudo rules
-
-### `/etc/sudoers.d/ledmatrix_web`
-
-Generated by `web_sudoers_rules()` in
-[`scripts/install/lib_sudoers.sh`](../scripts/install/lib_sudoers.sh), the
-only place these rules are defined. Installed by the installer and by
-[`configure_web_sudo.sh`](../scripts/install/configure_web_sudo.sh), both of
-which check them with `visudo -c` first. The web user may run, without a
-password:
-
-- `reboot`, `poweroff`
-- `systemctl start|stop|restart|enable|disable|status ledmatrix.service`,
-  `systemctl is-active ledmatrix[.service]`
-- `systemctl start|stop|restart ledmatrix-web.service`
-- `bash <project>/scripts/fix_perms/safe_plugin_rm.sh *` — removes a
-  directory only if it resolves to a child of `plugin-repos/` or `plugins/`
-- `bash <project>/scripts/fix_perms/safe_pip_install.sh *` — installs a
-  `requirements.txt` only if it is the project's own or one under
-  `plugin-repos/` or `plugins/`, so the root display service can import the
-  packages
-- `journalctl -u ledmatrix.service *`, `-u ledmatrix *`, `-t ledmatrix *`,
-  tagged `NOEXEC`: journalctl opens a pager on a terminal, and a shell
-  escape from that pager would be a root shell
-
-### `/etc/sudoers.d/ledmatrix_wifi`
-
-Written by
-[`scripts/install/configure_wifi_permissions.sh`](../scripts/install/configure_wifi_permissions.sh)
-(run as the web user; the installer calls it). It refuses to grant a binary
-that is not root-owned or is group/world-writable. The rules cover:
-
-- `nmcli device wifi connect|disconnect *`, `nmcli device connect|disconnect *`,
-  `nmcli radio wifi on|off`
-- `systemctl start|stop|restart hostapd`, `... dnsmasq`,
-  `systemctl restart NetworkManager`
-- `sysctl -w net.ipv4.ip_forward=0|1`
-- `nft add|delete table ip ledmatrix`
-- `rfkill unblock wifi`
-- `mkdir -p /etc/NetworkManager/dnsmasq-shared.d`
-- `cp` of `/tmp/hostapd.conf` and `/tmp/dnsmasq.conf` to their fixed
-  destinations, and `rm -f /etc/dnsmasq.d/ledmatrix-captive.conf`
-- `cp /tmp/ledmatrix-nm-dnsmasq.conf` to
-  `/etc/NetworkManager/dnsmasq-shared.d/ledmatrix-captive.conf`, and
-  `rm -f` of that file
-
-**`iptables` is deliberately not granted.** The captive portal's rules are
-built from the interface name and port, so a rule covering them would need a
-trailing wildcard, and `iptables --modprobe=<path>` runs `<path>` as root: a
-wildcard grant is a root shell for the web user. Doing it safely needs a
-wrapper script that builds the rules itself, like `safe_plugin_rm.sh`. On a
-stock Raspberry Pi OS image the default user's blanket `NOPASSWD` rule
-(`/etc/sudoers.d/010_pi-nopasswd`) hides this gap.
-
-### polkit
-
-The same script installs `/etc/polkit-1/rules.d/10-ledmatrix-wifi.rules`,
-which lets the web user perform any `org.freedesktop.NetworkManager.*`
-action without authentication.
-
-## Repair scripts
-
-In [`scripts/fix_perms/`](../scripts/fix_perms/). Run them from the project
-directory.
-
-| Script | Run as | What it does | Notes |
-|---|---|---|---|
-| `fix_plugin_permissions.sh` | `sudo` | `plugins/` and `plugin-repos/` to `root:<user>`, dirs `2775`, files `664`; makes a `700` home directory `755` so root can traverse it | Safe. Group-writable, so the web user keeps write access |
-| `fix_assets_permissions.sh` | `sudo` | `assets/` to `<user>:<group>`, mode `777` recursively | Works, but looser than the installer's `755`/`644` |
-| `fix_cache_permissions.sh` | `sudo` | Runs [`setup_cache.sh`](../scripts/install/setup_cache.sh) for `/var/cache/ledmatrix` (`root:ledmatrix`, `2775`, files `660`), then makes `~/.ledmatrix_cache` (the fallback cache) `<user>:<group>` mode `777` | Safe. The `~/.ledmatrix_cache` mode is still `777` |
-| `fix_web_permissions.sh` | the web user, **without** `sudo` | Resets project file ownership for the web user (it calls `sudo` itself), then makes `safe_plugin_rm.sh` and `safe_pip_install.sh` `root:root` `755` again and restores `config_secrets.json` to its owner, group `ledmatrix`, mode `640` | Refuses to run as root. It does not write sudoers rules |
-| `safe_plugin_rm.sh`, `safe_pip_install.sh` | — | Called by the web interface through sudo | Not for manual use |
-
-To reinstall the sudoers rules, run
-`./scripts/install/configure_web_sudo.sh` (web rules) or
-`./scripts/install/configure_wifi_permissions.sh` (WiFi rules and polkit) as
-the web user, not with `sudo`.
-
-After any of these, restart both services:
-
-```bash
-sudo systemctl restart ledmatrix.service ledmatrix-web.service
-```
-
-## Checking
-
-```bash
-ls -ld /var/cache/ledmatrix          # drwxrwsr-x root ledmatrix
-stat -c '%U:%G %a %n' config/config.json config/config_secrets.json
-id                                   # web user should list ledmatrix
-sudo -l                              # lists the NOPASSWD rules
-```

docs/PLUGIN_API_REFERENCE.md

@@ -9,7 +9,6 @@ Complete API reference for plugin developers. This document describes all method
 
 ## Table of Contents
 
-- [Manifest Required Fields](#manifest-required-fields)
 - [BasePlugin](#baseplugin)
 - [Display Manager](#display-manager)
 - [Cache Manager](#cache-manager)
@@ -18,50 +17,6 @@ Complete API reference for plugin developers. This document describes all method
 
 ---
 
-## Manifest Required Fields
-
-Three parts of core check `manifest.json`, each for a different set of
-fields:
-
-| Check | Fields | What happens when one is missing |
-|---|---|---|
-| JSON schema, [`schema/manifest_schema.json`](../schema/manifest_schema.json) | `id`, `name`, `version`, `author`, `entry_point`, `class_name`, `compatible_versions` | Install from URL logs a warning (`PluginStoreManager._validate_manifest_schema()`); nothing is refused |
-| Plugin Store install, [`src/plugin_system/store_install.py`](../src/plugin_system/store_install.py) | `id`, `name`, `class_name`, `display_modes` | Install is refused. A registry install first tries to detect a missing `class_name` from the entry-point file |
-| Plugin loader, [`src/plugin_system/plugin_loader.py`](../src/plugin_system/plugin_loader.py) | `class_name` | The plugin fails to load |
-
-Defaults and other uses:
-
-- `entry_point` defaults to `manager.py`; the store writes the default back
-  into the manifest on install.
-- `compatible_versions` (a list of semver ranges such as `">=2.0.0"`) is how
-  the store decides whether a plugin can run on this core. An install is
-  refused only when the field excludes the running version
-  (`compatibility.check()` in
-  [`src/plugin_system/compatibility.py`](../src/plugin_system/compatibility.py)).
-- `version` is compared with the registry's `latest_version` to decide
-  whether an update is available.
-- If `display_modes` is empty at load time, the display controller uses the
-  plugin id as the only mode.
-
-**Set all eight:** `id`, `name`, `version`, `author`, `entry_point`,
-`class_name`, `display_modes`, `compatible_versions`. That satisfies every
-check. The schema lists the optional fields.
-
-```json
-{
-  "id": "my-plugin",
-  "name": "My Plugin",
-  "version": "1.0.0",
-  "author": "YourName",
-  "entry_point": "manager.py",
-  "class_name": "MyPlugin",
-  "display_modes": ["my-plugin"],
-  "compatible_versions": [">=2.0.0"]
-}
-```
-
----
-
 ## BasePlugin
 
 All plugins must inherit from `BasePlugin` and implement the required methods. The base class provides access to managers and common functionality.
@@ -477,17 +432,82 @@ self.display_manager.update_display()
 
 This is the canonical way to render arbitrary images.
 
-### Weather Icons (deprecated)
+### Weather Icons
 
-> Deprecated, removed in 3.7.0 — draw your own icons (the weather plugin
-> ships `WeatherIcons`). See [Deprecated APIs](#deprecated-apis).
+#### `draw_weather_icon(condition: str, x: int, y: int, size: int = 16) -> None`
 
-- `draw_weather_icon(condition, x, y, size=16)` — icon for a condition
-  string such as `"clear"`, `"clouds"`, `"rain"`, `"snow"`, `"storm"`
-- `draw_sun(x, y, size=16)`, `draw_cloud(x, y, size=16, color=(200, 200, 200))`,
-  `draw_rain(x, y, size=16)`, `draw_snow(x, y, size=16)`
-- `draw_text_with_icons(text, icons=None, x=None, y=None, color=(255, 255, 255))`
-  — text plus a list of `(icon_type, x, y)` icons; calls `update_display()`
+Draw a weather icon based on the condition string.
+
+**Parameters**:
+- `condition` (str): Weather condition (e.g., "clear", "cloudy", "rain", "snow", "storm")
+- `x` (int): X position
+- `y` (int): Y position
+- `size` (int): Icon size in pixels (default: 16)
+
+**Supported Conditions**:
+- `"clear"`, `"sunny"` → Sun icon
+- `"clouds"`, `"cloudy"`, `"partly cloudy"` → Cloud icon
+- `"rain"`, `"drizzle"`, `"shower"` → Rain icon
+- `"snow"`, `"sleet"`, `"hail"` → Snow icon
+- `"thunderstorm"`, `"storm"` → Storm icon
+
+**Example**:
+```python
+self.display_manager.draw_weather_icon("rain", x=10, y=10, size=16)
+```
+
+#### `draw_sun(x: int, y: int, size: int = 16) -> None`
+
+Draw a sun icon with rays.
+
+**Parameters**:
+- `x` (int): X position
+- `y` (int): Y position
+- `size` (int): Icon size (default: 16)
+
+#### `draw_cloud(x: int, y: int, size: int = 16, color: tuple = (200, 200, 200)) -> None`
+
+Draw a cloud icon.
+
+**Parameters**:
+- `x` (int): X position
+- `y` (int): Y position
+- `size` (int): Icon size (default: 16)
+- `color` (tuple): RGB color (default: light gray)
+
+#### `draw_rain(x: int, y: int, size: int = 16) -> None`
+
+Draw rain icon with cloud and droplets.
+
+#### `draw_snow(x: int, y: int, size: int = 16) -> None`
+
+Draw snow icon with cloud and snowflakes.
+
+#### `draw_text_with_icons(text: str, icons: List[tuple] = None, x: int = None, y: int = None, color: tuple = (255, 255, 255)) -> None`
+
+Draw text with weather icons at specified positions.
+
+**Parameters**:
+- `text` (str): Text to display
+- `icons` (List[tuple], optional): List of (icon_type, x, y) tuples
+- `x` (int, optional): X position for text
+- `y` (int, optional): Y position for text
+- `color` (tuple): Text color
+
+**Note**: Automatically calls `update_display()` after drawing.
+
+**Example**:
+```python
+icons = [
+    ("sun", 5, 5),
+    ("cloud", 100, 5)
+]
+self.display_manager.draw_text_with_icons(
+    "Weather: Sunny, Cloudy",
+    icons=icons,
+    x=10, y=20
+)
+```
 
 ### Scrolling State Management
 
@@ -581,8 +601,6 @@ Process any deferred updates if not currently scrolling. Called automatically by
 
 #### `get_scrolling_stats() -> dict`
 
-> Deprecated, removed in 3.7.0. See [Deprecated APIs](#deprecated-apis).
-
 Get current scrolling statistics for debugging.
 
 **Returns**: Dictionary with scrolling state information
@@ -724,8 +742,6 @@ data = self.cache_manager.get_with_auto_strategy("nhl_live_scores")
 
 #### `get_background_cached_data(key: str, sport_key: Optional[str] = None) -> Optional[Dict[str, Any]]`
 
-> Deprecated, removed in 3.7.0 — use `get()`. See [Deprecated APIs](#deprecated-apis).
-
 Get background service cached data with sport-specific intervals.
 
 **Parameters**:
@@ -763,8 +779,6 @@ max_age = strategy['max_age']  # Get configured max age
 
 #### `get_sport_live_interval(sport_key: str) -> int`
 
-> Deprecated, removed in 3.7.0. See [Deprecated APIs](#deprecated-apis).
-
 Get the live_update_interval for a specific sport from config.
 
 **Parameters**:
@@ -789,8 +803,6 @@ Extract data type from cache key to determine appropriate cache strategy.
 
 #### `get_sport_key_from_cache_key(key: str) -> Optional[str]`
 
-> Deprecated, removed in 3.7.0. See [Deprecated APIs](#deprecated-apis).
-
 Extract sport key from cache key for sport-specific strategies.
 
 **Parameters**:
@@ -835,12 +847,10 @@ for file_info in files:
     self.logger.info(f"Cache: {file_info['key']}, Age: {file_info['age_display']}")
 ```
 
-### Metrics Methods (deprecated)
+### Metrics Methods
 
 #### `get_cache_metrics() -> Dict[str, Any]`
 
-> Deprecated, removed in 3.7.0. See [Deprecated APIs](#deprecated-apis).
-
 Get cache performance metrics.
 
 **Returns**: Dictionary with cache statistics (`total_requests`, `cache_hit_rate`, `background_hit_rate`, `api_calls_saved`, `average_fetch_time`, etc.)
@@ -853,8 +863,6 @@ self.logger.info(f"Cache hit rate: {metrics['cache_hit_rate']:.2%}")
 
 #### `get_memory_cache_stats() -> Dict[str, Any]`
 
-> Deprecated, removed in 3.7.0. See [Deprecated APIs](#deprecated-apis).
-
 Get memory cache statistics.
 
 **Returns**: Dictionary with memory cache stats (size, max_size, etc.)
@@ -899,8 +907,6 @@ for plugin_id, plugin in all_plugins.items():
 
 #### `get_enabled_plugins() -> List[str]`
 
-> Deprecated, removed in 3.7.0 — check `enabled` on the instances in `plugin_manager.plugins`. See [Deprecated APIs](#deprecated-apis).
-
 Get list of enabled plugin IDs.
 
 **Returns**: List of plugin identifier strings
@@ -979,8 +985,9 @@ def update(self):
 
 **Example - Checking if another plugin is enabled**:
 ```python
-weather = self.plugin_manager.plugins.get("weather")
-if weather is not None and weather.enabled:
+enabled_plugins = self.plugin_manager.get_enabled_plugins()
+if "weather" in enabled_plugins:
+    # Weather plugin is enabled
     pass
 ```
 

docs/PLUGIN_CONFIGURATION_GUIDE.md

@@ -124,14 +124,6 @@ Plugins are configured by adding their plugin ID as a top-level key in the confi
 }
 ```
 
-How often the core calls a plugin's `update()`: the plugin's
-`get_update_interval()` if it returns a number, else `update_interval` in the
-plugin's `manifest.json`, else `update_interval` in its `config.json` section
-as above, else 60 seconds. A config `update_interval` therefore only sets the
-scheduler's cadence for a plugin whose manifest does not; plugins that expose
-it in their config schema typically also honour it themselves inside
-`update()`. See [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md#get_update_interval---optionalfloat).
-
 ### Plugin Display Durations
 
 Add plugin display modes to the `display_durations` section:
@@ -202,7 +194,7 @@ plugin-repos/
 ```
 
 The Plugin Store refuses a manifest that lacks any of `id`, `name`,
-`class_name` or `display_modes` (`store_install.py`); the loader itself
+`class_name` or `display_modes` (`store_manager.py`); the loader itself
 needs `class_name`. `version` is not required, but the store compares it
 with the registry's `latest_version` to offer updates, so set it.
 `entry_point` defaults to `manager.py` if omitted. The config schema is not

docs/PLUGIN_CONFIGURATION_TABS.md

@@ -203,7 +203,7 @@ Forms are rendered on the server, not generated in the browser:
    from the schema (widgets named by `x-widget` are rendered by the scripts in
    `web_interface/static/v3/js/widgets/`)
 4. **Save Configuration** posts the form to `/api/v3/plugins/config`
-   (`web_interface/blueprints/api_v3/plugin_config.py`), which validates it against
+   (`web_interface/blueprints/api_v3/plugins.py`), which validates it against
    the schema, writes `config.json` (secret fields go to
    `config_secrets.json`) and shows a notification
 

docs/PLUGIN_CONFIG_ARCHITECTURE.md

@@ -32,7 +32,7 @@
 │    • masks x-secret fields                                         │
 │    • renders partials/plugin_config.html (render_field macros)     │
 │                                                                    │
-│  api_v3 blueprint (blueprints/api_v3/plugin_config.py)             │
+│  api_v3 blueprint (blueprints/api_v3/plugins.py)                   │
 │   save_plugin_config()   POST /api/v3/plugins/config               │
 │   get_plugin_config()    GET  /api/v3/plugins/config               │
 │   get_plugin_schema()    GET  /api/v3/plugins/schema               │
@@ -91,7 +91,7 @@ validatePluginConfigForm() (client-side checks)
 POST /api/v3/plugins/config?plugin_id=<id>   (form data, all fields of the form)
         │
         ▼
-save_plugin_config()                          (api_v3/plugin_config.py)
+save_plugin_config()                          (api_v3/plugins.py)
         ├─→ Start from the stored config.json[<id>]
         ├─→ Apply form fields: dotted names → nested keys, "[]" checkbox
         │   groups → lists, values coerced to the schema's types
@@ -155,9 +155,9 @@ deep-merged back into the plugin's config at load time
 ### Custom input widgets
 
 Set `"x-widget": "<name>"` on a property. Core widgets are in
-`web_interface/static/v3/js/widgets/`; a plugin can ship its own widget
-script, served from `/static/plugin-widgets/<plugin_id>/<name>.js`. See the
-[widget guide](../web_interface/static/v3/js/widgets/README.md).
+`web_interface/static/v3/js/widgets/` (see its README); a plugin can ship its
+own widget script, served from `/static/plugin-widgets/<plugin_id>/<name>.js`.
+See [widget-guide.md](widget-guide.md).
 
 ### Custom actions
 
@@ -175,7 +175,7 @@ Implement `on_config_change(new_config)` in the plugin (see
 |---------|------|
 | Tab partial loader | `web_interface/blueprints/pages_v3.py` (`_load_plugin_config_partial`) |
 | Form template and field macros | `web_interface/templates/v3/partials/plugin_config.html` |
-| Save / get / schema / reset handlers | `web_interface/blueprints/api_v3/plugin_config.py` |
+| Save / get / schema / reset handlers | `web_interface/blueprints/api_v3/plugins.py` |
 | Schema loading, defaults, validation | `src/plugin_system/schema_manager.py` |
 | Secret masking and splitting | `src/web_interface/secret_helpers.py` |
 | Widgets | `web_interface/static/v3/js/widgets/` |

docs/PLUGIN_CUSTOM_ICONS.md

@@ -5,9 +5,11 @@
 A plugin can name an icon for its tab in the web interface's second nav row
 (next to **Plugin Manager**) with the `icon` field in `manifest.json`.
 
-`GET /api/v3/plugins/installed` passes the manifest's `icon` through (a
-non-string value comes back as `null`), and a plugin without one gets the
-default puzzle piece.
+> **Status:** the tab code honors `icon`, but `GET /api/v3/plugins/installed`
+> (`web_interface/blueprints/api_v3/plugins.py`) does not currently include
+> the manifest's `icon` in its response, so every tab shows the default
+> puzzle piece. Setting `icon` is harmless and will take effect once the API
+> passes it through again.
 
 ## Font Awesome classes only
 
@@ -53,8 +55,8 @@ With no `icon` (or an empty one) the tab shows `fas fa-puzzle-piece`.
    or misspelled class renders as a blank space.
 2. Include the style prefix (`fas`, `far` or `fab`) as well as the icon
    class.
-3. The manifest is re-read on each plugin list load; reload the page after
-   editing `icon`.
+3. See the status note above: the icon is currently not passed through by
+   the API.
 
 ## Related Documentation
 

docs/PLUGIN_DEPENDENCY_GUIDE.md

@@ -25,7 +25,7 @@ which runs as root.** Anything installed only into another user's
 The web interface is not root, so it installs through a narrow sudo helper:
 
 1. `PluginStoreManager._install_dependencies()`
-   (`src/plugin_system/store_install.py`) calls
+   (`src/plugin_system/store_manager.py`) calls
    `install_requirements_file()` (`src/common/permission_utils.py`).
 2. That runs `sudo -n bash scripts/fix_perms/safe_pip_install.sh <plugin>/requirements.txt`.
    The helper checks the path is the project's own `requirements.txt` or a
@@ -154,9 +154,8 @@ For more, see the [Plugin Dependency Troubleshooting Guide](PLUGIN_DEPENDENCY_TR
 ## Files to Reference
 
 - Service units: `systemd/ledmatrix.service`, `systemd/ledmatrix-web.service`
-- Store installs: `src/plugin_system/store_install.py` (`_install_dependencies`)
+- Store installs: `src/plugin_system/store_manager.py` (`_install_dependencies`)
 - Root install helper: `src/common/permission_utils.py` (`install_requirements_file`), `scripts/fix_perms/safe_pip_install.sh`
 - Load-time installs: `src/plugin_system/plugin_loader.py` (`install_dependencies`)
-- Sudo rules: `scripts/install/lib_sudoers.sh` (written by `first_time_install.sh`
-  and `scripts/install/configure_web_sudo.sh`)
+- Sudo rules: `scripts/install/configure_web_sudo.sh`
 - Manual installer: `scripts/install_plugin_dependencies.sh`

docs/PLUGIN_DEVELOPMENT_GUIDE.md

@@ -520,22 +520,19 @@ When developing plugins, you'll need to use the APIs provided by the LEDMatrix s
   `display_manager.image` (a PIL Image) and call `update_display()`;
   there is no `draw_image()` helper method.
 - `draw_weather_icon()`, `draw_sun()`, `draw_cloud()` - Weather icons
-  (deprecated, removed in 3.7.0 — draw your own icons)
 - `get_text_width()`, `get_font_height()` - Text utilities
 - `set_scrolling_state()`, `defer_update()` - Scrolling state management
 
 **Cache Manager** (`self.cache_manager`):
 - `get()`, `set()`, `delete()` - Basic caching
 - `get_cached_data_with_strategy()` - Advanced caching with strategies
-- `get_background_cached_data()` - deprecated, removed in 3.7.0 — use `get()`
+- `get_background_cached_data()` - Background service caching
 
 **Plugin Manager** (`self.plugin_manager`):
 - `get_plugin()`, `get_all_plugins()` - Access other plugins
 - `get_plugin_info()` - Get plugin information
 
-See [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) for complete
-documentation, and its [Deprecated APIs](PLUGIN_API_REFERENCE.md#deprecated-apis)
-table for everything removed in 3.7.0.
+See [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) for complete documentation.
 
 ## 3rd Party Plugin Development
 
@@ -580,14 +577,12 @@ Your plugin must:
            pass
    ```
 
-2. **Include manifest.json** with the required fields listed in
-   [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md#manifest-required-fields):
+2. **Include manifest.json** with required fields:
    ```json
    {
      "id": "my-plugin",
      "name": "My Plugin",
      "version": "1.0.0",
-     "author": "YourName",
      "class_name": "MyPlugin",
      "entry_point": "manager.py",
      "display_modes": ["my_plugin"],
@@ -645,7 +640,7 @@ To have your plugin added to the official plugin store:
 
 3. **Contact maintainers** (own-repository plugins):
    - Open a GitHub issue in the [ledmatrix-plugins](https://github.com/ChuckBuilds/ledmatrix-plugins) repository
-   - Or reach out on Discord: https://discord.gg/RdrC37rEag
+   - Or reach out on Discord: https://discord.gg/uW36dVAtcT
    - Include: Repository URL, plugin description, why it's useful
 
 4. **Review process**:
@@ -663,7 +658,7 @@ For your plugin to work well in the plugin store:
   with the registry's `latest_version`; releases and tags are not read
 - **README.md**: Clear installation and configuration instructions
 - **config_schema.json**: Recommended for web UI configuration
-- **manifest.json**: Required, with the [required fields](PLUGIN_API_REFERENCE.md#manifest-required-fields)
+- **manifest.json**: Required with all required fields
 - **requirements.txt**: If your plugin has Python dependencies
 
 ### Distribution Options

docs/PLUGIN_QUICK_REFERENCE.md

@@ -45,8 +45,7 @@ LEDMatrix/
 
 ### 1. Minimal Plugin Structure
 
-**manifest.json** (the required fields are explained in
-[PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md#manifest-required-fields)):
+**manifest.json**:
 ```json
 {
   "id": "my-plugin",
@@ -55,8 +54,6 @@ LEDMatrix/
   "author": "YourName",
   "entry_point": "manager.py",
   "class_name": "MyPlugin",
-  "display_modes": ["my-plugin"],
-  "compatible_versions": [">=2.0.0"],
   "category": "custom"
 }
 ```

docs/PLUGIN_REGISTRY_SETUP_GUIDE.md

@@ -67,9 +67,9 @@ Don't edit `latest_version` or `last_updated` by hand for monorepo plugins:
 
 ## Adding or changing an official plugin
 
-1. Add or edit `plugins/<your-plugin-id>/` in the monorepo, with the
-   manifest fields listed in
-   [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md#manifest-required-fields).
+1. Add or edit `plugins/<your-plugin-id>/` in the monorepo. The store refuses
+   a manifest without `id`, `name`, `class_name` and `display_modes`; also
+   set `version`.
 2. Bump `version` in the plugin's `manifest.json` for every change, or users
    won't be offered the update.
 3. Run `python update_registry.py` in ledmatrix-plugins and commit the

docs/README.md

@@ -11,7 +11,7 @@ the one-shot installer. The pages here go deeper.
 2. [WEB_INTERFACE_GUIDE.md](WEB_INTERFACE_GUIDE.md) — using the web UI
 3. [PLUGIN_STORE_GUIDE.md](PLUGIN_STORE_GUIDE.md) — installing and managing plugins
 4. [WIFI_NETWORK_SETUP.md](WIFI_NETWORK_SETUP.md) — WiFi and AP-mode setup
-5. [TROUBLESHOOTING.md](TROUBLESHOOTING.md) — common issues and fixes ([PERMISSIONS.md](PERMISSIONS.md) for "Permission denied")
+5. [TROUBLESHOOTING.md](TROUBLESHOOTING.md) — common issues and fixes
 6. [SSH_UNAVAILABLE_AFTER_INSTALL.md](SSH_UNAVAILABLE_AFTER_INSTALL.md) — recovering SSH after install
 7. [CONFIG_DEBUGGING.md](CONFIG_DEBUGGING.md) — diagnosing config problems
 8. [LOW_MEMORY_BOARDS.md](LOW_MEMORY_BOARDS.md) — Pi Zero 2 W / 3B+ / 1GB Pi 4 memory limits
@@ -37,7 +37,7 @@ Going deeper:
 - [PLUGIN_CUSTOM_ICONS.md](PLUGIN_CUSTOM_ICONS.md)
 - [PLUGIN_REGISTRY_SETUP_GUIDE.md](PLUGIN_REGISTRY_SETUP_GUIDE.md) (+ [registry template](plugin_registry_template.json))
 - [STARLARK_APPS_GUIDE.md](STARLARK_APPS_GUIDE.md) — Starlark-based mini-apps
-- [Widget guide](../web_interface/static/v3/js/widgets/README.md) — built-in `x-widget`s and custom widgets
+- [widget-guide.md](widget-guide.md) — widget development
 - [ADAPTIVE_LAYOUT.md](ADAPTIVE_LAYOUT.md) — render legibly on any panel size (opt-in font/layout scaling)
 - [plugin-safety-harness.md](plugin-safety-harness.md) — test a plugin across every screen and matrix size
 
@@ -56,27 +56,21 @@ Going deeper:
 - [ADVANCED_FEATURES.md](ADVANCED_FEATURES.md) — Vegas scroll, on-demand display,
   cache management, background services, permissions
 - [FONT_MANAGER.md](FONT_MANAGER.md) — font system
-- [SCROLL_PERFORMANCE.md](SCROLL_PERFORMANCE.md) — how scrolling is paced, and how to make a plugin's marquee smooth
-- [OFFSCREEN_RENDERING.md](OFFSCREEN_RENDERING.md) — rendering plugin content off the render thread
-- [PERMISSIONS.md](PERMISSIONS.md) — file ownership, sudo rules, repair scripts
-- [MQTT bridge](../integrations/mqtt_bridge/README.md) — control the display from Home Assistant over MQTT
 
 ## Reference
 
 - [CONFIG_REFERENCE.md](CONFIG_REFERENCE.md) — every key in config.json and config_secrets.json
 - [REST_API_REFERENCE.md](REST_API_REFERENCE.md) — all web-interface HTTP endpoints
 - [PLUGIN_API_REFERENCE.md](PLUGIN_API_REFERENCE.md) — Python APIs available to plugins
-- [src/common/README.md](../src/common/README.md) — shared helper modules plugins can import
 - [DEVELOPER_QUICK_REFERENCE.md](DEVELOPER_QUICK_REFERENCE.md) — common dev tasks
 
 ## Contributing to LEDMatrix itself
 
-- [ARCHITECTURE.md](ARCHITECTURE.md) — processes, display loop, plugin system, web UI; where to start reading
 - [DEVELOPMENT.md](DEVELOPMENT.md) — environment setup
 - [HOW_TO_RUN_TESTS.md](HOW_TO_RUN_TESTS.md) — running the test suite
 - [MULTI_ROOT_WORKSPACE_SETUP.md](MULTI_ROOT_WORKSPACE_SETUP.md) — multi-repo workspace
 - [MIGRATION_GUIDE.md](MIGRATION_GUIDE.md) — breaking changes between releases
-- [SPORTS_UNIFICATION.md](SPORTS_UNIFICATION.md) — how shared sports scoreboard code moves into `src/common`
+- [SPORTS_UNIFICATION.md](SPORTS_UNIFICATION.md) — how the sports scoreboard base classes are organized
 
 ## Audits
 

docs/REST_API_REFERENCE.md

@@ -40,14 +40,13 @@ the entry below says so.
 
 > The API blueprint is the `api_v3` package in
 > `web_interface/blueprints/api_v3/` (one module per area: `config.py`,
-> `display.py`, `system.py`, `backup.py`, `fonts.py`, `misc.py`, `wifi.py`,
-> `starlark.py`, and `plugins.py` plus the `plugin_*.py` modules for the
-> plugin routes). `web_interface/app.py` registers it
+> `display.py`, `plugins.py`, `system.py`, `backup.py`, `fonts.py`,
+> `misc.py`, `wifi.py`, `starlark.py`). `web_interface/app.py` registers it
 > at `/api/v3` (`app.register_blueprint(api_v3, url_prefix='/api/v3')`).
 > The three SSE endpoints (`/api/v3/stream/*`) are defined directly on the
 > Flask app in `app.py` (`stream_stats`, `stream_display`, `stream_logs`).
 > `test/fixtures/api_v3_url_map.json` is the canonical list of blueprint
-> routes; a test fails if the code and that fixture differ.
+> routes (116 URL rules); a test fails if the code and that fixture differ.
 
 ---
 
@@ -390,7 +389,7 @@ Request a specific plugin to display on-demand.
 - `mode` (string, optional): Display mode name (plugin_id inferred if not provided)
 - `duration` (number, optional): Duration in seconds (0 = until stopped)
 - `pinned` (boolean, optional): Pin display (pause rotation)
-- `start_service` (boolean, optional): Start the display service if it is not running (default: true). A running service is never restarted: it picks the request up within about a quarter of a second. When false and the service is stopped, the route returns 400.
+- `start_service` (boolean, optional): (Re)start the display service so it picks the request up (default: true)
 
 **Response**:
 ```json
@@ -870,13 +869,7 @@ Get a plugin's resource limits. `data` is `null` when none are configured.
 **POST** `/api/v3/plugins/limits/<plugin_id>`
 
 Set a plugin's resource limits. The body replaces all four limits: a key you
-omit is stored as no limit (`warning_threshold` defaults to `0.8`). Each value
-must be a non-negative number or `null`; anything else is a 400.
-
-The limits are stored in the shared cache. A display service that has already
-read limits for the plugin keeps using those until it restarts; likewise the
-health and metrics reset routes clear the stored record and the web process's
-copy, not the display service's in-memory state.
+omit is stored as no limit (`warning_threshold` defaults to `0.8`).
 
 **Request Body**:
 ```json
@@ -2118,18 +2111,13 @@ Errors use one of two shapes. Most endpoints answer:
 }
 ```
 
-An exception no route anticipated gets this shape too, with a 500, the
-message `An error occurred; see logs for details`, and `details` naming the
-exception type and text (credentials redacted). The api_v3 blueprint's
-error handler produces it, so it is the same for every `/api/v3` route.
-
-Endpoints built on the structured error helper add a code, and usually
-suggested fixes (the web UI's error dialog lists them):
+Endpoints built on the structured error helper add a code and category:
 
 ```json
 {
   "status": "error",
   "error_code": "CONFIG_SAVE_FAILED",
+  "error_category": "configuration",
   "message": "Error description",
   "details": "optional",
   "context": { },

docs/SCROLL_PERFORMANCE.md

@@ -207,10 +207,7 @@ Fixed by rebuilding the binding: `scripts/build_rgbmatrix_nogil.sh`.
 ### 3. Sub-pixel blending was wrong for this display
 
 Enabling it made things worse, not better — see the rule at the top. It is off
-by default everywhere. Vegas mode used to opt in; it now scrolls in whole
-pixels locked to the refresh like the plugin tickers, and keeps the blend only
-behind `display.vegas_scroll.sub_pixel_blend` (default `false`). The blend is
-also why text looked anti-aliased in the web preview while the panel shimmered.
+by default and only Vegas mode opts in via `set_sub_pixel_scrolling(True)`.
 
 ### 4. Frame-based stepping raced the vsync clock
 
@@ -234,9 +231,6 @@ advances by elapsed time at `scroll_speed / scroll_delay` px/s.
 
 ## Diagnosing a juddery scroller
 
-To check a whole rig rather than one scroller, soak it -- see *Soaking a rig*
-below.
-
 **An average will lie to you.** A 2 ms duplicate frame and a 21 ms double-wait
 mean exactly 10 ms, so a ticker stalling on half its frames still averages to a
 healthy 100 fps. The stats line reports the tail for that reason — read the
@@ -309,269 +303,6 @@ journalctl -u ledmatrix --since "-5min" --no-pager | grep -iE "px/s|px/frame"
 If a plugin logs its scroll config **twice** with different modes, the second
 line is what is running.
 
-## Soaking a rig
-
-The per-scroller lines above tell you *which* scroller misbehaves. The soak
-answers the question a release has to answer for each rig: **over a long run,
-how often did a moving frame reach the panel late?**
-
-Every frame reaches the panel through `DisplayManager.update_display`, so it is
-timed there once, whoever drew it -- Vegas, a ticker plugin, anything. The
-render thread only appends a tuple; a worker thread aggregates and rewrites
-`/dev/shm/ledmatrix_frame_stats.json` every 10 seconds (RAM, so no SD-card
-wear). `src/common/frame_timing.py` has the details.
-
-```bash
-python3 scripts/frame_soak.py                 # 10 minutes, as the display is now
-python3 scripts/frame_soak.py --preview       # with the web preview open
-python3 scripts/frame_soak.py --show          # totals since the service started
-python3 scripts/frame_soak.py --json a.json   # keep the report to compare later
-```
-
-It runs as any user next to the display service and stops nothing. It needs
-something to *scroll* during the run: a live game holding a static scoreboard
-on screen gives no verdict. `--preview` keeps the web preview's viewer marker
-fresh, which puts the preview's PNG encoding at full rate -- run it as the web
-service's user.
-
-| line | what it tells you |
-|---|---|
-| **Late frames** | Frames presented one or more refreshes after they were due: the panel showed the previous frame again, a visible hitch. **The pass/fail number**, 0.1% by default (`--max-late-pct`). Only intervals between two scrolling frames count, and a frame held for `frame_hold` refreshes is due `frame_hold` refreshes after the last. |
-| **Freezes** | Gaps of 250 ms or more inside a scroll: recomposes, plugin handovers, blocking calls on the render thread. Reported but not failed on, because some are handovers between plugins rather than faults. A gap still counts when the display's scroll state went missing for one frame across it, as long as scrolling resumes within 1 s: both of that frame's intervals count. Two static frames in a row end the scroll. (The state expires after 2 s without scroll activity, and plugins can clear it from their own `display()`.) The late and early rates are over frames judged against a known refresh period, which the recorder adopts once two windows in a row agree on it. |
-| **blit** | Copying the frame into the matrix canvas (`SetImage`). It grows with width × height × `pwm_bits`: ~5.5 ms at 512×64 with 8 bits on a Pi 4. It is the biggest fixed cost, and it sets the refresh rates a rig can hold one pixel per refresh at. |
-| **wait** | Time blocked in `SwapOnVSync`, i.e. the slack left in each refresh. A p50 near zero means the rig has no headroom and anything extra lands a frame late. |
-| **work** | Everything else between two frames: drawing, scrolling, and waiting for the GIL. A wide gap between its p50 and p99 is another thread getting in the way. |
-| **Binding** | `STOCK` means the rgbmatrix binding holds the GIL through the vsync wait, which starves every other thread. See *Rebuilding the binding*. |
-
-The refresh rate is estimated from the frames themselves (swaps that block on
-vsync can only land on refresh boundaries). Cross-check it with
-`scroll_speeds.py --measure` if it looks wrong. It can read high on a rig where
-nothing ever presented at the full refresh rate.
-
-A soak is only meaningful against a fixed workload. Compare runs with the same
-content and `--preview` setting, and alternate which build goes first when you
-A/B two of them. A live-API workload drifts over time.
-
-The soak says how often; the service's log says why. A scroll that presents no
-frame for 250 ms logs `Render stall:` with the stack of the render thread and
-the top of every other thread's, and whether the whole interpreter was blocked
-(C code holding the GIL) rather than one thread. To see what is behind the
-shorter hitches, run the service with `LEDMATRIX_STALL_WATCHDOG_MS=30`, which
-dumps at three refreshes late instead: its extra polling costs a little GIL
-time of its own, so do that on a diagnostic run, not a soak you are grading.
-`LEDMATRIX_STALL_WATCHDOG=0` turns it off.
-
-### Results: hdpi, 2026-09-24
-
-Pi 4, 4×128×64 on one chain (512×64), `gpio_slowdown` 3, cap 120 Hz, the
-GIL-releasing binding. Vegas mode with live content, 8-minute soaks with
-`--preview`, run in the order shown so each build went both first and last.
-
-| run | build | pacing | pwm_bits | refresh | late | 1 | 2 | 3–5 | 6+ | freezes |
-|---|---|---|---|---|---|---|---|---|---|---|
-| 1 | main | time-based, blended, 90 px/s | 8 | 94.5 Hz | 6.33% | 2,542 | 74 | 19 | 4 | 0 |
-| 2 | #628 | 1 px / refresh | 8 | 100.2 Hz | 0.66% | 238 | 32 | 30 | 5 | 2 |
-| 3 | #628 | 1 px / refresh | 8 | 100.3 Hz | 0.70% | 252 | 38 | 26 | 6 | 2 |
-| 4 | main | time-based, blended, 90 px/s | 8 | 94.5 Hz | 6.46% | 2,659 | 90 | 10 | 4 | 0 |
-| 5 | #628 | 1 px / 2 refreshes (53 px/s) | **7** | 107.2 Hz | 0.32% | 68 | 7 | 4 | 2 | 1 |
-
-- Blending cost the panel refresh rate as well as frames: 94.5 Hz against
-  ~100 Hz for the same hardware under whole-pixel pacing.
-- The freezes and the 3+ rows in the #628 runs line up with canvas-bound
-  plugins fetched on the render thread (`drain_deferred`): `news` took ~320 ms
-  and `hockey-scoreboard` ~660 ms there. Moving those
-  fetches off the render thread is proposed separately (offscreen rendering).
-- Run 5 changed two things at once: the speed, and `pwm_bits` (changed on the
-  rig between runs). Its lower late rate cannot be credited to either alone.
-- These soaks were taken before the recorder counted 1–2 s stalls as freezes,
-  so a stall of that length would be missing from these rows.
-
-### Without the service: `render_bench.py`
-
-The soak measures the service as it really runs: live content, plugin
-updates, the web preview. `scripts/render_bench.py` answers the narrower
-question underneath: *with nothing else in the way, can this hardware present
-every frame on time?* It scrolls a synthetic strip through the production path
--- a real `DisplayManager`, a real `ScrollHelper`, the same `scroll_config`
-resolver every ticker uses -- on content that is identical every run, which
-makes it the tool for comparing rigs (a Pi 3 against a Pi 4, one HAT against
-another) and for A/B testing a change to the render path.
-
-```bash
-sudo systemctl stop ledmatrix          # the service owns the GPIO
-
-sudo python3 scripts/render_bench.py                 # 60s at one pixel per refresh
-sudo python3 scripts/render_bench.py --seconds 600   # the shipping gate
-sudo python3 scripts/render_bench.py --speed 50      # a held (frame_hold 2) speed
-sudo python3 scripts/render_bench.py --busy 2        # with threads imitating plugin updates
-sudo python3 scripts/render_bench.py --json /tmp/pi4-512x64.json
-
-sudo systemctl start ledmatrix
-```
-
-It never starts or stops the service itself, so a crash in it cannot leave
-the panel dark. It grades with the same recorder as the soak and prints the
-same report, with the same exit status, except that **2** also means the run
-could not be set up at all (no root, no panel, a fallback display), so a rig
-that was never measured cannot pass by accident.
-
-Two differences from the soak matter:
-
-- **It measures the panel first.** Before scrolling it times bare swaps for a
-  few seconds to get the idle refresh rate, and seeds the recorder with it.
-  That is what catches a loop that never locked to the panel at all. The first
-  version of the bench announced its scrolling state once instead of every
-  frame; the state expired, the dirty-tracking skip fired mid-scroll, and the
-  loop free-ran at 827 fps. Graded against its own frames that looks perfectly
-  steady; graded against the panel's measured rate every frame is early, and
-  the run fails as NOT LOCKED. (The soak has no idle measurement, so it checks
-  the rate against `limit_refresh_rate_hz` instead: a "refresh" faster than
-  the cap cannot have been waiting for the panel.)
-- **The stall watchdog prints to the terminal.** A frame held up for more than
-  250 ms prints the stack of what held it up, in the middle of the run.
-
-Measured with the first version of the bench on hdpi (Pi 4, 512x64,
-`pwm_bits` 8), two-minute runs at one pixel per refresh: 8 of 11,449 frames
-late (0.070%), and with `--busy 2` 3 of 11,445 (0.026%). The render path and
-the hardware pass on their own. Compare the soak results above, from the same
-rig with the service running, for how much of the late rate comes from
-everything else.
-
-### The panel is slower while you are rendering into it
-
-The bench prints two refresh rates, and they differ:
-
-| | Pi 4, 512x64, `pwm_bits` 8 |
-|---|---|
-| idle, timing bare swaps | 100.4 Hz |
-| while scrolling | 96.3 Hz |
-
-Both are real. Driving an LED matrix is bit-banging on the same machine, so
-`SetImage` over a 512x64 chain contends with the refresh itself and slows it.
-The recorder therefore reads the rendering rate back from the frames: swaps
-that block on vsync can only return on a refresh boundary, so the low end of
-`interval / frame_hold` is the period. The idle figure is still printed,
-because the gap between the two is itself a measure of how expensive a frame
-is: **a rise in that gap is a render-cost regression even when nothing is
-late.**
-
-The practical consequence for config: set `limit_refresh_rate_hz` near the rate
-the panel holds *while rendering*, not the idle rate and certainly not a cap it
-can never reach. A cap well above the real rate makes `scroll_config` solve
-speeds against a refresh that does not exist, which is where "3px every 4
-refreshes" comes from.
-
-### Bench-only counters
-
-| line | meaning |
-|---|---|
-| `duplicate` | frames that advanced no pixels. A crisp fixed-step scroll should show none; any at all means the loop is presenting faster than the strip is moving. |
-| `blank` | frames with no visible slice to draw: the helper had no content. Should be zero. |
-| `restarts` | how many times the strip was scrolled through end to end. Informational: the bench restarts the strip where a plugin would hand over to the next one. |
-
-`--json` writes the full report plus the panel geometry, the solved speed and
-these counters, so two rigs (or one rig before and after a change) can be
-compared without re-reading a terminal.
-
----
-
-## A tear across the middle on fast scrolls
-
-**Symptom:** while text scrolls, the top and bottom halves of the panel look
-shifted sideways against each other along a horizontal line at mid-height, and
-the shift grows with scroll speed. It shows most in Vegas mode at high speed.
-
-**It is the panel's scan, not the software.** The measured panel, like most
-64-row panels, is multiplexed 1:32 (some panels of the same size scan
-differently, so check yours): it lights two rows at a time, one from each half
-(row 0 with row 32, row 1 with row 33, …), stepping down both halves together
-once per refresh. So row 31,
-the last row of the top half, lights almost a whole refresh period after row 32
-right below it. Your eye follows moving text, and moving content that lights at
-different times lands in different places, so the two rows meet with an offset
-of roughly
-
-```
-offset ≈ scroll speed × refresh period
-```
-
-Each frame reaches the panel whole (`SwapOnVSync` swaps complete frames between
-refreshes); the shift is created inside a single refresh. Other panel heights
-show it too, at the point where their two scan halves meet.
-
-On the 2×128×64 chain above, which refreshes at about 130 Hz flat out
-(7.7 ms per pass):
-
-| scroll speed | offset at the midline |
-|---|---|
-| 50 px/s (Vegas default) | ~0.4 px |
-| 100 px/s | ~0.8 px |
-| 150 px/s | ~1.2 px, plainly visible |
-
-### What the display does about it
-
-At one pixel per refresh, the fastest crisp speed, the step is exactly one
-refresh's worth of motion, so it can be cancelled: show one half of the panel
-a refresh behind the other -- the half whose row at the seam lights at the
-start of each refresh. The two rows either side of the seam then show the same
-moment again. What is left is a
-lean of one pixel per half from top to bottom, continuous across the panel,
-which reads as nothing where the step read as a tear. `DisplayManager` does
-this while something scrolls at one frame per refresh
-(`display.scan_order_compensation`, `"auto"` by default, `"off"` to disable;
-the geometry is in `src/scan_order.py`). The lagging rows come from the
-previous frame the display presented, so it works for Vegas and every plugin
-ticker without knowing how they scroll.
-
-Checked on hdpi (4×128×64 on one chain, rotated 180, 2026-09-24) before it was
-written: `scan_mode: 1` (interlaced) made the step vanish but turned moving
-edges grainy, and halving the speed halved it, so it is the scan and not a torn
-frame. With the compensation the step is gone at 90 px/s.
-
-It is left off where the row order is unknown or the maths does not hold:
-
-- **Slower speeds**, where each frame is held for two or more refreshes. The
-  offset there is half a pixel or less, and cancelling it would need a lag of
-  a fraction of a frame.
-- **Other layouts:** pixel mappers other than a 0 or 180 degree rotation
-  (U-mapper, 90/270), non-zero `multiplexing`, interlaced `scan_mode`, and a
-  canvas remapped to another height (double-sided mode).
-- **The emulator,** which has no scan order.
-
-### When it cannot apply
-
-Only a shorter scan period (a faster refresh) or a slower scroll. Measure what
-the panel actually achieves first. The library prints the rate with a carriage
-return and no newline, so read it from the raw journal:
-
-```bash
-# set display.hardware.show_refresh_rate to true (web UI, Display tab), restart, then:
-journalctl -u ledmatrix --since "-1min" --no-pager -o cat --all | grep -a -oE "[0-9.]+Hz" | tail -5
-```
-
-Turn it off again afterwards. Measured on that panel (Pi 4, single chain),
-changing one setting at a time from `pwm_bits: 7`, `gpio_slowdown: 3`:
-
-| change | refresh, uncapped | notes |
-|---|---|---|
-| none | ~130 Hz | the ceiling for this wiring |
-| `pwm_bits: 6` | ~138 Hz | barely faster, and half the colour depth |
-| `gpio_slowdown: 2` | ~130 Hz | no faster, **and visible glitching**; keep 3 |
-| `limit_refresh_rate_hz: 0` | ~130 Hz | Vegas dropped from 100 to 72–95 fps as the refresh thread took more CPU |
-
-None of these helps much, because the time goes into shifting each row's pixels
-out: a 2×128 chain pushes 256 pixels per row down one output. What does help is
-**fewer pixels per output**. On a bonnet with more than one output (the
-`regular` and `classic` mappings have 3; `adafruit-hat` has 1), put each panel
-on its own output and set `parallel` to the number of outputs used and
-`chain_length` to the panels per output, for example `parallel: 2`,
-`chain_length: 1` for two panels. Each refresh then shifts half the data, which
-should roughly double the refresh rate and halve the offset. That is a cable
-change, so measure again afterwards.
-
-Short of rewiring, keep fast scrolls moderate on those layouts: at 50 px/s the
-offset is under half a pixel.
-
 ## Rebuilding the binding
 
 ```bash

docs/SPORTS_UNIFICATION.md

@@ -73,21 +73,14 @@ B2 below promoted code into it (`SportsCore`, the mode classes,
 capabilities sections record that design, but none of it ships in core any
 more. Shared sports code lives in `src/common`:
 
-| Module | Since | Holds |
-|---|---|---|
-| `sports_scroll.py` | 3.2.0 | `SportsScrollDisplay` / `SportsScrollDisplayManager` — scroll orchestration (content building stays in the plugins) |
-| `sports_card.py` | 3.3.0 | Free functions for card settings, colours, favourite-team rules, dates and font sizes |
-| `sports_game_renderer.py` | 3.3.0 | `SportsGameRendererMixin` — scroll/Vegas card geometry |
-| `sports_shared.py` | 3.3.0 | `SportsCoreSharedMixin`, `SportsLiveSharedMixin`, `SportsRecentSharedMixin` — the sport-independent `sports.py` methods |
-| `sports_helpers.py` | 3.5.0 | clamp/logo/rotation free functions and `SportsHelpersMixin`, plus the `_favorite_key` seam |
-| `espn_dates.py` | 3.5.0 | ESPN date-range and `limit` workarounds |
-| `favorite_team_check.py` | 3.6.0 | `FavoriteTeamCheck` — logs why a favourite team code shows nothing |
-| `sports_timezone.py` | 3.6.0 | Which timezone start times are drawn in (`resolve_timezone_name`) |
-| `sports_celebration.py` | 3.7.0 | `SportsCelebrationMixin` — draws the score/win takeover; colour helpers |
-| `sports_fetch.py` | 3.7.0 | `SportsFetchMixin` — season fetch, live lookback and live-odds decisions |
-| `sports_card_wrappers.py` | 3.7.0 | `SportsCardWrappersMixin` — the game renderer's `sports_card` delegations |
-
-Each is described in [src/common/README.md](../src/common/README.md).
+```
+src/common/
+  sports_scroll.py       SportsScrollDisplay / …Manager — scroll orchestration
+                         (content building stays in the plugins)
+  sports_helpers.py      clamp/logo/rotation free functions + SportsHelpersMixin
+                         (3.5.0) — the helpers byte-identical in the
+                         plugins' sports.py, and the _favorite_key seam
+```
 
 ### Converging on `src/common`
 
@@ -97,7 +90,7 @@ modules taken from the plugin copies, each a **new module** rather than growth
 on an existing one: a plugin that deletes a method copy and relies on an older
 module having gained it fails at runtime with an `AttributeError`, while a
 missing module fails at load, where the version checks can see it.
-`sports_helpers.py` is the newest (it holds `_favorite_key`, the override point
+`sports_helpers.py` is the first (it holds `_favorite_key`, the override point
 listed below, for later phases); its parity test compares every body against
 the plugin copies when `LEDMATRIX_PLUGINS` points at a checkout, and
 `test/test_common_is_hardware_free.py` keeps `src/common` free of
@@ -171,15 +164,6 @@ Mix it in **before** the mode class — `class SoccerLive(CelebrationMixin,
 SportsLive)` — so the celebration `display()` runs first and falls through to
 the scorebug via `super()`.
 
-What shipped is narrower. `src/common/sports_celebration.py`
-(`SportsCelebrationMixin`) holds only the drawing, which is identical in the
-five scoreboards that celebrate (afl, football, hockey, nrl, soccer — hockey
-grew celebrations after this was written). Arming a celebration stays in each
-plugin: the trigger bodies differ (nrl matches favourites by team id, football
-folds a touchdown's extra point into one celebration and picks scenery by
-points), and so does `display()`. The seams above were not needed to move the
-drawing, so none was added.
-
 **Rotation strategies.** The three "dialects" turned out to be one algorithm
 (Smooth Weighted Round-Robin) in two shapes: an incremental picker holding state
 across calls (afl/nrl/soccer) and a precomputed per-cycle list

docs/STARLARK_APPS_GUIDE.md

@@ -102,16 +102,9 @@ cd /path/to/LEDMatrix
 bash scripts/download_pixlet.sh
 ```
 
-The script downloads only the Linux ARM64 build (Raspberry Pi OS 64-bit),
-from the `tronbyt/pixlet` releases, to `bin/pixlet/pixlet-linux-arm64`. On
-any other platform (32-bit Pi OS, x86_64, macOS), put a `pixlet` binary on
-your `PATH`, or set the plugin's `pixlet_path`, or place it in `bin/pixlet/`
-under the name `_find_pixlet_binary()` looks for
-([`web_interface/blueprints/api_v3/__init__.py`](../web_interface/blueprints/api_v3/__init__.py)).
-
 Verify installation:
 ```bash
-./bin/pixlet/pixlet-linux-arm64 version
+./bin/pixlet/pixlet-linux-amd64 version
 # Pixlet 0.50.2 (or later)
 ```
 
@@ -283,8 +276,10 @@ LEDMatrix/
 │           ├── hour_hand.png
 │           └── minute_hand.png
 │
-├── bin/pixlet/                     # Pixlet binary
-│   └── pixlet-linux-arm64          # the only one download_pixlet.sh fetches
+├── bin/pixlet/                     # Pixlet binaries
+│   ├── pixlet-linux-amd64
+│   ├── pixlet-linux-arm64
+│   └── pixlet-darwin-arm64
 │
 └── scripts/
     └── download_pixlet.sh          # Pixlet installer
@@ -329,7 +324,7 @@ Many apps require API keys for external services:
 **Solutions**:
 1. Check logs: `journalctl -u ledmatrix | grep -i pixlet`
 2. Verify config: Ensure all required fields are filled
-3. Test manually: `./bin/pixlet/pixlet-linux-arm64 render starlark-apps/{app-id}/{app-id}.star`
+3. Test manually: `./bin/pixlet/pixlet-linux-amd64 render starlark-apps/{app-id}/{app-id}.star`
 4. Missing assets: Some apps need images/fonts that may fail to download
 5. API issues: Check API keys and rate limits
 

docs/TROUBLESHOOTING.md

@@ -201,11 +201,10 @@ sudo systemctl restart ledmatrix-web
 
 **Solutions:**
 
-1. **Install dependencies** as root, so the root display service can import
-   them:
+1. **Install dependencies:**
    ```bash
-   sudo python3 -m pip install --break-system-packages --no-cache-dir -r requirements.txt
-   sudo python3 -m pip install --break-system-packages --no-cache-dir -r web_interface/requirements.txt
+   pip3 install --break-system-packages -r requirements.txt
+   pip3 install --break-system-packages -r web_interface/requirements.txt
    ```
 
 2. **Test imports step-by-step:**
@@ -251,18 +250,15 @@ sudo systemctl restart ledmatrix-web
 
 **Solutions:**
 
-[PERMISSIONS.md](PERMISSIONS.md) lists the expected owner and mode of every
-file and directory, and which `scripts/fix_perms/` script to run as which
-user. Don't `chown -R` the whole project: the two sudo helper scripts in
-`scripts/fix_perms/` must stay owned by root.
-
 ```bash
-# Config files: web user owns both; secrets must stay 640
-stat -c '%U:%G %a %n' config/config.json config/config_secrets.json
+# Fix ownership of LEDMatrix directory
+sudo chown -R ledpi:ledpi /home/ledpi/LEDMatrix
+
+# Fix config file permissions
 sudo chmod 644 config/config.json
 sudo chmod 640 config/config_secrets.json
 
-# Which user the web interface runs as
+# Verify service runs as correct user
 sudo systemctl cat ledmatrix-web | grep User
 ```
 
@@ -466,17 +462,15 @@ sudo systemctl cat ledmatrix-web | grep User
    }
    ```
 
-   Or toggle the plugin on in the **Plugin Manager** tab, which writes the
-   same flag.
+2. **Restart display:**
+   ```bash
+   sudo systemctl restart ledmatrix
+   ```
 
-2. **Wait a few seconds.** The display service watches `config.json` and
-   loads a newly enabled plugin without a restart
-   (`DisplayController._reconcile_enabled_plugins()` in
-   [`src/display_controller.py`](../src/display_controller.py)). This
-   needs hot reload, which is on unless `LEDMATRIX_HOT_RELOAD=false` is set.
-
-3. **If it still does not appear**, check the logs for a config validation
-   error, then restart: `sudo systemctl restart ledmatrix`
+3. **Verify in web interface:**
+   - Open the **Plugin Manager** tab
+   - Toggle the plugin switch to enable
+   - From **Overview**, click **Restart Display Service**
 
 #### Plugin Not Loading
 
@@ -497,12 +491,10 @@ sudo systemctl cat ledmatrix-web | grep User
    # Verify all required fields present
    ```
 
-3. **Check dependencies installed.** Install them with `sudo`: the display
-   service runs as root and does not see packages pip put in your user's
-   `~/.local` (see [PLUGIN_DEPENDENCY_GUIDE.md](PLUGIN_DEPENDENCY_GUIDE.md)):
+3. **Check dependencies installed:**
    ```bash
    if [ -f plugin-repos/plugin-id/requirements.txt ]; then
-     sudo python3 -m pip install --break-system-packages --no-cache-dir -r plugin-repos/plugin-id/requirements.txt
+     pip3 install --break-system-packages -r plugin-repos/plugin-id/requirements.txt
    fi
    ```
 
@@ -511,9 +503,14 @@ sudo systemctl cat ledmatrix-web | grep User
    sudo journalctl -u ledmatrix -f | grep plugin-id
    ```
 
-5. **Load and render the plugin headlessly:**
+5. **Test plugin import:**
    ```bash
-   python3 scripts/check_plugin.py --plugin plugin-id
+   python3 -c "
+   import sys
+   sys.path.insert(0, 'plugin-repos/plugin-id')
+   from manager import PluginClass
+   print('Plugin imports successfully')
+   "
    ```
 
 #### Stale Cache Data
@@ -543,12 +540,10 @@ sudo systemctl cat ledmatrix-web | grep User
    sudo systemctl restart ledmatrix
    ```
 
-2. **Check cache permissions.** Expected: `root:ledmatrix`, `drwxrwsr-x`.
-   `setup_cache.sh` restores that layout (see
-   [PERMISSIONS.md](PERMISSIONS.md#repair-scripts)):
+2. **Check cache permissions:**
    ```bash
    ls -ld /var/cache/ledmatrix
-   sudo bash scripts/install/setup_cache.sh
+   sudo ./scripts/fix_perms/fix_cache_permissions.sh
    ```
 
 ---
@@ -616,15 +611,6 @@ sudo systemctl cat ledmatrix-web | grep User
    ```
    **Note:** Minimum recommended: 300 seconds (5 minutes)
 
-   How often the core calls the plugin's `update()` comes from the plugin
-   itself first: its `get_update_interval()` if it has one, then
-   `update_interval` in its `manifest.json`. The `update_interval` in
-   `config.json` is used by the scheduler only when the manifest sets none.
-   Many plugins also read their own config `update_interval` and skip the
-   API call inside `update()` until it has elapsed, which is what makes the
-   setting above effective; check the plugin's settings form or
-   `config_schema.json` for the option it actually honours.
-
 2. **Check current rate limit usage:**
    - OpenWeatherMap free tier: 1,000 calls/day, 60 calls/minute
    - With 300s interval: 288 calls/day (well within limits)

docs/WEB_INTERFACE_GUIDE.md

@@ -161,11 +161,7 @@ duration, and related settings — so you can configure Vegas mode
 entirely from the web UI without hand-editing JSON. See
 [ADVANCED_FEATURES.md](ADVANCED_FEATURES.md) for what the options do.
 
-Brightness and the Vegas Scroll settings apply to the running display
-within a few seconds. Matrix hardware settings (rows, columns, chain length,
-mapping, GPIO slowdown, PWM and refresh settings) are only read when the
-display starts, so those need **Restart Display Service** from the Overview
-tab.
+Changes require **Restart Display Service** from the Overview tab.
 
 ### Plugin Manager Tab
 
@@ -252,16 +248,16 @@ View real-time system logs:
 
 1. Open the **Display** tab
 2. Adjust the **Brightness** slider (1–100)
-3. Click **Save**. The panel picks up the new brightness within a few
-   seconds; no restart is needed
+3. Click **Save**
+4. Click **Restart Display Service** on the **Overview** tab
 
 ### Installing a New Plugin
 
 1. Open the **Plugin Manager** tab
 2. Scroll to the **Plugin Store** section and browse or search
 3. Click **Install** next to the plugin
-4. Toggle the plugin on in **Installed Plugins**. The running display
-   loads it within a few seconds; no restart is needed
+4. Toggle the plugin on in **Installed Plugins**
+5. Click **Restart Display Service** on **Overview**
 
 ### Configuring a Plugin
 

docs/widget-guide.md

@@ -1,7 +1,590 @@
 # Widget Development Guide
 
-The widget guide lives next to the widgets, in
-[web_interface/static/v3/js/widgets/README.md](../web_interface/static/v3/js/widgets/README.md).
-It lists every built-in `x-widget`, the schema keywords the config form
-understands (`x-options.labels`, `x-advanced`, `x-display: "hidden"`), and how
-to ship a custom widget with a plugin.
+## Overview
+
+The LEDMatrix Widget Registry system allows plugins to use reusable UI components for configuration forms. This enables:
+
+- **Reusable Components**: Use existing widgets (file upload, checkboxes, etc.) without custom code
+- **Custom Widgets**: Create plugin-specific widgets without modifying the LEDMatrix codebase
+- **Backwards Compatibility**: Existing plugins continue to work without changes
+
+## Available Core Widgets
+
+### Plugin File Manager Widget (`plugin-file-manager`)
+
+Full inline file management UI for plugins that manage files via the `web_ui_actions` system. Renders a card grid, upload zone, create/delete modals, and an entry table editor — entirely inline, no iframe.
+
+`plugin_id` is **automatically injected** from template context. File operations call `/api/v3/plugins/action` immediately on user action; no Save Configuration needed.
+
+**Schema Configuration:**
+```json
+{
+  "file_manager": {
+    "type": "null",
+    "title": "Data Files",
+    "x-widget": "plugin-file-manager",
+    "x-widget-config": {
+      "actions": {
+        "list":   "list-files",
+        "get":    "get-file",
+        "save":   "save-file",
+        "upload": "upload-file",
+        "delete": "delete-file",
+        "create": "create-file",
+        "toggle": "toggle-category"
+      },
+      "upload_hint":      "JSON files with day numbers 1–365 as keys",
+      "directory_label":  "my_data/",
+      "create_fields": [
+        { "key": "category_name", "label": "Category Name",
+          "placeholder": "e.g., my_words", "pattern": "^[a-z0-9_]+$",
+          "hint": "Lowercase letters, numbers, underscores" },
+        { "key": "display_name", "label": "Display Name",
+          "placeholder": "e.g., My Words", "hint": "Optional" }
+      ]
+    }
+  }
+}
+```
+
+**`list` is required** — the widget calls it on render to populate the file grid; omitting it leaves the widget stuck in a loading state. All other actions are optional — omit any key to hide its UI element (e.g., no `create` = no New File button, no `toggle` = no enable/disable switch).
+
+The edit view auto-detects whether file content is tabular (object-of-objects with uniform keys) and shows a paginated table editor with inline cells. Otherwise falls back to a JSON textarea.
+
+**Used by:** of-the-day
+
+---
+
+### Time Picker Widget (`time-picker`)
+
+Single time selection using the browser's native time input. Returns a string in `HH:MM` (24-hour) format. Generic — works in any plugin without configuration.
+
+**Schema Configuration:**
+```json
+{
+  "target_time": {
+    "type": "string",
+    "x-widget": "time-picker",
+    "default": "00:00",
+    "x-options": {
+      "placeholder": "Select time",
+      "clearable": true
+    }
+  }
+}
+```
+
+**Used by:** countdown
+
+---
+
+### File Upload Single Widget (`file-upload-single`)
+
+Single-image upload for string fields. Uploads to the plugin's asset folder (`assets/plugins/<plugin_id>/uploads/`) and sets the string field value to the returned relative path. Shows a thumbnail preview and a clear button. The `plugin_id` is **automatically injected** from the template context — no need to specify it in the schema.
+
+**Schema Configuration:**
+```json
+{
+  "image_path": {
+    "type": "string",
+    "x-widget": "file-upload-single",
+    "x-upload-config": {
+      "allowed_types": ["image/png", "image/jpeg", "image/bmp", "image/gif"],
+      "max_size_mb": 5
+    }
+  }
+}
+```
+
+Note: Unlike `file-upload` (array-level), this widget is for a single `string` field. It is ideal for per-item images inside `array-table` rows.
+
+**Used by:** countdown
+
+---
+
+### File Upload Widget (`file-upload`)
+
+Upload and manage image files with drag-and-drop support, preview, delete, and scheduling.
+
+**Schema Configuration:**
+```json
+{
+  "type": "array",
+  "x-widget": "file-upload",
+  "x-upload-config": {
+    "plugin_id": "my-plugin",
+    "max_files": 10,
+    "max_size_mb": 5,
+    "allowed_types": ["image/png", "image/jpeg", "image/bmp", "image/gif"]
+  }
+}
+```
+
+**Used by:** static-image, news plugins
+
+### Checkbox Group Widget (`checkbox-group`)
+
+Multi-select checkboxes for array fields with enum items.
+
+**Schema Configuration:**
+```json
+{
+  "type": "array",
+  "x-widget": "checkbox-group",
+  "items": {
+    "type": "string",
+    "enum": ["option1", "option2", "option3"]
+  },
+  "x-options": {
+    "labels": {
+      "option1": "Option 1 Label",
+      "option2": "Option 2 Label"
+    }
+  }
+}
+```
+
+**Used by:** odds-ticker, news plugins
+
+### Custom Feeds Widget (`custom-feeds`)
+
+Table-based RSS feed editor with logo uploads.
+
+**Schema Configuration:**
+```json
+{
+  "type": "array",
+  "x-widget": "custom-feeds",
+  "items": {
+    "type": "object",
+    "properties": {
+      "name": { "type": "string" },
+      "url": { "type": "string", "format": "uri" },
+      "enabled": { "type": "boolean" },
+      "logo": { "type": "object" }
+    }
+  },
+  "maxItems": 50
+}
+```
+
+**Used by:** news plugin (for custom RSS feeds)
+
+## Using Existing Widgets
+
+To use an existing widget in your plugin's `config_schema.json`, simply add the `x-widget` property:
+
+```json
+{
+  "properties": {
+    "my_images": {
+      "type": "array",
+      "x-widget": "file-upload",
+      "x-upload-config": {
+        "plugin_id": "my-plugin",
+        "max_files": 5
+      }
+    },
+    "enabled_leagues": {
+      "type": "array",
+      "x-widget": "checkbox-group",
+      "items": {
+        "type": "string",
+        "enum": ["nfl", "nba", "mlb"]
+      },
+      "x-options": {
+        "labels": {
+          "nfl": "NFL",
+          "nba": "NBA",
+          "mlb": "MLB"
+        }
+      }
+    }
+  }
+}
+```
+
+The widget will be automatically rendered when the plugin configuration form is loaded.
+
+## Labelling Enum Options (`x-options.labels`)
+
+A plain `enum` renders as a dropdown whose option text is the value with
+underscores replaced and title case applied — `day_first` becomes "Day First".
+That is fine for values that read as their own label, and wrong for values that
+do not: `vs` becomes "Vs", and `abbrev` says nothing about the `Sep 19` it
+actually produces.
+
+Supply `x-options.labels` to set the visible text. This is the same convention
+the `checkbox-group` widget uses:
+
+```json
+{
+  "date_format": {
+    "type": "string",
+    "enum": ["abbrev", "numeric", "day_first"],
+    "default": "abbrev",
+    "x-options": {
+      "labels": {
+        "abbrev": "Sep 19",
+        "numeric": "9/19",
+        "day_first": "19 Sep"
+      }
+    }
+  }
+}
+```
+
+Labels are **display only** — the stored value is still the enum value, so
+adding them never changes a saved config. The map may be partial: any value
+without a label keeps the humanised fallback. Older cores that predate this
+support ignore `x-options` and render the fallback for every option, so a
+plugin can ship labels without requiring a core upgrade.
+
+Array-table columns (`x-widget: array-table`) accept the same
+`x-options.labels` on a column definition, but their fallback is the **raw
+value** rather than the humanised one, because those columns hold values such
+as ticker symbols where `aapl` → "Aapl" would be wrong. Rows added in the
+browser use the labels too (`array-table.js`), so a column reads the same
+before and after a page reload.
+
+## Marking Fields as Advanced (`x-advanced`)
+
+Add `"x-advanced": true` to any top-level, non-object property to move it out
+of the main form and into a single collapsed **Advanced Settings** section at
+the bottom of the plugin's configuration page:
+
+```json
+{
+  "properties": {
+    "city": {
+      "type": "string",
+      "title": "City"
+    },
+    "request_timeout": {
+      "type": "integer",
+      "default": 10,
+      "description": "HTTP timeout in seconds",
+      "x-advanced": true
+    }
+  }
+}
+```
+
+Guidelines:
+
+- Use it for fine-tuning knobs most users never touch (timeouts, retry
+  behavior, cache TTLs, styling overrides). Anything a first-time user must
+  set to get the plugin working should stay basic.
+- Nothing is hidden permanently — the section expands on click, and the
+  settings search finds and auto-expands advanced fields like any others.
+- The flag is ignored on `object`-type properties (they already render as
+  their own collapsible sections) and is safely ignored by older cores, so
+  adding it never breaks compatibility.
+
+## Hiding Fields From the Form (`x-display: "hidden"`)
+
+Add `"x-display": "hidden"` to a property that must stay in the schema but
+should not appear as a control: a deprecated key kept so existing configs keep
+validating, or an internal value such as an auto-generated row id.
+
+```json
+{
+  "properties": {
+    "radar_zoom": {
+      "type": "integer",
+      "default": 6,
+      "title": "Radar Zoom Level (deprecated)",
+      "x-display": "hidden"
+    }
+  }
+}
+```
+
+What the core does with it:
+
+- **Not rendered** at any depth: top-level fields, children of an object
+  section, and properties of array-of-object items (never a table column, even
+  if `x-columns` names it, and never in the row editor). A hidden field flagged
+  `x-advanced` is not listed or counted in Advanced Settings, and an object
+  whose children are all hidden draws no empty section. Hidden fields don't
+  show up in the settings search either, since it indexes the rendered form.
+- **Stored value preserved on save.** Saving the form never changes a hidden
+  value. The unchecked-checkbox rule ignores a hidden boolean. Array rows carry
+  a hidden property's stored value through the form, so the value survives the
+  row being posted back; a new row gets no value (the plugin fills it in).
+- **The API is unaffected.** A JSON save to `POST /api/v3/plugins/config` can
+  still set a hidden field.
+
+Older cores ignore the flag and render the field as a normal control.
+
+## Creating Custom Widgets
+
+### Step 1: Create Widget File
+
+Create a JavaScript file in your plugin's `widgets/` directory, named
+`widgets/[widget-name].js`. The directory is not optional: it is the only
+place the core will serve a widget from.
+
+```javascript
+// Ensure LEDMatrixWidgets registry is available
+if (typeof window.LEDMatrixWidgets === 'undefined') {
+    console.error('LEDMatrixWidgets registry not found');
+    return;
+}
+
+// Register your widget
+window.LEDMatrixWidgets.register('my-custom-widget', {
+    name: 'My Custom Widget',
+    version: '1.0.0',
+    
+    /**
+     * Render the widget HTML
+     * @param {HTMLElement} container - Container element to render into
+     * @param {Object} config - Widget configuration from schema
+     * @param {*} value - Current value
+     * @param {Object} options - Additional options (fieldId, pluginId, etc.)
+     */
+    render: function(container, config, value, options) {
+        const fieldId = options.fieldId || container.id;
+        
+        // Always escape HTML to prevent XSS
+        const escapeHtml = (text) => {
+            const div = document.createElement('div');
+            div.textContent = text;
+            return div.innerHTML;
+        };
+        
+        container.innerHTML = `
+            <div class="my-custom-widget">
+                <input type="text" 
+                       id="${fieldId}_input" 
+                       value="${escapeHtml(value || '')}"
+                       class="w-full px-3 py-2 border border-gray-300 rounded">
+            </div>
+        `;
+        
+        // Attach event listeners
+        const input = container.querySelector('input');
+        input.addEventListener('change', (e) => {
+            this.handlers.onChange(fieldId, e.target.value);
+        });
+    },
+    
+    /**
+     * Get current value from widget
+     */
+    getValue: function(fieldId) {
+        const input = document.querySelector(`#${fieldId}_input`);
+        return input ? input.value : null;
+    },
+    
+    /**
+     * Set value programmatically
+     */
+    setValue: function(fieldId, value) {
+        const input = document.querySelector(`#${fieldId}_input`);
+        if (input) {
+            input.value = value || '';
+        }
+    },
+    
+    /**
+     * Event handlers
+     */
+    handlers: {
+        onChange: function(fieldId, value) {
+            // Trigger form change event
+            const event = new CustomEvent('widget-change', {
+                detail: { fieldId, value },
+                bubbles: true
+            });
+            document.dispatchEvent(event);
+        }
+    }
+});
+```
+
+### Step 2: Declare the Widget in `manifest.json`
+
+The manifest is the allowlist. A widget is served only if the plugin declares
+it, so shipping a file under `widgets/` does not by itself publish it:
+
+```json
+{
+  "widgets": [
+    {
+      "name": "my-custom-widget",
+      "script": "my-custom-widget.js",
+      "description": "What this widget is for"
+    }
+  ]
+}
+```
+
+`name` is what you use in `x-widget` and in the URL. `script` is optional and
+defaults to `[name].js`; it must be a plain filename directly inside
+`widgets/` (no paths). Both are validated against
+`schema/manifest_schema.json`.
+
+### Step 3: Reference Widget in Schema
+
+In your plugin's `config_schema.json`:
+
+```json
+{
+  "properties": {
+    "my_field": {
+      "type": "string",
+      "description": "My custom field",
+      "x-widget": "my-custom-widget",
+      "default": ""
+    }
+  }
+}
+```
+
+### Step 4: Widget Loading
+
+The widget is loaded on demand when the plugin's configuration form renders a
+field that references it. The system will:
+
+1. Check whether the widget is already registered in the core registry.
+2. If not, fetch it from `/static/plugin-widgets/[plugin-id]/[widget-name].js`.
+   That route serves the declared `script` from your plugin's `widgets/`
+   directory, as `text/javascript`.
+3. Render it by calling the `render` function your script registered.
+
+The fetch uses a dynamic `import()`, so the file must parse as an ES module.
+A plain IIFE does — modules are strict mode, so avoid sloppy-mode constructs.
+
+**If the widget fails to load** (not declared, file missing, script throws, or
+it never calls `register`), the field falls back to a plain text input holding
+the current value. This is deliberate: a broken widget costs the user an
+editor, not their configured value.
+
+**Limitation:** the on-demand path applies to `string`-typed fields (the
+default branch of the config-form renderer). Fields typed `object`, `array`,
+`boolean`, `integer` or `number`, and fields whose `enum` is set, are
+dispatched by the server-side template to its own built-in renderers, so a
+plugin-supplied `x-widget` on one of those is ignored today.
+
+## Widget API Reference
+
+### Widget Definition Object
+
+```javascript
+{
+    name: string,           // Human-readable widget name
+    version: string,        // Widget version
+    render: function,       // Required: Render function
+    getValue: function,     // Optional: Get current value
+    setValue: function,     // Optional: Set value programmatically
+    handlers: object        // Optional: Event handlers
+}
+```
+
+### Render Function
+
+```javascript
+render(container, config, value, options)
+```
+
+**Parameters:**
+- `container` (HTMLElement): Container element to render into
+- `config` (Object): Widget configuration from schema
+- `value` (*): Current field value
+- `options` (Object): Additional options
+  - `fieldId` (string): Field ID
+  - `pluginId` (string): Plugin ID
+  - `fullKey` (string): Full field key path
+
+### Get Value Function
+
+```javascript
+getValue(fieldId)
+```
+
+**Returns:** Current widget value
+
+### Set Value Function
+
+```javascript
+setValue(fieldId, value)
+```
+
+**Parameters:**
+- `fieldId` (string): Field ID
+- `value` (*): Value to set
+
+## Examples
+
+See [`web_interface/static/v3/js/widgets/example-color-picker.js`](../web_interface/static/v3/js/widgets/example-color-picker.js) for a complete example of a custom color picker widget.
+
+## Best Practices
+
+### Security
+
+1. **Always escape HTML**: Use `escapeHtml()` or `textContent` to prevent XSS
+2. **Validate inputs**: Validate user input before processing
+3. **Sanitize values**: Clean values before storing
+
+### Performance
+
+1. **Lazy loading**: Load widget scripts only when needed
+2. **Event delegation**: Use event delegation for dynamic content
+3. **Debounce**: Debounce frequent events (e.g., input changes)
+
+### Accessibility
+
+1. **Labels**: Always associate labels with inputs
+2. **ARIA attributes**: Use appropriate ARIA attributes
+3. **Keyboard navigation**: Ensure keyboard accessibility
+
+## Troubleshooting
+
+### Widget Not Loading
+
+1. Check browser console for errors
+2. Verify widget file path is correct
+3. Ensure `LEDMatrixWidgets.register()` is called
+4. Check that widget name matches schema `x-widget` value
+
+### Widget Not Rendering
+
+1. Verify `render` function is defined
+2. Check container element exists
+3. Ensure widget is registered before form loads
+4. Check for JavaScript errors in console
+
+### Value Not Saving
+
+1. Ensure widget triggers `widget-change` event
+2. Verify form submission includes widget value
+3. Check `getValue` function returns correct type
+4. Verify field name matches schema property
+
+## Current Implementation Status
+
+**Phase 1 Complete:**
+- ✅ Widget registry system created
+- ✅ Core widgets extracted to separate files
+- ✅ Widget handlers available globally (backwards compatible)
+- ✅ Plugin widget loading system implemented
+
+**Current Behavior:**
+- Core widgets are server-side rendered via Jinja2 templates (existing behavior preserved)
+- Widget handlers are registered and available globally
+- Custom widgets can be created, declared in `manifest.json`, and are served
+  and rendered on demand for `string`-typed fields
+- Plugin widgets on non-string fields are not dispatched yet (see Step 4)
+
+**Backwards Compatibility:**
+- All existing plugins using widgets continue to work without changes
+- Server-side rendering remains the primary method
+- Widget registry provides foundation for future enhancements
+
+## See Also
+
+- [Widget README](../web_interface/static/v3/js/widgets/README.md) - Complete widget development guide with examples
+- [Plugin Development Guide](PLUGIN_DEVELOPMENT_GUIDE.md) - General plugin development
+- [Plugin Configuration Guide](PLUGIN_CONFIGURATION_GUIDE.md) - Configuration setup

first_time_install.sh

@@ -18,7 +18,7 @@ on_error() {
         echo "-- Last 100 lines from log --" >&2
         tail -n 100 "$LOG_FILE" >&2 || true
     fi
-    printf '\nCommon fixes:\n' >&2
+    echo "\nCommon fixes:" >&2
     echo "- Ensure the Pi is online (try: ping -c1 8.8.8.8)." >&2
     echo "- If you saw an APT lock error: wait a minute, close other installers, then run: sudo dpkg --configure -a" >&2
     echo "- Re-run this script. It is safe to run multiple times." >&2
@@ -115,8 +115,7 @@ fi
 echo "✓ OS requirements met"
 echo ""
 
-# The user who ran the installer: SUDO_USER once we are running under sudo
-# (the re-exec below guarantees that), otherwise whoever we are now.
+# Get the actual user who invoked sudo (set after we ensure sudo below)
 if [ -n "${SUDO_USER:-}" ]; then
     ACTUAL_USER="$SUDO_USER"
 else
@@ -203,7 +202,7 @@ echo ""
 # Check if running as root; if not, try to elevate automatically for novices
 if [ "$EUID" -ne 0 ]; then
     echo "This script needs administrator privileges. Attempting to re-run with sudo..."
-    exec sudo -E bash "$0" "$@"
+    exec sudo -E env LEDMATRIX_ELEVATED=1 bash "$0" "$@"
 fi
 echo "✓ Running as root (required for installation)"
 
@@ -503,44 +502,6 @@ print_rgbmatrix_build_failure() {
     fi
 }
 
-# Set WEB_SERVICE_USER to the account ledmatrix-web.service runs as, or "root"
-# when it cannot tell. Steps 3.1 and 11 choose plugin-directory ownership from
-# it. The logic was pasted three times, identically, and is kept verbatim here.
-# Note: install_web_service.sh and install_service.sh no longer contain the
-# "User=root" / "User=${ACTUAL_USER}" strings grepped for below (the units come
-# from systemd/*.service templates with User=__USER__). So once the unit is
-# installed (Step 7.5, by install_service.sh) the first branch reads its real
-# User=; before that the second branch is taken whenever
-# install_web_service.sh exists, matches neither string, and yields "root" --
-# the later branches are reached only if that script is missing.
-detect_web_service_user() {
-    WEB_SERVICE_USER="root"
-    if [ -f "/etc/systemd/system/ledmatrix-web.service" ]; then
-        # Check actual installed service file (most accurate)
-        WEB_SERVICE_USER=$(grep "^User=" /etc/systemd/system/ledmatrix-web.service | cut -d'=' -f2 || echo "root")
-    elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh" ]; then
-        # Check install_web_service.sh (used by first_time_install.sh)
-        if grep -q "User=root" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
-            WEB_SERVICE_USER="root"
-        elif grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
-            WEB_SERVICE_USER="$ACTUAL_USER"
-        fi
-    elif [ -f "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" ]; then
-        # Check template file (may have placeholder)
-        WEB_SERVICE_USER=$(grep "^User=" "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" | cut -d'=' -f2 || echo "root")
-        # If template has placeholder, check install script
-        if [ "$WEB_SERVICE_USER" = "__USER__" ] || [ -z "$WEB_SERVICE_USER" ]; then
-            # Check install_service.sh to see what user it uses
-            if [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
-                WEB_SERVICE_USER="$ACTUAL_USER"
-            fi
-        fi
-    elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
-        # Web service will be installed by install_service.sh as ACTUAL_USER
-        WEB_SERVICE_USER="$ACTUAL_USER"
-    fi
-}
-
 echo ""
 echo "This script will perform the following steps:"
 echo "1. Check prerequisites (network, disk, memory) and install system dependencies"
@@ -673,9 +634,8 @@ else
     echo "Setting ownership of assets directory..."
     chown -R "$ACTUAL_USER:$ACTUAL_USER" "$PROJECT_ROOT_DIR/assets"
     
-    # 777: read/write for owner, group and every other account. Root (the
-    # display service) does not need it -- root ignores mode bits -- so the
-    # "other" bits only matter to accounts that are neither the owner nor root.
+    # Set permissions to allow read/write for owner, group, and others (for root service user)
+    # Note: 777 allows root (service user) to write, which is necessary when service runs as root
     echo "Setting permissions for assets directory..."
     chmod -R 777 "$PROJECT_ROOT_DIR/assets"
     
@@ -739,7 +699,32 @@ else
     fi
     
     # Determine ownership based on web service user
-    detect_web_service_user
+    # Check if web service file exists and what user it runs as
+    WEB_SERVICE_USER="root"
+    if [ -f "/etc/systemd/system/ledmatrix-web.service" ]; then
+        # Check actual installed service file (most accurate)
+        WEB_SERVICE_USER=$(grep "^User=" /etc/systemd/system/ledmatrix-web.service | cut -d'=' -f2 || echo "root")
+    elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh" ]; then
+        # Check install_web_service.sh (used by first_time_install.sh)
+        if grep -q "User=root" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+            WEB_SERVICE_USER="root"
+        elif grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+            WEB_SERVICE_USER="$ACTUAL_USER"
+        fi
+    elif [ -f "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" ]; then
+        # Check template file (may have placeholder)
+        WEB_SERVICE_USER=$(grep "^User=" "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" | cut -d'=' -f2 || echo "root")
+        # If template has placeholder, check install script
+        if [ "$WEB_SERVICE_USER" = "__USER__" ] || [ -z "$WEB_SERVICE_USER" ]; then
+            # Check install_service.sh to see what user it uses
+            if [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+                WEB_SERVICE_USER="$ACTUAL_USER"
+            fi
+        fi
+    elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+        # Web service will be installed by install_service.sh as ACTUAL_USER
+        WEB_SERVICE_USER="$ACTUAL_USER"
+    fi
     
     # If web service runs as ACTUAL_USER (not root), set ownership to ACTUAL_USER
     # so the web service can change permissions. Root service can still access via group (775).
@@ -773,7 +758,32 @@ if [ ! -d "$PLUGIN_REPOS_DIR" ]; then
 fi
 
 # Determine ownership based on web service user
-detect_web_service_user
+# Check if web service file exists and what user it runs as
+WEB_SERVICE_USER="root"
+if [ -f "/etc/systemd/system/ledmatrix-web.service" ]; then
+    # Check actual installed service file (most accurate)
+    WEB_SERVICE_USER=$(grep "^User=" /etc/systemd/system/ledmatrix-web.service | cut -d'=' -f2 || echo "root")
+elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh" ]; then
+    # Check install_web_service.sh (used by first_time_install.sh)
+    if grep -q "User=root" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+        WEB_SERVICE_USER="root"
+    elif grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+        WEB_SERVICE_USER="$ACTUAL_USER"
+    fi
+elif [ -f "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" ]; then
+    # Check template file (may have placeholder)
+    WEB_SERVICE_USER=$(grep "^User=" "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" | cut -d'=' -f2 || echo "root")
+    # If template has placeholder, check install script
+    if [ "$WEB_SERVICE_USER" = "__USER__" ] || [ -z "$WEB_SERVICE_USER" ]; then
+        # Check install_service.sh to see what user it uses
+        if [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+            WEB_SERVICE_USER="$ACTUAL_USER"
+        fi
+    fi
+elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+    # Web service will be installed by install_service.sh as ACTUAL_USER
+    WEB_SERVICE_USER="$ACTUAL_USER"
+fi
 
 # If web service runs as ACTUAL_USER (not root), set ownership to ACTUAL_USER
 # so the web service can change permissions. Root service can still access via group (775).
@@ -787,8 +797,8 @@ else
     chown -R root:"$ACTUAL_USER" "$PLUGIN_REPOS_DIR"
 fi
 
-# Set directory permissions (2775: rwxrwsr-x, setgid so new entries inherit the group)
-echo "Setting plugin-repos directory permissions to 2775 (setgid)..."
+# Set directory permissions (775: rwxrwxr-x)
+echo "Setting plugin-repos directory permissions to 2775 (sticky bit)..."
 find "$PLUGIN_REPOS_DIR" -type d -exec chmod 2775 {} \;
 
 # Set file permissions (664: rw-rw-r--)
@@ -995,9 +1005,9 @@ if [ -f "$PROJECT_ROOT_DIR/requirements.txt" ]; then
         PACKAGE_NUM=$((PACKAGE_NUM + 1))
         echo "[$PACKAGE_NUM/$TOTAL_PACKAGES] Installing: $line"
         
-        # Install with a timeout where available. --verbose output goes to
-        # $INSTALL_OUTPUT (filtered below, full copy in the log); --no-cache-dir
-        # avoids pip cache issues.
+        # Check if package is already installed (basic check - may not catch all cases)
+        # Try installing with verbose output and timeout (if available)
+        # Use --no-cache-dir to avoid cache issues, --verbose for diagnostics
         INSTALL_OUTPUT=$(mktemp)
         INSTALL_SUCCESS=false
         
@@ -1302,11 +1312,7 @@ else
             WEB_DEPS_OK=false
         fi
     else
-        # No marker means Step 5 did not install web_interface/requirements.txt,
-        # and without the smart installer there is nothing else to try here.
-        echo "⚠ scripts/install_dependencies_apt.py not found, and Step 5 did not install"
-        echo "  web_interface/requirements.txt, so web interface dependencies may be missing."
-        WEB_DEPS_OK=false
+        echo "Web dependencies already installed from web_interface/requirements.txt in Step 5"
     fi
 
     # Create the marker only when installation actually succeeded, so a
@@ -1510,31 +1516,51 @@ POWEROFF_PATH=$(which poweroff)
 BASH_PATH=$(which bash)
 JOURNALCTL_PATH=$(which journalctl 2>/dev/null || true)
 
-# The rules themselves live in scripts/install/lib_sudoers.sh, shared with
-# scripts/install/configure_web_sudo.sh so the two cannot drift apart again.
-# If it is missing (a damaged checkout), keep whatever is already installed
-# rather than failing the whole install; the gate below skips the install.
-SUDOERS_VALID=1
-SUDOERS_LIB="$PROJECT_ROOT_DIR/scripts/install/lib_sudoers.sh"
-if [ -f "$SUDOERS_LIB" ]; then
-    # shellcheck source=scripts/install/lib_sudoers.sh
-    . "$SUDOERS_LIB"
-    web_sudoers_rules "$ACTUAL_USER" "$PROJECT_ROOT_DIR" "$SYSTEMCTL_PATH" "$BASH_PATH" \
-        "$REBOOT_PATH" "$POWEROFF_PATH" "$JOURNALCTL_PATH" > "$SUDOERS_TMP"
-else
-    SUDOERS_VALID=0
-    echo "⚠ $SUDOERS_LIB not found; cannot generate the sudoers rules." >&2
-    echo "⚠ Leaving $SUDOERS_FILE unchanged. The web interface cannot control" >&2
-    echo "  the display service until this is fixed." >&2
+# Create sudoers content
+cat > "$SUDOERS_TMP" << EOF
+# LED Matrix Web Interface passwordless sudo configuration
+# This allows the web interface user to run specific commands without a password
+
+# Allow $ACTUAL_USER to run specific commands without a password for the LED Matrix web interface
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $REBOOT_PATH
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $POWEROFF_PATH
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH enable ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH disable ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH status ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix-web.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix-web.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix-web.service
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $BASH_PATH $PROJECT_ROOT_DIR/scripts/fix_perms/safe_plugin_rm.sh *
+# Install a requirements.txt as root via vetted helper, so packages are visible
+# to root-run ledmatrix.service (not just the web interface's own user).
+$ACTUAL_USER ALL=(ALL) NOPASSWD: $BASH_PATH $PROJECT_ROOT_DIR/scripts/fix_perms/safe_pip_install.sh *
+EOF
+if [ -n "$JOURNALCTL_PATH" ]; then
+    cat >> "$SUDOERS_TMP" << EOF
+# NOEXEC, because these rules end in a wildcard and journalctl starts a pager
+# when its output is a terminal. From that pager (less) a "!sh" is a root
+# shell -- the standard journalctl escalation. The web interface always passes
+# --no-pager, so nothing here needs it, but the rule cannot require a flag that
+# sits in the middle of the command line. NOEXEC stops the command executing
+# another program at all, which closes the hole without depending on wildcard
+# matching subtleties.
+$ACTUAL_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix.service *
+$ACTUAL_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix *
+$ACTUAL_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -t ledmatrix *
+EOF
 fi
 
 # Never install rules we have not parsed. A malformed drop-in in
 # /etc/sudoers.d makes sudo refuse every command for every user, which on a
 # headless Pi leaves no way in at all. If the rules do not parse, say so and
 # keep whatever is already installed.
-if [ "$SUDOERS_VALID" = "0" ]; then
-    :  # nothing was generated; already reported above
-elif command -v visudo >/dev/null 2>&1; then
+SUDOERS_VALID=1
+if command -v visudo >/dev/null 2>&1; then
     if ! visudo -c -f "$SUDOERS_TMP" >/dev/null 2>&1; then
         SUDOERS_VALID=0
         echo "⚠ The generated sudoers rules did not parse:" >&2
@@ -1571,12 +1597,11 @@ echo "-----------------------------------------------------"
 if [ -f "$PROJECT_ROOT_DIR/scripts/install/configure_wifi_permissions.sh" ]; then
     echo "Configuring WiFi management permissions..."
     # Run as the actual user (not root) since the script checks for that
-    if sudo -u "$ACTUAL_USER" bash "$PROJECT_ROOT_DIR/scripts/install/configure_wifi_permissions.sh"; then
-        echo "✓ WiFi management permissions configured"
-    else
+    sudo -u "$ACTUAL_USER" bash "$PROJECT_ROOT_DIR/scripts/install/configure_wifi_permissions.sh" || {
         echo "⚠ WiFi permissions configuration failed, but continuing installation"
         echo "  You can run it manually later: ./scripts/install/configure_wifi_permissions.sh"
-    fi
+    }
+    echo "✓ WiFi management permissions configured"
 else
     echo "⚠ configure_wifi_permissions.sh not found; skipping WiFi permissions configuration"
     echo "  You can configure WiFi permissions later by running:"
@@ -1665,8 +1690,28 @@ fi
 
 # Re-apply plugin directory permissions based on web service user
 echo "Re-applying plugin directory permissions..."
-# Determine ownership based on web service user
-detect_web_service_user
+# Determine web service user (check installed service, install scripts, or template)
+WEB_SERVICE_USER="root"
+if [ -f "/etc/systemd/system/ledmatrix-web.service" ]; then
+    # Check actual installed service file (most accurate)
+    WEB_SERVICE_USER=$(grep "^User=" /etc/systemd/system/ledmatrix-web.service | cut -d'=' -f2 || echo "root")
+elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh" ]; then
+    # Check install_web_service.sh (used by first_time_install.sh)
+    if grep -q "User=root" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+        WEB_SERVICE_USER="root"
+    elif grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_web_service.sh"; then
+        WEB_SERVICE_USER="$ACTUAL_USER"
+    fi
+elif [ -f "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" ]; then
+    WEB_SERVICE_USER=$(grep "^User=" "$PROJECT_ROOT_DIR/systemd/ledmatrix-web.service" | cut -d'=' -f2 || echo "root")
+    if [ "$WEB_SERVICE_USER" = "__USER__" ] || [ -z "$WEB_SERVICE_USER" ]; then
+        if [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+            WEB_SERVICE_USER="$ACTUAL_USER"
+        fi
+    fi
+elif [ -f "$PROJECT_ROOT_DIR/scripts/install/install_service.sh" ] && grep -q "User=\${ACTUAL_USER}" "$PROJECT_ROOT_DIR/scripts/install/install_service.sh"; then
+    WEB_SERVICE_USER="$ACTUAL_USER"
+fi
 
 # Set ownership based on web service user
 if [ "$WEB_SERVICE_USER" = "$ACTUAL_USER" ] || [ "$WEB_SERVICE_USER" != "root" ]; then
@@ -1746,11 +1791,10 @@ echo "-------------------------------------"
 echo "Removing potential conflicting services (bluetooth and others)..."
 if [ "$SKIP_SOUND" = "1" ]; then
     echo "Skipping sound module configuration as requested (--skip-sound)."
-else
-    # apt_remove never fails (it ends in `|| true`); apt itself reports any
-    # package it could not remove.
-    apt_remove bluez bluez-firmware pi-bluetooth triggerhappy pigpio
+elif apt_remove bluez bluez-firmware pi-bluetooth triggerhappy pigpio; then
     echo "✓ Unnecessary services removed (or not present)"
+else
+    echo "⚠ Some packages could not be removed; continuing"
 fi
 
 # Blacklist onboard sound module (idempotent)
@@ -1965,6 +2009,20 @@ if systemctl list-unit-files | grep -q "ledmatrix-wifi-monitor.service"; then
 fi
 
 echo ""
+if [ "$SKIP_REBOOT_PROMPT" = "1" ]; then
+    echo "Skipping reboot prompt as requested (--no-reboot-prompt)."
+elif [ "$ASSUME_YES" = "1" ]; then
+    echo "Non-interactive mode: rebooting now to apply changes..."
+    reboot
+else
+    read -p "A reboot is recommended to apply kernel and audio changes. Reboot now? (y/N): " -n 1 -r
+    echo
+    if [[ $REPLY =~ ^[Yy]$ ]]; then
+        echo "Rebooting now..."
+        reboot
+    fi
+fi
+
 echo "=========================================="
 echo "Installation Complete!"
 echo "=========================================="
@@ -2010,7 +2068,7 @@ if command -v nmcli >/dev/null 2>&1; then
     if [ -n "$WIFI_STATUS" ]; then
         echo "$WIFI_STATUS" | while IFS=':' read -r _ _ state; do
             if [ "$state" = "connected" ]; then
-                SSID=$(nmcli -t -f active,ssid device wifi 2>/dev/null | grep "^yes:" | cut -d: -f2 | head -1 || true)
+                SSID=$(nmcli -t -f active,ssid device wifi 2>/dev/null | grep "^yes:" | cut -d: -f2 | head -1)
                 if [ -n "$SSID" ]; then
                     echo "  ✓ Connected to: $SSID"
                 else
@@ -2034,7 +2092,7 @@ echo "AP Mode Status:"
 if systemctl is-active --quiet hostapd 2>/dev/null; then
     echo "  ✓ AP Mode is ACTIVE"
     echo "  → Connect to WiFi network: LEDMatrix-Setup"
-    echo "  → Open network, no password"
+    echo "  → Password: ledmatrix123"
     echo "  → Access web UI at: http://192.168.4.1:5000"
     AP_MODE_ACTIVE=true
 else
@@ -2042,7 +2100,7 @@ else
     if ip addr show wlan0 2>/dev/null | grep -q "192.168.4.1"; then
         echo "  ✓ AP Mode is ACTIVE (IP detected)"
         echo "  → Connect to WiFi network: LEDMatrix-Setup"
-        echo "  → Open network, no password"
+        echo "  → Password: ledmatrix123"
         echo "  → Access web UI at: http://192.168.4.1:5000"
         AP_MODE_ACTIVE=true
     else
@@ -2144,22 +2202,3 @@ echo "   - Main config: $PROJECT_ROOT_DIR/config/config.json"
 echo "   - Secrets: $PROJECT_ROOT_DIR/config/config_secrets.json"
 echo ""
 echo "Enjoy your LED Matrix display!"
-
-# Reboot last. It used to come before the summary above, so with -y (and
-# the one-shot installer, which always passes -y) the reboot was already
-# under way while the summary printed, and the SSH session usually dropped
-# before any of it -- the web UI address included -- could be read.
-echo ""
-if [ "$SKIP_REBOOT_PROMPT" = "1" ]; then
-    echo "Skipping reboot prompt as requested (--no-reboot-prompt)."
-elif [ "$ASSUME_YES" = "1" ]; then
-    echo "Non-interactive mode: rebooting now to apply changes..."
-    reboot
-else
-    read -p "A reboot is recommended to apply kernel and audio changes. Reboot now? (y/N): " -n 1 -r
-    echo
-    if [[ $REPLY =~ ^[Yy]$ ]]; then
-        echo "Rebooting now..."
-        reboot
-    fi
-fi

mypy-clean.txt

@@ -1,86 +0,0 @@
-# The mypy ratchet: modules that type-check clean, one path per line, sorted.
-#
-# CI ("Type check (mypy ratchet)") runs `python scripts/check_types.py`, which
-# runs mypy on exactly these files (imports followed silently, so errors in an
-# unlisted module they import don't count) and fails on any error, so a listed
-# module stays clean. Most of src/ isn't clean yet. When you make a module
-# clean, add it here. Don't take a module off to get CI green -- fix the error
-# (annotation-only where you can: hints, typing.cast, TYPE_CHECKING imports;
-# widen an annotation rather than delete a defensive runtime check).
-
-src/__init__.py
-src/adaptive_images.py
-src/auto_update_setup.py
-src/backup_manager.py
-src/base_odds_manager.py
-src/cache/__init__.py
-src/cache/cache_metrics.py
-src/cache/cache_strategy.py
-src/cache/memory_cache.py
-src/common/__init__.py
-src/common/api_helper.py
-src/common/bdf_font.py
-src/common/espn_dates.py
-src/common/favorite_team_check.py
-src/common/font_layout.py
-src/common/frame_timing.py
-src/common/json_body.py
-src/common/logo_helper.py
-src/common/path_safety.py
-src/common/permission_utils.py
-src/common/render_gate.py
-src/common/scroll_config.py
-src/common/snapshot_policy.py
-src/common/sports_card.py
-src/common/sports_card_wrappers.py
-src/common/sports_celebration.py
-src/common/sports_fetch.py
-src/common/sports_scroll.py
-src/common/sports_timezone.py
-src/config_service.py
-src/core_config_keys.py
-src/deprecation.py
-src/device_location.py
-src/display_geometry.py
-src/dynamic_team_resolver.py
-src/exceptions.py
-src/font_usage.py
-src/logging_config.py
-src/logo_downloader.py
-src/matrix_support.py
-src/pi5_matrix_support.py
-src/plugin_system/__init__.py
-src/plugin_system/compatibility.py
-src/plugin_system/operation_history.py
-src/plugin_system/operation_queue.py
-src/plugin_system/operation_types.py
-src/plugin_system/plugin_dirs.py
-src/plugin_system/plugin_executor.py
-src/plugin_system/plugin_health.py
-src/plugin_system/plugin_loader.py
-src/plugin_system/plugin_state.py
-src/plugin_system/repo_urls.py
-src/plugin_system/resource_monitor.py
-src/plugin_system/saved_repositories.py
-src/plugin_system/schema_manager.py
-src/plugin_system/state_reconciliation.py
-src/plugin_system/testing/__init__.py
-src/plugin_system/testing/bounds_display_manager.py
-src/plugin_system/testing/loading.py
-src/plugin_system/testing/mocks.py
-src/plugin_system/testing/plugin_test_base.py
-src/plugin_system/testing/sizes.py
-src/redaction.py
-src/scan_order.py
-src/startup_validator.py
-src/vegas_mode/__init__.py
-src/vegas_mode/config.py
-src/vegas_mode/coordinator.py
-src/vegas_mode/geometry.py
-src/vegas_mode/stream_manager.py
-src/web_interface/api_helpers.py
-src/web_interface/config_arrays.py
-src/web_interface/error_handler.py
-src/web_interface/errors.py
-src/web_interface/secret_helpers.py
-src/web_interface/validators.py

mypy.ini

@@ -1,11 +1,6 @@
 [mypy]
 # Mypy configuration for LEDMatrix
 
-# What a bare `mypy` checks. ini values can't span lines or carry trailing
-# comments -- this file used to have both, so mypy refused to read it at all.
-files = src
-exclude = (^|/)(test|__pycache__)/
-
 # Python version
 python_version = 3.10
 
@@ -30,11 +25,11 @@ warn_unreachable = True
 # Strict optional checking
 strict_optional = True
 
-# Disallow untyped definitions (set to True once all code is typed)
-disallow_untyped_defs = False
+# Disallow untyped definitions
+disallow_untyped_defs = False  # Set to True once all code is typed
 
-# Disallow untyped calls (set to True once all code is typed)
-disallow_untyped_calls = False
+# Disallow untyped calls
+disallow_untyped_calls = False  # Set to True once all code is typed
 
 # Check untyped definitions
 check_untyped_defs = True
@@ -101,20 +96,10 @@ ignore_missing_imports = True
 [mypy-spotipy.*]
 ignore_missing_imports = True
 
+# Exclude test files and generated files
+exclude = (?x)(
+    ^test/.*|
+    ^.*/__pycache__/.*|
+    ^.*\.pyc$
+)
 
-# numpy's own stubs (numpy>=2.3) use Python 3.12 `type` statements, which mypy
-# refuses to parse under python_version = 3.10 -- and 3.10 is the floor this
-# code has to run on, so it stays. Treat numpy as Any instead: skip it, and
-# follow_imports_for_stubs makes the skip apply to its .pyi files too.
-[mypy-numpy.*]
-follow_imports = skip
-follow_imports_for_stubs = True
-
-# orjson is optional (see requirements.txt): the modules that use it fall back
-# to the stdlib when `import orjson` fails. Whether mypy sees its stubs would
-# otherwise depend on whether it happens to be installed -- installed, the
-# `orjson = None` fallback is a type error and the stdlib branch "unreachable";
-# not installed, silencing either is an unused ignore. Treat it as Any always.
-[mypy-orjson.*]
-follow_imports = skip
-follow_imports_for_stubs = True

requirements-test.txt

@@ -1,10 +1,10 @@
 # Test/dev-only dependencies (not needed on a running display).
 # Install alongside requirements.txt:  pip install -r requirements.txt -r requirements-test.txt
 pytest>=9.0.3,<10.0.0
-pytest-cov>=4.1.0,<8.0.0
+pytest-cov>=4.1.0,<5.0.0
 pytest-mock>=3.11.0,<4.0.0
 freezegun>=1.2,<2        # deterministic time for golden-image tests
-psutil>=6.0.0,<7.0.0     # optional at runtime; installed for tests so the
+psutil>=6.0.0,<8.0.0     # optional at runtime; installed for tests so the
                          # /system/status endpoint's real path is exercised
 mypy>=1.5.0,<2.0.0       # static type checking (also pinned in .pre-commit-config.yaml)
 PyYAML>=6.0.2,<7.0.0     # not a core dependency: test_starlark_pixlet_routes loads

requirements.txt

@@ -7,7 +7,7 @@ Pillow>=12.2.0,<13.0.0
 numpy>=1.24.0  # For fast array operations in ScrollHelper (compatible with 2.x)
 
 # Timezone handling
-pytz>=2024.2,<2027.0  # Updated for latest timezone data
+pytz>=2024.2,<2025.0  # Updated for latest timezone data
 
 # HTTP requests
 requests>=2.33.0,<3.0.0

run.py

@@ -31,6 +31,8 @@ if args.emulator:
     print("Using pygame/RGBMatrixEmulator for display")
     print("Press ESC to exit\n")
 
+# Project directory already added above
+
 # Debug output (only in debug mode or emulator mode)
 debug_mode = args.debug or args.emulator or os.environ.get('LEDMATRIX_DEBUG', '').lower() == 'true'
 if debug_mode:

scripts/README.md

@@ -1,61 +0,0 @@
-# Scripts
-
-Helper scripts for installing, repairing, diagnosing and developing
-LEDMatrix. Most users only ever run the one-shot installer (see the project
-README); everything else here is for troubleshooting or development.
-
-Status key: **keep** — part of install/runtime or referenced by docs, CI,
-tests or code; **dev-only** — for plugin/core development, not needed on a
-display; **diagnostic** — run by hand on a Pi when something is wrong.
-
-## Directories
-
-| Directory | Status | What it holds |
-|---|---|---|
-| [`install/`](install/README.md) | keep | The installers: one-shot, services, sudoers/WiFi permissions, cache setup, and the shared `lib_*.sh` helpers `first_time_install.sh` sources |
-| [`fix_perms/`](fix_perms/README.md) | keep | Permission repair scripts, plus the two root helpers the web interface runs through sudo (`safe_plugin_rm.sh`, `safe_pip_install.sh`) |
-| [`utils/`](utils/README.md) | keep | Scripts run by systemd units or the web interface (conditional web start, WiFi monitor, update verify, DNS fix, Pixlet config editor, cache clearing) |
-| [`dev/`](dev/README.md) | dev-only | Plugin linking, emulator runner, Vegas density audit, Pillow smoke test |
-| `templates/` | dev-only | `dev_preview.html`, the page `dev_server.py` serves |
-
-## Top-level scripts
-
-| Script | Status | What it does |
-|---|---|---|
-| `build_rgbmatrix_nogil.sh` | keep | Rebuilds the rgbmatrix Python binding so `SwapOnVSync` releases the GIL (docs/SCROLL_PERFORMANCE.md) |
-| `check_plugin.py` | dev-only | Renders a plugin across every mode and matrix size and fails on crashes, overflow or golden-image drift |
-| `check_release_version.py` | keep | Checks a release tag, CHANGELOG and `src.__version__` agree (release-version-check workflow) |
-| `check_system_compatibility.sh` | diagnostic | Pre-install check of hardware, OS (Trixie only), kernel, Python, packages, disk and network |
-| `dev_server.py` | dev-only | Browser preview server for plugins without the display loop (http://localhost:5001) |
-| `diagnose_dependencies.sh` | diagnostic | Investigates pip installs stuck on "Preparing metadata" |
-| `diagnose_web_interface.sh` | diagnostic | Checks why the web interface is not reachable |
-| `download_pixlet.sh` | keep | Downloads the bundled Pixlet binaries for Starlark apps (also run from the web UI) |
-| `emergency_reconnect.sh` | diagnostic | Reconnects to your WiFi network if captive-portal testing leaves the Pi offline |
-| `frame_soak.py` | diagnostic | Soaks a running display and reports how often frames reached the panel late (docs/SCROLL_PERFORMANCE.md) |
-| `install_dependencies_apt.py` | keep | Dependency installer that tries apt packages first, then pip (installer Step 7, plugin loader) |
-| `install_plugin_dependencies.sh` | diagnostic | Installs plugin requirements by hand when the automatic install fails |
-| `prove_security.py` | keep | Security property checks run by pre-commit |
-| `render_bench.py` | diagnostic | Benchmarks the render loop against the panel's real refresh rate on a synthetic strip |
-| `render_plugin.py` | dev-only | Runs a plugin's `update()` + `display()` and saves the frame as a PNG |
-| `run_plugin_tests.py` | dev-only | Discovers and runs plugin test suites |
-| `scroll_speeds.py` | keep | Shows and tries the scroll speeds your panel can display cleanly |
-| `troubleshoot_captive_portal.sh` | diagnostic | Troubleshoots captive-portal WiFi setup after you can SSH back in |
-| `update_plugin_repos.py` | dev-only | Pulls the latest `ledmatrix-plugins` monorepo |
-| `verify_installation.sh` | diagnostic | Checks that an installation completed correctly |
-| `verify_wifi_setup.sh` | diagnostic | Health check of the WiFi management setup |
-
-## Candidates for removal
-
-Nothing in the repo (docs, CI, tests, other scripts or code) refers to these.
-They are kept for now; each one needs an owner decision before it goes.
-
-| Script | What it does |
-|---|---|
-| `add_defaults_to_schemas.py` | One-off: adds missing `default` values to plugin config schemas |
-| `analyze_plugin_schemas.py` | One-off: reports duplicate/inconsistent fields across plugin schemas |
-| `audit_plugins.py` | AST security audit of plugin code; says it is "designed to run in CI" but no workflow runs it |
-| `audit_render_path.py` | Finds blocking calls reachable from a plugin's `display()` |
-| `sports_scroll_check.py` | Drives a sports scoreboard scroll on the panel and reports its pacing |
-| `test_captive_portal.sh` | Tests the captive portal from a device connected to the AP |
-| `verify_wifi_before_testing.sh` | Pre-flight check before unplugging Ethernet to test WiFi |
-| `dev/test_pillow_compat.py` | Pillow API smoke test to run after upgrading Pillow |

scripts/add_defaults_to_schemas.py

@@ -194,7 +194,7 @@ def process_schema_file(schema_path: Path) -> bool:
         print(f"  ✓ Modified {len(modified_fields)} fields")
         return True
     else:
-        print("  ✓ No changes needed")
+        print(f"  ✓ No changes needed")
         return False
 
 

scripts/analyze_plugin_schemas.py

@@ -87,6 +87,7 @@ def find_duplicate_fields(schema: Dict[str, Any], path: str = "") -> List[str]:
 
 def validate_schema_syntax(schema_path: Path) -> tuple[bool, List[str]]:
     """Validate JSON Schema syntax."""
+    errors = []
     try:
         with open(schema_path, 'r', encoding='utf-8') as f:
             schema = json.load(f)
@@ -163,7 +164,7 @@ def analyze_schema(schema_path: Path) -> Dict[str, Any]:
                     if "update_interval_seconds" in properties:
                         analysis["update_interval_variant"] = "update_interval_seconds"
                         analysis["naming_issues"].append(
-                            "Uses 'update_interval_seconds' instead of 'update_interval'"
+                            f"Uses 'update_interval_seconds' instead of 'update_interval'"
                         )
                     else:
                         analysis["missing_common_fields"].append(field_name)
@@ -238,7 +239,7 @@ def main():
             print(f"  Missing common fields: {', '.join(result['missing_common_fields'])}")
         
         if result['naming_issues']:
-            print("  Naming issues:")
+            print(f"  Naming issues:")
             for issue in result['naming_issues']:
                 print(f"    - {issue}")
         

scripts/check_system_compatibility.sh

@@ -28,12 +28,12 @@ print_success() {
 
 print_warning() {
     echo -e "${YELLOW}⚠${NC} $1"
-    WARNINGS=$((WARNINGS + 1))
+    ((WARNINGS++))
 }
 
 print_error() {
     echo -e "${RED}✗${NC} $1"
-    COMPATIBILITY_ISSUES=$((COMPATIBILITY_ISSUES + 1))
+    ((COMPATIBILITY_ISSUES++))
 }
 
 # Check if running on Raspberry Pi
@@ -61,18 +61,20 @@ if [ -f /etc/os-release ]; then
     echo "OS: $PRETTY_NAME"
     echo "Version ID: ${VERSION_ID:-unknown}"
     
-    # first_time_install.sh refuses anything but Raspberry Pi OS / Debian 13
-    # (Trixie), so anything else is an error here too, not a warning.
     if [[ "$ID" == "raspbian" ]] || [[ "$ID" == "debian" ]]; then
-        if [ "${VERSION_ID:-0}" = "13" ]; then
-            print_success "Detected Debian 13 Trixie - supported"
-        elif [ "${VERSION_ID:-0}" = "12" ]; then
-            print_error "Debian 12 Bookworm is not supported - the installer requires Raspberry Pi OS Lite (Trixie), Debian 13"
+        if [ "${VERSION_ID:-0}" -ge "12" ]; then
+            print_success "Running compatible Debian/Raspbian version (${VERSION_ID})"
+            
+            if [ "${VERSION_ID:-0}" -eq "13" ]; then
+                print_success "Detected Debian 13 Trixie - full compatibility expected"
+            elif [ "${VERSION_ID:-0}" -eq "12" ]; then
+                print_success "Detected Debian 12 Bookworm - full compatibility confirmed"
+            fi
         else
-            print_error "Debian/Raspbian ${VERSION_ID:-unknown} is not supported - the installer requires Raspberry Pi OS Lite (Trixie), Debian 13"
+            print_warning "Old Debian/Raspbian version (${VERSION_ID}) - upgrade recommended"
         fi
     else
-        print_error "${ID:-unknown} is not supported - the installer requires Raspberry Pi OS Lite (Trixie), Debian 13"
+        print_warning "Not running Debian/Raspbian - compatibility not guaranteed"
     fi
 else
     print_error "Could not detect OS version"
@@ -112,13 +114,15 @@ if command -v python3 >/dev/null 2>&1; then
     echo "Python: $PYTHON_VERSION"
     
     if [ "$PYTHON_MAJOR" -eq "3" ]; then
-        if [ "$PYTHON_MINOR" -ge "10" ] && [ "$PYTHON_MINOR" -le "13" ]; then
-            print_success "Python version is supported (3.10-3.13)"
+        if [ "$PYTHON_MINOR" -ge "10" ] && [ "$PYTHON_MINOR" -le "12" ]; then
+            print_success "Python version is fully supported (3.10-3.12)"
+        elif [ "$PYTHON_MINOR" -eq "13" ]; then
+            print_warning "Python 3.13 detected - most packages compatible, but some may have limited testing"
+            print_warning "Please report any compatibility issues you encounter"
         elif [ "$PYTHON_MINOR" -ge "14" ]; then
             print_warning "Python 3.${PYTHON_MINOR} is very new - some packages may not be compatible yet"
         else
-            # Pillow 12 and the pinned test tools need 3.10+, so this won't install.
-            print_error "Python 3.${PYTHON_MINOR} is too old - Python 3.10+ is required"
+            print_warning "Python 3.${PYTHON_MINOR} is outdated - upgrade to 3.10+ recommended"
         fi
     else
         print_error "Python 2.x detected - Python 3.10+ is required"
@@ -153,10 +157,7 @@ ESSENTIAL_PACKAGES=(
 
 for pkg_info in "${ESSENTIAL_PACKAGES[@]}"; do
     IFS=':' read -r pkg desc <<< "$pkg_info"
-    # dpkg-query rather than `dpkg -l | grep -q`: under pipefail, grep -q
-    # exiting on its first match kills dpkg with SIGPIPE and fails the pipeline,
-    # which reported installed packages as missing.
-    if [ "$(dpkg-query -W -f='${Status}' "$pkg" 2>/dev/null)" = "install ok installed" ]; then
+    if dpkg -l | grep -q "^ii  $pkg "; then
         print_success "$desc ($pkg) is installed"
     else
         print_warning "$desc ($pkg) not installed - will be installed during setup"

scripts/check_types.py

@@ -1,99 +0,0 @@
-#!/usr/bin/env python3
-"""Type-check the modules listed in mypy-clean.txt (the mypy ratchet).
-
-Most of src/ still has mypy errors, so CI can't require a clean `mypy src`.
-Instead mypy-clean.txt lists the modules that *are* clean, and this script
-fails if any of them regresses. When you make another module clean, add it to
-the list; nothing ever comes off it.
-
-Imports are followed silently: a listed module is checked against the types of
-everything it imports, but errors inside those imported modules are not
-reported, so a clean file isn't failed by an unlisted neighbour.
-
-Usage:
-    python scripts/check_types.py            # check the listed modules
-    python scripts/check_types.py --list     # print the list and exit
-
-Extra arguments after ``--`` are passed to mypy.
-Exit status: 0 clean, 1 mypy errors, 2 a bad list (missing file, duplicate,
-unsorted, or empty).
-"""
-
-import argparse
-import subprocess  # nosec B404 - list-form argv only, no shell  # nosemgrep
-import sys
-from pathlib import Path
-
-REPO_ROOT = Path(__file__).resolve().parent.parent
-LIST_FILE = REPO_ROOT / "mypy-clean.txt"
-
-
-def read_list(path: Path = LIST_FILE) -> list:
-    """The listed paths, in file order, with comments and blank lines dropped."""
-    entries = []
-    for raw in path.read_text(encoding="utf-8").splitlines():
-        line = raw.split("#", 1)[0].strip()
-        if line:
-            entries.append(line)
-    return entries
-
-
-def list_problems(entries: list, root: Path = REPO_ROOT) -> list:
-    """Why the list can't be used as-is; empty when it is fine."""
-    problems = []
-    if not entries:
-        problems.append(f"{LIST_FILE.name} lists no modules")
-    seen = set()
-    for entry in entries:
-        if entry in seen:
-            problems.append(f"listed twice: {entry}")
-        seen.add(entry)
-        if "\\" in entry:
-            problems.append(f"use forward slashes: {entry}")
-        elif not (root / entry).is_file():
-            problems.append(f"listed but not found (renamed or deleted? update the list): {entry}")
-    if entries != sorted(entries):
-        problems.append(f"{LIST_FILE.name} is not sorted")
-    return problems
-
-
-def main(argv=None) -> int:
-    parser = argparse.ArgumentParser(description=__doc__.split("\n\n")[0])
-    parser.add_argument("--list", action="store_true", help="print the listed modules and exit")
-    parser.add_argument("mypy_args", nargs="*", help="extra mypy arguments (after --)")
-    args = parser.parse_args(argv)
-
-    entries = read_list()
-    problems = list_problems(entries)
-    if problems:
-        for problem in problems:
-            print(f"check_types: {problem}", file=sys.stderr)
-        return 2
-    if args.list:
-        print("\n".join(entries))
-        return 0
-
-    cmd = [
-        sys.executable, "-m", "mypy",
-        "--config-file", str(REPO_ROOT / "mypy.ini"),
-        "--follow-imports=silent",
-        *args.mypy_args,
-        *entries,
-    ]
-    print(f"check_types: mypy on {len(entries)} modules from {LIST_FILE.name}", flush=True)
-    # This interpreter's mypy, fixed flags, and paths from the checked-in list.
-    result = subprocess.run(cmd, cwd=REPO_ROOT)  # nosec B603 - list-form argv, no shell  # nosemgrep
-    if result.returncode > 1:  # mypy itself failed (bad config, crash)
-        return result.returncode
-    if result.returncode != 0:
-        print(
-            "check_types: a module on the mypy ratchet has type errors. Fix them "
-            f"(annotation-only where possible) rather than taking it off {LIST_FILE.name}.",
-            file=sys.stderr,
-        )
-        return 1
-    return 0
-
-
-if __name__ == "__main__":
-    sys.exit(main())

scripts/dev/README.md

@@ -6,8 +6,6 @@ This directory contains scripts and utilities for development and testing.
 
 - **`dev_plugin_setup.sh`** - Sets up plugin development environment by linking plugin repositories
 - **`run_emulator.sh`** - Runs the LED Matrix display in emulator mode (for development without hardware)
-- **`vegas_audit.py`** - Measures how much of the Vegas ticker strip actually shows content (dead-frame ratio)
-- **`test_pillow_compat.py`** - Pillow API smoke test to run after upgrading Pillow (`python3 scripts/dev/test_pillow_compat.py`)
 
 ## Usage
 

scripts/dev_server.py

@@ -423,7 +423,7 @@ def main():
     global _extra_dirs
     _extra_dirs = args.extra_dir
 
-    print("LEDMatrix Dev Preview Server")
+    print(f"LEDMatrix Dev Preview Server")
     print(f"Open http://{args.host}:{args.port} in your browser")
     print(f"Plugin search dirs: {[str(d) for d in get_search_dirs()]}")
     print()

scripts/fix_perms/README.md

@@ -18,26 +18,21 @@ system user.
   permissions on the `assets/` tree so plugins can download and cache
   team logos, fonts, and other static content.
 
-- **`fix_cache_permissions.sh`** — Restores `/var/cache/ledmatrix/` to the
-  shared `ledmatrix`-group setup by running
-  `scripts/install/setup_cache.sh` (the same script the installer uses),
-  and creates/fixes `~/.ledmatrix_cache/` of the user running `sudo`. It
-  does not touch the cache manager's other fallbacks
-  (`/opt/ledmatrix/cache`, `$TMPDIR/ledmatrix_cache`).
+- **`fix_cache_permissions.sh`** — Creates (if missing) and fixes
+  permissions on `/var/cache/ledmatrix/` and `~/.ledmatrix_cache/` of the
+  user running `sudo`, and creates
+  `/var/cache/ledmatrix/placeholder_logos/` for the sports plugins. It does
+  not touch the cache manager's other fallbacks (`/opt/ledmatrix/cache`,
+  `$TMPDIR/ledmatrix_cache`).
 
 - **`fix_plugin_permissions.sh`** — Fixes ownership on the plugins
   directory so both the root display service and the web service user
   can read and write plugin files (manifests, configs, requirements
   installs).
 
-- **`fix_web_permissions.sh`** — Adds you to the `systemd-journal` and
-  `adm` groups so the web UI can read logs, and makes the project
-  directory yours again, keeping the root-owned sudo helpers
-  (`safe_plugin_rm.sh`, `safe_pip_install.sh`) and `config_secrets.json`
-  the way the installer leaves them. Run it as the web interface's user,
-  **without** `sudo` (it refuses to run as root and calls `sudo` itself).
-  It does not write sudoers rules; that is
-  `scripts/install/configure_web_sudo.sh`.
+- **`fix_web_permissions.sh`** — Fixes permissions on log files,
+  systemd journal access, and the sudoers entries the web interface
+  needs to control the display service.
 
 - **`safe_pip_install.sh`** — Installs a `requirements.txt` as root
   after checking it is the project's own or one under `plugin-repos/` or
@@ -72,9 +67,7 @@ Run these scripts only when:
 sudo ./scripts/fix_perms/fix_cache_permissions.sh
 sudo ./scripts/fix_perms/fix_assets_permissions.sh
 sudo ./scripts/fix_perms/fix_plugin_permissions.sh
-
-# Run as the web interface's user, without sudo (it asks for sudo itself)
-./scripts/fix_perms/fix_web_permissions.sh
+sudo ./scripts/fix_perms/fix_web_permissions.sh
 ```
 
 If you're not sure which one you need, run `fix_cache_permissions.sh`

scripts/fix_perms/fix_assets_permissions.sh

@@ -36,12 +36,11 @@ else
     exit 1
 fi
 
-# 777: read/write for owner, group and every other account. Root (the display
-# service) does not need it -- root ignores mode bits -- so the "other" bits
-# only matter to accounts that are neither $REAL_USER nor root.
+# Set permissions to allow read/write for owner, group, and others (for root service user)
+# Note: 777 allows root (service user) to write, which is necessary when service runs as root
 echo "Setting permissions for assets directory..."
 if sudo chmod -R 777 "$ASSETS_DIR"; then
-    echo "✓ Set assets directory permissions to 777"
+    echo "✓ Set assets directory permissions to 777 (writable by root service user)"
 else
     echo "✗ Failed to set assets directory permissions"
     exit 1
@@ -71,7 +70,8 @@ for SPORTS_DIR in "${SPORTS_DIRS[@]}"; do
         echo "  - Current permissions:"
         ls -ld "$FULL_PATH"
         
-        # Owned by the real user; 777 as above (root can write here regardless)
+        # Ensure the directory is writable by both the real user and root (service user)
+        # Use 777 permissions to allow root (service) to write, or set group ownership
         sudo chmod 777 "$FULL_PATH"
         sudo chown "$REAL_USER:$REAL_GROUP" "$FULL_PATH"
         

scripts/fix_perms/fix_cache_permissions.sh

@@ -1,23 +1,11 @@
 #!/bin/bash
 
 # LEDMatrix Cache Permissions Fix Script
-#
-# /var/cache/ledmatrix is shared by the display service (root) and the web
-# interface (your user) through the ledmatrix group: root:ledmatrix, 2775,
-# files 660. scripts/install/setup_cache.sh is what sets that up (the
-# installer's Step 2 runs it, and install_web_service.sh keeps the group), so
-# this script runs it rather than applying a model of its own. It used to set
-# the directory 777 and re-group it to your own group, replacing the ledmatrix
-# group everything else relies on.
-#
-# It also repairs ~/.ledmatrix_cache, the cache manager's fallback when
-# /var/cache/ledmatrix is unusable.
+# This script fixes permissions on all known cache directories so they're writable by the daemon or current user
+# Also sets up placeholder logo directories for sports managers
 
 echo "Fixing LEDMatrix cache directory permissions..."
 
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-SETUP_CACHE="$SCRIPT_DIR/../install/setup_cache.sh"
-
 # Get the real user (not root when running with sudo)
 REAL_USER=${SUDO_USER:-$USER}
 # Resolve the home directory of the real user robustly
@@ -28,36 +16,72 @@ else
 fi
 REAL_GROUP=$(id -gn "$REAL_USER")
 
+# Known cache directories for LEDMatrix. Use the actual user's home instead of a hard-coded path.
+CACHE_DIRS=(
+    "/var/cache/ledmatrix"
+    "$REAL_HOME/.ledmatrix_cache"
+)
+
+for CACHE_DIR in "${CACHE_DIRS[@]}"; do
+    echo ""
+    echo "Checking cache directory: $CACHE_DIR"
+    if [ ! -d "$CACHE_DIR" ]; then
+        echo "  - Directory does not exist. Creating it..."
+        sudo mkdir -p "$CACHE_DIR"
+    fi
+    echo "  - Current permissions:"
+    ls -ld "$CACHE_DIR"
+    echo "  - Fixing permissions..."
+    # Make directory writable by services regardless of user context
+    sudo chmod 777 "$CACHE_DIR"
+    sudo chown "$REAL_USER":"$REAL_GROUP" "$CACHE_DIR"
+    echo "  - Updated permissions:"
+    ls -ld "$CACHE_DIR"
+    echo "  - Testing write access as $REAL_USER..."
+    if sudo -u "$REAL_USER" test -w "$CACHE_DIR"; then
+        echo "    ✓ $CACHE_DIR is now writable by $REAL_USER"
+    else
+        echo "    ✗ $CACHE_DIR is still not writable by $REAL_USER"
+    fi
+    echo "  - Permissions fix complete for $CACHE_DIR."
+done
+
+# Set up placeholder logos directory for sports managers
 echo ""
-echo "Checking cache directory: /var/cache/ledmatrix"
-if [ -f "$SETUP_CACHE" ]; then
-    bash "$SETUP_CACHE"
+echo "Setting up placeholder logos directory for sports managers..."
+
+PLACEHOLDER_DIR="/var/cache/ledmatrix/placeholder_logos"
+if [ ! -d "$PLACEHOLDER_DIR" ]; then
+    echo "Creating placeholder logos directory: $PLACEHOLDER_DIR"
+    sudo mkdir -p "$PLACEHOLDER_DIR"
+    sudo chown "$REAL_USER":"$REAL_GROUP" "$PLACEHOLDER_DIR"
+    sudo chmod 777 "$PLACEHOLDER_DIR"
 else
-    echo "  ✗ $SETUP_CACHE not found; /var/cache/ledmatrix left unchanged."
+    echo "Placeholder logos directory already exists: $PLACEHOLDER_DIR"
+    sudo chmod 777 "$PLACEHOLDER_DIR"
+    sudo chown "$REAL_USER":"$REAL_GROUP" "$PLACEHOLDER_DIR"
 fi
 
-CACHE_DIR="$REAL_HOME/.ledmatrix_cache"
-echo ""
-echo "Checking cache directory: $CACHE_DIR"
-if [ ! -d "$CACHE_DIR" ]; then
-    echo "  - Directory does not exist. Creating it..."
-    sudo mkdir -p "$CACHE_DIR"
-fi
 echo "  - Current permissions:"
-ls -ld "$CACHE_DIR"
-echo "  - Fixing permissions..."
-sudo chmod 777 "$CACHE_DIR"
-sudo chown "$REAL_USER":"$REAL_GROUP" "$CACHE_DIR"
-echo "  - Updated permissions:"
-ls -ld "$CACHE_DIR"
+ls -ld "$PLACEHOLDER_DIR"
 echo "  - Testing write access as $REAL_USER..."
-if sudo -u "$REAL_USER" test -w "$CACHE_DIR"; then
-    echo "    ✓ $CACHE_DIR is now writable by $REAL_USER"
+if sudo -u "$REAL_USER" test -w "$PLACEHOLDER_DIR"; then
+    echo "    ✓ Placeholder logos directory is writable by $REAL_USER"
 else
-    echo "    ✗ $CACHE_DIR is still not writable by $REAL_USER"
+    echo "    ✗ Placeholder logos directory is not writable by $REAL_USER"
+fi
+
+# Test with daemon user (which the system might run as)
+if sudo -u daemon test -w "$PLACEHOLDER_DIR" 2>/dev/null; then
+    echo "    ✓ Placeholder logos directory is writable by daemon user"
+else
+    echo "    ✗ Placeholder logos directory is not writable by daemon user"
 fi
-echo "  - Permissions fix complete for $CACHE_DIR."
 
 echo ""
 echo "All cache directory permission fixes attempted."
 echo "If you still see errors, check which user is running the LEDMatrix service and ensure it matches the owner above."
+echo ""
+echo "The system will now create placeholder logos in:"
+echo "  $PLACEHOLDER_DIR"
+echo "This should eliminate the permission denied warnings for sports logos." 

scripts/fix_perms/fix_plugin_permissions.sh

@@ -51,10 +51,9 @@ fi
 echo "Setting ownership to root:$ACTUAL_USER..."
 sudo chown -R root:"$ACTUAL_USER" "$PLUGINS_DIR"
 
-# Set directory permissions (2775: rwxrwsr-x)
-# Owner (root) and group (ACTUAL_USER): read/write/execute, others: read/execute.
-# The setgid bit makes new entries inherit the ACTUAL_USER group.
-echo "Setting directory permissions to 2775 (rwxrwsr-x, setgid)..."
+# Set directory permissions (775: rwxrwxr-x)
+# Root: read/write/execute, Group (ACTUAL_USER): read/write/execute, Others: read/execute
+echo "Setting directory permissions to 2775 (rwxrwxr-x + sticky bit)..."
 find "$PLUGINS_DIR" -type d -exec sudo chmod 2775 {} \;
 
 # Set file permissions (664: rw-rw-r--)
@@ -72,7 +71,7 @@ fi
 echo "Setting ownership of plugin-repos to root:$ACTUAL_USER..."
 sudo chown -R root:"$ACTUAL_USER" "$PLUGIN_REPOS_DIR"
 
-echo "Setting plugin-repos directory permissions to 2775 (rwxrwsr-x, setgid)..."
+echo "Setting plugin-repos directory permissions to 2775 (rwxrwxr-x + sticky bit)..."
 find "$PLUGIN_REPOS_DIR" -type d -exec sudo chmod 2775 {} \;
 
 echo "Setting plugin-repos file permissions to 664..."
@@ -88,7 +87,7 @@ echo "plugin-repos/:"
 ls -la "$PLUGIN_REPOS_DIR" 2>/dev/null || echo "  (empty or not accessible)"
 echo ""
 echo "Permissions summary:"
-echo "- Root service: Can read/write plugins (as root it needs no permission bits)"
+echo "- Root service: Can read/write plugins (for PWM hardware access)"
 echo "- Web service ($ACTUAL_USER): Can read/write plugins (for installation)"
 echo "- Others: Can read plugins"
 

scripts/fix_perms/fix_web_permissions.sh

@@ -25,9 +25,8 @@ echo ""
 echo "This script will:"
 echo "1. Add the web user to the 'systemd-journal' group for log access"
 echo "2. Add the web user to the 'adm' group for additional system access"
-echo "3. Make the project directory yours again, keeping the root-owned sudo"
-echo "   helpers and config_secrets.json as the installer leaves them"
-echo "   (sudoers rules are configure_web_sudo.sh's job, not this script's)"
+echo "3. Configure sudoers for passwordless access to system commands"
+echo "4. Set proper file permissions"
 echo ""
 
 # Ask for confirmation
@@ -63,51 +62,6 @@ else
     echo "✗ Failed to set project ownership"
 fi
 
-# The chown above also takes back two kinds of file that first_time_install.sh
-# deliberately keeps from the web user. Put them back the way the installer
-# leaves them (its Steps 11 and 11.1), whether or not the chown succeeded.
-#
-# 1. The helpers /etc/sudoers.d/ledmatrix_web lets the web user run as root
-#    (scripts/install/lib_sudoers.sh). A copy the web user owns is a root shell
-#    for whoever can edit it, so they stay root-owned and writable by root only.
-#    Keep this list in step with the installer's Step 11.1 loop;
-#    test/test_web_sudoers_installers_agree.py checks both against the grants.
-for helper in safe_plugin_rm.sh safe_pip_install.sh; do
-    HELPER_PATH="$PROJECT_DIR/scripts/fix_perms/$helper"
-    if [ -f "$HELPER_PATH" ]; then
-        if sudo chown root:root "$HELPER_PATH" && sudo chmod 755 "$HELPER_PATH"; then
-            echo "✓ $helper is root-owned again (sudo runs it as root)"
-        else
-            echo "⚠ Could not make $HELPER_PATH root-owned, mode 755."
-            echo "  Fix it by hand: sudo chown root:root $HELPER_PATH && sudo chmod 755 $HELPER_PATH"
-        fi
-    fi
-done
-
-# 2. config_secrets.json: owned by the account ledmatrix-web.service runs as,
-#    group ledmatrix, mode 640 -- the same owner, group and mode as the
-#    installer's Step 11 gives it.
-SECRETS_FILE="$PROJECT_DIR/config/config_secrets.json"
-if [ -f "$SECRETS_FILE" ]; then
-    SECRETS_OWNER=""
-    if [ -f /etc/systemd/system/ledmatrix-web.service ]; then
-        SECRETS_OWNER=$(grep -m1 "^User=" /etc/systemd/system/ledmatrix-web.service | cut -d'=' -f2 || true)
-    fi
-    SECRETS_OWNER="${SECRETS_OWNER:-$WEB_USER}"
-    if getent group ledmatrix >/dev/null 2>&1; then
-        SECRETS_OWNERSHIP="$SECRETS_OWNER:ledmatrix"
-    else
-        # No ledmatrix group means the installer never ran; keep the chown's group.
-        SECRETS_OWNERSHIP="$SECRETS_OWNER"
-    fi
-    if sudo chown "$SECRETS_OWNERSHIP" "$SECRETS_FILE" && sudo chmod 640 "$SECRETS_FILE"; then
-        echo "✓ config_secrets.json restored to $SECRETS_OWNERSHIP, mode 640"
-    else
-        echo "⚠ Could not restore $SECRETS_FILE to $SECRETS_OWNERSHIP, mode 640."
-        echo "  Fix it by hand: sudo chown $SECRETS_OWNERSHIP $SECRETS_FILE && sudo chmod 640 $SECRETS_FILE"
-    fi
-fi
-
 # Set proper permissions for config files
 if sudo chmod 644 "$PROJECT_DIR/config/config.json" 2>/dev/null; then
     echo "✓ Set config file permissions"
@@ -132,7 +86,7 @@ echo "Step 5: Testing sudo access..."
 if sudo -n systemctl status ledmatrix.service > /dev/null 2>&1; then
     echo "✓ Sudo access test passed"
 else
-    echo "⚠ Sudo access test failed - you may need to run scripts/install/configure_web_sudo.sh"
+    echo "⚠ Sudo access test failed - you may need to run configure_web_sudo.sh"
 fi
 
 echo ""
@@ -147,5 +101,5 @@ echo ""
 echo "After logging back in, test journal access with:"
 echo "  journalctl --no-pager --lines=5"
 echo ""
-echo "If you still have sudo issues, run (as this user, without sudo):"
-echo "  $PROJECT_DIR/scripts/install/configure_web_sudo.sh"
+echo "If you still have sudo issues, run:"
+echo "  ./configure_web_sudo.sh"

scripts/frame_soak.py

@@ -1,389 +0,0 @@
-#!/usr/bin/env python3
-"""Soak a running display and report how often moving frames reached the panel late.
-
-Runs NEXT TO the display service, as any user: it only reads the stats file the
-service writes (src/common/frame_timing.py) at the start and end of the run and
-reports the difference. Nothing is stopped, restarted or drawn.
-
-    # 10 minutes, as the display is now
-    python3 scripts/frame_soak.py
-
-    # the same with the web preview open (the preview's PNG encodes are one of
-    # the things that used to make the render loop miss refreshes)
-    python3 scripts/frame_soak.py --preview
-
-    # quick look at the totals since the service started
-    python3 scripts/frame_soak.py --show
-
-    # keep the report for a before/after comparison
-    python3 scripts/frame_soak.py --duration 600 --json soak-before.json
-
-Exit status: 0 when the late-frame rate is within ``--max-late-pct``, 1 when it
-is not, 2 when there was nothing to measure (no stats file, the service
-restarted mid-run, or nothing scrolled).
-
-What the numbers mean
----------------------
-late frames     frames that reached the panel one or more refreshes after they
-                were due -- the panel showed the previous frame again, which on
-                a moving strip is a visible hitch. This is the pass/fail number.
-freezes         gaps of 250ms+ inside a scroll: recomposes, plugin handovers,
-                blocking calls on the render thread. Reported, not failed on,
-                since some are handovers between plugins rather than faults.
-blit            copying the frame into the matrix canvas (rgbmatrix SetImage).
-                Grows with width x height x pwm_bits.
-wait            blocked in SwapOnVSync, i.e. slack before the refresh.
-work            everything else between two frames: drawing, scrolling, and
-                waiting for the GIL.
-"""
-from __future__ import annotations
-
-import argparse
-import json
-import os
-import sys
-import time
-from pathlib import Path
-from typing import Any, Dict, Optional
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from src.common.frame_timing import (  # noqa: E402
-    BUCKET_COUNT,
-    SCHEMA_VERSION,
-    default_stats_path,
-)
-
-#: Touched by the web UI while someone has the preview open; a fresh marker
-#: puts the display service's snapshot writer at full rate. Same path as
-#: DisplayManager._viewer_marker_path.
-VIEWER_MARKER = "/tmp/led_matrix_preview_viewer"  # nosec B108 - fixed path shared with the service
-
-#: A stats file not rewritten for this long means nothing is being presented.
-STALE_SECONDS = 30.0
-
-
-def load(path: str) -> Optional[Dict[str, Any]]:
-    try:
-        with open(path, encoding="utf-8") as handle:
-            stats = json.load(handle)
-    except (OSError, ValueError):
-        return None
-    if not isinstance(stats, dict) or stats.get("version") != SCHEMA_VERSION:
-        return None
-    return stats
-
-
-def _histogram(stats: Dict[str, Any], name: str) -> Dict[int, int]:
-    raw = (stats.get("histograms") or {}).get(name) or {}
-    return {int(k): int(v) for k, v in raw.items()}
-
-
-def diff(before: Dict[str, Any], after: Dict[str, Any]) -> Dict[str, Any]:
-    """What happened between two snapshots of the same process."""
-    tb, ta = before["totals"], after["totals"]
-    totals = {}
-    for key, value in ta.items():
-        if isinstance(value, dict):
-            totals[key] = {k: v - tb.get(key, {}).get(k, 0)
-                           for k, v in value.items()}
-        elif key == "worst_interval_ms":
-            # A running maximum can't be differenced; it is reported as the
-            # worst since the service started.
-            totals[key] = value
-        else:
-            totals[key] = value - tb.get(key, 0)
-    histograms = {}
-    for name in (after.get("histograms") or {}):
-        hb, ha = _histogram(before, name), _histogram(after, name)
-        histograms[name] = {k: v - hb.get(k, 0) for k, v in ha.items()
-                            if v - hb.get(k, 0) > 0}
-    return {"totals": totals, "histograms": histograms,
-            "seconds": after["updated"] - before["updated"]}
-
-
-def percentiles(histogram: Dict[int, int], bucket_ms: float) -> Dict[str, Any]:
-    """p50/p95/p99/max from a sparse histogram, as each bucket's upper edge."""
-    count = sum(histogram.values())
-    if not count:
-        return {}
-    out = {}
-    targets = {"p50": 0.50, "p95": 0.95, "p99": 0.99}
-    running = 0
-    for index in sorted(histogram):
-        running += histogram[index]
-        for name, fraction in list(targets.items()):
-            if running >= fraction * count:
-                out[name] = _edge(index, bucket_ms)
-                del targets[name]
-    out["max"] = _edge(max(histogram), bucket_ms)
-    return out
-
-
-def _edge(index: int, bucket_ms: float):
-    if index >= BUCKET_COUNT - 1:
-        return f">={index * bucket_ms:g}"
-    return round((index + 1) * bucket_ms, 2)
-
-
-def build_report(before, after, preview: bool) -> Dict[str, Any]:
-    delta = diff(before, after)
-    totals = delta["totals"]
-    frames = totals["scroll_frames"]
-    # The rates are over frames judged against a known refresh period. Stats
-    # from a recorder that predates the count fall back to every frame.
-    timed = totals.get("timed_frames", frames) if "timed_frames" in totals else frames
-    hours = delta["seconds"] / 3600.0 if delta["seconds"] > 0 else 0.0
-    bucket_ms = after.get("bucket_ms", 0.25)
-    report = {
-        "seconds": round(delta["seconds"], 1),
-        "preview": preview,
-        "info": after.get("info"),
-        "binding_releases_gil": after.get("binding_releases_gil"),
-        "measured_refresh_hz": after.get("measured_refresh_hz"),
-        "scroll_frames": frames,
-        "static_frames": totals["static_frames"],
-        "late_frames": totals["late_frames"],
-        "timed_frames": timed,
-        "late_pct": round(100.0 * totals["late_frames"] / timed, 3) if timed else None,
-        "missed_refreshes": totals["missed_refreshes"],
-        "late_by": totals["late_by"],
-        "early_frames": totals.get("early_frames", 0),
-        "early_pct": (round(100.0 * totals.get("early_frames", 0) / timed, 3)
-                      if timed else None),
-        "freeze_by": totals.get("freeze_by", {}),
-        "freezes": totals["freezes"],
-        "freezes_per_hour": round(totals["freezes"] / hours, 1) if hours else None,
-        "freeze_seconds": round(totals["freeze_seconds"], 2),
-        "worst_interval_ms": (round(totals["worst_interval_ms"], 1)
-                              if totals["worst_interval_ms"] else None),
-        "timing_ms": {name: percentiles(h, bucket_ms)
-                      for name, h in delta["histograms"].items()},
-    }
-    # The rate the panel held while rendering: the typical frame's interval
-    # per refresh held. A few percent under the idle rate is normal (the Pi is
-    # bit-banging the panel and pushing frames at once); a widening gap between
-    # the two is a render-cost regression even when nothing is late.
-    typical = (report["timing_ms"].get("interval_per_hold") or {}).get("p50")
-    # percentiles() reports a bucket's upper edge; the midpoint is the better
-    # estimate, and half a 0.25ms bucket is already ~1% at 100Hz -- the size
-    # of the idle-vs-held gap this number exists to show.
-    if isinstance(typical, (int, float)) and typical > bucket_ms / 2:
-        report["held_refresh_hz"] = round(1000.0 / (typical - bucket_ms / 2), 1)
-    else:
-        report["held_refresh_hz"] = None
-    return report
-
-
-def print_report(report: Dict[str, Any], limit: float) -> None:
-    info = report.get("info") or {}
-    size = "{}x{}".format(
-        (info.get("cols") or 0) * (info.get("chain_length") or 1),
-        (info.get("rows") or 0) * (info.get("parallel") or 1))
-    gil = {True: "releases the GIL", False: "STOCK (holds the GIL in SwapOnVSync)",
-           None: "unknown"}[report.get("binding_releases_gil")]
-    print(f"Rig       {info.get('pi_model') or 'unknown'}")
-    print(f"Panel     {size}  chain {info.get('chain_length')} x parallel "
-          f"{info.get('parallel')}  pwm_bits {info.get('pwm_bits')}  "
-          f"slowdown {info.get('gpio_slowdown')}  mapping {info.get('hardware_mapping')}")
-    print(f"Refresh   {report.get('measured_refresh_hz') or '?'} Hz measured, "
-          f"cap {info.get('limit_refresh_rate_hz')}")
-    print(f"Binding   {gil}")
-    print(f"Run       {report['seconds']:.0f}s, preview "
-          f"{'open (simulated)' if report['preview'] else 'as-is'}")
-    print()
-    frames = report["scroll_frames"]
-    print(f"Scrolling frames   {frames}")
-    if frames:
-        late_by = report["late_by"]
-        print(f"Late frames        {report['late_frames']} ({report['late_pct']}%)"
-              f"  missed refreshes {report['missed_refreshes']}"
-              f"  [by 1: {late_by['1']}, 2: {late_by['2']}, "
-              f"3-5: {late_by['3-5']}, 6+: {late_by['6+']}]")
-        if report["early_frames"]:
-            print(f"Early frames       {report['early_frames']} "
-                  f"({report['early_pct']}%)  swaps returned a refresh early")
-    print(f"Freezes >=250ms    {report['freezes']}"
-          f" ({report['freezes_per_hour']}/h, {report['freeze_seconds']}s total)"
-          f"  worst gap since start {report['worst_interval_ms'] or '-'} ms")
-    if report["freezes"]:
-        print("                   by length: " + ", ".join(
-            f"{k}: {v}" for k, v in report["freeze_by"].items()))
-    print()
-    print(f"{'ms':<18}{'p50':>8}{'p95':>8}{'p99':>8}{'max':>8}")
-    for name in ("blit", "wait", "work", "interval_per_hold"):
-        row = report["timing_ms"].get(name) or {}
-        print(f"{name:<18}" + "".join(f"{str(row.get(k, '-')):>8}"
-                                        for k in ("p50", "p95", "p99", "max")))
-    print()
-    if report["late_pct"] is None:
-        print("RESULT  nothing scrolled - no verdict")
-    elif not locked(report, limit):
-        ceiling = refresh_ceiling(report)
-        if (report.get("early_pct") or 0.0) > limit:
-            why = (f"{report['early_pct']}% of frames came a refresh early, so the "
-                   "swaps were not waiting for the panel")
-        else:
-            why = (f"frames arrived at {report['measured_refresh_hz']}Hz, faster than "
-                   f"the panel can refresh ({ceiling:g}Hz)")
-        print(f"RESULT  FAIL  NOT LOCKED: {why}, and the late count means nothing")
-    elif report["late_pct"] <= limit:
-        print(f"RESULT  PASS  {report['late_pct']}% late <= {limit}%")
-    else:
-        print(f"RESULT  FAIL  {report['late_pct']}% late > {limit}%")
-
-
-#: How far over the panel's rate frames may arrive before the loop cannot have
-#: been waiting for it. The margin covers the refresh wandering a little.
-CEILING_MARGIN = 1.05
-
-
-def refresh_ceiling(report: Dict[str, Any]) -> Optional[float]:
-    """The fastest the panel can refresh, as far as this run knows.
-
-    The benchmark measures it (``idle_refresh_hz``); the service only knows its
-    cap. With neither, there is no ceiling to check against.
-    """
-    idle = report.get("idle_refresh_hz")
-    if idle:
-        return float(idle)
-    cap = (report.get("info") or {}).get("limit_refresh_rate_hz")
-    try:
-        cap = float(cap)
-    except (TypeError, ValueError):
-        return None
-    return cap if cap > 0 else None
-
-
-def locked(report: Dict[str, Any], limit: float) -> bool:
-    """Whether the loop was paced by the panel at all.
-
-    Two ways it is not. Frames a whole refresh early mean some swaps did not
-    wait. And a loop that never waited at all -- the dirty-tracking skip firing
-    mid-scroll let one free-run at 827fps -- looks self-consistent to a refresh
-    estimate taken from its own frames, so nothing registers as early; what
-    gives it away is a "refresh" faster than the panel can physically do.
-    """
-    if (report.get("early_pct") or 0.0) > limit:
-        return False
-    ceiling = refresh_ceiling(report)
-    measured = report.get("measured_refresh_hz")
-    return not (ceiling and measured and measured > ceiling * CEILING_MARGIN)
-
-
-def passed(report: Dict[str, Any], limit: float) -> bool:
-    return (report["late_pct"] is not None and locked(report, limit)
-            and report["late_pct"] <= limit)
-
-
-def touch_marker() -> bool:
-    try:
-        with open(VIEWER_MARKER, "a"):
-            pass
-        os.utime(VIEWER_MARKER, None)
-        return True
-    except OSError:
-        return False
-
-
-def wait_for_fresh(path: str, timeout: float) -> Optional[Dict[str, Any]]:
-    """The first snapshot written after now, so both ends of the run are exact."""
-    first = load(path)
-    deadline = time.time() + timeout
-    while time.time() < deadline:
-        current = load(path)
-        if current and (first is None or current["updated"] != first["updated"]):
-            return current
-        time.sleep(0.5)
-    return None
-
-
-def main(argv=None) -> int:
-    parser = argparse.ArgumentParser(description=__doc__.split("\n")[0])
-    parser.add_argument("--duration", type=float, default=600.0,
-                        help="seconds to soak (default 600)")
-    parser.add_argument("--preview", action="store_true",
-                        help="keep the web-preview viewer marker fresh, as an "
-                             "open preview tab does")
-    parser.add_argument("--max-late-pct", type=float, default=0.1,
-                        help="fail above this percentage of late frames (default 0.1)")
-    parser.add_argument("--stats", default=default_stats_path(),
-                        help="stats file written by the display service")
-    parser.add_argument("--json", metavar="PATH",
-                        help="also write the report as JSON")
-    parser.add_argument("--show", action="store_true",
-                        help="print totals since the service started and exit")
-    args = parser.parse_args(argv)
-
-    current = load(args.stats)
-    if current is None:
-        print(f"No frame stats at {args.stats}. Is the display service running a "
-              "build with frame timing, and has anything scrolled for ~10s?",
-              file=sys.stderr)
-        return 2
-    if time.time() - current["updated"] > STALE_SECONDS:
-        print(f"Frame stats are {time.time() - current['updated']:.0f}s old: nothing "
-              "has been presented recently (static screen, or the service stopped).",
-              file=sys.stderr)
-        if not args.show:
-            return 2
-
-    if args.show:
-        empty = json.loads(json.dumps(current))
-        for key, value in empty["totals"].items():
-            empty["totals"][key] = ({k: 0 for k in value} if isinstance(value, dict)
-                                    else 0)
-        empty["histograms"] = {}
-        empty["updated"] = current["started"]
-        report = build_report(empty, current, preview=False)
-        print_report(report, args.max_late_pct)
-        return 0
-
-    if args.preview and not touch_marker():
-        print(f"Cannot touch {VIEWER_MARKER}; run as the web service's user to "
-              "simulate an open preview.", file=sys.stderr)
-        return 2
-
-    print(f"Waiting for a fresh baseline from {args.stats} ...", flush=True)
-    before = wait_for_fresh(args.stats, timeout=60.0)
-    if before is None:
-        print("The stats file stopped updating.", file=sys.stderr)
-        return 2
-
-    end = time.time() + args.duration
-    next_progress = time.time() + 60.0
-    while time.time() < end:
-        if args.preview:
-            touch_marker()
-        time.sleep(1.0)
-        if time.time() >= next_progress:
-            now = load(args.stats)
-            if now and now.get("pid") == before["pid"]:
-                done = now["totals"]["scroll_frames"] - before["totals"]["scroll_frames"]
-                late = now["totals"]["late_frames"] - before["totals"]["late_frames"]
-                print(f"  {int(end - time.time())}s left: {done} scrolling frames, "
-                      f"{late} late", flush=True)
-            next_progress += 60.0
-
-    after = wait_for_fresh(args.stats, timeout=60.0)
-    if after is None:
-        print("The stats file stopped updating during the run.", file=sys.stderr)
-        return 2
-    if after.get("pid") != before.get("pid"):
-        print("The display service restarted during the run; results discarded.",
-              file=sys.stderr)
-        return 2
-
-    report = build_report(before, after, preview=args.preview)
-    print()
-    print_report(report, args.max_late_pct)
-    if args.json:
-        with open(args.json, "w", encoding="utf-8") as handle:
-            json.dump(report, handle, indent=2)
-    if report["late_pct"] is None:
-        return 2
-    return 0 if passed(report, args.max_late_pct) else 1
-
-
-if __name__ == "__main__":
-    sys.exit(main())

scripts/install/README.md

@@ -19,21 +19,6 @@ This directory contains scripts for installing and configuring the LEDMatrix sys
   (the user who runs the script, i.e. the one you installed LEDMatrix as;
   there is no `ledmatrix` system user) the passwordless `nmcli` and related
   WiFi permissions the web interface needs
-- **`install_dns_fix.sh`** - Optional. Installs `ledmatrix-dns-fix.service`,
-  which adds `options single-request` to the resolver when API calls time
-  out (see `systemd/README.md`)
-- **`install_mqtt_bridge.sh`** - Optional. Installs the Home Assistant MQTT
-  bridge service (see `integrations/mqtt_bridge/README.md`)
-
-Libraries (sourced, not run):
-
-- **`lib_sudoers.sh`** - The web interface's sudo allow-list
-  (`/etc/sudoers.d/ledmatrix_web`), shared by `first_time_install.sh` and
-  `configure_web_sudo.sh`
-- **`lib_systemd_render.sh`** - `sed_escape_replacement`, used by every
-  script that renders a unit from `systemd/*.service`
-- **`lib_lowmem.sh`** - Build-job sizing and temporary swap for the C++
-  build on low-memory Pis (`first_time_install.sh` Step 6)
 
 ## Usage
 

scripts/install/configure_web_sudo.sh

@@ -26,31 +26,17 @@ fi
 # Get the full paths to commands and validate each one
 MISSING_CMDS=()
 
-# Full path of a command, also looking in the sbin directories. This script runs
-# as the web user, whose PATH usually lacks /usr/sbin and /sbin -- where reboot
-# and poweroff live -- so `command -v` alone silently dropped their rules.
-find_command() {
-    local found
-    found=$(command -v "$1" 2>/dev/null) && { printf '%s\n' "$found"; return 0; }
-    for dir in /usr/sbin /sbin /usr/bin /bin; do
-        if [ -x "$dir/$1" ]; then
-            printf '%s\n' "$dir/$1"
-            return 0
-        fi
-    done
-    return 1
-}
-
-SYSTEMCTL_PATH=$(find_command systemctl) || true
-REBOOT_PATH=$(find_command reboot)    || true
-POWEROFF_PATH=$(find_command poweroff)  || true
-BASH_PATH=$(find_command bash)        || true
-JOURNALCTL_PATH=$(find_command journalctl) || true
+PYTHON_PATH=$(command -v python3)   || true
+SYSTEMCTL_PATH=$(command -v systemctl) || true
+REBOOT_PATH=$(command -v reboot)    || true
+POWEROFF_PATH=$(command -v poweroff)  || true
+BASH_PATH=$(command -v bash)        || true
+JOURNALCTL_PATH=$(command -v journalctl) || true
 SAFE_RM_PATH="$PROJECT_ROOT/scripts/fix_perms/safe_plugin_rm.sh"
 SAFE_PIP_INSTALL_PATH="$PROJECT_ROOT/scripts/fix_perms/safe_pip_install.sh"
 
-# Validate required commands (systemctl and bash are essential)
-for CMD_NAME in SYSTEMCTL_PATH BASH_PATH; do
+# Validate required commands (systemctl, bash, python3 are essential)
+for CMD_NAME in SYSTEMCTL_PATH BASH_PATH PYTHON_PATH; do
     CMD_VAL="${!CMD_NAME}"
     if [ -z "$CMD_VAL" ]; then
         MISSING_CMDS+=("$CMD_NAME")
@@ -73,17 +59,8 @@ if [ ! -f "$SAFE_PIP_INSTALL_PATH" ]; then
     exit 1
 fi
 
-# The rules are shared with first_time_install.sh (Step 10) so the two cannot
-# drift apart; add or remove a grant in lib_sudoers.sh, not here.
-SUDOERS_LIB="$PROJECT_DIR/lib_sudoers.sh"
-if [ ! -f "$SUDOERS_LIB" ]; then
-    echo "Error: Sudoers rules library not found: $SUDOERS_LIB" >&2
-    exit 1
-fi
-# shellcheck source=scripts/install/lib_sudoers.sh
-. "$SUDOERS_LIB"
-
 echo "Command paths:"
+echo "  Python: $PYTHON_PATH"
 echo "  Systemctl: $SYSTEMCTL_PATH"
 echo "  Reboot: ${REBOOT_PATH:-(not found, skipping)}"
 echo "  Poweroff: ${POWEROFF_PATH:-(not found, skipping)}"
@@ -92,24 +69,62 @@ echo "  Journalctl: ${JOURNALCTL_PATH:-(not found, skipping)}"
 echo "  Safe plugin rm: $SAFE_RM_PATH"
 echo "  Safe pip install: $SAFE_PIP_INSTALL_PATH"
 
-# Create a temporary sudoers file. A predictable name in a world-writable
-# directory is a symlink target, and these rules end up in /etc/sudoers.d, so
-# let mktemp pick the name; the trap removes it however the script ends.
-TEMP_SUDOERS=$(mktemp "${TMPDIR:-/tmp}/ledmatrix_web_sudoers.XXXXXX") || {
-    echo "Error: could not create a temporary file" >&2
-    exit 1
-}
-trap 'rm -f "$TEMP_SUDOERS"' EXIT
+# Create a temporary sudoers file
+TEMP_SUDOERS="/tmp/ledmatrix_web_sudoers_$$"
 
-web_sudoers_rules "$WEB_USER" "$PROJECT_ROOT" "$SYSTEMCTL_PATH" "$BASH_PATH" \
-    "$REBOOT_PATH" "$POWEROFF_PATH" "$JOURNALCTL_PATH" > "$TEMP_SUDOERS"
+{
+    echo "# LED Matrix Web Interface passwordless sudo configuration"
+    echo "# This allows the web interface user to run specific commands without a password"
+    echo ""
+    echo "# Allow $WEB_USER to run specific commands without a password for the LED Matrix web interface"
+
+    # Optional: reboot/poweroff (non-critical — skip if not found)
+    if [ -n "$REBOOT_PATH" ]; then
+        echo "$WEB_USER ALL=(ALL) NOPASSWD: $REBOOT_PATH"
+    fi
+    if [ -n "$POWEROFF_PATH" ]; then
+        echo "$WEB_USER ALL=(ALL) NOPASSWD: $POWEROFF_PATH"
+    fi
+
+    # Required: systemctl
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH enable ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH disable ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH status ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix-web.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix-web.service"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix-web.service"
+
+    # Optional: journalctl (non-critical — skip if not found)
+    #
+    # NOEXEC, matching first_time_install.sh. These rules end in a wildcard and
+    # journalctl starts a pager, so without it the caller can reach a shell:
+    # less runs "!command" as the user the pager belongs to, which here is
+    # root. NOEXEC stops the granted command executing anything of its own.
+    if [ -n "$JOURNALCTL_PATH" ]; then
+        echo "$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix.service *"
+        echo "$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix *"
+        echo "$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -t ledmatrix *"
+    fi
+
+    echo ""
+    echo "# Allow web user to remove plugin directories via vetted helper script"
+    echo "# The helper validates that the target path resolves inside plugin-repos/ or plugins/"
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $BASH_PATH $SAFE_RM_PATH *"
+    echo ""
+    echo "# Allow web user to install a plugin's requirements.txt as root via vetted"
+    echo "# helper script, so packages are visible to root-run ledmatrix.service"
+    echo "# (not just the web interface's own user). The helper validates the target"
+    echo "# is requirements.txt at the project root or under plugin-repos/ or plugins/."
+    echo "$WEB_USER ALL=(ALL) NOPASSWD: $BASH_PATH $SAFE_PIP_INSTALL_PATH *"
+} > "$TEMP_SUDOERS"
 
 # Never offer to install rules we have not parsed. A malformed drop-in in
 # /etc/sudoers.d makes sudo refuse every command for every user.
-# visudo lives in /usr/sbin, which is not on every user's PATH.
-if ! command -v visudo >/dev/null 2>&1 && [ -x /usr/sbin/visudo ]; then
-    PATH="$PATH:/usr/sbin"
-fi
 if command -v visudo >/dev/null 2>&1; then
     if ! visudo -c -f "$TEMP_SUDOERS" >/dev/null 2>&1; then
         echo ""
@@ -119,8 +134,6 @@ if command -v visudo >/dev/null 2>&1; then
         rm -f "$TEMP_SUDOERS"
         exit 1
     fi
-else
-    echo "⚠ visudo not found; the rules below have not been validated"
 fi
 
 echo ""
@@ -149,7 +162,7 @@ if [[ ! $REPLY =~ ^[Yy]$ ]]; then
     exit 0
 fi
 
-# Apply the configuration
+# Apply the configuration using visudo
 echo "Applying sudoers configuration..."
 # Harden the helper script: root-owned, not writable by web user
 echo "Hardening safe_plugin_rm.sh ownership..."
@@ -168,29 +181,21 @@ if ! sudo chmod 755 "$SAFE_PIP_INSTALL_PATH"; then
 fi
 
 if sudo cp "$TEMP_SUDOERS" /etc/sudoers.d/ledmatrix_web; then
-    # sudo reads /etc/sudoers.d files that are root-owned and not writable by
-    # group or other; 440 is the mode visudo and first_time_install.sh use.
-    if ! sudo chmod 440 /etc/sudoers.d/ledmatrix_web; then
-        echo "Warning: could not set mode 440 on /etc/sudoers.d/ledmatrix_web"
-    fi
     echo "Configuration applied successfully!"
     echo ""
     echo "Testing sudo access..."
     
-    # Ask sudo whether two of the new rules let this user in without a
-    # password. `sudo -l CMD` answers from the rules without running CMD, so
-    # this does not depend on whether ledmatrix.service is running, and it
-    # tests commands the rules actually grant.
-    if sudo -n -l "$SYSTEMCTL_PATH" status ledmatrix.service > /dev/null 2>&1; then
+    # Test a few commands
+    if sudo -n systemctl status ledmatrix.service > /dev/null 2>&1; then
         echo "✓ systemctl status ledmatrix.service - OK"
     else
-        echo "✗ systemctl status ledmatrix.service - not allowed without a password"
+        echo "✗ systemctl status ledmatrix.service - Failed"
     fi
-
-    if sudo -n -l "$BASH_PATH" "$SAFE_RM_PATH" "$PROJECT_ROOT/plugin-repos/example" > /dev/null 2>&1; then
-        echo "✓ safe_plugin_rm.sh helper - OK"
+    
+    if sudo -n test -f "$PROJECT_ROOT/start_display.sh"; then
+        echo "✓ File access test - OK"
     else
-        echo "✗ safe_plugin_rm.sh helper - not allowed without a password"
+        echo "✗ File access test - Failed"
     fi
     
     echo ""

scripts/install/configure_wifi_permissions.sh

@@ -144,11 +144,6 @@ $WEB_USER ALL=(ALL) NOPASSWD: $MKDIR_PATH -p /etc/NetworkManager/dnsmasq-shared.
 $WEB_USER ALL=(ALL) NOPASSWD: /usr/bin/cp /tmp/hostapd.conf /etc/hostapd/hostapd.conf
 $WEB_USER ALL=(ALL) NOPASSWD: /usr/bin/cp /tmp/dnsmasq.conf /etc/dnsmasq.d/ledmatrix-captive.conf
 $WEB_USER ALL=(ALL) NOPASSWD: /usr/bin/rm -f /etc/dnsmasq.d/ledmatrix-captive.conf
-# The same captive-portal DNS drop-in for NetworkManager's shared-mode dnsmasq
-# (wifi_manager._write_nm_dnsmasq_captive_conf / _remove_nm_dnsmasq_captive_conf),
-# exact paths.
-$WEB_USER ALL=(ALL) NOPASSWD: /usr/bin/cp /tmp/ledmatrix-nm-dnsmasq.conf /etc/NetworkManager/dnsmasq-shared.d/ledmatrix-captive.conf
-$WEB_USER ALL=(ALL) NOPASSWD: /usr/bin/rm -f /etc/NetworkManager/dnsmasq-shared.d/ledmatrix-captive.conf
 EOF
 
 echo "Generated sudoers configuration:"
@@ -156,21 +151,6 @@ echo "--------------------------------"
 cat "$TEMP_SUDOERS"
 echo "--------------------------------"
 
-# Never install rules we have not parsed. A malformed drop-in in
-# /etc/sudoers.d makes sudo refuse every command for every user, which on a
-# headless Pi leaves no way in at all. first_time_install.sh and
-# configure_web_sudo.sh check their rules the same way.
-if command -v visudo >/dev/null 2>&1; then
-    if ! visudo -c -f "$TEMP_SUDOERS" >/dev/null 2>&1; then
-        echo "✗ The generated sudoers rules did not parse:" >&2
-        visudo -c -f "$TEMP_SUDOERS" >&2 || true
-        echo "  Leaving $SUDOERS_FILE unchanged." >&2
-        exit 1
-    fi
-else
-    echo "⚠ visudo not found; installing the sudoers rules unvalidated"
-fi
-
 # Apply the sudoers configuration
 echo ""
 echo "Applying sudoers configuration..."
@@ -233,14 +213,11 @@ rm -f "$TEMP_POLKIT"
 echo ""
 echo "Step 3: Testing permissions..."
 
-# Ask sudo whether one of the new rules lets this user in without a password.
-# `sudo -l CMD` answers from the rules without running CMD, so the radio is
-# left alone. (This used to run `nmcli device status`, which is not granted,
-# so it could only ever report a failure.)
-if sudo -n -l "$NMCLI_PATH" radio wifi on > /dev/null 2>&1; then
-    echo "✓ nmcli radio wifi on - OK"
+# Test sudo access
+if sudo -n "$NMCLI_PATH" device status > /dev/null 2>&1; then
+    echo "✓ nmcli device status - OK"
 else
-    echo "✗ nmcli radio wifi on - not allowed without a password"
+    echo "✗ nmcli device status - Failed (this is expected if not connected)"
 fi
 
 echo ""

scripts/install/install_dns_fix.sh

@@ -10,10 +10,6 @@
 set -e
 
 PROJECT_ROOT_DIR=$(cd "$(dirname "$0")/../.." && pwd)
-
-# shellcheck source=scripts/install/lib_systemd_render.sh
-source "$PROJECT_ROOT_DIR/scripts/install/lib_systemd_render.sh"
-
 SERVICE_NAME="ledmatrix-dns-fix"
 UNIT_SRC="$PROJECT_ROOT_DIR/systemd/$SERVICE_NAME.service"
 UNIT_DEST="/etc/systemd/system/$SERVICE_NAME.service"
@@ -38,8 +34,7 @@ fi
 chmod +x "$PROJECT_ROOT_DIR/scripts/utils/apply_dns_single_request.sh"
 
 echo "Installing $UNIT_DEST..."
-ESCAPED_PROJECT_ROOT_DIR=$(sed_escape_replacement "$PROJECT_ROOT_DIR")
-sed "s|__PROJECT_ROOT_DIR__|$ESCAPED_PROJECT_ROOT_DIR|g" "$UNIT_SRC" \
+sed "s|__PROJECT_ROOT_DIR__|$PROJECT_ROOT_DIR|g" "$UNIT_SRC" \
     | $SUDO tee "$UNIT_DEST" > /dev/null
 
 # Order ledmatrix.service after the fix. `Before=` in the unit itself only

scripts/install/install_mqtt_bridge.sh

@@ -9,10 +9,6 @@
 set -e
 
 PROJECT_ROOT_DIR=$(cd "$(dirname "$0")/../.." && pwd)
-
-# shellcheck source=scripts/install/lib_systemd_render.sh
-source "$PROJECT_ROOT_DIR/scripts/install/lib_systemd_render.sh"
-
 BRIDGE_DIR="$PROJECT_ROOT_DIR/integrations/mqtt_bridge"
 SERVICE_NAME="ledmatrix-mqtt-bridge"
 UNIT_SRC="$PROJECT_ROOT_DIR/systemd/$SERVICE_NAME.service"
@@ -44,8 +40,7 @@ python3 -m pip install -r "$BRIDGE_DIR/requirements.txt" 2>/dev/null \
     || python3 -m pip install --break-system-packages -r "$BRIDGE_DIR/requirements.txt"
 
 echo "Installing $UNIT_DEST..."
-ESCAPED_PROJECT_ROOT_DIR=$(sed_escape_replacement "$PROJECT_ROOT_DIR")
-sed "s|__PROJECT_ROOT_DIR__|$ESCAPED_PROJECT_ROOT_DIR|g" "$UNIT_SRC" \
+sed "s|__PROJECT_ROOT_DIR__|$PROJECT_ROOT_DIR|g" "$UNIT_SRC" \
     | $SUDO tee "$UNIT_DEST" > /dev/null
 
 $SYSTEMCTL_CMD daemon-reload

scripts/install/install_wifi_monitor.sh

@@ -51,25 +51,20 @@ if [ ${#MISSING_PACKAGES[@]} -gt 0 ]; then
     
     # Install packages automatically (no prompt)
     # Use apt directly if running as root, otherwise use sudo
-    PACKAGES_OK=true
     if [ "$EUID" -eq 0 ]; then
         apt update || echo "⚠ apt update failed, continuing anyway..."
         apt install -y "${MISSING_PACKAGES[@]}" || {
-            PACKAGES_OK=false
             echo "⚠ Package installation failed, but continuing with WiFi monitor setup"
             echo "  You may need to install packages manually: apt install -y ${MISSING_PACKAGES[*]}"
         }
     else
         sudo apt update || echo "⚠ apt update failed, continuing anyway..."
         sudo apt install -y "${MISSING_PACKAGES[@]}" || {
-            PACKAGES_OK=false
             echo "⚠ Package installation failed, but continuing with WiFi monitor setup"
             echo "  You may need to install packages manually: sudo apt install -y ${MISSING_PACKAGES[*]}"
         }
     fi
-    if [ "$PACKAGES_OK" = true ]; then
-        echo "✓ Package installation completed"
-    fi
+    echo "✓ Package installation completed"
 fi
 
 # Render the unit from systemd/ledmatrix-wifi-monitor.service rather than

scripts/install/lib_sudoers.sh

@@ -1,76 +0,0 @@
-#!/bin/bash
-#
-# The web interface's passwordless-sudo allow-list, /etc/sudoers.d/ledmatrix_web.
-#
-# Sourced by first_time_install.sh (Step 10) and
-# scripts/install/configure_web_sudo.sh. Both used to carry their own copy of
-# these rules, and the copies drifted: one granted safe_pip_install.sh and the
-# other did not. Each caller still owns its own validate (visudo -c) / install /
-# confirm flow; this file only prints the rules.
-#
-# Add or remove a grant here and nowhere else.
-
-# web_sudoers_rules WEB_USER PROJECT_ROOT SYSTEMCTL_PATH BASH_PATH REBOOT_PATH POWEROFF_PATH JOURNALCTL_PATH
-#
-# Print the ledmatrix_web sudoers rules to stdout.
-#
-# SYSTEMCTL_PATH and BASH_PATH are required, and the caller must make sure they
-# are not empty: `visudo -c` does not catch every such rule (with an empty
-# BASH_PATH the helper rules still parse, granting the script itself).
-# first_time_install.sh stops on a failed `which`; configure_web_sudo.sh checks
-# them before calling this.
-# REBOOT_PATH, POWEROFF_PATH and JOURNALCTL_PATH are optional: pass "" and
-# their rules are left out.
-web_sudoers_rules() {
-    local WEB_USER="${1:-}"
-    local PROJECT_ROOT="${2:-}"
-    local SYSTEMCTL_PATH="${3:-}"
-    local BASH_PATH="${4:-}"
-    local REBOOT_PATH="${5:-}"
-    local POWEROFF_PATH="${6:-}"
-    local JOURNALCTL_PATH="${7:-}"
-
-    cat << EOF
-# LED Matrix Web Interface passwordless sudo configuration
-# This allows the web interface user to run specific commands without a password
-
-# Allow $WEB_USER to run specific commands without a password for the LED Matrix web interface
-EOF
-    if [ -n "$REBOOT_PATH" ]; then
-        printf '%s\n' "$WEB_USER ALL=(ALL) NOPASSWD: $REBOOT_PATH"
-    fi
-    if [ -n "$POWEROFF_PATH" ]; then
-        printf '%s\n' "$WEB_USER ALL=(ALL) NOPASSWD: $POWEROFF_PATH"
-    fi
-    cat << EOF
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH enable ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH disable ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH status ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH is-active ledmatrix.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH start ledmatrix-web.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH stop ledmatrix-web.service
-$WEB_USER ALL=(ALL) NOPASSWD: $SYSTEMCTL_PATH restart ledmatrix-web.service
-$WEB_USER ALL=(ALL) NOPASSWD: $BASH_PATH $PROJECT_ROOT/scripts/fix_perms/safe_plugin_rm.sh *
-# Install a requirements.txt as root via vetted helper, so packages are visible
-# to root-run ledmatrix.service (not just the web interface's own user).
-$WEB_USER ALL=(ALL) NOPASSWD: $BASH_PATH $PROJECT_ROOT/scripts/fix_perms/safe_pip_install.sh *
-EOF
-    if [ -n "$JOURNALCTL_PATH" ]; then
-        cat << EOF
-# NOEXEC, because these rules end in a wildcard and journalctl starts a pager
-# when its output is a terminal. From that pager (less) a "!sh" is a root
-# shell -- the standard journalctl escalation. The web interface always passes
-# --no-pager, so nothing here needs it, but the rule cannot require a flag that
-# sits in the middle of the command line. NOEXEC stops the command executing
-# another program at all, which closes the hole without depending on wildcard
-# matching subtleties.
-$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix.service *
-$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -u ledmatrix *
-$WEB_USER ALL=(ALL) NOPASSWD:NOEXEC: $JOURNALCTL_PATH -t ledmatrix *
-EOF
-    fi
-}

scripts/install/lib_systemd_render.sh

@@ -2,10 +2,9 @@
 #
 # Shared helper for rendering systemd unit templates via sed.
 #
-# Sourced by install_service.sh, install_web_service.sh,
-# install_wifi_monitor.sh, install_dns_fix.sh and install_mqtt_bridge.sh so
-# every unit renderer escapes sed replacement text the same way instead of
-# carrying its own copy of the fix.
+# Sourced by install_service.sh, install_web_service.sh and
+# install_wifi_monitor.sh so all three escape sed replacement text the same
+# way instead of carrying three copies of the same fix.
 
 # sed_escape_replacement VALUE
 #

scripts/install/one-shot-install.sh

@@ -205,6 +205,27 @@ check_sudo() {
     print_success "Sudo access confirmed"
 }
 
+# Fix /tmp permissions if needed (common issue when running via curl | bash)
+# Note: /tmp permission fixing is now done inline before running first_time_install.sh
+# This function is kept for backward compatibility but not actively used
+fix_tmp_permissions() {
+    CURRENT_STEP="TMP directory check"
+    # Only fix if /tmp is actually not writable (don't preemptively fix)
+    if [ ! -w /tmp ]; then
+        print_warning "/tmp is not writable, attempting to fix..."
+        if [ "$EUID" -eq 0 ]; then
+            chmod 1777 /tmp 2>/dev/null || true
+        else
+            sudo chmod 1777 /tmp 2>/dev/null || true
+        fi
+    fi
+    
+    # Ensure TMPDIR is set correctly
+    if [ -z "${TMPDIR:-}" ] || [ ! -w "${TMPDIR:-/tmp}" ]; then
+        export TMPDIR=/tmp
+    fi
+}
+
 # Main installation function
 main() {
     print_step "LED Matrix One-Shot Installation"
@@ -408,13 +429,6 @@ main() {
         print_step "Installation Complete!"
         print_success "LED Matrix has been successfully installed!"
         echo ""
-        # first_time_install.sh -y reboots as its last action, so by now the
-        # reboot is under way (unless LEDMATRIX_SKIP_REBOOT_PROMPT=1 was set).
-        if [ "${LEDMATRIX_SKIP_REBOOT_PROMPT:-0}" != "1" ]; then
-            echo "The installer has just started a reboot to finish setup, so this"
-            echo "session may disconnect now. Give the Pi a few minutes to come back, then:"
-            echo ""
-        fi
         echo "Next steps:"
         echo "  1. Configure your settings: sudo nano $REPO_DIR/config/config.json"
         if command -v hostname >/dev/null 2>&1; then
@@ -435,7 +449,7 @@ main() {
         else
             echo "  2. Or use the web interface: http://<your-pi-ip>:5000"
         fi
-        echo "  3. The display service starts on boot; to start it by hand: sudo systemctl start ledmatrix.service"
+        echo "  3. Start the service: sudo systemctl start ledmatrix.service"
         echo ""
     else
         print_error "Main installation script exited with code $INSTALL_EXIT_CODE"

scripts/render_bench.py

@@ -1,404 +0,0 @@
-#!/usr/bin/env python3
-"""Benchmark the render loop against the panel's real refresh rate.
-
-The question this answers is the one that decides whether a rig ships: *does
-every frame present on the refresh it was meant to?* It drives the production
-path -- a real ``DisplayManager`` and ``ScrollHelper``, the same crisp speed
-resolver every ticker uses -- scrolls a synthetic strip for a while, and grades
-it with the same frame-timing recorder the display service uses
-(``src.common.frame_timing``), printing the same report as
-``scripts/frame_soak.py``. A run passes when the loop was genuinely locked to
-the panel and no more than ``--max-late-pct`` percent of frames were late.
-
-Where frame_soak.py measures the service as it runs -- live content, plugin
-updates, the web preview -- this measures the hardware and the render path
-with nothing else in the way, on content that is identical every run. That is
-what makes it the tool for comparing rigs (a Pi 3 against a Pi 4, one HAT
-against another) and for A/B testing a change to the render path.
-
-    # stop the service first; it owns the GPIO
-    sudo systemctl stop ledmatrix
-
-    sudo python3 scripts/render_bench.py                    # 60s, default speed
-    sudo python3 scripts/render_bench.py --seconds 600      # the 10-minute gate
-    sudo python3 scripts/render_bench.py --speed 50         # a slower, held speed
-    sudo python3 scripts/render_bench.py --busy 2           # with background load
-    sudo python3 scripts/render_bench.py --json /tmp/pi4.json
-
-    sudo systemctl start ledmatrix
-
-Like scripts/scroll_speeds.py, this never starts or stops the service itself,
-so a crash here can never leave the panel dark.
-
-Exit status is 0 when the run clears the gate, 1 when it does not, and 2 when
-the run could not be set up (no hardware, no root, unusable config) -- so a rig
-that cannot be measured is never mistaken for a rig that passed.
-"""
-from __future__ import annotations
-
-import argparse
-import json
-import logging
-import os
-import sys
-import threading
-import time
-import zlib
-from pathlib import Path
-
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
-
-from src.common import frame_timing, scroll_config  # noqa: E402
-
-sys.path.insert(0, str(Path(__file__).resolve().parent))
-import frame_soak  # noqa: E402  (same report, same verdict as the soak)
-
-REPO = Path(__file__).resolve().parent.parent
-CONFIG = REPO / "config" / "config.json"
-
-#: Long enough to average out a scheduler hiccup, short enough that nobody
-#: skips running it. The shipping gate is --seconds 600.
-DEFAULT_SECONDS = 60.0
-
-#: Seconds spent timing bare swaps before the scroll starts. The measurement
-#: has to settle, but every second here is a second not scrolling.
-MEASURE_SECONDS = 4.0
-
-#: Scrolling discarded before the graded run starts: the first frames carry
-#: first-touch costs and the scrolling state settling.
-WARMUP_SECONDS = 2.0
-
-
-def load_config() -> dict:
-    """The config the display service would run with."""
-    try:
-        from src.config_manager import ConfigManager
-
-        config = ConfigManager().config
-        if isinstance(config, dict) and config:
-            return config
-    except Exception as exc:  # noqa: BLE001 - any failure means use the plain read
-        print(f"ConfigManager unavailable ({exc}); reading {CONFIG} directly",
-              file=sys.stderr)
-    # ConfigManager pulls in a lot; a plain read is enough to drive the panel
-    # and keeps the benchmark usable on a half-installed machine.
-    try:
-        with open(CONFIG, encoding="utf-8") as handle:
-            config = json.load(handle)
-    except (OSError, ValueError) as exc:
-        sys.exit(f"could not read {CONFIG}: {exc}")
-    if not isinstance(config, dict):
-        sys.exit(f"{CONFIG} is not a config object")
-    return config
-
-
-def build_strip(width: int, height: int, label: str):
-    """A marquee strip a few screens wide, with text and colour.
-
-    Deliberately not plain white text on black: how long ``SetImage`` takes
-    depends on how many subpixels are lit, so a strip that is mostly dark
-    flatters the panel and hides exactly the regression this benchmark exists
-    to catch.
-    """
-    from PIL import Image, ImageDraw, ImageFont
-
-    from src.common.font_layout import load_truetype
-
-    font = None
-    for path, size in (
-        (str(REPO / "assets/fonts/PressStart2P-Regular.ttf"), max(8, height // 4)),
-        ("/usr/share/fonts/truetype/dejavu/DejaVuSansMono-Bold.ttf", max(10, height // 2)),
-    ):
-        try:
-            font = load_truetype(path, size)
-            break
-        except OSError:
-            continue
-    if font is None:
-        font = ImageFont.load_default()
-
-    text = f"  {label}  ***  THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG  ***  "
-    probe = ImageDraw.Draw(Image.new("RGB", (8, 8)))
-    box = probe.textbbox((0, 0), text, font=font)
-    text_width = max(1, box[2] - box[0])
-    text_height = box[3] - box[1]
-
-    reps = max(2, (width * 4) // text_width + 1)
-    strip = Image.new("RGB", (text_width * reps, height), (0, 0, 0))
-    draw = ImageDraw.Draw(strip)
-    draw.fontmode = "1"  # the panel has no partial brightness; see DisplayManager
-    palette = [(255, 210, 60), (80, 200, 255), (255, 90, 90), (140, 255, 140)]
-    for i in range(reps):
-        left = i * text_width
-        # A filled block per repeat, so a meaningful share of the strip is lit.
-        draw.rectangle(
-            [left + 4, height - 4, left + text_width - 4, height - 2],
-            fill=palette[i % len(palette)],
-        )
-        draw.text((left, (height - text_height) // 2 - box[1]), text,
-                  font=font, fill=palette[(i + 1) % len(palette)])
-    return strip
-
-
-class BackgroundLoad:
-    """Threads that imitate plugins updating while the panel scrolls.
-
-    Not a simulation of any particular plugin -- it is the shape of the work
-    that competes with the render loop for the GIL: decoding JSON, resizing an
-    image, compressing bytes. A render loop that only holds its pacing on an
-    idle machine is not shippable, and this is how that shows up.
-    """
-
-    def __init__(self, workers: int) -> None:
-        self.workers = max(0, workers)
-        self._stop = threading.Event()
-        self._threads: list = []
-
-    def __enter__(self) -> "BackgroundLoad":
-        for index in range(self.workers):
-            thread = threading.Thread(
-                target=self._run, args=(index,), name=f"bench-load-{index}", daemon=True)
-            thread.start()
-            self._threads.append(thread)
-        return self
-
-    def __exit__(self, *exc_info) -> None:
-        self._stop.set()
-        for thread in self._threads:
-            thread.join(timeout=2.0)
-
-    def _run(self, index: int) -> None:
-        from PIL import Image
-
-        payload = json.dumps({"games": [{"id": n, "score": [n, n + 1],
-                                         "name": f"team {n}"} for n in range(200)]})
-        image = Image.new("RGB", (256, 64), (12, 34, 56))
-        while not self._stop.wait(0.25 + 0.05 * index):
-            json.loads(payload)
-            image.resize((128, 32), Image.LANCZOS)
-            zlib.compress(image.tobytes(), 1)
-
-
-
-def main(argv=None) -> int:
-    parser = argparse.ArgumentParser(
-        description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter)
-    parser.add_argument("--seconds", type=float, default=DEFAULT_SECONDS,
-                        help=f"how long to scroll for (default {DEFAULT_SECONDS:.0f}; "
-                             "the shipping gate is 600)")
-    parser.add_argument("--speed", type=float, default=None,
-                        help="requested px/s; snapped to the nearest speed the "
-                             "panel can show in whole pixels (default: one pixel "
-                             "per refresh)")
-    parser.add_argument("--hz", type=float, default=None,
-                        help="skip the idle measurement and take this as the "
-                             "panel's rate (for reproducing a rig's numbers)")
-    parser.add_argument("--busy", type=int, default=0, metavar="N",
-                        help="run N background workers imitating plugin updates")
-    parser.add_argument("--max-late-pct", "--max-missed", dest="max_late_pct",
-                        type=float, default=0.1, metavar="PCT",
-                        help="fail above this percentage of late frames (default 0.1)")
-    parser.add_argument("--json", dest="json_path", default=None, metavar="PATH",
-                        help="also write the report as JSON, for comparing rigs")
-    parser.add_argument("--label", default=None,
-                        help="name for this run in the JSON report (default: hostname)")
-    args = parser.parse_args(argv)
-
-    # Everything the display service logs would otherwise land in the middle of
-    # the report; the benchmark's own output is the point. The stall watchdog
-    # is the exception: a stack dump naming what held a frame up belongs here.
-    logging.basicConfig(level=logging.ERROR, stream=sys.stderr)
-    logging.getLogger("src.common.frame_timing").setLevel(logging.WARNING)
-
-    if hasattr(os, "geteuid") and os.geteuid() != 0:
-        print("this needs root for GPIO access - rerun with sudo", file=sys.stderr)
-        return 2
-
-    config = load_config()
-
-    from src.common.scroll_helper import ScrollHelper
-    from src.display_manager import DisplayManager
-
-    try:
-        display = DisplayManager(config, suppress_test_pattern=True)
-    except Exception as exc:
-        print(f"could not open the display ({exc}).\n"
-              "If the display service is running it owns the GPIO - stop it "
-              "first:\n    sudo systemctl stop ledmatrix", file=sys.stderr)
-        return 2
-
-    if getattr(display, "matrix", None) is None:
-        print("the display came up in fallback mode - there is no panel here to "
-              "measure, and a software loop's frame times say nothing about "
-              "vsync. Run this on a rig.", file=sys.stderr)
-        return 2
-
-    width, height = display.width, display.height
-
-    if args.hz is not None:
-        idle_hz = float(args.hz)
-        print(f"taking the panel's rate as {idle_hz:.1f}Hz (given, not measured)")
-    else:
-        print(f"measuring the panel for {MEASURE_SECONDS:.0f}s...", flush=True)
-        idle_hz = frame_timing.measure_refresh_hz(display.matrix, MEASURE_SECONDS)
-        if idle_hz <= 0:
-            print("the panel did not answer a swap; cannot measure it",
-                  file=sys.stderr)
-            return 2
-        cap = scroll_config.refresh_hz_from_config(config)
-        note = (f" (cap is {cap:.0f}Hz)" if idle_hz < cap * 0.98
-                else " (at its configured cap)")
-        print(f"panel refreshes at {idle_hz:.1f}Hz{note}")
-
-    requested = args.speed if args.speed else idle_hz
-
-    # Configured through the shared resolver rather than by setting the helper
-    # up by hand, so the benchmark measures the engine every ticker runs on. A
-    # speed the bench reached some other way would be measuring something no
-    # plugin does.
-    helper = ScrollHelper(width, height)
-    settings = scroll_config.configure(
-        helper,
-        plugin_config={"scroll_pixels_per_second": requested},
-        global_config=config,
-        refresh_hz=idle_hz,
-        display_manager=display,
-    )
-    choice = settings.crisp
-    if choice is None:
-        print("the resolver did not snap to a whole-pixel speed; nothing to "
-              "grade against", file=sys.stderr)
-        return 2
-    print(f"asked for {requested:.1f} px/s -> {choice.describe()}")
-
-    helper.set_sub_pixel_scrolling(False)
-    helper.set_scrolling_image(
-        build_strip(width, height, f"{choice.pixels_per_second:.0f} px/s"))
-
-    # The display service's own recorder, owned outright here: never flushed to
-    # the service's stats file, drained exactly at the start and end of the
-    # graded run, and seeded with the idle rate so a loop that never locked
-    # (free-running, or stuck at a fraction of the refresh) shows as early or
-    # late frames instead of looking self-consistent.
-    recorder = frame_timing.FrameTimingRecorder(
-        flush_interval=float("inf"),
-        info=display._frame_timing_info(),  # pylint: disable=protected-access
-        refresh_hz=idle_hz,
-    )
-    recorder.scrolling_now = display._scrolling_now  # pylint: disable=protected-access
-    display.frame_timing = recorder
-
-    print(f"scrolling {width}x{height} for {args.seconds:.0f}s"
-          + (f" with {args.busy} background worker(s)" if args.busy else "")
-          + " ...", flush=True)
-
-    frames = 0
-    duplicates = 0
-    blanks = 0
-    restarts = 0
-    last_column = None
-    before = None
-    started = time.perf_counter()
-    run_started = None
-    try:
-        with BackgroundLoad(args.busy):
-            while True:
-                now = time.perf_counter()
-                if run_started is None and now - started >= WARMUP_SECONDS:
-                    recorder.drain()
-                    before = recorder.snapshot()
-                    run_started = now
-                    frames = duplicates = blanks = restarts = 0
-                if run_started is not None and now - run_started >= args.seconds:
-                    break
-                helper.update_scroll_position()
-                if helper.is_scroll_complete():
-                    # The helper parks at the end of the strip and stops
-                    # advancing, exactly as it does under a plugin -- which
-                    # then hands over to the next one. Here there is nothing
-                    # to hand over to, so start the strip again. Without this
-                    # the benchmark measures a still image for the rest of the
-                    # run and reports a smoothness it never demonstrated.
-                    helper.reset_scroll()
-                    restarts += 1
-                visible = helper.get_visible_portion()
-                column = int(helper.scroll_position)
-                if column == last_column:
-                    duplicates += 1
-                last_column = column
-                if visible is None:
-                    blanks += 1
-                else:
-                    display.image.paste(visible, (0, 0))
-                # Every frame, not once before the loop. The scrolling state
-                # expires on its own inactivity threshold and takes the frame
-                # hold with it, so a scroll that announces itself once is
-                # presented at the wrong rate for all but its first moments --
-                # and its unchanged frames start taking the dirty-tracking
-                # skip, which returns without waiting for the panel at all.
-                # Every ticker re-announces per frame; so does this.
-                display.set_scrolling_state(True, frame_hold=choice.frame_hold)
-                display.update_display()
-                frames += 1
-    except KeyboardInterrupt:
-        print("\ninterrupted - reporting what was measured so far")
-    finally:
-        display.set_scrolling_state(False)
-        try:
-            display.clear()
-        except Exception as exc:  # noqa: BLE001 - a lit panel is harmless; say so and go on
-            print(f"could not blank the panel: {exc}", file=sys.stderr)
-
-    if before is None:
-        print("interrupted during warm-up; nothing was graded", file=sys.stderr)
-        return 2
-    recorder.drain()
-    report = frame_soak.build_report(before, recorder.snapshot(), preview=False)
-    report["idle_refresh_hz"] = round(idle_hz, 2)
-
-    print()
-    frame_soak.print_report(report, args.max_late_pct)
-    held = report.get("held_refresh_hz")
-    if held:
-        drop = 100.0 * (idle_hz - held) / idle_hz
-        print(f"\npanel held ~{held:.1f}Hz while rendering, {drop:.1f}% below its "
-              f"{idle_hz:.1f}Hz idle rate (a widening gap is a render-cost "
-              "regression even with nothing late)")
-    if duplicates:
-        # A frame that shows the same columns as the one before it is work the
-        # panel did not need. It is not a miss -- the frame arrived on time --
-        # but it means the loop is presenting faster than the strip is moving.
-        print(f"duplicate   {duplicates} frames advanced no pixels "
-              f"({100.0 * duplicates / max(1, frames):.2f}%)")
-    if blanks:
-        print(f"blank       {blanks} frames had no visible slice to draw")
-    if restarts:
-        print(f"restarts    {restarts} (the strip was scrolled through "
-              f"{restarts} time{'s' if restarts != 1 else ''})")
-
-    if args.json_path:
-        report.update({
-            "label": args.label or os.uname().nodename,
-            "bench": True,
-            "requested_pixels_per_second": requested,
-            "pixels_per_second": choice.pixels_per_second,
-            "pixels_per_frame": choice.pixels_per_frame,
-            "frame_hold": choice.frame_hold,
-            "busy_workers": args.busy,
-            "duplicate_frames": duplicates,
-            "blank_frames": blanks,
-            "strip_restarts": restarts,
-            "max_late_pct": args.max_late_pct,
-            "passed": frame_soak.passed(report, args.max_late_pct),
-        })
-        Path(args.json_path).write_text(json.dumps(report, indent=2) + "\n",
-                                        encoding="utf-8")
-        print(f"\nwrote {args.json_path}")
-
-    if report["late_pct"] is None:
-        return 2
-    return 0 if frame_soak.passed(report, args.max_late_pct) else 1
-
-
-if __name__ == "__main__":
-    sys.exit(main())

scripts/run_plugin_tests.py

@@ -299,5 +299,6 @@ def main():
 
 if __name__ == '__main__':
     import importlib.util
+    from typing import Optional
     sys.exit(main())
 

scripts/scroll_speeds.py

@@ -42,7 +42,7 @@ from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
 
-from src.common import frame_timing, scroll_config  # noqa: E402
+from src.common import scroll_config  # noqa: E402
 
 CONFIG = Path(__file__).resolve().parent.parent / "config" / "config.json"
 
@@ -99,13 +99,20 @@ def open_matrix(config, refresh_override=None):
 def measure_refresh(config, seconds=6.0):
     """Actual refresh rate, by running uncapped and timing the swaps.
 
-    What an older Pi or a longer chain will really give you, as opposed to
-    whatever limit_refresh_rate_hz optimistically asks for. The timing loop
-    itself lives in src.common.frame_timing so the benchmark grades against
-    the same measurement this ladder is built from.
+    SwapOnVSync blocks until the panel's next refresh, so an unthrottled loop
+    runs at exactly the panel's rate. This is what an older Pi or a longer
+    chain will really give you, as opposed to whatever limit_refresh_rate_hz
+    optimistically asks for.
     """
     matrix = open_matrix(config, refresh_override=0)
-    measured = frame_timing.measure_refresh_hz(matrix, seconds)
+    canvas = matrix.CreateFrameCanvas()
+    canvas = matrix.SwapOnVSync(canvas)  # discard the first, it includes setup
+    frames = 0
+    started = time.perf_counter()
+    while time.perf_counter() - started < seconds:
+        canvas = matrix.SwapOnVSync(canvas)
+        frames += 1
+    measured = frames / (time.perf_counter() - started)
     matrix.Clear()
     return measured
 

scripts/utils/README.md

@@ -9,7 +9,6 @@ This directory contains utility scripts for maintenance and system operations.
 - **`wifi_monitor_daemon.py`** - Background daemon that monitors WiFi/Ethernet connection and manages access point mode
 - **`pixlet_config_editor.sh`** - Opens Pixlet's own config UI for one installed Starlark app
 - **`apply_dns_single_request.sh`** - Adds `options single-request` to the resolver (run by `ledmatrix-dns-fix.service`)
-- **`auto_update_verify.py`** - Health check after an automatic update, rolling back if it fails (the updater copies it to `data/` before pulling and `ledmatrix-update-verify.service` runs that copy)
 
 ## Usage
 

scripts/utils/wifi_monitor_daemon.py

@@ -42,8 +42,6 @@ class WiFiMonitorDaemon:
         """
         self.check_interval = check_interval
         self.wifi_manager = WiFiManager()
-        # mtime of wifi_config.json as last loaded; see _reload_config_if_changed.
-        self._config_mtime = self._config_file_mtime()
         self.running = True
         self.last_state = None
         # Counts consecutive checks where nmcli says "connected" but internet is unreachable.
@@ -59,32 +57,7 @@ class WiFiMonitorDaemon:
         """Handle shutdown signals"""
         logger.info(f"Received signal {signum}, shutting down...")
         self.running = False
-
-    def _config_file_mtime(self):
-        try:
-            return self.wifi_manager.config_path.stat().st_mtime_ns
-        except OSError:
-            return None
-
-    def _reload_config_if_changed(self):
-        """Re-read wifi_config.json when it has changed on disk.
-
-        The web UI's auto-enable toggle (POST /api/v3/wifi/ap/auto-enable)
-        only writes the file; this process read it once at startup, so the
-        toggle did nothing until the daemon restarted. One stat per check.
-        """
-        mtime = self._config_file_mtime()
-        if mtime is None or mtime == self._config_mtime:
-            return
-        before = self.wifi_manager.config.get("auto_enable_ap_mode", True)
-        self.wifi_manager._load_config()
-        # _load_config can itself save (it fills in missing keys), so take
-        # the mtime after it, or that save would trigger another reload.
-        self._config_mtime = self._config_file_mtime()
-        after = self.wifi_manager.config.get("auto_enable_ap_mode", True)
-        if after != before:
-            logger.info(f"wifi_config.json changed: auto_enable_ap_mode={after}")
-
+    
     def run(self):
         """Main daemon loop"""
         logger.info("WiFi Monitor Daemon started")
@@ -105,8 +78,6 @@ class WiFiMonitorDaemon:
         
         while self.running:
             try:
-                self._reload_config_if_changed()
-
                 # One combined check that also returns the state it observed —
                 # the previous flow fetched status before AND after the check
                 # on top of the check's own internal fetch, each one several
@@ -248,7 +219,7 @@ def main():
     parser.add_argument(
         '--foreground',
         action='store_true',
-        help='Accepted for compatibility; the daemon always runs in the foreground'
+        help='Run in foreground (for debugging)'
     )
     
     args = parser.parse_args()

src/__init__.py

@@ -4,5 +4,5 @@ LEDMatrix Display System
 Core source package for the LED Matrix Display project.
 """
 
-__version__ = "3.7.0"
+__version__ = "3.5.0"
 

src/adaptive_images.py

@@ -29,9 +29,13 @@ from typing import Any, Optional, Tuple
 
 from PIL import Image
 
-# Re-exported by src.common for plugins, which import them from there.
-RESAMPLE_LANCZOS = Image.Resampling.LANCZOS
-RESAMPLE_NEAREST = Image.Resampling.NEAREST
+# The one Pillow >= 9.1 compat shim (replaces the per-plugin copies).
+try:
+    RESAMPLE_LANCZOS = Image.Resampling.LANCZOS
+    RESAMPLE_NEAREST = Image.Resampling.NEAREST
+except AttributeError:  # Pillow < 9.1
+    RESAMPLE_LANCZOS = Image.LANCZOS
+    RESAMPLE_NEAREST = Image.NEAREST
 
 FIT_MODES = ("contain", "cover", "fill_height", "stretch")
 

src/auto_update_setup.py

@@ -70,14 +70,7 @@ def _read(path):
 
 
 def is_enabled(config):
-    # Only the {"enabled": true} object turns this on. A hand-edited
-    # non-dict (e.g. "auto_update": true) raised AttributeError here and
-    # aborted startup setup; the web UI's save replaces such a value with {}
-    # (disabled), so read it the same way.
-    section = config.get('auto_update')
-    if not isinstance(section, dict):
-        return False
-    return bool(section.get('enabled', False))
+    return bool((config.get('auto_update') or {}).get('enabled', False))
 
 
 class UpdateHelperSetup:
@@ -208,26 +201,17 @@ class UpdateHelperSetup:
         try:
             self.result_file.parent.mkdir(parents=True, exist_ok=True)
             fd, tmp = tempfile.mkstemp(dir=str(self.result_file.parent), prefix='.auto_update_setup_')
-            try:
-                with os.fdopen(fd, 'w', encoding='utf-8') as f:
-                    json.dump(result, f, indent=2)
-                os.chmod(tmp, 0o644)
-                if self._web_ids and hasattr(os, 'chown'):
-                    # Only root can give the file away; the result is readable
-                    # (0644) either way, so a failed chown must not lose it.
-                    try:
-                        os.chown(tmp, *self._web_ids)
-                    except OSError:
-                        pass
-                os.replace(tmp, self.result_file)
-            except BaseException:
-                # Don't leave a .auto_update_setup_* file behind in the
-                # project dir every time the write fails.
+            with os.fdopen(fd, 'w', encoding='utf-8') as f:
+                json.dump(result, f, indent=2)
+            os.chmod(tmp, 0o644)
+            if self._web_ids and hasattr(os, 'chown'):
+                # Only root can give the file away; the result is readable
+                # (0644) either way, so a failed chown must not lose it.
                 try:
-                    os.unlink(tmp)
+                    os.chown(tmp, *self._web_ids)
                 except OSError:
                     pass
-                raise
+            os.replace(tmp, self.result_file)
         except OSError as e:
             logger.warning("Could not record automatic update setup result: %s", e)
         return result

src/background_data_service.py

@@ -26,7 +26,6 @@ from enum import Enum
 from concurrent.futures import ThreadPoolExecutor
 import pytz
 from src.cache_manager import CacheManager
-from src.common.json_body import response_json
 from src.common.espn_dates import (
     RANGE_RETRY_SECONDS,
     _note_range_rejected,
@@ -103,32 +102,6 @@ class FetchResult:
     # FAILED, which turns "you cancelled this" into "this errored".
     final_status: Optional[FetchStatus] = None
 
-class _ConnectionRetryingSession:
-    """``session.get`` that retries a connection error a few times.
-
-    For ESPN date chunks, which bypass _make_request_with_retry: a failed
-    chunk is logged and skipped, so a brief network blip would otherwise drop
-    a month from a cached season. That protection used to come from the
-    session adapter's own retries, which every other request stacked with the
-    retry loop.
-    """
-
-    ATTEMPTS = 3
-    DELAY = 0.5
-
-    def __init__(self, session):
-        self._session = session
-
-    def get(self, *args, **kwargs):
-        for attempt in range(self.ATTEMPTS):
-            try:
-                return self._session.get(*args, **kwargs)
-            except requests.ConnectionError:
-                if attempt == self.ATTEMPTS - 1:
-                    raise
-                time.sleep(self.DELAY * (attempt + 1))
-
-
 class BackgroundDataService:
     """
     Background data service for fetching season data without blocking the main thread.
@@ -157,14 +130,19 @@ class BackgroundDataService:
         
         # Thread management
         self.executor = ThreadPoolExecutor(max_workers=max_workers, thread_name_prefix="BackgroundData")
-        # cache_key -> request_id for fetches currently in flight, so a second
-        # submit for the same key joins the running fetch instead of starting
-        # another. It is the normal case: a sport's Recent and Upcoming
-        # managers miss the cache for the same season schedule together.
+        # cache_key -> request_id for fetches currently in flight. Submitting
+        # the same key twice used to start two identical fetches: request_id
+        # carries a millisecond timestamp, so every submit looked new, and
+        # active_requests is keyed by it rather than by what is being fetched.
+        # On a real board the season-schedule key is requested by both the
+        # Recent and the Upcoming manager, which miss the cache in the same
+        # millisecond and each download and parse the same payload.
         self._inflight_by_cache_key: Dict[str, str] = {}
-        # Makes every request_id unique. The id also carries a millisecond
-        # timestamp, but two submits can share a millisecond, and a joiner
-        # uses the id as its handle for get_result().
+        # request_id was sport_year_milliseconds, which is not unique: two
+        # submits inside the same millisecond produced the SAME id, so one
+        # silently replaced the other in active_requests and completed_requests.
+        # Rare before, but dedupe hands this id back to every joiner as their
+        # handle for get_result(), so it has to be unique. A counter is enough.
         self._request_seq = itertools.count()
         self.active_requests: Dict[str, FetchRequest] = {}
         self.completed_requests: Dict[str, FetchResult] = {}
@@ -189,16 +167,10 @@ class BackgroundDataService:
             'average_fetch_time': 0.0
         }
         
-        # Session for HTTP requests. No retries at the adapter: a fetch goes
-        # through _make_request_with_retry (max_retries + 1 attempts with
-        # exponential backoff, logged), and date-range chunks through
-        # _ConnectionRetryingSession. With the adapter also retrying
-        # connection errors three times, a dead network cost up to 16
-        # connection attempts per request and held one of the few worker
-        # threads for all of them.
+        # Session for HTTP requests
         self.session = requests.Session()
-        self.session.mount('http://', requests.adapters.HTTPAdapter(max_retries=0))
-        self.session.mount('https://', requests.adapters.HTTPAdapter(max_retries=0))
+        self.session.mount('http://', requests.adapters.HTTPAdapter(max_retries=3))
+        self.session.mount('https://', requests.adapters.HTTPAdapter(max_retries=3))
         
         # Default headers: core's shared set (real User-Agent, no hand-set
         # Accept-Encoding) -- see src/common/api_helper.py.
@@ -213,9 +185,9 @@ class BackgroundDataService:
         This ensures Recent/Upcoming managers and background service
         use the same cache keys.
         """
-        # Same format as CacheManager.generate_sport_cache_key(), built here
-        # rather than by constructing a CacheManager (config load, cache-dir
-        # probing) on every submit without a cache_key.
+        # Same format as CacheManager.generate_sport_cache_key(). This used to
+        # build a whole CacheManager to call it -- config load, cache-dir
+        # probing with test writes -- on every submit without a cache_key.
         if date_str is None:
             date_str = datetime.now(pytz.utc).strftime('%Y%m%d')
         return f"{sport}_{date_str}"
@@ -279,19 +251,15 @@ class BackgroundDataService:
                 # same object the dict holds.
                 self.completed_requests[request_id] = result
 
-            # The callback runs outside the lock, as on the worker path: it is
-            # plugin code, and holding the service lock through it blocked
-            # every worker's result bookkeeping (and any other thread's
-            # submit) for as long as the callback took.
-            if callback:
-                try:
-                    callback(result)
-                except Exception as e:
-                    logger.error(f"Error in callback for request {request_id}: {e}")
-                self._release_payload(result)
+                if callback:
+                    try:
+                        callback(result)
+                    except Exception as e:
+                        logger.error(f"Error in callback for request {request_id}: {e}")
+                    self._release_payload(result)
 
-            logger.debug(f"Cache hit for {sport} {year} data")
-            return request_id
+                logger.debug(f"Cache hit for {sport} {year} data")
+                return request_id
         
         # limit above 500 makes an ESPN *scoreboard* return a truncated list
         # (src/common/espn_dates.py). Other endpoints need more: /teams has 762
@@ -362,8 +330,10 @@ class BackgroundDataService:
         
         try:
             with self._lock:
-                # A request cancelled while it sat in the executor queue stays
-                # cancelled: no download, no cache write, no callback.
+                # A request cancelled while it sat in the executor queue must
+                # stay cancelled. Overwriting the status here undid the cancel
+                # outright: the worker went on to download, cache and call back
+                # for work the caller had already withdrawn.
                 if request.status == FetchStatus.CANCELLED:
                     cancelled_before_start = True
                 else:
@@ -419,7 +389,7 @@ class BackgroundDataService:
                         response.raise_for_status()
                 else:
                     response.raise_for_status()
-                    data = response_json(response)
+                    data = response.json()
             
             # Validate data structure
             if not isinstance(data, dict):
@@ -492,9 +462,10 @@ class BackgroundDataService:
             logger.error(f"Failed to fetch {request.sport} {request.year} data: {error_msg}")
             
             with self._lock:
-                # A cancelled request stays CANCELLED even when its fetch
-                # failed: the finally block skips callbacks only for
-                # CANCELLED, and nobody is waiting on this fetch any more.
+                # Don't relabel a cancelled request. The callback gate in the
+                # finally block only suppresses CANCELLED, so promoting it to
+                # FAILED here delivered an error callback for a fetch nobody
+                # was waiting on any more.
                 if request.status != FetchStatus.CANCELLED:
                     request.status = FetchStatus.FAILED
                 request.error = error_msg
@@ -554,13 +525,20 @@ class BackgroundDataService:
                 except Exception as e:
                     logger.error(f"Error in callback for request {request.id}: {e}")
 
-            # Released after the loop, never inside it: every callback holds
-            # the same FetchResult (a sport's recent, upcoming and live
-            # managers usually share one fetch), so a release between
-            # deliveries would hand the later ones `result.data is None`.
+            # Released AFTER the loop, not inside it. Every callback here holds
+            # the same FetchResult, so releasing per-delivery handed the first
+            # one the data and every joiner `result.data is None` -- which is
+            # not a quiet degradation: they read `result.data.get('events')` and
+            # raise AttributeError, which this very loop catches and logs, so
+            # the symptom was one ERROR line and a manager that silently never
+            # got its schedule. Deduplication is the normal case, not a corner:
+            # a sport's recent, upcoming and live managers all ride one season
+            # fetch.
             #
-            # Only when there were callbacks: a request submitted without one
-            # collects its payload by polling get_result().
+            # Guarded on `callbacks`, because a request submitted without one
+            # has no other way to collect its payload than polling get_result().
+            # The old per-delivery release got that right by accident: an empty
+            # list never entered the loop body.
             if callbacks:
                 self._release_payload(result)
                 request.result = None
@@ -596,7 +574,7 @@ class BackgroundDataService:
         """
         logger.info("Recovering %s %s from a rejected date range", request.sport, request.year)
         return fetch_espn_date_chunks(
-            _ConnectionRetryingSession(self.session),
+            self.session,
             request.url,
             params=request.params,
             headers=request.headers,
@@ -742,6 +720,9 @@ class BackgroundDataService:
                 'completed_requests_count': len(self.completed_requests),
                 'max_completed_requests': self._max_completed_requests,
                 'completed_requests_usage_percent': (len(self.completed_requests) / self._max_completed_requests * 100) if self._max_completed_requests > 0 else 0,
+                # Nothing is queued outside the executor; kept for callers
+                # that read the key.
+                'queue_size': 0,
                 'last_cleanup': self._last_completed_requests_cleanup,
                 'cleanup_interval': self._completed_requests_cleanup_interval
             }
@@ -811,6 +792,27 @@ class BackgroundDataService:
             
             return removed_count
     
+    def clear_completed_requests(self, older_than_hours: int = 24):
+        """
+        Clear completed requests older than specified time.
+        
+        Args:
+            older_than_hours: Clear requests older than this many hours
+        """
+        cutoff_time = time.time() - (older_than_hours * 3600)
+        
+        with self._lock:
+            to_remove = []
+            for request_id, result in self.completed_requests.items():
+                if result.completed_at < cutoff_time:
+                    to_remove.append(request_id)
+            
+            for request_id in to_remove:
+                del self.completed_requests[request_id]
+            
+            if to_remove:
+                logger.info(f"Cleared {len(to_remove)} old completed requests")
+    
     def shutdown(self, wait: bool = True):
         """
         Shutdown the background data service.

src/backup_manager.py

@@ -83,31 +83,14 @@ BUNDLED_FONTS: frozenset[str] = frozenset({
 _CONFIG_REL = Path("config/config.json")
 _SECRETS_REL = Path("config/config_secrets.json")
 _WIFI_REL = Path("config/wifi_config.json")
-# A YouTube Music session: pure user state that has to be re-authenticated by
-# hand if lost, so a restore must bring it back.
+# Sits in config/ next to the three above and is pure user state — a
+# YouTube Music session that has to be re-authenticated by hand if lost.
+# It was omitted from backups, so a restore silently signed the user out.
 _YTM_REL = Path("config/ytm_auth.json")
 _FONTS_REL = Path("assets/fonts")
 _PLUGIN_UPLOADS_REL = Path("assets/plugins")
 _STATE_REL = Path("data/plugin_state.json")
 
-#: The sections that are one file each: (section name, path, the
-#: RestoreOptions flag that restores it). create, preview, validate and
-#: restore all walk this table. ytm_auth follows restore_wifi: it is
-#: device-local auth like the Wi-Fi settings, and a toggle of its own for one
-#: file would be noise in the restore dialog.
-_SINGLE_FILE_SECTIONS: Tuple[Tuple[str, Path, str], ...] = (
-    ("config", _CONFIG_REL, "restore_config"),
-    ("secrets", _SECRETS_REL, "restore_secrets"),
-    ("wifi", _WIFI_REL, "restore_wifi"),
-    ("ytm_auth", _YTM_REL, "restore_wifi"),
-)
-
-#: Sections holding credentials. Restored onto a device that has no copy yet,
-#: they would otherwise take the extracted temp file's umask mode (0o644,
-#: world-readable); 0o640 matches what config_manager_atomic gives secrets.
-_PRIVATE_SECTION_RELS = frozenset({_SECRETS_REL, _WIFI_REL, _YTM_REL})
-_PRIVATE_FILE_MODE = 0o640
-
 MANIFEST_NAME = "manifest.json"
 PLUGINS_MANIFEST_NAME = "plugins.json"
 
@@ -157,18 +140,34 @@ class RestoreResult:
 # ---------------------------------------------------------------------------
 
 
-def _ledmatrix_version() -> str:
-    """The release of the running core (``src.__version__``), recorded in the
-    manifest so a restore can tell which release wrote the backup."""
-    from src import __version__
-    return __version__
+def _ledmatrix_version(project_root: Path) -> str:
+    """Best-effort version string for the current install."""
+    version_file = project_root / "VERSION"
+    if version_file.exists():
+        try:
+            return version_file.read_text(encoding="utf-8").strip() or "unknown"
+        except OSError:
+            pass
+    head_file = project_root / ".git" / "HEAD"
+    if head_file.exists():
+        try:
+            head = head_file.read_text(encoding="utf-8").strip()
+            if head.startswith("ref: "):
+                ref = head[5:]
+                ref_path = project_root / ".git" / ref
+                if ref_path.exists():
+                    return ref_path.read_text(encoding="utf-8").strip()[:12] or "unknown"
+            return head[:12] or "unknown"
+        except OSError:
+            pass
+    return "unknown"
 
 
-def _build_manifest(contents: List[str]) -> Dict[str, Any]:
+def _build_manifest(contents: List[str], project_root: Path) -> Dict[str, Any]:
     return {
         "schema_version": SCHEMA_VERSION,
         "created_at": datetime.now(timezone.utc).isoformat().replace("+00:00", "Z"),
-        "ledmatrix_version": _ledmatrix_version(),
+        "ledmatrix_version": _ledmatrix_version(project_root),
         "hostname": socket.gethostname(),
         "contents": contents,
     }
@@ -179,34 +178,13 @@ def _build_manifest(contents: List[str]) -> Dict[str, Any]:
 # ---------------------------------------------------------------------------
 
 
-def _plugins_directory(project_root: Path) -> Path:
-    """The plugin install directory: ``plugin_system.plugins_directory`` from
-    config/config.json (relative to ``project_root`` unless absolute), or
-    ``plugin-repos`` when the config does not say or cannot be read."""
-    configured: Any = None
-    try:
-        with (project_root / _CONFIG_REL).open("r", encoding="utf-8") as f:
-            config = json.load(f)
-        if isinstance(config, dict):
-            plugin_system = config.get("plugin_system")
-            if isinstance(plugin_system, dict):
-                configured = plugin_system.get("plugins_directory")
-    except (OSError, json.JSONDecodeError):
-        pass
-    if not isinstance(configured, str) or not configured.strip():
-        configured = "plugin-repos"
-    path = Path(configured)
-    return path if path.is_absolute() else project_root / path
-
-
 def list_installed_plugins(project_root: Path) -> List[Dict[str, Any]]:
     """
     Return a list of currently-installed plugins suitable for the backup
     manifest. Each entry has ``plugin_id`` and ``version``.
 
-    Reads ``data/plugin_state.json`` if present, then adds any plugin it
-    does not list from the ``manifest.json`` files in the configured plugin
-    directory (see :func:`_plugins_directory`).
+    Reads ``data/plugin_state.json`` if present; otherwise walks the plugin
+    directory and reads each ``manifest.json``.
     """
     plugins: Dict[str, Dict[str, Any]] = {}
 
@@ -228,7 +206,8 @@ def list_installed_plugins(project_root: Path) -> List[Dict[str, Any]]:
         except (OSError, json.JSONDecodeError) as e:
             logger.warning("Could not read plugin_state.json: %s", e)
 
-    plugins_root = _plugins_directory(project_root)
+    # Fall back to scanning plugin-repos/ for manifests.
+    plugins_root = project_root / "plugin-repos"
     if plugins_root.exists():
         for entry in sorted(plugins_root.iterdir()):
             if not entry.is_dir():
@@ -241,10 +220,6 @@ def list_installed_plugins(project_root: Path) -> List[Dict[str, Any]]:
                     data = json.load(f)
             except (OSError, json.JSONDecodeError):
                 continue
-            # Valid JSON that is not an object (a list, a bare string) would
-            # raise AttributeError on .get() and abort the whole export.
-            if not isinstance(data, dict):
-                continue
             plugin_id = data.get("id") or entry.name
             if plugin_id not in plugins:
                 plugins[plugin_id] = {
@@ -320,17 +295,22 @@ def create_backup(
     contents: List[str] = []
 
     # Stream directly to a temp file so we never hold the whole ZIP in memory.
-    # The name is unique per call: a fixed "<zip>.tmp" was shared by two
-    # exports started in the same second, which then wrote the same file.
-    fd, tmp_name = tempfile.mkstemp(dir=str(output_dir), prefix=f".{zip_name}.", suffix=".tmp")
-    os.close(fd)
-    tmp_path = Path(tmp_name)
+    tmp_path = zip_path.with_suffix(".zip.tmp")
     try:
         with zipfile.ZipFile(tmp_path, "w", compression=zipfile.ZIP_DEFLATED) as zf:
-            for section, rel, _flag in _SINGLE_FILE_SECTIONS:
-                if (project_root / rel).exists():
-                    zf.write(project_root / rel, rel.as_posix())
-                    contents.append(section)
+            # Config files.
+            if (project_root / _CONFIG_REL).exists():
+                zf.write(project_root / _CONFIG_REL, _CONFIG_REL.as_posix())
+                contents.append("config")
+            if (project_root / _SECRETS_REL).exists():
+                zf.write(project_root / _SECRETS_REL, _SECRETS_REL.as_posix())
+                contents.append("secrets")
+            if (project_root / _WIFI_REL).exists():
+                zf.write(project_root / _WIFI_REL, _WIFI_REL.as_posix())
+                contents.append("wifi")
+            if (project_root / _YTM_REL).exists():
+                zf.write(project_root / _YTM_REL, _YTM_REL.as_posix())
+                contents.append("ytm_auth")
 
             # User-uploaded fonts.
             user_fonts = iter_user_fonts(project_root)
@@ -358,27 +338,10 @@ def create_backup(
                 contents.append("plugins")
 
             # Manifest goes last so that `contents` reflects what we actually wrote.
-            manifest = _build_manifest(contents)
+            manifest = _build_manifest(contents, project_root)
             zf.writestr(MANIFEST_NAME, json.dumps(manifest, indent=2))
 
-        # Same-second exports share a timestamp; number the later one rather
-        # than replacing the backup the first one just returned. The name is
-        # claimed with an exclusive create (O_EXCL fails if it exists), so two
-        # exports finishing together can't both pick the same free name; the
-        # replace then swaps the finished archive in over our own placeholder.
-        suffix = 2
-        while True:
-            try:
-                os.close(os.open(zip_path, os.O_CREAT | os.O_EXCL | os.O_WRONLY, 0o600))
-                break
-            except FileExistsError:
-                zip_path = output_dir / f"{Path(zip_name).stem}-{suffix}.zip"
-                suffix += 1
-        try:
-            os.replace(tmp_path, zip_path)
-        except BaseException:
-            zip_path.unlink(missing_ok=True)
-            raise
+        os.replace(tmp_path, zip_path)
     except Exception:
         tmp_path.unlink(missing_ok=True)
         raise
@@ -389,16 +352,15 @@ def create_backup(
 def preview_backup_contents(project_root: Path) -> Dict[str, Any]:
     """Return a summary of what ``create_backup`` would include."""
     project_root = Path(project_root).resolve()
-    preview: Dict[str, Any] = {
-        f"has_{section}": (project_root / rel).exists()
-        for section, rel, _flag in _SINGLE_FILE_SECTIONS
-    }
-    preview.update({
+    return {
+        "has_config": (project_root / _CONFIG_REL).exists(),
+        "has_secrets": (project_root / _SECRETS_REL).exists(),
+        "has_wifi": (project_root / _WIFI_REL).exists(),
+        "has_ytm_auth": (project_root / _YTM_REL).exists(),
         "user_fonts": [p.name for p in iter_user_fonts(project_root)],
         "plugin_uploads": len(iter_plugin_uploads(project_root)),
         "plugins": list_installed_plugins(project_root),
-    })
-    return preview
+    }
 
 
 # ---------------------------------------------------------------------------
@@ -469,10 +431,15 @@ def validate_backup(zip_path: Path) -> Tuple[bool, str, Dict[str, Any]]:
                     {},
                 )
 
-            detected: List[str] = [
-                section for section, rel, _flag in _SINGLE_FILE_SECTIONS
-                if rel.as_posix() in names
-            ]
+            detected: List[str] = []
+            if _CONFIG_REL.as_posix() in names:
+                detected.append("config")
+            if _SECRETS_REL.as_posix() in names:
+                detected.append("secrets")
+            if _WIFI_REL.as_posix() in names:
+                detected.append("wifi")
+            if _YTM_REL.as_posix() in names:
+                detected.append("ytm_auth")
             if any(n.startswith(_FONTS_REL.as_posix() + "/") for n in names):
                 detected.append("fonts")
             if any(
@@ -481,8 +448,7 @@ def validate_backup(zip_path: Path) -> Tuple[bool, str, Dict[str, Any]]:
             ):
                 detected.append("plugin_uploads")
 
-            # Whatever the archive's manifest holds; checked below.
-            plugins: Any = []
+            plugins: List[Dict[str, Any]] = []
             if PLUGINS_MANIFEST_NAME in names:
                 try:
                     plugins = json.loads(zf.read(PLUGINS_MANIFEST_NAME).decode("utf-8"))
@@ -525,7 +491,7 @@ def _extract_zip_safe(zip_path: Path, dest_dir: Path) -> None:
                 shutil.copyfileobj(src, dst, length=64 * 1024)
 
 
-def _copy_file(src: Path, dst: Path, new_mode: Optional[int] = None) -> None:
+def _copy_file(src: Path, dst: Path) -> None:
     """Replace ``dst`` with ``src``, atomically, without needing to own ``dst``.
 
     ``shutil.copy2`` opens the destination for writing, so it needs write
@@ -541,7 +507,6 @@ def _copy_file(src: Path, dst: Path, new_mode: Optional[int] = None) -> None:
 
     The destination's existing mode is preserved when there is one, so
     restoring secrets does not silently widen them to the umask default.
-    When there is none, ``new_mode`` (if given) is used instead of ``src``'s.
     """
     dst.parent.mkdir(parents=True, exist_ok=True)
 
@@ -563,8 +528,6 @@ def _copy_file(src: Path, dst: Path, new_mode: Optional[int] = None) -> None:
         shutil.copyfile(src, tmp_path)
         if existing_mode is not None:
             os.chmod(tmp_path, existing_mode)
-        elif new_mode is not None:
-            os.chmod(tmp_path, new_mode)
         else:
             shutil.copymode(src, tmp_path)
         if existing_owner is not None and hasattr(os, 'chown'):
@@ -621,19 +584,55 @@ def restore_backup(
             result.errors.append("Failed to extract backup")
             return result
 
-        for section, rel, flag in _SINGLE_FILE_SECTIONS:
-            if not (tmp_dir / rel).exists():
-                continue
-            if not getattr(options, flag):
-                result.skipped.append(section)
-                continue
+        # Main config.
+        if options.restore_config and (tmp_dir / _CONFIG_REL).exists():
             try:
-                _copy_file(tmp_dir / rel, project_root / rel,
-                           new_mode=_PRIVATE_FILE_MODE if rel in _PRIVATE_SECTION_RELS else None)
-                result.restored.append(section)
+                _copy_file(tmp_dir / _CONFIG_REL, project_root / _CONFIG_REL)
+                result.restored.append("config")
             except OSError as e:
-                logger.error("[Backup] Failed to restore %s: %s", rel.name, e, exc_info=True)
-                result.errors.append(f"Failed to restore {rel.name}")
+                logger.error("[Backup] Failed to restore config.json: %s", e, exc_info=True)
+                result.errors.append("Failed to restore config.json")
+        elif (tmp_dir / _CONFIG_REL).exists():
+            result.skipped.append("config")
+
+        # Secrets.
+        if options.restore_secrets and (tmp_dir / _SECRETS_REL).exists():
+            try:
+                _copy_file(tmp_dir / _SECRETS_REL, project_root / _SECRETS_REL)
+                result.restored.append("secrets")
+            except OSError as e:
+                logger.error(
+                    "[Backup] Failed to restore config_secrets.json: %s", e, exc_info=True
+                )
+                result.errors.append("Failed to restore config_secrets.json")
+        elif (tmp_dir / _SECRETS_REL).exists():
+            result.skipped.append("secrets")
+
+        # WiFi.
+        if options.restore_wifi and (tmp_dir / _WIFI_REL).exists():
+            try:
+                _copy_file(tmp_dir / _WIFI_REL, project_root / _WIFI_REL)
+                result.restored.append("wifi")
+            except OSError as e:
+                logger.error(
+                    "[Backup] Failed to restore wifi_config.json: %s", e, exc_info=True
+                )
+                result.errors.append("Failed to restore wifi_config.json")
+        elif (tmp_dir / _WIFI_REL).exists():
+            result.skipped.append("wifi")
+
+        # YouTube Music session. Follows restore_wifi rather than getting its
+        # own flag: it is device-local auth in the same sense, and a separate
+        # toggle for one file would be noise in the restore dialog.
+        if options.restore_wifi and (tmp_dir / _YTM_REL).exists():
+            try:
+                _copy_file(tmp_dir / _YTM_REL, project_root / _YTM_REL)
+                result.restored.append("ytm_auth")
+            except OSError as e:
+                logger.error("[Backup] Failed to restore ytm_auth.json: %s", e, exc_info=True)
+                result.errors.append("Failed to restore ytm_auth.json")
+        elif (tmp_dir / _YTM_REL).exists():
+            result.skipped.append("ytm_auth")
 
         # User fonts — skip anything that collides with a bundled font.
         tmp_fonts = tmp_dir / _FONTS_REL

src/base_odds_manager.py

@@ -16,15 +16,8 @@ import time
 
 import requests
 import json
-from typing import Dict, Any, Optional, List, cast
+from typing import Dict, Any, Optional, List
 
-from src.common.api_helper import DEFAULT_HTTP_HEADERS
-
-
-
-def _is_no_odds_marker(data: Any) -> bool:
-    """Whether a cached odds entry is the "ESPN had none" marker, not odds."""
-    return isinstance(data, dict) and bool(data.get("no_odds"))
 
 class BaseOddsManager:
     """
@@ -52,15 +45,22 @@ class BaseOddsManager:
         self.logger = logging.getLogger(__name__)
         self.base_url = "https://sports.core.api.espn.com/v2/sports"
 
-        # Core's shared headers: ESPN rejects requests' default User-Agent
-        # (see api_helper.USER_AGENT), and a rejected odds request costs the
-        # calling plugin its update budget.
+        # This path used a bare requests.get, so it identified itself as
+        # python-requests/x.y -- the one thing ESPN is known to reject. Around
+        # 2026-08-04 it began 403ing browser strings and bare custom tokens
+        # alike; what it accepts is a token with a URL that says who is
+        # calling. Every other ESPN caller in the tree already sends this
+        # (src/common/api_helper.py); the odds path was simply missed, and it is the one whose failures cost
+        # the caller its whole update budget.
         #
         # Deliberately no retry adapter, unlike api_helper: retries multiply
         # request_timeout, which is set to 5s precisely to stay inside that
         # budget. One try, then the cooldown below.
         self.session = requests.Session()
-        self.session.headers.update(DEFAULT_HTTP_HEADERS)
+        self.session.headers.update({
+            'User-Agent': 'LEDMatrix/1.0 (+https://github.com/ChuckBuilds/LEDMatrix)',
+            'Accept': 'application/json',
+        })
         
         # Configuration with defaults
         self.update_interval = 3600  # 1 hour default
@@ -72,6 +72,7 @@ class BaseOddsManager:
         self.request_timeout = 5
         # Set when a request fails; until then, skip the network entirely.
         self._skip_network_until = 0.0
+        self.cache_ttl = 1800       # 30 minutes default
         
         # Load configuration if available
         if config_manager:
@@ -88,10 +89,12 @@ class BaseOddsManager:
             
             self.update_interval = odds_config.get('update_interval', self.update_interval)
             self.request_timeout = odds_config.get('timeout', self.request_timeout)
-
+            self.cache_ttl = odds_config.get('cache_ttl', self.cache_ttl)
+            
             self.logger.debug(f"BaseOddsManager configuration loaded: "
                             f"update_interval={self.update_interval}s, "
-                            f"timeout={self.request_timeout}s")
+                            f"timeout={self.request_timeout}s, "
+                            f"cache_ttl={self.cache_ttl}s")
                             
         except Exception as e:
             self.logger.warning(f"Failed to load BaseOddsManager configuration: {e}")
@@ -105,7 +108,7 @@ class BaseOddsManager:
     _FAILURE_COOLDOWN = 60.0
 
     def get_odds(self, sport: str | None, league: str | None, event_id: str,
-                 update_interval_seconds: Optional[int] = None) -> Optional[Dict[str, Any]]:
+                 update_interval_seconds: int = None) -> Optional[Dict[str, Any]]:
         """
         Fetch odds data for a specific game.
         
@@ -126,20 +129,10 @@ class BaseOddsManager:
         cache_key = f"odds_espn_{sport}_{league}_{event_id}"
 
         # Check cache first
-        cached_data: Optional[Dict[str, Any]] = self.cache_manager.get_with_auto_strategy(cache_key)
+        cached_data = self.cache_manager.get_with_auto_strategy(cache_key)
 
-        # Per-game chatter, logged on every update of every game on the
-        # slate: debug, not the journal.
         if cached_data:
-            # A game ESPN had no odds for is cached as {"no_odds": True} so it
-            # isn't re-requested every update. That marker is a cache hit --
-            # its ttl decides when to ask again -- but it is not odds: returned
-            # as-is, a caller saw a truthy dict and treated the game as having
-            # odds. The plugins' bundled copies already did this.
-            if _is_no_odds_marker(cached_data):
-                self.logger.debug("Cached no-odds marker for %s", cache_key)
-                return None
-            self.logger.debug(f"Using cached odds from ESPN for {cache_key}")
+            self.logger.info(f"Using cached odds from ESPN for {cache_key}")
             return cached_data
 
         if time.monotonic() < self._skip_network_until:
@@ -152,7 +145,7 @@ class BaseOddsManager:
                 self._skip_network_until - time.monotonic())
             return None
 
-        self.logger.debug(f"Cache miss - fetching fresh odds from ESPN for {cache_key}")
+        self.logger.info(f"Cache miss - fetching fresh odds from ESPN for {cache_key}")
 
         try:
             # Map league names to ESPN API format
@@ -166,7 +159,7 @@ class BaseOddsManager:
             
             espn_league = league_mapping.get(league, league)
             url = f"{self.base_url}/{sport}/leagues/{espn_league}/events/{event_id}/competitions/{event_id}/odds"
-            self.logger.debug(f"Requesting odds from URL: {url}")
+            self.logger.info(f"Requesting odds from URL: {url}")
             
             response = self.session.get(url, timeout=self.request_timeout)
             response.raise_for_status()
@@ -178,33 +171,30 @@ class BaseOddsManager:
             
             odds_data = self._extract_espn_data(raw_data)
             if odds_data:
-                self.logger.debug(f"Successfully extracted odds data: {odds_data}")
+                self.logger.info(f"Successfully extracted odds data: {odds_data}")
+            else:
+                self.logger.debug("No odds data available for this game")
+            
+            if odds_data:
                 self.cache_manager.set(cache_key, odds_data, ttl=interval)
-                self.logger.debug(f"Saved odds data to cache for {cache_key} with TTL {interval}s")
+                self.logger.info(f"Saved odds data to cache for {cache_key} with TTL {interval}s")
             else:
                 self.logger.debug(f"No odds data available for {cache_key}")
-                # Cache the absence too, so the game is not re-requested
-                # on every update until the interval passes.
+                # Cache the fact that no odds are available to avoid repeated API calls
                 self.cache_manager.set(cache_key, {"no_odds": True}, ttl=interval)
             
             return odds_data
 
-        # Before RequestException: requests' JSONDecodeError subclasses it, so
-        # listed second this branch never ran and a bad body was reported as a
-        # failed fetch. It holds off like a failed fetch did, so only the
-        # message changes.
-        except (json.JSONDecodeError, requests.exceptions.JSONDecodeError):
-            self._skip_network_until = time.monotonic() + self._FAILURE_COOLDOWN
-            self.logger.error(f"Error decoding JSON response from ESPN API for {cache_key}.")
         except requests.exceptions.RequestException as e:
             self._skip_network_until = time.monotonic() + self._FAILURE_COOLDOWN
             self.logger.error(
                 "Error fetching odds from ESPN API for %s: %s. Holding off on odds "
                 "for %.0fs so a slate of games does not pay this timeout each.",
                 cache_key, e, self._FAILURE_COOLDOWN)
-
-        cached = self.cache_manager.get_with_auto_strategy(cache_key)
-        return None if _is_no_odds_marker(cached) else cast(Optional[Dict[str, Any]], cached)
+        except json.JSONDecodeError:
+            self.logger.error(f"Error decoding JSON response from ESPN API for {cache_key}.")
+        
+        return self.cache_manager.get_with_auto_strategy(cache_key)
 
     def _extract_espn_data(self, data: Dict[str, Any]) -> Optional[Dict[str, Any]]:
         """

src/cache/disk_cache.py

@@ -7,14 +7,13 @@ Handles persistent disk-based caching with atomic writes and error recovery.
 import json
 import math
 import os
-import re
 import stat
 import time
 import tempfile
 import logging
 import threading
 import zlib
-from typing import Dict, Any, Optional, Protocol, Tuple
+from typing import Dict, Any, Optional, Protocol
 from datetime import datetime
 
 from src.common.path_safety import safe_path_component
@@ -99,88 +98,6 @@ def _replace_nonfinite(obj: Any) -> Any:
 # deleted. Both halves are covered by test/test_cache_nonfinite_floats.py.
 
 
-#: Enough of a record to hold its header: ``{"timestamp":<float>,"ttl":<n>,``.
-_HEAD_BYTES = 256
-
-#: A record written with its header first (CacheManager.set does). Anything
-#: else -- older files with "data" first, records from other writers -- does not
-#: match and is parsed in full, as before.
-_HEAD_RE = re.compile(
-    rb'\A\s*\{\s*"timestamp"\s*:\s*(-?[0-9][0-9.eE+-]*)\s*'
-    rb'(?:,\s*"ttl"\s*:\s*(-?[0-9][0-9.eE+-]*))?\s*[,}]'
-)
-
-
-def _head_timestamp(head: bytes) -> Optional[Tuple[float, int]]:
-    """A header-first record's timestamp and the offset just past it.
-
-    None when the record does not start with a finite numeric timestamp.
-    """
-    match = _HEAD_RE.match(head)
-    if not match:
-        return None
-    try:
-        timestamp = float(match.group(1))
-    except ValueError:
-        return None
-    if not math.isfinite(timestamp):
-        return None
-    return timestamp, match.end(1)
-
-
-# FRESHNESS OF A SKIPPED WRITE
-# ----------------------------
-# CacheManager.set stamps every record with time.time(), so re-saving
-# unchanged data produced a different payload every time and DiskCache.set's
-# identical-payload skip never fired: every plugin rewrote its unchanged API
-# data to the SD card every update cycle. set() now compares header-first
-# records without their timestamp, and on a skip moves the file's mtime to
-# the timestamp the skipped record carried instead of rewriting it. So the
-# file's mtime is when its content was last saved, and a header-first
-# record is as fresh as the later of its embedded timestamp and its mtime.
-#
-# A real write sets the mtime to the embedded timestamp too, so mtime is
-# never later than the timestamp for a record written with an old one on
-# purpose -- only a skip can move it forward.
-
-
-def _refreshed_at(timestamp: float, mtime: float) -> float:
-    """When a header-first record was last saved, embedded time or mtime.
-
-    An mtime within a second of the timestamp is the write that carried it
-    (float rounding, or an older file whose mtime was not set to match),
-    not a skipped rewrite, and leaves the record as written.
-    """
-    return mtime if mtime > timestamp + 1.0 else timestamp
-
-
-def _stale_from_head(head: bytes, max_age: Optional[int], now: float,
-                     refreshed: Optional[float] = None) -> bool:
-    """True when a record's header alone shows it has expired.
-
-    Mirrors the expiry rule in DiskCache.get: a per-entry ttl wins over the
-    caller's max_age, and no limit at all means never stale. False whenever the
-    header cannot be read, so the full parse decides as it always did.
-    ``refreshed`` is the file's mtime: a skipped rewrite advances it rather
-    than the embedded timestamp (see "FRESHNESS OF A SKIPPED WRITE").
-    """
-    match = _HEAD_RE.match(head)
-    if not match:
-        return False
-    try:
-        timestamp = float(match.group(1))
-        if refreshed is not None:
-            timestamp = max(timestamp, refreshed)
-        limit = max_age
-        if match.group(2) is not None:
-            ttl = float(match.group(2))
-            if ttl >= 0:
-                limit = ttl
-    except ValueError:
-        return False
-    return limit is not None and (now - timestamp) > limit
-
-
 if orjson is not None:
     # Encoding the cache record dominated the background fetch worker: on a
     # Pi 4, stdlib json.dumps runs ~12ms per MB and holds the GIL for all of
@@ -296,13 +213,11 @@ class DiskCache:
         self.cache_dir = cache_dir
         self.logger = logger or logging.getLogger(__name__)
         self._lock = threading.Lock()
-        # key -> ((length, adler32) of the last content written to the
-        # primary cache path, (st_ino, st_size) of the file it left); lets
-        # set() skip rewriting identical data. The file identity catches
-        # another process -- the web interface writes and clears keys too --
-        # having replaced the file since, which would otherwise make the skip
-        # a missed write. Per-process only. Guarded by _lock.
-        self._write_digests: Dict[str, Tuple[Tuple[int, int], Tuple[int, int]]] = {}
+        # key -> adler32 of the last payload successfully written to the
+        # primary cache path; lets set() skip rewriting identical data
+        # (per-process only — worst case another process rewrites, never
+        # a missed write). Guarded by _lock.
+        self._write_digests: Dict[str, int] = {}
     
     def get_cache_path(self, key: str) -> Optional[str]:
         """
@@ -351,30 +266,12 @@ class DiskCache:
         try:
             with self._lock:
                 with open(cache_path, 'rb') as f:
-                    # Decide staleness from the header before paying for the
-                    # parse. A stale read is the common case for the biggest
-                    # records (a season schedule is re-fetched when its cache
-                    # expires), and parsing 53MB to throw it away held the GIL
-                    # for ~1.8s -- a visible freeze on the panel.
-                    head = f.read(_HEAD_BYTES)
-                    stamp = _head_timestamp(head)
-                    fresh_at = None
-                    if stamp is not None:
-                        fresh_at = _refreshed_at(stamp[0], os.fstat(f.fileno()).st_mtime)
-                    if _stale_from_head(head, max_age, time.time(), fresh_at):
-                        return None
-                    f.seek(0)
                     record = _loads(f.read())
             
             # Determine record timestamp (prefer embedded, else file mtime)
             record_ts = None
             if isinstance(record, dict):
                 record_ts = record.get('timestamp')
-                if fresh_at is not None and fresh_at > stamp[0]:
-                    # A skipped rewrite refreshed this record (see "FRESHNESS
-                    # OF A SKIPPED WRITE"); hand callers the time it was last
-                    # saved, as the rewrite would have.
-                    record['timestamp'] = record_ts = fresh_at
             if record_ts is None:
                 try:
                     record_ts = os.path.getmtime(cache_path)
@@ -463,37 +360,24 @@ class DiskCache:
             self.logger.warning("Cache data for key '%s' not serializable: %s", key, e)
             return
 
-        # A header-first record is compared without its timestamp, which
-        # CacheManager.set changes on every call (see "FRESHNESS OF A SKIPPED
-        # WRITE"). The length rides along with adler32, which is weak on its
-        # own for short payloads, and a collision here is a missed write.
-        stamp = _head_timestamp(payload[:_HEAD_BYTES])
-        stamped_at = stamp[0] if stamp is not None else None
-        content = memoryview(payload)[stamp[1]:] if stamp is not None else payload
-        digest = (len(content), zlib.adler32(content))
+        digest = zlib.adler32(payload)
 
         try:
             # Atomic write to avoid partial/corrupt files
             with self._lock:
-                # Skip the disk entirely when this content was already
+                # Skip the disk entirely when this exact payload was already
                 # written for this key (plugins re-save unchanged API data
                 # every update cycle — each write is real SD-card wear).
-                # Move the file mtime instead, so the record stays as fresh as
-                # the rewrite would have left it; a metadata touch is
-                # journal-cheap compared to rewriting the data.
-                known = self._write_digests.get(key)
-                if known is not None and known[0] == digest:
+                # Refresh the file mtime so records that rely on it for TTL
+                # (no embedded 'timestamp') don't expire early; a metadata
+                # touch is journal-cheap compared to rewriting the data.
+                if self._write_digests.get(key) == digest:
                     try:
-                        st = os.stat(cache_path)
-                        if (st.st_ino, st.st_size) == known[1]:
-                            os.utime(cache_path, None if stamped_at is None
-                                     else (stamped_at, stamped_at))
-                            return
+                        os.utime(cache_path, None)
+                        return
                     except OSError:
-                        pass
-                    # File vanished, was replaced by another process, or its
-                    # times cannot be set — fall through and write
-                    self._write_digests.pop(key, None)
+                        # File vanished or perms changed — fall through and write
+                        self._write_digests.pop(key, None)
 
                 tmp_dir = os.path.dirname(cache_path)
                 # Try to create temp file in cache directory first
@@ -531,7 +415,7 @@ class DiskCache:
                                 # opened it in between was refused.
                                 _share_open_file(tmp_file.fileno(), _shared_group(tmp_dir))
                             os.replace(tmp_path, cache_path)
-                            self._remember_write(key, cache_path, digest, stamped_at)
+                            self._write_digests[key] = digest
                         finally:
                             if os.path.exists(tmp_path):
                                 try:
@@ -544,7 +428,7 @@ class DiskCache:
                             with open(cache_path, 'wb') as cache_file:
                                 cache_file.write(payload)
                                 _share_open_file(cache_file.fileno(), _shared_group(tmp_dir))
-                            self._remember_write(key, cache_path, digest, stamped_at)
+                            self._write_digests[key] = digest
                             self.logger.debug("Wrote cache for %s directly (non-atomic)", key)
                         except (IOError, OSError, PermissionError) as write_error:
                             # If direct write also fails, try fallback location
@@ -593,26 +477,6 @@ class DiskCache:
             )
             return  # Exit gracefully without raising exception
     
-    def _remember_write(self, key: str, cache_path: str,
-                        digest: Tuple[int, int], stamped_at: Optional[float]) -> None:
-        """Record a completed write so an identical set() can skip the disk.
-
-        Caller holds _lock. A header-first record's mtime is set to its
-        timestamp, so only a skipped rewrite ever moves it later (see
-        "FRESHNESS OF A SKIPPED WRITE").
-        """
-        try:
-            if stamped_at is not None:
-                os.utime(cache_path, (stamped_at, stamped_at))
-            st = os.stat(cache_path)
-        except OSError:
-            # Written but not stamped (another user's file, on the direct
-            # write path): mtime is the write time, which _refreshed_at reads
-            # as the write itself. Remember nothing; the next set() writes.
-            self._write_digests.pop(key, None)
-            return
-        self._write_digests[key] = (digest, (st.st_ino, st.st_size))
-
     def clear(self, key: Optional[str] = None) -> None:
         """
         Clear cache entry or all entries.

src/cache/memory_cache.py

@@ -8,7 +8,7 @@ import os
 import time
 import threading
 import logging
-from typing import Dict, Any, Optional, Union
+from typing import Dict, Any, Optional
 
 # Historical fixed ceiling, kept as the fallback when RAM cannot be read.
 DEFAULT_MAX_SIZE = 1000
@@ -70,15 +70,13 @@ class MemoryCache:
         """
         self.logger = logging.getLogger(__name__)
         self._cache: Dict[str, Dict[str, Any]] = {}
-        # Values are time.time() floats; get()/cleanup also accept a numeric
-        # string, as a timestamp may have been restored from serialized data.
-        self._timestamps: Dict[str, Union[float, str]] = {}
+        self._timestamps: Dict[str, float] = {}
         self._lock = threading.Lock()
         self._max_size = max_size
         self._cleanup_interval = cleanup_interval
         self._last_cleanup = time.time()
     
-    def get(self, key: str, max_age: Optional[float] = None) -> Optional[Dict[str, Any]]:
+    def get(self, key: str, max_age: Optional[int] = None) -> Optional[Dict[str, Any]]:
         """
         Get value from memory cache.
         
@@ -202,7 +200,6 @@ class MemoryCache:
             max_age_for_cleanup = 3600  # 1 hour
             
             expired_keys = []
-            timestamp: Optional[Union[float, str]]
             for key, timestamp in list(self._timestamps.items()):
                 if isinstance(timestamp, str):
                     try:

src/cache_manager.py

@@ -32,6 +32,7 @@ from typing import Any, Dict, List, Optional
 import logging
 import threading
 import tempfile
+from src.exceptions import CacheError
 from src.cache.memory_cache import MemoryCache, default_max_size
 from src.cache.disk_cache import DiskCache
 from src.cache.cache_strategy import CacheStrategy
@@ -271,9 +272,12 @@ class CacheManager:
         # Update memory cache first
         self._memory_cache_component.set(key, data)
         
-        # DiskCache logs a failed write and raises CacheError, which the
-        # caller gets as is.
-        self._disk_cache_component.set(key, data)
+        # Save to disk cache
+        try:
+            self._disk_cache_component.set(key, data)
+        except CacheError:
+            # Disk cache errors are already logged and raised by DiskCache
+            raise
 
     def load_cache(self, key: str) -> Optional[Dict[str, Any]]:
         """Load data from cache with memory caching."""
@@ -518,9 +522,8 @@ class CacheManager:
     def update_cache(self, data_type: str, data: Dict[str, Any]) -> bool:
         """Update cache with new data."""
         cache_data = {
-            # Header first; see DiskCache's stale check.
-            'timestamp': time.time(),
             'data': data,
+            'timestamp': time.time()
         }
         return self.save_cache(data_type, cache_data)
 
@@ -553,15 +556,12 @@ class CacheManager:
                  from the key and is only a fallback for entries that did not
                  say. Omit it to keep that inferred behaviour.
         """
-        # timestamp and ttl before data, so they are the first bytes on disk:
-        # DiskCache.get reads them from the head of the file and can call a
-        # record stale without parsing it. That matters for the big ones -- a
-        # whole MLB season is 53MB and ~1.8s of orjson.loads with the GIL held,
-        # paid in full only to learn the record had expired.
-        cache_data: Dict[str, Any] = {'timestamp': time.time()}
+        cache_data = {
+            'data': data,
+            'timestamp': time.time()
+        }
         if ttl is not None:
             cache_data['ttl'] = ttl
-        cache_data['data'] = data
         self.save_cache(key, cache_data)
 
     @deprecated("3.7.0")

src/common/README.md

@@ -1,326 +1,53 @@
-# src/common
+# Common Utilities
 
-Helpers shared by core and plugins. This page lists every module, what it is
-for, and whether plugins are expected to import it.
+This directory contains reusable utilities and helpers for LEDMatrix plugins and core modules.
 
-Rules for the package:
+## Adaptive Layout & Images (`src/adaptive_layout.py`, `src/adaptive_images.py`)
 
-- Every module must import without display hardware: nothing here may import
-  `src.display_manager` or `src.plugin_system` at module level
-  ([`test/test_common_is_hardware_free.py`](../../test/test_common_is_hardware_free.py)).
-  That keeps plugins that use it loadable by the web preview,
-  `scripts/check_plugin.py` and tests on a laptop.
-- A plugin that imports a module added in a given core release must declare
-  that release as its minimum (`ledmatrix_min_version` in the manifest's
-  `versions` entry). The "Since" column gives the release; "—" means it
-  predates 3.1.0, "n/a" that plugins should not import it.
-- `from src.common import ...` re-exports `APIHelper`, `ScrollHelper`,
-  `LogoHelper`, `TextHelper`, `scroll_config` (plus `ScrollSettings`,
-  `configure_scroll`, `resolve_scroll_settings`, `refresh_hz_from_config`) and
-  the adaptive layout names below ([`__init__.py`](__init__.py)).
-
-## Summary
-
-| Module | For | Plugins import it? | Since |
-|---|---|---|---|
-| [`api_helper`](#api_helper) | HTTP GET/POST with caching and rate limiting | Yes | — |
-| [`bdf_font`](#bdf_font) | Load and draw BDF bitmap fonts | Yes, if drawing BDF text directly | 3.5.0 |
-| [`espn_dates`](#espn_dates) | Fetch ESPN scoreboards across a date range | Yes (scoreboards) | 3.5.0 |
-| [`favorite_team_check`](#favorite_team_check) | Log why a favourite team code shows nothing | Yes (scoreboards) | 3.6.0 |
-| [`font_layout`](#font_layout) | Reproducible TrueType loading, crisp sizes | Yes | 3.4.0 |
-| [`frame_timing`](#frame_timing) | Timing of every presented frame, stall watchdog | No, core-internal | n/a |
-| [`json_body`](#json_body) | Parse a response body as JSON, with orjson if installed | Optional (large payloads) | 3.5.0 |
-| [`logo_helper`](#logo_helper) | Load, resize and cache team logos | Yes | — |
-| [`path_safety`](#path_safety) | Turn request-supplied names into safe paths | No, core-internal | n/a |
-| [`permission_utils`](#permission_utils) | File modes and shared-group ownership | Rarely | — |
-| [`render_gate`](#render_gate) | Keep background Python off the GIL while the panel swaps | No, core-internal | n/a |
-| [`scroll_config`](#scroll_config) | Plugin scroll config → configured `ScrollHelper` | Yes (scrollers) | 3.4.0 |
-| [`scroll_helper`](#scroll_helper) | Pre-rendered horizontal scrolling | Yes | — |
-| [`snapshot_policy`](#snapshot_policy) | When to write the web preview frame | No, core-internal | n/a |
-| [`sports_card`](#sports_card) | Scoreboard card settings, colours, fonts, dates | Yes (scoreboards) | 3.3.0 |
-| [`sports_card_wrappers`](#sports_card_wrappers) | The game renderer's `sports_card` delegations | Yes (scoreboards) | 3.7.0 |
-| [`sports_celebration`](#sports_celebration) | Draw a scoreboard's score/win celebration | Yes (scoreboards) | 3.7.0 |
-| [`sports_fetch`](#sports_fetch) | Scoreboard season fetch, lookback and live-odds decisions | Yes (scoreboards) | 3.7.0 |
-| [`sports_game_renderer`](#sports_game_renderer) | Scoreboard scroll/Vegas card geometry | Yes (scoreboards) | 3.3.0 |
-| [`sports_helpers`](#sports_helpers) | Small helpers every scoreboard `sports.py` copies | Yes (scoreboards) | 3.5.0 |
-| [`sports_scroll`](#sports_scroll) | Scoreboard scroll-display orchestration | Yes (scoreboards) | 3.2.0 |
-| [`sports_shared`](#sports_shared) | Sport-independent `sports.py` methods | Yes (scoreboards) | 3.3.0 |
-| [`sports_timezone`](#sports_timezone) | Which timezone a scoreboard draws start times in | Yes (scoreboards) | 3.6.0 |
-| [`sync_manager`](#sync_manager) | Leader/follower sync between two displays | No, core-internal | n/a |
-| [`text_helper`](#text_helper) | Outlined text, wrapping, measurement | Yes | — |
-
-The `sports_*` mixin and card modules hold code the scoreboard plugins
-used to carry as identical copies. Each module docstring lists what a host
-class must provide. The plan behind them is in
-[docs/SPORTS_UNIFICATION.md](../../docs/SPORTS_UNIFICATION.md).
-
-## Adaptive layout and images
-
-`src/adaptive_layout.py` and `src/adaptive_images.py` live outside this
-package but are re-exported from `src.common`. They are the recommended way
-to lay out a plugin that renders legibly on any panel size. Every
-`BasePlugin` already has `self.layout`, `self.draw_fit()` and
-`self.draw_image()`:
+The recommended way to lay out plugins that render legibly on **any** panel
+size (64x32 through 256x128+) without hand-tuned coordinates. Re-exported
+from `src.common` for convenience; canonical import paths are
+`src.adaptive_layout` / `src.adaptive_images`.
 
 ```python
+# Every BasePlugin already has self.layout and the draw helpers:
 regs = scoreboard_regions(self.layout.bounds, ctx=self.layout)
 self.draw_image(away_logo, regs.away_slot, mode="fill_height",
                 crop_to_ink=True, cache_key=f"logo:{abbr}")
 self.draw_fit(score_text, regs.score_area)     # largest crisp font that fits
+self.draw_fit(status, regs.status_band)
 ```
 
-Key pieces: `Region`, the font ladders `LADDER_GRID` / `LADDER_ARCADE`,
-`LayoutContext` (`fit_text`, `fit_image`, `by_tier`, `px`), and
-`scoreboard_regions()` / `media_row()`. Guide:
-[docs/ADAPTIVE_LAYOUT.md](../../docs/ADAPTIVE_LAYOUT.md).
+Key pieces: `Region` (rect algebra: bands/columns/splits/offset),
+font ladders (`LADDER_GRID`, `LADDER_ARCADE` — discrete crisp sizes, never
+fractional scaling), `LayoutContext` (`fit_text`, `fit_image`, `by_tier`,
+`px`), and composite carvers `scoreboard_regions()` / `media_row()`.
+Full guide: [docs/ADAPTIVE_LAYOUT.md](../../docs/ADAPTIVE_LAYOUT.md).
 
-## Modules
+## API Helpers (`api_helper.py`)
 
-### api_helper
+Utilities for making HTTP requests and handling API responses.
 
-[`api_helper.py`](api_helper.py). `APIHelper(cache_manager=None, ...)`:
-`get()` and `post()` with retries, optional caching through the cache
-manager, and a minimum interval between requests (`set_rate_limit()`). Also has
-`fetch_espn_scoreboard()`, `fetch_espn_standings()` and
-`fetch_espn_rankings()`.
+## Logo Helpers (`logo_helper.py`)
 
-### bdf_font
+Utilities for loading and managing team logos.
 
-[`bdf_font.py`](bdf_font.py). The one BDF loader and rasterizer.
-`load_bdf_face(path, size)` returns `(face, realised_px)`, falling back to
-the file's native strike when it has none at `size`;
-`draw_bdf_text(draw, text, x, y, face, color)` draws top-left anchored onto a
-PIL `ImageDraw` the same way the panel does. `read_bdf_native_size(path)`
-and `clear_face_cache()` round it out. Faces are cached per thread (FreeType
-faces are not thread-safe). `DisplayManager`, `FontManager`, `element_style`
-and the plugin test harness all use it. Most plugins get BDF text through
-`display_manager.draw_text()` or `FontManager` and never import this.
+## Text Helpers (`text_helper.py`)
 
-### espn_dates
+Utilities for text processing and formatting.
 
-[`espn_dates.py`](espn_dates.py). ESPN's site API rejects `dates=` ranges
-and truncates results when `limit` is above 500. `fetch_espn_scoreboard()`
-splits a range into month and day requests ESPN accepts and merges the
-results; `espn_date_chunks()`, `fetch_espn_date_chunks()`,
-`clamp_espn_limit()` and `merge_scoreboard_payloads()` are the pieces.
-Scoreboard plugins also bundle a copy for older cores.
+## Scroll Helpers (`scroll_helper.py`)
 
-### favorite_team_check
+Utilities for scrolling text on the display.
 
-[`favorite_team_check.py`](favorite_team_check.py).
-`FavoriteTeamCheck(logger, leagues)`, where `leagues` maps a league key to
-`(display name, ESPN sport/league path)`. `schedule(league_key, favorites)`
-checks the configured favourite team codes against ESPN's team list once per
-league, on a daemon thread, and logs a bad code with the nearest real one, or
-says the league has nothing on yet; `reset()` re-arms it after a config edit.
-Diagnostics only: every failure is swallowed. Scoreboard plugins also bundle
-a copy for older cores.
+## Permission Utilities (`permission_utils.py`)
 
-### font_layout
+Helpers for ensuring directory permissions and ownership are correct
+when running as a service (used by `CacheManager` to set up its
+persistent cache directory).
 
-[`font_layout.py`](font_layout.py). `load_truetype(path, size)` is
-`ImageFont.truetype` with PIL's Basic layout engine pinned, so text lays out
-the same whether or not the host Pillow has libraqm; use it for anything
-drawn to the panel or compared against a golden image. `crisp_size()` gives
-the size a bundled face renders on whole pixels at. `resolve_asset_path()`
-resolves `assets/fonts/...` against the install root rather than the
-working directory.
+## Best Practices
 
-### frame_timing
-
-[`frame_timing.py`](frame_timing.py). Core-internal. `DisplayManager`
-records every presented frame in a `FrameTimingRecorder`, which writes
-cumulative late-frame counters and histograms to `/dev/shm` for
-`scripts/frame_soak.py` and `scripts/render_bench.py`. `StallWatchdog` logs
-the stack of whatever holds up a scroll. See
-[docs/SCROLL_PERFORMANCE.md](../../docs/SCROLL_PERFORMANCE.md).
-
-### json_body
-
-[`json_body.py`](json_body.py). `response_json(response)` is
-`response.json()` parsed by orjson when it is installed, falling back to the
-stdlib parser (and requests' own error) otherwise. For multi-MB payloads such
-as a season schedule, where the parse holds the GIL and freezes the display.
-A plugin that also runs on older cores should guard the import, as
-`espn_dates` does.
-
-### logo_helper
-
-[`logo_helper.py`](logo_helper.py). `LogoHelper(display_width,
-display_height, ...)`: `load_logo()`, `load_logo_with_download()`,
-`get_logo_variations()`, `normalize_abbreviation()`, with an in-memory cache.
-
-### path_safety
-
-[`path_safety.py`](path_safety.py). Core-internal, used by web handlers that
-open files named in a request. `safe_path_component(value)` returns the
-value if it is one harmless path segment, else `None`;
-`resolve_under(base, *parts)` returns the resolved path, or `None` if a part
-is unsafe or the result would leave `base`; `safe_relative_parts()` splits a
-relative path the same way. Both return the sanitised value rather than a
-boolean, so a caller cannot check one string and open another.
-
-### permission_utils
-
-[`permission_utils.py`](permission_utils.py). The modes and ownership that
-let the root display service and the web user share files:
-`ensure_directory_permissions()`, `ensure_file_permissions()`, the
-`get_*_mode()` functions, `ensure_shared_group_ownership()`,
-`sudo_remove_directory()` and `install_requirements_file()` (the sudo
-`safe_pip_install.sh` path). `ConfigManager`, `CacheManager` and the store
-already call these; a plugin needs them only when it creates its own files
-outside the cache. See [docs/PERMISSIONS.md](../../docs/PERMISSIONS.md).
-
-### render_gate
-
-[`render_gate.py`](render_gate.py). Core-internal. `RenderGate` is opened by
-the render thread around each vsync swap; a background thread inside
-`gate.yielding()` (Vegas's prefetch) parks while the gate is closed, so the
-render thread finds the GIL free when its refresh arrives. It never parks a
-thread holding a guarded lock or inside logging, threading or import code.
-
-### scroll_config
-
-[`scroll_config.py`](scroll_config.py). `configure(scroll_helper,
-plugin_config=, global_config=, display_manager=, plugin_logger=)` reads a
-plugin's scroll settings, snaps the speed to a whole number of pixels per
-panel refresh, puts the helper in fixed-step mode and returns
-`ScrollSettings`. Pass `settings.frame_hold` to
-`display_manager.set_scrolling_state(True, frame_hold=...)` or the scroll
-runs too fast. `resolve()` does the calculation without touching a helper.
-See [docs/SCROLL_PERFORMANCE.md](../../docs/SCROLL_PERFORMANCE.md).
-
-### scroll_helper
-
-[`scroll_helper.py`](scroll_helper.py). `ScrollHelper(display_width,
-display_height, logger=None)`: build a wide image once
-(`create_scrolling_image()` or `set_scrolling_image()`), then per frame
-`update_scroll_position()` and `get_visible_portion()`;
-`is_scroll_complete()`, `calculate_dynamic_duration()` and
-`get_dynamic_duration()` for timing. Configure it with `scroll_config`
-rather than the `set_*` methods. Vegas mode reads a plugin's
-`scroll_helper` image when the plugin has no `get_vegas_content()`.
-
-### snapshot_policy
-
-[`snapshot_policy.py`](snapshot_policy.py). Core-internal. `decide()`
-tells `DisplayManager` whether to write `/tmp/led_matrix_preview.png`, only
-touch its mtime, or skip, based on whether a browser is watching the preview.
-The web health check reads the file's age.
-
-### sports_card
-
-[`sports_card.py`](sports_card.py). Free functions taking `config`, `fonts`
-and `logger` explicitly: card options (`scroll_card_option()`,
-`vs_text()`, `upcoming_center_mode()`), colours (`element_color()`,
-`font_color()`, `score_color_for()`, `recent_score_color()`), favourite-team
-rules (`favorite_teams_for()`, `side_is_favorite()`, `favorite_result()`),
-dates (`format_game_date()`, `format_game_time()`, `card_tzinfo()`) and font
-sizes (`schema_font_size()`, `resolve_font_size()`). A plugin keeps its own
-method and delegates the body.
-
-### sports_card_wrappers
-
-[`sports_card_wrappers.py`](sports_card_wrappers.py).
-`SportsCardWrappersMixin`: the one-line methods a scoreboard's game renderer
-uses to call `sports_card` with its own `config` and `logger`
-(`_vs_text()`, `_element_color()`, `_format_game_date()`, ... seventeen in
-all), under their existing names. They are what `sports_game_renderer`'s
-mixin expects its host to provide. No `__init__` and no state.
-
-### sports_celebration
-
-[`sports_celebration.py`](sports_celebration.py). `SportsCelebrationMixin`
-draws the full-screen takeover a scoreboard shows when a team scores or wins
-(`_draw_celebration_layout(celebration)`): a backdrop in the scoring team's
-colours read off its crest, scenery, confetti, the headline and the score.
-The colour helpers are free functions (`logo_palette()`, `lift_color()`,
-`mix_color()`, ...). Deciding *when* to celebrate stays in the plugin, which
-builds the celebration dict the docstring describes.
-
-### sports_fetch
-
-[`sports_fetch.py`](sports_fetch.py). `SportsFetchMixin`: the `SportsCore`
-methods that decide which requests a scoreboard makes --
-`_fetch_season_directly()` (a season, in chunks ESPN accepts),
-`_background_fetches_espn_ranges()`, `_needs_previous_day()` (the live
-lookback) and `_wants_live_odds()` (odds only for games near the screen).
-
-### sports_game_renderer
-
-[`sports_game_renderer.py`](sports_game_renderer.py).
-`SportsGameRendererMixin`: the scroll/Vegas card geometry (centre gap, logo
-slot, layout offsets, upcoming-card date and time). No `__init__` and no
-state; add it as a base class of the plugin's game renderer and override
-what differs.
-
-### sports_helpers
-
-[`sports_helpers.py`](sports_helpers.py). Free functions `clamp_window()`,
-`clamp_seconds()`, `logo_needs_refresh()`, `spread_weighted_order()`, and
-`SportsHelpersMixin` with the scoreboards' `_mode_customization`,
-`_setting_int`, `_reset_dwell_on_reentry`, `_next_switch_index`,
-`_odds_color` and `_upcoming_date_and_time_text` under their existing names.
-Nothing in core uses it.
-
-### sports_scroll
-
-[`sports_scroll.py`](sports_scroll.py). `SportsScrollDisplay` and
-`SportsScrollDisplayManager`: the scroll-display orchestration the
-scoreboards share (Vegas items, dynamic duration, frame loop), paced through
-`scroll_config`. Subclasses supply `prepare_scroll_content()` and set
-`SCROLL_LEAGUE_KEYS`; see the module docstring for an example.
-
-### sports_shared
-
-[`sports_shared.py`](sports_shared.py). `SportsCoreSharedMixin`,
-`SportsLiveSharedMixin`, `SportsRecentSharedMixin`: the `sports.py` methods
-that were identical in every scoreboard (game selection and rotation,
-fonts, colours, dates, the switch-mode upcoming card). The docstring lists
-the attributes the host class must have and the three methods deliberately
-left out.
-
-### sports_timezone
-
-[`sports_timezone.py`](sports_timezone.py).
-`resolve_timezone_name(config, plugin_manager, cache_manager, log, *,
-plugin_label, writeback_fixed_in=None)` and `resolve_timezone(...)` (the same
-as a pytz zone): the plugin's own `timezone`, then the global one via either
-manager's `config_manager`, then the host's zone (`system_timezone_name()`),
-then UTC. `plugin_label` names the plugin in the warning logged when nothing
-resolves; `writeback_fixed_in` is for a plugin that once wrote `"UTC"` into
-the saved config (a bare plugin-level `"UTC"` is then ignored when another
-source disagrees). Scoreboard plugins also bundle a copy for older cores.
-
-### sync_manager
-
-[`sync_manager.py`](sync_manager.py). Core-internal. `DisplaySyncManager`
-links two displays as leader and follower (`sync.role` in config) over UDP
-port 5765, plus TCP on the next port for scroll images. The leader drives the
-scroll and sends the follower its part of each frame; a follower falls back
-to its own plugins when the leader goes quiet. Rows and columns must match.
-Created by `DisplayController`; works with any plugin.
-
-### text_helper
-
-[`text_helper.py`](text_helper.py). `TextHelper(font_dir=None, ...)`:
-`load_fonts()`, `draw_text_with_outline()`, `get_text_width()`,
-`get_text_dimensions()`, `center_text()`, `wrap_text()`,
-`draw_multiline_text()`, `create_text_image()`.
-
-## Logging
-
-Modules here create their logger with `logging.getLogger(__name__)`, which is
-the same logger `src.logging_config.get_logger(__name__)` returns. The helper
-classes (`APIHelper`, `LogoHelper`, `ScrollHelper`, `TextHelper`) and
-`espn_dates` take an optional `logger`. In a plugin, pass `self.logger`: it is
-created by `get_logger(..., plugin_id=...)` in `BasePlugin`, so messages carry
-the plugin id.
-
-## Adding a module
-
-- Keep it importable without hardware (see the test above).
-- Give it a module docstring that says what it is for and, if it is a mixin,
-  what the host class must provide.
-- Add it to the table on this page and, if plugins may import it, to the
-  CHANGELOG with the release to floor on.
+1. **Use centralized logging**: Import from `src.logging_config` instead of creating loggers directly
+2. **Reuse utilities**: Check existing utilities before creating new ones
+3. **Document additions**: Add documentation when adding new utilities

src/common/api_helper.py

@@ -1,9 +1,8 @@
 """
 API Helper
 
-HTTP requests, response caching and ESPN fetch helpers for plugins
-(``from src.common import APIHelper``), plus the headers every core request
-sends (:data:`USER_AGENT`, :data:`DEFAULT_HTTP_HEADERS`).
+Handles HTTP requests, caching, and ESPN API integration for LED matrix plugins.
+Extracted from LEDMatrix core to provide reusable functionality for plugins.
 """
 
 import logging
@@ -11,16 +10,12 @@ import time
 from datetime import datetime
 from types import MappingProxyType
 from src.common.espn_dates import ESPN_MAX_LIMIT
-from typing import TYPE_CHECKING, Any, Dict, Mapping, Optional, cast
+from typing import Any, Dict, Mapping, Optional
 
 import requests
 from requests.adapters import HTTPAdapter
 from urllib3.util.retry import Retry
 
-if TYPE_CHECKING:
-    # What Session() puts in .headers; the stubs only promise a MutableMapping.
-    from requests.structures import CaseInsensitiveDict
-
 
 #: The User-Agent core sends to ESPN and other data APIs. It names the client
 #: and links to it: around 2026-08-04 ESPN began 403ing bare custom tokens
@@ -41,20 +36,13 @@ DEFAULT_HTTP_HEADERS: Mapping[str, str] = MappingProxyType({
 
 class APIHelper:
     """
-    HTTP requests with retries, response caching and ESPN helpers.
-
-    - Requests go through one ``requests.Session`` that retries GET, HEAD
-      and OPTIONS on 429 and 5xx with exponential backoff, and sends
-      :data:`DEFAULT_HTTP_HEADERS`.
-    - Consecutive requests from one helper are spaced at least
-      ``set_rate_limit()`` seconds apart (1 second by default). A cache hit
-      does not count.
-    - With a ``cache_manager``, :meth:`get` caches the parsed JSON under
-      ``cache_key`` for ``cache_ttl`` seconds. The lifetime is stored with
-      the entry, so CacheManager honours it on every later read, whatever
-      max_age that read asks for.
-    - Failed requests are logged and return None; nothing here raises for a
-      network or HTTP error.
+    Helper class for HTTP requests, caching, and ESPN API integration.
+    
+    Provides functionality for:
+    - HTTP requests with retry logic and timeouts
+    - Response caching with TTL support
+    - ESPN API integration for sports data
+    - Request rate limiting and throttling
     """
     
     def __init__(self, cache_manager=None, default_timeout: int = 30,
@@ -85,14 +73,16 @@ class APIHelper:
         self.session.mount("https://", adapter)
         self.session.mount("http://", adapter)
         
-        self.session.headers.update({**DEFAULT_HTTP_HEADERS, 'Connection': 'keep-alive'})
+        # Default headers
+        self.session.headers.update({
+            'User-Agent': USER_AGENT,
+            'Accept': 'application/json',
+            'Accept-Language': 'en-US,en;q=0.9',
+            'Connection': 'keep-alive'
+        })
         
         # Rate limiting
-        self._last_request_time: float = 0  # wall clock, reported by get_request_stats()
-        # The interval is measured on time.monotonic(): a wall-clock step
-        # back (NTP correcting a Pi with no RTC) made time_since_last
-        # negative and the "remaining interval" sleep as long as the step.
-        self._last_request_monotonic: Optional[float] = None
+        self._last_request_time = 0
         self._min_request_interval = 1.0  # Minimum seconds between requests
     
     def get(self, url: str, params: Optional[Dict] = None, 
@@ -112,18 +102,19 @@ class APIHelper:
         Returns:
             Response data as dictionary or None if request fails
         """
+        # Check cache first
         if cache_key and self.cache_manager:
-            cached = self._get_from_cache(cache_key, cache_ttl)
+            cached = self._get_from_cache(cache_key)
             if cached is not None:
                 self.logger.debug(f"Using cached response for {cache_key}")
-                return cast(Dict[Any, Any], cached)
+                return cached
         
         # Rate limiting
         self._enforce_rate_limit()
         
         try:
             # Prepare request
-            request_headers = cast('CaseInsensitiveDict[Any]', self.session.headers).copy()
+            request_headers = self.session.headers.copy()
             if headers:
                 request_headers.update(headers)
             
@@ -137,7 +128,7 @@ class APIHelper:
             response.raise_for_status()
             
             # Parse JSON response
-            data: Dict[Any, Any] = response.json()
+            data = response.json()
             
             # Cache response if cache key provided
             if cache_key and self.cache_manager:
@@ -251,7 +242,7 @@ class APIHelper:
         self._enforce_rate_limit()
         
         try:
-            request_headers = cast('CaseInsensitiveDict[Any]', self.session.headers).copy()
+            request_headers = self.session.headers.copy()
             if headers:
                 request_headers.update(headers)
             
@@ -264,7 +255,7 @@ class APIHelper:
             )
             response.raise_for_status()
             
-            return cast(Optional[Dict[Any, Any]], response.json())
+            return response.json()
             
         except requests.exceptions.RequestException as e:
             self.logger.error(f"POST request failed for {url}: {e}")
@@ -277,31 +268,33 @@ class APIHelper:
         Args:
             key: Cache key
             data: Data to cache
-            ttl: Seconds the entry stays valid. Stored with the entry, so
-                it applies to every later read of ``key``.
+            ttl: Time-to-live in seconds (ignored - CacheManager doesn't support TTL)
         """
-        self._set_cache(key, data, ttl)
+        if self.cache_manager:
+            self.cache_manager.set(key, data)
     
     def get_cache(self, key: str) -> Optional[Any]:
         """
         Get cached data.
-
+        
         Args:
             key: Cache key
-
+            
         Returns:
-            Cached data, or None if there is none or it has expired. An
-            entry written with a ttl (set_cache, get) expires after that ttl;
-            one written without expires after CacheManager's default max_age.
+            Cached data or None if not found
         """
-        return self._get_from_cache(key)
+        if self.cache_manager:
+            return self.cache_manager.get(key)
+        return None
     
     def clear_cache(self, pattern: Optional[str] = None) -> None:
         """
         Clear cache data.
 
-        Uses CacheManager's clear_cache(), or list_cache_files() and delete()
-        for a pattern. A cache manager without those methods is left alone.
+        Uses CacheManager's real surface (clear_cache / delete /
+        list_cache_files); safely no-ops on managers without it. The old
+        implementation guarded on a nonexistent ``clear`` method, so it
+        silently never cleared anything.
 
         Args:
             pattern: Optional substring to match cache keys; only matching
@@ -322,33 +315,31 @@ class APIHelper:
                     "cannot clear by pattern")
         elif hasattr(self.cache_manager, 'clear_cache'):
             self.cache_manager.clear_cache()
+        elif hasattr(self.cache_manager, 'clear'):
+            self.cache_manager.clear()
         else:
             self.logger.debug("Cache manager exposes no clear method; no-op")
     
-    def _get_from_cache(self, key: str, max_age: Optional[int] = None) -> Optional[Any]:
-        """Cached data for ``key``, or None. ``max_age`` only matters for an
-        entry stored without a ttl; one stored with a ttl uses that."""
-        if not self.cache_manager:
-            return None
-        if max_age is None:
-            return self.cache_manager.get(key)
-        return self.cache_manager.get(key, max_age=max_age)
-
-    def _set_cache(self, key: str, data: Any, ttl: Optional[int]) -> None:
-        """Store ``data`` under ``key`` for ``ttl`` seconds."""
+    def _get_from_cache(self, key: str) -> Optional[Any]:
+        """Get data from cache."""
         if self.cache_manager:
-            self.cache_manager.set(key, data, ttl=ttl)
+            return self.cache_manager.get(key)
+        return None
+    
+    def _set_cache(self, key: str, data: Any, ttl: int) -> None:
+        """Set data in cache."""
+        if self.cache_manager:
+            self.cache_manager.set(key, data)
     
     def _enforce_rate_limit(self) -> None:
         """Enforce rate limiting between requests."""
-        if self._last_request_monotonic is not None:
-            time_since_last = time.monotonic() - self._last_request_monotonic
-
-            if time_since_last < self._min_request_interval:
-                sleep_time = self._min_request_interval - time_since_last
-                time.sleep(sleep_time)
-
-        self._last_request_monotonic = time.monotonic()
+        current_time = time.time()
+        time_since_last = current_time - self._last_request_time
+        
+        if time_since_last < self._min_request_interval:
+            sleep_time = self._min_request_interval - time_since_last
+            time.sleep(sleep_time)
+        
         self._last_request_time = time.time()
     
     def set_rate_limit(self, min_interval: float) -> None:
@@ -371,8 +362,5 @@ class APIHelper:
         return {
             'min_request_interval': self._min_request_interval,
             'last_request_time': self._last_request_time,
-            'time_since_last_request': (
-                time.monotonic() - self._last_request_monotonic
-                if self._last_request_monotonic is not None
-                else time.time() - self._last_request_time),
+            'time_since_last_request': time.time() - self._last_request_time
         }

src/common/bdf_font.py

@@ -1,261 +0,0 @@
-"""Loading and drawing BDF bitmap fonts: one loader, one rasterizer.
-
-BDF fonts are fixed-size bitmap strikes. FreeType renders them at the size
-baked into the file and rejects any other size, and PIL cannot draw a
-``freetype.Face`` at all, so the core draws BDF text itself, glyph by glyph.
-
-This used to be done in several places that drifted apart:
-``FontManager``, ``element_style`` and ``DisplayManager`` each loaded faces
-their own way, and ``DisplayManager`` and the plugin test harness
-(``VisualTestDisplayManager``) each had a copy of the glyph drawing loop. The
-harness renders plugin golden images and ``check_plugin`` / ``dev_server``
-previews, so a copy that differs from the panel's shows something the panel
-never draws. Everything now goes through the two functions here:
-
-* :func:`load_bdf_face` -- a ``freetype.Face`` at the requested pixel size,
-  or at the file's native strike when the file has no strike at that size.
-* :func:`draw_bdf_text` -- draw a string in a ``freetype.Face`` onto a PIL
-  ``ImageDraw``, top-left anchored like ``ImageDraw.text``.
-
-Only PIL and freetype-py are imported, so the module is as cheap to import
-from the test harness as from core.
-"""
-
-from __future__ import annotations
-
-import ctypes
-import logging
-import os
-import threading
-from collections import OrderedDict
-from typing import Any, Optional, Sequence, Tuple
-
-from PIL import Image
-
-try:
-    import freetype
-except ImportError:  # pragma: no cover - freetype-py is a core requirement
-    freetype = None
-
-logger = logging.getLogger(__name__)
-
-__all__ = ["read_bdf_native_size", "load_bdf_face", "draw_bdf_text"]
-
-
-# --------------------------------------------------------------------------
-# Loading
-# --------------------------------------------------------------------------
-
-def read_bdf_native_size(bdf_path: str) -> Optional[int]:
-    """A BDF file's one true pixel size, read from its header, or None.
-
-    Prefers the PIXEL_SIZE property, which states the real pixel height
-    directly; falls back to the SIZE line's point-size only if PIXEL_SIZE is
-    absent, since point-size only equals pixel height at exactly 100dpi --
-    several bundled fonts (e.g. 6x13.bdf, 5x8.bdf) are defined at 75dpi, where
-    the two values genuinely differ. Stops at the first STARTCHAR.
-    """
-    size_line_value = None
-    try:
-        with open(bdf_path, "r", encoding="ascii", errors="ignore") as f:
-            for line in f:
-                if line.startswith("PIXEL_SIZE"):
-                    parts = line.split()
-                    if len(parts) >= 2:
-                        return int(float(parts[1]))
-                elif line.startswith("SIZE") and size_line_value is None:
-                    # Format: "SIZE <point_size> <xres> <yres>"
-                    parts = line.split()
-                    if len(parts) >= 2:
-                        size_line_value = int(float(parts[1]))
-                elif line.startswith("STARTCHAR"):
-                    break
-    except (OSError, ValueError):
-        return None
-    return size_line_value
-
-
-#: Loaded faces, keyed on (absolute path, requested size, mtime_ns, file size)
-#: so a font file replaced on disk under the same name is loaded afresh.
-#: Bounded LRU: the display process runs for weeks and every config save can
-#: introduce a new (font, size) pair, but a panel draws from a handful.
-_FACE_CACHE_MAX = 256
-_face_cache: "OrderedDict[tuple, Tuple[Any, int]]" = OrderedDict()
-_face_cache_lock = threading.Lock()
-
-
-def _face_at(path: str, size_px: int) -> Any:
-    face = freetype.Face(path)
-    # Character size in 1/64th points at 72dpi == pixel size.
-    face.set_char_size(size_px * 64, size_px * 64, 72, 72)
-    return face
-
-
-def load_bdf_face(path: str, size_px: int) -> Tuple[Any, int]:
-    """``(face, realised_px)`` for the BDF file at ``path``.
-
-    ``realised_px`` is ``size_px`` when the file has a strike at that size,
-    otherwise the file's native size: FreeType refuses any other size for a
-    bitmap font, and answering that with some other typeface (which both
-    ``FontManager`` and ``element_style`` once did) is worse than drawing the
-    font that was asked for at the size it can do. Callers that lay out by
-    size need ``realised_px``, not the size they asked for.
-
-    Faces are cached per thread. A ``freetype.Face`` holds per-glyph state
-    (``load_char`` rewrites its glyph slot), and FreeType does not allow two
-    threads to use one face at once, so the display thread and a plugin's
-    update thread must never be handed the same object. Within a thread the
-    face is shared by every caller. Raises if the file can't be loaded at
-    either size.
-    """
-    if freetype is None:
-        raise RuntimeError("freetype-py is not installed; BDF fonts need it")
-    size_px = int(size_px)
-    abs_path = os.path.abspath(path)
-    try:
-        st = os.stat(abs_path)
-        key = (threading.get_ident(), abs_path, size_px,
-               st.st_mtime_ns, st.st_size)
-    except OSError:
-        key = None  # let freetype raise its own error below
-
-    if key is not None:
-        with _face_cache_lock:
-            cached = _face_cache.get(key)
-            if cached is not None:
-                _face_cache.move_to_end(key)
-                return cached
-
-    try:
-        entry = (_face_at(abs_path, size_px), size_px)
-    except Exception:
-        native = read_bdf_native_size(abs_path)
-        if not native or native == size_px:
-            raise
-        # A fresh Face: the first one already took a failed set_char_size.
-        entry = (_face_at(abs_path, native), native)
-        logger.debug(
-            "BDF font %s requested at %spx renders at its native %spx "
-            "(the file has no strike at the requested size)",
-            abs_path, size_px, native,
-        )
-
-    if key is not None:
-        with _face_cache_lock:
-            _face_cache[key] = entry
-            _face_cache.move_to_end(key)
-            while len(_face_cache) > _FACE_CACHE_MAX:
-                _face_cache.popitem(last=False)
-    return entry
-
-
-def clear_face_cache() -> None:
-    """Drop every cached face (tests; a font directory swapped wholesale)."""
-    with _face_cache_lock:
-        _face_cache.clear()
-
-
-# --------------------------------------------------------------------------
-# Drawing
-# --------------------------------------------------------------------------
-
-def _bitmap_bytes(bitmap: Any, nbytes: int) -> bytes:
-    """The first ``nbytes`` of a glyph bitmap's buffer, zero-padded.
-
-    ``bitmap.buffer`` builds a Python list one byte at a time; reading the
-    underlying FT_Bitmap directly is the same bytes without that cost.
-    """
-    raw = getattr(bitmap, "_FT_Bitmap", None)
-    if raw is not None and raw.buffer:
-        return ctypes.string_at(raw.buffer, nbytes)
-    buf = bytes(bitmap.buffer[:nbytes])
-    if len(buf) < nbytes:
-        buf += bytes(nbytes - len(buf))
-    return buf
-
-
-def _glyph_points(bitmap: Any, left: int, top: int,
-                  clip_w: int, clip_h: int) -> list:
-    """Every lit pixel of a glyph, clipped, as ``(x, y)`` pairs.
-
-    The reference definition of which pixels a glyph lights: the MSB-first
-    bit ``j`` of byte ``i * pitch + j // 8``. Used only where the fast path
-    below can't express exactly the same thing.
-    """
-    buffer = bitmap.buffer
-    pitch = bitmap.pitch
-    points = []
-    for i in range(bitmap.rows):
-        for j in range(bitmap.width):
-            byte_index = i * pitch + (j // 8)
-            if byte_index < len(buffer) and buffer[byte_index] & (1 << (7 - (j % 8))):
-                px = left + j
-                py = top + i
-                if 0 <= px < clip_w and 0 <= py < clip_h:
-                    points.append((px, py))
-    return points
-
-
-def draw_bdf_text(draw: Any, text: str, x: int, y: int, face: Any,
-                  color: Any = (255, 255, 255),
-                  clip: Optional[Sequence[int]] = None) -> int:
-    """Draw ``text`` in a ``freetype.Face`` with ``draw``; return the pen x.
-
-    ``(x, y)`` is the top-left of the line, as for ``ImageDraw.text``: the
-    baseline is ``y`` plus the face's ascender. Each glyph's lit bits are set
-    to ``color`` exactly -- no blending, no anti-aliasing -- and pixels
-    outside ``[0, clip_w) x [0, clip_h)`` are skipped (``clip`` defaults to
-    the image size). The pen advances by each glyph's advance width.
-
-    Glyphs are drawn as 1-bit masks with ``ImageDraw.bitmap`` rather than a
-    point at a time, which is pixel-identical and far faster. A ``draw`` that
-    blends (``ImageDraw.Draw(rgb_image, "RGBA")``) is drawn point by point, so
-    a translucent colour still blends exactly as it always has.
-
-    Errors (a non-BDF ``face``, a bad colour) propagate after any glyphs
-    before the failing one are drawn; callers decide whether to log them.
-    """
-    try:
-        ascender_px = face.size.ascender >> 6
-    except Exception:
-        ascender_px = 0
-    baseline_y = y + ascender_px
-
-    if clip is None:
-        clip_w, clip_h = draw.im.size
-    else:
-        clip_w, clip_h = int(clip[0]), int(clip[1])
-    blending = draw.mode != draw.im.mode
-
-    for char in text:
-        face.load_char(char)
-        glyph = face.glyph
-        bitmap = glyph.bitmap
-        rows, width, pitch = bitmap.rows, bitmap.width, bitmap.pitch
-        left = x + glyph.bitmap_left
-        top = baseline_y - glyph.bitmap_top
-
-        if rows > 0 and width > 0:
-            if blending or pitch <= 0:
-                points = _glyph_points(bitmap, left, top, clip_w, clip_h)
-                if points:
-                    draw.point(points, fill=color)
-            else:
-                # The visible part of the glyph box, in glyph coordinates.
-                x0, y0 = max(0, -left), max(0, -top)
-                x1, y1 = min(width, clip_w - left), min(rows, clip_h - top)
-                if x0 < x1 and y0 < y1:
-                    # Raw mode "1" with stride=pitch reads exactly the bits
-                    # _glyph_points does, whatever the glyph's pixel mode.
-                    mask = Image.frombytes(
-                        "1", (width, rows), _bitmap_bytes(bitmap, rows * pitch),
-                        "raw", "1", pitch)
-                    if (x0, y0, x1, y1) != (0, 0, width, rows):
-                        mask = mask.crop((x0, y0, x1, y1))
-                    # An all-blank glyph draws nothing -- and, as before,
-                    # never touches the colour.
-                    if mask.getbbox() is not None:
-                        draw.bitmap((left + x0, top + y0), mask, fill=color)
-
-        x += glyph.advance.x >> 6
-    return x

src/common/espn_dates.py

@@ -37,15 +37,7 @@ import time
 from concurrent.futures import ThreadPoolExecutor
 from datetime import date, timedelta
 from functools import partial
-from typing import Any, Dict, List, Optional, Tuple, cast
-
-try:
-    from src.common.json_body import response_json
-except ImportError:
-    # Plugins bundle copies of this module for older cores, which predate
-    # json_body; the stdlib parse is what those cores always used.
-    def response_json(response: Any) -> Any:
-        return response.json()
+from typing import Any, Dict, List, Optional, Tuple
 
 # Above this, ESPN returns a truncated list instead of an error. See module
 # docstring: 500 is the largest value measured to return complete data.
@@ -159,7 +151,7 @@ def espn_date_chunks(start: date, end: date) -> List[str]:
     return chunks
 
 
-def merge_scoreboard_payloads(payloads: List[Any]) -> Dict[str, Any]:
+def merge_scoreboard_payloads(payloads: List[Dict[str, Any]]) -> Dict[str, Any]:
     """Fold chunk responses into one scoreboard payload.
 
     Events are de-duplicated by id and keep first-seen order. Non-event keys
@@ -202,7 +194,7 @@ def _fetch_one_chunk(
             timeout=timeout,
         )
         response.raise_for_status()
-        return cast(Optional[Dict[str, Any]], response_json(response))
+        return response.json()
     except Exception as exc:  # noqa: BLE001 - see docstring
         if logger:
             logger.warning("ESPN chunk %s failed, skipping it: %s", chunk, exc)
@@ -379,4 +371,4 @@ def fetch_espn_scoreboard(
         if data is not None:
             return data
     response.raise_for_status()
-    return cast(Dict[str, Any], response_json(response))
+    return response.json()

src/common/favorite_team_check.py

@@ -1,409 +0,0 @@
-"""
-Explain an empty screen: a wrong team code, or a season that has not started.
-
-Favourite teams are matched by exact ESPN abbreviation, so a plausible-looking
-code silently matches nothing and the plugin shows an empty screen with no hint
-that the code is at fault. The codes are not always guessable — ESPN calls
-Alabama ``ALA`` rather than ``BAMA``, and Golden State ``GS`` rather than
-``GSW``. Between seasons a perfectly correct code produces the same empty
-screen for a completely different reason, and the two were indistinguishable
-from the logs.
-
-This module is diagnostics only. It runs on a daemon thread, once per league per
-process, and every failure is swallowed: it must never delay a frame or change
-what is displayed.
-"""
-
-import difflib
-import logging
-import re
-import threading
-from datetime import datetime, timezone
-from typing import Dict, Iterable, List, Optional, Set, Tuple
-
-TEAMS_URL = "https://site.api.espn.com/apis/site/v2/sports/{path}/teams?limit=1000"
-SCOREBOARD_URL = "https://site.api.espn.com/apis/site/v2/sports/{path}/scoreboard"
-REQUEST_TIMEOUT = 15
-
-
-class FavoriteTeamCheck:
-    """
-    Validates configured favourite team codes against ESPN, and says so in the log.
-
-    ``leagues`` maps the plugin's own league key to a
-    ``(human readable name, ESPN sport/league path)`` pair, e.g.
-    ``{'nhl': ('NHL', 'hockey/nhl')}``.
-    """
-
-    # How far out the next fixture has to be before it is worth mentioning.
-    # An off day or two is normal mid-season and saying so would just be noise.
-    GAP_DAYS = 3
-
-    def __init__(self, logger: Optional[logging.Logger],
-                 leagues: Dict[str, Tuple[str, str]]) -> None:
-        self.logger = logger or logging.getLogger(__name__)
-        self.leagues = leagues
-        self._checked: Set[str] = set()
-        self._lock = threading.Lock()
-
-    def reset(self) -> None:
-        """Re-check on the next call, e.g. after the user edits the config."""
-        with self._lock:
-            self._checked.clear()
-
-    def schedule(self, league_key: str, favorites: Iterable[str]) -> None:
-        """Check one league in the background, at most once per process."""
-        try:
-            favorites = [str(f) for f in (favorites or []) if str(f).strip()]
-            if not favorites or league_key not in self.leagues:
-                return
-            with self._lock:
-                if league_key in self._checked:
-                    return
-                self._checked.add(league_key)
-            threading.Thread(
-                target=self._run, args=(league_key, favorites),
-                name="favorite-team-check", daemon=True,
-            ).start()
-        except Exception:
-            pass  # nosec B110 - a diagnostic must never be the reason an update fails  # nosemgrep
-
-    def _run(self, league_key: str, favorites) -> None:
-        try:
-            self._check(league_key, favorites)
-        except Exception as exc:
-            self.logger.debug("Favorite team check failed for %s: %s",
-                              league_key, exc)
-
-    def _check(self, league_key: str, favorites) -> None:
-        name, path = self.leagues[league_key]
-
-        try:
-            teams = self._fetch_teams(path)
-        except Exception as exc:
-            self.logger.debug("Could not verify %s favorite teams: %s", name, exc)
-            return
-        if not teams:
-            # Some ESPN endpoints (college lacrosse) return no teams at all.
-            # Nothing can be concluded, so say nothing.
-            return
-
-        # Dynamic groups like AP_TOP_25 are expanded elsewhere; they are not
-        # team codes and must not be reported as bad ones.
-        codes = [f for f in favorites if not self._is_dynamic(f)]
-        recognised = [f for f in codes if f in teams]
-        unknown = [f for f in codes if f not in teams]
-
-        for code in unknown:
-            self.logger.warning(
-                "%s favorite team %r is not a %s team code.%s "
-                "Every code this league accepts is listed at %s.",
-                name, code, name, self._suggest(code, teams),
-                TEAMS_URL.format(path=path),
-            )
-
-        if codes and not recognised:
-            self.logger.warning(
-                "%s has no recognised favorite teams, so nothing will be shown "
-                "for it. Codes must be ESPN abbreviations, e.g. %s.",
-                name, ", ".join("{} ({})".format(a, n)
-                                for a, n in list(sorted(teams.items()))[:3]),
-            )
-            return
-
-        if not recognised:
-            return
-
-        # Codes are fine, so check the other cause of an empty screen.
-        try:
-            note = self._schedule_note(path)
-        except Exception as exc:
-            self.logger.debug("Could not check the %s schedule: %s", name, exc)
-            return
-
-        if note:
-            self.logger.info(
-                "%s favorite teams %s look correct, but %s. An empty display "
-                "until then is expected, not a configuration problem.",
-                name, ", ".join(recognised), note,
-            )
-        else:
-            self.logger.info("%s favorite teams recognised: %s",
-                             name, ", ".join(recognised))
-
-    @staticmethod
-    def _is_dynamic(code: str) -> bool:
-        upper = (code or "").strip().upper()
-        return upper.startswith("AP_") or upper.startswith("TOP_") or "TOP_" in upper
-
-    @staticmethod
-    def _fetch_teams(path: str) -> Dict[str, str]:
-        """ESPN's {abbreviation: display name} for a league.
-
-        ``limit=1000`` is required: the default page size truncates the NCAA
-        responses to roughly half their teams, which makes valid codes look wrong.
-        """
-        import requests
-
-        payload = requests.get(TEAMS_URL.format(path=path),
-                               timeout=REQUEST_TIMEOUT).json()
-        entries = payload['sports'][0]['leagues'][0]['teams']
-        return {
-            t['team']['abbreviation']: t['team']['displayName']
-            for t in entries if t.get('team', {}).get('abbreviation')
-        }
-
-    @classmethod
-    def _schedule_note(cls, path: str) -> Optional[str]:
-        """
-        Why the league has nothing to show, as a clause, or ``None`` if it does.
-
-        Two things make this harder than reading ``events``:
-
-        * An out-of-season league does not come back empty. ESPN rolls the
-          scoreboard forward to the next day that has fixtures, so in July the
-          NHL endpoint returns seven September games. Emptiness cannot be the
-          signal; the date of those games is, and it is more useful anyway.
-        * A *finished* season rolls nowhere and returns its last game instead,
-          months in the past — so dates have to be filtered to the future
-          before the soonest one means anything.
-        """
-        import requests
-
-        payload = requests.get(SCOREBOARD_URL.format(path=path),
-                               timeout=REQUEST_TIMEOUT).json()
-
-        event_dates = [cls._parse_date(e.get('date'))
-                       for e in payload.get('events') or []]
-        calendar_dates = []
-        for entry in (payload.get('leagues') or [{}])[0].get('calendar') or []:
-            calendar_dates.append(cls._parse_date(
-                entry if isinstance(entry, str) else entry.get('startDate')))
-
-        # Count the last day as current, rather than filtering on "later than
-        # right now": a game that began a few hours ago still means the league
-        # has something on, and dropping it would report a live slate as a
-        # finished season. A day's grace also keeps this correct whatever the
-        # user's timezone, since these timestamps are UTC.
-        now = datetime.now(timezone.utc)
-
-        def future(candidates):
-            return sorted(d for d in candidates if d and (now - d).days < 1)
-
-        # Events are fixtures; the calendar is week and phase boundaries,
-        # which routinely open days before their first game (an NFL week 1
-        # calendar entry starts the weekend before the Thursday opener).
-        # Reading the two together reported the earliest boundary as a game
-        # date -- "nothing on until 06 September" for a league whose first
-        # snap is the 10th. The calendar only gets a say when the scoreboard
-        # has no events at all to roll forward to: events that exist but are
-        # all in the past mean the season is over, and an offseason calendar
-        # phase must not be dressed up as its next game.
-        #
-        # The exception is a calendar of match days. With calendarType "day"
-        # and calendarIsWhitelist true, every entry is a day that has games,
-        # so a future entry is a real next fixture. Soccer needs it: between
-        # matchdays the scoreboard keeps showing the last one, so on
-        # 2026-09-29 every Premier League event was from 20 September and the
-        # next games (10 October) were only in the calendar. A day calendar
-        # that is not a whitelist (MLB's) lists days *without* games.
-        if any(event_dates):
-            upcoming = future(event_dates)
-            if not upcoming and cls._calendar_is_match_days(payload):
-                upcoming = future(calendar_dates)
-        else:
-            upcoming = future(calendar_dates)
-        if not upcoming:
-            if not any(event_dates) and not any(calendar_dates):
-                return None  # Nothing published either way; draw no conclusion.
-            if cls._moved_to_later_phase(payload):
-                return None  # e.g. postseason under way; see the method.
-            if cls._later_round_scheduled(payload, now):
-                return None  # e.g. Europa League between matchdays.
-            return ("the season has finished and the next one's fixtures are "
-                    "not published yet")
-
-        # A day or two out is just an off day, and saying so would be noise.
-        if (upcoming[0] - now).days < cls.GAP_DAYS:
-            return None
-        return "the league has nothing on until {}".format(
-            upcoming[0].strftime('%d %B %Y'))
-
-    @staticmethod
-    def _calendar_is_match_days(payload) -> bool:
-        """Whether the league calendar lists the days that have games."""
-        league = (payload.get('leagues') or [{}])[0] or {}
-        return (league.get('calendarType') == 'day'
-                and league.get('calendarIsWhitelist') is True)
-
-    @staticmethod
-    def _moved_to_later_phase(payload) -> bool:
-        """
-        Whether the league is in a later in-season phase than its events.
-
-        ESPN does not roll the scoreboard forward into a postseason. The day
-        after MLB's regular season ended, the default scoreboard still returned
-        that last regular-season day, while ``leagues[0].season`` already said
-        Postseason and the wild-card games were two days out. Past events alone
-        then read as a finished season while the same process's upcoming
-        manager was showing the favourite's playoff games.
-
-        Only regular season (2) and postseason (3) count as "later". The
-        offseason (4) follows the postseason too, and there past events really
-        do mean the season is over.
-        """
-        season = ((payload.get('leagues') or [{}])[0] or {}).get('season') or {}
-        league_type = (season.get('type') or {}).get('type')
-        if league_type not in (2, 3):
-            return False
-        event_types = [(e.get('season') or {}).get('type')
-                       for e in payload.get('events') or []]
-        known = [t for t in event_types if isinstance(t, int)]
-        return bool(known) and all(t < league_type for t in known)
-
-    @classmethod
-    def _later_round_scheduled(cls, payload, now: datetime) -> bool:
-        """
-        Whether a "list" calendar has a round that has not started yet.
-
-        Competitions with a list calendar (the UEFA club competitions, the
-        World Cup, AFL, NFL) give each phase its rounds as ``entries`` with
-        start and end dates. Between matchdays the Europa League scoreboard
-        keeps showing the last one: on 2026-09-29 every event was from 17
-        September, the next matchday was only days away, and the rounds from
-        the knockout play-offs to the final were all still to come. A round
-        that starts later means the season is not over, even though the
-        date of the next fixture is not known.
-
-        Only a round's *start* counts. End dates are padded well past the
-        last game -- the World Cup's final round ran to 1 August for a 19 July
-        final -- so a future end date is also true of a finished season.
-        Rounds in an offseason phase (the college football All-Star week)
-        are not games for the favourites and do not count either.
-        """
-        league = (payload.get('leagues') or [{}])[0] or {}
-        for phase in league.get('calendar') or []:
-            if not isinstance(phase, dict) or cls._is_offseason(phase.get('label')):
-                continue
-            for entry in phase.get('entries') or []:
-                if not isinstance(entry, dict) or cls._is_offseason(entry.get('label')):
-                    continue
-                start = cls._parse_date(entry.get('startDate'))
-                if start and start > now:
-                    return True
-        return False
-
-    @staticmethod
-    def _is_offseason(label) -> bool:
-        """'Off Season', 'Offseason', 'Off-season' ..."""
-        return isinstance(label, str) and 'offseason' in re.sub(
-            r'[^a-z]', '', label.lower())
-
-    @staticmethod
-    def _parse_date(raw) -> Optional[datetime]:
-        if not raw or not isinstance(raw, str):
-            return None
-        try:
-            return datetime.fromisoformat(raw.replace('Z', '+00:00'))
-        except ValueError:
-            return None
-
-    @classmethod
-    def _suggest(cls, code: str, teams: Dict[str, str]) -> str:
-        """Nearest matching code for a typo, as a ready-to-log clause."""
-        upper = (code or "").strip().upper()
-        if not upper or code in teams:
-            return ""
-
-        # Right code, wrong case — matching is case-sensitive. Guard on the case
-        # actually differing, so a valid code never draws this message.
-        for abbr in teams:
-            if abbr.upper() == upper:
-                return " Codes are case-sensitive; use {!r} ({}).".format(
-                    abbr, teams[abbr])
-
-        ranked = cls._rank(upper, (a for a, n in teams.items()
-                                   if cls._abbreviates(upper, n)), teams)
-        if not ranked:
-            # Nicknames are often a fragment of a word rather than its initials:
-            # 'BAMA' sits inside 'Alabama' but abbreviates nothing in it. Require
-            # three characters, since shorter fragments match far too much.
-            if len(upper) >= 3:
-                ranked = cls._rank(
-                    upper,
-                    (a for a, n in teams.items()
-                     if any(upper in w for w in cls._words(n))),
-                    teams)
-
-        if len(ranked) == 1:
-            return " Closest match is {!r} ({}).".format(
-                ranked[0], teams[ranked[0]])
-        if ranked:
-            return " Did you mean {}?".format(", ".join(
-                "{!r} ({})".format(a, teams[a]) for a in ranked[:3]))
-
-        # Otherwise fall back to similarity, against names before codes: a name
-        # gives more characters to compare and so produces fewer ties.
-        names = {n.upper(): a for a, n in teams.items()}
-        hits = difflib.get_close_matches(upper, list(names), n=1, cutoff=0.6)
-        if hits:
-            abbr = names[hits[0]]
-            return " Closest match is {!r} ({}).".format(abbr, teams[abbr])
-
-        code_hits = difflib.get_close_matches(upper, list(teams), n=1, cutoff=0.6)
-        if code_hits:
-            return " Closest match is {!r} ({}).".format(
-                code_hits[0], teams[code_hits[0]])
-        return ""
-
-    @staticmethod
-    def _words(name: str):
-        return [w for w in re.split(r'[^A-Za-z0-9]+', (name or '').upper()) if w]
-
-    @classmethod
-    def _rank(cls, code: str, candidates, teams: Dict[str, str]):
-        """
-        Order candidate codes best-first.
-
-        A code that picks up the *first* word of the name wins, because that is
-        how people shorten team names: 'SCAR' for South Carolina starts at
-        'South', whereas for Rutgers Scarlet Knights it starts mid-name. Without
-        this the tie is broken alphabetically and the obvious answer can land
-        third in the list.
-        """
-        def key(abbr):
-            words = cls._words(teams.get(abbr, ''))
-            first_word_hit = bool(words) and words[0].startswith(code[:1])
-            return (not first_word_hit, len(abbr), abbr)
-
-        return sorted(set(candidates), key=key)
-
-    @staticmethod
-    def _abbreviates(code: str, name: str) -> bool:
-        """
-        Whether ``code`` reads as an abbreviation of ``name``.
-
-        Each part of the code must be a prefix of one of the name's words, taken
-        in order — which is how people actually shorten team names. Plain string
-        similarity is no use for three-letter codes: 'MUN' scores identically
-        against 'MAN' and 'SUN', so Manchester United and Sunderland tie and the
-        suggestion is a coin flip. This rule separates them, because 'MUN'
-        splits as M-anchester UN-ited while Sunderland has no word starting M.
-        """
-        words = [w for w in re.split(r'[^A-Za-z0-9]+', (name or '').upper()) if w]
-
-        def consume(rest: str, remaining: List[str]) -> bool:
-            if not rest:
-                return True
-            if not remaining:
-                return False
-            head, tail = remaining[0], remaining[1:]
-            # Skip this word entirely, as in "Manchester United" -> "UTD".
-            if consume(rest, tail):
-                return True
-            for size in range(1, min(len(rest), len(head)) + 1):
-                if head.startswith(rest[:size]) and consume(rest[size:], tail):
-                    return True
-            return False
-
-        return consume((code or "").strip().upper(), words)

src/common/font_layout.py

@@ -67,11 +67,10 @@ _INSTALL_ROOT = Path(__file__).resolve().parents[2]
 def resolve_asset_path(relative_path: str) -> str:
     """Resolve a repo-relative asset path independently of the process cwd.
 
-    In order: an absolute path that exists is returned untouched; otherwise
-    ``relative_path`` under the install root derived above, if that exists;
-    otherwise ``relative_path`` unchanged, so a caller that wants to raise
-    and fall back still can. The cwd is never consulted, so a relative path
-    means the same file whichever directory the process started in.
+    Prefers the path as given — so an absolute path is returned untouched and
+    behaviour is unchanged wherever the cwd already happened to be the install
+    root — then the install root derived above, then the original string so a
+    caller that wants to raise and fall back still can.
 
     Without the fallback, any process started outside the install root (the
     plugin safety harness, a manual ``python run.py`` from ``$HOME``, a unit

src/common/frame_timing.py

@@ -1,615 +0,0 @@
-"""System-wide frame timing: one set of numbers for every presented frame.
-
-Each scroller already logs its own stats line (ScrollHelper.log_frame_rate,
-the Vegas coordinator's "Vegas FPS"), but in different formats, per source,
-and Vegas only logs a healthy window at DEBUG. None of that answers the
-question a release has to answer on each rig: *over a long run, how often did
-a moving frame reach the panel late?*
-
-Every frame reaches the panel through ``DisplayManager.update_display``, so it
-is recorded there, once, whoever drew it. The render thread only appends a
-tuple; a worker thread aggregates, and every ``flush_interval`` seconds writes
-cumulative counters and histograms to a small JSON file -- in ``/dev/shm`` where
-it exists, so a stats file refreshed all day costs no SD-card writes.
-``scripts/frame_soak.py`` reads it twice and reports the difference.
-
-What is counted
----------------
-Only intervals between two consecutive *scrolling* frames count: a static
-screen that changes once a second has no timing to get wrong, and the first
-frame of a scroll has no predecessor worth measuring against.
-
-"Scrolling" is DisplayManager's scroll state when the frame is presented, and
-that state can go missing in the middle of a scroll. It expires after 2s
-without scroll activity, which a long enough stall outlasts, and any thread can
-clear it: plugins call ``set_scrolling_state(False)`` from their own
-``display()``, and Vegas captures some of those on the render thread between
-two of its frames. The frame after that is recorded as static, and the interval
-it ends -- the stall, or the capture -- would vanish from the report. So a
-single static frame between two scrolling ones, with the scroll picking up
-again within ``RESUME_SECONDS``, is treated as a frame of the scroll: both of
-its intervals count. A second static frame in a row means the scroll really
-ended. (On hdpi on 2026-09-24 the watchdog logged a 1.9s stall that the soak
-report did not have; this is how.)
-
-A frame held for ``hold`` refreshes should arrive ``hold`` refresh periods
-after the one before it. One that arrives a whole refresh or more after that is
-**late**: the panel showed the previous frame again, which on a moving strip is
-a visible hitch. ``missed_refreshes`` sums how many refreshes late.
-
-An interval of ``FREEZE_SECONDS`` or more is a **freeze** instead -- a
-recompose, a plugin handover, a blocking call on the render thread. Those are
-counted separately, both because they are a different fault and because
-folding a single 400ms handover into the late count as "40 missed refreshes"
-would drown the jitter the late count exists to measure. ``freeze_by`` splits
-them by length. Intervals of ``GAP_SECONDS`` or more are ignored as not being
-frames of one scroll at all.
-
-A frame that arrives a whole refresh or more *early* means the swap did not
-wait for the panel: the emulator, the fallback display, or a hold that was not
-the one in effect. Those are counted as **early**, and a run with more than a
-trace of them was not locked to the panel, so its late count means nothing.
-
-The refresh period is estimated from the frames themselves: swaps that block
-on vsync can only land on refresh boundaries, so the low end of
-interval / hold is the period. It is the smallest per-window 10th percentile
-seen so far, over windows with enough frames to trust -- except that a window
-cutting it by more than ``MAX_REFRESH_DROP`` is ignored. A panel's refresh does
-not jump like that; swaps that stopped blocking do, and adopting their period
-would make every early frame look on time.
-
-A caller that has measured the panel independently -- ``scripts/render_bench.py``
-times bare swaps first with :func:`measure_refresh_hz` -- passes that rate in
-as ``refresh_hz``. The estimate then starts from it instead of from the frames,
-which is what catches a loop that never locked at all: one that free-runs
-faster than the panel (every frame early) or sits at half its rate (every
-frame late), both of which look self-consistent to an estimate taken from
-their own intervals.
-
-Stall watchdog
---------------
-Counting a freeze says that it happened, not why. ``StallWatchdog`` watches the
-same frames from its own thread and, when a scroll's last frame is more than
-``STALL_SECONDS`` old, logs the stack of the thread that presented it and the
-top of every other thread's, so the log names what the render thread was
-waiting on. It also measures how late its own wake-up was: if the watchdog was
-held up as long as the render thread, the whole interpreter was blocked (C
-code holding the GIL, or the process not scheduled), not one thread on a lock.
-Set ``LEDMATRIX_STALL_WATCHDOG=0`` to turn it off, or
-``LEDMATRIX_STALL_WATCHDOG_MS`` to dump at a lower threshold -- 30 catches
-frames three refreshes late, which is where GIL contention shows. It polls
-three times per threshold, so keep it to diagnostic runs, not soaks.
-"""
-
-from __future__ import annotations
-
-import copy
-import json
-import logging
-import os
-import queue
-import sys
-import tempfile
-import threading
-import time
-import traceback
-from typing import Any, Callable, Dict, List, Optional, Tuple, TypedDict
-
-logger = logging.getLogger(__name__)
-
-#: Bumped when a field changes meaning, so a reader can refuse stale files.
-SCHEMA_VERSION = 1
-
-#: Histogram resolution. 64ms of range covers any frame worth drawing a
-#: distribution of; everything beyond lands in the last bucket.
-BUCKET_MS = 0.25
-BUCKET_COUNT = 256
-
-#: See the module docstring.
-FREEZE_SECONDS = 0.25
-
-#: Intervals this long are not frames of one scroll. This used to be 1s,
-#: which silently dropped every 1-2s stall inside a scroll. It is now only a
-#: sanity bound.
-GAP_SECONDS = 5.0
-
-#: A frame recorded as static between two scrolling frames is a frame of the
-#: scroll whose state went missing, if the scroll resumes within this long.
-#: See "What is counted".
-RESUME_SECONDS = 1.0
-
-#: Buckets for freeze length, as cumulative counters a soak can difference.
-FREEZE_BUCKETS = ((0.5, "<0.5s"), (1.0, "0.5-1s"), (2.0, "1-2s"),
-                  (float("inf"), "2s+"))
-
-#: A window may lower the refresh-period estimate by at most this fraction.
-MAX_REFRESH_DROP = 0.2
-
-#: A window needs this many scrolling frames before its refresh estimate is
-#: trusted -- about a second of scrolling.
-MIN_FRAMES_FOR_REFRESH = 90
-
-FLUSH_INTERVAL = 10.0
-
-#: A scroll's last frame older than this is a stall worth a stack dump.
-STALL_SECONDS = 0.25
-#: How often the watchdog looks. Also the resolution of its starvation check.
-WATCHDOG_POLL_SECONDS = 0.05
-#: At most one stack dump per this many seconds: a stall that repeats every
-#: extension would otherwise write the same stacks to the SD card all day.
-STALL_LOG_INTERVAL = 30.0
-
-#: Written by the display service, read by scripts/frame_soak.py and anything
-#: else that wants the numbers. The web UI's viewer marker lives in /tmp; this
-#: goes to RAM where there is some, since it is rewritten all day.
-STATS_FILENAME = "ledmatrix_frame_stats.json"
-
-
-def default_stats_path() -> str:
-    # A fixed name in a shared directory is safe here: write() creates its
-    # temp file with mkstemp and os.replace()s it over this path, which swaps
-    # out whatever is there -- a planted symlink included -- without following it.
-    base = "/dev/shm" if os.path.isdir("/dev/shm") else tempfile.gettempdir()  # nosec B108
-    return os.path.join(base, STATS_FILENAME)
-
-
-def _bucket(seconds: float) -> int:
-    index = int(seconds * 1000.0 / BUCKET_MS)
-    return min(max(index, 0), BUCKET_COUNT - 1)
-
-
-def binding_releases_gil() -> Optional[bool]:
-    """Whether the loaded rgbmatrix binding releases the GIL, or None.
-
-    The stock binding blocks in SwapOnVSync holding the GIL, which starves
-    every other thread for most of each frame (docs/SCROLL_PERFORMANCE.md).
-    scripts/build_rgbmatrix_nogil.sh rebuilds it, and the rebuilt module links
-    PyEval_SaveThread where the stock one never does -- a crude test, but the
-    only one that needs neither a probe on the panel nor the source tree the
-    module was built from. None when no hardware binding is loaded.
-    """
-    module = sys.modules.get("rgbmatrix.core")
-    path = getattr(module, "__file__", None)
-    if not path:
-        return None
-    try:
-        with open(path, "rb") as handle:
-            return b"PyEval_SaveThread" in handle.read()
-    except OSError:
-        return None
-
-
-def _pi_model() -> Optional[str]:
-    try:
-        with open("/proc/device-tree/model", "rb") as handle:
-            return handle.read().rstrip(b"\0").decode("ascii", "replace").strip()
-    except OSError:
-        return None
-
-
-def measure_refresh_hz(matrix: Any, seconds: float = 4.0) -> float:
-    """The panel's refresh rate with nothing else running, by timing bare swaps.
-
-    ``SwapOnVSync`` blocks until the panel's next refresh, so a loop that does
-    nothing else runs at exactly the panel's rate. ``limit_refresh_rate_hz`` is
-    a *cap*, and a long chain, a high ``pwm_bits`` or an older Pi will sit well
-    under it. Solving scroll speeds against a cap the panel cannot reach is
-    what produces "3px every 4 refreshes" and the judder that comes with it.
-
-    This is the idle rate. The panel refreshes a few percent slower while the
-    Pi is also pushing frames into it (100.4Hz idle against 96.3Hz scrolling on
-    a Pi 4 driving 512x64), which is why the recorder reads the rendering rate
-    back from the frames rather than trusting this.
-
-    Pass the matrix the display is already running on rather than opening a
-    second one: the GPIO has a single owner, and the options in force change
-    the answer.
-
-    :returns: measured Hz, or 0.0 if the matrix cannot be swapped (no
-        hardware, a stub, a mock).
-    """
-    try:
-        canvas = matrix.CreateFrameCanvas()
-        # Discard the first swap: it carries construction and first-touch costs
-        # that have nothing to do with the steady-state refresh.
-        canvas = matrix.SwapOnVSync(canvas)
-    except Exception:  # pylint: disable=broad-except
-        return 0.0
-
-    frames = 0
-    started = time.perf_counter()
-    while time.perf_counter() - started < seconds:
-        canvas = matrix.SwapOnVSync(canvas)
-        frames += 1
-    elapsed = time.perf_counter() - started
-    if elapsed <= 0 or frames <= 0:
-        return 0.0
-    return frames / elapsed
-
-class FrameTimingRecorder:
-    """Collects per-frame timings on the render thread; aggregates elsewhere.
-
-    ``record`` is the only method the render thread calls, and it does no more
-    than compare two floats and append a tuple.
-    """
-
-    def __init__(
-        self,
-        path: Optional[str] = None,
-        flush_interval: float = FLUSH_INTERVAL,
-        info: Optional[Dict[str, Any]] = None,
-        refresh_hz: Optional[float] = None,
-    ):
-        """
-        :param refresh_hz: the panel's rate, measured independently (see the
-            module docstring). Omit it to estimate from the frames alone, as
-            the display service does.
-        """
-        self.path = path or default_stats_path()
-        self.flush_interval = flush_interval
-        self.info = dict(info or {})
-
-        # Render-thread state.
-        self._pending: List[Tuple[float, float, float, int]] = []
-        self._static_frames = 0
-        self._previous: Optional[Tuple[float, bool, int]] = None
-        # The interval ended by a static frame that followed a scrolling one,
-        # until the next frame shows whether the scroll went on.
-        self._unsure: Optional[Tuple[float, float, float, int]] = None
-        self._last_flush: Optional[float] = None
-        self._queue: "queue.SimpleQueue" = queue.SimpleQueue()
-        self._worker: Optional[threading.Thread] = None
-
-        # Worker-thread state. Nothing on the render thread reads these.
-        self.started = time.time()
-        self.refresh_period: Optional[float] = (
-            1.0 / refresh_hz if refresh_hz and refresh_hz > 0 else None)
-        # The first estimate, until a second window agrees with it.
-        self._refresh_candidate: Optional[float] = None
-        self.totals: Dict[str, Any] = {
-            "static_frames": 0,
-            "scroll_frames": 0,
-            "late_frames": 0,
-            "missed_refreshes": 0,
-            "late_by": {"1": 0, "2": 0, "3-5": 0, "6+": 0},
-            "early_frames": 0,
-            # Frames judged against a known refresh period: the denominator
-            # for the late and early rates. Frames before the period is known
-            # are neither, and must not dilute them.
-            "timed_frames": 0,
-            "freezes": 0,
-            "freeze_seconds": 0.0,
-            "freeze_by": {label: 0 for _, label in FREEZE_BUCKETS},
-            "worst_interval_ms": 0.0,
-        }
-        self.histograms: Dict[str, Dict[int, int]] = {
-            "blit": {}, "wait": {}, "work": {}, "interval_per_hold": {},
-        }
-        self._binding_gil: Optional[bool] = None
-        self._binding_checked = False
-
-        # Read by the stall watchdog from its own thread: one tuple assignment,
-        # so it always sees a consistent (time, scrolling, thread) triple.
-        self.last_frame: Optional[Tuple[float, bool, int]] = None
-        #: Whether a scroll is running *now*, supplied by the display manager.
-        #: The last frame's flag alone would call the end of every scroll a
-        #: stall.
-        self.scrolling_now: Optional[Callable[[], bool]] = None
-        self.watchdog: Optional["StallWatchdog"] = None
-
-    def close(self) -> None:
-        """Stop the stall watchdog, if one was started."""
-        watchdog, self.watchdog = self.watchdog, None
-        if watchdog is not None:
-            watchdog.stop()
-
-    # -- render thread ------------------------------------------------------
-
-    def record(self, blit: float, wait: float, hold: int, scrolling: bool,
-               presented_at: float) -> None:
-        """One frame reached the panel.
-
-        :param blit: seconds spent copying the frame into the canvas.
-        :param wait: seconds SwapOnVSync blocked.
-        :param hold: the refreshes this frame was held for.
-        :param scrolling: whether a scroll was running when it was presented.
-        :param presented_at: ``time.perf_counter()`` when the swap returned.
-        """
-        previous = self._previous
-        self._previous = (presented_at, scrolling, hold)
-        self.last_frame = (presented_at, scrolling, threading.get_ident())
-        if not scrolling:
-            self._static_frames += 1
-            # The scroll ended, or its state went missing for this frame: the
-            # next frame says which. Its hold may have been dropped with the
-            # state, so the interval is due at the scroll's own.
-            self._unsure = None
-            if previous is not None and previous[1]:
-                self._unsure = (presented_at - previous[0], blit, wait, previous[2])
-        elif self.watchdog is None and self.scrolling_now is not None \
-                and os.environ.get("LEDMATRIX_STALL_WATCHDOG", "1") != "0":
-            self.watchdog = StallWatchdog(self, **watchdog_settings())
-            self.watchdog.start()
-        elif previous is not None:
-            interval = presented_at - previous[0]
-            unsure, self._unsure = self._unsure, None
-            if previous[1]:
-                if interval < GAP_SECONDS:
-                    self._pending.append((interval, blit, wait, hold))
-            elif unsure is not None and interval < RESUME_SECONDS:
-                # One static frame between two scrolling ones: the scroll never
-                # stopped, only its state did. Both intervals were motion.
-                self._static_frames -= 1
-                if unsure[0] < GAP_SECONDS:
-                    self._pending.append(unsure)
-                self._pending.append((interval, blit, wait, hold))
-
-        if self._last_flush is None:
-            self._last_flush = presented_at
-        elif presented_at - self._last_flush >= self.flush_interval:
-            self._hand_off()
-            self._last_flush = presented_at
-
-    def _hand_off(self) -> None:
-        batch, self._pending = self._pending, []
-        static, self._static_frames = self._static_frames, 0
-        self._queue.put((batch, static))
-        if self._worker is None or not self._worker.is_alive():
-            self._worker = threading.Thread(
-                target=self._run, daemon=True, name="frame-timing")
-            self._worker.start()
-
-    def drain(self) -> None:
-        """Aggregate everything recorded so far, on the calling thread.
-
-        For a caller that owns the recorder outright and wants exact numbers at
-        a moment of its choosing -- the benchmark, between warm-up and run and
-        at the end. Construct it with ``flush_interval=float('inf')`` so the
-        worker never runs; the two must not aggregate at once.
-        """
-        batch, self._pending = self._pending, []
-        static, self._static_frames = self._static_frames, 0
-        self.aggregate(batch, static)
-
-    # -- worker thread ------------------------------------------------------
-
-    def _run(self) -> None:
-        while True:
-            batch, static = self._queue.get()
-            try:
-                self.aggregate(batch, static)
-                self.write()
-            except Exception:  # never let telemetry take anything down
-                logger.debug("Frame timing flush failed", exc_info=True)
-
-    def aggregate(self, batch: List[Tuple[float, float, float, int]],
-                  static: int) -> None:
-        """Fold one window of frames into the running totals."""
-        totals = self.totals
-        totals["static_frames"] += static
-
-        per_hold = sorted(interval / max(1, hold)
-                          for interval, _, _, hold in batch
-                          if interval < FREEZE_SECONDS)
-        if len(per_hold) >= MIN_FRAMES_FOR_REFRESH:
-            estimate = per_hold[len(per_hold) // 10]
-            current = self.refresh_period
-            if estimate <= 0:
-                pass
-            elif current is None:
-                # Adopt the first period only once two windows in a row agree:
-                # one loaded window at startup, most of its frames a refresh
-                # late, would otherwise fix a period twice the real one for
-                # the life of the process, since later windows may only lower
-                # it by MAX_REFRESH_DROP.
-                candidate = self._refresh_candidate
-                if candidate and abs(estimate - candidate) <= candidate * MAX_REFRESH_DROP:
-                    self.refresh_period = min(candidate, estimate)
-                else:
-                    self._refresh_candidate = estimate
-            elif current * (1.0 - MAX_REFRESH_DROP) <= estimate < current:
-                self.refresh_period = estimate
-        period = self.refresh_period
-
-        histograms = self.histograms
-        for interval, blit, wait, hold in batch:
-            totals["worst_interval_ms"] = max(totals["worst_interval_ms"],
-                                              interval * 1000.0)
-            if interval >= FREEZE_SECONDS:
-                totals["freezes"] += 1
-                totals["freeze_seconds"] += interval
-                label = next(name for limit, name in FREEZE_BUCKETS
-                             if interval < limit)
-                totals["freeze_by"][label] += 1
-                continue
-            totals["scroll_frames"] += 1
-            for name, value in (("blit", blit), ("wait", wait),
-                                ("work", max(0.0, interval - blit - wait)),
-                                ("interval_per_hold", interval / max(1, hold))):
-                bucket = _bucket(value)
-                histogram = histograms[name]
-                histogram[bucket] = histogram.get(bucket, 0) + 1
-            if period:
-                totals["timed_frames"] += 1
-                missed = round(interval / period) - hold
-                if missed >= 1:
-                    totals["late_frames"] += 1
-                    totals["missed_refreshes"] += missed
-                    key = ("1" if missed == 1 else "2" if missed == 2
-                           else "3-5" if missed <= 5 else "6+")
-                    totals["late_by"][key] += 1
-                elif missed <= -1:
-                    totals["early_frames"] += 1
-
-    def snapshot(self) -> Dict[str, Any]:
-        """The JSON document: cumulative since this process started."""
-        if not self._binding_checked:
-            self._binding_gil = binding_releases_gil()
-            self._binding_checked = True
-        info = dict(self.info)
-        info.setdefault("pi_model", _pi_model())
-        period = self.refresh_period
-        return {
-            "version": SCHEMA_VERSION,
-            "pid": os.getpid(),
-            "started": self.started,
-            "updated": time.time(),
-            "bucket_ms": BUCKET_MS,
-            "freeze_seconds": FREEZE_SECONDS,
-            "measured_refresh_hz": round(1.0 / period, 2) if period else None,
-            "binding_releases_gil": self._binding_gil,
-            "info": info,
-            "totals": copy.deepcopy(self.totals),
-            # JSON keys are strings; readers convert back.
-            "histograms": {name: {str(k): v for k, v in sorted(h.items())}
-                           for name, h in self.histograms.items()},
-        }
-
-    def write(self) -> None:
-        """Replace the stats file atomically with the current snapshot."""
-        directory = os.path.dirname(self.path) or "."
-        fd, tmp = tempfile.mkstemp(dir=directory, prefix=".frame_stats.",
-                                   suffix=".tmp")
-        try:
-            with os.fdopen(fd, "w", encoding="utf-8") as handle:
-                json.dump(self.snapshot(), handle)
-            os.chmod(tmp, 0o644)
-            os.replace(tmp, self.path)
-        except Exception:
-            try:
-                os.unlink(tmp)
-            except OSError:
-                pass
-            raise
-
-
-class _WatchdogSettings(TypedDict, total=False):
-    """The StallWatchdog keyword arguments watchdog_settings() may set."""
-    threshold: float
-    poll: float
-
-
-def watchdog_settings() -> _WatchdogSettings:
-    """StallWatchdog arguments from ``LEDMATRIX_STALL_WATCHDOG_MS``, if set.
-
-    The poll comes down with the threshold, or a stall shorter than one poll
-    would go unseen.
-    """
-    try:
-        ms = float(os.environ.get("LEDMATRIX_STALL_WATCHDOG_MS") or 0)
-    except ValueError:
-        ms = 0.0
-    if ms <= 0:
-        return {}
-    threshold = ms / 1000.0
-    return {"threshold": threshold,
-            "poll": min(WATCHDOG_POLL_SECONDS, threshold / 3)}
-
-
-class StallWatchdog:
-    """Log what the render thread is doing when a scroll stops presenting.
-
-    See the module docstring. Polls; never touches the render thread.
-    """
-
-    def __init__(
-        self,
-        recorder: FrameTimingRecorder,
-        threshold: float = STALL_SECONDS,
-        poll: float = WATCHDOG_POLL_SECONDS,
-        log_interval: float = STALL_LOG_INTERVAL,
-        clock: Callable[[], float] = time.perf_counter,
-    ):
-        self.recorder = recorder
-        self.threshold = threshold
-        self.poll = poll
-        self.log_interval = log_interval
-        self.clock = clock
-        self.stalls = 0
-        self._last_dump: Optional[float] = None
-        self._thread: Optional[threading.Thread] = None
-        self._stop = threading.Event()
-
-    def start(self) -> None:
-        self._thread = threading.Thread(
-            target=self._run, daemon=True, name="stall-watchdog")
-        self._thread.start()
-
-    def stop(self, timeout: float = 1.0) -> None:
-        """End the polling thread (DisplayManager.cleanup calls this)."""
-        self._stop.set()
-        thread = self._thread
-        if thread is not None and thread is not threading.current_thread():
-            thread.join(timeout)
-
-    def _run(self) -> None:
-        last_wake = self.clock()
-        stall_from: Optional[float] = None   # presented_at of the stalled frame
-        dumped = False
-        while not self._stop.wait(self.poll):
-            now = self.clock()
-            late = max(0.0, now - last_wake - self.poll)
-            last_wake = now
-            try:
-                stall_from, dumped = self.check(now, late, stall_from, dumped)
-            except Exception:  # never let a diagnostic take anything down
-                logger.debug("Stall watchdog check failed", exc_info=True)
-
-    def check(self, now: float, late: float, stall_from: Optional[float],
-              dumped: bool) -> Tuple[Optional[float], bool]:
-        """One look. Returns the updated (stall_from, dumped) state."""
-        frame = self.recorder.last_frame
-        if frame is None:
-            return None, False
-        presented_at, scrolling, ident = frame
-
-        if stall_from is not None and presented_at != stall_from:
-            # A frame arrived: the stall is over.
-            if dumped:
-                logger.warning(
-                    "Render stall over: no frame for %.0fms",
-                    (presented_at - stall_from) * 1000.0)
-            return None, False
-
-        scrolling_now = self.recorder.scrolling_now
-        if (stall_from is not None and now - stall_from >= GAP_SECONDS
-                and (scrolling_now is None or not scrolling_now())):
-            # The scroll ended without another frame: nothing more to time.
-            # Only past GAP_SECONDS: the scroll state expires after 2s without
-            # activity, which a stall outlasts, and its end still wants saying.
-            return None, False
-        age = now - presented_at
-        if (stall_from is None and scrolling and age >= self.threshold
-                and scrolling_now is not None and scrolling_now()):
-            self.stalls += 1
-            if self._last_dump is None or now - self._last_dump >= self.log_interval:
-                self._last_dump = now
-                logger.warning(self.describe(ident, age, late))
-                return presented_at, True
-            return presented_at, False
-        return stall_from, dumped
-
-    def describe(self, ident: int, age: float, late: float) -> str:
-        """The stack dump: the stalled thread in full, the rest in brief."""
-        names = {t.ident: t.name for t in threading.enumerate()}
-        frames = sys._current_frames()
-        lines = [
-            f"Render stall: no frame for {age * 1000.0:.0f}ms mid-scroll "
-            f"(watchdog woke {late * 1000.0:.0f}ms late"
-            + ("; the interpreter itself was blocked" if late >= age / 2 else "")
-            + ")",
-            f"-- {names.get(ident, ident)} (presents frames):",
-        ]
-        stalled = frames.get(ident)
-        if stalled is not None:
-            lines.extend(line.rstrip() for line in
-                         traceback.format_stack(stalled, limit=12))
-        for other, frame in frames.items():
-            if other in (ident, threading.get_ident()):
-                continue
-            top = traceback.extract_stack(frame, limit=3)
-            where = " <- ".join(
-                f"{os.path.basename(f.filename)}:{f.lineno} {f.name}"
-                for f in reversed(top))
-            lines.append(f"-- {names.get(other, other)}: {where}")
-        return "\n".join(lines)

src/common/json_body.py

@@ -1,29 +0,0 @@
-"""Parse an HTTP response body as JSON, with orjson when it is installed.
-
-``requests``' ``response.json()`` uses the stdlib parser. For the payloads the
-sports plugins fetch -- a season schedule is tens of MB -- that runs ~1.7x
-slower than orjson on a Pi 4 (3.1s against 1.8s for the 53MB MLB season), and
-both hold the GIL for the whole parse, which freezes the display for as long.
-Nothing else changes: the result is the same Python objects.
-"""
-
-from __future__ import annotations
-
-from typing import Any
-
-try:
-    import orjson
-except ImportError:  # optional dependency; see docs/SCROLL_PERFORMANCE.md
-    orjson = None
-
-
-def response_json(response: Any) -> Any:
-    """``response.json()``, parsed by orjson when available."""
-    body = getattr(response, "content", None)
-    if orjson is None or not isinstance(body, (bytes, bytearray)):
-        return response.json()
-    try:
-        return orjson.loads(body)
-    except orjson.JSONDecodeError:
-        # Let requests raise its usual error, with its usual message.
-        return response.json()

src/common/logo_helper.py

@@ -8,10 +8,10 @@ Extracted from LEDMatrix core to provide reusable functionality for plugins.
 import logging
 import time
 from pathlib import Path
-from typing import Dict, List, Optional, Tuple, Union
+from typing import Dict, List, Optional, Union
 
 import requests
-from PIL import Image, ImageDraw
+from PIL import Image
 from src.common.api_helper import USER_AGENT
 from src.common.permission_utils import (
     ensure_directory_permissions,
@@ -32,14 +32,35 @@ from src.common.permission_utils import (
 # trade for not re-warning about a file nobody is going to add.
 MISSING_LOGO_RECHECK_SECONDS = 3600.0
 
+#: Bounds on a user-supplied logo scale. Wide enough to be useful, closed
+#: enough that a typo cannot ask for a 4000px image on a 64px panel.
+MIN_LOGO_SCALE = 0.05
+MAX_LOGO_SCALE = 8.0
+
+
+def _usable_scale(scale) -> float:
+    """A scale that can be applied, or 1.0.
+
+    Anything unusable -- None, a string, zero, a negative, NaN, infinity --
+    means "as shipped", because the alternative is a blank panel from a
+    mistyped number.
+    """
+    try:
+        value = float(scale)
+    except (TypeError, ValueError):
+        return 1.0
+    if value != value or value in (float('inf'), float('-inf')):
+        return 1.0
+    if value < MIN_LOGO_SCALE or value > MAX_LOGO_SCALE:
+        return 1.0
+    return value
+
+
+
 # Well above any real team logo; bounds what a remote URL can write to disk.
 # The cap for every logo download: src.logo_downloader.fetch_logo uses it too.
 MAX_LOGO_BYTES = 10 * 1024 * 1024
 
-#: A logo's default bounding box, as a multiple of the panel's width and
-#: height, when the caller gives no max_width / max_height.
-DEFAULT_LOGO_BOX_FACTOR = 1.5
-
 
 class LogoHelper:
     """
@@ -80,11 +101,6 @@ class LogoHelper:
         # Time-bounded rather than permanent so a logo that appears later (the
         # downloader writes them at runtime) is still picked up.
         self._missing_logos: Dict[str, float] = {}
-
-        # Failed downloads by logo path. A logo that is absent (not a stale
-        # placeholder) has no on-disk timestamp to back off on, so without this
-        # every call retried the download -- up to a 30s timeout each time.
-        self._download_failures: Dict[str, float] = {}
         
         # Session for HTTP requests
         self.session = requests.Session()
@@ -103,16 +119,12 @@ class LogoHelper:
         Args:
             team_abbr: Team abbreviation for caching
             logo_path: Path to the logo file
-            max_width: Maximum width (default display_width *
-                DEFAULT_LOGO_BOX_FACTOR)
-            max_height: Maximum height (default display_height *
-                DEFAULT_LOGO_BOX_FACTOR)
+            max_width: Maximum width (defaults to display_width * 1.5)
+            max_height: Maximum height (defaults to display_height * 1.5)
             scale: User's size multiplier for this image, from
-                ``customization.layout.<element>.scale``; 1.0 leaves the box
-                as is. Callers hold the config, so they resolve the element
-                name; this only applies the number, clamped to
-                src.element_style's MIN_ELEMENT_SCALE..MAX_ELEMENT_SCALE.
-                A value that is not a finite positive number means 1.0.
+                ``customization.layout.<element>.scale``. 1.0 is untouched and
+                takes exactly the path it always did. Callers hold the config,
+                so they resolve the element name; this only applies the number.
 
         Returns:
             PIL Image object or None if loading fails
@@ -125,7 +137,14 @@ class LogoHelper:
         # Resolve the effective target size BEFORE the cache lookup so the
         # key is size-qualified — a panel-size change must not return a
         # logo resized for the old dimensions.
-        max_width, max_height, scale = self._scaled_box(max_width, max_height, scale)
+        if max_width is None:
+            max_width = int(self.display_width * 1.5)
+        if max_height is None:
+            max_height = int(self.display_height * 1.5)
+        scale = _usable_scale(scale)
+        if scale != 1.0:
+            max_width = max(1, int(round(max_width * scale)))
+            max_height = max(1, int(round(max_height * scale)))
         # The key carries the scaled box, so two elements scaled differently
         # cannot be served each other's image.
         cache_key = f"{team_abbr}_{logo_path}_{max_width}x{max_height}"
@@ -154,7 +173,7 @@ class LogoHelper:
                 return None
             
             # Load image
-            logo: Image.Image = Image.open(logo_path)
+            logo = Image.open(logo_path)
             if logo.mode != 'RGBA':
                 logo = logo.convert('RGBA')
             
@@ -199,12 +218,7 @@ class LogoHelper:
             return self.load_logo(team_abbr, logo_path, max_width, max_height,
                                   scale)
         
-        # Download if URL provided and file doesn't exist, unless the last
-        # attempt for this path failed recently.
-        failed_at = self._download_failures.get(str(logo_path))
-        if (logo_url and failed_at is not None
-                and time.time() - failed_at < MISSING_LOGO_RECHECK_SECONDS):
-            logo_url = None
+        # Download if URL provided and file doesn't exist
         if logo_url:
             try:
                 self.logger.info(f"Downloading logo for {team_abbr} from {logo_url}")
@@ -218,7 +232,6 @@ class LogoHelper:
                                   scale)
             except Exception as e:
                 self.logger.error(f"Failed to download logo for {team_abbr}: {e}")
-                self._download_failures[str(logo_path)] = time.time()
                 # The retry failed, so restart the back-off. The stale
                 # placeholder is still on disk with its old timestamp, and
                 # leaving it there means the next call retries immediately --
@@ -226,30 +239,8 @@ class LogoHelper:
                 # exists to prevent.
                 self._refresh_stale_placeholder(logo_path)
         
-        # Create placeholder if all else fails. Sized to the same scaled box
-        # a real logo gets, so a scaled element doesn't jump in size while
-        # its logo is missing.
-        box_width, box_height, _ = self._scaled_box(max_width, max_height, scale)
-        return self._create_placeholder_logo(team_abbr, box_width, box_height)
-
-    def _scaled_box(self, max_width: Optional[int], max_height: Optional[int],
-                    scale: float) -> Tuple[int, int, float]:
-        """The logo box after defaults and the user's scale are applied.
-
-        Returns ``(width, height, coerced_scale)``.
-        """
-        if max_width is None:
-            max_width = int(self.display_width * DEFAULT_LOGO_BOX_FACTOR)
-        if max_height is None:
-            max_height = int(self.display_height * DEFAULT_LOGO_BOX_FACTOR)
-        # Imported here: src.element_style imports src.common (for bdf_font),
-        # whose __init__ imports this module.
-        from src.element_style import coerce_scale
-        scale = coerce_scale(scale, 1.0)
-        if scale != 1.0:
-            max_width = max(1, int(round(max_width * scale)))
-            max_height = max(1, int(round(max_height * scale)))
-        return max_width, max_height, scale
+        # Create placeholder if all else fails
+        return self._create_placeholder_logo(team_abbr, max_width, max_height)
     
     def _invalidate_cached_logo(self, team_abbr: str, logo_path: Path) -> None:
         """Drop every cached size of one logo after its file changed on disk."""
@@ -263,7 +254,6 @@ class LogoHelper:
         # leaving it would hide a logo we just downloaded.
         for key in [k for k in self._missing_logos if k.startswith(prefix)]:
             del self._missing_logos[key]
-        self._download_failures.pop(str(logo_path), None)
 
     @staticmethod
     def _refresh_stale_placeholder(logo_path: Path) -> None:
@@ -356,10 +346,9 @@ class LogoHelper:
         self._logo_cache.clear()
         self._cache_order.clear()
         self._missing_logos.clear()
-        self._download_failures.clear()
         self.logger.debug("Logo cache cleared")
     
-    def get_cache_stats(self) -> Dict[str, float]:
+    def get_cache_stats(self) -> Dict[str, int]:
         """
         Get cache statistics.
         
@@ -385,9 +374,9 @@ class LogoHelper:
         nobody asked to grow would change every existing render.
         """
         if max_width is None:
-            max_width = int(self.display_width * DEFAULT_LOGO_BOX_FACTOR)
+            max_width = int(self.display_width * 1.5)
         if max_height is None:
-            max_height = int(self.display_height * DEFAULT_LOGO_BOX_FACTOR)
+            max_height = int(self.display_height * 1.5)
 
         # Only resize if necessary
         if logo.width <= max_width and logo.height <= max_height:
@@ -440,26 +429,31 @@ class LogoHelper:
                                max_width: Optional[int] = None,
                                max_height: Optional[int] = None) -> Optional[Image.Image]:
         """
-        A stand-in for a logo that could not be loaded or downloaded: a
-        translucent grey box with a light outline, filling the logo box.
-        No text is drawn; ``team_abbr`` is only used in log messages.
-
+        Create a placeholder logo with team abbreviation.
+        
         Args:
-            team_abbr: Team the placeholder stands in for
-            max_width: Width (default display_width * DEFAULT_LOGO_BOX_FACTOR)
-            max_height: Height (default display_height * DEFAULT_LOGO_BOX_FACTOR)
-
+            team_abbr: Team abbreviation to display
+            max_width: Maximum width
+            max_height: Maximum height
+            
         Returns:
-            The RGBA placeholder, or None if it could not be created
+            PIL Image with placeholder logo
         """
         try:
             if max_width is None:
-                max_width = int(self.display_width * DEFAULT_LOGO_BOX_FACTOR)
+                max_width = int(self.display_width * 1.5)
             if max_height is None:
-                max_height = int(self.display_height * DEFAULT_LOGO_BOX_FACTOR)
+                max_height = int(self.display_height * 1.5)
             
+            # Create placeholder image
             placeholder = Image.new('RGBA', (max_width, max_height), (0, 0, 0, 0))
+            
+            # This would require a font, so we'll create a simple colored rectangle
+            # In a real implementation, you'd want to add text rendering here
+            from PIL import ImageDraw
             draw = ImageDraw.Draw(placeholder)
+            
+            # Draw a simple rectangle with team abbreviation
             draw.rectangle([0, 0, max_width-1, max_height-1], 
                           fill=(100, 100, 100, 200), outline=(200, 200, 200, 255))
             

src/common/permission_utils.py

@@ -241,8 +241,7 @@ def get_assets_dir_mode() -> int:
     Return permission mode for asset directories.
     
     Returns:
-        Permission mode: 0o2775 (rwxrwsr-x): group-writable, and setgid so
-        entries created in it take the directory's group
+        Permission mode: 0o2775 (rwxrwxr-x + sticky bit) for group-writable directories
     """
     return 0o2775  # rwxrwsr-x (setgid + group writable)
 
@@ -252,8 +251,7 @@ def get_config_dir_mode() -> int:
     Return permission mode for config directory.
     
     Returns:
-        Permission mode: 0o2775 (rwxrwsr-x): group-writable, and setgid so
-        entries created in it take the directory's group
+        Permission mode: 0o2775 (rwxrwxr-x + sticky bit) for group-writable directories
     """
     return 0o2775  # rwxrwsr-x (setgid + group writable)
 
@@ -273,8 +271,7 @@ def get_plugin_dir_mode() -> int:
     Return permission mode for plugin directories.
     
     Returns:
-        Permission mode: 0o2775 (rwxrwsr-x): group-writable, and setgid so
-        entries created in it take the directory's group
+        Permission mode: 0o2775 (rwxrwxr-x + sticky bit) for group-writable directories
     """
     return 0o2775  # rwxrwsr-x (setgid + group writable)
 
@@ -284,32 +281,11 @@ def get_cache_dir_mode() -> int:
     Return permission mode for cache directories.
 
     Returns:
-        Permission mode: 0o2775 (rwxrwsr-x): group-writable, and setgid so
-        entries created in it take the directory's group
+        Permission mode: 0o2775 (rwxrwxr-x + sticky bit) for group-writable cache directories
     """
     return 0o2775  # rwxrwsr-x (setgid + group writable)
 
 
-def _sudo_bash_candidates() -> list:
-    """Bash paths to try, in order, when running a vetted helper via sudo.
-
-    sudoers matches the exact argv, so ``sudo -n <bash> <helper> ...`` only
-    works if <bash> is the same path configure_web_sudo.sh wrote into the
-    rule -- whatever ``command -v bash`` said on the machine that ran it.
-    On merged-/usr systems /usr/bin/bash and /bin/bash are the same file but
-    different strings to sudo, and the web user's PATH can differ from the
-    installer's, so no single guess is reliable. Callers try each in turn and
-    move on only when sudo refused the command line (SUDO_REFUSAL_PHRASES).
-    The helper is invoked through bash rather than its shebang for the same
-    reason: the rule names bash, not the script.
-    """
-    candidates = []
-    for candidate in ("/usr/bin/bash", "/bin/bash", _shutil.which("bash")):
-        if candidate and candidate not in candidates:
-            candidates.append(candidate)
-    return candidates
-
-
 def sudo_remove_directory(path: Path, allowed_bases: Optional[list] = None) -> bool:
     """
     Remove a directory using sudo as a last resort.
@@ -370,25 +346,22 @@ def sudo_remove_directory(path: Path, allowed_bases: Optional[list] = None) -> b
         logger.error(f"Safe removal helper not found: {helper_script}")
         return False
 
+    bash_path = _shutil.which('bash') or '/bin/bash'
+
     try:
-        for bash_path in _sudo_bash_candidates():
-            result = subprocess.run(
-                ['sudo', '-n', bash_path, str(helper_script), str(resolved)],
-                capture_output=True,
-                text=True,
-                timeout=30
-            )
-            if result.returncode == 0 and not resolved.exists():
-                logger.info(f"Successfully removed {path} via sudo helper")
-                return True
-            # Only a refused command line is worth another bash path; if the
-            # helper itself ran and failed, a retry would just repeat it.
-            if result.returncode == 0 or not any(
-                    phrase in (result.stderr or '') for phrase in SUDO_REFUSAL_PHRASES):
-                break
-        stderr = (result.stderr or '').strip()
-        logger.error(f"sudo helper failed for {path}: {stderr}")
-        return False
+        result = subprocess.run(
+            ['sudo', '-n', bash_path, str(helper_script), str(resolved)],
+            capture_output=True,
+            text=True,
+            timeout=30
+        )
+        if result.returncode == 0 and not resolved.exists():
+            logger.info(f"Successfully removed {path} via sudo helper")
+            return True
+        else:
+            stderr = result.stderr.strip()
+            logger.error(f"sudo helper failed for {path}: {stderr}")
+            return False
     except subprocess.TimeoutExpired:
         logger.error(f"sudo helper timed out for {path}")
         return False
@@ -440,10 +413,16 @@ def install_requirements_file(req_file: Path, timeout: int = 300) -> subprocess.
     wrapper = project_root / "scripts" / "fix_perms" / "safe_pip_install.sh"
 
     if wrapper.exists():
-        # See _sudo_bash_candidates for why bash is invoked by explicit path
-        # and why there is more than one to try.
+        # See sudo_remove_directory / configure_web_sudo.sh for why bash must
+        # be invoked with an explicit, known path rather than relying on the
+        # wrapper's shebang: sudoers matches the exact command line.
+        bash_candidates = []
+        for candidate in ("/usr/bin/bash", "/bin/bash", _shutil.which("bash")):
+            if candidate and candidate not in bash_candidates:
+                bash_candidates.append(candidate)
+
         result = None
-        for bash_path in _sudo_bash_candidates():
+        for bash_path in bash_candidates:
             # bash_path and wrapper are fixed, known-good paths, and
             # safe_pip_install.sh independently re-validates req_file is an
             # allowed requirements.txt before installing anything as root.

src/common/render_gate.py

@@ -1,238 +0,0 @@
-"""Let a background thread run Python only while the render thread waits on vsync.
-
-With plugin rendering moved to Vegas's prefetch thread (DisplayManager.offscreen,
-#630) the render thread no longer stops for it, but it still shares the GIL
-with it. The render thread spends most of each refresh inside SwapOnVSync,
-which releases the GIL, and needs it back the moment the swap returns. If the
-prefetch thread is running Python right then, the render thread waits: up to
-the switch interval (5ms) behind bytecode, and for as long as a C call that
-keeps the GIL takes. On hdpi that showed up as frames 2-5 refreshes late while
-a group was being prepared.
-
-The gate turns that around. The display manager opens it just before each swap,
-with a deadline shortly ahead of the refresh the swap will return on, and
-closes it when the swap returns. A thread inside ``gate.yielding()`` checks it on
-every Python and C call through a profile hook, and once the window has closed
-it parks -- blocked on a condition, GIL released -- until the next swap opens
-it. The render thread then finds the GIL free when its refresh arrives, and the
-background work runs in time the render thread was only spending waiting.
-
-Parking a thread is only safe if nothing the render thread needs is stuck
-behind it, so it is never parked:
-
-* while it holds a lock registered with ``guard()`` (the Vegas buffers and
-  caches the render thread also takes);
-* inside logging, threading, importlib or the cache, all of which take locks the
-  render thread can take too;
-* when there is no render loop to protect -- no swap for ``STALE_SECONDS``, as
-  on a static screen or a stalled frame.
-
-And a parked thread is never held more than ``MAX_WAIT_SECONDS`` at a time, so
-whatever the gate gets wrong costs a frame, not a freeze. The render thread
-itself is never gated, whatever it calls.
-
-It gates the prefetch thread only. Gating the ESPN fetch threads as well was
-tried for the hourly sports refresh, twenty-odd of them at once, and measured
-worse on hdpi (0.85% late frames without it, 1.14% with it, across a burst every
-five minutes): each parked thread has to take the GIL again just to park at the
-end of every window, and the fetches ran two to three times as long.
-
-"""
-
-from __future__ import annotations
-
-import math
-import sys
-import threading
-import time
-from collections import deque
-from typing import Any, Callable, Deque, List, Optional, cast
-
-from src.common.frame_timing import binding_releases_gil
-
-#: Park background threads this long before the refresh a swap will return on,
-#: so a short C call already under way has finished by then.
-MARGIN_SECONDS = 0.002
-
-#: The longest a background thread is parked in one go.
-MAX_WAIT_SECONDS = 0.05
-
-#: No swap for this long means there is no render loop running to protect.
-STALE_SECONDS = 0.05
-
-#: Swaps needed before the refresh period is trusted enough to open a window.
-MIN_SAMPLES = 8
-
-#: Parking inside any of these modules could hold a lock the render thread
-#: takes: logging handler locks, Condition and Event internals, the module
-#: import locks, and the disk and memory cache locks. Matched by module name,
-#: not file path: a path can say "cache" or "logging" for reasons of its own --
-#: a virtualenv under ~/.cache, or GitHub's /opt/hostedtoolcache, where every
-#: stdlib frame would otherwise count and the gate would never park anything.
-_UNSAFE_MODULES = frozenset({
-    "logging", "threading", "importlib", "src.cache_manager", "src.cache",
-})
-_UNSAFE_PREFIXES = ("logging.", "importlib.", "_frozen_importlib", "src.cache.")
-
-
-def _unsafe(frame: Any, base: Any) -> bool:
-    """True if a frame above ``base`` comes from somewhere parking could deadlock.
-
-    ``base`` is the frame that entered ``yielding()``; what lies below it (the
-    thread's own bootstrap in threading.py) holds nothing.
-    """
-    while frame is not None and frame is not base:
-        name = frame.f_globals.get("__name__") or ""
-        if name in _UNSAFE_MODULES or name.startswith(_UNSAFE_PREFIXES):
-            return True
-        frame = frame.f_back
-    return False
-
-
-def swap_releases_gil() -> Optional[bool]:
-    """Whether the loaded rgbmatrix binding releases the GIL, or None if none is loaded.
-
-    A thin delegate to src.common.frame_timing.binding_releases_gil (#629),
-    which this used to duplicate line for line. The name stays because the
-    coordinator calls it here and tests replace it here.
-    """
-    return binding_releases_gil()
-
-
-def _held(lock: Any) -> bool:
-    """Is ``lock`` held? RLocks report this thread's ownership; plain locks, anyone's."""
-    is_owned = getattr(lock, "_is_owned", None)
-    if is_owned is not None:
-        return cast(bool, is_owned())
-    return cast(bool, lock.locked())
-
-
-class RenderGate:
-    """Opened by the render thread around each swap; honoured by background threads."""
-
-    def __init__(self, clock: Callable[[], float] = time.monotonic):
-        self.clock = clock
-        self._cond = threading.Condition()
-        self._generation = 0
-        self._open_until = 0.0
-        self._last_return: Optional[float] = None
-        self._periods: Deque[float] = deque(maxlen=64)
-        self._period: Optional[float] = None
-        self._guarded: List[Any] = []
-        self._local = threading.local()
-        self._render_ident: Optional[int] = None
-        #: How often, and for how long in all, background threads were parked.
-        self.parks = 0
-        self.parked_seconds = 0.0
-
-    def guard(self, *locks: Any) -> None:
-        """Never park a thread while it holds (or, for a plain Lock, anyone holds) these."""
-        self._guarded.extend(lock for lock in locks if lock is not None)
-
-    # -- render thread -----------------------------------------------------
-
-    def refresh_period(self) -> Optional[float]:
-        """The panel's refresh period from recent swaps, or None until known.
-
-        The 10th percentile of the gaps between swap returns, each divided by
-        the hold: a late frame only ever lengthens a gap, so the low end is
-        the panel's own period.
-        """
-        return self._period
-
-    def before_swap(self, hold: int) -> None:
-        """The render thread is about to block in SwapOnVSync: open the window."""
-        hold = max(1, int(hold))
-        period = self._period
-        now = self.clock()
-        last = self._last_return
-        if period and last is not None and now - last < STALE_SECONDS:
-            # The swap returns on the first refresh boundary after both the
-            # current frame's hold is up and this frame has been handed over;
-            # boundaries fall a whole period apart from the last return.
-            refreshes = max(hold, math.ceil((now - last) / period))
-            open_until = last + refreshes * period - MARGIN_SECONDS
-        else:
-            open_until = 0.0     # no rhythm to predict from: leave threads be
-        with self._cond:
-            self._open_until = open_until
-            self._generation += 1
-            self._cond.notify_all()
-
-    def after_swap(self, hold: int) -> None:
-        """The swap returned and the render thread needs the GIL: close the window."""
-        now = self.clock()
-        self._open_until = 0.0
-        if self._render_ident is None:
-            # The first thread to swap is the render loop. A plugin pushing a
-            # live refresh from its update thread swaps too, but must not take
-            # over its exemption.
-            self._render_ident = threading.get_ident()
-        last = self._last_return
-        if last is not None and now - last < STALE_SECONDS:
-            self._periods.append((now - last) / max(1, int(hold)))
-            if len(self._periods) >= MIN_SAMPLES:
-                ordered = sorted(self._periods)
-                self._period = ordered[len(ordered) // 10]
-        self._last_return = now
-
-    # -- background threads ------------------------------------------------
-
-    def _should_park(self, frame: Any, now: float) -> bool:
-        if now < self._open_until:
-            return False                 # inside the window
-        last = self._last_return
-        if last is None or now - last > STALE_SECONDS or self._period is None:
-            return False                 # no render loop to protect
-        for lock in self._guarded:
-            if _held(lock):
-                return False
-        return not _unsafe(frame, getattr(self._local, "base", None))
-
-    def _hook(self, frame: Any, _event: str, _arg: Any) -> None:
-        now = self.clock()
-        if not self._should_park(frame, now):
-            return
-        generation = self._generation
-        with self._cond:
-            self._cond.wait_for(lambda: self._generation != generation,
-                                timeout=MAX_WAIT_SECONDS)
-        self.parks += 1
-        self.parked_seconds += self.clock() - now
-
-    def yielding(self) -> "_Yielding":
-        """``with gate.yielding():`` runs the block giving way to the render thread."""
-        return _Yielding(self)
-
-
-class _Yielding:
-    """Installs a gate's profile hook on the thread for the length of a block."""
-
-    def __init__(self, gate: RenderGate):
-        self.gate = gate
-        self._previous: Any = None
-        self._previous_base: Any = None
-        self._skipped = False
-
-    def __enter__(self) -> RenderGate:
-        gate = self.gate
-        # pylint: disable=protected-access
-        if threading.get_ident() == gate._render_ident:
-            self._skipped = True        # parking the render thread parks the display
-            return gate
-        local = gate._local
-        self._previous_base = getattr(local, "base", None)
-        if self._previous_base is None:
-            # Nested blocks keep the outermost frame, so everything the thread
-            # entered since it first gave way is still checked for locks.
-            local.base = sys._getframe(1)
-        self._previous = sys.getprofile()
-        sys.setprofile(gate._hook)
-        return gate
-
-    def __exit__(self, *_exc: Any) -> None:
-        if self._skipped:
-            return
-        sys.setprofile(self._previous)
-        self.gate._local.base = self._previous_base  # pylint: disable=protected-access
-

src/common/scroll_config.py

@@ -49,9 +49,7 @@ from __future__ import annotations
 
 import logging
 from dataclasses import dataclass, replace
-from typing import Any, Dict, List, Optional, cast
-
-from src.matrix_support import DEFAULT_REFRESH_LIMIT_HZ
+from typing import Any, Dict, Optional
 
 logger = logging.getLogger(__name__)
 
@@ -65,9 +63,8 @@ MIN_PIXELS_PER_SECOND = 1.0
 MAX_PIXELS_PER_SECOND = 500.0
 
 #: Assumed refresh when the caller does not say. Matches the usual
-#: ``display.hardware.limit_refresh_rate_hz``, and is the cap DisplayManager
-#: applies when that key is missing.
-DEFAULT_REFRESH_HZ = float(DEFAULT_REFRESH_LIMIT_HZ)
+#: ``display.hardware.limit_refresh_rate_hz``.
+DEFAULT_REFRESH_HZ = 100.0
 
 #: How far px/s may sit from a whole number of pixels per refresh before it is
 #: worth warning about. 0.05px per frame is invisible; a third of a pixel is not.
@@ -132,14 +129,14 @@ def crisp_ladder(
     refresh_hz: float = DEFAULT_REFRESH_HZ,
     max_frame_hold: int = MAX_FRAME_HOLD,
     max_pixels_per_frame: int = MAX_PIXELS_PER_FRAME,
-) -> List[CrispSpeed]:
+):
     """Every whole-pixel speed this panel can show, slowest first.
 
     Duplicates are collapsed keeping the gentlest option: 100 px/s is reachable
     as 1px every refresh or 2px every 2nd refresh, and the former moves in
     smaller increments, so that is the one worth offering.
     """
-    best: Dict[float, CrispSpeed] = {}
+    best = {}
     for hold in range(1, max_frame_hold + 1):
         for ppf in range(1, max_pixels_per_frame + 1):
             pps = refresh_hz / hold * ppf
@@ -434,8 +431,7 @@ def configure(
     # they start scrolling. configure() only reports what is needed.
 
     if choice:
-        # Set whenever there is a crisp choice (see the replace() above).
-        requested = cast(float, settings.requested_pixels_per_second)
+        requested = settings.requested_pixels_per_second
         if abs(requested - applied) > 0.05:
             log.info(
                 "Scroll configured: %s (asked for %.1f px/s from %s; "

src/common/scroll_helper.py

@@ -238,9 +238,20 @@ class ScrollHelper:
         self.cached_image = full_image
         # Convert to numpy array for fast operations
         self.cached_array = np.array(full_image)
+        
+        # Use actual image width instead of calculated width to ensure accuracy
+        # This fixes cases where width calculation doesn't match actual positioning
         actual_image_width = full_image.width
         self.total_scroll_width = actual_image_width
         
+        # Log if there's a mismatch (indicating a bug in width calculation)
+        if actual_image_width != total_width:
+            self.logger.warning(
+                "Width calculation mismatch: calculated=%dpx, actual=%dpx (diff=%dpx). "
+                "Using actual width for scroll calculations.",
+                total_width, actual_image_width, abs(actual_image_width - total_width)
+            )
+        
         self.scroll_position = 0.0
         self.total_distance_scrolled = 0.0
         self.scroll_complete = False
@@ -254,9 +265,6 @@ class ScrollHelper:
         now = time.time()
         self.scroll_start_time = now
         self.last_progress_log_time = now
-        # The position just went back to 0; the first update must not advance
-        # it by however long the helper sat idle (off-screen) before this.
-        self.last_update_time = now
         self.logger.info(
             "Dynamic duration target set to %ds (min=%ds, max=%ds, buffer=%.2f)",
             self.calculated_duration,
@@ -331,8 +339,10 @@ class ScrollHelper:
             # gained. This is what the one visibly smooth scroller on the
             # hardware (the stock ticker) was already doing by virtue of never
             # enabling frame-based mode.
-            # set_scroll_delay clamps scroll_delay to at least 0.001.
-            pixels_per_second = self.scroll_speed / self.scroll_delay
+            if self.scroll_delay > 0:
+                pixels_per_second = self.scroll_speed / self.scroll_delay
+            else:
+                pixels_per_second = self.scroll_speed * 100.0
             pixels_to_move = pixels_per_second * delta_time
             self.last_step_time = current_time
         else:
@@ -343,11 +353,11 @@ class ScrollHelper:
         self.scroll_position += pixels_to_move
         self.total_distance_scrolled += pixels_to_move
         
-        # One pass is total_scroll_width. With the default lead_gap the strip
-        # starts with display_width of blank, so by then the last item has
-        # fully left the panel; a caller passing a smaller lead_gap (Vegas)
-        # decides for itself where its cycle ends. Adding display_width here
-        # caused 1-2 extra wrap-arounds on wide chains.
+        # Calculate required total distance: total_scroll_width only.
+        # The image already includes display_width pixels of blank padding at the start
+        # (added by create_scrolling_image), so once scroll_position reaches
+        # total_scroll_width the last card has fully scrolled off the left edge.
+        # Adding display_width here would cause 1-2 extra wrap-arounds on wide chains.
         required_total_distance = self.total_scroll_width
 
         # Guard: zero-width content has nothing to scroll — keep position at 0 and skip
@@ -404,6 +414,7 @@ class ScrollHelper:
             and current_time - self.last_progress_log_time >= self.progress_log_interval
         ):
             elapsed_time = current_time - (self.scroll_start_time or current_time)
+            # The image already includes display_width padding, so we only need total_scroll_width
             required_total_distance = self.total_scroll_width
             # Progress telemetry, emitted every few seconds for the whole of
             # every scroll. It says how far along a marquee is, which is what
@@ -450,8 +461,10 @@ class ScrollHelper:
         """
         Linear blend between the frames at ``start_x`` and ``start_x + 1``.
 
-        Implemented with numpy rather than scipy.ndimage.shift, which is not
-        installed on the target devices.
+        Implemented with numpy rather than scipy.ndimage.shift: scipy is not
+        installed on the target devices, and the old scipy-based sub-pixel path
+        was dead code -- get_visible_portion never consulted the flag. The scipy
+        import was removed with it; installing scipy has no effect.
 
         Args:
             start_x: Left column of the earlier of the two frames
@@ -558,16 +571,22 @@ class ScrollHelper:
             return self.min_duration
         
         try:
-            # The strip's width plus one more screen, so the duration covers
-            # the last item leaving the panel even when the strip has less
-            # than display_width of lead-in blank (lead_gap).
+            # Calculate total scroll distance needed
+            # The image already includes display_width padding at the start, so we need
+            # to scroll total_scroll_width pixels to show all content, plus display_width
+            # more pixels to ensure the last content scrolls completely off the screen
             total_scroll_distance = self.total_scroll_width + self.display_width
             
             # Calculate effective pixels per second based on scrolling mode
             if self.frame_based_scrolling:
-                # Frame-based mode: scroll_speed is pixels per scroll_delay
-                # seconds, and set_scroll_delay keeps scroll_delay >= 0.001.
-                pixels_per_second = self.scroll_speed / self.scroll_delay
+                # Frame-based mode: scroll_speed is pixels per frame, scroll_delay is seconds per frame
+                # Effective pixels per second = pixels per frame / seconds per frame
+                if self.scroll_delay > 0:
+                    pixels_per_second = self.scroll_speed / self.scroll_delay
+                else:
+                    # Fallback if scroll_delay is invalid
+                    pixels_per_second = self.scroll_speed * 50  # Assume 50 FPS default
+                    self.logger.warning("Invalid scroll_delay (%s), using fallback calculation", self.scroll_delay)
                 scroll_mode_str = "frame-based"
             else:
                 # Time-based mode: scroll_speed is already pixels per second
@@ -779,18 +798,6 @@ class ScrollHelper:
             self.clear_cache()
             return
         
-        # Every frame is cut from cached_array with Image.frombytes('RGB', ...),
-        # which reads a 4-channel (RGBA) array as garbage and raises on a
-        # 1-channel (L) one. Transparent pixels go to black, the panel's
-        # background, rather than to whatever colour hides under the alpha.
-        if image.mode != 'RGB':
-            if 'A' in image.mode or 'transparency' in image.info:
-                rgba = image.convert('RGBA')
-                image = Image.new('RGB', rgba.size, (0, 0, 0))
-                image.paste(rgba, (0, 0), rgba)
-            else:
-                image = image.convert('RGB')
-
         # Set the cached image
         self.cached_image = image
         
@@ -817,9 +824,6 @@ class ScrollHelper:
         self.scroll_start_time = now
         self.last_progress_log_time = now
         self.last_step_time = now  # Initialize step timer for frame-based scrolling
-        # The position just went back to 0; the first update must not advance
-        # it by however long the helper sat idle before this image arrived.
-        self.last_update_time = now
         
         self.logger.debug("Set scrolling image: %dx%d, total_scroll_width=%d", 
                          image.width, image.height, self.total_scroll_width)
@@ -1068,6 +1072,7 @@ class ScrollHelper:
         Returns:
             Dictionary with scroll state information
         """
+        # The image already includes display_width padding, so we only need total_scroll_width
         required_total_distance = self.total_scroll_width if self.total_scroll_width > 0 else 0
         return {
             'scroll_position': self.scroll_position,

src/common/snapshot_policy.py

@@ -5,7 +5,7 @@ serves two consumers with different needs:
 
 - The web UI's live preview (SSE reader in web_interface/app.py) wants
   fresh frames — but only while a browser is actually watching.
-- The health check (web_interface/blueprints/api_v3/misc.py, hardware status)
+- The health check (web_interface/blueprints/api_v3.py, hardware status)
   uses the file's AGE as a liveness proxy: age >= 60s reads as degraded.
 
 PNG-encoding every frame at 5 fps forever — identical frames, no viewers —
@@ -27,7 +27,7 @@ Policy:
   TOUCH_INTERVAL so the health check (60s threshold) never degrades.
 
 If any constant here changes, re-check the health threshold in
-api_v3/misc.py (get_hardware_status) — TOUCH_INTERVAL must stay well under it.
+api_v3.py (get_hardware_status) — TOUCH_INTERVAL must stay well under it.
 """
 
 from enum import Enum
@@ -37,7 +37,7 @@ VIEWER_INTERVAL = 0.2
 # Snapshot cadence with no viewers — cheap freshness for page-open (seconds).
 IDLE_INTERVAL = 30.0
 # Max age of the last write/touch before bumping mtime for the health
-# check. MUST stay well under get_hardware_status's 60s degraded threshold.
+# check. MUST stay well under api_v3's 60s degraded threshold.
 TOUCH_INTERVAL = 20.0
 # A viewer marker older than this no longer counts as a live viewer.
 VIEWER_MARKER_FRESH_SEC = 5.0

src/common/sports_card.py

@@ -101,10 +101,11 @@ def element_color(config: Optional[Dict[str, Any]], element: str,
                   mode: Optional[str] = None):
     """Per-element text colour from customization.<element>.text_color.
 
-    Delegates to src.element_style.element_color, which also resolves the
-    element under the names plugins actually use (the layout block says
-    `score` where the style block says `score_text`) and honours a per-mode
-    override. Hex strings are accepted.
+    Delegated rather than reimplemented: there were two copies of this
+    read and three of the offset read, and the shared one also resolves
+    the element under the names plugins actually use (the layout block
+    says `score` where the style block says `score_text`) and honours a
+    per-mode override. Hex strings are still accepted.
     """
     from src.element_style import element_color as _shared
     return _shared(config, element, default, mode)
@@ -124,11 +125,12 @@ def resolve_font_color(config: Optional[Dict[str, Any]],
     One object can legitimately belong to several elements -- a size resolver
     can land two of them on the same face, and a BDF face cannot be un-shared
     at all because ``freetype.Face`` objects cannot be rebuilt from a path.
-    Ambiguity is therefore narrowed before it is given up on: among the
+    Those draws used to go out white, which is how an element rendered in any
+    of the 32 shipped bitmap fonts could silently lose a colour the user had
+    set. So ambiguity is now narrowed before it is given up on: among the
     elements sharing a face, a single configured colour is the only thing the
     user can have meant, and several that agree mean the same thing. Only a
-    genuine disagreement falls back to *default* -- otherwise an element
-    drawn in any of the shipped bitmap fonts could lose a colour the user set.
+    genuine disagreement falls back to *default*.
 
     The element vocabulary is a parameter because the two callers disagree
     about it -- the mixin's map says ``team_text`` where this module's says
@@ -144,8 +146,7 @@ def resolve_font_color(config: Optional[Dict[str, Any]],
         if len(matches) > 1:
             configured = []
             for element in matches:
-                # None as the default makes it come back when unconfigured.
-                colour = element_color(config, element, None, mode)  # type: ignore[arg-type]
+                colour = element_color(config, element, None, mode)
                 if colour is not None and colour not in configured:
                     configured.append(colour)
             if len(configured) == 1:
@@ -338,18 +339,6 @@ def format_game_date(config: Optional[Dict[str, Any]], logger, date_text: str,
     if not raw:
         return ""
     fmt = str(scroll_card_option(config, "date_format", "abbrev") or "abbrev")
-    return _format_date_as(fmt, raw, lambda: weekday_for(config, logger, game))
-
-
-def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR) -> str:
-    """Render a stripped, non-empty "M/D" *raw* in style *fmt*.
-
-    The body both date formatters share. They differ in which setting names the
-    style and in which zone the weekday is taken from (see
-    ``SportsCoreSharedMixin._format_game_date``), so those arrive as arguments:
-    *weekday* is a zero-argument callable, only called for the "weekday" style.
-    *months* lets the mixin keep reading its (overridable) ``_MONTH_ABBR``.
-    """
     if fmt == "numeric":
         return raw
     parts = raw.replace("-", "/").split("/")
@@ -358,14 +347,14 @@ def _format_date_as(fmt: str, raw: str, weekday, months=MONTH_ABBR) -> str:
     month, day = int(parts[0]), int(parts[1])
     if not 1 <= month <= 12:
         return raw
-    name = months[month - 1]
+    name = MONTH_ABBR[month - 1]
     if fmt == "numeric_day_first":
         return f"{day}/{month}"
     if fmt == "day_first":
         return f"{day} {name}"
     if fmt == "weekday":
-        day_name = weekday()
-        return f"{day_name} {name} {day}" if day_name else f"{name} {day}"
+        weekday = weekday_for(config, logger, game)
+        return f"{weekday} {name} {day}" if weekday else f"{name} {day}"
     return f"{name} {day}"
 
 
@@ -399,29 +388,6 @@ def format_game_time(config: Optional[Dict[str, Any]], time_text: str) -> str:
 _SCHEMA_FONT_SIZE_CACHE: Dict[str, Dict[str, int]] = {}
 
 
-def _read_schema_font_sizes(schema_path: str) -> Dict[str, int]:
-    """``{element: font_size default}`` from a config_schema.json. Raises.
-
-    The parse both schema-default lookups share. Each keeps its own cache --
-    this function per schema path, ``SportsCoreSharedMixin._schema_font_size``
-    per class -- because the lifetimes differ: a class is rebuilt when the
-    display service reloads a plugin, a module-level path cache is not. One
-    cache would change when a reloaded plugin sees an edited schema.
-    """
-    import json
-    with open(schema_path) as fh:
-        schema = json.load(fh)
-    props = (schema.get('properties', {})
-                   .get('customization', {})
-                   .get('properties', {}))
-    sizes: Dict[str, int] = {}
-    for key, spec in props.items():
-        size = spec.get('properties', {}).get('font_size', {}).get('default')
-        if size is not None:
-            sizes[key] = int(size)
-    return sizes
-
-
 def schema_font_size(schema_path: str, element_key) -> Optional[int]:
     """The font_size this plugin's config_schema.json declares, or None.
 
@@ -433,8 +399,18 @@ def schema_font_size(schema_path: str, element_key) -> Optional[int]:
         return None
     cache = _SCHEMA_FONT_SIZE_CACHE.get(schema_path)
     if cache is None:
+        cache = {}
         try:
-            cache = _read_schema_font_sizes(schema_path)
+            import json
+            with open(schema_path) as fh:
+                schema = json.load(fh)
+            props = (schema.get('properties', {})
+                           .get('customization', {})
+                           .get('properties', {}))
+            for key, spec in props.items():
+                size = spec.get('properties', {}).get('font_size', {}).get('default')
+                if size is not None:
+                    cache[key] = int(size)
         except Exception as exc:
             # See sports_shared._schema_font_size: an unreadable schema
             # silently disables the pixel-grid snap for every element.
@@ -468,7 +444,7 @@ def resolve_font_size(schema_path: str, element_config, element_key,
     return crisp_size(font_name, default_size, aliases, grid_table)
 
 
-def unshare_element_fonts(logger, fonts, element_for_font=None):
+def unshare_element_fonts(logger, fonts):
     """Give each colourable element its own face object.
 
     The colour a draw gets is resolved from the face it was handed, and
@@ -482,20 +458,14 @@ def unshare_element_fonts(logger, fonts, element_for_font=None):
     with identical metrics, so nothing about the rendering changes; only
     the ability to tell two elements apart does. Faces that cannot be
     rebuilt (a BDF loaded through freetype.Face, anything without a usable
-    path) are left shared; resolve_font_color then picks their colour.
-
-    *element_for_font* names the font keys to consider, in order (the first
-    holder of a face keeps it); it defaults to this module's
-    :data:`ELEMENT_FOR_FONT`. ``SportsCoreSharedMixin`` passes its own map,
-    which names different keys -- see ``resolve_font_color`` for why the two
-    vocabularies are kept apart.
+    path) are left shared, and their draws stay white as before.
     """
-    # Looked up at call time so tests can spy on the pinned loader.
-    from src.common.font_layout import load_truetype
-    if element_for_font is None:
-        element_for_font = ELEMENT_FOR_FONT
+    try:
+        from src.common.font_layout import load_truetype as _load
+    except ImportError:  # pragma: no cover
+        return fonts
     seen = {}
-    for key in element_for_font:
+    for key in ELEMENT_FOR_FONT:
         font = fonts.get(key)
         if font is None:
             continue
@@ -506,7 +476,7 @@ def unshare_element_fonts(logger, fonts, element_for_font=None):
         if not path or not size:
             continue
         try:
-            fonts[key] = load_truetype(path, size)
+            fonts[key] = _load(path, size)
         except (OSError, ValueError, TypeError):
             logger.debug(
                 "Could not un-share the %s face; it keeps the default colour", key)