fix(wifi): address four review findings in wifi_manager.py

IP parsing (line 476): use partition(':') so bare "ip/mask" lines
(no field-label prefix) are handled without IndexError; falls back to
the full string when no ':' is present before splitting on '/'.

AP-mode override comment (line 503): add one-line explanation above
the wifi_connected/ssid/ip_address clear so maintainers know why the
fields are reset while wlan0 reports as "connected".

Stale force-flag cleanup (__init__): remove a left-over
_FORCE_AP_FLAG_PATH from a prior crash on first instantiation per
process (guarded by class-level _startup_cleanup_done so the nmcli
AP-state check only runs once, not on every per-request instantiation).

Force-flag logging (enable_ap_mode): log at debug when force=True is
applied, log success at debug and failure with OSError details at
warning for both the hostapd and nmcli hotspot paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

.codacy.yml

@@ -1,7 +0,0 @@
----
-exclude_paths:
-  - "plugin-repos/**"
-  - "plugins/**"
-  - "assets/**"
-  - "test/**"
-  - "scripts/debug/**"

docs/widget-guide.md

@@ -10,98 +10,6 @@ The LEDMatrix Widget Registry system allows plugins to use reusable UI component
 
 ## Available Core Widgets
 
-### Plugin File Manager Widget (`plugin-file-manager`)
-
-Full inline file management UI for plugins that manage files via the `web_ui_actions` system. Renders a card grid, upload zone, create/delete modals, and an entry table editor — entirely inline, no iframe.
-
-`plugin_id` is **automatically injected** from template context. File operations call `/api/v3/plugins/action` immediately on user action; no Save Configuration needed.
-
-**Schema Configuration:**
-```json
-{
-  "file_manager": {
-    "type": "null",
-    "title": "Data Files",
-    "x-widget": "plugin-file-manager",
-    "x-widget-config": {
-      "actions": {
-        "list":   "list-files",
-        "get":    "get-file",
-        "save":   "save-file",
-        "upload": "upload-file",
-        "delete": "delete-file",
-        "create": "create-file",
-        "toggle": "toggle-category"
-      },
-      "upload_hint":      "JSON files with day numbers 1–365 as keys",
-      "directory_label":  "my_data/",
-      "create_fields": [
-        { "key": "category_name", "label": "Category Name",
-          "placeholder": "e.g., my_words", "pattern": "^[a-z0-9_]+$",
-          "hint": "Lowercase letters, numbers, underscores" },
-        { "key": "display_name", "label": "Display Name",
-          "placeholder": "e.g., My Words", "hint": "Optional" }
-      ]
-    }
-  }
-}
-```
-
-**`list` is required** — the widget calls it on render to populate the file grid; omitting it leaves the widget stuck in a loading state. All other actions are optional — omit any key to hide its UI element (e.g., no `create` = no New File button, no `toggle` = no enable/disable switch).
-
-The edit view auto-detects whether file content is tabular (object-of-objects with uniform keys) and shows a paginated table editor with inline cells. Otherwise falls back to a JSON textarea.
-
-**Used by:** of-the-day
-
----
-
-### Time Picker Widget (`time-picker`)
-
-Single time selection using the browser's native time input. Returns a string in `HH:MM` (24-hour) format. Generic — works in any plugin without configuration.
-
-**Schema Configuration:**
-```json
-{
-  "target_time": {
-    "type": "string",
-    "x-widget": "time-picker",
-    "default": "00:00",
-    "x-options": {
-      "placeholder": "Select time",
-      "clearable": true
-    }
-  }
-}
-```
-
-**Used by:** countdown
-
----
-
-### File Upload Single Widget (`file-upload-single`)
-
-Single-image upload for string fields. Uploads to the plugin's asset folder (`assets/plugins/<plugin_id>/uploads/`) and sets the string field value to the returned relative path. Shows a thumbnail preview and a clear button. The `plugin_id` is **automatically injected** from the template context — no need to specify it in the schema.
-
-**Schema Configuration:**
-```json
-{
-  "image_path": {
-    "type": "string",
-    "x-widget": "file-upload-single",
-    "x-upload-config": {
-      "allowed_types": ["image/png", "image/jpeg", "image/bmp", "image/gif"],
-      "max_size_mb": 5
-    }
-  }
-}
-```
-
-Note: Unlike `file-upload` (array-level), this widget is for a single `string` field. It is ideal for per-item images inside `array-table` rows.
-
-**Used by:** countdown
-
----
-
 ### File Upload Widget (`file-upload`)
 
 Upload and manage image files with drag-and-drop support, preview, delete, and scheduling.

plugin-repos/starlark-apps/manifest.json

@@ -22,6 +22,5 @@
     "Pillow>=10.0.0",
     "PyYAML>=6.0",
     "requests>=2.31.0"
-  ],
-  "local_only": true
+  ]
 }

src/cache_manager.py

@@ -1,28 +1,3 @@
-"""
-Cache Manager — multi-tier response cache for the LEDMatrix application.
-
-:class:`CacheManager` provides a unified caching layer used by all plugins
-to reduce external API calls and survive network outages gracefully.
-
-Two storage tiers
------------------
-* **Memory tier** (:class:`~src.cache.memory_cache.MemoryCache`): fast LRU
-  cache (up to 1 000 entries by default).  Hit on this tier before touching
-  disk.
-* **Disk tier** (:class:`~src.cache.disk_cache.DiskCache`): filesystem-backed
-  persistent store that survives process restarts.
-
-Data written to cache is serialised as JSON.  :class:`DateTimeEncoder` handles
-``datetime`` objects transparently so callers don't have to pre-serialise them.
-
-Typical plugin usage::
-
-    data = self.cache_manager.get_cached_data('my_key', max_age=300)
-    if data is None:
-        data = fetch_from_api()
-        self.cache_manager.save_cache('my_key', data)
-"""
-
 import json
 import os
 import time
@@ -40,10 +15,7 @@ from src.cache.cache_metrics import CacheMetrics
 from src.logging_config import get_logger
 
 class DateTimeEncoder(json.JSONEncoder):
-    """JSON encoder that serialises ``datetime`` objects as ISO-8601 strings."""
-
     def default(self, obj):
-        """Return ISO-8601 string for datetime; delegate all other types to the base encoder."""
         if isinstance(obj, datetime):
             return obj.isoformat()
         return super().default(obj)

src/common/scroll_helper.py

@@ -347,40 +347,34 @@ class ScrollHelper:
         return self._get_visible_portion_integer(start_x_int, end_x_int)
     
     def _get_visible_portion_integer(self, start_x: int, end_x: int) -> Image.Image:
-        """Fast integer pixel extraction (no interpolation).
-
-        Uses Image.frombytes instead of Image.fromarray: frombytes skips
-        numpy's array-protocol overhead and is ~50% faster for the display-sized
-        slices (128×32 = 12 KB) used here.
-        """
-        _size = (self.display_width, self.display_height)
-        img_w = self.cached_image.width
-
-        if end_x <= img_w:
-            # Normal case: single contiguous slice (fastest path)
-            frame_array = np.ascontiguousarray(self.cached_array[:, start_x:end_x])
-            return Image.frombytes('RGB', _size, frame_array.tobytes())
+        """Fast integer pixel extraction (no interpolation)."""
+        # Fast numpy array slicing for normal case (no wrap-around)
+        if end_x <= self.cached_image.width:
+            # Normal case: single slice - fastest path
+            frame_array = self.cached_array[:, start_x:end_x]
+            # Convert to PIL Image (minimal overhead)
+            return Image.fromarray(frame_array)
         else:
-            # Ensure frame buffer is allocated for all non-simple paths
-            if self._frame_buffer is None or self._frame_buffer.shape != (self.display_height, self.display_width, 3):
-                self._frame_buffer = np.zeros((self.display_height, self.display_width, 3), dtype=np.uint8)
-
-            width1 = img_w - start_x
+            # Wrap-around case: combine two slices using numpy
+            width1 = self.cached_image.width - start_x
             if width1 > 0:
-                # Wrap-around: tail of image + head of image
+                # Use pre-allocated buffer for output
+                if self._frame_buffer is None or self._frame_buffer.shape != (self.display_height, self.display_width, 3):
+                    self._frame_buffer = np.zeros((self.display_height, self.display_width, 3), dtype=np.uint8)
+                
+                # First part from end of image (fast numpy slice)
                 self._frame_buffer[:, :width1] = self.cached_array[:, start_x:]
+                
+                # Second part from beginning of image
                 remaining_width = self.display_width - width1
                 self._frame_buffer[:, width1:] = self.cached_array[:, :remaining_width]
+                
+                # Convert combined buffer to PIL Image
+                return Image.fromarray(self._frame_buffer)
             else:
-                # Edge case: start_x at or past image end — show from beginning,
-                # clamped to available width (scroll_position should wrap before
-                # reaching this state in normal operation).
-                available = min(self.display_width, img_w)
-                self._frame_buffer[:, :available] = self.cached_array[:, :available]
-                if available < self.display_width:
-                    self._frame_buffer[:, available:] = 0
-
-            return Image.frombytes('RGB', _size, self._frame_buffer.tobytes())
+                # Edge case: start_x >= image width, wrap to beginning
+                frame_array = self.cached_array[:, :self.display_width]
+                return Image.fromarray(frame_array)
     
     def _get_visible_portion_subpixel(self, start_x_int: int, fractional: float) -> Image.Image:
         """

src/config_manager.py

@@ -1,29 +1,3 @@
-"""
-Config Manager — reads, writes, and validates ``config/config.json``.
-
-:class:`ConfigManager` is the single owner of the on-disk configuration
-files:
-
-* ``config/config.json``         — main user-editable configuration.
-* ``config/config_secrets.json`` — sensitive values (API keys, tokens).
-
-All writes go through :class:`~src.config_manager_atomic.AtomicConfigManager`
-which performs a backup before overwriting, validates the result, and rolls
-back on error.  This makes config corruption essentially impossible.
-
-Plugin configuration
---------------------
-Plugin configs are stored inside ``config.json`` under the plugin's ID key
-and survive plugin reinstalls.  Use :meth:`ConfigManager.update_plugin_config`
-to write plugin settings; never write directly to the plugin directory.
-
-Hot-reload
-----------
-:class:`~src.config_service.ConfigService` wraps ``ConfigManager`` and
-detects file changes, broadcasting the new config to registered listeners
-without requiring a restart.
-"""
-
 import json
 import os
 import logging
@@ -43,13 +17,6 @@ from src.common.permission_utils import (
 )
 
 class ConfigManager:
-    """
-    Reads and writes the main application configuration files.
-
-    Wraps :class:`~src.config_manager_atomic.AtomicConfigManager` for safe
-    atomic writes with automatic backup and rollback.  Also exposes helpers
-    for plugin configuration persistence and secret-field masking.
-    """
     def __init__(self, config_path: Optional[str] = None, secrets_path: Optional[str] = None) -> None:
         # Use current working directory as base
         self.config_path: str = config_path or "config/config.json"
@@ -62,11 +29,9 @@ class ConfigManager:
         self._atomic_manager: Optional[AtomicConfigManager] = None
 
     def get_config_path(self) -> str:
-        """Return the path to the main config file (``config/config.json``)."""
         return self.config_path
 
     def get_secrets_path(self) -> str:
-        """Return the path to the secrets file (``config/config_secrets.json``)."""
         return self.secrets_path
     
     def _get_atomic_manager(self) -> AtomicConfigManager:

src/display_controller.py

@@ -1,25 +1,3 @@
-"""
-Display Controller — top-level orchestration for the LEDMatrix application.
-
-This module owns the main run loop that drives the LED display.  It ties
-together every major subsystem:
-
-  - ConfigManager / ConfigService  — loads config.json, hot-reloads on change
-  - DisplayManager                 — hardware (or emulator) output interface
-  - FontManager                    — TTF/BDF font loading and caching
-  - CacheManager                   — multi-tier API response cache
-  - PluginManager                  — plugin lifecycle (load, update, display)
-  - DisplaySyncManager             — optional leader/follower multi-Pi sync
-  - VegasModeCoordinator           — optional continuous Vegas scroll mode
-
-The main loop inside :meth:`DisplayController.run` rotates through enabled
-plugin display modes, respecting schedule windows, brightness dim schedules,
-on-demand overrides, and live-priority interrupts.
-
-Entry point: :func:`main` — instantiates :class:`DisplayController` and calls
-:meth:`~DisplayController.run`.
-"""
-
 import time
 import os
 import json
@@ -50,24 +28,6 @@ DEFAULT_DYNAMIC_DURATION_CAP = 180.0
 WIFI_STATUS_FILE = None  # Will be initialized in __init__
 
 class DisplayController:
-    """
-    Top-level controller that owns the LED display run loop.
-
-    Responsibilities
-    ----------------
-    * Initialise and wire together all subsystems at startup.
-    * Rotate through plugin display modes in :meth:`run`.
-    * Honour schedule windows (active/inactive hours) and dim schedules.
-    * Handle on-demand override requests (external callers can pin a
-      specific plugin/mode for a fixed duration via the cache bus).
-    * Coordinate with a follower Pi when multi-display sync is configured.
-    * Delegate all actual content to the plugin system — this class contains
-      no display logic of its own.
-
-    There is exactly one instance per process; call :func:`main` to create
-    it and start the run loop.
-    """
-
     def __init__(self):
         start_time = time.time()
         logger.info("Starting DisplayController initialization")
@@ -178,11 +138,7 @@ class DisplayController:
         self.on_demand_last_event: Optional[str] = None
         self.on_demand_schedule_override = False
         self.rotation_resume_index: Optional[int] = None
-        # Saved rotation position when a live-priority plugin preempts the
-        # rotation, so it resumes where it left off (not after the live plugin)
-        # once live priority ends.
-        self._live_resume_index: Optional[int] = None
-
+        
         # WiFi status message tracking
         global WIFI_STATUS_FILE
         if WIFI_STATUS_FILE is None:
@@ -192,11 +148,7 @@ class DisplayController:
         self.wifi_status_file = WIFI_STATUS_FILE
         self.wifi_status_active = False
         self.wifi_status_expires_at: Optional[float] = None
-
-        # Plugin display() signature cache — must be initialised before the plugin
-        # loading loop below so the .pop() invalidation at load time is always safe.
-        self._plugin_accepts_display_mode: Dict[str, bool] = {}
-
+        
         try:
             logger.info("Attempting to import plugin system...")
             from src.plugin_system import PluginManager
@@ -369,8 +321,6 @@ class DisplayController:
                             self.plugin_modes[mode] = plugin_instance
                             self.mode_to_plugin_id[mode] = plugin_id
                             logger.debug("  Added mode: %s", mode)
-                        # Invalidate signature cache so the new instance is re-inspected
-                        self._plugin_accepts_display_mode.pop(plugin_id, None)
                         
                         # Show progress
                         progress_pct = int((loaded_count / enabled_count) * 100)
@@ -417,39 +367,11 @@ class DisplayController:
         self.is_display_active = True
         self._was_display_active = True  # Track previous state for schedule change detection
 
-        # --- Opt #2: cached config values ---
-        # Avoids chained dict.get() with temporary {} defaults on every hot path call.
-        # Refreshed via _refresh_config_cache() on every hot-reload.
-        self._normal_brightness: int = (
-            self.config.get('display', {}).get('hardware', {}).get('brightness', 90)
-        )
-        self._scroll_speed: float = (
-            self.config.get('display', {}).get('vegas_scroll', {}).get('scroll_speed', 75)
-        )
-
         # Brightness state tracking for dim schedule
-        self.current_brightness = self._normal_brightness
+        self.current_brightness = self.config.get('display', {}).get('hardware', {}).get('brightness', 90)
         self.is_dimmed = False
         self._was_dimmed = False
 
-        # --- Opt #3: schedule minute-gate ---
-        # Both _check_schedule and _check_dim_schedule re-evaluated at most once per
-        # clock minute.  Storing the (hour, minute) tuple that was last evaluated lets
-        # the methods skip all timezone / strptime work within the same minute.
-        # Reset to None on config change so the next call re-evaluates immediately.
-        self._tz = None                              # pytz timezone, lazily built from config
-        self._schedule_checked_minute: Optional[tuple] = None
-        self._dim_checked_minute: Optional[tuple] = None
-        self._cached_target_brightness: int = self._normal_brightness
-
-        # Register controller-level hot-reload callback so cached config values
-        # (_normal_brightness, _scroll_speed, _tz, minute-gates) stay in sync
-        # when the user saves settings via the web UI.
-        def _controller_config_change(old_config: Dict[str, Any], new_config: Dict[str, Any]) -> None:
-            self._refresh_config_cache(new_config)
-
-        self.config_service.subscribe(_controller_config_change)
-
         # Publish initial on-demand state
         try:
             self._publish_on_demand_state()
@@ -611,24 +533,17 @@ class DisplayController:
             logger.debug("Schedule is disabled - display always active")
             return
 
-        # Lazily build the timezone object once; reuse on every subsequent call.
-        if self._tz is None:
-            timezone_str = self.config.get('timezone', 'UTC')
-            try:
-                self._tz = pytz.timezone(timezone_str)
-            except pytz.UnknownTimeZoneError:
-                logger.warning("Unknown timezone '%s', using UTC", timezone_str)
-                self._tz = pytz.UTC
+        # Get configured timezone, default to UTC
+        timezone_str = self.config.get('timezone', 'UTC')
+        try:
+            tz = pytz.timezone(timezone_str)
+        except pytz.UnknownTimeZoneError:
+            logger.warning(f"Unknown timezone '{timezone_str}', using UTC")
+            tz = pytz.UTC
 
-        current_time = datetime.now(self._tz)
-        # Gate: schedule state can only change on a minute boundary, so skip
-        # all the strptime / comparison work if we already evaluated this minute.
-        current_minute_key = (current_time.hour, current_time.minute)
-        if current_minute_key == self._schedule_checked_minute:
-            return
-        self._schedule_checked_minute = current_minute_key
-
-        current_day = current_time.strftime('%A').lower()  # e.g. 'monday'
+        # Use timezone-aware current time
+        current_time = datetime.now(tz)
+        current_day = current_time.strftime('%A').lower()  # Get day name (monday, tuesday, etc.)
         current_time_only = current_time.time()
         
         # Check if per-day schedule is configured
@@ -717,8 +632,8 @@ class DisplayController:
             Target brightness level (dim_brightness if in dim period,
             normal brightness otherwise)
         """
-        # Opt #2: use cached brightness rather than re-traversing config dict
-        normal_brightness = self._normal_brightness
+        # Get normal brightness from config
+        normal_brightness = self.config.get('display', {}).get('hardware', {}).get('brightness', 90)
 
         # If display is OFF via schedule, don't process dim schedule
         if not self.is_display_active:
@@ -732,21 +647,15 @@ class DisplayController:
             self.is_dimmed = False
             return normal_brightness
 
-        # Opt #3: lazily build timezone; gate full re-parse to once per clock minute
-        if self._tz is None:
-            timezone_str = self.config.get('timezone', 'UTC')
-            try:
-                self._tz = pytz.timezone(timezone_str)
-            except pytz.UnknownTimeZoneError:
-                logger.warning("Unknown timezone '%s' in dim schedule, using UTC", timezone_str)
-                self._tz = pytz.UTC
-
-        current_time = datetime.now(self._tz)
-        current_minute_key = (current_time.hour, current_time.minute)
-        if current_minute_key == self._dim_checked_minute:
-            return self._cached_target_brightness
-        self._dim_checked_minute = current_minute_key
+        # Get configured timezone
+        timezone_str = self.config.get('timezone', 'UTC')
+        try:
+            tz = pytz.timezone(timezone_str)
+        except pytz.UnknownTimeZoneError:
+            logger.warning(f"Unknown timezone '{timezone_str}' in dim schedule, using UTC")
+            tz = pytz.UTC
 
+        current_time = datetime.now(tz)
         current_day = current_time.strftime('%A').lower()
         current_time_only = current_time.time()
 
@@ -794,12 +703,10 @@ class DisplayController:
                 logger.info(f"Dim schedule deactivated: brightness restored to {target_brightness}%")
 
             self._was_dimmed = self.is_dimmed
-            self._cached_target_brightness = target_brightness  # persist for minute-gate
             return target_brightness
 
         except ValueError as e:
-            logger.warning("Invalid dim schedule time format: %s", e)
-            self._cached_target_brightness = normal_brightness  # persist for minute-gate
+            logger.warning(f"Invalid dim schedule time format: {e}")
             return normal_brightness
 
     def _update_modules(self):
@@ -1475,36 +1382,6 @@ class DisplayController:
         except Exception as e:
             logger.debug(f"Error logging memory stats: {e}")
 
-    def _apply_live_priority(self, live_priority_mode):
-        """Switch to a live-priority mode, or resume rotation when it ends.
-
-        When a live-priority plugin preempts the rotation, the position the
-        rotation had reached is saved so that, once live priority ends, the
-        rotation resumes from there instead of continuing after the live
-        plugin's mode (which would skip every mode between the two). The save
-        happens only on the initial switch, not on each re-check while the
-        live hold continues.
-        """
-        if live_priority_mode:
-            if self.current_display_mode != live_priority_mode:
-                logger.info("Live content detected - switching immediately to %s", live_priority_mode)
-                if self._live_resume_index is None:
-                    self._live_resume_index = self.current_mode_index
-                self.current_display_mode = live_priority_mode
-                self.force_change = True
-                # Update mode index to match the new mode
-                try:
-                    self.current_mode_index = self.available_modes.index(live_priority_mode)
-                except ValueError:
-                    pass
-        elif self._live_resume_index is not None and self.available_modes:
-            # Live priority ended — resume rotation where it was interrupted.
-            self.current_mode_index = self._live_resume_index % len(self.available_modes)
-            self.current_display_mode = self.available_modes[self.current_mode_index]
-            self.force_change = True
-            logger.info("Live priority ended - resuming rotation at %s", self.current_display_mode)
-            self._live_resume_index = None
-
     def _check_live_priority(self):
         """
         Check all plugins for live priority content.
@@ -1606,8 +1483,12 @@ class DisplayController:
                     rp = vc.render_pipeline if (vc and vc.render_pipeline) else None
                     width = self.display_manager.width
 
-                    # Opt #2: use pre-cached scroll speed (constant for the run)
-                    vegas_speed = self._scroll_speed
+                    # Advance local position at Vegas scroll speed (px/s → px/tick)
+                    vegas_speed = (
+                        self.config.get('display', {})
+                            .get('vegas_scroll', {})
+                            .get('scroll_speed', 75)
+                    )
                     local_x = getattr(self, '_follower_local_x', None)
                     if local_x is None:
                         local_x = float(width)  # safe start (past pre-roll guard)
@@ -1692,7 +1573,15 @@ class DisplayController:
                 # Check for live priority content and switch to it immediately
                 if not self.on_demand_active and not wifi_status_data:
                     live_priority_mode = self._check_live_priority()
-                    self._apply_live_priority(live_priority_mode)
+                    if live_priority_mode and self.current_display_mode != live_priority_mode:
+                        logger.info("Live content detected - switching immediately to %s", live_priority_mode)
+                        self.current_display_mode = live_priority_mode
+                        self.force_change = True
+                        # Update mode index to match the new mode
+                        try:
+                            self.current_mode_index = self.available_modes.index(live_priority_mode)
+                        except ValueError:
+                            pass
 
                 # Vegas scroll mode - continuous ticker across all plugins
                 # Priority: on-demand > wifi-status > live-priority > vegas > normal rotation
@@ -1739,8 +1628,7 @@ class DisplayController:
 
                 manager_to_display = None
                 
-                logger.info("Processing mode: %s (%d available)", active_mode, len(self.available_modes))
-                logger.debug("Loaded plugin modes: %s", list(self.plugin_modes.keys()))
+                logger.info(f"Processing mode: {active_mode}, available_modes: {len(self.available_modes)}, plugin_modes: {list(self.plugin_modes.keys())}")
                 
                 # Handle plugin-based display modes
                 if active_mode in self.plugin_modes:
@@ -1776,22 +1664,17 @@ class DisplayController:
                     try:
                         logger.debug(f"Calling display() for {active_mode} with force_clear={self.force_change}")
                         if hasattr(manager_to_display, 'display'):
-                            # Opt #1: look up (or compute once) whether display() accepts display_mode
-                            _cache_key = plugin_id
-                            if _cache_key not in self._plugin_accepts_display_mode:
-                                import inspect as _inspect
-                                self._plugin_accepts_display_mode[_cache_key] = (
-                                    'display_mode' in _inspect.signature(manager_to_display.display).parameters
-                                )
-                            _accepts_display_mode = self._plugin_accepts_display_mode[_cache_key]
-
+                            # Check if plugin accepts display_mode parameter
+                            import inspect
+                            sig = inspect.signature(manager_to_display.display)
+                            
                             # Use PluginExecutor for safe execution with timeout
                             if self.plugin_manager and hasattr(self.plugin_manager, 'plugin_executor'):
                                 result = self.plugin_manager.plugin_executor.execute_display(
                                     manager_to_display,
                                     plugin_id,
                                     force_clear=self.force_change,
-                                    display_mode=active_mode if _accepts_display_mode else None
+                                    display_mode=active_mode if 'display_mode' in sig.parameters else None
                                 )
                                 # execute_display returns bool, convert to expected format
                                 if result:
@@ -1800,7 +1683,7 @@ class DisplayController:
                                     result = False  # Failed
                             else:
                                 # Fallback to direct call if executor not available
-                                if _accepts_display_mode:
+                                if 'display_mode' in sig.parameters:
                                     result = manager_to_display.display(display_mode=active_mode, force_clear=self.force_change)
                                 else:
                                     result = manager_to_display.display(force_clear=self.force_change)
@@ -1937,9 +1820,9 @@ class DisplayController:
                     min_duration = base_duration
                     if dynamic_enabled:
                         # Try to get plugin-calculated cycle duration first
-                        logger.debug("Attempting to get cycle duration for mode %s", active_mode)
+                        logger.info("Attempting to get cycle duration for mode %s", active_mode)
                         plugin_cycle_duration = self._plugin_cycle_duration(manager_to_display, active_mode)
-                        logger.debug("Got cycle duration: %s", plugin_cycle_duration)
+                        logger.info("Got cycle duration: %s", plugin_cycle_duration)
                         
                         # Get caps for validation
                         plugin_cap = self._plugin_dynamic_cap(manager_to_display)
@@ -2079,7 +1962,7 @@ class DisplayController:
                         if needs_high_fps:
                             # Ultra-smooth FPS for scrolling plugins (8ms = 125 FPS)
                             display_interval = 0.008
-                            logger.debug(
+                            logger.info(
                                 "Entering high-FPS loop for %s with display_interval=%.3fs (%.1f FPS)",
                                 active_mode,
                                 display_interval,
@@ -2089,7 +1972,7 @@ class DisplayController:
                             while True:
                                 try:
                                     # Pass display_mode to maintain sticky manager state
-                                    if _accepts_display_mode:
+                                    if 'display_mode' in sig.parameters:
                                         result = manager_to_display.display(display_mode=active_mode, force_clear=False)
                                     else:
                                         result = manager_to_display.display(force_clear=False)
@@ -2131,7 +2014,7 @@ class DisplayController:
                         else:
                             # Normal FPS for other plugins (1 second)
                             display_interval = 1.0
-                            logger.debug(
+                            logger.info(
                                 "Entering normal FPS loop for %s with display_interval=%.3fs",
                                 active_mode,
                                 display_interval
@@ -2153,7 +2036,7 @@ class DisplayController:
 
                                 try:
                                     # Pass display_mode to maintain sticky manager state
-                                    if _accepts_display_mode:
+                                    if 'display_mode' in sig.parameters:
                                         result = manager_to_display.display(display_mode=active_mode, force_clear=False)
                                     else:
                                         result = manager_to_display.display(force_clear=False)
@@ -2450,30 +2333,6 @@ class DisplayController:
             self.wifi_status_active = False
             self.wifi_status_expires_at = None
 
-    def _refresh_config_cache(self, new_config: Dict[str, Any]) -> None:
-        """Refresh all config-derived caches when a hot-reload fires.
-
-        Called by the controller-level ConfigService subscriber.  Keeps
-        ``_normal_brightness``, ``_scroll_speed``, the cached timezone, and the
-        schedule minute-gates consistent with the live config so callers never
-        read stale values after the user saves settings via the web UI.
-        """
-        self.config = new_config
-        self._normal_brightness = (
-            self.config.get('display', {}).get('hardware', {}).get('brightness', 90)
-        )
-        self._scroll_speed = (
-            self.config.get('display', {}).get('vegas_scroll', {}).get('scroll_speed', 75)
-        )
-        # Force the timezone to be re-derived from the new config on next schedule check
-        self._tz = None
-        # Invalidate minute-gates so the new schedule/dim times take effect immediately
-        self._schedule_checked_minute = None
-        self._dim_checked_minute = None
-        self._cached_target_brightness = self._normal_brightness
-        logger.debug("Config cache refreshed (brightness=%s, scroll_speed=%s)",
-                     self._normal_brightness, self._scroll_speed)
-
     def cleanup(self):
         """Clean up resources."""
         # Shutdown config service if it exists
@@ -2488,7 +2347,6 @@ class DisplayController:
         logger.info("Cleanup complete.")
 
 def main():
-    """Application entry point — create a DisplayController and run until interrupted."""
     controller = DisplayController()
     controller.run()
 

src/display_manager.py

@@ -1,28 +1,3 @@
-"""
-Display Manager — hardware abstraction layer for the RGB LED matrix.
-
-This module provides :class:`DisplayManager`, the single interface between
-application code and the physical (or emulated) LED panel.
-
-Key responsibilities
---------------------
-* Initialise the ``RGBMatrix`` (hardware) or ``RGBMatrixEmulator`` depending
-  on the ``EMULATOR`` environment variable.
-* Expose a PIL ``Image``/``ImageDraw`` canvas that plugins draw into, then
-  flush it to the matrix via double-buffering (:meth:`DisplayManager.update_display`).
-* Load and cache TTF/BDF fonts; expose ``draw_text`` for consistent text rendering.
-* Provide ``width`` / ``height`` properties — always use these instead of
-  hard-coding display dimensions.
-* Write periodic PNG snapshots to ``/tmp/led_matrix_preview.png`` for the
-  web-interface live preview.
-* Track scrolling state and gate deferred updates so plugins don't race with
-  an in-progress scroll.
-
-Singleton: only one ``DisplayManager`` instance exists per process.  The
-first call to ``DisplayManager(config)`` creates it; subsequent calls return
-the same object.
-"""
-
 import json
 import os
 import tempfile
@@ -43,24 +18,6 @@ logger = logging.getLogger(__name__)
 logger.setLevel(logging.INFO)  # Set to INFO level
 
 class DisplayManager:
-    """
-    Singleton hardware abstraction layer for the RGB LED matrix.
-
-    Plugins should never interact with ``RGBMatrix`` directly; they use this
-    class to draw content and call :meth:`update_display` to push frames to
-    the panel.
-
-    Typical plugin usage::
-
-        canvas = Image.new('RGB', (self.display_manager.width,
-                                   self.display_manager.height), (0, 0, 0))
-        draw = ImageDraw.Draw(canvas)
-        # ... draw content ...
-        self.display_manager.image = canvas
-        self.display_manager.draw = ImageDraw.Draw(self.display_manager.image)
-        self.display_manager.update_display()
-    """
-
     _instance = None
     _initialized = False
 
@@ -76,10 +33,6 @@ class DisplayManager:
         self._suppress_test_pattern = suppress_test_pattern
         # When True, update_display() and clear() skip hardware writes (used during off-screen content capture)
         self._capture_mode_active = False
-        # Text-width measurement cache: (text, id(font)) -> pixel_width
-        # Avoids re-measuring the same string+font on every display() call.
-        # Cleared on _load_fonts() so stale entries don't survive a font reload.
-        self._text_width_cache: Dict[tuple, int] = {}
         # Snapshot settings for web preview integration (service writes, web reads)
         self._snapshot_path = "/tmp/led_matrix_preview.png"  # nosec B108 - fixed path intentional; web UI reads same path
         self._snapshot_min_interval_sec = 0.2  # max ~5 fps
@@ -484,9 +437,6 @@ class DisplayManager:
 
     def _load_fonts(self):
         """Load fonts with proper error handling."""
-        # Font objects get new id()s after reload, so the text-width cache would
-        # return stale measurements keyed on the old ids.  Clear it here.
-        self._text_width_cache.clear()
         try:
             # Load Press Start 2P font
             self.regular_font = ImageFont.truetype("assets/fonts/PressStart2P-Regular.ttf", 8)
@@ -547,32 +497,22 @@ class DisplayManager:
 
 
     def get_text_width(self, text, font):
-        """Get the width of text when rendered with the given font.
-
-        Results are cached by (text, font identity) so plugins that measure
-        the same string every frame (e.g. to centre a score) pay only one
-        measurement per unique (text, font) pair.
-        """
-        cache_key = (text, id(font))
-        cached = self._text_width_cache.get(cache_key)
-        if cached is not None:
-            return cached
-
+        """Get the width of text when rendered with the given font."""
         try:
             if isinstance(font, freetype.Face):
+                # For FreeType faces, calculate width using freetype
                 width = 0
                 for char in text:
                     font.load_char(char)
                     width += font.glyph.advance.x >> 6
+                return width
             else:
+                # For PIL fonts, use textbbox
                 bbox = self.draw.textbbox((0, 0), text, font=font)
-                width = bbox[2] - bbox[0]
-        except (AttributeError, TypeError, ValueError, OSError) as e:
-            logger.error("Error getting text width: %s", e)
-            return 0
-
-        self._text_width_cache[cache_key] = width
-        return width
+                return bbox[2] - bbox[0]
+        except Exception as e:
+            logger.error(f"Error getting text width: {e}")
+            return 0  # Return 0 as fallback
 
     def get_font_height(self, font):
         """Get the height of the given font for line spacing purposes."""

src/font_manager.py

@@ -1,30 +1,3 @@
-"""
-Font Manager — TTF/BDF font loading, caching, and dynamic registration.
-
-:class:`FontManager` serves two purposes:
-
-1. **System fonts** — loads the configured small/medium/large TTF fonts (and
-   their BDF bitmap equivalents) at startup, caches metrics, and exposes them
-   via ``DisplayManager`` attributes (``small_font``, ``medium_font``, etc.).
-
-2. **Plugin fonts** — lets plugins register their own fonts at runtime via
-   :meth:`FontManager.register_manager_font` and resolve them later via
-   :meth:`FontManager.resolve_font`.  Registered fonts are namespaced by
-   plugin ID so they cannot collide.
-
-Font sources
-------------
-* Local paths relative to the project root.
-* Remote URLs — downloaded once, cached to disk, and never re-fetched while
-  the cached copy is fresh.
-
-BDF fallback
-------------
-Pixel-accurate LED fonts are stored as ``.bdf`` (Bitmap Distribution Format)
-files.  When PIL cannot measure BDF glyphs natively, ``freetype-py`` is used
-for accurate width/height calculations.
-"""
-
 import os
 import logging
 import freetype

src/plugin_system/plugin_loader.py

@@ -5,7 +5,6 @@ Handles plugin module imports, dependency installation, and class instantiation.
 Extracted from PluginManager to improve separation of concerns.
 """
 
-import hashlib
 import json
 import importlib
 import importlib.util
@@ -139,98 +138,53 @@ class PluginLoader:
         self,
         plugin_dir: Path,
         plugin_id: str,
-        plugins_dir: Optional[Path] = None,
         timeout: int = 300
     ) -> bool:
         """
         Install plugin dependencies from requirements.txt.
-
+        
         Args:
             plugin_dir: Plugin directory path
             plugin_id: Plugin identifier
-            plugins_dir: Trusted base plugins directory for path containment check
             timeout: Installation timeout in seconds
-
+            
         Returns:
             True if dependencies installed or not needed, False on error
         """
         plugin_id = os.path.basename(plugin_id or '')
         if not plugin_id:
             return False
-
-        # Resolve to a canonical absolute path (normalises .. and symlinks)
-        plugin_dir_real = os.path.realpath(str(plugin_dir))
-
-        if plugins_dir is not None:
-            # Reconstruct the plugin path from a trusted base + a sanitised
-            # directory name.  os.path.basename() is CodeQL's recognised
-            # py/path-injection sanitiser: it strips all directory components
-            # so the result cannot contain traversal sequences.  Joining it
-            # with the resolved, trusted plugins_dir produces a path that
-            # CodeQL considers untainted.
-            plugins_dir_real = os.path.realpath(str(plugins_dir))
-            safe_dir_name = os.path.basename(plugin_dir_real)
-            if not safe_dir_name:
-                self.logger.error("Could not determine plugin directory name for %s", plugin_id)
-                return False
-            safe_plugin_dir = os.path.join(plugins_dir_real, safe_dir_name)
-            if not os.path.isdir(safe_plugin_dir):
-                self.logger.error(
-                    "Plugin directory for %s not found inside plugins dir", plugin_id
-                )
-                return False
-        else:
-            safe_plugin_dir = plugin_dir_real
-            if not os.path.isdir(safe_plugin_dir):
-                self.logger.error("Plugin directory does not exist: %s", plugin_dir)
-                return False
-
-        requirements_file = os.path.join(safe_plugin_dir, "requirements.txt")
-        marker_file = os.path.join(safe_plugin_dir, ".dependencies_installed")
-
-        if not os.path.isfile(requirements_file):
-            return True  # No dependencies needed
-
+        # Resolve and validate plugin_dir before constructing any derived paths
         try:
-            with open(requirements_file, 'rb') as fh:
-                current_hash = hashlib.sha256(fh.read()).hexdigest()
-        except OSError as e:
-            self.logger.error("Failed to read requirements.txt for %s: %s", plugin_id, e)
+            plugin_dir_resolved = plugin_dir.resolve(strict=True)
+        except OSError:
+            self.logger.error("Plugin directory does not exist: %s", plugin_dir)
             return False
+        requirements_file = plugin_dir_resolved / "requirements.txt"
+        if not requirements_file.exists():
+            return True  # No dependencies needed
+        marker_path = plugin_dir_resolved / ".dependencies_installed"
 
-        # Skip if requirements.txt hasn't changed since last install
-        if os.path.isfile(marker_file):
-            try:
-                with open(marker_file, 'r', encoding='utf-8') as fh:
-                    stored_hash = fh.read().strip()
-            except OSError as e:
-                self.logger.warning(
-                    "Could not read dependency marker for %s (%s), will reinstall dependencies",
-                    plugin_id, e
-                )
-            else:
-                if stored_hash == current_hash:
-                    self.logger.debug("Dependencies already installed for %s (requirements unchanged)", plugin_id)
-                    return True
-                self.logger.info("Requirements changed for %s, reinstalling dependencies", plugin_id)
-
+        # Check if already installed
+        if marker_path.exists():
+            self.logger.debug("Dependencies already installed for %s", plugin_id)
+            return True
+        
         try:
             self.logger.info("Installing dependencies for plugin %s...", plugin_id)
             result = subprocess.run(
-                [sys.executable, "-m", "pip", "install", "--break-system-packages", "-r", requirements_file],
+                [sys.executable, "-m", "pip", "install", "--break-system-packages", "-r", str(requirements_file)],
                 capture_output=True,
                 text=True,
                 timeout=timeout,
                 check=False
             )
-
+            
             if result.returncode == 0:
-                try:
-                    with open(marker_file, 'w', encoding='utf-8') as fh:
-                        fh.write(current_hash)
-                    ensure_file_permissions(Path(marker_file), get_plugin_file_mode())
-                except OSError as marker_err:
-                    self.logger.debug("Could not write dependency marker for %s: %s", plugin_id, marker_err)
+                # Mark as installed
+                marker_path.touch()
+                # Set proper file permissions after creating marker
+                ensure_file_permissions(marker_path, get_plugin_file_mode())
                 self.logger.info("Dependencies installed successfully for %s", plugin_id)
                 return True
             else:
@@ -245,12 +199,8 @@ class PluginLoader:
                         "Assuming they are satisfied: %s",
                         plugin_id, stderr.strip()
                     )
-                    try:
-                        with open(marker_file, 'w', encoding='utf-8') as fh:
-                            fh.write(current_hash)
-                        ensure_file_permissions(Path(marker_file), get_plugin_file_mode())
-                    except OSError as marker_err:
-                        self.logger.debug("Could not write dependency marker for %s: %s", plugin_id, marker_err)
+                    marker_path.touch()
+                    ensure_file_permissions(marker_path, get_plugin_file_mode())
                     return True
                 self.logger.warning(
                     "Dependency installation returned non-zero exit code for %s: %s",
@@ -593,12 +543,11 @@ class PluginLoader:
         display_manager: Any,
         cache_manager: Any,
         plugin_manager: Any,
-        install_deps: bool = True,
-        plugins_dir: Optional[Path] = None,
+        install_deps: bool = True
     ) -> Tuple[Any, Any]:
         """
         Complete plugin loading process.
-
+        
         Args:
             plugin_id: Plugin identifier
             manifest: Plugin manifest
@@ -608,22 +557,16 @@ class PluginLoader:
             cache_manager: Cache manager instance
             plugin_manager: Plugin manager instance
             install_deps: Whether to install dependencies
-            plugins_dir: Trusted base plugins directory forwarded to install_dependencies
-
+            
         Returns:
             Tuple of (plugin_instance, module)
-
+            
         Raises:
             PluginError: If loading fails
         """
         # Install dependencies if needed
         if install_deps:
-            if not self.install_dependencies(plugin_dir, plugin_id, plugins_dir=plugins_dir):
-                raise PluginError(
-                    f"Dependency installation failed for plugin {plugin_id} in {plugin_dir}",
-                    plugin_id=plugin_id,
-                    context={'plugin_dir': str(plugin_dir)},
-                )
+            self.install_dependencies(plugin_dir, plugin_id)
         
         # Load module
         entry_point = manifest.get('entry_point', 'manager.py')

src/plugin_system/plugin_manager.py

@@ -15,7 +15,7 @@ import threading
 from pathlib import Path
 from typing import Dict, List, Optional, Any
 import logging
-from src.exceptions import PluginError, ConfigError
+from src.exceptions import PluginError
 from src.logging_config import get_logger
 from src.plugin_system.plugin_loader import PluginLoader
 from src.plugin_system.plugin_executor import PluginExecutor
@@ -81,13 +81,7 @@ class PluginManager:
         self.plugin_manifests: Dict[str, Dict[str, Any]] = {}
         self.plugin_modules: Dict[str, Any] = {}
         self.plugin_last_update: Dict[str, float] = {}
-
-        # Cached data-fetch intervals per plugin_id.
-        # _get_plugin_update_interval falls back to config_manager.get_config()
-        # (a full dict copy) when the manifest lacks an interval — caching avoids
-        # that copy on every 30-fps tick.  Cleared on load/unload.
-        self._update_interval_cache: Dict[str, Optional[float]] = {}
-
+        
         # Health tracking (optional, set by display_controller if available)
         self.health_tracker = None
         self.resource_monitor = None
@@ -356,8 +350,7 @@ class PluginManager:
                 display_manager=self.display_manager,
                 cache_manager=self.cache_manager,
                 plugin_manager=self,
-                install_deps=True,
-                plugins_dir=self.plugins_dir,
+                install_deps=True
             )
             
             # Store module
@@ -394,8 +387,6 @@ class PluginManager:
             # Store plugin instance
             self.plugins[plugin_id] = plugin_instance
             self.plugin_last_update[plugin_id] = 0.0
-            # Invalidate cached interval so next tick re-derives it for this plugin
-            self._update_interval_cache.pop(plugin_id, None)
             
             # Update state based on enabled status
             if config.get('enabled', True):
@@ -452,8 +443,8 @@ class PluginManager:
             
             # Remove from active plugins
             del self.plugins[plugin_id]
-            self.plugin_last_update.pop(plugin_id, None)
-            self._update_interval_cache.pop(plugin_id, None)
+            if plugin_id in self.plugin_last_update:
+                del self.plugin_last_update[plugin_id]
             
             # Remove main module from sys.modules if present
             module_name = f"plugin_{plugin_id.replace('-', '_')}"
@@ -647,46 +638,41 @@ class PluginManager:
 
     def _get_plugin_update_interval(self, plugin_id: str, plugin_instance: Any) -> Optional[float]:
         """
-        Get the data-fetch interval for a plugin (seconds between update() calls).
-
-        Result is cached per plugin_id after the first lookup to avoid calling
-        config_manager.get_config() — which returns a full dict copy — on every
-        tick of the 30-fps display loop.  The cache is invalidated when a plugin
-        is loaded or unloaded.
+        Get the update interval for a plugin.
+        
+        Args:
+            plugin_id: Plugin identifier
+            plugin_instance: Plugin instance
+            
+        Returns:
+            Update interval in seconds or None if not configured
         """
-        if plugin_id in self._update_interval_cache:
-            return self._update_interval_cache[plugin_id]
-
-        interval: Optional[float] = None
-
-        # 1. Manifest (immutable after load — preferred source)
+        # Check manifest first
         manifest = self.plugin_manifests.get(plugin_id, {})
-        raw = manifest.get('update_interval')
-        if raw is not None:
+        update_interval = manifest.get('update_interval')
+        
+        if update_interval:
             try:
-                interval = float(raw)
+                return float(update_interval)
             except (ValueError, TypeError):
                 pass
-
-        # 2. Plugin config (mutable; only read once and then cached)
-        if interval is None and self.config_manager:
+        
+        # Check plugin config
+        if self.config_manager:
             try:
                 config = self.config_manager.get_config()
-                raw = config.get(plugin_id, {}).get('update_interval')
-                if raw is not None:
+                plugin_config = config.get(plugin_id, {})
+                update_interval = plugin_config.get('update_interval')
+                if update_interval:
                     try:
-                        interval = float(raw)
+                        return float(update_interval)
                     except (ValueError, TypeError):
                         pass
-            except (ConfigError, OSError, ValueError, TypeError) as e:
+            except Exception as e:
                 self.logger.debug("Could not get update interval from config: %s", e)
-
-        # 3. Default
-        if interval is None:
-            interval = 60.0
-
-        self._update_interval_cache[plugin_id] = interval
-        return interval
+        
+        # Default: 60 seconds
+        return 60.0
 
     def _record_update_failure(
         self,

src/plugin_system/state_reconciliation.py

@@ -185,19 +185,13 @@ class StateReconciliation:
                 message=f"Reconciliation failed: {str(e)}"
             )
     
-    # Top-level config keys that are NOT plugins.
-    # Includes both config.json structural keys and config_secrets.json top-level
-    # keys (load_config() deep-merges secrets in, so secrets keys appear here too).
+    # Top-level config keys that are NOT plugins
     _SYSTEM_CONFIG_KEYS = frozenset({
         'web_display_autostart', 'timezone', 'location', 'display',
         'plugin_system', 'vegas_scroll_speed', 'vegas_separator_width',
         'vegas_target_fps', 'vegas_buffer_ahead', 'vegas_plugin_order',
         'vegas_excluded_plugins', 'vegas_scroll_enabled', 'logging',
         'dim_schedule', 'network', 'system', 'schedule',
-        # Multi-display sync config (config.json structural key)
-        'sync',
-        # Secrets file top-level keys (merged in by load_config)
-        'github', 'youtube',
     })
 
     def _get_config_state(self) -> Dict[str, Dict[str, Any]]:
@@ -340,15 +334,15 @@ class StateReconciliation:
         # Check: Enabled state mismatch
         config_enabled = config.get('enabled', False)
         state_mgr_enabled = state_mgr.get('enabled')
-
+        
         if state_mgr_enabled is not None and config_enabled != state_mgr_enabled:
             inconsistencies.append(Inconsistency(
                 plugin_id=plugin_id,
                 inconsistency_type=InconsistencyType.PLUGIN_ENABLED_MISMATCH,
                 description=f"Plugin {plugin_id} enabled state mismatch: config={config_enabled}, state_manager={state_mgr_enabled}",
                 fix_action=FixAction.AUTO_FIX,
-                current_state={'enabled': state_mgr_enabled},
-                expected_state={'enabled': config_enabled},
+                current_state={'enabled': config_enabled},
+                expected_state={'enabled': state_mgr_enabled},
                 can_auto_fix=True
             ))
         
@@ -371,23 +365,15 @@ class StateReconciliation:
                 return self._auto_repair_missing_plugin(inconsistency.plugin_id)
 
             elif inconsistency.inconsistency_type == InconsistencyType.PLUGIN_ENABLED_MISMATCH:
-                # config.json is the user-editable source of truth for enabled state.
-                # Bring the state manager in sync with config rather than the reverse,
-                # so that manual config edits (or the state left behind after an
-                # uninstall+reinstall cycle) don't silently override the user's intent.
-                config_enabled = inconsistency.expected_state.get('enabled')
-                success = self.state_manager.set_plugin_enabled(inconsistency.plugin_id, config_enabled)
-                if success:
-                    self.logger.info(
-                        f"Fixed: Synced state manager enabled={config_enabled} for "
-                        f"{inconsistency.plugin_id} to match config"
-                    )
-                else:
-                    self.logger.warning(
-                        f"Failed to sync state manager enabled={config_enabled} for "
-                        f"{inconsistency.plugin_id}"
-                    )
-                return success
+                # Sync enabled state from state manager to config
+                expected_enabled = inconsistency.expected_state.get('enabled')
+                config = self.config_manager.load_config()
+                if inconsistency.plugin_id not in config:
+                    config[inconsistency.plugin_id] = {}
+                config[inconsistency.plugin_id]['enabled'] = expected_enabled
+                self.config_manager.save_config(config)
+                self.logger.info(f"Fixed: Synced enabled state for {inconsistency.plugin_id}")
+                return True
             
         except Exception as e:
             self.logger.error(f"Error fixing inconsistency: {e}", exc_info=True)

src/plugin_system/store_manager.py

@@ -5,7 +5,6 @@ Handles plugin discovery, installation, updates, and uninstallation
 from both the official registry and custom GitHub repositories.
 """
 
-import hashlib
 import os
 import json
 import stat
@@ -1756,12 +1755,6 @@ class PluginStoreManager:
                 timeout=300
             )
             self.logger.info(f"Dependencies installed successfully for {plugin_path.name}")
-            # Write hash marker so plugin_loader skips redundant pip run on next startup
-            try:
-                current_hash = hashlib.sha256(requirements_file.read_bytes()).hexdigest()
-                (plugin_path / ".dependencies_installed").write_text(current_hash, encoding='utf-8')
-            except OSError as marker_err:
-                self.logger.debug("Could not write dependency marker for %s: %s", plugin_path.name, marker_err)
             return True
             
         except subprocess.CalledProcessError as e:

test/plugins/test_basketball_scoreboard.py

@@ -49,10 +49,9 @@ class TestBasketballScoreboardPlugin(PluginTestBase):
         """Test that plugin has display modes."""
         manifest = self.load_plugin_manifest(plugin_id)
         assert 'display_modes' in manifest
-        # Manifest uses league-prefixed modes (nba_, wnba_, ncaam_, ncaaw_)
-        assert 'nba_live' in manifest['display_modes']
-        assert 'nba_recent' in manifest['display_modes']
-        assert 'nba_upcoming' in manifest['display_modes']
+        assert 'basketball_live' in manifest['display_modes']
+        assert 'basketball_recent' in manifest['display_modes']
+        assert 'basketball_upcoming' in manifest['display_modes']
     
     def test_plugin_has_get_display_modes(self, plugin_id):
         """Test that plugin can return display modes."""

test/test_display_controller.py

@@ -167,53 +167,6 @@ class TestDisplayControllerLivePriority:
         assert controller.current_display_mode == "test_plugin_live"
         assert controller.force_change is True
 
-    def test_live_priority_resume_continues_rotation(self, test_display_controller):
-        """Regression: when live priority ends, rotation resumes where it was
-        interrupted, not after the live plugin's mode.
-
-        Without the fix, _apply_live_priority left current_mode_index pointing at
-        the live plugin's slot, so the next rotation step skipped every mode
-        between the interrupted position and the live plugin (e.g. elections,
-        which sits just before a flights plugin in the order)."""
-        controller = test_display_controller
-        controller.available_modes = [
-            "weather", "forecast", "almanac", "election_ticker", "flight_live"
-        ]
-        # Rotation is about to show the 3rd mode (index 2).
-        controller.current_mode_index = 2
-        controller.current_display_mode = "almanac"
-        controller._live_resume_index = None
-
-        # Live priority (e.g. planes overhead) preempts -> flight_live (index 4).
-        controller._apply_live_priority("flight_live")
-        assert controller.current_display_mode == "flight_live"
-        assert controller.current_mode_index == 4
-        assert controller._live_resume_index == 2  # saved rotation position
-
-        # Re-checks while the hold continues must not move the saved position.
-        controller._apply_live_priority("flight_live")
-        assert controller._live_resume_index == 2
-
-        # Live priority ends -> resume at the saved index (almanac), so the next
-        # rotation step lands on election_ticker (index 3) rather than skipping it.
-        controller._apply_live_priority(None)
-        assert controller.current_mode_index == 2
-        assert controller.current_display_mode == "almanac"
-        assert controller._live_resume_index is None
-
-    def test_live_priority_no_resume_when_idle(self, test_display_controller):
-        """No saved position + no live content is a no-op (normal rotation)."""
-        controller = test_display_controller
-        controller.available_modes = ["a", "b", "c"]
-        controller.current_mode_index = 1
-        controller.current_display_mode = "b"
-        controller._live_resume_index = None
-
-        controller._apply_live_priority(None)
-
-        assert controller.current_mode_index == 1
-        assert controller.current_display_mode == "b"
-
 
 class TestDisplayControllerDynamicDuration:
     """Test dynamic duration handling."""
@@ -276,20 +229,18 @@ class TestDisplayControllerSchedule:
     def test_inactive_hours(self, test_display_controller):
         """Test inactive hours check."""
         controller = test_display_controller
-        # Inject schedule directly into self.config (what _check_schedule actually reads)
-        # and reset the minute gate so the cached result from any prior call is cleared.
-        controller.config['schedule'] = {
-            "enabled": True,
-            "start_time": "09:00",
-            "end_time": "17:00",
-        }
-        controller._schedule_checked_minute = None
-        controller._tz = None
-
         with patch('src.display_controller.datetime') as mock_datetime:
             mock_datetime.now.return_value.strftime.return_value.lower.return_value = "monday"
             mock_datetime.now.return_value.time.return_value = datetime.strptime("20:00", "%H:%M").time()
             mock_datetime.strptime = datetime.strptime
 
-            controller._check_schedule()
-            assert controller.is_display_active is False
+            schedule_config = {
+                "schedule": {
+                    "enabled": True,
+                    "start_time": "09:00",
+                    "end_time": "17:00"
+                }
+            }
+            with patch.object(controller.config_service, 'get_config', return_value=schedule_config):
+                controller._check_schedule()
+                assert controller.is_display_active is False

test/test_display_controller_optimizations.py

@@ -1,322 +0,0 @@
-"""
-Tests for the three display_controller.py optimizations:
-
-  Opt #1 — inspect.signature() caching per plugin_id
-  Opt #2 — pre-cached config values (_normal_brightness, _scroll_speed)
-  Opt #3 — schedule minute-gate (_check_schedule, _check_dim_schedule)
-"""
-
-import pytest
-import time
-from datetime import datetime
-from unittest.mock import MagicMock, patch, call
-
-
-# ---------------------------------------------------------------------------
-# Shared fixture
-# ---------------------------------------------------------------------------
-
-@pytest.fixture
-def controller(test_display_controller):
-    """Return a ready DisplayController from the existing suite fixture."""
-    return test_display_controller
-
-
-# ---------------------------------------------------------------------------
-# Opt #1 — signature cache
-# ---------------------------------------------------------------------------
-
-class TestSignatureCache:
-    """inspect.signature() should be called at most once per plugin_id."""
-
-    class _PluginWithMode:
-        """Real class whose display() accepts display_mode — inspectable by signature."""
-        plugin_id = "mode_plugin"
-        def display(self, display_mode=None, force_clear=False):
-            return True
-
-    class _PluginNoMode:
-        """Real class whose display() does NOT accept display_mode."""
-        plugin_id = "no_mode_plugin"
-        def display(self, force_clear=False):
-            return True
-
-    def test_cache_starts_empty(self, controller):
-        assert controller._plugin_accepts_display_mode == {}
-
-    def test_signature_computed_and_cached(self, controller):
-        """After the first cache population, the dict holds a bool and stays unchanged
-        if queried again without explicitly deleting the key."""
-        import inspect as _inspect
-        plugin = self._PluginNoMode()
-        key = "sig_test"
-        if key not in controller._plugin_accepts_display_mode:
-            controller._plugin_accepts_display_mode[key] = (
-                "display_mode" in _inspect.signature(plugin.display).parameters
-            )
-        original = controller._plugin_accepts_display_mode[key]
-
-        # Accessing cache again should not change the value
-        second = controller._plugin_accepts_display_mode[key]
-        assert second == original
-
-    def test_cache_stores_false_for_no_display_mode(self, controller):
-        """Plugin whose display() doesn't accept display_mode → cached False."""
-        import inspect as _inspect
-        plugin = self._PluginNoMode()
-        controller._plugin_accepts_display_mode["no_mode_plugin"] = (
-            "display_mode" in _inspect.signature(plugin.display).parameters
-        )
-        assert controller._plugin_accepts_display_mode["no_mode_plugin"] is False
-
-    def test_cache_stores_true_for_display_mode(self, controller):
-        """Plugin whose display() accepts display_mode → cached True."""
-        import inspect as _inspect
-        plugin = self._PluginWithMode()
-        controller._plugin_accepts_display_mode["mode_plugin"] = (
-            "display_mode" in _inspect.signature(plugin.display).parameters
-        )
-        assert controller._plugin_accepts_display_mode["mode_plugin"] is True
-
-    def test_cache_cleared_on_plugin_reload(self, controller):
-        """Populating plugin_modes for an id that's already cached must clear the entry."""
-        plugin = MagicMock()
-        controller._plugin_accepts_display_mode["reload_plugin"] = False
-
-        # Simulate the plugin_modes population code path (as in __init__)
-        plugin_id = "reload_plugin"
-        controller.plugin_modes["reload_plugin"] = plugin
-        if hasattr(controller, "_plugin_accepts_display_mode"):
-            controller._plugin_accepts_display_mode.pop(plugin_id, None)
-
-        assert "reload_plugin" not in controller._plugin_accepts_display_mode
-
-
-# ---------------------------------------------------------------------------
-# Opt #2 — cached config values
-# ---------------------------------------------------------------------------
-
-class TestCachedConfigValues:
-    """_normal_brightness and _scroll_speed are populated from config at init."""
-
-    def test_normal_brightness_cached(self, controller):
-        """_normal_brightness must equal what the config says."""
-        expected = (
-            controller.config
-            .get("display", {})
-            .get("hardware", {})
-            .get("brightness", 90)
-        )
-        assert controller._normal_brightness == expected
-
-    def test_scroll_speed_cached(self, controller):
-        """_scroll_speed must equal what the config says."""
-        expected = (
-            controller.config
-            .get("display", {})
-            .get("vegas_scroll", {})
-            .get("scroll_speed", 75)
-        )
-        assert controller._scroll_speed == expected
-
-    def test_current_brightness_uses_cached_value(self, controller):
-        """current_brightness is initialised from _normal_brightness."""
-        assert controller.current_brightness == controller._normal_brightness
-
-    def test_cached_target_brightness_init(self, controller):
-        """_cached_target_brightness starts equal to _normal_brightness."""
-        assert controller._cached_target_brightness == controller._normal_brightness
-
-    def test_normal_brightness_default_is_90(self, controller):
-        """If config has no brightness key the default is 90."""
-        controller.config = {}
-        controller._normal_brightness = (
-            controller.config.get("display", {})
-            .get("hardware", {})
-            .get("brightness", 90)
-        )
-        assert controller._normal_brightness == 90
-
-
-# ---------------------------------------------------------------------------
-# Opt #3 — schedule minute-gate
-# ---------------------------------------------------------------------------
-
-class TestScheduleMinuteGate:
-    """_check_schedule and _check_dim_schedule skip re-evaluation within the same minute."""
-
-    # ── _check_schedule ──────────────────────────────────────────────────────
-
-    def test_schedule_checked_minute_starts_none(self, controller):
-        assert controller._schedule_checked_minute is None
-
-    def test_first_call_sets_checked_minute(self, controller):
-        """After the first real evaluation the minute key is stored."""
-        controller.config["schedule"] = {
-            "enabled": True,
-            "start_time": "00:00",
-            "end_time": "23:59",
-        }
-        controller._schedule_checked_minute = None
-        controller._tz = None
-
-        controller._check_schedule()
-        assert controller._schedule_checked_minute is not None
-
-    def test_second_call_same_minute_does_not_re_evaluate(self, controller):
-        """A second call with the same (hour, minute) returns without changing state."""
-        controller.config["schedule"] = {
-            "enabled": True,
-            "start_time": "00:00",
-            "end_time": "23:59",
-        }
-        controller._tz = None
-        controller._schedule_checked_minute = None
-
-        # First call — evaluates and marks as active (whole-day window)
-        controller._check_schedule()
-        assert controller.is_display_active is True
-        first_minute_key = controller._schedule_checked_minute
-
-        # Force is_display_active to False so we can tell if it gets re-evaluated
-        controller.is_display_active = False
-
-        # Second call within the same minute — gate fires, is_display_active unchanged
-        controller._schedule_checked_minute = first_minute_key  # same minute
-        controller._check_schedule()
-        assert controller.is_display_active is False, (
-            "Second call in same minute should return immediately without re-evaluation"
-        )
-
-    def test_new_minute_forces_re_evaluation(self, controller):
-        """A different (hour, minute) key causes a full re-evaluation."""
-        controller.config["schedule"] = {
-            "enabled": True,
-            "start_time": "00:00",
-            "end_time": "23:59",
-        }
-        controller._tz = None
-
-        # Plant a stale minute key from yesterday
-        controller._schedule_checked_minute = (-1, -1)
-        controller.is_display_active = False  # wrong value to be corrected
-
-        controller._check_schedule()
-        assert controller.is_display_active is True, (
-            "A new minute key should trigger re-evaluation and correct is_display_active"
-        )
-
-    def test_gate_skipped_when_schedule_disabled(self, controller):
-        """When schedule.enabled=False the method returns before reaching the gate."""
-        controller.config["schedule"] = {"enabled": False}
-        controller._schedule_checked_minute = None
-        controller._tz = None
-
-        controller._check_schedule()
-        # The early-return path doesn't set the minute key
-        assert controller._schedule_checked_minute is None
-
-    # ── _check_dim_schedule ──────────────────────────────────────────────────
-
-    def test_dim_checked_minute_starts_none(self, controller):
-        assert controller._dim_checked_minute is None
-
-    def test_first_dim_call_sets_checked_minute(self, controller):
-        """First call with dim schedule enabled stores the minute key."""
-        controller.config["dim_schedule"] = {
-            "enabled": True,
-            "start_time": "22:00",
-            "end_time": "06:00",
-        }
-        controller.is_display_active = True
-        controller._dim_checked_minute = None
-        controller._tz = None
-
-        controller._check_dim_schedule()
-        assert controller._dim_checked_minute is not None
-
-    def test_dim_second_call_returns_cached_brightness(self, controller):
-        """Second call with same minute returns _cached_target_brightness immediately."""
-        controller.config["dim_schedule"] = {
-            "enabled": True,
-            "start_time": "22:00",
-            "end_time": "06:00",
-        }
-        controller.is_display_active = True
-        controller._dim_checked_minute = None
-        controller._tz = None
-
-        # First call stores the result
-        first_result = controller._check_dim_schedule()
-        assert controller._cached_target_brightness == first_result
-        minute_key = controller._dim_checked_minute
-
-        # Corrupt cached value to something recognisable
-        controller._cached_target_brightness = 42
-
-        # Second call in same minute — must return the cached 42
-        controller._dim_checked_minute = minute_key
-        second_result = controller._check_dim_schedule()
-        assert second_result == 42, (
-            "Same-minute call must return cached brightness, not re-compute"
-        )
-
-    def test_dim_gate_skipped_when_display_off(self, controller):
-        """When display is off the method exits before the minute gate."""
-        controller.config["dim_schedule"] = {"enabled": True, "start_time": "22:00", "end_time": "06:00"}
-        controller.is_display_active = False
-        controller._dim_checked_minute = None
-        controller._tz = None
-
-        controller._check_dim_schedule()
-        # Early-exit path does not set the minute key
-        assert controller._dim_checked_minute is None
-
-    def test_dim_cached_target_brightness_updated_after_full_evaluation(self, controller):
-        """After a full evaluation _cached_target_brightness reflects the result."""
-        controller.config["dim_schedule"] = {
-            "enabled": True,
-            "start_time": "22:00",
-            "end_time": "06:00",
-        }
-        controller.is_display_active = True
-        controller._dim_checked_minute = None   # force full re-evaluation
-        controller._tz = None
-
-        result = controller._check_dim_schedule()
-        assert controller._cached_target_brightness == result
-
-    # ── timezone lazy init ───────────────────────────────────────────────────
-
-    def test_tz_starts_none(self, controller):
-        assert controller._tz is None
-
-    def test_tz_lazily_initialised_on_first_schedule_check(self, controller):
-        """_tz is None until _check_schedule or _check_dim_schedule is called."""
-        controller.config["schedule"] = {
-            "enabled": True,
-            "start_time": "00:00",
-            "end_time": "23:59",
-        }
-        controller._tz = None
-        controller._schedule_checked_minute = None
-
-        controller._check_schedule()
-        assert controller._tz is not None
-
-    def test_tz_shared_between_schedule_and_dim(self, controller):
-        """Both methods use the same cached _tz instance."""
-        controller.config["schedule"] = {"enabled": True, "start_time": "00:00", "end_time": "23:59"}
-        controller.config["dim_schedule"] = {"enabled": True, "start_time": "22:00", "end_time": "06:00"}
-        controller.is_display_active = True
-        controller._tz = None
-        controller._schedule_checked_minute = None
-        controller._dim_checked_minute = None
-
-        controller._check_schedule()
-        tz_after_schedule = controller._tz
-
-        controller._check_dim_schedule()
-        assert controller._tz is tz_after_schedule, (
-            "_check_dim_schedule should reuse the _tz set by _check_schedule"
-        )

test/test_store_manager_caches.py

@@ -58,15 +58,19 @@ class TestGitInfoCache(unittest.TestCase):
         (self.plugin_path / ".git" / "HEAD").write_text("ref: refs/heads/main\n")
 
     def _fake_subprocess_run(self, *args, **kwargs):
-        # _get_local_git_info now reads branch and remote_url directly from
-        # .git/HEAD and .git/config (no subprocess) and uses a single
-        # ``git log --format=%H%n%cI`` call that returns SHA on line 1 and
-        # ISO date on line 2.  Adjust the fake accordingly.
+        # Return different dummy values depending on which git subcommand
+        # was invoked so the code paths that parse output all succeed.
         cmd = args[0]
         result = MagicMock()
         result.returncode = 0
-        if "log" in cmd:
-            result.stdout = "abcdef1234567890\n2026-04-08T12:00:00+00:00\n"
+        if "rev-parse" in cmd and "HEAD" in cmd and "--abbrev-ref" not in cmd:
+            result.stdout = "abcdef1234567890\n"
+        elif "--abbrev-ref" in cmd:
+            result.stdout = "main\n"
+        elif "config" in cmd:
+            result.stdout = "https://example.com/repo.git\n"
+        elif "log" in cmd:
+            result.stdout = "2026-04-08T12:00:00+00:00\n"
         else:
             result.stdout = ""
         return result
@@ -80,8 +84,7 @@ class TestGitInfoCache(unittest.TestCase):
             self.assertIsNotNone(first)
             self.assertEqual(first["short_sha"], "abcdef1")
             calls_after_first = mock_run.call_count
-            # Production code now uses a single ``git log`` call.
-            self.assertEqual(calls_after_first, 1)
+            self.assertEqual(calls_after_first, 4)
 
             # Second call with unchanged HEAD: zero new subprocess calls.
             second = self.sm._get_local_git_info(self.plugin_path)
@@ -102,8 +105,7 @@ class TestGitInfoCache(unittest.TestCase):
             os.utime(head, (new_time, new_time))
 
             self.sm._get_local_git_info(self.plugin_path)
-            # One new ``git log`` call after cache invalidation.
-            self.assertEqual(mock_run.call_count, calls_after_first + 1)
+            self.assertEqual(mock_run.call_count, calls_after_first + 4)
 
     def test_no_git_directory_returns_none(self):
         non_git = self.plugins_dir / "no_git"
@@ -190,11 +192,14 @@ class TestGitInfoCache(unittest.TestCase):
             result = MagicMock()
             result.returncode = 0
             cmd = args[0]
-            # Production code now uses a single ``git log --format=%H%n%cI``.
-            # Branch and remote_url are read directly from .git/HEAD/.git/config.
-            if "log" in cmd:
-                sha = branch_file.read_text().strip()
-                result.stdout = f"{sha}\n2026-04-08T12:00:00+00:00\n"
+            if "rev-parse" in cmd and "--abbrev-ref" not in cmd:
+                result.stdout = branch_file.read_text().strip() + "\n"
+            elif "--abbrev-ref" in cmd:
+                result.stdout = "main\n"
+            elif "config" in cmd:
+                result.stdout = "https://example.com/repo.git\n"
+            elif "log" in cmd:
+                result.stdout = "2026-04-08T12:00:00+00:00\n"
             else:
                 result.stdout = ""
             return result

test/test_web_api.py

@@ -617,8 +617,7 @@ class TestDottedKeyNormalization:
             'leagues': {'eng.1': {'enabled': True, 'favorite_teams': []}},
         }
         schema_mgr.merge_with_defaults.side_effect = lambda config, defaults: {**defaults, **config}
-        # Must be a (bool, list) tuple: the endpoint does is_valid, errors = validate_config_against_schema(...)
-        schema_mgr.validate_config_against_schema.return_value = (True, [])
+        schema_mgr.validate_config_against_schema.return_value = []
         api_v3.schema_manager = schema_mgr
 
         request_data = {
@@ -680,7 +679,7 @@ class TestDottedKeyNormalization:
             'leagues': {'eng.1': {'favorite_teams': []}},
         }
         schema_mgr.merge_with_defaults.side_effect = lambda config, defaults: {**defaults, **config}
-        schema_mgr.validate_config_against_schema.return_value = (True, [])
+        schema_mgr.validate_config_against_schema.return_value = []
         api_v3.schema_manager = schema_mgr
 
         request_data = {

test/web_interface/test_state_reconciliation.py

@@ -224,14 +224,20 @@ class TestStateReconciliation(unittest.TestCase):
         with open(manifest_path, 'w') as f:
             json.dump({"version": "1.0.0", "name": "Plugin 1"}, f)
         
+        # Mock save_config to track calls
+        saved_configs = []
+        def save_config(config):
+            saved_configs.append(config)
+        
+        self.config_manager.save_config = save_config
+        
         # Run reconciliation
         result = self.reconciler.reconcile_state()
-
-        # config.json is the source of truth for enabled state. The fix syncs
-        # the state manager to match config (config says True → state set True),
-        # rather than overwriting the config with the stale state value.
+        
+        # Verify fix was attempted
         self.assertEqual(len(result.inconsistencies_fixed), 1)
-        self.state_manager.set_plugin_enabled.assert_called_once_with("plugin1", True)
+        self.assertEqual(len(saved_configs), 1)
+        self.assertEqual(saved_configs[0]["plugin1"]["enabled"], False)
     
     def test_multiple_inconsistencies(self):
         """Test reconciliation with multiple inconsistencies."""

web_interface/app.py

@@ -2,11 +2,8 @@ from flask import Flask, request, redirect, url_for, jsonify, Response, send_fro
 import json
 import logging
 import os
-import queue
-import shutil
 import sys
 import subprocess
-import threading
 import time
 from pathlib import Path
 from datetime import datetime, timedelta
@@ -25,9 +22,6 @@ from src.plugin_system.state_manager import PluginStateManager
 from src.plugin_system.operation_history import OperationHistory
 from src.plugin_system.health_monitor import PluginHealthMonitor
 
-_JOURNALCTL = shutil.which('journalctl')
-_SYSTEMCTL = shutil.which('systemctl')
-
 # Create Flask app
 app = Flask(__name__)
 app.secret_key = os.urandom(24)
@@ -391,22 +385,6 @@ def captive_portal_redirect():
     # Redirect to lightweight captive portal setup page (not the full UI)
     return redirect(url_for('pages_v3.captive_setup'), code=302)
 
-# Append a content-version query param (file mtime) to every static URL so the
-# long-lived `immutable` cache (see add_security_headers below) is actually safe:
-# when a static file changes its URL changes, so browsers refetch it. Without
-# this, edited JS/CSS were served immutable under an unchanging URL and never
-# reached clients until a manual cache clear.
-@app.url_defaults
-def add_static_version(endpoint, values):
-    if endpoint == 'static' and values.get('filename'):
-        try:
-            file_path = os.path.join(app.static_folder, values['filename'])
-            values['v'] = int(os.path.getmtime(file_path))
-        except OSError:
-            # File missing (e.g. plugin asset not yet installed) — skip versioning.
-            pass
-
-
 # Add security headers and caching to all responses
 @app.after_request
 def add_security_headers(response):
@@ -435,53 +413,13 @@ def add_security_headers(response):
     
     return response
 
-class _StreamBroadcaster:
-    """Fan-out broadcaster: one background generator thread pushes to all SSE clients.
-
-    This means N browser tabs share one generator instead of each running their own,
-    keeping PIL encodes / subprocess forks constant regardless of how many tabs are open.
-    """
-
-    def __init__(self, generator_factory):
-        self._generator_factory = generator_factory
-        self._clients: set = set()
-        self._lock = threading.Lock()
-        self._thread: threading.Thread | None = None
-
-    def subscribe(self) -> queue.Queue:
-        q: queue.Queue = queue.Queue(maxsize=5)
-        with self._lock:
-            self._clients.add(q)
-            if not (self._thread and self._thread.is_alive()):
-                self._thread = threading.Thread(target=self._broadcast, daemon=True)
-                self._thread.start()
-        return q
-
-    def unsubscribe(self, q: queue.Queue) -> None:
-        with self._lock:
-            self._clients.discard(q)
-
-    def _broadcast(self):
-        for data in self._generator_factory():
-            with self._lock:
-                if not self._clients:
-                    # No subscribers — exit so the thread doesn't spin indefinitely.
-                    # subscribe() will restart it when a new client arrives.
-                    break
-                for q in self._clients:
-                    try:
-                        q.put_nowait(data)
-                    except queue.Full:
-                        # Client is reading too slowly; drop the oldest item and
-                        # deliver the latest so the queue never stalls the client.
-                        try:
-                            q.get_nowait()
-                        except queue.Empty:
-                            pass
-                        try:
-                            q.put_nowait(data)
-                        except queue.Full:
-                            pass
+# SSE helper function
+def sse_response(generator_func):
+    """Helper to create SSE responses"""
+    def generate():
+        for data in generator_func():
+            yield f"data: {json.dumps(data)}\n\n"
+    return Response(generate(), mimetype='text/event-stream')
 
 # System status generator for SSE
 def system_status_generator():
@@ -512,13 +450,12 @@ def system_status_generator():
             # Check if display service is running (cached to avoid per-client subprocess forks)
             now = time.time()
             if (now - _ledmatrix_service_cache['timestamp']) >= _LEDMATRIX_SERVICE_CACHE_TTL:
-                if _SYSTEMCTL:
-                    try:
-                        result = subprocess.run([_SYSTEMCTL, 'is-active', 'ledmatrix'],
-                                                capture_output=True, text=True, timeout=2)
-                        _ledmatrix_service_cache['active'] = result.stdout.strip() == 'active'
-                    except (subprocess.SubprocessError, OSError) as e:
-                        app.logger.warning("systemctl status check failed: %s", e)
+                try:
+                    result = subprocess.run(['systemctl', 'is-active', 'ledmatrix'],
+                                            capture_output=True, text=True, timeout=2)
+                    _ledmatrix_service_cache['active'] = result.stdout.strip() == 'active'
+                except (subprocess.SubprocessError, OSError):
+                    pass
                 _ledmatrix_service_cache['timestamp'] = now
             service_active = _ledmatrix_service_cache['active']
             
@@ -610,13 +547,8 @@ def logs_generator():
             # Get recent logs from journalctl (simplified version)
             # Note: User should be in systemd-journal group to read logs without sudo
             try:
-                if not _JOURNALCTL:
-                    yield {'timestamp': time.time(), 'logs': 'journalctl not found; cannot read logs'}
-                    time.sleep(60)
-                    continue
                 result = subprocess.run(
-                    [_JOURNALCTL, '-u', 'ledmatrix.service', '-u', 'ledmatrix-web.service',
-                     '-n', '50', '--no-pager', '--output=short-iso'],
+                    ['journalctl', '-u', 'ledmatrix.service', '-n', '50', '--no-pager'],
                     capture_output=True, text=True, timeout=5
                 )
 
@@ -632,7 +564,7 @@ def logs_generator():
                         # No logs available
                         logs_data = {
                             'timestamp': time.time(),
-                            'logs': 'No logs available from ledmatrix or ledmatrix-web service'
+                            'logs': 'No logs available from ledmatrix service'
                         }
                         yield logs_data
                 else:
@@ -664,50 +596,20 @@ def logs_generator():
 
         time.sleep(5)  # Update every 5 seconds (reduced frequency for better performance)
 
-# One broadcaster per stream — shared across all SSE clients
-_stats_broadcaster = _StreamBroadcaster(system_status_generator)
-_display_broadcaster = _StreamBroadcaster(display_preview_generator)
-_logs_broadcaster = _StreamBroadcaster(logs_generator)
-
-
-def _sse_stream(broadcaster: _StreamBroadcaster) -> Response:
-    """Return a streaming SSE response backed by a shared broadcaster."""
-    q = broadcaster.subscribe()
-
-    def generate():
-        try:
-            while True:
-                try:
-                    data = q.get(timeout=30)
-                    yield f"data: {json.dumps(data)}\n\n"
-                except queue.Empty:
-                    # Send an SSE comment heartbeat to keep the connection alive
-                    # through proxies that close idle connections.
-                    yield ": heartbeat\n\n"
-        except GeneratorExit:
-            pass
-        finally:
-            broadcaster.unsubscribe(q)
-
-    return Response(generate(), mimetype='text/event-stream')
-
-
 # SSE endpoints
 @app.route('/api/v3/stream/stats')
 def stream_stats():
-    return _sse_stream(_stats_broadcaster)
+    return sse_response(system_status_generator)
 
 @app.route('/api/v3/stream/display')
 def stream_display():
-    return _sse_stream(_display_broadcaster)
+    return sse_response(display_preview_generator)
 
 @app.route('/api/v3/stream/logs')
 def stream_logs():
-    return _sse_stream(_logs_broadcaster)
+    return sse_response(logs_generator)
 
-# Exempt SSE streams from CSRF and apply a generous rate limit.
-# SSE connections are long-lived HTTP requests, not repeated API calls, so the
-# tight "20 per minute" default would be exhausted quickly on reconnects.
+# Exempt SSE streams from CSRF and add rate limiting
 if csrf:
     csrf.exempt(stream_stats)
     csrf.exempt(stream_display)
@@ -715,9 +617,9 @@ if csrf:
     # Note: api_v3 blueprint is exempted above after registration
 
 if limiter:
-    limiter.limit("200 per minute")(stream_stats)
-    limiter.limit("200 per minute")(stream_display)
-    limiter.limit("200 per minute")(stream_logs)
+    limiter.limit("20 per minute")(stream_stats)
+    limiter.limit("20 per minute")(stream_display)
+    limiter.limit("20 per minute")(stream_logs)
 
 # Main route - redirect to v3 interface as default
 @app.route('/')

web_interface/blueprints/api_v3.py

@@ -4,7 +4,6 @@ import os
 import re
 import stat
 import sys
-import shutil
 import subprocess
 import tempfile
 import time
@@ -26,9 +25,6 @@ from src.web_interface.validators import (
 )
 from src.error_aggregator import get_error_aggregator
 
-_SUDO = shutil.which('sudo')
-_JOURNALCTL = shutil.which('journalctl')
-
 # Will be initialized when blueprint is registered
 config_manager = None
 plugin_manager = None
@@ -1460,41 +1456,31 @@ def execute_system_action():
             if mode:
                 # For on-demand modes, we would need to integrate with the display controller
                 # For now, just start the display service
-                try:
-                    result = subprocess.run(['sudo', 'systemctl', 'start', 'ledmatrix'],
-                                         capture_output=True, text=True, timeout=10)
-                except subprocess.TimeoutExpired as e:
-                    logger.error("start_display (%s) timed out: %s", mode, e)
-                    return jsonify({'status': 'error', 'message': 'Command timed out', 'returncode': -1, 'stderr': 'timeout'})
+                result = subprocess.run(['sudo', 'systemctl', 'start', 'ledmatrix'],
+                                     capture_output=True, text=True)
                 logger.info("start_display (%s) returned code %d", mode, result.returncode)
-                if result.returncode != 0 and result.stderr:
-                    logger.error("start_display (%s) stderr: %s", mode, result.stderr.strip())
-                resp = {
+                return jsonify({
                     'status': 'success' if result.returncode == 0 else 'error',
                     'message': 'Display started' if result.returncode == 0 else 'Failed to start display',
-                }
-                if result.returncode != 0:
-                    resp['returncode'] = result.returncode
-                    resp['stderr'] = result.stderr.strip()
-                return jsonify(resp)
+                })
             else:
                 result = subprocess.run(['sudo', 'systemctl', 'start', 'ledmatrix'],
-                                     capture_output=True, text=True, timeout=10)
+                                     capture_output=True, text=True)
         elif action == 'stop_display':
             result = subprocess.run(['sudo', 'systemctl', 'stop', 'ledmatrix'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'enable_autostart':
             result = subprocess.run(['sudo', 'systemctl', 'enable', 'ledmatrix'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'disable_autostart':
             result = subprocess.run(['sudo', 'systemctl', 'disable', 'ledmatrix'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'reboot_system':
             result = subprocess.run(['sudo', 'reboot'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'shutdown_system':
             result = subprocess.run(['sudo', 'poweroff'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'git_pull':
             # Use PROJECT_ROOT instead of hardcoded path
             project_dir = str(PROJECT_ROOT)
@@ -1569,29 +1555,20 @@ def execute_system_action():
             })
         elif action == 'restart_display_service':
             result = subprocess.run(['sudo', 'systemctl', 'restart', 'ledmatrix'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         elif action == 'restart_web_service':
             # Try to restart the web service (assuming it's ledmatrix-web.service)
             result = subprocess.run(['sudo', 'systemctl', 'restart', 'ledmatrix-web'],
-                                 capture_output=True, text=True, timeout=10)
+                                 capture_output=True, text=True)
         else:
             return jsonify({'status': 'error', 'message': 'Unknown action'}), 400
 
         logger.info("system action '%s' returncode=%d", action, result.returncode)
-        if result.returncode != 0 and result.stderr:
-            logger.error("system action '%s' stderr: %s", action, result.stderr.strip())
-        resp = {
+        return jsonify({
             'status': 'success' if result.returncode == 0 else 'error',
             'message': 'Action completed' if result.returncode == 0 else 'Action failed; check logs for details',
-        }
-        if result.returncode != 0:
-            resp['returncode'] = result.returncode
-            resp['stderr'] = result.stderr.strip()
-        return jsonify(resp)
+        })
 
-    except subprocess.TimeoutExpired as e:
-        logger.error("system action '%s' timed out: %s", action, e)
-        return jsonify({'status': 'error', 'message': 'Command timed out', 'returncode': -1, 'stderr': 'timeout'})
     except Exception as e:
         logger.error("execute_system_action failed: %s", e, exc_info=True)
         return jsonify({'status': 'error', 'message': 'Action failed; see logs for details'}), 500
@@ -2412,13 +2389,6 @@ def reconcile_plugin_state():
 
         from src.plugin_system.state_reconciliation import StateReconciliation
 
-        # Parse optional `force` flag from request body, guarding against
-        # non-dict bodies (bare string, array, null) that would raise AttributeError.
-        payload = request.get_json(silent=True)
-        if not isinstance(payload, dict):
-            payload = {}
-        force = _coerce_to_bool(payload.get('force', False))
-
         reconciler = StateReconciliation(
             state_manager=api_v3.plugin_state_manager,
             config_manager=api_v3.config_manager,
@@ -2426,7 +2396,7 @@ def reconcile_plugin_state():
             plugins_dir=Path(api_v3.plugin_manager.plugins_dir)
         )
 
-        result = reconciler.reconcile_state(force=force)
+        result = reconciler.reconcile_state()
 
         return success_response(
             data={
@@ -2694,16 +2664,6 @@ def update_plugin():
                 with open(manifest_path, 'r', encoding='utf-8') as f:
                     manifest = json.load(f)
                     current_last_updated = manifest.get('last_updated')
-                if manifest.get('local_only'):
-                    logger.debug("Skipping update for local-only plugin: %s", plugin_id)
-                    if api_v3.operation_history:
-                        api_v3.operation_history.record_operation(
-                            "update",
-                            plugin_id=plugin_id,
-                            status="skipped",
-                            details={"reason": "local_only"}
-                        )
-                    return success_response(message=f'Plugin {plugin_id} is managed locally and does not receive registry updates')
             except Exception as e:
                 logger.debug("Could not read local manifest for plugin: %s", e)
 
@@ -2853,89 +2813,6 @@ def update_plugin():
             status_code=500
         )
 
-def _do_transactional_uninstall(plugin_id, preserve_config):
-    """Execute an uninstall with snapshot-based rollback.
-
-    Order of operations:
-      1. Snapshot main config + secrets (abort on unexpected errors, proceed on expected I/O errors).
-      2. Clean up plugin config (abort with 500 if this raises — avoids orphaned files).
-      3. Unload plugin from runtime if loaded (rollback + 500 if this raises).
-      4. Remove plugin files (rollback + 500 if this returns False or raises).
-      5. Finish (remove state, invalidate caches).
-
-    Rollback restores the config snapshot and, if the plugin had been
-    loaded before unload, calls load_plugin to restore runtime state.
-
-    Returns (True, None) on success or (False, error_message) on failure.
-    """
-    from src.exceptions import ConfigError
-
-    # --- Step 1: snapshot main + secrets ---
-    main_snapshot = None
-    secrets_snapshot = None
-    try:
-        main_snapshot = api_v3.config_manager.get_raw_file_content('main')
-    except (OSError, ConfigError):
-        pass  # Proceed without snapshot; narrow catch preserves TypeError/AttributeError
-    try:
-        secrets_snapshot = api_v3.config_manager.get_raw_file_content('secrets')
-    except (OSError, ConfigError):
-        pass
-
-    # --- Step 2: cleanup config first (abort before touching filesystem) ---
-    if not preserve_config:
-        api_v3.config_manager.cleanup_plugin_config(plugin_id, remove_secrets=True)
-
-    # Record whether the plugin was running before we touch anything.
-    was_loaded = (
-        api_v3.plugin_manager is not None
-        and plugin_id in api_v3.plugin_manager.plugins
-    )
-
-    def _rollback(reload_plugin):
-        if main_snapshot is not None:
-            try:
-                api_v3.config_manager.save_raw_file_content('main', main_snapshot)
-            except Exception as restore_err:
-                logger.error("Failed to restore main config snapshot for %s: %s", plugin_id, restore_err)
-        if secrets_snapshot is not None:
-            try:
-                api_v3.config_manager.save_raw_file_content('secrets', secrets_snapshot)
-            except Exception as restore_err:
-                logger.error("Failed to restore secrets snapshot for %s: %s", plugin_id, restore_err)
-        if reload_plugin and api_v3.plugin_manager is not None:
-            try:
-                api_v3.plugin_manager.load_plugin(plugin_id)
-            except Exception as reload_err:
-                logger.error("Failed to reload plugin %s during rollback: %s", plugin_id, reload_err)
-
-    # --- Step 3: unload ---
-    if was_loaded:
-        try:
-            api_v3.plugin_manager.unload_plugin(plugin_id)
-        except Exception as unload_err:
-            _rollback(reload_plugin=False)  # unload failed — runtime state unchanged
-            return False, f"Failed to unload plugin {plugin_id}: {unload_err}"
-
-    # --- Step 4: remove files ---
-    try:
-        success = api_v3.plugin_store_manager.uninstall_plugin(plugin_id)
-    except Exception as remove_err:
-        _rollback(reload_plugin=was_loaded)
-        return False, f"Failed to remove plugin {plugin_id}: {remove_err}"
-
-    if not success:
-        _rollback(reload_plugin=was_loaded)
-        return False, f"Failed to uninstall plugin {plugin_id}"
-
-    # --- Step 5: finish ---
-    if api_v3.schema_manager:
-        api_v3.schema_manager.invalidate_cache(plugin_id)
-    if api_v3.plugin_state_manager:
-        api_v3.plugin_state_manager.remove_plugin_state(plugin_id)
-    return True, None
-
-
 @api_v3.route('/plugins/uninstall', methods=['POST'])
 def uninstall_plugin():
     """Uninstall plugin"""
@@ -2955,13 +2832,19 @@ def uninstall_plugin():
         plugin_id = data['plugin_id']
         preserve_config = data.get('preserve_config', False)
 
-        # Both queued and direct paths use the same transactional helper so
-        # snapshot/rollback behaviour is consistent regardless of deployment.
+        # Use operation queue if available
         if api_v3.operation_queue:
             def uninstall_callback(operation):
-                """Callback to execute plugin uninstallation via transactional helper."""
-                success, error_msg = _do_transactional_uninstall(plugin_id, preserve_config)
+                """Callback to execute plugin uninstallation."""
+                # Unload the plugin first if it's loaded
+                if api_v3.plugin_manager and plugin_id in api_v3.plugin_manager.plugins:
+                    api_v3.plugin_manager.unload_plugin(plugin_id)
+
+                # Uninstall the plugin
+                success = api_v3.plugin_store_manager.uninstall_plugin(plugin_id)
+
                 if not success:
+                    error_msg = f'Failed to uninstall plugin {plugin_id}'
                     if api_v3.operation_history:
                         api_v3.operation_history.record_operation(
                             "uninstall",
@@ -2969,7 +2852,24 @@ def uninstall_plugin():
                             status="failed",
                             error=error_msg
                         )
-                    raise Exception(error_msg or f'Failed to uninstall plugin {plugin_id}')
+                    raise Exception(error_msg)
+
+                # Invalidate schema cache
+                if api_v3.schema_manager:
+                    api_v3.schema_manager.invalidate_cache(plugin_id)
+
+                # Clean up plugin configuration if not preserving
+                if not preserve_config:
+                    try:
+                        api_v3.config_manager.cleanup_plugin_config(plugin_id, remove_secrets=True)
+                    except Exception as cleanup_err:
+                        logger.warning("Failed to cleanup config after uninstall: %s", cleanup_err)
+
+                # Remove from state manager
+                if api_v3.plugin_state_manager:
+                    api_v3.plugin_state_manager.remove_plugin_state(plugin_id)
+
+                # Record in history
                 if api_v3.operation_history:
                     api_v3.operation_history.record_operation(
                         "uninstall",
@@ -2977,6 +2877,7 @@ def uninstall_plugin():
                         status="success",
                         details={"preserve_config": preserve_config}
                     )
+
                 return {'success': True, 'message': 'Plugin uninstalled successfully'}
 
             # Enqueue operation
@@ -2991,10 +2892,31 @@ def uninstall_plugin():
                 message='Plugin uninstallation queued'
             )
         else:
-            # Direct (non-queued) transactional uninstall
-            success, error_msg = _do_transactional_uninstall(plugin_id, preserve_config)
+            # Fallback to direct uninstall
+            # Unload the plugin first if it's loaded
+            if api_v3.plugin_manager and plugin_id in api_v3.plugin_manager.plugins:
+                api_v3.plugin_manager.unload_plugin(plugin_id)
+
+            # Uninstall the plugin
+            success = api_v3.plugin_store_manager.uninstall_plugin(plugin_id)
 
             if success:
+                # Invalidate schema cache
+                if api_v3.schema_manager:
+                    api_v3.schema_manager.invalidate_cache(plugin_id)
+
+                # Clean up plugin configuration if not preserving
+                if not preserve_config:
+                    try:
+                        api_v3.config_manager.cleanup_plugin_config(plugin_id, remove_secrets=True)
+                    except Exception as cleanup_err:
+                        logger.warning("Failed to cleanup config after uninstall: %s", cleanup_err)
+
+                # Remove from state manager
+                if api_v3.plugin_state_manager:
+                    api_v3.plugin_state_manager.remove_plugin_state(plugin_id)
+
+                # Record in history
                 if api_v3.operation_history:
                     api_v3.operation_history.record_operation(
                         "uninstall",
@@ -3002,6 +2924,7 @@ def uninstall_plugin():
                         status="success",
                         details={"preserve_config": preserve_config}
                     )
+
                 return success_response(message='Plugin uninstalled successfully')
             else:
                 if api_v3.operation_history:
@@ -3009,11 +2932,12 @@ def uninstall_plugin():
                         "uninstall",
                         plugin_id=plugin_id,
                         status="failed",
-                        error=error_msg
+                        error='Plugin uninstall failed'
                     )
+
                 return error_response(
                     ErrorCode.PLUGIN_UNINSTALL_FAILED,
-                    error_msg or 'Plugin uninstall failed',
+                    'Plugin uninstall failed',
                     status_code=500
                 )
 
@@ -4260,9 +4184,7 @@ def save_plugin_config():
                             nested_dict = config_dict.get(prop_key)
 
                         if isinstance(nested_dict, dict):
-                            # Pass no prefix: config_dict is already the navigated sub-dict,
-                            # so path segments from the parent would mis-navigate it.
-                            fix_array_structures(nested_dict, prop_schema['properties'])
+                            fix_array_structures(nested_dict, prop_schema['properties'], nested_prefix)
 
             # Also ensure array fields that are None get converted to empty arrays
             def ensure_array_defaults(config_dict, schema_props, prefix=''):
@@ -4322,8 +4244,7 @@ def save_plugin_config():
                                 nested_dict = config_dict[prop_key]
 
                         if isinstance(nested_dict, dict):
-                            # Pass no prefix: config_dict is already navigated.
-                            ensure_array_defaults(nested_dict, prop_schema['properties'])
+                            ensure_array_defaults(nested_dict, prop_schema['properties'], nested_prefix)
 
             if schema and 'properties' in schema:
                 # First, fix any dict structures that should be arrays
@@ -4423,21 +4344,6 @@ def save_plugin_config():
             defaults = schema_mgr.generate_default_config(plugin_id, use_cache=True)
             plugin_config = schema_mgr.merge_with_defaults(plugin_config, defaults)
 
-        # After merging defaults, replace any None array values with their schema defaults.
-        # merge_with_defaults gives user config higher priority, so a None submitted by
-        # the client can survive the merge — this pass cleans those up.
-        def _fix_none_arrays(cfg, props):
-            for k, pschema in props.items():
-                if pschema.get('type') == 'array':
-                    if isinstance(cfg, dict) and (k not in cfg or cfg[k] is None):
-                        cfg[k] = pschema.get('default', [])
-                elif pschema.get('type') == 'object' and 'properties' in pschema:
-                    if isinstance(cfg, dict) and isinstance(cfg.get(k), dict):
-                        _fix_none_arrays(cfg[k], pschema['properties'])
-
-        if schema and 'properties' in schema and isinstance(plugin_config, dict):
-            _fix_none_arrays(plugin_config, schema['properties'])
-
         # Ensure enabled state is preserved after defaults merge
         # Defaults should not overwrite an explicitly preserved enabled value
         if preserved_enabled is not None:
@@ -6519,14 +6425,9 @@ def list_plugin_assets():
 def get_logs():
     """Get system logs from journalctl"""
     try:
-        if not _JOURNALCTL:
-            return jsonify({'status': 'error', 'message': 'journalctl not found on this system'}), 503
         # Get recent logs from journalctl
-        _cmd = ([_SUDO, _JOURNALCTL] if _SUDO else [_JOURNALCTL]) + [
-            '-u', 'ledmatrix.service', '-u', 'ledmatrix-web.service',
-            '-n', '100', '--no-pager', '--output=short-iso']
         result = subprocess.run(
-            _cmd,
+            ['sudo', 'journalctl', '-u', 'ledmatrix.service', '-n', '100', '--no-pager'],
             capture_output=True,
             text=True,
             timeout=5
@@ -6537,7 +6438,7 @@ def get_logs():
             return jsonify({
                 'status': 'success',
                 'data': {
-                    'logs': logs_text if logs_text else 'No logs available from ledmatrix or ledmatrix-web service'
+                    'logs': logs_text if logs_text else 'No logs available from ledmatrix service'
                 }
             })
         else:

web_interface/blueprints/pages_v3.py

@@ -3,13 +3,8 @@ from markupsafe import escape
 import json
 import logging
 import os
-import os.path
 import re
 from pathlib import Path
-
-# Strict allowlists for URL-derived values used in path and script operations.
-_SAFE_PLUGIN_ID_RE = re.compile(r'^[a-zA-Z0-9_-]{1,64}$')
-_SAFE_WEB_UI_FILE_RE = re.compile(r'^[a-zA-Z0-9_-]{1,64}\.html$')
 from src.web_interface.secret_helpers import mask_secret_fields
 
 logger = logging.getLogger(__name__)
@@ -107,99 +102,6 @@ def load_plugin_config_partial(plugin_id):
         logger.error("Error loading plugin config partial for %s", plugin_id, exc_info=True)
         return '<div class="text-red-500 p-4">Error loading plugin config; see logs for details</div>', 500
 
-
-@pages_v3.route('/plugin-ui/<plugin_id>/web-ui/<path:filename>')
-def serve_plugin_web_ui(plugin_id, filename):
-    """Serve a plugin's web_ui/ HTML fragment as a standalone page.
-
-    Wraps the fragment with a minimal HTML page that injects window.PLUGIN_ID
-    and loads Tailwind CSS so the fragment runs correctly in a sandboxed iframe.
-    """
-    # Validate URL-derived values against strict allowlists before any path or
-    # script operations.
-    if not _SAFE_PLUGIN_ID_RE.match(plugin_id):
-        return 'Invalid plugin ID', 400, {'Content-Type': 'text/plain'}
-    if not _SAFE_WEB_UI_FILE_RE.match(filename):
-        return 'Invalid filename', 400, {'Content-Type': 'text/plain'}
-
-    # os.path.basename() is the CodeQL-recognised path sanitizer used throughout
-    # this codebase (see plugin_loader.py).  Applying it here breaks the taint
-    # chain even though the allowlist above already prevents path separators.
-    safe_id = os.path.basename(plugin_id)
-    safe_fn = os.path.basename(filename)
-    if not safe_id or not safe_fn:
-        return 'Invalid path component', 400, {'Content-Type': 'text/plain'}
-
-    if not pages_v3.plugin_manager:
-        return 'Plugin manager not available', 503, {'Content-Type': 'text/plain'}
-
-    try:
-        _plugins_base = Path(pages_v3.plugin_manager.plugins_dir).resolve()
-
-        # Reconstruct from sanitised basename — CodeQL-approved pattern.
-        _plugin_dir = (_plugins_base / safe_id).resolve()
-        _plugin_dir.relative_to(_plugins_base)  # containment guard
-
-        # Mirror PluginManager's ledmatrix- prefix fallback.
-        if not _plugin_dir.exists():
-            _alt_id  = os.path.basename(f'ledmatrix-{safe_id}')
-            _alt     = (_plugins_base / _alt_id).resolve()
-            try:
-                _alt.relative_to(_plugins_base)
-                _plugin_dir = _alt
-            except ValueError:
-                pass
-
-        web_ui_path = (_plugin_dir / 'web_ui' / safe_fn).resolve()
-        web_ui_path.relative_to(_plugin_dir / 'web_ui')  # second guard
-
-        if not web_ui_path.exists():
-            return 'Not found', 404, {'Content-Type': 'text/plain'}
-
-        fragment = web_ui_path.read_text(encoding='utf-8')
-
-        # json.dumps wraps the value in quotes.  Replace HTML meta-chars with
-        # their JS Unicode escape sequences so the value cannot close or escape
-        # the enclosing <script> tag.
-        # r'<' is the 6-char literal string <, which JavaScript
-        # interprets as <.  This is the standard JSON-in-HTML hardening pattern.
-        safe_plugin_id_js = (
-            json.dumps(safe_id)
-            .replace('<', '\\u003c')
-            .replace('>', '\\u003e')
-            .replace('&', '\\u0026')
-        )
-
-        page = (
-            '<!DOCTYPE html>\n'
-            '<html lang="en">\n'
-            '<head>\n'
-            '<meta charset="UTF-8">\n'
-            '<meta name="viewport" content="width=device-width,initial-scale=1">\n'
-            '<script>\n'
-            # Inject plugin context before the fragment runs.
-            # plugin_id is validated to [a-zA-Z0-9_-] above, so this is safe,
-            # but we also Unicode-escape HTML meta-chars as defence in depth.
-            f'  window.PLUGIN_ID = {safe_plugin_id_js};\n'
-            '</script>\n'
-            # Tailwind v2 CDN — same version used by the parent LEDMatrix UI
-            '<link rel="stylesheet" '
-            'href="https://cdnjs.cloudflare.com/ajax/libs/tailwindcss/2.2.19/tailwind.min.css" '
-            'crossorigin="anonymous">\n'
-            '<style>body{margin:0;padding:0;background:#fff;}</style>\n'
-            '</head>\n'
-            '<body>\n'
-            + fragment +
-            '\n</body>\n</html>'
-        )
-        return page, 200, {'Content-Type': 'text/html; charset=utf-8'}
-
-    except ValueError:
-        return 'Forbidden', 403, {'Content-Type': 'text/plain'}
-    except Exception:
-        logger.error('Error serving plugin web_ui %s/%s', plugin_id, filename, exc_info=True)
-        return 'Error serving file', 500, {'Content-Type': 'text/plain'}
-
 def _load_overview_partial():
     """Load overview partial with system stats"""
     try:

web_interface/static/v3/app.js

@@ -1,4 +1,4 @@
-/* global showNotification, updateSystemStats, updateDisplayPreview, htmx */
+/* global showNotification, updateSystemStats, htmx */
 // LED Matrix v3 JavaScript
 // Additional helpers for HTMX and Alpine.js integration
 
@@ -51,8 +51,7 @@ document.body.addEventListener('htmx:afterRequest', function(event) {
     }
 });
 
-// SSE reconnection helper — closes and reopens both SSE streams,
-// reattaching the open/error handlers defined in base.html.
+// SSE reconnection helper
 window.reconnectSSE = function() {
     if (window.statsSource) {
         window.statsSource.close();
@@ -61,18 +60,14 @@ window.reconnectSSE = function() {
             const data = JSON.parse(event.data);
             if (typeof updateSystemStats === 'function') updateSystemStats(data);
         };
-        if (window._statsOpenHandler) window.statsSource.addEventListener('open', window._statsOpenHandler);
-        if (window._statsErrorHandler) window.statsSource.addEventListener('error', window._statsErrorHandler);
     }
 
     if (window.displaySource) {
         window.displaySource.close();
         window.displaySource = new EventSource('/api/v3/stream/display');
-        window.displaySource.onmessage = function(event) {
-            const data = JSON.parse(event.data);
-            if (typeof updateDisplayPreview === 'function') updateDisplayPreview(data);
+        window.displaySource.onmessage = function() {
+            // Handle display updates
         };
-        if (window._displayErrorHandler) window.displaySource.addEventListener('error', window._displayErrorHandler);
     }
 };
 

web_interface/static/v3/js/widgets/array-table.js

@@ -5,14 +5,21 @@
  * Handles adding, removing, and editing array items with object properties.
  * Reads column definitions from the schema's items.properties.
  *
- * Supported x-widget hints on item properties:
- *   date-picker  → <input type="date">
- *   time-picker  → <input type="time">
- *   file-upload-single → compact path input + upload button
- *   (enum values always render as <select>)
- *
- * Non-displayed properties (objects like layout/style) are stored in a hidden
- * cell and editable via the ⚙ row editor modal.
+ * Usage in config_schema.json:
+ *   "my_array": {
+ *     "type": "array",
+ *     "x-widget": "array-table",
+ *     "x-columns": ["name", "code", "priority", "enabled"],  // optional
+ *     "items": {
+ *       "type": "object",
+ *       "properties": {
+ *         "name": { "type": "string" },
+ *         "code": { "type": "string" },
+ *         "priority": { "type": "integer", "default": 50 },
+ *         "enabled": { "type": "boolean", "default": true }
+ *       }
+ *     }
+ *   }
  *
  * @module ArrayTableWidget
  */
@@ -20,16 +27,18 @@
 (function() {
     'use strict';
 
+    // Ensure LEDMatrixWidgets registry exists
     if (typeof window.LEDMatrixWidgets === 'undefined') {
         console.error('[ArrayTableWidget] LEDMatrixWidgets registry not found. Load registry.js first.');
         return;
     }
 
-    // ─── Widget registration ────────────────────────────────────────────────
-
+    /**
+     * Register the array-table widget
+     */
     window.LEDMatrixWidgets.register('array-table', {
         name: 'Array Table Widget',
-        version: '2.0.0',
+        version: '1.0.0',
 
         render: function(container, config, value, options) {
             console.log('[ArrayTableWidget] Render called (server-side rendered)');
@@ -44,39 +53,24 @@
 
             rows.forEach((row) => {
                 const item = {};
-
-                // Collect all named form controls (input + select), skip type=hidden except
-                // for boolean hidden sentinels (those end in the field name only, not .enabled).
-                row.querySelectorAll('input, select').forEach(el => {
-                    const name = el.getAttribute('name');
-                    if (!name) return;
-                    // Skip hidden inputs that are boolean sentinels (they duplicate checkboxes)
-                    if (el.type === 'hidden' && !el.dataset.nestedProp) return;
-
-                    // Nested advanced props stored in hidden cell
-                    if (el.dataset.nestedProp) {
-                        const propPath = el.dataset.nestedProp;
-                        setNestedValue(item, propPath, coerceValue(el.value, el.dataset.propType || 'string'));
-                        return;
-                    }
-
-                    // Standard display-column props: name matches fullKey.index.propName[.subKey...]
-                    const match = name.match(/\.\d+\.(.+)$/);
-                    if (!match) return;
-                    const propPath = match[1];
-
-                    if (el.tagName === 'SELECT') {
-                        setNestedValue(item, propPath, el.value);
-                    } else if (el.type === 'checkbox') {
-                        setNestedValue(item, propPath, el.checked);
-                    } else if (el.type === 'number') {
-                        setNestedValue(item, propPath, el.value !== '' ? parseFloat(el.value) : null);
-                    } else {
-                        setNestedValue(item, propPath, el.value);
+                row.querySelectorAll('input').forEach(input => {
+                    const name = input.getAttribute('name');
+                    if (!name || name.endsWith('.enabled') || input.type === 'hidden') return;
+                    const match = name.match(/\.\d+\.([^.]+)$/);
+                    if (match) {
+                        const propName = match[1];
+                        if (input.type === 'checkbox') {
+                            item[propName] = input.checked;
+                        } else if (input.type === 'number') {
+                            item[propName] = input.value ? parseFloat(input.value) : null;
+                        } else {
+                            item[propName] = input.value;
+                        }
                     }
                 });
-
-                if (Object.keys(item).length > 0) items.push(item);
+                if (Object.keys(item).length > 0) {
+                    items.push(item);
+                }
             });
 
             return items;
@@ -87,733 +81,236 @@
                 console.error('[ArrayTableWidget] setValue expects an array');
                 return;
             }
+
             if (!options || !options.fullKey || !options.pluginId) {
                 throw new Error('ArrayTableWidget.setValue requires options.fullKey and options.pluginId');
             }
 
             const tbody = document.getElementById(`${fieldId}_tbody`);
-            if (!tbody) return;
+            if (!tbody) {
+                console.warn(`[ArrayTableWidget] tbody not found for fieldId: ${fieldId}`);
+                return;
+            }
 
             tbody.innerHTML = '';
+
             items.forEach((item, index) => {
                 const row = createArrayTableRow(
-                    fieldId, options.fullKey, index, options.pluginId,
-                    item, options.itemProperties || {}, options.displayColumns || [],
-                    options.fullItemProperties || options.itemProperties || {}
+                    fieldId,
+                    options.fullKey,
+                    index,
+                    options.pluginId,
+                    item,
+                    options.itemProperties || {},
+                    options.displayColumns || []
                 );
                 tbody.appendChild(row);
             });
+
+            // Refresh Add button state after repopulating rows
             updateAddButtonState(fieldId);
         },
 
         handlers: {}
     });
 
-    // ─── Helpers ────────────────────────────────────────────────────────────
-
-    function safeSetHTML(target, html) {
-        target.textContent = '';
-        // createContextualFragment parses html relative to the document context
-        // without executing scripts — a widely recognised safe insertion method.
-        const frag = document.createRange().createContextualFragment(html);
-        target.appendChild(frag);
-    }
-
-    // Keys that must never be assigned to prevent prototype pollution.
-    const _FORBIDDEN_KEYS = new Set(['__proto__', 'prototype', 'constructor']);
-
-    function setNestedValue(obj, path, value) {
-        const parts = path.split('.');
-        let cur = obj;
-        for (let i = 0; i < parts.length - 1; i++) {
-            const key = parts[i];
-            if (_FORBIDDEN_KEYS.has(key)) return;
-            // Use hasOwnProperty to avoid reading inherited prototype properties,
-            // and defineProperty to write without triggering prototype setters.
-            if (!Object.hasOwn(cur, key) ||
-                typeof Object.getOwnPropertyDescriptor(cur, key).value !== 'object') {
-                Object.defineProperty(cur, key, {
-                    value: Object.create(null), writable: true,
-                    enumerable: true, configurable: true
-                });
-            }
-            cur = Object.getOwnPropertyDescriptor(cur, key).value;
-        }
-        const lastKey = parts[parts.length - 1];
-        if (!_FORBIDDEN_KEYS.has(lastKey)) {
-            Object.defineProperty(cur, lastKey, {
-                value: value, writable: true, enumerable: true, configurable: true
-            });
-        }
-    }
-
-    function coerceValue(strVal, typeHint) {
-        if (strVal === '' || strVal === null || strVal === undefined) return null;
-        if (typeHint === 'integer') return parseInt(strVal, 10);
-        if (typeHint === 'number') return parseFloat(strVal);
-        if (typeHint === 'boolean') return strVal === 'true' || strVal === '1';
-        // nullable integer/number: "integer|null"
-        if (typeHint && typeHint.includes('integer')) return strVal !== '' ? parseInt(strVal, 10) : null;
-        if (typeHint && typeHint.includes('number'))  return strVal !== '' ? parseFloat(strVal) : null;
-        return strVal;
-    }
-
-    // ─── Cell rendering ─────────────────────────────────────────────────────
-
     /**
-     * Create one <td> for a display column.
+     * Create a table row element for array item
      */
-    function createCell(fullKey, index, colName, colDef, colValue, pluginId) {
-        const colType   = Array.isArray(colDef.type) ? colDef.type.find(t => t !== 'null') || 'string' : (colDef.type || 'string');
-        const xWidget   = colDef['x-widget'] || colDef['x_widget'];
-        const enumVals  = colDef.enum;
-        const inputName = `${fullKey}.${index}.${colName}`;
-
-        const cell = document.createElement('td');
-        cell.className = 'px-3 py-3 whitespace-nowrap';
-        cell.style.verticalAlign = 'middle';
-
-        if (colType === 'boolean') {
-            // Boolean: hidden sentinel + visible checkbox
-            const hidden = document.createElement('input');
-            hidden.type  = 'hidden';
-            hidden.name  = inputName;
-            hidden.value = 'false';
-            cell.appendChild(hidden);
-
-            const cb = document.createElement('input');
-            cb.type      = 'checkbox';
-            cb.name      = inputName;
-            cb.checked   = Boolean(colValue);
-            cb.value     = 'true';
-            cb.className = 'h-4 w-4 text-blue-600';
-            cell.appendChild(cb);
-
-        } else if (colType === 'integer' || colType === 'number') {
-            const inp = document.createElement('input');
-            inp.type      = 'number';
-            inp.name      = inputName;
-            inp.value     = colValue !== null && colValue !== undefined ? colValue : '';
-            if (colDef.minimum !== undefined) inp.min  = colDef.minimum;
-            if (colDef.maximum !== undefined) inp.max  = colDef.maximum;
-            inp.step      = colType === 'integer' ? '1' : 'any';
-            inp.className = 'block w-20 px-2 py-1 border border-gray-300 rounded text-sm text-center';
-            if (colDef.description) inp.title = colDef.description;
-            cell.appendChild(inp);
-
-        } else if (Array.isArray(enumVals) && enumVals.length > 0) {
-            // Enum: render <select>
-            cell.style.minWidth = '90px';
-            const sel = document.createElement('select');
-            sel.name      = inputName;
-            sel.className = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm bg-white';
-            enumVals.forEach(opt => {
-                if (opt === null) return;
-                const o = document.createElement('option');
-                o.value    = opt;
-                o.textContent = opt;
-                if (String(colValue) === String(opt)) o.selected = true;
-                sel.appendChild(o);
-            });
-            // If current value didn't match any option, set to first
-            if (!sel.value && enumVals.length > 0) sel.value = enumVals[0];
-            cell.appendChild(sel);
-
-        } else if (xWidget === 'date-picker') {
-            cell.style.minWidth = '140px';
-            const inp = document.createElement('input');
-            inp.type      = 'date';
-            inp.name      = inputName;
-            inp.value     = colValue || '';
-            inp.className = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            inp.style.minWidth = '128px';
-            if (colDef.description) inp.title = colDef.description;
-            cell.appendChild(inp);
-
-        } else if (xWidget === 'time-picker') {
-            cell.style.minWidth = '115px';
-            const inp = document.createElement('input');
-            inp.type      = 'time';
-            inp.name      = inputName;
-            inp.value     = colValue || '00:00';
-            inp.className = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            inp.style.minWidth = '100px';
-            cell.appendChild(inp);
-
-        } else if (xWidget === 'file-upload-single') {
-            // Compact: text input (stores path) + upload button
-            cell.style.minWidth = '200px';
-            const wrap = document.createElement('div');
-            wrap.className = 'flex items-center gap-1';
-
-            const pathInput = document.createElement('input');
-            pathInput.type        = 'text';
-            pathInput.name        = inputName;
-            pathInput.id          = `${fullKey}_${index}_${colName}`.replace(/\./g,'_');
-            pathInput.value       = colValue || '';
-            pathInput.className   = 'block px-1 py-1 border border-gray-300 rounded text-xs flex-1';
-            pathInput.style.minWidth = '100px';
-            pathInput.placeholder = 'path…';
-
-            const preview = document.createElement('img');
-            preview.className    = 'w-6 h-6 object-cover rounded flex-shrink-0';
-            preview.style.display = colValue ? 'inline' : 'none';
-            if (colValue) { preview.src = '/' + colValue; preview.onerror = () => { preview.style.display = 'none'; }; }
-
-            const labelEl = document.createElement('label');
-            labelEl.className = 'cursor-pointer flex-shrink-0 inline-flex items-center px-1 py-1 bg-blue-50 border border-blue-200 rounded text-xs text-blue-600 hover:bg-blue-100';
-            labelEl.title = 'Upload image';
-            labelEl.innerHTML = '<i class="fas fa-upload"></i>';
-
-            const fileInput = document.createElement('input');
-            fileInput.type   = 'file';
-            fileInput.accept = 'image/png,image/jpeg,image/bmp,image/gif';
-            fileInput.style.display = 'none';
-            fileInput.dataset.pluginId    = pluginId;
-            fileInput.dataset.targetInput = pathInput.id;
-            fileInput.dataset.previewImg  = preview.id || '';
-            fileInput.onchange = function(e) {
-                window.handleArrayTableImageUpload(e, pathInput, preview, pluginId);
-            };
-            labelEl.appendChild(fileInput);
-
-            wrap.appendChild(preview);
-            wrap.appendChild(pathInput);
-            wrap.appendChild(labelEl);
-            cell.appendChild(wrap);
-
-        } else {
-            // Default: text input
-            const inp = document.createElement('input');
-            inp.type      = 'text';
-            inp.name      = inputName;
-            inp.value     = colValue !== null && colValue !== undefined ? colValue : '';
-            inp.className = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            if (colDef.description) inp.placeholder = colDef.description;
-            if (colDef.pattern)     inp.pattern = colDef.pattern;
-            if (colDef.minLength)   inp.minLength = colDef.minLength;
-            if (colDef.maxLength)   inp.maxLength = colDef.maxLength;
-            cell.appendChild(inp);
-        }
-
-        return cell;
-    }
-
-    /**
-     * Create a hidden <td> holding flat hidden inputs for non-displayed properties
-     * (including nested objects like layout/style).
-     */
-    function createAdvancedCell(fullKey, index, nonDisplayedProps, item) {
-        const cell = document.createElement('td');
-        cell.style.display = 'none';
-        cell.className = 'array-table-advanced-data';
-        cell.dataset.propSchema = JSON.stringify(nonDisplayedProps);
-
-        Object.entries(nonDisplayedProps).forEach(([propName, propSchema]) => {
-            const propType = Array.isArray(propSchema.type)
-                ? propSchema.type.find(t => t !== 'null') || 'string'
-                : (propSchema.type || 'string');
-
-            if (propType === 'object' && propSchema.properties) {
-                const nestedVal = (item && item[propName]) || {};
-                Object.entries(propSchema.properties).forEach(([subName, subSchema]) => {
-                    const subType = Array.isArray(subSchema.type)
-                        ? subSchema.type.find(t => t !== 'null') || 'string'
-                        : (subSchema.type || 'string');
-                    const defaultVal = subSchema.default !== undefined ? subSchema.default : null;
-                    const currentVal = nestedVal[subName] !== undefined ? nestedVal[subName] : defaultVal;
-
-                    const hidden = document.createElement('input');
-                    hidden.type  = 'hidden';
-                    hidden.name  = `${fullKey}.${index}.${propName}.${subName}`;
-                    hidden.value = currentVal !== null && currentVal !== undefined ? String(currentVal) : '';
-                    hidden.dataset.nestedProp = `${propName}.${subName}`;
-                    hidden.dataset.propType   = subType;
-                    hidden.dataset.propSchema = JSON.stringify(subSchema);
-                    cell.appendChild(hidden);
-                });
-            } else {
-                const defaultVal = propSchema.default !== undefined ? propSchema.default : null;
-                const currentVal = item && item[propName] !== undefined ? item[propName] : defaultVal;
-
-                const hidden = document.createElement('input');
-                hidden.type  = 'hidden';
-                hidden.name  = `${fullKey}.${index}.${propName}`;
-                hidden.value = currentVal !== null && currentVal !== undefined ? String(currentVal) : '';
-                hidden.dataset.nestedProp = propName;
-                hidden.dataset.propType   = propType;
-                hidden.dataset.propSchema = JSON.stringify(propSchema);
-                cell.appendChild(hidden);
-            }
-        });
-
-        return cell;
-    }
-
-    // ─── Row creation ────────────────────────────────────────────────────────
-
-    function createArrayTableRow(fieldId, fullKey, index, pluginId, item, itemProperties, displayColumns, fullItemProperties) {
-        item               = item || {};
-        fullItemProperties = fullItemProperties || itemProperties;
-
+    function createArrayTableRow(fieldId, fullKey, index, pluginId, item, itemProperties, displayColumns) {
+        item = item || {};
         const row = document.createElement('tr');
         row.className = 'array-table-row';
         row.setAttribute('data-index', index);
 
-        // Visible column cells
         displayColumns.forEach(colName => {
-            const colDef   = itemProperties[colName] || {};
-            const colType  = Array.isArray(colDef.type) ? colDef.type.find(t => t !== 'null') || 'string' : (colDef.type || 'string');
-            const colDefault = colDef.default !== undefined ? colDef.default
-                : (colType === 'boolean' ? false : colType === 'time-picker' ? '00:00' : '');
+            const colDef = itemProperties[colName] || {};
+            const colType = colDef.type || 'string';
+            const colDefault = colDef.default !== undefined ? colDef.default : (colType === 'boolean' ? false : '');
             const colValue = item[colName] !== undefined ? item[colName] : colDefault;
-            row.appendChild(createCell(fullKey, index, colName, colDef, colValue, pluginId));
-        });
 
-        // Determine non-displayed properties (these go into the advanced cell + edit modal)
-        const nonDisplayed = {};
-        Object.keys(fullItemProperties).forEach(k => {
-            if (!displayColumns.includes(k) && k !== 'id') {
-                nonDisplayed[k] = fullItemProperties[k];
+            const cell = document.createElement('td');
+            cell.className = 'px-4 py-3 whitespace-nowrap';
+
+            if (colType === 'boolean') {
+                const hiddenInput = document.createElement('input');
+                hiddenInput.type = 'hidden';
+                hiddenInput.name = `${fullKey}.${index}.${colName}`;
+                hiddenInput.value = 'false';
+                cell.appendChild(hiddenInput);
+
+                const checkbox = document.createElement('input');
+                checkbox.type = 'checkbox';
+                checkbox.name = `${fullKey}.${index}.${colName}`;
+                checkbox.checked = Boolean(colValue);
+                checkbox.value = 'true';
+                checkbox.className = 'h-4 w-4 text-blue-600';
+                cell.appendChild(checkbox);
+            } else if (colType === 'integer' || colType === 'number') {
+                const input = document.createElement('input');
+                input.type = 'number';
+                input.name = `${fullKey}.${index}.${colName}`;
+                input.value = colValue !== null && colValue !== undefined ? colValue : '';
+                if (colDef.minimum !== undefined) input.min = colDef.minimum;
+                if (colDef.maximum !== undefined) input.max = colDef.maximum;
+                input.step = colType === 'integer' ? '1' : 'any';
+                input.className = 'block w-20 px-2 py-1 border border-gray-300 rounded text-sm text-center';
+                if (colDef.description) input.title = colDef.description;
+                cell.appendChild(input);
+            } else {
+                const input = document.createElement('input');
+                input.type = 'text';
+                input.name = `${fullKey}.${index}.${colName}`;
+                input.value = colValue !== null && colValue !== undefined ? colValue : '';
+                input.className = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
+                if (colDef.description) input.placeholder = colDef.description;
+                if (colDef.pattern) input.pattern = colDef.pattern;
+                if (colDef.minLength) input.minLength = colDef.minLength;
+                if (colDef.maxLength) input.maxLength = colDef.maxLength;
+                cell.appendChild(input);
             }
+
+            row.appendChild(cell);
         });
-        const hasAdvanced = Object.keys(nonDisplayed).length > 0;
 
         // Actions cell
         const actionsCell = document.createElement('td');
-        actionsCell.className   = 'px-3 py-3 whitespace-nowrap text-center';
-        actionsCell.style.minWidth = '90px';
-        actionsCell.style.verticalAlign = 'middle';
-
-        const removeBtn = document.createElement('button');
-        removeBtn.type      = 'button';
-        removeBtn.className = 'text-red-600 hover:text-red-800 px-2 py-1';
-        removeBtn.onclick   = function() { window.removeArrayTableRow(this); };
-        removeBtn.innerHTML = '<i class="fas fa-trash"></i>';
-        actionsCell.appendChild(removeBtn);
-
-        if (hasAdvanced) {
-            const editBtn = document.createElement('button');
-            editBtn.type      = 'button';
-            editBtn.className = 'text-blue-500 hover:text-blue-700 px-2 py-1 ml-1';
-            editBtn.title     = 'Edit advanced properties (layout, style…)';
-            editBtn.onclick   = function() { window.openArrayTableRowEditor(this); };
-            editBtn.innerHTML = '<i class="fas fa-sliders-h"></i>';
-            actionsCell.appendChild(editBtn);
-        }
-
+        actionsCell.className = 'px-4 py-3 whitespace-nowrap text-center';
+        const removeButton = document.createElement('button');
+        removeButton.type = 'button';
+        removeButton.className = 'text-red-600 hover:text-red-800 px-2 py-1';
+        removeButton.onclick = function() { window.removeArrayTableRow(this); };
+        const removeIcon = document.createElement('i');
+        removeIcon.className = 'fas fa-trash';
+        removeButton.appendChild(removeIcon);
+        actionsCell.appendChild(removeButton);
         row.appendChild(actionsCell);
 
-        // Hidden advanced data cell
-        if (hasAdvanced) {
-            row.appendChild(createAdvancedCell(fullKey, index, nonDisplayed, item));
-        }
-
         return row;
     }
 
-    // ─── Row editor modal ────────────────────────────────────────────────────
-
-    window.openArrayTableRowEditor = function(button) {
-        const row         = button.closest('tr');
-        const advancedCell = row.querySelector('.array-table-advanced-data');
-        if (!advancedCell) return;
-
-        const schema = JSON.parse(advancedCell.dataset.propSchema || '{}');
-        // Close any existing modal
-        const existing = document.getElementById('array-row-editor-modal');
-        if (existing) existing.remove();
-
-        const overlay = document.createElement('div');
-        overlay.id        = 'array-row-editor-modal';
-        // Use inline styles for position/dimensions — inset-0 may be purged from the CSS bundle
-        // since it only appears in JS-generated markup, not in scanned templates.
-        overlay.style.cssText = 'position:fixed;top:0;left:0;right:0;bottom:0;z-index:9999;display:flex;align-items:center;justify-content:center;padding:1rem;background:rgba(0,0,0,0.5);';
-        overlay.onclick   = function(e) { if (e.target === overlay) window.closeArrayTableRowEditor(); };
-
-        const dialog = document.createElement('div');
-        dialog.className = 'bg-white rounded-lg shadow-xl max-w-lg w-full max-h-screen overflow-y-auto';
-
-        // Header
-        safeSetHTML(dialog, `
-            <div class="flex items-center justify-between px-5 py-4 border-b border-gray-200">
-                <h3 class="text-base font-semibold text-gray-900">Advanced Properties</h3>
-                <button type="button" onclick="window.closeArrayTableRowEditor()"
-                        class="text-gray-400 hover:text-gray-600"><i class="fas fa-times"></i></button>
-            </div>`);
-
-        const body = document.createElement('div');
-        body.className = 'px-5 py-4 space-y-4';
-
-        // Render a field for each advanced property
-        Object.entries(schema).forEach(([propName, propSchema]) => {
-            const propType = Array.isArray(propSchema.type)
-                ? propSchema.type.find(t => t !== 'null') || 'string'
-                : (propSchema.type || 'string');
-            const label = propSchema.title || propName.replace(/_/g, ' ').replace(/\b\w/g, c => c.toUpperCase());
-            const desc  = propSchema.description || '';
-
-            if (propType === 'object' && propSchema.properties) {
-                // Section for nested object
-                const section = document.createElement('div');
-                section.className = 'border border-gray-200 rounded-lg p-3';
-                const _secH4 = document.createElement('h4');
-                _secH4.className = 'text-sm font-medium text-gray-700 mb-3';
-                _secH4.textContent = label;
-                section.appendChild(_secH4);
-
-                const grid = document.createElement('div');
-                grid.className = 'grid grid-cols-2 gap-3';
-
-                Object.entries(propSchema.properties).forEach(([subName, subSchema]) => {
-                    const subType    = Array.isArray(subSchema.type) ? subSchema.type.find(t => t !== 'null') || 'string' : (subSchema.type || 'string');
-                    const subLabel   = subSchema.title || subName.replace(/_/g, ' ').replace(/\b\w/g, c => c.toUpperCase());
-                    const subDesc    = subSchema.description || '';
-                    const nestedPath = `${propName}.${subName}`;
-
-                    // Read current value from hidden input
-                    const hiddenInput = advancedCell.querySelector(`[data-nested-prop="${nestedPath}"]`);
-                    const currentVal  = hiddenInput ? hiddenInput.value : (subSchema.default !== undefined ? subSchema.default : '');
-
-                    const fieldDiv = document.createElement('div');
-                    const _subLbl = document.createElement('label');
-                    _subLbl.className = 'block text-xs font-medium text-gray-600 mb-1';
-                    _subLbl.title = subDesc;
-                    _subLbl.textContent = subLabel;
-                    fieldDiv.appendChild(_subLbl);
-                    fieldDiv.appendChild(buildModalInput(nestedPath, subSchema, subType, currentVal));
-                    grid.appendChild(fieldDiv);
-                });
-
-                section.appendChild(grid);
-                body.appendChild(section);
-            } else {
-                // Flat property
-                const hiddenInput = advancedCell.querySelector(`[data-nested-prop="${propName}"]`);
-                const currentVal  = hiddenInput ? hiddenInput.value : (propSchema.default !== undefined ? propSchema.default : '');
-
-                const fieldDiv = document.createElement('div');
-                const _flatLbl = document.createElement('label');
-                _flatLbl.className = 'block text-sm font-medium text-gray-700 mb-1';
-                _flatLbl.title = desc;
-                _flatLbl.textContent = label;
-                fieldDiv.appendChild(_flatLbl);
-                fieldDiv.appendChild(buildModalInput(propName, propSchema, propType, currentVal));
-                body.appendChild(fieldDiv);
-            }
-        });
-
-        dialog.appendChild(body);
-
-        // Footer
-        const footer = document.createElement('div');
-        footer.className = 'flex justify-end gap-3 px-5 py-4 border-t border-gray-200 bg-gray-50 rounded-b-lg';
-        safeSetHTML(footer, `
-            <button type="button" onclick="window.closeArrayTableRowEditor()"
-                    class="px-4 py-2 text-sm text-gray-700 border border-gray-300 rounded-md hover:bg-gray-100">Cancel</button>
-            <button type="button" id="array-row-editor-save"
-                    class="px-4 py-2 text-sm bg-blue-600 hover:bg-blue-700 text-white rounded-md">Save</button>`);
-
-        // Save handler
-        footer.querySelector('#array-row-editor-save').onclick = function() {
-            body.querySelectorAll('[data-modal-prop]').forEach(el => {
-                const propPath   = el.dataset.modalProp;
-                const targetInput = advancedCell.querySelector(`[data-nested-prop="${propPath}"]`);
-                if (!targetInput) return;
-                if (el.type === 'checkbox') {
-                    targetInput.value = el.checked ? 'true' : 'false';
-                } else {
-                    targetInput.value = el.value;
-                }
-            });
-            window.closeArrayTableRowEditor();
-        };
-
-        dialog.appendChild(footer);
-        overlay.appendChild(dialog);
-        document.body.appendChild(overlay);
-    };
-
-    window.closeArrayTableRowEditor = function() {
-        const modal = document.getElementById('array-row-editor-modal');
-        if (modal) modal.remove();
-    };
-
     /**
-     * Build a single form control for the row editor modal.
+     * Update the Add button's disabled state based on current row count
+     * @param {string} fieldId - Field ID to find the tbody and button
      */
-    function buildModalInput(propPath, schema, propType, currentVal) {
-        const xWidget  = schema['x-widget'] || schema['x_widget'];
-        const enumVals = schema.enum;
-        const wrap     = document.createElement('div');
-
-        if (propType === 'boolean') {
-            const cb = document.createElement('input');
-            cb.type              = 'checkbox';
-            cb.className         = 'h-4 w-4 text-blue-600';
-            cb.checked           = currentVal === 'true' || currentVal === true || currentVal === 1;
-            cb.dataset.modalProp = propPath;
-            wrap.appendChild(cb);
-            return wrap;
-        }
-
-        // Array[3] with x-widget color-picker → R/G/B row
-        if ((propType === 'array' || xWidget === 'color-picker') &&
-            (schema.minItems === 3 || schema.maxItems === 3 || xWidget === 'color-picker')) {
-            const parts  = currentVal ? String(currentVal).split(',').map(s => s.trim()) : ['', '', ''];
-            const rVal   = parts[0] || '';
-            const gVal   = parts[1] || '';
-            const bVal   = parts[2] || '';
-
-            // Hex color picker for visual selection
-            const hexVal = (rVal && gVal && bVal)
-                ? '#' + [rVal, gVal, bVal].map(n => parseInt(n, 10).toString(16).padStart(2, '0')).join('')
-                : '#ffffff';
-
-            const colorRow = document.createElement('div');
-            colorRow.className = 'flex items-center gap-2 flex-wrap';
-
-            const colorPick = document.createElement('input');
-            colorPick.type  = 'color';
-            colorPick.value = hexVal;
-            colorPick.className = 'h-8 w-10 cursor-pointer rounded border';
-            colorRow.appendChild(colorPick);
-
-            ['R', 'G', 'B'].forEach((ch, i) => {
-                const lbl = document.createElement('label');
-                lbl.className = 'text-xs text-gray-500';
-                lbl.textContent = ch;
-                const numInp = document.createElement('input');
-                numInp.type      = 'number';
-                numInp.min       = '0';
-                numInp.max       = '255';
-                numInp.step      = '1';
-                numInp.value     = [rVal, gVal, bVal][i];
-                numInp.className = 'w-14 px-1 py-1 border border-gray-300 rounded text-sm text-center';
-                numInp.dataset.colorChannel = i;
-                colorRow.appendChild(lbl);
-                colorRow.appendChild(numInp);
-            });
-
-            // Hidden aggregate input that the save handler reads
-            const agg = document.createElement('input');
-            agg.type              = 'hidden';
-            agg.value             = `${rVal},${gVal},${bVal}`;
-            agg.dataset.modalProp = propPath;
-            colorRow.appendChild(agg);
-
-            // Sync: color picker → R/G/B numbers + agg
-            colorPick.oninput = function() {
-                const hex = colorPick.value;
-                const r   = parseInt(hex.slice(1,3), 16);
-                const g   = parseInt(hex.slice(3,5), 16);
-                const b   = parseInt(hex.slice(5,7), 16);
-                const nums = colorRow.querySelectorAll('input[data-color-channel]');
-                if (nums[0]) nums[0].value = r;
-                if (nums[1]) nums[1].value = g;
-                if (nums[2]) nums[2].value = b;
-                agg.value = `${r},${g},${b}`;
-            };
-
-            // Sync: R/G/B numbers → color picker + agg
-            colorRow.querySelectorAll('input[data-color-channel]').forEach(inp => {
-                inp.oninput = function() {
-                    const nums = colorRow.querySelectorAll('input[data-color-channel]');
-                    const r = parseInt(nums[0] ? nums[0].value : 0, 10) || 0;
-                    const g = parseInt(nums[1] ? nums[1].value : 0, 10) || 0;
-                    const b = parseInt(nums[2] ? nums[2].value : 0, 10) || 0;
-                    colorPick.value = '#' + [r,g,b].map(n => n.toString(16).padStart(2,'0')).join('');
-                    agg.value = `${r},${g},${b}`;
-                };
-            });
-
-            wrap.appendChild(colorRow);
-            return wrap;
-        }
-
-        if (Array.isArray(enumVals) && enumVals.length > 0) {
-            const sel = document.createElement('select');
-            sel.className        = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm bg-white';
-            sel.dataset.modalProp = propPath;
-            enumVals.forEach(opt => {
-                if (opt === null) return;
-                const o = document.createElement('option');
-                o.value = opt; o.textContent = opt;
-                if (String(currentVal) === String(opt)) o.selected = true;
-                sel.appendChild(o);
-            });
-            wrap.appendChild(sel);
-            return wrap;
-        }
-
-        if (xWidget === 'date-picker') {
-            const inp = document.createElement('input');
-            inp.type              = 'date';
-            inp.value             = currentVal || '';
-            inp.className         = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            inp.dataset.modalProp = propPath;
-            wrap.appendChild(inp);
-            return wrap;
-        }
-
-        if (xWidget === 'time-picker') {
-            const inp = document.createElement('input');
-            inp.type              = 'time';
-            inp.value             = currentVal || '00:00';
-            inp.className         = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            inp.dataset.modalProp = propPath;
-            wrap.appendChild(inp);
-            return wrap;
-        }
-
-        if (propType === 'integer' || propType === 'number') {
-            const inp = document.createElement('input');
-            inp.type              = 'number';
-            inp.value             = currentVal !== '' && currentVal !== null ? currentVal : '';
-            inp.className         = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-            inp.dataset.modalProp = propPath;
-            if (schema.minimum !== undefined) inp.min  = schema.minimum;
-            if (schema.maximum !== undefined) inp.max  = schema.maximum;
-            inp.step = propType === 'integer' ? '1' : 'any';
-            if (schema.description) inp.placeholder = schema.description;
-            wrap.appendChild(inp);
-            return wrap;
-        }
-
-        // Default: text
-        const inp = document.createElement('input');
-        inp.type              = 'text';
-        inp.value             = currentVal || '';
-        inp.className         = 'block w-full px-2 py-1 border border-gray-300 rounded text-sm';
-        inp.dataset.modalProp = propPath;
-        if (schema.description) inp.placeholder = schema.description;
-        wrap.appendChild(inp);
-        return wrap;
-    }
-
-
-    // ─── In-cell image upload ────────────────────────────────────────────────
-
-    /**
-     * Called from file-upload-single cells inside array-table rows.
-     * Uploads the selected file and updates the path text input.
-     */
-    window.handleArrayTableImageUpload = async function(event, pathInput, previewImg, pluginId) {
-        const file = event.target.files && event.target.files[0];
-        if (!file) return;
-
-        const notifyFn = window.showNotification || console.log;
-        const allowed  = ['image/png', 'image/jpeg', 'image/bmp', 'image/gif'];
-        if (!allowed.includes(file.type)) {
-            notifyFn(`File type "${file.type}" not allowed`, 'error');
-            return;
-        }
-        if (file.size > 5 * 1024 * 1024) {
-            notifyFn('File exceeds 5MB limit', 'error');
-            return;
-        }
-
-        const formData = new FormData();
-        formData.append('plugin_id', pluginId);
-        formData.append('files', file);
-
-        try {
-            const resp = await fetch('/api/v3/plugins/assets/upload', { method: 'POST', body: formData });
-            if (!resp.ok) throw new Error(`Server error ${resp.status}`);
-            const data = await resp.json();
-            if (data.status === 'success' && data.uploaded_files && data.uploaded_files[0]) {
-                const path = data.uploaded_files[0].path;
-                pathInput.value = path;
-                if (previewImg) { previewImg.src = '/' + path; previewImg.style.display = 'inline'; }
-                notifyFn('Image uploaded', 'success');
-            } else {
-                throw new Error(data.message || 'Upload failed');
-            }
-        } catch (err) {
-            notifyFn('Upload error: ' + err.message, 'error');
-        } finally {
-            event.target.value = '';
-        }
-    };
-
-    // ─── Button helpers ──────────────────────────────────────────────────────
-
     function updateAddButtonState(fieldId) {
-        const tbody     = document.getElementById(fieldId + '_tbody');
+        const tbody = document.getElementById(fieldId + '_tbody');
+        if (!tbody) return;
+
+        // Find the add button by looking for the button with matching data-field-id
         const addButton = document.querySelector(`button[data-field-id="${fieldId}"]`);
-        if (!tbody || !addButton) return;
-        const maxItems    = parseInt(addButton.getAttribute('data-max-items'), 10);
-        const currentRows = tbody.querySelectorAll('.array-table-row').length;
-        const isAtMax     = currentRows >= maxItems;
-        addButton.disabled    = isAtMax;
+        if (!addButton) return;
+
+        const maxItems = parseInt(addButton.getAttribute('data-max-items'), 10);
+        const currentRows = tbody.querySelectorAll('.array-table-row');
+        const isAtMax = currentRows.length >= maxItems;
+
+        addButton.disabled = isAtMax;
         addButton.style.opacity = isAtMax ? '0.5' : '';
     }
 
+    // Expose for external use if needed
     window.updateArrayTableAddButtonState = updateAddButtonState;
 
+    /**
+     * Add a new row to the array table
+     * @param {HTMLElement} button - The button element with data attributes
+     */
     window.addArrayTableRow = function(button) {
-        const fieldId        = button.getAttribute('data-field-id');
-        const fullKey        = button.getAttribute('data-full-key');
-        const maxItems       = parseInt(button.getAttribute('data-max-items'), 10);
-        const pluginId       = button.getAttribute('data-plugin-id');
+        const fieldId = button.getAttribute('data-field-id');
+        const fullKey = button.getAttribute('data-full-key');
+        const maxItems = parseInt(button.getAttribute('data-max-items'), 10);
+        const pluginId = button.getAttribute('data-plugin-id');
 
-        let itemProperties     = {};
-        let displayColumns     = [];
-        let fullItemProperties = {};
+        // Parse JSON with fallback on error
+        let itemProperties = {};
+        let displayColumns = [];
+        const rawItemProps = button.getAttribute('data-item-properties') || '{}';
+        const rawDisplayCols = button.getAttribute('data-display-columns') || '[]';
 
-        try { itemProperties     = JSON.parse(button.getAttribute('data-item-properties')     || '{}'); } catch(_e) {}
-        try { displayColumns     = JSON.parse(button.getAttribute('data-display-columns')      || '[]'); } catch(_e) {}
-        try { fullItemProperties = JSON.parse(button.getAttribute('data-full-item-properties') || '{}'); } catch(_e) { fullItemProperties = itemProperties; }
+        try {
+            itemProperties = JSON.parse(rawItemProps);
+        } catch (e) {
+            console.error('[ArrayTableWidget] Failed to parse data-item-properties:', rawItemProps, e);
+            itemProperties = {};
+        }
+
+        try {
+            displayColumns = JSON.parse(rawDisplayCols);
+        } catch (e) {
+            console.error('[ArrayTableWidget] Failed to parse data-display-columns:', rawDisplayCols, e);
+            displayColumns = [];
+        }
 
         const tbody = document.getElementById(fieldId + '_tbody');
         if (!tbody) return;
 
-        const currentRows = tbody.querySelectorAll('.array-table-row').length;
-        if (currentRows >= maxItems) {
-            (window.showNotification || alert)(`Maximum ${maxItems} items allowed`, 'error');
+        const currentRows = tbody.querySelectorAll('.array-table-row');
+        if (currentRows.length >= maxItems) {
+            const notifyFn = window.showNotification || alert;
+            notifyFn(`Maximum ${maxItems} items allowed`, 'error');
             return;
         }
 
-        const newIndex = currentRows;
-        const row = createArrayTableRow(fieldId, fullKey, newIndex, pluginId, {}, itemProperties, displayColumns, fullItemProperties);
+        const newIndex = currentRows.length;
+        const row = createArrayTableRow(fieldId, fullKey, newIndex, pluginId, {}, itemProperties, displayColumns);
         tbody.appendChild(row);
+
+        // Update button state after adding
         updateAddButtonState(fieldId);
     };
 
+    /**
+     * Remove a row from the array table
+     * @param {HTMLElement} button - The remove button element
+     */
     window.removeArrayTableRow = function(button) {
         const row = button.closest('tr');
         if (!row) return;
-        if (!confirm('Remove this item?')) return;
 
-        const tbody  = row.parentElement;
-        if (!tbody) return;
-        const fieldId = tbody.id.replace('_tbody', '');
-        row.remove();
+        if (confirm('Remove this item?')) {
+            const tbody = row.parentElement;
+            if (!tbody) return;
 
-        // Re-index remaining rows
-        tbody.querySelectorAll('.array-table-row').forEach((r, index) => {
-            r.setAttribute('data-index', index);
-            r.querySelectorAll('input, select').forEach(el => {
-                const name = el.getAttribute('name');
-                if (name) el.setAttribute('name', name.replace(/\.\d+\./, '.' + index + '.'));
-                // Also update data-nested-prop-based inputs (they don't have regular names needing re-index)
+            // Get fieldId from tbody id (format: {fieldId}_tbody)
+            const fieldId = tbody.id.replace('_tbody', '');
+
+            row.remove();
+
+            // Re-index remaining rows
+            const rows = tbody.querySelectorAll('.array-table-row');
+            rows.forEach(function(r, index) {
+                r.setAttribute('data-index', index);
+                r.querySelectorAll('input').forEach(function(input) {
+                    const name = input.getAttribute('name');
+                    if (name) {
+                        input.setAttribute('name', name.replace(/\.\d+\./, '.' + index + '.'));
+                    }
+                });
             });
-        });
 
-        updateAddButtonState(fieldId);
+            // Update button state after removing
+            updateAddButtonState(fieldId);
+        }
     };
 
+    /**
+     * Initialize all array table add buttons on page load
+     */
     function initArrayTableButtons() {
-        document.querySelectorAll('button[data-field-id][data-max-items]').forEach(button => {
-            updateAddButtonState(button.getAttribute('data-field-id'));
+        const addButtons = document.querySelectorAll('button[data-field-id][data-max-items]');
+        addButtons.forEach(function(button) {
+            const fieldId = button.getAttribute('data-field-id');
+            updateAddButtonState(fieldId);
         });
     }
 
+    // Initialize on DOM ready
     if (document.readyState === 'loading') {
         document.addEventListener('DOMContentLoaded', initArrayTableButtons);
     } else {
         initArrayTableButtons();
     }
 
-    console.log('[ArrayTableWidget] Array table widget registered (v2.0.0)');
+    console.log('[ArrayTableWidget] Array table widget registered');
 })();

web_interface/static/v3/js/widgets/file-upload-single.js

@@ -1,291 +0,0 @@
-/**
- * LEDMatrix File Upload Single Widget
- *
- * Single-image upload for string fields. Uploads to the plugin's asset folder
- * and sets the string field value to the returned relative path.
- * Designed for per-item image fields within array-table rows.
- *
- * The plugin_id is injected automatically from the template context
- * via options.pluginId — no need to specify it in the schema.
- *
- * Schema example (any plugin):
- * {
- *   "image_path": {
- *     "type": "string",
- *     "x-widget": "file-upload-single",
- *     "x-upload-config": {
- *       "allowed_types": ["image/png", "image/jpeg", "image/bmp", "image/gif"],
- *       "max_size_mb": 5
- *     }
- *   }
- * }
- *
- * @module FileUploadSingleWidget
- */
-
-(function() {
-    'use strict';
-
-    if (typeof window.LEDMatrixWidgets === 'undefined') {
-        console.error('[FileUploadSingleWidget] LEDMatrixWidgets registry not found. Load registry.js first.');
-        return;
-    }
-
-    const base = window.BaseWidget ? new window.BaseWidget('FileUploadSingle', '1.0.0') : null;
-
-    function escapeHtml(text) {
-        if (base) return base.escapeHtml(text);
-        const div = document.createElement('div');
-        div.textContent = String(text);
-        return div.innerHTML.replace(/"/g, '"').replace(/'/g, ''');
-    }
-
-    function sanitizeId(id) {
-        if (base) return base.sanitizeId(id);
-        return String(id).replace(/[^a-zA-Z0-9_-]/g, '_');
-    }
-
-    function triggerChange(fieldId, value) {
-        if (base) {
-            base.triggerChange(fieldId, value);
-        } else {
-            document.dispatchEvent(new CustomEvent('widget-change', {
-                detail: { fieldId, value },
-                bubbles: true,
-                cancelable: true
-            }));
-        }
-    }
-
-    function isImagePath(path) {
-        if (!path) return false;
-        return /\.(png|jpg|jpeg|bmp|gif)$/i.test(path);
-    }
-
-    function safeSetHTML(target, html) {
-        target.textContent = '';
-        // createContextualFragment parses html relative to the document context
-        // without executing scripts — a widely recognised safe insertion method.
-        const frag = document.createRange().createContextualFragment(html);
-        target.appendChild(frag);
-    }
-
-    window.LEDMatrixWidgets.register('file-upload-single', {
-        name: 'File Upload Single Widget',
-        version: '1.0.0',
-
-        render: function(container, config, value, options) {
-            const fieldId = sanitizeId(options.fieldId || container.id || 'file_upload_single');
-            const uploadConfig = config['x-upload-config'] || config['x_upload_config'] || {};
-            const allowedTypes = (uploadConfig.allowed_types || ['image/png', 'image/jpeg', 'image/bmp', 'image/gif']).join(',');
-            const maxSizeMb = uploadConfig.max_size_mb || 5;
-            const pluginId = options.pluginId || '';
-            const currentValue = value || '';
-            const hasImage = isImagePath(currentValue);
-
-            let html = `<div id="${fieldId}_widget" class="file-upload-single-widget" data-field-id="${fieldId}" data-plugin-id="${escapeHtml(pluginId)}">`;
-
-            // Hidden input carries the actual string value
-            html += `<input type="hidden" id="${fieldId}" name="${escapeHtml(options.name || fieldId)}" value="${escapeHtml(currentValue)}">`;
-
-            // Preview area (shown when a value is set)
-            html += `<div id="${fieldId}_preview" class="${hasImage ? '' : 'hidden'} flex items-center space-x-3 mb-2 p-2 bg-gray-50 rounded border border-gray-200">`;
-            html += `<img id="${fieldId}_thumb" src="/${escapeHtml(currentValue)}" alt="Preview"
-                          class="w-12 h-12 object-cover rounded"
-                          onerror="this.style.display='none';document.getElementById('${fieldId}_thumb_placeholder').style.display='flex'">`;
-            html += `<div id="${fieldId}_thumb_placeholder" style="display:none" class="w-12 h-12 bg-gray-200 rounded flex items-center justify-center">
-                         <i class="fas fa-image text-gray-400 text-lg"></i>
-                     </div>`;
-            html += `<div class="flex-1 min-w-0">
-                         <p id="${fieldId}_filename" class="text-xs text-gray-600 truncate">${escapeHtml(currentValue.split('/').pop() || '')}</p>
-                         <p id="${fieldId}_fullpath" class="text-xs text-gray-400">${escapeHtml(currentValue)}</p>
-                     </div>`;
-            html += `<button type="button"
-                             onclick="window.LEDMatrixWidgets.getHandlers('file-upload-single').onClear('${fieldId}')"
-                             class="flex-shrink-0 text-red-400 hover:text-red-600 p-1" title="Remove image">
-                         <i class="fas fa-times"></i>
-                     </button>`;
-            html += '</div>';
-
-            // Upload drop zone — keyboard accessible via tabindex + Enter/Space
-            html += `<div id="${fieldId}_drop_zone"
-                          class="border-2 border-dashed border-gray-300 rounded-lg p-3 text-center hover:border-blue-400 transition-colors cursor-pointer"
-                          role="button" tabindex="0"
-                          aria-label="${hasImage ? 'Replace image' : 'Upload image'}"
-                          ondrop="window.LEDMatrixWidgets.getHandlers('file-upload-single').onDrop(event, '${fieldId}')"
-                          ondragover="event.preventDefault()"
-                          onclick="document.getElementById('${fieldId}_file_input').click()"
-                          onkeydown="if(event.key==='Enter'||event.key===' '){event.preventDefault();document.getElementById('${fieldId}_file_input').click();}">
-                         <input type="file"
-                                id="${fieldId}_file_input"
-                                accept="${escapeHtml(allowedTypes)}"
-                                style="display:none"
-                                data-field-id="${fieldId}"
-                                data-plugin-id="${escapeHtml(pluginId)}"
-                                data-max-size-mb="${maxSizeMb}"
-                                data-allowed-types="${escapeHtml(allowedTypes)}"
-                                onchange="window.LEDMatrixWidgets.getHandlers('file-upload-single').onFileSelect(event, '${fieldId}')">
-                         <i class="fas fa-cloud-upload-alt text-xl text-gray-400 mb-1"></i>
-                         <p class="text-xs text-gray-500">${hasImage ? 'Click to replace image' : 'Click or drag to upload image'}</p>
-                         <p class="text-xs text-gray-400">Max ${maxSizeMb}MB</p>
-                     </div>`;
-
-            // Status area for upload feedback
-            html += `<div id="${fieldId}_status" class="mt-1 text-xs hidden"></div>`;
-
-            html += '</div>';
-            safeSetHTML(container, html);
-        },
-
-        getValue: function(fieldId) {
-            const safeId = sanitizeId(fieldId);
-            const input = document.getElementById(safeId);
-            return input ? input.value : '';
-        },
-
-        setValue: function(fieldId, value) {
-            const safeId = sanitizeId(fieldId);
-            const hidden = document.getElementById(safeId);
-            const preview = document.getElementById(`${safeId}_preview`);
-            const thumb = document.getElementById(`${safeId}_thumb`);
-            const thumbPlaceholder = document.getElementById(`${safeId}_thumb_placeholder`);
-            const filename = document.getElementById(`${safeId}_filename`);
-            const dropZone = document.getElementById(`${safeId}_drop_zone`);
-
-            if (hidden) hidden.value = value || '';
-
-            const hasImage = isImagePath(value);
-            if (preview) preview.classList.toggle('hidden', !hasImage);
-            if (thumb && hasImage) {
-                thumb.src = `/${value}`;
-                thumb.style.display = '';
-                if (thumbPlaceholder) thumbPlaceholder.style.display = 'none';
-            }
-            if (filename) filename.textContent = hasImage ? value.split('/').pop() : '';
-            const fullpath = document.getElementById(`${safeId}_fullpath`);
-            if (fullpath) fullpath.textContent = value || '';
-
-            // Update drop zone hint text
-            const hint = dropZone ? dropZone.querySelector('p') : null;
-            if (hint) hint.textContent = hasImage ? 'Click to replace image' : 'Click or drag to upload image';
-        },
-
-        handlers: {
-            onFileSelect: function(event, fieldId) {
-                const files = event.target.files;
-                if (files && files.length > 0) {
-                    window.LEDMatrixWidgets.getHandlers('file-upload-single').uploadFile(fieldId, files[0]);
-                }
-            },
-
-            onDrop: function(event, fieldId) {
-                event.preventDefault();
-                const files = event.dataTransfer.files;
-                if (files && files.length > 0) {
-                    window.LEDMatrixWidgets.getHandlers('file-upload-single').uploadFile(fieldId, files[0]);
-                }
-            },
-
-            onClear: function(fieldId) {
-                const widget = window.LEDMatrixWidgets.get('file-upload-single');
-                widget.setValue(fieldId, '');
-                triggerChange(fieldId, '');
-                // Reset file input so the same file can be re-selected
-                const fileInput = document.getElementById(`${sanitizeId(fieldId)}_file_input`);
-                if (fileInput) fileInput.value = '';
-            },
-
-            uploadFile: async function(fieldId, file) {
-                const safeId = sanitizeId(fieldId);
-                const fileInput = document.getElementById(`${safeId}_file_input`);
-                const statusDiv = document.getElementById(`${safeId}_status`);
-                const notifyFn = window.showNotification || console.log;
-
-                // Read config from the file input data attributes
-                const pluginId = (fileInput && fileInput.dataset.pluginId) || '';
-                const maxSizeMb = parseFloat((fileInput && fileInput.dataset.maxSizeMb) || '5');
-                const allowedTypes = ((fileInput && fileInput.dataset.allowedTypes) || 'image/png,image/jpeg,image/bmp,image/gif')
-                    .split(',').map(t => t.trim());
-
-                if (!pluginId) {
-                    notifyFn('Plugin ID not set — cannot upload', 'error');
-                    return;
-                }
-
-                // Validate type
-                if (!allowedTypes.includes(file.type)) {
-                    notifyFn(`File type "${file.type}" not allowed`, 'error');
-                    return;
-                }
-
-                // Validate size
-                if (file.size > maxSizeMb * 1024 * 1024) {
-                    notifyFn(`File exceeds ${maxSizeMb}MB limit`, 'error');
-                    return;
-                }
-
-                // Show uploading status — use DOM methods to avoid innerHTML with dynamic data
-                if (statusDiv) {
-                    statusDiv.className = 'mt-1 text-xs text-gray-500';
-                    statusDiv.textContent = '';
-                    const spinner = document.createElement('i');
-                    spinner.className = 'fas fa-spinner fa-spin mr-1';
-                    statusDiv.appendChild(spinner);
-                    statusDiv.appendChild(document.createTextNode('Uploading…'));
-                }
-
-                const formData = new FormData();
-                formData.append('plugin_id', pluginId);
-                formData.append('files', file);
-
-                try {
-                    const response = await fetch('/api/v3/plugins/assets/upload', {
-                        method: 'POST',
-                        body: formData
-                    });
-
-                    if (!response.ok) {
-                        const body = await response.text();
-                        throw new Error(`Server error ${response.status}: ${body}`);
-                    }
-
-                    const data = await response.json();
-
-                    if (data.status === 'success' && data.uploaded_files && data.uploaded_files.length > 0) {
-                        const uploadedPath = data.uploaded_files[0].path;
-                        const widget = window.LEDMatrixWidgets.get('file-upload-single');
-                        widget.setValue(fieldId, uploadedPath);
-                        triggerChange(fieldId, uploadedPath);
-
-                        if (statusDiv) {
-                            statusDiv.className = 'mt-1 text-xs text-green-600';
-                            statusDiv.textContent = '';
-                            const icon = document.createElement('i');
-                            icon.className = 'fas fa-check-circle mr-1';
-                            statusDiv.appendChild(icon);
-                            statusDiv.appendChild(document.createTextNode('Uploaded successfully'));
-                            setTimeout(() => { statusDiv.className = 'mt-1 text-xs hidden'; statusDiv.textContent = ''; }, 3000);
-                        }
-                        notifyFn('Image uploaded successfully', 'success');
-                    } else {
-                        throw new Error(data.message || 'Upload failed');
-                    }
-                } catch (error) {
-                    if (statusDiv) {
-                        statusDiv.className = 'mt-1 text-xs text-red-600';
-                        statusDiv.textContent = '';
-                        const errIcon = document.createElement('i');
-                        errIcon.className = 'fas fa-exclamation-circle mr-1';
-                        statusDiv.appendChild(errIcon);
-                        statusDiv.appendChild(document.createTextNode(error.message || 'Upload failed'));
-                    }
-                    notifyFn(`Upload error: ${error.message}`, 'error');
-                } finally {
-                    if (fileInput) fileInput.value = '';
-                }
-            }
-        }
-    });
-
-    console.log('[FileUploadSingleWidget] File upload single widget registered');
-})();

web_interface/static/v3/js/widgets/json-file-manager.js

@@ -1,783 +0,0 @@
-/**
- * JsonFileManager — reusable JSON file management widget for LEDMatrix plugins.
- *
- * Usage via config_schema.json:
- *   "file_manager": {
- *     "type": "null",
- *     "title": "Data Files",
- *     "x-widget": "json-file-manager",
- *     "x-widget-config": {
- *       "actions": {
- *         "list":   "list-files",   // required
- *         "get":    "get-file",     // required for editing
- *         "save":   "save-file",    // required for editing
- *         "upload": "upload-file",  // optional
- *         "delete": "delete-file",  // optional
- *         "create": "create-file",  // optional
- *         "toggle": "toggle-category" // optional
- *       },
- *       "upload_hint":      "Hint text under the drop zone",
- *       "directory_label":  "of_the_day/",
- *       "create_fields": [
- *         { "key": "category_name", "label": "Category Name",
- *           "placeholder": "my_words", "pattern": "^[a-z0-9_]+$",
- *           "hint": "Used as filename" },
- *         { "key": "display_name", "label": "Display Name",
- *           "placeholder": "My Words" }
- *       ],
- *       "toggle_key": "category_name"
- *     }
- *   }
- *
- * No CDN dependencies. Works on all modern browsers.
- */
-(function () {
-    'use strict';
-
-    class JsonFileManager {
-        constructor(container, config, pluginId) {
-            // Prevent duplicate instances on the same container
-            if (container._jfmInstance) {
-                container._jfmInstance._destroy();
-            }
-            container._jfmInstance = this;
-
-            this.el         = container;
-            this.pluginId   = pluginId;
-            this.actions    = config.actions || {};
-            this.uploadHint = config.upload_hint || '';
-            this.dirLabel   = config.directory_label || '';
-            this.createFields = config.create_fields || [];
-            this.toggleKey  = config.toggle_key || null;
-
-            // Unique prefix for all DOM IDs in this instance
-            this._uid = 'jfm_' + Array.from(crypto.getRandomValues(new Uint8Array(4)), b => b.toString(16).padStart(2, '0')).join('');
-
-            // Mutable state
-            this._editFile   = null;
-            this._deleteFile = null;
-            this._keyHandler = this._onKey.bind(this);
-
-            this._inject();
-            this._bind();
-            this._loadList();
-        }
-
-        // ── Lifecycle ────────────────────────────────────────────────────────
-
-        _destroy() {
-            document.removeEventListener('keydown', this._keyHandler);
-            this.el._jfmInstance = null;
-        }
-
-        // ── DOM Injection ────────────────────────────────────────────────────
-
-        _inject() {
-            const u = this._uid;
-            const hasUpload = !!this.actions.upload;
-            const hasCreate = !!this.actions.create;
-            const hasDelete = !!this.actions.delete;
-
-            this.el.innerHTML = this._css(u) + `
-<div id="${u}" class="jfm">
-
-  <div class="jfm-header">
-    <div class="jfm-header-left">
-      <span class="jfm-title">Data Files</span>
-      ${this.dirLabel ? `<code class="jfm-dir">${this._esc(this.dirLabel)}</code>` : ''}
-    </div>
-    <div class="jfm-header-right">
-      ${hasCreate ? `<button type="button" class="jfm-btn jfm-btn-primary jfm-btn-sm" data-jfm="open-create">+ New File</button>` : ''}
-      <button type="button" class="jfm-btn jfm-btn-ghost jfm-btn-sm" data-jfm="refresh" title="Refresh file list">&#8635;</button>
-    </div>
-  </div>
-
-  <div id="${u}-list" class="jfm-list">
-    <div class="jfm-loading"><span class="jfm-spin"></span> Loading…</div>
-  </div>
-
-  ${hasUpload ? `
-  <div class="jfm-upload-wrap">
-    <input type="file" accept=".json" id="${u}-fileinput" tabindex="-1">
-    <div class="jfm-dropzone" id="${u}-dropzone" data-jfm="open-picker" role="button" tabindex="0"
-         aria-label="Upload JSON file">
-      <span class="jfm-drop-icon">&#128193;</span>
-      <p class="jfm-drop-primary">Drop a JSON file here, or click to browse</p>
-      ${this.uploadHint ? `<p class="jfm-drop-hint">${this._esc(this.uploadHint)}</p>` : ''}
-    </div>
-  </div>` : ''}
-
-  <!-- ── Edit modal ─────────────────────────────────────── -->
-  <div class="jfm-modal" id="${u}-edit-modal" role="dialog" aria-modal="true" hidden>
-    <div class="jfm-modal-box jfm-modal-wide">
-      <div class="jfm-modal-head">
-        <span id="${u}-edit-title" class="jfm-modal-title">Edit file</span>
-        <div class="jfm-modal-tools">
-          <button type="button" class="jfm-btn jfm-btn-ghost jfm-btn-sm" data-jfm="fmt">Format</button>
-          <button type="button" class="jfm-btn jfm-btn-ghost jfm-btn-sm" data-jfm="validate">Validate</button>
-          <button type="button" class="jfm-close-btn" data-jfm="close-edit" aria-label="Close">&times;</button>
-        </div>
-      </div>
-      <div id="${u}-edit-err" class="jfm-err-bar" hidden></div>
-      <textarea id="${u}-editor" class="jfm-editor"
-                spellcheck="false" autocomplete="off"
-                autocorrect="off" autocapitalize="off"
-                aria-label="JSON editor"></textarea>
-      <div class="jfm-modal-foot">
-        <span id="${u}-charcount" class="jfm-stat"></span>
-        <button type="button" class="jfm-btn jfm-btn-ghost" data-jfm="close-edit">Cancel</button>
-        <button type="button" class="jfm-btn jfm-btn-primary" data-jfm="save" id="${u}-save-btn">Save</button>
-      </div>
-    </div>
-  </div>
-
-  <!-- ── Delete modal ───────────────────────────────────── -->
-  ${hasDelete ? `
-  <div class="jfm-modal" id="${u}-del-modal" role="dialog" aria-modal="true" hidden>
-    <div class="jfm-modal-box">
-      <div class="jfm-modal-head">
-        <span class="jfm-modal-title">Delete file</span>
-        <button type="button" class="jfm-close-btn" data-jfm="close-del" aria-label="Close">&times;</button>
-      </div>
-      <div class="jfm-modal-body">
-        <p>Delete <strong id="${u}-del-name"></strong>?</p>
-        <p class="jfm-muted">This permanently removes the file and its entry from the plugin configuration.</p>
-      </div>
-      <div class="jfm-modal-foot">
-        <button type="button" class="jfm-btn jfm-btn-ghost" data-jfm="close-del">Cancel</button>
-        <button type="button" class="jfm-btn jfm-btn-danger" data-jfm="confirm-del" id="${u}-del-btn">Delete</button>
-      </div>
-    </div>
-  </div>` : ''}
-
-  <!-- ── Create modal ───────────────────────────────────── -->
-  ${hasCreate ? `
-  <div class="jfm-modal" id="${u}-create-modal" role="dialog" aria-modal="true" hidden>
-    <div class="jfm-modal-box">
-      <div class="jfm-modal-head">
-        <span class="jfm-modal-title">Create new file</span>
-        <button type="button" class="jfm-close-btn" data-jfm="close-create" aria-label="Close">&times;</button>
-      </div>
-      <div class="jfm-modal-body">
-        ${this.createFields.map(f => `
-        <div class="jfm-field">
-          <label for="${u}-cf-${this._esc(f.key)}">${this._esc(f.label)}</label>
-          <input type="text" id="${u}-cf-${this._esc(f.key)}"
-                 placeholder="${this._esc(f.placeholder || '')}"
-                 ${f.pattern ? `pattern="${this._esc(f.pattern)}"` : ''}>
-          ${f.hint ? `<span class="jfm-hint">${this._esc(f.hint)}</span>` : ''}
-        </div>`).join('')}
-      </div>
-      <div class="jfm-modal-foot">
-        <button type="button" class="jfm-btn jfm-btn-ghost" data-jfm="close-create">Cancel</button>
-        <button type="button" class="jfm-btn jfm-btn-primary" data-jfm="do-create" id="${u}-create-btn">Create</button>
-      </div>
-    </div>
-  </div>` : ''}
-
-</div>`;  // end #${u}
-
-            // Cache frequently-used elements
-            this._root        = document.getElementById(u);
-            this._listEl      = document.getElementById(`${u}-list`);
-            this._editorEl    = document.getElementById(`${u}-editor`);
-            this._editModal   = document.getElementById(`${u}-edit-modal`);
-            this._delModal    = document.getElementById(`${u}-del-modal`);
-            this._createModal = document.getElementById(`${u}-create-modal`);
-            this._dropzone    = document.getElementById(`${u}-dropzone`);
-            this._fileInput   = document.getElementById(`${u}-fileinput`);
-        }
-
-        _css(u) {
-            return `<style>
-#${u}{font-family:inherit;color:#111827;}
-#${u} *{box-sizing:border-box;}
-
-/* Header */
-#${u} .jfm-header{display:flex;justify-content:space-between;align-items:center;margin-bottom:.875rem;gap:.5rem;}
-#${u} .jfm-header-left{display:flex;align-items:center;gap:.5rem;flex-wrap:wrap;}
-#${u} .jfm-title{font-size:.9375rem;font-weight:600;color:#111827;}
-#${u} .jfm-dir{font-size:.75rem;color:#6b7280;background:#f3f4f6;padding:.125rem .375rem;border-radius:.25rem;font-family:monospace;}
-#${u} .jfm-header-right{display:flex;gap:.375rem;align-items:center;flex-shrink:0;}
-
-/* Buttons */
-#${u} .jfm-btn{display:inline-flex;align-items:center;gap:.25rem;padding:.4375rem .875rem;border-radius:.375rem;border:1px solid #d1d5db;background:#fff;color:#374151;font-size:.875rem;font-weight:500;cursor:pointer;transition:background .12s,border-color .12s,opacity .12s;line-height:1.25;}
-#${u} .jfm-btn:hover:not(:disabled){background:#f9fafb;border-color:#9ca3af;}
-#${u} .jfm-btn:focus-visible{outline:2px solid #3b82f6;outline-offset:1px;}
-#${u} .jfm-btn:disabled{opacity:.5;cursor:not-allowed;}
-#${u} .jfm-btn-sm{padding:.3125rem .625rem;font-size:.8125rem;}
-#${u} .jfm-btn-primary{background:#3b82f6;border-color:#3b82f6;color:#fff;}
-#${u} .jfm-btn-primary:hover:not(:disabled){background:#2563eb;border-color:#2563eb;}
-#${u} .jfm-btn-danger{background:#ef4444;border-color:#ef4444;color:#fff;}
-#${u} .jfm-btn-danger:hover:not(:disabled){background:#dc2626;border-color:#dc2626;}
-#${u} .jfm-btn-ghost{background:transparent;border-color:transparent;color:#6b7280;}
-#${u} .jfm-btn-ghost:hover:not(:disabled){background:#f3f4f6;color:#374151;}
-#${u} .jfm-close-btn{display:flex;align-items:center;justify-content:center;width:2rem;height:2rem;border:none;background:none;color:#9ca3af;font-size:1.25rem;cursor:pointer;border-radius:.25rem;padding:0;line-height:1;}
-#${u} .jfm-close-btn:hover{background:#f3f4f6;color:#374151;}
-
-/* File list */
-#${u} .jfm-list{display:grid;grid-template-columns:repeat(auto-fill,minmax(240px,1fr));gap:.625rem;margin-bottom:1rem;min-height:5rem;}
-#${u} .jfm-loading{grid-column:1/-1;display:flex;align-items:center;justify-content:center;gap:.5rem;padding:2rem;color:#6b7280;font-size:.875rem;}
-#${u} .jfm-empty{grid-column:1/-1;text-align:center;padding:2.5rem 1rem;color:#9ca3af;}
-#${u} .jfm-empty-icon{font-size:2.25rem;margin-bottom:.625rem;}
-#${u} .jfm-empty-title{font-weight:600;color:#374151;margin:0 0 .25rem;}
-#${u} .jfm-empty-sub{font-size:.875rem;margin:0;}
-
-/* File cards */
-#${u} .jfm-card{border:1px solid #e5e7eb;border-radius:.5rem;padding:.875rem;background:#fff;display:flex;flex-direction:column;gap:.5rem;transition:border-color .15s,box-shadow .15s;}
-#${u} .jfm-card:hover{border-color:#93c5fd;box-shadow:0 2px 8px rgba(59,130,246,.1);}
-#${u} .jfm-card.jfm-off{opacity:.6;}
-#${u} .jfm-card-top{display:flex;justify-content:space-between;align-items:flex-start;gap:.5rem;}
-#${u} .jfm-card-name{font-weight:600;font-size:.9375rem;word-break:break-word;color:#111827;flex:1;}
-#${u} .jfm-card-meta{font-size:.75rem;color:#6b7280;display:flex;flex-direction:column;gap:.125rem;line-height:1.5;}
-#${u} .jfm-card-actions{display:flex;gap:.375rem;padding-top:.5rem;border-top:1px solid #f3f4f6;margin-top:.125rem;}
-#${u} .jfm-card-actions .jfm-btn{flex:1;justify-content:center;}
-#${u} .jfm-card-actions .jfm-del{flex:0 0 auto;}
-
-/* Toggle */
-#${u} .jfm-toggle{display:flex;align-items:center;gap:.3125rem;font-size:.75rem;color:#6b7280;white-space:nowrap;flex-shrink:0;}
-#${u} .jfm-toggle input[type=checkbox]{width:.9375rem;height:.9375rem;cursor:pointer;accent-color:#22c55e;margin:0;}
-
-/* Upload zone */
-#${u} .jfm-upload-wrap{margin-top:.25rem;}
-#${u} input[type=file]#${u}-fileinput{position:absolute;left:-9999px;width:1px;height:1px;opacity:0;}
-#${u} .jfm-dropzone{border:2px dashed #d1d5db;border-radius:.5rem;padding:1.25rem 1rem;text-align:center;cursor:pointer;transition:border-color .15s,background .15s;background:#f9fafb;user-select:none;}
-#${u} .jfm-dropzone:hover,#${u} .jfm-dropzone:focus-visible,#${u} .jfm-dropzone.jfm-over{border-color:#3b82f6;background:#eff6ff;border-style:solid;outline:none;}
-#${u} .jfm-drop-icon{font-size:1.75rem;display:block;margin-bottom:.375rem;}
-#${u} .jfm-drop-primary{font-size:.875rem;color:#374151;margin:0 0 .25rem;}
-#${u} .jfm-drop-hint{font-size:.75rem;color:#9ca3af;margin:0;}
-
-/* Modals */
-#${u} .jfm-modal{position:fixed;inset:0;background:rgba(0,0,0,.45);z-index:9999;display:flex;align-items:center;justify-content:center;padding:1rem;backdrop-filter:blur(1px);}
-#${u} .jfm-modal[hidden]{display:none;}
-#${u} .jfm-modal-box{background:#fff;border-radius:.5rem;box-shadow:0 20px 40px rgba(0,0,0,.15);display:flex;flex-direction:column;width:100%;max-width:440px;max-height:92vh;}
-#${u} .jfm-modal-wide{max-width:880px;}
-#${u} .jfm-modal-head{display:flex;justify-content:space-between;align-items:center;padding:.875rem 1.125rem;border-bottom:1px solid #e5e7eb;flex-shrink:0;gap:.5rem;}
-#${u} .jfm-modal-title{font-weight:600;font-size:.9375rem;color:#111827;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;}
-#${u} .jfm-modal-tools{display:flex;gap:.25rem;align-items:center;flex-shrink:0;}
-#${u} .jfm-modal-body{padding:1.125rem;overflow-y:auto;flex:1;}
-#${u} .jfm-modal-foot{display:flex;gap:.5rem;justify-content:flex-end;align-items:center;padding:.75rem 1.125rem;border-top:1px solid #e5e7eb;flex-shrink:0;background:#f9fafb;border-radius:0 0 .5rem .5rem;}
-#${u} .jfm-stat{margin-right:auto;font-size:.75rem;color:#9ca3af;font-variant-numeric:tabular-nums;}
-
-/* JSON editor */
-#${u} .jfm-editor{display:block;width:100%;min-height:400px;height:58vh;max-height:64vh;resize:vertical;font-family:'Courier New',Consolas,ui-monospace,monospace;font-size:.8rem;line-height:1.55;padding:.75rem 1rem;border:none;border-radius:0;outline:none;white-space:pre;overflow:auto;color:#1e293b;background:#fafafa;tab-size:2;}
-#${u} .jfm-err-bar{background:#fef2f2;border-bottom:1px solid #fecaca;color:#991b1b;font-size:.8125rem;padding:.5rem 1.125rem;flex-shrink:0;line-height:1.4;}
-#${u} .jfm-err-bar[hidden]{display:none;}
-
-/* Create form */
-#${u} .jfm-field{margin-bottom:.875rem;}
-#${u} .jfm-field:last-child{margin-bottom:0;}
-#${u} .jfm-field label{display:block;font-size:.875rem;font-weight:500;color:#374151;margin-bottom:.3125rem;}
-#${u} .jfm-field input{width:100%;padding:.4375rem .75rem;border:1px solid #d1d5db;border-radius:.375rem;font-size:.875rem;color:#111827;background:#fff;}
-#${u} .jfm-field input:focus{outline:none;border-color:#3b82f6;box-shadow:0 0 0 3px rgba(59,130,246,.12);}
-#${u} .jfm-hint{display:block;font-size:.75rem;color:#9ca3af;margin-top:.25rem;}
-#${u} .jfm-muted{font-size:.875rem;color:#6b7280;margin-top:.375rem;}
-
-/* Spinner */
-#${u} .jfm-spin{display:inline-block;width:.9rem;height:.9rem;border:2px solid #e5e7eb;border-top-color:#3b82f6;border-radius:50%;animation:jfm-spin-${u} .6s linear infinite;vertical-align:middle;}
-@keyframes jfm-spin-${u}{to{transform:rotate(360deg);}}
-</style>`;
-        }
-
-        // ── Event Binding ────────────────────────────────────────────────────
-
-        _bind() {
-            // Delegated clicks on the widget root
-            this._root.addEventListener('click', this._onClick.bind(this));
-            this._root.addEventListener('change', this._onChange.bind(this));
-
-            // Drag-and-drop on the dropzone
-            if (this._dropzone) {
-                this._dropzone.addEventListener('dragover', e => {
-                    e.preventDefault();
-                    this._dropzone.classList.add('jfm-over');
-                });
-                this._dropzone.addEventListener('dragleave', () => {
-                    this._dropzone.classList.remove('jfm-over');
-                });
-                this._dropzone.addEventListener('drop', e => {
-                    e.preventDefault();
-                    this._dropzone.classList.remove('jfm-over');
-                    const file = e.dataTransfer?.files[0];
-                    if (file) this._uploadFile(file);
-                });
-                // Keyboard activation of drop zone
-                this._dropzone.addEventListener('keydown', e => {
-                    if (e.key === 'Enter' || e.key === ' ') {
-                        e.preventDefault();
-                        this._fileInput?.click();
-                    }
-                });
-            }
-
-            // Modal backdrop clicks
-            [this._editModal, this._delModal, this._createModal].forEach(m => {
-                if (m) m.addEventListener('click', e => { if (e.target === m) this._closeAll(); });
-            });
-
-            // Editor: char count + Tab indent
-            if (this._editorEl) {
-                this._editorEl.addEventListener('input', () => this._updateStat());
-                this._editorEl.addEventListener('keydown', e => {
-                    if (e.key === 'Tab') {
-                        e.preventDefault();
-                        const s = this._editorEl.selectionStart;
-                        const end = this._editorEl.selectionEnd;
-                        const v = this._editorEl.value;
-                        this._editorEl.value = v.slice(0, s) + '  ' + v.slice(end);
-                        this._editorEl.selectionStart = this._editorEl.selectionEnd = s + 2;
-                        this._updateStat();
-                    }
-                });
-            }
-
-            // Global keyboard shortcuts
-            document.addEventListener('keydown', this._keyHandler);
-        }
-
-        _onKey(e) {
-            const editOpen   = this._editModal   && !this._editModal.hidden;
-            const delOpen    = this._delModal    && !this._delModal.hidden;
-            const createOpen = this._createModal && !this._createModal.hidden;
-
-            if (e.key === 'Escape') {
-                if (editOpen)   { this._closeEdit();   return; }
-                if (delOpen)    { this._closeDel();    return; }
-                if (createOpen) { this._closeCreate(); return; }
-            }
-            if ((e.ctrlKey || e.metaKey) && e.key === 's' && editOpen) {
-                e.preventDefault();
-                this._doSave();
-            }
-        }
-
-        _onClick(e) {
-            const btn = e.target.closest('[data-jfm]');
-            if (!btn) return;
-            const action = btn.dataset.jfm;
-
-            switch (action) {
-                case 'refresh':      this._loadList(); break;
-                case 'open-picker':  this._fileInput?.click(); break;
-                case 'open-create':  this._openCreate(); break;
-                case 'close-edit':   this._closeEdit(); break;
-                case 'close-del':    this._closeDel(); break;
-                case 'close-create': this._closeCreate(); break;
-                case 'fmt':          this._formatJson(); break;
-                case 'validate':     this._validateJson(); break;
-                case 'save':         this._doSave(); break;
-                case 'confirm-del':  this._doDelete(); break;
-                case 'do-create':    this._doCreate(); break;
-                case 'edit-file': {
-                    const card = btn.closest('[data-jfm-file]');
-                    if (card) this._openEdit(card.dataset.jfmFile);
-                    break;
-                }
-                case 'del-file': {
-                    const card = btn.closest('[data-jfm-file]');
-                    if (card) this._openDel(card.dataset.jfmFile);
-                    break;
-                }
-            }
-        }
-
-        _onChange(e) {
-            // Toggle checkbox
-            if (e.target.classList.contains('jfm-toggle-cb')) {
-                const catName = e.target.dataset.cat;
-                const enabled = e.target.checked;
-                this._doToggle(catName, enabled, e.target);
-            }
-            // File input
-            if (e.target === this._fileInput) {
-                const file = e.target.files?.[0];
-                if (file) this._uploadFile(file);
-                e.target.value = '';
-            }
-        }
-
-        // ── API helper ───────────────────────────────────────────────────────
-
-        async _api(actionKey, params) {
-            const actionId = Object.prototype.hasOwnProperty.call(this.actions, actionKey) ? this.actions[actionKey] : undefined;
-            if (!actionId) throw new Error(`Action "${actionKey}" not configured`);
-            const body = { plugin_id: this.pluginId, action_id: actionId };
-            if (params !== undefined) body.params = params;
-            const r = await fetch('/api/v3/plugins/action', {
-                method: 'POST',
-                headers: { 'Content-Type': 'application/json' },
-                body: JSON.stringify(body)
-            });
-            if (!r.ok) throw new Error('Server error ' + r.status);
-            const ct = r.headers.get('content-type') || '';
-            if (!ct.includes('application/json')) {
-                const txt = await r.text();
-                throw new Error('Unexpected response: ' + txt.slice(0, 120));
-            }
-            return r.json();
-        }
-
-        // ── File List ────────────────────────────────────────────────────────
-
-        async _loadList() {
-            this._listEl.innerHTML = `<div class="jfm-loading"><span class="jfm-spin"></span> Loading…</div>`;
-            try {
-                const data = await this._api('list');
-                if (data.status !== 'success') throw new Error(data.message || 'Load failed');
-                this._renderList(data.files || []);
-            } catch (err) {
-                this._listEl.innerHTML = `
-                    <div class="jfm-empty">
-                        <div class="jfm-empty-icon">&#9888;</div>
-                        <p class="jfm-empty-title">Failed to load files</p>
-                        <p class="jfm-empty-sub">${this._esc(err.message)}</p>
-                    </div>`;
-            }
-        }
-
-        _renderList(files) {
-            if (!files.length) {
-                this._listEl.innerHTML = `
-                    <div class="jfm-empty">
-                        <div class="jfm-empty-icon">&#128193;</div>
-                        <p class="jfm-empty-title">No files yet</p>
-                        <p class="jfm-empty-sub">Upload or create a JSON file to get started</p>
-                    </div>`;
-                return;
-            }
-            this._listEl.innerHTML = files.map(f => this._card(f)).join('');
-        }
-
-        _card(f) {
-            const enabled     = f.enabled !== false;
-            const displayName = this._esc(f.display_name || f.filename);
-            const filename    = this._esc(f.filename);
-            const catName     = this.toggleKey ? this._esc(f[this.toggleKey] || '') : '';
-            const showToggle  = !!(this.actions.toggle && this.toggleKey && f[this.toggleKey]);
-            const hasEdit     = !!this.actions.get && !!this.actions.save;
-            const hasDelete   = !!this.actions.delete;
-
-            return `
-<div class="jfm-card${enabled ? '' : ' jfm-off'}" data-jfm-file="${filename}">
-  <div class="jfm-card-top">
-    <span class="jfm-card-name" title="${filename}">${displayName}</span>
-    ${showToggle ? `
-    <label class="jfm-toggle" title="${enabled ? 'Enabled — click to disable' : 'Disabled — click to enable'}">
-      <input type="checkbox" class="jfm-toggle-cb" data-cat="${catName}" ${enabled ? 'checked' : ''}>
-      <span>${enabled ? 'On' : 'Off'}</span>
-    </label>` : ''}
-  </div>
-  <div class="jfm-card-meta">
-    <span>&#128196; ${filename}</span>
-    <span>&#128202; ${f.entry_count ?? 0} entries &middot; ${this._fmtSize(f.size || 0)}</span>
-    <span>&#128337; ${this._fmtDate(f.modified)}</span>
-  </div>
-  <div class="jfm-card-actions">
-    ${hasEdit ? `<button type="button" class="jfm-btn jfm-btn-sm" data-jfm="edit-file">&#9998; Edit</button>` : ''}
-    ${hasDelete ? `<button type="button" class="jfm-btn jfm-btn-danger jfm-btn-sm jfm-del" data-jfm="del-file" title="Delete file">&#128465;</button>` : ''}
-  </div>
-</div>`;
-        }
-
-        // ── Edit flow ────────────────────────────────────────────────────────
-
-        async _openEdit(filename) {
-            this._editFile = filename;
-            document.getElementById(`${this._uid}-edit-title`).textContent = `Edit: ${filename}`;
-            this._clearErr();
-            this._editorEl.value = 'Loading…';
-            this._updateStat();
-            this._editModal.hidden = false;
-
-            try {
-                const data = await this._api('get', { filename });
-                if (data.status !== 'success') throw new Error(data.message || 'Load failed');
-                this._editorEl.value = JSON.stringify(data.content, null, 2);
-                this._updateStat();
-                this._editorEl.focus();
-                this._editorEl.setSelectionRange(0, 0);
-                this._editorEl.scrollTop = 0;
-            } catch (err) {
-                this._showErr('Failed to load file: ' + err.message);
-                this._editorEl.value = '';
-            }
-        }
-
-        _closeEdit() {
-            if (this._editModal) this._editModal.hidden = true;
-            this._editFile = null;
-            this._clearErr();
-        }
-
-        _formatJson() {
-            try {
-                const parsed = JSON.parse(this._editorEl.value);
-                this._editorEl.value = JSON.stringify(parsed, null, 2);
-                this._updateStat();
-                this._clearErr();
-            } catch (err) {
-                this._showErr('Invalid JSON — ' + err.message);
-            }
-        }
-
-        _validateJson() {
-            try {
-                const parsed = JSON.parse(this._editorEl.value);
-                const n = (typeof parsed === 'object' && parsed !== null) ? Object.keys(parsed).length : '?';
-                this._clearErr();
-                this._notify(`Valid JSON — ${n} top-level keys`, 'success');
-            } catch (err) {
-                this._showErr('Invalid JSON — ' + err.message);
-            }
-        }
-
-        async _doSave() {
-            if (!this._editFile) return;
-            let contentStr;
-            try {
-                const parsed = JSON.parse(this._editorEl.value);
-                contentStr = JSON.stringify(parsed, null, 2);
-            } catch (err) {
-                this._showErr('Cannot save — fix JSON first: ' + err.message);
-                return;
-            }
-            const btn = document.getElementById(`${this._uid}-save-btn`);
-            this._busy(btn, 'Saving…');
-            try {
-                const data = await this._api('save', { filename: this._editFile, content: contentStr });
-                if (data.status !== 'success') throw new Error(data.message || 'Save failed');
-                this._notify('File saved', 'success');
-                this._closeEdit();
-                this._loadList();
-            } catch (err) {
-                this._showErr('Save failed: ' + err.message);
-            } finally {
-                this._idle(btn, 'Save');
-            }
-        }
-
-        // ── Delete flow ──────────────────────────────────────────────────────
-
-        _openDel(filename) {
-            this._deleteFile = filename;
-            const el = document.getElementById(`${this._uid}-del-name`);
-            if (el) el.textContent = filename;
-            if (this._delModal) this._delModal.hidden = false;
-        }
-
-        _closeDel() {
-            if (this._delModal) this._delModal.hidden = true;
-            this._deleteFile = null;
-        }
-
-        async _doDelete() {
-            if (!this._deleteFile) return;
-            const btn = document.getElementById(`${this._uid}-del-btn`);
-            this._busy(btn, 'Deleting…');
-            try {
-                const data = await this._api('delete', { filename: this._deleteFile });
-                if (data.status !== 'success') throw new Error(data.message || 'Delete failed');
-                this._notify('File deleted', 'success');
-                this._closeDel();
-                this._loadList();
-            } catch (err) {
-                this._notify('Delete failed: ' + err.message, 'error');
-            } finally {
-                this._idle(btn, 'Delete');
-            }
-        }
-
-        // ── Create flow ──────────────────────────────────────────────────────
-
-        _openCreate() {
-            if (!this._createModal) return;
-            this.createFields.forEach(f => {
-                const el = document.getElementById(`${this._uid}-cf-${f.key}`);
-                if (el) el.value = '';
-            });
-            this._createModal.hidden = false;
-            const first = this.createFields[0];
-            if (first) document.getElementById(`${this._uid}-cf-${first.key}`)?.focus();
-        }
-
-        _closeCreate() {
-            if (this._createModal) this._createModal.hidden = true;
-        }
-
-        async _doCreate() {
-            const params = {};
-            for (const f of this.createFields) {
-                const el  = document.getElementById(`${this._uid}-cf-${f.key}`);
-                const val = (el?.value || '').trim();
-                // display_name may be blank — auto-derived from category_name below
-                if (!val && f.key !== 'display_name') {
-                    this._notify(`"${f.label}" is required`, 'error');
-                    el?.focus();
-                    return;
-                }
-                if (f.pattern && val && el && el.validity.patternMismatch) {
-                    this._notify(`"${f.label}" format is invalid`, 'error');
-                    el?.focus();
-                    return;
-                }
-                if (val) params[f.key] = val;
-            }
-            // Auto-derive display_name from category_name when left blank
-            if (!params.display_name && params.category_name) {
-                params.display_name = params.category_name.replace(/_/g, ' ').replace(/\b\w/g, c => c.toUpperCase());
-            }
-            const btn = document.getElementById(`${this._uid}-create-btn`);
-            this._busy(btn, 'Creating…');
-            try {
-                const data = await this._api('create', params);
-                if (data.status !== 'success') throw new Error(data.message || 'Create failed');
-                this._notify('File created', 'success');
-                this._closeCreate();
-                this._loadList();
-            } catch (err) {
-                this._notify('Create failed: ' + err.message, 'error');
-            } finally {
-                this._idle(btn, 'Create');
-            }
-        }
-
-        // ── Upload ───────────────────────────────────────────────────────────
-
-        async _uploadFile(file) {
-            if (!file.name.endsWith('.json')) {
-                this._notify('Please select a .json file', 'error');
-                return;
-            }
-            let content;
-            try {
-                content = await file.text();
-                JSON.parse(content); // client-side validation
-            } catch (err) {
-                this._notify('Invalid JSON: ' + err.message, 'error');
-                return;
-            }
-            if (this._dropzone) this._dropzone.style.opacity = '.5';
-            try {
-                const data = await this._api('upload', { filename: file.name, content });
-                if (data.status !== 'success') throw new Error(data.message || 'Upload failed');
-                this._notify(`"${file.name}" uploaded`, 'success');
-                this._loadList();
-            } catch (err) {
-                this._notify('Upload failed: ' + err.message, 'error');
-            } finally {
-                if (this._dropzone) this._dropzone.style.opacity = '';
-            }
-        }
-
-        // ── Toggle ───────────────────────────────────────────────────────────
-
-        async _doToggle(catName, enabled, checkbox) {
-            checkbox.disabled = true;
-            try {
-                const params = { enabled };
-                if (this.toggleKey) params[this.toggleKey] = catName;
-                const data = await this._api('toggle', params);
-                if (data.status !== 'success') throw new Error(data.message || 'Toggle failed');
-                this._notify(enabled ? 'Category enabled' : 'Category disabled', 'success');
-                this._loadList();
-            } catch (err) {
-                this._notify('Toggle failed: ' + err.message, 'error');
-                checkbox.checked = !enabled; // revert
-                checkbox.disabled = false;
-            }
-        }
-
-        // ── Helpers ──────────────────────────────────────────────────────────
-
-        _closeAll() {
-            this._closeEdit();
-            this._closeDel();
-            this._closeCreate();
-        }
-
-        _updateStat() {
-            const v = this._editorEl?.value || '';
-            const lines = v ? v.split('\n').length : 0;
-            const el = document.getElementById(`${this._uid}-charcount`);
-            if (el) el.textContent = `${lines.toLocaleString()} lines · ${v.length.toLocaleString()} chars`;
-        }
-
-        _showErr(msg) {
-            const el = document.getElementById(`${this._uid}-edit-err`);
-            if (el) { el.textContent = msg; el.hidden = false; }
-        }
-
-        _clearErr() {
-            const el = document.getElementById(`${this._uid}-edit-err`);
-            if (el) { el.textContent = ''; el.hidden = true; }
-        }
-
-        _notify(msg, type) {
-            if (typeof window.showNotification === 'function') {
-                window.showNotification(msg, type || 'info');
-            } else {
-                console.info(`[JsonFileManager] ${type || 'info'}: ${msg}`);
-            }
-        }
-
-        _busy(btn, label) {
-            if (!btn) return;
-            btn._jfmOrigText = btn.textContent;
-            btn.disabled = true;
-            btn.textContent = '';
-            const spin = document.createElement('span');
-            spin.className = 'jfm-spin';
-            btn.appendChild(spin);
-            btn.appendChild(document.createTextNode(' ' + label));
-        }
-
-        _idle(btn, label) {
-            if (!btn) return;
-            btn.disabled = false;
-            btn.textContent = btn._jfmOrigText !== undefined ? btn._jfmOrigText : label;
-            delete btn._jfmOrigText;
-        }
-
-        _esc(str) {
-            const d = document.createElement('div');
-            d.textContent = String(str ?? '');
-            return d.innerHTML;
-        }
-
-        _fmtSize(bytes) {
-            if (!bytes) return '0 B';
-            const i = Math.min(Math.floor(Math.log2(bytes + 1) / 10), 2);
-            const unit = ['B', 'KB', 'MB'][i];
-            const val  = bytes / Math.pow(1024, i);
-            return (i ? val.toFixed(1) : val) + ' ' + unit;
-        }
-
-        _fmtDate(str) {
-            if (!str) return '—';
-            try {
-                return new Date(str).toLocaleDateString(undefined, {
-                    month: 'short', day: 'numeric', year: 'numeric'
-                });
-            } catch { return str; }
-        }
-    }
-
-    // ── Widget registry integration ──────────────────────────────────────────
-
-    window.JsonFileManager = JsonFileManager;
-
-    if (typeof window.LEDMatrixWidgets !== 'undefined') {
-        window.LEDMatrixWidgets.register('json-file-manager', {
-            name: 'JSON File Manager',
-            version: '1.0.0',
-            render(container, config, _value, options) {
-                new JsonFileManager(container, config || {}, options?.pluginId || '');
-            },
-            getValue() { return null; },
-            setValue() {}
-        });
-        console.log('[JsonFileManager] Registered with LEDMatrixWidgets');
-    } else {
-        console.log('[JsonFileManager] Loaded (LEDMatrixWidgets registry not available)');
-    }
-})();

web_interface/static/v3/js/widgets/plugin-file-manager.js

@@ -1,797 +0,0 @@
-/**
- * Plugin File Manager Widget
- *
- * Reusable inline file manager for plugins that manage files via the
- * web_ui_actions system. Driven entirely by x-widget-config in the schema —
- * no external HTML file or iframe needed.
- *
- * Any plugin can adopt this widget by:
- *   1. Defining web_ui_actions in manifest.json (list, get, save, upload,
- *      delete, create, toggle) with ui_hidden: true
- *   2. Adding x-widget: "plugin-file-manager" to a field in config_schema.json
- *      with x-widget-config mapping the action IDs
- *
- * Schema example:
- * {
- *   "file_manager": {
- *     "type": "null",
- *     "title": "Data Files",
- *     "x-widget": "plugin-file-manager",
- *     "x-widget-config": {
- *       "actions": {
- *         "list":   "list-files",
- *         "get":    "get-file",
- *         "save":   "save-file",
- *         "upload": "upload-file",
- *         "delete": "delete-file",
- *         "create": "create-file",
- *         "toggle": "toggle-category"
- *       },
- *       "upload_hint":     "JSON files with day numbers 1–365 as keys",
- *       "directory_label": "of_the_day/",
- *       "create_fields": [
- *         { "key": "category_name", "label": "Category Name",
- *           "placeholder": "e.g., my_words", "pattern": "^[a-z0-9_]+$",
- *           "hint": "Lowercase letters, numbers, underscores" },
- *         { "key": "display_name", "label": "Display Name",
- *           "placeholder": "e.g., My Words", "hint": "Optional — auto-generated if blank" }
- *       ]
- *     }
- *   }
- * }
- *
- * @module PluginFileManagerWidget
- */
-
-(function () {
-    'use strict';
-
-    if (typeof window.LEDMatrixWidgets === 'undefined') {
-        console.error('[PluginFileManager] LEDMatrixWidgets registry not found.');
-        return;
-    }
-
-    // ─── Inject widget-scoped styles once ────────────────────────────────────
-
-    if (!document.getElementById('pfm-styles')) {
-        const style = document.createElement('style');
-        style.id = 'pfm-styles';
-        style.textContent = `
-.pfm-root { font-family: inherit; }
-.pfm-header { display:flex; align-items:center; justify-content:space-between;
-              margin-bottom:.75rem; }
-.pfm-title  { font-size:1rem; font-weight:600; color:#111827; }
-.pfm-dir    { font-size:.75rem; color:#6b7280; margin-top:.125rem; }
-.pfm-upload { border:2px dashed #d1d5db; border-radius:.5rem; padding:1.25rem;
-              text-align:center; cursor:pointer; transition:border-color .15s,background .15s; }
-.pfm-upload:hover,.pfm-upload.dragover { border-color:#3b82f6; background:#eff6ff; }
-.pfm-upload p  { font-size:.875rem; color:#4b5563; margin:.25rem 0 0; }
-.pfm-upload small { font-size:.75rem; color:#9ca3af; }
-.pfm-grid  { display:grid; grid-template-columns:repeat(auto-fill,minmax(260px,1fr));
-             gap:.75rem; margin-top:.75rem; }
-.pfm-card  { border:1px solid #e5e7eb; border-radius:.5rem; padding:.875rem;
-             background:#fff; transition:box-shadow .15s; }
-.pfm-card:hover { box-shadow:0 1px 4px rgba(0,0,0,.1); }
-.pfm-card.disabled { opacity:.55; }
-.pfm-card-top  { display:flex; align-items:center; justify-content:space-between;
-                 margin-bottom:.5rem; }
-.pfm-card-icon { width:2rem; height:2rem; background:#f3f4f6; border-radius:.375rem;
-                 display:flex; align-items:center; justify-content:center;
-                 color:#6b7280; font-size:1rem; }
-.pfm-card-name { font-weight:600; color:#111827; font-size:.875rem; margin:.375rem 0 .125rem; }
-.pfm-card-meta { font-size:.75rem; color:#6b7280; line-height:1.5; }
-.pfm-card-actions { display:flex; gap:.375rem; margin-top:.625rem; }
-.pfm-btn       { display:inline-flex; align-items:center; gap:.25rem; padding:.375rem .75rem;
-                 border-radius:.375rem; font-size:.8125rem; font-weight:500;
-                 border:none; cursor:pointer; transition:background .15s; }
-.pfm-btn-primary   { background:#2563eb; color:#fff; flex:1; justify-content:center; }
-.pfm-btn-primary:hover  { background:#1d4ed8; }
-.pfm-btn-danger    { background:#dc2626; color:#fff; }
-.pfm-btn-danger:hover   { background:#b91c1c; }
-.pfm-btn-secondary { background:#f3f4f6; color:#374151; border:1px solid #d1d5db; }
-.pfm-btn-secondary:hover { background:#e5e7eb; }
-.pfm-btn-sm { padding:.25rem .5rem; font-size:.75rem; }
-.pfm-btn-create { background:#059669; color:#fff; }
-.pfm-btn-create:hover { background:#047857; }
-.pfm-toggle-wrap  { display:flex; align-items:center; gap:.375rem; }
-.pfm-toggle-label { font-size:.75rem; color:#6b7280; }
-.pfm-toggle-cb    { position:relative; display:inline-block; width:2rem; height:1.125rem; }
-.pfm-toggle-cb input { opacity:0; width:0; height:0; }
-.pfm-toggle-slider { position:absolute; inset:0; background:#d1d5db; border-radius:9999px;
-                     cursor:pointer; transition:background .2s; }
-.pfm-toggle-slider:before { content:''; position:absolute; height:.75rem; width:.75rem;
-                             left:.1875rem; bottom:.1875rem; background:#fff;
-                             border-radius:50%; transition:transform .2s; }
-.pfm-toggle-cb input:checked + .pfm-toggle-slider { background:#10b981; }
-.pfm-toggle-cb input:checked + .pfm-toggle-slider:before { transform:translateX(.875rem); }
-.pfm-empty { text-align:center; padding:2rem; color:#9ca3af; }
-.pfm-empty i { font-size:2rem; margin-bottom:.5rem; display:block; }
-
-/* Modal */
-.pfm-overlay { position:fixed; inset:0; background:rgba(0,0,0,.5);
-               display:flex; align-items:flex-start; justify-content:center;
-               z-index:9999; padding:2rem 1rem; overflow-y:auto; }
-.pfm-modal   { background:#fff; border-radius:.75rem; width:100%; max-width:56rem;
-               box-shadow:0 20px 50px rgba(0,0,0,.3); margin:auto; }
-.pfm-modal-header { display:flex; align-items:center; justify-content:space-between;
-                    padding:1rem 1.25rem; border-bottom:1px solid #e5e7eb; }
-.pfm-modal-title  { font-size:1rem; font-weight:600; color:#111827; }
-.pfm-modal-body   { padding:1.25rem; overflow-y:auto; max-height:70vh; }
-.pfm-modal-footer { display:flex; justify-content:flex-end; gap:.5rem;
-                    padding:.875rem 1.25rem; border-top:1px solid #e5e7eb;
-                    background:#f9fafb; border-radius:0 0 .75rem .75rem; }
-
-/* Entry table */
-.pfm-table-wrap { overflow-x:auto; }
-.pfm-table { width:100%; border-collapse:collapse; font-size:.8125rem; }
-.pfm-table th { background:#f9fafb; text-align:left; padding:.5rem .625rem;
-                font-weight:600; color:#374151; border-bottom:1px solid #e5e7eb;
-                white-space:nowrap; position:sticky; top:0; }
-.pfm-table td { padding:.375rem .625rem; border-bottom:1px solid #f3f4f6;
-                vertical-align:top; }
-.pfm-table tr.today-row td { background:#fef9c3; }
-.pfm-table td input, .pfm-table td textarea {
-  width:100%; border:1px solid #d1d5db; border-radius:.25rem;
-  padding:.25rem .375rem; font-size:.8125rem; font-family:inherit;
-  resize:vertical; background:#fff; }
-.pfm-table td input:focus, .pfm-table td textarea:focus {
-  outline:none; border-color:#3b82f6; }
-.pfm-day-col { width:3rem; text-align:center; font-weight:600;
-               color:#6b7280; white-space:nowrap; }
-.pfm-pagination { display:flex; align-items:center; justify-content:space-between;
-                  margin-top:.75rem; font-size:.8125rem; color:#6b7280; }
-.pfm-page-jump  { display:flex; align-items:center; gap:.375rem; font-size:.8125rem; }
-.pfm-page-jump input { width:3.5rem; padding:.25rem .375rem; border:1px solid #d1d5db;
-                        border-radius:.25rem; text-align:center; }
-
-/* Form in create modal */
-.pfm-field { margin-bottom:.875rem; }
-.pfm-field label { display:block; font-size:.875rem; font-weight:500;
-                   color:#374151; margin-bottom:.25rem; }
-.pfm-field input { width:100%; padding:.4rem .625rem; border:1px solid #d1d5db;
-                   border-radius:.375rem; font-size:.875rem; }
-.pfm-field input:focus { outline:none; border-color:#3b82f6; }
-.pfm-field-hint { font-size:.75rem; color:#9ca3af; margin-top:.2rem; }
-.pfm-field-error { font-size:.75rem; color:#dc2626; margin-top:.2rem; }
-
-/* Delete danger box */
-.pfm-danger-box { background:#fef2f2; border:1px solid #fecaca;
-                  border-radius:.5rem; padding:.875rem; font-size:.875rem;
-                  color:#991b1b; }
-`;
-        document.head.appendChild(style);
-    }
-
-    // ─── Safe HTML helper ─────────────────────────────────────────────────────
-
-    /**
-     * Parse html in a sandboxed DOMParser document (scripts never execute) and
-     * replace target's children with the result.  All dynamic values in html
-     * must be escaped by the caller before passing here.
-     */
-    function safeSetHTML(target, html) {
-        target.textContent = '';
-        // createContextualFragment parses html relative to the document context
-        // without executing scripts — a widely recognised safe insertion method.
-        const frag = document.createRange().createContextualFragment(html);
-        target.appendChild(frag);
-    }
-
-    // ─── Per-instance state ───────────────────────────────────────────────────
-
-    const _state = new Map(); // fieldId → { pluginId, actions, createFields, files, page, entriesPerPage, modal }
-
-    function getState(fieldId) {
-        if (!_state.has(fieldId)) _state.set(fieldId, {
-            pluginId: '', actions: {}, createFields: [], uploadHint: '',
-            directoryLabel: '', files: [], page: 1, entriesPerPage: 20,
-            currentModal: null
-        });
-        return _state.get(fieldId);
-    }
-
-    // ─── API helper ───────────────────────────────────────────────────────────
-
-    async function callAction(pluginId, actionId, params = {}) {
-        const resp = await fetch('/api/v3/plugins/action', {
-            method: 'POST',
-            headers: { 'Content-Type': 'application/json' },
-            body: JSON.stringify({ plugin_id: pluginId, action_id: actionId, params })
-        });
-        return resp.json();
-    }
-
-    function notify(msg, type) {
-        if (window.showNotification) window.showNotification(msg, type);
-        else console.log(`[PFM][${type}] ${msg}`);
-    }
-
-    function escHtml(s) {
-        const d = document.createElement('div');
-        d.textContent = String(s ?? '');
-        return d.innerHTML;
-    }
-
-    function formatSize(bytes) {
-        if (bytes >= 1048576) return (bytes / 1048576).toFixed(1) + ' MB';
-        return (bytes / 1024).toFixed(2) + ' KB';
-    }
-
-    function formatDate(iso) {
-        try { return new Date(iso).toLocaleString(undefined, { dateStyle: 'short', timeStyle: 'short' }); }
-        catch { return iso; }
-    }
-
-    // ─── Core: load files ─────────────────────────────────────────────────────
-
-    async function loadFiles(fieldId) {
-        const st = getState(fieldId);
-        const root = document.getElementById(`${fieldId}_pfm`);
-        if (!root) return;
-        const grid = root.querySelector('.pfm-grid');
-        if (grid) safeSetHTML(grid, '<div class="pfm-empty"><i class="fas fa-spinner fa-spin"></i>Loading…</div>');
-
-        const data = await callAction(st.pluginId, st.actions.list).catch(() => null);
-        if (!data || data.status !== 'success') {
-            if (grid) safeSetHTML(grid, '<div class="pfm-empty"><i class="fas fa-exclamation-circle"></i>Failed to load files.</div>');
-            return;
-        }
-        st.files = data.files || [];
-        renderCards(fieldId);
-    }
-
-    // ─── Card grid ────────────────────────────────────────────────────────────
-
-    function renderCards(fieldId) {
-        const st = getState(fieldId);
-        const root = document.getElementById(`${fieldId}_pfm`);
-        if (!root) return;
-        const grid = root.querySelector('.pfm-grid');
-        if (!grid) return;
-
-        if (!st.files.length) {
-            safeSetHTML(grid, '<div class="pfm-empty"><i class="fas fa-folder-open"></i>No files yet. Create or upload one.</div>');
-            return;
-        }
-
-        // Remove any existing delegated listener before re-render
-        if (st._gridClickHandler) grid.removeEventListener('click', st._gridClickHandler);
-        if (st._gridChangeHandler) grid.removeEventListener('change', st._gridChangeHandler);
-
-        // Event delegation: handles edit/delete/toggle via data attributes so
-        // filenames and category names are never interpolated into JS string literals.
-        st._gridClickHandler = function(e) {
-            const btn = e.target.closest('[data-pfm-action]');
-            if (!btn) return;
-            const action = btn.dataset.pfmAction;
-            const fId    = btn.dataset.pfmField;
-            if (action === 'edit')   window._pfmOpenEdit(fId, btn.dataset.pfmFile);
-            if (action === 'delete') window._pfmOpenDelete(fId, btn.dataset.pfmFile);
-        };
-        st._gridChangeHandler = function(e) {
-            const inp = e.target.closest('[data-pfm-action="toggle"]');
-            if (!inp) return;
-            window._pfmToggle(inp.dataset.pfmField, inp.dataset.pfmCategory, inp.checked);
-        };
-        grid.addEventListener('click',  st._gridClickHandler);
-        grid.addEventListener('change', st._gridChangeHandler);
-
-        // Build cards with DOM methods so no user-derived data flows through innerHTML.
-        grid.textContent = '';
-        const frag = document.createDocumentFragment();
-        st.files.forEach(function(f) {
-            const card = document.createElement('div');
-            card.className = 'pfm-card' + (f.enabled === false ? ' disabled' : '');
-            card.dataset.filename = f.filename;
-            card.dataset.category = f.category_name;
-
-            // Top row: label + optional toggle
-            const top = document.createElement('div');
-            top.className = 'pfm-card-top';
-            const lbl = document.createElement('span');
-            lbl.className = 'pfm-toggle-label';
-            lbl.textContent = f.enabled !== false ? 'Enabled' : 'Disabled';
-            top.appendChild(lbl);
-            if (st.actions.toggle) {
-                const tglLabel = document.createElement('label');
-                tglLabel.className = 'pfm-toggle-cb';
-                tglLabel.title = f.enabled !== false ? 'Click to disable' : 'Click to enable';
-                const tglInput = document.createElement('input');
-                tglInput.type = 'checkbox';
-                tglInput.checked = f.enabled !== false;
-                tglInput.dataset.pfmAction   = 'toggle';
-                tglInput.dataset.pfmField    = fieldId;
-                tglInput.dataset.pfmCategory = f.category_name;
-                const tglSlider = document.createElement('span');
-                tglSlider.className = 'pfm-toggle-slider';
-                tglLabel.appendChild(tglInput);
-                tglLabel.appendChild(tglSlider);
-                top.appendChild(tglLabel);
-            }
-            card.appendChild(top);
-
-            // Icon (static markup)
-            const icon = document.createElement('div');
-            icon.className = 'pfm-card-icon';
-            icon.innerHTML = '<i class="fas fa-file-code"></i>';
-            card.appendChild(icon);
-
-            // Name & meta — textContent avoids any HTML injection
-            const name = document.createElement('div');
-            name.className = 'pfm-card-name';
-            name.textContent = f.display_name || f.filename;
-            card.appendChild(name);
-
-            const meta = document.createElement('div');
-            meta.className = 'pfm-card-meta';
-            meta.appendChild(document.createTextNode(f.filename));
-            meta.appendChild(document.createElement('br'));
-            if (f.entry_count != null) {
-                meta.appendChild(document.createTextNode(f.entry_count + ' entries · ' + formatSize(f.size)));
-            }
-            meta.appendChild(document.createElement('br'));
-            meta.appendChild(document.createTextNode(formatDate(f.modified)));
-            card.appendChild(meta);
-
-            // Action buttons
-            const actions = document.createElement('div');
-            actions.className = 'pfm-card-actions';
-            if (st.actions.get && st.actions.save) {
-                const editBtn = document.createElement('button');
-                editBtn.className = 'pfm-btn pfm-btn-primary';
-                editBtn.dataset.pfmAction = 'edit';
-                editBtn.dataset.pfmField  = fieldId;
-                editBtn.dataset.pfmFile   = f.filename;
-                editBtn.innerHTML = '<i class="fas fa-edit"></i> Edit'; // static
-                actions.appendChild(editBtn);
-            }
-            if (st.actions.delete) {
-                const delBtn = document.createElement('button');
-                delBtn.className = 'pfm-btn pfm-btn-danger pfm-btn-sm';
-                delBtn.dataset.pfmAction = 'delete';
-                delBtn.dataset.pfmField  = fieldId;
-                delBtn.dataset.pfmFile   = f.filename;
-                delBtn.innerHTML = '<i class="fas fa-trash"></i>'; // static
-                actions.appendChild(delBtn);
-            }
-            card.appendChild(actions);
-            frag.appendChild(card);
-        });
-        grid.appendChild(frag);
-    }
-
-    // ─── Edit modal ───────────────────────────────────────────────────────────
-
-    window._pfmOpenEdit = async function (fieldId, filename) {
-        const st = getState(fieldId);
-        const overlay = createOverlay(fieldId);
-        // Build modal using DOM methods so filename never enters a JS string literal.
-        const modal = document.createElement('div');
-        modal.className = 'pfm-modal';
-        safeSetHTML(modal, `
-            <div class="pfm-modal-header">
-                <span class="pfm-modal-title"><i class="fas fa-edit mr-2"></i>${escHtml(filename)}</span>
-                <button class="pfm-btn pfm-btn-secondary pfm-btn-sm" id="${escHtml(fieldId)}_modal_close">
-                    <i class="fas fa-times"></i>
-                </button>
-            </div>
-            <div class="pfm-modal-body" id="${escHtml(fieldId)}_edit_body">
-                <div class="pfm-empty"><i class="fas fa-spinner fa-spin"></i>Loading…</div>
-            </div>
-            <div class="pfm-modal-footer">
-                <button class="pfm-btn pfm-btn-secondary" id="${escHtml(fieldId)}_modal_cancel">Cancel</button>
-                <button class="pfm-btn pfm-btn-primary" id="${escHtml(fieldId)}_save_btn">
-                    <i class="fas fa-save mr-1"></i>Save
-                </button>
-            </div>`;
-        overlay.appendChild(modal);
-        // Bind events after DOM insertion — filename captured in closure, not in HTML.
-        modal.querySelector(`#${CSS.escape(fieldId)}_modal_close`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_modal_cancel`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_save_btn`).addEventListener('click', () => window._pfmSave(fieldId, filename));
-
-        const data = await callAction(st.pluginId, st.actions.get, { filename }).catch(() => null);
-        const body = document.getElementById(`${fieldId}_edit_body`);
-        if (!data || data.status !== 'success' || !body) {
-            if (body) safeSetHTML(body, '<div class="pfm-empty" style="color:#dc2626">Failed to load file.</div>');
-            return;
-        }
-
-        const content = data.content || data.data || {};
-        st._editFilename = filename;
-
-        if (isTabular(content)) {
-            // Table path: track cell edits live in _editData
-            st._editData = content;
-            renderEntryTable(fieldId, body, content);
-        } else {
-            // Textarea path: _editData stays null; save() reads from the <textarea>
-            st._editData = null;
-            safeSetHTML(body, `
-                <textarea id="${escHtml(fieldId)}_json_ta" rows="20"
-                    style="width:100%;font-family:monospace;font-size:.75rem;border:1px solid #d1d5db;border-radius:.375rem;padding:.5rem;"
-                >${escHtml(JSON.stringify(content, null, 2))}</textarea>
-                <div id="${escHtml(fieldId)}_json_err" style="color:#dc2626;font-size:.75rem;margin-top:.25rem;"></div>`;
-        }
-    };
-
-    function isTabular(data) {
-        if (typeof data !== 'object' || Array.isArray(data)) return false;
-        const keys = Object.keys(data);
-        if (!keys.length) return false;
-        const first = data[keys[0]];
-        if (typeof first !== 'object' || Array.isArray(first)) return false;
-        const entryKeys = Object.keys(first);
-        return entryKeys.length > 0 && entryKeys.length <= 8;
-    }
-
-    function renderEntryTable(fieldId, container, content) {
-        const st = getState(fieldId);
-        const entries = Object.entries(content).sort((a, b) => parseInt(a[0]) - parseInt(b[0]));
-        if (!entries.length) { container.textContent = 'No entries.'; return; }
-
-        const cols = Object.keys(entries[0][1]);
-        const MS_PER_DAY = 86400 * 1000; // eslint-disable-line no-magic-numbers -- 86400s/day is not magic
-        const todayDoy = Math.ceil((new Date() - new Date(new Date().getFullYear(), 0, 0)) / MS_PER_DAY);
-        const total = entries.length;
-        const perPage = st.entriesPerPage;
-
-        function buildPage(page) {
-            const start = (page - 1) * perPage; // eslint-disable-line no-magic-numbers
-            const pageEntries = entries.slice(start, start + perPage);
-            const totalPages = Math.ceil(total / perPage);
-
-            safeSetHTML(container, `
-                <div class="pfm-table-info" style="font-size:.75rem;color:#6b7280;margin-bottom:.375rem;">
-                    ${total} entries total
-                    <button class="pfm-btn pfm-btn-secondary pfm-btn-sm" style="margin-left:.5rem"
-                        onclick="(function(){const targetPage=Math.ceil(${todayDoy}/${perPage});window._pfmTablePage('${fieldId}',targetPage);setTimeout(function(){const row=document.querySelector('tr[data-day=\\'${todayDoy}\\']');if(row)row.scrollIntoView({block:'center'});},60);})()">
-                        <i class="fas fa-calendar-day"></i> Jump to today (day ${todayDoy})
-                    </button>
-                </div>
-                <div id="${fieldId}_tbl_wrap" class="pfm-table-wrap" style="max-height:52vh;overflow-y:auto;">
-                    <table class="pfm-table">
-                        <thead>
-                            <tr>
-                                <th class="pfm-day-col">Day</th>
-                                ${cols.map(c => `<th>${escHtml(c.replace(/_/g, ' ').replace(/\b\w/g, l => l.toUpperCase()))}</th>`).join('')}
-                            </tr>
-                        </thead>
-                        <tbody>
-                            ${pageEntries.map(([day, val]) => `
-                            <tr data-day="${day}" class="${parseInt(day) === todayDoy ? 'today-row' : ''}">
-                                <td class="pfm-day-col" style="user-select:none;">${escHtml(day)}</td>
-                                ${cols.map(col => {
-                                    const v = val[col] ?? '';
-                                    const isLong = String(v).length > 60 || col === 'description' || col === 'definition' || col === 'content';
-                                    return isLong
-                                        ? `<td><textarea data-day="${day}" data-col="${escHtml(col)}" rows="2"
-                                            oninput="window._pfmCellEdit('${fieldId}','${day}','${escHtml(col)}',this.value)"
-                                            >${escHtml(String(v))}</textarea></td>`
-                                        : `<td><input type="text" data-day="${day}" data-col="${escHtml(col)}"
-                                            value="${escHtml(String(v))}"
-                                            oninput="window._pfmCellEdit('${fieldId}','${day}','${escHtml(col)}',this.value)"></td>`;
-                                }).join('')}
-                            </tr>`).join('')}
-                        </tbody>
-                    </table>
-                </div>
-                <div class="pfm-pagination">
-                    <span>Page ${page} of ${totalPages}</span>
-                    <div class="pfm-page-jump">
-                        <button class="pfm-btn pfm-btn-secondary pfm-btn-sm"
-                                ${page <= 1 ? 'disabled' : ''}
-                                onclick="window._pfmTablePage('${fieldId}',${page - 1})">‹ Prev</button>
-                        <span>Go to</span>
-                        <input type="number" min="1" max="${totalPages}" value="${page}"
-                            onchange="window._pfmTablePage('${fieldId}',+this.value)">
-                        <button class="pfm-btn pfm-btn-secondary pfm-btn-sm"
-                                ${page >= totalPages ? 'disabled' : ''}
-                                onclick="window._pfmTablePage('${fieldId}',${page + 1})">Next ›</button>
-                    </div>
-                </div>`;
-            st._tablePage = page;
-            st._tableEntries = entries;
-            st._tableCols = cols;
-        }
-
-        // Store buildPage in per-instance state so multiple instances don't
-        // clobber each other's pagination via a shared global.
-        st._buildPage = buildPage;
-        buildPage(st._tablePage || 1);
-    }
-
-    // Global dispatcher — resolves the per-instance buildPage from state so
-    // multiple plugin-file-manager instances don't clobber each other.
-    window._pfmTablePage = function (fId, p) {
-        const s = getState(fId);
-        if (s._buildPage) {
-            const total = s._tableEntries ? s._tableEntries.length : 0;
-            const totalP = Math.ceil(total / s.entriesPerPage) || 1;
-            s._buildPage(Math.max(1, Math.min(p, totalP)));
-        }
-    };
-
-    window._pfmCellEdit = function (fieldId, day, col, value) {
-        const st = getState(fieldId);
-        if (st._editData && st._editData[day]) st._editData[day][col] = value;
-    };
-
-    window._pfmSave = async function (fieldId, filename) {
-        const st = getState(fieldId);
-        const saveBtn = document.getElementById(`${fieldId}_save_btn`);
-        let content;
-
-        // Try getting from inline table data first, then textarea fallback
-        if (st._editData) {
-            content = st._editData;
-        } else {
-            const ta = document.getElementById(`${fieldId}_json_ta`);
-            if (!ta) return;
-            try { content = JSON.parse(ta.value); }
-            catch (e) {
-                const errEl = document.getElementById(`${fieldId}_json_err`);
-                if (errEl) errEl.textContent = 'Invalid JSON: ' + e.message;
-                return;
-            }
-        }
-
-        if (saveBtn) { saveBtn.disabled = true; (function(b){b.textContent='';const i=document.createElement('i');i.className='fas fa-spinner fa-spin mr-1';b.appendChild(i);b.appendChild(document.createTextNode('Saving…'));})(saveBtn); }
-
-        const result = await callAction(st.pluginId, st.actions.save, {
-            filename, content: JSON.stringify(content)
-        }).catch(() => ({ status: 'error', message: 'Network error' }));
-
-        if (saveBtn) { saveBtn.disabled = false; (function(b){b.textContent='';const i=document.createElement('i');i.className='fas fa-save mr-1';b.appendChild(i);b.appendChild(document.createTextNode('Save'));})(saveBtn); }
-
-        if (result.status === 'success') {
-            notify('File saved successfully', 'success');
-            window._pfmCloseModal(fieldId);
-            await loadFiles(fieldId);
-        } else {
-            notify('Save failed: ' + (result.message || 'Unknown error'), 'error');
-        }
-    };
-
-    // ─── Delete modal ─────────────────────────────────────────────────────────
-
-    window._pfmOpenDelete = function (fieldId, filename) {
-        const overlay = createOverlay(fieldId);
-        const modal = document.createElement('div');
-        modal.className = 'pfm-modal';
-        modal.style.maxWidth = '28rem';
-        safeSetHTML(modal, `
-            <div class="pfm-modal-header">
-                <span class="pfm-modal-title"><i class="fas fa-trash mr-2"></i>Delete File</span>
-                <button class="pfm-btn pfm-btn-secondary pfm-btn-sm" id="${escHtml(fieldId)}_del_close">
-                    <i class="fas fa-times"></i>
-                </button>
-            </div>
-            <div class="pfm-modal-body">
-                <div class="pfm-danger-box">
-                    <strong>${escHtml(filename)}</strong> will be permanently deleted and removed
-                    from the plugin configuration. This cannot be undone.
-                </div>
-            </div>
-            <div class="pfm-modal-footer">
-                <button class="pfm-btn pfm-btn-secondary" id="${escHtml(fieldId)}_del_cancel">Cancel</button>
-                <button class="pfm-btn pfm-btn-danger" id="${escHtml(fieldId)}_del_confirm">
-                    <i class="fas fa-trash mr-1"></i>Delete
-                </button>
-            </div>`;
-        overlay.appendChild(modal);
-        modal.querySelector(`#${CSS.escape(fieldId)}_del_close`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_del_cancel`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_del_confirm`).addEventListener('click', () => window._pfmConfirmDelete(fieldId, filename));
-    };
-
-    window._pfmConfirmDelete = async function (fieldId, filename) {
-        const st = getState(fieldId);
-        const result = await callAction(st.pluginId, st.actions.delete, { filename })
-            .catch(() => ({ status: 'error', message: 'Network error' }));
-        if (result.status === 'success') {
-            notify('File deleted', 'success');
-            window._pfmCloseModal(fieldId);
-            await loadFiles(fieldId);
-        } else {
-            notify('Delete failed: ' + (result.message || ''), 'error');
-        }
-    };
-
-    // ─── Create modal ─────────────────────────────────────────────────────────
-
-    window._pfmOpenCreate = function (fieldId) {
-        const st = getState(fieldId);
-        const fields = st.createFields;
-        const overlay = createOverlay(fieldId);
-        const modal = document.createElement('div');
-        modal.className = 'pfm-modal';
-        modal.style.maxWidth = '32rem';
-        safeSetHTML(modal, `
-            <div class="pfm-modal-header">
-                <span class="pfm-modal-title"><i class="fas fa-plus-circle mr-2"></i>Create New File</span>
-                <button class="pfm-btn pfm-btn-secondary pfm-btn-sm" id="${escHtml(fieldId)}_cre_close">
-                    <i class="fas fa-times"></i>
-                </button>
-            </div>
-            <div class="pfm-modal-body">
-                <div id="${escHtml(fieldId)}_create_err" class="pfm-field-error" style="margin-bottom:.5rem;"></div>
-                ${fields.map(f => `
-                <div class="pfm-field">
-                    <label for="${escHtml(fieldId)}_cf_${escHtml(f.key)}">${escHtml(f.label || f.key)}</label>
-                    <input type="text" id="${escHtml(fieldId)}_cf_${escHtml(f.key)}"
-                           placeholder="${escHtml(f.placeholder || '')}"
-                           ${f.pattern ? `pattern="${escHtml(f.pattern)}"` : ''}>
-                    ${f.hint ? `<div class="pfm-field-hint">${escHtml(f.hint)}</div>` : ''}
-                </div>`).join('')}
-            </div>
-            <div class="pfm-modal-footer">
-                <button class="pfm-btn pfm-btn-secondary" id="${escHtml(fieldId)}_cre_cancel">Cancel</button>
-                <button class="pfm-btn pfm-btn-create" id="${escHtml(fieldId)}_create_btn">
-                    <i class="fas fa-plus mr-1"></i>Create
-                </button>
-            </div>
-            </div>`;
-        overlay.appendChild(modal);
-        modal.querySelector(`#${CSS.escape(fieldId)}_cre_close`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_cre_cancel`).addEventListener('click', () => window._pfmCloseModal(fieldId));
-        modal.querySelector(`#${CSS.escape(fieldId)}_create_btn`).addEventListener('click', () => window._pfmConfirmCreate(fieldId));
-    };
-
-    window._pfmConfirmCreate = async function (fieldId) {
-        const st = getState(fieldId);
-        const errEl = document.getElementById(`${fieldId}_create_err`);
-        const btn = document.getElementById(`${fieldId}_create_btn`);
-        const params = {};
-
-        for (const f of st.createFields) {
-            const inp = document.getElementById(`${fieldId}_cf_${f.key}`);
-            if (!inp) continue;
-            const val = inp.value.trim();
-            // Client-side pattern validation omitted — server-side create-file script validates.
-            params[f.key] = val;
-        }
-
-        if (btn) { btn.disabled = true; (function(b){b.textContent='';const i=document.createElement('i');i.className='fas fa-spinner fa-spin mr-1';b.appendChild(i);b.appendChild(document.createTextNode('Creating…'));})(btn); }
-        if (errEl) errEl.textContent = '';
-
-        const result = await callAction(st.pluginId, st.actions.create, params)
-            .catch(() => ({ status: 'error', message: 'Network error' }));
-
-        if (btn) { btn.disabled = false; (function(b){b.textContent='';const i=document.createElement('i');i.className='fas fa-plus mr-1';b.appendChild(i);b.appendChild(document.createTextNode('Create'));})(btn); }
-
-        if (result.status === 'success') {
-            notify('File created', 'success');
-            window._pfmCloseModal(fieldId);
-            await loadFiles(fieldId);
-        } else {
-            if (errEl) errEl.textContent = result.message || 'Create failed';
-        }
-    };
-
-    // ─── Toggle ───────────────────────────────────────────────────────────────
-
-    window._pfmToggle = async function (fieldId, categoryName, enabled) {
-        const st = getState(fieldId);
-        const result = await callAction(st.pluginId, st.actions.toggle, { category_name: categoryName, enabled })
-            .catch(() => ({ status: 'error' }));
-        if (result.status === 'success') {
-            notify(enabled ? `${categoryName} enabled` : `${categoryName} disabled`, 'success');
-            await loadFiles(fieldId);
-        } else {
-            notify('Toggle failed', 'error');
-            await loadFiles(fieldId); // revert UI
-        }
-    };
-
-    // ─── Upload ───────────────────────────────────────────────────────────────
-
-    window._pfmUpload = async function (fieldId, file) {
-        const st = getState(fieldId);
-        const notifyFn = window.showNotification || console.log;
-        if (!file.name.toLowerCase().endsWith('.json')) {
-            notifyFn('Only .json files can be uploaded', 'error'); return;
-        }
-        let content;
-        try { content = await file.text(); JSON.parse(content); }
-        catch { notifyFn('File contains invalid JSON', 'error'); return; }
-
-        const result = await callAction(st.pluginId, st.actions.upload, {
-            filename: file.name, content
-        }).catch(() => ({ status: 'error', message: 'Network error' }));
-
-        if (result.status === 'success') {
-            notify('File uploaded: ' + (result.filename || file.name), 'success');
-            await loadFiles(fieldId);
-        } else {
-            notify('Upload failed: ' + (result.message || ''), 'error');
-        }
-    };
-
-    // ─── Modal helpers ────────────────────────────────────────────────────────
-
-    function createOverlay(fieldId) {
-        window._pfmCloseModal(fieldId); // close any open modal first
-        const overlay = document.createElement('div');
-        overlay.className = 'pfm-overlay';
-        overlay.id = `${fieldId}_pfm_overlay`;
-        // Close on backdrop click
-        overlay.addEventListener('click', e => { if (e.target === overlay) window._pfmCloseModal(fieldId); });
-        document.body.appendChild(overlay);
-        getState(fieldId).currentModal = overlay;
-        return overlay;
-    }
-
-    window._pfmCloseModal = function (fieldId) {
-        const st = getState(fieldId);
-        if (st.currentModal) { st.currentModal.remove(); st.currentModal = null; }
-        st._editData = null;
-        st._editFilename = null;
-    };
-
-    // ─── Widget registration ──────────────────────────────────────────────────
-
-    window.LEDMatrixWidgets.register('plugin-file-manager', {
-        name: 'Plugin File Manager Widget',
-        version: '1.0.0',
-
-        render: function (container, config, value, options) {
-            const fieldId  = (options.fieldId || container.id || 'pfm').replace(/[^a-zA-Z0-9_-]/g, '_');
-            const wc       = config['x-widget-config'] || {};
-            const actions  = wc.actions        || {};
-            const pluginId = options.pluginId   || '';
-
-            const st = getState(fieldId);
-            Object.assign(st, {
-                pluginId,
-                actions,
-                createFields:   wc.create_fields    || [],
-                uploadHint:     wc.upload_hint       || 'Upload JSON files',
-                directoryLabel: wc.directory_label   || ''
-            });
-
-            safeSetHTML(container, `
-                <div class="pfm-root" id="${fieldId}_pfm">
-                    <div class="pfm-header">
-                        <div>
-                            <div class="pfm-title">File Explorer</div>
-                            ${st.directoryLabel ? `<div class="pfm-dir">Manage files in <code>${escHtml(st.directoryLabel)}</code></div>` : ''}
-                        </div>
-                        <div style="display:flex;gap:.375rem;">
-                            ${actions.create ? `
-                            <button class="pfm-btn pfm-btn-create"
-                                    onclick="window._pfmOpenCreate('${fieldId}')">
-                                <i class="fas fa-plus mr-1"></i>New File
-                            </button>` : ''}
-                        </div>
-                    </div>
-
-                    ${actions.upload ? `
-                    <div class="pfm-upload" id="${fieldId}_upload_zone"
-                         onclick="document.getElementById('${fieldId}_file_input').click()"
-                         ondragover="event.preventDefault();this.classList.add('dragover')"
-                         ondragleave="this.classList.remove('dragover')"
-                         ondrop="this.classList.remove('dragover');event.preventDefault();
-                                 if(event.dataTransfer.files[0])window._pfmUpload('${fieldId}',event.dataTransfer.files[0])">
-                        <input type="file" id="${fieldId}_file_input" accept=".json"
-                               style="display:none"
-                               onchange="if(this.files[0])window._pfmUpload('${fieldId}',this.files[0]);this.value=''">
-                        <i class="fas fa-cloud-upload-alt" style="font-size:1.5rem;color:#9ca3af;"></i>
-                        <p>Drag and drop or click to upload</p>
-                        <small>${escHtml(st.uploadHint)}</small>
-                    </div>` : ''}
-
-                    <div class="pfm-grid">
-                        <div class="pfm-empty"><i class="fas fa-spinner fa-spin"></i>Loading…</div>
-                    </div>
-                </div>`;
-
-            loadFiles(fieldId);
-        },
-
-        getValue: function () { return null; }, // file ops are immediate; nothing to submit
-        setValue: function (fieldId) { loadFiles(fieldId); }
-    });
-
-    console.log('[PluginFileManager] plugin-file-manager widget registered');
-})();

web_interface/static/v3/js/widgets/time-picker.js

@@ -1,166 +0,0 @@
-/**
- * LEDMatrix Time Picker Widget
- *
- * Single time selection using the browser's native time input.
- * Returns a string in HH:MM (24-hour) format.
- *
- * Schema example:
- * {
- *   "target_time": {
- *     "type": "string",
- *     "x-widget": "time-picker",
- *     "default": "00:00",
- *     "x-options": {
- *       "placeholder": "Select time",
- *       "clearable": true
- *     }
- *   }
- * }
- *
- * @module TimePickerWidget
- */
-
-(function() {
-    'use strict';
-
-    const base = window.BaseWidget ? new window.BaseWidget('TimePicker', '1.0.0') : null;
-
-    function escapeHtml(text) {
-        if (base) return base.escapeHtml(text);
-        const div = document.createElement('div');
-        div.textContent = String(text);
-        return div.innerHTML.replace(/"/g, '"').replace(/'/g, ''');
-    }
-
-    function sanitizeId(id) {
-        if (base) return base.sanitizeId(id);
-        return String(id).replace(/[^a-zA-Z0-9_-]/g, '_');
-    }
-
-    function triggerChange(fieldId, value) {
-        if (base) {
-            base.triggerChange(fieldId, value);
-        } else {
-            document.dispatchEvent(new CustomEvent('widget-change', {
-                detail: { fieldId, value },
-                bubbles: true,
-                cancelable: true
-            }));
-        }
-    }
-
-    function safeSetHTML(target, html) {
-        target.textContent = '';
-        // createContextualFragment parses html relative to the document context
-        // without executing scripts — a widely recognised safe insertion method.
-        const frag = document.createRange().createContextualFragment(html);
-        target.appendChild(frag);
-    }
-
-    window.LEDMatrixWidgets.register('time-picker', {
-        name: 'Time Picker Widget',
-        version: '1.0.0',
-
-        render: function(container, config, value, options) {
-            const fieldId = sanitizeId(options.fieldId || container.id || 'time_picker');
-            const xOptions = config['x-options'] || config['x_options'] || {};
-            const placeholder = xOptions.placeholder || '';
-            const clearable = xOptions.clearable === true;
-            const disabled = xOptions.disabled === true;
-            const required = xOptions.required === true;
-
-            const currentValue = value || '';
-
-            let html = `<div id="${fieldId}_widget" class="time-picker-widget" data-field-id="${fieldId}">`;
-            html += '<div class="flex items-center">';
-            html += `
-                <div class="relative flex-1">
-                    <input type="time"
-                           id="${fieldId}_input"
-                           name="${escapeHtml(options.name || fieldId)}"
-                           value="${escapeHtml(currentValue)}"
-                           ${placeholder ? `placeholder="${escapeHtml(placeholder)}"` : ''}
-                           ${disabled ? 'disabled' : ''}
-                           ${required ? 'required' : ''}
-                           onchange="window.LEDMatrixWidgets.getHandlers('time-picker').onChange('${fieldId}')"
-                           class="form-input w-full rounded-md border-gray-300 shadow-sm focus:border-blue-500 focus:ring-blue-500 ${disabled ? 'bg-gray-100 cursor-not-allowed' : 'bg-white'} text-black pr-10">
-                    <div class="absolute inset-y-0 right-0 flex items-center pr-3 pointer-events-none">
-                        <i class="fas fa-clock text-gray-400"></i>
-                    </div>
-                </div>
-            `;
-
-            if (clearable && !disabled) {
-                html += `
-                    <button type="button"
-                            id="${fieldId}_clear"
-                            onclick="window.LEDMatrixWidgets.getHandlers('time-picker').onClear('${fieldId}')"
-                            class="ml-2 inline-flex items-center px-2 py-2 text-gray-400 hover:text-gray-600 ${currentValue ? '' : 'hidden'}"
-                            title="Clear">
-                        <i class="fas fa-times"></i>
-                    </button>
-                `;
-            }
-
-            html += '</div>';
-            html += `<div id="${fieldId}_error" class="text-sm text-red-600 mt-1 hidden"></div>`;
-            html += '</div>';
-
-            safeSetHTML(container, html);
-        },
-
-        getValue: function(fieldId) {
-            const safeId = sanitizeId(fieldId);
-            const input = document.getElementById(`${safeId}_input`);
-            return input ? input.value : '';
-        },
-
-        setValue: function(fieldId, value) {
-            const safeId = sanitizeId(fieldId);
-            const input = document.getElementById(`${safeId}_input`);
-            const clearBtn = document.getElementById(`${safeId}_clear`);
-            if (input) input.value = value || '';
-            if (clearBtn) clearBtn.classList.toggle('hidden', !value);
-        },
-
-        validate: function(fieldId) {
-            const safeId = sanitizeId(fieldId);
-            const input = document.getElementById(`${safeId}_input`);
-            const errorEl = document.getElementById(`${safeId}_error`);
-            if (!input) return { valid: true, errors: [] };
-            const isValid = input.checkValidity();
-            if (errorEl) {
-                if (!isValid) {
-                    errorEl.textContent = input.validationMessage;
-                    errorEl.classList.remove('hidden');
-                    input.classList.add('border-red-500');
-                } else {
-                    errorEl.classList.add('hidden');
-                    input.classList.remove('border-red-500');
-                }
-            }
-            return { valid: isValid, errors: isValid ? [] : [input.validationMessage] };
-        },
-
-        handlers: {
-            onChange: function(fieldId) {
-                const widget = window.LEDMatrixWidgets.get('time-picker');
-                const safeId = sanitizeId(fieldId);
-                const clearBtn = document.getElementById(`${safeId}_clear`);
-                const value = widget.getValue(fieldId);
-                if (clearBtn) clearBtn.classList.toggle('hidden', !value);
-                widget.validate(fieldId);
-                triggerChange(fieldId, value);
-            },
-
-            onClear: function(fieldId) {
-                const widget = window.LEDMatrixWidgets.get('time-picker');
-                widget.setValue(fieldId, '');
-                widget.validate(fieldId); // refresh required/error state
-                triggerChange(fieldId, '');
-            }
-        }
-    });
-
-    console.log('[TimePickerWidget] Time picker widget registered');
-})();

web_interface/static/v3/plugins_manager.js

@@ -3446,28 +3446,6 @@ function generateFieldHtml(key, prop, value, prefix = '') {
             html += `<option value="${option}" ${selected}>${option}</option>`;
         });
         html += `</select>`;
-    } else if (prop['x-widget'] === 'json-file-manager') {
-        // Reusable JSON file manager widget (no CDN, keyboard shortcuts, configurable actions)
-        const widgetConfig = prop['x-widget-config'] || {};
-        const pluginId = currentPluginConfig?.pluginId || window.currentPluginConfig?.pluginId || '';
-        const safeFieldId = (fullKey || 'file_manager').replace(/[^a-zA-Z0-9_-]/g, '_');
-
-        html += `<div id="${safeFieldId}_jfm_mount"></div>`;
-
-        setTimeout(() => {
-            const mount = document.getElementById(`${safeFieldId}_jfm_mount`);
-            if (!mount) return;
-            // Destroy the previous instance for this mount only — leave other instances intact
-            window.__jfmInstances = window.__jfmInstances || {};
-            const prev = window.__jfmInstances[safeFieldId];
-            if (prev?._destroy) prev._destroy();
-            if (typeof JsonFileManager !== 'undefined') {
-                window.__jfmInstances[safeFieldId] = new JsonFileManager(mount, widgetConfig, pluginId);
-            } else {
-                window.__jfmInstances[safeFieldId] = null;
-                mount.innerHTML = '<p style="color:#dc2626;font-size:.875rem;">json-file-manager widget not loaded. Check base.html includes json-file-manager.js.</p>';
-            }
-        }, 150);
     } else if (prop['x-widget'] === 'custom-html') {
         // Custom HTML widget - load HTML from plugin directory
         const htmlFile = prop['x-html-file'];

web_interface/templates/v3/base.html

@@ -352,14 +352,15 @@
                         }
                     });
 
-                    // Mark tab containers as loaded once their content settles, so switching
-                    // away and back doesn't re-fetch. Scoped to the "loadtab" trigger (tab
-                    // containers only) so modals and plugin config panels can still reload.
+                    // Set data-loaded on tab containers after HTMX settles their content,
+                    // preventing repeated re-fetches on every tab switch.
+                    // Scoped to elements with hx-trigger="revealed" (tab containers only) so
+                    // modals and plugin config panels that legitimately reload are unaffected.
                     document.body.addEventListener('htmx:afterSettle', function(event) {
                         if (event.detail && event.detail.target) {
                             var target = event.detail.target;
                             var trigger = target.getAttribute('hx-trigger') || '';
-                            if (trigger.includes('loadtab')) {
+                            if (trigger.includes('revealed')) {
                                 target.setAttribute('data-loaded', 'true');
                             }
                         }
@@ -866,7 +867,7 @@
     <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.0.0/css/all.min.css">
 
     <!-- Custom v3 styles -->
-    <link rel="stylesheet" href="{{ url_for('static', filename='v3/app.css') }}">
+    <link rel="stylesheet" href="{{ url_for('static', filename='v3/app.css') }}?v=20260216b">
 </head>
 <body x-data="app()" class="bg-gray-50 min-h-screen">
     <!-- Header -->
@@ -1029,7 +1030,7 @@
         <div id="tab-content" class="space-y-6">
             <!-- Overview tab -->
             <div x-show="activeTab === 'overview'" x-transition>
-                <div id="overview-content" hx-get="/v3/partials/overview" hx-trigger="loadtab" hx-swap="innerHTML" hx-on::htmx:response-error="loadOverviewDirect()">
+                <div id="overview-content" hx-get="/v3/partials/overview" hx-trigger="revealed" hx-swap="innerHTML" hx-on::htmx:response-error="loadOverviewDirect()">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1097,7 +1098,7 @@
 
             <!-- General tab -->
             <div x-show="activeTab === 'general'" x-transition>
-                <div id="general-content" hx-get="/v3/partials/general" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="general-content" hx-get="/v3/partials/general" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1115,7 +1116,7 @@
             <div x-show="activeTab === 'wifi'" x-transition>
                 <div id="wifi-content" 
                      hx-get="/v3/partials/wifi" 
-                     hx-trigger="loadtab" 
+                     hx-trigger="revealed" 
                      hx-swap="innerHTML"
                      hx-on::htmx:response-error="loadWifiDirect()">
                     <div class="animate-pulse">
@@ -1166,7 +1167,7 @@
 
             <!-- Schedule tab -->
             <div x-show="activeTab === 'schedule'" x-transition>
-                <div id="schedule-content" hx-get="/v3/partials/schedule" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="schedule-content" hx-get="/v3/partials/schedule" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1182,7 +1183,7 @@
 
             <!-- Display tab -->
             <div x-show="activeTab === 'display'" x-transition>
-                <div id="display-content" hx-get="/v3/partials/display" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="display-content" hx-get="/v3/partials/display" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1197,7 +1198,7 @@
 
             <!-- Backup & Restore tab -->
             <div x-show="activeTab === 'backup-restore'" x-transition>
-                <div id="backup-restore-content" hx-get="/v3/partials/backup-restore" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="backup-restore-content" hx-get="/v3/partials/backup-restore" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1209,7 +1210,7 @@
 
             <!-- Config Editor tab -->
             <div x-show="activeTab === 'config-editor'" x-transition>
-                <div id="config-editor-content" hx-get="/v3/partials/raw-json" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="config-editor-content" hx-get="/v3/partials/raw-json" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1224,7 +1225,7 @@
 
             <!-- Plugins tab -->
             <div x-show="activeTab === 'plugins'" x-transition>
-                <div id="plugins-content" hx-get="/v3/partials/plugins" hx-trigger="loadtab" hx-swap="innerHTML"
+                <div id="plugins-content" hx-get="/v3/partials/plugins" hx-trigger="revealed" hx-swap="innerHTML"
                      hx-on::response-error="loadPluginsDirect()">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
@@ -1241,7 +1242,7 @@
 
             <!-- Fonts tab -->
             <div x-show="activeTab === 'fonts'" x-transition>
-                <div id="fonts-content" hx-get="/v3/partials/fonts" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="fonts-content" hx-get="/v3/partials/fonts" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1256,7 +1257,7 @@
 
             <!-- Logs tab -->
             <div x-show="activeTab === 'logs'" x-transition>
-                <div id="logs-content" hx-get="/v3/partials/logs" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="logs-content" hx-get="/v3/partials/logs" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1268,7 +1269,7 @@
 
             <!-- Cache tab -->
             <div x-show="activeTab === 'cache'" x-transition>
-                <div id="cache-content" hx-get="/v3/partials/cache" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="cache-content" hx-get="/v3/partials/cache" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1280,7 +1281,7 @@
 
             <!-- Operation History tab -->
             <div x-show="activeTab === 'operation-history'" x-transition>
-                <div id="operation-history-content" hx-get="/v3/partials/operation-history" hx-trigger="loadtab" hx-swap="innerHTML">
+                <div id="operation-history-content" hx-get="/v3/partials/operation-history" hx-trigger="revealed" hx-swap="innerHTML">
                     <div class="animate-pulse">
                         <div class="bg-white rounded-lg shadow p-6">
                             <div class="h-4 bg-gray-200 rounded w-1/4 mb-4"></div>
@@ -1369,64 +1370,34 @@
 
     <!-- SSE connection for real-time updates -->
     <script>
-        // Assign to window so reconnectSSE() in app.js can reach them.
-        window.statsSource = new EventSource('/api/v3/stream/stats');
-        window.displaySource = new EventSource('/api/v3/stream/display');
+        // Connect to SSE streams
+        const statsSource = new EventSource('/api/v3/stream/stats');
+        const displaySource = new EventSource('/api/v3/stream/display');
 
-        window.statsSource.onmessage = function(event) {
+        statsSource.onmessage = function(event) {
             const data = JSON.parse(event.data);
             updateSystemStats(data);
         };
 
-        window.displaySource.onmessage = function(event) {
+        displaySource.onmessage = function(event) {
             const data = JSON.parse(event.data);
             updateDisplayPreview(data);
         };
 
-        function _setConnectionStatus(connected, reconnecting) {
-            const el = document.getElementById('connection-status');
-            if (!el) return;
-            if (connected) {
-                el.innerHTML = `
-                    <div class="w-2 h-2 bg-green-500 rounded-full"></div>
-                    <span class="text-gray-600">Connected</span>
-                `;
-            } else if (reconnecting) {
-                el.innerHTML = `
-                    <div class="w-2 h-2 bg-yellow-500 rounded-full animate-pulse"></div>
-                    <span class="text-gray-600">Reconnecting…</span>
-                `;
-            } else {
-                el.innerHTML = `
-                    <div class="w-2 h-2 bg-red-500 rounded-full"></div>
-                    <span class="text-gray-600" title="Connection lost — try refreshing the page">Disconnected</span>
-                `;
-            }
-        }
+        // Connection status
+        statsSource.addEventListener('open', function() {
+            document.getElementById('connection-status').innerHTML = `
+                <div class="w-2 h-2 bg-green-500 rounded-full"></div>
+                <span class="text-gray-600">Connected</span>
+            `;
+        });
 
-        var _statsErrorCount = 0;
-
-        // Named on window so reconnectSSE() in app.js can reattach them after
-        // replacing the EventSource instances.
-        window._statsOpenHandler = function() {
-            _statsErrorCount = 0;
-            _setConnectionStatus(true, false);
-        };
-        window._statsErrorHandler = function() {
-            _statsErrorCount++;
-            // EventSource readyState 0 = CONNECTING (auto-retrying), 2 = CLOSED
-            var reconnecting = window.statsSource.readyState === EventSource.CONNECTING;
-            _setConnectionStatus(false, reconnecting && _statsErrorCount <= 3);
-        };
-        window._displayErrorHandler = function() {
-            // Display stream errors don't change the status badge but log to console
-            // so failures aren't completely silent.
-            console.warn('LEDMatrix: display preview stream error (readyState=' + window.displaySource.readyState + ')');
-        };
-
-        window.statsSource.addEventListener('open', window._statsOpenHandler);
-        window.statsSource.addEventListener('error', window._statsErrorHandler);
-        window.displaySource.addEventListener('error', window._displayErrorHandler);
+        statsSource.addEventListener('error', function() {
+            document.getElementById('connection-status').innerHTML = `
+                <div class="w-2 h-2 bg-red-500 rounded-full"></div>
+                <span class="text-gray-600">Disconnected</span>
+            `;
+        });
 
         function updateSystemStats(data) {
             // Update CPU in header
@@ -1860,53 +1831,28 @@
                 },
 
                 loadTabContent(tab) {
-                    const contentEl = document.getElementById(tab + '-content');
-                    // data-loaded: already fetched. data-loading: a fetch is queued or in
-                    // flight. Both guard against re-entry so a panel loads exactly once, even
-                    // if the tab is reopened before an in-progress (or polling) load settles.
-                    if (!contentEl || contentEl.hasAttribute('data-loaded') || contentEl.hasAttribute('data-loading')) return;
-                    const url = contentEl.getAttribute('hx-get');
-                    if (!url) return;
-
-                    contentEl.setAttribute('data-loading', 'true');
-
-                    // htmx.ajax issues the request and swaps the response into the panel
-                    // directly, so it works even before htmx has wired up the element's
-                    // hx-trigger listeners. data-loaded is stamped on success so the panel
-                    // loads once; the activeTab check drops loads for a tab the user navigated
-                    // away from while htmx was still loading (avoids fetching hidden panels).
-                    const swap = contentEl.getAttribute('hx-swap') || 'innerHTML';
-                    const load = () => {
-                        if (this.activeTab !== tab || contentEl.hasAttribute('data-loaded')) {
-                            contentEl.removeAttribute('data-loading');
-                            return;
-                        }
-                        return htmx.ajax('GET', url, { target: contentEl, swap: swap })
-                            .then(() => contentEl.setAttribute('data-loaded', 'true'))
-                            .catch(() => {}) // leave unstamped on failure so it can retry
-                            .finally(() => contentEl.removeAttribute('data-loading'));
-                    };
-
+                    // Try to load content for the active tab
                     if (typeof htmx !== 'undefined') {
-                        load();
-                        return;
-                    }
-
-                    // htmx is loaded from a CDN and may not be ready yet. Poll until it is,
-                    // then load; if it never arrives, fall back to a direct fetch.
-                    let tries = 0;
-                    const timer = setInterval(() => {
-                        if (typeof htmx !== 'undefined') {
-                            clearInterval(timer);
-                            load();
-                        } else if (++tries > 100) { // ~10s
-                            clearInterval(timer);
-                            contentEl.removeAttribute('data-loading');
+                        const contentId = tab + '-content';
+                        const contentEl = document.getElementById(contentId);
+                        if (contentEl && !contentEl.hasAttribute('data-loaded')) {
+                            // Trigger HTMX load
+                            htmx.trigger(contentEl, 'revealed');
+                        }
+                    } else {
+                        // HTMX is still loading asynchronously — retry when it signals ready,
+                        // or fall back to direct fetch if it fails to load entirely.
+                        const self = this;
+                        function onReady() { window.removeEventListener('htmx-load-failed', onFailed); self.loadTabContent(tab); }
+                        function onFailed() {
+                            window.removeEventListener('htmx:ready', onReady);
                             if (tab === 'overview' && typeof loadOverviewDirect === 'function') loadOverviewDirect();
                             else if (tab === 'wifi' && typeof loadWifiDirect === 'function') loadWifiDirect();
                             else if (tab === 'plugins' && typeof loadPluginsDirect === 'function') loadPluginsDirect();
                         }
-                    }, 100);
+                        window.addEventListener('htmx:ready', onReady, { once: true });
+                        window.addEventListener('htmx-load-failed', onFailed, { once: true });
+                    }
                 },
 
                 async loadInstalledPlugins() {
@@ -4649,9 +4595,6 @@
     <script src="{{ url_for('static', filename='v3/js/widgets/timezone-selector.js') }}" defer></script>
     <script src="{{ url_for('static', filename='v3/js/widgets/plugin-loader.js') }}" defer></script>
     
-    <!-- Reusable JSON file manager widget (used by of-the-day and others via x-widget: json-file-manager) -->
-    <script src="{{ url_for('static', filename='v3/js/widgets/json-file-manager.js') }}" defer></script>
-
     <!-- Legacy plugins_manager.js (for backward compatibility during migration) -->
     <script src="{{ url_for('static', filename='v3/plugins_manager.js') }}?v=20260307" defer></script>
     

web_interface/templates/v3/partials/plugin_config.html

@@ -497,31 +497,15 @@
                     {% endif %}
 
                     <div class="array-table-container mt-1" data-field-id="{{ field_id }}" data-full-key="{{ full_key }}" data-max-items="{{ max_items }}" data-plugin-id="{{ plugin_id }}">
-                        <div style="overflow-x:auto">
-                        <table class="divide-y divide-gray-200 border border-gray-300 rounded-lg" style="min-width:max-content;width:100%">
+                        <table class="min-w-full divide-y divide-gray-200 border border-gray-300 rounded-lg">
                             <thead class="bg-gray-50">
                                 <tr>
                                     {% for col_name in display_columns %}
                                         {% set col_def = item_properties.get(col_name, {}) %}
                                         {% set col_title = col_def.get('title', col_name|replace('_', ' ')|title) %}
-                                        {% set col_xwidget = col_def.get('x-widget') or col_def.get('x_widget', '') %}
-                                        {% set col_enum = col_def.get('enum', []) %}
-                                        {% set _raw_ctype = col_def.get('type', 'string') %}
-                                        {% if _raw_ctype is iterable and _raw_ctype is not string %}
-                                            {% set col_ctype = (_raw_ctype | reject('equalto','null') | list | first) or 'string' %}
-                                        {% else %}
-                                            {% set col_ctype = _raw_ctype or 'string' %}
-                                        {% endif %}
-                                        {% if col_xwidget == 'date-picker' %}{% set col_min_w = '140px' %}
-                                        {% elif col_xwidget == 'time-picker' %}{% set col_min_w = '115px' %}
-                                        {% elif col_xwidget == 'file-upload-single' %}{% set col_min_w = '200px' %}
-                                        {% elif col_enum %}{% set col_min_w = '90px' %}
-                                        {% elif col_ctype == 'boolean' %}{% set col_min_w = '60px' %}
-                                        {% elif col_ctype in ['integer', 'number'] %}{% set col_min_w = '80px' %}
-                                        {% else %}{% set col_min_w = '110px' %}{% endif %}
-                                        <th class="px-3 py-3 text-left text-xs font-medium text-gray-500 uppercase tracking-wider" style="min-width:{{ col_min_w }}">{{ col_title }}</th>
+                                        <th class="px-4 py-3 text-left text-xs font-medium text-gray-500 uppercase tracking-wider">{{ col_title }}</th>
                                     {% endfor %}
-                                    <th class="px-3 py-3 text-center text-xs font-medium text-gray-500 uppercase tracking-wider" style="min-width:90px">Actions</th>
+                                    <th class="px-4 py-3 text-center text-xs font-medium text-gray-500 uppercase tracking-wider w-20">Actions</th>
                                 </tr>
                             </thead>
                             <tbody id="{{ field_id }}_tbody" class="bg-white divide-y divide-gray-200">
@@ -530,24 +514,9 @@
                                 <tr class="array-table-row" data-index="{{ item_index }}">
                                     {% for col_name in display_columns %}
                                         {% set col_def = item_properties.get(col_name, {}) %}
-                                        {# Normalize nullable types e.g. ["null","integer"] → "integer" #}
-                                        {% set _raw_type = col_def.get('type', 'string') %}
-                                        {% if _raw_type is iterable and _raw_type is not string %}
-                                            {% set col_type = (_raw_type | reject('equalto','null') | list | first) or 'string' %}
-                                        {% else %}
-                                            {% set col_type = _raw_type or 'string' %}
-                                        {% endif %}
-                                        {% set col_xwidget = col_def.get('x-widget') or col_def.get('x_widget', '') %}
-                                        {% set col_enum = col_def.get('enum', []) %}
+                                        {% set col_type = col_def.get('type', 'string') %}
                                         {% set col_value = item.get(col_name, col_def.get('default', '')) %}
-                                        {% if col_xwidget == 'date-picker' %}{% set td_min_w = '140px' %}
-                                        {% elif col_xwidget == 'time-picker' %}{% set td_min_w = '115px' %}
-                                        {% elif col_xwidget == 'file-upload-single' %}{% set td_min_w = '200px' %}
-                                        {% elif col_enum %}{% set td_min_w = '90px' %}
-                                        {% elif col_type == 'boolean' %}{% set td_min_w = '60px' %}
-                                        {% elif col_type in ['integer', 'number'] %}{% set td_min_w = '80px' %}
-                                        {% else %}{% set td_min_w = '110px' %}{% endif %}
-                                        <td class="px-3 py-3 whitespace-nowrap" style="min-width:{{ td_min_w }};vertical-align:middle">
+                                        <td class="px-4 py-3 whitespace-nowrap">
                                             {% if col_type == 'boolean' %}
                                                 <input type="hidden" name="{{ full_key }}.{{ item_index }}.{{ col_name }}" value="false">
                                                 <input type="checkbox"
@@ -564,43 +533,6 @@
                                                        {% if col_type == 'integer' %}step="1"{% else %}step="any"{% endif %}
                                                        class="block w-20 px-2 py-1 border border-gray-300 rounded text-sm text-center"
                                                        {% if col_def.get('description') %}title="{{ col_def.get('description') }}"{% endif %}>
-                                            {% elif col_enum %}
-                                                <select name="{{ full_key }}.{{ item_index }}.{{ col_name }}"
-                                                        class="block w-full px-2 py-1 border border-gray-300 rounded text-sm bg-white">
-                                                    {% for opt in col_enum %}{% if opt is not none %}
-                                                    <option value="{{ opt }}" {% if col_value == opt or (col_value is none and col_def.get('default') == opt) %}selected{% endif %}>{{ opt }}</option>
-                                                    {% endif %}{% endfor %}
-                                                </select>
-                                            {% elif col_xwidget == 'date-picker' %}
-                                                <input type="date"
-                                                       name="{{ full_key }}.{{ item_index }}.{{ col_name }}"
-                                                       value="{{ col_value if col_value is not none else '' }}"
-                                                       class="block w-full px-2 py-1 border border-gray-300 rounded text-sm">
-                                            {% elif col_xwidget == 'time-picker' %}
-                                                <input type="time"
-                                                       name="{{ full_key }}.{{ item_index }}.{{ col_name }}"
-                                                       value="{{ col_value if col_value is not none else '00:00' }}"
-                                                       class="block w-full px-2 py-1 border border-gray-300 rounded text-sm">
-                                            {% elif col_xwidget == 'file-upload-single' %}
-                                                {% set cell_input_id = field_id ~ '_' ~ item_index ~ '_' ~ col_name %}
-                                                <div class="flex items-center gap-1">
-                                                    {% if col_value %}<img src="/{{ col_value }}" class="w-6 h-6 object-cover rounded flex-shrink-0" onerror="this.style.display='none'">{% endif %}
-                                                    <input type="text"
-                                                           id="{{ cell_input_id }}"
-                                                           name="{{ full_key }}.{{ item_index }}.{{ col_name }}"
-                                                           value="{{ col_value if col_value is not none else '' }}"
-                                                           class="block w-20 px-1 py-1 border border-gray-300 rounded text-xs"
-                                                           placeholder="path…">
-                                                    <label class="cursor-pointer flex-shrink-0 inline-flex items-center px-1 py-1 bg-blue-50 border border-blue-200 rounded text-xs text-blue-600 hover:bg-blue-100" title="Upload image">
-                                                        <i class="fas fa-upload"></i>
-                                                        <input type="file"
-                                                               accept="image/png,image/jpeg,image/bmp,image/gif"
-                                                               style="display:none"
-                                                               data-plugin-id="{{ plugin_id }}"
-                                                               data-target-input="{{ cell_input_id }}"
-                                                               onchange="(function(e){ const t=document.getElementById('{{ cell_input_id }}'); const p=t.previousElementSibling && t.previousElementSibling.tagName==='IMG' ? t.previousElementSibling : null; window.handleArrayTableImageUpload(e,t,p,'{{ plugin_id }}'); })(event)">
-                                                    </label>
-                                                </div>
                                             {% else %}
                                                 <input type="text"
                                                        name="{{ full_key }}.{{ item_index }}.{{ col_name }}"
@@ -613,60 +545,13 @@
                                             {% endif %}
                                         </td>
                                     {% endfor %}
-
-                                    {# Actions cell: delete + optional edit button for advanced props #}
-                                    {% set has_advanced = namespace(value=false) %}
-                                    {% for k in item_properties.keys() %}{% if k not in display_columns and k != 'id' %}{% set has_advanced.value = true %}{% endif %}{% endfor %}
-                                    <td class="px-3 py-3 whitespace-nowrap text-center" style="min-width:90px;vertical-align:middle">
+                                    <td class="px-4 py-3 whitespace-nowrap text-center">
                                         <button type="button"
                                                 onclick="removeArrayTableRow(this)"
                                                 class="text-red-600 hover:text-red-800 px-2 py-1">
                                             <i class="fas fa-trash"></i>
                                         </button>
-                                        {% if has_advanced.value %}
-                                        <button type="button"
-                                                onclick="openArrayTableRowEditor(this)"
-                                                class="text-blue-500 hover:text-blue-700 px-2 py-1 ml-1"
-                                                title="Edit layout, style and other advanced properties">
-                                            <i class="fas fa-sliders-h"></i>
-                                        </button>
-                                        {% endif %}
                                     </td>
-
-                                    {# Hidden cell: flat hidden inputs for non-displayed props (layout, style, etc.) #}
-                                    {% if has_advanced.value %}
-                                    {% set adv_schema = namespace(d={}) %}
-                                    {% for k, v in item_properties.items() %}{% if k not in display_columns and k != 'id' %}{% set _ = adv_schema.d.update({k: v}) %}{% endif %}{% endfor %}
-                                    <td style="display:none" class="array-table-advanced-data"
-                                        data-prop-schema='{{ adv_schema.d|tojson }}'>
-                                        {% for prop_name, prop_schema in adv_schema.d.items() %}
-                                            {% set prop_type = prop_schema.get('type', 'string') %}
-                                            {% if prop_type == 'object' and prop_schema.get('properties') %}
-                                                {% for sub_name, sub_schema in prop_schema.get('properties', {}).items() %}
-                                                    {% set sub_val = item.get(prop_name, {}).get(sub_name) %}
-                                                    {% set sub_default = sub_schema.get('default') %}
-                                                    {% set final_val = sub_val if sub_val is not none else sub_default %}
-                                                    <input type="hidden"
-                                                           name="{{ full_key }}.{{ item_index }}.{{ prop_name }}.{{ sub_name }}"
-                                                           data-nested-prop="{{ prop_name }}.{{ sub_name }}"
-                                                           data-prop-type="{{ sub_schema.get('type', 'string') }}"
-                                                           data-prop-schema='{{ sub_schema|tojson }}'
-                                                           value="{{ final_val if final_val is not none else '' }}">
-                                                {% endfor %}
-                                            {% else %}
-                                                {% set prop_val = item.get(prop_name) %}
-                                                {% set prop_default = prop_schema.get('default') %}
-                                                {% set final_val = prop_val if prop_val is not none else prop_default %}
-                                                <input type="hidden"
-                                                       name="{{ full_key }}.{{ item_index }}.{{ prop_name }}"
-                                                       data-nested-prop="{{ prop_name }}"
-                                                       data-prop-type="{{ prop_schema.get('type', 'string') }}"
-                                                       data-prop-schema='{{ prop_schema|tojson }}'
-                                                       value="{{ final_val if final_val is not none else '' }}">
-                                            {% endif %}
-                                        {% endfor %}
-                                    </td>
-                                    {% endif %}
                                 </tr>
                                 {% endfor %}
                             </tbody>
@@ -678,58 +563,11 @@
                                 data-max-items="{{ max_items }}"
                                 data-plugin-id="{{ plugin_id }}"
                                 data-item-properties='{% set ns = namespace(d={}) %}{% for k in display_columns %}{% if k in item_properties %}{% set _ = ns.d.update({k: item_properties[k]}) %}{% endif %}{% endfor %}{{ ns.d|tojson }}'
-                                data-full-item-properties='{{ item_properties|tojson }}'
                                 data-display-columns='{{ display_columns|tojson }}'
                                 class="mt-3 px-4 py-2 text-sm bg-blue-600 hover:bg-blue-700 text-white rounded-md"
                                 {% if array_value|length >= max_items %}disabled style="opacity: 0.5;"{% endif %}>
                             <i class="fas fa-plus mr-1"></i> Add Item
                         </button>
-                        </div>{# end overflow-x:auto wrapper #}
-                    </div>
-                {% elif x_widget == 'color-picker' %}
-                    {# RGB color array: R / G / B number inputs + visual swatch + sync'd hex picker #}
-                    {% set color_arr = value if value is not none and value is iterable and value is not string else (prop.default if prop.default is defined and prop.default is iterable and prop.default is not string else [255, 255, 255]) %}
-                    {% set r_val = color_arr[0] if color_arr|length > 0 else 255 %}
-                    {% set g_val = color_arr[1] if color_arr|length > 1 else 255 %}
-                    {% set b_val = color_arr[2] if color_arr|length > 2 else 255 %}
-                    {% set hex_val = '#%02x%02x%02x' % (r_val|int, g_val|int, b_val|int) %}
-                    <div class="flex items-center gap-3 flex-wrap mt-1" id="{{ field_id }}_color_row">
-                        <input type="color"
-                               id="{{ field_id }}_hex"
-                               value="{{ hex_val }}"
-                               class="h-9 w-12 cursor-pointer rounded border border-gray-300"
-                               title="Color picker"
-                               oninput="(function(h){var r=parseInt(h.slice(1,3),16),g=parseInt(h.slice(3,5),16),b=parseInt(h.slice(5,7),16);document.getElementById('{{ field_id }}_r').value=r;document.getElementById('{{ field_id }}_g').value=g;document.getElementById('{{ field_id }}_b').value=b;})(this.value)">
-                        <div class="flex items-center gap-1">
-                            <label class="text-xs text-gray-500 font-medium">R</label>
-                            <input type="number" min="0" max="255" step="1"
-                                   id="{{ field_id }}_r"
-                                   name="{{ full_key }}.0"
-                                   value="{{ r_val }}"
-                                   class="w-16 px-2 py-1 border border-gray-300 rounded text-sm text-center"
-                                   oninput="(function(){var r=+document.getElementById('{{ field_id }}_r').value||0,g=+document.getElementById('{{ field_id }}_g').value||0,b=+document.getElementById('{{ field_id }}_b').value||0;document.getElementById('{{ field_id }}_hex').value='#'+[r,g,b].map(function(n){return n.toString(16).padStart(2,'0')}).join('')})()">
-                        </div>
-                        <div class="flex items-center gap-1">
-                            <label class="text-xs text-gray-500 font-medium">G</label>
-                            <input type="number" min="0" max="255" step="1"
-                                   id="{{ field_id }}_g"
-                                   name="{{ full_key }}.1"
-                                   value="{{ g_val }}"
-                                   class="w-16 px-2 py-1 border border-gray-300 rounded text-sm text-center"
-                                   oninput="(function(){var r=+document.getElementById('{{ field_id }}_r').value||0,g=+document.getElementById('{{ field_id }}_g').value||0,b=+document.getElementById('{{ field_id }}_b').value||0;document.getElementById('{{ field_id }}_hex').value='#'+[r,g,b].map(function(n){return n.toString(16).padStart(2,'0')}).join('')})()">
-                        </div>
-                        <div class="flex items-center gap-1">
-                            <label class="text-xs text-gray-500 font-medium">B</label>
-                            <input type="number" min="0" max="255" step="1"
-                                   id="{{ field_id }}_b"
-                                   name="{{ full_key }}.2"
-                                   value="{{ b_val }}"
-                                   class="w-16 px-2 py-1 border border-gray-300 rounded text-sm text-center"
-                                   oninput="(function(){var r=+document.getElementById('{{ field_id }}_r').value||0,g=+document.getElementById('{{ field_id }}_g').value||0,b=+document.getElementById('{{ field_id }}_b').value||0;document.getElementById('{{ field_id }}_hex').value='#'+[r,g,b].map(function(n){return n.toString(16).padStart(2,'0')}).join('')})()">
-                        </div>
-                        <div class="w-8 h-8 rounded border border-gray-300 flex-shrink-0"
-                             style="background-color: rgb({{ r_val }}, {{ g_val }}, {{ b_val }})"
-                             title="Color preview"></div>
                     </div>
                 {% else %}
                     {# Generic array-of-objects would go here if needed in the future #}
@@ -788,19 +626,7 @@
                            name="{{ full_key }}"
                            value="{{ str_value }}">
                 </div>
-            {% elif str_widget == 'json-file-manager' %}
-                {# Embedded file manager — plugin's web_ui/file_manager.html served via /v3/plugin-ui/ route #}
-                <div class="mt-1 rounded-lg border border-gray-200 overflow-hidden">
-                    <iframe id="{{ field_id }}_frame"
-                            src="/v3/plugin-ui/{{ plugin_id }}/web-ui/file_manager.html"
-                            style="width:100%;height:640px;border:none;"
-                            title="File Manager for {{ plugin_id }}"></iframe>
-                </div>
-                <p class="text-xs text-amber-600 mt-2 flex items-center">
-                    <i class="fas fa-info-circle mr-1"></i>
-                    Changes in the file manager save immediately — no need to click Save Configuration.
-                </p>
-            {% elif str_widget in ['text-input', 'textarea', 'select-dropdown', 'toggle-switch', 'radio-group', 'date-picker', 'time-picker', 'slider', 'color-picker', 'email-input', 'url-input', 'password-input', 'font-selector', 'file-upload-single', 'plugin-file-manager'] %}
+            {% elif str_widget in ['text-input', 'textarea', 'select-dropdown', 'toggle-switch', 'radio-group', 'date-picker', 'slider', 'color-picker', 'email-input', 'url-input', 'password-input', 'font-selector'] %}
                 {# Render widget container #}
                 <div id="{{ field_id }}_container" class="{{ str_widget }}-container"></div>
                 <script>
@@ -817,9 +643,7 @@
                             'enum': {{ (prop.enum or [])|tojson|safe }},
                             'minimum': {{ prop.minimum|tojson if prop.minimum is defined else 'null' }},
                             'maximum': {{ prop.maximum|tojson if prop.maximum is defined else 'null' }},
-                            'x-options': {{ (prop.get('x-options') or prop.get('x_options') or {})|tojson|safe }},
-                            'x-upload-config': {{ (prop.get('x-upload-config') or prop.get('x_upload_config') or {})|tojson|safe }},
-                            'x-widget-config': {{ (prop.get('x-widget-config') or prop.get('x_widget_config') or {})|tojson|safe }}
+                            'x-options': {{ (prop.get('x-options') or prop.get('x_options') or {})|tojson|safe }}
                         };
                         widget.render(container, config, value, { fieldId: '{{ field_id }}', name: '{{ full_key }}', pluginId: '{{ plugin_id }}' });
                     }
@@ -1040,28 +864,15 @@
             </div>
         </div>
         
-        {# Web UI Actions — hide if schema has a dedicated file-manager widget,
-           or if every action is marked ui_hidden in the manifest. #}
-        {% set has_file_manager_widget = namespace(value=false) %}
-        {% for _fk, _fp in schema.get('properties', {}).items() %}
-            {% if (_fp.get('x-widget') or _fp.get('x_widget')) in ('json-file-manager', 'plugin-file-manager') %}
-                {% set has_file_manager_widget.value = true %}
-            {% endif %}
-        {% endfor %}
-        {% set visible_actions = [] %}
-        {% for _a in web_ui_actions %}
-            {% if not _a.get('ui_hidden', false) %}
-                {% set _ = visible_actions.append(_a) %}
-            {% endif %}
-        {% endfor %}
-        {% if visible_actions and not has_file_manager_widget.value %}
+        {# Web UI Actions (if any) #}
+        {% if web_ui_actions %}
         <div class="mt-6 pt-4 border-t border-gray-200">
             <h3 class="text-md font-medium text-gray-900 mb-3">Plugin Actions</h3>
-            {% if visible_actions[0].section_description %}
-            <p class="text-sm text-gray-600 mb-4">{{ visible_actions[0].section_description }}</p>
+            {% if web_ui_actions[0].section_description %}
+            <p class="text-sm text-gray-600 mb-4">{{ web_ui_actions[0].section_description }}</p>
             {% endif %}
             <div class="space-y-3">
-                {% for action in visible_actions %}
+                {% for action in web_ui_actions %}
                 {% set action_id = "action-" ~ action.id ~ "-" ~ loop.index0 %}
                 {% set status_id = "action-status-" ~ action.id ~ "-" ~ loop.index0 %}
                 {% set bg_color = action.color or 'blue' %}