1348 Commits

Author	SHA1	Message	Date
Chuck	22c495ea7c	perf(store): cache GitHub API calls and eliminate redundant requests (#251) ... The plugin store was making excessive GitHub API calls causing slow page loads (10-30s): - Installed plugins endpoint called get_plugin_info() per plugin (3 GitHub API calls each) just to read the `verified` field from the registry. Use new get_registry_info() instead (zero API calls). - _get_latest_commit_info() had no cache — all 31 monorepo plugins share the same repo URL, causing 31 identical API calls. Add 5-min cache keyed by repo:branch. - _fetch_manifest_from_github() also uncached — add 5-min cache. - load_config() called inside loop per-plugin — hoist outside loop. - Install/update operations pass force_refresh=True to bypass caches and always get the latest commit SHA from GitHub. Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-15 14:46:31 -05:00
Chuck	bc8568604a	feat(web): add LED RGB sequence, multiplexing, and panel type settings (#248) ... * feat(web): add LED RGB sequence, multiplexing, and panel type settings Expose three rpi-rgb-led-matrix hardware options in the Display Settings UI so users can configure non-standard panels without editing config.json manually. All defaults match existing behavior (RGB, Direct, Standard). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(api): validate led_rgb_sequence, multiplexing, and panel_type inputs Reject invalid values with 400 errors before writing to config: whitelist check for led_rgb_sequence and panel_type, range + type check for multiplexing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-13 18:16:21 -05:00
Chuck	878f339fb3	fix(logos): support logo downloads for custom soccer leagues (#247) ... * fix(logos): support logo downloads for custom soccer leagues LogoDownloader.fetch_teams_data() and fetch_single_team() only had hardcoded API endpoints for predefined soccer leagues. Custom leagues (e.g., por.1, mex.1) would silently fail when the ESPN game data didn't include a direct logo URL. Now dynamically constructs the ESPN teams API URL for any soccer_* league not in the predefined map. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(logos): address PR review — directory, bulk download, and dedup - get_logo_directory: custom soccer leagues now resolve to shared assets/sports/soccer_logos/ instead of creating per-league dirs - download_all_missing_logos: use _resolve_api_url so custom soccer leagues are no longer silently skipped - Extract _resolve_api_url helper to deduplicate dynamic URL construction between fetch_teams_data and fetch_single_team Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-13 17:43:05 -05:00
Chuck	158e07c82b	fix(plugins): prevent root-owned files from blocking plugin updates (#242) ... * fix(web): unify operation history tracking for monorepo plugin operations The operation history UI was reading from the wrong data source (operation_queue instead of operation_history), install/update records lacked version details, toggle operations used a type name that didn't match UI filters, and the Clear History button was non-functional. - Switch GET /plugins/operation/history to read from OperationHistory audit log with return type hint and targeted exception handling - Add DELETE /plugins/operation/history endpoint; wire up Clear button - Add _get_plugin_version helper with specific exception handling (FileNotFoundError, PermissionError, json.JSONDecodeError) and structured logging with plugin_id/path context - Record plugin version, branch, and commit details on install/update - Record install failures in the direct (non-queue) code path - Replace "toggle" operation type with "enable"/"disable" - Add normalizeStatus() in JS to map completed→success, error→failed so status filter works regardless of server-side convention - Truncate commit SHAs to 7 chars in details display - Fix HTML filter options, operation type colors, duplicate JS init Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(plugins): prevent root-owned files from blocking plugin updates The root ledmatrix service creates __pycache__ and data cache files owned by root inside plugin directories. The web service (non-root) cannot delete these when updating or uninstalling plugins, causing operations to fail with "Permission denied". Defense in depth with three layers: - Prevent: PYTHONDONTWRITEBYTECODE=1 in systemd service + run.py - Fallback: sudoers rules for rm on plugin directories - Code: _safe_remove_directory() now uses sudo as last resort, and all bare shutil.rmtree() calls routed through it Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(security): harden sudo removal with path-validated helper script Address code review findings: - Replace raw rm/find sudoers wildcards with a vetted helper script (safe_plugin_rm.sh) that resolves symlinks and validates the target is a strict child of plugin-repos/ or plugins/ before deletion - Add allow-list validation in sudo_remove_directory() that checks resolved paths against allowed bases before invoking sudo - Check _safe_remove_directory() return value before shutil.move() in the manifest ID rename path - Move stat import to module level in store_manager.py - Use stat.S_IRWXU instead of 0o777 in chmod fallback stage - Add ignore_errors=True to temp dir cleanup in finally block - Use command -v instead of which in configure_web_sudo.sh Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(security): address code review round 2 — harden paths and error handling - safe_plugin_rm.sh: use realpath --canonicalize-missing for ALLOWED_BASES so the script doesn't fail under set -e when dirs don't exist yet - safe_plugin_rm.sh: add -- before path in rm -rf to prevent flag injection - permission_utils.py: use shutil.which('bash') instead of hardcoded /bin/bash to match whatever path the sudoers BASH_PATH resolves to - store_manager.py: check _safe_remove_directory() return before shutil.move() in _install_from_monorepo_zip to prevent moving into a non-removed target - store_manager.py: catch OSError instead of PermissionError in Stage 1 removal to handle both EACCES and EPERM error codes - store_manager.py: hoist sudo_remove_directory import to module level - configure_web_sudo.sh: harden safe_plugin_rm.sh to root-owned 755 so the web user cannot modify the vetted helper script Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(security): validate command paths in sudoers config and use resolved paths - configure_web_sudo.sh: validate that required commands (systemctl, bash, python3) resolve to non-empty paths before generating sudoers entries; abort with clear error if any are missing; skip optional commands (reboot, poweroff, journalctl) with a warning instead of emitting malformed NOPASSWD lines; validate helper script exists on disk - permission_utils.py: pass the already-resolved path to the subprocess call and use it for the post-removal exists() check, eliminating a TOCTOU window between Python-side validation and shell-side execution Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-12 19:28:05 -05:00
Chuck	9a72adbde1	fix(web): unify operation history tracking for monorepo plugin operations (#240) ... The operation history UI was reading from the wrong data source (operation_queue instead of operation_history), install/update records lacked version details, toggle operations used a type name that didn't match UI filters, and the Clear History button was non-functional. - Switch GET /plugins/operation/history to read from OperationHistory audit log with return type hint and targeted exception handling - Add DELETE /plugins/operation/history endpoint; wire up Clear button - Add _get_plugin_version helper with specific exception handling (FileNotFoundError, PermissionError, json.JSONDecodeError) and structured logging with plugin_id/path context - Record plugin version, branch, and commit details on install/update - Record install failures in the direct (non-queue) code path - Replace "toggle" operation type with "enable"/"disable" - Add normalizeStatus() in JS to map completed→success, error→failed so status filter works regardless of server-side convention - Truncate commit SHAs to 7 chars in details display - Fix HTML filter options, operation type colors, duplicate JS init Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-12 12:11:12 -05:00
Chuck	9d3bc55c18	fix: post-merge monorepo hardening and cleanup (#239) ... * fix: address PR review nitpicks for monorepo hardening - Add docstring note about regex limitation in parse_json_with_trailing_commas - Abort on zip-slip in ZIP installer instead of skipping (consistent with API installer) - Use _safe_remove_directory for non-git plugin reinstall path - Use segment-wise encodeURIComponent for View button URL encoding Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: check _safe_remove_directory result before reinstalling plugin Avoid calling install_plugin into a partially-removed directory by checking the boolean return of _safe_remove_directory, mirroring the guard already used in the git-remote migration path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: normalize subpath prefix and add zip-slip guard to download installer - Strip trailing slashes from plugin_subpath before building the tree filter prefix, preventing double-slash ("subpath//") that would cause file_entries to silently miss all matches. - Add zip-slip protection to _install_via_download (extractall path), matching the guard already present in _install_from_monorepo_zip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-12 11:59:23 -05:00
Chuck	df3cf9bb56	Feat/monorepo migration (#238) ... * feat: adapt LEDMatrix for monorepo plugin architecture Update store_manager to fetch manifests from subdirectories within the monorepo (plugin_path/manifest.json) instead of repo root. Remove 21 plugin submodule entries from .gitmodules, simplify workspace file to reference the monorepo, and clean up scripts for the new layout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: auto-reinstall plugins when registry repo URL changes When a user clicks "Update" on a git-cloned plugin, detect if the local git remote URL no longer matches the registry's repo URL (e.g. after monorepo migration). Instead of pulling from the stale archived repo, automatically remove and reinstall from the new registry source. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: plugin store "View" button links to correct monorepo subdirectory When a plugin has a plugin_path (monorepo plugin), construct the GitHub URL as repo/tree/main/plugin_path so users land on the specific plugin directory. Pass plugin_path through the store API response to the frontend. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: monorepo manifest fetch in search + version-based update detection Fix search_plugins() to pass plugin_path when fetching manifests from GitHub, matching the fix already in get_plugin_info(). Without this, monorepo plugin descriptions 404 in search results. Add version comparison for non-git plugins (monorepo installs) so "Update All" skips plugins already at latest_version instead of blindly reinstalling every time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat: show plugin version instead of misleading monorepo commit info Replace commit hash, date, and stars on plugin cards with the plugin's version number. In a monorepo all plugins share the same commit history and star count, making those fields identical and misleading. Version is the meaningful per-plugin signal users care about. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * docs: add CLAUDE.md with project structure and plugin store docs Documents plugin store architecture, monorepo install flow, version- based update detection, and the critical version bump workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * perf: extract only target plugin from monorepo ZIP instead of all files Previously _install_from_monorepo() called extractall() on the entire monorepo ZIP (~13MB, 600+ files) just to grab one plugin subdirectory. Now filter zip members by the plugin prefix and extract only matching files, reducing disk I/O by ~96% per install/update. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * perf: download only target plugin files via GitHub Trees API Replace full monorepo ZIP download (~5MB) with targeted file downloads (~200KB per plugin) using the GitHub Git Trees API for directory listing and raw.githubusercontent.com for individual file content. One API call fetches the repo tree, client filters for the target plugin's files, then downloads each file individually. Falls back to ZIP if the API is unavailable (rate limited, no network, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: clean up partial files between API and ZIP install fallbacks Ensure target_path is fully removed before the ZIP fallback runs, and before shutil.move() in the ZIP method. Prevents directory nesting if the API method creates target_path then fails mid-download. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: harden scripts and fix monorepo URL handling - setup_plugin_repos.py: add type hints, remove unnecessary f-string, wrap manifest parsing in try/except to skip malformed manifests - update_plugin_repos.py: add 120s timeout to git pull with TimeoutExpired handling - store_manager.py: fix rstrip('.zip') stripping valid branch chars, use removesuffix('.zip'); remove redundant import json - plugins_manager.js: View button uses dynamic branch, disables when repo is missing, encodes plugin_path in URL - CLAUDE.md: document plugin repo naming convention Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: harden monorepo install security and cleanup - store_manager: fix temp dir leak in _install_from_monorepo_zip by moving cleanup to finally block - store_manager: add zip-slip guard validating extracted paths stay inside temp directory - store_manager: add 500-file sanity cap to API-based install - store_manager: extract _normalize_repo_url as @staticmethod - setup_plugin_repos: propagate create_symlinks() failure via sys.exit, narrow except to OSError Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add path traversal guard to API-based monorepo installer Validate that each file's resolved destination stays inside target_path before creating directories or writing bytes, mirroring the zip-slip guard in _install_from_monorepo_zip. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: use _safe_remove_directory for monorepo migration cleanup Replace shutil.rmtree(ignore_errors=True) with _safe_remove_directory which handles permission errors gracefully and returns status, preventing install_plugin from running against a partially-removed directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-11 18:57:30 -05:00
Chuck	b99be88cec	fix(plugins): namespace-isolate modules for safe parallel loading (#237) ... * fix(plugins): prevent KeyError race condition in module cleanup When multiple plugins have modules with the same name (e.g., background_data_service.py), the _clear_conflicting_modules function could raise a KeyError if a module was removed between iteration and deletion. This race condition caused plugin loading failures with errors like: "Unexpected error loading plugin: 'background_data_service'" Changes: - Use sys.modules.pop(mod_name, None) instead of del sys.modules[mod_name] to safely handle already-removed modules - Apply same fix to plugin unload in plugin_manager.py for consistency - Fix typo in sports.py: rankself._team_rankings_cacheings -> self._team_rankings_cache Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(plugins): namespace-isolate plugin modules to prevent parallel loading collisions Multiple sport plugins share identically-named Python files (scroll_display.py, game_renderer.py, sports.py, etc.). When loaded in parallel via ThreadPoolExecutor, bare module names collide in sys.modules causing KeyError crashes. Replace _clear_conflicting_modules with _namespace_plugin_modules: after exec_module loads a plugin, its bare-name sub-modules are moved to namespaced keys (e.g. _plg_basketball_scoreboard_scroll_display) so they cannot collide. A threading lock serializes the exec_module window where bare names temporarily exist. Also updates unload_plugin to clean up namespaced sub-modules from sys.modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(plugins): address review feedback on namespace isolation - Fix main module accidentally renamed: move before_keys snapshot to after sys.modules[module_name] insertion so the main entry is excluded from namespace renaming and error cleanup - Use Path.is_relative_to() instead of substring matching for plugin directory containment checks to avoid false-matches on overlapping directory names - Add try/except around exec_module to clean up partially-initialized modules on failure, preventing leaked bare-name entries - Add public unregister_plugin_modules() method on PluginLoader so PluginManager doesn't reach into private attributes during unload - Update stale comment referencing removed _clear_conflicting_modules Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(plugins): remove unused plugin_dir_str variable Leftover from the old substring containment check, now replaced by Path.is_relative_to(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(plugins): extract shared helper for bare-module filtering Hoist plugin_dir.resolve() out of loops and deduplicate the bare-module filtering logic between _namespace_plugin_modules and the error cleanup block into _iter_plugin_bare_modules(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix(plugins): keep bare-name alias to prevent lazy import duplication Stop removing bare module names from sys.modules after namespacing. Removing them caused lazy intra-plugin imports (deferred imports inside methods) to re-import from disk, creating a second inconsistent module copy. Keeping both the bare and namespaced entries pointing to the same object avoids this. The next plugin's exec_module naturally overwrites the bare entry with its own version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-10 22:47:24 -05:00
Chuck	0d5510d8f7	Fix/plugin module namespace collision (#229) ... * fix(web): handle string boolean values in schedule-picker widget The normalizeSchedule function used strict equality (===) to check the enabled field, which would fail if the config value was a string "true" instead of boolean true. This could cause the checkbox to always appear unchecked even when the setting was enabled. Added coerceToBoolean helper that properly handles: - Boolean true/false (returns as-is) - String "true", "1", "on" (case-insensitive) → true - String "false" or other values → false Applied to both main schedule enabled and per-day enabled fields. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: trim whitespace in coerceToBoolean string handling * fix: normalize mode value to handle per_day and per-day variants * fix(plugins): resolve module namespace collisions between plugins When multiple plugins have modules with the same name (e.g., data_fetcher.py), Python's sys.modules cache would return the wrong module. This caused plugins like ledmatrix-stocks to fail loading because it imported data_fetcher from ledmatrix-leaderboard instead of its own. Added _clear_conflicting_modules() to remove cached plugin modules from sys.modules before loading each plugin, ensuring correct module resolution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-30 16:24:06 -05:00
Chuck	8fb2800495	feat: add error detection, monitoring, and code quality improvements (#223) ... * feat: add error detection, monitoring, and code quality improvements This comprehensive update addresses automatic error detection, code quality, and plugin development experience: ## Error Detection & Monitoring - Add ErrorAggregator service for centralized error tracking - Add pattern detection for recurring errors (5+ in 60 min) - Add error dashboard API endpoints (/api/v3/errors/*) - Integrate error recording into plugin executor ## Code Quality - Remove 10 silent `except: pass` blocks in sports.py and football.py - Remove hardcoded debug log paths - Add pre-commit hooks to prevent future bare except clauses ## Validation & Type Safety - Add warnings when plugins lack config_schema.json - Add config key collision detection for plugins - Improve type coercion logging in BasePlugin ## Testing - Add test_config_validation_edge_cases.py - Add test_plugin_loading_failures.py - Add test_error_aggregator.py ## Documentation - Add PLUGIN_ERROR_HANDLING.md guide - Add CONFIG_DEBUGGING.md guide Note: GitHub Actions CI workflow is available in the plan but requires workflow scope to push. Add .github/workflows/ci.yml manually. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address code review issues - Fix GitHub issues URL in CONFIG_DEBUGGING.md - Use RLock in error_aggregator.py to prevent deadlock in export_to_file - Distinguish missing vs invalid schema files in plugin_manager.py - Add assertions to test_null_value_for_required_field test - Remove unused initial_count variable in test_plugin_load_error_recorded - Add validation for max_age_hours in clear_old_errors API endpoint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-30 10:05:09 -05:00
Chuck	68c4259370	fix: reduce scroll catch-up steps to limit jitter (#219) ... Reduce max_steps from 0.1s to 0.04s of catch-up time (from 5 to 2 steps at 50 FPS). When the system lags, the previous catch-up logic allowed jumping up to 5 pixels at once, causing visible jitter. Limiting to 2 steps provides smoother scrolling while still allowing for minor timing corrections. Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-29 20:03:17 -05:00
Chuck	14c50f316e	feat: add timezone support for schedules and dim schedule feature (#218) ... * feat: add timezone support for schedules and dim schedule feature - Fix timezone handling in _check_schedule() to use configured timezone instead of system time (addresses schedule offset issues) - Add dim schedule feature for automatic brightness dimming: - New dim_schedule config section with brightness level and time windows - Smart interaction: dim schedule won't turn display on if it's off - Supports both global and per-day modes like on/off schedule - Add set_brightness() and get_brightness() methods to DisplayManager for runtime brightness control - Add REST API endpoints: GET/POST /api/v3/config/dim-schedule - Add web UI for dim schedule configuration in schedule settings page Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: normalize per-day mode and validate dim_brightness input - Normalize mode string in _check_dim_schedule to handle both "per-day" and "per_day" variants - Add try/except around dim_brightness int conversion to handle invalid input gracefully Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor: improve error handling in brightness and dim schedule endpoints - display_manager.py: Add fail-fast input validation, catch specific exceptions (AttributeError, TypeError, ValueError), add [BRIGHTNESS] context tags, include stack traces in error logs - api_v3.py: Catch specific config exceptions (FileNotFoundError, JSONDecodeError, IOError), add [DIM SCHEDULE] context tags for Pi debugging, include stack traces Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-29 18:12:45 -05:00
Chuck	7524747e44	Feature/vegas scroll mode (#215) ... * feat(display): add Vegas-style continuous scroll mode Implement an opt-in Vegas ticker mode that composes all enabled plugin content into a single continuous horizontal scroll. Includes a modular package (src/vegas_mode/) with double-buffered streaming, 125 FPS render pipeline using the existing ScrollHelper, live priority interruption support, and a web UI for configuration with drag-drop plugin ordering. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(vegas): add three-mode display system (SCROLL, FIXED_SEGMENT, STATIC) Adds a flexible display mode system for Vegas scroll mode that allows plugins to control how their content appears in the continuous scroll: - SCROLL: Content scrolls continuously (multi-item plugins like sports) - FIXED_SEGMENT: Fixed block that scrolls by (clock, weather) - STATIC: Scroll pauses, plugin displays, then resumes (alerts) Changes: - Add VegasDisplayMode enum to base_plugin.py with backward-compatible mapping from legacy get_vegas_content_type() - Add static pause handling to coordinator with scroll position save/restore - Add mode-aware content composition to stream_manager - Add vegas_mode info to /api/v3/plugins/installed endpoint - Add mode indicators to Vegas settings UI - Add comprehensive plugin developer documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas,widgets): address validation, thread safety, and XSS issues Vegas mode fixes: - config.py: align validation limits with UI (scroll_speed max 200, separator_width max 128) - coordinator.py: fix race condition by properly initializing _pending_config - plugin_adapter.py: remove unused import - render_pipeline.py: preserve deque type in reset() method - stream_manager.py: fix lock handling and swap_buffers to truly swap API fixes: - api_v3.py: normalize boolean checkbox values, validate numeric fields, ensure JSON arrays Widget fixes: - day-selector.js: remove escapeHtml from JSON.stringify to prevent corruption - password-input.js: use deterministic color class mapping for Tailwind JIT - radio-group.js: replace inline onchange with addEventListener to prevent XSS - select-dropdown.js: guard global registry access - slider.js: add escapeAttr for attributes, fix null dereference in setValue Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): improve exception handling and static pause state management coordinator.py: - _check_live_priority: use logger.exception for full traceback - _end_static_pause: guard scroll resume on interruption (stop/live priority) - _update_static_mode_plugins: log errors instead of silently swallowing render_pipeline.py: - compose_scroll_content: use specific exceptions and logger.exception - render_frame: use specific exceptions and logger.exception - hot_swap_content: use specific exceptions and logger.exception Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): add interrupt mechanism and improve config/exception handling - Add interrupt checker callback to Vegas coordinator for responsive handling of on-demand requests and wifi status during Vegas mode - Fix config.py update() to include dynamic duration fields - Fix is_plugin_included() consistency with get_ordered_plugins() - Update _apply_pending_config to propagate config to StreamManager - Change _fetch_plugin_content to use logger.exception for traceback - Replace bare except in _refresh_plugin_list with specific exceptions - Add aria-label accessibility to Vegas toggle checkbox - Fix XSS vulnerability in plugin metadata rendering with escapeHtml Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): improve logging, validation, lock handling, and config updates - display_controller.py: use logger.exception for Vegas errors with traceback - base_plugin.py: validate vegas_panel_count as positive integer with warning - coordinator.py: fix _apply_pending_config to avoid losing concurrent updates by clearing _pending_config while holding lock - plugin_adapter.py: remove broad catch-all, use narrower exception types (AttributeError, TypeError, ValueError, OSError, RuntimeError) and logger.exception for traceback preservation - api_v3.py: only update vegas_config['enabled'] when key is present in data to prevent incorrect disabling when checkbox is omitted Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): improve cycle advancement, logging, and accessibility - Add advance_cycle() method to StreamManager for clearing buffer between cycles - Call advance_cycle() in RenderPipeline.start_new_cycle() for fresh content - Use logger.exception() for interrupt check and static pause errors (full tracebacks) - Add id="vegas_scroll_label" to h3 for aria-labelledby reference - Call updatePluginConfig() after rendering plugin list for proper initialization Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): add thread-safety, preserve updates, and improve logging - display_controller.py: Use logger.exception() for Vegas import errors - plugin_adapter.py: Add thread-safe cache lock, remove unused exception binding - stream_manager.py: In-place merge in process_updates() preserves non-updated plugins - api_v3.py: Change vegas_scroll_enabled default from False to True Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): add debug logging and narrow exception types - stream_manager.py: Log when get_vegas_display_mode() is unavailable - stream_manager.py: Narrow exception type from Exception to (AttributeError, TypeError) - api_v3.py: Log exceptions when reading Vegas display metadata with plugin context Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): fix method call and improve exception logging - Fix _check_vegas_interrupt() calling nonexistent _check_wifi_status(), now correctly calls _check_wifi_status_message() - Update _refresh_plugin_list() exception handler to use logger.exception() with plugin_id and class name for remote debugging Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(web): replace complex toggle with standard checkbox for Vegas mode The Tailwind pseudo-element toggle (after:content-[''], etc.) wasn't rendering because these classes weren't in the CSS bundle. Replaced with a simple checkbox that matches other form controls in the template. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * debug(vegas): add detailed logging to _refresh_plugin_list Track why plugins aren't being found for Vegas scroll: - Log count of loaded plugins - Log enabled status for each plugin - Log content_type and display_mode checks - Log when plugin_manager lacks loaded_plugins Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): use correct attribute name for plugin manager StreamManager and VegasModeCoordinator were checking for plugin_manager.loaded_plugins but PluginManager stores active plugins in plugin_manager.plugins. This caused Vegas scroll to find zero plugins despite plugins being available. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): convert scroll_speed from px/sec to px/frame correctly The config scroll_speed is in pixels per second, but ScrollHelper in frame_based_scrolling mode interprets it as pixels per frame. Previously this caused the speed to be clamped to max 5.0 regardless of the configured value. Now properly converts: pixels_per_frame = scroll_speed * scroll_delay With defaults (50 px/s, 0.02s delay), this gives 1 px/frame = 50 px/s. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(vegas): add FPS logging every 5 seconds Logs actual FPS vs target FPS to help diagnose performance issues. Shows frame count in each 5-second interval. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): improve plugin content capture reliability - Call update_data() before capture to ensure fresh plugin data - Try display() without force_clear first, fallback if TypeError - Retry capture with force_clear=True if first attempt is blank - Use histogram-based blank detection instead of point sampling (more reliable for content positioned anywhere in frame) This should help capture content from plugins that don't implement get_vegas_content() natively. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): handle callable width/height on display_manager DisplayManager.width and .height may be methods or properties depending on the implementation. Use callable() check to call them if needed, ensuring display_width and display_height are always integers. Fixes potential TypeError when width/height are methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): use logger.exception for display mode errors Replace logger.error with logger.exception to capture full stack trace when get_vegas_display_mode() fails on a plugin. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): protect plugin list updates with buffer lock Move assignment of _ordered_plugins and index resets under _buffer_lock to prevent race conditions with _prefetch_content() which reads these variables under the same lock. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): catch all exceptions in get_vegas_display_mode Broaden exception handling from AttributeError/TypeError to Exception so any plugin error in get_vegas_display_mode() doesn't abort the entire plugin list refresh. The loop continues with the default FIXED_SEGMENT mode. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(vegas): refresh stream manager when config updates After updating stream_manager.config, force a refresh to pick up changes to plugin_order, excluded_plugins, and buffer_ahead settings. Also use logger.exception to capture full stack traces on config update errors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * debug(vegas): add detailed logging for blank image detection * feat(vegas): extract full scroll content from plugins using ScrollHelper Plugins like ledmatrix-stocks and odds-ticker use ScrollHelper with a cached_image that contains their full scrolling content. Instead of falling back to single-frame capture, now check for scroll_helper.cached_image first to get the complete scrolling content for Vegas mode. * debug(vegas): add comprehensive INFO-level logging for plugin content flow - Log each plugin being processed with class name - Log which content methods are tried (native, scroll_helper, fallback) - Log success/failure of each method with image dimensions - Log brightness check results for blank image detection - Add visual separators in logs for easier debugging - Log plugin list refresh with enabled/excluded status Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(vegas): trigger scroll content generation when cache is empty When a plugin has a scroll_helper but its cached_image is not yet populated, try to trigger content generation by: 1. Calling _create_scrolling_display() if available (stocks pattern) 2. Calling display(force_clear=True) as a fallback This allows plugins like stocks to provide their full scroll content even when Vegas mode starts before the plugin has run its normal display cycle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: improve exception handling in plugin_adapter scroll content retrieval Replace broad except Exception handlers with narrow exception types (AttributeError, TypeError, ValueError, OSError) and use logger.exception instead of logger.warning/info to capture full stack traces for better diagnosability. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: narrow exception handling in coordinator and plugin_adapter - coordinator.py: Replace broad Exception catch around get_vegas_display_mode() with (AttributeError, TypeError) and use logger.exception for stack traces - plugin_adapter.py: Narrow update_data() exception handler to (AttributeError, RuntimeError, OSError) and use logger.exception Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: improve Vegas mode robustness and API validation - display_controller: Guard against None plugin_manager in Vegas init - coordinator: Restore scrolling state in resume() to match pause() - api_v3: Validate Vegas numeric fields with range checks and 400 errors Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-29 10:23:56 -05:00
Chuck	384ed096ff	fix: prevent /tmp permission corruption breaking system updates (#209) ... Issue: LEDMatrix was changing /tmp permissions from 1777 (drwxrwxrwt) to 2775 (drwxrwsr-x), breaking apt update and other system tools. Root cause: display_manager.py's _write_snapshot_if_due() called ensure_directory_permissions() on /tmp when writing snapshots to /tmp/led_matrix_preview.png. This removed the sticky bit and world-writable permissions that /tmp requires. Fix: - Added PROTECTED_SYSTEM_DIRECTORIES safelist to permission_utils.py to prevent modifying permissions on /tmp and other system directories - Added explicit check in display_manager.py to skip /tmp - Defense-in-depth approach prevents similar issues in other code paths The sticky bit (1xxx) is critical for /tmp - it prevents users from deleting files they don't own. Without world-writable permissions, regular users cannot create temp files. Fixes #202 Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-01-26 10:56:30 -05:00
Chuck	1833e30c1d	Feature/wifi setup improvements (#187) ... * fix: Handle permission errors when removing plugin directories - Added _safe_remove_directory() method to handle permission errors gracefully - Fixes permissions on __pycache__ directories before removal - Updates uninstall_plugin() and install methods to use safe removal - Resolves [Errno 13] Permission denied errors during plugin install/uninstall * feat(wifi): Add grace period for AP mode and improve setup documentation - Add 90-second grace period (3 checks at 30s intervals) before enabling AP mode - Change AP to open network (no password) for easier initial setup - Add verification script for WiFi setup - Update documentation with grace period details and open network info - Improve WiFi monitor daemon logging and error handling * feat(wifi): Add Trixie compatibility and dynamic interface discovery - Add dynamic WiFi interface discovery instead of hardcoded wlan0 - Supports traditional (wlan0), predictable (wlp2s0), and USB naming - Falls back gracefully if detection fails - Add Raspberry Pi OS Trixie (Debian 13) detection and compatibility - Detect Netplan configuration and connection file locations - Disable PMF (Protected Management Frames) on Trixie for better client compatibility with certain WiFi adapters - Improve nmcli hotspot setup for Trixie - Add explicit IP configuration (192.168.4.1/24) - Add channel configuration to hotspot creation - Handle Trixie's default 10.42.0.1 IP override - Add dnsmasq conflict detection - Warn if Pi-hole or other DNS services are using dnsmasq - Create backup before overwriting config - Improve error handling - Replace bare except clauses with specific exceptions - All subprocess calls now have explicit timeouts - Document sudoers requirements in module docstring - List all required NOPASSWD entries for ledpi user Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor(wifi): Use NM_CONNECTIONS_PATHS constant in _detect_trixie Replace hardcoded Path instances with references to the NM_CONNECTIONS_PATHS constant for consistency. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(verify): Use ETH_CONNECTED and AP_ACTIVE in summary output Add connectivity summary section that displays Ethernet and AP mode status using the previously unused ETH_CONNECTED and AP_ACTIVE flags. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-19 16:43:02 -05:00
Chuck	2381ead03f	feat(cache): Add intelligent disk cache cleanup with retention policies (#199) ... * feat(cache): Add intelligent disk cache cleanup with retention policies - Add cleanup_expired_files() method to DiskCache class - Implement retention policies based on cache data types: * Odds data: 2 days (lines move frequently) * Live/recent/leaderboard: 7 days (weekly updates) * News/stocks: 14 days * Upcoming/schedules/team_info/logos: 60 days (stable data) - Add cleanup_disk_cache() orchestration in CacheManager - Start background cleanup thread running every 24 hours - Run cleanup on application startup - Add disk cleanup metrics tracking - Comprehensive logging with cleanup statistics This prevents disk cache from accumulating indefinitely while preserving important season data longer than volatile live game data. * refactor(cache): improve disk cache cleanup implementation - Implement force parameter throttle mechanism in cleanup_disk_cache - Fix TOCTOU race condition in disk cache cleanup (getsize/remove) - Reduce lock contention by processing files outside lock where possible - Add CacheStrategyProtocol for better type safety (replaces Any) - Move time import to module level in cache_metrics - Defer initial cleanup to background thread for non-blocking startup - Add graceful shutdown mechanism with threading.Event for cleanup thread - Add stop_cleanup_thread() method for controlled thread termination * fix(cache): improve disk cache cleanup initialization and error handling - Only start cleanup thread when disk caching is enabled (cache_dir is set) - Remove unused retention policy keys (leaderboard, live_scores, logos) - Handle FileNotFoundError as benign race condition in cleanup - Preserve existing OSError handling for actual file system errors --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-19 15:57:19 -05:00
Chuck	bc23b7c75c	fix(logos): Add ncaam/ncaaw sport key aliases for basketball plugin (#200) ... The basketball scoreboard plugin uses sport_key="ncaam" and "ncaaw", but LogoDownloader only had "ncaam_basketball" mapped. This caused get_logo_directory() to fall back to "assets/sports/ncaam_logos" (non-existent) instead of "assets/sports/ncaa_logos". Added aliases to both LOGO_DIRECTORIES and API_ENDPOINTS: - ncaam -> assets/sports/ncaa_logos - ncaaw -> assets/sports/ncaa_logos - ncaaw_basketball -> assets/sports/ncaa_logos Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-19 09:48:52 -05:00
Chuck	3b8910ac09	Fix/duplicate display settings (#173) ... * fix(plugins): Remove compatible_versions requirement from single plugin install Remove compatible_versions from required fields in install_from_url method to match install_plugin behavior. This allows installing plugins from URLs without manifest version requirements, consistent with store plugin installation. * fix(7-segment-clock): Update submodule with separator and spacing fixes * fix(plugins): Add onchange handlers to existing custom feed inputs - Add onchange handlers to key and value inputs for existing patternProperties fields - Fixes bug where editing existing custom RSS feeds didn't save changes - Ensures hidden JSON input field is updated when users edit feed entries - Affects all plugins using patternProperties (custom_feeds, feed_logo_map, etc.) * Add array-of-objects widget support to web UI - Add support for rendering arrays of objects in web UI (for custom_feeds) - Implement add/remove/update functions for array-of-objects widgets - Support file-upload widgets within array items - Update form data handling to support array JSON data fields * Update plugins_manager.js cache-busting version Update version parameter to force browser to load new JavaScript with array-of-objects widget support. * Fix: Move array-of-objects detection before file-upload/checkbox checks Move the array-of-objects widget detection to the top of the array handler so it's checked before file-upload and checkbox-group widgets. This ensures custom_feeds is properly detected as an array of objects. * Update cache-busting version for array-of-objects fix * Remove duplicate array-of-objects check * Update cache version again * Add array-of-objects widget support to server-side template Add detection and rendering for array-of-objects in the Jinja2 template (plugin_config.html). This enables the custom_feeds widget to display properly with name, URL, enabled checkbox, and logo upload fields. The widget is detected by checking if prop.items.type == 'object' && prop.items.properties, and is rendered before the file-upload widget check. * Use window. prefix for array-of-objects JavaScript functions Explicitly use window.addArrayObjectItem, window.removeArrayObjectItem, etc. in the template to ensure the functions are accessible from inline event handlers. Also add safety checks to prevent errors if functions aren't loaded yet. * Fix duplicate display settings in config Prevent display settings from being saved at both nested (display.hardware/runtime) and root level. The save_main_config function was processing display fields twice - once correctly in the nested structure, and again in the catch-all section creating root-level duplicates. Added display_fields to the skip list in the catch-all section to prevent root-level duplicates. All code expects the nested format, so this ensures consistency. * fix: Recreate one-shot install script with APT permission and non-interactive fixes Recreate one-shot install script that was deleted, with fixes for: 1. APT permission denied errors on /tmp 2. Non-interactive mode support Fixes: 1. Fix /tmp permissions before running first_time_install.sh: - chmod 1777 /tmp to ensure APT can write temp files - Set TMPDIR=/tmp explicitly - Preserve TMPDIR when using sudo -E 2. Enable non-interactive mode: - Pass -y flag or LEDMATRIX_ASSUME_YES=1 to first_time_install.sh - Prevents read prompt failure at line 242 when run via curl | bash 3. Better error handling: - Temporarily disable errexit to capture exit code - Re-enable errexit after capturing - Added fix_tmp_permissions() function This resolves the 'Permission denied' errors for APT temp files and the interactive prompt failure when running via pipe. * fix(plugins): Restore version and display_modes to required_fields and fix array object data persistence - Restore 'version' and 'display_modes' to required_fields in store_manager.py manifest validation (both occurrences at lines 839 and 977) - Fix updateArrayObjectData to merge input fields with existing item data to preserve non-editable properties like logo objects - Implement handleArrayObjectFileUpload to properly upload files and store metadata in data-file-data attribute - Implement removeArrayObjectFile to properly remove file metadata and update data structure - Update renderArrayObjectItem to preserve file data in data-file-data attribute when rendering existing items * fix(plugins): Remove version from required_fields, keep display_modes required - Remove 'version' from required_fields in store_manager.py (both occurrences) - Some existing plugins have version: null or no version field (basketball-scoreboard, odds-ticker) - All code uses safe accessors (manifest.get('version')), so optional is safe - Keep 'display_modes' as required - all plugins have it and tests expect it * fix: Preserve exit codes in retry() and fix null handling in JSON data detection - Fix retry() function to preserve original command exit code by capturing status immediately after command execution - Fix JSON data detection to prevent null from overwriting config by checking jsonValue !== null before treating as object - Both fixes prevent edge cases that could cause incorrect behavior or data corruption * fix: Resolve merge conflict, fix array-of-objects file upload, and improve retry function - Remove unresolved merge conflict marker in array rendering (checkbox input attributes) - Fix array-of-objects file upload selector mismatch by adding id to wrapper element - Fix index-based preserve corruption by using data-item-data attributes instead of array indices - Add showNotification guards to prevent errors when notifications aren't available - Fix retry() function to work with set -Eeuo pipefail by disabling errexit for command execution * fix: Remove duplicate implementations, fix upload config, and add type coercion - Remove/guard duplicate updateArrayObjectData, handleArrayObjectFileUpload, and removeArrayObjectFile stub implementations that were overwriting real implementations - Fix hard-coded plugin ID fallback in renderArrayObjectItem - use null instead of 'ledmatrix-news' - Fix upload config to use uploadConfig.allowed_types and uploadConfig.max_size_mb from schema instead of hard-coded values - Store uploadConfig in data-upload-config attribute and read it in handleArrayObjectFileUpload for validation - Add type coercion to updateArrayObjectData: coerce number inputs to Number, array inputs via JSON.parse with comma-split fallback * fix: Use event-based element lookup in handleArrayObjectFileUpload - Change from constructing ID to using event.target.closest('.array-object-item') to find item element - Query fileUploadContainer from itemEl instead of using constructed ID lookup - Remove reliance on `${fieldId}_item_${itemIndex}` which breaks after reindexing - Add response.ok check before calling response.json() to avoid JSON parsing errors on HTTP errors - Handle non-OK responses with proper error messages (JSON parse with fallback) * fix: Improve HTML escaping and add pluginId validation for file uploads - Replace manual single-quote escaping with escapeAttribute() for proper HTML escaping in array-of-objects hidden input - Update default allowed_types to include 'image/jpg' in handleArrayObjectFileUpload - Add explicit pluginId validation before upload to fail fast with clear error message - Prevents XSS vulnerabilities and backend rejections from invalid uploads * fix: Use propKey-scoped selector and harden pluginId validation - Narrow file widget lookup to use propKey-specific selector (.file-upload-widget-inline[data-prop-key]) to target correct widget when item has multiple file widgets - Harden pluginId validation by checking typeof pluginId === 'string' before calling trim() to prevent errors on non-string values --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-14 10:51:55 -05:00
Chuck	fdf09fabd2	Debug/fps logging (#183) ... * fix: Use plugin.modes instead of manifest.json for available modes - Display controller now checks plugin_instance.modes first before falling back to manifest - This allows plugins to dynamically provide modes based on enabled leagues - Fixes issue where disabled leagues (WNBA, NCAAW) appeared in available modes - Plugins can now control their available modes at runtime based on config * fix: Handle permission errors when removing plugin directories - Added _safe_remove_directory() method to handle permission errors gracefully - Fixes permissions on __pycache__ directories before removal - Updates uninstall_plugin() and install methods to use safe removal - Resolves [Errno 13] Permission denied errors during plugin install/uninstall * debug(display): Change FPS check logging from debug to info level - Change FPS check log from DEBUG to INFO to help diagnose scrolling FPS issues - Add active_mode to log message for clarity - Helps identify if plugins are being detected for high-FPS mode * debug(display): Add logging for display_interval in both FPS loops - Log display_interval when entering high-FPS and normal loops - Shows expected FPS for high-FPS mode - Helps diagnose why news ticker shows 50 FPS despite high-FPS detection --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-13 10:55:54 -05:00
Chuck	c35769cefb	Fix/checkbox save and dynamic duration (#182) ... * fix: Use plugin.modes instead of manifest.json for available modes - Display controller now checks plugin_instance.modes first before falling back to manifest - This allows plugins to dynamically provide modes based on enabled leagues - Fixes issue where disabled leagues (WNBA, NCAAW) appeared in available modes - Plugins can now control their available modes at runtime based on config * fix: Handle permission errors when removing plugin directories - Added _safe_remove_directory() method to handle permission errors gracefully - Fixes permissions on __pycache__ directories before removal - Updates uninstall_plugin() and install methods to use safe removal - Resolves [Errno 13] Permission denied errors during plugin install/uninstall * refactor: Improve error handling in _safe_remove_directory - Rename unused 'dirs' variable to '_dirs' to indicate intentional non-use - Use logger.exception() instead of logger.error() to preserve stack traces - Add comment explaining 0o777 permissions are acceptable (temporary before deletion) * fix(install): Fix one-shot-install script reliability issues - Install git and curl before attempting repository clone - Add HOME variable validation to prevent path errors - Improve git branch detection (try current branch, main, then master) - Add validation for all directory change operations - Improve hostname command handling in success message - Fix edge cases for better installation success rate * fix(install): Fix IP address display in installation completion message - Replace unreliable pipe-to-while-read loop with direct for loop - Filter out loopback addresses (127.0.0.1, ::1) from display - Add proper message when no non-loopback IPs are found - Fixes blank IP address display issue at end of installation * fix(install): Prevent unintended merges in one-shot-install git pull logic - Use git pull --ff-only for current branch to avoid unintended merges - Use git fetch (not pull) for other branches to check existence without merging - Only update current branch if fast-forward is possible - Provide better warnings when branch updates fail but other branches exist - Prevents risk of merging remote main/master into unrelated working branches * fix(install): Improve IPv6 address handling in installation scripts - Filter out IPv6 link-local addresses (fe80:) in addition to loopback - Properly format IPv6 addresses with brackets in URLs (http://[::1]:5000) - Filter loopback and link-local addresses when selecting IP for display - Prevents invalid IPv6 URLs and excludes non-useful addresses - Fixes: first_time_install.sh and one-shot-install.sh IP display logic * fix: Fix checkbox-group saving and improve dynamic duration calculation - Fix checkbox-group widget saving by setting values directly in plugin_config - Fix element_gap calculation bug in ScrollHelper (was over-calculating width) - Use actual image width instead of calculated width for scroll calculations - Add comprehensive INFO-level logging for dynamic duration troubleshooting - Enhanced scroll completion logging with position and percentage details This fixes issues where checkbox-group values weren't saving correctly and improves dynamic duration calculation accuracy for scrolling content. --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-12 18:44:06 -05:00
Chuck	f9e21c6033	Fix/plugin permission errors (#180) ... * fix: Use plugin.modes instead of manifest.json for available modes - Display controller now checks plugin_instance.modes first before falling back to manifest - This allows plugins to dynamically provide modes based on enabled leagues - Fixes issue where disabled leagues (WNBA, NCAAW) appeared in available modes - Plugins can now control their available modes at runtime based on config * fix: Handle permission errors when removing plugin directories - Added _safe_remove_directory() method to handle permission errors gracefully - Fixes permissions on __pycache__ directories before removal - Updates uninstall_plugin() and install methods to use safe removal - Resolves [Errno 13] Permission denied errors during plugin install/uninstall * refactor: Improve error handling in _safe_remove_directory - Rename unused 'dirs' variable to '_dirs' to indicate intentional non-use - Use logger.exception() instead of logger.error() to preserve stack traces - Add comment explaining 0o777 permissions are acceptable (temporary before deletion) --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-12 16:15:12 -05:00
Chuck	f7d72f88b5	fix(plugins): Remove compatible_versions requirement from single plugin install (#169) ... Remove compatible_versions from required fields in install_from_url method to match install_plugin behavior. This allows installing plugins from URLs without manifest version requirements, consistent with store plugin installation. Co-authored-by: Chuck <chuck@example.com>	2026-01-03 15:54:37 -05:00
Chuck	a13bd971b3	fix(plugins): Fix GitHub install and update functionality for plugins installed from URLs (#167) ... * fix(plugins): Fix GitHub install button for single plugin installation - Clone install button before attaching event listener to prevent duplicate handlers - Add safety checks for pluginStatusDiv element - Move installFromCustomRegistry function definition earlier in file - Add error logging when button/elements not found - Ensure consistent button reference usage in event handlers Fixes issue where Install button in 'Install Single Plugin' section was not working properly. * fix(plugins): Add button type and better logging for install button - Add type='button' to install button to prevent form submission - Add console logging to debug click handler attachment - Add preventDefault and stopPropagation to click handler - Improve error logging for debugging * fix(plugins): Re-attach install button handler when section is shown - Extract install button handler to separate function - Re-attach handler when GitHub install section is toggled visible - Add data attribute to prevent duplicate handler attachments - Add comprehensive logging for debugging - Handler now attaches even if section starts hidden * fix(plugins): Add comprehensive logging to debug install button handler - Add logging at function entry points - Add logging when section is shown and handler re-attached - Add logging before and after calling attachInstallButtonHandler - Helps diagnose why handler isn't being attached * fix(plugins): Expose GitHub install handlers globally and add fallback - Expose setupGitHubInstallHandlers and attachInstallButtonHandler to window object - Add fallback handler attachment after page load delay - Fix typo in getElementById call - Allows manual testing from browser console - Ensures handlers are accessible even if IIFE scope issues occur * fix(plugins): Add fallback handler attachment after page load * fix(plugins): Ensure GitHub install handlers are set up even if already initialized - Add check to verify setupGitHubInstallHandlers exists before calling - Call setupGitHubInstallHandlers even if initializePlugins was already called - Add comprehensive logging to track function execution - Helps diagnose why handlers aren't being attached * fix(plugins): Add more prominent logging markers for easier debugging * fix(plugins): Add simple standalone handler for GitHub plugin installation - Create handleGitHubPluginInstall() function defined early and globally - Add inline onclick handler to button as fallback - Bypasses complex initialization flow and IIFE scope issues - Direct approach that works immediately without dependencies - Provides clear error messages and logging * chore: Update 7-segment-clock plugin submodule - Update to latest version with scaling support - Includes compatible_versions field fix for plugin store installation * fix(plugins): Add update and uninstall handling to global event delegation fallback - Add 'update' action handling in handleGlobalPluginAction fallback - Add 'uninstall' action handling with confirmation dialog - Fixes issue where update/uninstall buttons did nothing - Buttons now work even if handlePluginAction isn't available yet * fix(plugins): Improve error message for plugin updates from GitHub URLs - Check if plugin is a git repository before checking registry - Provide more accurate error messages for plugins installed from URLs - Fixes misleading 'Plugin not found in registry' error for git-based plugins - Update should work for plugins installed from GitHub URLs even if not in registry * fix(plugins): Add detailed logging for plugin update failures - Log git command that failed and return code - Add logging before/after update attempt - Log whether plugin is detected as git repository - Helps diagnose why updates fail for plugins installed from URLs * fix(plugins): Add better logging for plugin update detection - Log when plugin is detected as git repository - Log when plugin is not a git repository - Provide helpful message for ZIP-installed plugins - Helps diagnose why updates fail for plugins installed from URLs * fix(plugins): Enable updates for plugins installed from GitHub URLs - Get git remote URL from plugin directory even if .git is missing - If plugin not in registry but has remote URL, reinstall as git repo - Allows updating plugins installed from URLs even if git clone failed initially - Falls back to reinstalling from original URL to enable future updates * fix(plugins): Reinstall from git remote URL if plugin not in registry - When plugin is not a git repo and not in registry, check for git remote URL - If remote URL exists, reinstall plugin from that URL to enable future updates - Handles case where plugin was installed from URL but git clone failed initially * fix(plugins): Improve git update error handling and logging - Make git fetch non-fatal (log warning but continue) - Make git checkout non-fatal (log warning but continue) - Add detailed error messages for common git failures - Log which git command failed and return code - Better handling of authentication, merge conflicts, and unrelated histories * fix(plugins): Add detailed exception logging to update endpoint - Log full traceback when update fails - Log exception details in catch block - Helps diagnose update failures from API endpoint * fix(plugins): Handle untracked files during plugin update - Remove .dependencies_installed marker file before pull (safe to regenerate) - Stash untracked files using 'git stash -u' if they can't be removed - Prevents 'untracked files would be overwritten' errors during update - Fixes issue where .dependencies_installed blocks git pull * chore: Update 7-segment-clock submodule with improved clone instructions --------- Co-authored-by: Chuck <chuck@example.com>	2026-01-03 09:44:51 -05:00
Chuck	67197635c9	Feature/on demand plugin filtering (#166) ... * fix(web): Resolve font display and config API error handling issues - Fix font catalog display error where path.startsWith fails (path is object, not string) - Update save_main_config to use error_response() helper - Improve save_raw_main_config error handling consistency - Add proper error codes and traceback details to API responses * fix(web): Prevent fontCatalog redeclaration error on HTMX reload - Use window object to store global font variables - Check if script has already loaded before declaring variables - Update both window properties and local references on assignment - Fixes 'Identifier fontCatalog has already been declared' error * fix(web): Wrap fonts script in IIFE to prevent all redeclaration errors - Wrap entire script in IIFE that only runs once - Check if script already loaded before declaring variables/functions - Expose initializeFontsTab to window for re-initialization - Prevents 'Identifier has already been declared' errors on HTMX reload * fix(web): Exempt config save API endpoints from CSRF protection - Exempt save_raw_main_config, save_raw_secrets_config, and save_main_config from CSRF - These endpoints are called via fetch from JavaScript and don't include CSRF tokens - Fixes 500 error when saving config via raw JSON editor * fix(web): Exempt system action endpoint from CSRF protection - Exempt execute_system_action from CSRF - Fixes 500 error when using system action buttons (restart display, restart Pi, etc.) - These endpoints are called via HTMX and don't include CSRF tokens * fix(web): Exempt all API v3 endpoints from CSRF protection - Add before_request handler to exempt all api_v3.* endpoints - All API endpoints are programmatic (HTMX/fetch) and don't include CSRF tokens - Prevents future CSRF errors on any API endpoint - Cleaner than exempting individual endpoints * refactor(web): Remove CSRF protection for local-only application - CSRF is designed for internet-facing apps to prevent cross-site attacks - For local-only Raspberry Pi app, threat model is different - All endpoints were exempted anyway, so it wasn't protecting anything - Forms use HTMX without CSRF tokens - If exposing to internet later, can re-enable with proper token implementation * fix(web): Fix font path double-prefixing in font catalog display - Only prefix with 'assets/fonts/' if path is a bare filename - If path starts with '/' (absolute) or 'assets/' (already prefixed), use as-is - Fixes double-prefixing when get_fonts_catalog returns relative paths like 'assets/fonts/press_start.ttf' * fix(web): Remove fontsTabInitialized guard to allow re-initialization on HTMX reload - Remove fontsTabInitialized check that prevented re-initialization on HTMX content swap - The window._fontsScriptLoaded guard is sufficient to prevent function redeclaration - Allow initializeFontsTab() to run on each HTMX swap to attach listeners to new DOM elements - Fixes fonts UI breaking after HTMX reload (buttons, upload dropzone, etc. not working) * fix(api): Preserve empty strings for optional string fields in plugin config - Add _is_field_required() helper to check if fields are required in schema - Update _parse_form_value_with_schema() to preserve empty strings for optional string fields - Fixes 400 error when saving MQTT plugin config with empty username/password - Resolves validation error: 'Expected type string, got NoneType' * fix(config): Add defaults to schemas and fix None value handling - Updated merge_with_defaults to replace None values with defaults - Fixed form processing to skip empty optional fields without defaults - Added script to automatically add defaults to all plugin config schemas - Added defaults to 89 fields across 10 plugin schemas - Prevents validation errors from None values in configs Changes: - schema_manager.py: Enhanced merge_with_defaults to replace None with defaults - api_v3.py: Added _SKIP_FIELD sentinel to skip optional fields without defaults - add_defaults_to_schemas.py: Script to add sensible defaults to schemas - Plugin schemas: Added defaults for number, boolean, and array fields * fix(config): Fix save button spinner by checking HTTP status code - Fixed handleConfigSave to check xhr.status instead of event.detail.successful - With hx-swap="none", HTMX doesn't set event.detail.successful - Now properly detects successful saves (status 200-299) and stops spinner - Improved error message extraction from API responses - Also fixed handleToggleResponse for consistency * fix(web-ui): Resolve GitHub token warning persistence after save - Made checkGitHubAuthStatus() return Promise for proper async handling - Clear sessionStorage dismissal flag when token is saved - Add delay before status check to ensure backend token reload - Wait for status check completion before hiding settings panel Fixes issue where GitHub token warnings and pop-ups would not disappear after successfully saving a token in the web UI. * fix(web-ui): Add token validation and improve GitHub token warning behavior - Add token validation to backend API endpoint to check if token is valid/expired - Implement _validate_github_token() method in PluginStoreManager with caching - Update frontend to show warning only when token is missing or invalid - Keep settings panel accessible (collapsible) when token is configured - Collapse settings panel content after successful token save instead of hiding - Display specific error messages for invalid/expired tokens - Clear sessionStorage dismissal flag when token becomes valid Fixes issue where GitHub token warnings and settings panel would not properly hide/show based on token status. Now validates token validity and provides better UX with collapsible settings panel. * fix(web-ui): Fix CSS/display issue for GitHub token warning and settings - Update all hide/show operations to use both classList and style.display - Fix checkGitHubAuthStatus() to properly hide/show warning and settings - Fix dismissGithubWarning() to use both methods - Fix toggleGithubTokenSettings() with improved state checking - Fix collapse button handler with improved state checking - Fix saveGithubToken() to properly show/collapse settings panel This ensures elements actually hide/show when status changes, matching the pattern used elsewhere in the codebase (like toggleSection). All buttons (dismiss, close, collapse) should now work correctly. * fix(web-ui): Fix GitHub token expand button functionality - Convert collapse button handler to named function (toggleGithubTokenContent) - Improve state checking using class, inline style, and computed style - Re-attach event listener after saving token to ensure it works - Add console logging for debugging - Make function globally accessible for better reliability Fixes issue where expand button didn't work after saving token. * fix(web-ui): Remove X button and improve GitHub token panel behavior - Remove X (close) button from GitHub token configuration panel - Replace toggleGithubTokenSettings() with openGithubTokenSettings() that only opens - Auto-collapse panel when token is valid (user must click expand to edit) - Auto-detect token status on page load (no need to click save) - Simplify saveGithubToken() to rely on checkGitHubAuthStatus() for UI updates - Ensure expand button works correctly with proper event listener attachment The panel now remains visible but collapsed when a token is configured, allowing users to expand it when needed without the ability to completely hide it. * refactor(web-ui): Improve GitHub token collapse button code quality - Update comment to reflect actual behavior (prevent parent click handlers) - Use empty string for display to defer to CSS instead of hard-coding block/none - Extract duplicate clone-and-attach logic into attachGithubTokenCollapseHandler() helper - Make helper function globally accessible for reuse in checkGitHubAuthStatus() Improves maintainability and makes code more future-proof for layout changes. * fix(web-ui): Fix collapse/expand button by using removeProperty for display - Use style.removeProperty('display') instead of style.display = '' - This properly removes inline styles and defers to CSS classes - Fixes issue where collapse/expand button stopped working after refactor * fix(web-ui): Make display handling consistent for token collapse - Use removeProperty('display') consistently in all places - Fix checkGitHubAuthStatus() to use removeProperty instead of inline style - Simplify state checking to rely on hidden class with computed style fallback - Ensures collapse/expand button works correctly by deferring to CSS classes * fix(web-ui): Fix token collapse button and simplify state detection - Simplify state checking to rely on hidden class only (element has class='block') - Only remove inline display style if it exists (check before removing) - Add console logging to debug handler attachment - Ensure collapse/expand works by relying on CSS classes Fixes issues where: - Collapse button did nothing - Auto-detection of token status wasn't working * debug(web-ui): Add extensive debugging for token collapse button - Add console logs to track function calls and element detection - Improve state detection to use computed style as fallback - Add wrapper function for click handler to ensure it's called - Better error messages to identify why handler might not attach This will help identify why the collapse button isn't working. * debug(web-ui): Add comprehensive debugging for GitHub token features - Add console logs to checkGitHubAuthStatus() to track execution - Re-attach collapse handler after plugin store is rendered - Add error stack traces for better debugging - Ensure handler is attached when content is dynamically loaded This will help identify why: - Auto-detection of token status isn't working - Collapse button isn't functioning * fix(web-ui): Move checkGitHubAuthStatus before IIFE to fix scope issue - Move checkGitHubAuthStatus function definition before IIFE starts - Function was defined after IIFE but called inside it, causing it to be undefined - Now function is available when called during initialization - This should fix auto-detection of token status on page load * debug(web-ui): Add extensive logging to GitHub token functions - Add logging when checkGitHubAuthStatus is defined - Add logging when function is called during initialization - Add logging in attachGithubTokenCollapseHandler - Add logging in store render callback - This will help identify why functions aren't executing * fix(web-ui): Move GitHub token functions outside IIFE for availability - Move attachGithubTokenCollapseHandler and toggleGithubTokenContent outside IIFE - These functions need to be available when store renders, before IIFE completes - Add logging to initializePlugins to track when it's called - This should fix the 'undefined' error when store tries to attach handlers * fix(web-ui): Fix GitHub token content collapse/expand functionality - Element has 'block' class in HTML which conflicts with 'hidden' class - When hiding: add 'hidden', remove 'block', set display:none inline - When showing: remove 'hidden', add 'block', remove inline display - This ensures proper visibility toggle for the GitHub API Configuration section * feat(display): Implement on-demand plugin filtering with restart - Add on-demand plugin filtering to DisplayController initialization - Filters available_modes to only include on-demand plugin's modes - Allows plugin internal rotation (e.g., NFL upcoming, NCAA FB Recent) - Prevents rotation to other plugins - Implement restart mechanism for on-demand activation/clear - _restart_with_on_demand_filter() saves state and restarts with filter - _restart_without_on_demand_filter() restores normal operation - Supports both systemd service and direct process execution - Add state preservation across restarts - Saves/restores rotation position from cache - Restores on-demand config from cache after restart - Add service detection method - Detects if running as systemd service - Uses file-based approach for environment variable passing - Update API endpoints with restart flow comments - Update systemd service file with on-demand support notes - Add comprehensive error handling for edge cases * perf(web-ui): Optimize GitHub token detection speed - Call checkGitHubAuthStatus immediately when script loads (if elements exist) - Call it early in initPluginsPage (before full initialization completes) - Use requestAnimationFrame instead of setTimeout(100ms) for store render callback - Reduce save token delay from 300ms to 100ms - Token detection now happens in parallel with other initialization tasks - This makes token status visible much faster on page load * fix(ui): Move on-demand modal to base.html for always-available access - Move on-demand modal from plugins.html to base.html - Ensures modal is always in DOM when Run On-Demand button is clicked - Fixes issue where button in plugin_config.html couldn't find modal - Modal is now available regardless of which tab is active * fix(ui): Initialize on-demand modal unconditionally on page load - Create initializeOnDemandModal() function that runs regardless of plugins tab - Modal is in base.html so it should always be available - Call initialization on DOMContentLoaded and with timeout - Fixes 'On-demand modal elements not found' error when clicking button - Modal setup now happens even if plugins tab hasn't been loaded yet * fix(ui): Add safety check for updatePluginTabStates function - Check if updatePluginTabStates exists before calling - Prevents TypeError when function is not available - Fixes error when clicking plugin tabs * fix(ui): Add safety checks for all updatePluginTabStates calls - Add safety check in Alpine component tab button handler - Add safety check in Alpine callback - Prevents TypeError when function is not available in all contexts * fix(ui): Add safety check in Alpine callback for updatePluginTabStates * debug(ui): Add console logging to trace on-demand modal opening - Add logging to runPluginOnDemand function - Add logging to __openOnDemandModalImpl function - Log plugin lookup, modal element checks, and display changes - Helps diagnose why modal doesn't open when button is clicked * debug(ui): Add logging for modal display change * debug(ui): Add more explicit modal visibility settings and computed style logging - Set visibility and opacity explicitly when showing modal - Force reflow to ensure styles are applied - Log computed styles to diagnose CSS issues - Helps identify if modal is hidden by CSS rules * debug(ui): Increase modal z-index and add bounding rect check - Set z-index to 9999 to ensure modal is above all other elements - Add bounding rect check to verify modal is in viewport - Helps diagnose if modal is positioned off-screen or behind other elements * debug(display): Add detailed logging for on-demand restart flow - Log when polling finds requests - Log service detection result - Log file writing and systemctl commands - Log restart command execution and results - Helps diagnose why on-demand restart isn't working * debug(display): Add logging for on-demand request polling - Log request_id comparison to diagnose why requests aren't being processed - Helps identify if request_id matching is preventing processing * fix(ui): Force modal positioning with !important to override any conflicting styles - Use cssText with !important flags to ensure modal is always visible - Remove all inline styles first to start fresh - Ensure modal is positioned at top:0, left:0 with fixed positioning - Fixes issue where modal was still positioned off-screen (top: 2422px) * debug(ui): Add logging to on-demand form submission - Log form submission events - Log payload being sent - Log response status and data - Helps diagnose why on-demand requests aren't being processed * fix(display): Remove restart-based on-demand activation - Replace restart-based activation with immediate mode switch - On-demand now activates without restarting the service - Saves rotation state for restoration when on-demand ends - Fixes infinite restart loop issue - On-demand now works when display is already running * docs: Add comprehensive guide for on-demand cache management - Document all on-demand cache keys and their purposes - Explain when manual clearing is needed - Clarify what clearing from cache management tab does/doesn't do - Provide troubleshooting steps and best practices * fix(display): Ensure on-demand takes priority over live priority - Move on-demand check BEFORE live priority check - Add explicit logging when on-demand overrides live priority - Improve request_id checking with both instance and persisted checks - Add debug logging to trace why requests aren't being processed - Fixes issue where on-demand didn't interrupt live NHL game * fix(display): Ensure on-demand takes priority over live priority - Move on-demand check BEFORE live priority check in main loop - Add explicit logging when on-demand overrides live priority - Fixes issue where on-demand didn't interrupt live NHL game * fix(display): Improve on-demand request processing and priority - Add persistent processed_id check to prevent duplicate processing - Mark request as processed BEFORE processing to prevent race conditions - Improve logging to trace request processing - Ensure on-demand takes priority over live priority (already fixed in previous commit) * fix(display): Remove duplicate action line * fix(display): Fix live priority and ensure on-demand overrides it - Fix live priority to properly set active_mode when live content is detected - Ensure on-demand check happens before live priority check - Add debug logging to trace on-demand vs live priority - Fix live priority to stay on live mode instead of rotating * fix(display): Add debug logging for on-demand priority check * fix(display): Add better logging for on-demand request processing - Add logging to show when requests are blocked by processed_id check - Add logging to show on-demand state after activation - Helps debug why on-demand requests aren't being processed * fix(display): Add detailed logging for on-demand activation and checking - Log on-demand state after activation to verify it's set correctly - Add debug logging in main loop to trace on-demand check - Helps identify why on-demand isn't overriding live priority * fix(display): Add debug logging for on-demand check in main loop * fix(display): Remove restart logic from _clear_on_demand and fix cache delete - Replace cache_manager.delete() with cache_manager.clear_cache() - Remove restart logic from _clear_on_demand - now clears immediately - Restore rotation state immediately without restarting - Fixes AttributeError: 'CacheManager' object has no attribute 'delete' * fix(display): Remove restart logic from _clear_on_demand - Remove restart logic - now clears on-demand state immediately - Restore rotation state immediately without restarting - Use clear_cache instead of delete (already fixed in previous commit) - Fixes error when stopping on-demand mode * feat(display): Clear display before activating on-demand mode - Clear display and reset state before activating on-demand - Reset dynamic mode state to ensure clean transition - Mimics the behavior of manually stopping display first - Should fix issue where on-demand only works after manual stop * feat(display): Stop display service before starting on-demand mode - Stop the display service first if it's running - Wait 1.5 seconds for clean shutdown - Then start the service with on-demand request in cache - Mimics the manual workflow of stopping display first - Should fix issue where on-demand only works after manual stop * feat(display): Filter plugins during initialization for on-demand mode - Check cache for on-demand requests during initialization - Only load the on-demand plugin if on-demand request is found - Prevents loading background services for other plugins - Fixes issue where Hockey/Football data loads even when only Clock is requested * fix(display): Use filtered enabled_plugins list instead of discovered_plugins - Use enabled_plugins list which is already filtered for on-demand mode - Prevents loading all plugins when on-demand mode is active - Fixes issue where all plugins were loaded even in on-demand mode * fix(display): Fix on-demand stop request processing and expiration check - Always process stop requests, even if request_id was seen before - Fix expiration check to handle cases where on-demand is not active - Add better logging for stop requests and expiration - Fixes issue where stop button does nothing and timer doesn't expire * fix(display): Fix on-demand stop processing, expiration, and plugin filtering - Fix stop request processing to always process stop requests, bypassing request_id checks - Fix expiration check logic to properly check on_demand_active and expires_at separately - Store display_on_demand_config cache key in _activate_on_demand for plugin filtering - Clear display before switching to on-demand mode to prevent visual artifacts - Clear display_on_demand_config cache key in _clear_on_demand to prevent stale data - Implement plugin filtering during initialization based on display_on_demand_config Fixes issues where: - Stop button did nothing (stop requests were blocked by request_id check) - Expiration timer didn't work (logic issue with or condition) - Plugin filtering didn't work on restart (config cache key never set) - Display showed artifacts when switching to on-demand (display not cleared) - All plugins loaded even in on-demand mode (filtering not implemented) * fix(web): Allow on-demand to work with disabled plugins - Remove frontend checks that blocked disabled plugins from on-demand - Backend already supports temporarily enabling disabled plugins during on-demand - Update UI messages to indicate plugin will be temporarily enabled - Remove disabled attribute from Run On-Demand button Fixes issue where disabled plugins couldn't use on-demand feature even though the backend implementation supports it. * fix(display): Resolve plugin_id when sent as mode in on-demand requests - Detect when mode parameter is actually a plugin_id and resolve to first display mode - Handle case where frontend sends plugin_id as mode (e.g., 'football-scoreboard') - Add fallback to use first available display mode if provided mode is invalid - Add logging for mode resolution debugging Fixes issue where on-demand requests with mode=plugin_id failed with 'invalid-mode' error * feat(display): Rotate through all plugin modes in on-demand mode - Store all modes for on-demand plugin instead of locking to single mode - Rotate through available modes (live, recent, upcoming) when on-demand active - Skip modes that return False (no content) and move to next mode - Prioritize live modes if they have content, otherwise skip them - Add on_demand_modes list and on_demand_mode_index for rotation tracking Fixes issue where on-demand mode stayed on one mode (e.g., football_recent) and didn't rotate through other available modes (football_live, football_upcoming). Now properly rotates through all modes, skipping empty ones. * fix(display): Improve on-demand stop request handling - Always process stop requests if on-demand is active, even if same request_id - Add better logging when stop is requested but on-demand is not active - Improve logging in _clear_on_demand to show which mode rotation resumes to - Ensure stop requests are properly acknowledged Fixes issue where stop button shows as completed but display doesn't resume normal rotation. Stop requests now properly clear on-demand state and resume. * security(web): Fix XSS vulnerability in GitHub auth error display Replace innerHTML usage with safe DOM manipulation: - Use textContent to clear element and create text nodes - Create <strong> element via createElement instead of string HTML - Add safe fallback ('Unknown error') for error messages - Ensure authData.error/authData.message are treated as plain text - Avoid trusting backend-provided data as HTML Fixes XSS vulnerability where malicious HTML in error messages could be injected into the DOM. * style(api): Remove unnecessary str() in f-string for error message Remove explicit str(e) call in error_response f-string since f-strings automatically convert exceptions to strings. This matches the style used elsewhere in the file. Changed: f"Error saving configuration: {str(e)}" To: f"Error saving configuration: {e}" * fix(store): Skip caching for rate-limited 403 responses When a 403 response indicates a rate limit (detected by checking if 'rate limit' is in response.text.lower()), return the error result but do NOT cache it in _token_validation_cache. Rate limits are temporary and should be retried, so caching would incorrectly mark the token as invalid. Continue to cache 403 responses that indicate missing token permissions, as these are persistent issues that should be cached. This prevents rate-limited responses from being incorrectly cached as invalid tokens, allowing the system to retry after the rate limit resets. * fix(display): Prevent ZeroDivisionError when on_demand_modes is empty Add guards to check if on_demand_modes is non-empty before performing any rotation/index math operations. When on_demand_active is True but on_demand_modes is empty, clear on-demand mode instead of attempting division by zero. Fixed in three locations: 1. Mode selection logic (line ~1081): Check before accessing modes 2. Skip to next mode when no content (line ~1190): Guard before modulo 3. Rotate to next mode (line ~1561): Guard before modulo This prevents ZeroDivisionError when a plugin has no available display modes or when on_demand_modes becomes empty unexpectedly. * fix(display): Improve guard for empty on_demand_modes in rotation skip Refine the guard around lines 1195-1209 to: - Check if on_demand_modes is empty before any modulo/index operations - Log warning and debug trace when no modes are configured - Skip rotation (continue) instead of clearing on-demand mode - Only perform modulo and index operations when modes are available - Only log rotation message when next_mode is valid This prevents ZeroDivisionError and ensures all logging only occurs when next_mode is valid, providing better traceability. * fix(display): Populate on_demand_modes when restoring on-demand state from cache When restoring on-demand state from cache during initialization (around lines 163-197), the code sets on_demand_active, on_demand_plugin_id and related fields but does not populate self.on_demand_modes, causing the run loop to see an empty modes list after restart. Fix by: 1. Adding _populate_on_demand_modes_from_plugin() method that retrieves the plugin's display modes from plugin_display_modes and builds the ordered modes list (prioritizing live modes with content, same logic as _activate_on_demand) 2. Calling this method after plugin loading completes (around line 296) when on_demand_active and on_demand_plugin_id are set 3. Setting on_demand_mode_index to match the restored mode if available, otherwise starting at index 0 This ensures on_demand_modes is populated after restart, preventing empty modes list errors in the run loop. * docs: Update on-demand documentation to reflect current implementation Replace obsolete log message reference with current log messages: - Old: 'Activating on-demand mode... restarting display controller' - New: 'Processing on-demand start request for plugin' and 'Activated on-demand for plugin' Update Scenario 2 to reflect immediate mode switching: - Changed title from 'Infinite Restart Loop' to 'On-Demand Mode Switching Issues' - Updated symptoms to describe mode switching issues instead of restart loops - Added note that on-demand now switches modes immediately without restarting - Updated solution to include display_on_demand_state key This reflects the current implementation where on-demand activates immediately without restarting the service. * fix(api): Fix undefined logger and service stop logic in start_on_demand_display - Add module-level logger to avoid NameError when logging disabled plugin - Only stop display service when start_service is True (prevents stopping service without restarting when start_service is False) - Remove unused stop_result variable - Clean up f-strings that don't need formatting - Improve code formatting for logger.info call Fixes issue where logger.info() would raise NameError and where the service would be stopped even when start_service=False, leaving the service stopped without restarting it. --------- Signed-off-by: Chuck <33324927+ChuckBuilds@users.noreply.github.com> Co-authored-by: Chuck <chuck@example.com>	2026-01-01 18:27:58 -05:00
Chuck	24c34c5a40	fix(plugins): Resolve plugin action button errors and config save permission issues (#162) ... * fix(plugins): Resolve plugin ID determination error in action buttons - Fix server-side template parameter order for executePluginAction - Add data-plugin-id attributes to action buttons in all templates - Enhance executePluginAction with comprehensive fallback logic - Support retrieving pluginId from DOM, Alpine context, and config state - Fixes 'Unable to determine plugin ID' error for Spotify/YouTube auth * fix(plugins): Add missing button IDs and status divs in server-side action template - Add action-{id}-{index} IDs to action buttons - Add action-status-{id}-{index} status divs for each action - Match client-side template structure for consistency - Fixes 'Action elements not found' error * fix(api): Fix indentation error in execute_plugin_action function - Fix incorrect else block indentation that caused 500 errors - Correct indentation for OAuth flow and simple script execution paths - Resolves syntax error preventing plugin actions from executing * fix(api): Improve error handling for plugin actions and config saves - Add better JSON parsing error handling with request details - Add detailed permission error messages for secrets file saves - Include file path and permission status in error responses - Helps diagnose 400 errors on action execution and 500 errors on config saves * fix(api): Add detailed permission error handling for secrets config saves - Add PermissionError-specific handling with permission checks - Include directory and file permission status in error logs - Provide more helpful error messages with file paths - Helps diagnose permission issues when saving config_secrets.json * fix(config): Add permission check and actionable error message for config saves - Check file writability before attempting write - Show file owner and current permissions in error message - Provide exact command to fix permissions (chown + chmod) - Helps diagnose and resolve permission issues with config_secrets.json * fix(config): Preserve detailed permission error messages - Handle PermissionError separately to preserve detailed error messages - Ensure actionable permission fix commands are included in error response - Prevents detailed error messages from being lost in exception chain * fix(config): Remove overly strict pre-write permission check - Remove pre-write file existence/writability check that was blocking valid writes - Let actual file write operation determine success/failure - Provide detailed error messages only when write actually fails - Fixes regression where config_secrets.json saves were blocked unnecessarily * fix(config): Use atomic writes for config_secrets.json to handle permission issues - Write to temp file first, then atomically move to final location - Works even when existing file isn't writable (as long as directory is writable) - Matches pattern used elsewhere in codebase (disk_cache, atomic_manager) - Fixes permission errors when saving secrets configuration * chore: Update music plugin submodule to include live_priority fix * fix(plugins): Improve plugin ID determination in dynamic button generation - Update generateFormFromSchema to pass currentPluginConfig?.pluginId and add data attributes - Update generateSimpleConfigForm to pass currentPluginConfig?.pluginId and add data attributes - Scope fallback 6 DOM lookup to button context instead of document-wide search - Ensures correct plugin tab selection when multiple plugins are present - Maintains existing try/catch error handling and logging --------- Co-authored-by: Chuck <chuck@example.com>	2025-12-29 22:17:11 -05:00
Chuck	1815a5b791	fix(fonts): Remove missing cozette.bdf font reference (#160) ... - Removed cozette_bdf from common_fonts dictionary in font_manager.py - Removed cozette_bdf option from web interface font selectors - Resolves warning: 'Common font file not found: assets/fonts/cozette.bdf' - Font can be re-enabled by adding the font file and re-adding to common_fonts Co-authored-by: Chuck <chuck@example.com>	2025-12-28 17:25:09 -05:00
Chuck	97a301a1a9	fix(web-ui): Fix GitHub token warning persistence and improve UX (#154) ... * fix(web): Resolve font display and config API error handling issues - Fix font catalog display error where path.startsWith fails (path is object, not string) - Update save_main_config to use error_response() helper - Improve save_raw_main_config error handling consistency - Add proper error codes and traceback details to API responses * fix(web): Prevent fontCatalog redeclaration error on HTMX reload - Use window object to store global font variables - Check if script has already loaded before declaring variables - Update both window properties and local references on assignment - Fixes 'Identifier fontCatalog has already been declared' error * fix(web): Wrap fonts script in IIFE to prevent all redeclaration errors - Wrap entire script in IIFE that only runs once - Check if script already loaded before declaring variables/functions - Expose initializeFontsTab to window for re-initialization - Prevents 'Identifier has already been declared' errors on HTMX reload * fix(web): Exempt config save API endpoints from CSRF protection - Exempt save_raw_main_config, save_raw_secrets_config, and save_main_config from CSRF - These endpoints are called via fetch from JavaScript and don't include CSRF tokens - Fixes 500 error when saving config via raw JSON editor * fix(web): Exempt system action endpoint from CSRF protection - Exempt execute_system_action from CSRF - Fixes 500 error when using system action buttons (restart display, restart Pi, etc.) - These endpoints are called via HTMX and don't include CSRF tokens * fix(web): Exempt all API v3 endpoints from CSRF protection - Add before_request handler to exempt all api_v3.* endpoints - All API endpoints are programmatic (HTMX/fetch) and don't include CSRF tokens - Prevents future CSRF errors on any API endpoint - Cleaner than exempting individual endpoints * refactor(web): Remove CSRF protection for local-only application - CSRF is designed for internet-facing apps to prevent cross-site attacks - For local-only Raspberry Pi app, threat model is different - All endpoints were exempted anyway, so it wasn't protecting anything - Forms use HTMX without CSRF tokens - If exposing to internet later, can re-enable with proper token implementation * fix(web): Fix font path double-prefixing in font catalog display - Only prefix with 'assets/fonts/' if path is a bare filename - If path starts with '/' (absolute) or 'assets/' (already prefixed), use as-is - Fixes double-prefixing when get_fonts_catalog returns relative paths like 'assets/fonts/press_start.ttf' * fix(web): Remove fontsTabInitialized guard to allow re-initialization on HTMX reload - Remove fontsTabInitialized check that prevented re-initialization on HTMX content swap - The window._fontsScriptLoaded guard is sufficient to prevent function redeclaration - Allow initializeFontsTab() to run on each HTMX swap to attach listeners to new DOM elements - Fixes fonts UI breaking after HTMX reload (buttons, upload dropzone, etc. not working) * fix(api): Preserve empty strings for optional string fields in plugin config - Add _is_field_required() helper to check if fields are required in schema - Update _parse_form_value_with_schema() to preserve empty strings for optional string fields - Fixes 400 error when saving MQTT plugin config with empty username/password - Resolves validation error: 'Expected type string, got NoneType' * fix(config): Add defaults to schemas and fix None value handling - Updated merge_with_defaults to replace None values with defaults - Fixed form processing to skip empty optional fields without defaults - Added script to automatically add defaults to all plugin config schemas - Added defaults to 89 fields across 10 plugin schemas - Prevents validation errors from None values in configs Changes: - schema_manager.py: Enhanced merge_with_defaults to replace None with defaults - api_v3.py: Added _SKIP_FIELD sentinel to skip optional fields without defaults - add_defaults_to_schemas.py: Script to add sensible defaults to schemas - Plugin schemas: Added defaults for number, boolean, and array fields * fix(config): Fix save button spinner by checking HTTP status code - Fixed handleConfigSave to check xhr.status instead of event.detail.successful - With hx-swap="none", HTMX doesn't set event.detail.successful - Now properly detects successful saves (status 200-299) and stops spinner - Improved error message extraction from API responses - Also fixed handleToggleResponse for consistency * fix(web-ui): Resolve GitHub token warning persistence after save - Made checkGitHubAuthStatus() return Promise for proper async handling - Clear sessionStorage dismissal flag when token is saved - Add delay before status check to ensure backend token reload - Wait for status check completion before hiding settings panel Fixes issue where GitHub token warnings and pop-ups would not disappear after successfully saving a token in the web UI. * fix(web-ui): Add token validation and improve GitHub token warning behavior - Add token validation to backend API endpoint to check if token is valid/expired - Implement _validate_github_token() method in PluginStoreManager with caching - Update frontend to show warning only when token is missing or invalid - Keep settings panel accessible (collapsible) when token is configured - Collapse settings panel content after successful token save instead of hiding - Display specific error messages for invalid/expired tokens - Clear sessionStorage dismissal flag when token becomes valid Fixes issue where GitHub token warnings and settings panel would not properly hide/show based on token status. Now validates token validity and provides better UX with collapsible settings panel. * fix(web-ui): Fix CSS/display issue for GitHub token warning and settings - Update all hide/show operations to use both classList and style.display - Fix checkGitHubAuthStatus() to properly hide/show warning and settings - Fix dismissGithubWarning() to use both methods - Fix toggleGithubTokenSettings() with improved state checking - Fix collapse button handler with improved state checking - Fix saveGithubToken() to properly show/collapse settings panel This ensures elements actually hide/show when status changes, matching the pattern used elsewhere in the codebase (like toggleSection). All buttons (dismiss, close, collapse) should now work correctly. * fix(web-ui): Fix GitHub token expand button functionality - Convert collapse button handler to named function (toggleGithubTokenContent) - Improve state checking using class, inline style, and computed style - Re-attach event listener after saving token to ensure it works - Add console logging for debugging - Make function globally accessible for better reliability Fixes issue where expand button didn't work after saving token. * fix(web-ui): Remove X button and improve GitHub token panel behavior - Remove X (close) button from GitHub token configuration panel - Replace toggleGithubTokenSettings() with openGithubTokenSettings() that only opens - Auto-collapse panel when token is valid (user must click expand to edit) - Auto-detect token status on page load (no need to click save) - Simplify saveGithubToken() to rely on checkGitHubAuthStatus() for UI updates - Ensure expand button works correctly with proper event listener attachment The panel now remains visible but collapsed when a token is configured, allowing users to expand it when needed without the ability to completely hide it. * refactor(web-ui): Improve GitHub token collapse button code quality - Update comment to reflect actual behavior (prevent parent click handlers) - Use empty string for display to defer to CSS instead of hard-coding block/none - Extract duplicate clone-and-attach logic into attachGithubTokenCollapseHandler() helper - Make helper function globally accessible for reuse in checkGitHubAuthStatus() Improves maintainability and makes code more future-proof for layout changes. * fix(web-ui): Fix collapse/expand button by using removeProperty for display - Use style.removeProperty('display') instead of style.display = '' - This properly removes inline styles and defers to CSS classes - Fixes issue where collapse/expand button stopped working after refactor * fix(web-ui): Make display handling consistent for token collapse - Use removeProperty('display') consistently in all places - Fix checkGitHubAuthStatus() to use removeProperty instead of inline style - Simplify state checking to rely on hidden class with computed style fallback - Ensures collapse/expand button works correctly by deferring to CSS classes * fix(web-ui): Fix token collapse button and simplify state detection - Simplify state checking to rely on hidden class only (element has class='block') - Only remove inline display style if it exists (check before removing) - Add console logging to debug handler attachment - Ensure collapse/expand works by relying on CSS classes Fixes issues where: - Collapse button did nothing - Auto-detection of token status wasn't working * debug(web-ui): Add extensive debugging for token collapse button - Add console logs to track function calls and element detection - Improve state detection to use computed style as fallback - Add wrapper function for click handler to ensure it's called - Better error messages to identify why handler might not attach This will help identify why the collapse button isn't working. * debug(web-ui): Add comprehensive debugging for GitHub token features - Add console logs to checkGitHubAuthStatus() to track execution - Re-attach collapse handler after plugin store is rendered - Add error stack traces for better debugging - Ensure handler is attached when content is dynamically loaded This will help identify why: - Auto-detection of token status isn't working - Collapse button isn't functioning * fix(web-ui): Move checkGitHubAuthStatus before IIFE to fix scope issue - Move checkGitHubAuthStatus function definition before IIFE starts - Function was defined after IIFE but called inside it, causing it to be undefined - Now function is available when called during initialization - This should fix auto-detection of token status on page load * debug(web-ui): Add extensive logging to GitHub token functions - Add logging when checkGitHubAuthStatus is defined - Add logging when function is called during initialization - Add logging in attachGithubTokenCollapseHandler - Add logging in store render callback - This will help identify why functions aren't executing * fix(web-ui): Move GitHub token functions outside IIFE for availability - Move attachGithubTokenCollapseHandler and toggleGithubTokenContent outside IIFE - These functions need to be available when store renders, before IIFE completes - Add logging to initializePlugins to track when it's called - This should fix the 'undefined' error when store tries to attach handlers * fix(web-ui): Fix GitHub token content collapse/expand functionality - Element has 'block' class in HTML which conflicts with 'hidden' class - When hiding: add 'hidden', remove 'block', set display:none inline - When showing: remove 'hidden', add 'block', remove inline display - This ensures proper visibility toggle for the GitHub API Configuration section * perf(web-ui): Optimize GitHub token detection speed - Call checkGitHubAuthStatus immediately when script loads (if elements exist) - Call it early in initPluginsPage (before full initialization completes) - Use requestAnimationFrame instead of setTimeout(100ms) for store render callback - Reduce save token delay from 300ms to 100ms - Token detection now happens in parallel with other initialization tasks - This makes token status visible much faster on page load * fix(web-ui): Fix all collapse/expand buttons on plugins page - Fix Installed Plugins section collapse/expand button - Fix Plugin Store section collapse/expand button - Fix GitHub Install section collapse/expand button - Apply same fixes as GitHub token button: * Clone buttons to remove existing listeners * Handle block/hidden class conflicts properly * Add proper event prevention (stopPropagation/preventDefault) * Add logging for debugging - All collapse/expand buttons should now work correctly * fix(web-ui): Fix syntax error in setupGitHubInstallHandlers - Ensure all handler setup code is inside the function - Add comment to mark function end clearly * refactor(web-ui): Remove collapse buttons from Installed Plugins and Plugin Store - Remove collapse/expand buttons from Installed Plugins section - Remove collapse/expand buttons from Plugin Store section - Remove related JavaScript handler code - These sections are now always visible for better UX - GitHub token section still has collapse functionality --------- Co-authored-by: Chuck <chuck@example.com>	2025-12-28 14:18:51 -05:00
Chuck	7ec4323ff4	fix(config): Add defaults to schemas and fix config validation issues (#153) ... * fix(web): Resolve font display and config API error handling issues - Fix font catalog display error where path.startsWith fails (path is object, not string) - Update save_main_config to use error_response() helper - Improve save_raw_main_config error handling consistency - Add proper error codes and traceback details to API responses * fix(web): Prevent fontCatalog redeclaration error on HTMX reload - Use window object to store global font variables - Check if script has already loaded before declaring variables - Update both window properties and local references on assignment - Fixes 'Identifier fontCatalog has already been declared' error * fix(web): Wrap fonts script in IIFE to prevent all redeclaration errors - Wrap entire script in IIFE that only runs once - Check if script already loaded before declaring variables/functions - Expose initializeFontsTab to window for re-initialization - Prevents 'Identifier has already been declared' errors on HTMX reload * fix(web): Exempt config save API endpoints from CSRF protection - Exempt save_raw_main_config, save_raw_secrets_config, and save_main_config from CSRF - These endpoints are called via fetch from JavaScript and don't include CSRF tokens - Fixes 500 error when saving config via raw JSON editor * fix(web): Exempt system action endpoint from CSRF protection - Exempt execute_system_action from CSRF - Fixes 500 error when using system action buttons (restart display, restart Pi, etc.) - These endpoints are called via HTMX and don't include CSRF tokens * fix(web): Exempt all API v3 endpoints from CSRF protection - Add before_request handler to exempt all api_v3.* endpoints - All API endpoints are programmatic (HTMX/fetch) and don't include CSRF tokens - Prevents future CSRF errors on any API endpoint - Cleaner than exempting individual endpoints * refactor(web): Remove CSRF protection for local-only application - CSRF is designed for internet-facing apps to prevent cross-site attacks - For local-only Raspberry Pi app, threat model is different - All endpoints were exempted anyway, so it wasn't protecting anything - Forms use HTMX without CSRF tokens - If exposing to internet later, can re-enable with proper token implementation * fix(web): Fix font path double-prefixing in font catalog display - Only prefix with 'assets/fonts/' if path is a bare filename - If path starts with '/' (absolute) or 'assets/' (already prefixed), use as-is - Fixes double-prefixing when get_fonts_catalog returns relative paths like 'assets/fonts/press_start.ttf' * fix(web): Remove fontsTabInitialized guard to allow re-initialization on HTMX reload - Remove fontsTabInitialized check that prevented re-initialization on HTMX content swap - The window._fontsScriptLoaded guard is sufficient to prevent function redeclaration - Allow initializeFontsTab() to run on each HTMX swap to attach listeners to new DOM elements - Fixes fonts UI breaking after HTMX reload (buttons, upload dropzone, etc. not working) * fix(api): Preserve empty strings for optional string fields in plugin config - Add _is_field_required() helper to check if fields are required in schema - Update _parse_form_value_with_schema() to preserve empty strings for optional string fields - Fixes 400 error when saving MQTT plugin config with empty username/password - Resolves validation error: 'Expected type string, got NoneType' * fix(config): Add defaults to schemas and fix None value handling - Updated merge_with_defaults to replace None values with defaults - Fixed form processing to skip empty optional fields without defaults - Added script to automatically add defaults to all plugin config schemas - Added defaults to 89 fields across 10 plugin schemas - Prevents validation errors from None values in configs Changes: - schema_manager.py: Enhanced merge_with_defaults to replace None with defaults - api_v3.py: Added _SKIP_FIELD sentinel to skip optional fields without defaults - add_defaults_to_schemas.py: Script to add sensible defaults to schemas - Plugin schemas: Added defaults for number, boolean, and array fields * fix(config): Fix save button spinner by checking HTTP status code - Fixed handleConfigSave to check xhr.status instead of event.detail.successful - With hx-swap="none", HTMX doesn't set event.detail.successful - Now properly detects successful saves (status 200-299) and stops spinner - Improved error message extraction from API responses - Also fixed handleToggleResponse for consistency --------- Co-authored-by: Chuck <chuck@example.com>	2025-12-28 09:18:20 -05:00
Chuck	b0d65581df	Fix/config save error handling (#150) ... * fix(docs): Add trailing newlines to documentation files * fix(web): Resolve font configuration loading error on first page load - Remove ineffective DOMContentLoaded listener from fonts partial (loads via HTMX after main page DOMContentLoaded) - Add proper HTMX event handling with htmx:afterSettle for reliable initialization - Add duplicate initialization protection flag - Improve error handling with response validation and clearer error messages - Add fallback initialization check for edge cases - Ensure DOM elements exist before attempting initialization Fixes issue where 'Error loading font configuration' appeared on first web UI load when opening fonts tab. * fix(config): Update plugins_directory to plugin-repos in config template The web-ui-info plugin is located in plugin-repos/ directory, but the config template was pointing to plugins/ directory. This caused the plugin to not be discovered on fresh installations. - Changed plugins_directory from 'plugins' to 'plugin-repos' in config.template.json - Matches actual plugin location and code default behavior - Ensures web-ui-info plugin is available by default on fresh installs * fix(config): Improve config save error handling - Make load_config() failure non-fatal in save_raw_file_content - Wrapped reload in try-except to prevent save failures when reload fails - File save is atomic and successful even if reload fails - Logs warning when reload fails but doesn't fail the operation - Improve error messages in API endpoints - Added detailed error logging with full traceback for debugging - Extract specific error messages from ConfigError exceptions - Include config_path in error messages when available - Provide fallback messages for empty error strings - Enhance frontend error handling - Check response status before parsing JSON - Better handling of non-JSON error responses - Fallback error messages if error details are missing Fixes issue where 'Error saving config.json: an error occured' was shown even when the file was saved successfully but reload failed. --------- Co-authored-by: Chuck <chuck@example.com>	2025-12-27 18:00:32 -05:00
Chuck	7d71656cf1	Plugins (#145) ... Chaotic mega-merge into main. THINGS WILL PROBABLY BE BROKEN * chore: Update soccer-scoreboard submodule to merged commit - Update submodule reference to include manifest.json v2 registry format - Version updated to 1.0.1 * refactor: Remove test_mode and logo_dir config reading from base SportsCore - Remove test_mode initialization and usage - Remove logo_dir reading from mode_config - Use LogoDownloader defaults directly for logo directories * chore: Update plugin submodules after removing global properties - Update basketball-scoreboard submodule (removed global test_mode, live_priority, dynamic_duration, logo_dir) - Update soccer-scoreboard submodule (removed global test_mode, live_priority, dynamic_duration, logo_dir) * feat(calendar): Add credentials.json file upload via web interface - Add API endpoint /api/v3/plugins/calendar/upload-credentials for file upload - Validate JSON format and Google OAuth structure - Save file to plugin directory with secure permissions (0o600) - Backup existing credentials.json before overwriting - Add file upload widget support for string fields in config forms - Add frontend handler handleCredentialsUpload() for single file uploads - Update .gitignore to allow calendar submodule - Update calendar submodule reference * fix(web): Improve spacing for nested configuration sections - Add dynamic margin based on nesting depth (mb-6 for deeply nested sections) - Increase padding in nested content areas (py-3 to py-4) - Add extra spacing after nested sections to prevent overlap - Enhance CSS spacing for nested sections (1.5rem for nested, 2rem for deeply nested) - Add padding-bottom to expanded nested content to prevent cutoff - Fixes issue where game_limits and other nested settings were hidden under next section header * chore(plugins): Update sports scoreboard plugins with live update interval fix - Updated hockey-scoreboard, football-scoreboard, basketball-scoreboard, and soccer-scoreboard submodules - All plugins now fix the interval selection bug that caused live games to update every 5 minutes instead of 30 seconds - Ensures all live games update at the configured live_update_interval (30s) for timely score updates * fix: Initialize test_mode in SportsLive and fix config migration - Add test_mode initialization in SportsLive.__init__() to prevent AttributeError - Remove invalid new_secrets parameter from save_config_atomic() call in config migration - Fixes errors: 'NBALiveManager' object has no attribute 'test_mode' - Fixes errors: ConfigManager.save_config_atomic() got unexpected keyword argument 'new_secrets' * chore: Update submodules with test_mode initialization fixes - Update basketball-scoreboard submodule - Update soccer-scoreboard submodule * fix(plugins): Auto-stash local changes before plugin updates - Automatically stash uncommitted changes before git pull during plugin updates - Prevents update failures when plugins have local modifications - Improves error messages for git update failures - Matches behavior of main LEDMatrix update process * fix(basketball-scoreboard): Update submodule with timeout fix - Updated basketball-scoreboard plugin to fix update() timeout issue - Plugin now uses fire-and-forget odds fetching for upcoming games - Prevents 30-second timeout when processing many upcoming games Also fixed permission issue on devpi: - Changed /var/cache/ledmatrix/display_on_demand_state.json permissions from 600 to 660 to allow web service (devpi user) to read the file * fix(cache): Ensure cache files use 660 permissions for group access - Updated setup_cache.sh to set file permissions to 660 (not 775) - Updated first_time_install.sh to properly set cache file permissions - Modified DiskCache to set 660 permissions when creating cache files - Ensures display_on_demand_state.json and other cache files are readable by web service (devpi user) which is in ledmatrix group This fixes permission issues where cache files were created with 600 permissions, preventing the web service from reading them. Now files are created with 660 (rw-rw----) allowing group read access. * fix(soccer-scoreboard): Update submodule with manifest fix - Updated soccer-scoreboard plugin submodule - Added missing entry_point and class_name to manifest.json - Fixes plugin loading error: 'No class_name in manifest' Also fixed cache file permissions on devpi server: - Changed display_on_demand_state.json from 600 to 660 permissions - Allows web service (devpi user) to read cache files * fix(display): Remove update_display() calls from clear() to prevent black flash Previously, display_manager.clear() was calling update_display() twice, which immediately showed a black screen on the hardware before new content could be drawn. This caused visible black flashes when switching between modes, especially when plugins switch from general modes (e.g., football_upcoming) to specific sub-modes (e.g., nfl_upcoming). Now clear() only prepares the buffer without updating the hardware. Callers can decide when to update the display, allowing smooth transitions from clear → draw → update_display() without intermediate black flashes. Places that intentionally show a cleared screen (error cases) already explicitly call update_display() after clear(), so backward compatibility is maintained. * fix(scroll): Prevent wrap-around before cycle completion in dynamic duration - Check scroll completion BEFORE allowing wrap-around - Clamp scroll_position when complete to prevent visual loop - Only wrap-around if cycle is not complete yet - Fixes issue where stocks plugin showed first stock again at end - Completion logged only once to avoid spam - Ensures smooth transition to next mode without visual repeat * fix(on-demand): Ensure on-demand buttons work and display service runs correctly - Add early stub functions for on-demand modal to ensure availability when Alpine.js initializes - Increase on-demand request cache max_age from 5min to 1hr to prevent premature expiration - Fixes issue where on-demand buttons were not functional due to timing issues - Ensures display service properly picks up on-demand requests when started * test: Add comprehensive test coverage (30%+) - Add 100+ new tests across core components - Add tests for LayoutManager (27 tests) - Add tests for PluginLoader (14 tests) - Add tests for SchemaManager (20 tests) - Add tests for MemoryCache and DiskCache (24 tests) - Add tests for TextHelper (9 tests) - Expand error handling tests (7 new tests) - Improve coverage from 25.63% to 30.26% - All 237 tests passing Test files added: - test/test_layout_manager.py - test/test_plugin_loader.py - test/test_schema_manager.py - test/test_text_helper.py - test/test_config_service.py - test/test_display_controller.py - test/test_display_manager.py - test/test_error_handling.py - test/test_font_manager.py - test/test_plugin_system.py Updated: - pytest.ini: Enable coverage reporting with 30% threshold - test/conftest.py: Enhanced fixtures for better test isolation - test/test_cache_manager.py: Expanded cache component tests - test/test_config_manager.py: Additional config tests Documentation: - HOW_TO_RUN_TESTS.md: Guide for running and understanding tests * test(web): Add comprehensive API endpoint tests - Add 30 new tests for Flask API endpoints in test/test_web_api.py - Cover config, system, display, plugins, fonts, and error handling APIs - Increase test coverage from 30.26% to 30.87% - All 267 tests passing Tests cover: - Config API: GET/POST main config, schedule, secrets - System API: Status, version, system actions - Display API: Current display, on-demand start/stop - Plugins API: Installed plugins, health, config, operations, state - Fonts API: Catalog, tokens, overrides - Error handling: Invalid JSON, missing fields, 404s * test(plugins): Add comprehensive integration tests for all plugins - Add base test class for plugin integration tests - Create integration tests for all 6 plugins: - basketball-scoreboard (11 tests) - calendar (10 tests) - clock-simple (11 tests) - odds-ticker (9 tests) - soccer-scoreboard (11 tests) - text-display (12 tests) - Total: 64 new plugin integration tests - Increase test coverage from 30.87% to 33.38% - All 331 tests passing Tests verify: - Plugin loading and instantiation - Required methods (update, display) - Manifest validation - Display modes - Config schema validation - Graceful handling of missing API credentials Uses hybrid approach: integration tests in main repo, plugin-specific unit tests remain in plugin submodules. * Add mqtt-notifications plugin as submodule * fix(sports): Respect games_to_show settings for favorite teams - Fix upcoming games to show N games per team (not just 1) - Fix recent games to show N games per team (not just 1) - Add duplicate removal for games involving multiple favorite teams - Match behavior of basketball-scoreboard plugin - Affects NFL, NHL, and other sports using base_classes/sports.py * chore: Remove debug instrumentation logs - Remove temporary debug logging added during fix verification - Fix confirmed working by user * debug: Add instrumentation to debug configuration header visibility issue * fix: Resolve nested section content sliding under next header - Remove overflow-hidden from nested-section to allow proper document flow - Add proper z-index and positioning to prevent overlap - Add margin-top to nested sections for better spacing - Remove debug instrumentation that was causing ERR_BLOCKED_BY_CLIENT errors * fix: Prevent unnecessary plugin tab redraws - Add check to only update tabs when plugin list actually changes - Increase debounce timeout to batch rapid changes - Compare plugin IDs before updating to avoid redundant redraws - Fix setter to check for actual changes before triggering updates * fix: Prevent form-groups from sliding out of view when nested sections expand - Increase margin-bottom on nested-sections for better spacing - Add clear: both to nested-sections to ensure proper document flow - Change overflow to visible when expanded to allow natural flow - Add margin-bottom to expanded content - Add spacing rules for form-groups that follow nested sections - Add clear spacer div after nested sections * fix: Reduce excessive debug logging in generateConfigForm - Only log once per plugin instead of on every function call - Prevents log spam when Alpine.js re-renders the form multiple times - Reduces console noise from 10+ logs per plugin to 1 log per plugin * fix: Prevent nested section content from sliding out of view when expanded - Remove overflow-hidden from nested-section in base.html (was causing clipping) - Add scrollIntoView to scroll expanded sections into view within modal - Set nested-section overflow to visible to prevent content clipping - Add min-height to nested-content to ensure proper rendering - Wait for animation to complete before scrolling into view * fix: Prevent form-groups from overlapping and appearing outside view - Change nested-section overflow to hidden by default, visible when expanded - Add :has() selector to allow overflow when content is expanded - Ensure form-groups after nested sections have proper spacing and positioning - Add clear: both and width: 100% to prevent overlap - Use !important for margin-top to ensure spacing is applied - Ensure form-groups are in normal document flow with float: none * fix: Use JavaScript to toggle overflow instead of :has() selector - :has() selector may not be supported in all browsers - Use JavaScript to set overflow: visible when expanded, hidden when collapsed - This ensures better browser compatibility while maintaining functionality * fix: Make parent sections expand when nested sections expand - Add updateParentNestedContentHeight() helper to recursively update parent heights - When a nested section expands, recalculate all parent nested-content max-heights - Ensures parent sections (like NFL) expand to accommodate expanded child sections - Updates parent heights both on expand and collapse for proper animation * refactor: Simplify parent section expansion using CSS max-height: none - Remove complex recursive parent height update function - Use CSS max-height: none when expanded to allow natural expansion - Parent sections automatically expand because nested-content has no height constraint - Simpler and more maintainable solution * refactor: Remove complex recursive parent height update function - CSS max-height: none already handles parent expansion automatically - No need for JavaScript to manually update parent heights - Much simpler and cleaner solution * debug: Add instrumentation to debug auto-collapse issue - Add logging to track toggle calls and state changes - Add guard to prevent multiple simultaneous toggles - Pass event object to prevent bubbling - Improve state detection logic - Add return false to onclick handlers * chore: Remove debug instrumentation from toggleNestedSection - Remove all debug logging code - Keep functional fixes: event handling, toggle guard, improved state detection - Code is now clean and production-ready * fix(web): Add browser refresh note to plugin fetch errors * refactor(text-display): Update submodule to use ScrollHelper * fix(text-display): Fix scrolling display issue - update position in display() * feat(text-display): Add scroll_loop option and improve scroll speed control * debug: Add instrumentation to track plugin enabled state changes Added debug logging to investigate why plugins appear to disable themselves: - Track enabled state during plugin load (before/after schema merge) - Track enabled state during plugin reload - Track enabled state preservation during config save - Track state reconciliation fixes - Track enabled state updates in on_config_change This will help identify which code path is causing plugins to disable. * debug: Fix debug log path to work on Pi Changed hardcoded log path to use dynamic project root detection: - Uses LEDMATRIX_ROOT env var if set - Falls back to detecting project root by looking for config directory - Creates .cursor directory if it doesn't exist - Falls back to /tmp/ledmatrix_debug.log if all else fails - Added better error handling with logger fallback * Remove debug instrumentation for plugin enabled state tracking Removed all debug logging that was added to track plugin enabled state changes. The instrumentation has been removed as requested. * Reorganize documentation and cleanup test files - Move documentation files to docs/ directory - Remove obsolete test files - Update .gitignore and README * feat(text-display): Switch to frame-based scrolling with high FPS support * fix(text-display): Add backward compatibility for ScrollHelper sub-pixel scrolling * feat(scroll_helper): Add sub-pixel scrolling support for smooth movement - Add sub-pixel interpolation using scipy (if available) or numpy fallback - Add set_sub_pixel_scrolling() method to enable/disable feature - Implement _get_visible_portion_subpixel() for fractional pixel positioning - Implement _interpolate_subpixel() for linear interpolation - Prevents pixel skipping at slow scroll speeds - Maintains backward compatibility with integer pixel path * fix(scroll_helper): Reset last_update_time in reset_scroll() to prevent jump-ahead - Reset last_update_time when resetting scroll position - Prevents large delta_time on next update after reset - Fixes issue where scroll would immediately complete again after reset - Ensures smooth scrolling continuation after loop reset * fix(scroll_helper): Fix numpy broadcasting error in sub-pixel interpolation - Add output_width parameter to _interpolate_subpixel() for variable widths - Fix wrap-around case to use correct widths for interpolation - Handle edge cases where source array is smaller than expected - Prevent 'could not broadcast input array' errors in sub-pixel scrolling - Ensure proper width matching in all interpolation paths * feat(scroll): Add frame-based scrolling mode for smooth LED matrix movement - Add frame_based_scrolling flag to ScrollHelper - When enabled, moves fixed pixels per step, throttled by scroll_delay - Eliminates time-based jitter by ignoring frame timing variations - Provides stock-ticker-like smooth, predictable scrolling - Update text-display plugin to use frame-based mode This addresses stuttering issues where time-based scrolling caused visual jitter due to frame timing variations in the main display loop. * fix(scroll): Fix NumPy broadcasting errors in sub-pixel wrap-around - Ensure _interpolate_subpixel always returns exactly requested width - Handle cases where scipy.ndimage.shift produces smaller arrays - Add padding logic for wrap-around cases when arrays are smaller than expected - Prevents 'could not broadcast input array' errors during scrolling * refactor(scroll): Remove sub-pixel interpolation, use high FPS integer scrolling - Disable sub-pixel scrolling by default in ScrollHelper - Simplify get_visible_portion to always use integer pixel positioning - Restore frame-based scrolling logic for smooth high FPS movement - Use high frame rate (like stock ticker) for smoothness instead of interpolation - Reduces complexity and eliminates broadcasting errors * fix(scroll): Prevent large pixel jumps in frame-based scrolling - Initialize last_step_time properly to prevent huge initial jumps - Clamp scroll_speed to max 5 pixels/frame in frame-based mode - Prevents 60-pixel jumps when scroll_speed is misconfigured - Simplified step calculation to avoid lag catch-up jumps * fix(text-display): Align config schema and add validation - Update submodule reference - Adds warning and logging for scroll_speed config issues * fix(scroll): Simplify frame-based scrolling to match stock ticker behavior - Remove throttling logic from frame-based scrolling - Move pixels every call (DisplayController's loop timing controls rate) - Add enable_scrolling attribute to text-display plugin for high-FPS treatment - Matches stock ticker: simple, predictable movement every frame - Eliminates jitter from timing mismatches between DisplayController and ScrollHelper * fix(scroll): Restore scroll_delay throttling in frame-based mode - Restore time-based throttling using scroll_delay - Move pixels only when scroll_delay has passed - Handle lag catch-up with reasonable caps to prevent huge jumps - Preserve fractional timing for smooth operation - Now scroll_delay actually controls the scroll speed as intended * feat(text-display): Add FPS counter logging - Update submodule reference - Adds FPS tracking and logging every 5 seconds * fix(text-display): Add display-width buffer so text scrolls completely off - Update submodule reference - Adds end buffer to ensure text exits viewport before looping * fix: Prevent premature game switching in SportsLive - Set last_game_switch when games load even if current_game already exists - Set last_game_switch when same games update but it's still 0 - Add guard to prevent switching check when last_game_switch is 0 - Fixes issue where first game shows for only ~2 seconds before switching - Also fixes random screen flickering when games change prematurely * feat(plugins): Add branch selection support for plugin installation - Add optional branch parameter to install_plugin() and install_from_url() in store_manager - Update API endpoints to accept and pass branch parameter - Update frontend JavaScript to support branch selection in install calls - Maintain backward compatibility - branch parameter is optional everywhere - Falls back to default branch logic if specified branch doesn't exist * feat(plugins): Add UI for branch selection in plugin installation - Add branch input field in 'Install Single Plugin' section - Add global branch input for store installations - Update JavaScript to read branch from input fields - Branch input applies to all store installations when specified * feat(plugins): Change branch selection to be per-plugin instead of global - Remove global store branch input field - Add individual branch input field to each plugin card in store - Add branch input to custom registry plugin cards - Each plugin can now have its own branch specified independently * debug: Add logging to _should_exit_dynamic * feat(display_controller): Add universal get_cycle_duration support for all plugins UNIVERSAL FEATURE: Any plugin can now implement get_cycle_duration() to dynamically calculate the total time needed to show all content for a mode. New method: - _plugin_cycle_duration(plugin, display_mode): Queries plugin for calculated duration Integration: - Display controller calls plugin.get_cycle_duration(display_mode) - Uses returned duration as target (respecting max cap) - Falls back to cap if not provided Benefits: - Football plugin: Show all games (3 games × 15s = 45s total) - Basketball plugin: Could implement same logic - Hockey/Baseball/any sport: Universal support - Stock ticker: Could calculate based on number of stocks - Weather: Could calculate based on forecast days Example plugin implementation: Result: Plugins control their own display duration based on actual content, creating a smooth user experience where all content is shown before switching. * debug: Add logging to cycle duration call * debug: Change loop exit logs to INFO level * fix: Change cycle duration logs to INFO level * fix: Don't exit loop on False for dynamic duration plugins For plugins with dynamic duration enabled, keep the display loop running even when display() returns False. This allows games to continue rotating within the calculated duration. The loop will only exit when: - Cycle is complete (plugin reports all content shown) - Max duration is reached - Mode is changed externally * fix(schedule): Improve display scheduling functionality - Add GET endpoint for schedule configuration retrieval - Fix mode switching to clean up old config keys (days/start_time/end_time) - Improve error handling with consistent error_response() usage - Enhance display controller schedule checking with better edge case handling - Add validation for time formats and ensure at least one day enabled in per-day mode - Add debug logging for schedule state changes Fixes issues where schedule mode switching left stale config causing incorrect behavior. * fix(install): Add cmake and ninja-build to system dependencies Resolves h3 package build failure during first-time installation. The h3 package (dependency of timezonefinder) requires CMake and Ninja to build from source. Adding these build tools ensures successful installation of all Python dependencies. * fix: Pass display_mode in ALL loop calls to maintain sticky manager CRITICAL FIX: Display controller was only passing display_mode on first call, causing plugins to fall back to internal mode cycling and bypass sticky manager logic. Now consistently passes display_mode=active_mode on every display() call in both high-FPS and normal loops. This ensures plugins maintain mode context and sticky manager state throughout the entire display duration. * feat(install): Add OS check for Raspberry Pi OS Lite (Trixie) - Verify OS is Raspberry Pi OS (raspbian/debian) - Require Debian 13 (Trixie) specifically - Check for Lite version (no desktop environment) - Exit with clear error message if requirements not met - Provide instructions for obtaining correct OS version * fix(web-ui): Add missing notification handlers to quick action buttons - Added hx-on:htmx:after-request handlers to all quick action buttons in overview.html - Added hx-ext='json-enc' for proper JSON encoding - Added missing notification handler for reboot button in index.html - Users will now see toast notifications when actions complete or fail * fix(display): Ensure consistent display mode handling in all plugin calls - Updated display controller to consistently pass display_mode in all plugin display() calls. - This change maintains the sticky manager state and ensures plugins retain their mode context throughout the display duration. - Addresses issues with mode cycling and improves overall display reliability. * fix(display): Enhance display mode persistence across plugin updates - Updated display controller to ensure display_mode is consistently maintained during plugin updates. - This change prevents unintended mode resets and improves the reliability of display transitions. - Addresses issues with mode persistence, ensuring a smoother user experience across all plugins. * feat: Add Olympics countdown plugin as submodule - Add olympics-countdown plugin submodule - Update .gitignore to allow olympics-countdown plugin - Plugin automatically determines next Olympics and counts down to opening/closing ceremonies * feat(web-ui): Add checkbox-group widget support for multi-select arrays - Add checkbox-group widget rendering in plugins_manager.js - Update form processing to handle checkbox groups with [] naming - Support for friendly labels via x-options in config schemas - Update odds-ticker submodule with checkbox-group implementation * fix(plugins): Preserve enabled state when saving plugin config from main config endpoint When saving plugin configuration through save_main_config endpoint, the enabled field was not preserved if missing from the form data. This caused plugins to be automatically disabled when users saved their configuration from the plugin manager tab. This fix adds the same enabled state preservation logic that exists in save_plugin_config endpoint, ensuring consistent behavior across both endpoints. The enabled state is preserved from current config, plugin instance, or defaults to True to prevent unexpected disabling of plugins. * fix(git): Resolve git status timeout and exclude plugins from base project updates - Add --untracked-files=no flag to git status for faster execution - Increase timeout from 5s to 30s for git status operations - Add timeout exception handling for git status and stash operations - Filter out plugins directory from git status checks (plugins are separate repos) - Exclude plugins from stash operations using :!plugins pathspec - Apply same fixes to plugin store manager update operations * feat(plugins): Add granular scroll speed control to odds-ticker and leaderboard plugins - Add display object to both plugins' config schemas with scroll_speed and scroll_delay - Enable frame-based scrolling mode for precise FPS control (100 FPS for leaderboard) - Add set_scroll_speed() and set_scroll_delay() methods to both plugins - Maintain backward compatibility with scroll_pixels_per_second config - Leaderboard plugin now explicitly sets target_fps to 100 for high-performance scrolling * fix(scroll): Correct dynamic duration calculation for frame-based scrolling - Fix calculate_dynamic_duration() to properly handle frame-based scrolling mode - Convert scroll_speed from pixels/frame to pixels/second when in frame-based mode - Prevents incorrect duration calculations (e.g., 2609s instead of 52s) - Affects all plugins using ScrollHelper: odds-ticker, leaderboard, stocks, text-display - Add debug logging to show scroll mode and effective speed * Remove version logic from plugin system, use git commits instead - Remove version parameter from install_plugin() method - Rename fetch_latest_versions to fetch_commit_info throughout codebase - Remove version fields from plugins.json registry (versions, latest_version, download_url_template) - Remove version logging from plugin manager - Update web UI to use fetch_commit_info parameter - Update .gitignore to ignore all plugin folders (remove whitelist exceptions) - Remove plugin directories from git index (plugins now installed via plugin store only) Plugins now always install latest commit from default branch. Version fields replaced with git commit SHA and commit dates. System uses git-based approach for all plugin metadata. * feat(plugins): Normalize all plugins as git submodules - Convert all 18 plugins to git submodules for uniform management - Add submodules for: baseball-scoreboard, christmas-countdown, football-scoreboard, hockey-scoreboard, ledmatrix-flights, ledmatrix-leaderboard, ledmatrix-music, ledmatrix-stocks, ledmatrix-weather, static-image - Re-initialize mqtt-notifications as proper submodule - Update .gitignore to allow all plugin submodules - Add normalize_plugin_submodules.sh script for future plugin management All plugins with GitHub repositories are now managed as git submodules, ensuring consistent version control and easier updates. * refactor(repository): Reorganize scripts and files into organized directory structure - Move installation scripts to scripts/install/ (except first_time_install.sh) - Move development scripts to scripts/dev/ - Move utility scripts to scripts/utils/ - Move systemd service files to systemd/ - Keep first_time_install.sh, start_display.sh, stop_display.sh in root - Update all path references in scripts, documentation, and service files - Add README.md files to new directories explaining their purpose - Remove empty tools/ directory (contents moved to scripts/dev/) - Add .gitkeep to data/ directory * fix(scripts): Fix PROJECT_DIR path in start_web_conditionally.py after move to scripts/utils/ * fix(scripts): Fix PROJECT_DIR/PROJECT_ROOT path resolution in moved scripts - Fix wifi_monitor_daemon.py to use project root instead of scripts/utils/ - Fix shell scripts in scripts/ to correctly resolve project root (go up one more level) - Fix scripts in scripts/fix_perms/ to correctly resolve project root - Update diagnose_web_interface.sh to reference moved start_web_conditionally.py path All scripts now correctly determine project root after reorganization. * fix(install): Update first_time_install.sh to detect and update service files with old paths - Check for old paths in service files and reinstall if needed - Always reinstall main service (install_service.sh is idempotent) - This ensures existing installations get updated paths after reorganization * fix(install): Update install_service.sh message to indicate it updates existing services * fix(wifi): Enable WiFi scan to work when AP mode is active - Temporarily disable AP mode during network scanning - Automatically re-enable AP mode after scan completes - Add proper error handling with try/finally to ensure AP mode restoration - Add user notification when AP mode is temporarily disabled - Improve error messages for common scanning failures - Add timing delays for interface mode switching * fix(wifi): Fix network parsing to handle frequency with 'MHz' suffix - Strip 'MHz' suffix from frequency field before float conversion - Add better error logging for parsing failures - Fixes issue where all networks were silently skipped due to ValueError * debug(wifi): Add console logging and Alpine.js reactivity fixes for network display - Add console.log statements to debug network scanning - Add x-effect to force Alpine.js reactivity updates - Add unique keys to x-for template - Add debug display showing network count - Improve error handling and user feedback * fix(wifi): Manually update select options instead of using Alpine.js x-for - Replace Alpine.js x-for template with manual DOM manipulation - Add updateSelectOptions() method to directly update select dropdown - This fixes issue where networks weren't appearing in dropdown - Alpine.js x-for inside select elements can be unreliable * feat(web-ui): Add patternProperties support for dynamic key-value pairs - Add UI support for patternProperties objects (custom_feeds, feed_logo_map) - Implement key-value pair editor with add/remove functionality - Add JavaScript functions for managing dynamic key-value pairs - Update form submission to handle patternProperties JSON data - Enable easy configuration of feed_logo_map in web UI * chore: Update ledmatrix-news submodule to latest commit * fix(plugins): Handle arrays of objects in config normalization Fix configuration validation failure for static-image plugin by adding recursive normalization support for arrays of objects. The normalize_config_values function now properly handles arrays containing objects (like image_config.images) by recursively normalizing each object in the array using the items schema properties. This resolves the 'configuration validation failed' error when saving static image plugin configuration with multiple images. * fix(plugins): Handle union types in config normalization and form generation Fix configuration validation for fields with union types like ['integer', 'null']. The normalization function now properly handles: - Union types in top-level fields (e.g., random_seed: ['integer', 'null']) - Union types in array items - Empty string to None conversion for nullable fields - Form generation and submission for union types This resolves validation errors when saving plugin configs with nullable integer/number fields (e.g., rotation_settings.random_seed in static-image plugin). Also improves UX by: - Adding placeholder text for nullable fields explaining empty = use default - Properly handling empty values in form submission for union types * fix(plugins): Improve union type normalization with better edge case handling Enhanced normalization for union types like ['integer', 'null']: - Better handling of whitespace in string values - More robust empty string to None conversion - Fallback to None when conversion fails and null is allowed - Added debug logging for troubleshooting normalization issues - Improved handling of nested object fields with union types This should resolve remaining validation errors for nullable integer/number fields in nested objects (e.g., rotation_settings.random_seed). * chore: Add ledmatrix-news plugin to .gitignore exceptions * Fix web interface service script path in install_service.sh - Updated ExecStart path from start_web_conditionally.py to scripts/utils/start_web_conditionally.py - Updated diagnose_web_ui.sh to check for correct script path - Fixes issue where web UI service fails to start due to incorrect script path * Fix nested configuration section headers not expanding Fixed toggleNestedSection function to properly calculate scrollHeight when expanding nested configuration sections. The issue occurred when sections started with display:none - the scrollHeight was being measured before the browser had a chance to lay out the element, resulting in a value of 0. Changes: - Added setTimeout to delay scrollHeight measurement until after layout - Added overflow handling during animations to prevent content jumping - Added fallback for edge cases where scrollHeight might still be 0 - Set maxHeight to 'none' after expansion completes for natural growth - Updated function in both base.html and plugins_manager.js This fix applies to all plugins with nested configuration sections, including: - Hockey/Football/Basketball/Baseball/Soccer scoreboards (customization, global sections) - All plugins with transition, display, and other nested configuration objects Fixes configuration header expansion issues across all plugins. * Fix syntax error in first_time_install.sh step 8.5 Added missing 'fi' statement to close the if block in the WiFi monitor service installation section. This resolves the 'unexpected end of file' error that occurred at line 1385 during step 8.5. * Fix WiFi UI: Display correct SSID and accurate signal strength - Fix WiFi network selection dropdown not showing available networks - Replace manual DOM manipulation with Alpine.js x-for directive - Add fallback watcher to ensure select updates reactively - Fix WiFi status display showing netplan connection name instead of SSID - Query actual SSID from device properties (802-11-wireless.ssid) - Add fallback methods to get SSID from active WiFi connection list - Improve signal strength accuracy - Get signal directly from device properties (WIFI.SIGNAL) - Add multiple fallback methods for robust signal retrieval - Ensure signal percentage is accurate and up-to-date * Improve WiFi connection UI and error handling - Fix connect button disabled condition to check both selectedSSID and manualSSID - Improve error handling to display actual server error messages from 400 responses - Add step-by-step labels (Step 1, Step 2, Step 3) to clarify connection workflow - Add visual feedback showing selected network in blue highlight box - Improve password field labeling with helpful instructions - Add auto-clear logic between dropdown and manual SSID entry - Enhance backend validation with better error messages and logging - Trim SSID whitespace before processing to prevent validation errors * Add WiFi disconnect functionality for AP mode testing - Add disconnect_from_network() method to WiFiManager - Disconnects from current WiFi network using nmcli - Automatically triggers AP mode check if auto_enable_ap_mode is enabled - Returns success/error status with descriptive messages - Add /api/v3/wifi/disconnect API endpoint - POST endpoint to disconnect from current WiFi network - Includes proper error handling and logging - Add disconnect button to WiFi status section - Only visible when connected to a network - Red styling to indicate disconnection action - Shows 'Disconnecting...' state during operation - Automatically refreshes status after disconnect - Integrates with AP mode auto-enable functionality - When disconnected, automatically enables AP mode if configured - Perfect for testing captive portal and AP mode features * Add explicit handling for broken pipe errors during plugin dependency installation - Catch BrokenPipeError and OSError (errno 32) explicitly in all dependency installation methods - Add clear error messages explaining network interruption or buffer overflow causes - Improves error handling in store_manager, plugin_loader, and plugin_manager - Helps diagnose 'Errno 32 Broken Pipe' errors during pip install operations * Add WiFi permissions configuration script and integrate into first-time install - Create configure_wifi_permissions.sh script - Configures passwordless sudo for nmcli commands - Configures PolicyKit rules for NetworkManager control - Fixes 'Not Authorized to control Networking' error - Allows web interface to connect/disconnect WiFi without password prompts - Integrate WiFi permissions configuration into first_time_install.sh - Added as Step 10.1 after passwordless sudo configuration - Runs automatically during first-time installation - Ensures WiFi management works out of the box - Resolves authorization errors when connecting/disconnecting WiFi networks - NetworkManager requires both sudo and PolicyKit permissions - Script configures both automatically for seamless WiFi management * Add WiFi status LED message display integration - Integrate WiFi status messages from wifi_manager into display_controller - WiFi status messages interrupt normal rotation (but respect on-demand) - Priority: on-demand > wifi-status > live-priority > normal rotation - Safe implementation with comprehensive error handling - Automatic cleanup of expired/corrupted status files - Word-wrapping for long messages (max 2 lines) - Centered text display with small font - Non-intrusive: all errors are caught and logged, never crash controller * Fix display loop issues: reduce log spam and handle missing plugins - Change _should_exit_dynamic logging from INFO to DEBUG to reduce log spam in tight loops (every 8ms) that was causing high CPU usage - Fix display loop not running when manager_to_display is None - Add explicit check to set display_result=False when no plugin manager found - Fix logic bug where manager_to_display was overwritten after circuit breaker skip - Ensure proper mode rotation when plugins have no content or aren't found * Add debug logging to diagnose display loop stuck issue * Change debug logs to INFO level to diagnose display loop stuck * Add schedule activation logging and ensure display is blanked when inactive - Add clear INFO-level log message when schedule makes display inactive - Track previous display state to detect schedule transitions - Clear display when schedule makes it inactive to ensure blank screen (prevents showing initialization screen when schedule kicks in) - Initialize _was_display_active state tracking in __init__ * Fix indentation errors in schedule state tracking * Add rotation between hostname and IP address every 10 seconds - Added _get_local_ip() method to detect device IP address - Implemented automatic rotation between hostname and IP every 10 seconds - Enhanced logging to include both hostname and IP in initialization - Updated get_info() to expose device_ip and current_display_mode * Add WiFi connection failsafe system - Save original connection before attempting new connection - Automatically restore original connection if new connection fails - Enable AP mode as last resort if restoration fails - Enhanced connection verification with multiple attempts - Verify correct SSID (not just 'connected' status) - Better error handling and exception recovery - Prevents Pi from becoming unresponsive on connection failure - Always ensures device remains accessible via original WiFi or AP mode * feat(web): Improve web UI startup speed and fix cache permissions - Defer plugin discovery until first API request (removed from startup) - Add lazy loading to operation queue, state manager, and operation history - Defer health monitor initialization until first request - Fix cache directory permission issue: - Add systemd CacheDirectory feature for automatic cache dir creation - Add manual cache directory creation in install script as fallback - Improve cache manager logging (reduce alarming warnings) - Fix syntax errors in wifi_manager.py (unclosed try blocks) These changes significantly improve web UI startup time, especially with many plugins installed, while maintaining full backward compatibility. * feat(plugins): Improve GitHub token pop-up UX and combine warning/settings - Fix visibility toggle to handle inline styles properly - Remove redundant inline styles from HTML elements - Combine warning banner and settings panel into unified component - Add loading states to save/load token buttons - Improve error handling with better user feedback - Add token format validation (ghp_ or github_pat_ prefix) - Auto-refresh GitHub auth status after saving token - Hide warning banner when settings panel opens - Clear input field after successful save for security This creates a smoother UX flow where clicking 'Configure Token' transitions from warning directly to configuration form. * fix(wifi): Prevent WiFi radio disabling during AP mode disable - Make NetworkManager restart conditional (only for hostapd mode) - Add enhanced WiFi radio enable with retry and verification logic - Add connectivity safety check before NetworkManager restart - Ensure WiFi radio enabled after all AP mode disable operations - Fix indentation bug in dnsmasq backup restoration logic - Add pre-connection WiFi radio check for safety Fixes issue where WiFi radio was being disabled when disabling AP mode, especially when connected via Ethernet, making it impossible to enable WiFi from the web UI. * fix(plugin-templates): Fix unreachable fallback to expired cache in update() method The exception handler in update() checked the cached variable, which would always be None or falsy at that point. If fresh cached data existed, the method returned early. If cached data was expired, it was filtered out by max_age constraint. The fix retrieves cached data again in the exception handler with a very large max_age (1 year) to effectively bypass expiration check and allow fallback to expired data when fetch fails. * fix(plugin-templates): Resolve plugin_id mismatch in test template setUp method * feat(plugins): Standardize manifest version fields schema - Consolidate version fields to use consistent naming: - compatible_versions: array of semver ranges (required) - min_ledmatrix_version: string (optional) - max_ledmatrix_version: string (optional) - versions[].ledmatrix_min_version: renamed from ledmatrix_min - Add manifest schema validation (schema/manifest_schema.json) - Update store_manager to validate version fields and schema - Update template and all documentation examples to use standardized fields - Add deprecation warnings for ledmatrix_version and ledmatrix_min fields * fix(templates): Update plugin README template script path to correct location * docs(plugin): Resolve conflicting version management guidance in .cursorrules * chore(.gitignore): Consolidate plugin exclusion patterns Remove unnecessary !plugins/*/.git pattern and consolidate duplicate negations by keeping only trailing-slash directory exclusions. * docs: Add language specifiers to code blocks in STATIC_IMAGE_MULTI_UPLOAD_PLAN.md * fix(templates): Remove api_key from config.json example in plugin README template Remove api_key field from config.json example to prevent credential leakage. API keys should only be stored in config_secrets.json. Added clarifying note about proper credential storage. * docs(README): Add plugin installation and migration information - Add plugin installation instructions via web interface and GitHub URL - Add plugin migration guide for users upgrading from old managers - Improve plugin documentation for new users * docs(readme): Update donation links and add Discord acknowledgment * docs: Add comprehensive API references and consolidate documentation - Add API_REFERENCE.md with complete REST API documentation (50+ endpoints) - Add PLUGIN_API_REFERENCE.md documenting Display Manager, Cache Manager, and Plugin Manager APIs - Add ADVANCED_PLUGIN_DEVELOPMENT.md with advanced patterns and examples - Add DEVELOPER_QUICK_REFERENCE.md for quick developer reference - Consolidate plugin configuration docs into single PLUGIN_CONFIGURATION_GUIDE.md - Archive completed implementation summaries to docs/archive/ - Enhance PLUGIN_DEVELOPMENT_GUIDE.md with API links and 3rd party submission guidelines - Update docs/README.md with new API reference sections - Update root README.md with documentation links * fix(install): Fix IP detection and network diagnostics after fresh install - Fix web-ui-info plugin IP detection to handle no internet, AP mode, and network state changes - Replace socket-based detection with robust interface scanning using hostname -I and ip addr - Add AP mode detection returning 192.168.4.1 when AP mode is active - Add periodic IP refresh every 30 seconds to handle network state changes - Improve network diagnostics in first_time_install.sh showing actual IPs, WiFi status, and AP mode - Add WiFi connection check in WiFi monitor installation with warnings - Enhance web service startup logging to show accessible IP addresses - Update README with network troubleshooting section and fix port references (5001->5000) Fixes issue where display showed incorrect IP (127.0.11:5000) and users couldn't access web UI after fresh install. * chore: Add GitHub sponsor button configuration * fix(wifi): Fix aggressive AP mode enabling and improve WiFi detection Critical fixes: - Change auto_enable_ap_mode default from True to False (manual enable only) - Fixes issue where Pi would disconnect from network after code updates - Matches documented behavior (was incorrectly defaulting to True in code) Improvements: - Add grace period: require 3 consecutive disconnected checks (90s) before enabling AP mode - Prevents AP mode from enabling on transient network hiccups - Improve WiFi status detection with retry logic and better nmcli parsing - Enhanced logging for debugging WiFi connection issues - Better handling of WiFi device detection (works with any wlan device) This prevents the WiFi monitor from aggressively enabling AP mode and disconnecting the Pi from the network when there are brief network issues or during system initialization. * fix(wifi): Revert auto_enable_ap_mode default to True with grace period protection Change default back to True for auto_enable_ap_mode while keeping the grace period protection that prevents interrupting valid WiFi connections. - Default auto_enable_ap_mode back to True (useful for setup scenarios) - Grace period (3 consecutive checks = 90s) prevents false positives - Improved WiFi detection with retry logic ensures accurate status - AP mode will auto-enable when truly disconnected, but won't interrupt valid connections due to transient detection issues * fix(news): Update submodule reference for manifest fix Update ledmatrix-news submodule to include the fixed manifest.json with required entry_point and class_name fields. * fix(news): Update submodule reference with validate_config addition Update ledmatrix-news submodule to include validate_config method for proper configuration validation. * feat: Add of-the-day plugin as git submodule - Add ledmatrix-of-the-day plugin as git submodule - Rename submodule path from plugins/of-the-day to plugins/ledmatrix-of-the-day to match repository naming convention - Update .gitignore to allow ledmatrix-of-the-day submodule - Plugin includes fixes for display rendering and web UI configuration support * fix(wifi): Make AP mode open network and fix WiFi page loading in AP mode AP Mode Changes: - Remove password requirement from AP mode (open network for easier setup) - Update hostapd config to create open network (no WPA/WPA2) - Update nmcli hotspot to create open network (no password parameter) WiFi Page Loading Fixes: - Download local copies of HTMX and Alpine.js libraries - Auto-detect AP mode (192.168.4.x) and use local JS files instead of CDN - Auto-open WiFi tab when accessing via AP mode IP - Add fallback loading if HTMX fails to load - Ensures WiFi setup page works in AP mode without internet access This fixes the issue where the WiFi page wouldn't load on iPhone when accessing via AP mode (192.168.4.1:5000) because CDN resources couldn't be fetched without internet connectivity. * feat(wifi): Add explicit network switching support with clean disconnection WiFi Manager Improvements: - Explicitly disconnect from current network before connecting to a new one - Add skip_ap_check parameter to disconnect_from_network() to prevent AP mode from activating during network switches - Check if already connected to target network to avoid unnecessary work - Improved logging for network switching operations Web UI Improvements: - Detect and display network switching status in UI - Show 'Switching from [old] to [new]...' message when switching networks - Enhanced status reloading after connection (multiple checks at 2s, 5s, 10s) - Better user feedback during network transitions This ensures clean network switching without AP mode interruptions and provides clear feedback to users when changing WiFi networks. * fix(web-ui): Add fallback content loading when HTMX fails to load Problem: - After recent updates, web UI showed navigation and CPU status but main content tabs never loaded - Content tabs depend on HTMX's 'revealed' trigger to load - If HTMX failed to load or initialize, content would never appear Solutions: - Enhanced HTMX loading verification with timeout checks - Added fallback direct fetch for overview tab if HTMX fails - Added automatic tab content loading when tabs change - Added loadTabContent() method to manually trigger content loading - Added global 'htmx-load-failed' event for error handling - Automatic retry after 5 seconds if HTMX isn't available - Better error messages and console logging for debugging This ensures the web UI loads content even if HTMX has issues, providing graceful degradation and better user experience. * feat(web-ui): Add support for plugin custom HTML widgets and static file serving - Add x-widget: custom-html support in config schema generation - Add loadCustomHtmlWidget() function to load HTML from plugin directories - Add /api/v3/plugins/<plugin_id>/static/<file_path> endpoint for serving plugin static files - Enhance execute_plugin_action() to pass params via stdin as JSON for scripts - Add JSON output parsing for script action responses These changes enable plugins to provide custom UI components while keeping all functionality plugin-scoped. Used by of-the-day plugin for file management. * fix(web-ui): Resolve Alpine.js initialization errors - Prevent Alpine.js from auto-initializing before app() function is defined - Add deferLoadingAlpine to ensure proper initialization order - Make app() function globally available via window.app - Fix 'app is not defined' and 'activeTab is not defined' errors - Remove duplicate Alpine.start() calls that caused double initialization warnings * fix(web-ui): Fix IndentationError in api_v3.py OAuth flow - Fix indentation in if action_def.get('oauth_flow') block - Properly indent try/except block and all nested code - Resolves IndentationError that prevented web interface from starting * fix(web-ui): Fix SyntaxError in api_v3.py else block - Fix indentation of OAuth flow code inside else block - Properly indent else block for simple script execution - Resolves SyntaxError at line 3458 that prevented web interface from starting * fix(web-ui): Restructure OAuth flow check to fix SyntaxError - Move OAuth flow check before script execution in else block - Remove unreachable code that was causing syntax error - OAuth check now happens first, then falls back to script execution - Resolves SyntaxError at line 3458 * fix(web-ui): Define app() function in head for Alpine.js initialization - Define minimal app() function in head before Alpine.js loads - Ensures app() is available when Alpine initializes - Full implementation in body enhances/replaces the stub - Fixes 'app is not defined' and 'activeTab is not defined' errors * fix(web-ui): Ensure plugin tabs load when full app() implementation is available - Update stub init() to detect and use full implementation when available - Ensure full implementation properly replaces stub methods - Call init() after merging to load plugins and set up watchers - Fixes issue where installed plugins weren't showing in navigation bar * fix(web-ui): Prevent 'Cannot redefine property' error for installedPlugins - Check if window.installedPlugins property already exists before defining - Make property configurable to allow redefinition if needed - Add _initialized flag to prevent multiple init() calls - Fixes TypeError when stub tries to enhance with full implementation * fix(web-ui): Fix variable redeclaration errors in logs tab - Replace let/const declarations with window properties to avoid redeclaration - Use window._logsEventSource, window._allLogs, etc. to persist across HTMX reloads - Clean up existing event source before reinitializing - Remove and re-add event listeners to prevent duplicates - Fixes 'Identifier has already been declared' error when accessing logs tab multiple times * feat(web-ui): Add support for additionalProperties object rendering - Add handler for objects with additionalProperties containing object schemas - Render dynamic category controls with enable/disable toggles - Display category metadata (display name, data file path) - Used by of-the-day plugin for category management * fix(wifi): Ensure AP mode hotspot is always open (no password) Problem: - LEDMatrix-Setup WiFi AP was still asking for password despite code changes - Existing hotspot connections with passwords weren't being fully cleaned up - NetworkManager might reuse old connection profiles with passwords Solutions: - More thorough cleanup: Delete all hotspot-related connections, not just known names - Verification: Check if hotspot has password after creation - Automatic fix: Remove password and restart connection if security is detected - Better logging: Log when password is detected and removed This ensures the AP mode hotspot is always open for easy setup access, even if there were previously saved connections with passwords. * fix(wifi): Improve network switching reliability and device state handling Problem: - Pi failing to switch WiFi networks via web UI - Connection attempts happening before device is ready - Disconnect not fully completing before new connection attempt - Connection name lookup issues when SSID doesn't match connection name Solutions: - Improved disconnect logic: Disconnect specific connection first, then device - Device state verification: Wait for device to be ready (disconnected/unavailable) before connecting - Better connection lookup: Search by SSID, not just connection name - Increased wait times: 2 seconds for disconnect to complete - State checking before activating existing connections - Enhanced error handling and logging throughout This ensures network switching works reliably by properly managing device state transitions and using correct connection identifiers. * debug(web-ui): Add debug logging for custom HTML widget loading - Add console logging to track widget generation - Improve error messages with missing configuration details - Help diagnose why file manager widget may not be appearing * fix(web-ui): Fix [object Object] display in categories field - Add type checking to ensure category values are strings before rendering - Safely extract data_file and display_name properties - Prevent object coercion issues in category display * perf(web-ui): Optimize plugin loading in navigation bar - Reduce stub init timeout from 100ms to 10ms for faster enhancement - Change full implementation merge from 50ms setTimeout to requestAnimationFrame - Add direct plugin loading in stub while waiting for full implementation - Skip plugin reload in full implementation if already loaded by stub - Significantly improves plugin tab loading speed in navigation bar * feat(web-ui): Adapt file-upload widget for JSON files in of-the-day plugin - Add specialized JSON upload/delete endpoints for of-the-day plugin - Modify file-upload widget to support JSON files (file_type: json) - Render JSON files with file-code icon instead of image preview - Show entry count for JSON files - Store files in plugins/ledmatrix-of-the-day/of_the_day/ directory - Automatically update categories config when files are uploaded/deleted - Populate uploaded_files array from categories on form load - Remove custom HTML widget, use standard file-upload widget instead * fix(web-ui): Add working updatePluginTabs to stub for immediate plugin tab rendering - Stub's updatePluginTabs was empty, preventing tabs from showing - Add basic implementation that creates plugin tabs in navigation bar - Ensures plugin tabs appear immediately when plugins load, even before full implementation merges - Fixes issue where plugin navigation bar wasn't working * feat(api): Populate uploaded_files and categories from disk for of-the-day plugin - Scan of_the_day directory for existing JSON files when loading config - Populate uploaded_files array from files on disk - Populate categories from files on disk if not in config - Categories default to disabled, user can enable them - Ensures existing JSON files (word_of_the_day.json, slovenian_word_of_the_day.json) appear in UI * fix(api): Improve category merging logic for of-the-day plugin - Preserve existing category enabled state when merging with files from disk - Ensure all JSON files from disk appear in categories section - Categories from files default to disabled, preserving user choices - Properly merge existing config with scanned files * fix(wifi): More aggressive password removal for AP mode hotspot Problem: - LEDMatrix-Setup network still asking for password despite previous fixes - NetworkManager may add default security settings to hotspots - Existing connections with passwords may not be fully cleaned up Solutions: - Always remove ALL security settings after creating hotspot (not just when detected) - Remove multiple security settings: key-mgmt, psk, wep-key, auth-alg - Verify security was removed and recreate connection if verification fails - Improved cleanup: Delete connections by SSID match, not just by name - Disconnect connections before deleting them - Always restart connection after removing security to apply changes - Better logging for debugging This ensures the AP mode hotspot is always open, even if NetworkManager tries to add default security settings. * perf(web): Optimize web interface performance and fix JavaScript errors - Add resource hints (preconnect, dns-prefetch) for CDN resources to reduce DNS lookup delays - Fix duplicate response parsing bug in loadPluginConfig that was parsing JSON twice - Replace direct fetch() calls with PluginAPI.getInstalledPlugins() to leverage caching and throttling - Fix Alpine.js function availability issues with defensive checks and $nextTick - Enhance request deduplication with debug logging and statistics - Add response caching headers for static assets and API responses - Add performance monitoring utilities with detailed metrics Fixes console errors for loadPluginConfig and generateConfigForm not being defined. Reduces duplicate API calls to /api/v3/plugins/installed endpoint. Improves initial page load time with resource hints and optimized JavaScript loading. * perf(web-ui): optimize CSS for Raspberry Pi performance - Remove backdrop-filter blur from modal-backdrop - Remove box-shadow transitions (use transform/opacity only) - Remove button ::before pseudo-element animation - Simplify skeleton loader (gradient to opacity pulse) - Optimize transition utility (specific properties, not 'all') - Improve color contrast for WCAG AA compliance - Add CSS containment to cards, plugin-cards, modals - Remove unused CSS classes (duration-300, divider, divider-light) - Remove duplicate spacing utility classes All animations now GPU-accelerated (transform/opacity only). Optimized for low-powered Raspberry Pi devices. * fix(web): Resolve ReferenceError for getInstalledPluginsSafe in v3 stub initialization Move getInstalledPluginsSafe() function definition before the app() stub code that uses it. The function was previously defined at line 3756 but was being called at line 849 during Alpine.js initialization, causing a ReferenceError when loadInstalledPluginsDirectly() attempted to load plugins before the full implementation was ready. * fix(web): Resolve TypeError for installedPlugins.map in plugin loading Fix PluginAPI.getInstalledPlugins() to properly extract plugins array from API response structure. The API returns {status: 'success', data: {plugins: [...]}}, but the method was returning response.data (the object) instead of response.data.plugins (the array). Changes: - api_client.js: Extract plugins array from response.data.plugins - plugins_manager.js: Add defensive array checks and handle array return value correctly - base.html: Add defensive check in getInstalledPluginsSafe() to ensure plugins is always an array This prevents 'installedPlugins.map is not a function' errors when loading plugins. * style(web-ui): Enhance navigation bar styling for better readability - Improve contrast: Change inactive tab text from gray-500 to gray-700 - Add gradient background and thicker border for active tabs - Enhance hover states with background highlights - Add smooth transitions using GPU-accelerated properties - Update all navigation buttons (system tabs and plugin tabs) - Add updatePluginTabStates() method for dynamic tab state management All changes are CSS-only with zero performance overhead. * fix(web-ui): Optimize plugin loading and reduce initialization errors - Make generateConfigForm accessible to inline Alpine components via parent scope - Consolidate plugin initialization to prevent duplicate API calls - Fix script execution from HTMX-loaded content by extracting scripts before DOM insertion - Add request deduplication to loadInstalledPlugins() to prevent concurrent requests - Improve Alpine component initialization with proper guards and fallbacks This eliminates 'generateConfigForm is not defined' errors and reduces plugin API calls from 3-4 duplicate calls to 1 per page load, significantly improving page load performance. * fix(web-ui): Add guard check for generateConfigForm to prevent Alpine errors Add typeof check in x-show to prevent Alpine from evaluating generateConfigForm before the component methods are fully initialized. This eliminates the 'generateConfigForm is not defined' error that was occurring during component initialization. * fix(web-ui): Fix try-catch block structure in script execution code Correct the nesting of try-catch block inside the if statement for script execution. The catch block was incorrectly placed after the else clause, causing a syntax error. * fix(web-ui): Escape quotes in querySelector to avoid HTML attribute conflicts Change double quotes to single quotes in the CSS selector to prevent conflicts with HTML attribute parsing when the x-data expression is embedded. * style(web): Improve button text readability in Quick Actions section * fix(web): Resolve Alpine.js expression errors in plugin configuration component - Capture plugin from parent scope into component data to fix parsing errors - Update all plugin references to use this.plugin in component methods - Fix x-init to properly call loadPluginConfig method - Resolves 'Uncaught ReferenceError' for isOnDemandLoading, onDemandLastUpdated, and other component properties * fix(web): Fix remaining Alpine.js scope issues in plugin configuration - Use this.generateConfigForm in typeof checks and method calls - Fix form submission to use this.plugin.id - Use $root. prefix for parent scope function calls (refreshPlugin, updatePlugin, etc.) - Fix confirm dialog string interpolation - Ensures all component methods and properties are properly scoped * fix(web): Add this. prefix to all Alpine.js component property references - Fix all template expressions to use this. prefix for component properties - Update isOnDemandLoading, onDemandLastUpdated, onDemandRefreshing references - Update onDemandStatusClass, onDemandStatusText, onDemandServiceClass, onDemandServiceText - Update disableRunButton, canStopOnDemand, showEnableHint, loading references - Ensures Alpine.js can properly resolve all component getters and properties * fix(web): Resolve Alpine.js expression errors in plugin configuration - Move complex x-data object to pluginConfigData() function for better parsing - Fix all template expressions to use this.plugin instead of plugin - Add this. prefix to all method calls in event handlers - Fix duplicate x-on:click attribute on uninstall button - Add proper loading state management in loadPluginConfig method This resolves the 'Invalid or unexpected token' and 'Uncaught ReferenceError' errors in the browser console. * fix(web): Fix plugin undefined errors in Alpine.js plugin configuration - Change x-data initialization to capture plugin from loop scope first - Use Object.assign in x-init to merge pluginConfigData properties - Add safety check in pluginConfigData function for undefined plugins - Ensure plugin is available before accessing properties in expressions This resolves the 'Cannot read properties of undefined' errors by ensuring the plugin object is properly captured from the x-for loop scope before any template expressions try to access it. * style(web): Make Quick Actions button text styling consistent - Update Start Display, Stop Display, and Reboot System buttons - Change from text-sm font-medium to text-base font-semibold - All Quick Actions buttons now have consistent bold, larger text - Matches the styling of Update Code, Restart Display Service, and Restart Web Service buttons * fix(wifi): Properly handle AP mode disable during WiFi connection - Check return value of disable_ap_mode() before proceeding with connection - Add verification loop to ensure AP mode is actually disabled - Increase wait time to 5 seconds for NetworkManager restart stabilization - Return clear error messages if AP mode cannot be disabled - Prevents connection failures when switching networks from web UI or AP mode This fixes the issue where WiFi network switching would fail silently when AP mode disable failed, leaving the system in an inconsistent state. * fix(web): Handle API response errors in plugin configuration loading - Add null/undefined checks before accessing API response status - Set fallback defaults when API responses don't have status 'success' - Add error handling for batch API requests with fallback to individual requests - Add .catch() handlers to individual fetch calls to prevent unhandled rejections - Add console warnings to help debug API response failures - Fix applies to both main loadPluginConfig and PluginConfigHelpers.loadPluginConfig This fixes the issue where plugin configuration sections would get stuck showing the loading animation when API responses failed or returned error status. * fix(web): Fix Alpine.js reactivity for plugin config by using direct x-data Changed from Object.assign pattern to direct x-data assignment to ensure Alpine.js properly tracks reactive properties. The previous approach used Object.assign to merge properties into the component after initialization, which caused Alpine to not detect changes to config/schema properties. The fix uses pluginConfigData(plugin) directly as x-data, ensuring all properties including config, schema, loading, etc. are reactive from component initialization. * fix(web): Ensure plugin variable is captured in x-data scope Use spread operator to merge pluginConfigData properties while explicitly capturing the plugin variable from outer x-for scope. This fixes undefined plugin errors when Alpine evaluates the component data. * fix(web): Use $data for Alpine.js reactivity when merging plugin config Use Object.assign with Alpine's $data reactive proxy instead of this to ensure added properties are properly reactive. This fixes the issue where plugin variable scoping from x-for wasn't accessible in x-data expressions. * fix(web): Remove incorrect 'this.' prefix in Alpine.js template expressions Alpine.js template expressions (x-show, x-html, x-text, x-on) use the component data as the implicit context, so 'this.' prefix is incorrect. In template expressions, 'this' refers to the DOM element, not the component data. Changes: - Replace 'this.plugin.' with 'plugin.' in all template expressions (19 instances) - Replace 'this.loading' with 'loading' in x-show directives - Replace 'this.generateConfigForm' with 'generateConfigForm' in x-show/x-html - Replace 'this.savePluginConfig' with 'savePluginConfig' in x-on:submit - Replace 'this.config/schema/webUiActions' with direct property access - Use '$data.loadPluginConfig' in x-init for explicit method call Note: 'this.' is still correct inside JavaScript method definitions within pluginConfigData() function since those run with proper object context. * fix(web): Prevent infinite recursion in plugin config methods Add 'parent !== this' check to loadPluginConfig, generateConfigForm, and savePluginConfig methods in pluginConfigData to prevent infinite recursion when the component tries to delegate to a parent that resolves to itself. This fixes the 'Maximum call stack size exceeded' error that occurred when the nested Alpine component's $root reference resolved to a component that had the same delegating methods via Object.assign. * fix(web): Resolve infinite recursion in plugin config by calling $root directly The previous implementation had delegating methods (generateConfigForm, savePluginConfig) in pluginConfigData that tried to call parent.method(), but the parent detection via getParentApp() was causing circular calls because multiple components had the same methods. Changes: - Template now calls $root.generateConfigForm() and $root.savePluginConfig() directly instead of going through nested component delegation - Removed delegating generateConfigForm and savePluginConfig from pluginConfigData - Removed getParentApp() helper that was enabling the circular calls - Simplified loadPluginConfig to use PluginConfigHelpers directly This fixes the 'Maximum call stack size exceeded' error when rendering plugin configuration forms. * fix(web): Use window.PluginConfigHelpers instead of $root for plugin config The $root magic variable in Alpine.js doesn't correctly reference the app() component's data scope from nested x-data contexts. This causes generateConfigForm and savePluginConfig to be undefined. Changed to use window.PluginConfigHelpers which has explicit logic to find and use the app component's methods. * fix(web): Use direct x-data initialization for plugin config reactivity Changed from Object.assign($data, pluginConfigData(plugin)) to x-data="pluginConfigData(plugin)" to ensure Alpine.js properly tracks reactivity for all plugin config properties. This fixes the issue where all plugin tabs were showing the same config. * refactor(web): Implement server-side plugin config rendering with HTMX Major architectural improvement to plugin configuration management: - Add server-side Jinja2 template for plugin config forms (web_interface/templates/v3/partials/plugin_config.html) - Add Flask route to serve plugin config partials on-demand - Replace complex client-side form generation with HTMX lazy loading - Add Alpine.js store for centralized plugin state management - Mark old pluginConfigData and PluginConfigHelpers as deprecated Benefits: - Lazy loading: configs only load when tab is accessed - Server-side rendering: reduces client-side complexity - Better performance: especially on Raspberry Pi - Cleaner code: Jinja2 macros replace JS string templates - More maintainable: form logic in one place (server) The old client-side code is preserved for backwards compatibility but is no longer used by the main plugin configuration UI. * fix(web): Trigger HTMX manually after Alpine renders plugin tabs HTMX processes attributes at page load time, before Alpine.js renders dynamic content. Changed from :hx-get attribute to x-init with htmx.ajax() to properly trigger the request after the element is rendered. * fix(web): Remove duplicate 'enabled' toggle from plugin config form The 'enabled' field was appearing twice in plugin configuration: 1. Header toggle (quick action, uses HTMX) 2. Configuration form (from schema, requires save) Now only the header toggle is shown, avoiding user confusion. The 'enabled' key is explicitly skipped when rendering schema properties. * perf(web): Optimize plugin manager with request caching and init guards Major performance improvements to plugins_manager.js: 1. Request Deduplication & Caching - Added pluginLoadCache with 3-second TTL - Subsequent calls return cached data instead of making API requests - In-flight request deduplication prevents parallel duplicate fetches - Added refreshInstalledPlugins() for explicit force-refresh 2. Initialization Guards - Added pluginsInitialized flag to prevent multiple initializePlugins() calls - Added _eventDelegationSetup guard on container to prevent duplicate listeners - Added _listenerSetup guards on search/category inputs 3. Debug Logging Control - Added PLUGIN_DEBUG flag (localStorage.setItem('pluginDebug', 'true')) - Most console.log calls now use pluginLog() which only logs when debug enabled - Reduces console noise from ~150 logs to ~10 in production Expected improvements: - API calls reduced from 6+ to 2 on page load - Event listeners no longer duplicated - Cleaner console output - Faster perceived performance * fix(web): Handle missing search elements in searchPluginStore The searchPluginStore function was failing silently when called before the plugin-search and plugin-category elements existed in the DOM. This caused the plugin store to never load. Now safely checks if elements exist before accessing their values. * fix(web): Ensure plugin store loads via pluginManager.searchPluginStore - Exposed searchPluginStore on window.pluginManager for easier access - Updated base.html to fallback to pluginManager.searchPluginStore - Added logging when loading plugin store * fix(web): Expose searchPluginStore from inside the IIFE The function was defined inside the IIFE but only exposed after the IIFE ended, where the function was out of scope. Now exposed immediately after definition inside the IIFE. * fix(web): Add cache-busting version to plugins_manager.js URL Static JS files were being aggressively cached, preventing updates from being loaded by browsers. * fix(web): Fix pluginLog reference error outside IIFE pluginLog is defined inside the IIFE, so use _PLUGIN_DEBUG_EARLY and console.log directly for code outside the IIFE. * chore(web): Update plugins_manager.js cache version * fix(web): Defer plugin store render when grid not ready Instead of showing an error when plugin-store-grid doesn't exist, store plugins in window.__pendingStorePlugins for later rendering when the tab loads (consistent with how installed plugins work). * chore: Bump JS cache version * fix(web): Restore enabledBool variable in plugin render Variable was removed during debug logging optimization but was still being used in the template string for toggle switch rendering. * fix(ui): Add header and improve categories section rendering - Add proper header (h4) to categories section with label - Add debug logging to diagnose categories field rendering - Improve additionalProperties condition check readability * fix(ui): Improve additionalProperties condition check - Explicitly exclude objects with properties to avoid conflicts - Ensure categories section is properly detected and rendered - Categories should show as header with toggles, not text box * fix(web-ui): Fix JSON parsing errors and default value loading for plugin configs - Fix JSON parsing errors when saving file upload fields by properly unescaping HTML entities - Merge config with schema defaults when loading plugin config so form shows default values - Improve default value handling in form generation for nested objects and arrays - Add better error handling for malformed JSON in file upload fields * fix(plugins): Return plugins array from getInstalledPlugins() instead of data object Fixed PluginAPI.getInstalledPlugins() to return response.data.plugins (array) instead of response.data (object). This was preventing window.installedPlugins from being set correctly, which caused plugin configuration tabs to not appear and prevented users from saving plugin configurations via the web UI. The fix ensures that: - window.installedPlugins is properly populated with plugin array - Plugin tabs are created automatically on page load - Configuration forms and save buttons are rendered correctly - Save functionality works as expected * fix(api): Support form data submission for plugin config saves The HTMX form submissions use application/x-www-form-urlencoded format instead of JSON. This update allows the /api/v3/plugins/config POST endpoint to accept both formats: - JSON: plugin_id and config in request body (existing behavior) - Form data: plugin_id from query string, config fields from form Added _parse_form_value helper to properly convert form strings to appropriate Python types (bool, int, float, JSON arrays/objects). * debug: Add form data logging to diagnose config save issue * fix(web): Re-discover plugins before loading config partial The plugin config partial was returning 'not found' for plugins because the plugin manifests weren't loaded. The installed plugins API was working because it calls discover_plugins() first. Changes: - Add discover_plugins() call in _load_plugin_config_partial when plugin info is not found on first try - Remove debug logging from form data handling * fix(web): Comprehensive plugin config save improvements SWEEPING FIX for plugin configuration saving issues: 1. Form data now MERGES with existing config instead of replacing - Partial form submissions (missing fields) no longer wipe out existing config values - Fixes plugins with complex schemas (football, clock, etc.) 2. Improved nested value handling with _set_nested_value helper - Correctly handles deeply nested structures like customization - Properly merges when intermediate objects already exist 3. Better JSON parsing for arrays - RGB color arrays like [255, 0, 0] now parse correctly - Parse JSON before trying number conversion 4. Bump cache version to force JS reload * fix(web): Add early stubs for updatePlugin and uninstallPlugin Ensures these functions are available immediately when the page loads, even before the full IIFE executes. Provides immediate user feedback and makes API calls directly. This fixes the 'Update button does not work' issue by ensuring the function is always defined and callable. * fix(web): Support form data in toggle endpoint The toggle endpoint now accepts both JSON and HTMX form submissions. Also updated the plugin config template to send the enabled state via hx-vals when the checkbox changes. Fixes: 415 Unsupported Media Type error when toggling plugins * fix(web): Prevent config duplication when toggling plugins Changed handleToggleResponse to update UI in place instead of refreshing the entire config partial, which was causing duplication. Also improved refreshPluginConfig with proper container targeting and concurrent refresh prevention (though it's no longer needed for toggles since we update in place). * fix(api): Schema-aware form value parsing for plugin configs Major fix for plugin config saving issues: 1. Load schema BEFORE processing form data to enable type-aware parsing 2. New _parse_form_value_with_schema() function that: - Converts comma-separated strings to arrays when schema says 'array' - Parses JSON strings for arrays/objects - Handles empty strings for arrays (returns [] instead of None) - Uses schema to determine correct number types 3. Post-processing to ensure None arrays get converted to empty arrays 4. Proper handling of nested object fields Fixes validation errors: - 'category_order': Expected type array, got str - 'categories': Expected type object, got str - 'uploaded_files': Expected type array, got NoneType - RGB color arrays: Expected type array, got str * fix(web): Make plugin config handlers idempotent and remove scripts from HTMX partials CRITICAL FIX for script redeclaration errors: 1. Removed all <script> tags from plugin_config.html partial - Scripts were being re-executed on every HTMX swap - Caused 'Identifier already declared' errors 2. Moved all handler functions to base.html with idempotent initialization - Added window.__pluginConfigHandlersInitialized guard - Functions only initialized once, even if script runs multiple times - All state stored on window object (e.g., window.pluginConfigRefreshInProgress) 3. Enhanced error logging: - Client-side: Logs form payload, response status, and parsed error details - Server-side: Logs raw form data and parsed config on validation failures 4. Functions moved to window scope: - toggleSection - handleConfigSave (with detailed error logging) - handleToggleResponse (updates UI in place, no refresh) - handlePluginUpdate - refreshPluginConfig (with duplicate prevention) - runPluginOnDemand - stopOnDemand - executePluginAction This ensures HTMX-swapped fragments only contain HTML, and all scripts run once in the base layout. * fix(api): Filter config to only schema-defined fields before validation When merging with existing_config, fields not in the plugin's schema (like high_performance_transitions, transition, dynamic_duration) were being preserved, causing validation failures when additionalProperties is false. Add _filter_config_by_schema() function to recursively filter config to only include fields defined in the schema before validation. This fixes validation errors like: - 'Additional properties are not allowed (high_performance_transitions, transition were unexpected)' * fix(web): Improve update plugin error handling and support form data 1. Enhanced updatePlugin JavaScript function: - Validates pluginId before sending request - Checks response.ok before parsing JSON - Better error logging with request/response details - Handles both successful and error responses properly 2. Update endpoint now supports both JSON and form data: - Similar to config endpoint, accepts plugin_id from query string or form - Better error messages and debug logging 3. Prevent duplicate function definitions: - Second updatePlugin definition checks if improved version exists - Both definitions now have consistent error handling Fixes: 400 BAD REQUEST 'Request body must be valid JSON' error * fix(web): Show correct 'update' message instead of 'save' for plugin updates The handlePluginUpdate function now: 1. Checks actual HTTP status code (not just event.detail.successful) 2. Parses JSON response to get server's actual message 3. Replaces 'save' with 'update' if message incorrectly says 'save' Fixes: Update button showing 'saved successfully' instead of 'updated successfully' * fix(web): Execute plugin updates immediately instead of queuing Plugin updates are now executed directly (synchronously) instead of being queued for async processing. This provides immediate feedback to users about whether the update succeeded or failed. Updates are fast git pull operations, so they don't need async processing. The operation queue is reserved for longer operations like install/uninstall. Fixes: Update button not actually updating plugins (operations were queued but users didn't see results) * fix(web): Ensure toggleSection function is always available for collapsible headers Moved toggleSection outside the initialization guard block so it's always defined, even if the plugin config handlers have already been initialized. This ensures collapsible sections in plugin config forms work correctly. Added debug logging to help diagnose if sections/icons aren't found. Fixes: Collapsible headers in plugin config schema not collapsing * fix(web): Improve toggleSection to explicitly show/hide collapsible content Changed from classList.toggle() to explicit add/remove of 'hidden' class based on current state. This ensures the content visibility is properly controlled when collapsing/expanding sections. Added better error checking and state detection for more reliable collapsible section behavior. * fix(web): Load plugin tabs on page load instead of waiting for plugin manager tab click The stub's loadInstalledPlugins was an empty function, so plugin tabs weren't loading until the plugin manager tab was clicked. Now the stub implementation: 1. Tries to use global window.loadInstalledPlugins if available 2. Falls back to window.pluginManager.loadInstalledPlugins 3. Finally falls back to direct loading via loadInstalledPluginsDirectly 4. Always updates tabs after loading plugins This ensures plugin navigation tabs are available immediately on page load. Fixes: Plugin tabs only loading after clicking plugin manager tab * fix(web): Ensure plugin navigation tabs load on any page regardless of active tab Multiple improvements to ensure plugin tabs are always visible: 1. Stub's loadInstalledPluginsDirectly now waits for DOM to be ready before updating tabs, using requestAnimationFrame for proper timing 2. Stub's init() now has a retry mechanism that periodically checks if plugins have been loaded by plugins_manager.js and updates tabs accordingly (checks for 2 seconds) 3. Full implementation's init() now properly handles async plugin loading and ensures tabs are updated after loading completes, checking window.installedPlugins first before attempting to load 4. Both stub and full implementation ensure tabs update using $nextTick to wait for Alpine.js rendering cycle This ensures plugin navigation tabs are visible immediately when the page loads, regardless of whether the user is on overview, plugin manager, or any other tab. Fixes: Plugin tabs only appearing after clicking plugin manager tab * fix(web): Fix restart display button not working The initPluginsPage function was returning early before event listeners were set up, making all the event listener code unreachable. Moved the return statement to after all event listeners are attached. This fixes the restart display button and all other buttons in the plugin manager (refresh plugins, update all, search, etc.) that depend on event listeners being set up. Fixes: Restart Display button not working in plugin manager * fix(web-ui): Improve categories field rendering for of-the-day plugin - Add more explicit condition checking for additionalProperties objects - Add debug logging specifically for categories field - Add fallback handler for objects that don't match special cases (render as JSON textarea) - Ensure categories section displays correctly with toggle cards instead of plain text * fix(install): Prevent following broken symlinks during file ownership setup - Add -P flag to find commands to prevent following symlinks when traversing - Add -h flag to chown to operate on symlinks themselves rather than targets - Exclude scripts/dev/plugins directory which contains development symlinks - Fixes error when chown tries to dereference broken symlinks with extra LEDMatrix in path * fix(scroll): Ensure scroll completes fully before switching displays - Add display_width to total scroll distance calculation - Scroll now continues until content is completely off screen - Update scroll completion check to use total_scroll_width + display_width - Prevents scroll from being cut off mid-way when switching to next display * fix(install): Remove unsupported -P flag from find commands - Remove -P flag which is not supported on all find versions - Keep -h flag on chown to operate on symlinks themselves - Change to {} \; syntax for better error handling - Add error suppression to continue on broken symlinks - Exclude scripts/dev/plugins directory to prevent traversal into broken symlinks * docs(wifi): Add trailing newline to WiFi AP failover setup guide * fix(web): Suppress non-critical socket errors and fix WiFi permissions script - Add error filtering in web interface to suppress harmless client disconnection errors - Downgrade 'No route to host' and broken pipe errors from ERROR to DEBUG level - Fix WiFi permissions script to use mktemp instead of manual temp file creation - Add cleanup trap to ensure temp files are removed on script exit - Resolves permission denied errors when creating temp files during installation * fix(web): Ensure plugin navigation tabs load on any page by dispatching events The issue was that when plugins_manager.js loaded and called loadInstalledPlugins(), it would set window.installedPlugins but the Alpine.js component wouldn't know to update its tabs unless the plugin manager tab was clicked. Changes: 1. loadInstalledPlugins() now always dispatches a 'pluginsUpdated' event when it sets window.installedPlugins, not just when plugin IDs change 2. renderInstalledPlugins() also dispatches the event and always updates window.installedPlugins for reactivity 3. Cached plugin data also dispatches the event when returned The Alpine component already listens for the 'pluginsUpdated' event in its init() method, so tabs will now update immediately when plugins are loaded, regardless of which tab is active. Fixes: Plugin navigation tabs only loading after clicking plugin manager tab * fix(web): Improve input field contrast in plugin configuration forms Changed input backgrounds from bg-gray-800 to bg-gray-900 (darker) to ensure high contrast with white text. Added placeholder:text-gray-400 for better placeholder text visibility. Updated in both server-side template (plugin_config.html) and client-side form generation (plugins_manager.js): - Number inputs - Text inputs - Array inputs (comma-separated) - Select dropdowns - Textareas (JSON objects) - Fallback inputs without schema This ensures all form inputs have high contrast white text on dark background, making them clearly visible and readable. Fixes: White text on white background in plugin config inputs * fix(web): Change plugin config input text from white to black Changed all input fields in plugin configuration forms to use black text on white background instead of white text on dark background for better readability and standard form appearance. Updated: - Input backgrounds: bg-gray-900 -> bg-white - Text color: text-white -> text-black - Placeholder color: text-gray-400 -> text-gray-500 Applied to both server-side template and client-side form generation for all input types (number, text, select, textarea). * fix(web): Ensure toggleSection function is available for plugin config collapsible sections Moved toggleSection function definition to an early script block so it's available immediately when HTMX loads plugin configuration content. The function was previously defined later in the page which could cause it to not be accessible when inline onclick handlers try to call it. The function toggles the 'hidden' class on collapsible section content divs and rotates the chevron icon between right (collapsed) and down (expanded) states. Fixes: Plugin configuration section headers not collapsing/expanding * fix(web): Fix collapsible section toggle to properly hide/show content Updated toggleSection function to explicitly set display style in addition to toggling the hidden class. This ensures the content is properly hidden even if CSS specificity or other styles might interfere with just the hidden class. The function now: - Checks both the hidden class and computed display style - Explicitly sets display: '' when showing and display: 'none' when hiding - Rotates chevron icon between right (collapsed) and down (expanded) This ensures collapsible sections in plugin configuration forms properly hide and show their content when the header is clicked. Fixes: Collapsible section headers rotate chevron but don't hide content * fix(web): Fix collapsible section toggle to work on first click Simplified the toggle logic to rely primarily on the 'hidden' class check rather than mixing it with computed display styles. When hiding, we now remove any inline display style to let Tailwind's 'hidden' class properly control the display property. This ensures sections respond correctly on the first click, whether they're starting in a collapsed or expanded state. Fixes: Sections requiring 2 clicks to collapse * fix(web): Ensure collapsible sections start collapsed by default Added explicit display: none style to nested content divs in plugin config template to ensure they start collapsed. The hidden class should handle this, but adding the inline style ensures sections are definitely collapsed on initial page load. Sections now: - Start collapsed (hidden) with chevron pointing right - Expand when clicked (chevron points down) - Collapse when clicked again (chevron points right) This ensures a consistent collapsed initial state across all plugin configuration sections. * fix(web): Fix collapsible section toggle to properly collapse on second click Fixed the toggle logic to explicitly set display: block when showing and display: none when hiding, rather than clearing the display style. This ensures the section state is properly tracked and the toggle works correctly on both expand and collapse clicks. The function now: - When hidden: removes hidden class, sets display: block, chevron down - When visible: adds hidden class, sets display: none, chevron right This fixes the issue where sections would expand but not collapse again. Fixes: Sections not collapsing on second click * feat(web): Ensure plugin navigation tabs load automatically on any page Implemented comprehensive solution to ensure plugin navigation tabs load automatically without requiring a visit to the plugin manager page: 1. Global event listener for 'pluginsUpdated' - works even if Alpine isn't ready yet, updates tabs directly when plugins_manager.js loads plugins 2. Enhanced stub's loadInstalledPluginsDirectly(): - Sets window.installedPlugins after loading - Dispatches 'pluginsUpdated' event for global listener - Adds console logging for debugging 3. Event listener in stub's init() method: - Listens for 'pluginsUpdated' events - Updates component state and tabs when events fire 4. Fallback timer: - If plugins_manager.js hasn't loaded after 2 seconds, fetches plugins directly via API - Ensures tabs appear even if plugins_manager.js fails 5. Improved checkAndUpdateTabs(): - Better logging - Fallback to direct fetch after timeout 6. Enhanced logging throughout plugin loading flow for debugging This ensures plugin tabs are visible immediately on page load, regardless of which tab is active or when plugins_manager.js loads. Fixes: Plugin navigation tabs only loading after visiting plugin manager * fix(web): Improve plugin tabs update logging and ensure immediate execution Enhanced logging in updatePluginTabs() and _doUpdatePluginTabs() to help debug why tabs aren't appearing. Changed debounce behavior to execute immediately on first call to ensure tabs appear quickly. Added detailed console logging with [FULL] prefix to track: - When updatePluginTabs() is called - When _doUpdatePluginTabs() executes - DOM element availability - Tab creation process - Final tab count This will help identify if tabs are being created but not visible, or if the update function isn't being called at all. Fixes: Plugin tabs loading but not visible in navigation bar * fix(web): Prevent duplicate plugin tab updates and clearing Added debouncing and duplicate prevention to stub's updatePluginTabs() to prevent tabs from being cleared and re-added multiple times. Also checks if tabs already match before clearing them. Changes: 1. Debounce stub's updatePluginTabs() with 100ms delay 2. Check if existing tabs match current plugin list before clearing 3. Global event listener only triggers full implementation's updatePluginTabs 4. Stub's event listener only works in stub mode (before enhancement) This prevents the issue where tabs were being cleared and re-added multiple times in rapid succession, which could leave tabs empty. Fixes: Plugin tabs being cleared and not re-added properly * fix(web): Fix plugin tabs not rendering when plugins are loaded Fixed _doUpdatePluginTabs() to properly use component's installedPlugins instead of checking window.installedPlugins first. Also fixed the 'unchanged' check to not skip when both lists are empty (first load scenario). Changes: 1. Check component's installedPlugins first (most up-to-date) 2. Only skip update if plugins exist AND match (don't skip empty lists) 3. Retry if no plugins found (in case they're still loading) 4. Ensure window.installedPlugins is set when loading directly 5. Better logging to show which plugin source is being used This ensures tabs are rendered when plugins are loaded, even on first page load. Fixes: Plugin tabs not being drawn despite plugins being loaded * fix(config): Fix array field parsing and validation for plugin config forms - Added logic to detect and combine indexed array fields (text_color.0, text_color.1, etc.) - Fixed array fields incorrectly stored as dicts with numeric keys - Improved handling of comma-separated array values from form submissions - Ensures array fields meet minItems requirements before validation - Resolves 400 BAD REQUEST errors when saving plugin config with RGB color arrays * fix(config): Improve array field handling and secrets error handling - Use schema defaults when array fields don't meet minItems requirement - Add debug logging for array field parsing - Improve error handling for secrets file writes - Fix arrays stored as dicts with numeric keys conversion - Better handling of incomplete array values from form submissions * fix(config): Convert array elements to correct types (numbers not strings) - Fix array element type conversion when converting dicts to arrays - Ensure RGB color arrays have integer elements, not strings - Apply type conversion for both nested and top-level array fields - Fixes validation errors: 'Expected type number, got str' * fix(config): Fix array fields showing 'none' when value is null - Handle None/null values in array field templates properly - Use schema defaults when array values are None/null - Fix applies to both Jinja2 template and JavaScript form generation - Resolves issue where stock ticker plugin shows 'none' instead of default values * fix(config): Add novalidate to plugin config form to prevent HTML5 validation blocking saves - Prevents browser HTML5 validation from blocking form submission - Allows custom validation logic to handle form data properly - Fixes issue where save button appears unclickable due to invalid form controls - Resolves problems with plugins like clock-simple that have nested/array fields * feat(config): Add helpful form validation with detailed error messages - Keep HTML5 validation enabled (removed novalidate) to prevent broken configs - Add validatePluginConfigForm function that shows which fields fail and why - Automatically expands collapsed sections containing invalid fields - Focuses first invalid field and scrolls to it - Shows user-friendly error messages with field names and specific issues - Prevents form submission until all fields are valid * fix(schema): Remove core properties from required array during validation - Core properties (enabled, display_duration, live_priority) are system-managed - SchemaManager now removes them from required array after injection - Added default values for core properties (enabled=True, display_duration=15, live_priority=False) - Updated generate_default_config() to ensure live_priority has default - Resolves 186 validation issues, reducing to 3 non-blocking warnings (98.4% reduction) - All 19 of 20 plugins now pass validation without errors Documentation: - Created docs/PLUGIN_CONFIG_CORE_PROPERTIES.md explaining core property handling - Updated existing docs to reflect core property behavior - Removed temporary audit files and scripts * fix(ui): Improve button text contrast on white backgrounds - Changed Screenshot button text from text-gray-700 to text-gray-900 - Added global CSS rule to ensure all buttons with white backgrounds use dark text (text-gray-900) for better readability - Fixes contrast issues where light text on light backgrounds was illegible * fix(ui): Add explicit text color to form-control inputs - Added color: #111827 to .form-control class to ensure dark text on white backgrounds - Fixes issue where input fields had white text on white background after button contrast fix - Ensures all form inputs are readable with proper contrast * docs: Update impact explanation and plugin config documentation * docs: Improve documentation and fix template inconsistencies - Add migration guide for script path reorganization (scripts moved to scripts/install/ and scripts/fix_perms/) - Add breaking changes section to README with migration guidance - Fix config template: set plugins_directory to 'plugins' to match actual plugin locations - Fix test template: replace Jinja2 placeholders with plain text to match other templates - Fix markdown linting: add language identifiers to code blocks (python, text, javascript) - Update permission guide: document setgid bit (0o2775) for directory modes - Fix example JSON: pin dependency versions and fix compatible_versions range - Improve readability: reduce repetition in IMPACT_EXPLANATION.md * feat(web): Make v3 interface production-ready for local deployment - Phase 2: Real Service Integration - Replace sample data with real psutil system monitoring (CPU, memory, disk, temp, uptime) - Integrate display controller to read from /tmp/led_matrix_preview.png snapshot - Scan assets/fonts directory and extract font metadata with freetype - Phase 1: Security & Input Validation - Add input validation module with URL, file upload, and config sanitization - Add optional CSRF protection (gracefully degrades if flask-wtf missing) - Add rate limiting (lenient for local use, prevents accidental abuse) - Add file upload validation to font upload endpoint - Phase 3: Error Handling - Add global error handlers for 404, 500, and unhandled exceptions - All endpoints have comprehensive try/except blocks - Phase 4: Monitoring & Observability - Add structured logging with JSON format support - Add request logging middleware (tracks method, path, status, duration, IP) - Add /api/v3/health endpoint with service status checks - Phase 5: Performance & Caching - Add in-memory caching system (separate module to avoid circular imports) - Cache font catalog (5 minute TTL) - Cache system status (10 second TTL) - Invalidate cache on config changes - All changes are non-blocking with graceful error handling - Optional dependencies (flask-wtf, flask-limiter) degrade gracefully - All imports protected with try/except blocks - Verified compilation and import tests pass * docs: Fix caching pattern logic flaw and merge conflict resolution plan - Fix Basic Caching Pattern: Replace broken stale cache fallback with correct pattern - Re-fetch cache with large max_age (31536000) in except block instead of checking already-falsy cached variable - Fixes both instances in ADVANCED_PLUGIN_DEVELOPMENT.md - Matches correct pattern from manager.py.template - Fix MERGE_CONFLICT_RESOLUTION_PLAN.md merge direction - Correct Step 1 to checkout main and merge plugins into it (not vice versa) - Update commit message to reflect 'Merge plugins into main' direction - Fixes workflow to match documented plugins → main merge --------- Co-authored-by: Chuck <chuck@example.com>	2025-12-27 14:15:49 -05:00
Evan Salter	711482d59a	Add news source logos (#143) ... * Download favicons; Display first one * Refine image loading * Switch to static images * Remove unused var * Fix * Clean up * Fix width fallback	2025-12-09 10:59:18 -05:00
Evan Salter	694c7cec10	Center time better (#144) ... * Center time better * Use ampm spacing of 4 pixels	2025-12-09 10:58:57 -05:00
Alex Resnick	c06893f3e0	Use current season for Leaderboard (#128) ... Signed-off-by: Alex Resnick <adr8292@gmail.com> Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-11-04 08:28:38 -06:00
Alex Resnick	cd0c43fb3a	Use EST for Active Games and 1 Day lookback (#129) ... Signed-off-by: Alex Resnick <adr8292@gmail.com>	2025-10-31 10:22:45 -05:00
Chuck	ce79ccaec2	Feature/music skip delay (#115) ... * feat: Add configurable delay for music module skip when nothing playing - Add 'skip_when_nothing_playing' and 'skip_delay_seconds' config options - Implement timer-based skip logic that waits 2 seconds before skipping - Reset timer when music resumes or display is deactivated - Improve user experience by preventing jarring immediate skips - Maintains backward compatibility with existing configurations * feat: Add live priority support to music manager - Add 'live_priority' and 'live_game_duration' config options for music - Integrate music manager into live priority rotation system - Add 'music_live' mode that participates in live priority takeover - Music manager joins live priority rotation when actively playing - Supports future plugin ecosystem with consistent live priority interface - Maintains backward compatibility with existing music configurations * feat: Add new music settings to web interface - Add 'Skip When Nothing Playing' checkbox and delay configuration - Add 'Enable Live Priority' checkbox and duration configuration - Update music form JavaScript to save all new settings - Users can now configure music skip behavior and live priority through web UI * fix: Improve music live priority integration - Enhanced music live content detection with detailed logging - Modified live priority logic to properly handle music mode - Added music to live priority sports collection when actively playing - Updated live priority rotation to handle music mode correctly - Improved live priority takeover logic for music manager - Music now properly participates in live priority rotation when playing * perf: Reduce logging frequency for music live priority - Add timestamp-based throttling to music live priority logging - Info messages now only appear every 30 seconds instead of every few milliseconds - Debug messages are also throttled to reduce log spam - Maintains visibility of important events while reducing noise * Fix unreachable code bug in music live priority handling - Moved music live priority logic outside the sports iteration loop where it was unreachable - The 'if sport == music' block was never executed since 'music' wasn't in the sports list - Consolidated music handling in its own separate section for cleaner code structure - Added music configuration options to config template - Maintained exact same functionality while eliminating dead code * Fix music_live_game_duration setting not being used - Modified get_current_duration() method to check for music live priority mode - When music is in live priority mode, use configured live_game_duration setting - Added proper config reading for music_live_game_duration during initialization - Ensures music displays for the configured duration when in live priority mode * Fix stale timestamp bug in live priority debug logging - Fixed issue where debug log at line 1240 was using a stale current_time variable - The current_time variable was conditionally reassigned in music live priority check - This caused inconsistent log throttling behavior - Now uses fresh current_time_for_debug variable for accurate throttling	2025-10-16 16:46:37 -04:00
Chuck	98d3ed7d91	Fix NBA leaderboard team ID field for logo fetching (#116) ... * Fix NBA leaderboard team ID field for logo fetching - Add missing 'id' field to NBA team standings data structure - Enables proper logo fetching from assets/sports/nba_logos/ - Fixes 'id' KeyError when creating NBA leaderboard images - Includes diagnostic and test scripts for verification * Add NBA logo downloader script and documentation - download_nba_logos.py: Script to download all 30 NBA team logos from ESPN API - README_NBA_LOGOS.md: Comprehensive documentation for the logo downloader - Supports force re-download and quiet modes - Downloads to assets/sports/nba_logos/ for leaderboard integration * replace NBA Logos * return NBA logo	2025-10-10 18:27:36 -04:00
Chuck	7a61ecff7b	Feature/memory optimization config (#108) ... * feat(config): optimize memory usage to prevent OOM killer - Reduce brightness from 95 to 50 to lower power consumption - Reduce refresh rate from 120Hz to 100Hz to reduce CPU/memory pressure - Reduce background service workers from 3 to 1 per manager - Change hardware mapping from adafruit-hat-pwm to adafruit-hat - Expected memory savings: ~700MB reduction in background service usage - Addresses SIGKILL errors caused by memory exhaustion on Raspberry Pi Fixes: OOM killer terminating ledmatrix.service with status=9/KILL * revert display brightness * refactor(background-service): hardcode optimized settings and remove config blocks - Hardcode background service to 1 worker in all managers - Remove background_service config blocks from template - Simplify configuration for users - no need to adjust system settings - Memory optimization: ~700MB reduction in background service usage - Settings: 1 worker, 30s timeout, 3 retries (hardcoded) Files updated: - src/base_classes/sports.py - src/leaderboard_manager.py - src/odds_ticker_manager.py - src/soccer_managers.py - src/milb_manager.py - config/config.template.json This prevents OOM killer errors by reducing memory usage from 15 background threads to 5 threads total across all managers. * remove fallback in case of background service failure	2025-10-08 19:10:54 -05:00
Chuck	58bbb5fe6f	fix(nba): Add missing PIL imports for Image and ImageFont (#103) ... - Added PIL import for Image and ImageFont classes - Resolves NameError when running display_controller.py - Fixes type hint for _load_and_resize_logo method	2025-10-05 16:05:47 -04:00
Alex Resnick	fb38a5a814	Create Basketball Base Class and Consolidate Basketball Managers (#97) ... * Create basketball Base class * Migrate NBA * Add NCAA Mens Basketball * Add NCAA Women's Basketball * Add WNBA --------- Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-10-05 15:22:00 -04:00
Alex Resnick	3406234e00	Add NCAA Women's Hockey (#96) ... * Add NCAA Womens Hockey * Fix status text --------- Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-10-05 15:19:03 -04:00
Alex Resnick	9ba76b56d7	Update Football display. Add End of Period text and long down distance for larger screens (#101) ... Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-10-05 15:17:49 -04:00
Chuck	f3d02e07ea	Feature/static image manager (#95) ... * feat(static-image): Add static image manager with web interface - Create StaticImageManager class with image scaling and transparency support - Add configuration options for display duration, zoom scale, and background color - Integrate with display controller and web interface - Add image upload functionality to web interface - Support for various image formats with proper scaling - Efficient image processing with aspect ratio preservation - Ready for future scrolling feature implementation * fix(static-image): Move display duration to main display_durations block - Remove display_duration from static_image config section - Update StaticImageManager to read duration from display.display_durations.static_image - Remove display duration field from web interface form - Update web interface JavaScript to not include display_duration in payload - Follows same pattern as all other managers in the project * feat(static-image): Add fit to display option - Add fit_to_display checkbox to automatically scale images to fit display - When enabled, images are scaled to fit display dimensions while preserving aspect ratio - When disabled, manual zoom_scale control is available - Update web interface with smart form controls (zoom scale disabled when fit to display is on) - Prevents stretching or cropping - images are always properly fitted - Default to fit_to_display=true for better user experience * refactor(static-image): Remove zoom_scale and simplify to fit_to_display only - Remove zoom_scale option entirely as it was confusing and redundant - Simplify image processing to always fit to display dimensions - Remove zoom_scale field from web interface - Clean up JavaScript to remove zoom scale logic - Images are now always properly fitted without stretching or cropping - Much simpler and more intuitive user experience	2025-10-05 10:46:36 -04:00
Alex Resnick	f6e2881f2f	Multiple Sports Fixes (#93)	2025-10-02 16:35:17 -05:00
Chuck	4adb7b49ba	fix: Resolve permission errors in soccer_manager logo downloads (#90) ... - Fix download_missing_logo call to use correct signature with Path parameter - Add comprehensive permission error handling with helpful error messages - Include instructions to run fix_assets_permissions.sh when permission errors occur - Improve error logging for directory listing and logo access permission issues - Add test script to verify permission error handling works correctly Fixes: [Errno 13] Permission denied errors when downloading soccer team logos	2025-10-01 10:14:34 -04:00
Alex Resnick	2d6c238ea0	Consolidate Baseball leagues to completely use Baseball class (#84) ... * Consolidate MLB to completely use Baseball class * typos * add OT period number * Add new live class and abstracts * NCAA BB is consolidated * MLB Working * NCAA Hockey and NHL working * didn't need wrapper function * Add hockey shots on goal * cleanup --------- Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-09-30 17:55:45 -04:00
Chuck	38c1bff9dc	fix(nhl): Add missing games_list initialization in NHLRecentManager (#85) ... - Add self.games_list = [] to NHLRecentManager.__init__ method - Fixes AttributeError when display method tries to access games_list - Follows same pattern as other RecentManager classes	2025-09-29 08:45:48 -04:00
Chuck	08af182380	Feature/nhl background service integration (#77) ... * feat(nhl): Integrate NHL manager with background service - Fix NHL data source to use ESPN API instead of NHL.com API - Add background service integration following NFL/NCAA pattern - Add HTTP session with retry strategy and proper headers - Add background fetch request tracking and callback handling - Add synchronous fallback when background service disabled - Update _fetch_nhl_api_data() to use background threading - Simplify _fetch_data() method for consistency - Add _fetch_nhl_api_data_sync() for direct API fallback This brings NHL manager in line with other sports managers and resolves the 'No events found in ESPN API response' error by using the correct ESPN API endpoint that matches the existing parsing logic. * update NHL	2025-09-28 16:34:41 -04:00
Alex Resnick	1ee805901f	Fix odds and more (#81) ... * fix(odds): Resolve incorrect sport and league parameters in _fetch_odds calls - Fixed SportsCore._fetch_data() to call _fetch_odds(game) instead of _fetch_odds(game, sport_key, sport_key) - Updated _fetch_odds method signature to accept only game parameter - Added _fetch_odds_with_params helper method for sport-specific implementations - Updated sport-specific managers to use correct sport and league parameters: - NFL: football/nfl - NCAA Football: football/college-football - NCAA Hockey: hockey/mens-college-hockey - Ensures odds are fetched with correct ESPN API endpoints Fixes #79 * Fix odds and other things * update hockey * fix rankings * update imports * Fix Logo Cache * Add show_favorite_team_only attribute --------- Co-authored-by: ChuckBuilds <33324927+ChuckBuilds@users.noreply.github.com> Co-authored-by: Alex Resnick <adr8282@gmail.com>	2025-09-28 16:34:21 -04:00
Chuck	a98760f4d9	team switch logging (#73) ... Works and doesn't seem to break anything else	2025-09-27 12:50:50 -04:00
Chuck	fc06493990	Fix/logo download permission error (#70) ... * fix: Resolve permission errors when downloading sports logos - Fix fix_assets_permissions.sh to use correct directory name 'ncaa_logos' instead of 'ncaa_fbs_logos' - Add comprehensive permission checking in logo downloader - Improve error handling with specific permission error messages - Add write access testing before attempting logo downloads - Provide clear instructions to run permission fix script when errors occur Fixes: [Errno 13] Permission denied errors when downloading team logos like SELA.png * fix: Update first_time_install.sh to use correct ncaa_logos directory - Fix manual permission setting section to use 'ncaa_logos' instead of 'ncaa_fbs_logos' - Ensures consistency across all installation scripts - Prevents permission issues during first-time installation * fix: Update all remaining references from ncaa_fbs_logos to ncaa_logos - Fix README.md directory reference - Update wiki documentation files (MANAGER_GUIDE_COMPREHENSIVE.md, TEAM_ABBREVIATIONS_AND_LEAGUE_SLUGS.md) - Fix test files (save_missing_teams.py, test_ranking_toggle.py, test_leaderboard_simple.py) - Update missing_team_logos.txt with correct directory paths Ensures complete consistency across the entire project for NCAA logo directory naming.	2025-09-25 19:21:26 -04:00