rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-04-10 21:03:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Resolve permission errors in soccer_manager logo downloads (#90)

Browse Source 
- Fix download_missing_logo call to use correct signature with Path parameter
- Add comprehensive permission error handling with helpful error messages
- Include instructions to run fix_assets_permissions.sh when permission errors occur
- Improve error logging for directory listing and logo access permission issues
- Add test script to verify permission error handling works correctly

Fixes: [Errno 13] Permission denied errors when downloading soccer team logos
This commit is contained in:
Chuck
2025-10-01 10:14:34 -04:00
committed by GitHub
parent 2d6c238ea0
commit 4adb7b49ba
2 changed files with 161 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/soccer_managers.py
View File

@@ -429,7 +429,8 @@ class BaseSoccerManager:
break
except (OSError, PermissionError) as e:
self.logger.warning(f"Error listing directory {self.logo_dir}: {e}")
self.logger.warning(f"Permission denied listing directory {self.logo_dir}: {e}")
self.logger.warning(f"Please run: sudo ./fix_assets_permissions.sh")
if logo_path is None:
logo_path = expected_path # Use original path for creation attempts
@@ -453,7 +454,7 @@ class BaseSoccerManager:
soccer_league_key = get_soccer_league_key(league_code)
self.logger.debug(f"Attempting to download {team_abbrev} logo from {league_code} ({soccer_league_key})")
success = download_missing_logo(team_abbrev, soccer_league_key, team_abbrev)
success = download_missing_logo(soccer_league_key, team_abbrev, team_abbrev, Path(logo_path))
if success:
self.logger.info(f"Successfully downloaded logo for {team_abbrev} from {league_code}")
download_success = True
@@ -494,7 +495,8 @@ class BaseSoccerManager:
# No cache directory available, just use in-memory placeholder
raise PermissionError("No writable cache directory available")
except (PermissionError, OSError) as pe:
self.logger.debug(f"Could not create placeholder logo file for {team_abbrev}: {pe}")
self.logger.warning(f"Permission denied creating placeholder logo for {team_abbrev}: {pe}")
self.logger.warning(f"Please run: sudo ./fix_assets_permissions.sh")
# Return a simple in-memory placeholder instead
logo = Image.new('RGBA', (36, 36), (random.randint(50, 200), random.randint(50, 200), random.randint(50, 200), 255))
self._logo_cache[team_abbrev] = logo
@@ -523,6 +525,7 @@ class BaseSoccerManager:
return logo
except PermissionError as pe:
self.logger.warning(f"Permission denied accessing logo for {team_abbrev}: {pe}")
self.logger.warning(f"Please run: sudo ./fix_assets_permissions.sh")
# Return a simple in-memory placeholder instead
logo = Image.new('RGBA', (36, 36), (random.randint(50, 200), random.randint(50, 200), random.randint(50, 200), 255))
self._logo_cache[team_abbrev] = logo