Fix/logo download permission error (#70)

* fix: Resolve permission errors when downloading sports logos

- Fix fix_assets_permissions.sh to use correct directory name 'ncaa_logos' instead of 'ncaa_fbs_logos'
- Add comprehensive permission checking in logo downloader
- Improve error handling with specific permission error messages
- Add write access testing before attempting logo downloads
- Provide clear instructions to run permission fix script when errors occur

Fixes: [Errno 13] Permission denied errors when downloading team logos like SELA.png

* fix: Update first_time_install.sh to use correct ncaa_logos directory

- Fix manual permission setting section to use 'ncaa_logos' instead of 'ncaa_fbs_logos'
- Ensures consistency across all installation scripts
- Prevents permission issues during first-time installation

* fix: Update all remaining references from ncaa_fbs_logos to ncaa_logos

- Fix README.md directory reference
- Update wiki documentation files (MANAGER_GUIDE_COMPREHENSIVE.md, TEAM_ABBREVIATIONS_AND_LEAGUE_SLUGS.md)
- Fix test files (save_missing_teams.py, test_ranking_toggle.py, test_leaderboard_simple.py)
- Update missing_team_logos.txt with correct directory paths

Ensures complete consistency across the entire project for NCAA logo directory naming.
This commit is contained in:
Chuck
2025-09-25 19:21:26 -04:00
committed by GitHub
parent 1bc4e531ae
commit fc06493990
8 changed files with 341 additions and 313 deletions

View File

@@ -53,7 +53,7 @@ fi
# Specifically ensure the sports logos directories are writable
SPORTS_DIRS=(
"sports/ncaa_fbs_logos"
"sports/ncaa_logos"
"sports/nfl_logos"
"sports/nba_logos"
"sports/nhl_logos"
@@ -99,21 +99,21 @@ for SPORTS_DIR in "${SPORTS_DIRS[@]}"; do
done
echo ""
echo "Testing write access to ncaa_fbs_logos directory specifically..."
NCAA_DIR="$ASSETS_DIR/sports/ncaa_fbs_logos"
echo "Testing write access to ncaa_logos directory specifically..."
NCAA_DIR="$ASSETS_DIR/sports/ncaa_logos"
if [ -d "$NCAA_DIR" ]; then
# Create a test file to verify write access
TEST_FILE="$NCAA_DIR/.permission_test"
if sudo -u "$REAL_USER" touch "$TEST_FILE" 2>/dev/null; then
echo "✓ Successfully created test file in ncaa_fbs_logos directory"
echo "✓ Successfully created test file in ncaa_logos directory"
sudo -u "$REAL_USER" rm -f "$TEST_FILE"
echo "✓ Successfully removed test file"
else
echo "✗ Failed to create test file in ncaa_fbs_logos directory"
echo "✗ Failed to create test file in ncaa_logos directory"
echo " This indicates the permission fix did not work properly"
fi
else
echo "✗ ncaa_fbs_logos directory does not exist"
echo "✗ ncaa_logos directory does not exist"
fi
echo ""