From fc06493990881a3fc6c4fde61ac177b12a12d368 Mon Sep 17 00:00:00 2001 From: Chuck <33324927+ChuckBuilds@users.noreply.github.com> Date: Thu, 25 Sep 2025 19:21:26 -0400 Subject: [PATCH] Fix/logo download permission error (#70) * fix: Resolve permission errors when downloading sports logos - Fix fix_assets_permissions.sh to use correct directory name 'ncaa_logos' instead of 'ncaa_fbs_logos' - Add comprehensive permission checking in logo downloader - Improve error handling with specific permission error messages - Add write access testing before attempting logo downloads - Provide clear instructions to run permission fix script when errors occur Fixes: [Errno 13] Permission denied errors when downloading team logos like SELA.png * fix: Update first_time_install.sh to use correct ncaa_logos directory - Fix manual permission setting section to use 'ncaa_logos' instead of 'ncaa_fbs_logos' - Ensures consistency across all installation scripts - Prevents permission issues during first-time installation * fix: Update all remaining references from ncaa_fbs_logos to ncaa_logos - Fix README.md directory reference - Update wiki documentation files (MANAGER_GUIDE_COMPREHENSIVE.md, TEAM_ABBREVIATIONS_AND_LEAGUE_SLUGS.md) - Fix test files (save_missing_teams.py, test_ranking_toggle.py, test_leaderboard_simple.py) - Update missing_team_logos.txt with correct directory paths Ensures complete consistency across the entire project for NCAA logo directory naming. --- README.md | 2 +- first_time_install.sh | 2 +- fix_assets_permissions.sh | 12 +- src/logo_downloader.py | 32 +- test/missing_team_logos.txt | 590 ++++++++++++++++---------------- test/save_missing_teams.py | 4 +- test/test_leaderboard_simple.py | 4 +- test/test_ranking_toggle.py | 8 +- 8 files changed, 341 insertions(+), 313 deletions(-) diff --git a/README.md b/README.md index 531b3c9d..1e3ed63b 100644 --- a/README.md +++ b/README.md @@ -439,7 +439,7 @@ The ticker displays team logos alongside the text: - `assets/sports/nfl_logos/` - `assets/sports/nba_logos/` - `assets/sports/mlb_logos/` - - `assets/sports/ncaa_fbs_logos/` + - `assets/sports/ncaa_logos/` ### Troubleshooting diff --git a/first_time_install.sh b/first_time_install.sh index 3bea92c6..c87f4675 100644 --- a/first_time_install.sh +++ b/first_time_install.sh @@ -240,7 +240,7 @@ else # Specifically ensure the sports logos directories are writable SPORTS_DIRS=( - "sports/ncaa_fbs_logos" + "sports/ncaa_logos" "sports/nfl_logos" "sports/nba_logos" "sports/nhl_logos" diff --git a/fix_assets_permissions.sh b/fix_assets_permissions.sh index ea3c40c1..f74f6558 100644 --- a/fix_assets_permissions.sh +++ b/fix_assets_permissions.sh @@ -53,7 +53,7 @@ fi # Specifically ensure the sports logos directories are writable SPORTS_DIRS=( - "sports/ncaa_fbs_logos" + "sports/ncaa_logos" "sports/nfl_logos" "sports/nba_logos" "sports/nhl_logos" @@ -99,21 +99,21 @@ for SPORTS_DIR in "${SPORTS_DIRS[@]}"; do done echo "" -echo "Testing write access to ncaa_fbs_logos directory specifically..." -NCAA_DIR="$ASSETS_DIR/sports/ncaa_fbs_logos" +echo "Testing write access to ncaa_logos directory specifically..." +NCAA_DIR="$ASSETS_DIR/sports/ncaa_logos" if [ -d "$NCAA_DIR" ]; then # Create a test file to verify write access TEST_FILE="$NCAA_DIR/.permission_test" if sudo -u "$REAL_USER" touch "$TEST_FILE" 2>/dev/null; then - echo "✓ Successfully created test file in ncaa_fbs_logos directory" + echo "✓ Successfully created test file in ncaa_logos directory" sudo -u "$REAL_USER" rm -f "$TEST_FILE" echo "✓ Successfully removed test file" else - echo "✗ Failed to create test file in ncaa_fbs_logos directory" + echo "✗ Failed to create test file in ncaa_logos directory" echo " This indicates the permission fix did not work properly" fi else - echo "✗ ncaa_fbs_logos directory does not exist" + echo "✗ ncaa_logos directory does not exist" fi echo "" diff --git a/src/logo_downloader.py b/src/logo_downloader.py index 76ceb137..1756e9c6 100644 --- a/src/logo_downloader.py +++ b/src/logo_downloader.py @@ -140,7 +140,23 @@ class LogoDownloader: """Ensure the logo directory exists, create if necessary.""" try: os.makedirs(logo_dir, exist_ok=True) - return True + + # Check if we can actually write to the directory + test_file = os.path.join(logo_dir, '.write_test') + try: + with open(test_file, 'w') as f: + f.write('test') + os.remove(test_file) + logger.debug(f"Directory {logo_dir} is writable") + return True + except PermissionError: + logger.error(f"Permission denied: Cannot write to directory {logo_dir}") + logger.error(f"Please run: sudo ./fix_assets_permissions.sh") + return False + except Exception as e: + logger.error(f"Failed to test write access to directory {logo_dir}: {e}") + return False + except Exception as e: logger.error(f"Failed to create logo directory {logo_dir}: {e}") return False @@ -187,6 +203,10 @@ class LogoDownloader: pass return False + except PermissionError as e: + logger.error(f"Permission denied downloading logo for {team_abbreviation}: {e}") + logger.error(f"Please run: sudo ./fix_assets_permissions.sh") + return False except requests.exceptions.RequestException as e: logger.error(f"Failed to download logo for {team_abbreviation}: {e}") return False @@ -496,6 +516,12 @@ class LogoDownloader: def download_missing_logo_for_team(self, league: str, team_id: str, team_abbreviation: str, logo_path: Path) -> bool: """Download a specific team's logo if it's missing.""" + # Ensure the logo directory exists and is writable + logo_dir = str(logo_path.parent) + if not self.ensure_logo_directory(logo_dir): + logger.error(f"Cannot download logo for {team_abbreviation}: directory {logo_dir} is not writable") + return False + # Fetch team data to find the logo URL data = self.fetch_single_team(league, team_id) if not data: @@ -660,7 +686,9 @@ def download_missing_logo(league: str, team_id: str, team_abbreviation: str, log # Check if logo already exists logo_dir = downloader.get_logo_directory(league) - downloader.ensure_logo_directory(logo_dir) + if not downloader.ensure_logo_directory(logo_dir): + logger.error(f"Cannot download logo for {team_abbreviation}: directory {logo_dir} is not writable") + return False filename = f"{downloader.normalize_abbreviation(team_abbreviation)}.png" filepath = Path(logo_dir) / filename diff --git a/test/missing_team_logos.txt b/test/missing_team_logos.txt index b012a05d..76cce633 100644 --- a/test/missing_team_logos.txt +++ b/test/missing_team_logos.txt @@ -347,301 +347,301 @@ FILENAMES NEEDED: Add these PNG files to their respective directories: assets/sports/mlb_logos/OAK.png -assets/sports/ncaa_fbs_logos/AAMU.png -assets/sports/ncaa_fbs_logos/ACU.png -assets/sports/ncaa_fbs_logos/ADA.png -assets/sports/ncaa_fbs_logos/ADR.png -assets/sports/ncaa_fbs_logos/AIC.png -assets/sports/ncaa_fbs_logos/ALB.png -assets/sports/ncaa_fbs_logos/ALBS.png -assets/sports/ncaa_fbs_logos/ALCN.png -assets/sports/ncaa_fbs_logos/ALD.png -assets/sports/ncaa_fbs_logos/ALF.png -assets/sports/ncaa_fbs_logos/ALL.png -assets/sports/ncaa_fbs_logos/ALST.png -assets/sports/ncaa_fbs_logos/AMH.png -assets/sports/ncaa_fbs_logos/AND.png -assets/sports/ncaa_fbs_logos/ANG.png -assets/sports/ncaa_fbs_logos/ANN.png -assets/sports/ncaa_fbs_logos/APSU.png -assets/sports/ncaa_fbs_logos/ASH.png -assets/sports/ncaa_fbs_logos/ASP.png -assets/sports/ncaa_fbs_logos/ASU.png -assets/sports/ncaa_fbs_logos/AUG.png -assets/sports/ncaa_fbs_logos/AUR.png -assets/sports/ncaa_fbs_logos/AUS.png -assets/sports/ncaa_fbs_logos/AVE.png -assets/sports/ncaa_fbs_logos/AVI.png -assets/sports/ncaa_fbs_logos/AZU.png -assets/sports/ncaa_fbs_logos/BAK.png -assets/sports/ncaa_fbs_logos/BAL.png -assets/sports/ncaa_fbs_logos/BAT.png -assets/sports/ncaa_fbs_logos/BEC.png -assets/sports/ncaa_fbs_logos/BEL.png -assets/sports/ncaa_fbs_logos/BEN.png -assets/sports/ncaa_fbs_logos/BENT.png -assets/sports/ncaa_fbs_logos/BET.png -assets/sports/ncaa_fbs_logos/BHS.png -assets/sports/ncaa_fbs_logos/BIR.png -assets/sports/ncaa_fbs_logos/BKN.png -assets/sports/ncaa_fbs_logos/BLA.png -assets/sports/ncaa_fbs_logos/BLOM.png -assets/sports/ncaa_fbs_logos/BLU.png -assets/sports/ncaa_fbs_logos/BOW.png -assets/sports/ncaa_fbs_logos/BRI.png -assets/sports/ncaa_fbs_logos/BRWN.png -assets/sports/ncaa_fbs_logos/BST.png -assets/sports/ncaa_fbs_logos/BUCK.png -assets/sports/ncaa_fbs_logos/BUE.png -assets/sports/ncaa_fbs_logos/BUF.png -assets/sports/ncaa_fbs_logos/BUT.png -assets/sports/ncaa_fbs_logos/CAM.png -assets/sports/ncaa_fbs_logos/CAP.png -assets/sports/ncaa_fbs_logos/CAR.png -assets/sports/ncaa_fbs_logos/CARK.png -assets/sports/ncaa_fbs_logos/CAS.png -assets/sports/ncaa_fbs_logos/CAT.png -assets/sports/ncaa_fbs_logos/CCSU.png -assets/sports/ncaa_fbs_logos/CEN.png -assets/sports/ncaa_fbs_logos/CHA.png -assets/sports/ncaa_fbs_logos/CHI.png -assets/sports/ncaa_fbs_logos/CHSO.png -assets/sports/ncaa_fbs_logos/CLA.png -assets/sports/ncaa_fbs_logos/CLMB.png -assets/sports/ncaa_fbs_logos/COE.png -assets/sports/ncaa_fbs_logos/COL.png -assets/sports/ncaa_fbs_logos/COLC.png -assets/sports/ncaa_fbs_logos/COLG.png -assets/sports/ncaa_fbs_logos/CON.png -assets/sports/ncaa_fbs_logos/COR.png -assets/sports/ncaa_fbs_logos/CP.png -assets/sports/ncaa_fbs_logos/CRO.png -assets/sports/ncaa_fbs_logos/CSU.png -assets/sports/ncaa_fbs_logos/CUL.png -assets/sports/ncaa_fbs_logos/CUM.png -assets/sports/ncaa_fbs_logos/CUR.png -assets/sports/ncaa_fbs_logos/DAK.png -assets/sports/ncaa_fbs_logos/DART.png -assets/sports/ncaa_fbs_logos/DAV.png -assets/sports/ncaa_fbs_logos/DAY.png -assets/sports/ncaa_fbs_logos/DEF.png -assets/sports/ncaa_fbs_logos/DEL.png -assets/sports/ncaa_fbs_logos/DEN.png -assets/sports/ncaa_fbs_logos/DEP.png -assets/sports/ncaa_fbs_logos/DIC.png -assets/sports/ncaa_fbs_logos/DRKE.png -assets/sports/ncaa_fbs_logos/DSU.png -assets/sports/ncaa_fbs_logos/DUB.png -assets/sports/ncaa_fbs_logos/DUQ.png -assets/sports/ncaa_fbs_logos/EAS.png -assets/sports/ncaa_fbs_logos/EDI.png -assets/sports/ncaa_fbs_logos/EIU.png -assets/sports/ncaa_fbs_logos/EKU.png -assets/sports/ncaa_fbs_logos/ELI.png -assets/sports/ncaa_fbs_logos/ELM.png -assets/sports/ncaa_fbs_logos/ELON.png -assets/sports/ncaa_fbs_logos/EMO.png -assets/sports/ncaa_fbs_logos/EMP.png -assets/sports/ncaa_fbs_logos/END.png -assets/sports/ncaa_fbs_logos/EOR.png -assets/sports/ncaa_fbs_logos/ETSU.png -assets/sports/ncaa_fbs_logos/EUR.png -assets/sports/ncaa_fbs_logos/EWU.png -assets/sports/ncaa_fbs_logos/FAY.png -assets/sports/ncaa_fbs_logos/FDU.png -assets/sports/ncaa_fbs_logos/FER.png -assets/sports/ncaa_fbs_logos/FIN.png -assets/sports/ncaa_fbs_logos/FIT.png -assets/sports/ncaa_fbs_logos/FLA.png -assets/sports/ncaa_fbs_logos/FOR.png -assets/sports/ncaa_fbs_logos/FRA.png -assets/sports/ncaa_fbs_logos/FRO.png -assets/sports/ncaa_fbs_logos/FRST.png -assets/sports/ncaa_fbs_logos/FTLW.png -assets/sports/ncaa_fbs_logos/FUR.png -assets/sports/ncaa_fbs_logos/GAL.png -assets/sports/ncaa_fbs_logos/GAN.png -assets/sports/ncaa_fbs_logos/GEN.png -assets/sports/ncaa_fbs_logos/GEO.png -assets/sports/ncaa_fbs_logos/GET.png -assets/sports/ncaa_fbs_logos/GLE.png -assets/sports/ncaa_fbs_logos/GMU.png -assets/sports/ncaa_fbs_logos/GRA.png -assets/sports/ncaa_fbs_logos/GRE.png -assets/sports/ncaa_fbs_logos/GRI.png -assets/sports/ncaa_fbs_logos/GRO.png -assets/sports/ncaa_fbs_logos/GUI.png -assets/sports/ncaa_fbs_logos/GWEB.png -assets/sports/ncaa_fbs_logos/HAM.png -assets/sports/ncaa_fbs_logos/HAMP.png -assets/sports/ncaa_fbs_logos/HAN.png -assets/sports/ncaa_fbs_logos/HAR.png -assets/sports/ncaa_fbs_logos/HARV.png -assets/sports/ncaa_fbs_logos/HAS.png -assets/sports/ncaa_fbs_logos/HAW.png -assets/sports/ncaa_fbs_logos/HBU.png -assets/sports/ncaa_fbs_logos/HC.png -assets/sports/ncaa_fbs_logos/HEI.png -assets/sports/ncaa_fbs_logos/HEN.png -assets/sports/ncaa_fbs_logos/HIL.png -assets/sports/ncaa_fbs_logos/HIR.png -assets/sports/ncaa_fbs_logos/HOB.png -assets/sports/ncaa_fbs_logos/HOW.png -assets/sports/ncaa_fbs_logos/HUS.png -assets/sports/ncaa_fbs_logos/IDHO.png -assets/sports/ncaa_fbs_logos/IDST.png -assets/sports/ncaa_fbs_logos/ILST.png -assets/sports/ncaa_fbs_logos/ILW.png -assets/sports/ncaa_fbs_logos/IND.png -assets/sports/ncaa_fbs_logos/INST.png -assets/sports/ncaa_fbs_logos/IOW.png -assets/sports/ncaa_fbs_logos/ITH.png -assets/sports/ncaa_fbs_logos/JKST.png -assets/sports/ncaa_fbs_logos/JOH.png -assets/sports/ncaa_fbs_logos/JUN.png -assets/sports/ncaa_fbs_logos/KAL.png -assets/sports/ncaa_fbs_logos/KAN.png -assets/sports/ncaa_fbs_logos/KEN.png -assets/sports/ncaa_fbs_logos/KIN.png -assets/sports/ncaa_fbs_logos/KNO.png -assets/sports/ncaa_fbs_logos/KUT.png -assets/sports/ncaa_fbs_logos/KYST.png -assets/sports/ncaa_fbs_logos/KYW.png -assets/sports/ncaa_fbs_logos/LA.png -assets/sports/ncaa_fbs_logos/LAG.png -assets/sports/ncaa_fbs_logos/LAK.png -assets/sports/ncaa_fbs_logos/LAM.png -assets/sports/ncaa_fbs_logos/LAN.png -assets/sports/ncaa_fbs_logos/LAW.png -assets/sports/ncaa_fbs_logos/LEB.png -assets/sports/ncaa_fbs_logos/LEH.png -assets/sports/ncaa_fbs_logos/LEN.png -assets/sports/ncaa_fbs_logos/LEW.png -assets/sports/ncaa_fbs_logos/LIM.png -assets/sports/ncaa_fbs_logos/LIN.png -assets/sports/ncaa_fbs_logos/LOC.png -assets/sports/ncaa_fbs_logos/LOR.png -assets/sports/ncaa_fbs_logos/LUT.png -assets/sports/ncaa_fbs_logos/LYC.png -assets/sports/ncaa_fbs_logos/M-OH.png -assets/sports/ncaa_fbs_logos/MAC.png -assets/sports/ncaa_fbs_logos/MAI.png -assets/sports/ncaa_fbs_logos/MAN.png -assets/sports/ncaa_fbs_logos/MAR.png -assets/sports/ncaa_fbs_logos/MAS.png -assets/sports/ncaa_fbs_logos/MAY.png -assets/sports/ncaa_fbs_logos/MCM.png -assets/sports/ncaa_fbs_logos/MCN.png -assets/sports/ncaa_fbs_logos/MEN.png -assets/sports/ncaa_fbs_logos/MER.png -assets/sports/ncaa_fbs_logos/MERC.png -assets/sports/ncaa_fbs_logos/MES.png -assets/sports/ncaa_fbs_logos/MET.png -assets/sports/ncaa_fbs_logos/MH.png -assets/sports/ncaa_fbs_logos/MID.png -assets/sports/ncaa_fbs_logos/MIL.png -assets/sports/ncaa_fbs_logos/MIN.png -assets/sports/ncaa_fbs_logos/MIS.png -assets/sports/ncaa_fbs_logos/MNST.png -assets/sports/ncaa_fbs_logos/MONM.png -assets/sports/ncaa_fbs_logos/MONT.png -assets/sports/ncaa_fbs_logos/MOR.png -assets/sports/ncaa_fbs_logos/MORE.png -assets/sports/ncaa_fbs_logos/MORG.png -assets/sports/ncaa_fbs_logos/MOU.png -assets/sports/ncaa_fbs_logos/MRST.png -assets/sports/ncaa_fbs_logos/MSU.png -assets/sports/ncaa_fbs_logos/MTST.png -assets/sports/ncaa_fbs_logos/MTU.png -assets/sports/ncaa_fbs_logos/MUH.png -assets/sports/ncaa_fbs_logos/MUR.png -assets/sports/ncaa_fbs_logos/MUS.png -assets/sports/ncaa_fbs_logos/MVSU.png -assets/sports/ncaa_fbs_logos/NAU.png -assets/sports/ncaa_fbs_logos/NBY.png -assets/sports/ncaa_fbs_logos/NCAT.png -assets/sports/ncaa_fbs_logos/NCCU.png -assets/sports/ncaa_fbs_logos/NCST.png -assets/sports/ncaa_fbs_logos/NDOH.png -assets/sports/ncaa_fbs_logos/NDSU.png -assets/sports/ncaa_fbs_logos/NH.png -assets/sports/ncaa_fbs_logos/NICH.png -assets/sports/ncaa_fbs_logos/NMH.png -assets/sports/ncaa_fbs_logos/NMI.png -assets/sports/ncaa_fbs_logos/NOR.png -assets/sports/ncaa_fbs_logos/NORF.png -assets/sports/ncaa_fbs_logos/OBE.png -assets/sports/ncaa_fbs_logos/OHI.png -assets/sports/ncaa_fbs_logos/OKL.png -assets/sports/ncaa_fbs_logos/OLI.png -assets/sports/ncaa_fbs_logos/OMA.png -assets/sports/ncaa_fbs_logos/OTT.png -assets/sports/ncaa_fbs_logos/PAC.png -assets/sports/ncaa_fbs_logos/PENN.png -assets/sports/ncaa_fbs_logos/PIKE.png -assets/sports/ncaa_fbs_logos/PRE.png -assets/sports/ncaa_fbs_logos/PRI.png -assets/sports/ncaa_fbs_logos/PRIN.png -assets/sports/ncaa_fbs_logos/PST.png -assets/sports/ncaa_fbs_logos/RED.png -assets/sports/ncaa_fbs_logos/RICH.png -assets/sports/ncaa_fbs_logos/RIT.png -assets/sports/ncaa_fbs_logos/ROB.png -assets/sports/ncaa_fbs_logos/ROS.png -assets/sports/ncaa_fbs_logos/SAC.png -assets/sports/ncaa_fbs_logos/SAG.png -assets/sports/ncaa_fbs_logos/SDAK.png -assets/sports/ncaa_fbs_logos/SET.png -assets/sports/ncaa_fbs_logos/SIU.png -assets/sports/ncaa_fbs_logos/SLI.png -assets/sports/ncaa_fbs_logos/SOU.png -assets/sports/ncaa_fbs_logos/SPR.png -assets/sports/ncaa_fbs_logos/ST.png -assets/sports/ncaa_fbs_logos/STE.png -assets/sports/ncaa_fbs_logos/STET.png -assets/sports/ncaa_fbs_logos/STO.png -assets/sports/ncaa_fbs_logos/SUS.png -assets/sports/ncaa_fbs_logos/SUU.png -assets/sports/ncaa_fbs_logos/TA&M.png -assets/sports/ncaa_fbs_logos/TAY.png -assets/sports/ncaa_fbs_logos/TIF.png -assets/sports/ncaa_fbs_logos/TRI.png -assets/sports/ncaa_fbs_logos/TUF.png -assets/sports/ncaa_fbs_logos/TXST.png -assets/sports/ncaa_fbs_logos/UAPB.png -assets/sports/ncaa_fbs_logos/UCD.png -assets/sports/ncaa_fbs_logos/UCONN.png -assets/sports/ncaa_fbs_logos/ULM.png -assets/sports/ncaa_fbs_logos/UMD.png -assets/sports/ncaa_fbs_logos/UMDA.png -assets/sports/ncaa_fbs_logos/UML.png -assets/sports/ncaa_fbs_logos/UNA.png -assets/sports/ncaa_fbs_logos/UNCO.png -assets/sports/ncaa_fbs_logos/UND.png -assets/sports/ncaa_fbs_logos/UNH.png -assets/sports/ncaa_fbs_logos/UNI.png -assets/sports/ncaa_fbs_logos/UNNY.png -assets/sports/ncaa_fbs_logos/UNT.png -assets/sports/ncaa_fbs_logos/UPP.png -assets/sports/ncaa_fbs_logos/URI.png -assets/sports/ncaa_fbs_logos/USA.png -assets/sports/ncaa_fbs_logos/USD.png -assets/sports/ncaa_fbs_logos/UTC.png -assets/sports/ncaa_fbs_logos/UTI.png -assets/sports/ncaa_fbs_logos/VAL.png -assets/sports/ncaa_fbs_logos/VILL.png -assets/sports/ncaa_fbs_logos/VIR.png -assets/sports/ncaa_fbs_logos/VT.png -assets/sports/ncaa_fbs_logos/WAB.png -assets/sports/ncaa_fbs_logos/WAS.png -assets/sports/ncaa_fbs_logos/WAY.png -assets/sports/ncaa_fbs_logos/WES.png -assets/sports/ncaa_fbs_logos/WHE.png -assets/sports/ncaa_fbs_logos/WIL.png -assets/sports/ncaa_fbs_logos/WIN.png -assets/sports/ncaa_fbs_logos/WIS.png -assets/sports/ncaa_fbs_logos/WOR.png -assets/sports/ncaa_fbs_logos/YALE.png +assets/sports/ncaa_logos/AAMU.png +assets/sports/ncaa_logos/ACU.png +assets/sports/ncaa_logos/ADA.png +assets/sports/ncaa_logos/ADR.png +assets/sports/ncaa_logos/AIC.png +assets/sports/ncaa_logos/ALB.png +assets/sports/ncaa_logos/ALBS.png +assets/sports/ncaa_logos/ALCN.png +assets/sports/ncaa_logos/ALD.png +assets/sports/ncaa_logos/ALF.png +assets/sports/ncaa_logos/ALL.png +assets/sports/ncaa_logos/ALST.png +assets/sports/ncaa_logos/AMH.png +assets/sports/ncaa_logos/AND.png +assets/sports/ncaa_logos/ANG.png +assets/sports/ncaa_logos/ANN.png +assets/sports/ncaa_logos/APSU.png +assets/sports/ncaa_logos/ASH.png +assets/sports/ncaa_logos/ASP.png +assets/sports/ncaa_logos/ASU.png +assets/sports/ncaa_logos/AUG.png +assets/sports/ncaa_logos/AUR.png +assets/sports/ncaa_logos/AUS.png +assets/sports/ncaa_logos/AVE.png +assets/sports/ncaa_logos/AVI.png +assets/sports/ncaa_logos/AZU.png +assets/sports/ncaa_logos/BAK.png +assets/sports/ncaa_logos/BAL.png +assets/sports/ncaa_logos/BAT.png +assets/sports/ncaa_logos/BEC.png +assets/sports/ncaa_logos/BEL.png +assets/sports/ncaa_logos/BEN.png +assets/sports/ncaa_logos/BENT.png +assets/sports/ncaa_logos/BET.png +assets/sports/ncaa_logos/BHS.png +assets/sports/ncaa_logos/BIR.png +assets/sports/ncaa_logos/BKN.png +assets/sports/ncaa_logos/BLA.png +assets/sports/ncaa_logos/BLOM.png +assets/sports/ncaa_logos/BLU.png +assets/sports/ncaa_logos/BOW.png +assets/sports/ncaa_logos/BRI.png +assets/sports/ncaa_logos/BRWN.png +assets/sports/ncaa_logos/BST.png +assets/sports/ncaa_logos/BUCK.png +assets/sports/ncaa_logos/BUE.png +assets/sports/ncaa_logos/BUF.png +assets/sports/ncaa_logos/BUT.png +assets/sports/ncaa_logos/CAM.png +assets/sports/ncaa_logos/CAP.png +assets/sports/ncaa_logos/CAR.png +assets/sports/ncaa_logos/CARK.png +assets/sports/ncaa_logos/CAS.png +assets/sports/ncaa_logos/CAT.png +assets/sports/ncaa_logos/CCSU.png +assets/sports/ncaa_logos/CEN.png +assets/sports/ncaa_logos/CHA.png +assets/sports/ncaa_logos/CHI.png +assets/sports/ncaa_logos/CHSO.png +assets/sports/ncaa_logos/CLA.png +assets/sports/ncaa_logos/CLMB.png +assets/sports/ncaa_logos/COE.png +assets/sports/ncaa_logos/COL.png +assets/sports/ncaa_logos/COLC.png +assets/sports/ncaa_logos/COLG.png +assets/sports/ncaa_logos/CON.png +assets/sports/ncaa_logos/COR.png +assets/sports/ncaa_logos/CP.png +assets/sports/ncaa_logos/CRO.png +assets/sports/ncaa_logos/CSU.png +assets/sports/ncaa_logos/CUL.png +assets/sports/ncaa_logos/CUM.png +assets/sports/ncaa_logos/CUR.png +assets/sports/ncaa_logos/DAK.png +assets/sports/ncaa_logos/DART.png +assets/sports/ncaa_logos/DAV.png +assets/sports/ncaa_logos/DAY.png +assets/sports/ncaa_logos/DEF.png +assets/sports/ncaa_logos/DEL.png +assets/sports/ncaa_logos/DEN.png +assets/sports/ncaa_logos/DEP.png +assets/sports/ncaa_logos/DIC.png +assets/sports/ncaa_logos/DRKE.png +assets/sports/ncaa_logos/DSU.png +assets/sports/ncaa_logos/DUB.png +assets/sports/ncaa_logos/DUQ.png +assets/sports/ncaa_logos/EAS.png +assets/sports/ncaa_logos/EDI.png +assets/sports/ncaa_logos/EIU.png +assets/sports/ncaa_logos/EKU.png +assets/sports/ncaa_logos/ELI.png +assets/sports/ncaa_logos/ELM.png +assets/sports/ncaa_logos/ELON.png +assets/sports/ncaa_logos/EMO.png +assets/sports/ncaa_logos/EMP.png +assets/sports/ncaa_logos/END.png +assets/sports/ncaa_logos/EOR.png +assets/sports/ncaa_logos/ETSU.png +assets/sports/ncaa_logos/EUR.png +assets/sports/ncaa_logos/EWU.png +assets/sports/ncaa_logos/FAY.png +assets/sports/ncaa_logos/FDU.png +assets/sports/ncaa_logos/FER.png +assets/sports/ncaa_logos/FIN.png +assets/sports/ncaa_logos/FIT.png +assets/sports/ncaa_logos/FLA.png +assets/sports/ncaa_logos/FOR.png +assets/sports/ncaa_logos/FRA.png +assets/sports/ncaa_logos/FRO.png +assets/sports/ncaa_logos/FRST.png +assets/sports/ncaa_logos/FTLW.png +assets/sports/ncaa_logos/FUR.png +assets/sports/ncaa_logos/GAL.png +assets/sports/ncaa_logos/GAN.png +assets/sports/ncaa_logos/GEN.png +assets/sports/ncaa_logos/GEO.png +assets/sports/ncaa_logos/GET.png +assets/sports/ncaa_logos/GLE.png +assets/sports/ncaa_logos/GMU.png +assets/sports/ncaa_logos/GRA.png +assets/sports/ncaa_logos/GRE.png +assets/sports/ncaa_logos/GRI.png +assets/sports/ncaa_logos/GRO.png +assets/sports/ncaa_logos/GUI.png +assets/sports/ncaa_logos/GWEB.png +assets/sports/ncaa_logos/HAM.png +assets/sports/ncaa_logos/HAMP.png +assets/sports/ncaa_logos/HAN.png +assets/sports/ncaa_logos/HAR.png +assets/sports/ncaa_logos/HARV.png +assets/sports/ncaa_logos/HAS.png +assets/sports/ncaa_logos/HAW.png +assets/sports/ncaa_logos/HBU.png +assets/sports/ncaa_logos/HC.png +assets/sports/ncaa_logos/HEI.png +assets/sports/ncaa_logos/HEN.png +assets/sports/ncaa_logos/HIL.png +assets/sports/ncaa_logos/HIR.png +assets/sports/ncaa_logos/HOB.png +assets/sports/ncaa_logos/HOW.png +assets/sports/ncaa_logos/HUS.png +assets/sports/ncaa_logos/IDHO.png +assets/sports/ncaa_logos/IDST.png +assets/sports/ncaa_logos/ILST.png +assets/sports/ncaa_logos/ILW.png +assets/sports/ncaa_logos/IND.png +assets/sports/ncaa_logos/INST.png +assets/sports/ncaa_logos/IOW.png +assets/sports/ncaa_logos/ITH.png +assets/sports/ncaa_logos/JKST.png +assets/sports/ncaa_logos/JOH.png +assets/sports/ncaa_logos/JUN.png +assets/sports/ncaa_logos/KAL.png +assets/sports/ncaa_logos/KAN.png +assets/sports/ncaa_logos/KEN.png +assets/sports/ncaa_logos/KIN.png +assets/sports/ncaa_logos/KNO.png +assets/sports/ncaa_logos/KUT.png +assets/sports/ncaa_logos/KYST.png +assets/sports/ncaa_logos/KYW.png +assets/sports/ncaa_logos/LA.png +assets/sports/ncaa_logos/LAG.png +assets/sports/ncaa_logos/LAK.png +assets/sports/ncaa_logos/LAM.png +assets/sports/ncaa_logos/LAN.png +assets/sports/ncaa_logos/LAW.png +assets/sports/ncaa_logos/LEB.png +assets/sports/ncaa_logos/LEH.png +assets/sports/ncaa_logos/LEN.png +assets/sports/ncaa_logos/LEW.png +assets/sports/ncaa_logos/LIM.png +assets/sports/ncaa_logos/LIN.png +assets/sports/ncaa_logos/LOC.png +assets/sports/ncaa_logos/LOR.png +assets/sports/ncaa_logos/LUT.png +assets/sports/ncaa_logos/LYC.png +assets/sports/ncaa_logos/M-OH.png +assets/sports/ncaa_logos/MAC.png +assets/sports/ncaa_logos/MAI.png +assets/sports/ncaa_logos/MAN.png +assets/sports/ncaa_logos/MAR.png +assets/sports/ncaa_logos/MAS.png +assets/sports/ncaa_logos/MAY.png +assets/sports/ncaa_logos/MCM.png +assets/sports/ncaa_logos/MCN.png +assets/sports/ncaa_logos/MEN.png +assets/sports/ncaa_logos/MER.png +assets/sports/ncaa_logos/MERC.png +assets/sports/ncaa_logos/MES.png +assets/sports/ncaa_logos/MET.png +assets/sports/ncaa_logos/MH.png +assets/sports/ncaa_logos/MID.png +assets/sports/ncaa_logos/MIL.png +assets/sports/ncaa_logos/MIN.png +assets/sports/ncaa_logos/MIS.png +assets/sports/ncaa_logos/MNST.png +assets/sports/ncaa_logos/MONM.png +assets/sports/ncaa_logos/MONT.png +assets/sports/ncaa_logos/MOR.png +assets/sports/ncaa_logos/MORE.png +assets/sports/ncaa_logos/MORG.png +assets/sports/ncaa_logos/MOU.png +assets/sports/ncaa_logos/MRST.png +assets/sports/ncaa_logos/MSU.png +assets/sports/ncaa_logos/MTST.png +assets/sports/ncaa_logos/MTU.png +assets/sports/ncaa_logos/MUH.png +assets/sports/ncaa_logos/MUR.png +assets/sports/ncaa_logos/MUS.png +assets/sports/ncaa_logos/MVSU.png +assets/sports/ncaa_logos/NAU.png +assets/sports/ncaa_logos/NBY.png +assets/sports/ncaa_logos/NCAT.png +assets/sports/ncaa_logos/NCCU.png +assets/sports/ncaa_logos/NCST.png +assets/sports/ncaa_logos/NDOH.png +assets/sports/ncaa_logos/NDSU.png +assets/sports/ncaa_logos/NH.png +assets/sports/ncaa_logos/NICH.png +assets/sports/ncaa_logos/NMH.png +assets/sports/ncaa_logos/NMI.png +assets/sports/ncaa_logos/NOR.png +assets/sports/ncaa_logos/NORF.png +assets/sports/ncaa_logos/OBE.png +assets/sports/ncaa_logos/OHI.png +assets/sports/ncaa_logos/OKL.png +assets/sports/ncaa_logos/OLI.png +assets/sports/ncaa_logos/OMA.png +assets/sports/ncaa_logos/OTT.png +assets/sports/ncaa_logos/PAC.png +assets/sports/ncaa_logos/PENN.png +assets/sports/ncaa_logos/PIKE.png +assets/sports/ncaa_logos/PRE.png +assets/sports/ncaa_logos/PRI.png +assets/sports/ncaa_logos/PRIN.png +assets/sports/ncaa_logos/PST.png +assets/sports/ncaa_logos/RED.png +assets/sports/ncaa_logos/RICH.png +assets/sports/ncaa_logos/RIT.png +assets/sports/ncaa_logos/ROB.png +assets/sports/ncaa_logos/ROS.png +assets/sports/ncaa_logos/SAC.png +assets/sports/ncaa_logos/SAG.png +assets/sports/ncaa_logos/SDAK.png +assets/sports/ncaa_logos/SET.png +assets/sports/ncaa_logos/SIU.png +assets/sports/ncaa_logos/SLI.png +assets/sports/ncaa_logos/SOU.png +assets/sports/ncaa_logos/SPR.png +assets/sports/ncaa_logos/ST.png +assets/sports/ncaa_logos/STE.png +assets/sports/ncaa_logos/STET.png +assets/sports/ncaa_logos/STO.png +assets/sports/ncaa_logos/SUS.png +assets/sports/ncaa_logos/SUU.png +assets/sports/ncaa_logos/TA&M.png +assets/sports/ncaa_logos/TAY.png +assets/sports/ncaa_logos/TIF.png +assets/sports/ncaa_logos/TRI.png +assets/sports/ncaa_logos/TUF.png +assets/sports/ncaa_logos/TXST.png +assets/sports/ncaa_logos/UAPB.png +assets/sports/ncaa_logos/UCD.png +assets/sports/ncaa_logos/UCONN.png +assets/sports/ncaa_logos/ULM.png +assets/sports/ncaa_logos/UMD.png +assets/sports/ncaa_logos/UMDA.png +assets/sports/ncaa_logos/UML.png +assets/sports/ncaa_logos/UNA.png +assets/sports/ncaa_logos/UNCO.png +assets/sports/ncaa_logos/UND.png +assets/sports/ncaa_logos/UNH.png +assets/sports/ncaa_logos/UNI.png +assets/sports/ncaa_logos/UNNY.png +assets/sports/ncaa_logos/UNT.png +assets/sports/ncaa_logos/UPP.png +assets/sports/ncaa_logos/URI.png +assets/sports/ncaa_logos/USA.png +assets/sports/ncaa_logos/USD.png +assets/sports/ncaa_logos/UTC.png +assets/sports/ncaa_logos/UTI.png +assets/sports/ncaa_logos/VAL.png +assets/sports/ncaa_logos/VILL.png +assets/sports/ncaa_logos/VIR.png +assets/sports/ncaa_logos/VT.png +assets/sports/ncaa_logos/WAB.png +assets/sports/ncaa_logos/WAS.png +assets/sports/ncaa_logos/WAY.png +assets/sports/ncaa_logos/WES.png +assets/sports/ncaa_logos/WHE.png +assets/sports/ncaa_logos/WIL.png +assets/sports/ncaa_logos/WIN.png +assets/sports/ncaa_logos/WIS.png +assets/sports/ncaa_logos/WOR.png +assets/sports/ncaa_logos/YALE.png assets/sports/nhl_logos/ARI.png assets/sports/nhl_logos/VGS.png assets/sports/soccer_logos/DOR.png diff --git a/test/save_missing_teams.py b/test/save_missing_teams.py index 970b70b7..33c657ca 100644 --- a/test/save_missing_teams.py +++ b/test/save_missing_teams.py @@ -15,7 +15,7 @@ def save_missing_teams(): 'nba_logos': 'NBA', 'nfl_logos': 'NFL', 'nhl_logos': 'NHL', - 'ncaa_fbs_logos': ['NCAAF', 'NCAA Conferences/Divisions', 'NCAA_big10', 'NCAA_big12', 'NCAA_acc', 'NCAA_sec', 'NCAA_pac12', 'NCAA_american', 'NCAA_cusa', 'NCAA_mac', 'NCAA_mwc', 'NCAA_sunbelt', 'NCAA_ind', 'NCAA_ovc', 'NCAA_col', 'NCAA_usa', 'NCAA_bigw'], + 'ncaa_logos': ['NCAAF', 'NCAA Conferences/Divisions', 'NCAA_big10', 'NCAA_big12', 'NCAA_acc', 'NCAA_sec', 'NCAA_pac12', 'NCAA_american', 'NCAA_cusa', 'NCAA_mac', 'NCAA_mwc', 'NCAA_sunbelt', 'NCAA_ind', 'NCAA_ovc', 'NCAA_col', 'NCAA_usa', 'NCAA_bigw'], 'soccer_logos': ['Soccer - Premier League (England)', 'Soccer - La Liga (Spain)', 'Soccer - Bundesliga (Germany)', 'Soccer - Serie A (Italy)', 'Soccer - Ligue 1 (France)', 'Soccer - Champions League', 'Soccer - Other Teams'], 'milb_logos': 'MiLB' } @@ -143,7 +143,7 @@ def save_missing_teams(): elif 'NHL' in section: dir_name = 'nhl_logos' elif 'NCAA' in section: - dir_name = 'ncaa_fbs_logos' + dir_name = 'ncaa_logos' elif 'Soccer' in section: dir_name = 'soccer_logos' elif 'MiLB' in section: diff --git a/test/test_leaderboard_simple.py b/test/test_leaderboard_simple.py index f65fb081..36c30569 100644 --- a/test/test_leaderboard_simple.py +++ b/test/test_leaderboard_simple.py @@ -185,8 +185,8 @@ def test_logo_loading(): "assets/sports/nba_logos/nba.png", "assets/sports/mlb_logos/mlb.png", "assets/sports/nhl_logos/nhl.png", - "assets/sports/ncaa_fbs_logos/ncaa_fb.png", - "assets/sports/ncaa_fbs_logos/ncaam.png" + "assets/sports/ncaa_logos/ncaa_fb.png", + "assets/sports/ncaa_logos/ncaam.png" ] for logo_path in league_logos: diff --git a/test/test_ranking_toggle.py b/test/test_ranking_toggle.py index 703e32e7..fb494c72 100644 --- a/test/test_ranking_toggle.py +++ b/test/test_ranking_toggle.py @@ -164,7 +164,7 @@ def test_ncaa_fb_ranking_toggle(): 'enabled': True, 'show_records': True, 'show_ranking': True, - 'logo_dir': 'assets/sports/ncaa_fbs_logos', + 'logo_dir': 'assets/sports/ncaa_logos', 'display_modes': { 'ncaa_fb_live': True, 'ncaa_fb_recent': True, @@ -180,7 +180,7 @@ def test_ncaa_fb_ranking_toggle(): 'enabled': True, 'show_records': False, 'show_ranking': True, - 'logo_dir': 'assets/sports/ncaa_fbs_logos', + 'logo_dir': 'assets/sports/ncaa_logos', 'display_modes': { 'ncaa_fb_live': True, 'ncaa_fb_recent': True, @@ -196,7 +196,7 @@ def test_ncaa_fb_ranking_toggle(): 'enabled': True, 'show_records': True, 'show_ranking': False, - 'logo_dir': 'assets/sports/ncaa_fbs_logos', + 'logo_dir': 'assets/sports/ncaa_logos', 'display_modes': { 'ncaa_fb_live': True, 'ncaa_fb_recent': True, @@ -212,7 +212,7 @@ def test_ncaa_fb_ranking_toggle(): 'enabled': True, 'show_records': False, 'show_ranking': False, - 'logo_dir': 'assets/sports/ncaa_fbs_logos', + 'logo_dir': 'assets/sports/ncaa_logos', 'display_modes': { 'ncaa_fb_live': True, 'ncaa_fb_recent': True,