mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-04-11 21:33:00 +00:00
fix(security): comprehensive error handling cleanup
- Remove all traceback.format_exc() from client responses (33 remaining instances) - Sanitize str(e) from client-facing messages, replacing with generic error messages - Replace ~65 bare print() calls with structured logger.exception/error/warning/info/debug - Remove ~35 redundant inline `import traceback` and `import logging` statements - Convert logging.error/warning calls to use module-level named logger - Fix WiFi endpoints that created redundant inline logger instances - Add logger.exception() at all WebInterfaceError.from_exception() call sites - Fix from_exception() in errors.py to use safe messages instead of raw str(exception) - Apply consistent [Tag] prefixes to all logger calls for production triage Only safe, user-input-derived str(e) kept: json.JSONDecodeError handlers (400 responses). Subprocess template print(stdout) calls preserved (not error logging). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -214,12 +214,40 @@ class WebInterfaceError:
|
||||
|
||||
return cls(
|
||||
error_code=error_code,
|
||||
message=str(exception),
|
||||
message=cls._safe_message(error_code),
|
||||
details=cls._get_exception_details(exception),
|
||||
context=error_context,
|
||||
original_error=exception
|
||||
)
|
||||
|
||||
|
||||
@classmethod
|
||||
def _safe_message(cls, error_code: ErrorCode) -> str:
|
||||
"""Get a safe, user-facing message for an error code."""
|
||||
messages = {
|
||||
ErrorCode.CONFIG_SAVE_FAILED: "Failed to save configuration",
|
||||
ErrorCode.CONFIG_LOAD_FAILED: "Failed to load configuration",
|
||||
ErrorCode.CONFIG_VALIDATION_FAILED: "Configuration validation failed",
|
||||
ErrorCode.CONFIG_ROLLBACK_FAILED: "Failed to rollback configuration",
|
||||
ErrorCode.PLUGIN_NOT_FOUND: "Plugin not found",
|
||||
ErrorCode.PLUGIN_INSTALL_FAILED: "Failed to install plugin",
|
||||
ErrorCode.PLUGIN_UPDATE_FAILED: "Failed to update plugin",
|
||||
ErrorCode.PLUGIN_UNINSTALL_FAILED: "Failed to uninstall plugin",
|
||||
ErrorCode.PLUGIN_LOAD_FAILED: "Failed to load plugin",
|
||||
ErrorCode.PLUGIN_OPERATION_CONFLICT: "A plugin operation is already in progress",
|
||||
ErrorCode.VALIDATION_ERROR: "Validation error",
|
||||
ErrorCode.SCHEMA_VALIDATION_FAILED: "Schema validation failed",
|
||||
ErrorCode.INVALID_INPUT: "Invalid input",
|
||||
ErrorCode.NETWORK_ERROR: "Network error",
|
||||
ErrorCode.API_ERROR: "API error",
|
||||
ErrorCode.TIMEOUT: "Operation timed out",
|
||||
ErrorCode.PERMISSION_DENIED: "Permission denied",
|
||||
ErrorCode.FILE_PERMISSION_ERROR: "File permission error",
|
||||
ErrorCode.SYSTEM_ERROR: "A system error occurred",
|
||||
ErrorCode.SERVICE_UNAVAILABLE: "Service unavailable",
|
||||
ErrorCode.UNKNOWN_ERROR: "An unexpected error occurred",
|
||||
}
|
||||
return messages.get(error_code, "An unexpected error occurred")
|
||||
|
||||
@classmethod
|
||||
def _infer_error_code(cls, exception: Exception) -> ErrorCode:
|
||||
"""Infer error code from exception type."""
|
||||
|
||||
File diff suppressed because it is too large
Load Diff
Reference in New Issue
Block a user