mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-10-04 14:25:08 +00:00

Files

T

ChuckandClaude Opus 5.5 724673ba0b fix: one retry layer for background fetches; CI installs the web requirements; one Discord invite (#657 )

- BackgroundDataService: the session adapter retried connection errors 3x
  inside each attempt of the service's own retry loop (up to 16 connection
  attempts per request on a dead network). The adapter no longer retries;
  ESPN date chunks, which bypass the loop and skip a failed chunk, get a
  small connection retry of their own (_ConnectionRetryingSession).
- CI installs web_interface/requirements.txt. The brotli header test now
  checks its intent (core never hand-sets br; requests may advertise it when
  a decoder is installed) instead of failing whenever brotli is present.
- Every Discord link uses the LEDMatrix server's invite (RdrC37rEag).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

2026-09-28 11:08:43 -04:00

4.4 KiB

Raw Blame History

Contributing to LEDMatrix

Thanks for considering a contribution! LEDMatrix is built with help from the community and we welcome bug reports, plugins, documentation improvements, and code changes.

Quick links

Bugs / feature requests: open an issue using one of the templates in .github/ISSUE_TEMPLATE/.
Real-time discussion: the LEDMatrix Discord.
Plugin development: docs/PLUGIN_DEVELOPMENT_GUIDE.md and the ledmatrix-plugins repository.
Security issues: see SECURITY.md. Please don't open public issues for vulnerabilities.

Setting up a development environment

Clone with submodules:

git clone --recurse-submodules https://github.com/ChuckBuilds/LEDMatrix.git
cd LEDMatrix

For development without hardware, run the dev preview server:
```
python3 scripts/dev_server.py
# then open http://localhost:5001
```
See docs/DEV_PREVIEW.md for details.
To run the full display in emulator mode:
```
EMULATOR=true python3 run.py
```
To target real hardware on a Raspberry Pi, follow the install instructions in the root README.md.

Running the tests

pip install -r requirements.txt -r requirements-test.txt
pytest

See docs/HOW_TO_RUN_TESTS.md for details on test markers, the per-plugin tests, and the web-interface integration tests.

Submitting changes

Open an issue first for non-trivial changes. This avoids wasted work on PRs that don't fit the project direction.
Create a topic branch off main: feat/<short-description>, fix/<short-description>, docs/<short-description>.
Keep PRs focused. One conceptual change per PR. If you find adjacent bugs while working, fix them in a separate PR.
Follow the existing code style. The pre-commit hooks run flake8 (E9, F63, F7, F82 plus bugbear B checks), bandit, and gitleaks — install the CLI with python -m pip install pre-commit, then run pre-commit install so they run on every commit. mypy on src/ is a manual hook while existing type errors are paid down (pre-commit run mypy --hook-stage manual): please don't add new errors in the files you touch. HTML/JS in web_interface/ follows the patterns already in templates/v3/ and static/v3/.
Update documentation alongside code changes. If you add a config key, document it in the relevant *.md file (or, for plugins, in config_schema.json so the form is auto-generated).
Run the tests locally before opening the PR.
Use the PR template — .github/PULL_REQUEST_TEMPLATE.md will prompt you for what we need.

Commit message convention

Conventional Commits is encouraged but not strictly enforced:

feat: add NHL playoff bracket display
fix(plugin-loader): handle missing class_name in manifest
docs: correct web UI port in TROUBLESHOOTING.md
refactor(cache): consolidate strategy lookup

Keep the subject under 72 characters; put the why in the body.

Contributing a plugin

LEDMatrix plugins live in their own repository: ledmatrix-plugins. Plugin contributions go through that repo's SUBMISSION.md process. The hello-world plugin is the canonical starter template.

Reviewing pull requests

Maintainer review is by @ChuckBuilds. Community review is welcome on any open PR — leave constructive comments, test on your hardware if applicable, and call out anything unclear.

Code of conduct

This project follows the Contributor Covenant. By participating you agree to abide by its terms.

License

LEDMatrix is licensed under the GNU General Public License v3.0 or later. By submitting a contribution you agree to license it under the same terms (the standard "inbound = outbound" rule that GitHub applies by default).

LEDMatrix builds on rpi-rgb-led-matrix, which is GPL-2.0-or-later. The "or later" clause makes it compatible with GPL-3.0 distribution.

4.4 KiB Raw Blame History