mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-13 10:36:35 +00:00
update_plugin() returns True both for a real update and for "nothing to do" (a ZIP-installed monorepo plugin already at the registry version, a bundled plugin). With no git commit to compare, POST /plugins/update called every such success "updated successfully", so Check & Update All counted most official plugins as updated on every run. The route now reads what changed off the plugin itself (commit, else manifest version, else last_updated) and returns data.update_status (updated / up_to_date / local_only). The update-all toast is summarised by PluginInstallManager.summarizeUpdateResults from that status, falling back to the message for older servers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
234 lines
9.0 KiB
JavaScript
234 lines
9.0 KiB
JavaScript
/**
|
|
* Plugin installation and update management.
|
|
*
|
|
* Handles plugin installation, updates, and uninstallation operations.
|
|
*/
|
|
|
|
const PluginInstallManager = {
|
|
/**
|
|
* Install a plugin.
|
|
*
|
|
* @param {string} pluginId - Plugin identifier
|
|
* @param {string} branch - Optional branch name to install from
|
|
* @returns {Promise<Object>} Installation result
|
|
*/
|
|
async install(pluginId, branch = null) {
|
|
try {
|
|
const result = await window.PluginAPI.installPlugin(pluginId, branch);
|
|
|
|
// Refresh installed plugins list
|
|
if (window.PluginStateManager) {
|
|
await window.PluginStateManager.loadInstalledPlugins();
|
|
}
|
|
|
|
return result;
|
|
} catch (error) {
|
|
if (window.errorHandler) {
|
|
window.errorHandler.displayError(error, `Failed to install plugin ${pluginId}`);
|
|
}
|
|
throw error;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Update a plugin.
|
|
*
|
|
* @param {string} pluginId - Plugin identifier
|
|
* @returns {Promise<Object>} Update result
|
|
*/
|
|
async update(pluginId) {
|
|
try {
|
|
const result = await window.PluginAPI.updatePlugin(pluginId);
|
|
|
|
// Refresh installed plugins list
|
|
if (window.PluginStateManager) {
|
|
await window.PluginStateManager.loadInstalledPlugins();
|
|
}
|
|
|
|
return result;
|
|
} catch (error) {
|
|
if (window.errorHandler) {
|
|
window.errorHandler.displayError(error, `Failed to update plugin ${pluginId}`);
|
|
}
|
|
throw error;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Uninstall a plugin.
|
|
*
|
|
* @param {string} pluginId - Plugin identifier
|
|
* @returns {Promise<Object>} Uninstall result
|
|
*/
|
|
async uninstall(pluginId) {
|
|
try {
|
|
const result = await window.PluginAPI.uninstallPlugin(pluginId);
|
|
|
|
// Refresh installed plugins list
|
|
if (window.PluginStateManager) {
|
|
await window.PluginStateManager.loadInstalledPlugins();
|
|
}
|
|
|
|
return result;
|
|
} catch (error) {
|
|
if (window.errorHandler) {
|
|
window.errorHandler.displayError(error, `Failed to uninstall plugin ${pluginId}`);
|
|
}
|
|
throw error;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Whether POST /plugins/update can update this installed-list entry.
|
|
*
|
|
* /plugins/installed also lists installed Starlark apps as virtual
|
|
* `starlark:<app_id>` entries (flagged `is_starlark_app`) so they can be
|
|
* seen and toggled with everything else. They are not plugin directories:
|
|
* the plugin updater has nothing to update for them, and there is no
|
|
* Starlark update route (reinstalling from the repository would reset the
|
|
* app's saved settings), so they are left out of update-all.
|
|
*
|
|
* @param {Object} plugin - Entry from /plugins/installed
|
|
* @returns {boolean}
|
|
*/
|
|
isUpdatablePlugin(plugin) {
|
|
if (!plugin || typeof plugin.id !== 'string' || !plugin.id) return false;
|
|
return !plugin.is_starlark_app && !plugin.id.startsWith('starlark:');
|
|
},
|
|
|
|
/**
|
|
* The entries update-all sends to POST /plugins/update, in list order.
|
|
*
|
|
* @param {Array} plugins - Entries from /plugins/installed
|
|
* @returns {Array}
|
|
*/
|
|
updatablePlugins(plugins) {
|
|
return (Array.isArray(plugins) ? plugins : []).filter(p => this.isUpdatablePlugin(p));
|
|
},
|
|
|
|
/**
|
|
* Backoff (ms) before re-sending an update whose request never got an
|
|
* answer. Covers a web-service restart (~3s on a Pi) with room to spare.
|
|
*/
|
|
NETWORK_RETRY_DELAYS_MS: [1000, 2000, 4000, 8000, 15000],
|
|
|
|
/**
|
|
* Update all plugins.
|
|
*
|
|
* @param {Function} onProgress - Optional callback(index, total, pluginId) for progress updates
|
|
* @param {Object} options - Optional { sleep(ms), retryDelaysMs } (tests inject these)
|
|
* @returns {Promise<Array>} Update results, one per plugin sent
|
|
*/
|
|
async updateAll(onProgress, options = {}) {
|
|
// Prefer PluginStateManager if populated, fall back to window.installedPlugins
|
|
// (plugins_manager.js populates window.installedPlugins independently)
|
|
const stateManagerPlugins = window.PluginStateManager && window.PluginStateManager.installedPlugins;
|
|
const listed = (stateManagerPlugins && stateManagerPlugins.length > 0)
|
|
? stateManagerPlugins
|
|
: (window.installedPlugins || []);
|
|
// Snapshot: the list can be replaced while this loop is awaiting.
|
|
const plugins = this.updatablePlugins(listed);
|
|
|
|
if (!plugins.length) {
|
|
return [];
|
|
}
|
|
const sleep = options.sleep || (ms => new Promise(resolve => setTimeout(resolve, ms)));
|
|
const retryDelays = options.retryDelaysMs || this.NETWORK_RETRY_DELAYS_MS;
|
|
const results = [];
|
|
|
|
for (let i = 0; i < plugins.length; i++) {
|
|
const plugin = plugins[i];
|
|
if (onProgress) onProgress(i + 1, plugins.length, plugin.id);
|
|
// Each plugin gets its own pass over the backoff schedule.
|
|
const pendingDelays = retryDelays.slice();
|
|
for (;;) {
|
|
try {
|
|
const result = await window.PluginAPI.updatePlugin(plugin.id);
|
|
results.push({ pluginId: plugin.id, success: true, result });
|
|
break;
|
|
} catch (error) {
|
|
// No HTTP answer at all (connection refused/reset, e.g. the
|
|
// web service restarting mid-run): the server never saw or
|
|
// never finished this plugin, so send it again once it is
|
|
// back rather than skipping it. An HTTP error response is
|
|
// the server's answer and is not retried.
|
|
if (error && error.error_code === 'NETWORK_ERROR' && pendingDelays.length > 0) {
|
|
await sleep(pendingDelays.shift());
|
|
continue;
|
|
}
|
|
results.push({ pluginId: plugin.id, success: false, error });
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
// Reload plugin list once at the end
|
|
if (window.PluginStateManager) {
|
|
await window.PluginStateManager.loadInstalledPlugins();
|
|
}
|
|
|
|
return results;
|
|
},
|
|
|
|
/**
|
|
* Classify one POST /plugins/update answer.
|
|
*
|
|
* The route reports what actually happened in `data.update_status`
|
|
* (`updated`, `up_to_date`, `local_only`). A plugin the updater had
|
|
* nothing to do for -- e.g. a ZIP-installed monorepo plugin already at the
|
|
* registry version -- is still a success response, so it must not be
|
|
* counted as updated. Older servers only say so in the message.
|
|
*
|
|
* @param {Object} entry - One element of updateAll()'s results
|
|
* @returns {string} 'failed' | 'updated' | 'up_to_date' | 'local_only'
|
|
*/
|
|
updateOutcome(entry) {
|
|
if (!entry || !entry.success) return 'failed';
|
|
const result = entry.result || {};
|
|
const status = result.data && result.data.update_status;
|
|
if (status === 'up_to_date' || status === 'local_only' || status === 'updated') {
|
|
return status;
|
|
}
|
|
const message = typeof result.message === 'string' ? result.message : '';
|
|
if (message.includes('already up to date')) return 'up_to_date';
|
|
if (message.includes('managed locally')) return 'local_only';
|
|
return 'updated';
|
|
},
|
|
|
|
/**
|
|
* Summarise updateAll()'s results for the Check & Update All toast.
|
|
*
|
|
* @param {Array} results - updateAll()'s results
|
|
* @returns {{updated: number, upToDate: number, localOnly: number, failed: number, text: string, type: string}}
|
|
*/
|
|
summarizeUpdateResults(results) {
|
|
const counts = { updated: 0, up_to_date: 0, local_only: 0, failed: 0 };
|
|
for (const entry of (Array.isArray(results) ? results : [])) {
|
|
counts[this.updateOutcome(entry)]++;
|
|
}
|
|
const parts = [];
|
|
if (counts.updated > 0) parts.push(`${counts.updated} updated`);
|
|
if (counts.up_to_date > 0) parts.push(`${counts.up_to_date} already up to date`);
|
|
if (counts.local_only > 0) parts.push(`${counts.local_only} managed locally`);
|
|
if (counts.failed > 0) parts.push(`${counts.failed} failed`);
|
|
const type = counts.failed > 0 ? (counts.updated > 0 ? 'warning' : 'error') : 'success';
|
|
return {
|
|
updated: counts.updated,
|
|
upToDate: counts.up_to_date,
|
|
localOnly: counts.local_only,
|
|
failed: counts.failed,
|
|
text: parts.join(', '),
|
|
type
|
|
};
|
|
}
|
|
};
|
|
|
|
// Export
|
|
if (typeof module !== 'undefined' && module.exports) {
|
|
module.exports = PluginInstallManager;
|
|
} else {
|
|
window.PluginInstallManager = PluginInstallManager;
|
|
window.updateAllPlugins = (onProgress) => PluginInstallManager.updateAll(onProgress);
|
|
}
|
|
|