* docs: add ARCHITECTURE and PERMISSIONS guides ARCHITECTURE.md maps the processes, the state the display and web services share through the cache, the display loop, the plugin system, the web UI and the update path, with links into the code and a where-to-start table. PERMISSIONS.md lists who owns what after install, both sudoers files (and why iptables is not granted), the polkit rule, and which scripts/fix_perms script to run as which user. Both are linked from the docs index, along with the MQTT bridge README and src/common/README.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: correct stale setup, service and troubleshooting claims - README: quick actions run systemctl on ledmatrix.service (run.py), not display_controller.py; use_short_date_format has no effect; the installer uses system pip with --break-system-packages, not a venv. - CONFIG_DEBUGGING: LEDMATRIX_DEBUG must be "true"; logs are in journald. - GETTING_STARTED, WEB_INTERFACE_GUIDE, TROUBLESHOOTING: enabling a plugin, plugin settings, brightness and Vegas settings apply without a restart; matrix hardware settings still need one. - TROUBLESHOOTING: install dependencies with sudo so the root service sees them; point permission problems at PERMISSIONS.md instead of a project-wide chown. - ADVANCED_FEATURES: real BackgroundDataService stats keys; Vegas hooks return VegasDisplayMode and None falls back to capture; cache files are 0660; fix_web_permissions.sh runs as the web user and does not touch sudoers. - STARLARK_APPS_GUIDE: only the linux-arm64 pixlet binary is downloaded. - HOW_TO_RUN_TESTS: test class examples that exist. - CLAUDE.md: PluginStoreManager, plugin_dirs.py, monorepo installs via the Trees API with ZIP fallback, requirements.txt is optional. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: mark deprecated plugin APIs and state manifest fields once Methods @deprecated("3.7.0") (the set pinned in test_deprecation.py) were shown as current API in the quick reference, API reference, advanced guide, development guide and FONT_MANAGER. Each is now marked deprecated with its replacement. FONT_MANAGER is rewritten around the current API; the override editor is gone and override methods are deprecated. Required manifest fields were stated three different ways. The API reference now has one section: the 7 schema-required fields, the 4 the store refuses without, class_name for the loader, and the 8 to set. The other guides link to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: document every src/common module and every widget - src/common/README.md covered 7 of 17 modules. It now has a table of all of them (purpose, whether plugins import it, release to floor on), a short entry each, and logging advice that matches the code. - SPORTS_UNIFICATION listed two shared modules and called sports_helpers the first; it now lists all six. - The widgets README lists all 28 registered widgets plus the support files, and absorbs the parts that only docs/widget-guide.md had (x-options.labels, x-advanced, x-display hidden, plugin-file-manager). docs/widget-guide.md is now a pointer to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): fix_web_permissions.sh re-hardens the root sudo helpers The script chowns the whole project to the web user. That included scripts/fix_perms/safe_plugin_rm.sh and safe_pip_install.sh -- the two helpers /etc/sudoers.d/ledmatrix_web lets the web user run as root -- so running it turned both into a root shell for whoever can edit them. It also re-grouped config_secrets.json away from ledmatrix. After the chown it now does what first_time_install.sh's Steps 11 and 11.1 do: helpers back to root:root 755, and config_secrets.json back to the web unit's User=:ledmatrix 640. Each step is non-fatal and prints the manual command if it fails. Also fixes what the script and its docs claimed: it never configured sudoers, its closing hint pointed at ./configure_web_sudo.sh (wrong path), and the README and ADVANCED_FEATURES.md said to run it with sudo, which it refuses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(security): validate and harden every sudoers drop-in the scripts write configure_wifi_permissions.sh copied its rules into /etc/sudoers.d/ledmatrix_wifi without `visudo -c`. A malformed drop-in makes sudo refuse every command for every user, which on a headless Pi leaves no way back in. It now checks first and leaves the installed file alone when the rules do not parse, as the other two writers do. (It already used mktemp, so that part of the review did not apply.) It also grants the two literal commands wifi_manager.py runs for NetworkManager's shared-mode dnsmasq drop-in -- `cp /tmp/ledmatrix-nm-dnsmasq.conf .../dnsmasq-shared.d/ledmatrix-captive.conf` and `rm -f` of that file. The directory's mkdir was granted, the file was not. Both are pinned in test_sudo_allowlist_covers_calls.py. configure_web_sudo.sh wrote its rules to /tmp/ledmatrix_web_sudoers_$$, a predictable name in a world-writable directory; it now uses mktemp with an EXIT trap, as first_time_install.sh does. It sets mode 440 on the installed file instead of leaving the temp file's mode, and finds visudo in /usr/sbin when that is not on the user's PATH, which skipped the check silently. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): escape the project path in the DNS-fix and MQTT unit renderers install_dns_fix.sh and install_mqtt_bridge.sh substituted __PROJECT_ROOT_DIR__ with the raw path, while the other three renderers go through sed_escape_replacement from lib_systemd_render.sh. A checkout under a path containing `&`, `\` or `|` rendered a corrupted unit from these two only. Both now source the helper and use it, and a test checks that every placeholder substitution in scripts/install uses an escaped value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): stop the installer scripts reporting things that are not true - first_time_install.sh printed "Password: ledmatrix123" for the setup access point. wifi_manager creates it as an open network ("No password" on the panel), so it now says so. - Step 10.1 printed "✓ WiFi management permissions configured" straight after its own failure message; install_wifi_monitor.sh printed "✓ Package installation completed" after a failed apt install. The tick now only follows success. - Step 7 printed "Web dependencies already installed ... in Step 5" in the one branch that runs because Step 5 did not install them, then created .web_deps_installed on that basis. It now warns and leaves the marker off so the next run retries, as the comment below it intends. - check_system_compatibility.sh called Debian 12 Bookworm "full compatibility confirmed" while first_time_install.sh refuses anything but Debian 13. Bookworm, older Debian and non-Debian systems are now errors. Its counters used ((X++)), which under `set -e` exits the script at the first warning or error (the expression is 0), so the check never reached its summary on any system with one. - configure_web_sudo.sh and configure_wifi_permissions.sh finished by testing `sudo -n test -f ...` and `sudo -n nmcli device status`, neither of which is granted, so they always reported a failure. They now ask `sudo -n -l` about commands the new rules do grant, which checks the rule without running anything. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(install): print the completion summary before rebooting With -y -- and so for every one-shot `curl | bash` install, which always passes -y -- first_time_install.sh ran `reboot` about 180 lines before its "Installation Complete / Web UI Access" summary. reboot returns at once, so the summary printed while the Pi was going down and the SSH session usually dropped before the web UI address could be read. The reboot block moves, unchanged, to the very end of the script. The interactive prompt now also follows the summary. Because the summary now runs before the -y reboot, its one command that could fail under `set -Eeuo pipefail` (the SSID lookup, when nmcli reports a connected device but no active network line) gets `|| true`; a missing SSID was already handled as "SSID unknown". one-shot-install.sh prints its "Next steps" after the installer returns, by which time the reboot is under way, so it now says so, and README's Quick Install mentions the automatic reboot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(scripts): correct wrong comments and messages, drop dead code No behaviour change except the output text noted below. - 2775 is setgid, not the sticky bit (first_time_install.sh Step 3.1, fix_plugin_permissions.sh), and root needs no "PWM hardware access" to plugin files. - The 777 comments in first_time_install.sh Step 3's fallback and fix_assets_permissions.sh said root needs it to write. Root ignores mode bits; the comments now say what 777 actually opens. The 777 itself is unchanged. - apt_remove ends in `|| true`, so Step 12's "Some packages could not be removed" branch could never run; it is gone and the helper stays non-fatal. - detect_web_service_user's comment named Step 8 for the web unit (install_service.sh installs it in Step 7.5) and now says which branch actually runs. - Step 5 described an "already installed" check that does not exist; the ACTUAL_USER comment described the re-exec backwards. - on_error printed a literal "\n" before "Common fixes:". - Dead code: one-shot-install.sh's uncalled fix_tmp_permissions, LEDMATRIX_ELEVATED=1 (never read) on the sudo re-exec, and configure_web_sudo.sh's unused PYTHON_PATH, which also made a missing python3 fatal for rules that never mention it. - start_display.sh / stop_display.sh said "for user: <you>"; the service runs as root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(fix_perms): fix_cache_permissions.sh uses setup_cache.sh's model There were two models for /var/cache/ledmatrix. setup_cache.sh (the installer's Step 2) and install_web_service.sh share it through the ledmatrix group: root:ledmatrix, 2775, files 660, which is also what DiskCache relies on to give files the directory's group. fix_cache_permissions.sh instead made it 777 and re-grouped it to the invoking user's group, undoing that. It now runs setup_cache.sh for /var/cache/ledmatrix and keeps its own handling of ~/.ledmatrix_cache. Dropped: /var/cache/ledmatrix/ placeholder_logos (nothing reads it) and the checks against the `daemon` user (no service runs as daemon). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: pin actions/checkout in the Claude workflows, drop template comments claude.yml and claude-code-review.yml used actions/checkout@v4 while test.yml and release-version-check.yml pin the v4.2.2 commit SHA; they now pin the same SHA. The commented-out starter-template settings (prompt, claude_args, paths, author filter) are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(scripts): index every script and list removal candidates New scripts/README.md gives one line per top-level script and scripts directory, marked keep, dev-only or diagnostic, and lists the eight scripts nothing in the repo refers to as candidates for removal (kept for now). The install, utils and dev READMEs now list the files they were missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: tighten two checks that mutation testing showed were too loose - The wifi sudoers check matched `visudo -c -f "$TEMP_SUDOERS"` in the error report too, so replacing the check with `if false` still passed. It now requires the command as the condition. - The summary test never had the setup access point up, so reinstating the bogus "Password: ledmatrix123" line went unnoticed. A case with hostapd active now checks the AP is described as open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(permissions): describe the repaired fix_perms scripts and new WiFi grants Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): docs-scripts Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
12 KiB
src/common
Helpers shared by core and plugins. This page lists every module, what it is for, and whether plugins are expected to import it.
Rules for the package:
- Every module must import without display hardware: nothing here may import
src.display_managerorsrc.plugin_systemat module level (test/test_common_is_hardware_free.py). That keeps plugins that use it loadable by the web preview,scripts/check_plugin.pyand tests on a laptop. - A plugin that imports a module added in a given core release must declare
that release as its minimum (
ledmatrix_min_versionin the manifest'sversionsentry). The "Since" column gives the release; "—" means it predates 3.1.0, "n/a" that plugins should not import it. from src.common import ...re-exportsAPIHelper,ScrollHelper,LogoHelper,TextHelper,scroll_config(plusScrollSettings,configure_scroll,resolve_scroll_settings,refresh_hz_from_config) and the adaptive layout names below (__init__.py).
Summary
| Module | For | Plugins import it? | Since |
|---|---|---|---|
api_helper |
HTTP GET/POST with caching and rate limiting | Yes | — |
bdf_font |
Load and draw BDF bitmap fonts | Yes, if drawing BDF text directly | Unreleased |
espn_dates |
Fetch ESPN scoreboards across a date range | Yes (scoreboards) | 3.5.0 |
font_layout |
Reproducible TrueType loading, crisp sizes | Yes | 3.4.0 |
logo_helper |
Load, resize and cache team logos | Yes | — |
path_safety |
Turn request-supplied names into safe paths | No, core-internal | n/a |
permission_utils |
File modes and shared-group ownership | Rarely | — |
scroll_config |
Plugin scroll config → configured ScrollHelper |
Yes (scrollers) | 3.4.0 |
scroll_helper |
Pre-rendered horizontal scrolling | Yes | — |
snapshot_policy |
When to write the web preview frame | No, core-internal | n/a |
sports_card |
Scoreboard card settings, colours, fonts, dates | Yes (scoreboards) | 3.3.0 |
sports_game_renderer |
Scoreboard scroll/Vegas card geometry | Yes (scoreboards) | 3.3.0 |
sports_helpers |
Small helpers every scoreboard sports.py copies |
Yes (scoreboards) | 3.5.0 |
sports_scroll |
Scoreboard scroll-display orchestration | Yes (scoreboards) | 3.2.0 |
sports_shared |
Sport-independent sports.py methods |
Yes (scoreboards) | 3.3.0 |
sync_manager |
Leader/follower sync between two displays | No, core-internal | n/a |
text_helper |
Outlined text, wrapping, measurement | Yes | — |
The four sports_* mixin and card modules hold code the scoreboard plugins
used to carry as identical copies. Each module docstring lists what a host
class must provide. The plan behind them is in
docs/SPORTS_UNIFICATION.md.
Adaptive layout and images
src/adaptive_layout.py and src/adaptive_images.py live outside this
package but are re-exported from src.common. They are the recommended way
to lay out a plugin that renders legibly on any panel size. Every
BasePlugin already has self.layout, self.draw_fit() and
self.draw_image():
regs = scoreboard_regions(self.layout.bounds, ctx=self.layout)
self.draw_image(away_logo, regs.away_slot, mode="fill_height",
crop_to_ink=True, cache_key=f"logo:{abbr}")
self.draw_fit(score_text, regs.score_area) # largest crisp font that fits
Key pieces: Region, the font ladders LADDER_GRID / LADDER_ARCADE,
LayoutContext (fit_text, fit_image, by_tier, px), and
scoreboard_regions() / media_row(). Guide:
docs/ADAPTIVE_LAYOUT.md.
Modules
api_helper
api_helper.py. APIHelper(cache_manager=None, ...):
get() and post() with retries, optional caching through the cache
manager, and a minimum interval between requests (set_rate_limit()). Also has
fetch_espn_scoreboard(), fetch_espn_standings() and
fetch_espn_rankings().
bdf_font
bdf_font.py. The one BDF loader and rasterizer.
load_bdf_face(path, size) returns (face, realised_px), falling back to
the file's native strike when it has none at size;
draw_bdf_text(draw, text, x, y, face, color) draws top-left anchored onto a
PIL ImageDraw the same way the panel does. read_bdf_native_size(path)
and clear_face_cache() round it out. Faces are cached per thread (FreeType
faces are not thread-safe). DisplayManager, FontManager, element_style
and the plugin test harness all use it. Most plugins get BDF text through
display_manager.draw_text() or FontManager and never import this.
espn_dates
espn_dates.py. ESPN's site API rejects dates= ranges
and truncates results when limit is above 500. fetch_espn_scoreboard()
splits a range into month and day requests ESPN accepts and merges the
results; espn_date_chunks(), fetch_espn_date_chunks(),
clamp_espn_limit() and merge_scoreboard_payloads() are the pieces.
Scoreboard plugins also bundle a copy for older cores.
font_layout
font_layout.py. load_truetype(path, size) is
ImageFont.truetype with PIL's Basic layout engine pinned, so text lays out
the same whether or not the host Pillow has libraqm; use it for anything
drawn to the panel or compared against a golden image. crisp_size() gives
the size a bundled face renders on whole pixels at. resolve_asset_path()
resolves assets/fonts/... against the install root rather than the
working directory.
logo_helper
logo_helper.py. LogoHelper(display_width, display_height, ...): load_logo(), load_logo_with_download(),
get_logo_variations(), normalize_abbreviation(), with an in-memory cache.
path_safety
path_safety.py. Core-internal, used by web handlers that
open files named in a request. safe_path_component(value) returns the
value if it is one harmless path segment, else None;
resolve_under(base, *parts) returns the resolved path, or None if a part
is unsafe or the result would leave base; safe_relative_parts() splits a
relative path the same way. Both return the sanitised value rather than a
boolean, so a caller cannot check one string and open another.
permission_utils
permission_utils.py. The modes and ownership that
let the root display service and the web user share files:
ensure_directory_permissions(), ensure_file_permissions(), the
get_*_mode() functions, ensure_shared_group_ownership(),
sudo_remove_directory() and install_requirements_file() (the sudo
safe_pip_install.sh path). ConfigManager, CacheManager and the store
already call these; a plugin needs them only when it creates its own files
outside the cache. See docs/PERMISSIONS.md.
scroll_config
scroll_config.py. configure(scroll_helper, plugin_config=, global_config=, display_manager=, plugin_logger=) reads a
plugin's scroll settings, snaps the speed to a whole number of pixels per
panel refresh, puts the helper in fixed-step mode and returns
ScrollSettings. Pass settings.frame_hold to
display_manager.set_scrolling_state(True, frame_hold=...) or the scroll
runs too fast. resolve() does the calculation without touching a helper.
See docs/SCROLL_PERFORMANCE.md.
scroll_helper
scroll_helper.py. ScrollHelper(display_width, display_height, logger=None): build a wide image once
(create_scrolling_image() or set_scrolling_image()), then per frame
update_scroll_position() and get_visible_portion();
is_scroll_complete(), calculate_dynamic_duration() and
get_dynamic_duration() for timing. Configure it with scroll_config
rather than the set_* methods. Vegas mode reads a plugin's
scroll_helper image when the plugin has no get_vegas_content().
snapshot_policy
snapshot_policy.py. Core-internal. decide()
tells DisplayManager whether to write /tmp/led_matrix_preview.png, only
touch its mtime, or skip, based on whether a browser is watching the preview.
The web health check reads the file's age.
sports_card
sports_card.py. Free functions taking config, fonts
and logger explicitly: card options (scroll_card_option(),
vs_text(), upcoming_center_mode()), colours (element_color(),
font_color(), score_color_for(), recent_score_color()), favourite-team
rules (favorite_teams_for(), side_is_favorite(), favorite_result()),
dates (format_game_date(), format_game_time(), card_tzinfo()) and font
sizes (schema_font_size(), resolve_font_size()). A plugin keeps its own
method and delegates the body.
sports_game_renderer
sports_game_renderer.py.
SportsGameRendererMixin: the scroll/Vegas card geometry (centre gap, logo
slot, layout offsets, upcoming-card date and time). No __init__ and no
state; add it as a base class of the plugin's game renderer and override
what differs.
sports_helpers
sports_helpers.py. Free functions clamp_window(),
clamp_seconds(), logo_needs_refresh(), spread_weighted_order(), and
SportsHelpersMixin with the scoreboards' _mode_customization,
_setting_int, _reset_dwell_on_reentry, _next_switch_index,
_odds_color and _upcoming_date_and_time_text under their existing names.
Nothing in core uses it.
sports_scroll
sports_scroll.py. SportsScrollDisplay and
SportsScrollDisplayManager: the scroll-display orchestration the
scoreboards share (Vegas items, dynamic duration, frame loop), paced through
scroll_config. Subclasses supply prepare_scroll_content() and set
SCROLL_LEAGUE_KEYS; see the module docstring for an example.
sports_shared
sports_shared.py. SportsCoreSharedMixin,
SportsLiveSharedMixin, SportsRecentSharedMixin: the sports.py methods
that were identical in every scoreboard (game selection and rotation,
fonts, colours, dates, the switch-mode upcoming card). The docstring lists
the attributes the host class must have and the three methods deliberately
left out.
sync_manager
sync_manager.py. Core-internal. DisplaySyncManager
links two displays as leader and follower (sync.role in config) over UDP
port 5765, plus TCP on the next port for scroll images. The leader drives the
scroll and sends the follower its part of each frame; a follower falls back
to its own plugins when the leader goes quiet. Rows and columns must match.
Created by DisplayController; works with any plugin.
text_helper
text_helper.py. TextHelper(font_dir=None, ...):
load_fonts(), draw_text_with_outline(), get_text_width(),
get_text_dimensions(), center_text(), wrap_text(),
draw_multiline_text(), create_text_image().
Logging
Modules here create their logger with logging.getLogger(__name__), which is
the same logger src.logging_config.get_logger(__name__) returns. The helper
classes (APIHelper, LogoHelper, ScrollHelper, TextHelper) and
espn_dates take an optional logger. In a plugin, pass self.logger: it is
created by get_logger(..., plugin_id=...) in BasePlugin, so messages carry
the plugin id.
Adding a module
- Keep it importable without hardware (see the test above).
- Give it a module docstring that says what it is for and, if it is a mixin, what the host class must provide.
- Add it to the table on this page and, if plugins may import it, to the CHANGELOG with the release to floor on.