mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-05-16 02:13:32 +00:00
urllib3 CVEs (10 Trivy findings):
plugin-repos/march-madness/requirements.txt: bump urllib3>=1.26.0 to
>=2.2.2 to address CVE-2021-33503, CVE-2023-43804, CVE-2023-45803,
CVE-2024-37891, and 2025-2026 decompression/redirect CVEs.
Missed code fixes from round-1:
display_helper.py: remove unused draw=ImageDraw.Draw(img) — the method
delegates to _draw_centered_text which creates its own draw context.
custom-feeds.js:334: one bare removeCustomFeedRow(this) was missed by
the earlier replace_all; changed to window.removeCustomFeedRow(this).
app.js: add htmx to /* global */ declaration — htmx.ajax() is called
at lines 146 and 172 but htmx was only declared in the extension files.
timezone-selector.js:215: second unused catch (e) → catch {} missed
when we fixed line 361 in round-1.
Bandit B110 annotations (3 new except/pass blocks from newer PRs):
start.py: hostname -I IP parsing — non-critical startup info.
display_controller.py: scroll_helper.get_portion_at — optional method.
display_manager.py: canvas reset during cleanup — best-effort.
41 confirmed false positives suppressed via Codacy API:
35x pyflakes in test/, plugin-repos/, scripts/ — not production code
Flask 0.0.0.0, os.execvp, Bandit B603, vendor ESLint, already-fixed
Biome noPrototypeBuiltins.
Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
141 lines
5.1 KiB
Python
141 lines
5.1 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
LED Matrix Web Interface V3 Startup Script
|
|
Modern web interface with real-time display preview and plugin management.
|
|
"""
|
|
|
|
import os
|
|
import socket
|
|
import subprocess
|
|
import sys
|
|
import logging
|
|
from pathlib import Path
|
|
|
|
def get_local_ips():
|
|
"""Get list of local IP addresses the service will be accessible on."""
|
|
ips = []
|
|
|
|
# Check if AP mode is active
|
|
try:
|
|
result = subprocess.run(
|
|
["systemctl", "is-active", "hostapd"],
|
|
capture_output=True,
|
|
text=True,
|
|
timeout=2
|
|
)
|
|
if result.returncode == 0 and result.stdout.strip() == "active":
|
|
ips.append("192.168.4.1 (AP Mode)")
|
|
except Exception: # nosec B110 - AP mode IP detection is non-critical startup info; systemctl may not exist
|
|
pass
|
|
|
|
# Get IPs from hostname -I
|
|
try:
|
|
result = subprocess.run(
|
|
["hostname", "-I"],
|
|
capture_output=True,
|
|
text=True,
|
|
timeout=2
|
|
)
|
|
if result.returncode == 0:
|
|
for ip in result.stdout.strip().split():
|
|
ip = ip.strip()
|
|
if ip and not ip.startswith("127.") and ip != "192.168.4.1":
|
|
ips.append(ip)
|
|
except Exception: # nosec B110 - hostname -I output parsing; non-critical startup info
|
|
pass
|
|
|
|
# Fallback: try socket method
|
|
if not ips:
|
|
try:
|
|
s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
|
|
try:
|
|
s.connect(('8.8.8.8', 80))
|
|
ip = s.getsockname()[0]
|
|
if ip and not ip.startswith("127."):
|
|
ips.append(ip)
|
|
finally:
|
|
s.close()
|
|
except Exception:
|
|
pass
|
|
|
|
return ips if ips else ["localhost"]
|
|
|
|
def main():
|
|
"""Main startup function."""
|
|
# Change to project root directory
|
|
project_root = Path(__file__).parent.parent
|
|
os.chdir(project_root)
|
|
|
|
# Add to Python path
|
|
sys.path.insert(0, str(project_root))
|
|
|
|
# Configure logging to suppress non-critical socket errors
|
|
# These occur when clients disconnect and are harmless
|
|
werkzeug_logger = logging.getLogger('werkzeug')
|
|
original_log_exception = werkzeug_logger.error
|
|
|
|
def log_exception_filtered(message, *args, **kwargs):
|
|
"""Filter out non-critical socket errors from werkzeug logs."""
|
|
if isinstance(message, str):
|
|
# Suppress "No route to host" and similar connection errors
|
|
if 'No route to host' in message or 'errno 113' in message:
|
|
# Log at debug level instead of error
|
|
werkzeug_logger.debug(message, *args, **kwargs)
|
|
return
|
|
# Suppress broken pipe errors (client disconnected)
|
|
if 'Broken pipe' in message or 'errno 32' in message:
|
|
werkzeug_logger.debug(message, *args, **kwargs)
|
|
return
|
|
# For exceptions, check if it's a socket error
|
|
if 'exc_info' in kwargs and kwargs['exc_info']:
|
|
exc_type, exc_value, exc_tb = kwargs['exc_info']
|
|
if isinstance(exc_value, OSError):
|
|
# Suppress common non-critical socket errors
|
|
if exc_value.errno in (113, 32, 104): # No route to host, Broken pipe, Connection reset
|
|
werkzeug_logger.debug(message, *args, **kwargs)
|
|
return
|
|
# Log everything else normally
|
|
original_log_exception(message, *args, **kwargs)
|
|
|
|
werkzeug_logger.error = log_exception_filtered
|
|
|
|
# Import and run the Flask app
|
|
from web_interface.app import app
|
|
|
|
print("Starting LED Matrix Web Interface V3...")
|
|
print("Web server binding to: 0.0.0.0:5000")
|
|
|
|
# Get and display accessible IP addresses
|
|
ips = get_local_ips()
|
|
if ips:
|
|
print("Access the interface at:")
|
|
for ip in ips:
|
|
if "AP Mode" in ip:
|
|
print(" - http://192.168.4.1:5000 (AP Mode - connect to LEDMatrix-Setup WiFi)")
|
|
else:
|
|
print(f" - http://{ip}:5000")
|
|
else:
|
|
print(" - http://localhost:5000 (local only)")
|
|
print(" - http://<your-pi-ip>:5000 (replace with your Pi's IP address)")
|
|
|
|
# Run the web server with error handling for client disconnections
|
|
try:
|
|
# threaded=True is Flask's default since 1.0, but set it explicitly
|
|
# so it's self-documenting: the two /api/v3/stream/* SSE endpoints
|
|
# hold long-lived connections and would starve other requests under
|
|
# a single-threaded server.
|
|
app.run(host='0.0.0.0', port=5000, debug=False, threaded=True)
|
|
except (OSError, BrokenPipeError) as e:
|
|
# Suppress non-critical socket errors (client disconnections)
|
|
if isinstance(e, OSError) and e.errno in (113, 32, 104): # No route to host, Broken pipe, Connection reset
|
|
werkzeug_logger.debug(f"Client disconnected: {e}", exc_info=True)
|
|
# Re-raise only if it's not a client disconnection error
|
|
if e.errno not in (113, 32, 104):
|
|
raise
|
|
else:
|
|
raise
|
|
|
|
if __name__ == '__main__':
|
|
main()
|
|
|