mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-17 20:39:13 +00:00
Claude
a561a7500a
Address CodeRabbit findings on install_service.sh, install_web_service.sh and install_wifi_monitor.sh: - Values interpolated into each script's sed expression (project root path, username) were not escaped, so a value containing &, \ or the | delimiter would corrupt the rendered systemd unit. Add a shared sed_escape_replacement() helper in the new scripts/install/lib_systemd_render.sh (sourced by all three scripts) and apply it to every sed replacement. - install_service.sh rendered the main and web units to the predictable path /tmp/ledmatrix.service.tmp before installing them -- a symlink/TOCTOU race (CWE-377). Use mktemp for both, with a trap to clean up on exit. - install_service.sh treated a missing template as a mere warning and then checked only whether a unit already existed at the destination before enabling/starting it, so a render failure could silently fall back to enabling a stale, previously-installed unit. Both unit blocks now exit non-zero on a missing template or a failed render. Also rename the ambiguous loop variable `l` to `line` in test/test_systemd_unit_drift.py (Ruff E741); ruff isn't wired into any CI workflow in this repo today, so this isn't currently CI-blocking, but the rename is trivial and correct regardless. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S3bPMESe2TfrGvbs1ef9c5
28 lines
1.1 KiB
Bash
28 lines
1.1 KiB
Bash
#!/bin/bash
|
|
#
|
|
# Shared helper for rendering systemd unit templates via sed.
|
|
#
|
|
# Sourced by install_service.sh, install_web_service.sh and
|
|
# install_wifi_monitor.sh so all three escape sed replacement text the same
|
|
# way instead of carrying three copies of the same fix.
|
|
|
|
# sed_escape_replacement VALUE
|
|
#
|
|
# Print VALUE escaped for safe use as the replacement side of `sed
|
|
# s|pattern|replacement|`. Every one of these scripts builds its sed
|
|
# expression by interpolating a shell variable (a path, a username, ...)
|
|
# straight into the replacement text. sed gives three characters special
|
|
# meaning there: backslash (escape character), & (whole match) and the
|
|
# delimiter itself (here `|`). A value containing any of them -- e.g. a
|
|
# username or path with an `&`, a literal backslash, or a `|` -- would
|
|
# otherwise corrupt the rendered unit file instead of being substituted
|
|
# literally. Escape the backslash first so the later escapes aren't
|
|
# double-escaped.
|
|
sed_escape_replacement() {
|
|
local value="$1"
|
|
value="${value//\\/\\\\}"
|
|
value="${value//&/\\&}"
|
|
value="${value//|/\\|}"
|
|
printf '%s' "$value"
|
|
}
|