mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 14:25:08 +00:00
ChuckandClaude Opus 5.5
f841fa36b6
Updates that move HEAD now install changed systemd units through a root-owned helper (/usr/local/sbin/ledmatrix-refresh-units, two literal sudo lines), with a backup restored on rollback; a refresh that fails part-way puts the old units back. Devices without the new sudo rule keep updating and are told to re-run the installer once. The one-shot installer now checks out the newest vX.Y.Z release (LEDMATRIX_CHANNEL=beta keeps main) and never moves an existing checkout backwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
119 lines
4.6 KiB
Python
119 lines
4.6 KiB
Python
"""A pull that changed nothing on the running system is not an applied update.
|
|
|
|
git_pull replaces files on disk and restarts nothing -- there is no systemctl
|
|
call anywhere in the handler. The display and web services keep running the
|
|
code they loaded at boot, so the user is told "Code updated successfully" and
|
|
sees no change until they happen to reboot. The response now says whether a
|
|
restart is owed, and the UI raises the existing restart-pending banner.
|
|
"""
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
from flask import Flask
|
|
|
|
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
|
|
|
|
from web_interface.blueprints import api_v3 as mod # noqa: E402
|
|
from web_interface.blueprints.api_v3 import api_v3 # noqa: E402
|
|
|
|
|
|
@pytest.fixture
|
|
def client():
|
|
app = Flask(__name__)
|
|
app.config['TESTING'] = True
|
|
app.register_blueprint(api_v3, url_prefix='/api/v3')
|
|
# The handler consults these after a successful pull; None is the
|
|
# "not wired up" case it already guards for.
|
|
api_v3.plugin_store_manager = None
|
|
api_v3.config_manager = None
|
|
return app.test_client()
|
|
|
|
|
|
def _git(heads, pull_rc=0, pull_out='Updating a1b2c3..d4e5f6\n'):
|
|
"""Fake git. `heads` are the successive answers to rev-parse HEAD."""
|
|
seq = list(heads)
|
|
|
|
def run(args, **kwargs):
|
|
def ok(stdout='', rc=0, b=False):
|
|
return subprocess.CompletedProcess(
|
|
args, rc, stdout=(stdout.encode() if b else stdout),
|
|
stderr=(b'' if b else ''))
|
|
if args[:2] == ['git', 'rev-parse'] and args[-1] == 'HEAD':
|
|
return ok(seq.pop(0) + '\n' if seq else 'deadbeef\n')
|
|
if 'symbolic-full-name' in args or '@{u}' in args:
|
|
return ok('origin/main\n')
|
|
if args[:2] == ['git', 'status']:
|
|
return ok('')
|
|
if args[:2] == ['git', 'diff']:
|
|
return ok('')
|
|
if args[:2] == ['git', 'pull']:
|
|
return ok(pull_out, pull_rc)
|
|
return ok('')
|
|
return run
|
|
|
|
|
|
def _pull(client):
|
|
return client.post('/api/v3/system/action',
|
|
json={'action': 'git_pull'}).get_json()
|
|
|
|
|
|
class TestRestartIsRequestedWhenCodeChanged:
|
|
def test_a_pull_that_moved_head_asks_for_a_restart(self, client):
|
|
with patch.object(mod.subprocess, 'run', _git(['aaa111', 'bbb222'])):
|
|
data = _pull(client)
|
|
assert data['status'] == 'success'
|
|
assert data['restart_required'] is True, (
|
|
"new code on disk, services still running the old code, and "
|
|
"nothing told the user to restart")
|
|
|
|
def test_already_up_to_date_does_not(self, client):
|
|
with patch.object(mod.subprocess, 'run',
|
|
_git(['aaa111', 'aaa111'], pull_out='Already up to date.\n')):
|
|
data = _pull(client)
|
|
assert data['status'] == 'success'
|
|
assert data['restart_required'] is False, (
|
|
"prompting after a no-op update trains users to ignore the prompt")
|
|
|
|
def test_a_failed_pull_does_not(self, client):
|
|
with patch.object(mod.subprocess, 'run', _git(['aaa111'], pull_rc=1)):
|
|
data = _pull(client)
|
|
assert data['status'] == 'error'
|
|
assert data['restart_required'] is False
|
|
|
|
|
|
class TestUnitsAreRefreshedWithTheCode:
|
|
"""New code may bring new systemd unit settings; installing them is part of the update."""
|
|
|
|
@pytest.fixture
|
|
def refresh(self, monkeypatch):
|
|
from web_interface import unit_refresh
|
|
calls = []
|
|
|
|
def fake():
|
|
calls.append(True)
|
|
return {'status': 'refreshed', 'message': 'Service settings updated (ledmatrix.service).',
|
|
'units': ['ledmatrix.service']}
|
|
monkeypatch.setattr(unit_refresh, 'refresh_after_update', fake)
|
|
return calls
|
|
|
|
def test_an_update_that_moved_head_refreshes_the_units(self, client, refresh):
|
|
with patch.object(mod.subprocess, 'run', _git(['aaa111', 'bbb222'])):
|
|
data = _pull(client)
|
|
assert refresh == [True]
|
|
assert data['unit_refresh']['status'] == 'refreshed'
|
|
assert 'Service settings updated' in data['message']
|
|
|
|
def test_nothing_new_touches_no_units(self, client, refresh):
|
|
with patch.object(mod.subprocess, 'run',
|
|
_git(['aaa111', 'aaa111'], pull_out='Already up to date.\n')):
|
|
data = _pull(client)
|
|
assert refresh == [] and data['unit_refresh'] is None
|
|
|
|
def test_a_failed_pull_touches_no_units(self, client, refresh):
|
|
with patch.object(mod.subprocess, 'run', _git(['aaa111'], pull_rc=1)):
|
|
data = _pull(client)
|
|
assert refresh == [] and data['unit_refresh'] is None
|