mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 06:15:09 +00:00
* fix(web-ui): Update All sends the live installed list and redraws the grid updateAll() preferred PluginStateManager.installedPlugins over window.installedPlugins. Only updateAll's own end-of-run refresh ever fills PluginStateManager, so from the second run on it sent the first run's plugins: one uninstalled since failed with "plugin not found" and one installed since was never updated. That refresh also only replaced window.installedPlugins, so the installed cards and the Updates badge kept offering "Update to vX" for what had just been updated. Read window.installedPlugins, the list plugins_manager.js republishes after every install, uninstall and refresh, keeping PluginStateManager as the fallback for a page without it, and refresh through pluginManager.loadInstalledPlugins(true), which redraws the grid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-ui): list each plugin's display modes in /plugins/installed The on-demand modal fills its Display Mode select from plugin.display_modes, but /plugins/installed never sent the field. Every plugin offered one option, its own id, under "This plugin exposes a single display mode"; the display resolved that id to the plugin's first mode, so a multi-mode plugin could only be started, or pinned, there. Add display_modes to each entry, read from the plugin catalog (get_plugin_display_modes), the same declared list /display/modes and on-demand/start use, keeping only strings. Single-mode plugins still get one option and the same hint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-ui): enable a store install by its installed id, and not on reinstall The store's Install button enabled the new plugin by the registry id it installed. Weather, Music, Stocks and Leaderboard install under the id their manifests declare (weather -> ledmatrix-weather); the plugin list, the config section and /plugins/toggle know only that id, so the toggle answered 404 "Plugin not found" and the plugin stayed disabled behind "installed, but enabling it failed". The same button on an installed plugin (Reinstall) enabled it too, switching a plugin the user had turned off back on. POST /plugins/install now names the installed plugin: plugin_id in the direct answer and in the queued operation's result, read from the installed manifest found the way the store's update and uninstall find it (_find_plugin_path: id, aliases, plugin_path name), else the requested id. The client reloads the list, then enables that id; from an answer without it, the installed entry the store entry matches (findInstalledStorePlugin, which isStorePluginInstalled now uses). A reinstall, decided by the same match that labelled the button, reloads the list and leaves the enabled state alone. test/js/plugins_manager_sandbox.js runs the whole of plugins_manager.js in a vm context against a fake DOM and API, for suites that drive its real flows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-ui): wait for long store installs; on timeout reload, not fail pollOperationStatus gave a queued install 60 polls, a second apart, then reported "Install operation timed out" as an error and stopped. The server allows the plugin's dependency install 300 s on its own (install_requirements_file in store_install.py), after a download that fetches the plugin a file at a time, so installs that went on to succeed were reported as failed, never enabled, and left out of the installed list until the page was reloaded. Give installs INSTALL_POLL_MAX_ATTEMPTS (600, ten minutes). When even that runs out, reload the installed list and the store badges and warn that the install may still be running; nothing is enabled without the operation's answer. Uninstall keeps the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-ui): build the store's category filter from the store's plugins The #plugin-category select listed seven fixed categories while the registry uses about twenty (productivity, utility, transit, finance, ...), so roughly a third of the store could not be filtered to, and "Financial" missed the plugin filed under "finance". The template now ships only "All Categories"; syncStoreCategoryOptions, run by applyStoreFiltersAndSort, adds one option per category the cached store plugins have (case folded, as the filter compares), keeps the current choice, and rebuilds only when the set changes or the partial was swapped in afresh -- the way the Starlark section builds its own. The test sandbox gains window.addEventListener (initPluginsPage needs it) and quiets the script's "element not found" warnings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web-ui): one handler for the GitHub-URL Install button #install-plugin-from-url had an inline onclick calling window.handleGitHubPluginInstall, and attachInstallButtonHandler also gave it a click listener that installs, so both ran on every click (and on Enter, which clicks it). The inline handler threw a ReferenceError -- it called isGithubUrl, which is local to the plugin-manager IIFE, from outside it -- so only the listener's request went out; correcting that scope alone would have sent every install twice. Remove the inline onclick and the window.handleGitHubPluginInstall it called, which nothing else uses. The listener, which already sent the only request, is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
94 lines
3.9 KiB
JavaScript
94 lines
3.9 KiB
JavaScript
// Plugin Manager > Install from GitHub > Install Single Plugin: one click,
|
|
// one request, no errors.
|
|
//
|
|
// The Install button carried an inline onclick calling
|
|
// window.handleGitHubPluginInstall, and attachInstallButtonHandler also gave
|
|
// it a click listener that installs. Both ran on every click. The inline one
|
|
// threw a ReferenceError (it called isGithubUrl, which lives inside the
|
|
// plugin-manager IIFE, from outside it), so only the listener's request went
|
|
// out -- and fixing that scope alone would have sent every install twice.
|
|
// The button now has the listener only.
|
|
//
|
|
// Runs the whole of plugins_manager.js in the sandbox, with the button as
|
|
// partials/plugins.html ships it.
|
|
|
|
const { create, templateAttributes } = require('../plugins_manager_sandbox');
|
|
|
|
let pass = 0, fail = 0;
|
|
const ok = (label, cond, extra) => cond
|
|
? (pass++, console.log(' ok ' + label))
|
|
: (fail++, console.log(' FAIL ' + label + (extra !== undefined ? ' -> ' + JSON.stringify(extra).slice(0, 400) : '')));
|
|
|
|
const URL = 'https://github.com/someone/ledmatrix-demo';
|
|
|
|
function route(method, url) {
|
|
if (method === 'POST' && url === '/api/v3/plugins/install-from-url') {
|
|
return { json: { status: 'success', message: 'Plugin demo installed successfully', plugin_id: 'demo' } };
|
|
}
|
|
if (url.startsWith('/api/v3/plugins/installed')) return { json: { status: 'success', data: { plugins: [] } } };
|
|
return { json: { status: 'success' } };
|
|
}
|
|
|
|
function page() {
|
|
const sb = create({ route });
|
|
const button = templateAttributes('install-plugin-from-url');
|
|
sb.el('install-plugin-from-url', button.tag, button.attrs);
|
|
sb.el('github-plugin-url', 'input');
|
|
sb.el('github-plugin-status');
|
|
sb.el('plugin-branch-input', 'input');
|
|
return sb;
|
|
}
|
|
|
|
const installs = sb => sb.requests.filter(r => r.url === '/api/v3/plugins/install-from-url');
|
|
|
|
(async () => {
|
|
console.log('\nthe template');
|
|
{
|
|
const { attrs } = templateAttributes('install-plugin-from-url');
|
|
ok('the Install button has no inline onclick', !('onclick' in attrs), attrs.onclick);
|
|
}
|
|
|
|
console.log('\na click');
|
|
{
|
|
const sb = page();
|
|
sb.window.attachInstallButtonHandler();
|
|
// htmx:afterSettle runs it again on every swap; that must not add a handler.
|
|
sb.window.attachInstallButtonHandler();
|
|
sb.el('github-plugin-url').value = URL;
|
|
sb.window.document.getElementById('install-plugin-from-url').click();
|
|
await sb.settle();
|
|
ok('raises no error', sb.errors.length === 0, sb.errors.map(String));
|
|
ok('sends exactly one install request', installs(sb).length === 1, installs(sb));
|
|
ok('for the URL typed', installs(sb)[0] && installs(sb)[0].body.repo_url === URL, installs(sb));
|
|
ok('and reports the result', /Successfully installed: demo/.test(sb.el('github-plugin-status').innerHTML),
|
|
sb.el('github-plugin-status').innerHTML);
|
|
}
|
|
|
|
console.log('\nEnter in the URL field');
|
|
{
|
|
const sb = page();
|
|
sb.window.attachInstallButtonHandler();
|
|
const input = sb.el('github-plugin-url');
|
|
input.value = URL;
|
|
input.dispatch('keypress', { key: 'Enter' });
|
|
await sb.settle();
|
|
ok('raises no error', sb.errors.length === 0, sb.errors.map(String));
|
|
ok('sends exactly one install request', installs(sb).length === 1, installs(sb));
|
|
}
|
|
|
|
console.log('\na URL that is not GitHub');
|
|
{
|
|
const sb = page();
|
|
sb.window.attachInstallButtonHandler();
|
|
sb.el('github-plugin-url').value = 'https://example.com/x';
|
|
sb.window.document.getElementById('install-plugin-from-url').click();
|
|
await sb.settle();
|
|
ok('is refused without a request or an error',
|
|
installs(sb).length === 0 && sb.errors.length === 0 && /valid GitHub URL/.test(sb.el('github-plugin-status').innerHTML),
|
|
{ errors: sb.errors.map(String), status: sb.el('github-plugin-status').innerHTML });
|
|
}
|
|
|
|
console.log(`\n${pass} passed, ${fail} failed`);
|
|
process.exit(fail ? 1 : 0);
|
|
})().catch(e => { console.error(e); process.exit(1); });
|