mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-04-10 21:03:01 +00:00
8912501604
* fix: remove plugin-specific calendar duration from config template
Plugin display durations should be added dynamically when plugins are
installed, not hardcoded in the template.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(web): ensure unchecked checkboxes save as false in main config forms
HTML checkboxes omit their key entirely when unchecked, so the backend
never received updates to set boolean values to false. This affected:
- vegas_scroll_enabled: Now uses _coerce_to_bool helper
- use_short_date_format: Now uses _coerce_to_bool helper
- Plugin system checkboxes (auto_discover, auto_load_enabled, development_mode):
Now uses _coerce_to_bool helper
- Hardware checkboxes (disable_hardware_pulsing, inverse_colors, show_refresh_rate):
Now uses _coerce_to_bool helper
- web_display_autostart: Now uses _coerce_to_bool helper
Added _coerce_to_bool() helper function that properly converts form string
values ("true", "on", "1", "yes") to actual Python booleans, ensuring
consistent JSON types in config and correct downstream boolean checks.
Also added value="true" to all main config checkboxes for consistent boolean
parsing (sends "true" instead of "on" when checked).
This is the same issue fixed in commit 10d70d91 for plugin configs, but
for the main configuration forms (display settings, general settings).
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
180 lines
8.5 KiB
HTML
180 lines
8.5 KiB
HTML
<div class="bg-white rounded-lg shadow p-6">
|
|
<div class="border-b border-gray-200 pb-4 mb-6">
|
|
<h2 class="text-lg font-semibold text-gray-900">General Settings</h2>
|
|
<p class="mt-1 text-sm text-gray-600">Configure general system settings and location information.</p>
|
|
</div>
|
|
|
|
<form hx-post="/api/v3/config/main"
|
|
hx-ext="json-enc"
|
|
hx-headers='{"Content-Type": "application/json"}'
|
|
hx-swap="none"
|
|
hx-on:htmx:after-request="
|
|
var xhr = event.detail.xhr;
|
|
var isSuccess = xhr.status >= 200 && xhr.status < 300;
|
|
var message = '';
|
|
var status = 'success';
|
|
try {
|
|
var data = JSON.parse(xhr.responseText);
|
|
message = data.message || '';
|
|
status = data.status || status;
|
|
} catch (e) {}
|
|
if (isSuccess) {
|
|
message = message || 'Settings saved';
|
|
} else {
|
|
message = message || 'Failed to save settings';
|
|
status = 'error';
|
|
}
|
|
showNotification(message, status);
|
|
"
|
|
class="space-y-6">
|
|
|
|
<!-- Web Display Autostart -->
|
|
<div class="form-group">
|
|
<label class="flex items-center">
|
|
<input type="checkbox"
|
|
name="web_display_autostart"
|
|
value="true"
|
|
{% if main_config.web_display_autostart %}checked{% endif %}
|
|
class="form-control h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
|
|
<span class="ml-2 text-sm font-medium text-gray-900">Web Display Autostart</span>
|
|
</label>
|
|
<p class="mt-1 text-sm text-gray-600">Start the web interface on boot for easier access.</p>
|
|
</div>
|
|
|
|
<!-- Timezone -->
|
|
<div class="form-group">
|
|
<label for="timezone" class="block text-sm font-medium text-gray-700">Timezone</label>
|
|
<div id="timezone_container" class="mt-1"></div>
|
|
<p class="mt-1 text-sm text-gray-600">Select your timezone for time-based features and scheduling.</p>
|
|
</div>
|
|
<script>
|
|
(function() {
|
|
// Track if already initialized to prevent re-render
|
|
if (window.__timezoneWidgetInitialized) return;
|
|
|
|
function initTimezoneWidget() {
|
|
if (!window.LEDMatrixWidgets) { setTimeout(initTimezoneWidget, 50); return; }
|
|
var widget = window.LEDMatrixWidgets.get('timezone-selector');
|
|
if (!widget) { setTimeout(initTimezoneWidget, 50); return; }
|
|
var container = document.getElementById('timezone_container');
|
|
if (!container) return;
|
|
|
|
// Only render if container is empty (not already rendered)
|
|
if (container.children.length > 0) return;
|
|
|
|
widget.render(container, {
|
|
'x-options': { showOffset: true, placeholder: 'Select your timezone...' }
|
|
}, {{ (main_config.timezone or "America/Chicago")|tojson }}, {
|
|
fieldId: 'timezone',
|
|
name: 'timezone'
|
|
});
|
|
window.__timezoneWidgetInitialized = true;
|
|
}
|
|
if (document.readyState === 'loading') {
|
|
document.addEventListener('DOMContentLoaded', initTimezoneWidget);
|
|
} else {
|
|
setTimeout(initTimezoneWidget, 50);
|
|
}
|
|
})();
|
|
</script>
|
|
|
|
<!-- Location Information -->
|
|
<div class="grid grid-cols-1 md:grid-cols-3 xl:grid-cols-3 2xl:grid-cols-3 gap-4">
|
|
<div class="form-group">
|
|
<label for="city" class="block text-sm font-medium text-gray-700">City</label>
|
|
<input type="text"
|
|
id="city"
|
|
name="city"
|
|
value="{{ main_config.location.city or 'Dallas' }}"
|
|
class="form-control">
|
|
</div>
|
|
|
|
<div class="form-group">
|
|
<label for="state" class="block text-sm font-medium text-gray-700">State</label>
|
|
<input type="text"
|
|
id="state"
|
|
name="state"
|
|
value="{{ main_config.location.state or 'Texas' }}"
|
|
class="form-control">
|
|
</div>
|
|
|
|
<div class="form-group">
|
|
<label for="country" class="block text-sm font-medium text-gray-700">Country</label>
|
|
<input type="text"
|
|
id="country"
|
|
name="country"
|
|
value="{{ main_config.location.country or 'US' }}"
|
|
class="form-control">
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Plugin System Settings -->
|
|
<div class="border-t border-gray-200 pt-6 mt-6">
|
|
<h3 class="text-lg font-semibold text-gray-900 mb-4">Plugin System Settings</h3>
|
|
<p class="text-sm text-gray-600 mb-4">Configure the core plugin system behavior.</p>
|
|
|
|
<div class="space-y-4">
|
|
<!-- Auto Discover -->
|
|
<div class="form-group">
|
|
<label class="flex items-center">
|
|
<input type="checkbox"
|
|
name="auto_discover"
|
|
value="true"
|
|
{% if main_config.get('plugin_system', {}).get('auto_discover', True) %}checked{% endif %}
|
|
class="form-control h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
|
|
<span class="ml-2 text-sm font-medium text-gray-900">Auto Discover Plugins</span>
|
|
</label>
|
|
<p class="mt-1 text-sm text-gray-600">Automatically discover plugins in the plugins directory on startup.</p>
|
|
</div>
|
|
|
|
<!-- Auto Load Enabled -->
|
|
<div class="form-group">
|
|
<label class="flex items-center">
|
|
<input type="checkbox"
|
|
name="auto_load_enabled"
|
|
value="true"
|
|
{% if main_config.get('plugin_system', {}).get('auto_load_enabled', True) %}checked{% endif %}
|
|
class="form-control h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
|
|
<span class="ml-2 text-sm font-medium text-gray-900">Auto Load Enabled Plugins</span>
|
|
</label>
|
|
<p class="mt-1 text-sm text-gray-600">Automatically load plugins that are enabled in configuration.</p>
|
|
</div>
|
|
|
|
<!-- Development Mode -->
|
|
<div class="form-group">
|
|
<label class="flex items-center">
|
|
<input type="checkbox"
|
|
name="development_mode"
|
|
value="true"
|
|
{% if main_config.get('plugin_system', {}).get('development_mode', False) %}checked{% endif %}
|
|
class="form-control h-4 w-4 text-blue-600 focus:ring-blue-500 border-gray-300 rounded">
|
|
<span class="ml-2 text-sm font-medium text-gray-900">Development Mode</span>
|
|
</label>
|
|
<p class="mt-1 text-gray-600 text-sm">Enable verbose logging and development features for plugin debugging.</p>
|
|
</div>
|
|
|
|
<!-- Plugins Directory -->
|
|
<div class="form-group">
|
|
<label for="plugins_directory" class="block text-sm font-medium text-gray-700">Plugins Directory</label>
|
|
<input type="text"
|
|
id="plugins_directory"
|
|
name="plugins_directory"
|
|
value="{{ main_config.get('plugin_system', {}).get('plugins_directory', 'plugin-repos') }}"
|
|
placeholder="plugin-repos"
|
|
class="form-control">
|
|
<p class="mt-1 text-sm text-gray-600">Directory where plugins are stored (relative to project root).</p>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<!-- Submit Button -->
|
|
<div class="flex justify-end mt-6">
|
|
<button type="submit"
|
|
class="btn bg-blue-600 hover:bg-blue-700 text-white px-4 py-2 rounded-md">
|
|
<i class="fas fa-save mr-2"></i>
|
|
Save General Settings
|
|
</button>
|
|
</div>
|
|
</form>
|
|
</div>
|