mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-10-17 20:39:13 +00:00

Files

T

ChuckandClaude Opus 5 87d8b79196 fix: work through the remaining review findings on the editor and bridge

allow_insecure_mqtt (CWE-319, requested): a password with TLS disabled crosses
the network in cleartext. Refused now rather than merely warned about -- but
refused, not forbidden, because unencrypted MQTT on a trusted LAN is a normal
deliberate setup. allow_insecure_mqtt is the explicit acknowledgement, defaults
false, and is coerced like the other booleans so the string "false" cannot
switch the guard off.

starlark.py:796 -- the supported service runs Flask threaded, so two start
requests could each see running=False, each launch an editor, and the second
state write replace the first PID, orphaning a process that holds the display
down with nothing recording it. The check-launch-write sequence now takes a
module-level lock.

starlark.py:848 -- if the state write failed the route returned success with an
editor running and no PID recorded: status and stop both reported no session
while the display stayed down until the timeout expired. It now terminates the
process group and returns an error.

starlark.py:890 -- SIGKILL gives the script's EXIT trap no chance to run, so
nothing hands the display back, yet the response said "the display is
restarting". After an escalation the display is now restarted explicitly, and a
failure to do so returns an error naming the manual step instead of a success.

pixlet_config_editor.sh:184 -- find_pixlet supports Darwin but macOS ships no
timeout(1); GNU coreutils installs it as gtimeout. Resolved up front so the
failure lands before the display is stopped rather than after.

pixlet_config_editor.sh:154 -- wildcard, loopback and an explicit interface
address are three cases, not two. Collapsing the last two printed a URL saying
"localhost" whenever PIXLET_EDITOR_HOST named a LAN address.

tools.html:1254 -- escHtml does not encode single quotes, and the app id was
interpolated into an inline onclick="startPixletEditor('...')", so a directory
containing an apostrophe could break out of the JS string and run script. The
handler binds with addEventListener and reads the id from dataset, where it is
only ever parsed as an HTML attribute.

Tests: test_mqtt_bridge_config_endpoint.py grows to 23 cases covering the opt-in
in both directions. The tools DOM suite gains three guards asserting the edit
buttons carry no inline onclick and pass the id via dataset -- those need jsdom
and did not run here, so CI verifies them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-09-11 11:08:29 -04:00

apply_dns_single_request.sh

feat(starlark,on-demand): the third-party fixes worth taking, plus a Home Assistant MQTT bridge (#538 )

2026-09-08 08:34:52 -04:00

cleanup_venv.sh

Plugins (#145 )

2025-12-27 14:15:49 -05:00

clear_cache.py

Codebase audit: fix shipping bugs, remove verified-dead code, repair doc drift, add regression guards (#438 )

2026-08-06 14:04:23 -04:00

clear_python_cache.sh

Plugins (#145 )

2025-12-27 14:15:49 -05:00

pixlet_config_editor.sh

fix: work through the remaining review findings on the editor and bridge

2026-09-11 11:08:29 -04:00

README.md

feat(starlark,on-demand): the third-party fixes worth taking, plus a Home Assistant MQTT bridge (#538 )

2026-09-08 08:34:52 -04:00

start_web_conditionally.py

fix(web): default web_display_autostart to true, as the installer already does (#556 )

2026-09-10 17:42:00 -04:00

wifi_monitor_daemon.py

perf(wifi): one status fetch per monitor tick instead of three (#411 )

2026-07-14 11:22:37 -04:00

README.md

Utility Scripts

This directory contains utility scripts for maintenance and system operations.

Scripts

clear_cache.py - Clears LEDMatrix cache data (specific keys or all cache)
start_web_conditionally.py - Conditionally starts the web interface based on config settings
wifi_monitor_daemon.py - Background daemon that monitors WiFi/Ethernet connection and manages access point mode
cleanup_venv.sh - Cleans up Python virtual environment files
clear_python_cache.sh - Clears Python cache files (pycache, *.pyc, etc.)
pixlet_config_editor.sh - Opens Pixlet's own config UI for one installed Starlark app
apply_dns_single_request.sh - Adds options single-request to the resolver (run by ledmatrix-dns-fix.service)

Usage

Clear Cache

python3 scripts/utils/clear_cache.py --list          # List cache keys
python3 scripts/utils/clear_cache.py --clear-all      # Clear all cache
python3 scripts/utils/clear_cache.py --clear <key>    # Clear specific key

Start Web Interface Conditionally

This script is typically called by the systemd service (ledmatrix-web.service) and checks the web_display_autostart setting in config/config.json before starting the web interface.

WiFi Monitor Daemon

This daemon is typically run as a systemd service (ledmatrix-wifi-monitor.service) and automatically manages WiFi access point mode based on network connectivity.

Pixlet Config Editor

Run it when you want Pixlet's own config form for a Starlark app -- live render preview, cascading dropdowns -- rather than the LEDMatrix one.

./scripts/utils/pixlet_config_editor.sh                 # list installed apps
./scripts/utils/pixlet_config_editor.sh penndot_signs   # edit, on localhost:8080

Deliberately not a service. It stops the display for the length of the session and pixlet serve listens with no authentication, so it should only be running while you are actually editing. It backs the config up first and restarts the display on exit, however it exits.

It binds loopback only, with no flag to change that: anything that can reach pixlet serve can rewrite the app's config, and a printed warning is not access control. To edit from another machine, forward the port -- SSH does the authenticating and nothing is left listening on the LAN:

ssh -L 8080:localhost:8080 pi@ledpi.local

Apply DNS Single-Request Fix

Installed and run by ledmatrix-dns-fix.service; see systemd/README.md. Safe to run by hand (sudo ./scripts/utils/apply_dns_single_request.sh) and idempotent.