RonandClaude Opus 5 745d13a201 fix(plugins): copy history entries out, lock clear_state ...

Review follow-ups on the transition history.

get_state_history() copied only the outer list, so a caller holding a
returned transition could rewrite the manager's record of what happened
-- which contradicted the defensive-copy guarantee in its own docstring.
Copy each entry too. Every value in a transition is immutable, so a
shallow copy per entry is enough. test_get_state_history_entries_are_copies
pins it; without the change it fails with 'tampered' == 'enabled'.

clear_state() mutated five shared dicts without holding _lock, while
every other mutator takes it. A concurrent set_state() could interleave
and leave a plugin with history but no state. Drop the five as one unit.

This does not close the wider unload-vs-worker race, which lives in
PluginManager.unload_plugin() and predates this change: an update worker
still in flight can call set_state() after clear_state() returns and
recreate the entry. Serialising that needs the per-plugin lock held
across worker join in unload_plugin(), which is a separate change.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-24 19:01:10 -07:00

..

fixtures/plugins/ci-fixture-plugin

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

plugins

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

web_interface

Stop array-item secrets being wiped, and logging them (#493)

2026-08-23 11:43:08 -04:00

__init__.py

fix(test): repair test infrastructure and mock fixtures (#281)

2026-03-20 15:06:58 -04:00

_api_v3_test_helpers.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

conftest.py

fix(core): harden text-measurement caches; surface snapshot failures (#400)

2026-07-13 08:59:41 -04:00

test_adaptive_images.py

feat: adaptive layout system — size-aware regions, crisp font ladders, image fitting (#393)

2026-07-12 10:38:52 -04:00

test_adaptive_layout.py

feat: adaptive layout system — size-aware regions, crisp font ladders, image fitting (#393)

2026-07-12 10:38:52 -04:00

test_api_extractors.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_api_helper.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_api_v3_calendar_credentials.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_api_v3_music_auth_endpoints.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_api_v3_non_finite_numbers.py

fix(web): reject non-finite JSON numbers instead of raising (#497)

2026-08-23 11:44:23 -04:00

test_api_v3_optional_body.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_api_v3_plugin_install_endpoints.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_api_v3_registry_endpoints.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_api_v3_wifi_endpoints.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_async_plugin_updates.py

perf(plugins): run scheduled updates off the render thread (#407)

2026-07-14 08:08:51 -04:00

test_background_data_service.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_backup_manager.py

fix(backup): make a restored device match the one that was backed up (#439)

2026-08-07 13:02:59 -04:00

test_base_odds_manager.py

fix(odds): identify the odds requests to ESPN (#451)

2026-08-11 16:10:56 -04:00

test_base_plugin_duration.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_cache_cleanup_thread_ownership.py

fix(cache): one cleanup thread per cache directory, not per manager (#453)

2026-08-12 08:42:56 -04:00

test_cache_manager.py

fix: keep low-memory boards reachable under load (#464)

2026-08-19 12:28:22 -04:00

test_cache_orphan_temp_sweep.py

fix(cache): collect the temp files abandoned writes leave behind (#452)

2026-08-12 08:40:07 -04:00

test_cache_ttl_honoured.py

fix(cache): make the ttl parameter actually control expiry (#450)

2026-08-11 14:14:25 -04:00

test_checkbox_group_stale_values.py

fix(web): stop checkbox groups posting back options they cannot show (#465)

2026-08-19 17:40:52 -04:00

test_compatibility.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_config_helper.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_config_load_cache.py

perf(config): mtime-signature fast path for load_config (#410)

2026-07-14 08:49:43 -04:00

test_config_main_redacts_secrets.py

consolidate(web): credential exposure, secret loss, and the update path (#485)

2026-08-21 14:30:29 -04:00

test_config_manager_secrets.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_config_manager.py

Codebase audit: fix shipping bugs, remove verified-dead code, repair doc drift, add regression guards (#438)

2026-08-06 14:04:23 -04:00

test_config_service.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_config_validation_edge_cases.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_core_owned_config_keys.py

fix(plugins): core's own config keys no longer flag plugins as degraded (#434)

2026-08-04 13:46:28 -04:00

test_data_sources.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_discovery_path_contract.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_display_controller_optimizations.py

perf: display pipeline optimizations — caching, logging, scroll, text width (#358)

2026-06-01 11:58:21 -04:00

test_display_controller_plugin_toggle.py

fix(display): retry a plugin that is enabled but failed to load (#495)

2026-08-23 11:43:39 -04:00

test_display_controller_schedule.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_display_controller_vegas_tick.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_display_controller.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_display_dirty_tracking.py

perf(display): dirty tracking in update_display + plugin FPS declaration (#406)

2026-07-13 10:31:20 -04:00

test_display_helper.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_display_manager.py

Add panel orientation setting for upside-down mounting (#455)

2026-08-12 09:40:48 -04:00

test_doc_links.py

Codebase audit: fix shipping bugs, remove verified-dead code, repair doc drift, add regression guards (#438)

2026-08-06 14:04:23 -04:00

test_dynamic_team_resolver.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_element_style.py

Sports unification phase 0: safety net, cwd-independent fonts, element_style (#425)

2026-08-02 12:01:56 -04:00

test_enum_option_labels.py

feat(web): let schemas label enum dropdown options (#442)

2026-08-07 13:27:20 -04:00

test_error_aggregator.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_error_handling.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_font_manager.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_game_helper.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_git_pull_resolution.py

consolidate(web): credential exposure, secret loss, and the update path (#485)

2026-08-21 14:30:29 -04:00

test_harness_empty_claimed.py

test(harness): flag a mode that draws nothing without reporting it (#447)

2026-08-10 08:17:57 -04:00

test_harness_fill.py

feat: adaptive layout system — size-aware regions, crisp font ladders, image fitting (#393)

2026-07-12 10:38:52 -04:00

test_health_monitor.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_health_write_churn.py

consolidate(perf): cut SD writes, log volume, and metrics churn (#486)

2026-08-21 15:50:55 -04:00

test_initial_update_budget.py

fix(startup): bound the initial plugin update so the panel lights sooner (#456)

2026-08-12 14:58:05 -04:00

test_initializing_screen.py

fix(startup): bound the initial plugin update so the panel lights sooner (#456)

2026-08-12 14:58:05 -04:00

test_install_lowmem.py

test(install): stop assuming pytest's tmp_path is on disk (#492)

2026-08-23 11:42:51 -04:00

test_install_preserves_existing.py

feat(store): refuse to install a plugin that needs a newer core (re-target of #429) (#431)

2026-08-03 16:52:42 -04:00

test_journald_log_priority.py

consolidate(perf): cut SD writes, log volume, and metrics churn (#486)

2026-08-21 15:50:55 -04:00

test_loader_compat_warning.py

feat: adaptive layout system — size-aware regions, crisp font ladders, image fitting (#393)

2026-07-12 10:38:52 -04:00

test_logging_config.py

test(logging): stop the location assertion matching the clock (#496)

2026-08-23 11:44:00 -04:00

test_logo_downloader.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_logo_helper.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_metrics_cache_unknown_fields.py

consolidate(perf): cut SD writes, log volume, and metrics churn (#486)

2026-08-21 15:50:55 -04:00

test_odds_request_budget.py

fix(odds): identify the odds requests to ESPN (#451)

2026-08-11 16:10:56 -04:00

test_onboarding_checklist.py

fix(web): verify the onboarding timezone step, don't compare it to the default (#462)

2026-08-19 12:49:46 -04:00

test_permission_utils.py

fix(plugins): replace dependency marker files with a real satisfaction check (#390)

2026-07-11 08:55:50 -04:00

test_pixlet_download.py

fix(pixlet): resolve the release tag correctly when downloading (#461)

2026-08-17 15:35:02 -04:00

test_plugin_compatibility_gate.py

feat(store): evaluate compatible_versions, not just the floor (#433)

2026-08-04 13:46:05 -04:00

test_plugin_discovery_reports_skips.py

fix(plugins): say when discovery skips a directory (#489)

2026-08-21 16:19:33 -04:00

test_plugin_health.py

fix: keep low-memory boards reachable under load (#464)

2026-08-19 12:28:22 -04:00

test_plugin_loader.py

fix(plugins): replace dependency marker files with a real satisfaction check (#390)

2026-07-11 08:55:50 -04:00

test_plugin_loading_failures.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_plugin_manager_discovered_ids.py

fix(display): retry a plugin that is enabled but failed to load (#495)

2026-08-23 11:43:39 -04:00

test_plugin_manager_schema_soft.py

feat: activate dormant plugin health/metrics subsystem and surface it in the web UI (#388)

2026-07-09 07:54:18 -04:00

test_plugin_state_history_cap.py

fix(plugins): copy history entries out, lock clear_state

2026-08-24 19:01:10 -07:00

test_plugin_system.py

Give plugins access to device-wide config, and a global scroll frame rate (#424)

2026-08-02 10:40:12 -04:00

test_plugin_update_reservation.py

fix(plugins): make update scheduling atomic so update() cannot run twice at once (#437)

2026-08-05 19:38:11 -04:00

test_registry_id_resolution.py

fix(backup): make a restored device match the one that was backed up (#439)

2026-08-07 13:02:59 -04:00

test_resource_monitor.py

consolidate(perf): cut SD writes, log volume, and metrics churn (#486)

2026-08-21 15:50:55 -04:00

test_saved_repositories.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_schema_manager_device_location.py

fix(config): make the device location the default for plugin location fields (#490)

2026-08-21 16:22:48 -04:00

test_schema_manager_merge.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_schema_manager.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_scroll_helper_continuous.py

Vegas mode: reclaim dead space and pace the rotation (#423)

2026-07-31 09:40:38 -04:00

test_scroll_helper.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_skin_runtime_cache.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_skin_system.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_snapshot_policy.py

perf(display): snapshot mirror — viewer gating, digest skip, keepalive (#404)

2026-07-13 09:28:30 -04:00

test_sports_base_characterization.py

Sports unification phases 1–2: package split, promoted methods, opt-in capabilities (#426)

2026-08-02 12:39:33 -04:00

test_sports_capabilities.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_sports_core_promotions.py

Sports unification phases 1–2: package split, promoted methods, opt-in capabilities (#426)

2026-08-02 12:39:33 -04:00

test_sports_modes_promotions.py

Sports unification phases 1–2: package split, promoted methods, opt-in capabilities (#426)

2026-08-02 12:39:33 -04:00

test_sports_odds_fanout.py

fix(sports): fetch odds for the games shown, not the whole schedule window (#494)

2026-08-21 16:24:15 -04:00

test_sports_scroll.py

Sports unification phases 1–2: package split, promoted methods, opt-in capabilities (#426)

2026-08-02 12:39:33 -04:00

test_startup_validator.py

Follow-ups from #441: secret-helper migration, ten more bug fixes, and coverage for every remaining untested module (#444)

2026-08-07 16:17:11 -04:00

test_store_manager_caches.py

fix(plugins): stop core updates from resurrecting uninstalled built-in plugins (#368)

2026-06-11 18:18:28 -04:00

test_store_update_rollback.py

fix(store): plugin updates keep the old install until the new one succeeds (#405)

2026-07-13 09:32:37 -04:00

test_sudo_allowlist_covers_calls.py

harden: cap malloc arenas, warn on unit drift, and grant the portal's sudo commands (#476)

2026-08-21 14:29:45 -04:00

test_sudoers_noexec_on_pagers.py

fix(install): tag the secondary installer's journalctl grants too (#491)

2026-08-21 14:28:23 -04:00

test_sync_manager.py

Cover the next tier of untested modules and endpoints, and fix the 43 bugs that surfaced (#459)

2026-08-21 11:16:52 -04:00

test_systemd_malloc_arenas.py

harden: cap malloc arenas, warn on unit drift, and grant the portal's sudo commands (#476)

2026-08-21 14:29:45 -04:00

test_systemd_unit_drift.py

harden: cap malloc arenas, warn on unit drift, and grant the portal's sudo commands (#476)

2026-08-21 14:29:45 -04:00

test_template_targets.py

Codebase audit: fix shipping bugs, remove verified-dead code, repair doc drift, add regression guards (#438)

2026-08-06 14:04:23 -04:00

test_testing_mocks.py

fix(testing): add MockCacheManager.get_cached_data_with_strategy/save_cache (#409)

2026-07-14 08:33:08 -04:00

test_text_helper.py

fix: Codacy security fixes, CVE dependency bumps, and code quality cleanup (#331)

2026-05-15 10:19:55 -04:00

test_uninstall_and_reconcile_endpoint.py

fix(plugins): stop reconciliation install loop, slow plugin list, uninstall resurrection (#309)

2026-04-08 12:33:54 -04:00

test_update_change_reporting.py

fix(plugins): report updates that completed, not ones that were queued (#460)

2026-08-17 13:28:40 -04:00

test_update_check_reports_failure.py

consolidate(web): credential exposure, secret loss, and the update path (#485)

2026-08-21 14:30:29 -04:00

test_update_prompts_restart.py

consolidate(web): credential exposure, secret loss, and the update path (#485)

2026-08-21 14:30:29 -04:00

test_utils.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_vegas_config.py

test: add 306 new tests covering previously untested modules (#347)

2026-05-24 09:38:15 -04:00

test_vegas_continuous_refresh.py

Vegas mode: reclaim dead space and pace the rotation (#423)

2026-07-31 09:40:38 -04:00

test_vegas_density.py

fix(vegas): stop the width cap emitting fragments and stale windows (#446)

2026-08-10 09:41:25 -04:00

test_vegas_fps_health.py

perf(vegas): report the frame rate when it is worth reporting (#487)

2026-08-23 11:42:33 -04:00

test_vegas_frame_percentile.py

feat(vegas): make scroll stutter visible, and catch it in the act (#454)

2026-08-12 14:06:32 -04:00

test_vegas_geometry.py

Vegas mode: reclaim dead space and pace the rotation (#423)

2026-07-31 09:40:38 -04:00

test_vegas_live_weighting.py

feat(vegas): let live content keep its place in the ticker (#457)

2026-08-13 17:02:36 -04:00

test_vegas_log_volume.py

consolidate(perf): cut SD writes, log volume, and metrics churn (#486)

2026-08-21 15:50:55 -04:00

test_vegas_plugin_adapter.py

Fix inconsistent Vegas scroll transition gaps caused by plugin-baked padding (#384)

2026-07-08 09:43:13 -04:00

test_vegas_render_pipeline_recompose.py

fix(vegas): restore live plugin-update refresh dropped by sync refactor (#395)

2026-07-12 10:40:34 -04:00

test_version_comparison_consistency.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_version_consistency.py

fix(version): make the core version have exactly one answer (#428)

2026-08-03 15:21:47 -04:00

test_web_api.py

Test suite overhaul + fixes for the three bugs it uncovered (#441)

2026-08-07 10:17:30 -04:00

test_web_error_detail.py

fix(web): say what actually went wrong instead of "unknown" (#448)

2026-08-11 13:56:16 -04:00

test_web_settings_ui.py

Add settings tooltips and search to the web UI (#387)

2026-07-09 09:22:24 -04:00

test_web_smoke.py

Web UI: mobile navigation, guided onboarding, basic/advanced config tiering + performance (#417)

2026-07-16 20:32:07 -04:00

test_web_static_audit.py

Web UI: mobile navigation, guided onboarding, basic/advanced config tiering + performance (#417)

2026-07-16 20:32:07 -04:00

test_widget_scripts.py

Codebase audit: fix shipping bugs, remove verified-dead code, repair doc drift, add regression guards (#438)

2026-08-06 14:04:23 -04:00

test_wifi_check_state.py

perf(wifi): one status fetch per monitor tick instead of three (#411)

2026-07-14 11:22:37 -04:00

test_wifi_manager_ap.py

fix(wifi): reliable open AP with captive portal — tested on Trixie Pi (#320)

2026-05-03 08:25:20 -04:00