mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-04-10 13:02:59 +00:00
* chore: Update basketball-scoreboard submodule for odds font fix
* feat(widgets): Add widget registry system for plugin configuration forms
- Create core widget registry system (registry.js, base-widget.js)
- Extract existing widgets to separate modules:
- file-upload.js: Image upload with drag-and-drop, preview, delete, scheduling
- checkbox-group.js: Multi-select checkboxes for array fields
- custom-feeds.js: Table-based RSS feed editor with logo uploads
- Implement plugin widget loading system (plugin-loader.js)
- Add comprehensive documentation (widget-guide.md, README.md)
- Include example custom widget (example-color-picker.js)
- Maintain backwards compatibility with existing plugins
- All widget handlers available globally for existing functionality
This enables:
- Reusable UI components for plugin configuration forms
- Third-party plugins to create custom widgets without modifying LEDMatrix
- Modular widget architecture for future enhancements
Existing plugins (odds-ticker, static-image, news) continue to work without changes.
* fix(widgets): Security and correctness fixes for widget system
- base-widget.js: Fix escapeHtml to always escape (coerce to string first)
- base-widget.js: Add sanitizeId helper for safe DOM ID usage
- base-widget.js: Use DOM APIs in showError instead of innerHTML
- checkbox-group.js: Normalize types in setValue for consistent comparison
- custom-feeds.js: Implement setValue with full row creation logic
- example-color-picker.js: Validate hex colors before using in style attributes
- file-upload.js: Replace innerHTML with DOM creation to prevent XSS
- file-upload.js: Preserve open schedule editors when updating image list
- file-upload.js: Normalize types when filtering deleted files
- file-upload.js: Sanitize imageId in openImageSchedule and all schedule handlers
- file-upload.js: Fix max-files check order and use allowed_types from config
- README.md: Add security guidance for ID sanitization in examples
* fix(widgets): Additional security and error handling improvements
- scripts/update_plugin_repos.py: Add explicit UTF-8 encoding and proper error handling for file operations
- scripts/update_plugin_repos.py: Fix git fetch/pull error handling with returncode checks and specific exception types
- base-widget.js: Guard notify method against undefined/null type parameter
- file-upload.js: Remove inline handlers from schedule template, use addEventListener with data attributes
- file-upload.js: Update hideUploadProgress to show dynamic file types from config instead of hardcoded list
- README.md: Update Color Picker example to use sanitized fieldId throughout
* fix(widgets): Update Slider example to use sanitized fieldId
- Add sanitizeId helper to Slider example render, getValue, and setValue methods
- Use sanitizedFieldId for all DOM IDs and query selectors
- Maintain consistency with Color Picker example pattern
* fix(plugins_manager): Move configurePlugin and togglePlugin to top of file
- Move configurePlugin and togglePlugin definitions to top level (after uninstallPlugin)
- Ensures these critical functions are available immediately when script loads
- Fixes 'Critical functions not available after 20 attempts' error
- Functions are now defined before any HTML rendering checks
* fix(plugins_manager): Fix checkbox state saving using querySelector
- Add escapeCssSelector helper function for safe CSS selector usage
- Replace form.elements[actualKey] with form.querySelector for boolean fields
- Properly handle checkbox checked state using element.checked property
- Fix both schema-based and schema-less boolean field processing
- Ensures checkboxes with dot notation names (nested fields) work correctly
Fixes issue where checkbox states were not properly saved when field names
use dot notation (e.g., 'display.scroll_enabled'). The form.elements
collection doesn't reliably handle dot notation in bracket notation access.
* fix(base.html): Fix form element lookup for dot notation field names
- Add escapeCssSelector helper function (both as method and standalone)
- Replace form.elements[key] with form.querySelector for element type detection
- Fixes element lookup failures when field names use dot notation
- Ensures checkbox and multi-select skipping logic works correctly
- Applies fix to both Alpine.js method and standalone function
This complements the fix in plugins_manager.js to ensure all form
element lookups handle nested field names (e.g., 'display.scroll_enabled')
reliably across the entire web interface.
* fix(plugins_manager): Add race condition protection to togglePlugin
- Initialize window._pluginToggleRequests map for per-plugin request tokens
- Generate unique token for each toggle request to track in-flight requests
- Disable checkbox and wrapper UI during request to prevent overlapping toggles
- Add visual feedback with opacity and pointer-events-none classes
- Verify token matches before applying response updates (both success and error)
- Ignore out-of-order responses to preserve latest user intent
- Clear token and re-enable UI after request completes
Prevents race conditions when users rapidly toggle plugins, ensuring
only the latest toggle request's response affects the UI state.
* refactor(escapeCssSelector): Use CSS.escape() for better selector safety
- Prefer CSS.escape() when available for proper CSS selector escaping
- Handles edge cases: unicode characters, leading digits, and spec compliance
- Keep regex-based fallback for older browsers without CSS.escape support
- Update all three instances: plugins_manager.js and both in base.html
CSS.escape() is the standard API for escaping CSS selectors and provides
more robust handling than custom regex, especially for unicode and edge cases.
* fix(plugins_manager): Fix syntax error - missing closing brace for file-upload if block
- Add missing closing brace before else-if for checkbox-group widget
- Fixes 'Unexpected token else' error at line 3138
- The if block for file-upload widget (line 3034) was missing its closing brace
- Now properly structured: if (file-upload) { ... } else if (checkbox-group) { ... }
* fix(plugins_manager): Fix indentation in file-upload widget if block
- Properly indent all code inside the file-upload if block
- Fix template string closing brace indentation
- Ensures proper structure: if (file-upload) { ... } else if (checkbox-group) { ... }
- Resolves syntax error at line 3138
* fix(plugins_manager): Skip checkbox-group [] inputs to prevent config leakage
- Add skip logic for keys ending with '[]' in handlePluginConfigSubmit
- Prevents checkbox-group bracket notation inputs from leaking into config
- Checkbox-group widgets emit name="...[]" checkboxes plus a _data JSON field
- The _data field is already processed correctly, so [] inputs are redundant
- Prevents schema validation failures and extra config keys
The checkbox-group widget creates:
1. Individual checkboxes with name="fullKey[]" (now skipped)
2. Hidden input with name="fullKey_data" containing JSON array (processed)
3. Sentinel hidden input with name="fullKey[]" and empty value (now skipped)
* fix(plugins_manager): Normalize string booleans when checkbox input is missing
- Fix boolean field processing to properly normalize string booleans in fallback path
- Prevents "false"/"0" from being coerced to true when checkbox element is missing
- Handles common string boolean representations: 'true', 'false', '1', '0', 'on', 'off'
- Applies to both schema-based (lines 2386-2400) and schema-less (lines 2423-2433) paths
When a checkbox element cannot be found, the fallback logic now:
1. Checks if value is a string and normalizes known boolean representations
2. Treats undefined/null as false
3. Coerces other types to boolean using Boolean()
This ensures string values like "false" or "0" are correctly converted to false
instead of being treated as truthy non-empty strings.
* fix(base.html): Improve escapeCssSelector fallback to match CSS.escape behavior
- Handle leading digits by converting to hex escape (e.g., '1' -> '\0031 ')
- Handle leading whitespace by converting to hex escape (e.g., ' ' -> '\0020 ')
- Escape internal spaces as '\ ' (preserving space in hex escapes)
- Ensures trailing space after hex escapes per CSS spec
- Applies to both Alpine.js method and standalone function
The fallback now better matches CSS.escape() behavior for older browsers:
1. Escapes leading digits (0-9) as hex escapes with trailing space
2. Escapes leading whitespace as hex escapes with trailing space
3. Escapes all special characters as before
4. Escapes internal spaces while preserving hex escape format
This prevents selector injection issues with field names starting with digits
or whitespace, matching the standard CSS.escape() API behavior.
---------
Co-authored-by: Chuck <chuck@example.com>
218 lines
8.1 KiB
JavaScript
218 lines
8.1 KiB
JavaScript
/**
|
|
* LEDMatrix Widget Registry
|
|
*
|
|
* Central registry for all UI widgets used in plugin configuration forms.
|
|
* Allows plugins to use existing widgets and enables third-party developers
|
|
* to create custom widgets without modifying the LEDMatrix codebase.
|
|
*
|
|
* @module LEDMatrixWidgets
|
|
*/
|
|
|
|
(function() {
|
|
'use strict';
|
|
|
|
// Global widget registry
|
|
window.LEDMatrixWidgets = {
|
|
_widgets: new Map(),
|
|
_handlers: new Map(),
|
|
|
|
/**
|
|
* Register a widget with the registry
|
|
* @param {string} widgetName - Unique identifier for the widget
|
|
* @param {Object} definition - Widget definition object
|
|
* @param {string} definition.name - Human-readable widget name
|
|
* @param {string} definition.version - Widget version
|
|
* @param {Function} definition.render - Function to render the widget HTML
|
|
* @param {Function} definition.getValue - Function to get current widget value
|
|
* @param {Function} definition.setValue - Function to set widget value programmatically
|
|
* @param {Object} definition.handlers - Event handlers for the widget
|
|
*/
|
|
register: function(widgetName, definition) {
|
|
if (!widgetName || typeof widgetName !== 'string') {
|
|
console.error('[WidgetRegistry] Invalid widget name:', widgetName);
|
|
return false;
|
|
}
|
|
|
|
if (!definition || typeof definition !== 'object') {
|
|
console.error('[WidgetRegistry] Invalid widget definition for:', widgetName);
|
|
return false;
|
|
}
|
|
|
|
// Validate required properties
|
|
if (typeof definition.render !== 'function') {
|
|
console.error('[WidgetRegistry] Widget must have a render function:', widgetName);
|
|
return false;
|
|
}
|
|
|
|
this._widgets.set(widgetName, definition);
|
|
|
|
if (definition.handlers) {
|
|
this._handlers.set(widgetName, definition.handlers);
|
|
}
|
|
|
|
console.log(`[WidgetRegistry] Registered widget: ${widgetName}`);
|
|
return true;
|
|
},
|
|
|
|
/**
|
|
* Get widget definition
|
|
* @param {string} widgetName - Widget identifier
|
|
* @returns {Object|null} Widget definition or null if not found
|
|
*/
|
|
get: function(widgetName) {
|
|
return this._widgets.get(widgetName) || null;
|
|
},
|
|
|
|
/**
|
|
* Get widget handlers
|
|
* @param {string} widgetName - Widget identifier
|
|
* @returns {Object} Widget handlers object (empty object if not found)
|
|
*/
|
|
getHandlers: function(widgetName) {
|
|
return this._handlers.get(widgetName) || {};
|
|
},
|
|
|
|
/**
|
|
* Check if widget exists in registry
|
|
* @param {string} widgetName - Widget identifier
|
|
* @returns {boolean} True if widget is registered
|
|
*/
|
|
has: function(widgetName) {
|
|
return this._widgets.has(widgetName);
|
|
},
|
|
|
|
/**
|
|
* List all registered widgets
|
|
* @returns {Array<string>} Array of widget names
|
|
*/
|
|
list: function() {
|
|
return Array.from(this._widgets.keys());
|
|
},
|
|
|
|
/**
|
|
* Render a widget into a container element
|
|
* @param {string} widgetName - Widget identifier
|
|
* @param {string|HTMLElement} container - Container element or ID
|
|
* @param {Object} config - Widget configuration from schema
|
|
* @param {*} value - Current value for the widget
|
|
* @param {Object} options - Additional options (fieldId, pluginId, etc.)
|
|
* @returns {boolean} True if rendering succeeded
|
|
*/
|
|
render: function(widgetName, container, config, value, options) {
|
|
const widget = this.get(widgetName);
|
|
if (!widget) {
|
|
console.error(`[WidgetRegistry] Widget not found: ${widgetName}`);
|
|
return false;
|
|
}
|
|
|
|
// Resolve container element
|
|
let containerEl = container;
|
|
if (typeof container === 'string') {
|
|
containerEl = document.getElementById(container);
|
|
if (!containerEl) {
|
|
console.error(`[WidgetRegistry] Container not found: ${container}`);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
if (!containerEl || !(containerEl instanceof HTMLElement)) {
|
|
console.error('[WidgetRegistry] Invalid container element');
|
|
return false;
|
|
}
|
|
|
|
try {
|
|
// Call widget's render function
|
|
widget.render(containerEl, config, value, options || {});
|
|
return true;
|
|
} catch (error) {
|
|
console.error(`[WidgetRegistry] Error rendering widget ${widgetName}:`, error);
|
|
return false;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Get current value from a widget
|
|
* @param {string} widgetName - Widget identifier
|
|
* @param {string} fieldId - Field ID
|
|
* @returns {*} Current widget value
|
|
*/
|
|
getValue: function(widgetName, fieldId) {
|
|
const widget = this.get(widgetName);
|
|
if (!widget || typeof widget.getValue !== 'function') {
|
|
console.warn(`[WidgetRegistry] Widget ${widgetName} does not support getValue`);
|
|
return null;
|
|
}
|
|
|
|
try {
|
|
return widget.getValue(fieldId);
|
|
} catch (error) {
|
|
console.error(`[WidgetRegistry] Error getting value from widget ${widgetName}:`, error);
|
|
return null;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Set value in a widget
|
|
* @param {string} widgetName - Widget identifier
|
|
* @param {string} fieldId - Field ID
|
|
* @param {*} value - Value to set
|
|
* @returns {boolean} True if setting succeeded
|
|
*/
|
|
setValue: function(widgetName, fieldId, value) {
|
|
const widget = this.get(widgetName);
|
|
if (!widget || typeof widget.setValue !== 'function') {
|
|
console.warn(`[WidgetRegistry] Widget ${widgetName} does not support setValue`);
|
|
return false;
|
|
}
|
|
|
|
try {
|
|
widget.setValue(fieldId, value);
|
|
return true;
|
|
} catch (error) {
|
|
console.error(`[WidgetRegistry] Error setting value in widget ${widgetName}:`, error);
|
|
return false;
|
|
}
|
|
},
|
|
|
|
/**
|
|
* Unregister a widget (for testing/cleanup)
|
|
* @param {string} widgetName - Widget identifier
|
|
* @returns {boolean} True if widget was removed
|
|
*/
|
|
unregister: function(widgetName) {
|
|
const removed = this._widgets.delete(widgetName);
|
|
this._handlers.delete(widgetName);
|
|
if (removed) {
|
|
console.log(`[WidgetRegistry] Unregistered widget: ${widgetName}`);
|
|
}
|
|
return removed;
|
|
},
|
|
|
|
/**
|
|
* Clear all registered widgets (for testing/cleanup)
|
|
*/
|
|
clear: function() {
|
|
this._widgets.clear();
|
|
this._handlers.clear();
|
|
console.log('[WidgetRegistry] Cleared all widgets');
|
|
}
|
|
};
|
|
|
|
// Expose registry for debugging
|
|
if (typeof window !== 'undefined' && window.console) {
|
|
window.LEDMatrixWidgets.debug = function() {
|
|
console.log('[WidgetRegistry] Registered widgets:', Array.from(this._widgets.keys()));
|
|
console.log('[WidgetRegistry] Widget details:', Array.from(this._widgets.entries()).map(([name, def]) => ({
|
|
name,
|
|
version: def.version || 'unknown',
|
|
hasRender: typeof def.render === 'function',
|
|
hasGetValue: typeof def.getValue === 'function',
|
|
hasSetValue: typeof def.setValue === 'function',
|
|
hasHandlers: !!def.handlers
|
|
})));
|
|
};
|
|
}
|
|
|
|
console.log('[WidgetRegistry] Widget registry initialized');
|
|
})();
|