Files
LEDMatrix/web_interface/templates/v3/partials/fonts.html
Chuck 448a15c1e6 feat(fonts): add dynamic font selection and font manager improvements (#232)
* feat(fonts): add dynamic font selection and font manager improvements

- Add font-selector widget for dynamic font selection in plugin configs
- Enhance /api/v3/fonts/catalog with filename, display_name, and type
- Add /api/v3/fonts/preview endpoint for server-side font rendering
- Add /api/v3/fonts/<family> DELETE endpoint with system font protection
- Fix /api/v3/fonts/upload to actually save uploaded font files
- Update font manager tab with dynamic dropdowns, server-side preview, and font deletion
- Add new BDF fonts: 6x10, 6x12, 6x13, 7x13, 7x14, 8x13, 9x15, 9x18, 10x20 (with bold/oblique variants)
- Add tom-thumb, helvR12, clR6x12, texgyre-27 fonts

Plugin authors can use x-widget: "font-selector" in schemas to enable
dynamic font selection that automatically shows all available fonts.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): security fixes and code quality improvements

- Fix README.md typos and add language tags to code fences
- Remove duplicate delete_font function causing Flask endpoint collision
- Add safe integer parsing for size parameter in preview endpoint
- Fix path traversal vulnerability in /fonts/preview endpoint
- Fix path traversal vulnerability in /fonts/<family> DELETE endpoint
- Fix XSS vulnerability in fonts.html by using DOM APIs instead of innerHTML
- Move baseUrl to shared scope to fix ReferenceError in multiple functions

Security improvements:
- Validate font filenames reject path separators and '..'
- Validate paths are within fonts_dir before file operations
- Use textContent and data attributes instead of inline onclick handlers
- Restrict file extensions to known font types

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): address code issues and XSS vulnerabilities

- Move `import re` to module level, remove inline imports
- Remove duplicate font_file assignment in upload_font()
- Remove redundant validation with inconsistent allowed extensions
- Remove redundant PathLib import, use already-imported Path
- Fix XSS vulnerabilities in fonts.html by using DOM APIs instead of
  innerHTML with template literals for user-controlled data

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): add size limits to font preview endpoint

Add input validation to prevent DoS via large image generation:
- MAX_TEXT_CHARS (100): Limit text input length
- MAX_TEXT_LINES (3): Limit number of newlines
- MAX_DIM (1024): Limit max width/height
- MAX_PIXELS (500000): Limit total pixel count

Validates text early before processing and checks computed
dimensions after bbox calculation but before image allocation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): improve error handling, catalog keys, and BDF preview

- Add structured logging for cache invalidation failures instead of
  silent pass (FontUpload, FontDelete, FontCatalog contexts)
- Use filename as unique catalog key to prevent collisions when
  multiple font files share the same family_name from metadata
- Return explicit error for BDF font preview instead of showing
  misleading preview with default font

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): address nitpick issues in font management

Frontend (fonts.html):
- Remove unused escapeHtml function (dead code)
- Add max-attempts guard (50 retries) to initialization loop
- Add response.ok checks before JSON parsing in deleteFont,
  addFontOverride, deleteFontOverride, uploadSelectedFonts
- Use is_system flag from API instead of hardcoded client-side list

Backend (api_v3.py):
- Move SYSTEM_FONTS to module-level frozenset for single source of truth
- Add is_system flag to font catalog entries
- Simplify delete_font system font check using frozenset lookup

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): align frontend upload validation with backend

- Add .otf to accepted file extensions (HTML accept attribute, JS filter)
- Update validation regex to allow hyphens (matching backend)
- Preserve hyphens in auto-generated font family names
- Update UI text to reflect all supported formats

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): fix lint errors and missing variable

- Remove unused exception binding in set_cached except block
- Define font_family_lower before case-insensitive fallback loop
- Add response.ok check to font preview fetch (consistent with other handlers)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): address nitpick code quality issues

- Add return type hints to get_font_preview and delete_font endpoints
- Catch specific PIL exceptions (IOError/OSError) when loading fonts
- Replace innerHTML with DOM APIs for trash icon (consistency)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix(fonts): remove unused exception bindings in cache-clearing blocks

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-11 18:21:27 -05:00

1120 lines
42 KiB
HTML

<div class="bg-white rounded-lg shadow p-6">
<div class="border-b border-gray-200 pb-4 mb-6">
<h2 class="text-lg font-semibold text-gray-900">Font Management</h2>
<p class="mt-1 text-sm text-gray-600">Manage custom fonts, overrides, and system font configuration for your LED matrix display.</p>
</div>
<!-- Font System Overview -->
<div class="grid grid-cols-1 md:grid-cols-2 xl:grid-cols-2 2xl:grid-cols-2 gap-6 mb-8">
<!-- Detected Fonts from Managers -->
<div class="bg-gray-50 rounded-lg p-4">
<h3 class="text-md font-medium text-gray-900 mb-3">Detected Manager Fonts</h3>
<div id="detected-fonts" class="bg-gray-800 text-gray-100 font-mono text-sm p-3 rounded h-40 overflow-y-auto">
<div class="text-gray-400">Loading...</div>
</div>
<p class="text-sm text-gray-600 mt-2">Fonts currently in use by managers (auto-detected)</p>
</div>
<!-- Available Fonts -->
<div class="bg-gray-50 rounded-lg p-4">
<h3 class="text-md font-medium text-gray-900 mb-3">Available Font Families</h3>
<div id="available-fonts" class="bg-gray-800 text-gray-100 font-mono text-sm p-3 rounded h-40 overflow-y-auto">
<div class="text-gray-400">Loading...</div>
</div>
<p class="text-sm text-gray-600 mt-2">All available font families in the system</p>
</div>
</div>
<!-- Font Upload -->
<div class="bg-gray-50 rounded-lg p-4 mb-8">
<h3 class="text-md font-medium text-gray-900 mb-4">Upload Custom Fonts</h3>
<p class="text-sm text-gray-600 mb-4">Upload your own TTF, OTF, or BDF font files to use in your LED matrix display.</p>
<div class="font-upload-area" id="font-upload-area">
<div class="upload-dropzone" id="upload-dropzone">
<i class="fas fa-cloud-upload-alt text-3xl text-gray-400 mb-3"></i>
<p class="text-gray-600">Drag and drop font files here, or click to select</p>
<p class="text-sm text-gray-500">Supports .ttf, .otf, and .bdf files</p>
<input type="file" id="font-file-input" accept=".ttf,.otf,.bdf" multiple style="display: none;">
</div>
</div>
<div class="upload-form" id="upload-form" style="display: none;">
<div class="mt-4 p-4 bg-white rounded border">
<h4 class="text-sm font-medium text-gray-900 mb-3">Selected Files</h4>
<div id="selected-files" class="space-y-2 mb-4">
<!-- Files will be listed here -->
</div>
<div class="grid grid-cols-1 md:grid-cols-2 gap-4">
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Font Family Name</label>
<input type="text" id="upload-font-family" class="form-control" placeholder="e.g., my-custom-font">
<p class="text-sm text-gray-600 mt-1">Custom name for this font (letters, numbers, underscores, hyphens)</p>
</div>
<div class="flex items-end">
<button type="button" id="upload-fonts-btn" class="btn bg-blue-600 hover:bg-blue-700 text-white px-4 py-2">
<i class="fas fa-upload mr-2"></i>Upload Fonts
</button>
<button type="button" id="cancel-upload-btn" class="btn bg-gray-600 hover:bg-gray-700 text-white px-4 py-2 ml-2">
<i class="fas fa-times mr-2"></i>Cancel
</button>
</div>
</div>
</div>
</div>
<!-- Upload Progress -->
<div id="upload-progress" class="mt-4 hidden">
<div class="bg-white rounded p-4 border">
<div class="flex items-center justify-between mb-2">
<span class="text-sm font-medium">Uploading...</span>
<span id="upload-percent" class="text-sm">0%</span>
</div>
<div class="w-full bg-gray-200 rounded-full h-2">
<div id="upload-progress-bar" class="bg-blue-600 h-2 rounded-full" style="width: 0%"></div>
</div>
</div>
</div>
</div>
<!-- Font Overrides -->
<div class="bg-gray-50 rounded-lg p-4 mb-8">
<h3 class="text-md font-medium text-gray-900 mb-4">Element Font Overrides</h3>
<p class="text-sm text-gray-600 mb-4">Override fonts for specific display elements. Changes take effect immediately.</p>
<!-- Add New Override -->
<div class="grid grid-cols-1 md:grid-cols-4 xl:grid-cols-4 2xl:grid-cols-4 gap-4 mb-4 p-4 bg-white rounded border">
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Element</label>
<select id="override-element" class="form-control text-sm">
<option value="">Select an element...</option>
<optgroup label="Sports">
<option value="nfl.live.score">NFL Live Score</option>
<option value="nfl.live.time">NFL Live Time</option>
<option value="nfl.live.team">NFL Live Team</option>
<option value="mlb.live.score">MLB Live Score</option>
<option value="nhl.live.score">NHL Live Score</option>
<option value="nba.live.score">NBA Live Score</option>
</optgroup>
<optgroup label="Clock">
<option value="clock.time">Clock Time</option>
<option value="clock.date">Clock Date</option>
</optgroup>
<optgroup label="Weather">
<option value="weather.current">Weather Current</option>
<option value="weather.forecast">Weather Forecast</option>
</optgroup>
</select>
</div>
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Font Family</label>
<select id="override-family" class="form-control text-sm">
<option value="">Use default</option>
<!-- Dynamically populated from font catalog -->
</select>
</div>
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Font Size</label>
<select id="override-size" class="form-control text-sm">
<option value="">Use default</option>
<option value="xs">Extra Small (6px)</option>
<option value="sm">Small (8px)</option>
<option value="md">Medium (10px)</option>
<option value="lg">Large (12px)</option>
<option value="xl">Extra Large (14px)</option>
</select>
</div>
<div class="flex items-end">
<button id="add-override-btn" class="btn bg-blue-600 hover:bg-blue-700 text-white px-4 py-2">
<i class="fas fa-plus mr-2"></i>Add Override
</button>
</div>
</div>
<!-- Current Overrides List -->
<div id="overrides-container">
<h4 class="text-sm font-medium text-gray-900 mb-3">Current Overrides</h4>
<div id="overrides-list" class="space-y-2">
<!-- Overrides will be populated here -->
<div class="text-gray-500 text-sm italic">No font overrides configured</div>
</div>
</div>
</div>
<!-- Font Preview -->
<div class="bg-gray-50 rounded-lg p-4">
<h3 class="text-md font-medium text-gray-900 mb-4">Font Preview</h3>
<div class="grid grid-cols-1 md:grid-cols-2 xl:grid-cols-2 2xl:grid-cols-2 gap-6">
<div>
<div id="font-preview-container" class="border border-gray-300 bg-black rounded p-4 min-h-[100px] flex items-center justify-center">
<img id="font-preview-image" src="" alt="Font preview" class="max-w-full" style="display: none;">
<span id="font-preview-loading" class="text-gray-400">Select a font to preview</span>
</div>
</div>
<div class="space-y-3">
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Preview Text</label>
<input type="text" id="preview-text" value="Sample Text 123" class="form-control text-sm">
</div>
<div class="grid grid-cols-2 gap-3">
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Font Family</label>
<select id="preview-family" class="form-control text-sm">
<!-- Dynamically populated from font catalog -->
</select>
</div>
<div>
<label class="block text-sm font-medium text-gray-700 mb-1">Font Size</label>
<select id="preview-size" class="form-control text-sm">
<option value="xs">XS (6px)</option>
<option value="sm">SM (8px)</option>
<option value="md">MD (10px)</option>
<option value="lg">LG (12px)</option>
<option value="xl">XL (14px)</option>
</select>
</div>
</div>
<button id="update-preview-btn" class="btn bg-gray-600 hover:bg-gray-700 text-white px-4 py-2">
<i class="fas fa-eye mr-2"></i>Update Preview
</button>
</div>
</div>
</div>
</div>
<script>
// Prevent script from running multiple times when HTMX reloads content
(function() {
// If script has already loaded, just re-initialize the tab without redeclaring variables/functions
if (typeof window._fontsScriptLoaded !== 'undefined') {
// Script already loaded, just trigger initialization
setTimeout(function() {
if (typeof window.initializeFontsTab === 'function') {
window.initializeFontsTab();
}
}, 50);
return;
}
// Mark script as loaded
window._fontsScriptLoaded = true;
// Initialize global variables on window object
window.fontCatalog = window.fontCatalog || {};
window.fontTokens = window.fontTokens || {};
window.fontOverrides = window.fontOverrides || {};
window.selectedFontFiles = window.selectedFontFiles || [];
// Create references that can be reassigned
var fontCatalog = window.fontCatalog;
var fontTokens = window.fontTokens;
var fontOverrides = window.fontOverrides;
var selectedFontFiles = window.selectedFontFiles;
// Base URL for API calls (shared scope)
var baseUrl = window.location.origin;
// Retry counter for initialization
var initRetryCount = 0;
var MAX_INIT_RETRIES = 50; // 5 seconds max (50 * 100ms)
function initializeFontsTab() {
// Allow re-initialization on each HTMX content swap
// The window._fontsScriptLoaded guard prevents function redeclaration
const detectedEl = document.getElementById('detected-fonts');
const availableEl = document.getElementById('available-fonts');
if (!detectedEl || !availableEl) {
initRetryCount++;
if (initRetryCount >= MAX_INIT_RETRIES) {
console.error('Fonts tab elements not found after max retries, giving up');
return;
}
console.log('Fonts tab elements not found, retrying...', {
detectedFonts: !!detectedEl,
availableFonts: !!availableEl,
attempt: initRetryCount
});
setTimeout(initializeFontsTab, 100);
return;
}
// Reset retry counter on successful init
initRetryCount = 0;
// showNotification is provided by the notification widget (notification.js)
// Fallback only if widget hasn't loaded yet
if (typeof window.showNotification !== 'function') {
window.showNotification = function(message, type = 'info') {
console.log(`[${type.toUpperCase()}]`, message);
};
}
console.log('Initializing font management...');
initializeFontManagement();
// Event listeners (use event delegation or ensure elements exist)
const uploadDropzone = document.getElementById('upload-dropzone');
const fontFileInput = document.getElementById('font-file-input');
const uploadFontsBtn = document.getElementById('upload-fonts-btn');
const cancelUploadBtn = document.getElementById('cancel-upload-btn');
const addOverrideBtn = document.getElementById('add-override-btn');
const updatePreviewBtn = document.getElementById('update-preview-btn');
if (uploadDropzone && fontFileInput) {
uploadDropzone.addEventListener('click', () => {
fontFileInput.click();
});
}
if (fontFileInput) {
fontFileInput.addEventListener('change', handleFileSelection);
}
if (uploadFontsBtn) {
uploadFontsBtn.addEventListener('click', uploadSelectedFonts);
}
if (cancelUploadBtn) {
cancelUploadBtn.addEventListener('click', cancelFontUpload);
}
if (addOverrideBtn) {
addOverrideBtn.addEventListener('click', addFontOverride);
}
if (updatePreviewBtn) {
updatePreviewBtn.addEventListener('click', updateFontPreview);
}
// Drag and drop for upload area
if (uploadDropzone) {
uploadDropzone.addEventListener('dragover', (e) => {
e.preventDefault();
uploadDropzone.classList.add('drag-over');
});
uploadDropzone.addEventListener('dragleave', () => {
uploadDropzone.classList.remove('drag-over');
});
uploadDropzone.addEventListener('drop', (e) => {
e.preventDefault();
uploadDropzone.classList.remove('drag-over');
handleFileSelection({ target: { files: e.dataTransfer.files } });
});
}
console.log('Fonts tab initialized successfully');
}
// Expose initializeFontsTab to window for re-initialization after HTMX reload
window.initializeFontsTab = initializeFontsTab;
// Initialize after HTMX content swap for dynamic loading
// Note: We don't use DOMContentLoaded here because this partial is loaded via HTMX
// after the main page's DOMContentLoaded has already fired
(function() {
// Function to initialize when fonts content is loaded
function tryInitializeFontsTab() {
const fontsContent = document.getElementById('fonts-content');
const detectedFonts = document.getElementById('detected-fonts');
if (fontsContent && detectedFonts) {
console.log('Fonts content detected, initializing...');
setTimeout(() => {
initializeFontsTab();
}, 50);
}
}
// Set up HTMX event listener for when content is swapped
if (typeof document.body !== 'undefined') {
document.body.addEventListener('htmx:afterSettle', function(event) {
// Check if the event target is the fonts-content container or contains it
const target = event.target;
if (target && (target.id === 'fonts-content' || target.querySelector && target.querySelector('#fonts-content'))) {
console.log('HTMX loaded fonts content, initializing...', target.id);
tryInitializeFontsTab();
}
});
}
// Also check if content is already loaded (e.g., if script runs after HTMX swap)
// This handles the case where the script executes after HTMX has already swapped
if (document.readyState === 'loading') {
document.addEventListener('DOMContentLoaded', tryInitializeFontsTab);
} else {
// DOM already loaded, check immediately
tryInitializeFontsTab();
}
})();
async function initializeFontManagement() {
try {
await loadFontData();
populateFontSelects();
displayCurrentOverrides();
updateFontPreview();
initializeFontUpload();
} catch (error) {
console.error('Error initializing font management:', error);
showNotification('Error loading font configuration', 'error');
}
}
async function loadFontData() {
const detectedContainer = document.getElementById('detected-fonts');
const availableContainer = document.getElementById('available-fonts');
// Ensure containers exist before proceeding
if (!detectedContainer || !availableContainer) {
console.error('Font containers not found, cannot load font data');
return;
}
// Show loading states
detectedContainer.innerHTML = '<div class="text-blue-400">Loading font data...</div>';
availableContainer.innerHTML = '<div class="text-blue-400">Loading font data...</div>';
try {
// Use absolute URLs to ensure they work when loaded via HTMX
const [catalogRes, tokensRes, overridesRes] = await Promise.all([
fetch(`${baseUrl}/api/v3/fonts/catalog`),
fetch(`${baseUrl}/api/v3/fonts/tokens`),
fetch(`${baseUrl}/api/v3/fonts/overrides`)
]);
// Check if all responses are successful
if (!catalogRes.ok || !tokensRes.ok || !overridesRes.ok) {
const statusText = `HTTP ${catalogRes.status}/${tokensRes.status}/${overridesRes.status}`;
console.error('Font API error:', statusText);
throw new Error(`Failed to load font data: ${statusText}`);
}
const catalogData = await catalogRes.json();
const tokensData = await tokensRes.json();
const overridesData = await overridesRes.json();
// Validate response structure
if (!catalogData || !catalogData.data || !tokensData || !tokensData.data || !overridesData || !overridesData.data) {
console.error('Invalid font API response structure:', {
catalog: !!catalogData?.data,
tokens: !!tokensData?.data,
overrides: !!overridesData?.data
});
throw new Error('Invalid response format from font API');
}
// Update both window properties and local references
window.fontCatalog = catalogData.data.catalog || {};
window.fontTokens = tokensData.data.tokens || {};
window.fontOverrides = overridesData.data.overrides || {};
// Update local variable references
fontCatalog = window.fontCatalog;
fontTokens = window.fontTokens;
fontOverrides = window.fontOverrides;
// Update displays
updateDetectedFontsDisplay();
updateAvailableFontsDisplay();
console.log('Font data loaded successfully', {
catalogSize: Object.keys(fontCatalog).length,
tokensSize: Object.keys(fontTokens).length,
overridesSize: Object.keys(fontOverrides).length
});
} catch (error) {
console.error('Error loading font data:', error);
// Show error states
detectedContainer.innerHTML = '<div class="text-red-400">Error loading font data. Please refresh the page.</div>';
availableContainer.innerHTML = '<div class="text-red-400">Error loading font data. Please refresh the page.</div>';
// Only show notification if showNotification is available
if (typeof showNotification === 'function') {
showNotification('Error loading font configuration', 'error');
} else if (typeof window.showNotification === 'function') {
window.showNotification('Error loading font configuration', 'error');
} else {
console.error('Error loading font configuration:', error.message);
}
}
}
function updateDetectedFontsDisplay() {
const container = document.getElementById('detected-fonts');
if (!container) return;
// In a real implementation, this would collect font usage from all active managers
// For now, we'll simulate this by analyzing the font overrides and catalog
const detectedFonts = {};
// Check font overrides for active elements
for (const [elementKey, override] of Object.entries(fontOverrides)) {
if (override.family) {
detectedFonts[elementKey] = {
family: override.family,
size_px: override.size_px || 8,
usage_count: 1, // Would be actual usage count in real implementation
source: 'override'
};
}
}
// Check font catalog for commonly used fonts
for (const [fontKey, fontPath] of Object.entries(fontCatalog)) {
// Add some commonly used system fonts if not already in overrides
if (!detectedFonts[fontKey]) {
detectedFonts[fontKey] = {
family: fontKey,
size_px: 8,
usage_count: 1,
source: 'system'
};
}
}
if (Object.keys(detectedFonts).length === 0) {
container.innerHTML = '<div class="text-gray-400">No fonts detected yet (managers will register fonts when they render)</div>';
return;
}
const lines = [];
for (const [elementKey, fontInfo] of Object.entries(detectedFonts)) {
const sourceStr = fontInfo.source === 'override' ? ' [OVERRIDE]' : ' [SYSTEM]';
lines.push(`${elementKey}: ${fontInfo.family}@${fontInfo.size_px}px (used ${fontInfo.usage_count}x)${sourceStr}`);
}
container.textContent = lines.join('\n');
}
function updateAvailableFontsDisplay() {
const container = document.getElementById('available-fonts');
if (!container) return;
if (Object.keys(fontCatalog).length === 0) {
container.innerHTML = '<div class="text-gray-400">No fonts available</div>';
return;
}
const fontEntries = Object.entries(fontCatalog).map(([name, fontInfo]) => {
const fontPath = typeof fontInfo === 'string' ? fontInfo : (fontInfo?.path || '');
const filename = typeof fontInfo === 'object' ? (fontInfo.filename || name) : name;
const displayName = typeof fontInfo === 'object' ? (fontInfo.display_name || name) : name;
const fontType = typeof fontInfo === 'object' ? (fontInfo.type || '').toUpperCase() : '';
// Use is_system flag from API (single source of truth)
const isSystem = typeof fontInfo === 'object' ? (fontInfo.is_system === true) : false;
return { name, filename, displayName, fontType, fontPath, isSystem };
}).sort((a, b) => a.displayName.localeCompare(b.displayName));
// Build list using DOM APIs to prevent XSS
container.innerHTML = '';
fontEntries.forEach(font => {
const row = document.createElement('div');
row.className = 'flex items-center justify-between py-1 border-b border-gray-700 last:border-0';
const nameSpan = document.createElement('span');
nameSpan.className = 'truncate flex-1';
nameSpan.textContent = font.displayName;
if (font.fontType) {
const typeSpan = document.createElement('span');
typeSpan.className = 'text-gray-500 ml-1';
typeSpan.textContent = `(${font.fontType})`;
nameSpan.appendChild(typeSpan);
}
row.appendChild(nameSpan);
if (font.isSystem) {
const systemBadge = document.createElement('span');
systemBadge.className = 'text-gray-600 text-xs ml-2';
systemBadge.textContent = '[system]';
row.appendChild(systemBadge);
} else {
const deleteBtn = document.createElement('button');
deleteBtn.className = 'text-red-400 hover:text-red-300 text-xs ml-2';
deleteBtn.title = 'Delete font';
deleteBtn.textContent = '[delete]';
deleteBtn.dataset.fontName = font.name;
deleteBtn.addEventListener('click', function() {
deleteFont(this.dataset.fontName);
});
row.appendChild(deleteBtn);
}
container.appendChild(row);
});
}
async function deleteFont(fontFamily) {
if (!confirm(`Are you sure you want to delete the font "${fontFamily}"? This action cannot be undone.`)) {
return;
}
try {
const response = await fetch(`${baseUrl}/api/v3/fonts/${encodeURIComponent(fontFamily)}`, {
method: 'DELETE'
});
if (!response.ok) {
const text = await response.text();
let message;
try {
const errorData = JSON.parse(text);
message = errorData.message || `Server error: ${response.status}`;
} catch {
message = `Server error: ${response.status}`;
}
showNotification(message, 'error');
return;
}
const data = await response.json();
if (data.status === 'success') {
showNotification(data.message || `Font "${fontFamily}" deleted successfully`, 'success');
// Refresh font data and UI
await loadFontData();
populateFontSelects();
// Clear font-selector widget cache if available
if (typeof window.clearFontSelectorCache === 'function') {
window.clearFontSelectorCache();
}
} else {
showNotification(data.message || `Failed to delete font "${fontFamily}"`, 'error');
}
} catch (error) {
console.error('Error deleting font:', error);
showNotification(`Error deleting font: ${error.message}`, 'error');
}
}
function populateFontSelects() {
// Populate font family dropdowns from catalog
const overrideSelect = document.getElementById('override-family');
const previewSelect = document.getElementById('preview-family');
if (!overrideSelect || !previewSelect) return;
// Get font entries sorted by display name
const fontEntries = Object.entries(fontCatalog).map(([key, info]) => {
const filename = typeof info === 'object' ? (info.filename || key) : key;
const displayName = typeof info === 'object' ? (info.display_name || key) : key;
const fontType = typeof info === 'object' ? (info.type || 'unknown').toUpperCase() : '';
return { key, filename, displayName, fontType };
}).sort((a, b) => a.displayName.localeCompare(b.displayName));
// Build options using DOM APIs to prevent XSS
// Clear and add default option for override select
overrideSelect.innerHTML = '';
const defaultOption = document.createElement('option');
defaultOption.value = '';
defaultOption.textContent = 'Use default';
overrideSelect.appendChild(defaultOption);
// Clear preview select
previewSelect.innerHTML = '';
// Add font options to both selects
fontEntries.forEach(font => {
const typeLabel = font.fontType ? ` (${font.fontType})` : '';
const overrideOpt = document.createElement('option');
overrideOpt.value = font.filename;
overrideOpt.textContent = font.displayName + typeLabel;
overrideSelect.appendChild(overrideOpt);
const previewOpt = document.createElement('option');
previewOpt.value = font.filename;
previewOpt.textContent = font.displayName + typeLabel;
previewSelect.appendChild(previewOpt);
});
// Select first font in preview if available
if (fontEntries.length > 0) {
previewSelect.value = fontEntries[0].filename;
}
console.log(`Populated font selects with ${fontEntries.length} fonts`);
}
async function addFontOverride() {
const element = document.getElementById('override-element').value;
const family = document.getElementById('override-family').value;
const sizeToken = document.getElementById('override-size').value;
if (!element) {
showNotification('Please select an element', 'warning');
return;
}
if (!family && !sizeToken) {
showNotification('Please specify at least a font family or size', 'warning');
return;
}
try {
const overrideData = {};
if (family) overrideData.family = family;
if (sizeToken) {
const sizePx = fontTokens[sizeToken];
if (sizePx) overrideData.size_px = sizePx;
}
const response = await fetch(`${baseUrl}/api/v3/fonts/overrides`, {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
[element]: overrideData
})
});
if (!response.ok) {
const text = await response.text();
let message;
try {
const errorData = JSON.parse(text);
message = errorData.message || `Server error: ${response.status}`;
} catch {
message = `Server error: ${response.status}`;
}
showNotification('Error adding font override: ' + message, 'error');
return;
}
const data = await response.json();
if (data.status === 'success') {
showNotification('Font override added successfully', 'success');
await loadFontData();
displayCurrentOverrides();
// Clear form
document.getElementById('override-element').value = '';
document.getElementById('override-family').value = '';
document.getElementById('override-size').value = '';
} else {
showNotification('Error adding font override: ' + data.message, 'error');
}
} catch (error) {
console.error('Error adding font override:', error);
showNotification('Error adding font override: ' + error, 'error');
}
}
async function deleteFontOverride(elementKey) {
if (!confirm(`Are you sure you want to remove the font override for "${elementKey}"?`)) {
return;
}
try {
const response = await fetch(`${baseUrl}/api/v3/fonts/overrides/${elementKey}`, {
method: 'DELETE'
});
if (!response.ok) {
const text = await response.text();
let message;
try {
const errorData = JSON.parse(text);
message = errorData.message || `Server error: ${response.status}`;
} catch {
message = `Server error: ${response.status}`;
}
showNotification('Error removing font override: ' + message, 'error');
return;
}
const data = await response.json();
if (data.status === 'success') {
showNotification('Font override removed successfully', 'success');
await loadFontData();
displayCurrentOverrides();
} else {
showNotification('Error removing font override: ' + data.message, 'error');
}
} catch (error) {
console.error('Error deleting font override:', error);
showNotification('Error removing font override: ' + error, 'error');
}
}
function displayCurrentOverrides() {
const container = document.getElementById('overrides-list');
if (!container) return;
if (Object.keys(fontOverrides).length === 0) {
container.innerHTML = '<div class="text-gray-500 text-sm italic">No font overrides configured</div>';
return;
}
// Build list using DOM APIs to prevent XSS
container.innerHTML = '';
Object.entries(fontOverrides).forEach(([elementKey, override]) => {
const elementName = getElementDisplayName(elementKey);
const settings = [];
if (override.family) {
const familyName = getFontDisplayName(override.family);
settings.push(`Family: ${familyName}`);
}
if (override.size_px) {
settings.push(`Size: ${override.size_px}px`);
}
const row = document.createElement('div');
row.className = 'flex items-center justify-between p-3 bg-white rounded border';
const infoDiv = document.createElement('div');
const nameDiv = document.createElement('div');
nameDiv.className = 'font-medium text-gray-900';
nameDiv.textContent = elementName;
const settingsDiv = document.createElement('div');
settingsDiv.className = 'text-sm text-gray-600';
settingsDiv.textContent = settings.join(', ');
infoDiv.appendChild(nameDiv);
infoDiv.appendChild(settingsDiv);
const deleteBtn = document.createElement('button');
deleteBtn.className = 'btn bg-red-600 hover:bg-red-700 text-white px-3 py-1 text-sm';
const trashIcon = document.createElement('i');
trashIcon.className = 'fas fa-trash mr-1';
deleteBtn.appendChild(trashIcon);
deleteBtn.appendChild(document.createTextNode('Remove'));
deleteBtn.dataset.elementKey = elementKey;
deleteBtn.addEventListener('click', function() {
deleteFontOverride(this.dataset.elementKey);
});
row.appendChild(infoDiv);
row.appendChild(deleteBtn);
container.appendChild(row);
});
}
function getElementDisplayName(elementKey) {
const names = {
'nfl.live.score': 'NFL Live Score',
'nfl.live.time': 'NFL Live Time',
'nfl.live.team': 'NFL Live Team',
'mlb.live.score': 'MLB Live Score',
'nhl.live.score': 'NHL Live Score',
'nba.live.score': 'NBA Live Score',
'clock.time': 'Clock Time',
'clock.date': 'Clock Date',
'weather.current': 'Weather Current',
'weather.forecast': 'Weather Forecast'
};
return names[elementKey] || elementKey;
}
function getFontDisplayName(fontKey) {
const names = {
'press_start': 'Press Start 2P',
'four_by_six': '4x6 Font',
'matrix_light_6': 'Matrix Light 6'
};
return names[fontKey] || fontKey;
}
async function updateFontPreview() {
const previewImage = document.getElementById('font-preview-image');
const loadingText = document.getElementById('font-preview-loading');
const textInput = document.getElementById('preview-text');
const familySelect = document.getElementById('preview-family');
const sizeSelect = document.getElementById('preview-size');
if (!previewImage || !loadingText) return;
const text = textInput?.value || 'Sample Text 123';
const family = familySelect?.value || '';
const sizeToken = sizeSelect?.value || 'md';
const sizePx = fontTokens[sizeToken] || 10;
if (!family) {
previewImage.style.display = 'none';
loadingText.style.display = 'block';
loadingText.textContent = 'Select a font to preview';
return;
}
// Show loading state
loadingText.textContent = 'Loading preview...';
loadingText.style.display = 'block';
previewImage.style.display = 'none';
try {
const params = new URLSearchParams({
font: family,
text: text,
size: sizePx,
bg: '000000',
fg: 'ffffff'
});
const response = await fetch(`${baseUrl}/api/v3/fonts/preview?${params}`);
if (!response.ok) {
const text = await response.text();
let message;
try {
const errorData = JSON.parse(text);
message = errorData.message || `Server error: ${response.status}`;
} catch {
message = `Server error: ${response.status}`;
}
loadingText.textContent = message;
loadingText.style.display = 'block';
previewImage.style.display = 'none';
return;
}
const data = await response.json();
if (data.status === 'success' && data.data?.image) {
previewImage.src = data.data.image;
previewImage.style.display = 'block';
loadingText.style.display = 'none';
} else {
loadingText.textContent = data.message || 'Failed to load preview';
loadingText.style.display = 'block';
previewImage.style.display = 'none';
}
} catch (error) {
console.error('Error loading font preview:', error);
loadingText.textContent = 'Error loading preview';
loadingText.style.display = 'block';
previewImage.style.display = 'none';
}
}
function initializeFontUpload() {
// Setup already done in event listeners
}
function handleFileSelection(event) {
const files = Array.from(event.target.files);
const validExtensions = ['ttf', 'otf', 'bdf'];
const validFiles = files.filter(file => {
const extension = file.name.toLowerCase().split('.').pop();
return validExtensions.includes(extension);
});
if (validFiles.length === 0) {
showNotification('Please select valid .ttf, .otf, or .bdf font files', 'warning');
return;
}
if (validFiles.length !== files.length) {
showNotification(`${files.length - validFiles.length} invalid files were ignored`, 'warning');
}
selectedFontFiles = validFiles;
showUploadForm();
}
function showUploadForm() {
if (selectedFontFiles.length === 0) return;
const uploadForm = document.getElementById('upload-form');
const selectedFilesContainer = document.getElementById('selected-files');
const fontFamilyInput = document.getElementById('upload-font-family');
// Show selected files using DOM APIs to prevent XSS
selectedFilesContainer.innerHTML = '';
selectedFontFiles.forEach(file => {
const row = document.createElement('div');
row.className = 'flex items-center justify-between p-2 bg-gray-100 rounded';
const span = document.createElement('span');
span.className = 'text-sm';
span.textContent = `${file.name} (${(file.size / 1024).toFixed(1)} KB)`;
row.appendChild(span);
selectedFilesContainer.appendChild(row);
});
// Auto-generate font family name from first file
if (selectedFontFiles.length === 1) {
const filename = selectedFontFiles[0].name;
const nameWithoutExt = filename.substring(0, filename.lastIndexOf('.'));
// Preserve hyphens, convert other special chars to underscores
fontFamilyInput.value = nameWithoutExt.toLowerCase().replace(/[^a-z0-9-]/g, '_');
}
uploadForm.style.display = 'block';
uploadForm.scrollIntoView({ behavior: 'smooth' });
}
function cancelFontUpload() {
selectedFontFiles = [];
document.getElementById('upload-form').style.display = 'none';
document.getElementById('font-file-input').value = '';
}
async function uploadSelectedFonts() {
if (selectedFontFiles.length === 0) {
showNotification('No files selected', 'warning');
return;
}
const fontFamilyInput = document.getElementById('upload-font-family');
const fontFamily = fontFamilyInput.value.trim();
if (!fontFamily) {
showNotification('Please enter a font family name', 'warning');
return;
}
// Validate font family name (must match backend validation)
if (!/^[a-z0-9_-]+$/i.test(fontFamily)) {
showNotification('Font family name can only contain letters, numbers, underscores, and hyphens', 'warning');
return;
}
try {
showNotification('Uploading fonts...', 'info');
showUploadProgress();
for (let i = 0; i < selectedFontFiles.length; i++) {
const file = selectedFontFiles[i];
const formData = new FormData();
formData.append('font_file', file);
formData.append('font_family', i === 0 ? fontFamily : `${fontFamily}_${i + 1}`);
const response = await fetch(`${baseUrl}/api/v3/fonts/upload`, {
method: 'POST',
body: formData
});
if (!response.ok) {
const text = await response.text();
let message;
try {
const errorData = JSON.parse(text);
message = errorData.message || `Server error: ${response.status}`;
} catch {
message = `Server error: ${response.status}`;
}
showNotification(`Error uploading "${file.name}": ${message}`, 'error');
continue;
}
const data = await response.json();
if (data.status === 'success') {
showNotification(`Font "${data.font_family}" uploaded successfully`, 'success');
} else {
showNotification(`Error uploading "${file.name}": ${data.message}`, 'error');
}
// Update progress
const percent = ((i + 1) / selectedFontFiles.length) * 100;
updateUploadProgress(percent);
}
// Refresh font data and UI
await loadFontData();
populateFontSelects();
cancelFontUpload();
hideUploadProgress();
// Clear font-selector widget cache so new fonts appear in plugin configs
if (typeof window.clearFontSelectorCache === 'function') {
window.clearFontSelectorCache();
}
} catch (error) {
console.error('Error uploading fonts:', error);
showNotification('Error uploading fonts: ' + error, 'error');
hideUploadProgress();
}
}
function showUploadProgress() {
document.getElementById('upload-progress').classList.remove('hidden');
}
function hideUploadProgress() {
document.getElementById('upload-progress').classList.add('hidden');
}
function updateUploadProgress(percent) {
document.getElementById('upload-percent').textContent = Math.round(percent) + '%';
document.getElementById('upload-progress-bar').style.width = percent + '%';
}
})(); // End of script load guard - prevents redeclaration on HTMX reload
</script>
<style>
.drag-over {
border-color: #3b82f6 !important;
background-color: #eff6ff !important;
transform: scale(1.02);
}
.font-upload-area {
margin: 15px 0;
}
.upload-dropzone {
border: 3px dashed #d1d5db;
border-radius: 10px;
padding: 40px;
text-align: center;
background: #fafafa;
transition: all 0.3s ease;
cursor: pointer;
}
.upload-dropzone:hover {
border-color: #3b82f6;
background: #f0f8ff;
}
.upload-dropzone i {
font-size: 3rem;
color: #3b82f6;
margin-bottom: 15px;
display: block;
}
.upload-dropzone p {
margin: 5px 0;
font-size: 1.1rem;
color: #374151;
}
.upload-hint {
font-size: 0.9rem !important;
color: #6b7280 !important;
font-style: italic;
}
.upload-form {
margin-top: 20px;
padding: 20px;
background: #f9f9f9;
border-radius: 8px;
border: 1px solid #d1d5db;
}
#font-preview-container {
max-width: 100%;
min-height: 100px;
}
#font-preview-image {
max-width: 100%;
height: auto;
}
</style>