* feat: add error detection, monitoring, and code quality improvements This comprehensive update addresses automatic error detection, code quality, and plugin development experience: ## Error Detection & Monitoring - Add ErrorAggregator service for centralized error tracking - Add pattern detection for recurring errors (5+ in 60 min) - Add error dashboard API endpoints (/api/v3/errors/*) - Integrate error recording into plugin executor ## Code Quality - Remove 10 silent `except: pass` blocks in sports.py and football.py - Remove hardcoded debug log paths - Add pre-commit hooks to prevent future bare except clauses ## Validation & Type Safety - Add warnings when plugins lack config_schema.json - Add config key collision detection for plugins - Improve type coercion logging in BasePlugin ## Testing - Add test_config_validation_edge_cases.py - Add test_plugin_loading_failures.py - Add test_error_aggregator.py ## Documentation - Add PLUGIN_ERROR_HANDLING.md guide - Add CONFIG_DEBUGGING.md guide Note: GitHub Actions CI workflow is available in the plan but requires workflow scope to push. Add .github/workflows/ci.yml manually. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address code review issues - Fix GitHub issues URL in CONFIG_DEBUGGING.md - Use RLock in error_aggregator.py to prevent deadlock in export_to_file - Distinguish missing vs invalid schema files in plugin_manager.py - Add assertions to test_null_value_for_required_field test - Remove unused initial_count variable in test_plugin_load_error_recorded - Add validation for max_age_hours in clear_old_errors API endpoint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
6.0 KiB
Configuration Debugging Guide
This guide helps troubleshoot configuration issues in LEDMatrix.
Configuration Files
Main Files
| File | Purpose |
|---|---|
config/config.json |
Main configuration |
config/config_secrets.json |
API keys and sensitive data |
config/config.template.json |
Template for new installations |
Plugin Configuration
Each plugin's configuration is a top-level key in config.json:
{
"football-scoreboard": {
"enabled": true,
"display_duration": 30,
"nfl": {
"enabled": true,
"live_priority": false
}
},
"odds-ticker": {
"enabled": true,
"display_duration": 15
}
}
Schema Validation
Plugins define their configuration schema in config_schema.json. This enables:
- Automatic default value population
- Configuration validation
- Web UI form generation
Missing Schema Warning
If a plugin doesn't have config_schema.json, you'll see:
WARNING - Plugin 'my-plugin' has no config_schema.json - configuration will not be validated.
Fix: Add a config_schema.json to your plugin directory.
Schema Example
{
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"properties": {
"enabled": {
"type": "boolean",
"default": true,
"description": "Enable or disable this plugin"
},
"display_duration": {
"type": "number",
"default": 15,
"minimum": 1,
"description": "How long to display in seconds"
},
"api_key": {
"type": "string",
"description": "API key for data access"
}
},
"required": ["api_key"]
}
Common Configuration Issues
1. Type Mismatches
Problem: String value where number expected
{
"display_duration": "30" // Wrong: string
}
Fix: Use correct types
{
"display_duration": 30 // Correct: number
}
Logged Warning:
WARNING - Config display_duration has invalid string value '30', using default 15.0
2. Missing Required Fields
Problem: Required field not in config
{
"football-scoreboard": {
"enabled": true
// Missing api_key which is required
}
}
Logged Error:
ERROR - Plugin football-scoreboard configuration validation failed: 'api_key' is a required property
3. Invalid Nested Objects
Problem: Wrong structure for nested config
{
"football-scoreboard": {
"nfl": "enabled" // Wrong: should be object
}
}
Fix: Use correct structure
{
"football-scoreboard": {
"nfl": {
"enabled": true
}
}
}
4. Invalid JSON Syntax
Problem: Malformed JSON
{
"plugin": {
"enabled": true, // Trailing comma
}
}
Fix: Remove trailing commas, ensure valid JSON
{
"plugin": {
"enabled": true
}
}
Tip: Validate JSON at https://jsonlint.com/
Debugging Configuration Loading
Enable Debug Logging
Set environment variable:
export LEDMATRIX_DEBUG=1
python run.py
Check Merged Configuration
The configuration is merged with schema defaults. To see the final merged config:
- Enable debug logging
- Look for log entries like:
DEBUG - Merged config with schema defaults for football-scoreboard
Configuration Load Order
- Load
config.json - Load
config_secrets.json - Merge secrets into main config
- For each plugin:
- Load plugin's
config_schema.json - Extract default values from schema
- Merge user config with defaults
- Validate merged config against schema
- Load plugin's
Web Interface Issues
Changes Not Saving
- Check file permissions on
config/directory - Check disk space
- Look for errors in browser console
- Check server logs for save errors
Form Fields Not Appearing
- Plugin may not have
config_schema.json - Schema may have syntax errors
- Check browser console for JavaScript errors
Checkboxes Not Working
Boolean values from checkboxes should be actual booleans, not strings:
{
"enabled": true, // Correct
"enabled": "true" // Wrong
}
Config Key Collision Detection
LEDMatrix detects potential config key conflicts:
Reserved Keys
These plugin IDs will trigger a warning:
display,schedule,timezone,plugin_systemdisplay_modes,system,hardware,debuglog_level,emulator,web_interface
Warning:
WARNING - Plugin ID 'display' conflicts with reserved config key.
Case Collisions
Plugin IDs that differ only in case:
WARNING - Plugin ID 'Football-Scoreboard' may conflict with 'football-scoreboard' on case-insensitive file systems.
Checking Configuration via API
# Get current config
curl http://localhost:5000/api/v3/config
# Get specific plugin config
curl http://localhost:5000/api/v3/config/plugin/football-scoreboard
# Validate config without saving
curl -X POST http://localhost:5000/api/v3/config/validate \
-H "Content-Type: application/json" \
-d '{"football-scoreboard": {"enabled": true}}'
Backup and Recovery
Manual Backup
cp config/config.json config/config.backup.json
Automatic Backups
LEDMatrix creates backups before saves:
- Location:
config/backups/ - Format:
config_YYYYMMDD_HHMMSS.json
Recovery
# List backups
ls -la config/backups/
# Restore from backup
cp config/backups/config_20240115_120000.json config/config.json
Troubleshooting Checklist
- JSON syntax is valid (no trailing commas, quotes correct)
- Data types match schema (numbers are numbers, not strings)
- Required fields are present
- Nested objects have correct structure
- File permissions allow read/write
- No reserved config key collisions
- Plugin has
config_schema.jsonfor validation
Getting Help
- Check logs:
tail -f logs/ledmatrix.log - Enable debug:
LEDMATRIX_DEBUG=1 - Check error dashboard:
/api/v3/errors/summary - Validate JSON: https://jsonlint.com/
- File an issue: https://github.com/ChuckBuilds/LEDMatrix/issues