mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-04-10 13:02:59 +00:00

Files

Chuck 781224591f fix: post-audit follow-up code fixes (cache, fonts, icons, dev script) (#307 )

* fix: post-audit follow-up code fixes (cache, fonts, icons, dev script, CI)

The docs refresh effort (#306, ledmatrix-plugins#92) surfaced seven
code bugs that were intentionally left out of the docs PRs because
they required code changes rather than doc fixes. This PR addresses
the six that belong in LEDMatrix (the seventh — a lacrosse-scoreboard
mode rename — lives in the plugins repo).

Bug 1: cache_manager.delete() AttributeError
  src/common/api_helper.py:287 and
  src/plugin_system/resource_monitor.py:343 both call
  cache_manager.delete(key), which doesn't exist — only
  clear_cache(key=None). Added a delete() alias method on
  CacheManager that forwards to clear_cache(key). Reverts the
  "There is no delete() method" wording in DEVELOPER_QUICK_REFERENCE,
  .cursorrules so the docs match the new shim.

Bug 2: dev_plugin_setup.sh PROJECT_ROOT resolution
  scripts/dev/dev_plugin_setup.sh:9 set PROJECT_ROOT to SCRIPT_DIR
  instead of walking up two levels to the repo root, so PLUGINS_DIR
  resolved to scripts/dev/plugins/ and created symlinks under the
  script's own directory. Fixed the path and removed the stray
  scripts/dev/plugins/of-the-day symlink left by earlier runs.

Bug 3: plugin custom icons regressed from v2 to v3
  web_interface/blueprints/api_v3.py built the /plugins/installed
  response without including the manifest's "icon" field, and
  web_interface/templates/v3/base.html hardcoded
  fas fa-puzzle-piece in all three plugin-tab render sites. Pass
  the icon through the API and read it from the templates with a
  puzzle-piece fallback. Reverts the "currently broken" banners in
  docs/PLUGIN_CUSTOM_ICONS.md and docs/PLUGIN_CUSTOM_ICONS_FEATURE.md.

Bug 4: register_plugin_fonts was never wired up
  src/font_manager.py:150 defines register_plugin_fonts(plugin_id,
  font_manifest) but nothing called it, so plugin manifests with a
  "fonts" block were silently no-ops. Wired the call into
  PluginManager.load_plugin() right after plugin_loader.load_plugin
  returns. Reverts the "not currently wired" warning in
  docs/FONT_MANAGER.md's "For Plugin Developers" section.

Bug 5: dead web_interface_v2 import pattern (LEDMatrix half)
  src/base_odds_manager.py had a try/except importing
  web_interface_v2.increment_api_counter, falling back to a no-op
  stub. The module doesn't exist anywhere in the v3 codebase and
  no API metrics dashboard reads it. Deleted the import block and
  the single call site; the plugins-repo half of this cleanup lands
  in ledmatrix-plugins#<next>.

Bug 7: no CI test workflow
  .github/workflows/ only contained security-audit.yml; pytest ran
  locally but was not gated on PRs. Added
  .github/workflows/tests.yml running pytest against Python 3.10,
  3.11, 3.12 in EMULATOR=true mode, skipping tests marked hardware
  or slow. Updated docs/HOW_TO_RUN_TESTS.md to reflect that the
  workflow now exists.

Verification done locally:
  - CacheManager.delete(key) round-trips with set/get
  - base_odds_manager imports without the v2 module present
  - dev_plugin_setup.sh PROJECT_ROOT resolves to repo root
  - api_v3 and plugin_manager compile clean
  - tests.yml YAML parses
  - Script syntax check on dev_plugin_setup.sh

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address CodeRabbit review comments on #307

- src/cache_manager.py: clear_cache(key) treated empty string as
  "wipe all" because of `if key:`. Switched to `key is None`
  branching, made delete(key) and clear_cache(key) reject empty
  strings and None outright with ValueError, and updated both
  docstrings to make the contract explicit. Verified locally
  with a round-trip test that clear_cache() (no arg) still
  wipes everything but clear_cache("") and delete("") raise.

- src/plugin_system/plugin_manager.py: was reaching for the
  font manager via getattr(self.display_manager, 'font_manager',
  None). PluginManager already takes a dedicated font_manager
  parameter (line 54) and stores it as self.font_manager
  (line 69), so the old path was both wrong and could miss the
  font manager entirely when the host injects them separately.
  Switched to self.font_manager directly with the same try/except
  warning behavior.

- web_interface/templates/v3/base.html: in the full plugin-tab
  renderer, the icon was injected with
  `<i class="${escapeHtml(plugin.icon)}">` — but escapeHtml only
  escapes <, >, and &, not double quotes, so a manifest with a
  quote in its icon string could break out of the class
  attribute. Replaced the innerHTML template with createElement
  for the <i> tag, set className from plugin.icon directly
  (no string interpolation), and used a text node for the
  label. Same fix shape would also harden the two stub-renderer
  sites at line 515 / 774, but those already escape `"` to
  &quot; and CodeRabbit only flagged this site, so leaving them
  for now.

- docs/FONT_MANAGER.md: clarified that the Manual Font Overrides
  *workflow* (set_override / remove_override / font_overrides.json)
  is the supported override path today, and only the Fonts tab
  in the web UI is the placeholder. Previous wording conflated
  the two and made it sound like overrides themselves were
  broken.

- docs/HOW_TO_RUN_TESTS.md: replaced the vague "see the PR
  adding it" with a concrete link to #307 and a note that the
  workflow file itself is held back pending the workflow scope.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-04-08 09:25:12 -04:00

README.md

LEDMatrix Documentation

This directory contains guides, references, and architectural notes for the LEDMatrix project. If you are setting up a Pi for the first time, start with the project root README — it covers hardware, OS imaging, and the one-shot installer. The pages here go deeper.

I'm a new user

GETTING_STARTED.md — first-time setup walkthrough
WEB_INTERFACE_GUIDE.md — using the web UI
PLUGIN_STORE_GUIDE.md — installing and managing plugins
WIFI_NETWORK_SETUP.md — WiFi and AP-mode setup
TROUBLESHOOTING.md — common issues and fixes
SSH_UNAVAILABLE_AFTER_INSTALL.md — recovering SSH after install
CONFIG_DEBUGGING.md — diagnosing config problems

I want to write a plugin

Start here:

PLUGIN_DEVELOPMENT_GUIDE.md — end-to-end workflow
PLUGIN_QUICK_REFERENCE.md — cheat sheet
PLUGIN_API_REFERENCE.md — display, cache, and plugin-manager APIs
PLUGIN_ERROR_HANDLING.md — error-handling patterns
DEV_PREVIEW.md — preview plugins on your dev machine without a Pi
EMULATOR_SETUP_GUIDE.md — running the matrix emulator

Going deeper:

ADVANCED_PLUGIN_DEVELOPMENT.md — advanced patterns
PLUGIN_ARCHITECTURE_SPEC.md — full plugin-system spec
PLUGIN_DEPENDENCY_GUIDE.md / PLUGIN_DEPENDENCY_TROUBLESHOOTING.md
PLUGIN_WEB_UI_ACTIONS.md (+ example JSON)
PLUGIN_CUSTOM_ICONS.md / PLUGIN_CUSTOM_ICONS_FEATURE.md
PLUGIN_REGISTRY_SETUP_GUIDE.md (+ registry template)
STARLARK_APPS_GUIDE.md — Starlark-based mini-apps
widget-guide.md — widget development

Configuring plugins

PLUGIN_CONFIG_QUICK_START.md — minimal config you need
PLUGIN_CONFIGURATION_GUIDE.md — schema design
PLUGIN_CONFIGURATION_TABS.md — multi-tab UI configs
PLUGIN_CONFIG_ARCHITECTURE.md — how the config system works
PLUGIN_CONFIG_CORE_PROPERTIES.md — properties every plugin honors

Advanced features

ADVANCED_FEATURES.md — Vegas scroll, on-demand display, cache management, background services, permissions
FONT_MANAGER.md — font system

Reference

REST_API_REFERENCE.md — all web-interface HTTP endpoints
PLUGIN_API_REFERENCE.md — Python APIs available to plugins
DEVELOPER_QUICK_REFERENCE.md — common dev tasks
PLUGIN_IMPLEMENTATION_SUMMARY.md — what the plugin system actually does

Contributing to LEDMatrix itself

DEVELOPMENT.md — environment setup
HOW_TO_RUN_TESTS.md — running the test suite
MULTI_ROOT_WORKSPACE_SETUP.md — multi-repo workspace
MIGRATION_GUIDE.md — breaking changes between releases

Contributing to the docs

Markdown only, professional tone, minimal emoji.
Prefer adding to an existing page over creating a new one. If you add a new page, link it from this index in the section it belongs to.
If a page becomes obsolete, move it to docs/archive/ rather than deleting it, so links don't rot.
Keep examples runnable — paths, commands, and config keys here should match what's actually in the repo.