mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 14:25:08 +00:00
ChuckandClaude Opus 5.5
7ab6fb1aff
The web process built its own PluginManager and loaded plugins into itself: store installs and updates loaded or reloaded a web-side copy, and config saves and enable/disable called on_config_change, on_enable and on_disable on it. None of that reached the panel, and /plugins/installed reported runtime state from those copies. - Add PluginCatalog (src/plugin_system/plugin_catalog.py): manifests, directories, display modes, installed version, schema and config reads, with no way to run a plugin. app.py and both blueprints use it; the plugin_manager blueprint attribute is gone. - Remove every lifecycle call from the web routes. Config changes already reach the display through ConfigService (on_config_change) and the enabled-set reconcile. - Health and metrics readers move to api_v3.health_tracker / resource_monitor. /plugins/installed reports loaded/state/error_info as null (the display does not publish them) and enabled by the display's rule. - Store install, update and uninstall answer restart_required when the running display will not pick the change up by itself (display_restart_required). The restart banner follows the flag via window.noteRestartRequired instead of the /config/main URL heuristic; /config/main now sends restart_required: true. - The one remaining in-process import of plugin code (Starlark helper modules, oauth_flow action scripts) goes through _import_plugin_code_in_web_process() until a web-entry contract. - /plugins/installed reports vegas_participation (from #682) from the user's setting or the manifest, with vegas_participation_source; when only the plugin's code decides it, null with source 'runtime', since the web process no longer has plugin instances to ask. - Check & Update All keeps its restart flags when the final list refresh fails, and asks for a restart when an enabled plugin's first request got no answer and the re-sent one found it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
68 lines
2.4 KiB
Python
68 lines
2.4 KiB
Python
"""GET /plugins/health/<id> and /plugins/metrics/<id> read the display
|
|
service's latest state, not the web process's first snapshot.
|
|
|
|
The display service writes health and metrics to the shared cache; the web
|
|
process only reads them. Its tracker and monitor keep what they read first in
|
|
memory, so without ``force_reload`` the per-plugin routes kept answering with
|
|
that first read while the list routes (which pass it) moved on.
|
|
"""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent.parent))
|
|
|
|
from src.plugin_system.plugin_health import PluginHealthTracker # noqa: E402
|
|
from src.plugin_system.resource_monitor import PluginResourceMonitor # noqa: E402
|
|
from test._api_v3_test_helpers import api_v3_client, api_v3_module # noqa: F401,E402
|
|
|
|
|
|
class SharedCache:
|
|
"""The on-disk cache both processes see, reduced to a dict."""
|
|
|
|
def __init__(self):
|
|
self.entries = {}
|
|
|
|
def get(self, key, max_age=None, memory_ttl=None):
|
|
return self.entries.get(key)
|
|
|
|
def set(self, key, value, *args, **kwargs):
|
|
self.entries[key] = value
|
|
|
|
|
|
@pytest.fixture
|
|
def shared_cache(api_v3_module):
|
|
cache = SharedCache()
|
|
api_v3_module.api_v3.health_tracker = PluginHealthTracker(cache)
|
|
api_v3_module.api_v3.resource_monitor = PluginResourceMonitor(cache)
|
|
return cache
|
|
|
|
|
|
def test_health_reflects_failures_recorded_after_the_first_read(api_v3_client, shared_cache):
|
|
first = api_v3_client.get("/api/v3/plugins/health/weather").get_json()["data"]
|
|
assert first["total_failures"] == 0
|
|
|
|
display_side = PluginHealthTracker(shared_cache)
|
|
display_side.record_failure("weather", RuntimeError("api down"))
|
|
display_side.record_failure("weather", RuntimeError("api down"))
|
|
|
|
later = api_v3_client.get("/api/v3/plugins/health/weather").get_json()["data"]
|
|
assert later["total_failures"] == 2
|
|
|
|
|
|
def test_metrics_reflect_calls_recorded_after_the_first_read(api_v3_client, shared_cache):
|
|
first = api_v3_client.get("/api/v3/plugins/metrics/weather").get_json()["data"]
|
|
assert first["call_count"] == 0
|
|
|
|
shared_cache.set("plugin_metrics:weather", {
|
|
"memory_mb": 12.5, "cpu_percent": 3.0, "execution_time": 0.2,
|
|
"call_count": 40, "total_execution_time": 8.0,
|
|
"max_execution_time": 0.5, "min_execution_time": 0.1,
|
|
"last_update_time": 1000.0,
|
|
})
|
|
|
|
later = api_v3_client.get("/api/v3/plugins/metrics/weather").get_json()["data"]
|
|
assert later["call_count"] == 40
|