Files
LEDMatrix/test/test_vegas_prepared_blocks.py
ChuckandClaude Opus 5.5 795834811f perf(scroll): extend and trim the Vegas strip in place (#701)
* perf(timing): say which render-thread work a late frame followed

The soak already says how often a moving frame reached the panel late, but
not what the render thread was doing just before it. Vegas does two kinds of
work there between frames -- building its strip (compose, extend) and, with
live elements, patching changed pixels into it -- and deciding whether either
is affordable needs their own numbers.

- FrameTimingRecorder.note_op(kind, nbytes) tags the next presented frame.
  Totals gain op_frames, late_op_frames, op_freezes and op_bytes per kind;
  aggregate() still takes frames without ops. The file schema is unchanged.
- Vegas tags compose and every strip extension (with the bytes it copied).
- frame_soak prints an "after work" table: frames, late %, freezes and MB
  moved per kind, only when something tagged its work.
- render_bench gains --strip-screens (Vegas-sized strips), --patch-bytes /
  --patch-every / --patch-where (in-place column writes, as a live element
  update does) and --extend-every-screens / --extend-width (append + trim on
  a fixed cadence that holds the strip's width).

No runtime behaviour changes: this is the measurement gate for live Vegas
elements.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changelog): note the frame-op attribution and bench modes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* perf(scroll): build the strip's PIL image only when something reads it

Every Vegas strip extension rebuilt ScrollHelper.cached_image from
cached_array in full, twice (append, then trim), on the render thread:
Image.fromarray is 1.7ms for an 8,000px strip and 3.8ms for 20,000px on a
Pi 4 (measured on ledpi), about two thirds of an extension's render-thread
cost. Nothing on the frame path reads the image's pixels; every frame is cut
from the array.

cached_image is now a property. append_content and drop_scrolled_prefix
defer it; the first read builds it from the array it started with and keeps
it only if the strip has not changed meanwhile, so a sync push racing an
extension cannot leave a stale image cached. Assigning cached_image stores
exactly what was assigned, as before. has_strip() says whether there is a
strip without building its image; the helper's frame path, Vegas and the
adapter's scroll-cache invalidation use it. The strip is also no longer held
in memory twice.

In Vegas the image is now built only by a multi-display sync push.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(vegas): live elements -- a plugin API for content that changes while it scrolls

Vegas bakes each plugin's pictures into one strip, so a card already on its
way across the panel keeps what it showed when it was drawn. This adds the
API and bookkeeping for content that can be updated in place; the worker
that redraws and swaps it follows separately. No shipped plugin implements
the hook yet, so nothing changes for users.

Plugin API (core 3.8.0), all no-ops by default:
- BasePlugin.get_vegas_elements() -> [VegasElement(key, image, version,
  live, refresh_hz)]: named, fixed-width pieces of Vegas content.
- BasePlugin.redraw_vegas_element(key, width, height, at): a lock-free
  redraw for content that changes with time.
- BasePlugin.notify_vegas_data_changed(): data that lands outside update().
- src/plugin_system/vegas_elements.py (VegasElement, re-exported from
  base_plugin).

Core:
- PluginAdapter asks a plugin that implements the hook for elements on the
  background fetch only (under its lock, on its own canvas); every other
  path keeps get_vegas_content(). Live elements are pinned (padded with
  content_padding, never trimmed), tagged with their key, digest and data
  epoch in Image.info so the existing cache and group plumbing carry them
  unchanged, and untagged if a width budget crops them.
- RenderPipeline records where each live element lands (ElementRecord), in
  absolute strip columns a trim does not move; the block-start arithmetic
  is shared with the STATIC markers.
- PluginManager update listeners (add/remove_update_listener,
  notify_data_changed): told the moment update() completes, not at the
  next ~4s Vegas poll. The coordinator uses one to move each plugin's data
  epoch on.
- vegas_scroll.live_refresh (kill switch), live_max_hz, live_min_interval,
  live_lead_screens; per-plugin core-owned vegas_live. Live elements are
  off under multi-display sync, in swap mode and with offscreen_prefetch off.
- scripts/check_plugin.py checks the element contract
  (src/plugin_system/testing/vegas.py); test/fixtures/plugins/vegas-live-stub
  is a working example.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(vegas): live elements update in place while they scroll

One background worker (src/vegas_mode/live_worker.py) redraws a plugin's
live elements when its data epoch moves on (update listener) or on their
refresh_hz, nearest the screen first, and hands changed pixels lock-free to
the render thread, which copies them into the strip between frames
(RenderPipeline.apply_live_patches, ScrollHelper.patch_columns): at most
four patches or two screens of bytes a frame, no drawing or locks there.
The worker takes over group prefetch once a live element is placed, runs
inside the render gate, and is supervised. Update tick 1s while live
elements exist. Web UI switch for live_refresh. OFFSCREEN_RENDERING.md
describes what was built and why SegmentStrip was not needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(sports): live Vegas cards for the scoreboards (shared layer)

One live element per game, drawn only when what the card shows changes, so
a score changes on a card already crossing the panel. The shared part, so
each scoreboard adopts it in a few lines:

- src/common/sports_vegas.py: game_key, game_fingerprint (the whole game
  dict, frozen: no drawn field can be missed), dedupe_games, VegasCardCache,
  StickyOdds (odds a live poll left out stay drawn), finished_games /
  with_finished_games (a game that just went final keeps its card, after its
  league's live games; one a heuristic only judged over keeps its live
  state, so a tied end of regulation never shows FINAL early).
- SportsScrollDisplay.make_vegas_renderer() is the override point;
  build_vegas_elements() and SportsScrollDisplayManager
  .get_vegas_elements_for() do the rest. A card's version includes its
  teams' ranks, which the renderer draws from the rankings cache.
- SportsLiveSharedMixin._record_finished_game() / finished_games_snapshot():
  held for FINISHED_GAME_TTL after it leaves the live list.

A sport that does not implement make_vegas_renderer keeps its ordinary Vegas
content, so no scoreboard changes until it opts in.

scripts/render_plugin.py --vegas renders a plugin's Vegas block as the
ticker lays it out, and --timeline stacks it at successive moments as
the ticker would update it in place; the join is now
render_pipeline.join_plugin_rows().

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(vegas): keep live games in the ticker by default

display.vegas_scroll.live_in_ticker now defaults to true: through a live
game the marquee keeps running and the live scoreboard takes extra turns in
it -- its cards updating in place while they scroll -- instead of the ticker
giving way to the full-screen scoreboard.

The new default would reach nobody on its own: every existing config holds
an explicit false copied from the template (there was no control for it),
and the template merge only adds missing keys. ConfigManager therefore turns
a stored false on once, with a backup, and records live_in_ticker_migrated
so a false chosen afterwards stays. The marker is never in the template.

A "Keep live games in the ticker" checkbox under Vegas mode sets it. Tests
that pin the full-screen takeover now say live_in_ticker=false.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(dev): preview a plugin's Vegas strip in the dev server

The dev server's View selector gains "Vegas strip (live elements)" and
"Vegas strip (plain Vegas content)": the plugin's block of the Vegas ticker,
laid out by the ticker's own code (render_vegas_strip, as render_plugin.py
--vegas uses), with its live elements listed. /api/render takes
"vegas": "live" | "plain"; the display view is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* perf(scroll): extend and trim the Vegas strip in place

Every strip extension rebuilt the whole strip (np.concatenate: 2-2.6 ms for
a 10-14k px strip at 512x64 on a Pi 4) and every trim copied what was left
(1.2-1.8 ms), on the render thread. With ~4 ms of slack per refresh, every
extension frame on hdpi missed its refresh (5/5 in each soak run).

The strip now lives in a buffer with spare room; cached_array is a view of
its live columns. An append writes only the new columns (~0.2 ms), a trim
only moves the view's start, and the one full copy happens when the buffer
is reallocated (STRIP_SPARE_FACTOR 3: about once every two strip-lengths
scrolled). A cached_array set from outside -- the multi-display follower's
read-only one, create_scrolling_image's -- is never written through, and a
new strip lets the old buffer go. last_copy_bytes says what was copied, and
the Vegas frame-timing attribution reports that instead of the whole strip.

test_scroll_helper_in_place.py: the buffer is reused and only new columns
copied, trims copy nothing, reallocation when the room runs out, outside
arrays untouched, and random appends/trims/patches/scrolling checked frame
by frame against the old copying strip (mutation-checked).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(sports): a default _determine_game_type on SportsScrollDisplay

render_vegas_card looked the method up with getattr and a None default, which
static analysis (Codacy) reports as calling something that may not be
callable. The base class now has the default -- the card type from the game's
state -- and the plugins that define their own override it as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(scroll): no assert in _extended_strip

An assert vanishes under python -O (Codacy); a real check says the same.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: review follow-ups on the shared live-card layer

- The reused Vegas renderer always gets the current rankings, empty
  included, so ranks cleared since are not kept drawn.
- render_plugin.py: --timeline refuses --no-live (a timeline shows live
  elements changing), --timeline/--no-live need --vegas, and the Vegas
  paths create the output's directory like the display path does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* perf(vegas): lay a group's blocks out before the extension, off the render thread

#701 cut the strip copy, but the frame after an extension was still late:
the render thread also joined each plugin's rows (separation_gap measures
every pair) and pasted the blocks into an addition image, ~37 ms on hdpi
(Pi 4, 512x64) against ~3.75 ms of slack.

The thread that fetched the group now does that as each member arrives:
RenderPipeline.prepare_group_member joins the rows and turns the block into
pixels (the prefetch thread and the live worker, under the render gate).
extend_scroll_content takes those blocks, and ScrollHelper.append_content
writes items -- images or RGB arrays -- straight into the strip's spare room,
blanking only the gaps. A member that was not prepared (an inline fetch) is
joined at the extension as before; the strip is identical either way.

On hdpi the extension's render-thread work goes from 37.5 ms to 3.2 ms p50
in place (6.9 ms when the buffer is reallocated). The helper's per-append
INFO line, a duplicate of the pipeline's, is now DEBUG.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-01 09:48:47 -04:00

250 lines
9.6 KiB
Python

"""A group's blocks are laid out by the thread that fetched it, not at the extension.
Joining a plugin's rows (measuring the separation between them) and turning
the block into pixels cost the frame after every extension ~35 ms on a Pi 4,
against ~3.75 ms of slack. The prefetch thread and the live-element worker now
do it as each member arrives (RenderPipeline.prepare_group_member), and the
extension only writes those pixels into the strip (ScrollHelper.append_content
takes arrays). The strip a viewer sees must be exactly what it was.
"""
import random
import sys
from pathlib import Path
import numpy as np
import pytest
from PIL import Image, ImageDraw
sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
from src.common.scroll_helper import ScrollHelper # noqa: E402
from src.vegas_mode import elements # noqa: E402
from src.vegas_mode import render_pipeline # noqa: E402
from src.vegas_mode.config import VegasModeConfig # noqa: E402
from src.vegas_mode.elements import ElementMeta # noqa: E402
from src.vegas_mode.render_pipeline import RenderPipeline # noqa: E402
W, H = 96, 24
def _row(width, seed, live_key=None):
rng = np.random.default_rng(seed)
pixels = np.zeros((H, width, 3), dtype=np.uint8)
# Margins of different sizes, so the measured separation matters.
left, right = seed % 5, width - 1 - (seed % 7)
pixels[2:H - 2, left:right] = rng.integers(20, 255, (H - 4, right - left, 3), dtype=np.uint8)
image = Image.frombytes("RGB", (width, H), pixels.tobytes())
if live_key is None:
return image
pinned, array = elements.pin_element(image, 8)
return elements.tag(pinned, ElementMeta("p", live_key, 0, elements.pixel_digest(array), 0.0, 0.0))
def _groups(seed, n=8):
rng = random.Random(seed)
groups = []
for g in range(n):
group = []
for p in range(rng.randint(1, 3)):
rows = [_row(rng.randint(12, 60), rng.randint(0, 10**6),
f"g{g}p{p}r{r}" if rng.random() < 0.5 else None)
for r in range(rng.randint(1, 4))]
group.append((f"pl{g}{p}", rows))
groups.append(group)
return groups
class _Stream:
def __init__(self, groups, statics=()):
self.groups = groups
self.statics = set(statics)
self.plugin_manager = type("PM", (), {"plugins": {}})()
self.plugin_adapter = None
self.i = 0
def get_grouped_content_for_composition(self):
return self.groups[0]
def get_active_plugin_ids(self):
return []
def take_next_group(self, count=None, offscreen_only=False):
self.i += 1
return self.groups[self.i] if self.i < len(self.groups) else []
def is_static_plugin(self, plugin_id):
return plugin_id in self.statics
class _DM:
width, height = W, H
def __init__(self):
self.image = Image.new("RGB", (W, H))
def set_scrolling_state(self, *a):
pass
def update_display(self):
pass
def _pipeline(groups, prepared, statics=()):
p = RenderPipeline(VegasModeConfig(continuous_scroll=True, lead_in_width=0,
separator_width=12), _DM(), _Stream(groups, statics))
if prepared:
# The prefetch thread, run to completion before each extension.
def prefetch_now():
p._prepared_group = p.stream_manager.take_next_group(offscreen_only=True)
for member in p._prepared_group:
p.prepare_group_member(member)
p.start_prefetch = prefetch_now
else:
p.start_prefetch = lambda: None # every extension fetches inline
assert p.compose_scroll_content()
return p
def _run(p, steps=6):
for _ in range(steps):
p.scroll_helper.scroll_position = max(
p.scroll_helper.scroll_position, p.scroll_helper.total_scroll_width - 2 * W)
if not p.extend_scroll_content():
break
return p
@pytest.mark.parametrize("seed", range(6))
def test_the_strip_is_the_same_prepared_ahead_or_joined_at_the_extension(seed):
inline = _run(_pipeline(_groups(seed), prepared=False))
ahead = _run(_pipeline(_groups(seed), prepared=True))
assert np.array_equal(ahead.scroll_helper.cached_array, inline.scroll_helper.cached_array)
assert ahead._strip_origin == inline._strip_origin
assert [(r.key, r.abs_x, r.width) for r in ahead.live_records()] == \
[(r.key, r.abs_x, r.width) for r in inline.live_records()]
assert ahead.live_records()
def test_a_prepared_extension_joins_nothing_on_the_render_thread(monkeypatch):
p = _pipeline(_groups(1), prepared=True)
p.start_prefetch() # the group, prepared ahead
p.start_prefetch = lambda: None # and not the one after it
def joined_here(*_a, **_k):
raise AssertionError("the extension laid a block out itself")
monkeypatch.setattr(render_pipeline, "join_plugin_rows", joined_here)
monkeypatch.setattr(render_pipeline, "separation_gap", joined_here)
monkeypatch.setattr(Image.Image, "paste", joined_here)
assert p.extend_scroll_content()
assert not p._prepared_blocks # each block used once, then let go
def test_a_static_plugins_block_is_let_go_unused():
groups = _groups(2)
static = groups[1][0][0]
p = _pipeline(groups, prepared=True, statics=[static])
p.start_prefetch()
p.start_prefetch = lambda: None
assert p.extend_scroll_content()
assert not p._prepared_blocks
assert any(pid == static for _x, pid in p._static_markers)
def test_blocks_prepared_for_other_images_are_not_used():
groups = _groups(3)
p = _pipeline(groups, prepared=False)
images = groups[1][0][1]
p.prepare_group_member(("x", list(images))) # equal, not the same list
assert p._take_prepared_block(images) is None
# Filed under these images' id() -- as when a list dies and its id is
# reused -- but made from others.
p._prepared_blocks[id(images)] = render_pipeline.PreparedBlock(
[_row(20, 99)], p.config)
assert p._take_prepared_block(images) is None
def test_a_reset_drops_prepared_blocks():
p = _pipeline(_groups(4), prepared=True)
p.start_prefetch()
assert p._prepared_blocks
p.reset()
assert not p._prepared_blocks
def test_preparing_never_raises(caplog):
p = _pipeline(_groups(5), prepared=False)
p.prepare_group_member(("broken", [object()]))
p.prepare_group_member(("empty", []))
p.prepare_group_member(("deferred", None))
assert not p._prepared_blocks
def test_the_waiting_blocks_are_bounded():
p = _pipeline(_groups(6), prepared=False)
for n in range(RenderPipeline.PREPARED_BLOCKS_MAX * 2):
p.prepare_group_member((f"p{n}", [_row(20, n)]))
assert len(p._prepared_blocks) <= RenderPipeline.PREPARED_BLOCKS_MAX
# -- ScrollHelper.append_content with arrays ----------------------------------------
def _strip():
helper = ScrollHelper(W, H)
helper.create_scrolling_image([_row(40, k) for k in range(4)], item_gap=3, lead_gap=0)
return helper
@pytest.mark.parametrize("in_place", [False, True])
def test_appending_pixels_draws_exactly_what_appending_images_does(in_place):
items = [_row(30, 7),
_row(25, 8).convert("RGBA"), # converted, as paste does
Image.new("RGB", (20, H - 6), (200, 40, 40)), # short: black beneath
Image.new("RGB", (15, H + 6), (40, 200, 40))] # tall: cut at the strip
as_images, as_pixels = _strip(), _strip()
if in_place:
for helper in (as_images, as_pixels):
helper.append_content([_row(10, 1)], item_gap=2) # a buffer with room
as_images.append_content(items, item_gap=5, element_gap=2)
as_pixels.append_content([np.asarray(i.convert("RGB")) for i in items],
item_gap=5, element_gap=2)
assert np.array_equal(as_images.cached_array, as_pixels.cached_array)
assert as_images.total_scroll_width == as_pixels.total_scroll_width
def test_reference_paste_layout_is_unchanged():
"""Gaps black, short items padded below, tall ones cut: what paste did."""
items = [Image.new("RGB", (20, H - 6), (200, 40, 40)),
Image.new("RGBA", (15, H + 6), (40, 200, 40, 9))]
helper = _strip()
before = helper.cached_array.copy()
helper.append_content(items, item_gap=5, element_gap=2)
addition = Image.new("RGB", (5 + 20 + 2 + 5 + 15 + 2, H))
addition.paste(items[0], (5, 0))
addition.paste(items[1], (5 + 20 + 2 + 5, 0))
expected = np.concatenate((before, np.asarray(addition)), axis=1)
assert np.array_equal(helper.cached_array, expected)
def test_a_first_build_from_pixels_matches_one_from_images():
items = [_row(30, 3), _row(40, 4)]
a, b = ScrollHelper(W, H), ScrollHelper(W, H)
a.append_content(items, item_gap=4)
b.append_content([np.asarray(i) for i in items], item_gap=4)
assert np.array_equal(a.cached_array, b.cached_array)
def test_gaps_and_short_rows_are_black_whatever_the_spare_room_held():
"""Only uncovered columns are blanked, so they must all be."""
items = [Image.new("RGB", (20, H - 6), (200, 40, 40)), _row(30, 5)]
clean, dirty = _strip(), _strip()
for helper in (clean, dirty):
helper.append_content([_row(10, 1)], item_gap=2) # a buffer with room
end = dirty._strip_start + dirty.cached_array.shape[1]
dirty._strip_buffer[:, end:] = 255 # what an old strip left
for helper in (clean, dirty):
helper.append_content([np.asarray(i) for i in items], item_gap=5, element_gap=3)
assert np.array_equal(dirty.cached_array, clean.cached_array)
assert not dirty.cached_array[:, -3:].any() # the trailing element gap