mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 14:25:08 +00:00
ChuckandClaude Opus 5.5
7ab6fb1aff
The web process built its own PluginManager and loaded plugins into itself: store installs and updates loaded or reloaded a web-side copy, and config saves and enable/disable called on_config_change, on_enable and on_disable on it. None of that reached the panel, and /plugins/installed reported runtime state from those copies. - Add PluginCatalog (src/plugin_system/plugin_catalog.py): manifests, directories, display modes, installed version, schema and config reads, with no way to run a plugin. app.py and both blueprints use it; the plugin_manager blueprint attribute is gone. - Remove every lifecycle call from the web routes. Config changes already reach the display through ConfigService (on_config_change) and the enabled-set reconcile. - Health and metrics readers move to api_v3.health_tracker / resource_monitor. /plugins/installed reports loaded/state/error_info as null (the display does not publish them) and enabled by the display's rule. - Store install, update and uninstall answer restart_required when the running display will not pick the change up by itself (display_restart_required). The restart banner follows the flag via window.noteRestartRequired instead of the /config/main URL heuristic; /config/main now sends restart_required: true. - The one remaining in-process import of plugin code (Starlark helper modules, oauth_flow action scripts) goes through _import_plugin_code_in_web_process() until a web-entry contract. - /plugins/installed reports vegas_participation (from #682) from the user's setting or the manifest, with vegas_participation_source; when only the plugin's code decides it, null with source 'runtime', since the web process no longer has plugin instances to ask. - Check & Update All keeps its restart flags when the final list refresh fails, and asks for a restart when an enabled plugin's first request got no answer and the re-sent one found it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
46 lines
1.6 KiB
Python
46 lines
1.6 KiB
Python
"""GET /api/v3/plugins/installed carries the manifest's `icon`.
|
|
|
|
The tab nav sets ``iconEl.className = plugin.icon || 'fas fa-puzzle-piece'``
|
|
(app-shell.js, app-early.js), but the route never included `icon`, so every
|
|
plugin tab showed the default puzzle piece.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
from test._api_v3_test_helpers import ( # noqa: F401 - fixtures
|
|
api_v3_client, api_v3_module,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def installed(api_v3_module, api_v3_client, tmp_path):
|
|
def _get(manifest_extra):
|
|
api = api_v3_module.api_v3
|
|
info = {'id': 'demo', 'name': 'Demo', 'version': '1.0.0', 'loaded': False}
|
|
info.update(manifest_extra)
|
|
api.plugin_catalog.plugins_dir = str(tmp_path) # no manifest on disk
|
|
api.plugin_catalog.get_all_plugin_info = MagicMock(return_value=[info])
|
|
api.plugin_store_manager.get_registry_info = MagicMock(return_value=None)
|
|
api.config_manager.load_config = MagicMock(return_value={})
|
|
response = api_v3_client.get('/api/v3/plugins/installed')
|
|
assert response.status_code == 200
|
|
plugins = [p for p in response.get_json()['data']['plugins'] if p['id'] == 'demo']
|
|
assert len(plugins) == 1
|
|
return plugins[0]
|
|
return _get
|
|
|
|
|
|
def test_the_manifest_icon_is_passed_through(installed):
|
|
assert installed({'icon': 'fas fa-cloud-sun'})['icon'] == 'fas fa-cloud-sun'
|
|
|
|
|
|
def test_no_icon_comes_back_as_null(installed):
|
|
# The JS falls back to the puzzle piece on a falsy value.
|
|
assert installed({})['icon'] is None
|
|
|
|
|
|
def test_a_non_string_icon_is_not_passed_through(installed):
|
|
assert installed({'icon': {'class': 'fas fa-star'}})['icon'] is None
|