mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 06:15:09 +00:00
ChuckandClaude Opus 5.5
c00bf5e8e6
* fix(plugin-system): unload/update race, failed-load module cleanup, limits validation, schema lookup, install rollback, op-queue dedupe - unload_plugin takes the per-plugin lock (5s bounded) before cleanup(), and an update() that finishes after its plugin was unloaded no longer sets the state back to ENABLED. - A load that fails after import drops plugin_<id> and its submodules and forgets its manager fonts, so a fixed plugin reloads new code. - Resource limits are validated as non-negative numbers: 400 at POST /plugins/limits, bad cached records ignored with one warning. Route docstrings note health/metrics reset and limits only change the web process's view. - SchemaManager.get_schema_path resolves each search dir via resolve_plugin_dir (manifest id, ledmatrix-<id>) before the literal paths; plugins/ still before plugin-repos/. Misses cached 30s and logged once at DEBUG. - install_from_url sets an existing copy aside and restores it if the move fails, under the per-plugin reinstall lock. - Operation queue refuses a second pending op for a plugin and trims _operations with history. - get_vegas_render_width reads display_manager.width first. - get_logger in store/schema/health/resource/saved_repositories; UTF-8 reads in store_manager and state_manager. - Docs: update_interval precedence (manifest over config) stated where users are told to set it in config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(web): build the limits 400 message from the field name, not an exception CodeQL flagged str(e) flowing into the response. invalid_limit_field() returns the offending field without raising, and limits_from_dict uses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
63 lines
2.4 KiB
Python
63 lines
2.4 KiB
Python
"""Plugin-system JSON files are read as UTF-8, whatever the locale says.
|
|
|
|
store_manager (install_from_url's manifest, the secrets file) and
|
|
state_manager (plugin_state.json) opened text files without an encoding, so
|
|
the platform default applied. A manifest written in UTF-8 with a non-ASCII
|
|
name then read as mojibake -- or raised UnicodeDecodeError -- on a host
|
|
whose locale encoding is not UTF-8 (Windows' cp1252; a Pi with LANG=C).
|
|
On a UTF-8 host these pass either way; they fail on old code where the
|
|
default encoding differs.
|
|
"""
|
|
|
|
import json
|
|
|
|
import pytest
|
|
|
|
from src.plugin_system.state_manager import PluginStateManager
|
|
from src.plugin_system.store_manager import PluginStoreManager
|
|
|
|
NAME = "Météo Á" # "Á" is C3 81 in UTF-8; 0x81 is undefined in cp1252
|
|
|
|
|
|
@pytest.fixture
|
|
def store(tmp_path, monkeypatch):
|
|
mgr = PluginStoreManager(
|
|
plugins_dir=str(tmp_path / "plugins"),
|
|
uninstalled_registry_path=str(tmp_path / "uninstalled.json"))
|
|
mgr.plugins_dir.mkdir(parents=True, exist_ok=True)
|
|
monkeypatch.setattr(mgr, "_install_dependencies", lambda *a, **k: True)
|
|
|
|
def fake_clone(repo_url, target, branches):
|
|
target = type(mgr.plugins_dir)(target)
|
|
target.mkdir(parents=True, exist_ok=True)
|
|
manifest = {"id": "meteo", "name": NAME, "class_name": "P",
|
|
"display_modes": ["meteo"], "version": "1.0.0"}
|
|
(target / "manifest.json").write_bytes(
|
|
json.dumps(manifest, ensure_ascii=False).encode("utf-8"))
|
|
(target / "manager.py").write_text("class P: pass\n")
|
|
return "main"
|
|
|
|
monkeypatch.setattr(mgr, "_install_via_git", fake_clone)
|
|
return mgr
|
|
|
|
|
|
def test_install_from_url_reads_a_utf8_manifest(store):
|
|
result = store.install_from_url("https://github.com/x/y")
|
|
assert result["success"] is True
|
|
assert result["name"] == NAME
|
|
written = json.loads(
|
|
(store.plugins_dir / "meteo" / "manifest.json").read_bytes().decode("utf-8"))
|
|
assert written["name"] == NAME
|
|
|
|
|
|
def test_state_manager_loads_a_utf8_state_file(tmp_path):
|
|
state_file = tmp_path / "plugin_state.json"
|
|
state_file.write_bytes(json.dumps({
|
|
"version": 1,
|
|
"states": {"meteo": {"plugin_id": "meteo", "status": "installed",
|
|
"enabled": True, "metadata": {"label": NAME}}},
|
|
}, ensure_ascii=False).encode("utf-8"))
|
|
|
|
mgr = PluginStateManager(state_file=str(state_file))
|
|
assert mgr.get_plugin_state("meteo").metadata["label"] == NAME
|