New unit tests for pure or filesystem-only logic that previously had zero
direct coverage:
- test_compatibility.py: the semver install gate (parse_semver suffix
handling, every range operator, TRUSTWORTHY_FLOOR behavior for cores
reporting untrustworthy versions, 'more restrictive wins', and the
malformed-manifest shapes that used to raise).
- test/web_interface/test_secret_helpers.py: the canonical x-secret
helpers — find/separate/mask/remove, array-item secrets, no input
mutation, and a separate->recombine round-trip.
- test/web_interface/test_api_v3_helpers.py: the module-level helpers
behind the plugin config save endpoint (_is_plugin_update_available,
_coerce_to_bool including the int==1 quirk, deep_merge including its
shared-subtree shallowness, _parse_form_value, dotted-key-aware
_get_schema_property/_set_nested_value).
- test_base_plugin_duration.py: get_display_duration's full coercion
ladder (instance attr -> config -> 15.0), including the bool-is-int
quirk where display_duration=True means one second.
- test_config_manager_secrets.py: the secrets round-trip — deep-merge on
load, strip on save, group pruning, the load fast path — and two
characterized sharp edges marked SUSPECTED BUG: an unreadable secrets
file at save time writes secrets into config.json in plaintext, and a
same-mtime-same-size content swap is served stale.
- test_schema_manager_merge.py: merge_with_defaults branch behavior (None
replacement vs falsey preservation, dict-vs-scalar mismatches, arrays
replaced wholesale, defaults never mutated).
- test_skin_system.py (extended): render_skin_card shares _render_game's
3-strike counter but never resets it on success — the asymmetry is
pinned in both directions, along with card fallthrough and the disable
interaction between the two paths.
Suspected bugs are characterized, not fixed — each carries a comment so a
future behavior change is deliberate rather than accidental.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NohXi78cwsAKtN1sCfxjUh
* Add skin system: user-installable visual overlays for sports scoreboards
Skins restyle a scoreboard's live/recent/upcoming rendering while the
host plugin keeps doing data fetching, scheduling, caching, live
priority, and vegas mode — the anti-fork alternative for users who only
want a different layout.
- src/skin_system/: ScoreboardSkin API, SkinContext (canvas + adaptive
layout + logo/font helpers), discovery/loading runtime with API major
version gating and per-skin module namespacing
- src/base_classes/sports.py: _render_game() seam at the three
_draw_scorebug_layout call sites; skin-first with built-in fallback,
3-strikes session disable, slow-render warning; per-mode skin config
- scripts/validate_skin.py: headless multi-mode/multi-size validator
with bundled per-sport fixtures (no hardware or network needed)
- skins/example-classic-baseball/: working reference skin
- Web UI: served-schema Visual Skin dropdown (validation never
enum-restricted, so uninstalled skins can't invalidate configs) and
GET /api/v3/skins
- Store: registry entries with type "skin" install to skins/
- docs/SKIN_SYSTEM.md (architecture), docs/CREATING_SKINS.md (author
guide incl. Claude Code prompt), view-model contract locked by tests
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LrCusPasy1qeUN5anK3aA1
* Address review feedback on skin system
- skin_runtime: cache the entry module so the 2nd/3rd load of the same
skin (live/recent/upcoming hosts) doesn't re-execute it with unbound
sibling aliases; rebind cached sibling modules to their bare names
around entry import and restore prior bindings after; include per-
manifest mtimes in the discovery cache fingerprint so in-place skin
updates are picked up
- sports.py: count render_skin_card exceptions toward the 3-strike
session disable
- store_manager: validate skin ids (pattern + resolved-path containment
in skins/), reject registry/manifest id mismatches, and stage+validate
downloads in a temp sibling before replacing an existing skin
- schema_manager: leave the schema untouched when the configured skin
value is a per-mode mapping (a string dropdown could overwrite it)
- validate_skin.py: reject non-positive sizes and non-object --options
at parse time; support --output-dir outside the repo; type annotations
- example skin: validate accent_color once at load with logged fallback
- fixtures: pregame 0-0 scores in football/hockey upcoming fixtures
- api /skins: rely on the self-invalidating discovery cache instead of
force_refresh
- docs: valid JSON manifest example, load_logo caching semantics spelled
out, language ids on fenced blocks
- tests: view-model contract test now exercises the real extractor;
regression test for repeated same-skin loads with sibling modules
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LrCusPasy1qeUN5anK3aA1
---------
Co-authored-by: Claude <noreply@anthropic.com>
Claude