* rebase
* Update NFL and NCAA FB fetch
* update FB updates
* kinda working, kinda broken
* Fixed and update loggers
* move to individual files
* timeout updates
* seems to work well
* Leaderboard overestimates time
* ignore that
* minor syntax updates
* More consolidation but i broke something
* fixed
* Hockey seems to work
* Fix my changes to logo downloader
* even more consolidation
* fixes
* more cleanup
* inheritance stuff
* Change football to ESPN down text, it does what ur already doing. Change color to red on Red ZOne
* Fix leaderboard
* Update football.py
Signed-off-by: Alex Resnick <adr8292@gmail.com>
* Minor fixes
* don't want that
* background fetch
* whoops
---------
Signed-off-by: Alex Resnick <adr8292@gmail.com>
Co-authored-by: Alex Resnick <adr8282@gmail.com>
Co-authored-by: ChuckBuilds <33324927+ChuckBuilds@users.noreply.github.com>
* Fix leaderboard timing issues with comprehensive improvements
- Add maximum display time cap (120s) to prevent hanging
- Implement dynamic scroll speed tracking with runtime measurements
- Simplify complex timing logic that was causing hangs
- Add enhanced progress tracking and logging
- Add configurable safety buffer (10s)
- Update config template with new timing options
- Add comprehensive test suite for timing logic
Fixes the 30-second hanging issue reported in PR #53 by providing
multiple layers of protection against time overestimation.
* Simplify leaderboard timing to use long timeout with exception-based ending
- Remove complex dynamic duration calculations
- Remove safety buffer complexity
- Remove scroll speed tracking and measurements
- Use simple 10-minute timeout (600s) for both display_duration and max_display_time
- Let content determine when display is complete via existing StopIteration logic
- Update display controller to use simplified duration approach
- Clean up config template to remove unused timing settings
This approach is much more reliable than trying to predict content duration
and eliminates the hanging issues reported in PR #53.
* Fix configuration structure to use centralized display_durations
- Remove redundant display_duration from leaderboard section
- Use main display_durations.leaderboard (300s) for fixed duration mode
- Update leaderboard manager to read from centralized config
- Increase leaderboard default duration from 60s to 300s for better content coverage
- Maintain dynamic_duration option for user choice between fixed/dynamic modes
- Add comprehensive scroll behavior analysis and testing
This completes the leaderboard timing improvements with proper config structure.
* scroll every frame to be smoother like the stock ticker instead of waiting per subsecond
* leaderboard block api calls while scrolling
* leaderboard debugging
* added leaderboard fps logging
* leaderboard frame control and optimizations
* background update memory leak for scrolling text found and first solution applied
* tuning scroll speeds
* working display scrolls
* revert scroll delay to 0.01 (about 100fps)
* revert min duration of leaderboard
* remove onetime test scripts
* Fix NCAAFB ranking display issue
- Remove duplicate ranking system that was drawing rankings behind team logos
- Old system (_get_rank) was drawing rankings at top of logos
- New system (_fetch_team_rankings) correctly draws rankings in bottom corners
- Remove old ranking calls from live, recent, and upcoming game drawing functions
- Remove unnecessary _fetch_rankings() calls from update methods
- Rankings now only appear in designated corner positions, not overlapping logos
Fixes issue where team rankings/betting lines were being drawn behind
team logos instead of replacing team records in the corners.
* Add missing show_ranking and show_records options to NCAAFB web UI
- Add show_ranking option to NCAAFB scoreboard config template
- Add show_records and show_ranking toggle switches to NCAAFB web UI
- Update JavaScript form collection to include new fields
- Users can now control whether to show team records or rankings via web interface
This completes the fix for NCAAFB ranking display - users can now enable
show_ranking in the web UI to see AP Top 25 rankings instead of team records.
* Implement Background Threading for Season Data Fetching
Phase 1: Background Season Data Fetching - COMPLETED
Key Features:
- Created BackgroundDataService class with thread-safe operations
- Implemented automatic retry logic with exponential backoff
- Modified NFL manager to use background service
- Added immediate partial data return for non-blocking display
- Comprehensive logging and statistics tracking
Performance Benefits:
- Main display loop no longer blocked by API calls
- Season data always fresh with background updates
- Better user experience during data fetching
Files Added/Modified:
- src/background_data_service.py (NEW)
- src/nfl_managers.py (updated)
- config/config.template.json (updated)
- test_background_service.py (NEW)
- BACKGROUND_SERVICE_README.md (NEW)
* Fix data validation issues in background service
- Add comprehensive data structure validation in NFL managers
- Handle malformed events gracefully with proper error logging
- Validate cached data format and handle legacy formats
- Add data validation in background service response parsing
- Fix TypeError: string indices must be integers, not 'str'
This fixes the error where events were being treated as strings
instead of dictionaries, causing crashes in recent/upcoming games.
* Phase 2: Apply Background Service to Major Sport Managers
✅ Applied background service support to:
- NCAAFB Manager (College Football)
- NBA Manager (Basketball)
- NHL Manager (Hockey)
- MLB Manager (Baseball)
🔧 Key Features Added:
- Background service initialization for each sport
- Configurable workers, timeouts, and retry settings
- Graceful fallback when background service is disabled
- Comprehensive logging for monitoring
⚙️ Configuration Updates:
- Added background_service config section to NBA
- Added background_service config section to NHL
- Added background_service config section to NCAAFB
- Each sport can independently enable/disable background service
📈 Performance Benefits:
- Season data fetching no longer blocks display loops
- Immediate response with cached/partial data
- Background threads handle heavy API calls
- Better responsiveness across all supported sports
Next: Apply to remaining managers (MiLB, Soccer, etc.)
* Fix Python compatibility issue in BackgroundDataService shutdown
🐛 Bug Fix:
- Fixed TypeError in ThreadPoolExecutor.shutdown() for older Python versions
- Added try/catch to handle timeout parameter compatibility
- Fallback gracefully for Python < 3.9 that doesn't support timeout parameter
🔧 Technical Details:
- ThreadPoolExecutor.shutdown(timeout=) was added in Python 3.9
- Older versions only support shutdown(wait=)
- Added compatibility layer with proper error handling
✅ Result:
- No more shutdown exceptions on older Python versions
- Graceful degradation for different Python environments
- Maintains full functionality on newer Python versions
* Phase 2 Complete: Background Service Applied to All Sport Managers
🎉 MAJOR MILESTONE: Complete Background Service Rollout
✅ All Sport Managers Now Support Background Service:
- MiLB Manager (Minor League Baseball)
- Soccer Manager (Multiple leagues: Premier League, La Liga, etc.)
- Leaderboard Manager (Multi-sport standings)
- Odds Ticker Manager (Live betting odds)
🔧 Technical Implementation:
- Background service initialization in all managers
- Configurable workers, timeouts, and retry settings
- Graceful fallback when background service is disabled
- Comprehensive logging for monitoring and debugging
- Thread-safe operations with proper error handling
⚙️ Configuration Support Added:
- MiLB: background_service config section
- Soccer: background_service config section
- Leaderboard: background_service config section
- Odds Ticker: background_service config section
- Each manager can independently enable/disable background service
📈 Performance Benefits Achieved:
- Non-blocking data fetching across ALL sport managers
- Immediate response with cached/partial data
- Background threads handle heavy API calls
- Significantly improved responsiveness
- Better user experience during data loading
🚀 Production Ready:
- All major sport managers now support background threading
- Comprehensive configuration options
- Robust error handling and fallback mechanisms
- Ready for production deployment
Next: Phase 3 - Advanced features (priority queuing, analytics)
* Update wiki submodule with Background Service documentation
📚 Wiki Documentation Added:
- Complete Background Service Guide with architecture diagrams
- Configuration examples and best practices
- Performance benefits and troubleshooting guide
- Migration guide and advanced features
🔧 Navigation Updates:
- Added to sidebar under Technical section
- Updated home page with performance section
- Highlighted as NEW feature with ⚡ icon
The wiki now includes comprehensive documentation for the new
background threading system that improves performance across
all sport managers.
* Fix CacheManager constructor in test script
🐛 Bug Fix:
- Fixed CacheManager initialization in test_background_service.py
- CacheManager no longer takes config_manager parameter
- Updated constructor call to match current implementation
✅ Result:
- Test script now works with current CacheManager API
- Background service testing can proceed without errors
* Move test_background_service.py to test/ directory
📁 Organization Improvement:
- Moved test_background_service.py from root to test/ directory
- Updated import paths to work from new location
- Fixed sys.path to correctly reference src/ directory
- Updated imports to use relative paths
🔧 Technical Changes:
- Changed sys.path from 'src' to '../src' (go up from test/)
- Updated imports to remove 'src.' prefix
- Maintains all functionality while improving project structure
✅ Benefits:
- Better project organization
- Test files properly grouped in test/ directory
- Cleaner root directory structure
- Follows standard Python project layout
* Remove old test_background_service.py from root directory
📁 Cleanup:
- Removed test_background_service.py from root directory
- File has been moved to test/ directory for better organization
- Maintains clean project structure
* Fix NCAA FB team ranking display functionality
- Add missing _fetch_team_rankings() calls to all update methods (live, recent, upcoming)
- Add ranking display logic to live manager scorebug layout
- Remove unused old _fetch_rankings() method and top_25_rankings variable
- Rankings now properly display as #X format when show_ranking is enabled
- Fixes non-functional ranking feature despite existing UI and configuration options
* Fix NCAAFB ranking display issue
- Remove duplicate ranking system that was drawing rankings behind team logos
- Old system (_get_rank) was drawing rankings at top of logos
- New system (_fetch_team_rankings) correctly draws rankings in bottom corners
- Remove old ranking calls from live, recent, and upcoming game drawing functions
- Remove unnecessary _fetch_rankings() calls from update methods
- Rankings now only appear in designated corner positions, not overlapping logos
Fixes issue where team rankings/betting lines were being drawn behind
team logos instead of replacing team records in the corners.
* Add missing show_ranking and show_records options to NCAAFB web UI
- Add show_ranking option to NCAAFB scoreboard config template
- Add show_records and show_ranking toggle switches to NCAAFB web UI
- Update JavaScript form collection to include new fields
- Users can now control whether to show team records or rankings via web interface
This completes the fix for NCAAFB ranking display - users can now enable
show_ranking in the web UI to see AP Top 25 rankings instead of team records.
- Resolved conflicts in src/logo_downloader.py:
- Combined NCAA hockey endpoint with soccer league endpoints
- Updated directory mappings to use ncaa_logos for NCAA sports
- Added support for multiple soccer leagues (Premier League, La Liga, etc.)
- Resolved conflicts in src/ncaa_fb_managers.py:
- Combined immediate fetch approach with background fetch strategy
- Maintained both immediate response and comprehensive data fetching
- Preserved caching functionality for improved performance
- Includes all development branch features:
- Soccer league support with team logos
- Enhanced NCAA football data fetching
- Improved logo downloader with multiple league support
- Updated wiki documentation and configuration
