2 Commits

Author	SHA1	Message	Date
Chuck	2f3433cebc	docs: fix misc remaining docs (architecture, dev quickref, sub-dir READMEs) ... PLUGIN_ARCHITECTURE_SPEC.md - Added a banner at the top noting this is a historical design doc written before the plugin system shipped. The doc is ~1900 lines with 13 stale /api/plugins/* paths (real is /api/v3/plugins/*), references to web_interface_v2.py (current is app.py), and a Migration Strategy / Implementation Roadmap that's now history. Banner points readers at the current docs (PLUGIN_DEVELOPMENT_GUIDE, PLUGIN_API_REFERENCE, REST_API_REFERENCE) without needing to retrofit every section. PLUGIN_CONFIG_ARCHITECTURE.md - 10 occurrences of /api/plugins/* missing /v3 prefix. Bulk fixed. DEVELOPER_QUICK_REFERENCE.md - cache_manager.delete("key") -> cache_manager.clear_cache("key") with comment noting delete() doesn't exist. Same bug already documented in PLUGIN_API_REFERENCE.md. SSH_UNAVAILABLE_AFTER_INSTALL.md - 4 occurrences of port 5001 -> 5000 in AP-mode and Ethernet/WiFi recovery instructions. PLUGIN_CUSTOM_ICONS_FEATURE.md - Port 5001 -> 5000. CONFIG_DEBUGGING.md - Documented /api/v3/config/plugin/<id> and /api/v3/config/validate endpoints don't exist. Replaced with the real endpoints: /api/v3/config/main, /api/v3/plugins/schema?plugin_id=, /api/v3/plugins/config?plugin_id=. Added a note that validation runs server-side automatically on POST. STARLARK_APPS_GUIDE.md - "Plugins -> Starlark Apps" UI navigation path doesn't exist (5 occurrences). Replaced with the real path: Plugin Manager tab, then the per-plugin Starlark Apps tab in the second nav row. - "Navigate to Plugins" install step -> Plugin Manager tab. web_interface/README.md - Documented several endpoints that don't exist in the api_v3 blueprint: - GET /api/v3/plugins (list) -> /api/v3/plugins/installed - GET /api/v3/plugins/<id> -> doesn't exist - POST /api/v3/plugins/<id>/config -> POST /api/v3/plugins/config - GET /api/v3/plugins/<id>/enable + /disable -> POST /api/v3/plugins/toggle - GET /api/v3/store/plugins -> /api/v3/plugins/store/list - POST /api/v3/store/install/<id> -> POST /api/v3/plugins/install - POST /api/v3/store/uninstall/<id> -> POST /api/v3/plugins/uninstall - POST /api/v3/store/update/<id> -> POST /api/v3/plugins/update - POST /api/v3/display/start/stop/restart -> POST /api/v3/system/action - GET /api/v3/display/status -> GET /api/v3/system/status - Also fixed config/secrets.json -> config/config_secrets.json - Replaced the per-section endpoint duplication with a current real endpoint list and a pointer to docs/REST_API_REFERENCE.md. - Documented that SSE stream endpoints are defined directly on the Flask app at app.py:607-615, not in the api_v3 blueprint. scripts/install/README.md - Was missing 3 of the 9 install scripts in the directory: one-shot-install.sh, configure_wifi_permissions.sh, and debug_install.sh. Added them with brief descriptions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-07 09:19:47 -04:00
Chuck	8fb2800495	feat: add error detection, monitoring, and code quality improvements (#223) ... * feat: add error detection, monitoring, and code quality improvements This comprehensive update addresses automatic error detection, code quality, and plugin development experience: ## Error Detection & Monitoring - Add ErrorAggregator service for centralized error tracking - Add pattern detection for recurring errors (5+ in 60 min) - Add error dashboard API endpoints (/api/v3/errors/*) - Integrate error recording into plugin executor ## Code Quality - Remove 10 silent `except: pass` blocks in sports.py and football.py - Remove hardcoded debug log paths - Add pre-commit hooks to prevent future bare except clauses ## Validation & Type Safety - Add warnings when plugins lack config_schema.json - Add config key collision detection for plugins - Improve type coercion logging in BasePlugin ## Testing - Add test_config_validation_edge_cases.py - Add test_plugin_loading_failures.py - Add test_error_aggregator.py ## Documentation - Add PLUGIN_ERROR_HANDLING.md guide - Add CONFIG_DEBUGGING.md guide Note: GitHub Actions CI workflow is available in the plan but requires workflow scope to push. Add .github/workflows/ci.yml manually. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address code review issues - Fix GitHub issues URL in CONFIG_DEBUGGING.md - Use RLock in error_aggregator.py to prevent deadlock in export_to_file - Distinguish missing vs invalid schema files in plugin_manager.py - Add assertions to test_null_value_for_required_field test - Remove unused initial_count variable in test_plugin_load_error_recorded - Add validation for max_age_hours in clear_old_errors API endpoint Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Chuck <chuck@example.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-30 10:05:09 -05:00