CodeRabbit found _QUALITY_CHOICES and _RANKING_COVERAGE_SECONDS read by
_normalise_quality and _check_ranking_coverage but never defined on a mixin.
Confirmed: both are declared by all eight scoreboards, so nothing fails today --
it would only have bitten the ninth plugin to adopt this, at runtime, mid-render.
Both are identical everywhere, so they get defaults here; each plugin's own copy
still shadows them.
Auditing for others showed those two were the only ones, but also that the
host-contract docstring was substantially incomplete: it listed 21 attributes
where the mixins actually read about 40, and omitted five hooks
(_is_favorite_game, _is_game_really_over, _is_ranked_game,
_passes_other_filters, _get_timezone). The section is now derived from that
audit rather than remembered.
test_sports_shared.py covers what is genuinely new, not the moved bodies:
- The contract itself. It parses the module for every ALL-CAPS `self.X` the
mixins read and asserts each is defined, so the next omission fails here
rather than in the field.
- _plugin_dir, the only new logic in the move. Including the case that made it
necessary: SportsCore is an ABC, so a subclass built with type(name, bases,
ns) -- which the plugins' own tests build -- reports __module__ as "abc". The
test asserts that precondition before asserting the walk steps past it.
- The three SportsLive bodies. Hockey and lacrosse disable live mode in their
harness fixtures, so the 176 renders never reach this path; testing the mixin
directly means coverage no longer depends on which plugin happens to have a
unit test.
Two of those tests pin things that would otherwise be silently undone.
SportsRecentSharedMixin does carry an __init__ -- SportsRecent.__init__ was one
of the 48 byte-identical bodies. Its bare super() binds to where it is defined,
now the mixin, so it only reaches the host because the mixin is listed first in
the bases. One test proves the chain runs; the next proves that reversing the
order silently skips the host constructor.
