CodeQL doesn't credit the sanitization inside find_plugin_dir along
this flow; apply its documented barrier (normpath + startswith against
the allowed roots) inline in _parse_render_request, on the exact path
that reaches the render/load sinks.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam
CodeQL doesn't recognize the interprocedural allowlist as a
path-injection barrier; add the canonical one — normalize (without
following symlinks, since dev plugins are commonly symlinked into
plugins/) and require the result to stay inside the search dir.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam
CodeQL (py/path-injection): plugin_id arrives in request input and flows
into filesystem paths via find_plugin_dir. Gate it with the same
^[a-zA-Z0-9_-]{1,64}$ allowlist the web UI's pages_v3 uses, at the
single choke point every route resolves through.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam
- docs: scope the self.layout note to BasePlugin subclasses (others build
a LayoutContext directly) and make explicit that adaptive layout is
opt-in — classic rendering stays unless a plugin adopts the APIs.
- dev_server: broaden the render-request catch (a bad manifest.json now
returns a clean 400 instead of an unhandled 500) and stop echoing raw
exception text in the loader-failure responses — full tracebacks go to
the dev server's console log instead.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam
Quality gates for adaptive layout:
- fill_metrics()/check_scale_up() in the safety harness: overflow catches
content too big for a panel, but nothing caught content that stays tiny
on panels >= 2x the plugin's declared design size. The check measures
lit-content extents and warns (or fails, when a plugin opts into
"fill_check": "strict" in test/harness.json) below 50% coverage on the
doubled axis. Warn-only by default so no existing plugin breaks.
- harness.json "variants": extra runs with config overlays and their own
golden dirs, so an opt-in mode (e.g. layout_mode: adaptive) is golden-
tested beside the classic default. check_plugin.py loops base + variants
and labels variant results mode@name.
- Dev preview server: GET /api/sizes (harness size sample), POST
/api/render-matrix (render at up to 12 sizes in one call), size-preset
dropdown, and an "All Sizes" side-by-side gallery in the preview UI.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(web): wire up "Check & Update All" plugins button
window.updateAllPlugins was never assigned, so the button always showed
"Bulk update handler unavailable." Wire it to PluginInstallManager.updateAll(),
add per-plugin progress feedback in the button text, show a summary
notification on completion, and skip redundant plugin list reloads.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* feat: add dev preview server, CLI render script, and visual test display manager
Adds local development tools for rapid plugin iteration without deploying to RPi:
- VisualTestDisplayManager: renders real pixels via PIL (same fonts/interface as production)
- Dev preview server (Flask): interactive web UI with plugin picker, auto-generated config
forms, zoom/grid controls, and mock data support for API-dependent plugins
- CLI render script: render any plugin to PNG for AI-assisted visual feedback loops
- Updated test runner and conftest to auto-detect plugin-repos/ directory
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* fix(dev-preview): address code review issues
- Use get_logger() from src.logging_config instead of logging.getLogger()
in visual_display_manager.py to match project logging conventions
- Eliminate duplicate public/private weather draw methods — public draw_sun/
draw_cloud/draw_rain/draw_snow now delegate to the private _draw_* variants
so plugins get consistent pixel output in tests vs production
- Default install_deps=False in dev_server.py and render_plugin.py — dev
scripts don't need to run pip install; developers are expected to have
plugin deps installed in their venv already
- Guard plugins_dir fixture against PermissionError during directory iteration
- Fix PluginInstallManager.updateAll() to fall back to window.installedPlugins
when PluginStateManager.installedPlugins is empty (plugins_manager.js
populates window.installedPlugins independently of PluginStateManager)
- Remove 5 debug console.log statements from plugins_manager.js button setup
and initialization code
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(scroll): fix scroll completion to prevent multi-pass wrapping
Change required_total_distance from total_scroll_width + display_width to
total_scroll_width alone. The scrolling image already contains display_width
pixels of blank initial padding, so reaching total_scroll_width means all
content has scrolled off-screen. The extra display_width term was causing
1-2+ unnecessary wrap-arounds, making the same games appear multiple times
and producing a black flicker between passes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix(dev-preview): address PR #264 code review findings
- docs/DEV_PREVIEW.md: add bash language tag to fenced code block
- scripts/dev_server.py: add MAX/MIN_WIDTH/HEIGHT constants and validate
width/height in render endpoint; add structured logger calls to
discover_plugins (missing dirs, hidden entries, missing manifest,
JSON/OS errors, duplicate ids); add type annotations to all helpers
- scripts/render_plugin.py: add MIN/MAX_DIMENSION validation after
parse_args; replace prints with get_logger() calls; narrow broad
Exception catches to ImportError/OSError/ValueError in plugin load
block; add type annotations to all helpers and main(); rename unused
module binding to _module
- scripts/run_plugin_tests.py: wrap plugins_path.iterdir() in
try/except PermissionError with fallback to plugin-repos/
- scripts/templates/dev_preview.html: replace non-focusable div toggles
with button role="switch" + aria-checked; add keyboard handlers
(Enter/Space); sync aria-checked in toggleGrid/toggleAutoRefresh
- src/common/scroll_helper.py: early-guard zero total_scroll_width to
keep scroll_position at 0 and skip completion/wrap logic
- src/plugin_system/testing/visual_display_manager.py: forward color
arg in draw_cloud -> _draw_cloud; add color param to _draw_cloud;
restore _scrolling_state in reset(); narrow broad Exception catches in
_load_fonts to FileNotFoundError/OSError/ImportError; add explicit
type annotations to draw_text
- test/plugins/test_visual_rendering.py: use context manager for
Image.open in test_save_snapshot
- test/plugins/conftest.py: add return type hints to all fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* chore: add bandit and gitleaks pre-commit hooks
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Chuck <chuck@example.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
