fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes (#654)

* fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes

- font_manager: a .zip font URL is served as its extracted font after a
  restart (the cached-file check returned the archive first); downloads
  use requests with a 30s timeout into a temp file + os.replace.
- api_helper / sync_manager: rate-limit and heartbeat/leader timeouts use
  time.monotonic(); last_request_time and the status file's ts stay
  wall-clock. set_on_new_cycle docstring no longer claims core uses it.
- logo_helper: the placeholder uses the same scaled box as a real logo.
- permission_utils: one _sudo_bash_candidates() helper (with the sudoers
  exact-argv rationale) shared by sudo_remove_directory, which now retries
  the next bash path on a sudo refusal, and install_requirements_file.
- dynamic_team_resolver: failed/empty fetch backs off 5 min; duplicate
  INFO log and contradictory docstring example fixed.
- element_style: scale default looked up through element aliases.
- background_data_service: cache-hit callback runs outside the lock.
- config_arrays: union-aware type check (["array","null"]); stale
  dotToNested() reference removed.
- auto_update_setup: non-dict auto_update reads as off; temp result file
  unlinked when the write fails.
- exceptions: constructors copy the caller's context dict.
- logging_config: StructuredFormatter json.dumps(default=str).
- error_aggregator: removed unused export_path/export_to_file/_auto_export.
- Docstrings: validate_file_upload max_size_mb, raise_on_errors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(sync): retry the status-file rename like the other atomic writers

On Windows os.replace can fail with "Access is denied" while a scanner
briefly holds the target open; config_manager_atomic._replace already
retries that (and re-raises at once on other platforms). The sync status
writer called os.replace directly, which made
test_concurrent_writers_each_use_their_own_temp_file flaky on Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-09-28 10:40:16 -04:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 6f45ff5e63
commit f6c0fe55d9
28 changed files with 596 additions and 171 deletions
+65
View File
@@ -8,13 +8,18 @@ test here asserts observable behavior: returned font types, cache identity,
fallback selection, and BDF native-size reading.
"""
import hashlib
import io
import json
import shutil
import zipfile
from unittest.mock import MagicMock
import freetype
import pytest
from PIL import ImageFont
import src.font_manager as fm_module
from src.common.font_layout import resolve_asset_path
from src.font_manager import FontManager
@@ -188,3 +193,63 @@ class TestPluginFonts:
assert fm.register_plugin_fonts("my-plugin", self.MANIFEST)
assert fm.font_catalog["my-plugin::bundled"] == str(plugin_dir / "fonts" / "Bundled.ttf")
class TestDownloadFont:
"""_download_font: plugin fonts declared by URL, cached in temp_font_dir."""
URL = "https://fonts.example/pack.zip"
@staticmethod
def _zip_bytes():
buf = io.BytesIO()
with zipfile.ZipFile(buf, "w") as zf:
zf.writestr("MyFont.ttf", b"not really a font")
return buf.getvalue()
@staticmethod
def _response(chunks):
response = MagicMock()
response.raise_for_status.return_value = None
response.iter_content.side_effect = lambda chunk_size: iter(chunks)
return response
def test_a_zip_is_served_as_its_extracted_font_after_a_restart(self, fm, tmp_path):
# The state a previous run leaves: the .zip and its extracted font.
# The cache check used to find the .zip first and register the
# archive itself as the font.
fm.temp_font_dir = tmp_path
url_hash = hashlib.sha256(self.URL.encode()).hexdigest()[:16]
zip_path = tmp_path / f"pack_{url_hash}.zip"
zip_path.write_bytes(self._zip_bytes())
extract_dir = tmp_path / f"pack_{url_hash}"
with zipfile.ZipFile(zip_path) as zf:
zf.extractall(extract_dir)
path = fm._download_font(self.URL, {"family": "pack"})
assert path == str(extract_dir / "MyFont.ttf")
def test_download_has_a_timeout_and_lands_atomically(self, fm, tmp_path, monkeypatch):
fm.temp_font_dir = tmp_path
get = MagicMock(return_value=self._response([self._zip_bytes()]))
monkeypatch.setattr(fm_module.requests, "get", get)
path = fm._download_font(self.URL, {"family": "pack"})
assert path is not None and path.endswith("MyFont.ttf")
assert get.call_args.kwargs.get("timeout")
assert not list(tmp_path.glob("*.part"))
def test_an_interrupted_download_leaves_nothing_to_be_served(self, fm, tmp_path, monkeypatch):
fm.temp_font_dir = tmp_path
def chunks():
yield b"partial"
raise OSError("connection reset")
response = self._response([])
response.iter_content.side_effect = lambda chunk_size: chunks()
monkeypatch.setattr(fm_module.requests, "get", MagicMock(return_value=response))
assert fm._download_font("https://fonts.example/Font.ttf", {"family": "f"}) is None
assert list(tmp_path.iterdir()) == []