mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 06:15:09 +00:00
fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes (#654)
* fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes - font_manager: a .zip font URL is served as its extracted font after a restart (the cached-file check returned the archive first); downloads use requests with a 30s timeout into a temp file + os.replace. - api_helper / sync_manager: rate-limit and heartbeat/leader timeouts use time.monotonic(); last_request_time and the status file's ts stay wall-clock. set_on_new_cycle docstring no longer claims core uses it. - logo_helper: the placeholder uses the same scaled box as a real logo. - permission_utils: one _sudo_bash_candidates() helper (with the sudoers exact-argv rationale) shared by sudo_remove_directory, which now retries the next bash path on a sudo refusal, and install_requirements_file. - dynamic_team_resolver: failed/empty fetch backs off 5 min; duplicate INFO log and contradictory docstring example fixed. - element_style: scale default looked up through element aliases. - background_data_service: cache-hit callback runs outside the lock. - config_arrays: union-aware type check (["array","null"]); stale dotToNested() reference removed. - auto_update_setup: non-dict auto_update reads as off; temp result file unlinked when the write fails. - exceptions: constructors copy the caller's context dict. - logging_config: StructuredFormatter json.dumps(default=str). - error_aggregator: removed unused export_path/export_to_file/_auto_export. - Docstrings: validate_file_upload max_size_mb, raise_on_errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sync): retry the status-file rename like the other atomic writers On Windows os.replace can fail with "Access is denied" while a scanner briefly holds the target open; config_manager_atomic._replace already retries that (and re-raises at once on other platforms). The sync status writer called os.replace directly, which made test_concurrent_writers_each_use_their_own_temp_file flaky on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -48,9 +48,11 @@ def reset_class_cache():
|
||||
"""Reset the CLASS-level shared cache between tests."""
|
||||
DynamicTeamResolver._rankings_cache = {}
|
||||
DynamicTeamResolver._cache_timestamp = 0
|
||||
DynamicTeamResolver._failure_timestamp = 0
|
||||
yield
|
||||
DynamicTeamResolver._rankings_cache = {}
|
||||
DynamicTeamResolver._cache_timestamp = 0
|
||||
DynamicTeamResolver._failure_timestamp = 0
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
@@ -158,12 +160,20 @@ class TestRankingsParsing:
|
||||
assert list(rankings.keys()) == ['A1', 'B2', 'C3']
|
||||
assert list(rankings.values()) == [1, 2, 3]
|
||||
|
||||
def test_empty_rankings_returns_empty_and_caches_nothing(
|
||||
self, resolver, mock_get):
|
||||
def test_empty_rankings_returns_empty_and_backs_off(
|
||||
self, resolver, mock_get, monkeypatch):
|
||||
mock_get.return_value = _make_response({'rankings': []})
|
||||
|
||||
assert resolver._fetch_ncaa_fb_rankings() == {}
|
||||
# Nothing was cached, so the next call hits HTTP again.
|
||||
# No rankings were cached, but the failure is: the next call inside
|
||||
# the back-off window doesn't hit HTTP again.
|
||||
assert resolver._fetch_ncaa_fb_rankings() == {}
|
||||
assert mock_get.call_count == 1
|
||||
assert DynamicTeamResolver._rankings_cache == {}
|
||||
|
||||
stamp = DynamicTeamResolver._failure_timestamp
|
||||
monkeypatch.setattr(
|
||||
dtr_module, 'time', types.SimpleNamespace(time=lambda: stamp + 301))
|
||||
assert resolver._fetch_ncaa_fb_rankings() == {}
|
||||
assert mock_get.call_count == 2
|
||||
|
||||
@@ -226,7 +236,7 @@ class TestSharedCache:
|
||||
|
||||
class TestFailureHandling:
|
||||
def test_network_failure_drops_dynamic_keeps_static_caches_nothing(
|
||||
self, resolver, mock_get):
|
||||
self, resolver, mock_get, monkeypatch):
|
||||
mock_get.side_effect = [
|
||||
requests.exceptions.RequestException('boom'),
|
||||
_make_response(_rankings_payload()),
|
||||
@@ -237,12 +247,29 @@ class TestFailureHandling:
|
||||
# Dynamic name silently dropped, static name kept, nothing raises.
|
||||
assert result == ['UGA']
|
||||
|
||||
# Nothing was cached on failure: a subsequent call refetches and
|
||||
# succeeds.
|
||||
# Inside the back-off window the outage isn't retried: each resolve
|
||||
# would otherwise wait out the full request timeout again.
|
||||
assert resolver.resolve_teams(['UGA', 'AP_TOP_5']) == ['UGA']
|
||||
assert mock_get.call_count == 1
|
||||
|
||||
# No rankings were cached on failure: once the window passes, the
|
||||
# next call refetches and succeeds.
|
||||
stamp = DynamicTeamResolver._failure_timestamp
|
||||
monkeypatch.setattr(
|
||||
dtr_module, 'time', types.SimpleNamespace(time=lambda: stamp + 301))
|
||||
result = resolver.resolve_teams(['UGA', 'AP_TOP_5'])
|
||||
assert result == ['UGA', 'MICH', 'OSU', 'TEX', 'ALA']
|
||||
assert mock_get.call_count == 2
|
||||
|
||||
def test_clear_cache_forgets_a_failure(self, resolver, mock_get):
|
||||
mock_get.side_effect = [
|
||||
requests.exceptions.RequestException('boom'),
|
||||
_make_response(_rankings_payload()),
|
||||
]
|
||||
assert resolver.resolve_teams(['AP_TOP_5']) == []
|
||||
resolver.clear_cache()
|
||||
assert resolver.resolve_teams(['AP_TOP_5']) == TOP_TEAMS[:5]
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# sport argument
|
||||
|
||||
Reference in New Issue
Block a user