fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes (#654)

* fix(core): font zip cache, monotonic timers, resolver back-off, and other core/common fixes

- font_manager: a .zip font URL is served as its extracted font after a
  restart (the cached-file check returned the archive first); downloads
  use requests with a 30s timeout into a temp file + os.replace.
- api_helper / sync_manager: rate-limit and heartbeat/leader timeouts use
  time.monotonic(); last_request_time and the status file's ts stay
  wall-clock. set_on_new_cycle docstring no longer claims core uses it.
- logo_helper: the placeholder uses the same scaled box as a real logo.
- permission_utils: one _sudo_bash_candidates() helper (with the sudoers
  exact-argv rationale) shared by sudo_remove_directory, which now retries
  the next bash path on a sudo refusal, and install_requirements_file.
- dynamic_team_resolver: failed/empty fetch backs off 5 min; duplicate
  INFO log and contradictory docstring example fixed.
- element_style: scale default looked up through element aliases.
- background_data_service: cache-hit callback runs outside the lock.
- config_arrays: union-aware type check (["array","null"]); stale
  dotToNested() reference removed.
- auto_update_setup: non-dict auto_update reads as off; temp result file
  unlinked when the write fails.
- exceptions: constructors copy the caller's context dict.
- logging_config: StructuredFormatter json.dumps(default=str).
- error_aggregator: removed unused export_path/export_to_file/_auto_export.
- Docstrings: validate_file_upload max_size_mb, raise_on_errors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(sync): retry the status-file rename like the other atomic writers

On Windows os.replace can fail with "Access is denied" while a scanner
briefly holds the target open; config_manager_atomic._replace already
retries that (and re-raises at once on other platforms). The sync status
writer called os.replace directly, which made
test_concurrent_writers_each_use_their_own_temp_file flaky on Windows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-09-28 10:40:16 -04:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 6f45ff5e63
commit f6c0fe55d9
28 changed files with 596 additions and 171 deletions
+27
View File
@@ -93,6 +93,33 @@ class TestCacheHit:
stats = service.get_statistics()
assert stats["cached_hits"] == 1
def test_cache_hit_callback_runs_outside_the_service_lock(
self, service, mock_cache_manager):
"""The worker path calls plugin callbacks after releasing the lock;
the cache-hit path held it, so a slow callback stalled every other
thread's submit and result bookkeeping."""
import threading
mock_cache_manager.get.return_value = {"events": []}
seen = {}
def callback(result):
# The result is already filed, as before.
seen["filed"] = service.get_result(result.request_id) is result
other = {}
def try_lock():
other["got"] = service._lock.acquire(timeout=1)
if other["got"]:
service._lock.release()
t = threading.Thread(target=try_lock)
t.start()
t.join()
seen["lock_free"] = other["got"]
service.submit_fetch_request(sport="nba", year=2024, url="https://x.com",
cache_key="k", callback=callback)
assert seen == {"filed": True, "lock_free": True}
# ---------------------------------------------------------------------------
# Actual fetch path (mocked HTTP)