rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-08-20 18:09:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): stop dumping the config and request headers to the journal

Browse Source 
save_main_config logged its entire POST body and the full request headers at
ERROR on every save. The body is the configuration itself, and the headers
carry the session cookie, so a routine settings change wrote both to the
journal -- at a level that guarantees they survive any sane log filter.

The lines are leftover debug output: they say "DEBUG:" in the message while
calling logging.error, and they went through the root logger rather than the
module logger, bypassing the level configured for this blueprint.

Replaced with a debug-level line recording the shape of the request, which is
the part with diagnostic value. The local `import logging` went with them; it
shadowed a module-level import that was already there.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01STMbQE4YctTacQXfbYqKuW
This commit is contained in:
ChuckBuilds
2026-08-20 05:55:45 -04:00
co-authored by Claude Opus 5
parent cf0a551f7b
commit f0efdafbdb
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web_interface/blueprints/api_v3.py
+6 -4
View File
@@ -715,10 +715,12 @@ def save_main_config():
if not data: if not data:
return jsonify({'status': 'error', 'message': 'No data provided'}), 400 return jsonify({'status': 'error', 'message': 'No data provided'}), 400
import logging # What arrives here is the config itself, and the headers carry the
logging.error(f"DEBUG: save_main_config received data: {data}") # session cookie -- neither belongs in the journal, least of all at
logging.error(f"DEBUG: Content-Type header: {request.content_type}") # ERROR on every save. The shape of the request is the part with
logging.error(f"DEBUG: Headers: {dict(request.headers)}") # diagnostic value, so log that, at the level it deserves.
logger.debug("save_main_config: %s, %d top-level key(s)",
request.content_type or 'no content-type', len(data))
# Merge with existing config (similar to original implementation) # Merge with existing config (similar to original implementation)
current_config = api_v3.config_manager.load_config() current_config = api_v3.config_manager.load_config()