mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-11 01:26:37 +00:00
docs(dev): correct the test-running and rgbmatrix build instructions
- HOW_TO_RUN_TESTS: coverage is not collected by a plain pytest run and pytest.ini has no threshold; the only one is --cov-fail-under=52 in the core unit-test job of .github/workflows/test.yml, which runs the whole test/ tree (not an allowlist). Almost no tests carry markers, so -m integration / -m slow select nothing; drop them and -m unit as the quick check. Replace the hardcoded /home/chuck path. - DEVELOPMENT: the rgbmatrix package is built with pip install . from the submodule root (scikit-build-core + CMake + Ninja), as first_time_install.sh does; there is no make build-python / bindings/python step, and the build deps are python-dev-is-python3, cmake and ninja-build, not cython3/scons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
+10
-9
@@ -43,16 +43,21 @@ git submodule update --init --recursive rpi-rgb-led-matrix-master
|
||||
|
||||
#### Building the Submodule
|
||||
|
||||
After initializing the submodule, you need to build the Python bindings:
|
||||
After initializing the submodule, build and install the `rgbmatrix` Python
|
||||
package from the submodule root. Upstream's `pyproject.toml` builds it with
|
||||
scikit-build-core, CMake and Ninja; there is no separate `make` step:
|
||||
|
||||
```bash
|
||||
cd rpi-rgb-led-matrix-master
|
||||
make build-python
|
||||
cd bindings/python
|
||||
python3 -m pip install --break-system-packages .
|
||||
```
|
||||
|
||||
**Note:** The `first_time_install.sh` script automates this process during installation.
|
||||
On a board with 1 GB of RAM or less, cap the compile so it doesn't run out of
|
||||
memory: `CMAKE_BUILD_PARALLEL_LEVEL=1 python3 -m pip install --break-system-packages .`
|
||||
|
||||
**Note:** The `first_time_install.sh` script automates this process during
|
||||
installation, including the parallelism cap and a temporary swapfile on
|
||||
low-memory boards.
|
||||
|
||||
#### Troubleshooting
|
||||
|
||||
@@ -69,7 +74,7 @@ git submodule update --init --recursive rpi-rgb-led-matrix-master
|
||||
**Build fails:**
|
||||
Ensure you have the required build dependencies installed:
|
||||
```bash
|
||||
sudo apt install -y build-essential python3-dev cython3 scons
|
||||
sudo apt install -y build-essential python-dev-is-python3 cmake ninja-build
|
||||
```
|
||||
|
||||
**Import error for `rgbmatrix` module:**
|
||||
@@ -97,8 +102,6 @@ When setting up CI/CD pipelines, ensure submodules are initialized before buildi
|
||||
- name: Build rpi-rgb-led-matrix
|
||||
run: |
|
||||
cd rpi-rgb-led-matrix-master
|
||||
make build-python
|
||||
cd bindings/python
|
||||
pip install .
|
||||
```
|
||||
|
||||
@@ -110,8 +113,6 @@ variables:
|
||||
build:
|
||||
script:
|
||||
- cd rpi-rgb-led-matrix-master
|
||||
- make build-python
|
||||
- cd bindings/python
|
||||
- pip install .
|
||||
```
|
||||
|
||||
|
||||
Reference in New Issue
Block a user