rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-08-07 11:48:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: address review feedback — fixture lifecycle, test names, ClassVar

Browse Source 
- ci-fixture-plugin: call display_manager.clear() before rendering (per
  plugin guidelines — the fixture should model a well-behaved plugin),
  add a class docstring, and document why Pillow is deliberately not
  pinned in its requirements.txt (core dependency; harness installs
  nothing).
- Rename two tests whose names contradicted their assertions:
  test_unparseable_core_version_is_compatible ->
  test_unparseable_core_with_high_floor_is_blocked, and
  test_unreadable_secrets_file... -> test_corrupt_secrets_file...
- Annotate TestGetSchemaProperty.SCHEMA as ClassVar (RUF012).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NohXi78cwsAKtN1sCfxjUh
This commit is contained in:
Claude
2026-08-06 22:38:48 +00:00
parent b8b0c8e2e2
commit d159f2866d
5 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/test_compatibility.py
+1 -1
View File
@@ -216,7 +216,7 @@ class TestCheck:
assert ok is False
assert "2.0.0 - 2.9.9" in reason
def test_unparseable_core_version_is_compatible(self):
def test_unparseable_core_with_high_floor_is_blocked(self):
manifest = {"min_ledmatrix_version": "3.2.0",
"compatible_versions": [">=3.2.0"]}
# An unparseable core version is "unknown", not "old"... but note