fix(assets): drop case-colliding duplicate league logos (#506)

Browse Source

Four league fallback logos were each tracked at two paths differing
only in case:

  assets/sports/mlb_logos/MLB.png  +  mlb.png
  assets/sports/nba_logos/NBA.png  +  nba.png
  assets/sports/nfl_logos/NFL.png  +  nfl.png
  assets/sports/nhl_logos/NHL.png  +  nhl.png

On Windows and default macOS the filesystem is case-insensitive, so
both index entries map to one physical file. Whichever git writes last
wins and the other entry reports as permanently modified, so `git
status` can never be clean and any `git pull` flips which one is dirty.

For MLB/NBA/NFL the two entries pointed at the same blob, so the
collision was only cosmetic. NHL was not: NHL.png is 1439x1621
(672455 B) and nhl.png is 768x768 (107184 B), so which resolution the
league fallback logo loaded depended on checkout order rather than on
the code.

Keep the uppercase path in each pair. Every logo lookup uppercases the
abbreviation before building a filename -- LogoDownloader
.normalize_abbreviation and .get_logo_filename_variations
(src/logo_downloader.py) and LogoHelper.normalize_abbreviation
(src/common/logo_helper.py) all do -- and nothing in the tree requests
a lowercase league logo, so the uppercase name is what the code
actually asks for. For NHL that is also the higher-resolution asset.

Removed with `git update-index --force-remove` so the literal index
entry is dropped without the case-insensitive working tree deleting the
survivor.

...

This commit is contained in:

Chuck

2026-08-30 09:08:42 -04:00

committed by GitHub

parent 4aeb0033e0

commit cbc540a679

4 changed files with 0 additions and 0 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

assets/sports/mlb_logos/mlb.png

BIN

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 16 KiB

assets/sports/nba_logos/nba.png

BIN

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 23 KiB

assets/sports/nfl_logos/nfl.png

BIN

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 39 KiB

assets/sports/nhl_logos/nhl.png

BIN

Binary file not shown.

Side by Side Before Width:  |  Height:  |  Size: 105 KiB