rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-04-10 13:02:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): use sys.executable for plugin action subprocess calls (#277)

Browse Source 
* fix(api): use sys.executable for plugin action subprocess calls

The execute_plugin_action endpoint hardcoded 'python3' when spawning
plugin scripts via subprocess. This can fail if the system Python is
named differently or if a virtualenv is active, since 'python3' may
not point to the correct interpreter.

Changes:
- Replace 'python3' with sys.executable in the non-OAuth script
  execution branch (uses the same interpreter running the web service)
- Remove redundant 'import sys' inside the oauth_flow conditional
  block (sys is already imported at module level; the local import
  shadows the top-level binding for the entire function scope, which
  would cause UnboundLocalError if sys were referenced in the else
  branch on Python 3.12+)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(api): replace all remaining hardcoded python3 with sys.executable

Fix 4 additional subprocess calls that still used 'python3' instead of
sys.executable: parameterized action wrapper (line 5150), stdin-param
wrapper (line 5211), no-param wrapper (line 5417), and OAuth auth
script (line 5524). Ensures plugin actions work in virtualenvs and
non-standard Python installations.

Addresses CodeRabbit findings on PR #277.

Co-Authored-By: 5ymb01 <5ymb01@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: 5ymb01 <5ymb01@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
5ymb01
2026-03-21 12:21:18 -04:00
committed by GitHub
parent 28a374485f
commit c8737d1a6c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web_interface/blueprints/api_v3.py
View File

@@ -5053,7 +5053,7 @@ sys.exit(proc.returncode)
try:
result = subprocess.run(
['python3', wrapper_path],
[sys.executable, wrapper_path],
capture_output=True,
text=True,
timeout=120,
@@ -5114,7 +5114,7 @@ sys.exit(proc.returncode)
try:
result = subprocess.run(
['python3', wrapper_path],
[sys.executable, wrapper_path],
capture_output=True,
text=True,
timeout=120,
@@ -5209,7 +5209,7 @@ sys.exit(proc.returncode)
else:
# Simple script execution
result = subprocess.run(
['python3', str(script_file)],
[sys.executable, str(script_file)],
capture_output=True,
text=True,
timeout=60,
@@ -5320,7 +5320,7 @@ sys.exit(proc.returncode)
try:
result = subprocess.run(
['python3', wrapper_path],
[sys.executable, wrapper_path],
capture_output=True,
text=True,
timeout=120,
@@ -5426,7 +5426,7 @@ def authenticate_ytm():
# Run the authentication script
result = subprocess.run(
['python3', str(auth_script)],
[sys.executable, str(auth_script)],
capture_output=True,
text=True,
timeout=60,