rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-04-13 22:13:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce NHL warning spam with improved logging - Add class-level warning tracking variables - Implement warning cooldown to limit frequency - Share warning state across all NHL manager instances

Browse Source
This commit is contained in:
ChuckBuilds
2025-04-18 11:19:01 -05:00
parent 8557e9acb6
commit a14f5277b8
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/nhl_managers.py
View File

@@ -14,6 +14,11 @@ ESPN_NHL_SCOREBOARD_URL = "https://site.api.espn.com/apis/site/v2/sports/hockey/
class BaseNHLManager: class BaseNHLManager:
"""Base class for NHL managers with common functionality.""" """Base class for NHL managers with common functionality."""
# Class variables for warning tracking
_no_data_warning_logged = False
_last_warning_time = 0
_warning_cooldown = 60 # Only log warnings once per minute
def __init__(self, config: Dict[str, Any], display_manager: DisplayManager): def __init__(self, config: Dict[str, Any], display_manager: DisplayManager):
self.display_manager = display_manager self.display_manager = display_manager
self.config = config self.config = config
@@ -27,7 +32,6 @@ class BaseNHLManager:
self.fonts = self._load_fonts() self.fonts = self._load_fonts()
self.favorite_teams = self.nhl_config.get("favorite_teams", []) self.favorite_teams = self.nhl_config.get("favorite_teams", [])
self.logger = logging.getLogger('NHL') self.logger = logging.getLogger('NHL')
self.no_data_warning_logged = False # Flag to track if we've already logged a warning
# Get display dimensions from config # Get display dimensions from config
display_config = config.get("display", {}) display_config = config.get("display", {})
@@ -192,13 +196,16 @@ class BaseNHLManager:
def display(self, force_clear: bool = False): def display(self, force_clear: bool = False):
"""Display game information.""" """Display game information."""
if not self.current_game: if not self.current_game:
if not self.no_data_warning_logged: current_time = time.time()
# Only log a warning if we haven't logged one recently
if not BaseNHLManager._no_data_warning_logged and (current_time - BaseNHLManager._last_warning_time) > BaseNHLManager._warning_cooldown:
logging.warning("[NHL] No game data available to display") logging.warning("[NHL] No game data available to display")
self.no_data_warning_logged = True BaseNHLManager._no_data_warning_logged = True
BaseNHLManager._last_warning_time = current_time
return return
# Reset the warning flag when we have data # Reset the warning flag when we have data
self.no_data_warning_logged = False BaseNHLManager._no_data_warning_logged = False
try: try:
# Create a new black image # Create a new black image