rick/LEDMatrix
1
0
Fork 0
mirror of https://github.com/ChuckBuilds/LEDMatrix.git synced 2026-05-01 13:03:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): reset pluginsInitialized on HTMX re-swap; use refreshInstalledPlugins in refreshPlugins

Browse Source 
HTMX's `revealed` trigger fires each time the plugins tab becomes
visible (Alpine's x-show toggles display:none which re-triggers the
IntersectionObserver). Each re-reveal fetches a fresh empty HTML
skeleton via hx-swap="innerHTML". The htmx:afterSwap handler reset
window.pluginManager.initialized/initializing but not pluginsInitialized,
so initializePlugins() hit its guard and skipped loadInstalledPlugins()
and searchPluginStore() — leaving the fresh empty DOM unpopulated.

Fix: also reset pluginsInitialized = false in the afterSwap handler.
Existing caches (3s for installed plugins, 5min for store) mean tab
revisits within the TTL render from cache instantly with no extra
API traffic.

Also change refreshPlugins() to call refreshInstalledPlugins() (which
already exists and explicitly invalidates the cache) instead of the
bare loadInstalledPlugins() call that could silently skip the fetch
if the 3-second cache happened to still be valid.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Chuck
2026-04-30 10:34:18 -04:00
parent d6bd1ee215
commit 9a7c008b90
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web_interface/static/v3/plugins_manager.js
View File

@@ -1165,9 +1165,10 @@ function initializePluginPageWhenReady() {
if (target.id === 'plugins-content' || if (target.id === 'plugins-content' ||
target.querySelector('#installed-plugins-grid')) { target.querySelector('#installed-plugins-grid')) {
console.log('HTMX swap detected for plugins, initializing...'); console.log('HTMX swap detected for plugins, initializing...');
// Reset initialization flag to allow re-initialization after HTMX swap // Reset all initialization flags so the fresh empty DOM gets populated
window.pluginManager.initialized = false; window.pluginManager.initialized = false;
window.pluginManager.initializing = false; window.pluginManager.initializing = false;
pluginsInitialized = false;
initTimer = setTimeout(attemptInit, 100); initTimer = setTimeout(attemptInit, 100);
} }
}, { once: false }); // Allow multiple swaps }, { once: false }); // Allow multiple swaps
@@ -5127,7 +5128,7 @@ function refreshPlugins() {
pluginStoreCache = null; pluginStoreCache = null;
cacheTimestamp = null; cacheTimestamp = null;
loadInstalledPlugins(); refreshInstalledPlugins(); // invalidates cache before fetching
// Fetch latest metadata from GitHub when refreshing // Fetch latest metadata from GitHub when refreshing
searchPluginStore(true); searchPluginStore(true);
showNotification('Plugins refreshed with latest metadata from GitHub', 'success'); showNotification('Plugins refreshed with latest metadata from GitHub', 'success');