mirror of
https://github.com/ChuckBuilds/LEDMatrix.git
synced 2026-10-04 14:25:08 +00:00
refactor(web): read plugins through a PluginCatalog; only the display runs them (#688)
The web process built its own PluginManager and loaded plugins into itself: store installs and updates loaded or reloaded a web-side copy, and config saves and enable/disable called on_config_change, on_enable and on_disable on it. None of that reached the panel, and /plugins/installed reported runtime state from those copies. - Add PluginCatalog (src/plugin_system/plugin_catalog.py): manifests, directories, display modes, installed version, schema and config reads, with no way to run a plugin. app.py and both blueprints use it; the plugin_manager blueprint attribute is gone. - Remove every lifecycle call from the web routes. Config changes already reach the display through ConfigService (on_config_change) and the enabled-set reconcile. - Health and metrics readers move to api_v3.health_tracker / resource_monitor. /plugins/installed reports loaded/state/error_info as null (the display does not publish them) and enabled by the display's rule. - Store install, update and uninstall answer restart_required when the running display will not pick the change up by itself (display_restart_required). The restart banner follows the flag via window.noteRestartRequired instead of the /config/main URL heuristic; /config/main now sends restart_required: true. - The one remaining in-process import of plugin code (Starlark helper modules, oauth_flow action scripts) goes through _import_plugin_code_in_web_process() until a web-entry contract. - /plugins/installed reports vegas_participation (from #682) from the user's setting or the manifest, with vegas_participation_source; when only the plugin's code decides it, null with source 'runtime', since the web process no longer has plugin instances to ask. - Check & Update All keeps its restart flags when the final list refresh fails, and asks for a restart when an enabled plugin's first request got no answer and the re-sent one found it up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -115,19 +115,17 @@ def app_client(tmp_path):
|
||||
cm.save_config_atomic.side_effect = _save
|
||||
|
||||
pm = MagicMock()
|
||||
pm.plugins = {}
|
||||
pm.plugins_dir = plugins_dir
|
||||
pm.get_plugin.return_value = None
|
||||
pm.get_plugin_info.return_value = {"name": "Demo", "version": "1.0.0"}
|
||||
sm = SchemaManager(plugins_dir=plugins_dir, project_root=tmp_path)
|
||||
|
||||
names = ("config_manager", "schema_manager", "plugin_manager")
|
||||
names = ("config_manager", "schema_manager", "plugin_catalog")
|
||||
originals = {(bp, k): getattr(bp, k, None)
|
||||
for bp in (api.api_v3, pages.pages_v3) for k in names}
|
||||
for bp in (api.api_v3, pages.pages_v3):
|
||||
bp.config_manager = cm
|
||||
bp.schema_manager = sm
|
||||
bp.plugin_manager = pm
|
||||
bp.plugin_catalog = pm
|
||||
|
||||
base = Path(pages.__file__).resolve().parent.parent
|
||||
app = Flask(__name__, template_folder=str(base / "templates"),
|
||||
|
||||
Reference in New Issue
Block a user